Commit Graph

43442 Commits

Author SHA1 Message Date
Peter Wilson
1d0be627a9 Site Health: Reduce false reports of HTTPS failures.
Reduce severity of failing HTTPS tests from critical to warning. Stop reporting failures if the site is being accessed over HTTPS but `wp_is_https_supported()` indicates a lack of support.

Props annalamprou, AnotherDave, ayeshrajans, bobbingwide, Clorith, dragongate, eatsleepcode, gab81, geoffrey1963, Ipstenu, k3nsai, mmuyskens, nicegamer7, peterwilsoncc, pwallner, SergeyBiryukov, TimothyBlynJacobs, Toru.
Merges [50659] to the 5.7 branch.
Fixes #52783.

Built from https://develop.svn.wordpress.org/branches/5.7@50660


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-06 03:40:06 +00:00
Sergey Biryukov
551b6260da REST API: Correct enum validation for numeric values.
When validating `enum` values as `integer` or `number`, consider a number with a zero fractional part to be equivalent to an integer of the same value.

In `rest_are_values_equal()`, when comparing two values of type `int` or `float` (in any combination), first cast both of them to `float` and then compare.

This matches some test cases from the official JSON Schema test suite.

Follow-up to [50010].

Props yakimun, stefanjoebstl, TimothyBlynJacobs, rachelbaker.
Merges [50653] to the 5.7 branch.
Fixes #52932.
Built from https://develop.svn.wordpress.org/branches/5.7@50656


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-04 19:13:03 +00:00
Sergey Biryukov
69bfd1ff63 Coding Standards: Move some translator comments to the correct place.
Follow-up to [46273], [50060], [50117].

Merges [50654] to the 5.7 branch.
See #52627.
Built from https://develop.svn.wordpress.org/branches/5.7@50655


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-04 18:34:04 +00:00
Sergey Biryukov
8bda8b2847 KSES: Add object-position to the list of safe CSS properties.
This resolves an issue with the Cover block, where the `object-position` property is removed from the content when a non-admin user saves the post, leading to block recovery loop.

Props Mamaduka, aristath.
Merges [50634] to the 5.7 branch.
Fixes #52961.
Built from https://develop.svn.wordpress.org/branches/5.7@50649


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-02 19:31:06 +00:00
Sergey Biryukov
4fa46b8d14 External Libraries: Upgrade PHPMailer from 6.3.0 to 6.4.0.
6.4.0 reverts a change that made the `mail()` and sendmail transports set the envelope sender if one isn't explicitly provided, as it was causing problems in specific PHP/server configurations.

Release post: https://github.com/PHPMailer/PHPMailer/releases/tag/v6.4.0
Changelog: https://github.com/PHPMailer/PHPMailer/compare/v6.3.0...v6.4.0

Props Synchro, tigertech, ayeshrajans, galbaras, audrasjb, SergeyBiryukov, desrosj, ocean90.
Merges [50628] to the 5.7 branch.
Fixes #52822.
Built from https://develop.svn.wordpress.org/branches/5.7@50630


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-01 13:01:06 +00:00
davidbaumwald
35592e1ffa Privacy: Print screen reader text for the "Copy suggested policy text..." action button.
This change switches out sprintf for printf on the "Copy suggested policy text from..." button screen reader text. Also, wrap the actual button text in a <span aria-hidden="true"> to prevent both the button text and the screen reader text from being spoken.

Props mukesh27, SergeyBiryukov, sabernhardt, desrosj.
Merges [50585] to the 5.7 branch.
Fixes #52891.
Built from https://develop.svn.wordpress.org/branches/5.7@50609


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 20:32:04 +00:00
davidbaumwald
6e556a478a Revert [50607].
Unprops davidbaumwald.
Built from https://develop.svn.wordpress.org/branches/5.7@50608


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 20:18:02 +00:00
davidbaumwald
0a198192c7 Built from https://develop.svn.wordpress.org/branches/5.7@50607
git-svn-id: http://core.svn.wordpress.org/branches/5.7@50220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 20:09:03 +00:00
desrosj
d59cfc17b6 Build/Test Tools: Backport several build tool fixes & improvements.
This backports a handful of test fixes related to generating code coverage reporting, as well as some `devDependency` updates.

Backports [50591-50595,50597-50598] to the 5.7 branch.
See #52624, #52786, #51734.
Built from https://develop.svn.wordpress.org/branches/5.7@50601


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 16:09:18 +00:00
desrosj
fe2ee5b8cd Revert [50599].
Unprops desrosj.
Built from https://develop.svn.wordpress.org/branches/5.7@50600


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 15:56:17 +00:00
desrosj
12ba6aa8ed Built from https://develop.svn.wordpress.org/branches/5.7@50599
git-svn-id: http://core.svn.wordpress.org/branches/5.7@50212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 15:52:16 +00:00
desrosj
14b4fdff54 Twenty Twelve: Change theme version back to 3.3.
Because the changes in Twenty Twelve did not impact site look or functionality, version 3.4 of Twenty Twelve was not released in coordination with WordPress 5.7.

This reverts the portion of [50508] relevant to Twenty Twelve, changing the version back to 3.3 so that version 3.4 is not skipped accidentally when there are changes that should be released.

Merges [50596] to the 5.7 branch.
See #52704.
Built from https://develop.svn.wordpress.org/branches/5.7@50597


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 15:30:01 +00:00
desrosj
eaf88218f3 Build/Test Tools: Run test workflows on old branches on a schedule.
On TravisCI, old branches still receiving security updates were tested on a regular basis. This ensured tests continued to pass as time passed even if updates were not made to these branches.

On GitHub Actions, there is no interface to configure this (TravisCI had a UI), but there is a `schedule` event that can trigger workflow runs on cron that can be used to accomplish the same thing.

This introduces a workflow file that runs twice a month (on the 1st and 15th) to verify the tests within older branches.

Because the `schedule` event only runs within the primary branch, the appropriate workflows in each old branch will be triggered manually through the `workflow_dispatch` trigger using the GitHub REST API. `workflow_dispatch` will need to be added to all workflows in all old branches in order for the event to dispatch successfully.

Merges [50590] to the 5.7 branch.
See #52653.
Built from https://develop.svn.wordpress.org/branches/5.7@50591


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 13:18:03 +00:00
Peter Wilson
37dc8f3fc0 Twenty Seventeen: Remove extra space around post editor.
The editor uses the full height of its container, so the added margins cause the visual editor to break out of the container. This removes the top & bottom margins, and makes the left & right margins consistent with the meta box area.

Follow-up to [50465].

Props joseeyoast, audrasjb, SergeyBiryukov.
Merges [50534] to the 5.7 branch.
Fixes #52816.

Built from https://develop.svn.wordpress.org/branches/5.7@50588


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 04:10:06 +00:00
Peter Wilson
6c5e9f3656 Robots: Remove contradictory directive check in wp_robots().
Removes the mutually exclusive directives check in `wp_robots()`, ie allow both `follow` and `nofollow` to be specified and for `archive` and `noarchive` to be specified.

This fixes a bug in which WordPress would defer to the most permissive over the least permissive. When contradictory instructions are included, WordPress will defer to the search engine's or archivist's resolution policy: generally this is to observe the least, not most permissive.

Props Cybr, flixos90, SergeyBiryukov.
Merges [50566] to the 5.7 branch.
Fixes #52713.

Built from https://develop.svn.wordpress.org/branches/5.7@50587


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 00:28:03 +00:00
desrosj
12ecbce0b2 Build/Test Tools: Backport several GitHub Action improvements and dependency updates.
This backports several GitHub Action improvements and `devDependency` updates to the 5.7 branch.

Backports [50432,50435-50436,50479,50485-50487,50545,50579] to the 5.7 branch.
See #52667, #52643, #52658, #52660, #52624, #52625.
Built from https://develop.svn.wordpress.org/branches/5.7@50584


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 20:02:19 +00:00
ryelle
8df014b082 Pointers: Make pointer border darker to match arrow tip.
Props johnjamesjacoby, melchoyce, SergeyBiryukov.
Merges [50551] to the 5.7 branch.
Fixes #52670.


Built from https://develop.svn.wordpress.org/branches/5.7@50581


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 15:38:02 +00:00
ryelle
6bc61cc749 Login, Registration: Prevent button misalignment on login screen.
Replace the CSS removed in [50569], which is used to align the login & register buttons.

Props mukesh27, audrasjb.
Reviewed by SergeyBiryukov.
Merges [50577] to the 5.7 branch.
Fixes #52834.


Built from https://develop.svn.wordpress.org/branches/5.7@50580


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 15:33:02 +00:00
Sergey Biryukov
85bde2e551 Accessibility: Administration: Use a darker gray color for various admin UI items.
This ensures that the color meets the WCAG 2.0 AA recommended contrast ratio.

Follow-up to [50025], [50525].

Props sabernhardt, ryelle.
Merges [50571] to the 5.7 branch.
Fixes #52760.
Built from https://develop.svn.wordpress.org/branches/5.7@50578


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 14:44:06 +00:00
Peter Wilson
7d19c6d338 Privacy: Wrap text in buttons on privacy policy guide.
On narrow screens allow the text to wrap in the copy buttons on the privacy policy guide screen to avoid horizontal overflow of the parent container.

Props audrasjb, davidbaumwald, jaymanpandya, paaljoachim, palmiak, sabernhardt, SergeyBiryukov, sumitsingh.
Merges [50568] to the 5.7 branch.
Fixes #52751.

Built from https://develop.svn.wordpress.org/branches/5.7@50574


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 00:07:04 +00:00
Peter Wilson
a37595b941 REST API: Prevent database error when deleting meta data.
Add a check to `WP_REST_Meta_Fields::delete_meta_value()` ensuring meta data is set before attempting to delete it from the database. If the data does not exist, the delete is considered successful as the data matches the desired state.

Props BrechtVds, goaroundagain, TimothyBlynJacobs.
Merges [50567] to the 5.7 branch.
Fixes #52787.

Built from https://develop.svn.wordpress.org/branches/5.7@50573


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 00:04:02 +00:00
Peter Wilson
59e1fddb58 Login, Registration: Prevent button misalignment on password reset screen.
Prevent misalignment of "generate password" and "save password" buttons on the password reset screen on narrow screens and in languages requiring longer text than English.

Props audrasjb, grapplerulrich, ryelle.
Merges [50569] to the 5.7 branch.
Fixes #52834.

Built from https://develop.svn.wordpress.org/branches/5.7@50572


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 00:01:05 +00:00
Peter Wilson
37d01e0346 Media: Pass the appropriate reference into wp_getimagesize.
With changes that were introduced in #49889 the second parameter for getimagesize() function is expecting a a reference.

Previously, most calls did not pass the 2nd param, and as a result, we are getting unexpected results.

This was only a problem with applications that are using a custom stream wrapper, and the image contained EXIF data.

For more see:

    https://github.com/humanmade/S3-Uploads/issues/496
    https://github.com/aws/aws-sdk-php/issues/1923 

Fixes #52826.
Merges [50552] to the 5.7 branch.
Props terriann, SergeyBiryukov, Mista-Flo, hellofromTonya, rinatkhaziev, whyisjake.

Built from https://develop.svn.wordpress.org/branches/5.7@50553


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-19 02:13:05 +00:00
desrosj
b1855cb9d0 Build/Test Tools: Pin NodeJS 14.x in the .nvmrc file for the 5.7 branch.
See #52341.
Built from https://develop.svn.wordpress.org/branches/5.7@50539


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-17 19:46:04 +00:00
ryelle
ef272f47a3 Help/About: Run image comparison script after all assets have loaded.
If the callback is called before the images are loaded, the comparison doesn't work. `wp.domReady` uses `DOMContentLoaded`, which does not guarantee that the images are loaded. This switches to use the `load` event, which waits for all resources to load.

Props vladytimy, joyously, sergeybiryukov.
Merges [50535] to the 5.7 branch.
Fixes #52758.


Built from https://develop.svn.wordpress.org/branches/5.7@50536


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-15 19:57:05 +00:00
Sergey Biryukov
c46deb4cb6 Accessibility: Administration: Use a darker color for post dates in the Activity and Quick Draft dashboard widgets.
This ensures that the color meets the WCAG 2.0 AA recommended contrast ratio.

Follow-up to [50025].

Props sabernhardt, Otshelnik-Fm, audrasjb.
Merges [50525] to the 5.7 branch.
Fixes #52760.
Built from https://develop.svn.wordpress.org/branches/5.7@50526


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-12 12:08:13 +00:00
ryelle
e78b4f2b69 Help/About: Use absolute URLs for inline images on About pages.
This ensures the images are loaded correctly from both single site and network About pages.

Props TobiasBg, audrasjb.
Merges [50523] to the 5.7 branch.
Fixes #52743.


Built from https://develop.svn.wordpress.org/branches/5.7@50524


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-11 21:50:08 +00:00
Sergey Biryukov
f3a89c4ee8 Help/About: Correct the WebM video URL on About page.
Props mihdan, audrasjb.
Merges [50518] to the 5.7 branch.
Fixes #52756.
Built from https://develop.svn.wordpress.org/branches/5.7@50519


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-10 10:30:05 +00:00
desrosj
4d8d6310ec Post WordPress 5.7 version bump.
The 5.7 branch is now 5.7.1 alpha.
Built from https://develop.svn.wordpress.org/branches/5.7@50515


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-09 21:09:05 +00:00
Sergey Biryukov
9072030480 WordPress 5.7.
Built from https://develop.svn.wordpress.org/branches/5.7@50513


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-09 20:15:12 +00:00
Sergey Biryukov
c63ebe7525 Update $_old_files for 5.7.
Follow up to [50066].

Props desrosj.
Reviewed by davidbaumwald, SergeyBiryukov.
Fixes #52334.
Built from https://develop.svn.wordpress.org/branches/5.7@50511


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-08 19:05:07 +00:00
desrosj
6137b9efe0 Build/Test Tools: Ensure the test_php_and_js_shortcode_attribute_regexes_match() test can run when testing using either the src or build directory.
Reviewed by desrosj, johnbillion.
Props alexstine, desrosj.
Merges [50501] to the 5.7 branch.
Fixes #51734.
Built from https://develop.svn.wordpress.org/branches/5.7@50509


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-08 15:16:02 +00:00
desrosj
a9d4c88ff1 Bundled Themes: Bump theme version numbers for WordPres 5.7.
This updates all new default themes to new versions, which will be released shortly after WordPress 5.7. The new versions are:

- Twenty Twenty-One: 1.2
- Twenty Twenty: 1.7
- Twenty Nineteen: 2.0
- Twenty Seventeen: 2.6
- Twenty Sixteen: 2.4
- Twenty Fifteen: 2.9
- Twenty Fourteen: 3.1
- Twenty Thirteen: 3.3
- Twenty Twelve: 3.4
- Twenty Eleven: 3.7
- Twenty Ten: 3.3

Reviewed by desrosj, williampatton.
Merges [50507] to the 5.7 branch.
Fixes #52704.
Built from https://develop.svn.wordpress.org/branches/5.7@50508


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-08 14:56:04 +00:00
Sergey Biryukov
95694600e8 Post WordPress 5.7 RC3 version bump.
Built from https://develop.svn.wordpress.org/branches/5.7@50503


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-05 20:25:02 +00:00
Sergey Biryukov
5737a63b49 WordPress 5.7 RC3.
Built from https://develop.svn.wordpress.org/branches/5.7@50502


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-05 20:11:03 +00:00
Sergey Biryukov
c696886f57 XML-RPC: Pass an empty array to the xmlrpc_call action in methods that have no arguments.
This avoids an "Undefined variable" PHP notice in the `::mt_supportedMethods()` and `::mt_supportedTextFilters()` methods.

Follow-up to [50353].

Props dd32.
Reviewed by dd32, SergeyBiryukov.
Merges [50499] to the 5.7 branch.
Fixes #52524.
Built from https://develop.svn.wordpress.org/branches/5.7@50500


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-05 11:06:03 +00:00
Sergey Biryukov
7bb43234fb Help/About: Clarify two strings.
The intro text has been updated for accuracy and to make it easier for translation. The button text has been updated for accuracy.

Props jdy68, audrasjb, marybaum, davidbaumwald.
Reviewed by ryelle, SergeyBiryukov.
Merges [50495] to the 5.7 branch.
See #52347.
Built from https://develop.svn.wordpress.org/branches/5.7@50498


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-05 10:42:02 +00:00
noisysocks
eed48e29b8 Editor: Update @wordpress npm packages
Update @wordpress npm packages to the latest published versions. This includes
block editor bug fixes for WordPress 5.7 RC 3.

See #52718.

Built from https://develop.svn.wordpress.org/branches/5.7@50497


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-05 04:13:27 +00:00
desrosj
8538424c7f Twenty Twenty-One: Make text readable when dark background is selected for the Media & Text block.
This change ensures that the text in the Media & Text block is readable when dark background colors are selected.

This is a regression that was introduced in [49987].

Props hellofromTonya, poena, paaljoachim, ryelle.
Merges [50493] to the 5.7 branch.
Fixes #52702.
Built from https://develop.svn.wordpress.org/branches/5.7@50494


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-04 17:00:03 +00:00
desrosj
ad6d163cfa Help/About: Clarify a string about lazy-loading iframes.
Props davidbaumwald, audrasjb, hellofromTonya.
See #52347.
Built from https://develop.svn.wordpress.org/branches/5.7@50492


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-04 16:46:05 +00:00
noisysocks
8d05380afc Block Editor: Fix color support for dynamic blocks
Changes wp_apply_colors_support to check for for color instead of
experimentalColor when determining block support for color.

Props nosolosw, rafhun, youknowriad.
See #52709.

Built from https://develop.svn.wordpress.org/branches/5.7@50489


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-03 23:33:06 +00:00
Dion Hulse
cd0cb23aca Bump Akismet external to 4.1.9.
See #52245.


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-03 00:46:24 +00:00
desrosj
0447adfdbf Post WordPress 5.7 RC2 version bump.
Built from https://develop.svn.wordpress.org/branches/5.7@50482


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 20:47:03 +00:00
desrosj
64d9828155 WordPress 5.7 RC2.
Built from https://develop.svn.wordpress.org/branches/5.7@50481


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 20:33:03 +00:00
ryelle
b5e412fc3e Help/About: Iterate on the 5.7 About Page.
Adds a more obviously interactive comparison for viewing the color scheme differences. Improvements on RTL and IE11. Update strings to be more clear and consistent. Switch to the CDN for loading images.

Props sarahricker, desrosj, melchoyce, SergeyBiryukov, tikifez, clorith, marybaum, audrasjb, francina, hellofromTonya.
Reviewed by SergeyBiryukov.
Merges [50478] to the 5.7 branch.
Fixes #52693. See #52347.


Built from https://develop.svn.wordpress.org/branches/5.7@50480


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 20:14:04 +00:00
Mike Schroder
41f4aae738 Upgrade/Install: Invalidate OPcache for version.php during update.
Invalidate OPcache for wp-content/version.php on update individually, since it's copied separately.

Props stodorovic, krstarica, cenay, desrosj, pbiron, sergeybiryukov, mikeschroder.

Reviewed by mikeschroder, SergeyBiryukov.
Merges [50460] and [50475] to the 5.7 branch.
Fixes #51686, #51281.
See #36455.



Built from https://develop.svn.wordpress.org/branches/5.7@50477


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 18:21:03 +00:00
Sergey Biryukov
1adcc5bb83 Security, Site Health: Do not store HTTPS request error messages in an option.
This changes the logic in `update_https_detection_errors()` to never store error messages from the actual request since they could use a different encoding, which would make storing them in an option potentially fail, leading WordPress to then falsely assume that HTTPS is supported.

While this doesn't actually fix the encoding issue, it is not crucial to do so anyway, since these messages are not used anywhere. A simple differentiation between whether the overall HTTPS request or only the SSL verification failed should be sufficient for the purpose of this function.

Props flixos90, tmatsuur, lukecarbis.
Reviewed by flixos90, SergeyBiryukov.
Merges [50471] to the 5.7 branch.
Fixes #52484.
Built from https://develop.svn.wordpress.org/branches/5.7@50472


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 15:16:02 +00:00
Sergey Biryukov
b18d2e5fda REST API: Correct error code for the maxItems keyword.
Follow-up to [50007].

Props TimothyBlynJacobs.
Reviewed by desrosj, SergeyBiryukov.
Merges [50461] to the 5.7 branch.
Fixes #52317.
Built from https://develop.svn.wordpress.org/branches/5.7@50470


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 12:55:03 +00:00
Sergey Biryukov
e0058af83d Twenty Twenty-One: Correct inner container background color for Cover Blocks.
Adjust the background color palette rules so they don't show up on inner containers when they're not supposed to:
- When an inner container block is present, it only applies them to direct children of the block with the background color assigned.
- Since the background color should only be applied to the Cover block's overlay, not to the inner container, it opts that specific block out of this rule.

Props dianeco, kjellr, paaljoachim.
Reviewed by ryelle, SergeyBiryukov.
Merges [50466] to the 5.7 branch.
Fixes #52676.
Built from https://develop.svn.wordpress.org/branches/5.7@50469


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 12:52:03 +00:00
Sergey Biryukov
11ce2fe256 Twenty Fifteen & Twenty Sixteen: Remove extra space around post editor.
The editor uses the full height of its container, so the added margins cause the visual editor to break out of the container. This removes the top & bottom margins, and makes the left & right margins consistent with the meta box area.

Props antonlukin, paaljoachim, felipeelia.
Reviewed by ryelle, SergeyBiryukov.
Merges [50465] to the 5.7 branch.
Fixes #52646.
Built from https://develop.svn.wordpress.org/branches/5.7@50468


git-svn-id: http://core.svn.wordpress.org/branches/5.7@50079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 12:47:06 +00:00