WordPress

mirror of https://github.com/WordPress/WordPress.git synced 2024-12-27 19:47:42 +01:00

Author	SHA1	Message	Date
jorgefilipecosta	b7fbf7d373	Block Editor: Backport block styles server functions from block editor. This commit backports the block styles functionality added to the block editor in https://github.com/WordPress/gutenberg/pull/16356. Props: youknowriad, aduth, swissspidy. Fixes #48039. Built from https://develop.svn.wordpress.org/trunk@46111 git-svn-id: http://core.svn.wordpress.org/trunk@45923 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-14 18:21:54 +00:00
jorgefilipecosta	099eb0578e	Block Editor: Add preloading of autosaves. With the introduction of https://github.com/WordPress/gutenberg/pull/7945, the block editor requests autosave data when the editor is loaded. This can be optimized by preloading the request server-side and then passing the request data to the client using the preloading mechanism in editor-form-blocks.php. Props: talldanwp, aduth. Built from https://develop.svn.wordpress.org/trunk@46110 git-svn-id: http://core.svn.wordpress.org/trunk@45922 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-14 16:47:54 +00:00
Sergey Biryukov	8316af9198	Bootstrap/Load: Allow charset to be passed to the `wp_die()` function. Props mohsinrasool, spacedmonkey, socalchristina. Fixes #46666. Built from https://develop.svn.wordpress.org/trunk@46109 git-svn-id: http://core.svn.wordpress.org/trunk@45921 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-14 15:42:56 +00:00
Sergey Biryukov	0863695da8	Coding Standards: Fix WPCS issue in [46107]. See #46631. Built from https://develop.svn.wordpress.org/trunk@46108 git-svn-id: http://core.svn.wordpress.org/trunk@45920 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-14 15:19:54 +00:00
Sergey Biryukov	f9b87e88ba	HTTP API: Add a unit test for `get_status_header_desc()`. Props pbearne. Fixes #46631. Built from https://develop.svn.wordpress.org/trunk@46107 git-svn-id: http://core.svn.wordpress.org/trunk@45919 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-14 14:54:56 +00:00
Sergey Biryukov	42079f34a9	Site Health: Modify the grading indicator to remove percentage score in favor of a "Good" or "Should be improved" status. This removes arbitrary confusion about what the numbers mean. Props Clorith, hedgefield, Cybr, arena, DavidAnderson, earnjam, daveshine, Otto42, azaozz, asadkn, KARTHOST, tigertech, maximejobin, johnbillion, raboodesign, ramiy, afragen. Fixes #47046. Built from https://develop.svn.wordpress.org/trunk@46106 git-svn-id: http://core.svn.wordpress.org/trunk@45918 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-14 14:29:56 +00:00
Aaron Jorbin	dd3ad3ac51	GENERAL: Remove magic quote functions The path to magic quote sanity took a fun and exciting turn: PHP core removed it and WordPress updated the minimum version. For the formally external pclzip, the code is commented out to make investigating easier and in case we ever need to merge upstream (if that still exists) changes. Props ayeshrajans, jrf, jorbin. See #47783. Fixes #18322. Built from https://develop.svn.wordpress.org/trunk@46105 git-svn-id: http://core.svn.wordpress.org/trunk@45917 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-13 22:21:01 +00:00
desrosj	8a2bbf777a	Correct the version number specified in [46102]. See #45361. Built from https://develop.svn.wordpress.org/trunk@46104 git-svn-id: http://core.svn.wordpress.org/trunk@45916 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-13 18:55:56 +00:00
Adam Silverstein	a3eba2c201	Login and Registration: reset password - ensure submit button disabled when field empty. Fix an issue where the submit button was enabled with an empty password when the user previously checked "Confirm use of weak password" for a weak password, then cleared the password field. Props henry.wright. Fixes #47924. Built from https://develop.svn.wordpress.org/trunk@46103 git-svn-id: http://core.svn.wordpress.org/trunk@45915 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-13 18:30:55 +00:00
desrosj	7bbce99655	Menus: Nav menu locations should not be integers. When nav menu location slugs are integers, some hard to debug results can occur. `register_nav_menus()` utilizes `array_merge()` which renumbers numeric indexes, starting from 0. Because of this, numeric menu locations will almost always be changed. This change introduces a `_doing_it_wrong()` notice to inform developers that nav menu locations should always be strings. Props audrasjb, desrosj, welcher. Fixes #45361. Built from https://develop.svn.wordpress.org/trunk@46102 git-svn-id: http://core.svn.wordpress.org/trunk@45914 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-13 17:58:55 +00:00
Sergey Biryukov	55378bd295	REST API: Use correct parameter name in `rest_validate_value_from_schema()` error messages. Props manzoorwanijk. Fixes #47905. Built from https://develop.svn.wordpress.org/trunk@46101 git-svn-id: http://core.svn.wordpress.org/trunk@45913 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-13 03:06:55 +00:00
Adam Silverstein	67fd6e281f	Multisite: improve `sites_pre_query` and `networks_pre_query` filters, avoiding db queries. Improve the `pre_query` filters in multisite classes introduced in r44983. Return (non null) values immediately, avoiding the database queries entirely, similar to other `pre_query` filters. Props spacedmonkey, SergeyBiryukov, felipeelia. Fixes #47599. Built from https://develop.svn.wordpress.org/trunk@46100 git-svn-id: http://core.svn.wordpress.org/trunk@45912 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-12 22:17:55 +00:00
K. Adam White	c148f0aa55	REST API: Accept string path in rest_ensure_request. Update `rest_ensure_request()` to accept a string path, permitting a string path to be passed to `rest_do_request()` as is indicated (previously inaccurately) in that method's PHPDoc. Props TimothyBlynJacobs, kadamwhite. Fixes #40614. Built from https://develop.svn.wordpress.org/trunk@46099 git-svn-id: http://core.svn.wordpress.org/trunk@45911 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-12 21:47:57 +00:00
K. Adam White	742ab2d68b	REST API: Return term resources in "edit" context after PUT or POST request. Props westonruter, dlh. Fixes #41411. Built from https://develop.svn.wordpress.org/trunk@46098 git-svn-id: http://core.svn.wordpress.org/trunk@45910 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-12 21:29:57 +00:00
Sergey Biryukov	b987372d75	Mail: Update PHPMailer to 5.2.27. The full list of changes is available here: https://github.com/PHPMailer/PHPMailer/compare/v5.2.22...PHPMailer:v5.2.27 Props MattyRob, ayeshrajans, rogueresearch, bgermann, slaFFik, Presskopp, aaroncampbell. Fixes #40472. Built from https://develop.svn.wordpress.org/trunk@46097 git-svn-id: http://core.svn.wordpress.org/trunk@45909 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-12 14:37:57 +00:00
Sergey Biryukov	3591f1ad60	Text Changes: Correct "up-to-date" vs. "up to date" usage in a database update string and inline comments. * "Up to date" is an adverb phrase that describes an action that brings something in line with the latest information. * "Up-to-date" is an adjective phrase that is used as a synonym for "current". Props socalchristina, hareesh-pillai, garrett-eclipse, desrosj, aprea. Fixes #38998. Built from https://develop.svn.wordpress.org/trunk@46096 git-svn-id: http://core.svn.wordpress.org/trunk@45908 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-12 13:06:57 +00:00
Sergey Biryukov	cc6e23e4dc	External Libraries: Update jQuery Color plugin to 2.1.2. Props desrosj, hareesh-pillai, lovememore. Fixes #31511. Built from https://develop.svn.wordpress.org/trunk@46095 git-svn-id: http://core.svn.wordpress.org/trunk@45907 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-12 12:41:54 +00:00
Sergey Biryukov	b552f449db	HTTP: Update the Root Certificate bundle. Keep 1024-bit legacy root certificates re-added in [35919], except for those already expired, for compatibility with older OpenSSL versions. Props skithund, paragoninitiativeenterprises. Fixes #45807. Built from https://develop.svn.wordpress.org/trunk@46094 git-svn-id: http://core.svn.wordpress.org/trunk@45906 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-12 12:04:59 +00:00
Sergey Biryukov	877f356334	External Libraries: Revert [46092] pending test failure investigation. See #45785. Built from https://develop.svn.wordpress.org/trunk@46093 git-svn-id: http://core.svn.wordpress.org/trunk@45905 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-12 10:19:59 +00:00
desrosj	f7f27c37aa	External Libraries: Update Underscore to 1.9.1. Changes: https://github.com/jashkenas/underscore/compare/1.8.3...1.9.1 Props mukesh27, hareesh-pillai. Fixes #45785 Built from https://develop.svn.wordpress.org/trunk@46092 git-svn-id: http://core.svn.wordpress.org/trunk@45904 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-11 19:22:54 +00:00
desrosj	abed60bb51	Editor: Add missing block data fields for blocks registered server side. In [44122], the `styles` and `parent` block fields were omitted on accident. This change makes it possible to reuse them on the client. Props gziolo. Fixes #47017. Built from https://develop.svn.wordpress.org/trunk@46091 git-svn-id: http://core.svn.wordpress.org/trunk@45903 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-11 14:52:56 +00:00
Sergey Biryukov	5289afac9b	Accessibility: Comments: In `comment_form()`, remove `aria-describedby` attribute from the email field if there's no associated description in the `comment_notes_before` argument. The attribute is meant to communicate to user agents and assistive technologies that the element has a description. If the referenced description is missing, it will be flagged as failure by any automated accessibility checker tool and, most importantly, is potentially confusing for assistive technologies users. Props afercia, joedolson, dinhtungdu, donmhico, SergeyBiryukov. Fixes #47975. Built from https://develop.svn.wordpress.org/trunk@46090 git-svn-id: http://core.svn.wordpress.org/trunk@45902 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-11 01:51:54 +00:00
Sergey Biryukov	4d1761c881	Coding Standards: Fix WPCS issue in [46088]. See #47110. Built from https://develop.svn.wordpress.org/trunk@46089 git-svn-id: http://core.svn.wordpress.org/trunk@45901 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-10 20:01:54 +00:00
Sergey Biryukov	dcb08f0637	Docs: Fix placement of some duplicate hook references. Hook documentation should be on the line directly above the line containing the `do_action()` or `apply_filters()` call. The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of duplicate hook references. Includes minor code layout fixes. See #47110. Built from https://develop.svn.wordpress.org/trunk@46088 git-svn-id: http://core.svn.wordpress.org/trunk@45900 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-10 19:23:55 +00:00
Sergey Biryukov	c9071ca2e6	Docs: Clarify the `int` return value in `comments_pre_query` filter DocBlock. See #45800. Built from https://develop.svn.wordpress.org/trunk@46087 git-svn-id: http://core.svn.wordpress.org/trunk@45899 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-10 19:04:56 +00:00
Adam Silverstein	b3e64f0947	Comments: add a new `comments_pre_query` filter to short circuit WP_Comment_Query 'get_comments' queries. Return a non-null value to bypass WordPress's default comment queries. Props felipeelia, spacedmonkey. Fixes #45800. Built from https://develop.svn.wordpress.org/trunk@46086 git-svn-id: http://core.svn.wordpress.org/trunk@45898 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-10 18:42:56 +00:00
Sergey Biryukov	49b4cfc034	Accessibility: Media: Replace `@` with `at` in the displayed date format. The `@` symbol makes sense in the context of email addresses, but does not have a universal meaning in the context of dates. Props audrasjb, afercia. Fixes #47893. Built from https://develop.svn.wordpress.org/trunk@46085 git-svn-id: http://core.svn.wordpress.org/trunk@45897 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-09 00:07:57 +00:00
Sergey Biryukov	86a10090a0	Accessibility: Comments: Replace `@` with `at` in the displayed date format. The `@` symbol makes sense in the context of email addresses, but does not have a universal meaning in the context of dates. Props birgire, afercia, audrasjb, SergeyBiryukov. Fixes #47893. Built from https://develop.svn.wordpress.org/trunk@46084 git-svn-id: http://core.svn.wordpress.org/trunk@45896 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-08 23:53:55 +00:00
Sergey Biryukov	f8ba775d7c	Accessibility: Posts, Post Types: Replace `@` with `at` in the displayed date format. The `@` symbol makes sense in the context of email addresses, but does not have a universal meaning in the context of dates. Props birgire, afercia, audrasjb, SergeyBiryukov. Fixes #47832. Built from https://develop.svn.wordpress.org/trunk@46083 git-svn-id: http://core.svn.wordpress.org/trunk@45895 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-08 23:24:56 +00:00
Sergey Biryukov	0393a78206	Docs: Fix typo in `WP_Hook::resort_active_iterations()` description. Props itowhid06. Fixes #47999. Built from https://develop.svn.wordpress.org/trunk@46082 git-svn-id: http://core.svn.wordpress.org/trunk@45894 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-08 13:16:55 +00:00
Andrew Ozz	c0b5127683	Upload: Reset the temp upload reference in Plupload when the file is not an image. See #47872. Built from https://develop.svn.wordpress.org/trunk@46081 git-svn-id: http://core.svn.wordpress.org/trunk@45893 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-08 02:28:55 +00:00
Sergey Biryukov	e26f739e53	Posts, Post Types: Revert [46079] pending test failure investigation. See #47824. Built from https://develop.svn.wordpress.org/trunk@46080 git-svn-id: http://core.svn.wordpress.org/trunk@45892 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-07 19:33:55 +00:00
Sergey Biryukov	7828fe7e6a	Posts, Post Types: Avoid a PHP warning when `the_content()` is called outside of the loop. Fixes #47824. Built from https://develop.svn.wordpress.org/trunk@46079 git-svn-id: http://core.svn.wordpress.org/trunk@45891 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-07 14:33:56 +00:00
Andrew Ozz	2d6a772400	Fix "white spaces at end of line" in docblock (IDE) woes after [46077]. See #32437. Built from https://develop.svn.wordpress.org/trunk@46078 git-svn-id: http://core.svn.wordpress.org/trunk@45890 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-07 02:12:55 +00:00
Andrew Ozz	1de168e016	Media: Improve handling of cases where an uploaded image matches exactly a defined intermediate size. In most of these cases the original image has been edited by the user and is "web ready", there is no need for an identical intermediate image. Introduces the `wp_image_resize_identical_dimensions` filter so plugins and themes can determine whether a new image with identical dimensions should be created, defaults to false. Props wpdennis, HKandulla, galbaras, azaozz. See #32437. Built from https://develop.svn.wordpress.org/trunk@46077 git-svn-id: http://core.svn.wordpress.org/trunk@45889 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-07 01:34:55 +00:00
Andrew Ozz	dc8349ba0a	Media: Add handling for "BIG" images. When the users upload a big image, typically a photo, scale it down to make it suitable for web use. Then use the scaled image as the "full" size, and keep the originally uploaded image for creating high quality sub-sizes in the future and in case the users want to download it later. Introduces `wp_get_original_image_path()` that retrieves the path to the originally uploaded image in all cases, and `big_image_size_threshold` filter to set the pixel value above which images will be scaled. The same value is used as max-width and max-height when scaling. See #47873. Built from https://develop.svn.wordpress.org/trunk@46076 git-svn-id: http://core.svn.wordpress.org/trunk@45888 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-07 01:07:55 +00:00
Andrew Ozz	630bad3a4f	Uploads: Improve the error message shown when all attempts to create image sub-sizes fail. Props afercia. See #47872. Built from https://develop.svn.wordpress.org/trunk@46075 git-svn-id: http://core.svn.wordpress.org/trunk@45887 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-06 23:48:55 +00:00
whyisjake	f4562e5516	Remove the extra call for wp-sanitize from the script loader. Fixes #47986 Built from https://develop.svn.wordpress.org/trunk@46073 git-svn-id: http://core.svn.wordpress.org/trunk@45885 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-06 21:49:59 +00:00
Sergey Biryukov	699c6001fd	Upgrade/Install: Escape the `%` in `width="100%"` in a `printf()` call in `Plugin_Upgrader_Skin::after()`. Props afragen. Fixes #47989. Built from https://develop.svn.wordpress.org/trunk@46072 git-svn-id: http://core.svn.wordpress.org/trunk@45884 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-06 06:26:56 +00:00
Sergey Biryukov	c1e3b68b19	Docs: Improve documentation for `do_meta_boxes` action. Props felipeelia, killua99, SergeyBiryukov. Fixes #46542. Built from https://develop.svn.wordpress.org/trunk@46071 git-svn-id: http://core.svn.wordpress.org/trunk@45883 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-06 00:06:56 +00:00
Sergey Biryukov	6cab9557fb	REST API: Mark `WP_REST_Users_Controller::update_current_item()` and `::delete_current_item()` as public. Props dkarfa. Fixes #47967. Built from https://develop.svn.wordpress.org/trunk@46070 git-svn-id: http://core.svn.wordpress.org/trunk@45882 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-05 23:18:55 +00:00
Sergey Biryukov	65747e3c91	Docs: Remove extra spaces in various REST API DocBlocks. See #47110. Built from https://develop.svn.wordpress.org/trunk@46069 git-svn-id: http://core.svn.wordpress.org/trunk@45881 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-05 23:05:55 +00:00
Sergey Biryukov	7fb9cba55a	Docs: Correct DocBlocks for `WP_REST_Posts_Controller::get_available_actions()` and `WP_REST_Revisions_Controller::get_parent()`. Props dkarfa. Fixes #47966. Built from https://develop.svn.wordpress.org/trunk@46068 git-svn-id: http://core.svn.wordpress.org/trunk@45880 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-05 22:59:54 +00:00
Andrew Ozz	ee005d8fc5	Fix (unrelated) test after [46066]. See #43524. Built from https://develop.svn.wordpress.org/trunk@46067 git-svn-id: http://core.svn.wordpress.org/trunk@45879 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-05 22:53:56 +00:00
Andrew Ozz	3b976836a8	Media: Add two new intermediate image sizes, 1536px and 2048px. They are meant to enhance the way WordPress displays images on the front-end on larger, high-density devices. They make it possible to generate more suitable `srcset` and `sizes` attributes, and not use the original, often non-optimized image. Also change the default `max_srcset_image_width` value to match the new max size. Props pierlo, azaozz. See #43524. Built from https://develop.svn.wordpress.org/trunk@46066 git-svn-id: http://core.svn.wordpress.org/trunk@45878 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-05 22:27:58 +00:00
Andrea Fercia	17652fb3d4	Widgets: Fix "jumpiness" when reordering widgets by dragging them. Props ketanumretiya030, mukesh27, andraganescu, audrasjb. Fixes #46941. Built from https://develop.svn.wordpress.org/trunk@46028 git-svn-id: http://core.svn.wordpress.org/trunk@45838 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-04 21:49:48 +00:00
Sergey Biryukov	b9d4003d26	Coding Standards: Fix WPCS issue in [45990]. Built from https://develop.svn.wordpress.org/trunk@46019 git-svn-id: http://core.svn.wordpress.org/trunk@45830 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-04 21:45:07 +00:00
desrosj	30ac675795	Fix for URL sanitization that can lead to cross-site scripting (XSS) attacks. Props irsdl, sstoqnov, whyisjake. Built from https://develop.svn.wordpress.org/trunk@45997 git-svn-id: http://core.svn.wordpress.org/trunk@45808 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-04 17:52:56 +00:00
Sergey Biryukov	62b22b86a7	Improve handling the existing `rel` attribute in `wp_rel_nofollow_callback()`. Props xknown, sstoqnov. Built from https://develop.svn.wordpress.org/trunk@45990 git-svn-id: http://core.svn.wordpress.org/trunk@45801 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-04 17:37:55 +00:00
whyisjake	90d9bdc54c	Update wp.a11y.speak() to sanitize HTML before display. Props iandunn, adamsilverstein, sstoqnov, peterwilsoncc Built from https://develop.svn.wordpress.org/trunk@45979 git-svn-id: http://core.svn.wordpress.org/trunk@45790 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-04 17:13:21 +00:00
Sergey Biryukov	c86ee39ff4	Improve URL validation in `wp_validate_redirect()`. Props vortfu, whyisjake, peterwilsoncc. Built from https://develop.svn.wordpress.org/trunk@45971 git-svn-id: http://core.svn.wordpress.org/trunk@45782 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-04 16:57:56 +00:00
Andrea Fercia	187d747198	Bundled Theme: Twenty Nineteen: Use human-friendly color names. For better accessibility, the Primary and Secondary theme colors have now more understandable names. Changes the names "Primary" and "Secondary" to "Blue" and "Dark Blue". Fallbacks to the `hex` color codes when the theme is set to use a custom Primary color. Props kjellr, aduth, audrasjb. Fixes #46698. Built from https://develop.svn.wordpress.org/trunk@45964 git-svn-id: http://core.svn.wordpress.org/trunk@45775 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-04 16:47:10 +00:00
Andrea Fercia	8cb7918905	Bundled Theme: Twenty Nineteen: Fix the nesting of the `main` element. The `main` element must not appear as a descendant of the `section` element. Correct markup is the first requirement to make user agents and assistive technologies work properly. Changes the `<section>` element that was wrapping the `<main>` element to a `<div>`. Props albertomake, ryelle, desrosj, ianbelanger, audrasjb. Fixes #47066. Built from https://develop.svn.wordpress.org/trunk@45942 git-svn-id: http://core.svn.wordpress.org/trunk@45753 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-04 16:27:54 +00:00
Sergey Biryukov	761cd81a01	Escape the output in `wp_ajax_upload_attachment()`. Props whyisjake, sstoqnov. Built from https://develop.svn.wordpress.org/trunk@45936 git-svn-id: http://core.svn.wordpress.org/trunk@45747 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-04 16:09:56 +00:00
whyisjake	50d33282c1	Remove _convert_urlencoded_to_entities() from the get_the_content() callback. Props vortfu, whyisjake, peterwilsoncc Built from https://develop.svn.wordpress.org/trunk@45935 git-svn-id: http://core.svn.wordpress.org/trunk@45746 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-04 16:04:56 +00:00
Andrew Ozz	e313498193	Uploads: After an image is uploaded and PHP times out or runs out of memory during post-processing (the server response is HTTP 500 error), try to resize it three more times. Then, if all attempts fail, do a cleanup of any sub-sizes that may have been created and show an error message asking the user to scale the image and upload it again. See #47872. Built from https://develop.svn.wordpress.org/trunk@45934 git-svn-id: http://core.svn.wordpress.org/trunk@45745 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-04 01:11:54 +00:00
Sergey Biryukov	97cbf72bf9	I18N: Fix typo in a function name in [45932]. See #44360. Built from https://develop.svn.wordpress.org/trunk@45933 git-svn-id: http://core.svn.wordpress.org/trunk@45744 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-03 00:57:54 +00:00
Sergey Biryukov	e199663322	I18N: Capitalize translator comments consistently, add trailing punctuation. Includes minor code layout fixes. See #44360. Built from https://develop.svn.wordpress.org/trunk@45932 git-svn-id: http://core.svn.wordpress.org/trunk@45743 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-03 00:41:05 +00:00
Andrea Fercia	216838a0d2	Accessibility: Improve focus styles for legacy modal dialogs powered by jQuery UI. Fixes #47944. Built from https://develop.svn.wordpress.org/trunk@45931 git-svn-id: http://core.svn.wordpress.org/trunk@45742 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-02 21:49:55 +00:00
Andrea Fercia	fbc9dba70b	Accessibility: Audit usage of abbreviations. Title attributes on abbreviations are only available to a minority of users. The best option is to avoid unnecessary abbreviations when possible. In the other cases, use an `<abbr>` element (which provides a hint to user agents on how to announce and display the abbreviation) and provide an expansion in plain text on first use. - `readme.html`: improves abbreviations and removes unnecessary `title` attributes - options-general: removes unnecessary abbreviations and improves the remaining ones - customizer schedule changeset date: removes unnecessary abbreviations and improves the remaining ones - posts table date: uses a `span` element instead of an `abbr` element because this is not an abbreviation Fixes #46980. Built from https://develop.svn.wordpress.org/trunk@45930 git-svn-id: http://core.svn.wordpress.org/trunk@45741 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-02 21:44:58 +00:00
Felix Arntz	4089fad5fb	Formatting: Improve accuracy of `force_balance_tags()` and add support for custom element tags. This changeset includes a major iteration on the regular expression used to balance tags, with comprehensive test coverage to ensure that all scenarios are supported or unsupported as expected. Props dmsnell, westonruter, birgire. Fixes #47014. Built from https://develop.svn.wordpress.org/trunk@45929 git-svn-id: http://core.svn.wordpress.org/trunk@45740 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-02 10:25:56 +00:00
Peter Wilson	b55ca66759	#43590 : Use robots meta tag to better discourage search engines. This changes the "discourage search engines" option to output a `noindex, nofollow` robots meta tag. `Disallow: /` is removed from the `robots.txt` to allow search engines to discover they are requested not to index the site. Disallowing search engines from accessing a site in the `robots.txt` file can result in search engines listing a site with a fragment (a listing without content). Props donmhico, jonoaldersonwp. Fixes #43590. Built from https://develop.svn.wordpress.org/trunk@45928 git-svn-id: http://core.svn.wordpress.org/trunk@45739 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-02 02:27:55 +00:00
Sergey Biryukov	8662d9a74d	I18N: Split translatable strings located on the same line preceded with a translator comment, where the first string needs that comment, but the second does not. Props johnbillion. See #44360. Built from https://develop.svn.wordpress.org/trunk@45927 git-svn-id: http://core.svn.wordpress.org/trunk@45738 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-02 00:43:55 +00:00
Sergey Biryukov	16b8d91baa	I18N: Improve translator comments. * Add missing translator comments. * Fix placement of some translator comments. Translator comments should be on the line directly above the line containing the translation function call for optimal compatibility with various `.pot` file generation tools. The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of translator comments. Includes minor code layout fixes. Polyglots, rejoice! All WordPress core files now have translator comments for all strings with placeholders! Props jrf, subrataemfluence, GaryJ, webdados, Dency, swissspidy, alvarogois, marcomartins, mihaiiceyro, vladwtz, niq1982, flipkeijzer, michielatyoast, chandrapatel, thrijith, joshuanoyce, FesoVik, tessak22, bhaktirajdev, cleancoded, dhavalkasvala, garrett-eclipse, bibliofille, socalchristina, priyankkpatel, 5hel2l2y, adamsilverstein, JeffPaul, pierlo, SergeyBiryukov. Fixes #44360. Built from https://develop.svn.wordpress.org/trunk@45926 git-svn-id: http://core.svn.wordpress.org/trunk@45737 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-01 17:13:59 +00:00
Andrea Fercia	3ab18dba93	Accessibility: Add a default title for the media modal dialog. Makes sure the media modal dialog `h1` heading isn't empty when custom media frames don't set a title. This is particularly important now that the media modal is an ARIA dialog, as the title is referenced by an `aria-labelledby` attribute to properly label the dialog. Props donmhico, audrasjb. Fixes #47612. Built from https://develop.svn.wordpress.org/trunk@45925 git-svn-id: http://core.svn.wordpress.org/trunk@45736 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-01 15:18:56 +00:00
Sergey Biryukov	7fd6077864	Docs: Improve documentation for `auth_redirect()`. Props atachibana. Fixes #47956. Built from https://develop.svn.wordpress.org/trunk@45924 git-svn-id: http://core.svn.wordpress.org/trunk@45735 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-01 13:03:55 +00:00
Sergey Biryukov	f447c32aca	Twenty Nineteen: Remove unused jQuery argument passed to an IIFE that accepts no arguments. Props Christian1012, hareesh-pillai. Fixes #40333. Built from https://develop.svn.wordpress.org/trunk@45923 git-svn-id: http://core.svn.wordpress.org/trunk@45734 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-31 20:53:54 +00:00
Sergey Biryukov	4d7cc73e17	Twenty Seventeen: Remove unused jQuery argument passed to an IIFE that accepts no arguments. Props Christian1012, hareesh-pillai. See #40333. Built from https://develop.svn.wordpress.org/trunk@45922 git-svn-id: http://core.svn.wordpress.org/trunk@45733 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-31 20:52:56 +00:00
Sergey Biryukov	ceefe26e9e	Twenty Nineteen: Correct file name in JS DocBlocks. See #47110. Built from https://develop.svn.wordpress.org/trunk@45921 git-svn-id: http://core.svn.wordpress.org/trunk@45732 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-31 20:43:55 +00:00
Sergey Biryukov	c9d8c89ebd	Twenty Nineteen: Improve compatibility with custom colors in the separator block. Props kjellr. Fixes #47811. Built from https://develop.svn.wordpress.org/trunk@45920 git-svn-id: http://core.svn.wordpress.org/trunk@45731 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-30 19:15:56 +00:00
Sergey Biryukov	e30696bd20	Twenty Nineteen: Remove Baskerville Old Face from the font stack due to several shortcomings: * Being difficult to read due to its mix of thin and thick strokes. * Having poor language/extended character support. * Not having other weights/styles (bold, italic, etc) and relying on browser approximations of those variants. The next fonts down the stack (Garamond and Times) are more properly aligned to the appearance of the top-level serif font in the stack (Hoefler Text), and work better in its place. Props kjellr, Rarst, justintadlock. Fixes #45881. Built from https://develop.svn.wordpress.org/trunk@45919 git-svn-id: http://core.svn.wordpress.org/trunk@45730 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-30 18:58:57 +00:00
Sergey Biryukov	ffcb1d0d99	Comments: In AJAX response when deleting a comment, account for ` ` as a thousands separator in `total_items_i18n` and `total_pages_i18n` numbers. Props denisco, SergeyBiryukov. Fixes #47953. Built from https://develop.svn.wordpress.org/trunk@45918 git-svn-id: http://core.svn.wordpress.org/trunk@45729 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-30 18:34:06 +00:00
Sergey Biryukov	d26191eb03	Docs: Simplify `get_plugin_data()` and `get_file_data()` description. See #47110. Built from https://develop.svn.wordpress.org/trunk@45917 git-svn-id: http://core.svn.wordpress.org/trunk@45728 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-30 16:57:56 +00:00
Sergey Biryukov	3f048f5ace	Docs: Update plugin headers example in `get_plugin_data()` to clarify that `Version` is not a required field. Props casiepa. See #47110, #meta4707. Built from https://develop.svn.wordpress.org/trunk@45916 git-svn-id: http://core.svn.wordpress.org/trunk@45727 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-30 16:16:57 +00:00
John Blackbourn	640c90d35d	Docs: Correct and improve inline docs relating to caching, terms, meta, and some misc tweaks. See #47110 Built from https://develop.svn.wordpress.org/trunk@45915 git-svn-id: http://core.svn.wordpress.org/trunk@45726 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-30 11:36:08 +00:00
Sergey Biryukov	16c43f368d	Date/Time: Restore the previous behavior of `date_i18n()` where invalid input would result in current time. Make `wp_date()` return `false` on invalid timestamp input, for consistency with upstream PHP `date()` function. Props Rarst. Fixes #28636. Built from https://develop.svn.wordpress.org/trunk@45914 git-svn-id: http://core.svn.wordpress.org/trunk@45725 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-29 23:18:55 +00:00
Sergey Biryukov	3965d4735c	I18N: Add missing translator comment in help text on Reading Settings screen. Props garrett-eclipse. See #46708. Built from https://develop.svn.wordpress.org/trunk@45913 git-svn-id: http://core.svn.wordpress.org/trunk@45724 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-29 21:36:55 +00:00
Sergey Biryukov	7caac01470	Administration: Add a note to "For each post in a feed, include [Full text / Summary]" option that how content is displayed in browsers depends on the theme. Add a documentation link to learn more about feeds. Props JarretC, SergeyBiryukov, pento, talldanwp, dinhtungdu, noisysocks, tobifjellner. Fixes #46708. Built from https://develop.svn.wordpress.org/trunk@45912 git-svn-id: http://core.svn.wordpress.org/trunk@45723 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-29 21:25:55 +00:00
Sergey Biryukov	4629fa26d2	Date/Time: Update XML-RPC tests for invalid date input to account for a more consistent `mysql2date()` error handling in [45908]. The tests were meant to check for the lack of a fatal error in case of invalid date input, not specifically mark a particular outcome as the correct one. Props Rarst. Fixes #28992. Built from https://develop.svn.wordpress.org/trunk@45911 git-svn-id: http://core.svn.wordpress.org/trunk@45722 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-29 16:44:55 +00:00
Felix Arntz	90c424f73b	Multisite: Improve performance by caching not found lookups for sites and networks. With this change, the result of a site or network lookup by ID will be cached even if the ID does not exist. When a new site or network is created, the cache for the respective new ID is cleared. Props mnelson4, nielsdeblaauw. Fixes #42251. Built from https://develop.svn.wordpress.org/trunk@45910 git-svn-id: http://core.svn.wordpress.org/trunk@45721 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-29 12:42:56 +00:00
Mike Schroder	ccdc221b32	Administration: Output valid HTML when `wp_die()` is called. To better support HTML and string calls to `wp_die()` without outputting invalid HTML, wraps error messages in `<div>` rather than `<p>`. Adds `.wp-die-message` CSS class for styling. Props dinhtungdu, jeremyfelt, audrasjb, SergeyBiryukov, afercia, audrasjb, noisysocks. Fixes #47580. Built from https://develop.svn.wordpress.org/trunk@45909 git-svn-id: http://core.svn.wordpress.org/trunk@45720 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-29 07:54:01 +00:00
Sergey Biryukov	6057b32e9b	Date/Time: Revamp `mysql2date()` to use `wp_date()` and handle invalid input in a consistent manner. Add unit tests, improve documentation. Props Rarst, pbearne. Fixes #28992. Built from https://develop.svn.wordpress.org/trunk@45908 git-svn-id: http://core.svn.wordpress.org/trunk@45719 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-29 05:07:56 +00:00
Sergey Biryukov	29a6063f45	Coding Standards: Fix WPCS issue in [45906]. See #45322. Built from https://develop.svn.wordpress.org/trunk@45907 git-svn-id: http://core.svn.wordpress.org/trunk@45718 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-29 02:40:54 +00:00
Sergey Biryukov	e0adbf69ff	XML-RPC: Make sure editing a draft post with `wp.editPost` does not unintentionally cause its published date to be set. Props redsweater. Fixes #45322. Built from https://develop.svn.wordpress.org/trunk@45906 git-svn-id: http://core.svn.wordpress.org/trunk@45717 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-29 02:10:56 +00:00
Sergey Biryukov	27a384caa4	Site Health: Merge two similar strings explaining what drop-in plugins are. Props garrett-eclipse, ramiy, Clorith. Fixes #47247. Built from https://develop.svn.wordpress.org/trunk@45905 git-svn-id: http://core.svn.wordpress.org/trunk@45716 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-28 03:13:55 +00:00
Sergey Biryukov	6cad27efcd	Site Health: Standardize on `SELECT VERSION()` query for checking the database server version, due to the MariaDB version declaration potentially causing issues in production environments. Partially reverts [45691]. Props Clorith. Fixes #47738. Built from https://develop.svn.wordpress.org/trunk@45904 git-svn-id: http://core.svn.wordpress.org/trunk@45715 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-28 03:09:52 +00:00
K. Adam White	181d77f04e	REST API: Only cast scalar types to string when comparing new & old meta values. Newly-supported array and object meta types should not be cast to strings. Props TimothyBlynJacobs, caercam. Fixes #47928. Built from https://develop.svn.wordpress.org/trunk@45903 git-svn-id: http://core.svn.wordpress.org/trunk@45714 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-28 03:08:55 +00:00
Sergey Biryukov	e3d4e81ca0	Date/Time: Correct delta comparison in `test_should_return_wp_timestamp()`. See #25768. Built from https://develop.svn.wordpress.org/trunk@45902 git-svn-id: http://core.svn.wordpress.org/trunk@45713 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-28 02:20:54 +00:00
Sergey Biryukov	12aa694ee5	Date/Time: Introduce `wp_date()` to retrieve the date in localized format. Convert `date_i18n()` into a wrapper for `wp_date()`. `wp_date()` is intended as a replacement for `date_i18n()` without legacy quirks in it. It accepts a true Unix timestamp (not summed with timezone offset) and an arbitrary timezone. Props Rarst, mboynes, MikeHansenMe, rmccue, nacin. Fixes #28636. Built from https://develop.svn.wordpress.org/trunk@45901 git-svn-id: http://core.svn.wordpress.org/trunk@45712 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-28 00:52:56 +00:00
Sergey Biryukov	61d5337aca	Date/Time: Remove the last remaining `current_time( 'timestamp' )` instance in `wp_post_revision_title_expanded()`. Timestamps don't carry any timezone information, using `$revision->post_modified_gmt` simplifies the logic. Props Rarst. See #40657. Built from https://develop.svn.wordpress.org/trunk@45900 git-svn-id: http://core.svn.wordpress.org/trunk@45711 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-27 21:55:56 +00:00
Sergey Biryukov	6a7baa24a6	Docs: Clarify that `$name` and `$value` parameters of `set_user_setting()` can contain hyphens. Props tmatsuur. Fixes #47938. Built from https://develop.svn.wordpress.org/trunk@45899 git-svn-id: http://core.svn.wordpress.org/trunk@45710 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-27 01:17:55 +00:00
Sergey Biryukov	8750097e4b	Docs: Remove a clarification from `do_robots()` description that doesn't really clarify anything. See #47110. Built from https://develop.svn.wordpress.org/trunk@45898 git-svn-id: http://core.svn.wordpress.org/trunk@45709 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-27 00:17:56 +00:00
Sergey Biryukov	cc21760163	Twenty Nineteen: Make sure center-aligned images in columns do not break beyond the column boundaries. Props kjellr. Fixes #47937. Built from https://develop.svn.wordpress.org/trunk@45897 git-svn-id: http://core.svn.wordpress.org/trunk@45708 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-26 19:01:55 +00:00
Sergey Biryukov	9dc2a432b1	Twenty Nineteen: Update `style-rtl.css` after [45773]. See #47850. Built from https://develop.svn.wordpress.org/trunk@45896 git-svn-id: http://core.svn.wordpress.org/trunk@45707 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-26 19:00:58 +00:00
Sergey Biryukov	baffd21844	Docs: Reference `WP_Term_Query::__construct()` in `wp_list_categories()` DocBlock for additional accepted arguments. Clarify that `wp_dropdown_categories()` always returns a string, regardless of the `echo` parameter. See #47896, #47110. Built from https://develop.svn.wordpress.org/trunk@45895 git-svn-id: http://core.svn.wordpress.org/trunk@45706 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-26 17:00:55 +00:00
Boone Gorges	d1ac7170dc	Taxonomy: Standardize docs for `wp_list_categories()`. Many of the parameters historically documented on this function are merely passed through to `get_categories()` and its underlying functions. In order to avoid unnecessary duplication of function arguments, we remove documentation of these parameters, and replace it with reference to the wrapped functions. Parameters that receive special treatment or are otherwise changed before being passed through continue to be documented as part of `wp_list_categories()`. Props audrasjb, itowhid06, birgire. Fixes #47896. Built from https://develop.svn.wordpress.org/trunk@45894 git-svn-id: http://core.svn.wordpress.org/trunk@45705 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-26 15:24:55 +00:00
Boone Gorges	e0c83d76d1	Taxonomy: Fix unique-slug check for terms with parents. `wp_unique_term_slug()` appends numeric suffixes when the requested slug is already in use by a sibling term. Changes introduced in [32837] inadvertently caused this suffixing to be skipped in cases where the requested slug is suffixed with the parent slug, so that it became possible to have two terms `childslug-parentslug` underneath to the same `parentslug`. We fix this regression by ensuring that the numeric-suffix routine runs in all cases. Props yashar_hv, saskak, dlh. Fixes #46431. Built from https://develop.svn.wordpress.org/trunk@45893 git-svn-id: http://core.svn.wordpress.org/trunk@45704 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-26 15:19:56 +00:00
Andrew Ozz	c5fed47367	Docs: Improve and update the description of `multi_resize()` to explain changes and expected use. See #40439. Built from https://develop.svn.wordpress.org/trunk@45892 git-svn-id: http://core.svn.wordpress.org/trunk@45703 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-25 22:21:58 +00:00
Sergey Biryukov	b1847ef3e2	Menus: In `wp_setup_nav_menu_item()` and `Walker_Nav_Menu_Edit::start_el()`, check if the post or term associated with the menu item still exists to avoid a PHP notice. If the associated post or term no longer exists, mark the menu item as invalid. Props mehulkaklotar, kamrankhorsandi, cristiano.zanca, SergeyBiryukov. Fixes #31703. Built from https://develop.svn.wordpress.org/trunk@45891 git-svn-id: http://core.svn.wordpress.org/trunk@45702 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-25 21:32:59 +00:00
Sergey Biryukov	fe0b22cd67	Users: Adjust [45806] to make sure `$all_userids` is always defined. Props kbrownkd. Fixes #47936. Built from https://develop.svn.wordpress.org/trunk@45890 git-svn-id: http://core.svn.wordpress.org/trunk@45701 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-25 20:03:57 +00:00
Sergey Biryukov	c896a0911e	Site Health: Add timezone to Site Health Info page. Props justinahinon, sharaz, artisticasad, Rarst. Fixes #47842. Built from https://develop.svn.wordpress.org/trunk@45889 git-svn-id: http://core.svn.wordpress.org/trunk@45700 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-24 19:37:57 +00:00
Boone Gorges	17d32ebc8f	Taxonomy: Ensure consistency of `hide_empty` in term queries when `taxonomy` is excluded. When querying for terms in hierarchical categories using `hide_empty=true`, results have historically included parent terms which are themselves unattached to any objects (are "empty") but which have non-empty descendent terms. Because this process involves walking the descendant tree, we avoid it when we detect that the queried taxonomies are not hierarchical. (This behavior was introduced in [5525].) When the `taxonomy` parameter of `get_terms()` was made optional - see #35495, [36614] - it affected the mechanism for avoiding unneccessary tree walks, since there may not be any explicitly declared taxonomies to run through `is_taxonomy_hierarchical()`. As a result, term queries excluding `taxonomy` did not check descendants, and empty parents with non-empty children were not included in `hide_empty` results. We correct the behavior by crawling term descendants when the `taxonomy` argument is absent, which means that we're querying for terms in all taxonomies. Props smerriman. Fixes #37728. Built from https://develop.svn.wordpress.org/trunk@45888 git-svn-id: http://core.svn.wordpress.org/trunk@45699 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-23 16:05:56 +00:00
Sergey Biryukov	9672302e04	Date/Time: Rewrite and simplify `get_gmt_from_date()`, `get_date_from_gmt()`, and `iso8601_to_datetime()` using `wp_timezone()`. Improve unit test coverage. Props Rarst, goodevilgenius. Fixes #31809. Built from https://develop.svn.wordpress.org/trunk@45887 git-svn-id: http://core.svn.wordpress.org/trunk@45698 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-23 11:03:56 +00:00
Sergey Biryukov	1aaf11947e	Date/Time: Simplify the date comparing logic in `WP_Community_Events::trim_events()`. The Events API returns event date without timezone information, so trying to parse it into a timestamp and compare to a WP timestamp is pointless. Props Rarst. Fixes #47463. Built from https://develop.svn.wordpress.org/trunk@45886 git-svn-id: http://core.svn.wordpress.org/trunk@45697 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-23 02:15:55 +00:00
Gary Pendergast	601f5f7376	Build Tools: Pass the LOCAL_DIR environment variable through to the phpunit Docker container. This allows code running inside the container to know whether it's supposed to be running in `build` or `src`. See #47767. Built from https://develop.svn.wordpress.org/trunk@45885 git-svn-id: http://core.svn.wordpress.org/trunk@45696 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-23 01:56:56 +00:00
Sergey Biryukov	6330f10b7d	Date/Time: Revert unintended changes from [45882]. Props TimothyBlynJacobs. See #25768. Built from https://develop.svn.wordpress.org/trunk@45884 git-svn-id: http://core.svn.wordpress.org/trunk@45695 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-23 01:16:53 +00:00
Sergey Biryukov	6e555f0c77	Date/Time: Introduce `current_datetime()` for better time operations. Returning a `DateTimeImmutable` representation of the current moment in time, this allows for a more flexible and reliable use than `current_time()` provides. Props Rarst. Fixes #47464. Built from https://develop.svn.wordpress.org/trunk@45883 git-svn-id: http://core.svn.wordpress.org/trunk@45694 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-23 01:12:55 +00:00
Sergey Biryukov	6f8e50c7f0	Date/Time: Rewrite and simplify `date_i18n()` using `wp_timezone()` to address multiple issues with certain date formats and timezones, while preserving some extra handling for legacy use cases. Improve unit test coverage. Props Rarst, remcotolsma, raubvogel. Fixes #25768. Built from https://develop.svn.wordpress.org/trunk@45882 git-svn-id: http://core.svn.wordpress.org/trunk@45693 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-23 00:57:56 +00:00
desrosj	e7c8b21e71	Coding Standards: Dynamic hooks should be named using interpolation not concatenation. Props arena, desrosj. Fixes #47052. Built from https://develop.svn.wordpress.org/trunk@45881 git-svn-id: http://core.svn.wordpress.org/trunk@45692 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-22 19:08:55 +00:00
Sergey Biryukov	d309715a95	Coding Standards: Add missing `break` for the default case in `wp_privacy_anonymize_data()`. Props itowhid06. Fixes #47921. Built from https://develop.svn.wordpress.org/trunk@45877 git-svn-id: http://core.svn.wordpress.org/trunk@45688 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-22 14:50:55 +00:00
Sergey Biryukov	8d919b09d4	Date/Time: Use `wp_timezone()` in `WP_Date_Query::build_mysql_datetime()` to address timezone issues. Improve unit test coverage. Props Rarst, Biranit, birgire, jave.web, SergeyBiryukov. Fixes #41782. Built from https://develop.svn.wordpress.org/trunk@45876 git-svn-id: http://core.svn.wordpress.org/trunk@45687 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-22 03:11:55 +00:00
Gary Pendergast	1f8563d8e7	Build Tools: Don't use git for package installs. While NPM supports installing packages from git locations, this requires `git` to be in the path, which won't necessarily be true, particularly on Windows. We can download the release versions for these packages, instead. Fixes #47916. Built from https://develop.svn.wordpress.org/trunk@45875 git-svn-id: http://core.svn.wordpress.org/trunk@45686 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-22 02:29:54 +00:00
Sergey Biryukov	ad7b2949ba	Users: Adjust [45708] to make sure `wp_update_user()` does not issue a `WP_Error` if a single site was previously set up as Multisite and there's still a `spam` field in the user table. Add a unit test. Props azaozz, SergeyBiryukov. Fixes #45747. Built from https://develop.svn.wordpress.org/trunk@45874 git-svn-id: http://core.svn.wordpress.org/trunk@45685 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-22 01:53:55 +00:00
Sergey Biryukov	f6fc8025c4	Administration: Adjust [45814] to address a backward compatibility issue for plugins passing multiple CSS classes to `add_settings_error()`. Only add the `notice-` prefix for `error`, `success`, `warning`, `info` CSS classes, keep other classes as is. Add unit tests for `settings_errors()`. Props afercia, SergeyBiryukov. Fixes #44941. Built from https://develop.svn.wordpress.org/trunk@45873 git-svn-id: http://core.svn.wordpress.org/trunk@45684 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-22 00:22:56 +00:00
Sergey Biryukov	36b4debdb4	Docs: Correct type for the `$deprecated` argument of `get_terms()`. Props itowhid06. Fixes #47915. Built from https://develop.svn.wordpress.org/trunk@45872 git-svn-id: http://core.svn.wordpress.org/trunk@45683 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-21 16:27:55 +00:00
Sergey Biryukov	3d12c4b6d8	Docs: Fix typo in `_wp_make_subsizes()` DocBlock. Props itowhid06. Fixes #47913. See #40439. Built from https://develop.svn.wordpress.org/trunk@45871 git-svn-id: http://core.svn.wordpress.org/trunk@45682 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-21 16:23:56 +00:00
Sergey Biryukov	f8fb93cd0d	Customizer: Trim whitespace from custom link URLs. This complements a similar fix for the Menus screen in [45655]. Props donmhico, audrasjb. Fixes #47888. See #47723. Built from https://develop.svn.wordpress.org/trunk@45869 git-svn-id: http://core.svn.wordpress.org/trunk@45680 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-21 00:27:57 +00:00
Sergey Biryukov	6b9ab1c5c5	Docs: Update `@since` tag for new JS functions and variables introduced in [45572]. Props garrett-eclipse. See #47145. Built from https://develop.svn.wordpress.org/trunk@45867 git-svn-id: http://core.svn.wordpress.org/trunk@45678 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-20 22:54:55 +00:00
Sergey Biryukov	40d4037fa6	Twenty Seventeen: Fix tabs vs. spaces in [45764]. See #47414. Built from https://develop.svn.wordpress.org/trunk@45863 git-svn-id: http://core.svn.wordpress.org/trunk@45674 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-20 19:12:50 +00:00
Sergey Biryukov	18d991bfc0	Twenty Eleven: Fix tabs vs. spaces in [45763]. See #47414. Built from https://develop.svn.wordpress.org/trunk@45862 git-svn-id: http://core.svn.wordpress.org/trunk@45673 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-20 19:11:55 +00:00
Sergey Biryukov	561e17c1a4	Twenty Seventeen: Adjust [45764] to conform to CSS Coding Standards. See #47414. Built from https://develop.svn.wordpress.org/trunk@45861 git-svn-id: http://core.svn.wordpress.org/trunk@45672 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-20 19:07:49 +00:00
Sergey Biryukov	4a8c0b1498	Twenty Eleven: Adjust [45763] to conform to CSS Coding Standards. See #47414. Built from https://develop.svn.wordpress.org/trunk@45860 git-svn-id: http://core.svn.wordpress.org/trunk@45671 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-20 19:06:54 +00:00
Sergey Biryukov	9793494a2c	Tests: Remove `$wpdb` global reference from `test_wp_insert_user_with_empty_data()`. See #47902. Built from https://develop.svn.wordpress.org/trunk@45859 git-svn-id: http://core.svn.wordpress.org/trunk@45670 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-20 17:28:56 +00:00
Sergey Biryukov	022de7321e	Users: In `wp_insert_user()`, account for the `wp_pre_insert_user_data` filter returning empty data. Props juliobox, SergeyBiryukov. Fixes #47902. Built from https://develop.svn.wordpress.org/trunk@45858 git-svn-id: http://core.svn.wordpress.org/trunk@45669 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-20 17:26:55 +00:00
Sergey Biryukov	bdb1811935	Date/Time: Fix race conditions in `current_time()` tests. * Restore default timezone before performing assertions to avoid affecting other tests in case of failure. * Use delta comparison for timestamps to avoid race conditions. Props SergeyBiryukov, desrosj. Fixes #45821. Built from https://develop.svn.wordpress.org/trunk@45857 git-svn-id: http://core.svn.wordpress.org/trunk@45668 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-20 01:35:56 +00:00
Sergey Biryukov	349e9f56c1	Date/Time: Use PHP `DateTime` class API in `current_time()`. Only use the legacy WP timestamp approach (a sum of timestamp and timezone offset) for `timestamp` and `U` formats without the `$gmt` flag. Otherwise, make sure the function returns correct local time for any format. Props Rarst, jdgrimes. Fixes #40653. Built from https://develop.svn.wordpress.org/trunk@45856 git-svn-id: http://core.svn.wordpress.org/trunk@45667 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-19 21:07:50 +00:00
Sergey Biryukov	26f8b67e35	Coding Standards: Use long array syntax in `Tests_WP_Timezone::timezone_offset_provider()`. Per https://make.wordpress.org/core/2019/07/12/php-coding-standards-changes/, arrays must be declared using long array syntax for clarity. See #24730. Built from https://develop.svn.wordpress.org/trunk@45855 git-svn-id: http://core.svn.wordpress.org/trunk@45666 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-19 21:06:55 +00:00
Sergey Biryukov	46ca606114	Coding Standards: Use `KB_IN_BYTES` in `get_file_data()`. See #22405, #47632. Built from https://develop.svn.wordpress.org/trunk@45854 git-svn-id: http://core.svn.wordpress.org/trunk@45665 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-19 20:10:55 +00:00
Sergey Biryukov	4896dc64ee	Date/Time: Introduce `wp_timezone_string()` and `wp_timezone()` for unified timezone retrieval. * `wp_timezone_string()` retrieves the timezone from current settings as a string. Uses the `timezone_string` option to get a proper timezone if available, otherwise falls back to an offset. * `wp_timezone()` retrieves the timezone from current settings as a `DateTimeZone` object. Timezone can be based on a PHP timezone string or a `±HH:MM` offset. Props Rarst, remcotolsma, johnjamesjacoby, rmccue. Fixes #24730. Built from https://develop.svn.wordpress.org/trunk@45853 git-svn-id: http://core.svn.wordpress.org/trunk@45664 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-19 19:08:59 +00:00
Sergey Biryukov	82af4ad1c0	Coding Standards: Fix WPCS violations in [45851]. See #25347. Built from https://develop.svn.wordpress.org/trunk@45852 git-svn-id: http://core.svn.wordpress.org/trunk@45663 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-19 16:35:56 +00:00
Sergey Biryukov	a58eaa9424	Date/Time: In `wp_insert_post()`, when checking the post date to set `future` or `publish` status, use string comparison to work around far future dates (year 2038+) on 32-bit systems. Props Rarst, nofearinc. Fixes #25347. Built from https://develop.svn.wordpress.org/trunk@45851 git-svn-id: http://core.svn.wordpress.org/trunk@45662 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-19 15:50:56 +00:00
Sergey Biryukov	3541c5d74c	Date/Time: In `WP_Date_Query::__construct()`, return early if `$date_query` is empty or not an array. Props vishalkakadiya. Fixes #47392. Built from https://develop.svn.wordpress.org/trunk@45850 git-svn-id: http://core.svn.wordpress.org/trunk@45661 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-19 15:17:56 +00:00
Gary Pendergast	7a92316fd8	Tests: Add an xdebug group for tests that require xdebug. These tests are now also run as their own part of the Travis build, to ensure performance of other tests isn't affected by the presence of xdebug. Fixes #40532. Built from https://develop.svn.wordpress.org/trunk@45827 git-svn-id: http://core.svn.wordpress.org/trunk@45638 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-19 02:18:56 +00:00
Tammie Lister	a760ef9022	Multisite: Remove truncation to allow clearers identification of longer site names Previously the sites were truncated which meant longer names but with ending identifications were unable to be seen as different. This shows the full site name to allow easier understanding. Props tferry, melinedo, afercia, jeremyfelt Fixes: 47112 Built from https://develop.svn.wordpress.org/trunk@45826 git-svn-id: http://core.svn.wordpress.org/trunk@45637 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-18 12:31:00 +00:00
Sergey Biryukov	d9954ed4cb	Privacy: Add descriptions for sections in a personal data export file. Props garrett-eclipse, Venutius, karmatosed. Fixes #45491. Built from https://develop.svn.wordpress.org/trunk@45825 git-svn-id: http://core.svn.wordpress.org/trunk@45636 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-18 02:07:57 +00:00
Sergey Biryukov	53f5b172ab	Plugins: Adjust margin for plugin headings on "Add Plugins" screen to avoid overlapping with "Network Activate" button. Props justinahinon, chetan200891. Fixes #47600. Built from https://develop.svn.wordpress.org/trunk@45824 git-svn-id: http://core.svn.wordpress.org/trunk@45635 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-17 14:33:56 +00:00
Sergey Biryukov	cde194a21e	Pings/Trackbacks: In `wp_xmlrpc_server::pingback_ping()`, strip inline JS and CSS while trying to figure out the pingback context. Props david.binda. Fixes #47283. Built from https://develop.svn.wordpress.org/trunk@45823 git-svn-id: http://core.svn.wordpress.org/trunk@45634 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-17 13:59:55 +00:00
Sergey Biryukov	aa8e2ff3ba	Docs: Improve documentation for `wp_set_auth_cookie()` and related functions. Props arafat, SergeyBiryukov. Fixes #47886. Built from https://develop.svn.wordpress.org/trunk@45822 git-svn-id: http://core.svn.wordpress.org/trunk@45633 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-17 13:23:55 +00:00
John Blackbourn	3796b7da13	Docs: Add a missing return type. See #47110 Built from https://develop.svn.wordpress.org/trunk@45821 git-svn-id: http://core.svn.wordpress.org/trunk@45632 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-16 19:35:58 +00:00
K. Adam White	ca070acae3	Add @ticket annotations for [45812]. Props birgire. See #43709. Built from https://develop.svn.wordpress.org/trunk@45820 git-svn-id: http://core.svn.wordpress.org/trunk@45631 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-16 03:33:55 +00:00
Gary Pendergast	ea64ea7c96	Build Tools: Improve `local-env` start behaviour under Docker Toolbox. Docker Toolbox requires port forwarding to be configured, but generates error when trying to forward a port that's already been taken. This change removes clashing port forwarding rules before adding our own. See #47767. Built from https://develop.svn.wordpress.org/trunk@45819 git-svn-id: http://core.svn.wordpress.org/trunk@45630 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-16 01:40:54 +00:00
Sergey Biryukov	be6bbe4b5d	Administration: Replace legacy `updated` message type in `add_settings_error()` calls with `success`. See #44640. Built from https://develop.svn.wordpress.org/trunk@45818 git-svn-id: http://core.svn.wordpress.org/trunk@45629 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-16 00:39:55 +00:00
Sergey Biryukov	3f1186166d	Taxonomy: In `feed_links_extra()` and `get_the_archive_title()`, make sure the queried taxonomy term exists before accessing its properties. Props donmhico, truchot, zaantar. Fixes #46420. Built from https://develop.svn.wordpress.org/trunk@45817 git-svn-id: http://core.svn.wordpress.org/trunk@45628 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-16 00:24:54 +00:00
Sergey Biryukov	06d264d032	Coding Standards: In `wlwmanifest_link()`, use concatenation instead of commas for `echo`, for consistency with `rsd_link()` and the rest of core. See #47632. Built from https://develop.svn.wordpress.org/trunk@45816 git-svn-id: http://core.svn.wordpress.org/trunk@45627 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-16 00:21:56 +00:00
K. Adam White	34bc7ab089	REST API: Add @ticket annotation to test from [45813]. Props birgire. See #42209. Built from https://develop.svn.wordpress.org/trunk@45815 git-svn-id: http://core.svn.wordpress.org/trunk@45626 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-15 23:09:54 +00:00
Sergey Biryukov	e5deae5e78	Administration: In `add_settings_error()`, add `warning` and `info` as possible values for message type. Account for these new values in `settings_errors()`, resulting in `notice-warning` and `notice-info` CSS classes. Map legacy `error` and `updated` CSS classes to `notice-error` and `notice-success`. Props donmhico, toddhalfpenny, flixos90, desrosj, javorszky, SergeyBiryukov. Fixes #44640, #44941. Built from https://develop.svn.wordpress.org/trunk@45814 git-svn-id: http://core.svn.wordpress.org/trunk@45625 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-15 23:01:55 +00:00
K. Adam White	7eed5eff61	REST API: Always return post types list in taxonomies endpoint response as an array. Prevents a non-sequential post type array such as [ 0 => 'post', 2 => 'page' ] from being improperly converted to an object in the taxonomy endpoint's response JSON. Props TimothyBlynJacobs, birgire, spectacula. Fixes #42209. Built from https://develop.svn.wordpress.org/trunk@45813 git-svn-id: http://core.svn.wordpress.org/trunk@45624 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-15 22:12:55 +00:00
K. Adam White	00cb4c7dbd	REST API: Prevent deletion of post revisions. Allowing the client to delete revisions breaks the "audit trail" functionality. This is not allowed in WordPress and shouldn't be allowed through the API. While not recommended, a plugin may opt-in to the previous behavior by setting a custom 'delete_post' capability for the revisions post type. Props dlh, danielbachhuber, TimothyBlynJacobs, azaozz, kadamwhite. Fixes #43709. Built from https://develop.svn.wordpress.org/trunk@45812 git-svn-id: http://core.svn.wordpress.org/trunk@45623 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-15 22:01:55 +00:00
K. Adam White	5dbb64d0dd	REST API: Cache results of get_item_schema on controller instances for performance. Caches the output of get_item_schema() to avoid redundant recomputation of translatable strings and other computed values. This method is called many times per item in each REST request, and the results of the method should not vary between calls. Additional schema fields are not cached. Props kadamwhite, joehoyle, TimothyBlynJacobs. Fixes #47871. Built from https://develop.svn.wordpress.org/trunk@45811 git-svn-id: http://core.svn.wordpress.org/trunk@45622 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-15 21:09:55 +00:00
K. Adam White	dbfa0c7ed4	REST API: Clarify arguments passed to rest route get & update callbacks. Update doc block argument definitions to clarify that the REST API always passes an array to the `get_callback` and always passes an entity object to the `update_callback`. Props TimothyBlynJacobs, salzano. Fixes #44432. Built from https://develop.svn.wordpress.org/trunk@45810 git-svn-id: http://core.svn.wordpress.org/trunk@45621 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-15 20:04:55 +00:00
K. Adam White	8dcc10693f	REST API: Do not send response body if status is 204 or body is null. Status code 204 should indicate no response body is sent. Previously, a "null" string was sent, which MacOS Safari would try to parse as JSON and thereby fail to complete the request. Props TimothyBlynJacobs, andizer, matthias.thiel. Fixes #43691. Built from https://develop.svn.wordpress.org/trunk@45809 git-svn-id: http://core.svn.wordpress.org/trunk@45620 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-15 19:56:55 +00:00
K. Adam White	b75420443c	REST API: Add test class file incorrectly omitted from [45807]. Props @TimothyBlynJacobs. See #43392. Built from https://develop.svn.wordpress.org/trunk@45808 git-svn-id: http://core.svn.wordpress.org/trunk@45619 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-15 17:21:55 +00:00
K. Adam White	5b318f1dda	REST API: Support 'object' and 'array' types in register_meta() schemas. Extends meta registration to support complex schema values, mirroring the functionality in the settings controller. Error when trying to modify a meta key containing schema-nonconformant data. Props @TimothyBlynJacobs, @birgire, @mnelson4, @flixos90. Fixes #43392. Built from https://develop.svn.wordpress.org/trunk@45807 git-svn-id: http://core.svn.wordpress.org/trunk@45618 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-15 17:17:55 +00:00
Sergey Biryukov	ab0b860db9	Users: When deleting users, exclude the current user from the content existence check. The current user cannot be deleted, so the check is redundant in that context and should only be done for other users. Props mt8.biz, SergeyBiryukov. Fixes #47851. Built from https://develop.svn.wordpress.org/trunk@45806 git-svn-id: http://core.svn.wordpress.org/trunk@45617 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-15 13:06:55 +00:00
Gary Pendergast	7169586254	Schema: Add an index to `wp_options.autoload`. Most sites will be unaffected by this change, but those with a large number of rows in `wp_options`, only a small number of which have `autoload` set, will see a significant performance improvement. Sites with a large number of rows in `wp_options`, with many of them having `autoload` set will unfortunately see a performance penalty on top of the already very slow queries they're running, but this should be the minority of cases. Props DanBUK. Fixes #24044. Built from https://develop.svn.wordpress.org/trunk@45805 git-svn-id: http://core.svn.wordpress.org/trunk@45616 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-15 07:13:55 +00:00
Sergey Biryukov	98ffc642a9	Networks and Sites: Trim site domain when creating a new site on Add New Site screen before further validation. Props dharmin16, jeremyfelt, aubreypwd. Fixes #44808. Built from https://develop.svn.wordpress.org/trunk@45804 git-svn-id: http://core.svn.wordpress.org/trunk@45615 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-15 01:21:55 +00:00
Sergey Biryukov	d85ba82d8e	Docs: Add missing `@since` tag for `WP_Site_Health::has_late_cron()`. See #47223. Built from https://develop.svn.wordpress.org/trunk@45803 git-svn-id: http://core.svn.wordpress.org/trunk@45614 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-15 00:42:55 +00:00
Peter Wilson	1d7ae02376	Site Health Check: New tests file missed in [45801]. Built from https://develop.svn.wordpress.org/trunk@45802 git-svn-id: http://core.svn.wordpress.org/trunk@45613 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-15 00:37:56 +00:00
Peter Wilson	a56256d158	Site Health Check: Increase time allowance for cron checks. Introduces `WP_Site_Health::has_late_cron()` for late wp-cron jobs and extends the time allowance before a job is considered missed. In a standard configuration using loopback requests, a job is considered late once past due and missed over five minutes past due. Late and missed time frames are extended if `DISABLE_WP_CRON` is defined as `true` to allow for crontab tasks running less frequently. A job is considered late once it's 15 minutes past due and missed over one hour past due. A file for site health unit tests has been introduced with tests for cron in critical, late and missed states. Props rockfire, afragen, peterwilsoncc. Fixes #47223. Built from https://develop.svn.wordpress.org/trunk@45801 git-svn-id: http://core.svn.wordpress.org/trunk@45612 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-15 00:35:55 +00:00
Gary Pendergast	b8c5530131	Build Tools: Change the PHPUnit Docker image's working directory to match the other images. Also, pass the `WP_MULTISITE` environment variable along to the container. See #47767. Built from https://develop.svn.wordpress.org/trunk@45800 git-svn-id: http://core.svn.wordpress.org/trunk@45611 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-15 00:34:57 +00:00
Gary Pendergast	b473b2241e	Build Tools: Run `composer` commands in a Docker container on Travis. This tidies up the `.travis.yml` file a little more. See #47767. Built from https://develop.svn.wordpress.org/trunk@45799 git-svn-id: http://core.svn.wordpress.org/trunk@45610 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-14 23:12:55 +00:00
Sergey Biryukov	cc8e05df39	Widgets: Allow for short-circuiting widget output in `the_widget()` using the `widget_display_callback` filter, for consistency with output via a registered sidebar. Props MarcGuay, donmhico. Fixes #34226. Built from https://develop.svn.wordpress.org/trunk@45798 git-svn-id: http://core.svn.wordpress.org/trunk@45609 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-14 23:03:55 +00:00
Sergey Biryukov	0e1343ee2b	Docs: Correct type for `query_var` argument of `register_taxonomy()`. Props juiiee8487, audrasjb. Fixes #47877. Built from https://develop.svn.wordpress.org/trunk@45797 git-svn-id: http://core.svn.wordpress.org/trunk@45608 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-14 17:47:55 +00:00
Sergey Biryukov	c03a0bea8d	Posts, Post Types: In `wp_trim_words()` make sure the `$num_words` parameter is always an integer, as documented, to avoid a PHP warning. Props donmhico, pikamander2. Fixes #47867. Built from https://develop.svn.wordpress.org/trunk@45796 git-svn-id: http://core.svn.wordpress.org/trunk@45607 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-14 17:18:55 +00:00
Sergey Biryukov	ae4087bca6	Users: Make `wp_list_authors()` unit tests more readable. See #23498. Built from https://develop.svn.wordpress.org/trunk@45795 git-svn-id: http://core.svn.wordpress.org/trunk@45606 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-14 15:36:57 +00:00
Sergey Biryukov	d6faa62338	Networks and Sites: Improve documentation and variable naming in `switch_to_blog()` and `restore_current_blog()`. In `switch_to_blog()`: * Rename `$blog_id` to `$prev_blog_id` for clarity. * Rename `$new_blog` to `$new_blog_id` for consistency. * Pass `$prev_blog_id` as a second parameter to `switch_blog` action, instead of the duplicated `$new_blog_id`. This only clarifies documentation and does not affect functionality, since the values are equal in the context where the DocBlock is located. In `restore_current_blog()`: * Rename `$blog` to `$new_blog_id` for clarity. * Rename `$blog_id` to `$prev_blog_id` for clarity. Props ChriCo, jeremyfelt, SergeyBiryukov. Fixes #45594. Built from https://develop.svn.wordpress.org/trunk@45794 git-svn-id: http://core.svn.wordpress.org/trunk@45605 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-14 14:29:56 +00:00
Sergey Biryukov	428a738f1d	Plugins: Adjust the pause before running plugin search AJAX request on "Add Plugins" screen to allow more time for using browser's autocomplete. Props donmhico, apermo. Fixes #46021. Built from https://develop.svn.wordpress.org/trunk@45793 git-svn-id: http://core.svn.wordpress.org/trunk@45604 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-14 02:02:56 +00:00
Sergey Biryukov	3ce3927dc1	Coding Standards: Fix JSHint error in [45790]. See #41545. Built from https://develop.svn.wordpress.org/trunk@45792 git-svn-id: http://core.svn.wordpress.org/trunk@45603 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-14 00:02:55 +00:00
Sergey Biryukov	4cf729f5a9	Site Health: Simplify the language in Status Health Info page introduction, add a link to Status page. Props birgire, mukesh27, subrataemfluence, leogermani. Fixes #46946. Built from https://develop.svn.wordpress.org/trunk@45791 git-svn-id: http://core.svn.wordpress.org/trunk@45602 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-13 23:35:56 +00:00
Adam Silverstein	3e605d3852	Comments: enable typing cmd/ctrl-enter to submit comment forms. Add a key handler on the comment form that detects the cmd/ctrl-enter key press and submits the comment form. Props xyfi, Lindstromer, helen, splitti. Fixes #41545. Built from https://develop.svn.wordpress.org/trunk@45790 git-svn-id: http://core.svn.wordpress.org/trunk@45601 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-13 21:26:56 +00:00
Andrew Ozz	400ed5add0	Remove trailing white space in upgrade.php. See #46349. Built from https://develop.svn.wordpress.org/trunk@45789 git-svn-id: http://core.svn.wordpress.org/trunk@45600 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-13 19:53:55 +00:00
Andrew Ozz	197b4a829b	Admin email verification: - Add the `admin_email_lifespan` option when installing. Fixes a bug where the verification screen is shown right after installation. - Reset the same option when upgrading and the user doing the DB upgrade is not an admin. This will ensure the email verification is shown next time an admin logs in. - Use `site_url()` instead of `network_site_url()` for the form action. The latter seems needed only for password reset. See #46349. Built from https://develop.svn.wordpress.org/trunk@45788 git-svn-id: http://core.svn.wordpress.org/trunk@45599 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-13 17:40:55 +00:00
Peter Wilson	dc2e7e716f	Comments: Include post permalink in comment reply link. Include the post's permalink when generating reply links in `get_comment_reply_link()` to account for comments displayed on index and archive pages. This reapplies [32786] which was inadvertently reverted in [42360]. Props justinahinon, donmhico. See #33383. Fixes #47174. Built from https://develop.svn.wordpress.org/trunk@45787 git-svn-id: http://core.svn.wordpress.org/trunk@45598 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-13 05:09:56 +00:00
K. Adam White	aa90dc4e8c	Docs: Clarify custom-fields support requirement for viewing custom post meta in REST API. Fixes #47866. Built from https://develop.svn.wordpress.org/trunk@45786 git-svn-id: http://core.svn.wordpress.org/trunk@45597 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-13 01:51:56 +00:00
Gary Pendergast	28ad3662fc	Build Tools: Remove the old `docker-compose.yml` file, now no longer used. See #47767. Built from https://develop.svn.wordpress.org/trunk@45785 git-svn-id: http://core.svn.wordpress.org/trunk@45596 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-12 09:22:55 +00:00
Gary Pendergast	20f833426a	Build Tools: Add the `docker-compose.yml` file, missed in [45783]. See #47767. Built from https://develop.svn.wordpress.org/trunk@45784 git-svn-id: http://core.svn.wordpress.org/trunk@45595 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-12 09:21:56 +00:00
Gary Pendergast	74d03c4692	Build Tools: Miscellaneous `local-env` improvements. - Move the functionality for controlling `local-env` out of `package.json`, into JS scripts. - Merge the `docker-compose` config files, and move it to the root directory. This allows `docker-compose.override.yml` to work for local overrides. - Fix nginx redirecting to port 80 under some circumstances. - `npm run env:install` now creates `wp-tests.config.php` for you. - Cleaned up a bunch of cruft in `.travis.yml`. See #47767. Built from https://develop.svn.wordpress.org/trunk@45783 git-svn-id: http://core.svn.wordpress.org/trunk@45594 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-12 08:29:55 +00:00
Sergey Biryukov	99f4ff2578	Site Health: Add database charset and collation information to debug info. Props sharaz, Clorith, SergeyBiryukov. Fixes #47828. Built from https://develop.svn.wordpress.org/trunk@45782 git-svn-id: http://core.svn.wordpress.org/trunk@45593 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-12 01:54:57 +00:00
Sergey Biryukov	e6a4b884f5	Docs: Improve documentation for various feed link functions and filters. Props atachibana, SergeyBiryukov. Fixes #47862. Built from https://develop.svn.wordpress.org/trunk@45781 git-svn-id: http://core.svn.wordpress.org/trunk@45592 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-11 17:21:57 +00:00
Sergey Biryukov	b7e7a5321b	Docs: Improve documentation for `get_last_updated()`. Props atachibana. Fixes #47861. Built from https://develop.svn.wordpress.org/trunk@45780 git-svn-id: http://core.svn.wordpress.org/trunk@45591 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-11 16:18:57 +00:00
Sergey Biryukov	80d153fb70	Docs: Improve documentation for `get_page_by_title()`. Props atachibana. Fixes #47860. Built from https://develop.svn.wordpress.org/trunk@45779 git-svn-id: http://core.svn.wordpress.org/trunk@45590 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-11 12:42:56 +00:00
Sergey Biryukov	64290005f5	Docs: Document the `show_split_view` argument for `wp_text_diff()`. Convert `$args` array documentation to hash notation. Props riddhiehta02, jeremyfelt, SergeyBiryukov. Fixes #47224. Built from https://develop.svn.wordpress.org/trunk@45778 git-svn-id: http://core.svn.wordpress.org/trunk@45589 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-10 22:28:54 +00:00
whyisjake	1a9812d9b4	Widgets: Replace http with https in the link placeholder widget image The existing placeholder can make the user think that they must use http. We should encourage the use of https. Also, the block editor uses https for its placeholders. Let's add some consistency. Props Chaton666, audrasjb, mukesh27. Fixes #46320. Built from https://develop.svn.wordpress.org/trunk@45777 git-svn-id: http://core.svn.wordpress.org/trunk@45588 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-09 17:06:55 +00:00
Sergey Biryukov	6e060079ae	Twenty Sixteen: Correct HelpHub URL in `readme.txt`. See #47771. Built from https://develop.svn.wordpress.org/trunk@45776 git-svn-id: http://core.svn.wordpress.org/trunk@45587 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-09 13:53:56 +00:00
Sergey Biryukov	092872c3fc	Twenty Nineteen: Add missing `Installation` section to `readme.txt`, for consistency with other themes. See #47857. Built from https://develop.svn.wordpress.org/trunk@45775 git-svn-id: http://core.svn.wordpress.org/trunk@45586 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-09 13:42:57 +00:00
Sergey Biryukov	aaea839402	Twenty Nineteen: Add missing copyright information. Props poena, kjellr. Fixes #47857. Built from https://develop.svn.wordpress.org/trunk@45774 git-svn-id: http://core.svn.wordpress.org/trunk@45585 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-09 13:36:58 +00:00
Sergey Biryukov	441a3c97e0	Twenty Nineteen: Correct license URI. Props munyagu, shital-patel. Fixes #47850. Built from https://develop.svn.wordpress.org/trunk@45773 git-svn-id: http://core.svn.wordpress.org/trunk@45584 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-09 02:57:59 +00:00
Gary Pendergast	12aa773802	Feeds: Introduce the `get_self_link()` function. Corresponds to the `self_link()` template function. This matches other feed template functions, using one function to get the value, and a different function to echo it. Props jojotjebaby, mobeen-abdullah, donmhico, audrasjb, dshanske. Fixes #44838. Built from https://develop.svn.wordpress.org/trunk@45772 git-svn-id: http://core.svn.wordpress.org/trunk@45583 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-09 01:31:56 +00:00
Sergey Biryukov	2aa8ce5bc5	REST API: In `get_rest_url()`, check if `$_SERVER['SERVER_NAME']` is set to avoid a PHP warning in CLI context. Props paulschreiber. Fixes #47854. Built from https://develop.svn.wordpress.org/trunk@45771 git-svn-id: http://core.svn.wordpress.org/trunk@45582 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-08 20:20:55 +00:00
Sergey Biryukov	6041a08347	Bootstrap/Load: Change "Insufficient Requirements" `wp_die()` heading to "Requirements Not Met", which is more appropriate for the context it's used in. Props yoavf. Fixes #47575. Built from https://develop.svn.wordpress.org/trunk@45770 git-svn-id: http://core.svn.wordpress.org/trunk@45581 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-08 12:54:56 +00:00
Gary Pendergast	638bae9392	Emoji: Upgrade Twemoji to 12.1.2. This upgrade adds support for the transgender flag: 🏳️‍⚧️ There's some additional housekeeping in this commit: - Twemoji recently rearranged their repository and package, so `Gruntfile.js` needed tweaking to allow for that. - As only new files were added in this Twemoji release, the CDN version didn't need updating. Fixes #47852. Built from https://develop.svn.wordpress.org/trunk@45769 git-svn-id: http://core.svn.wordpress.org/trunk@45580 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-08 04:05:55 +00:00
Sergey Biryukov	83187125e4	Bundled Themes: Audit and update version numbers passed to `wp_enqueue_script()` to ensure proper cache busting. Props dswebsme, ianbelanger, justinahinon. Fixes #46981. Built from https://develop.svn.wordpress.org/trunk@45768 git-svn-id: http://core.svn.wordpress.org/trunk@45579 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-08 01:29:58 +00:00
Sergey Biryukov	e0563013ed	Bundled Themes: Audit and update version numbers passed to `wp_enqueue_style()` to ensure proper cache busting. Props dswebsme, ianbelanger, desrosj. Fixes #46979. Built from https://develop.svn.wordpress.org/trunk@45767 git-svn-id: http://core.svn.wordpress.org/trunk@45578 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-08 01:25:58 +00:00
Sergey Biryukov	c965d2e097	Administration: Show a warning in Reading Settings when a Privacy Policy page is accidentally set as a Homepage or Posts page. Props garrett-eclipse, subrataemfluence. Fixes #46831. Built from https://develop.svn.wordpress.org/trunk@45766 git-svn-id: http://core.svn.wordpress.org/trunk@45577 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-07 23:03:54 +00:00
Aaron Jorbin	b8fd2b631b	Bump grunt-patch-wordpress to 2.0.0 Fixes #47845 Props pento, kadamwhite, netweb, jorbin Built from https://develop.svn.wordpress.org/trunk@45765 git-svn-id: http://core.svn.wordpress.org/trunk@45576 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-07 15:09:57 +00:00
Sergey Biryukov	aa4ab3acdc	Twenty Seventeen: Correct height for a Button block without text. Props ianbelanger, laurelfulford, nayana123. Fixes #47414. Built from https://develop.svn.wordpress.org/trunk@45764 git-svn-id: http://core.svn.wordpress.org/trunk@45575 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-07 11:57:54 +00:00
Sergey Biryukov	64202a7ca3	Twenty Eleven: Correct height for a Button block without text. Props ianbelanger, laurelfulford, nayana123. See #47414. Built from https://develop.svn.wordpress.org/trunk@45763 git-svn-id: http://core.svn.wordpress.org/trunk@45574 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-07 11:56:57 +00:00
Gary Pendergast	d5d58a90f9	Build Tools: Switch all Travis PHPUnit jobs over to Docker-based PHP. Additionally, there are a handful of related minor changes in this commit: - `.travis.yml` has been tidied up a little. - [45745] was incorrectly marking Travis jobs as passed when some PHPUnit runs failed. - Add the `LOCAL_PHP_MEMCACHED` environment variable, for enabling Memcached. - Add the `env:pull` NPM script, for refreshing Docker images. See #47767. Built from https://develop.svn.wordpress.org/trunk@45762 git-svn-id: http://core.svn.wordpress.org/trunk@45573 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-07 11:55:57 +00:00
Sergey Biryukov	de099aec14	Twenty Nineteen: Revise Latest Posts block styles to support post content options. Props kjellr, ianbelanger. Fixes #47340. Built from https://develop.svn.wordpress.org/trunk@45761 git-svn-id: http://core.svn.wordpress.org/trunk@45572 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-07 11:48:57 +00:00
Sergey Biryukov	72b11e3322	Twenty Nineteen: Remove duplicate `height` and `width` attributes from SVG icons. The attributes are added via `TwentyNineteen_SVG_Icons::get_svg()`, there's no need to have them separately in SVG sources. Props mukesh27, albertomake. Fixes #47128. Built from https://develop.svn.wordpress.org/trunk@45760 git-svn-id: http://core.svn.wordpress.org/trunk@45571 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-07 11:41:54 +00:00
Sergey Biryukov	32afb6f7c7	Coding Standards: Use strict comparison in `wp-admin/edit.php`. Props davidbaumwald. Fixes #47201. Built from https://develop.svn.wordpress.org/trunk@45759 git-svn-id: http://core.svn.wordpress.org/trunk@45570 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-07 11:40:55 +00:00
Andrew Ozz	52c53ae6f8	Remove trailing white space in upgrade.php after [45757]. See #46349. Built from https://develop.svn.wordpress.org/trunk@45758 git-svn-id: http://core.svn.wordpress.org/trunk@45569 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-07 01:01:57 +00:00
Andrew Ozz	fff56d219f	Add admin email verification screen. Shown every six months after an admin has logged in. Also includes WPCS fixes for wp-login.php. Props andraganescu, boemedia, lessbloat, azaozz. See #46349. Built from https://develop.svn.wordpress.org/trunk@45757 git-svn-id: http://core.svn.wordpress.org/trunk@45568 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-07 00:04:56 +00:00
Sergey Biryukov	e081194455	Administration: Correct "Quick Edit" link height in list tables for consistency with other action links. Props jobthomas, burhandodhy. Fixes #47815. Built from https://develop.svn.wordpress.org/trunk@45756 git-svn-id: http://core.svn.wordpress.org/trunk@45567 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-05 22:20:58 +00:00
Sergey Biryukov	e4f1204e04	Coding Standards: Fix WPCS violation in [45754]. See #46570. Built from https://develop.svn.wordpress.org/trunk@45755 git-svn-id: http://core.svn.wordpress.org/trunk@45566 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-05 18:10:59 +00:00
Sergey Biryukov	282dfee8e0	General: Correctly detect large floats in `is_serialized()`. Props killerbishop, donmhico, hoythan. Fixes #46570. Built from https://develop.svn.wordpress.org/trunk@45754 git-svn-id: http://core.svn.wordpress.org/trunk@45565 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-05 13:55:57 +00:00
Sergey Biryukov	d5fc1647c0	Feeds: Escape `&` characters in `atom_site_icon()` for XML, for consistency with `rss2_site_icon()`. Props abhijitrakas, shawfactor. Fixes #47482. Built from https://develop.svn.wordpress.org/trunk@45753 git-svn-id: http://core.svn.wordpress.org/trunk@45564 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-05 13:15:56 +00:00
Sergey Biryukov	2ac34c799b	Coding Standards: Use strict comparison in `wp-admin/options-reading.php`. Props subrataemfluence. Fixes #46834. Built from https://develop.svn.wordpress.org/trunk@45752 git-svn-id: http://core.svn.wordpress.org/trunk@45563 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-05 12:52:56 +00:00
Sergey Biryukov	ad9d8c7d58	Plugins: Use `include_once` for `wp-admin/includes/plugin-install.php` in `WP_Plugin_Install_List_Table::prepare_items()`. This brings consistency with the other instances where the file is included, and allows for reusing its functions in custom code. Props engelen, desrosj. Fixes #38874. Built from https://develop.svn.wordpress.org/trunk@45751 git-svn-id: http://core.svn.wordpress.org/trunk@45562 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-05 11:07:55 +00:00
Sergey Biryukov	c1a252da8e	Site Health: Use correct variable when checking PHP requirements for a plugin update in `WP_Plugins_List_Table::single_row()`. Props diddledan, sharaz, vaishalipanchal. Fixes #47835. Built from https://develop.svn.wordpress.org/trunk@45750 git-svn-id: http://core.svn.wordpress.org/trunk@45561 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-05 10:58:56 +00:00
Sergey Biryukov	bec2aa0ef7	Docs: Correct `@type` annotation for `WP_Http_Curl` properties. Props diddledan. Fixes #46860. Built from https://develop.svn.wordpress.org/trunk@45749 git-svn-id: http://core.svn.wordpress.org/trunk@45560 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-05 08:12:56 +00:00
Sergey Biryukov	bbf84bccf7	Docs: Correct `@type` annotation for `WP_HTTP_Cookie::$expires`. Props diddledan. Fixes #46859. Built from https://develop.svn.wordpress.org/trunk@45748 git-svn-id: http://core.svn.wordpress.org/trunk@45559 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-05 07:56:56 +00:00
Sergey Biryukov	f7b8423b12	Upgrade/Install: Make sure `translate_level_to_role()` always returns a value. Props diddledan. Fixes #46848. Built from https://develop.svn.wordpress.org/trunk@45747 git-svn-id: http://core.svn.wordpress.org/trunk@45558 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-05 07:48:58 +00:00
Sergey Biryukov	69bbdc4022	Posts, Post Types: Update, not delete the `page_for_posts` option in `_reset_front_page_settings_for_post()` when a linked page is deleted or trashed. Props diddledan. Fixes #46850. Built from https://develop.svn.wordpress.org/trunk@45746 git-svn-id: http://core.svn.wordpress.org/trunk@45557 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-05 07:44:55 +00:00
Gary Pendergast	41dc3e8d39	Build Tools: Add a WordPress Development Environment. This commit adds the first iteration of a Docker-based config for setting up a local WordPress development environment. Props pento, noisysocks, mcsf, pbearne, isabel_brison. See #47767. Built from https://develop.svn.wordpress.org/trunk@45745 git-svn-id: http://core.svn.wordpress.org/trunk@45556 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-05 07:10:56 +00:00
Sergey Biryukov	545157d30d	Posts, Post Types: Revert unintended change from [45742]. See #46503. Built from https://develop.svn.wordpress.org/trunk@45744 git-svn-id: http://core.svn.wordpress.org/trunk@45555 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-04 14:44:55 +00:00
Sergey Biryukov	e8cd892ba4	Administration: Display a warning at the top of "All Settings" screen. Props zodiac1978, donmhico, pixolin. Fixes #47718. Built from https://develop.svn.wordpress.org/trunk@45743 git-svn-id: http://core.svn.wordpress.org/trunk@45554 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-04 13:03:55 +00:00
Sergey Biryukov	9967a3e030	Docs: Add missing description for `$post` global. Props immeet94. Fixes #46503. See #47110. Built from https://develop.svn.wordpress.org/trunk@45742 git-svn-id: http://core.svn.wordpress.org/trunk@45553 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-04 12:28:56 +00:00
Sergey Biryukov	0cf1235477	Docs: Remove incorrect `@return` tags in `comment_reply_link()` and `post_reply_link()` DocBlocks. Props atachibana. Fixes #47826. Built from https://develop.svn.wordpress.org/trunk@45741 git-svn-id: http://core.svn.wordpress.org/trunk@45552 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-04 02:20:55 +00:00
Sergey Biryukov	6da93732e7	Docs: Add missing description for `$current_screen` global. Props mukesh27. Fixes #45604. See #47110. Built from https://develop.svn.wordpress.org/trunk@45740 git-svn-id: http://core.svn.wordpress.org/trunk@45551 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-04 02:03:55 +00:00
Sergey Biryukov	7f7480cb2a	Docs: Add missing description for `$wp_query` and `$wp_the_query` globals. Props mukesh27. See #45604, #47110. Built from https://develop.svn.wordpress.org/trunk@45739 git-svn-id: http://core.svn.wordpress.org/trunk@45550 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-04 01:59:56 +00:00
Sergey Biryukov	77a31e6875	Docs: Add missing description for `$wp_locale_switcher` global. See #45604, #47110. Built from https://develop.svn.wordpress.org/trunk@45738 git-svn-id: http://core.svn.wordpress.org/trunk@45549 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-04 01:47:55 +00:00
Sergey Biryukov	e0311b76c7	Docs: Add missing description for `$wp_locale` global. Props mukesh27. See #45604, #47110. Built from https://develop.svn.wordpress.org/trunk@45737 git-svn-id: http://core.svn.wordpress.org/trunk@45548 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-04 01:46:55 +00:00
Sergey Biryukov	ea606165a5	Docs: Add missing description for `$wp` global. See #45604, #47110. Built from https://develop.svn.wordpress.org/trunk@45736 git-svn-id: http://core.svn.wordpress.org/trunk@45547 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-04 01:28:55 +00:00
Sergey Biryukov	b1e34ccc1f	Docs: Add missing description for `$wp_rewrite` global. See #45604, #47110. Built from https://develop.svn.wordpress.org/trunk@45735 git-svn-id: http://core.svn.wordpress.org/trunk@45546 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-04 01:19:56 +00:00
Sergey Biryukov	29b072e706	Docs: Add missing description for `$wpdb`, `$wp_db_version`, and `$wp_current_db_version` globals. Props mukesh27, utsav72640, immeet94, SergeyBiryukov. See #45604. Built from https://develop.svn.wordpress.org/trunk@45734 git-svn-id: http://core.svn.wordpress.org/trunk@45545 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-04 01:12:56 +00:00
Sergey Biryukov	702ee129ad	Docs: Fix typo in a comment in `WP_Site_Health::get_test_theme_version()`. See #47110. Built from https://develop.svn.wordpress.org/trunk@45733 git-svn-id: http://core.svn.wordpress.org/trunk@45544 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-04 00:48:56 +00:00
Sergey Biryukov	fd83290995	Site Health: If `WP_DEFAULT_THEME` doesn't exist, use `WP_Theme::get_core_default_theme()` as a fallback. Props ajayghaghretiya1, juliobox, SergeyBiryukov. Fixes #47299. Built from https://develop.svn.wordpress.org/trunk@45732 git-svn-id: http://core.svn.wordpress.org/trunk@45543 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-04 00:02:55 +00:00
Sergey Biryukov	7dbc4d28e5	Script Loader: Send a 400 Bad Request status code in `load-scripts.php` and `load-styles.php` if the required `load[]` parameter is not set. Props compilenix. Fixes #44108. Built from https://develop.svn.wordpress.org/trunk@45731 git-svn-id: http://core.svn.wordpress.org/trunk@45542 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-03 22:17:57 +00:00
Aaron Jorbin	c377191858	PHP 7.4 compatibility fix / accessing arrays/string using curly brace syntax PHP used to allow both square brackets and curly braces to be used interchangeably for accessing array elements and string offsets. The curly bracket syntax is only allowed in a limited set of cases and can be confusing for people not used to it. PHP 7.4 will deprecate the curly brace syntax for accessing array elements and string offsets and it is expected that support will be completely removed in PHP 8.0. Ref: https://wiki.php.net/rfc/deprecate_curly_braces_array_access See #47751. Props jrf. Built from https://develop.svn.wordpress.org/trunk@45730 git-svn-id: http://core.svn.wordpress.org/trunk@45541 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-03 20:21:55 +00:00
Andrea Fercia	b853e21bf9	Accessibility: Improve the differences between revisions. Color alone is not sufficient to visually communicate differences. - adds `plus` and `minus` icons to the changed lines - adds visually hidden text: `Added`, `Deleted`, and `Unchanged` to clarify the differences to assistive technologies users Props birgire, audrasjb, kjellr, adamsilverstein. Fixes #43532. Built from https://develop.svn.wordpress.org/trunk@45729 git-svn-id: http://core.svn.wordpress.org/trunk@45540 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-03 15:46:54 +00:00
Andrea Fercia	cbd6b7b5bc	Accessibility: Remove title attributes from the Meta widget. - removes the `Powered by WordPress, state-of-the-art semantic personal publishing platform.` title attribute - removes the title attribute from the abbreviations: contrary to a common belief, title attributes on abbreviations are only available to a minority of users, see https://developer.paciellogroup.com/blog/2019/03/short-note-the-abbreviation-appreciation-society/ - changes the term `RSS` to `feed`, as `RSS` is a technical term not all users are supposed to be familiar with - improves the `widget_meta_poweredby` filter documentation Props nishitlangaliya, chetan200891, audrasjb. See #46980, #24766. Fixes #46978. Built from https://develop.svn.wordpress.org/trunk@45728 git-svn-id: http://core.svn.wordpress.org/trunk@45539 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-03 13:28:57 +00:00
Andrea Fercia	7b45746001	Menus: Fix the Custom Links text fallback. When adding a Custom Link and leaving the "Link Text" field empty, WordPress used to set a default fallback text: "Menu Item". The changes in [36379] broke this behavior making the fallback text: ` (Pending)`, with a leading space. Pending major refactoring of the Menus page (which is going to use a block-based user interface) this change just restores the original behavior by adding the fallback text to the related AJAX response. Props christophherr, Fencer04, thakkarhardik, backermann1978, audrasjb. Fixes #38415. Built from https://develop.svn.wordpress.org/trunk@45727 git-svn-id: http://core.svn.wordpress.org/trunk@45538 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-03 12:19:56 +00:00
Andrea Fercia	2d60076e77	Accessibility: Improve the way emojis are announced by screen readers. Adds an ARIA `role="img"` to the emojis markup in the front end. While the ARIA role is technically redundant, it helps Safari and VoiceOver to properly announce the emojis as "image". Without the role, they announce a generic "group" role. Tested with Safari 12.1.1 / VoiceOver 9. Props pento. See #37486. Built from https://develop.svn.wordpress.org/trunk@45726 git-svn-id: http://core.svn.wordpress.org/trunk@45537 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-03 11:53:56 +00:00
Andrea Fercia	9228eeb47b	Accessibility: Fix the `alt` attribute of the Gallery images within the Classic Editor. Passes the images `alt` attribute value to the Gallery template used within the Classic Editor. Props yarnboy, wpboss. Fixes #47687. Built from https://develop.svn.wordpress.org/trunk@45725 git-svn-id: http://core.svn.wordpress.org/trunk@45536 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-03 11:36:53 +00:00
Sergey Biryukov	76f482de43	Posts, Post Types: Check the result of `wp_update_post()` in `wp_trash_post()` and `wp_untrash_post()`. Props abhijitrakas, manzoorwani.jk, siliconforks. Fixes #47773. Built from https://develop.svn.wordpress.org/trunk@45724 git-svn-id: http://core.svn.wordpress.org/trunk@45535 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-03 03:47:54 +00:00
Sergey Biryukov	c26f1c5d90	Taxonomy: Fix deprecated calls to `get_terms()`. The taxonomy should be passed as part of `$args`, rather than as its own argument. Props sgastard, mukesh27, SergeyBiryukov. Fixes #47819. Built from https://develop.svn.wordpress.org/trunk@45723 git-svn-id: http://core.svn.wordpress.org/trunk@45534 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-03 03:35:56 +00:00
Andrea Fercia	60431f3c53	Customize: Make the color picker close when clicking on the empty area on the right. Props monikarao. Fixes #47693. Built from https://develop.svn.wordpress.org/trunk@45722 git-svn-id: http://core.svn.wordpress.org/trunk@45533 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-02 17:09:57 +00:00
Sergey Biryukov	ad46ef7c06	Twenty Thirteen: Make `twentythirteen_author_bio_template()` use author templates if exist, fall back to regular template hierarchy otherwise. See #32096. Built from https://develop.svn.wordpress.org/trunk@45721 git-svn-id: http://core.svn.wordpress.org/trunk@45532 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-02 03:09:55 +00:00
Sergey Biryukov	b900e22629	Twenty Fifteen: Make `twentyfifteen_author_bio_template()` use author templates if exist, fall back to regular template hierarchy otherwise. See #32096. Built from https://develop.svn.wordpress.org/trunk@45720 git-svn-id: http://core.svn.wordpress.org/trunk@45531 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-02 03:08:55 +00:00
Sergey Biryukov	e2ea3f7f30	Twenty Thirteen: Prevent `author-bio.php` partial template from interfering with rendering an author archive of a user with the `bio` username. Props rclations, ianbelanger, lordlod, SergeyBiryukov. Fixes #32096. Built from https://develop.svn.wordpress.org/trunk@45719 git-svn-id: http://core.svn.wordpress.org/trunk@45530 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-02 02:34:52 +00:00
Sergey Biryukov	97f28973da	Twenty Fifteen: Prevent `author-bio.php` partial template from interfering with rendering an author archive of a user with the `bio` username. Props rclations, ianbelanger, lordlod, SergeyBiryukov. See #32096. Built from https://develop.svn.wordpress.org/trunk@45718 git-svn-id: http://core.svn.wordpress.org/trunk@45529 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-02 02:33:57 +00:00
Sergey Biryukov	f6770efd94	Users: Clean user cache in `check_password_reset_key()` tests. Props davidbaumwald, spacedmonkey. See #45845. Built from https://develop.svn.wordpress.org/trunk@45717 git-svn-id: http://core.svn.wordpress.org/trunk@45528 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-01 19:54:55 +00:00
Sergey Biryukov	65420d3c7a	Users: Replace raw SQL query in `check_password_reset_key()` with `get_user_by()`. Props davidbaumwald, iworks, spacedmonkey. Fixes #45845. Built from https://develop.svn.wordpress.org/trunk@45716 git-svn-id: http://core.svn.wordpress.org/trunk@45527 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-01 19:19:55 +00:00
Sergey Biryukov	ee5e044a2a	Users: Use `clean_user_cache()` in `wp_insert_user()`, `wp_update_user()`, `wp_set_password()`, `add_user_to_blog()`. Props spacedmonkey. Fixes #47021. Built from https://develop.svn.wordpress.org/trunk@45715 git-svn-id: http://core.svn.wordpress.org/trunk@45526 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-01 17:49:57 +00:00
Sergey Biryukov	75857aa857	Users: Use `wp_update_user()` in `get_password_reset_key()`. Props jayswadas, spacedmonkey, donmhico, SergeyBiryukov. Fixes #45746. Built from https://develop.svn.wordpress.org/trunk@45714 git-svn-id: http://core.svn.wordpress.org/trunk@45525 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-01 17:25:55 +00:00
Sergey Biryukov	f6189321e1	Users: Reorganize `user_nicename`, `user_url`, `user_registered` setting in `wp_insert_user()` for consistency with the order or fields in the database. See #45746. Built from https://develop.svn.wordpress.org/trunk@45713 git-svn-id: http://core.svn.wordpress.org/trunk@45524 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-01 17:13:57 +00:00
Sergey Biryukov	4a6461dcc2	Users: Use `get_password_reset_key()` in `wp_new_user_notification()`. Props mrasharirfan, spacedmonkey. Fixes #45745. Built from https://develop.svn.wordpress.org/trunk@45712 git-svn-id: http://core.svn.wordpress.org/trunk@45523 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-01 15:30:58 +00:00
Sergey Biryukov	6623a824d0	Taxonomy: Correct some strict comparisons after [45710]. See #47573. Built from https://develop.svn.wordpress.org/trunk@45711 git-svn-id: http://core.svn.wordpress.org/trunk@45522 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-01 15:04:56 +00:00
Sergey Biryukov	3e1126d940	Coding Standards: Use strict comparison in `wp-includes/taxonomy.php`. Props andizer, SergeyBiryukov. Fixes #47573. Built from https://develop.svn.wordpress.org/trunk@45710 git-svn-id: http://core.svn.wordpress.org/trunk@45521 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-01 13:45:56 +00:00

... 3 4 5 6 7 ...

14036 Commits