Commit Graph

30533 Commits

Author SHA1 Message Date
Andrew Nacin
2166b4a6c1 JSHint: Use 'global' rather than 'globals' for inline configuration.
Don't declare a global already listed in .jshintrc.

props johnjamesjacoby.
fixes #33021.

Built from https://develop.svn.wordpress.org/trunk@33324


git-svn-id: http://core.svn.wordpress.org/trunk@33296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-19 17:09:26 +00:00
Weston Ruter
910092531b Customizer: Indicate when there are no nav menu items available for a given type.
Props celloexpressions, valendesigns, rittesh.patel.
Fixes #32810.

Built from https://develop.svn.wordpress.org/trunk@33323


git-svn-id: http://core.svn.wordpress.org/trunk@33295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-19 00:06:24 +00:00
Weston Ruter
afd7a8e836 Customizer: Finish unit tests for nav menus.
Removes object_type restriction to allow for future extensibility. Refactors some methods to improve testability. Includes new tests for Ajax requests.

Fixes #32687.
Props valendesigns, welcher, westonruter.

Built from https://develop.svn.wordpress.org/trunk@33322


git-svn-id: http://core.svn.wordpress.org/trunk@33294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-18 23:20:25 +00:00
Weston Ruter
a36d50fbd0 Customizer: Prevent wp-a11y from being needlessly enqueued in the customizer preview.
Reduces the number of live regions that screen readers have to deal with.

Fixes #33001.

Built from https://develop.svn.wordpress.org/trunk@33321


git-svn-id: http://core.svn.wordpress.org/trunk@33293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-18 17:10:25 +00:00
Ella Iseulde Van Dorpe
e9b6d25bcd Editor: word count: count astrals as one character
This makes sure an emoji, for example, is counted as one character.

See #30966.

Built from https://develop.svn.wordpress.org/trunk@33320


git-svn-id: http://core.svn.wordpress.org/trunk@33292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-18 11:42:25 +00:00
Drew Jaynes
0729c70e03 Update the description for get_the_category() with helpful information for the proper function to use for custom taxonomies.
Also adds a missing return description.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@33318


git-svn-id: http://core.svn.wordpress.org/trunk@33290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-17 22:58:25 +00:00
Weston Ruter
909dde9ce5 Customizer: Move "Menu options" heading outside of a nav menu auto-add control's label.
Standardizes capitalization. Amends [33189].

Props valendesigns.
Fixes #32820.

Built from https://develop.svn.wordpress.org/trunk@33317


git-svn-id: http://core.svn.wordpress.org/trunk@33289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-17 22:42:24 +00:00
Gary Pendergast
a6cb4b293c WPDB: ::strip_text_from_query() doesn't pass a length to ::strip_invalid_text(), which was causing queries to fail when they contained characters that needed to be sanity checked by MySQL.
Props dd32, mdawaffe, pento.

Fixes #32279.


Built from https://develop.svn.wordpress.org/trunk@33310


git-svn-id: http://core.svn.wordpress.org/trunk@33282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-17 07:07:26 +00:00
Gary Pendergast
6759a210ca WPDB: Remove some of the complexities in ::strip_invalid_text() associated with switching character sets between queries. Instead of trying to dynamically change connection character sets, we now rely on the value of ::charset. This also fixes the case where queries were being blocked when DB_CHARSET was utf8, but the column character set was non-utf8.
Fixes #32165.


Built from https://develop.svn.wordpress.org/trunk@33308


git-svn-id: http://core.svn.wordpress.org/trunk@33280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-17 06:34:26 +00:00
Andrew Ozz
f9980c793c wpLink: fix vertical alignment of the fields labels.
Part props daniluk4000. Fixes #32829.
Built from https://develop.svn.wordpress.org/trunk@33300


git-svn-id: http://core.svn.wordpress.org/trunk@33272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-16 23:58:25 +00:00
Ella Iseulde Van Dorpe
f00d1e63f1 Editor: word count: exclude shortcodes
Props desaiuditd, adamsilverstein, azaozz and iseulde.
Fixes #27386. See #30966.

Built from https://develop.svn.wordpress.org/trunk@33299


git-svn-id: http://core.svn.wordpress.org/trunk@33271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-16 21:09:26 +00:00
Ella Iseulde Van Dorpe
dac985cdc4 Editor: Add Media should be a button
Props afercia.
Fixes #32969.

Built from https://develop.svn.wordpress.org/trunk@33298


git-svn-id: http://core.svn.wordpress.org/trunk@33270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-16 19:38:23 +00:00
Helen Hou-Sandí
e9f33a90b3 Customizer: Ensure consistent margins in sections.
Since the customizer dynamically changes, `nth-child` selectors are not always a great idea.

props afercia.
fixes #32902.

Built from https://develop.svn.wordpress.org/trunk@33297


git-svn-id: http://core.svn.wordpress.org/trunk@33269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-16 19:15:27 +00:00
Boone Gorges
0a24f1bebf Improve function description for wp_transition_post_status().
The documentation should make it clear that the function does not modify the
post object in the database, but only fires hooks related to the transition.

Props AramZS.
Fixes #33014.
Built from https://develop.svn.wordpress.org/trunk@33296


git-svn-id: http://core.svn.wordpress.org/trunk@33268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-16 14:35:26 +00:00
Ella Iseulde Van Dorpe
add46de183 Editor: word count: remove redundant script enqueuing
It is now a dependency of `post`.

Part props johnjamesjacoby.
Fixes #31766. See #30966.


Built from https://develop.svn.wordpress.org/trunk@33295


git-svn-id: http://core.svn.wordpress.org/trunk@33267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-16 12:41:25 +00:00
Ella Iseulde Van Dorpe
24594de8d4 TinyMCE: inline toolbar: fix memory leaks
Part props ungestaltbar.
Fixes #32873.

Built from https://develop.svn.wordpress.org/trunk@33294


git-svn-id: http://core.svn.wordpress.org/trunk@33266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-16 11:11:24 +00:00
Ella Iseulde Van Dorpe
54b5b3c808 Editor: DFW: hide udate message
Props miqrogroove.
Fixes #32674.

Built from https://develop.svn.wordpress.org/trunk@33293


git-svn-id: http://core.svn.wordpress.org/trunk@33265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-16 10:38:25 +00:00
Ella Iseulde Van Dorpe
e098c0e9ee Editor: word count: exclude more characters
Also only exclude these characters for the `words` type. They should be counted for other types.
Add the ASCIIOnly option to the uglify config to preserve escaped unicode characters.

See #30966. Fixes #27391.


Built from https://develop.svn.wordpress.org/trunk@33292


git-svn-id: http://core.svn.wordpress.org/trunk@33264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-16 09:45:26 +00:00
Ella Iseulde Van Dorpe
f7f834703f Editor: word count: update translator message
See #30966.

Built from https://develop.svn.wordpress.org/trunk@33291


git-svn-id: http://core.svn.wordpress.org/trunk@33263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 23:52:24 +00:00
Ella Iseulde Van Dorpe
bbccb9ca6b Editor: word count: add all type
This type will count all characters including spaces.

See #30966.

Built from https://develop.svn.wordpress.org/trunk@33290


git-svn-id: http://core.svn.wordpress.org/trunk@33262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 23:48:24 +00:00
Ella Iseulde Van Dorpe
25a9a1873c TinyMCE: fix visual regressions (2)
See #32801.

Built from https://develop.svn.wordpress.org/trunk@33289


git-svn-id: http://core.svn.wordpress.org/trunk@33261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 23:35:24 +00:00
Konstantin Obenland
9c61c058e3 4.3-beta3-33288
Built from https://develop.svn.wordpress.org/trunk@33288


git-svn-id: http://core.svn.wordpress.org/trunk@33260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 21:51:25 +00:00
Konstantin Obenland
97b844b172 4.3-beta3
Built from https://develop.svn.wordpress.org/trunk@33287


git-svn-id: http://core.svn.wordpress.org/trunk@33259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 21:43:24 +00:00
Andrew Ozz
7946fbad27 TinyMCE, keyboard shortcuts help: make the popup wider to easily accommodate translations.
Part props ocean90. See #31441;
Built from https://develop.svn.wordpress.org/trunk@33286


git-svn-id: http://core.svn.wordpress.org/trunk@33258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 21:34:25 +00:00
Ella Iseulde Van Dorpe
952564e84b TinyMCE: fix visual regressions
See #32801.

Built from https://develop.svn.wordpress.org/trunk@33285


git-svn-id: http://core.svn.wordpress.org/trunk@33257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 21:31:24 +00:00
Helen Hou-Sandí
59ad07be48 Toolbar: Ensure icons are colored correctly in alternate schemes.
props ryelle.
fixes #32931. see #29906.

Built from https://develop.svn.wordpress.org/trunk@33284


git-svn-id: http://core.svn.wordpress.org/trunk@33256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 20:14:25 +00:00
Weston Ruter
0f37c66077 Customizer: Defer updating nav menu item tabIndex attributes until pane is reflowed.
Introduces `pane-contents-reflowed` Customizer event.

Props valendesigns, westonruter.
Fixes #32943.

Built from https://develop.svn.wordpress.org/trunk@33283


git-svn-id: http://core.svn.wordpress.org/trunk@33255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 20:05:25 +00:00
Weston Ruter
8c9eb43d47 Customizer: Hide the transport list when it's empty, especially for screen readers.
Also prevent invalid markup for `.customize-section-description`.

Props valendesigns.
Fixes #32843.

Built from https://develop.svn.wordpress.org/trunk@33282


git-svn-id: http://core.svn.wordpress.org/trunk@33254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 19:59:25 +00:00
Konstantin Obenland
3271513442 Feeds: Revert [32765] because of objections raised in #4575.
Built from https://develop.svn.wordpress.org/trunk@33281


git-svn-id: http://core.svn.wordpress.org/trunk@33253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 19:58:24 +00:00
Konstantin Obenland
2883bbbb68 Customize: Provide a default way to save cropped images.
Allows plugins and themes to use `WP_Customize_Cropped_Image_Control` without
having to define their own way of saving the cropped image.

Props celloexpressions for initial patch.
Fixes #29211.


Built from https://develop.svn.wordpress.org/trunk@33280


git-svn-id: http://core.svn.wordpress.org/trunk@33252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 19:54:25 +00:00
Weston Ruter
4cb73cf347 Customizer: Fix element focus after menu item is deleted for keyboard accessibility.
Also restores box shadow on focus.

Props valendesigns.
Fixes #32740.

Built from https://develop.svn.wordpress.org/trunk@33279


git-svn-id: http://core.svn.wordpress.org/trunk@33251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 18:44:25 +00:00
Konstantin Obenland
080a4adfba Properly clean up header image data when the attachment is deleted.
Props CreativeInfusion.
Fixes #33005.


Built from https://develop.svn.wordpress.org/trunk@33278


git-svn-id: http://core.svn.wordpress.org/trunk@33250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 16:28:25 +00:00
Gary Pendergast
f28b182a7c WPDB: When checking that text isn't too long to insert into a column, LONGTEXT columns could fail, as their length is longer than PHP_INT_MAX. Treating their length as a float instead of an int fixes this.
See #32165.


Built from https://develop.svn.wordpress.org/trunk@33276


git-svn-id: http://core.svn.wordpress.org/trunk@33248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 04:33:25 +00:00
Konstantin Obenland
f75fe6980e Update password meter to match new color guidelines.
See: https://make.wordpress.org/design/handbook/foundations/colors/

Props melchoyce.
Fixes #32986.


Built from https://develop.svn.wordpress.org/trunk@33275


git-svn-id: http://core.svn.wordpress.org/trunk@33247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 00:12:24 +00:00
Drew Jaynes
cf7e13813f Docs: Update the DocBlock descriptions for a variety of template functions to better reflect that the dynamic $type_template hook can be used to filter the template path.
It's important to reference the actual dynamic hook name instead of an alias for purposes of auto-linking in the Code Reference.

Affects the docs for:
* `get_index_template()`
* `get_404_template()`
* `get_archive_template()`
* `get_post_type_archive_template()`
* `get_author_template()`
* `get_category_template()`
* `get_tag_template()`
* `get_taxonomy_template()`
* `get_date_template()`
* `get_home_template()`
* `get_page_template()`
* `get_paged_template()`
* `get_search_template()`
* `get_single_template()`
* `get_singular_template()`
* `get_attachment_template()`

See #32246.

Built from https://develop.svn.wordpress.org/trunk@33274


git-svn-id: http://core.svn.wordpress.org/trunk@33246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 22:27:24 +00:00
Drew Jaynes
f7f4a97d07 Docs: Clarify the hook docs for the {$type}_template hook to mention that non-alphanumeric characters delimiting words will also be removed from the passed $type parameter.
Also remove a now-unnecessary inline `@see` tag from the return description.

See #32246. See #32989.

Built from https://develop.svn.wordpress.org/trunk@33273


git-svn-id: http://core.svn.wordpress.org/trunk@33245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 22:12:25 +00:00
Drew Jaynes
84419a51b8 Update the descriptions for get_front_page_template() and get_comments_popup_template() to reference the correct dynamic hook names.
Part props @birgire.

Fixes #32989. See #32246.

Built from https://develop.svn.wordpress.org/trunk@33272


git-svn-id: http://core.svn.wordpress.org/trunk@33244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 21:59:25 +00:00
Scott Taylor
7c218ab59a After [33148]:
Don't nest `esc_attr()` and `htmlspecialchars()` when escaping the post title on the edit post screen.

Unrevert parts of [32851] and [32850].

Adds/alters unit tests.

Props miqrogroove.
Fixes #17780.

Built from https://develop.svn.wordpress.org/trunk@33271


git-svn-id: http://core.svn.wordpress.org/trunk@33243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 17:56:26 +00:00
Scott Taylor
4d34e37311 List Tables:
* In `->handle_row_actions()`, bail immediately if `$primary` and `$column_name` do not match. Saves us a nesting level and avoids declaring code that is unusable.
* In `WP_List_Table::single_row_columns()`, allow `_column_{$name}` to be called dynamically by core to avoid having to override the entirety of `->single_row_columns()` in `WP_MS_Users_List_Table` and `WP_Posts_List_Table`
* In `WP_MS_Sites_List_Table`, `id` is not a column.

Props wonderboymusic, paulwilde.
Fixes #29881.

Built from https://develop.svn.wordpress.org/trunk@33270


git-svn-id: http://core.svn.wordpress.org/trunk@33242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 17:47:24 +00:00
Konstantin Obenland
4f94d3a969 Media: Don't indent action links if there is no media icon.
See #32254.


Built from https://develop.svn.wordpress.org/trunk@33269


git-svn-id: http://core.svn.wordpress.org/trunk@33241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 17:46:24 +00:00
Konstantin Obenland
2a0ddf8523 Media: Reduce link noise between icons and titles in list view.
Props afercia.
Fixes #32254.


Built from https://develop.svn.wordpress.org/trunk@33268


git-svn-id: http://core.svn.wordpress.org/trunk@33240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 17:24:26 +00:00
Scott Taylor
9de28a2e04 Monkey patch MediaElement to include a PR that restores responsive videos in Firefox:
https://github.com/johndyer/mediaelement/pull/1531

Props joemcgill.
Fixes #32722.

Built from https://develop.svn.wordpress.org/trunk@33267


git-svn-id: http://core.svn.wordpress.org/trunk@33239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 16:30:25 +00:00
Helen Hou-Sandí
4182df24f8 List tables: Even more robust fallback for the primary column.
Since `WP_List_Table::get_default_primary_column()` can be overridden in a subclass and columns can be further filtered, it is possible to end up with a primary column that no longer exists. This is particularly evident in list tables for custom post types that have been altered via filter.

props ocean90.
fixes #32996.

Built from https://develop.svn.wordpress.org/trunk@33266


git-svn-id: http://core.svn.wordpress.org/trunk@33238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 16:18:25 +00:00
Konstantin Obenland
1f18ef86a3 Login: Reflect new password flow in registration form.
Props Ipstenu.
Fixes #32428.


Built from https://develop.svn.wordpress.org/trunk@33265


git-svn-id: http://core.svn.wordpress.org/trunk@33237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 16:08:25 +00:00
Konstantin Obenland
88e669b6db Use default parameter when getting the default avatar type.
Props johnjamesjacoby.
Fixes #32997.

Built from https://develop.svn.wordpress.org/trunk@33264


git-svn-id: http://core.svn.wordpress.org/trunk@33236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 15:39:25 +00:00
Konstantin Obenland
542e01162f Media: Remove post_type variable, unused since [32676].
Fixes #32948.

Built from https://develop.svn.wordpress.org/trunk@33263


git-svn-id: http://core.svn.wordpress.org/trunk@33235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 15:06:25 +00:00
Boone Gorges
28ce0320e3 In wp_unique_post_slug(), only prevent date archive conflicts when the slug is being changed.
This prevents existing posts with numeric slugs from having their permalinks
changed on update.

Fixes #5305.
Built from https://develop.svn.wordpress.org/trunk@33262


git-svn-id: http://core.svn.wordpress.org/trunk@33234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 12:28:48 +00:00
Boone Gorges
5a1618b497 When creating a new post with an empty post_name and post_title, don't generate a post_name that conflicts with a date archive permalink.
See #5305.
Built from https://develop.svn.wordpress.org/trunk@33261


git-svn-id: http://core.svn.wordpress.org/trunk@33233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 12:28:24 +00:00
Gary Pendergast
4ee0da1798 WPDB: When extracting the table name from a query, we had a 1000 character limit on the SQL string that would be searched. This was a hangover from when the code was imported from HyperDB, and isn't appropriate for Core, where a wider range of queries are likely to be run.
Fixes #32763


Built from https://develop.svn.wordpress.org/trunk@33259


git-svn-id: http://core.svn.wordpress.org/trunk@33231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 10:19:24 +00:00
Dion Hulse
43077a6ef8 Updates: When performing an ajax plugin update, rely upon wp_update_plugins() to check the contents of the transient and return early if no request needs to be made.
This works around a bug where custom update handlers are injecting an update into an empty transient, malforming the transient and causing update failures.
Fixes #32198 for trunk

Built from https://develop.svn.wordpress.org/trunk@33257


git-svn-id: http://core.svn.wordpress.org/trunk@33229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 08:01:25 +00:00