Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-12-29 12:37:57 +01:00
Code Issues Projects Releases Wiki Activity
41,041 Commits 50 Branches 749 Tags 806 MiB
23696bb074
Commit Graph

41041 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
K. Adam White
23696bb074 REST API: Match REST API routes on namespace before performing regex checks. 
Rule out groups of API endpoints by simple namespace string comparison to reduce the number of regex checks necessary when matching a route.

Props TimothyBlynJacobs.
Fixes #48530.

Built from https://develop.svn.wordpress.org/trunk@47260


git-svn-id: http://core.svn.wordpress.org/trunk@47060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 03:22:05 +00:00
Andrew Ozz
3d126b2dc7 Media: Improve wording for error message on failed post-processing of uploaded images. 
Props eclev91, desrosj, antpb, azaozz.
Fixes #49280.
Built from https://develop.svn.wordpress.org/trunk@47259


git-svn-id: http://core.svn.wordpress.org/trunk@47059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 03:20:06 +00:00
K. Adam White
25d8f7240e REST API: List all core theme feature support details in /themes endpoint response. 
Fully list which first-party core theme features are supported in the /themes endpoint response. This brings the REST API themes controller's response more in line with the output of get_theme_support().

Props adamboro, apieschel, koke, spacedmonkey, TimothyBlynJacobs.
See #49037.

Built from https://develop.svn.wordpress.org/trunk@47258


git-svn-id: http://core.svn.wordpress.org/trunk@47058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 02:00:07 +00:00
Sergey Biryukov
9614434049 Media: Improve the preview of transparent images in Image widget by using CSS3 to show a checkered background. 
Props bahia0019.
Fixes #49237.
Built from https://develop.svn.wordpress.org/trunk@47257


git-svn-id: http://core.svn.wordpress.org/trunk@47057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 01:47:06 +00:00
Sergey Biryukov
5d00e8f78b Administration: Move .has-row-actions class in Recent Comments dashboard widget next to .dashboard-comment-wrap, for consistency. 
Follow-up to [47255].

See #42938.
Built from https://develop.svn.wordpress.org/trunk@47256


git-svn-id: http://core.svn.wordpress.org/trunk@47056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 01:21:05 +00:00
Sergey Biryukov
8c2fb2148b Administration: Remove a blank space in the Recent Comments dashboard widget if avatars are disabled on Discussion Settings screen. 
Props Marius84, shital-patel, GaryJ, ianbelanger, sgastard, lgrev01, donmhico, garrett-eclipse, audrasjb, SergeyBiryukov.
Fixes #42938.
Built from https://develop.svn.wordpress.org/trunk@47255


git-svn-id: http://core.svn.wordpress.org/trunk@47055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 01:17:06 +00:00
Sergey Biryukov
055af2b506 Site Health: Improve the wording for PHP update recommendations. 
Props Clorith, grafruessel, sathyapulse, wpgurudev, garrett-eclipse, marybaum, xkon, SergeyBiryukov.
Fixes #48716.
Built from https://develop.svn.wordpress.org/trunk@47254


git-svn-id: http://core.svn.wordpress.org/trunk@47054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 00:41:05 +00:00
Sergey Biryukov
ca3366926a Docs: Improve documentation for tests/phpunit/includes/spy-rest-server.php. 
Props andizer.
Fixes #47567.
Built from https://develop.svn.wordpress.org/trunk@47253


git-svn-id: http://core.svn.wordpress.org/trunk@47053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 00:20:07 +00:00
Sergey Biryukov
984d1c60b5 Comments: Improve the appearance of the Status box on Edit Comment screen. 
This makes the box more consistent with the Publish meta box in classic editor.

Props birgire, nfmohit, melchoyce, afercia.
Fixes #43587.
Built from https://develop.svn.wordpress.org/trunk@47252


git-svn-id: http://core.svn.wordpress.org/trunk@47052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 00:06:04 +00:00
Sergey Biryukov
507d056b7e Media: In media_sideload_image(), store the original attachment URL in the _source_url post meta value. 
Props dshanske, joemcgill, antpb.
Fixes #48164.
Built from https://develop.svn.wordpress.org/trunk@47251


git-svn-id: http://core.svn.wordpress.org/trunk@47051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 23:47:04 +00:00
jorgefilipecosta
56906bcf59 Block Editor: Update WordPress Packages; Remove navigation block; Add social links block 
The following package versions were changed:
@wordpress/annotations: 1.11.0 -> 1.12.0
@wordpress/api-fetch: 3.10.0 -> 3.11.0
@wordpress/block-directory: 1.4.0 -> 1.5.0
@wordpress/block-editor: 3.6.0 -> 3.7.0
@wordpress/block-library: 2.13.0 -> 2.14.0
@wordpress/blocks: 6.11.0 -> 6.12.0
@wordpress/components: 9.1.0 -> 9.2.0
@wordpress/core-data: 2.11.0 -> 2.12.0
@wordpress/data: 4.13.0 -> 4.14.0
@wordpress/data-controls: 1.7.0 -> 1.8.0
@wordpress/e2e-test-utils: 4.2.0 -> 4.3.0
@wordpress/edit-post: 3.12.0 -> 3.13.0
@wordpress/editor: 9.11.0 -> 9.12.0
@wordpress/format-library: 1.13.0 -> 1.14.0
@wordpress/icons: 1.0.0 -> 1.1.0
@wordpress/keyboard-shortcuts: 1.0.0 -> 1.1.0
@wordpress/list-reusable-blocks: 1.12.0 -> 1.13.0
@wordpress/media-utils: 1.6.0 -> 1.7.0
@wordpress/notices: 1.12.0 -> 2.0.0
@wordpress/nux: 3.11.0 -> 3.12.0
@wordpress/plugins: 2.11.0 -> 2.12.0
@wordpress/primitives: 1.0.0 -> 1.1.0
@wordpress/rich-text: 3.11.0 -> 3.12.0
@wordpress/server-side-render: 1.7.0 -> 1.8.0
@wordpress/url: 2.10.0 -> 2.11.0
@wordpress/viewport: 2.12.0 -> 2.13.0
The navigation block inclusion was reverted.
The social links block was included.

Props gziolo, youknowriad, mcsf, noisysocks.
Fixes #49397.
Built from https://develop.svn.wordpress.org/trunk@47250


git-svn-id: http://core.svn.wordpress.org/trunk@47050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 22:33:27 +00:00
Sergey Biryukov
363191d8ee Docs: Improve documentation for the $attr parameter of wp_get_attachment_image(). 
Props juanfra, Mte90, DrewAPicture, joemcgill, SergeyBiryukov.
Fixes #36661.
Built from https://develop.svn.wordpress.org/trunk@47249


git-svn-id: http://core.svn.wordpress.org/trunk@47049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 22:03:07 +00:00
Sergey Biryukov
f8f24b49e6 Coding Standards: Fix JSHint issues in [47246]. 
See #44264.
Built from https://develop.svn.wordpress.org/trunk@47248


git-svn-id: http://core.svn.wordpress.org/trunk@47048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 21:38:08 +00:00
Sergey Biryukov
13922a3210 Privacy: Convert buttons to links visually in Privacy Export/Erasure "Next Steps" column. 
With a lot of export or erasure requests, the secondary buttons were becoming overwhelming when stacked on top of each other.

Props xkon, karmatosed.
Fixes #49323.
Built from https://develop.svn.wordpress.org/trunk@47247


git-svn-id: http://core.svn.wordpress.org/trunk@47047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 21:15:05 +00:00
Sergey Biryukov
5ddf97e142 Privacy: Give progress indication for export and erasure. 
This adds a progress indicator for "Download Personal Data" and "Erase Personal Data" row actions, which can take a while with a lot of data.

Props garrett-eclipse, allendav, dominic_ks, xkon, karmatosed, birgire.
Fixes #44264.
Built from https://develop.svn.wordpress.org/trunk@47246


git-svn-id: http://core.svn.wordpress.org/trunk@47046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 20:19:05 +00:00
Sergey Biryukov
3342aafe5e Privacy: Rename wp_get_user_request_data() to wp_get_user_request() for clarity; deprecate the old function. 
The function returns an instance of the `WP_User_Request` object itself, not its `$request_data` property.

Follow-up to [44606].

Props garrett-eclipse.
Fixes #46302.
Built from https://develop.svn.wordpress.org/trunk@47245


git-svn-id: http://core.svn.wordpress.org/trunk@47045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 19:57:05 +00:00
ianbelanger
99f402dc62 Bundled Themes: Twenty Twenty post navigation links outside of the container. 
Fixes a bug where the in-page pagination does not align within the inner container.

Props ataurr, audrasjb, mukesh27.
Fixes #48979.
Built from https://develop.svn.wordpress.org/trunk@47244


git-svn-id: http://core.svn.wordpress.org/trunk@47044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 19:25:05 +00:00
ianbelanger
598b2889a9 Bundled Themes: Twenty Twenty add WhatsApp to the social icon menu. 
This adds WhatsApp as an option in the social icon menu.

Props rryyaanndd, audrasjb.
Fixes #49098.
Built from https://develop.svn.wordpress.org/trunk@47243


git-svn-id: http://core.svn.wordpress.org/trunk@47043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 19:12:05 +00:00
Sergey Biryukov
762140cc6b Twenty Nineteen: Add the missing inc/helper-functions.php file. 
Follow-up to [47214].

Props kjellr, jffng.
Fixes #45984.
Built from https://develop.svn.wordpress.org/trunk@47242


git-svn-id: http://core.svn.wordpress.org/trunk@47042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 19:07:06 +00:00
ianbelanger
2b52ae5c1b Bundled Themes: Twenty Twenty Author Bio/Post Meta Width in Cover Template in Mobile. 
Fixes a bug where the author bio and post meta have no left or right padding in smaller viewports.

Props JarretC.
Fixes #49254.
Built from https://develop.svn.wordpress.org/trunk@47241


git-svn-id: http://core.svn.wordpress.org/trunk@47041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 18:25:07 +00:00
jorgefilipecosta
76e375434b Block Editor: Backport inclusion of new editor settings to the core. 
This commit includes in the core settings for the gradients theme API stabilized in https://github.com/WordPress/gutenberg/pull/20107, and for the image sizes required for the latest posts feature image https://github.com/WordPress/gutenberg/pull/17151/.

Props: youknowriad, ryelle.
Fixes #49389.
Built from https://develop.svn.wordpress.org/trunk@47240


git-svn-id: http://core.svn.wordpress.org/trunk@47040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 17:52:15 +00:00
TimothyBlynJacobs
7019add74e REST API: Add support for the REDIRECT_HTTP_AUTHORIZATION header. 
Previously the REST API did not account for server configurations where the Authorization header must be added using ModRewrite. This caused major DUX issues when trying to use custom authentication mechanisms.

Fixes #47077.
Props dshanske, cklosows.

Built from https://develop.svn.wordpress.org/trunk@47239


git-svn-id: http://core.svn.wordpress.org/trunk@47039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 16:08:16 +00:00
aduth
4bff827833 Script Loader: Add polyfill for window.URL, window.DOMRect. 
Pending block editor revisions for WordPress 5.4 will make use of `window.URL` and `window.DOMRect`. These are not available in Internet Explorer (or pre-Chromium Edge for `DOMRect`) and must be polyfilled to avoid script errors.

The changes make use of the existing polyfill pattern, and existing `polyfill-library` dependency. The dependency is bumped to the latest version, since the previous version did not include the `DOMRect` polyfill.

Props jorgefilipecosta.
Fixes #49360.

Built from https://develop.svn.wordpress.org/trunk@47238


git-svn-id: http://core.svn.wordpress.org/trunk@47038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 15:17:07 +00:00
Sergey Biryukov
c14f2b74c0 Privacy: Include session tokens in Personal Data Export. 
Session tokens contain an IP address and user agent.

Props garrett-eclipse, nickylimjj, lakenh, xkon, rconde.
Fixes #45889.
Built from https://develop.svn.wordpress.org/trunk@47237


git-svn-id: http://core.svn.wordpress.org/trunk@47037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 05:44:04 +00:00
Sergey Biryukov
346f505a75 Privacy: Include community-events-location user meta value in Personal Data Export. 
The value is used by the WordPress Events and News widget to show relevant WP community events.

The location information may include an IP address, location description, and latitude/longitude coordinates.

Props garrett-eclipse, coreymckrill, xkon.
Fixes #43921.
Built from https://develop.svn.wordpress.org/trunk@47236


git-svn-id: http://core.svn.wordpress.org/trunk@47036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 05:32:06 +00:00
Sergey Biryukov
d98fe66044 Site Health: Move the warning about WP_DEBUG_LOG being publicly accessible from "critical issues" to "recommended improvements" if the error log is outside of the WordPress directory. 
Props afragen, Clorith, miss_jwo, mikeschroder, kubiq, xkon.
Fixes #47985.
Built from https://develop.svn.wordpress.org/trunk@47235


git-svn-id: http://core.svn.wordpress.org/trunk@47035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 05:16:07 +00:00
Sergey Biryukov
4f151b577e Administration: Standardize "found in Trash" messages. 
Props Presskopp, audrasjb.
Fixes #38669.
Built from https://develop.svn.wordpress.org/trunk@47234


git-svn-id: http://core.svn.wordpress.org/trunk@47034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 04:57:06 +00:00
Sergey Biryukov
a6949956d1 Administration: Capitalize Trash consistently in various messages and comments. 
When used as a noun referring to the "virtual" place, `Trash` should be capitalized.

Props garrett-eclipse, aandrewdixon, Presskopp.
Fixes #45317.
Built from https://develop.svn.wordpress.org/trunk@47233


git-svn-id: http://core.svn.wordpress.org/trunk@47033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 04:12:07 +00:00
Sergey Biryukov
02ae343849 Login and Registration: Clarify the message on "Lost Password" screen. 
Props pbiron, Presskopp.
Fixes #49346.
Built from https://develop.svn.wordpress.org/trunk@47232


git-svn-id: http://core.svn.wordpress.org/trunk@47032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 03:50:05 +00:00
Sergey Biryukov
c1fb007ff3 Docs: Add documentation for globals in wp-settings.php. 
Props chinteshprajapati.
Fixes #46253.
Built from https://develop.svn.wordpress.org/trunk@47231


git-svn-id: http://core.svn.wordpress.org/trunk@47031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 03:34:05 +00:00
Sergey Biryukov
32edd58e4c Docs: Add descriptions for some globals: 
* `$wp_version`
* `$wp_local_package`
* `$required_php_version`
* `$required_mysql_version`

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47230


git-svn-id: http://core.svn.wordpress.org/trunk@47030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 03:30:06 +00:00
Andrew Ozz
e4f36258f9 Media: Ensure imgareaselect.js is not initialized twice for the same image. May happen when uploading an image into a post and then clicking on Edit Image. 
Fixes #49262.
Built from https://develop.svn.wordpress.org/trunk@47229


git-svn-id: http://core.svn.wordpress.org/trunk@47029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 02:54:05 +00:00
Sergey Biryukov
f13044b031 Editor: Add unique classes to .post-attributes-label-wrapper paragraphs for easier JS or CSS targeting. 
Props sathyapulse, sabernhardt, garrett-eclipse, noisysocks.
Fixes #44408.
Built from https://develop.svn.wordpress.org/trunk@47228


git-svn-id: http://core.svn.wordpress.org/trunk@47028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 02:29:06 +00:00
Sergey Biryukov
ddc8ddb294 Import: Remove "Blogroll" import option (for links in OPML format) from the list of popular importer plugins. 
Link Manager is disabled for new installations since WordPress 3.5, so core should not encourage importing links.

See #meta4706 for the corresponding WordPress.org API change.

Props Ipstenu, hareesh-pillai, DrewAPicture, nacin, karmatosed, dd32, garrett-eclipse.
Fixes #22994. See #21307.
Built from https://develop.svn.wordpress.org/trunk@47227


git-svn-id: http://core.svn.wordpress.org/trunk@47027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 02:12:06 +00:00
Sergey Biryukov
95edb66e53 Login and Registration: Use CSS animation instead of old JavaScript code for "shake" animation on login failure. 
Props markjaquith, valentinbora.
Fixes #48490.
Built from https://develop.svn.wordpress.org/trunk@47226


git-svn-id: http://core.svn.wordpress.org/trunk@47026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 01:52:04 +00:00
Sergey Biryukov
9bd75db1fc Build/Test Tools: Expose port 3306 of MySQL container. 
This only defines the container port to allow `docker-compose` to choose an ephemeral host port.

Props ocean90, peterwilsoncc.
Fixes #48281.
Built from https://develop.svn.wordpress.org/trunk@47225


git-svn-id: http://core.svn.wordpress.org/trunk@47025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-09 21:22:05 +00:00
TimothyBlynJacobs
5ecd61023a REST API: Introduce selective link embedding. 
Previously the _embed flag would embed all embeddable links in a response even if only a subset of the links were necessary. Now, a list of link relations can be passed in the _embed parameter to restrict the list of embedded objects.

Props rheinardkorf, adamsilverstein, jnylen0, cklosows, chrisvanpatten, TimothyBlynJacobs.
Fixes #39696.

Built from https://develop.svn.wordpress.org/trunk@47224


git-svn-id: http://core.svn.wordpress.org/trunk@47024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-09 20:54:05 +00:00
Aaron Jorbin
b21985f139 General: Fix HTML for get_calendar() 
The <tfoot> element was allowed to precede the <tbody> element in HTML 5. However, that was changed in HTML 5.1 and <tfoot> must now follow <tbody>.

This removes the tfooot and instead uses a nav element for navigation between months.

Fixes: #39763
Props: isabel_brison, Harry Milatz, audrasjb, abhijitrakas, SergeyBiryukov

Built from https://develop.svn.wordpress.org/trunk@47223


git-svn-id: http://core.svn.wordpress.org/trunk@47023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-09 20:44:04 +00:00
joedolson
61ce35440c Editor: Fix incorrect usage of ID attributes on custom fields. 
Repeated containers used for custom fields have duplicate ID attributes. Duplicate IDs are incorrect HTML, and will also cause unexpected results when trying to manipulate using JS. Duplicate IDs are changed to matching classes; CSS & JS updated to match. 

Props jankimoradiya, audrasjb, donmhico, afercia.
Fixes #46964.

Built from https://develop.svn.wordpress.org/trunk@47222


git-svn-id: http://core.svn.wordpress.org/trunk@47022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-09 19:41:07 +00:00
joedolson
1dbe25bc0a Toolbar: Load toolbar in wp_body_open when available. 
For accessibility, the visual appearance and source order should match. Moving the toolbar to load in the new hook `wp_body_open` (5.2) fixes a long-standing source order problem.

Props jankimoradiya, afercia, SergeyBiryukov, audrasjb, ocean90, xkon, dinhtungdu.
Fixes #47053.

Built from https://develop.svn.wordpress.org/trunk@47221


git-svn-id: http://core.svn.wordpress.org/trunk@47021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-09 18:26:08 +00:00
Sergey Biryukov
9429c8436d Coding Standards: Correct the get_plugin_page_hook() check in wp-admin/admin.php. 
The condition is meant to check for a non-empty string, however `get_plugin_page_hook()` can return null, in which case the strict check doesn't work as expected.

Follow-up to [47218].

See #48455, #49222.
Built from https://develop.svn.wordpress.org/trunk@47220


git-svn-id: http://core.svn.wordpress.org/trunk@47020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-09 17:08:03 +00:00
Sergey Biryukov
641c632b0c Coding Standards: Use Yoda conditions where appropriate. 
See #49222.
Built from https://develop.svn.wordpress.org/trunk@47219


git-svn-id: http://core.svn.wordpress.org/trunk@47019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-09 16:55:09 +00:00
Sergey Biryukov
5e6c949861 Coding Standards: Use Yoda conditions in some wp-admin files. 
Props subrataemfluence, marcio-zebedeu, bookdude13, 1naveengiri, alishankhan.
Fixes #44365, #48455.
Built from https://develop.svn.wordpress.org/trunk@47218


git-svn-id: http://core.svn.wordpress.org/trunk@47018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-09 16:53:06 +00:00
Andrea Fercia
f2edcb4421 Accessibility: Media: Make the toolbar and inline uploader visual order always match the DOM order. 
Depending on the specific media view, the media UI elements are placed in a
different visual order. This change makes sure their visual order always
matches the DOM order.

Propos syhc, audrasjb, afercia.
See #37188.
Fixes #48403.

Built from https://develop.svn.wordpress.org/trunk@47217


git-svn-id: http://core.svn.wordpress.org/trunk@47017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-09 16:32:04 +00:00
Sergey Biryukov
f454fc8165 Embeds: Add support for TikTok. 
Props audrasjb, jblz, peterwilsoncc, felipeloureirosantos.
Fixes #49083.
Built from https://develop.svn.wordpress.org/trunk@47216


git-svn-id: http://core.svn.wordpress.org/trunk@47016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-09 04:55:06 +00:00
Sergey Biryukov
e713bf9a88 Site Health: Only get MySQL server information in tests where it's actually needed. 
This resolves an issue with plugins like HyperDB, which doesn't have a database connection until a query is made.

Props xkon, Otto42, Clorith.
See #47606.
Built from https://develop.svn.wordpress.org/trunk@47215


git-svn-id: http://core.svn.wordpress.org/trunk@47015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-08 20:10:05 +00:00
Sergey Biryukov
297aa098ae Twenty Nineteen: Improve code organization in template-functions.php by moving helper functions into their own file. 
These functions are moved to `inc/helper-functions.php`:

* `twentynineteen_can_show_post_thumbnail()`
* `twentynineteen_image_filters_enabled()`
* `twentynineteen_get_avatar_size()`
* `twentynineteen_is_comment_by_post_author()`
* `twentynineteen_get_discussion_data()`
* `twentynineteen_hsl_hex()`

Additionally, `twentynineteen_add_dropdown_icons()` is moved to `inc/icon-functions.php` to join `twentynineteen_nav_menu_social_icons()`.

Props akshayar, allancole, grapplerulrich.
Fixes #45984.
Built from https://develop.svn.wordpress.org/trunk@47214


git-svn-id: http://core.svn.wordpress.org/trunk@47014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-08 13:01:06 +00:00
Sergey Biryukov
7748f7082f Menus: When adding a label for special pages in wp_setup_nav_menu_item(), check if get_post_states() is available, to avoid fatal errors on front end. 
Fixes #49374.
Built from https://develop.svn.wordpress.org/trunk@47213


git-svn-id: http://core.svn.wordpress.org/trunk@47013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-08 12:49:07 +00:00
Sergey Biryukov
8fa6586958 Tests: Add a basic test for wp() function. 
Props pbearne, donmhico.
Fixes #48844.
Built from https://develop.svn.wordpress.org/trunk@47212


git-svn-id: http://core.svn.wordpress.org/trunk@47012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-08 05:31:07 +00:00
Sergey Biryukov
b70056dd70 Menus: Use get_post_states() to denote special pages on the added menu item accordions. 
Front Page, Posts Page, or Privacy Policy Page should now be marked as such on the added menu items.

Props garrett-eclipse.
Fixes #49374.
Built from https://develop.svn.wordpress.org/trunk@47211


git-svn-id: http://core.svn.wordpress.org/trunk@47011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-07 23:46:05 +00:00