Commit Graph

88 Commits

Author SHA1 Message Date
Jeremy Felt
f7b29ecd1b Multisite: Re-Account for striped table rows with .site-* classes.
[34356] removed the table row specificity on rules for `.site-deleted`, `.site-spammed`, `.site-archived`, and `.site-matured` so that the styles would be properly applied to other elements. Now, the zebra striping rules override these styles on even rows.

We can account for `tr` specific and more generic applications of these classes.

Fixes #33595.

Built from https://develop.svn.wordpress.org/trunk@35692


git-svn-id: http://core.svn.wordpress.org/trunk@35656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 21:59:26 +00:00
Scott Taylor
8caf5d9759 Plugins: add dismissible notices to update failures.
Adds unit test.

Props afercia, mehulkaklotar.
Fixes #33465.

Built from https://develop.svn.wordpress.org/trunk@35681


git-svn-id: http://core.svn.wordpress.org/trunk@35645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:10:26 +00:00
Scott Taylor
b17272831c List Tables: fix row links CSS for RTL.
Props afercia.
Fixes #34150.

Built from https://develop.svn.wordpress.org/trunk@35566


git-svn-id: http://core.svn.wordpress.org/trunk@35530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-07 16:05:25 +00:00
Andrea Fercia
3c0ed4295e List tables: Improve the displaying of pagination links on small screens.
Pagination links can break in two lines on small screens. Implements a partial fix, new ideas and better solutions should be explored though.

See #33962.
Built from https://develop.svn.wordpress.org/trunk@35523


git-svn-id: http://core.svn.wordpress.org/trunk@35487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:43:25 +00:00
Sergey Biryukov
1157540283 Replace Quick Edit and Bulk Edit headings with <legend> elements.
Props afercia.
Fixes #34289.
Built from https://develop.svn.wordpress.org/trunk@35234


git-svn-id: http://core.svn.wordpress.org/trunk@35200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 00:45:25 +00:00
John Blackbourn
87aa982824 Include network-active plugins and inactive network-only plugins on the Plugins listing screen for individual sites on Multisite.
These plugins are only shown to users with the `manage_network_plugins` capability, which is Super Admins by default. This new feature lowers the blood pressure of Super Admins who may browse or search the Plugins listing screen of an individual site, having forgotten that a particular plugin is network-active. Showing inactive network-only plugins here also reduces friction when searching the Plugins listing screen on individual sites.

This change introduces a `show_network_active_plugins` filter which controls whether the network-active plugins and inactive network-only plugins are shown. This can be used to enable this functionality for regular site admininstrators, or, indeed, to disable this functionality for Super Admins.

Fixes #20104

Built from https://develop.svn.wordpress.org/trunk@35151


git-svn-id: http://core.svn.wordpress.org/trunk@35117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 22:12:25 +00:00
Andrea Fercia
6ec8174ca1 Accessibility: bump headings one level up on the Add Plugins screen for a better headings hierarchy.
Fixes #33818.
Built from https://develop.svn.wordpress.org/trunk@35009


git-svn-id: http://core.svn.wordpress.org/trunk@34974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 15:17:26 +00:00
Scott Taylor
a3ec4d45f3 List Tables: after [34276], decrease horizontal padding for sorted column headers (causing weirdness in the Count column of tax list tables) - the vertical padding change suffices in fixing the original issue.
Fixes #27945.

Built from https://develop.svn.wordpress.org/trunk@34892


git-svn-id: http://core.svn.wordpress.org/trunk@34857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-07 01:40:24 +00:00
Scott Taylor
da1c938a5c Plugins: on the Install page, move the name of each plugin into the <h4> to accommodate screen readers.
Props afercia, ChrisMKindred.
Fixes #32400.

Built from https://develop.svn.wordpress.org/trunk@34760


git-svn-id: http://core.svn.wordpress.org/trunk@34725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-02 04:16:27 +00:00
Andrea Fercia
0acededa82 In wp_comment_reply() change the H5 headings in fieldset legends for better accessibility.
Also, add a "Edit Comment" legend before the Quick Edit form to pair it with "Reply to Comment" and "Add new Comment" and move the Name, Email, and URL fields after the Comment textarea.

Props joedolson, afercia.

Fixes #33757.
Built from https://develop.svn.wordpress.org/trunk@34743


git-svn-id: http://core.svn.wordpress.org/trunk@34708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-01 14:52:25 +00:00
Scott Taylor
21752923f0 List Tables: .column-date needs to become wider at smaller screen sizes, bump it from 10% to 14% at the breakpoint to prevent wrapping.
Fixes #32691.

Built from https://develop.svn.wordpress.org/trunk@34710


git-svn-id: http://core.svn.wordpress.org/trunk@34674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-30 01:25:25 +00:00
Scott Taylor
41bc0aee88 Revert [34083], I was willing to try this out for the greater good. The good was not greater. There is too much baggage associated with this specific change as pertains to BC and expected layout.
See #32691.

Built from https://develop.svn.wordpress.org/trunk@34709


git-svn-id: http://core.svn.wordpress.org/trunk@34673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-30 01:19:24 +00:00
Scott Taylor
bc5eb3a623 Comments: add date column to WP_Comments_List_Table to allow sorting and to break out the date/time from the comment content column.
Props jshreve.
Fixes #15520.

Built from https://develop.svn.wordpress.org/trunk@34504


git-svn-id: http://core.svn.wordpress.org/trunk@34468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 17:27:26 +00:00
Konstantin Obenland
b548119d99 Multisite: Make site status classes available to other elements.
Fixes a regression introduced in [31181], where links to user's site would not
have a colored background based on their status anymore.

Fixed during WordCamp Switzerland Contributor Day.

Props psoluch.
Fixes #33595.


Built from https://develop.svn.wordpress.org/trunk@34356


git-svn-id: http://core.svn.wordpress.org/trunk@34320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 12:53:27 +00:00
Scott Taylor
2c4323fc1c Updates: in Theme list table, set white-space to normal for theme titles at appropriate breakpoint to avoid horizontal scrolling on small screens.
Fixes #33831.

Built from https://develop.svn.wordpress.org/trunk@34332


git-svn-id: http://core.svn.wordpress.org/trunk@34296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 18:43:24 +00:00
Scott Taylor
60fadd7bdc List Tables: Ensure that sorting indicators have layout when cell widths are being calculated.
See #27743.

Built from https://develop.svn.wordpress.org/trunk@34323


git-svn-id: http://core.svn.wordpress.org/trunk@34287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 16:15:24 +00:00
Scott Taylor
fe6a7e4baa List Tables: ensure that sortable list table column headers have the same padding/line-height as non-sortable headers.
Props drozdz.
Fixes #27945.

Built from https://develop.svn.wordpress.org/trunk@34276


git-svn-id: http://core.svn.wordpress.org/trunk@34240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 03:26:26 +00:00
Helen Hou-Sandí
7f772bdaff Comments: Fix inline edit/reply on small screens.
props ocean90, SergeyBiryukov.
fixes #33596.

Built from https://develop.svn.wordpress.org/trunk@34094


git-svn-id: http://core.svn.wordpress.org/trunk@34062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-13 12:47:27 +00:00
Scott Taylor
a2aca8d063 Use table-layout: auto (instead of fixed) on table.fixed to ensure that things like date/time don't horrendously wrap on small screens. Before/After screenshots attached to the ticket.
Props gaelan.
Fixes #32691.

Built from https://develop.svn.wordpress.org/trunk@34083


git-svn-id: http://core.svn.wordpress.org/trunk@34051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 16:04:25 +00:00
Scott Taylor
d22fbc7545 Grunt RTL CSS: swap-dashicons-left-right-arrows in rtlcss:properties expects double-quoted content strings in CSS. It doesn't swap single-quoted values.
Props Ankit K Gupta, yoavf, netweb.
Fixes #33786.

Built from https://develop.svn.wordpress.org/trunk@34011


git-svn-id: http://core.svn.wordpress.org/trunk@33980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 20:22:25 +00:00
Sergey Biryukov
48a41a6663 List tables: Adjust the styles for checkbox column to align better with longer column names.
Props swissspidy.
Fixes #32825.
Built from https://develop.svn.wordpress.org/trunk@33928


git-svn-id: http://core.svn.wordpress.org/trunk@33897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 23:16:23 +00:00
Scott Taylor
f5c754bfed Dashicons CSS: one-word font families don't need quotes. Font families with a space in the name should use double-quotes (doesn't apply here).
Props afercia.
Fixes #32866.

Built from https://develop.svn.wordpress.org/trunk@33912


git-svn-id: http://core.svn.wordpress.org/trunk@33881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 19:57:25 +00:00
Scott Taylor
fa2d0a2d55 Comment List Tables:
* Toggle visibility of pending bubble when a comment is dynamically moderated
* Add a CSS class to the pending bubble to hide it / remove to show it

See #11200.

Built from https://develop.svn.wordpress.org/trunk@33692


git-svn-id: http://core.svn.wordpress.org/trunk@33659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 17:26:26 +00:00
Helen Hou-Sandí
50e42e8a07 List tables: Yet more primary column fallbacks.
Some custom list tables override enough methods for the column definition fallback to never kick in, so let's ensure that toggling columns only applies when a primary column is defined in some way. We also need to show a toggle button when we can when there are no row actions.

props Chouby, obenland, ocean90.
fixes #33313.

Built from https://develop.svn.wordpress.org/trunk@33623


git-svn-id: http://core.svn.wordpress.org/trunk@33590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-17 15:38:25 +00:00
Konstantin Obenland
08743e43eb After [32948]: Account for the use of paginate_links() with table navigation markup.
Props afercia.
Fixes #32253.


Built from https://develop.svn.wordpress.org/trunk@33608


git-svn-id: http://core.svn.wordpress.org/trunk@33575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-11 20:43:24 +00:00
Dominik Schilling
bd342572f1 List tables: Adjust width of Quick Edit labels for longer translations.
props Clorith, SergeyBiryukov, ocean90.
fixes #33212.
Built from https://develop.svn.wordpress.org/trunk@33598


git-svn-id: http://core.svn.wordpress.org/trunk@33565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-09 18:55:25 +00:00
Helen Hou-Sandí
7b7ae2ee25 Comments list table: Display that cute lil comment bubble.
The comments list table suffers from "wall of text" problems, which the two plain text links compounded.

props obenland. fixes #33149.

Built from https://develop.svn.wordpress.org/trunk@33490


git-svn-id: http://core.svn.wordpress.org/trunk@33457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-29 18:08:25 +00:00
Konstantin Obenland
4f94d3a969 Media: Don't indent action links if there is no media icon.
See #32254.


Built from https://develop.svn.wordpress.org/trunk@33269


git-svn-id: http://core.svn.wordpress.org/trunk@33241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 17:46:24 +00:00
Konstantin Obenland
2a0ddf8523 Media: Reduce link noise between icons and titles in list view.
Props afercia.
Fixes #32254.


Built from https://develop.svn.wordpress.org/trunk@33268


git-svn-id: http://core.svn.wordpress.org/trunk@33240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 17:24:26 +00:00
Helen Hou-Sandí
6e73f1282e List tables: Better accessibility and design for the comments bubble.
It is now plain text in the comments list table's "In Response To" column, where it was visually a bit confusing to have the bubble. For other list tables, it now shows a little notification bubble with the number of pending comments. The bubble and notification become plain text in the responsive list table view. It also shows no bubble when there are no comments at all, reducing some of the visual noise.

props picard102, afercia, karinchristen.
fixes #32152.

Built from https://develop.svn.wordpress.org/trunk@33155


git-svn-id: http://core.svn.wordpress.org/trunk@33127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-10 21:44:25 +00:00
Dominik Schilling
f0db1e0bb7 Customizer: Replace the plus icon for #available-menu-items .item-add with a thinner one, see [33126].
fixes #32734.
Built from https://develop.svn.wordpress.org/trunk@33152


git-svn-id: http://core.svn.wordpress.org/trunk@33124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 22:09:25 +00:00
Dominik Schilling
41a8b24a8f List tables: Remove a black colored separator in Quick Edit for pages.
fixes #32842.
Built from https://develop.svn.wordpress.org/trunk@33149


git-svn-id: http://core.svn.wordpress.org/trunk@33121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 20:57:24 +00:00
Helen Hou-Sandí
70a8c3e83d List tables: Better focus styling for the row toggle.
This circular focus styling could probably be expanded to other areas of the admin.

props hugobaeta.
see #32395.

Built from https://develop.svn.wordpress.org/trunk@33146


git-svn-id: http://core.svn.wordpress.org/trunk@33118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 19:12:25 +00:00
Helen Hou-Sandí
958cde5134 List tables: Ensure special CSS for the title column gets applied.
This could have some side effects if a custom list table has a title column with a strong element inside that is not the post title, but that is fairly edge and we can address that if it comes up. Also moves the rules into `list-tables.css`.

see #25408.

Built from https://develop.svn.wordpress.org/trunk@33105


git-svn-id: http://core.svn.wordpress.org/trunk@33076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 15:21:25 +00:00
Helen Hou-Sandí
df220685a0 List tables: Account for comments being reused on the post edit screen.
Adding the `.wp-list-table` class gets us a few responsive goodies for free. And now it won't show a strange button outline.

see #32395.

Built from https://develop.svn.wordpress.org/trunk@33101


git-svn-id: http://core.svn.wordpress.org/trunk@33072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 00:09:24 +00:00
Helen Hou-Sandí
2d6edf0fe8 List tables: Get rid of double borders for plugins and themes on narrow screens.
see #32395.

Built from https://develop.svn.wordpress.org/trunk@33099


git-svn-id: http://core.svn.wordpress.org/trunk@33070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 23:49:24 +00:00
Helen Hou-Sandí
6fff730706 List tables: Ensure the no items message appears on narrow screens.
fixes #32900. see #32395.

Built from https://develop.svn.wordpress.org/trunk@33098


git-svn-id: http://core.svn.wordpress.org/trunk@33069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 23:30:24 +00:00
Helen Hou-Sandí
8eb7f71e6b List tables: A better responsive view.
Instead of truncating columns, the data that's already in the markup can now be toggled into view. Only seems appropriate to celebrate four years of contributing by finally doing the first thing I ever mocked up.

Known issues / concerns:
* Custom list tables that don't define a primary column will show nothing at all. These are not extremely common, as `WP_List_Table` isn't really recommended for plugin consumption, but it happens. We need to come up with some kind of fallback.
* Some visual elements, particularly whitespace, could use refining.
* Needs a11y review.
* Touch performance on iOS feels sluggish - is there anything we can do about that?
* Would this be better accordion-style (only one expanded at a time)?
* Is `wp_strip_all_tags()` good enough for column titles that have HTML in them? It's essentially a workaround for the fact that core's comments column does that for the icon, which maybe it shouldn't. Perhaps worth another ticket, as a markup change would be fairly independent.
* Visual hierarchy is not great when expanded (also worthy of another ticket).
* Quick edit now becomes noticeably more annoying to cancel out of, as you have to scroll all the way down and you lose your position from before it was opened. Again, worthy of another ticket.

props Michael Arestad, helen.
see #32395.

Built from https://develop.svn.wordpress.org/trunk@33016


git-svn-id: http://core.svn.wordpress.org/trunk@32987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 01:31:25 +00:00
Sergey Biryukov
b26accf35a List tables: Select All should not be a column header.
It sets a redundant relationship with all checkboxes in its column and also conveys wrong information for screen readers.

props afercia, valendesigns.
see #31654.
Built from https://develop.svn.wordpress.org/trunk@32984


git-svn-id: http://core.svn.wordpress.org/trunk@32955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 05:46:25 +00:00
Scott Taylor
7537240d37 List tables: when post navigation links point to the current page, use <span>s and text instead of <a>s.
Props afercia.
Fixes #32253.

Built from https://develop.svn.wordpress.org/trunk@32948


git-svn-id: http://core.svn.wordpress.org/trunk@32919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 20:32:26 +00:00
Scott Taylor
587c570efa After [32796], improve the accessibility and markup for instances of touch_time().
Props rianrietveld, afercia.
Fixes #31714.

Built from https://develop.svn.wordpress.org/trunk@32945


git-svn-id: http://core.svn.wordpress.org/trunk@32916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 19:30:25 +00:00
Helen Hou-Sandí
d159cc2272 Media list table: Avoid PHP notices by using the proper variables.
Also visually tightens up the row actions.

props tyxla.
fixes #32657. see #29881.

Built from https://develop.svn.wordpress.org/trunk@32805


git-svn-id: http://core.svn.wordpress.org/trunk@32776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 21:33:25 +00:00
Dion Hulse
c726f72ea4 Updates: Allow the update row to include the active border styling post-ajax update.
Props TobiasBg. Fixes #32129

Built from https://develop.svn.wordpress.org/trunk@32782


git-svn-id: http://core.svn.wordpress.org/trunk@32753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 05:13:25 +00:00
Jeremy Felt
93ff65e677 Improve information displayed in a network's sites list table
* Better support for arbitrary domain/path combinations by displaying the URL in the primary column rather than Path or Domain.
* Show a cached count of total users per site as a more useful data point rather than the first 5 users.
* Clear that cached count of users for a site when a user is added to the site via `add_user_to_blog()`.

Props @ocean90.
Fixes #32434.

Built from https://develop.svn.wordpress.org/trunk@32718


git-svn-id: http://core.svn.wordpress.org/trunk@32688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 06:50:25 +00:00
Konstantin Obenland
5daf12dba4 Text improvements for screen readers in list table paginations.
Removes title attributes where reasonable and uses accessible hidden text.
Screen readers will now correctly read out all available information.

Props afercia, rianrietveld.
Fixes #32028.


Built from https://develop.svn.wordpress.org/trunk@32693


git-svn-id: http://core.svn.wordpress.org/trunk@32663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-05 05:01:25 +00:00
Helen Hou-Sandí
6f6788c4af Media list view: ensure thumbnails are appropriately sized and constrained.
see #29993.

Built from https://develop.svn.wordpress.org/trunk@32688


git-svn-id: http://core.svn.wordpress.org/trunk@32658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-03 15:23:25 +00:00
Helen Hou-Sandí
40fca44c89 Media: move the thumbnail into the title column in list view.
This gives us more space for the title and row actions, and will make a responsive list table enhancement significantly easier.

props bradt for the initial patch.
fixes #29993 and #32255. see #32509 and #32395.

Built from https://develop.svn.wordpress.org/trunk@32687


git-svn-id: http://core.svn.wordpress.org/trunk@32657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-03 15:13:25 +00:00
Aaron Jorbin
2dff825af7 In List Tables, ensure sorting indicator is visible on focus
In all List Tables, when tabbing through the sortable headers links, the "sorting-indicator" arrows are not displayed. Keyboard users are missing important feedback about the links purpose. 

Happy #GAAD

Props afercia
Fixes #32189


Built from https://develop.svn.wordpress.org/trunk@32521


git-svn-id: http://core.svn.wordpress.org/trunk@32491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 18:05:26 +00:00
Andrew Ozz
fe427017a5 Fix comments postbox:
- Add comment button text.
- Positioning of the Author, Email, URL fields.
Fixes #32349.
Built from https://develop.svn.wordpress.org/trunk@32495


git-svn-id: http://core.svn.wordpress.org/trunk@32465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-12 01:22:25 +00:00
Dominik Schilling
a42b5dc78e Improve focus styles for the Switch View links in Posts listings and Media Library.
props afercia.
fixes #32294.
Built from https://develop.svn.wordpress.org/trunk@32485


git-svn-id: http://core.svn.wordpress.org/trunk@32455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-11 19:34:27 +00:00