Drew Jaynes
3bb87e08e4
Docs: Add missing @access
tags to properties and methods in wp-admin/includes/class-wp-upgrader.
...
See #29086 .
Built from https://develop.svn.wordpress.org/trunk@33684
git-svn-id: http://core.svn.wordpress.org/trunk@33651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 04:05:25 +00:00
Drew Jaynes
73d6dec8eb
Docs: Correct a typo in the summary for the Theme_Upgrader->bulk
property.
...
Also adds a couple of missing `@access` tags.
Props kraftbj
See #29086 .
Built from https://develop.svn.wordpress.org/trunk@33683
git-svn-id: http://core.svn.wordpress.org/trunk@33650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 03:15:25 +00:00
Boone Gorges
52614b491a
Filter the arguments passed to wp_dropdown_categories()
in the Categories post edit metabox.
...
The new 'post_edit_category_parent_dropdown_args' provides parity with other
places in wp-admin where `wp_dropdown_categories()` args are filtered, such as
'taxonomy_parent_dropdown_args'.
Props theMikeD.
Fixes #33026 .
Built from https://develop.svn.wordpress.org/trunk@33682
git-svn-id: http://core.svn.wordpress.org/trunk@33649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 01:28:25 +00:00
Boone Gorges
8b15f8be3d
In Walker_CategoryDropdown::start_el()
, cast values to strings before deciding whether to append 'selected' attribute.
...
As of [32484], `wp_dropdown_categories()` uses the `$value_field` value to
decide whether a given `<option>` should be 'selected'. However, `$value_field`
can refer to a value that is a string, such as a category's slug. This causes
problems when doing a loose comparison (`==`) with the value of the `'selected'`
parameter, which defaults to `0`, because when doing a loose comparison
between an integer and a string, PHP will cast the string to an integer. This
creates false matches, resulting in `<option>` elements getting a 'selected'
attribute incorrectly.
We address the issue by casting the comparison values to strings, and then
using the strict comparison operator `===`.
Fixes #33452 for trunk.
Built from https://develop.svn.wordpress.org/trunk@33681
git-svn-id: http://core.svn.wordpress.org/trunk@33648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 01:11:26 +00:00
Drew Jaynes
b407bb0936
Docs: Standardize @deprecated
tag formatting in the DocBlock for the logIO()
function.
...
Props Alphawolf.
Fixes #28806 .
Built from https://develop.svn.wordpress.org/trunk@33680
git-svn-id: http://core.svn.wordpress.org/trunk@33647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 22:44:25 +00:00
Drew Jaynes
4770601d73
Docs: Standardize @deprecated
tag formatting in the DocBlocks for several wpdb
methods.
...
Props Alphawolf.
See #28806 .
Built from https://develop.svn.wordpress.org/trunk@33679
git-svn-id: http://core.svn.wordpress.org/trunk@33646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 22:42:25 +00:00
Drew Jaynes
bf371f1577
Docs: Standardize @deprecated
tag formatting in the DocBlock for WP_Object_Cache:reset()
.
...
Props Alphawolf.
See #28806 .
Built from https://develop.svn.wordpress.org/trunk@33678
git-svn-id: http://core.svn.wordpress.org/trunk@33645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 22:39:24 +00:00
Drew Jaynes
02ec47fc92
Docs: Standardize @deprecated
tag formatting in the DocBlock for wp_xmlrpc_server::login_pass_ok()
.
...
Props Alphawolf.
See #28806 .
Built from https://develop.svn.wordpress.org/trunk@33677
git-svn-id: http://core.svn.wordpress.org/trunk@33644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 22:38:25 +00:00
Drew Jaynes
eaab0e72a6
Docs: Standardize @deprecated
tag formatting and add missing summaries to deprecated functions in wp-includes/ms-deprecated.php.
...
Props Alphawolf for the initial patch.
Props DrewAPicture
See #28806 .
Built from https://develop.svn.wordpress.org/trunk@33676
git-svn-id: http://core.svn.wordpress.org/trunk@33643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 22:36:25 +00:00
Drew Jaynes
c8638a285a
Docs: Standardize @deprecated
tag formatting for deprecated functions in wp-admin/includes/ms-deprecated.php.
...
Props Alphawolf for the initial patch
Props DrewAPicture
See #28806 .
Built from https://develop.svn.wordpress.org/trunk@33675
git-svn-id: http://core.svn.wordpress.org/trunk@33642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 22:26:24 +00:00
Drew Jaynes
b2dcf3d1f4
Docs: Standardize @deprecated
tag formatting for deprecated functions in wp-includes/pluggable-deprecated.php.
...
Props Alphawolf for the initial patch.
Props DrewAPicture.
See #28806 .
Built from https://develop.svn.wordpress.org/trunk@33674
git-svn-id: http://core.svn.wordpress.org/trunk@33641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 22:15:25 +00:00
Drew Jaynes
e9f1e69b23
Docs: Standardize @deprecated
tag formatting and add missing DocBlock summaries to deprecated functions in wp-includes/deprecated.php.
...
Props Alphawolf for the initial patch.
Props DrewAPicture.
See #28806 .
Built from https://develop.svn.wordpress.org/trunk@33673
git-svn-id: http://core.svn.wordpress.org/trunk@33640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 22:11:26 +00:00
Scott Taylor
6f9aa6df03
After [33666], fix broken sprintf
cruff.
...
See #17609 .
Built from https://develop.svn.wordpress.org/trunk@33672
git-svn-id: http://core.svn.wordpress.org/trunk@33639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 21:37:24 +00:00
Drew Jaynes
bac6e69b3c
Docs: Standardize @deprecated
tag formatting and add missing DocBlocks to deprecated functions in wp-admin/includes/deprecated.php.
...
Opted not to use the multi-function DocBlock syntax in the name of not taking shortcuts in documentation for the sake of brevity.
Props Alphawolf for the initial patch.
See #28806
Built from https://develop.svn.wordpress.org/trunk@33671
git-svn-id: http://core.svn.wordpress.org/trunk@33638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 21:23:25 +00:00
Drew Jaynes
c36c4efea6
Docs: Add a missing summary to the DocBlock for wp_media_upload_handler()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@33670
git-svn-id: http://core.svn.wordpress.org/trunk@33637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 21:01:25 +00:00
Scott Taylor
677d47ebc5
In wp_get_attachment_link()
, accept an id
or WP_Post
as the first parameter.
...
Props several27, DrewAPicture.
Fixes #33277 .
Built from https://develop.svn.wordpress.org/trunk@33669
git-svn-id: http://core.svn.wordpress.org/trunk@33636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 20:32:26 +00:00
Drew Jaynes
89c39e7eab
Docs: Clarify the different return conditions in the DocBlock for WP_List_Table->handle_row_actions()
.
...
This clarification follows the introduction of primary columns in 4.3. See #33313 .
Props morganestes.
Fixes #33436 .
Built from https://develop.svn.wordpress.org/trunk@33668
git-svn-id: http://core.svn.wordpress.org/trunk@33635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 20:22:25 +00:00
Scott Taylor
4254f22c2d
In WP_Posts_List_Table::inline_edit()
, check that $post_formats[0]
is an array before traversing.
...
Props DrewAPicture.
Fixes #33025 .
Built from https://develop.svn.wordpress.org/trunk@33667
git-svn-id: http://core.svn.wordpress.org/trunk@33634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 20:19:25 +00:00
Scott Taylor
4694c477d3
Custom Post Types:
...
* Introduce `is_post_type_viewable( $post_type_object )`
* Separate the HTML bits from the translatable bits in the `post` messages array in `edit-form-advanced.php`
* Don't show certain UI pieces when a post is not viewable on the front end
When a custom post type item is not viewable on the front end, we don't want to show links to View it (on the front end) all over the admin. We also want to hide the Preview link, et al. We also want our admin messages to not contain said links.
Custom post types with `public_queryable` set to `false` are not viewable on the front end.
`'page'` is viewable on the front end, but `'page'` is a `_builtin` type, and `public_queryable` is set to `false` when it is registered - see `WP::parse_request()` for when `public_queryable` gets used.
This is confusing, but also somewhat straightforward: to determine if a post type is viewable on the front end, we can check one way for `_builtin => true` and another way for `_builtin => false`:
`$post_type->publicly_queryable || ( $post_type->_builtin && $post_type->public )`
If a post type is `publicly_queryable`, it's viewable. If that value is `false`, it is viewable if it's a `_builtin` type that is also `public`.
I am in search of edge cases, so this shall land.
Props wonderboymusic, DrewAPicture.
See #17609 .
Built from https://develop.svn.wordpress.org/trunk@33666
git-svn-id: http://core.svn.wordpress.org/trunk@33633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 19:40:25 +00:00
Drew Jaynes
a7b38bf90a
Docs: Correct the phpDoc type to a boolean for the $single
parameter in the get_{$meta_type}_metadata
hook docs.
...
Props dlh.
Fixes #33451 .
Built from https://develop.svn.wordpress.org/trunk@33665
git-svn-id: http://core.svn.wordpress.org/trunk@33632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 19:36:25 +00:00
Drew Jaynes
bec5bcf717
Docs: Mark the $notify
parameter in the DocBlock for wp_new_user_notification()
as optional, and provide additional context on the difference between the accepted values.
...
See [33620] and [33023] for background.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@33664
git-svn-id: http://core.svn.wordpress.org/trunk@33631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 18:26:26 +00:00
Scott Taylor
d65112d382
After [33662], remove unused var.
...
See #11200 .
Built from https://develop.svn.wordpress.org/trunk@33663
git-svn-id: http://core.svn.wordpress.org/trunk@33630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 17:19:25 +00:00
Scott Taylor
20f6db2b18
Comment List Tables:
...
* Ensure that dynamic bubble counts are in sync by `comment_post_ID`
* Scope `:animated` to `#the-comment-list`
See #11200 .
Built from https://develop.svn.wordpress.org/trunk@33662
git-svn-id: http://core.svn.wordpress.org/trunk@33629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 16:36:25 +00:00
Dominik Schilling
6d45b63562
WordPress 4.3 has just passed 2,222,222 downloads.
...
(Fix typo in [33653].)
Built from https://develop.svn.wordpress.org/trunk@33661
git-svn-id: http://core.svn.wordpress.org/trunk@33628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 16:00:28 +00:00
Scott Taylor
0e4606c13e
JSHint after [33655].
...
Built from https://develop.svn.wordpress.org/trunk@33660
git-svn-id: http://core.svn.wordpress.org/trunk@33627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 06:31:25 +00:00
Scott Taylor
45fc6a3def
Deprecate post_permalink()
(Introduced in 1.0, already had a deprecated argument in 1.3), which just wraps get_permalink()
and was only used by XML-RPC in 4 places.
...
Props solarissmoke.
Fixes #16982 .
Built from https://develop.svn.wordpress.org/trunk@33659
git-svn-id: http://core.svn.wordpress.org/trunk@33626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 06:24:26 +00:00
Scott Taylor
1fd0dcbc9e
Ensure that feeds are served with the proper Content-Type
HTTP header.
...
Props stevenkword.
Fixes #32024 .
Built from https://develop.svn.wordpress.org/trunk@33658
git-svn-id: http://core.svn.wordpress.org/trunk@33625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 06:10:24 +00:00
Scott Taylor
2e2223ae74
Comments List Table:
...
* In a view that initially has comments, but they get removed due to user actions: show the `No Items` row instead of bombing out and showing nothing (which looks broken)
* To accomplish this, in `WP_Comments_List_Table::display()`: call `->display_rows_or_placeholder()` instead of `->display()`
* Listen for the end of row `.fadeOut()`s if necessary using jQuery Promises
Fixes #11200 .
Built from https://develop.svn.wordpress.org/trunk@33657
git-svn-id: http://core.svn.wordpress.org/trunk@33624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 05:54:25 +00:00
Scott Taylor
657d0f6918
Comments List Table:
...
* Properly increment/decrement approved/pending bubbles in `response` column
See #11200 .
Built from https://develop.svn.wordpress.org/trunk@33656
git-svn-id: http://core.svn.wordpress.org/trunk@33623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 04:02:24 +00:00
Scott Taylor
df618f3461
Comments List Table:
...
* Show count next to "Approved"
* Properly increment/decrement counts when row actions are clicked
* In `_wp_ajax_delete_comment_response()`, return the comment's `status` with the `supplemental` data
* Handle counts properly on each scenario of `undo`
See #11200 .
Built from https://develop.svn.wordpress.org/trunk@33655
git-svn-id: http://core.svn.wordpress.org/trunk@33622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 02:51:25 +00:00
Scott Taylor
572a0a587a
Comments shouldn't have more than one _wp_trash_meta_status
entry. When deleting _wp_trash_meta_status
, also delete _wp_trash_meta_time
.
...
See #11200 .
Built from https://develop.svn.wordpress.org/trunk@33654
git-svn-id: http://core.svn.wordpress.org/trunk@33621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 02:45:26 +00:00
Boone Gorges
7c0d3ab83a
Introduce post_name__in
parameter for WP_Query
.
...
Props enshrined.
Fixes #33065 .
Built from https://develop.svn.wordpress.org/trunk@33653
git-svn-id: http://core.svn.wordpress.org/trunk@33620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 02:19:25 +00:00
Boone Gorges
bc592af91f
wp_update_term()
should return a true integer for 'term_taxonomy_id'.
...
Props ipm-frommen.
Fixes #32876 .
Built from https://develop.svn.wordpress.org/trunk@33652
git-svn-id: http://core.svn.wordpress.org/trunk@33619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 19:33:24 +00:00
Konstantin Obenland
f770303868
Themes: Prevent short descriptions from wrapping version info.
...
Props mehulkaklotar for initial patch.
Fixes #33248 .
Built from https://develop.svn.wordpress.org/trunk@33651
git-svn-id: http://core.svn.wordpress.org/trunk@33618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 19:10:24 +00:00
Konstantin Obenland
2849e2c5e9
Themes: Open preview when requesting a single theme in the installer.
...
Props kraftner, obenland.
Fixes #28735 .
Built from https://develop.svn.wordpress.org/trunk@33650
git-svn-id: http://core.svn.wordpress.org/trunk@33617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 18:54:27 +00:00
Dion Hulse
a32d83586e
Upgrades: When upgrading via FTP, use LIST -a
to detect if a file exists.
...
`LIST` & `NLST` by default on some servers require the `-a` flag to view hidden files (ie. `.maintenance`)
Although we could simply pass the `-a` flag to `NLST`, opting to use `LIST` which we use elsewhere should mean less chance of server incompatibilities.
Props jcroucher.
Fixes #28013 .
Built from https://develop.svn.wordpress.org/trunk@33648
git-svn-id: http://core.svn.wordpress.org/trunk@33615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 12:38:25 +00:00
Dion Hulse
25c5d372d3
Term Splitting: Fix a reversal of parameters to wp_schedule_single_event() introduced in [33621].
...
The existing invalid cron entries will not be purged automatically (as the 'timestamp' is never matched) so we do this ourselves.
Props mechter for noticing!
See #30261 .
Fixes #33423 for trunk.
Built from https://develop.svn.wordpress.org/trunk@33646
git-svn-id: http://core.svn.wordpress.org/trunk@33613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 11:31:26 +00:00
Dion Hulse
096b2f58fa
Fix PHP notice after [33492] when updating themes.
...
Props bobbingwide.
See #33208 .
Fixes #33427 .
Built from https://develop.svn.wordpress.org/trunk@33645
git-svn-id: http://core.svn.wordpress.org/trunk@33612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 10:35:25 +00:00
Scott Taylor
3923017f82
The 'restrict_manage_posts'
hook currently fires on the Post and Media list tables, but is passed zero arguments. Pass $post_type
.
...
Props sunnyratilal, scribu.
Fixes #17891 .
Built from https://develop.svn.wordpress.org/trunk@33644
git-svn-id: http://core.svn.wordpress.org/trunk@33611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 06:23:25 +00:00
Scott Taylor
b19bb99853
Playlists, for .wp-playlist-item-title
elements: move the curly quotes to CSS pseudo-element content
, making them easier to override or remove.
...
Fixes #33391 .
Built from https://develop.svn.wordpress.org/trunk@33643
git-svn-id: http://core.svn.wordpress.org/trunk@33610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 05:51:25 +00:00
Scott Taylor
07c079cc86
WP_Embed::maybe_run_ajax_cache()
doesn't hook to pages, because it only happens on 'edit_form_advanced'
, not 'edit_page_form'
. Make sure it runs for pages as well. This was probably not intentional, see [29557].
...
Fixes #32418 .
Built from https://develop.svn.wordpress.org/trunk@33642
git-svn-id: http://core.svn.wordpress.org/trunk@33609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 05:40:24 +00:00
Scott Taylor
c15a1c2bab
Replace some hyphens with —
s in admin help tabs.
...
Props pixolin.
Fixes #30605 .
Built from https://develop.svn.wordpress.org/trunk@33641
git-svn-id: http://core.svn.wordpress.org/trunk@33608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 04:53:25 +00:00
Scott Taylor
8af2dbc671
Correct punctuation/case for inline comment in async-upload.php
...
Props chriscct7.
Fixes #33408 .
Built from https://develop.svn.wordpress.org/trunk@33640
git-svn-id: http://core.svn.wordpress.org/trunk@33607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-18 23:35:25 +00:00
Scott Taylor
23f62a59da
Correct typo in doc block for WP_Filesystem_ftpsockets::rmdir
...
Props Toro_Unit.
Fixes #33255 .
Built from https://develop.svn.wordpress.org/trunk@33639
git-svn-id: http://core.svn.wordpress.org/trunk@33606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-18 23:33:24 +00:00
Scott Taylor
227d38c9cd
Correct typo in JSDoc for wp.updates.decrementCount
...
Props mt8.biz.
Fixes #33363 .
Built from https://develop.svn.wordpress.org/trunk@33638
git-svn-id: http://core.svn.wordpress.org/trunk@33605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-18 21:47:25 +00:00
Scott Taylor
0b29061b3d
Fix case type in docs for get_children()
.
...
Props bobbingwide.
Fixes #33364 .
Built from https://develop.svn.wordpress.org/trunk@33637
git-svn-id: http://core.svn.wordpress.org/trunk@33604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-18 21:39:24 +00:00
Helen Hou-Sandí
0c89678c9b
Trunk is now 4.4-alpha.
...
Built from https://develop.svn.wordpress.org/trunk@33636
git-svn-id: http://core.svn.wordpress.org/trunk@33603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-18 19:32:26 +00:00
Konstantin Obenland
2e73c24e30
WordPress 4.3
...
Built from https://develop.svn.wordpress.org/trunk@33633
git-svn-id: http://core.svn.wordpress.org/trunk@33600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-18 18:02:25 +00:00
Konstantin Obenland
e36a91efe4
About: Use actual locale and not subtitle debug cruft.
...
H/t dimadin.
See #32929 .
Built from https://develop.svn.wordpress.org/trunk@33632
git-svn-id: http://core.svn.wordpress.org/trunk@33599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-18 17:07:26 +00:00
Konstantin Obenland
d55738d327
About: Update release video to use the correct ID.
...
Also adjusts locale handling to work with Videopress' subtitle implementation.
Props siobhan, jacklenox, sararosso, hugobaeta, nickmomrik, rauchg.
See #32929 .
Built from https://develop.svn.wordpress.org/trunk@33631
git-svn-id: http://core.svn.wordpress.org/trunk@33598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-18 17:02:27 +00:00