Commit Graph

39639 Commits

Author SHA1 Message Date
whyisjake
42a430a0a9 REST API: Allow for multiple Vary: Origin headers in GET responses.
Simple fix, we pass false as the second parameter to the header function.

This is something that we added downstream of the 5.2.4 release, but we missed in 5.2/trunk.

Fixes #48309, see also [46544].
Props xknown, whyisjake.

Built from https://develop.svn.wordpress.org/branches/5.2@46545


git-svn-id: http://core.svn.wordpress.org/branches/5.2@46342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-15 15:54:53 +00:00
desrosj
d60f90873c Post WordPress 5.2.4 version bump. The 5.2 branch is now 5.2.5-alpha.
Built from https://develop.svn.wordpress.org/branches/5.2@46540


git-svn-id: http://core.svn.wordpress.org/branches/5.2@46337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-14 22:02:53 +00:00
desrosj
9380cf2995 WordPress 5.2.4.
Built from https://develop.svn.wordpress.org/branches/5.2@46508


git-svn-id: http://core.svn.wordpress.org/branches/5.2@46305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-14 20:06:55 +00:00
whyisjake
e9ecfd078e REST API: Send a Vary: Origin header on GET requests.
Add this header on all GET requests to prevent cached requests.

Fixes some code dulication from [46484] and backports the changes from [46484] to the 5.2 branch.
Props darthhexx, davidbinda, nickdaugherty, whyisjake.

Built from https://develop.svn.wordpress.org/branches/5.2@46487


git-svn-id: http://core.svn.wordpress.org/branches/5.2@46285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-14 17:44:54 +00:00
whyisjake
0ca56956ae Administration: Ensure that admin referer nonce is valid.
Coding standards, ensure that nonce is valid with identical, rather then equal operator.

Backports [46477] to the 5.2 branch.
Props vortfu, xknown, whyisjake.

Built from https://develop.svn.wordpress.org/branches/5.2@46486


git-svn-id: http://core.svn.wordpress.org/branches/5.2@46284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-14 17:34:53 +00:00
whyisjake
cbc773dcbb Filesystem API: Prevent directory travelersals when creating new folders.
Reject file paths that contain sub-directory paths.

Props iandunn, xknown, sstoqnov, whyisjake.

Built from https://develop.svn.wordpress.org/branches/5.2@46484


git-svn-id: http://core.svn.wordpress.org/branches/5.2@46282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-14 16:34:53 +00:00
whyisjake
e5e18e9b15 Filesystem API: Prevent directory travelersals when creating new folders.
Reject file paths that contain sub-directory paths.

Backports [46476] to the 5.2 branch.

Props iandunn, xknown, sstoqnov, whyisjake.

Built from https://develop.svn.wordpress.org/branches/5.2@46482


git-svn-id: http://core.svn.wordpress.org/branches/5.2@46280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-14 16:13:53 +00:00
whyisjake
c4a25f9386 Add merge information missed in r46474-46475.
Built from https://develop.svn.wordpress.org/branches/5.2@46481


git-svn-id: http://core.svn.wordpress.org/branches/5.2@46279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-14 16:09:51 +00:00
whyisjake
f0335c6a8b HTTP API: Protect against hex interpretation.
Return earlier from wp_http_validate_url().

Props: iandunn, xknown, voldemortensen, whyisjake.

Built from https://develop.svn.wordpress.org/branches/5.2@46480


git-svn-id: http://core.svn.wordpress.org/branches/5.2@46278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-14 15:52:53 +00:00
whyisjake
f82ed753cf Query: Remove the static query property.
Prevent unauthenticated views of publicly queryables content types.

Props aaroncampbell, whyisjake, nickdaugherty, xknown.

Built from https://develop.svn.wordpress.org/branches/5.2@46479


git-svn-id: http://core.svn.wordpress.org/branches/5.2@46277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-14 15:51:54 +00:00
Sergey Biryukov
c83ea95120 Formatting: In wp_validate_redirect(), normalize the path when validating the location for relative URLs, to account for Windows paths.
Props peterwilsoncc, rconde, jmmathc, mat-lipe, Sixes, justinahinon, cmagrin, daxelrod, SergeyBiryukov.
Merges [46472] to the 5.2 branch.
Fixes #47980.
Built from https://develop.svn.wordpress.org/branches/5.2@46473


git-svn-id: http://core.svn.wordpress.org/branches/5.2@46271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-14 11:04:55 +00:00
desrosj
5753d19fe4 Build/Test Tools: Remove PHP 7.4 and nightly builds from Travis.
See #48225.
Built from https://develop.svn.wordpress.org/branches/5.2@46406


git-svn-id: http://core.svn.wordpress.org/branches/5.2@46205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-05 16:58:53 +00:00
whyisjake
e4b3059eb2 Remove the extra call for wp-sanitize from the script loader.
Merges [46073] to the 5.2 branch.
Fixes #47986.


Built from https://develop.svn.wordpress.org/branches/5.2@46074


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-06 21:56:54 +00:00
Sergey Biryukov
fd1d9bb298 Post WordPress 5.2.3 version bump.
Built from https://develop.svn.wordpress.org/branches/5.2@46065


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-05 02:16:54 +00:00
whyisjake
e3194da7eb WordPress 5.2.3.
Built from https://develop.svn.wordpress.org/branches/5.2@46047


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-04 22:09:18 +00:00
desrosj
2df5a45321 Help/About: Update the About page for 5.2.3.
Props whyisjake, desrosj.
Fixes #47923.
Built from https://develop.svn.wordpress.org/branches/5.2@46046


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-04 22:08:25 +00:00
Sergey Biryukov
cbd492abd3 Coding Standards: Fix WPCS issue in [45990].
Merges [46019] to the 5.2. branch.
Built from https://develop.svn.wordpress.org/branches/5.2@46022


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-04 21:46:48 +00:00
desrosj
a3c199b473 Fix for URL sanitization in wp_kses_bad_protocol_once().
Merges [45997] to the 5.2 branch.

Props irsdl, sstoqnov, whyisjake.
Built from https://develop.svn.wordpress.org/branches/5.2@46000


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-04 17:57:52 +00:00
Sergey Biryukov
50f2f05956 Improve handling the existing rel attribute in wp_rel_nofollow_callback().
Merges [45990] to the 5.2 branch.
Props xknown, sstoqnov.
Built from https://develop.svn.wordpress.org/branches/5.2@45991


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-04 17:39:51 +00:00
whyisjake
affedce0a8 Update wp.a11y.speak() to sanitize HTML before display.
Merges [45979] to the 5.2 branch

Props iandunn, adamsilverstein, sstoqnov, peterwilsoncc

Built from https://develop.svn.wordpress.org/branches/5.2@45989


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-04 17:23:52 +00:00
Sergey Biryukov
684ef4e3a7 Improve URL validation in wp_validate_redirect().
Merges [45971] to the 5.2 branch.
Props vortfu, whyisjake, peterwilsoncc.
Built from https://develop.svn.wordpress.org/branches/5.2@45972


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-04 16:58:52 +00:00
Sergey Biryukov
4315d85d65 Escape the output in wp_ajax_upload_attachment().
Merges [45936] to the 5.2 branch.
Props whyisjake, sstoqnov.
Built from https://develop.svn.wordpress.org/branches/5.2@45938


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-04 16:15:51 +00:00
whyisjake
6a63bf0361 Remove _convert_urlencoded_to_entities() from the get_the_content() callback.
Props vortfu, whyisjake, peterwilsoncc

Built from https://develop.svn.wordpress.org/branches/5.2@45937


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-04 16:10:52 +00:00
whyisjake
c4999912e7 WordPress 5.2.3 Release Candidate 1 version bump.
Built from https://develop.svn.wordpress.org/branches/5.2@45880


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-22 17:57:52 +00:00
whyisjake
6e45fa6779 WordPress 5.2.3 Release Candidate 2
Built from https://develop.svn.wordpress.org/branches/5.2@45879


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-22 17:48:52 +00:00
whyisjake
dbfcb74609 WordPress 5.2.3 Release Candidate 1
Built from https://develop.svn.wordpress.org/branches/5.2@45878


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-22 17:21:52 +00:00
Sergey Biryukov
6b8460ee43 Customizer: Trim whitespace from custom link URLs.
This complements a similar fix for the Menus screen in [45655].

Props donmhico, audrasjb.
Merges [45869] to the 5.2 branch.
Fixes #47888. See #47723.
Built from https://develop.svn.wordpress.org/branches/5.2@45870


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-21 00:29:52 +00:00
Sergey Biryukov
7a64dfb557 Docs: Update @since tag for new JS functions and variables introduced in [45572].
Props garrett-eclipse.
Merges [45867] to the 5.2 branch.
See #47145.
Built from https://develop.svn.wordpress.org/branches/5.2@45868


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-20 22:55:52 +00:00
Sergey Biryukov
5bb75cf4fd Accessibility: Make the Media modal an ARIA modal dialog.
For a number of years, the Media modal missed an explicit ARIA role and the required attributes for modal dialogs.

This was confusing for assistive technology users, since they may not realize they're inside a dialog, and that consequently the keyboard interactions may be different from the rest of the page. Lack of an explicit label for the dialog was confusing as well, since assistive technology users didn't have an immediate sense of what the dialog is for.

This change makes the Media modal meet the ARIA Authoring Practices recommendations, helping users better understand the purpose and interactions with the modal. Also, it makes sure to hide the rest of the page content from assistive technologies, until support for `aria-modal="true"` improves.

Additionally:
- moves the modal H1 heading to the beginning of the modal content 
- changes the modal left menu position to make visual and DOM order match 
- improves the `wp.media.view.FocusManager` documentation

Props afercia.
Merges [45572] to the 5.2 branch.
Fixes #47145.
Built from https://develop.svn.wordpress.org/branches/5.2@45866


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-20 22:42:51 +00:00
Sergey Biryukov
f6a419e564 Accessibility: Fix the alt attribute of the Gallery images within the Classic Editor.
Passes the images `alt` attribute value to the Gallery template used within the Classic Editor.

Props yarnboy, wpboss.
Merges [45725] to the 5.2 branch.
Fixes #47687.
Built from https://develop.svn.wordpress.org/branches/5.2@45865


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-20 19:15:52 +00:00
Sergey Biryukov
49d9d2dc57 Twenty Seventeen: Correct height for a Button block without text.
Props ianbelanger, laurelfulford, nayana123.
Merges [45764], [45861], and [45863] to the 5.2 branch.
Fixes #47414.
Built from https://develop.svn.wordpress.org/branches/5.2@45864


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-20 19:13:54 +00:00
Sergey Biryukov
61461dfa07 Accessibility: Fix the order of the Previous, Next, and Close buttons in the Attachment Details modal.
Making the visual and DOM order match benefits keyboard users who navigate documents sequentially and expect the focus order to be consistent with the sequential reading order.

Props afercia.
Merges [45506] to the 5.2 branch.
Fixes #47458.
Built from https://develop.svn.wordpress.org/branches/5.2@45849


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-19 04:55:53 +00:00
Sergey Biryukov
6faaa121a8 Block Editor: Fix the link to the classic editor when incompatible meta boxen are detected.
Props tmatsuur, mukesh27.
Merges [45618] to the 5.2 branch.
Fixes #45935.
Built from https://develop.svn.wordpress.org/branches/5.2@45848


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-19 04:53:53 +00:00
Sergey Biryukov
bd7d21bc49 Twenty Seventeen: Correct the CSS selectors intended to fix hover colors for MediaElement controls.
This is a follow-up to the previous fix in [45146], which didn't work as expected.

Props ryokuhi.
Merges [45576] to the 5.2 branch.
Fixes #47543. See #40843.
Built from https://develop.svn.wordpress.org/branches/5.2@45847


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-19 04:49:51 +00:00
Sergey Biryukov
cfce1bcf97 Twenty Seventeen: Accessibility: Add missing focus state for native audio and video embeds.
Props kjellr, karlgroves.
Merges [45425] to the 5.2 branch.
Fixes #47190.
Built from https://develop.svn.wordpress.org/branches/5.2@45846


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-19 04:48:53 +00:00
Sergey Biryukov
0eb803e871 Twenty Nineteen: Revise Latest Posts block styles to support post content options.
Props kjellr, ianbelanger.
Merges [45761] to the 5.2 branch.
Fixes #47340.
Built from https://develop.svn.wordpress.org/branches/5.2@45845


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-19 04:46:53 +00:00
Sergey Biryukov
fc5723d396 Upgrade/Install: Bring some consistency to installation screen styles.
* Include `forms.css` and `l10n.css`, for consistency with login screen and other admin screens.
* Remove redundant `@import` directives from `login.css` for files already declared as dependencies.
* Adjust margin on password strength meter for consistency with other fields.
* Increase font size for "You will need this password to log in" notice.
* Fix misaligned icon on "Hide" button for the password.

Props iseulde, dan@micamedia.com, bassgang, cdog, johnbillion, nmenescardi, mukesh27, alpipego, SergeyBiryukov.
Merges [45673] to the 5.2 branch.
Fixes #35776, #43483, #47757, #47758.
Built from https://develop.svn.wordpress.org/branches/5.2@45844


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-19 04:44:53 +00:00
Sergey Biryukov
8cf11a944f Customize: Make the color picker close when clicking on the empty area on the right.
Props monikarao, afercia.
Merges [45722] to the 5.2 branch.
Fixes #47693.
Built from https://develop.svn.wordpress.org/branches/5.2@45843


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-19 04:39:51 +00:00
Sergey Biryukov
c1c7188c8a Accessibility: Toolbar: Make the min-width value for #wpadminbar at 782px breakpoint consistent with that of <body>.
This ensures that the "My Account" toolbar item stays visible at high zoom levels.

Props isabel_brison, chetan200891.
Merges [45684] to the 5.2 branch.
Fixes #47603.
Built from https://develop.svn.wordpress.org/branches/5.2@45842


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-19 04:37:52 +00:00
Sergey Biryukov
4ef44b9ab0 Media: Reduces the bulk media options to have one primary button.
This fixes where 2 primary buttons were showing for bulk actions within media trash.

Props garrett-eclipse, afercia, ianbelanger, SergeyBiryukov, karmatosed.
Merges [45701] to the 5.2 branch.
Fixes #46757, #46758
Built from https://develop.svn.wordpress.org/branches/5.2@45841


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-19 04:34:52 +00:00
Sergey Biryukov
90c221a67c Accessibility: Improve the media views upload Dismiss Errors button.
- makes the Dismiss Errors button visible in the media views inline uploader
- avoids a focus loss when activating the Dismiss Errors button

See the related GitHub issue from the WPCampus accessibility audit https://github.com/WordPress/gutenberg/issues/15354

Props afercia.
Merges [45376] to the 5.2 branch.
Fixes #47113.
Built from https://develop.svn.wordpress.org/branches/5.2@45840


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-19 04:31:52 +00:00
Sergey Biryukov
ad85b0fe1d Accessibility: Fix the headings hierarchy in the legacy Custom Background and Custom Header pages.
Props afercia.
Merges [45411] to the 5.2 branch.
Fixes #47386.
Built from https://develop.svn.wordpress.org/branches/5.2@45839


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-19 04:29:53 +00:00
Sergey Biryukov
b967202110 Media: Make sure the bottom media toolbar content is fully visible with Internet Explorer 11.
Props mspatovaliyski, afercia.
Merges [45526] to the 5.2 branch.
Fixes #47502.
Built from https://develop.svn.wordpress.org/branches/5.2@45838


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-19 04:26:51 +00:00
Sergey Biryukov
e256b2897b Formatting: Don't convert smilies in ignored tags that have attributes.
Smilies in ignored tags are not supposed to be converted to emoji, but this can malfunction if the tag has attributes. For example, the Preformatted block with add a `class` to the `<pre>` tag.

Props pento, jikamens.
Merges [45569] to the 5.2 branch.
Fixes #47489.
Built from https://develop.svn.wordpress.org/branches/5.2@45837


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-19 04:24:53 +00:00
Sergey Biryukov
303034e393 Editor: Correct since annotation for the excerpt_allowed_blocks filter.
Props mukesh27, rabmalin.
Merges [45284] to the 5.2 branch.
Fixes #47079.
Built from https://develop.svn.wordpress.org/branches/5.2@45836


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-19 04:18:53 +00:00
Sergey Biryukov
7b8b2a7f5c Accessibility: Improve settings tables and forms after [45403].
- adds `role="presentation"` to the edit comment table 
- removes a few pointless `<fieldset>` elements
- adds a few missing `<label>` elements
- adds the CSS class `class="td-full"` to table rows spanning to multiple cells
- adds explicit `scope="row"` attribute to the table headers in `options-permalink.php`: this table is better communicated as data table 
- uses consistent label association in the "Privacy Settings" page
- in the installation page "Set up your database connection": associates descriptions to their inout fields using `aria-describedby`
- improves the link to gravatar.com in the `user-edit.php` page

Props afercia.
Merges [45416] to the 5.2 branch.
See #46899.
Fixes #47390.
Built from https://develop.svn.wordpress.org/branches/5.2@45835


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-19 04:15:52 +00:00
Sergey Biryukov
18987f840c Accessibility: Make sure layout tables across the admin are correctly linearized.
Adds `role="presentation"` to the `<table>` elements used for layout purposes.

Ideally, HTML tables should be used for tabular data. When tables are used for layout purposes, it's important to remove any native semantics so that assistive technologies can correctly announce the table content in a linearized fashion.

Props greatislander, afercia.
Merges [45403] to the 5.2 branch.
See #46899.
Built from https://develop.svn.wordpress.org/branches/5.2@45834


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-19 04:13:54 +00:00
Sergey Biryukov
7b82b8fd18 Site Health: Use correct variable when checking PHP requirements for a plugin update in WP_Plugins_List_Table::single_row().
Props diddledan, sharaz, vaishalipanchal, afragen.
Merges [45750] to the 5.2 branch.
Fixes #47835.
Built from https://develop.svn.wordpress.org/branches/5.2@45833


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-19 04:09:52 +00:00
Sergey Biryukov
7ab695d1d6 Menus: Trim whitespace from custom link URLs.
Props majemedia, SergeyBiryukov.
Merges [45655] and [45656] to the 5.2 branch.
Fixes #47723.
Built from https://develop.svn.wordpress.org/branches/5.2@45832


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-19 04:07:52 +00:00
Sergey Biryukov
d8a0523887 Editor: Fix undefined $locked var in edit-form-blocks.php when the show_post_locked_dialog filter is used to disable displaying of the dialog.
Props aprea.
Merges [45564] to the 5.2 branch.
Fixes #47604.
Built from https://develop.svn.wordpress.org/branches/5.2@45831


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-19 04:04:52 +00:00