Commit Graph

42183 Commits

Author SHA1 Message Date
Sergey Biryukov
52b59a5f07 Comments: Update comment cache in the upgrade routine for changing the comment_type DB field value in comments table.
This ensures that comment object cache is cleared after changing the comment type to `comment` instead of an empty string.

Add a unit test for `_wp_batch_update_comment_type()`.

Follow-up to [47597], [47626], [48225], [48227].

Props imath, westonruter.
Reviewed by desrosj, SergeyBiryukov.
Merges [48748] and [48751] to the 5.5 branch.
Fixes #49236.
Built from https://develop.svn.wordpress.org/branches/5.5@48752


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-07 16:35:08 +00:00
desrosj
719ef3461b Site Health: Consistently pass an object to the auto_update_{$type} filter in Site Health debug data.
Previously, some instances of the filter received an array from a plugin or theme update response, potentially triggering PHP notices.

Merges [48745] to the 5.5 branch.
Reviewed by desrosj, SergeyBiryukov.
Props bpayton, pbiron.
Fixes #50852.
Built from https://develop.svn.wordpress.org/branches/5.5@48747


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-07 13:51:02 +00:00
desrosj
081d50e68f Site Health: Check if session_status() exists before calling it.
Merges [48742] to the 5.5 branch.
Reviewed by desrosj, SergeyBiryukov.
Props bgermann.
Fixes #50862.
Built from https://develop.svn.wordpress.org/branches/5.5@48746


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-07 13:43:05 +00:00
desrosj
96a9d51e11 General: Add svn:mergeinfo missed in [48733].
Finishes merging [48729-48730] to the 5.5 branch.
See #50416.
Built from https://develop.svn.wordpress.org/branches/5.5@48740


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 19:46:04 +00:00
whyisjake
dc9e56955d WordPress 5.5 RC 2 post-release version bump.
Built from https://develop.svn.wordpress.org/branches/5.5@48739


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 19:18:04 +00:00
whyisjake
80f9c9b8ab WordPress 5.5 RC 2.
Built from https://develop.svn.wordpress.org/branches/5.5@48738


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 18:57:02 +00:00
Sergey Biryukov
8f16fd5be2 Help/About: Correct header spacing on shorter screens after removing the musician name.
Remove some unnecessary CSS.

Follow-up to [48730].

Props ryelle.
Reviewed by whyisjake, SergeyBiryukov.
Merges [48736] to the 5.5 branch.
See #50416.
Built from https://develop.svn.wordpress.org/branches/5.5@48737


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 18:13:05 +00:00
Sergey Biryukov
79e668950f Plugins: Move the "Successfully installed the plugin" string to the correct Plugin_Upgrader method.
The string refers to the installation, and belongs in the `::install_strings()` method, not in `::upgrade_strings()`.

Props sswebster, nateinaction.
Reviewed by whyisjake, SergeyBiryukov.
Merges [48734] to the 5.5 branch.
Fixes #50837.
Built from https://develop.svn.wordpress.org/branches/5.5@48735


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 18:04:05 +00:00
desrosj
b21d6c49ff Help/About: String updates and accessibility improvements to the 5.5 About page.
Merges [48729-48730] to the 5.5 branch.
Props audrasjb, SergeyBiryukov.
See #50416.
Built from https://develop.svn.wordpress.org/branches/5.5@48733


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 17:44:06 +00:00
whyisjake
d4dcfc37f6 Site Health: Display auto-update properly for plugins that don't support auto-updates.
Properly filter auto_update_plugin when displaying the table.

This brings the changes from [48731] to the 5.5 branch.

Fixes #50822.
Props Gwendydd, pbiron, audrasjb, SergeyBiryukov, whyisjake.

Built from https://develop.svn.wordpress.org/branches/5.5@48732


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 17:39:06 +00:00
Sergey Biryukov
4710457463 Editor: Update JS packages.
Props ellatrix.
Reviewed by youknowriad, SergeyBiryukov.
Merges [48725] to the 5.5 branch.
Fixes #50844.
Built from https://develop.svn.wordpress.org/branches/5.5@48728


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 17:06:24 +00:00
Sergey Biryukov
12d6a09ff5 Editor: Make some hardcoded strings in block patterns translatable.
Props ocean90.
Reviewed by youknowriad, SergeyBiryukov.
Merges [48726] to the 5.5 branch.
Fixes #50842.
Built from https://develop.svn.wordpress.org/branches/5.5@48727


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 17:04:05 +00:00
whyisjake
afbbb3baa5 Help/About: String update for 5.5 release.
We don't use hyphens for the [block editor](https://make.wordpress.org/core/handbook/best-practices/spelling/).

See #50416.
Props davidbaumwald, marybaum, desrosj.

Built from https://develop.svn.wordpress.org/branches/5.5@48723


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 15:59:10 +00:00
desrosj
067856838b Editor: update JS packages.
Merges [48719] to the 5.5 branch.
Fixes #50841.
Built from https://develop.svn.wordpress.org/branches/5.5@48720


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 14:04:32 +00:00
Andrea Fercia
bfc7b4f50b Accessibility: Administration: Address backward compatibility concerns for the sortable postboxes areas after [48340].
Merges [48717] to the 5.5 branch.
Fixes #49288 for 5.5.

Built from https://develop.svn.wordpress.org/branches/5.5@48718


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 13:30:06 +00:00
Sergey Biryukov
08a594aaae HTTP: Update the Root Certificate bundle.
Keep 1024-bit legacy root certificates re-added in [35919], except for those already expired, for compatibility with older OpenSSL versions.

Props barry, ayeshrajans, desrosj, whyisjake.
Reviewed by whyisjake, SergeyBiryukov.
Merges [48707] to the 5.5 branch.
See #50828.
Built from https://develop.svn.wordpress.org/branches/5.5@48708


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-01 14:13:03 +00:00
Aaron Jorbin
e4188db213 Build/Test Tools: Update grunt-patch-wordpress for 5.5
Trunk's update happened in [50829]

Seconded by whyisjake and SergeyBiryukov.
Fixes #50829.


Built from https://develop.svn.wordpress.org/branches/5.5@48706


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-31 19:22:23 +00:00
whyisjake
e3e4523695 Upgrade/Install: Ensure the proper count of plugins that have auto-update enabled.
As certain plugins may not support updates, this count needs to accurately reflect that in the navbar.

This brings the changes from [48703] to the WordPress 5.5 branch.

Fixes 50808.
Props knutsp, audrasjb, pbiron, dd32, apedog, afragen, chriscct7, garyc40, whyisjake, SergeyBiryukov.

Built from https://develop.svn.wordpress.org/branches/5.5@48704


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-31 17:24:03 +00:00
whyisjake
fc4dd704c2 Upgrade/Install: Allow for WordPress.org to remotely disable auto-updates for plugins/themes
As auto-updates are rolled out across WordPress.org, the API response can modulate the response, ensuring that a rolled out could be stalled or staggered if needed for security or performance reasons.

This brings the changes from [48701] to the 5.5 branch.

Fixes #50824.
Props dd32, whyisjake, SergeyBiryukov.

Built from https://develop.svn.wordpress.org/branches/5.5@48702


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-31 17:05:04 +00:00
whyisjake
fd27e2560b Upgrade/Install: Only show auto-update for themes that support the feature.
Similar to the changes for plugins in [48669], let's only show the UI for themes when updates are supported for that theme.

This brings the changes from [48688] to the 5.5 branch.

See #50280.
Props dd32.

Built from https://develop.svn.wordpress.org/branches/5.5@48698


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-30 22:04:05 +00:00
whyisjake
bb983b936c Upgrade/Install: Pass the plugin file path into the plugin_auto_update_debug_string filter.
Adds better tooling for when user specific plugins can be updated, but platform specific ones cannot.

This brings [48696] to the 5.5 branch.

Fixes #50821.

Props bpayton, pbiron, audrasjb, SergeyBiryukov, whyisjake.

Built from https://develop.svn.wordpress.org/branches/5.5@48697


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-30 21:52:07 +00:00
Sergey Biryukov
5ca7f64672 Help/About: Adjust two strings on the About page for better i18n.
Follow-up to [48675].

Props ocean90, audrasjb, kittmedia, nao.
Reviewed by desrosj, SergeyBiryukov.
Merges [48686] to the 5.5 branch.
See #50416.
Built from https://develop.svn.wordpress.org/branches/5.5@48691


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-30 12:15:04 +00:00
Sergey Biryukov
f6b9ae8a6f Themes: Pass correct variable to is_php_version_compatible() in wp_theme_update_row().
This applies to the Themes screen in Multisite network admin.

Follow-up to [48660].

Props pbiron, afragen.
Reviewed by peterwilsoncc, SergeyBiryukov.
Merges [48689] to the 5.5 branch.
Fixes #48507. See #48491.
Built from https://develop.svn.wordpress.org/branches/5.5@48690


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-30 11:46:05 +00:00
Sergey Biryukov
9e23c609e9 Upgrade/Install: Pass correct argument to clear_destination in Theme_Upgrader::install().
Follow-up to [48390].

Props afragen, sabernhardt.
Reviewed by desrosj, SergeyBiryukov.
Merges [48685] to the 5.5 branch.
Fixes #9757.
Built from https://develop.svn.wordpress.org/branches/5.5@48687


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-29 15:21:06 +00:00
Sergey Biryukov
807aa76d7e Branch 5.5
Built from https://develop.svn.wordpress.org/branches/5.5@48682


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 20:53:09 +00:00
whyisjake
0976fed6c8 Post WordPress 5.5 RC 1 version bump.
Built from https://develop.svn.wordpress.org/trunk@48681


git-svn-id: http://core.svn.wordpress.org/trunk@48443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 19:15:05 +00:00
whyisjake
fc1c3ab4a3 WordPress 5.5 RC 1.
Built from https://develop.svn.wordpress.org/trunk@48680


git-svn-id: http://core.svn.wordpress.org/trunk@48442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 18:54:03 +00:00
whyisjake
7788261f42 WordPress 5.5 RC 1.
Built from https://develop.svn.wordpress.org/trunk@48679


git-svn-id: http://core.svn.wordpress.org/trunk@48441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 18:50:02 +00:00
whyisjake
d8fd6d05a3 Upgrade/Install: Swap auto-update-supported to update-supported in update checks.
Ensures backwards compatability with external updaters.

See #50280.
Props everyone-in-the-core-updates-channel. 


Built from https://develop.svn.wordpress.org/trunk@48678


git-svn-id: http://core.svn.wordpress.org/trunk@48440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 18:28:06 +00:00
desrosj
6209a40fd9 Upgrade/Install: Clarify the descriptions for install_(plugin|theme)_overwrite_actions.
See #9757.
Built from https://develop.svn.wordpress.org/trunk@48677


git-svn-id: http://core.svn.wordpress.org/trunk@48439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 18:16:07 +00:00
desrosj
1aa48c68f5 Upgrade/Install: Correct spelling of “overwrite” in new hooks and array indexes.
See #9757.
Built from https://develop.svn.wordpress.org/trunk@48676


git-svn-id: http://core.svn.wordpress.org/trunk@48438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 17:56:04 +00:00
whyisjake
7267fc02b0 Help/About: WordPress 5.5 About Page.
Speed. Search. Security.

This is the start of the WordPress 5.5 about page. 

Fixes #50416. 
Props ryelle, marybaum, estelaris, yvettesonneveld, michelebutcher-jones, metalandcoffee, melchoyce, marktimemedia, abhanonstopnewsuk, elmastudio, davidbaumwald, audrasjb, afercia, cbringmann, andreamiddleton, desrosj, earnjam, SergeyBiryukov, whyisjake, elrae.

Built from https://develop.svn.wordpress.org/trunk@48675


git-svn-id: http://core.svn.wordpress.org/trunk@48437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 17:46:04 +00:00
Sergey Biryukov
404b1a4238 Login and Registration: Correct the logic for determining the path to wp-login.php in wp_lostpassword_url().
Follow-up to [48672], [48673].

See #39311.
Built from https://develop.svn.wordpress.org/trunk@48674


git-svn-id: http://core.svn.wordpress.org/trunk@48436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 17:44:06 +00:00
Sergey Biryukov
466a057422 Login and Registration: Only call get_blog_details() in wp_lostpassword_url() on Multisite.
The function does not exist on single site.

Follow-up to [48672].

See #39311.
Built from https://develop.svn.wordpress.org/trunk@48673


git-svn-id: http://core.svn.wordpress.org/trunk@48435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 17:40:05 +00:00
Sergey Biryukov
31702738d6 Login and Registration: Link to the correct site after activating a user on a Multisite install in subdirectory mode.
Props pkarjala, Mista-Flo, tmoore41, Ipstenu, ksoares, mukesh27, whyisjake.
Fixes #39311.
Built from https://develop.svn.wordpress.org/trunk@48672


git-svn-id: http://core.svn.wordpress.org/trunk@48434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 17:20:06 +00:00
Sergey Biryukov
eb0869755e Administration: Correct alignment of the "PHP Update Required" dashboard box title.
Restore one instance of `!important` CSS rule for backward compatibility.

Follow-up to [48129], [48373].

Props whyisjake, sabernhardt, TimothyBlynJacobs, SergeyBiryukov.
Fixes #50788.
Built from https://develop.svn.wordpress.org/trunk@48671


git-svn-id: http://core.svn.wordpress.org/trunk@48433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 17:08:03 +00:00
Sergey Biryukov
e4b2ad02b6 Administration: Don't override the $mode global in WP_Screen::render_view_mode() if it's already set.
Follow-up to [48398], [48423], [48424], [48450].

See #49715.
Built from https://develop.svn.wordpress.org/trunk@48670


git-svn-id: http://core.svn.wordpress.org/trunk@48432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 16:55:04 +00:00
whyisjake
0f1f9bdb03 Upgrade/Install: Enhance auto-updates to be disabled for plugins that don't suport updates.
This removes the toggle UI when updates aren't available. When plugins use the filter, the UI is updated to show that they are being controlled via code. And then removed entirely when not available.

See #50798.
Fixes #50280.

Props elrae, pbiron, SergeyBiryukov, audrasjb, azaozz, StephenCronin, whyisjake, dd32, TimothyBlynJacobs, desrosj.


Built from https://develop.svn.wordpress.org/trunk@48669


git-svn-id: http://core.svn.wordpress.org/trunk@48431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 16:32:01 +00:00
Sergey Biryukov
2bf5b5749f Administration: Pull the table_view_mode filter for now.
The extensibility of list table view modes will be explored in a future release.

Props audrasjb.
See #49715.
Built from https://develop.svn.wordpress.org/trunk@48668


git-svn-id: http://core.svn.wordpress.org/trunk@48430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 16:19:03 +00:00
Sergey Biryukov
3db534a988 Upgrade/Install: Disable the plugin/theme auto-updates UI if AUTOMATIC_UPDATER_DISABLED is defined and set as true.
Props pbiron, dd32.
Fixes #50798. See #50280.
Built from https://develop.svn.wordpress.org/trunk@48667


git-svn-id: http://core.svn.wordpress.org/trunk@48429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 16:15:03 +00:00
Sergey Biryukov
4cfc383544 Upgrade/Install: Check WordPress and PHP version requirements when uploading a plugin or theme from ZIP file.
Props mariovalney, desrosj.
See #50593.
Built from https://develop.svn.wordpress.org/trunk@48666


git-svn-id: http://core.svn.wordpress.org/trunk@48428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 16:07:02 +00:00
Sergey Biryukov
3da046e1bc Taxonomy: Rename the default_taxonomy_$taxonomy option key to default_term_$taxonomy.
This better reflects the purpose of the option.

Follow-up to [48356], [48480].

See #43517.
Built from https://develop.svn.wordpress.org/trunk@48665


git-svn-id: http://core.svn.wordpress.org/trunk@48427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 15:42:07 +00:00
Sergey Biryukov
38e6367808 Coding Standards: Reformat a condifion for default taxonomy terms in map_meta_cap() for better readability.
Follow-up to [48356], [48480].

See #43517.
Built from https://develop.svn.wordpress.org/trunk@48664


git-svn-id: http://core.svn.wordpress.org/trunk@48426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 14:42:04 +00:00
Sergey Biryukov
ba445c0a59 Taxonomy: Ensure the child_of argument of get_terms() works as expected with 'fields' => 'id=>name' or 'id=>slug'.
Props Howdy_McGee, deepaklalwani, planvova.
Fixes #46768.
Built from https://develop.svn.wordpress.org/trunk@48663


git-svn-id: http://core.svn.wordpress.org/trunk@48425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 14:23:04 +00:00
Sergey Biryukov
fbebb744b0 Bootstrap/Load: Remove the wp_environment_type and wp_get_environment_type filters.
Since `wp_get_environment_type()` runs too early for plugins to hook these filters, and the result is then cached in a static variable and cannot be changed later, the filters are not that useful.

The `WP_ENVIRONMENT_TYPES` and `WP_ENVIRONMENT_TYPE` constants and environment variables should be enough for now.

Follow-up to [47919], [48188], [48372].

Props Clorith, SergeyBiryukov.
Fixes #33161.
Built from https://develop.svn.wordpress.org/trunk@48662


git-svn-id: http://core.svn.wordpress.org/trunk@48424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 12:10:05 +00:00
Sergey Biryukov
0dd2f9f5c5 Docs: Add missing documentation for various upgrade/install class properties and methods.
Props ramiy.
Fixes #42923.
Built from https://develop.svn.wordpress.org/trunk@48661


git-svn-id: http://core.svn.wordpress.org/trunk@48423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 11:57:03 +00:00
Sergey Biryukov
a745f035ab Themes: Display a message on Themes list table if a theme update requires a higher version of PHP or WordPress.
This applies to the Themes screen in Multisite network admin.

Props afragen, SergeyBiryukov.
Fixes #48507. See #48491.
Built from https://develop.svn.wordpress.org/trunk@48660


git-svn-id: http://core.svn.wordpress.org/trunk@48422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 11:34:04 +00:00
Sergey Biryukov
e349d92b53 Themes: Include theme name in available update messages, for better accessibility and consistency with other similar messages.
Follow-up to [48652-48654].

See #48491.
Built from https://develop.svn.wordpress.org/trunk@48659


git-svn-id: http://core.svn.wordpress.org/trunk@48421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 11:31:01 +00:00
Sergey Biryukov
5f6d6a79e8 Docs: Document that various metadata functions return false for an invalid ID.
Props salcode.
See #40519.
Built from https://develop.svn.wordpress.org/trunk@48658


git-svn-id: http://core.svn.wordpress.org/trunk@48420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 10:15:04 +00:00
Mike Schroder
8c3d56919e Upgrade/Install: Improve wp_opcache_invalidate() performance.
Changes from using `preg_match()` based `.php` extension checking to using `substr()` in `wp_opcache_invalidate()`.

Props jnylen0, aaroncampbell, SergeyBiryukov, desrosj, mikeschroder.
Fixes #50784.
Built from https://develop.svn.wordpress.org/trunk@48657


git-svn-id: http://core.svn.wordpress.org/trunk@48419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 08:09:05 +00:00