When encountering an HTML tag with duplicate copies of an attribute the tag processor ignores the duplicate values, according to the specification. However, when removing an attribute it must remove all copies of that attribute lest one of the duplicates becomes the primary and it appears as if no attributes were removed.
In this patch we're adding tests that will be used to ensure that all attribute copies are removed from a tag when one is request to be removed.
**Before**
{{{#!php
<?php
$p = new WP_HTML_Tag_Processor( '<br id=one id="two" id='three' id>' );
$p->next_tag();
$p->remove_attribute( 'id' );
$p->get_updated_html();
// <br id="two" id='three' id>
}}}
**After**
{{{#!php
<?php
$p = new WP_HTML_Tag_Processor( '<br id=one id="two" id='three' id>' );
$p->next_tag();
$p->remove_attribute( 'id' );
$p->get_updated_html();
// <br>
}}}
Previously we have been overlooking duplicate attributes since they don't have an impact on what parses into the DOM. However, as one unit test affirmed (asserting the presence of the bug in the tag processor) when removing an attribute where duplicates exist this meant we ended up changing the value of an attribute instead of removing it.
In this patch we're tracking the text spans of the parsed duplicate attributes so that ''if'' we attempt to remove them then we'll have the appropriate information necessary to do so. When an attribute isn't removed we'll simply forget about the tracked duplicates. This involves some overhead for normal operation ''when'' in fact there are duplicate attributes on a tag, but that overhead is minimal in the form of integer pairs of indices for each duplicated attribute.
Props dmsnell, zieladam.
Merges [56684] to the 6.3 branch.
Fixes#58119.
Built from https://develop.svn.wordpress.org/branches/6.3@56685
git-svn-id: http://core.svn.wordpress.org/branches/6.3@56197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
In PHPUnit 10.3.5, 9.6.13 and 8.5.34, the child processes used for process isolation now use temporary files to communicate their result to the parent process.
This caused a failure in some tests that set the `open_basedir` PHP directive to a value that did not include `sys_get_temp_dir()`.
This adds `sys_get_temp_dir()` to the `open_basedir` value set by the tests to ensure that permission is still granted for the temporary directory.
PHPUnit uses `sys_get_temp_dir()`. To ensure the result is the same, Core's `get_temp_dir()` function is not used.
References:
- https://github.com/sebastianbergmann/phpunit/issues/5356
Props desrosj, mukesh27, SergeyBiryukov, costdev.
Merges [56622] to the 6.3 branch.
See #59394.
Built from https://develop.svn.wordpress.org/branches/6.3@56624
git-svn-id: http://core.svn.wordpress.org/branches/6.3@56136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
In `WP_Upgrader::delete_temp_backup()`, a malformed `sprintf()` call did not pass the value, triggering a Warning in PHP 7 and a Fatal Error in PHP 8.
This fixes the malformed `sprintf()` call by correctly passing the value.
Follow-up to [55720].
Props akihiroharai, afragen.
Merges [56550] to the 6.3 branch.
Fixes#59320.
Built from https://develop.svn.wordpress.org/branches/6.3@56582
git-svn-id: http://core.svn.wordpress.org/branches/6.3@56094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
When encountering elements that imply switching into the RAWTEXT parsing state,
the Tag Processor should skip processing until exiting the RAWTEXT state.
In this patch the Tag Processor does just that, except for the case of the
deprecated XMP element which implies further and more complicated rules.
There's an implicit assumption that the SCRIPT ENABLED flag in HTML parsing
is enabled so that the contents of NOSCRIPT can be skipped. Otherwise, it would
be required to parse the contents of that tag.
Props dmsnell.
Merges [56563] to the 6.3 branch.
Fixes#59292.
Built from https://develop.svn.wordpress.org/branches/6.3@56564
git-svn-id: http://core.svn.wordpress.org/branches/6.3@56076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This restores the GitHub Actions job responsible for automatically retrying a failed workflow once within the E2E testing workflow.
[56198] disabled Slack notifications for this workflow because of the increased number of timeout errors occurring after recent changes until they could be further investigated. Even though the signal-to-noise ration was way too high, there’s still benefit in retrying the workflow once to see if the timeout can be resolved without human intervention. The one retry attempt will not result in any Slack notifications.
Follow up to [56198].
Merges [56308] to the 6.3 branch.
See #58779.
Built from https://develop.svn.wordpress.org/branches/6.3@56539
git-svn-id: http://core.svn.wordpress.org/branches/6.3@56051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This fixes an issue introduced in [56044] in which the path to core block styles are cached to avoid expensive file operations on every page load. The original caching strategy is now modified so that only the path relative to the blocks location are stored, rather than the full path, since the path to the `wp-includes`` folder can change after the value is generated. The new cached value also includes the current WordPress version value to ensure it is rebuilt when the version changes.
Props lhe2012, coreyw, colorful tones, petitphp, mukesh27, spacedmonkey, joemcgill, flixos90, kimannwall, desmith.
Merges [56524] to the 6.3 branch.
Fixes#59111.
Built from https://develop.svn.wordpress.org/branches/6.3@56528
git-svn-id: http://core.svn.wordpress.org/branches/6.3@56040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This avoids an additional query by passing the query args directly to the `WP_Query::query()` method, rather than to the constructor and calling get_posts(), following [55569].
Props david.binda, azaozz, spacedmonkey, mukesh27, flixos90, SergeyBiryukov, joemcgill.
Merges [56491] to the 6.3 branch.
Fixes#59224.
Built from https://develop.svn.wordpress.org/branches/6.3@56516
git-svn-id: http://core.svn.wordpress.org/branches/6.3@56028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The original filter location is `wp_maybe_add_fetchpriority_high_attr()` in `wp-includes/media.php`.
This commit updates the instance in `wp_get_loading_optimization_attributes()` to point to the correct file.
Follow-up to [56037], [56143], [56347].
Props tmatsuur, rajinsharwar, khokansardar.
Reviewed by azaozz, audrasjb.
Merges [56386] to the 6.3 branch.
Fixes#59067.
Built from https://develop.svn.wordpress.org/branches/6.3@56429
git-svn-id: http://core.svn.wordpress.org/branches/6.3@55941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
If the available disk space exceeds the `PHP_INT_MAX` value, i.e. a 32-bit PHP version is in use with more than 2 GB free, the type casting to `(int)` could cause
an overflow, and the Site Health test would then erroneously report that there is not enough free space.
This commit removes the unnecessary type casting and uses the result from `disk_free_space()` directly.
Includes optimizing the logic to skip further checks if the available disk space could not be determined.
Follow-up to [55720].
Props mathsgrinds, Presskopp, rajinsharwar, SergeyBiryukov.
Reviewed by azaozz, audrasjb.
Merges [56401] to the 6.3 branch.
Fixes#59116.
Built from https://develop.svn.wordpress.org/branches/6.3@56428
git-svn-id: http://core.svn.wordpress.org/branches/6.3@55940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
If `$blog_id` equals `0`, it should be treated as the current site ID, and there is no need to switch to a different site.
This commit prevents an unnecessary call to `switch_to_blog()` on single site to avoid a fatal error when using `'orderby' => 'post_count'` and the deprecated
`'who' => 'authors'` parameter:
`Uncaught Error: Call to undefined function switch_to_blog() in wp-includes/class-wp-user-query.php:1077`
Follow-up to [55657].
Props dd32, austinginder, RavanH, mukesh27.
Reviewed by azaozz, audrasjb.
Merges [56381] to the 6.3 branch.
Fixes#59011.
Built from https://develop.svn.wordpress.org/branches/6.3@56427
git-svn-id: http://core.svn.wordpress.org/branches/6.3@55939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Fixes the error handling for when `WP_Classic_To_Block_Menu_Converter::convert()` returns an instance of `WP_Error`.
`WP_Navigation_Fallback::create_classic_menu_fallback()` now checks for `is_wp_error()` and if `true`, returns the error. And the `@return` type is updated to
`string|WP_Error`.
Also includes a fix in the return type in `WP_Classic_To_Block_Menu_Converter::convert()` to return an empty string instead of an array instead, i.e. when bailing
out for no menu items returned by `wp_get_nav_menu_items()`. The return type is clearly documented as a string.
Follow-up to [56052].
Props dlh, get_dave, antonvlasenko, hellofromTonya.
Reviewed by azaozz, audrasjb.
Merges [56422] to the 6.3 branch.
Fixes#58823.
--Cette ligne, et les suivantes ci-dessous, seront
ignorées--
_M .
M src/wp-includes/class-wp-classic-to-block-menu-converter.php
M src/wp-includes/class-wp-navigation-fallback.php
M tests/phpunit/tests/editor/classic-to-block-menu-converter.php
Built from https://develop.svn.wordpress.org/branches/6.3@56426
git-svn-id: http://core.svn.wordpress.org/branches/6.3@55938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Includes fixes for footnotes and editor styles related crashes, as well as a cut and paste-related crash.
This changeset partially merges [56419] to the 6.3 branch as the package-lock had to be rebuilt due to the release branch still using node 14.x.x, and some manual
editing was necessary due to the unresolved floating-ui dependency issue.
Props ramonopoly, isabel_brison.
Reviewed by azaozz, audrasjb.
Merges [56419] to the 6.3 branch.
See #59151.
Built from https://develop.svn.wordpress.org/branches/6.3@56423
git-svn-id: http://core.svn.wordpress.org/branches/6.3@55935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The `{min|max}-device-pixel-ratio` syntax as a a non-standard CSS media feature that was used as an alternative to the now standard `resolution`. Prior to Safari 16.0, `-webkit-{min|max}-device-pixel-ratio` was needed to correctly support it.
This change is a result of the `caniuse-lite` update that was applied recently in [56065]. Though there were no changes to target browsers as a result of this update, it seems an upstream change identified these as unnecessary.
Props desrosj, joemcgill, isabel_brison, SergeyBiryukov, azaozz.
Reviewed by SergeyBiryukov, azaozz.
Backports [56279] to the 6.3 branch.
Fixes#57856.
Built from https://develop.svn.wordpress.org/branches/6.3@56367
git-svn-id: http://core.svn.wordpress.org/branches/6.3@55879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
With the introduction of temporary backups of plugins and themes before updating, a new Site Health test was added to verify that plugin and theme temporary backup directories are writable or can be created.
When using a non-direct filesystem, the Site Health test did not include the required credentials, leading to a fatal error as the connection was not initialized properly.
This commit attemps to use the stored credentials if available, and displays a message otherwise.
Includes a similar fix in a function that performs a cleanup of the temporary backup directory.
Follow-up to [55720].
Props utsav72640, rajinsharwar, costdev, mukesh27, peterwilsoncc, audrasjb, SergeyBiryukov.
Reviewed by audrasjb, SergeyBiryukov.
Merges [56341] to the 6.3 branch.
See #58940.
Built from https://develop.svn.wordpress.org/branches/6.3@56342
git-svn-id: http://core.svn.wordpress.org/branches/6.3@55854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
In coordination with the release of 6.3, a new version of each bundled theme will also be released. This bumps the version of each theme to the following:
- Twenty Ten: 3.9
- Twenty Eleven: 4.4
- Twenty Twelve: 4.0
- Twenty Thirteen: 3.9
- Twenty Fourteen: 3.7
- Twenty Fifteen: 3.5
- Twenty Sixteen: 3.0
- Twenty Seventeen: 3.3
- Twenty Nineteen: 2.6
- Twenty Twenty: 2.3
- Twenty Twenty-One: 1.9
- Twenty Twenty-Two: 1.5
- Twenty Twenty-Three: 1.2
Props mukesh27, hareesh-pillai, audrasjb, jakariaistauk, kafleg, sabernhardt, spacedmonkey.
Reviewed by audrasjb, spacedmonkey.
Merges [56315] to the 6.3 branch.
Fixes#57857.
Built from https://develop.svn.wordpress.org/branches/6.3@56318
git-svn-id: http://core.svn.wordpress.org/branches/6.3@55830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit updates the link URL to send contributors to an orientation tool for a short survey on what team they may be interested in joining. This coincides with the Get Involved tab.
Follow-up to [17877], [26354], [35898], [43032], [56220].
Props courane01, audrasjb.
Reviewed by audrasjb, SergeyBiryukov.
Merges [56311] to the 6.3 branch.
See #23348.
Built from https://develop.svn.wordpress.org/branches/6.3@56312
git-svn-id: http://core.svn.wordpress.org/branches/6.3@55824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changeset replaces `add_action( 'enqueue_block_editor_assets' )`, with `add_action( 'enqueue_block_assets' )`, in class `Twenty_Twenty_One_Dark_Mode` and class
`Twenty_Twenty_One_Custom_Colors`. This fixes an issue when activating dark mode in Twenty Twenty-One, where dark mode was not enabled in the block editor.
Props poena, mikinc860, huzaifaalmesbah, hasanuzzamanshamim, Ankit-K-Gupta.
Reviewed by desrosj, audrasjb.
Merges [56300] to the 6.3 branch.
Fixes#58835.
Built from https://develop.svn.wordpress.org/branches/6.3@56304
git-svn-id: http://core.svn.wordpress.org/branches/6.3@55816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Previously, Site Editor client-side routing started using only the path query argument for loading non-editor views. The router removed the `postType` query
argument, which caused an error message to be displayed when the template parts list page was reloaded.
This changeset fixes the issue as it was affecting hybrid themes.
Props Mamaduka, isabel_brison, ramonopoly.
Reviewed by isabel_brison, audrasjb.
Merges [56302] to the 6.3 branch.
Fixes#58889.
Built from https://develop.svn.wordpress.org/branches/6.3@56303
git-svn-id: http://core.svn.wordpress.org/branches/6.3@55815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
