Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-07 19:31:54 +01:00
Code Issues Projects Releases Wiki Activity
30,868 Commits 50 Branches 747 Tags 791 MiB
5a77c96ea6
Commit Graph

4625 Commits

Author SHA1 Message Date
Scott Taylor
42b6ac80e7 Ensure that attachment_url_to_postid() matches cross-scheme when front-end and back-end schemes are different. 
Adds unit test.

Props welcher.
Fixes #33109.

Built from https://develop.svn.wordpress.org/trunk@33705


git-svn-id: http://core.svn.wordpress.org/trunk@33672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-22 16:39:25 +00:00
Scott Taylor
f2a9cd365b update-core.php help docs, update string to include translations: themes, plugins, and translations 
Props netweb, DrewAPicture.
Fixes #28201.

Built from https://develop.svn.wordpress.org/trunk@33704


git-svn-id: http://core.svn.wordpress.org/trunk@33671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-22 16:25:28 +00:00
Dominik Schilling
f0a89de3d4 Tests: Fix a typo in function names for $autoload tests. 
Autoload is "no" if the `$autoload` param for `update_option()` is `'no'` or `false`.

see #26394.
Built from https://develop.svn.wordpress.org/trunk@33703


git-svn-id: http://core.svn.wordpress.org/trunk@33670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-22 09:45:27 +00:00
Dominik Schilling
888af781b2 Tests: Skip some tests for the Transients API when an external object cache is in use. 
`test_transient_data_with_timeout()`, `test_transient_add_timeout()`, `test_nonexistent_key_dont_delete_if_false()`, and `test_nonexistent_key_old_timeout` are testing option values which aren't available with an an external object cache like memcache.

see #31491.
Built from https://develop.svn.wordpress.org/trunk@33702


git-svn-id: http://core.svn.wordpress.org/trunk@33669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 20:33:26 +00:00
Scott Taylor
029c274b86 In wpdb::get_col_length(), breaks are not necessary when a case returns 
See #33491.

Built from https://develop.svn.wordpress.org/trunk@33701


git-svn-id: http://core.svn.wordpress.org/trunk@33668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 18:41:25 +00:00
Scott Taylor
3982598305 Doc block for_wp_specialchars: $quote_style can also be string ('single' or 'double') 
See #33491.

Built from https://develop.svn.wordpress.org/trunk@33700


git-svn-id: http://core.svn.wordpress.org/trunk@33667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 18:36:24 +00:00
Scott Taylor
2a44bc6a59 In _WP_Editors::editor_settings(), $first_run is unused. 
See #33491.

Built from https://develop.svn.wordpress.org/trunk@33699


git-svn-id: http://core.svn.wordpress.org/trunk@33666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 18:30:24 +00:00
Aaron Jorbin
ece59bf72a Add new constant MONTH_IN_SECONDS and expand time convenience documentation. 
The "month" isn't really a month.  It's a WordPress Month. As the docs make clear, it's not about accuracy as much as it about convenience.  This adds a missing step in the time convenience constants. 

Props egill
Fixes #33397



Built from https://develop.svn.wordpress.org/trunk@33698


git-svn-id: http://core.svn.wordpress.org/trunk@33665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 18:16:25 +00:00
Scott Taylor
0fa7f817c4 In wp_ajax_add_meta(), do not juggle the value of $_POST and alter it directly. This was done so that edit_post() could pull $_POST out of the air by-reference and alter it (equally as bad). edit_post() accepts a $post_data array. Do that instead. 
See #33491.

Built from https://develop.svn.wordpress.org/trunk@33697


git-svn-id: http://core.svn.wordpress.org/trunk@33664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 18:13:24 +00:00
Weston Ruter
cb2879b9d4 Widgets: Switch back to using array_key_exists() instead of isset() for widget instance existence check. 
Reverts unnecessary change in [32602] since `array_key_exists()` does actually work with `ArrayIterator` objects.

See #32474.
Fixes #33442.

Built from https://develop.svn.wordpress.org/trunk@33696


git-svn-id: http://core.svn.wordpress.org/trunk@33663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 18:09:25 +00:00
Scott Taylor
db32f96d8a Make 'Docs Committer' translatable. 
Props dimadin. 
Fixes #33424.

Built from https://develop.svn.wordpress.org/trunk@33695


git-svn-id: http://core.svn.wordpress.org/trunk@33662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 17:47:25 +00:00
Scott Taylor
3d780c6a4b Clarify doc entry for _wp_customize_include() 
Props ericlewis. 
Fixes #33488.

Built from https://develop.svn.wordpress.org/trunk@33694


git-svn-id: http://core.svn.wordpress.org/trunk@33661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 17:45:25 +00:00
Scott Taylor
e9305edbce When createing "Sample Page" on install, comments should be closed. 
Props macmanx. 
Fixes #33490.

Built from https://develop.svn.wordpress.org/trunk@33693


git-svn-id: http://core.svn.wordpress.org/trunk@33660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 17:42:25 +00:00
Scott Taylor
fa2d0a2d55 Comment List Tables: 
* Toggle visibility of pending bubble when a comment is dynamically moderated
* Add a CSS class to the pending bubble to hide it / remove to show it

See #11200.

Built from https://develop.svn.wordpress.org/trunk@33692


git-svn-id: http://core.svn.wordpress.org/trunk@33659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 17:26:26 +00:00
Drew Jaynes
54b2e39fdd Docs: Add a changelog entry for the $post_type parameter added to the restrict_manage_posts hook in [33644]. 
Props pavelevap
Fixes #17891.

Built from https://develop.svn.wordpress.org/trunk@33691


git-svn-id: http://core.svn.wordpress.org/trunk@33658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 16:12:25 +00:00
Drew Jaynes
0e4285c451 Docs: Fix a typo in the DocBlock description for _get_additional_user_keys(), introduced in [33687]. 
Props dimadin
See #29120.

Built from https://develop.svn.wordpress.org/trunk@33690


git-svn-id: http://core.svn.wordpress.org/trunk@33657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 16:01:28 +00:00
Helen Hou-Sandí
514caf0120 List tables: Allow filtering of hidden and default hidden columns. 
Similar to `get_hidden_meta_boxes()`, there are now filters named `default_hidden_columns` and `hidden_columns`.

props Compute, MikeHansenMe, chriscct7.
fixes #32499.

Built from https://develop.svn.wordpress.org/trunk@33689


git-svn-id: http://core.svn.wordpress.org/trunk@33656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 15:32:29 +00:00
Dion Hulse
09da29102b WP_Filesystem: SSH2 handler: Remove support for is_writable() via SSH, it turns out PHP doesn't verify the writability via SFTP and instead uses a comparison based on the current php system process user instead of the ssh user. 
This fixes the 'The update cannot be installed because we will be unable to copy some files.' error encountered during updates by skipping the write test completely.

Props jobst.
Fixes #33480 for trunk

Built from https://develop.svn.wordpress.org/trunk@33688


git-svn-id: http://core.svn.wordpress.org/trunk@33655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 11:43:25 +00:00
Drew Jaynes
6d405d34da Docs: Clarify the DocBlock summary and add a description and return description for _get_additional_user_keys(). 
As noted in the description, returned keys being set is dependent on the existence of those keys in user meta at the point where `_get_additional_user_keys()` is called in `wp_update_user()`.

Fixes #29120.

Built from https://develop.svn.wordpress.org/trunk@33687


git-svn-id: http://core.svn.wordpress.org/trunk@33654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 05:33:25 +00:00
Drew Jaynes
93009543bc Docs: Fix some minor inline documentation syntax issues in the hook docs for the post_edit_category_parent_dropdown_args filter, introduced in [33682]. 
See #32246. See #33026.

Built from https://develop.svn.wordpress.org/trunk@33686


git-svn-id: http://core.svn.wordpress.org/trunk@33653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 04:54:26 +00:00
Drew Jaynes
416df545ba Docs: Fix a variety of inline documentation syntax issues and add some strategic spacing. 
Fixes #29086.

Built from https://develop.svn.wordpress.org/trunk@33685


git-svn-id: http://core.svn.wordpress.org/trunk@33652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 04:13:24 +00:00
Drew Jaynes
3bb87e08e4 Docs: Add missing @access tags to properties and methods in wp-admin/includes/class-wp-upgrader. 
See #29086.

Built from https://develop.svn.wordpress.org/trunk@33684


git-svn-id: http://core.svn.wordpress.org/trunk@33651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 04:05:25 +00:00
Drew Jaynes
73d6dec8eb Docs: Correct a typo in the summary for the Theme_Upgrader->bulk property. 
Also adds a couple of missing `@access` tags.

Props kraftbj
See #29086.

Built from https://develop.svn.wordpress.org/trunk@33683


git-svn-id: http://core.svn.wordpress.org/trunk@33650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 03:15:25 +00:00
Boone Gorges
52614b491a Filter the arguments passed to wp_dropdown_categories() in the Categories post edit metabox. 
The new 'post_edit_category_parent_dropdown_args' provides parity with other
places in wp-admin where `wp_dropdown_categories()` args are filtered, such as
'taxonomy_parent_dropdown_args'.

Props theMikeD.
Fixes #33026.
Built from https://develop.svn.wordpress.org/trunk@33682


git-svn-id: http://core.svn.wordpress.org/trunk@33649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 01:28:25 +00:00
Boone Gorges
8b15f8be3d In Walker_CategoryDropdown::start_el(), cast values to strings before deciding whether to append 'selected' attribute. 
As of [32484], `wp_dropdown_categories()` uses the `$value_field` value to
decide whether a given `<option>` should be 'selected'. However, `$value_field`
can refer to a value that is a string, such as a category's slug. This causes
problems when doing a loose comparison (`==`) with the value of the `'selected'`
parameter, which defaults to `0`, because when doing a loose comparison
between an integer and a string, PHP will cast the string to an integer. This
creates false matches, resulting in `<option>` elements getting a 'selected'
attribute incorrectly.

We address the issue by casting the comparison values to strings, and then
using the strict comparison operator `===`.

Fixes #33452 for trunk.
Built from https://develop.svn.wordpress.org/trunk@33681


git-svn-id: http://core.svn.wordpress.org/trunk@33648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 01:11:26 +00:00
Drew Jaynes
b407bb0936 Docs: Standardize @deprecated tag formatting in the DocBlock for the logIO() function. 
Props Alphawolf.
Fixes #28806.

Built from https://develop.svn.wordpress.org/trunk@33680


git-svn-id: http://core.svn.wordpress.org/trunk@33647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 22:44:25 +00:00
Drew Jaynes
4770601d73 Docs: Standardize @deprecated tag formatting in the DocBlocks for several wpdb methods. 
Props Alphawolf.
See #28806.

Built from https://develop.svn.wordpress.org/trunk@33679


git-svn-id: http://core.svn.wordpress.org/trunk@33646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 22:42:25 +00:00
Drew Jaynes
bf371f1577 Docs: Standardize @deprecated tag formatting in the DocBlock for WP_Object_Cache:reset(). 
Props Alphawolf.
See #28806.

Built from https://develop.svn.wordpress.org/trunk@33678


git-svn-id: http://core.svn.wordpress.org/trunk@33645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 22:39:24 +00:00
Drew Jaynes
02ec47fc92 Docs: Standardize @deprecated tag formatting in the DocBlock for wp_xmlrpc_server::login_pass_ok(). 
Props Alphawolf.
See #28806.

Built from https://develop.svn.wordpress.org/trunk@33677


git-svn-id: http://core.svn.wordpress.org/trunk@33644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 22:38:25 +00:00
Drew Jaynes
eaab0e72a6 Docs: Standardize @deprecated tag formatting and add missing summaries to deprecated functions in wp-includes/ms-deprecated.php. 
Props Alphawolf for the initial patch.
Props DrewAPicture

See #28806.

Built from https://develop.svn.wordpress.org/trunk@33676


git-svn-id: http://core.svn.wordpress.org/trunk@33643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 22:36:25 +00:00
Drew Jaynes
c8638a285a Docs: Standardize @deprecated tag formatting for deprecated functions in wp-admin/includes/ms-deprecated.php. 
Props Alphawolf for the initial patch
Props DrewAPicture

See #28806.

Built from https://develop.svn.wordpress.org/trunk@33675


git-svn-id: http://core.svn.wordpress.org/trunk@33642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 22:26:24 +00:00
Drew Jaynes
b2dcf3d1f4 Docs: Standardize @deprecated tag formatting for deprecated functions in wp-includes/pluggable-deprecated.php. 
Props Alphawolf for the initial patch.
Props DrewAPicture.

See #28806.

Built from https://develop.svn.wordpress.org/trunk@33674


git-svn-id: http://core.svn.wordpress.org/trunk@33641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 22:15:25 +00:00
Drew Jaynes
e9f1e69b23 Docs: Standardize @deprecated tag formatting and add missing DocBlock summaries to deprecated functions in wp-includes/deprecated.php. 
Props Alphawolf for the initial patch.
Props DrewAPicture.

See #28806.

Built from https://develop.svn.wordpress.org/trunk@33673


git-svn-id: http://core.svn.wordpress.org/trunk@33640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 22:11:26 +00:00
Scott Taylor
6f9aa6df03 After [33666], fix broken sprintf cruff. 
See #17609.

Built from https://develop.svn.wordpress.org/trunk@33672


git-svn-id: http://core.svn.wordpress.org/trunk@33639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 21:37:24 +00:00
Drew Jaynes
bac6e69b3c Docs: Standardize @deprecated tag formatting and add missing DocBlocks to deprecated functions in wp-admin/includes/deprecated.php. 
Opted not to use the multi-function DocBlock syntax in the name of not taking shortcuts in documentation for the sake of brevity.

Props Alphawolf for the initial patch.
See #28806

Built from https://develop.svn.wordpress.org/trunk@33671


git-svn-id: http://core.svn.wordpress.org/trunk@33638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 21:23:25 +00:00
Drew Jaynes
c36c4efea6 Docs: Add a missing summary to the DocBlock for wp_media_upload_handler(). 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@33670


git-svn-id: http://core.svn.wordpress.org/trunk@33637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 21:01:25 +00:00
Scott Taylor
677d47ebc5 In wp_get_attachment_link(), accept an id or WP_Post as the first parameter. 
Props several27, DrewAPicture.
Fixes #33277.

Built from https://develop.svn.wordpress.org/trunk@33669


git-svn-id: http://core.svn.wordpress.org/trunk@33636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 20:32:26 +00:00
Drew Jaynes
89c39e7eab Docs: Clarify the different return conditions in the DocBlock for WP_List_Table->handle_row_actions(). 
This clarification follows the introduction of primary columns in 4.3. See #33313.

Props morganestes.
Fixes #33436.

Built from https://develop.svn.wordpress.org/trunk@33668


git-svn-id: http://core.svn.wordpress.org/trunk@33635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 20:22:25 +00:00
Scott Taylor
4254f22c2d In WP_Posts_List_Table::inline_edit(), check that $post_formats[0] is an array before traversing. 
Props DrewAPicture.
Fixes #33025.


Built from https://develop.svn.wordpress.org/trunk@33667


git-svn-id: http://core.svn.wordpress.org/trunk@33634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 20:19:25 +00:00
Scott Taylor
4694c477d3 Custom Post Types: 
* Introduce `is_post_type_viewable( $post_type_object )`
* Separate the HTML bits from the translatable bits in the `post` messages array in `edit-form-advanced.php`
* Don't show certain UI pieces when a post is not viewable on the front end

When a custom post type item is not viewable on the front end, we don't want to show links to View it (on the front end) all over the admin. We also want to hide the Preview link, et al. We also want our admin messages to not contain said links.

Custom post types with `public_queryable` set to `false` are not viewable on the front end. 
`'page'` is viewable on the front end, but `'page'` is a `_builtin` type, and `public_queryable` is set to `false` when it is registered - see `WP::parse_request()` for when `public_queryable` gets used.

This is confusing, but also somewhat straightforward: to determine if a post type is viewable on the front end, we can check one way for `_builtin => true` and another way for `_builtin => false`:

`$post_type->publicly_queryable || ( $post_type->_builtin && $post_type->public )`

If a post type is `publicly_queryable`, it's viewable. If that value is `false`, it is viewable if it's a `_builtin` type that is also `public`.

I am in search of edge cases, so this shall land.

Props wonderboymusic, DrewAPicture.
See #17609.

Built from https://develop.svn.wordpress.org/trunk@33666


git-svn-id: http://core.svn.wordpress.org/trunk@33633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 19:40:25 +00:00
Drew Jaynes
a7b38bf90a Docs: Correct the phpDoc type to a boolean for the $single parameter in the get_{$meta_type}_metadata hook docs. 
Props dlh.
Fixes #33451.

Built from https://develop.svn.wordpress.org/trunk@33665


git-svn-id: http://core.svn.wordpress.org/trunk@33632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 19:36:25 +00:00
Drew Jaynes
bec5bcf717 Docs: Mark the $notify parameter in the DocBlock for wp_new_user_notification() as optional, and provide additional context on the difference between the accepted values. 
See [33620] and [33023] for background.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@33664


git-svn-id: http://core.svn.wordpress.org/trunk@33631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 18:26:26 +00:00
Scott Taylor
d65112d382 After [33662], remove unused var. 
See #11200.

Built from https://develop.svn.wordpress.org/trunk@33663


git-svn-id: http://core.svn.wordpress.org/trunk@33630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 17:19:25 +00:00
Scott Taylor
20f6db2b18 Comment List Tables: 
* Ensure that dynamic bubble counts are in sync by `comment_post_ID`
* Scope `:animated` to `#the-comment-list`

See #11200.


Built from https://develop.svn.wordpress.org/trunk@33662


git-svn-id: http://core.svn.wordpress.org/trunk@33629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 16:36:25 +00:00
Dominik Schilling
6d45b63562 WordPress 4.3 has just passed 2,222,222 downloads. 
(Fix typo in [33653].)
Built from https://develop.svn.wordpress.org/trunk@33661


git-svn-id: http://core.svn.wordpress.org/trunk@33628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 16:00:28 +00:00
Scott Taylor
0e4606c13e JSHint after [33655]. 
Built from https://develop.svn.wordpress.org/trunk@33660


git-svn-id: http://core.svn.wordpress.org/trunk@33627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 06:31:25 +00:00
Scott Taylor
45fc6a3def Deprecate post_permalink() (Introduced in 1.0, already had a deprecated argument in 1.3), which just wraps get_permalink() and was only used by XML-RPC in 4 places. 
Props solarissmoke.
Fixes #16982.

Built from https://develop.svn.wordpress.org/trunk@33659


git-svn-id: http://core.svn.wordpress.org/trunk@33626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 06:24:26 +00:00
Scott Taylor
1fd0dcbc9e Ensure that feeds are served with the proper Content-Type HTTP header. 
Props stevenkword.
Fixes #32024.

Built from https://develop.svn.wordpress.org/trunk@33658


git-svn-id: http://core.svn.wordpress.org/trunk@33625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 06:10:24 +00:00
Scott Taylor
2e2223ae74 Comments List Table: 
* In a view that initially has comments, but they get removed due to user actions: show the `No Items` row instead of bombing out and showing nothing (which looks broken)
* To accomplish this, in `WP_Comments_List_Table::display()`: call `->display_rows_or_placeholder()` instead of `->display()`
* Listen for the end of row `.fadeOut()`s if necessary using jQuery Promises

Fixes #11200.

Built from https://develop.svn.wordpress.org/trunk@33657


git-svn-id: http://core.svn.wordpress.org/trunk@33624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 05:54:25 +00:00
Scott Taylor
657d0f6918 Comments List Table: 
* Properly increment/decrement approved/pending bubbles in `response` column

See #11200.

Built from https://develop.svn.wordpress.org/trunk@33656


git-svn-id: http://core.svn.wordpress.org/trunk@33623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 04:02:24 +00:00
Scott Taylor
df618f3461 Comments List Table: 
* Show count next to "Approved"
* Properly increment/decrement counts when row actions are clicked
* In `_wp_ajax_delete_comment_response()`, return the comment's `status` with the `supplemental` data
* Handle counts properly on each scenario of `undo`

See #11200.

Built from https://develop.svn.wordpress.org/trunk@33655


git-svn-id: http://core.svn.wordpress.org/trunk@33622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 02:51:25 +00:00
Scott Taylor
572a0a587a Comments shouldn't have more than one _wp_trash_meta_status entry. When deleting _wp_trash_meta_status, also delete _wp_trash_meta_time. 
See #11200.

Built from https://develop.svn.wordpress.org/trunk@33654


git-svn-id: http://core.svn.wordpress.org/trunk@33621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 02:45:26 +00:00
Boone Gorges
7c0d3ab83a Introduce post_name__in parameter for WP_Query. 
Props enshrined.
Fixes #33065.
Built from https://develop.svn.wordpress.org/trunk@33653


git-svn-id: http://core.svn.wordpress.org/trunk@33620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 02:19:25 +00:00
Boone Gorges
bc592af91f wp_update_term() should return a true integer for 'term_taxonomy_id'. 
Props ipm-frommen.
Fixes #32876.
Built from https://develop.svn.wordpress.org/trunk@33652


git-svn-id: http://core.svn.wordpress.org/trunk@33619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 19:33:24 +00:00
Konstantin Obenland
f770303868 Themes: Prevent short descriptions from wrapping version info. 
Props mehulkaklotar for initial patch.
Fixes #33248.


Built from https://develop.svn.wordpress.org/trunk@33651


git-svn-id: http://core.svn.wordpress.org/trunk@33618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 19:10:24 +00:00
Konstantin Obenland
2849e2c5e9 Themes: Open preview when requesting a single theme in the installer. 
Props kraftner, obenland.
Fixes #28735.


Built from https://develop.svn.wordpress.org/trunk@33650


git-svn-id: http://core.svn.wordpress.org/trunk@33617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 18:54:27 +00:00
Dion Hulse
a32d83586e Upgrades: When upgrading via FTP, use LIST -a to detect if a file exists. 
`LIST` & `NLST` by default on some servers require the `-a` flag to view hidden files (ie. `.maintenance`)
Although we could simply pass the `-a` flag to `NLST`, opting to use `LIST` which we use elsewhere should mean less chance of server incompatibilities.

Props jcroucher.
Fixes #28013.

Built from https://develop.svn.wordpress.org/trunk@33648


git-svn-id: http://core.svn.wordpress.org/trunk@33615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 12:38:25 +00:00
Dion Hulse
25c5d372d3 Term Splitting: Fix a reversal of parameters to wp_schedule_single_event() introduced in [33621]. 
The existing invalid cron entries will not be purged automatically (as the 'timestamp' is never matched) so we do this ourselves.

Props mechter for noticing!
See #30261.
Fixes #33423 for trunk.

Built from https://develop.svn.wordpress.org/trunk@33646


git-svn-id: http://core.svn.wordpress.org/trunk@33613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 11:31:26 +00:00
Dion Hulse
096b2f58fa Fix PHP notice after [33492] when updating themes. 
Props bobbingwide.
See #33208.
Fixes #33427.

Built from https://develop.svn.wordpress.org/trunk@33645


git-svn-id: http://core.svn.wordpress.org/trunk@33612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 10:35:25 +00:00
Scott Taylor
3923017f82 The 'restrict_manage_posts' hook currently fires on the Post and Media list tables, but is passed zero arguments. Pass $post_type. 
Props sunnyratilal, scribu.
Fixes #17891.

Built from https://develop.svn.wordpress.org/trunk@33644


git-svn-id: http://core.svn.wordpress.org/trunk@33611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 06:23:25 +00:00
Scott Taylor
b19bb99853 Playlists, for .wp-playlist-item-title elements: move the curly quotes to CSS pseudo-element content, making them easier to override or remove. 
Fixes #33391.

Built from https://develop.svn.wordpress.org/trunk@33643


git-svn-id: http://core.svn.wordpress.org/trunk@33610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 05:51:25 +00:00
Scott Taylor
07c079cc86 WP_Embed::maybe_run_ajax_cache() doesn't hook to pages, because it only happens on 'edit_form_advanced', not 'edit_page_form'. Make sure it runs for pages as well. This was probably not intentional, see [29557]. 
Fixes #32418.

Built from https://develop.svn.wordpress.org/trunk@33642


git-svn-id: http://core.svn.wordpress.org/trunk@33609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 05:40:24 +00:00
Scott Taylor
c15a1c2bab Replace some hyphens with &mdash;s in admin help tabs. 
Props pixolin.
Fixes #30605.

Built from https://develop.svn.wordpress.org/trunk@33641


git-svn-id: http://core.svn.wordpress.org/trunk@33608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 04:53:25 +00:00
Scott Taylor
8af2dbc671 Correct punctuation/case for inline comment in async-upload.php 
Props chriscct7.
Fixes #33408.

Built from https://develop.svn.wordpress.org/trunk@33640


git-svn-id: http://core.svn.wordpress.org/trunk@33607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-18 23:35:25 +00:00
Scott Taylor
23f62a59da Correct typo in doc block for WP_Filesystem_ftpsockets::rmdir 
Props Toro_Unit.
Fixes #33255.

Built from https://develop.svn.wordpress.org/trunk@33639


git-svn-id: http://core.svn.wordpress.org/trunk@33606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-18 23:33:24 +00:00
Scott Taylor
227d38c9cd Correct typo in JSDoc for wp.updates.decrementCount 
Props mt8.biz.
Fixes #33363.

Built from https://develop.svn.wordpress.org/trunk@33638


git-svn-id: http://core.svn.wordpress.org/trunk@33605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-18 21:47:25 +00:00
Scott Taylor
0b29061b3d Fix case type in docs for get_children(). 
Props bobbingwide.
Fixes #33364.

Built from https://develop.svn.wordpress.org/trunk@33637


git-svn-id: http://core.svn.wordpress.org/trunk@33604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-18 21:39:24 +00:00
Helen Hou-Sandí
0c89678c9b Trunk is now 4.4-alpha. 
Built from https://develop.svn.wordpress.org/trunk@33636


git-svn-id: http://core.svn.wordpress.org/trunk@33603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-18 19:32:26 +00:00
Konstantin Obenland
2e73c24e30 WordPress 4.3 
Built from https://develop.svn.wordpress.org/trunk@33633


git-svn-id: http://core.svn.wordpress.org/trunk@33600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-18 18:02:25 +00:00
Konstantin Obenland
e36a91efe4 About: Use actual locale and not subtitle debug cruft. 
H/t dimadin.

See #32929.

Built from https://develop.svn.wordpress.org/trunk@33632


git-svn-id: http://core.svn.wordpress.org/trunk@33599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-18 17:07:26 +00:00
Konstantin Obenland
d55738d327 About: Update release video to use the correct ID. 
Also adjusts locale handling to work with Videopress' subtitle implementation.

Props siobhan, jacklenox, sararosso, hugobaeta, nickmomrik, rauchg.
See #32929.


Built from https://develop.svn.wordpress.org/trunk@33631


git-svn-id: http://core.svn.wordpress.org/trunk@33598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-18 17:02:27 +00:00
Boone Gorges
2f514a6115 When generating a fallback post_name using the post ID, wp_insert_post() should clear the post cache immediately. 
If the post cache is not cleared at this point, the cache can become stale
for operations performed before the cache is cleared later in the function.
Specifically, the generation of a `guid` for new posts can use stale data,
resulting in non-unique values. [33262] introduced a call to `get_post()`
that introduced just such an invalidation problem.

Fixes #5305.
Built from https://develop.svn.wordpress.org/trunk@33630


git-svn-id: http://core.svn.wordpress.org/trunk@33597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-18 02:51:26 +00:00
Konstantin Obenland
6b9b32c431 4.3-RC3-33629 
Built from https://develop.svn.wordpress.org/trunk@33629


git-svn-id: http://core.svn.wordpress.org/trunk@33596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 21:46:25 +00:00
Konstantin Obenland
cd937b6771 4.3-RC3 
Built from https://develop.svn.wordpress.org/trunk@33628


git-svn-id: http://core.svn.wordpress.org/trunk@33595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 21:40:25 +00:00
Dominik Schilling
96a6f0ac1f Pinking shears. 
Built from https://develop.svn.wordpress.org/trunk@33627


git-svn-id: http://core.svn.wordpress.org/trunk@33594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 21:39:25 +00:00
Dominik Schilling
ce557062f4 Upgrade: Update $_old_files for 4.3. 
fixes #33394.
Built from https://develop.svn.wordpress.org/trunk@33626


git-svn-id: http://core.svn.wordpress.org/trunk@33593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 20:24:26 +00:00
Konstantin Obenland
69146f6b10 Passwords: Use keyup event to prevent IE8's misinterpretation of propertychange. 
Props adamsilverstein, peterwilsoncc.
Fixes #33385.


Built from https://develop.svn.wordpress.org/trunk@33625


git-svn-id: http://core.svn.wordpress.org/trunk@33592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 18:46:25 +00:00
Andrew Ozz
2de7757124 Fix creating of extra <br /> tags in both PHP and JS variants of wpautop(). Add PHP tests to catch similar problems in the future. 
Props valendesigns, azaozz. Fixes #33377.
Built from https://develop.svn.wordpress.org/trunk@33624


git-svn-id: http://core.svn.wordpress.org/trunk@33591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 17:36:24 +00:00
Helen Hou-Sandí
50e42e8a07 List tables: Yet more primary column fallbacks. 
Some custom list tables override enough methods for the column definition fallback to never kick in, so let's ensure that toggling columns only applies when a primary column is defined in some way. We also need to show a toggle button when we can when there are no row actions.

props Chouby, obenland, ocean90.
fixes #33313.

Built from https://develop.svn.wordpress.org/trunk@33623


git-svn-id: http://core.svn.wordpress.org/trunk@33590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 15:38:25 +00:00
Konstantin Obenland
dfcf1d0035 Editor: Exclude shift from modifier keys when handling spacebar shortcuts. 
Patterns that activate on enter are still canceled with any modifier active.

Props azaozz.
Fixes #33382.


Built from https://develop.svn.wordpress.org/trunk@33622


git-svn-id: http://core.svn.wordpress.org/trunk@33589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 14:51:24 +00:00
Boone Gorges
dba7c50d29 Don't run term-splitting routine on new installations. 
Props pento.
Fixes #30261.
Built from https://develop.svn.wordpress.org/trunk@33621


git-svn-id: http://core.svn.wordpress.org/trunk@33588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 14:29:25 +00:00
Konstantin Obenland
e6bc6242ad Passwords: Restore second parameter for wp_new_user_notification(). 
After [33023] users would always be notified, this restores previous behavior.

Props markjaquith, ocean90.
Fixes #33358.


Built from https://develop.svn.wordpress.org/trunk@33620


git-svn-id: http://core.svn.wordpress.org/trunk@33587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 14:25:27 +00:00
Boone Gorges
52a7082d11 Don't suspend cache invalidation when running term splitting batch routine. 
`wp_suspend_cache_invalidation()` was originally added to increase performance,
but the switch to batch processing in [33615] mitigates serious performance
concerns.

As a precaution against timeouts, the batch size has been reduced from 20 to 10.

Props Chouby.
See #30261.
Built from https://develop.svn.wordpress.org/trunk@33619


git-svn-id: http://core.svn.wordpress.org/trunk@33586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-15 19:25:26 +00:00
Helen Hou-Sandí
1880411a0b Menu customizer: Ensure the search results section is full height. 
fixes #33375.

Built from https://develop.svn.wordpress.org/trunk@33618


git-svn-id: http://core.svn.wordpress.org/trunk@33585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-14 21:32:25 +00:00
Weston Ruter
9ee7f050e9 Customize: Fix keyboard accessibility for toggling screen options and contextual help. 
Also fix layout of search results in mobile.

Props valendesigns, afercia, adamsilverstein.
Fixes #33184.

Built from https://develop.svn.wordpress.org/trunk@33617


git-svn-id: http://core.svn.wordpress.org/trunk@33584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-14 21:23:27 +00:00
Boone Gorges
69a03fd1a3 Remove unit test related to pre-4.1 term splitting during wp_update_term(). 
After [33615], `wp_update_term()` no longer checks `$wp_db_version` before
attempting a split. This is because pre-4.1 versions of WordPress must be
allowed to update to 4.3+.

See #30261.
Built from https://develop.svn.wordpress.org/trunk@33616


git-svn-id: http://core.svn.wordpress.org/trunk@33583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-14 04:16:26 +00:00
Boone Gorges
151d27369d Term splitting routine should be run in a separate process, triggered via wp-cron. 
[32814] introduced a routine to split shared terms, which was run during the
regular WP database upgrade. This turned out to be problematic because plugins
are not loaded during the db upgrade (due to `WP_INSTALLING`), with the result
that plugins were not able to hook into the 'split_shared_term' action during
the bulk split. We work around this limitation by moving the term splitting
routine to a separate process, triggered by a wp-cron hook.

Props boonebgorges, Chouby, peterwilsoncc, pento, dd32.
Fixes #30261.
Built from https://develop.svn.wordpress.org/trunk@33615


git-svn-id: http://core.svn.wordpress.org/trunk@33582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-14 03:59:26 +00:00
Dominik Schilling
f74a907eac Capabilities: Fall back to the edit_posts capability for orphaned comments. 
Also avoid PHP notices because of orphaned comments in the comments list table.
Includes unit test.

props pento, dd32.
fixes #33154.
Built from https://develop.svn.wordpress.org/trunk@33614


git-svn-id: http://core.svn.wordpress.org/trunk@33581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-13 22:31:24 +00:00
Konstantin Obenland
35f8b77882 About: Third pass at 4.3 about page: 
* Improves some of the feature descriptions.
* Uses .org CDN for images and feature video.
* Fixes an overzealous Jetpack style that adds unwanted padding.
* Uses more specific `WP_List_Table` header.
* Adds 4.3 tagline to freedoms and credit page.
* Adds infrastructure for 4.3 about video. Only the ID needs to be updated.
* Makes all strings translatable.

Props siobhan, adamsilverstein, melchoyce, ocean90, markjaquith, helen, obenland.
Fixes #32929.


Built from https://develop.svn.wordpress.org/trunk@33613


git-svn-id: http://core.svn.wordpress.org/trunk@33580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-13 22:11:35 +00:00
Scott Taylor
4a1f50f732 After [33325], supply a missing post_type in ->mw_editPost(). 
Add unit test.

Props ocean90.
Fixes #20662.

Built from https://develop.svn.wordpress.org/trunk@33612


git-svn-id: http://core.svn.wordpress.org/trunk@33579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-13 15:28:27 +00:00
Boone Gorges
2c9e81349c When splitting a shared 'nav_menu' term, ensure that nav items and theme locations are retained. 
Props boonebgorges, dd32.
Fixes #33187.
Built from https://develop.svn.wordpress.org/trunk@33611


git-svn-id: http://core.svn.wordpress.org/trunk@33578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-12 14:07:26 +00:00
Weston Ruter
7fcc3e50e1 Customize: Fix layout issues in panels and sections when resizing and autofocusing. 
Also reverts [33157] which is no longer needed.

Props valendesigns, mattwiebe, westonruter, ocean90.
Fixes #33220.

Built from https://develop.svn.wordpress.org/trunk@33610


git-svn-id: http://core.svn.wordpress.org/trunk@33577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-11 23:56:25 +00:00
Andrew Ozz
3bfd096440 Fix paste typos in upgrade.php. 
Props tellyworth. Fixes #33206.
Built from https://develop.svn.wordpress.org/trunk@33609


git-svn-id: http://core.svn.wordpress.org/trunk@33576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-11 23:44:24 +00:00
Konstantin Obenland
08743e43eb After [32948]: Account for the use of paginate_links() with table navigation markup. 
Props afercia.
Fixes #32253.


Built from https://develop.svn.wordpress.org/trunk@33608


git-svn-id: http://core.svn.wordpress.org/trunk@33575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-11 20:43:24 +00:00
Konstantin Obenland
be9d89d3e3 Tests: Update Site Icon tests to account for changes in [33605]. 
H/t jorbin.

Fixes #33325.


Built from https://develop.svn.wordpress.org/trunk@33607


git-svn-id: http://core.svn.wordpress.org/trunk@33574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-11 18:41:24 +00:00
Konstantin Obenland
dfa53a1da7 Site Icon: Improvements to Site Icon API. 
* Only call `get_blog_option()` when there is a blog id and we're in Mulitsite. If there is no blog id the request is for the current blog.
* Check return value of `wp_get_attachment_image_src()` before getting the URL since it could be `false`.
* Use `{bool}` rather than `!!` to return a boolean value.

Props MikeHansenMe, obenland.
Fixes #33326.


Built from https://develop.svn.wordpress.org/trunk@33606


git-svn-id: http://core.svn.wordpress.org/trunk@33573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-11 16:25:27 +00:00
Helen Hou-Sandí
731c255aee Site icon: Rearrange function parameters to avoid frequently passing empty values. 
props obenland.
fixes #33325.

Built from https://develop.svn.wordpress.org/trunk@33605


git-svn-id: http://core.svn.wordpress.org/trunk@33572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-10 20:15:26 +00:00
Konstantin Obenland
48712a0309 Customize: Limit styles for menu's reorder button to the nav_menu control. 
This prevents it from bleeding into other controls, misaligning their buttons.
Selectors use a class now too, which is preferable over ids.

Fixes #33260.


Built from https://develop.svn.wordpress.org/trunk@33604


git-svn-id: http://core.svn.wordpress.org/trunk@33571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-10 19:36:27 +00:00
Helen Hou-Sandí
d03082323e Network admin: Internationalize some existing strings that were missed in [33186]. 
Also adds the trailing slash to the `get_home_url()` calls.

props johnbillion.
fixes #33317.

Built from https://develop.svn.wordpress.org/trunk@33603


git-svn-id: http://core.svn.wordpress.org/trunk@33570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-10 18:11:25 +00:00
Helen Hou-Sandí
7e2cec4edb Customizer: Rename WP_New_Menu_Customize_Control to WP_Customize_New_Menu_Control for consistency. 
props DrewAPicture.
fixes #33324.

Built from https://develop.svn.wordpress.org/trunk@33602


git-svn-id: http://core.svn.wordpress.org/trunk@33569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-10 18:06:25 +00:00