Sergey Biryukov
5bb3476a4a
Comments: When setting the colspan
value for inline edit/reply, make sure it's actually a table and the value is not empty.
...
Merges [34179] to the 4.3 branch.
Props afercia.
See #33596 .
Built from https://develop.svn.wordpress.org/branches/4.3@34180
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 13:46:35 +00:00
Nikolay Bachiyski
f91a5fd10e
List tables: escape user e-mails
...
Merges [34133] for 4.3 branch
Built from https://develop.svn.wordpress.org/branches/4.3@34137
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 22:40:23 +00:00
Dominik Schilling
5fe5a0eb07
Passwords: Trigger a wp-check-valid-field
event when the password field is filled with a password by generatePassword()
.
...
Updates event handler in `wpAjax.invalidateForm()` to support `wp-check-valid-field`.
Merge of [34114] to the 4.3 branch.
Fixes #33406 .
Built from https://develop.svn.wordpress.org/branches/4.3@34120
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 13:09:23 +00:00
Dominik Schilling
12b08da9c2
Settings, password field: Fix placement of the error icon and removal of the error class.
...
Merge of [34068] to the 4.3 branch.
Props liljimmi, adamsilverstein.
See #33406 .
Built from https://develop.svn.wordpress.org/branches/4.3@34119
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 13:07:23 +00:00
Dominik Schilling
cca265971e
Passwords: Deprecate second parameter of wp_new_user_notification()
.
...
The second parameter `$plaintext_pass` was removed in [33023] and restored as `$notify` in [33620] with a different behavior. If you have a plugin overriding `wp_new_user_notification()` which hasn't been updated you would get a notification with your username and the password "both".
To prevent this the second parameter is now deprecated and reintroduced as the third parameter.
Adds unit tests.
Merge of [34116] to the 4.3 branch.
Props kraftbj, adamsilverstein, welcher, ocean90.
See #33654 .
Built from https://develop.svn.wordpress.org/branches/4.3@34118
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 13:03:24 +00:00
Helen Hou-Sandí
bf8ffcc14e
Comments: Fix inline edit/reply on small screens.
...
Merges [34094] to the 4.3 branch.
props ocean90, SergeyBiryukov.
see #33596 .
Built from https://develop.svn.wordpress.org/branches/4.3@34095
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-13 12:54:23 +00:00
Dominik Schilling
bff564ee35
Passwords: Refresh password fields when content is pasted into fields.
...
Use feature detection to determine whether password inputs should use the `keyup` or `input` event.
Merge of [34060] to the 4.3 branch.
Props peterwilsoncc, adamsilverstein.
Fixes #33398 .
Built from https://develop.svn.wordpress.org/branches/4.3@34078
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 12:30:24 +00:00
Andrew Ozz
17ae4e9fb9
Settings: reassign the label when switching password fields so it always highlights the visible field.
...
Props umesh.nevase.
Fixes #33778 4.3.
Built from https://develop.svn.wordpress.org/branches/4.3@34063
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 23:23:24 +00:00
Jeremy Felt
9f25a307f5
Multisite: Display content attribution drop down when deleting a user
...
The previous move from echo() to _e() left some of the output hanging. Introduced in [32333].
Merge of [34057] to the 4.3 branch.
Props figureone.
Fixes #33811 .
Built from https://develop.svn.wordpress.org/branches/4.3@34058
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 20:49:24 +00:00
Dominik Schilling
b04ce4a437
Site Icon: For preview fall back to full
size URL when thumbnail
size doesn't exist.
...
Prevents a JavaScript error for rare cases when cropping is skipped and the image is smaller than `thumbnail`.
Merge of [34056] to the 4.3 branch.
Props tyxla.
See #33417 .
Built from https://develop.svn.wordpress.org/branches/4.3@34057
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 20:16:48 +00:00
Dominik Schilling
2a95fc38b2
About: Remove period from placeholder.
...
The position of periods is different in some languages, like Japanese. This removes the period from the last placeholder for the Template Hierarchy section. It doesn't include a new period to avoid a string change in a minor release.
Merge of [34054] to the 4.3 branch.
Props extendwings, chriscct7.
See #33429 .
Built from https://develop.svn.wordpress.org/branches/4.3@34055
git-svn-id: http://core.svn.wordpress.org/branches/4.3@34023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 19:28:22 +00:00
Sergey Biryukov
516ee5f231
Prevent unintended password change after clicking "Generate Password" and then "Cancel" when editing a user profile.
...
Merges [33766] to the 4.3 branch.
Props peterwilsoncc.
Fixes #33419 for 4.3.1.
Built from https://develop.svn.wordpress.org/branches/4.3@33980
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 17:32:24 +00:00
Scott Taylor
5b643782b6
When creating "Sample Page" on install, comments should be closed.
...
Props macmanx.
Cherry-picks [33693] onto 4.3 branch.
Fixes #33490 for 4.3.
Built from https://develop.svn.wordpress.org/branches/4.3@33950
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-08 19:05:22 +00:00
Weston Ruter
7e56cfc30a
Customizer: Prevent JS error during init when nav_menus
panel is removed by plugin.
...
Cherry-picks [33753] onto 4.3 branch.
Fixes #33411 for 4.3.
Built from https://develop.svn.wordpress.org/branches/4.3@33943
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-07 06:28:22 +00:00
Weston Ruter
758d53b709
Customizer: Collapse any expanded panel/sections before expanding other panel/sections.
...
Fix removes need for workaround introduced in [33488] for direct link from nav menu widget to the customizer widgets panel. The todo is now implemented.
Cherry-picks [33837] onto 4.3 branch.
Props celloexpressions, westonruter.
Fixes #33396 for 4.3.
Built from https://develop.svn.wordpress.org/branches/4.3@33942
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-07 06:20:23 +00:00
Weston Ruter
00342ece4a
Customizer: Ensure persistence of unchanged active
state for controls, sections, and panels.
...
Cherry-picks [33754] onto 4.3 branch.
Props nikeo, westonruter.
Fixes #33428 for 4.3.
See also #33494 .
Built from https://develop.svn.wordpress.org/branches/4.3@33941
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-07 06:14:22 +00:00
Weston Ruter
23ef1979f6
Customize: Fix logic for determining the container element when focusing on a panel, section, or control.
...
Cherry-picks [33939] on the 4.3 branch.
Fixes #33695 for 4.3
Built from https://develop.svn.wordpress.org/branches/4.3@33940
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-07 06:05:23 +00:00
Dion Hulse
e7bb78b884
WP_Filesystem: SSH2 handler: Remove support for is_writable() via SSH, it turns out PHP doesn't verify the writability via SFTP and instead uses a comparison based on the current php system process user instead of the ssh user.
...
This fixes the 'The update cannot be installed because we will be unable to copy some files.' error encountered during updates by skipping the write test completely.
Merges [33688] to the 4.3 branch.
Props jobst.
Fixes #33480 for 4.3
Built from https://develop.svn.wordpress.org/branches/4.3@33883
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 04:38:15 +00:00
Dion Hulse
7f29687a55
Revert [33845]
...
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 03:33:24 +00:00
Dion Hulse
f0706a0895
Term Splitting: Switch to a faster cron unschedule process to benefit sites with thousands of affected jobs. Fix the cron hook name in the failsafe rescheduler.
...
Merges [33727] to the 4.3 branch
Props Otto42, dd32, peterwilsoncc
Fixes #33423 for trunk
Built from https://develop.svn.wordpress.org/branches/4.3@33877
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 03:31:17 +00:00
Dion Hulse
7cfe2d293f
Revert [33688] which removed all branches/4.3 files due to a sync script error.
...
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-24 22:14:43 +00:00
Weston Ruter
4e96fc9fd7
Widgets: Switch back to using array_key_exists()
instead of isset()
for widget instance existence check.
...
Reverts unnecessary change in [32602] since `array_key_exists()` does actually work with `ArrayIterator` objects.
Merges [33696] to the 4.3 branch.
See #32474 .
Fixes #33442 for the 4.3 branch.
Built from https://develop.svn.wordpress.org/branches/4.3@33721
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-24 19:31:16 +00:00
Dion Hulse
0b648f198b
Revert [33614] which removed all branches/4.3 files due to a sync script error.
...
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 13:24:10 +00:00
Dion Hulse
7f86f37642
Term Splitting: Fix a reversal of parameters to wp_schedule_single_event() introduced in [33621].
...
The existing invalid cron entries will not be purged automatically (as the 'timestamp' is never matched) so we do this ourselves.
Merges [33646] to the 4.3 branch.
Props mechter for noticing!
See #30261 .
Fixes #33423 for the 4.3 branch.
Built from https://develop.svn.wordpress.org/branches/4.3@33647
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 11:37:14 +00:00
Konstantin Obenland
e36a91efe4
About: Use actual locale and not subtitle debug cruft.
...
H/t dimadin.
See #32929 .
Built from https://develop.svn.wordpress.org/trunk@33632
git-svn-id: http://core.svn.wordpress.org/trunk@33599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-18 17:07:26 +00:00
Konstantin Obenland
d55738d327
About: Update release video to use the correct ID.
...
Also adjusts locale handling to work with Videopress' subtitle implementation.
Props siobhan, jacklenox, sararosso, hugobaeta, nickmomrik, rauchg.
See #32929 .
Built from https://develop.svn.wordpress.org/trunk@33631
git-svn-id: http://core.svn.wordpress.org/trunk@33598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-18 17:02:27 +00:00
Dominik Schilling
96a6f0ac1f
Pinking shears.
...
Built from https://develop.svn.wordpress.org/trunk@33627
git-svn-id: http://core.svn.wordpress.org/trunk@33594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-17 21:39:25 +00:00
Dominik Schilling
ce557062f4
Upgrade: Update $_old_files
for 4.3.
...
fixes #33394 .
Built from https://develop.svn.wordpress.org/trunk@33626
git-svn-id: http://core.svn.wordpress.org/trunk@33593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-17 20:24:26 +00:00
Konstantin Obenland
69146f6b10
Passwords: Use keyup
event to prevent IE8's misinterpretation of propertychange
.
...
Props adamsilverstein, peterwilsoncc.
Fixes #33385 .
Built from https://develop.svn.wordpress.org/trunk@33625
git-svn-id: http://core.svn.wordpress.org/trunk@33592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-17 18:46:25 +00:00
Andrew Ozz
2de7757124
Fix creating of extra <br />
tags in both PHP and JS variants of wpautop(). Add PHP tests to catch similar problems in the future.
...
Props valendesigns, azaozz. Fixes #33377 .
Built from https://develop.svn.wordpress.org/trunk@33624
git-svn-id: http://core.svn.wordpress.org/trunk@33591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-17 17:36:24 +00:00
Helen Hou-Sandí
50e42e8a07
List tables: Yet more primary column fallbacks.
...
Some custom list tables override enough methods for the column definition fallback to never kick in, so let's ensure that toggling columns only applies when a primary column is defined in some way. We also need to show a toggle button when we can when there are no row actions.
props Chouby, obenland, ocean90.
fixes #33313 .
Built from https://develop.svn.wordpress.org/trunk@33623
git-svn-id: http://core.svn.wordpress.org/trunk@33590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-17 15:38:25 +00:00
Boone Gorges
dba7c50d29
Don't run term-splitting routine on new installations.
...
Props pento.
Fixes #30261 .
Built from https://develop.svn.wordpress.org/trunk@33621
git-svn-id: http://core.svn.wordpress.org/trunk@33588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-17 14:29:25 +00:00
Konstantin Obenland
e6bc6242ad
Passwords: Restore second parameter for wp_new_user_notification()
.
...
After [33023] users would always be notified, this restores previous behavior.
Props markjaquith, ocean90.
Fixes #33358 .
Built from https://develop.svn.wordpress.org/trunk@33620
git-svn-id: http://core.svn.wordpress.org/trunk@33587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-17 14:25:27 +00:00
Helen Hou-Sandí
1880411a0b
Menu customizer: Ensure the search results section is full height.
...
fixes #33375 .
Built from https://develop.svn.wordpress.org/trunk@33618
git-svn-id: http://core.svn.wordpress.org/trunk@33585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-14 21:32:25 +00:00
Weston Ruter
9ee7f050e9
Customize: Fix keyboard accessibility for toggling screen options and contextual help.
...
Also fix layout of search results in mobile.
Props valendesigns, afercia, adamsilverstein.
Fixes #33184 .
Built from https://develop.svn.wordpress.org/trunk@33617
git-svn-id: http://core.svn.wordpress.org/trunk@33584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-14 21:23:27 +00:00
Boone Gorges
151d27369d
Term splitting routine should be run in a separate process, triggered via wp-cron.
...
[32814] introduced a routine to split shared terms, which was run during the
regular WP database upgrade. This turned out to be problematic because plugins
are not loaded during the db upgrade (due to `WP_INSTALLING`), with the result
that plugins were not able to hook into the 'split_shared_term' action during
the bulk split. We work around this limitation by moving the term splitting
routine to a separate process, triggered by a wp-cron hook.
Props boonebgorges, Chouby, peterwilsoncc, pento, dd32.
Fixes #30261 .
Built from https://develop.svn.wordpress.org/trunk@33615
git-svn-id: http://core.svn.wordpress.org/trunk@33582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-14 03:59:26 +00:00
Dominik Schilling
f74a907eac
Capabilities: Fall back to the edit_posts
capability for orphaned comments.
...
Also avoid PHP notices because of orphaned comments in the comments list table.
Includes unit test.
props pento, dd32.
fixes #33154 .
Built from https://develop.svn.wordpress.org/trunk@33614
git-svn-id: http://core.svn.wordpress.org/trunk@33581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-13 22:31:24 +00:00
Konstantin Obenland
35f8b77882
About: Third pass at 4.3 about page:
...
* Improves some of the feature descriptions.
* Uses .org CDN for images and feature video.
* Fixes an overzealous Jetpack style that adds unwanted padding.
* Uses more specific `WP_List_Table` header.
* Adds 4.3 tagline to freedoms and credit page.
* Adds infrastructure for 4.3 about video. Only the ID needs to be updated.
* Makes all strings translatable.
Props siobhan, adamsilverstein, melchoyce, ocean90, markjaquith, helen, obenland.
Fixes #32929 .
Built from https://develop.svn.wordpress.org/trunk@33613
git-svn-id: http://core.svn.wordpress.org/trunk@33580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-13 22:11:35 +00:00
Boone Gorges
2c9e81349c
When splitting a shared 'nav_menu' term, ensure that nav items and theme locations are retained.
...
Props boonebgorges, dd32.
Fixes #33187 .
Built from https://develop.svn.wordpress.org/trunk@33611
git-svn-id: http://core.svn.wordpress.org/trunk@33578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-12 14:07:26 +00:00
Weston Ruter
7fcc3e50e1
Customize: Fix layout issues in panels and sections when resizing and autofocusing.
...
Also reverts [33157] which is no longer needed.
Props valendesigns, mattwiebe, westonruter, ocean90.
Fixes #33220 .
Built from https://develop.svn.wordpress.org/trunk@33610
git-svn-id: http://core.svn.wordpress.org/trunk@33577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-11 23:56:25 +00:00
Andrew Ozz
3bfd096440
Fix paste typos in upgrade.php.
...
Props tellyworth. Fixes #33206 .
Built from https://develop.svn.wordpress.org/trunk@33609
git-svn-id: http://core.svn.wordpress.org/trunk@33576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-11 23:44:24 +00:00
Konstantin Obenland
08743e43eb
After [32948]: Account for the use of paginate_links()
with table navigation markup.
...
Props afercia.
Fixes #32253 .
Built from https://develop.svn.wordpress.org/trunk@33608
git-svn-id: http://core.svn.wordpress.org/trunk@33575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-11 20:43:24 +00:00
Konstantin Obenland
48712a0309
Customize: Limit styles for menu's reorder button to the nav_menu
control.
...
This prevents it from bleeding into other controls, misaligning their buttons.
Selectors use a class now too, which is preferable over ids.
Fixes #33260 .
Built from https://develop.svn.wordpress.org/trunk@33604
git-svn-id: http://core.svn.wordpress.org/trunk@33571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-10 19:36:27 +00:00
Helen Hou-Sandí
d03082323e
Network admin: Internationalize some existing strings that were missed in [33186].
...
Also adds the trailing slash to the `get_home_url()` calls.
props johnbillion.
fixes #33317 .
Built from https://develop.svn.wordpress.org/trunk@33603
git-svn-id: http://core.svn.wordpress.org/trunk@33570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-10 18:11:25 +00:00
Helen Hou-Sandí
7e2cec4edb
Customizer: Rename WP_New_Menu_Customize_Control
to WP_Customize_New_Menu_Control
for consistency.
...
props DrewAPicture.
fixes #33324 .
Built from https://develop.svn.wordpress.org/trunk@33602
git-svn-id: http://core.svn.wordpress.org/trunk@33569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-10 18:06:25 +00:00
Dion Hulse
aace7c2c8d
Function documentation: Fix a broken docbock introduced with [32642].
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@33601
git-svn-id: http://core.svn.wordpress.org/trunk@33568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-10 10:50:26 +00:00
Dominik Schilling
45b8634605
Customizer: Remove obsolete .control-panel-back
and .customize-overlay-close
buttons.
...
props afercia, ocean90.
see #31336 .
fixes #33229 .
Built from https://develop.svn.wordpress.org/trunk@33599
git-svn-id: http://core.svn.wordpress.org/trunk@33566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-09 19:00:24 +00:00
Dominik Schilling
bd342572f1
List tables: Adjust width of Quick Edit labels for longer translations.
...
props Clorith, SergeyBiryukov, ocean90.
fixes #33212 .
Built from https://develop.svn.wordpress.org/trunk@33598
git-svn-id: http://core.svn.wordpress.org/trunk@33565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-09 18:55:25 +00:00
Dion Hulse
e2b10dad49
Upgrade: Skip the sitecategories table when it doesn't exist (Global Terms is disabled).
...
Props nofearinc, obenland, SergeyBiryukov, and pento.
Fixes #33206
Built from https://develop.svn.wordpress.org/trunk@33597
git-svn-id: http://core.svn.wordpress.org/trunk@33564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-09 02:22:26 +00:00
Dominik Schilling
04c21a0e3c
Customizer: Restore Shift + Clicking on widgets to open the widgets panel.
...
Includes an alternative for jQuery UI's `:focusable` selector because it has an ancestor visibility requirement, see https://github.com/jquery/jquery-ui/pull/1583 .
props westonruter.
fixes #33258 .
Built from https://develop.svn.wordpress.org/trunk@33596
git-svn-id: http://core.svn.wordpress.org/trunk@33563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-08 09:37:26 +00:00