Commit Graph

50241 Commits

Author SHA1 Message Date
Peter Wilson
5cdf55fda7 Editor: Load all style variation fonts within the editors.
Loads the font family files from style variations defined within a theme for user in the site and post editors. This is to ensure the fonts are shown while editing without the need for a reload after switching styles.

Props ironprogrammer, mmaattiiaass.
Fixes #62231.



Built from https://develop.svn.wordpress.org/trunk@59260


git-svn-id: http://core.svn.wordpress.org/trunk@58652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-20 23:25:16 +00:00
Sergey Biryukov
a67b37192f Editor: Replace id attribute with class in WP_Font_Face::get_style_element().
`wp_print_font_faces()` prints an HTML tag that can be used more than once, so the document could end up having multiple tags with the same `id` attribute.

The `id` global attribute defines an identifier (ID) which must be unique in the whole document.

Reference: [https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/id MDN Web Docs: id].

Follow-up to [56500].

Props mmaattiiaass, peterwilsoncc.
Fixes #62246.
Built from https://develop.svn.wordpress.org/trunk@59259


git-svn-id: http://core.svn.wordpress.org/trunk@58651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-20 13:13:15 +00:00
Sergey Biryukov
05b4e2e094 Docs: Fix typo in a comment in WP_Rewrite::refresh_rewrite_rules().
Includes adjusting the method DocBlock per the documentation standards.

Follow-up to [56448].

See #61608.
Built from https://develop.svn.wordpress.org/trunk@59258


git-svn-id: http://core.svn.wordpress.org/trunk@58650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-19 23:54:18 +00:00
Andrew Ozz
e52423e435 Upgrade/Install: Return WP_Error when source files cannot be found.
Fixes a fatal error in `array_keys()` (PHP 8.0+) as `$wp_filesystem->dirlist()` will return `false` when the source directory doesn't exist or becomes unreadable for some reason.

Props: verygoode, lifelightweb, da5f656f, costdev, afragen, azaozz
Fixes #61114
Built from https://develop.svn.wordpress.org/trunk@59257


git-svn-id: http://core.svn.wordpress.org/trunk@58649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-18 23:37:20 +00:00
Joe McGill
5c8c27b24b Editor: Cache global styles for blocks.
This caches the generated CSS from block nodes in merged Theme JSON data to avoid repeated costly operations required to compute style properties for blocks. The generated CSS is saved to a transient that expires every hour.

This is a follow-up that reimplements [58334], which was previously reverted in [58710].

Props thekt12, spacedmonkey, pereirinha, mukesh27, isabel_brison, oandregal, andrewserong, ramonjd, joemcgill, costdev, aaronrobertshaw, peterwilsoncc.
Fixes #61679. See #59595.

Built from https://develop.svn.wordpress.org/trunk@59256


git-svn-id: http://core.svn.wordpress.org/trunk@58648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-18 21:55:18 +00:00
Sergey Biryukov
51868a5e8c Pings/Trackbacks: Validate that the specified charset is available on the receiving site.
This aims to avoid a subsequent fatal error from `mb_convert_encoding()` when an invalid charset is specified.

Follow-up to [1734], [2563], [12032].

Props dd32, jrf, oglekler, rajinsharwar.
Fixes #60261.
Built from https://develop.svn.wordpress.org/trunk@59255


git-svn-id: http://core.svn.wordpress.org/trunk@58647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-18 15:56:18 +00:00
desrosj
4725c28e34 Build/Test Tools: Refine paths filter for workflows part 2.
[59252] made the path filtering a bit too broad for the Test Old Branches workflow.

Though `v3` of the reusable PHPUnit workflow is used by some older branches, this version is updated much more frequently because it’s the latest version.

To limit the number of times this workflow runs, old branches should only be tested when old versions of the workflow are updated.

Follow up to [59252].

See #61564.
Built from https://develop.svn.wordpress.org/trunk@59254


git-svn-id: http://core.svn.wordpress.org/trunk@58646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-18 15:20:14 +00:00
Joe McGill
dd274216f1 Editor: Improve performance of WP_Theme_JSON::compute_style_properties
This improves the logic in `WP_Theme_JSON::compute_style_properties` to address a number of performance issues.

Props spacedmonkey.
Fixes #59595.

Built from https://develop.svn.wordpress.org/trunk@59253


git-svn-id: http://core.svn.wordpress.org/trunk@58645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-18 14:26:20 +00:00
desrosj
bb1f4f1f80 Build/Test Tools: Refine paths filter for workflows.
Some GitHub Action workflows use the `paths` filter to limit when workflows run for pull requests. This helps avoid running workflows unnecessarily when the pull request does not change any relevant code.

Currently, a few of these workflows are configured to run when any `.yml` file in the `.github/workflows/` directory is changed. This updates those workflows to target more specific workflow files for more efficient running.

See #61564.
Built from https://develop.svn.wordpress.org/trunk@59252


git-svn-id: http://core.svn.wordpress.org/trunk@58644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-18 14:02:19 +00:00
desrosj
e4517c21a9 Build/Test Tools: Add input for PHPUnit test group.
This adds a `phpunit-test-goups` input to the reusable PHPUnit test workflow for added flexibility.

When passed, only the specified test groups are run.

Props jrf.
See #52668.
Built from https://develop.svn.wordpress.org/trunk@59251


git-svn-id: http://core.svn.wordpress.org/trunk@58643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-18 13:39:18 +00:00
gziolo
a923a561ca HTML API: Fix the position update after changing the modifiable text when length differs
There was an edge case detected for updating the text placed without the wrapping HTML tag with `set_modifiable_text`.

Props gziolo, jonsurrell.
Fixes #62241.


Built from https://develop.svn.wordpress.org/trunk@59250


git-svn-id: http://core.svn.wordpress.org/trunk@58642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-18 13:31:17 +00:00
desrosj
4bc546e7f5 Build/Test Tools: Change commands used for the copying .env.example file.
This switches from using the `test`/`cp` commands when copying the `.env.example` file to using `node:fs`. `test` and `cp` are not available on Windows machines.

This also adds the `.env` file to the `svn:ignore` list to prevent it from being committed accidentally.

Follow up to [59038].

Props afercia, Clorith, poena.
Fixes #52668.
Built from https://develop.svn.wordpress.org/trunk@59249


git-svn-id: http://core.svn.wordpress.org/trunk@58641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-18 12:37:20 +00:00
Bernhard Reiter
1dbf1ddc5a HTML API: Ensure form closer tokens are reachable.
Form tag closers have complicated conditions. There was a bug where the HTML Processor would not stop correctly on a FORM tag closer token.
This changeset ensures that that token is reachable.

Developed in https://github.com/WordPress/wordpress-develop/pull/7582
Discussed in https://core.trac.wordpress.org/ticket/61576

Follow-up to [58779].

Props jonsurrell.
Fixes #61576.
Built from https://develop.svn.wordpress.org/trunk@59248


git-svn-id: http://core.svn.wordpress.org/trunk@58640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-17 17:48:19 +00:00
Adam Silverstein
e0d47a45b1 Media: Ensure Imagick quality is set correctly.
Fix an issue where Imagick did not properly set image quality for AVIF images. Adds a call to `setCompressionQuality`  where we currently call `setImageCompressionQuality`

Props: jamesosborne, adamsilverstein, mukeshpanchal27.

Fixes: #61614.


Built from https://develop.svn.wordpress.org/trunk@59247


git-svn-id: http://core.svn.wordpress.org/trunk@58639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-17 17:05:18 +00:00
Sergey Biryukov
bd1a653f42 External Libraries: Upgrade PHPMailer to version 6.9.2.
This is a maintenance release with minor bug fixes.

References:
* [https://github.com/PHPMailer/PHPMailer/releases/tag/v6.9.2 PHPMailer 6.9.2 release notes]
* [https://github.com/PHPMailer/PHPMailer/compare/v6.9.1...v6.9.2 Full list of changes in PHPMailer 6.9.2]

Follow-up to [50628], [50799], [51169], [51634], [51635], [52252], [52749], [52811], [53500], [53535], [53917], [54427], [54937], [55557], [56484], [57137].

Props ayeshrajans.
Fixes #62206.
Built from https://develop.svn.wordpress.org/trunk@59246


git-svn-id: http://core.svn.wordpress.org/trunk@58638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-17 11:31:12 +00:00
cbravobernal
cc5e9ffb43 HTML API: Fix typo in error message in html processor.
Possesive "it's" should be "its."

Follow-up to [59076].

Props jonsurrell.
Fixes #62036.

Built from https://develop.svn.wordpress.org/trunk@59245


git-svn-id: http://core.svn.wordpress.org/trunk@58637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-17 11:03:17 +00:00
Peter Wilson
3c5699206b Bundled Themes: Avoid loading translations too early.
Load block patterns for bundled themes on the `init` hook to avoid triggering notices caused by loading the translations too early.

The change is applied to Twenty Ten, Twenty Twelve, Twenty Thirteen, Twenty Fourteen, Twenty Fifteen, Twenty Sixteen and Twenty Twenty.

Props domainsupport, swissspidy.
Fixes #62237.
See #44937.

Built from https://develop.svn.wordpress.org/trunk@59244


git-svn-id: http://core.svn.wordpress.org/trunk@58636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-17 00:37:17 +00:00
Sergey Biryukov
172d5084a4 Tests: Correct test class name for rss_enclosure() as per the naming conventions.
Includes:
* Moving `@covers` tags to the class-level DocBlock, since this is the only function tested in the class.
* Adjusting the assertion messages for clarity, as `rss_enclosure()` does not return anything directly.
* Using a static closure for improved performance.

Follow-up to [59241].

See #61530.
Built from https://develop.svn.wordpress.org/trunk@59243


git-svn-id: http://core.svn.wordpress.org/trunk@58635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-16 14:19:16 +00:00
Peter Wilson
9668bc0839 Networks and Sites: Relocate defintion of absint().
Relocate the defintion of `absint()` to `load.php` to allow it to be available to `get_current_blog_id()` and `get_current_network_id()`. These functions may be called by caching drop-ins, prior to the loading of `functions.php`.

Props flixos90, geekofshire, johnjamesjacoby, sergeybiryukov, wonderboymusic.
Fixes #40682.


Built from https://develop.svn.wordpress.org/trunk@59242


git-svn-id: http://core.svn.wordpress.org/trunk@58634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-15 23:41:16 +00:00
Peter Wilson
d30cc780fd Feeds: Validate enclosures prior to generating tags.
Prevent possible PHP warnings caused by malformed enclosure meta data. This change ensures the enclosure meta data has at least three lines of text before generating the tag in `rss_enclosure()`.

Props arypneta, johnjamesjacoby, nihar007, rahmohn, rghedin, zahardoc.
Fixes #58798.


Built from https://develop.svn.wordpress.org/trunk@59241


git-svn-id: http://core.svn.wordpress.org/trunk@58633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-15 22:24:18 +00:00
Sergey Biryukov
0d6d21f9a9 Docs: Slightly adjust the description for $table_prefix in wp-config-sample.php.
This replaces the DB abbreviation for consistency, and aims to make the sentence a bit more clear.

Follow-up to [59044].

See #34189.
Built from https://develop.svn.wordpress.org/trunk@59240


git-svn-id: http://core.svn.wordpress.org/trunk@58632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-15 15:24:17 +00:00
cbravobernal
f3e8c615c8 Block Bindings: Fix panel not appearing in custom post types.
There is a bug where the attributes panel is not shown in custom post types. This is caused because each post type can define a capability_type, which by default is post, so the logic to map the capabilities wasn't correct and it was returning false.

Props santosguillamot, cbravobernal.
Fixes #62226.

Built from https://develop.svn.wordpress.org/trunk@59239


git-svn-id: http://core.svn.wordpress.org/trunk@58631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-15 14:13:19 +00:00
gziolo
4988a70658 Editor: Bootstrap block binding sources with inline script from server
Bootstrap block bindings sources earlier in the process through an inline script to ensure they are available when developers want to extend them in the client. Following the same pattern other APIs like registering block types are doing.

Props santosguillamot, cbravobernal, gziolo.
Fixes #6225.


Built from https://develop.svn.wordpress.org/trunk@59238


git-svn-id: http://core.svn.wordpress.org/trunk@58630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-15 08:52:17 +00:00
Peter Wilson
72b05d5d14 Post WordPress 6.7 Beta 3 version bump.
Built from https://develop.svn.wordpress.org/trunk@59237


git-svn-id: http://core.svn.wordpress.org/trunk@58629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-15 00:28:17 +00:00
Peter Wilson
11b364fbff WordPress 6.7 Beta 3.
Built from https://develop.svn.wordpress.org/trunk@59236


git-svn-id: http://core.svn.wordpress.org/trunk@58628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-15 00:10:22 +00:00
Peter Wilson
f5c1486c99 Media: Account for post ID queries in update_post_thumbnail_cache().
Updates `update_post_thumbnail_cache()` to account for `WP_Query` objects that only contain the post ID field rather than the entire post object.

This changes passes the `$post` value to `get_post_thumbnail_id()` rather than assuming the presence of the ID property. Additionally, the posts to which the thumbnail is attached are now primed prior to calling the function to avoid numerous unnecessary database queries.

The test `WP_Test_REST_Posts_Controller::test_get_items_primes_parent_post_caches()` is modified to account for an order of operations change for the priming of post meta caches. The cache is no longer primed in the final call to `update_meta_cache()` so the tests need to account for the post meta to be primed in any call to the function.

Props antpb, jorbin, khokansardar, linsoftware, mukesh27, oglekler, rajinsharwar, sumitsingh, xendo.
Fixes #59521.

Built from https://develop.svn.wordpress.org/trunk@59235


git-svn-id: http://core.svn.wordpress.org/trunk@58627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-14 22:22:10 +00:00
ryelle
940e899c7d Help/About: Update the About page for 6.7.
Introducing the new content for the 6.7 About page. As with the last release, this About page has a simple layout, and links off to WordPress.org for a full overview.

Props ndiego, annezazu, provenself, ryelle, joen, parinpanjari.
See #61961.


Built from https://develop.svn.wordpress.org/trunk@59234


git-svn-id: http://core.svn.wordpress.org/trunk@58626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-14 22:06:13 +00:00
Peter Wilson
4100458c7d Bundled Themes: Update Twenty Twenty-Five for 6.7 Beta 3.
This merges the latest improvements to the Twenty Twenty-Five theme from GitHub into `trunk` for 6.7 beta 3.

A full list of changes can be found on GitHub: [0d8b245021...5d17f41da8 WordPress/twentytwentyfive@0d8b245...5d17f41]

Props annezazu, areziaal, beafialho, cwhitmore, franz00, get_dave, joedolson, joen, juanfra, karmatosed, kartikmehta, mukesh27, onemaggie, pgeorgiev, poena, richtabor, sudipatel007, sumitbagthariya16, wildworks, youknowriad.
Fixes #62218.



Built from https://develop.svn.wordpress.org/trunk@59233


git-svn-id: http://core.svn.wordpress.org/trunk@58625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-14 21:58:17 +00:00
Sergey Biryukov
12f5686f77 Users: Further adjust the check for use_ssl meta in wp_insert_user().
This removes a redundant check for a falsey value, which is equivalent to the `empty()` check directly before.

Includes minor adjustments in the unit test:
* Adding a `@covers` tag.
* Correcting the description for clarity.
* Using `assertSame()` for strict type checking.

Follow-up to [59216].

See #60299.
Built from https://develop.svn.wordpress.org/trunk@59232


git-svn-id: http://core.svn.wordpress.org/trunk@58624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-14 21:16:17 +00:00
desrosj
da2f8d9cc6 Build/Test Tools: Move composer update to env:start.
Currently, `composer update` is run whenever `test:php` is called to ensure the latest versions of `yoast/phpunit-polyfills` and other dependencies are always installed when running the PHPUnit test suite. 

For contributors using the local Docker environment to run tests during development, this is unnecessary and can often result in a 30+ second delay every time `test:php` is called.

This moves the command to `env:install`, reducing the number of times `composer update` is run from many to once. Since the environment needs to be started in order to run tests, `env:install` will still confirm that the latest versions of required dependencies are installed and available prior to running the test suite.

Props azaozz, swissspidy, johnbillion, peterwilsoncc, hellofromtonya.
Fixes #57189.
Built from https://develop.svn.wordpress.org/trunk@59231


git-svn-id: http://core.svn.wordpress.org/trunk@58623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-14 12:38:17 +00:00
kevin940726
decedc1b93 Editor: Update packages for 6.7 Beta 3.
Syncs `@wordpress/*` packages to the `wp-6.7` npm tag.

Fixes #62205.

Built from https://develop.svn.wordpress.org/trunk@59230


git-svn-id: http://core.svn.wordpress.org/trunk@58622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-14 11:47:24 +00:00
Pascal Birchler
1c45d548c4 Sitemaps: Add missing _deprecated_function() call to newly deprecated method.
Follow-up to [59228].

See #61931.
Built from https://develop.svn.wordpress.org/trunk@59229


git-svn-id: http://core.svn.wordpress.org/trunk@58621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-14 08:52:12 +00:00
Pascal Birchler
7d9a297eb4 Sitemaps: Improve sitemap.xml redirects when using custom permalinks.
Changes the way redirects from `sitemap.xml` to `wp-sitemap.xml` happen, so that they also work when using a more complex custom rewrite structure.

Props gmariani405, swissspidy, euthelup, peterwilsoncc.
Fixes #61931.
Built from https://develop.svn.wordpress.org/trunk@59228


git-svn-id: http://core.svn.wordpress.org/trunk@58620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-14 08:49:19 +00:00
Peter Wilson
b99b8161e4 Bundled Themes: Test new themes are added to new bundled files.
Introduces a test to ensure that new bundled themes are included in the `$_new_bundled_files` array. Modifies previous theme related tests added during the 6.7 release cycle to include the correct annotations.

Props peterwilsoncc, mukesh27, costdev.
See #61530, #62103.

Built from https://develop.svn.wordpress.org/trunk@59227


git-svn-id: http://core.svn.wordpress.org/trunk@58619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-14 01:07:15 +00:00
joedolson
f17a0e2aee Bundled Theme: Twenty Eleven: Fix positioning to make links clickable in mobile.
Fix a combination of floated and absolutely positioned content that caused previous and next links to be stacked under other content, making them unclickable on mobile devices. Adjust the position of the post date so that focus order matches visible order. Prevent overlap of 'Edit' button on post title.

Props kel-dc, parthvataliya, dhruvang21, sabernhardt, wpeople, itpathsolutions, balub, dilip2615, tirth03. 
Fixes #62008.
Built from https://develop.svn.wordpress.org/trunk@59226


git-svn-id: http://core.svn.wordpress.org/trunk@58618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-13 21:22:15 +00:00
joedolson
0c88366123 Revisions: Improve accessibility of revisions selection.
Add `aria-labelledby` and `aria-describedby` attributes to revision slider selection handle. Add keyboard `:focus` state to revision slider  handle. Move 'multiple revision' checkbox before the buttons panel, matching its visual order. Change diff `Title` and `Content` headings from `h3` to `h2` to correct headings hierarchy.

Props joedolson, rishishah, sarahricker, williamalexander, afercia. 
Fixes #52303.
Built from https://develop.svn.wordpress.org/trunk@59225


git-svn-id: http://core.svn.wordpress.org/trunk@58617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-13 20:49:13 +00:00
joedolson
f7fb13a3c4 Administration: A11y: Fix accordion accessibility.
Change accordions in the customizer and the navigation menus to make proper usage of accordion markup patterns. This includes adding missing `:focus` states, using a `button` element to control tabbing and interaction, instead of the heading elements, and removing instructional text for screen reader users that was used to compensate for the incorrect markup pattern.

Props afercia, rishishah, kushang78, rcreators, krupajnanda, hmbashar, joedolson.
Fixes #42002.
Built from https://develop.svn.wordpress.org/trunk@59224


git-svn-id: http://core.svn.wordpress.org/trunk@58616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-13 19:09:12 +00:00
Sergey Biryukov
c0dc2960e4 Docs: Fix typos in a comment in wp_default_script_modules().
Follow-up to [59083].

Props shailu25.
Fixes #62213.
Built from https://develop.svn.wordpress.org/trunk@59223


git-svn-id: http://core.svn.wordpress.org/trunk@58615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-13 18:49:16 +00:00
Tammie Lister
a1bd872c12 Twenty Nineteen: Fixes adjusting avatar dimensions for comment author.
In Twenty Nineteen r58580 increased size of avatars. This caused issues with the position of author checkbox. This resolves by moving without impacting the avatar blocks.

Props sabernhardt, nithins53, sudipatel007.
Fixes #62096.

Built from https://develop.svn.wordpress.org/trunk@59222


git-svn-id: http://core.svn.wordpress.org/trunk@58614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-13 15:43:18 +00:00
desrosj
fb115f6a01 Build/Test Tools: Add input for Gutenberg version to E2E workflow.
The E2E test suite has some basic tests to confirm that the plugin can be activated without conflicts. This works great until the minimum version of WordPress required to run the plugin is raised. Old branches that attempt to run these tests that are newly incompatible with the latest version of the plugin will fail.

This change adds a `gutenberg-version` input to the E2E GitHub Action workflow to allow these tests to continue running with the last compatible version.

Props swissspidy.
See #61530.
Built from https://develop.svn.wordpress.org/trunk@59220


git-svn-id: http://core.svn.wordpress.org/trunk@58613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-12 13:16:12 +00:00
Sergey Biryukov
c803f6d3e0 Twenty Ten: Document the $css parameter in twentyten_remove_gallery_css().
Follow-up to [13012], [13128], [13157], [13552], [13885], [13886].

Props parthvataliya.
Fixes #62183.
Built from https://develop.svn.wordpress.org/trunk@59219


git-svn-id: http://core.svn.wordpress.org/trunk@58612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-12 11:59:19 +00:00
Sergey Biryukov
bdb722eed7 Twenty Nineteen: Document the $defaults parameter in twentynineteen_comment_form_defaults().
Follow-up to [43808].

Props parthvataliya.
See #62183.
Built from https://develop.svn.wordpress.org/trunk@59218


git-svn-id: http://core.svn.wordpress.org/trunk@58611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-11 22:26:15 +00:00
Joe McGill
8ec0909243 Build/Test Tools: Fix Performance Test workflows on release branches.
This fixes an issue after [59170] that was causing the Performance Test workflows to fail on older branches since the `CODEVITALS_PROJECT_TOKEN` input value was marked as required but was not being passed.

This is a follow-up to [59214] and [59215].

Fixes #62153.
Props desrosj, joemcgill, flixos90, swissspidy.

Built from https://develop.svn.wordpress.org/trunk@59217


git-svn-id: http://core.svn.wordpress.org/trunk@58610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-11 19:04:14 +00:00
Adam Silverstein
6f656ab4e5 Users: remove unnecessary writes to the database for use_ssl user meta.
When checking for updates to use_ssl, use strings for the comparison values, matching the stored values. Fixes an issue where calls to wp_update_user updated the database meta value for use_ssl even when the value was missing or unchanged. 

Props prettyboymp, rajinsharwar, adamsilverstein, johnbillion, rayhatron, mukesh27, joemcgill.

Fixes #60299.


Built from https://develop.svn.wordpress.org/trunk@59216


git-svn-id: http://core.svn.wordpress.org/trunk@58609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-11 17:20:14 +00:00
Joe McGill
6432da4794 Build/Test Tools: Revert [59214].
The commit caused the Performance Tests workflow to fail due to an invalid workflow file.

See #62153.
Unprops @joemcgill.

Built from https://develop.svn.wordpress.org/trunk@59215


git-svn-id: http://core.svn.wordpress.org/trunk@58608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-11 16:48:15 +00:00
Joe McGill
fdcb9f2613 Build/Test Tools: Fix Performance GH workflows on release branches.
This fixes an issue after [59170] that was causing the Performance release workflows to fail on older branches since the `CODEVITALS_PROJECT_TOKEN` input value was marked as required but was not being passed.

Fixes #62153.
Props desrosj, joemcgill, flixos90.

Built from https://develop.svn.wordpress.org/trunk@59214


git-svn-id: http://core.svn.wordpress.org/trunk@58607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-11 15:57:17 +00:00
Felix Arntz
d7fd9dc225 Themes: Improve performance of applying background image styles in theme.json.
The cost of using `WP_Theme_JSON::get_block_nodes()` for this in its original shape was high enough to lead to a performance regression. Therefore this changeset introduces a new option on the method that allows to bypass all logic except for retrieving the node paths, which is much faster and everything that this functionality needs.

Follow up to [58936].

Props mukesh27, flixos90, ramonopoly, joemcgill, andrewserong, swissspidy.
Fixes #61858.

Built from https://develop.svn.wordpress.org/trunk@59213


git-svn-id: http://core.svn.wordpress.org/trunk@58606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-10 21:07:19 +00:00
Sergey Biryukov
2234d91da2 Twenty Fourteen: Document the $args parameter in Featured_Content::hide_featured_term().
Follow-up to [25808], [26556], [28536].

Props parthvataliya.
See #62183.
Built from https://develop.svn.wordpress.org/trunk@59210


git-svn-id: http://core.svn.wordpress.org/trunk@58605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-10 18:01:11 +00:00
desrosj
c99ed6156f Build/Test Tools: Temporarily ignore Slack failures.
When many workflows are initiated at the same time, there are often instances where the requests to Slack providing updates are rate limited. This usually happens when the Test Old Branches workflow runs and initiates testing for all workflows in branches that could potentially receive a security update.

Even though everything was successful in the workflow except the message, the workflow run is marked as failed. The next time the same workflow runs for that branch, a “fixed” message will be sent to `#core` in Slack. The result is a burst of messages that is quite noisy and unnecessary.

This temporarily adds `continue-on-error` to the jobs responsible for sending the messages until a better solution can be decided on.

See #61701.
Built from https://develop.svn.wordpress.org/trunk@59209


git-svn-id: http://core.svn.wordpress.org/trunk@58604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-10 17:58:11 +00:00
desrosj
3d3805b478 Build/Test Tools: Update 3rd-party GitHub Actions.
This applies several updates to the following 3rd-party GitHub Actions:
- `actions/setup-node`
- `actions/cache`
- `actions/upload-artifact`
- `slackapi/slack-github-action`
- `codecov/codecov-action`.

See #61564.
Built from https://develop.svn.wordpress.org/trunk@59208


git-svn-id: http://core.svn.wordpress.org/trunk@58603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-10 17:10:15 +00:00