Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-12-30 13:08:26 +01:00
Code Issues Projects Releases Wiki Activity
32,527 Commits 50 Branches 749 Tags 806 MiB
5e9ed67b82
Commit Graph

6255 Commits

Author SHA1 Message Date
Boone Gorges
4430e5dbbb Return null from get_term() on taxonomy mismatch. 
[34997] caused `get_term()` to return an error object in the case when
`$taxonomy` did not match the taxonomy of the located term. This was an
inadvertant change from the previous behavior, when `get_term()` would return
null in these cases.

Props dlh.
See #14162. Fixes #34332.
Built from https://develop.svn.wordpress.org/trunk@35227


git-svn-id: http://core.svn.wordpress.org/trunk@35193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 21:42:25 +00:00
Scott Taylor
efb224e831 Unit Tests: PHP 5.2, I Hate You and You Are Bringing Me Down. 
#YOLOFriday

See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35226


git-svn-id: http://core.svn.wordpress.org/trunk@35192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 21:15:25 +00:00
Scott Taylor
a2a65a06bd Unit Tests: one $factory to rule them all, and it shall be static. 
Using more than one instance of `WP_UnitTest_Factory` causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use `setUpBeforeClass`, we were creating ad hoc instances. To avoid that, we were injecting one `static` instance via Dependency Injection in `wpSetUpBeforeClass`. All tests should really use the `static` instance, so we will remove the instance prop `$factory`.

Replace `$this->factory` with `self::$factory` over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values. 

#YOLOFriday


Built from https://develop.svn.wordpress.org/trunk@35225


git-svn-id: http://core.svn.wordpress.org/trunk@35191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 21:05:25 +00:00
Scott Taylor
3693228a9b Unit Tests: since [32953], we can just use self::delete_user() instead of using if logic for Multisite. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35224


git-svn-id: http://core.svn.wordpress.org/trunk@35190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 19:52:27 +00:00
Sergey Biryukov
7fdbebdd7d In WP_Posts_List_Table, correct the type for $comment_pending_count. 
See #11381.
Built from https://develop.svn.wordpress.org/trunk@35223


git-svn-id: http://core.svn.wordpress.org/trunk@35189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 18:25:25 +00:00
Sergey Biryukov
dcf23c5e2a In WP_Media_List_Table, rename $pending_count to $comment_pending_count and mark it as protected, for consistency with WP_Posts_List_Table. 
See #11381.
Built from https://develop.svn.wordpress.org/trunk@35222


git-svn-id: http://core.svn.wordpress.org/trunk@35188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 18:23:27 +00:00
Drew Jaynes
1cb39b180f Docs: Standardize the file header summary for wp-admin/includes/file.php. 
Also adds an `@since` version and corrects the `@subpackage` value.

See #33701.

Built from https://develop.svn.wordpress.org/trunk@35221


git-svn-id: http://core.svn.wordpress.org/trunk@35187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 16:56:26 +00:00
Andrea Fercia
dc0e7e1a79 Accessibility: Improve headings hierarchy in the Theme browser modal dialog. 
Fixes #34288.
Built from https://develop.svn.wordpress.org/trunk@35220


git-svn-id: http://core.svn.wordpress.org/trunk@35186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 15:56:25 +00:00
Andrea Fercia
7f4a0ebbf3 Bump H4 headings to H2 in the Updates screen for better accessibility. 
Fixes #34265.
Built from https://develop.svn.wordpress.org/trunk@35219


git-svn-id: http://core.svn.wordpress.org/trunk@35185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 15:45:28 +00:00
Dominik Schilling
0df9abe092 Travis CI: Use a pinned version of the object cache drop-in. 
Props tollmanz.
See #31491.
Built from https://develop.svn.wordpress.org/trunk@35218


git-svn-id: http://core.svn.wordpress.org/trunk@35184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 14:16:28 +00:00
Ella Iseulde Van Dorpe
bafdd96ebf TinyMCE: add lang attribute 
This is needed to make `hyphens: auto;` work correctly.

Fixes #32555.

Built from https://develop.svn.wordpress.org/trunk@35217


git-svn-id: http://core.svn.wordpress.org/trunk@35183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 10:11:27 +00:00
Ella Iseulde Van Dorpe
ef01315cac TinyMCE: make sure markers are removed after first init 
This is only relevant to non embeddable URLs.
After first init, markers were set but not removed,
causing an edited URL to revert when switching to text mode
or any paragraph after the URL to just contain that URL.

Fixes #33954.

Built from https://develop.svn.wordpress.org/trunk@35216


git-svn-id: http://core.svn.wordpress.org/trunk@35182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 05:43:26 +00:00
Helen Hou-Sandí
fc02ca2d01 Account for icon alignment using text-indent in RTL. 
fixes #33808.

Built from https://develop.svn.wordpress.org/trunk@35215


git-svn-id: http://core.svn.wordpress.org/trunk@35181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 00:58:25 +00:00
Scott Taylor
438c2462e1 Unit Tests: add SpeedTrapListener to phpunit/includes and add the config node to phpunit.xml.dist. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35214


git-svn-id: http://core.svn.wordpress.org/trunk@35180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 00:28:23 +00:00
Dominik Schilling
dd753ef3ad Travis: Extend our test suite with a memcached instance. 
To test persistent object caching Travis CI runs now a build on PHP 5.6 with memached enabled. The build uses the drop-in from https://github.com/tollmanz/wordpress-pecl-memcached-object-cache which is based on the PECL memcached extension.

Props pento, ocean90.
Fixes #31491.
Built from https://develop.svn.wordpress.org/trunk@35213


git-svn-id: http://core.svn.wordpress.org/trunk@35179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 22:52:25 +00:00
Dominik Schilling
22874716dd Multisite: Remove the strictness for $using_paths in WP_Network::get_by_path(). 
The network lookup was broken when using an external object cache because `$using_paths` isn't always a boolean. Added in [34099].

See #31985, #31491.
Built from https://develop.svn.wordpress.org/trunk@35212


git-svn-id: http://core.svn.wordpress.org/trunk@35178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 22:07:24 +00:00
Dominik Schilling
272ff97709 Tests: Remove the @runTestsInSeparateProcesses annotation for Ajax tests. 
They were added 3 years ago in [846/tests] because tests weren't excluded from the normal runs.

Reverts [35209] because it doesn't work with Xdebug.
`Tests_Ajax_Response::test_response_charset_in_header` is the only test which needs to run in a separate process, see [975/tests].

See #31491.
Built from https://develop.svn.wordpress.org/trunk@35211


git-svn-id: http://core.svn.wordpress.org/trunk@35177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 21:31:24 +00:00
Drew Jaynes
d4711aff8a Docs: Fix a typo in an inline comment in wp_get_attachment_image_srcset_array(). 
Props neoxx.
Fixes #34319.

Built from https://develop.svn.wordpress.org/trunk@35210


git-svn-id: http://core.svn.wordpress.org/trunk@35176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 20:52:24 +00:00
Dominik Schilling
bcdad0aa12 Tests: Don't preserve the global state for Ajax tests when using an external object cache. 
Most of the Ajax tests are running in a separate PHP process, and thus PHPUnit attempts to preserve the global state from the parent process by serializing all globals. But this doesn't work for external object caches so we have to disable this "feature".

See #31491.
Built from https://develop.svn.wordpress.org/trunk@35209


git-svn-id: http://core.svn.wordpress.org/trunk@35175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 20:35:23 +00:00
Aaron Jorbin
41b21cf23b Add Twenty Sixteen to travis builds 
This allows the automated tests to include Twenty Sixteen.

Fixes #34315. See #34306.


Built from https://develop.svn.wordpress.org/trunk@35208


git-svn-id: http://core.svn.wordpress.org/trunk@35174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 19:06:25 +00:00
Helen Hou-Sandí
7aabfdaca4 Circular focus styling for widgets and menus in the customizer. 
see #33808.

Built from https://develop.svn.wordpress.org/trunk@35207


git-svn-id: http://core.svn.wordpress.org/trunk@35173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 18:53:25 +00:00
Boone Gorges
76a89d95c3 Fix incorrect variable name introduced in [35197]. 
See #30017, #33968.
Built from https://develop.svn.wordpress.org/trunk@35206


git-svn-id: http://core.svn.wordpress.org/trunk@35172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 18:48:24 +00:00
Sergey Biryukov
2d540d0280 In WP::parse_request() and url_to_postid(), don't skip objects that have a post status with 'exclude_from_search' => false, e.g. inherit. 
This fixes pretty permalinks for attachments, broken in [35195].

Fixes #21970.
Built from https://develop.svn.wordpress.org/trunk@35205


git-svn-id: http://core.svn.wordpress.org/trunk@35171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 17:53:24 +00:00
Helen Hou-Sandí
395258bcaa Make the database update button primary. 
see #23738.

Built from https://develop.svn.wordpress.org/trunk@35204


git-svn-id: http://core.svn.wordpress.org/trunk@35170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 17:35:24 +00:00
Sergey Biryukov
de730d605f Twenty Sixteen: Update Gruntfile.js to ignore the html5 shiv for JSHint. 
See #34306, #34315.
Built from https://develop.svn.wordpress.org/trunk@35203


git-svn-id: http://core.svn.wordpress.org/trunk@35169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 17:27:24 +00:00
Drew Jaynes
0905e847ae Docs: Walker_Nav_Menu_Checklist and Walker_Nav_Menu_Edit are part of the Navigation Menu API, but intended for use in the scope of administration. 
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35202


git-svn-id: http://core.svn.wordpress.org/trunk@35168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 17:26:24 +00:00
Helen Hou-Sandí
12290303a8 Box shadows still need -webkit-, turns out. 
see #33808, [35200].

Built from https://develop.svn.wordpress.org/trunk@35201


git-svn-id: http://core.svn.wordpress.org/trunk@35167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 17:09:26 +00:00
Helen Hou-Sandí
50288dea5a Circular focus styling for expand/collapse arrows. 
Affects postboxes, widgets, and nav menus, all in the admin.

props grvrulz for the initial patch.
see #33808.

Built from https://develop.svn.wordpress.org/trunk@35200


git-svn-id: http://core.svn.wordpress.org/trunk@35166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 16:47:25 +00:00
Ella Iseulde Van Dorpe
3eb4a57c27 TinyMCE: make captioned images draggable 
See #28003.

Built from https://develop.svn.wordpress.org/trunk@35199


git-svn-id: http://core.svn.wordpress.org/trunk@35165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 15:20:25 +00:00
Ella Iseulde Van Dorpe
3babb1682a Fix close button plugin modal after [18590] 
See #18590.


Built from https://develop.svn.wordpress.org/trunk@35198


git-svn-id: http://core.svn.wordpress.org/trunk@35164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 14:52:26 +00:00
Scott Taylor
9d4069e5d9 Unit Tests: add/upgrade the fixtures in Tests_User_Query. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35197


git-svn-id: http://core.svn.wordpress.org/trunk@35163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 07:29:24 +00:00
Scott Taylor
1603ccad71 Unit Tests: create fewer terms in Tests_Term_getTerms::test_get_terms_parent_zero() 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35196


git-svn-id: http://core.svn.wordpress.org/trunk@35162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 06:53:24 +00:00
Sergey Biryukov
8a6d07f596 In WP::parse_request() and url_to_postid(), if a post slug clashes with a trashed page, return the post instead of the page. 
Props kovshenin, SergeyBiryukov, igmoweb.
Fixes #21970.
Built from https://develop.svn.wordpress.org/trunk@35195


git-svn-id: http://core.svn.wordpress.org/trunk@35161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 06:49:25 +00:00
Scott Taylor
3bf9aa75a4 Unit Tests: upgrade the fixtures in Tests_Post_Thumbnail_Template. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35194


git-svn-id: http://core.svn.wordpress.org/trunk@35160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 06:40:24 +00:00
Scott Taylor
274d7f5bb0 Unit Tests: upgrade the fixtures in Tests_Post_Revisions. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35193


git-svn-id: http://core.svn.wordpress.org/trunk@35159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 06:32:25 +00:00
Scott Taylor
5b49ff3a48 Unit Tests: in Tests_Comment_Query::test_get_comments_for_post(), create fewer comments (5, instead of 10). 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35192


git-svn-id: http://core.svn.wordpress.org/trunk@35158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 05:57:25 +00:00
Scott Taylor
53ef754260 Unit Tests: after [35186], "upgrade" the Canonical fixtures. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35191


git-svn-id: http://core.svn.wordpress.org/trunk@35157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 05:51:24 +00:00
Sergey Biryukov
8aa7fb88f0 Remove a one-time variable from edit_user() added in [35189]. 
See #27317.
Built from https://develop.svn.wordpress.org/trunk@35190


git-svn-id: http://core.svn.wordpress.org/trunk@35156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 05:46:24 +00:00
Sergey Biryukov
7f08716c16 Users: Add 'illegal_user_logins' filter to allow certain usernames to be blacklisted. 
Props danielbachhuber, chriscct7, crazycoolcam, SergeyBiryukov.
Fixes #27317.
Built from https://develop.svn.wordpress.org/trunk@35189


git-svn-id: http://core.svn.wordpress.org/trunk@35155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 05:43:26 +00:00
Scott Taylor
b6b2baccbd Unit Tests: create more fixtures for Tests_User. When using a factory to create ad hoc users, use the inherited static prop $static_factory instead of the instance prop, $factory. If 2 factories are used out of sync, the generator sequences diverge and dupes can be created, causing an untold number of unforeseen errors. Yay. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35188


git-svn-id: http://core.svn.wordpress.org/trunk@35154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 05:30:25 +00:00
Sergey Biryukov
09ee95ea49 Themes: Add Install Parent Theme button for child themes that are missing a parent theme. 
Props rabmalin for initial patch.
Fixes #32668.
Built from https://develop.svn.wordpress.org/trunk@35187


git-svn-id: http://core.svn.wordpress.org/trunk@35153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 05:11:24 +00:00
Scott Taylor
5cebd10ced Unit Tests: implement setUpBeforeClass() and tearDownAfterClass() on WP_UnitTestCase. Use late static binding (plus a gross fallback for PHP 5.2) to check if wpSetUpBeforeClass() or wpTearDownAfterClass() exist on the called class, and then call it and pass a static WP_UnitTest_Factory instance via Dependency Injection, if it exists. 
This makes it way easier to add fixtures, and tear them down, without needing to instantiate `WP_UnitTest_Factory` in every class - removes the need to call `commit_transaction()` in each individual class.

See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35186


git-svn-id: http://core.svn.wordpress.org/trunk@35152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 04:44:25 +00:00
Scott Taylor
e62864ce46 Unit Tests: in Tests_Term, create fixtures for posts. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35185


git-svn-id: http://core.svn.wordpress.org/trunk@35151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 03:48:25 +00:00
Sergey Biryukov
e63ba31f93 Acessibility: Add back-compat styles for plugins that use h3 inside the .metabox-holder container. 
Props afercia.
Fixes #33557.
Built from https://develop.svn.wordpress.org/trunk@35184


git-svn-id: http://core.svn.wordpress.org/trunk@35150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 03:38:25 +00:00
Scott Taylor
ad90d33285 Unit Tests: in Tests_Post, create fixtures for users. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35183


git-svn-id: http://core.svn.wordpress.org/trunk@35149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 03:31:24 +00:00
Helen Hou-Sandí
f3107e5842 Make some primary action buttons look primary. 
* User deletion/removal
* Site status change (multisite)
* Network upgrade
* Import file upload
* Media browser upload

props Dezzy for the initial patch.
fixes #23738.

Built from https://develop.svn.wordpress.org/trunk@35182


git-svn-id: http://core.svn.wordpress.org/trunk@35148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 03:08:24 +00:00
Scott Taylor
2c46a4dcba Unit Tests: in Tests_Media::test_wp_get_attachment_image_srcset_array_no_width(), just toggle metadata, instead of creating a new attachment. Shaves 75ms off the test. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35181


git-svn-id: http://core.svn.wordpress.org/trunk@35147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 02:55:24 +00:00
Sergey Biryukov
6d91caa931 Theme Editor: Repurpose the 'wp_theme_editor_filetypes' filter added in [35134] to actually filter file types instead of files. 
Default types include 'php' and 'css' and cannot be removed, only new types can be added.

Props DrewAPicture, SergeyBiryukov.
Fixes #22924.
Built from https://develop.svn.wordpress.org/trunk@35180


git-svn-id: http://core.svn.wordpress.org/trunk@35146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 02:20:24 +00:00
Scott Taylor
317d62bfad Unit Tests: make a fixture in Tests_Media to represent the large image, instead of creating it 10 times. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35179


git-svn-id: http://core.svn.wordpress.org/trunk@35145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 01:43:24 +00:00
Scott Taylor
60ad26b4fd Unit Tests: move some oEmbed tests that can trigger HTTP calls to Tests_External_HTTP_OEmbed. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35178


git-svn-id: http://core.svn.wordpress.org/trunk@35144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 01:29:24 +00:00
Scott Taylor
f19e4c9b46 Unit Tests: Tests_Canonical doesn't need to call wp_set_current_user() or implement tearDown because its grandparent calls wp_set_current_user( 0 ) in tearDown(). 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35177


git-svn-id: http://core.svn.wordpress.org/trunk@35143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 01:18:24 +00:00
Scott Taylor
972e76991f Unit Tests: Tests_Comment needs a tearDownAfterClass impl to avoid spillage. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35176


git-svn-id: http://core.svn.wordpress.org/trunk@35142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 01:06:24 +00:00
Scott Taylor
083537d213 Unit Tests: Tests_Auth needs a tearDownAfterClass impl to avoid spillage. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35175


git-svn-id: http://core.svn.wordpress.org/trunk@35141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 01:04:24 +00:00
Scott Taylor
b7e9b93be3 Unit Tests: call commit_transaction() in Tests_Auth set up. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35174


git-svn-id: http://core.svn.wordpress.org/trunk@35140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 00:49:24 +00:00
Scott Taylor
b1a39f1a6a Unit Tests: reuse fixtures in Tests_Comment. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35173


git-svn-id: http://core.svn.wordpress.org/trunk@35139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 00:39:23 +00:00
Scott Taylor
e9db7c15fd Unit Tests: move ->test_readme() out of Tests_Basic and into Tests_External_HTTP_Basic in tests/external-http/. 
I intend to move other `wp_remote_get()` tests into similar classes.

See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35172


git-svn-id: http://core.svn.wordpress.org/trunk@35138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 00:23:24 +00:00
Scott Taylor
351d78fbac Unit Tests: wrestle performance out of Tests_Auth by cloning the same user for a majority of the tests. 
See #30017, #33968.

Built from https://develop.svn.wordpress.org/trunk@35171


git-svn-id: http://core.svn.wordpress.org/trunk@35137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-15 00:11:24 +00:00
Drew Jaynes
217b661703 Docs: Add missing descriptions for the $wpdb global in DocBlocks all the places. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35170


git-svn-id: http://core.svn.wordpress.org/trunk@35136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 23:44:25 +00:00
Drew Jaynes
43c10f7d35 Docs: Fix third-person singular verbs for summaries in wp-admin/includes/bookmarks.php. 
Also adds some missing parameter, return, and global descriptions, and one missing summary.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35169


git-svn-id: http://core.svn.wordpress.org/trunk@35135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 23:25:25 +00:00
Drew Jaynes
c78ee60edd Docs: Standardize file header summary for wp-admin/includes/ajax-actions.php. 
See #33701.

[ci skip]

Built from https://develop.svn.wordpress.org/trunk@35168


git-svn-id: http://core.svn.wordpress.org/trunk@35134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 22:49:24 +00:00
Drew Jaynes
c3ee28ea06 Docs: wp-admin/includes/admin-filters.php is part of the Administration subpackage, update the summary. 
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35167


git-svn-id: http://core.svn.wordpress.org/trunk@35133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 22:35:24 +00:00
Drew Jaynes
2e2e898802 Docs: Add a version and standardize the file header summary for wp-admin/includes/admin.php. 
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35166


git-svn-id: http://core.svn.wordpress.org/trunk@35132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 22:32:24 +00:00
Boone Gorges
a53fe085aa Fix incorrect variable names from [35164]. 
Cool story - the tests appeared to pass with the typos.

See #30017, #33968.
Built from https://develop.svn.wordpress.org/trunk@35165


git-svn-id: http://core.svn.wordpress.org/trunk@35131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 22:00:26 +00:00
Boone Gorges
ba37dc9123 Share fixtures in Tests_Admin_includesListTable tests. 
See #30017, #33968.
Built from https://develop.svn.wordpress.org/trunk@35164


git-svn-id: http://core.svn.wordpress.org/trunk@35130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 21:41:24 +00:00
Boone Gorges
cb8a2f2e47 Share fixtures in Tests_Get_Archives. 
See #30017, #33968.
Built from https://develop.svn.wordpress.org/trunk@35163


git-svn-id: http://core.svn.wordpress.org/trunk@35129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 21:30:25 +00:00
Boone Gorges
530111994d Create fewer fixtures in some tests. 
See #30017, #33968.
Built from https://develop.svn.wordpress.org/trunk@35162


git-svn-id: http://core.svn.wordpress.org/trunk@35128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 21:24:24 +00:00
Helen Hou-Sandí
6820130e33 Screen options: Improve the "Apply" button 
Previously the button was output as a part of the per-page option rendering, inline with that input. While this was appropriate for core's usage, the `screen_settings` filter has allowed plugins to place additional items at the bottom of the panel, which a number take advantage of. This leads to confusing situations where plugins that don't save settings via Ajax either have to add their own button or piggyback onto the existing button, which doesn't make any sense in the flow of additional options. It also hinders core from adding any other options that need to be submitted.

Also, when the screen options panel is open, a submit button there is the primary action at that moment. The "Apply" button also does a full page load, which a primary button indicates better.

fixes #34295. see #22222, #23738.

Built from https://develop.svn.wordpress.org/trunk@35161


git-svn-id: http://core.svn.wordpress.org/trunk@35127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 18:58:25 +00:00
Andrea Fercia
f1787056de Bump the "Status" H3 heading to H2 on the Edit Comment screen for better accessibility. 
Fixes #34286.
Built from https://develop.svn.wordpress.org/trunk@35160


git-svn-id: http://core.svn.wordpress.org/trunk@35126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 17:44:24 +00:00
Jeremy Felt
9dd1462fe3 MS: Introduce action before_signup_header. 
This aligns `wp-signup.php` a bit more `with `wp-activate.php` and, among other things, allows a plugin to redirect signup requests.

Props pbearne.
Fixes #17630.

Built from https://develop.svn.wordpress.org/trunk@35159


git-svn-id: http://core.svn.wordpress.org/trunk@35125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 17:32:49 +00:00
Andrea Fercia
c4ff6317a7 Bump H3 headings to H2 on the legacy Link Manager screen for better accessibility. 
Fixes #34285.
Built from https://develop.svn.wordpress.org/trunk@35158


git-svn-id: http://core.svn.wordpress.org/trunk@35124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 17:32:24 +00:00
Drew Jaynes
d01f1c2e15 Docs: Add missing file headers to two Toolbar API files: wp-includes/admin-bar.php and wp-includes/class-wp-admin-bar.php. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35157


git-svn-id: http://core.svn.wordpress.org/trunk@35123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 17:27:25 +00:00
Jeremy Felt
b9b7592ee8 MS: Add "Settings" link under "Network Admin" toolbar menu. 
Props johnjamesjacoby.
Fixes #34287.

Built from https://develop.svn.wordpress.org/trunk@35156


git-svn-id: http://core.svn.wordpress.org/trunk@35122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 17:00:26 +00:00
Andrea Fercia
19eb905f58 Accessibility: update a jQuery selector used for the Plugin Cards after [35009]. 
When updating a plugin from its details modal dialog, focus should be moved back to the plugin title which now is a H3 heading.

Fixes #33818.
Built from https://develop.svn.wordpress.org/trunk@35155


git-svn-id: http://core.svn.wordpress.org/trunk@35121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 15:27:27 +00:00
Boone Gorges
fde30ae8b7 Create fewer fixtures in XML-RPC getComments tests. 
See #30017, #33968.
Built from https://develop.svn.wordpress.org/trunk@35154


git-svn-id: http://core.svn.wordpress.org/trunk@35120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 14:39:27 +00:00
John Blackbourn
a5cca9c5ff Reinstate the Link Category admin screen after [34359]. 
See [13216]

Fixes #34284

Built from https://develop.svn.wordpress.org/trunk@35153


git-svn-id: http://core.svn.wordpress.org/trunk@35119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 01:51:26 +00:00
John Blackbourn
8dd677a09f Introduce a language chooser to the site signup process on Multisite. 
If your Multisite installation is one of the relatively few that allows new sites to be registered, either by existing users or by new visitors to your site, a 'Site Language' dropdown menu will now be presented if your network has additional languages installed. This option defaults to the value of the 'Default Language' setting on the Network Admin Settings screen, and is restricted to currently installed languages.

The languages available in this setting can be controlled via the `signup_get_available_languages` filter. To disable it completely, return an empty array.

Fixes #33844
Props DrewAPicture, johnbillion

Built from https://develop.svn.wordpress.org/trunk@35152


git-svn-id: http://core.svn.wordpress.org/trunk@35118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 23:46:25 +00:00
John Blackbourn
87aa982824 Include network-active plugins and inactive network-only plugins on the Plugins listing screen for individual sites on Multisite. 
These plugins are only shown to users with the `manage_network_plugins` capability, which is Super Admins by default. This new feature lowers the blood pressure of Super Admins who may browse or search the Plugins listing screen of an individual site, having forgotten that a particular plugin is network-active. Showing inactive network-only plugins here also reduces friction when searching the Plugins listing screen on individual sites.

This change introduces a `show_network_active_plugins` filter which controls whether the network-active plugins and inactive network-only plugins are shown. This can be used to enable this functionality for regular site admininstrators, or, indeed, to disable this functionality for Super Admins.

Fixes #20104

Built from https://develop.svn.wordpress.org/trunk@35151


git-svn-id: http://core.svn.wordpress.org/trunk@35117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 22:12:25 +00:00
Sergey Biryukov
31b40bdbb7 Remove fast_finish: true from Travis CI configuration for now. 
Upstream: https://github.com/travis-ci/travis-ci/issues/4928
Built from https://develop.svn.wordpress.org/trunk@35150


git-svn-id: http://core.svn.wordpress.org/trunk@35116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 21:36:24 +00:00
John Blackbourn
537ac4c2ec Improve the docs for the $expiration parameter in set_transient(), set_site_transient(), and associated filters. 
See #32246

Built from https://develop.svn.wordpress.org/trunk@35149


git-svn-id: http://core.svn.wordpress.org/trunk@35115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 21:31:25 +00:00
Dominik Schilling
a2a4bdcb9d Improve [35146] to only skip pluggable function signature tests for wp-includes/cache.php when an external object cache is in use. 
See #31491, #33867.
Built from https://develop.svn.wordpress.org/trunk@35148


git-svn-id: http://core.svn.wordpress.org/trunk@35114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 20:45:24 +00:00
John Blackbourn
a9f9cca311 Reinstate wp_cache_get() into the pluggable function tests. The signature tests are now skipped if an external object cache is in use. 
See #31491

Built from https://develop.svn.wordpress.org/trunk@35147


git-svn-id: http://core.svn.wordpress.org/trunk@35113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 19:33:24 +00:00
John Blackbourn
74167bc09a Skip the pluggable function signature tests when an external object cache is in use. 
See #31491

Built from https://develop.svn.wordpress.org/trunk@35146


git-svn-id: http://core.svn.wordpress.org/trunk@35112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 19:31:25 +00:00
John Blackbourn
a13e405b4c Remove wp_cache_reset() from the pluggable functions signature tests, as the function is deprecated and no longer used. 
See #31491, #33867

Built from https://develop.svn.wordpress.org/trunk@35145


git-svn-id: http://core.svn.wordpress.org/trunk@35111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 19:20:25 +00:00
Drew Jaynes
57e69d4a3f Upgrader: Introduce a new action hook pre_auto_update, which fires immediately prior to an auto-update for core, themes, plugins, or translations. 
Props DavidAnderson, welcher.
Fixes #30441.

Built from https://develop.svn.wordpress.org/trunk@35144


git-svn-id: http://core.svn.wordpress.org/trunk@35110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 18:58:25 +00:00
Sergey Biryukov
4ef12c7814 Correct the error message displayed on setup when wp-config-sample.php does not exist. 
Props bradparbs.
Fixes #23247.
Built from https://develop.svn.wordpress.org/trunk@35143


git-svn-id: http://core.svn.wordpress.org/trunk@35109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 17:36:25 +00:00
Drew Jaynes
a0bbd154d9 Multisite: Improve two error strings specifying allowed characters in usernames and site names. 
Also removes two error strings that were likely never being triggered anyway due to the stricter character matching higher up.

Props atomicjack, bjornjohansen, DrewAPicture.
Fixes #33336.

Built from https://develop.svn.wordpress.org/trunk@35142


git-svn-id: http://core.svn.wordpress.org/trunk@35108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 17:33:24 +00:00
Scott Taylor
55e16aa98a KSES: have you ever heard of the <bdo> HTML tag? Same. http://www.w3schools.com/tags/tag_bdo.asp 
Adds unit test.

Props iandunn.
Fixes #34063.

Built from https://develop.svn.wordpress.org/trunk@35141


git-svn-id: http://core.svn.wordpress.org/trunk@35106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 17:18:25 +00:00
Scott Taylor
296671abcc Taxonomy: in wp_list_categories(), add an arg: separator, to allow the overriding of <br/>. 
Props wojtek.szkutnik.
Fixes #9025.

Built from https://develop.svn.wordpress.org/trunk@35140


git-svn-id: http://core.svn.wordpress.org/trunk@35105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 17:02:25 +00:00
Scott Taylor
45a0c26091 Taxonomy: get_terms_to_edit() can also return false or WP_Error. Vars using it should be set to empty string when errors are returned to avoid producing fatal errors when used in string operations. 
Props valendesigns.
Fixes #30472.

Built from https://develop.svn.wordpress.org/trunk@35139


git-svn-id: http://core.svn.wordpress.org/trunk@35104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 16:40:26 +00:00
Drew Jaynes
dc92982950 Users: Restore changes from [35114] accidentally reverted in [35135]. 
See #28631.

Built from https://develop.svn.wordpress.org/trunk@35138


git-svn-id: http://core.svn.wordpress.org/trunk@35103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 15:45:25 +00:00
Boone Gorges
b36cc4deab Create fewer fixtures in some XML-RPC tests. 
See #30017, #33968.
Built from https://develop.svn.wordpress.org/trunk@35137


git-svn-id: http://core.svn.wordpress.org/trunk@35102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 15:32:25 +00:00
Boone Gorges
f240b3398f In WP_UnitTestCase, only flush rewrite rules when they're set. 
See [34810]. See #33968.
Built from https://develop.svn.wordpress.org/trunk@35136


git-svn-id: http://core.svn.wordpress.org/trunk@35101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 15:22:24 +00:00
Drew Jaynes
cdd8891631 Docs: Add a changelog entry mentioning that the number argument now supports -1 (all). 
Also fixes the argument description.

-1 support was added in [35114].

See #28631.

Built from https://develop.svn.wordpress.org/trunk@35135


git-svn-id: http://core.svn.wordpress.org/trunk@35100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 15:16:24 +00:00
Scott Taylor
7c88e86bf6 Theme Editor: add a filter, wp_theme_editor_filetypes, to allow more filetypes to be edited via the Theme Editor. Usage of the Theme Editor is strenuously discouraged, but we should allow you to add whatever filetypes (.less, .scss) you would like. 
Props MikeHansenMe, pross.
Fixes #22924.

Built from https://develop.svn.wordpress.org/trunk@35134


git-svn-id: http://core.svn.wordpress.org/trunk@35099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 14:14:24 +00:00
Scott Taylor
357b916211 Theme Installer: fix the theme "Install"/"Installed" button's vertical alignment for HiDPI displays. 
Props paulwilde.
Fixes #34198.

Built from https://develop.svn.wordpress.org/trunk@35133


git-svn-id: http://core.svn.wordpress.org/trunk@35098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 13:52:27 +00:00
Sergey Biryukov
e19cda5c2d Toolbar: Improve padding of toolbar submenu items on small screens. 
Props tillkruess.
Fixes #28608.
Built from https://develop.svn.wordpress.org/trunk@35132


git-svn-id: http://core.svn.wordpress.org/trunk@35097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 07:40:25 +00:00
Sergey Biryukov
be10375eb6 Accessibility: Add back-compat styles for plugins that still use h2 as a main heading in their screens. 
Props afercia.
Fixes #33559.
Built from https://develop.svn.wordpress.org/trunk@35131


git-svn-id: http://core.svn.wordpress.org/trunk@35096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 07:17:24 +00:00
Sergey Biryukov
1c9ea9bb4a Accessibility: Correct the style for Popular Tags header on Edit Tags screen after [33917]. 
Props afercia.
See #33559. See #33658.
Built from https://develop.svn.wordpress.org/trunk@35130


git-svn-id: http://core.svn.wordpress.org/trunk@35095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 07:14:25 +00:00
Sergey Biryukov
7ebbe03a1f Acessibility: "Add New Category" links on Edit Post screen should not be a header. 
Props afercia.
Fixes #33557.
Built from https://develop.svn.wordpress.org/trunk@35129


git-svn-id: http://core.svn.wordpress.org/trunk@35094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 07:00:25 +00:00
Sergey Biryukov
1c5d327676 Accessibility: bump headings one level up in post meta boxes for a better headings hierarchy. 
Props afercia, joedolson, wonderboymusic.
See #33557.
Built from https://develop.svn.wordpress.org/trunk@35128


git-svn-id: http://core.svn.wordpress.org/trunk@35093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 06:57:24 +00:00
Sergey Biryukov
3cd956f9bb Add the CSS changes missed in [35126]. 
Props afercia.
See #34263.
Built from https://develop.svn.wordpress.org/trunk@35127


git-svn-id: http://core.svn.wordpress.org/trunk@35092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 06:51:24 +00:00
Sergey Biryukov
8688df4306 Accessibility: bump headings one level up on Credits screen for a better headings hierarchy. 
Props afercia.
Fixes #34263.
Built from https://develop.svn.wordpress.org/trunk@35126


git-svn-id: http://core.svn.wordpress.org/trunk@35091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 06:49:26 +00:00
Scott Taylor
596431bd21 Admin Bar: fix the alignment of secondary menu item arrows. 
Props juhise.
Fixes #33836.

Built from https://develop.svn.wordpress.org/trunk@35125


git-svn-id: http://core.svn.wordpress.org/trunk@35090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 03:54:24 +00:00
Scott Taylor
06594694e6 After [35122], update test_wp_unique_filename() to reflect the change. 
See #16226.

Built from https://develop.svn.wordpress.org/trunk@35124


git-svn-id: http://core.svn.wordpress.org/trunk@35089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 03:42:25 +00:00
Boone Gorges
8de6b7aa8e Correct expected counts in WP_User_Query 'number' test. 
The `create_many()` number should be padded by just one, to account for the
user created by the test suite. Introduced in [35114].

We also don't have to create so many fixtures to run this test.

See #28631.
Built from https://develop.svn.wordpress.org/trunk@35123


git-svn-id: http://core.svn.wordpress.org/trunk@35088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 03:26:23 +00:00
Scott Taylor
d8e20fa273 Fotmatting: in sanitize_file_name(), escape % when uploads contain them, otherwise attachment URLs will unescape the char and break. 
Adds unit tests.

Props mordauk, simonwheatley, dd32, solarissmoke.
Fixes #16226.

Built from https://develop.svn.wordpress.org/trunk@35122


git-svn-id: http://core.svn.wordpress.org/trunk@35087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 03:22:24 +00:00
Sergey Biryukov
ae0f01904f Feeds: Remove a confusing comment from add_feed(), added in [3638]. 
It always overrides the default callback if it's set, regardless of the `in_array()` check.

See #34259.
Built from https://develop.svn.wordpress.org/trunk@35121


git-svn-id: http://core.svn.wordpress.org/trunk@35086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 03:14:25 +00:00
Boone Gorges
cd563fd404 Use a more reliable method for generating get_terms() cache key. 
Previously, the cache key included a serialization of `list_terms_exclusions`
callbacks, to ensure that the cache was differentiated properly for different
uses of the `list_terms_exclusions` filter. This strategy was flawed in a
couple of ways: serialization doesn't work equally well for all callable types;
the serialization required reaching into the `$wp_filter` global; serializing
the callback itself didn't properly account for the possibility that the
callback might return different values in different contexts; the cache key
didn't account for other filters that similarly affect the cached values, such
as `terms_clauses`.

We skirt all these issues by concatenating the cache key using the SQL query
string, which will reflect all filters applied earlier in `get_terms()`.

Props boonebgorges, wonderboymusic.
Fixes #21267.
Built from https://develop.svn.wordpress.org/trunk@35120


git-svn-id: http://core.svn.wordpress.org/trunk@35085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 03:07:24 +00:00
Sergey Biryukov
bac64cc984 Docs: Describe the $feedname argument of add_feed(). 
Fixes #34259.
Built from https://develop.svn.wordpress.org/trunk@35119


git-svn-id: http://core.svn.wordpress.org/trunk@35084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 03:01:25 +00:00
Sergey Biryukov
ae9ce0ccd7 Feeds: Pass the second parameter of "do_feed_{$feed}" action, feed name, to callbacks added via add_feed(). 
The `$feed` parameter was added in [35115].

Props slimndap.
See #34259.
Built from https://develop.svn.wordpress.org/trunk@35118


git-svn-id: http://core.svn.wordpress.org/trunk@35083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 02:59:24 +00:00
Boone Gorges
7de3499949 In get_terms(), don't store WP_Term objects in cache. 
Fixes #34282.
Built from https://develop.svn.wordpress.org/trunk@35117


git-svn-id: http://core.svn.wordpress.org/trunk@35082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 02:58:24 +00:00
Scott Taylor
fc842e33c9 Users: when passing a WP_User instance to wp_update_user(), ensure that the user password is not accidentally double-hashed. This is terrifying. 
Adds unit tests.

Props tbcorr, salcode.
Fixes #28435.

Built from https://develop.svn.wordpress.org/trunk@35116


git-svn-id: http://core.svn.wordpress.org/trunk@35081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 02:48:24 +00:00
Sergey Biryukov
c332da3e12 Feeds: Pass the feed name to do_feed_{$feed} action. 
Props johnbillion.
See #34259.
Built from https://develop.svn.wordpress.org/trunk@35115


git-svn-id: http://core.svn.wordpress.org/trunk@35080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 02:44:23 +00:00
Scott Taylor
c9babc4cdd Users: allow -1 (no limit, use with extreme caution on large sites) as the value for number in WP_User_Query - similar to posts_per_page => -1 in WP_Query. 
Adds unit tests.

Props mordauk, jesin, nofearinc.
Fixes #28631.

Built from https://develop.svn.wordpress.org/trunk@35114


git-svn-id: http://core.svn.wordpress.org/trunk@35079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 02:40:24 +00:00
Scott Taylor
5bb40ab27d Widgets: after [35106], ensure that the widget required by the unit test is registered. 
See #19450.

Built from https://develop.svn.wordpress.org/trunk@35113


git-svn-id: http://core.svn.wordpress.org/trunk@35078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 02:37:12 +00:00
Boone Gorges
bec9315360 In term meta lazy-loading tests, force WP_Query to cache results. 
By default, `WP_Query` will not cache query results when using a persistent
object cache. The lazyload tests, however, depend on the cache being set during
each `WP_Query`, because the object cache is cleared between tests.

See #31491.
Built from https://develop.svn.wordpress.org/trunk@35112


git-svn-id: http://core.svn.wordpress.org/trunk@35077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 02:36:48 +00:00
Boone Gorges
07b7e7b3c7 Remove dead code from WP_Query::lazyload_term_meta(). 
Built from https://develop.svn.wordpress.org/trunk@35111


git-svn-id: http://core.svn.wordpress.org/trunk@35076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 02:36:25 +00:00
Sergey Biryukov
2c12662eff Remove obsolete code from `WP_Users_List_Table::get_sortable_columns(). 
Sorting by post count was disabled in [17024].

Props jdgrimes.
See #15861.
Built from https://develop.svn.wordpress.org/trunk@35110


git-svn-id: http://core.svn.wordpress.org/trunk@35075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 02:25:25 +00:00
Sergey Biryukov
319d0e8bf0 Replace get_bloginfo( 'wpurl' ) with admin_url() for plugin activation error message. 
Use `add_query_arg()` instead of constructing the URL manually.

Props johnbillion.
Fixes #34280.
Built from https://develop.svn.wordpress.org/trunk@35109


git-svn-id: http://core.svn.wordpress.org/trunk@35074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 02:12:24 +00:00
Boone Gorges
5d07f8eb46 In cache tests, determine cache class name dynamically. 
Some cache backends may use a class name other than `WP_Object_Cache` for their
cache drop-in. For example, certain versions of the APC Object Cache plugin
have a shim called `APC_Object_Cache`.

See #31491.
Built from https://develop.svn.wordpress.org/trunk@35108


git-svn-id: http://core.svn.wordpress.org/trunk@35073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 02:07:25 +00:00
Sergey Biryukov
34732f5a80 Replace get_bloginfo( 'wpurl' ) with admin_url() in plugin editor. 
Use `add_query_arg()` instead of constructing the URL manually.

Props johnbillion.
See #34280.
Built from https://develop.svn.wordpress.org/trunk@35107


git-svn-id: http://core.svn.wordpress.org/trunk@35072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 02:05:24 +00:00
Scott Taylor
05cd8a447e Widgets: When using the_widget(), the $before_widget argument only receives the widget class if using the default sidebar arguments. Run sprintf after parsing the args to fix this. 
Adds unit test.

Props coffee2code.
Fixes #19450.

Built from https://develop.svn.wordpress.org/trunk@35106


git-svn-id: http://core.svn.wordpress.org/trunk@35071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 01:49:48 +00:00
Sergey Biryukov
426944c744 Replace get_bloginfo( 'wpurl' ) with site_url() in rsd_link(). 
Ensure the correct scheme is used for the `application/rsd+xml` link URL.

Props johnbillion.
See #34280.
Built from https://develop.svn.wordpress.org/trunk@35105


git-svn-id: http://core.svn.wordpress.org/trunk@35070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 01:49:26 +00:00
Drew Jaynes
649382a7f1 Widgets: Rename the $name parameter in is_registered_sidebar() to $sidebar_id and adjust the accepted types to string|int as sidebar IDs can be numeric. 
See #24878.

Built from https://develop.svn.wordpress.org/trunk@35104


git-svn-id: http://core.svn.wordpress.org/trunk@35069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 01:45:25 +00:00
Scott Taylor
2e6865a7fb Widgets: add a default filter for widget_text (used by the Text widget), balanceTags, which respects the option for use_balanceTags. 
Props MikeHansenMe.
Fixes #23083.

Built from https://develop.svn.wordpress.org/trunk@35103


git-svn-id: http://core.svn.wordpress.org/trunk@35068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 01:40:26 +00:00
Scott Taylor
aa92c9555a Widgets: add a function, is_registered_sidebar() - helps us avoid touching the $wp_registered_sidebars global. 
Props GaryJ, wonderboymusic.
Fixes #24878.

Built from https://develop.svn.wordpress.org/trunk@35102


git-svn-id: http://core.svn.wordpress.org/trunk@35067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 01:33:25 +00:00
Boone Gorges
ff0b621719 Don't match partial roles in WP_User_Query. 
Because 'role=ocean90' shouldn't match 'role=bocean901'.

Props bocean901, ocean90.
Fixes #22212.
Built from https://develop.svn.wordpress.org/trunk@35101


git-svn-id: http://core.svn.wordpress.org/trunk@35066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 01:32:25 +00:00
Scott Taylor
e7c2544a89 Widgets: when getting settings, and none exist, set them to empty to avoid extraneous database queries on subsequent requests. 
Adds unit tests.

Props kovshenin, MikeHansenMe, dlh.
Fixes #26876.

Built from https://develop.svn.wordpress.org/trunk@35100


git-svn-id: http://core.svn.wordpress.org/trunk@35065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 01:13:24 +00:00
Scott Taylor
a31d7e37dc Color Picker: when opening and closing, toggle a wp-picker-active class on the wrapper. 
Props norcross.
Fixes #29471.

Built from https://develop.svn.wordpress.org/trunk@35099


git-svn-id: http://core.svn.wordpress.org/trunk@35064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 01:08:25 +00:00
Drew Jaynes
48811702cd Feeds: Simplify logic for checking if the do_feed_{$feed} action is hooked to any callbacks. 
See [35097] for where the aforementioned hook was renamed to actually be dynamic, thus rendering creation of the extra `$hook` variable moot.

See #34264.

Built from https://develop.svn.wordpress.org/trunk@35098


git-svn-id: http://core.svn.wordpress.org/trunk@35063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 01:07:25 +00:00
Drew Jaynes
b234b5d896 Feeds: Adjust the do_feed_{$feed} hook name to actually be dynamic, rather than pre-storing the tag name in a variable and referencing that. 
Props johnbillion.
Fixes #34264.

Built from https://develop.svn.wordpress.org/trunk@35097


git-svn-id: http://core.svn.wordpress.org/trunk@35062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 01:03:25 +00:00
Sergey Biryukov
b30dcc3f62 Format the number of comments in wp-includes/embed-template.php for the locale. 
Props johnbillion.
Fixes #34276.
Built from https://develop.svn.wordpress.org/trunk@35096


git-svn-id: http://core.svn.wordpress.org/trunk@35061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 01:02:25 +00:00
Scott Taylor
8941648ead XML-RPC: Add a filter, xmlrpc_memory_limit, to allow the value of $xmlrpc_memory_limit to be increased. 
Props ankit.gade.
Fixes #29957.

Built from https://develop.svn.wordpress.org/trunk@35095


git-svn-id: http://core.svn.wordpress.org/trunk@35060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 01:01:24 +00:00
Drew Jaynes
bcc7f8d079 Plugins: Introduce the delete_plugin transactional hook, which fires immediately after a plugin deletion attempt occurs. 
Props Veraxus for the initial patch.
Fixes #26904.

Built from https://develop.svn.wordpress.org/trunk@35094


git-svn-id: http://core.svn.wordpress.org/trunk@35059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 00:57:25 +00:00
Drew Jaynes
ad6a1303dc Login: Pass the username and WP_User object to the retrieve_password_title filter. 
Adding these parameters creates parity with the `retrieve_password_message` filter, used for modifying the message body of the same password reset email.

Props sudar.
Fixes #34252.

Built from https://develop.svn.wordpress.org/trunk@35093


git-svn-id: http://core.svn.wordpress.org/trunk@35058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 00:51:24 +00:00
Sergey Biryukov
7ef095171a In number_format_i18n(), check if $wp_locale is set before using it. 
Props pauldewouters.
Fixes #31553.
Built from https://develop.svn.wordpress.org/trunk@35092


git-svn-id: http://core.svn.wordpress.org/trunk@35057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-13 00:30:24 +00:00
Sergey Biryukov
e6987f3c31 Correct the post_date format in WP_Date_Query tests. 
It should be `'Y-m-d H:i:s'` in order to match the regex in `get_gmt_from_date()` if `'timezone_string'` option is not set.

Props pbearne.
Fixes #34277.
Built from https://develop.svn.wordpress.org/trunk@35091


git-svn-id: http://core.svn.wordpress.org/trunk@35056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 23:40:24 +00:00
John Blackbourn
00388a1dbf Add missing @since params and update the docs for site_icon_url() and has_site_icon(). 
See #32246

Built from https://develop.svn.wordpress.org/trunk@35090


git-svn-id: http://core.svn.wordpress.org/trunk@35055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 23:28:24 +00:00
John Blackbourn
76b77ff4d1 Remove another unnecessary function_exists() call. 
See [35087]
See #32522

Built from https://develop.svn.wordpress.org/trunk@35089


git-svn-id: http://core.svn.wordpress.org/trunk@35054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 23:20:24 +00:00
Drew Jaynes
cffce78d35 Version bump. 
Built from https://develop.svn.wordpress.org/trunk@35088


git-svn-id: http://core.svn.wordpress.org/trunk@35053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 22:59:25 +00:00
John Blackbourn
993d5c1c4b Remove an unnecessary function_exists() call which was included in the oEmbed feature plugin for compatibility with WordPress < 4.3. 
See #32522

Built from https://develop.svn.wordpress.org/trunk@35087


git-svn-id: http://core.svn.wordpress.org/trunk@35052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 22:54:24 +00:00
John Blackbourn
1a04fde012 Correct two escaping functions used in wp-includes/embed-template.php. 
See #32522

Built from https://develop.svn.wordpress.org/trunk@35086


git-svn-id: http://core.svn.wordpress.org/trunk@35051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 22:52:24 +00:00
John Blackbourn
7cb0dcc9a6 Add missing @since docs for the filters in wp-includes/embed-template.php 
See #32522, #32246

Built from https://develop.svn.wordpress.org/trunk@35085


git-svn-id: http://core.svn.wordpress.org/trunk@35050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 22:51:24 +00:00
John Blackbourn
2dd5ad6327 Correct the @since doc for WP_Query::is_embed(). 
See #32522

Built from https://develop.svn.wordpress.org/trunk@35084


git-svn-id: http://core.svn.wordpress.org/trunk@35049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 22:13:25 +00:00
Scott Taylor
75426585fb oEmbed: add fallback icons (not used yet) for older browsers. 
Props melchoyce.
See #34204.

Built from https://develop.svn.wordpress.org/trunk@35083


git-svn-id: http://core.svn.wordpress.org/trunk@35048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 21:17:25 +00:00
John Blackbourn
a2609c13fa Add $transient as a parameter to the set_transient_{transient} action. 
Props SergeyBiryukov
Fixes #34269

Built from https://develop.svn.wordpress.org/trunk@35082


git-svn-id: http://core.svn.wordpress.org/trunk@35047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 21:02:25 +00:00
Scott Taylor
affe1ab5ad Media: avoid "divide by zero" in wp_get_attachment_image_srcset_array(). 
Fixes #34238.

Built from https://develop.svn.wordpress.org/trunk@35081


git-svn-id: http://core.svn.wordpress.org/trunk@35046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 21:00:26 +00:00
Drew Jaynes
8b49acdd0e Docs: Specify the default image size in the $size parameter description for the image_send_to_editor hook. 
See #34257. See #32246. See [35058].

Built from https://develop.svn.wordpress.org/trunk@35080


git-svn-id: http://core.svn.wordpress.org/trunk@35045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 17:18:24 +00:00
Drew Jaynes
f7e92fc346 Docs: Normalize spacing in the DocBlock for get_image_send_to_editor() following [35056]. 
See #34257. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35079


git-svn-id: http://core.svn.wordpress.org/trunk@35044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 17:16:24 +00:00
Drew Jaynes
2d677edb1f Docs: The $size parameter for the get_image_tag hook also accepts an array. 
See #34257. See [35038].

Built from https://develop.svn.wordpress.org/trunk@35078


git-svn-id: http://core.svn.wordpress.org/trunk@35043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 17:11:24 +00:00
Drew Jaynes
36ef44735d Docs: The $size parameter for the get_image_tag_class hook also accepts an array. 
See #34257. See [35037].

Built from https://develop.svn.wordpress.org/trunk@35077


git-svn-id: http://core.svn.wordpress.org/trunk@35042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 17:09:25 +00:00
Drew Jaynes
bc631019d0 Docs: Adjust documentation for the $size parameter in the_post_thumbnail_url() to clarify the required order of width and height values when passing an array. 
Fixes #34257. Whew!

Built from https://develop.svn.wordpress.org/trunk@35076


git-svn-id: http://core.svn.wordpress.org/trunk@35041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 17:00:26 +00:00
Drew Jaynes
5e67b71443 Docs: The post_thumbnail_size hook can also accept an array (already supported). 
See #34257. See [35069].

Built from https://develop.svn.wordpress.org/trunk@35075


git-svn-id: http://core.svn.wordpress.org/trunk@35040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:57:24 +00:00
Drew Jaynes
03a39f75b3 Docs: The $size parameters in the begin_fetch_post_thumbnail_html and end_fetch_post_thumbnail_html hooks can also accept an array (already supported). 
See #34257. See #32246. See [35070] and [35071].

Built from https://develop.svn.wordpress.org/trunk@35074


git-svn-id: http://core.svn.wordpress.org/trunk@35039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:56:24 +00:00
Drew Jaynes
dcb18faab8 Docs: Normalize spacing in the post_thumbnail_html hook doc following [35072]. 
See #34257. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35073


git-svn-id: http://core.svn.wordpress.org/trunk@35038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:53:24 +00:00
Drew Jaynes
476655b0e0 Docs: Adjust documentation for the $size parameter in the post_thumbnail_html hook doc to clarify the required order of width and height values when an array is passed. 
Also adds the `array` type to the parameter documentation (already supported).

See #34257.

Built from https://develop.svn.wordpress.org/trunk@35072


git-svn-id: http://core.svn.wordpress.org/trunk@35037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:52:24 +00:00
Drew Jaynes
1564eb43b4 Docs: Adjust documentation for the $size parameter in the end_fetch_post_thumbnail_html hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35071


git-svn-id: http://core.svn.wordpress.org/trunk@35036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:50:25 +00:00
Drew Jaynes
91d5909507 Docs: Adjust documentation for the $size parameter in the begin_fetch_post_thumbnail_html hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35070


git-svn-id: http://core.svn.wordpress.org/trunk@35035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:49:24 +00:00
Drew Jaynes
fe0d59a061 Docs: Adjust documentation for the $size parameter in the post_thumbnail_size hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35069


git-svn-id: http://core.svn.wordpress.org/trunk@35034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:48:25 +00:00
Drew Jaynes
2091ff358d Docs: Adjust documentation for the $size parameter in get_the_post_thumbnail() to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35068


git-svn-id: http://core.svn.wordpress.org/trunk@35033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:47:25 +00:00
Drew Jaynes
2519b20959 Docs: Adjust documentation for the $size parameter in the_post_thumbnail() to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35067


git-svn-id: http://core.svn.wordpress.org/trunk@35032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:46:24 +00:00
Drew Jaynes
8544d69d35 Docs: Normalize spacing in the wp_get_attachment_link hook doc following [35065]. 
See #34257. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35066


git-svn-id: http://core.svn.wordpress.org/trunk@35031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:44:24 +00:00
Drew Jaynes
ad628c7165 Docs: Adjust documentation for the $size parameter in the wp_get_attachment_link hook doc to clarify the required order of width and height values when an array is passed. 
Also adds the `array` type to the parameter documentation (already supported).

See #34257.

Built from https://develop.svn.wordpress.org/trunk@35065


git-svn-id: http://core.svn.wordpress.org/trunk@35030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:42:23 +00:00
Drew Jaynes
61115eac58 Docs: Improve documentation for get_site_icon_url(), introduced in [32994]. 
Adds a missing `@since` version, fixes optional parameter syntax, adds default values, and fixes the return description.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35064


git-svn-id: http://core.svn.wordpress.org/trunk@35029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:38:24 +00:00
Drew Jaynes
b1b3fc5deb Docs: Re-clarify the $sizes[ $size ] section of the hash notations for WP_Image_Editor_GD::multi_resize() and WP_Image_Editor_Imagick::multi_resize() as not fully-optional. 
The `$width` value is optional if `$height` is specified, and vice versa. The `$crop` value is always optional and defaults to false.

Props dh-shredder.
See #32246. See [35061] and [35062].

Built from https://develop.svn.wordpress.org/trunk@35063


git-svn-id: http://core.svn.wordpress.org/trunk@35028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:34:23 +00:00
Drew Jaynes
041e3dd285 Docs: Fix hash notation syntax for the $sizes[ $size ] section in the DocBlock for WP_Image_Editor_Imagick::multi_resize(). 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35062


git-svn-id: http://core.svn.wordpress.org/trunk@35027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:27:24 +00:00
Drew Jaynes
243f66836f Docs: Fix hash notation syntax for the $sizes[ $size ] section in the DocBlock for WP_Image_Editor_GD::multi_resize(). 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35061


git-svn-id: http://core.svn.wordpress.org/trunk@35026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:26:24 +00:00
Drew Jaynes
ee544e44d5 Docs: Adjust documentation for the $size parameter in the admin_post_thumbnail_size hook doc to clarify the required order of width and height values when an array is passed. 
See #34257. See #28512.

Built from https://develop.svn.wordpress.org/trunk@35060


git-svn-id: http://core.svn.wordpress.org/trunk@35025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:22:25 +00:00
Drew Jaynes
9f5d887934 Docs: Normalize spacing in the image_send_to_editor hook doc following [35058]. 
See #34257. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35059


git-svn-id: http://core.svn.wordpress.org/trunk@35024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:19:23 +00:00
Drew Jaynes
c12f0caefd Docs: Adjust documentation for the $size parameter in the image_send_to_editor hook doc to clarify the required order of width and height values when an array is passed. 
Also adds the `array` type to the parameter documentation (already supported).

See #34257.

Built from https://develop.svn.wordpress.org/trunk@35058


git-svn-id: http://core.svn.wordpress.org/trunk@35023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:17:24 +00:00
Drew Jaynes
4534f13149 Docs: Fix the syntax for marking parameters optional and add defaults in the DocBlock for wp_get_attachment_link(). 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35057


git-svn-id: http://core.svn.wordpress.org/trunk@35022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:15:24 +00:00
Drew Jaynes
4aea111b29 Docs: Fix syntax and properly mark optional parameters as such in the DocBlock for get_image_send_to_editor(). 
Also fixes the return description, and adds the `$size` default value, missed in [35055].

See #34257. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35056


git-svn-id: http://core.svn.wordpress.org/trunk@35021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:11:24 +00:00
Drew Jaynes
16738bf325 Docs: Adjust documentation for the $size parameter in get_image_send_to_editor() to clarify the required order of width and height values when passing an array. 
Also adds the `array` type to the parameter documentation (already supported).

See #34257.

Built from https://develop.svn.wordpress.org/trunk@35055


git-svn-id: http://core.svn.wordpress.org/trunk@35020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:08:25 +00:00
Drew Jaynes
d4fe129e1a Docs: Adjust the order of 'width' and 'height' (for consistency) for the $crop parameter documentation in image_make_intermediate_size(). 
Props jaspermdegroot.
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35054


git-svn-id: http://core.svn.wordpress.org/trunk@35019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:06:24 +00:00
Drew Jaynes
8b26e5debc Docs: Adjust the order of 'width' and 'height' (for consistency) for the $crop parameter documentation in image_resize_dimensions(). 
Also similarly adjusts the `$crop` parameter description in the corresponding `image_resize_dimensions` hook doc.

Props jaspermdegroot.
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35053


git-svn-id: http://core.svn.wordpress.org/trunk@35018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:02:24 +00:00
Drew Jaynes
e0529ebdb5 Docs: Adjust the order of 'width' and 'height' (for consistency) for the $crop parameter documentation in set_post_thumbnail_size(). 
Props jaspermdegroot.
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35052


git-svn-id: http://core.svn.wordpress.org/trunk@35017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 16:00:26 +00:00
Drew Jaynes
771248a1f3 Docs: Adjust the order of 'width' and 'height' (for consistency) for the $crop parameter documentation in add_image_size(). 
Props jaspermdegroot.
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35051


git-svn-id: http://core.svn.wordpress.org/trunk@35016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:59:25 +00:00
Drew Jaynes
69a3c2d8d7 Docs: Adjust documentation for the $size parameter in wp_get_attachment_link() to clarify the required order of width and height values when passing an array. 
Also adds the `array` type to the parameter documentation (already supported).

Props jaspermdegroot.
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35050


git-svn-id: http://core.svn.wordpress.org/trunk@35015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:56:24 +00:00
Drew Jaynes
d0a392a34c Docs: Adjust documentation for the $size parameter in adjacent_image_link() to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35049


git-svn-id: http://core.svn.wordpress.org/trunk@35014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:53:25 +00:00
Drew Jaynes
81f67bae13 Docs: Adjust documentation for the $size parameter in next_image_link() to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35048


git-svn-id: http://core.svn.wordpress.org/trunk@35013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:50:24 +00:00
Drew Jaynes
141b096f6d Docs: Adjust documentation for the $size parameter in previous_image_link() to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35047


git-svn-id: http://core.svn.wordpress.org/trunk@35012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:48:25 +00:00
Drew Jaynes
1571907571 Docs: Normalize spacing in the $attr hash notation for gallery_shortcode() following [35045]. 
See #34257. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35046


git-svn-id: http://core.svn.wordpress.org/trunk@35011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:46:24 +00:00
Drew Jaynes
e4f9e334ea Docs: Adjust documentation for the $size argument in gallery_shortcode to clarify the required order of width and height values when passing an array. 
Also adds the `array` type to the argument documentation.

Props jaspermdegroot.
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35045


git-svn-id: http://core.svn.wordpress.org/trunk@35010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:43:25 +00:00
Drew Jaynes
9d5d27c26d Docs: Adjust documentation for the $size parameter in wp_get_attachment_image_url() to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35044


git-svn-id: http://core.svn.wordpress.org/trunk@35009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:39:25 +00:00
Drew Jaynes
987fe676a9 Docs: Adjust documentation for the $size parameter in the wp_get_attachment_image_attributes hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35043


git-svn-id: http://core.svn.wordpress.org/trunk@35008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:38:24 +00:00
Drew Jaynes
5631df0151 Docs: Adjust documentation for the $size parameter in wp_get_attachment_image() to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35042


git-svn-id: http://core.svn.wordpress.org/trunk@35007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:36:24 +00:00
Drew Jaynes
c02b132fcc Docs: Adjust documentation for the $size parameter in the wp_get_attachment_image_src hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35041


git-svn-id: http://core.svn.wordpress.org/trunk@35006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:34:24 +00:00
Drew Jaynes
8f3f5dba35 Docs: Adjust documentation for the $size parameter in wp_get_attachment_image_src() to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35040


git-svn-id: http://core.svn.wordpress.org/trunk@35005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:31:24 +00:00
Drew Jaynes
50fd2488f4 Docs: Adjust documentation for the $size parameter in image_get_intermediate_size() to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35039


git-svn-id: http://core.svn.wordpress.org/trunk@35004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:29:24 +00:00
Drew Jaynes
5a0eaa17de Docs: Adjust documentation for the $size parameter in the get_image_tag hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35038


git-svn-id: http://core.svn.wordpress.org/trunk@35003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:27:25 +00:00
Drew Jaynes
698b5f6880 Docs: Adjust documentation for the $size parameter in the get_image_tag_class hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35037


git-svn-id: http://core.svn.wordpress.org/trunk@35002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:26:25 +00:00
Drew Jaynes
71932de1f5 Docs: Adjust documentation for the $size parameter in get_image_tag() to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35036


git-svn-id: http://core.svn.wordpress.org/trunk@35001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:21:25 +00:00
Drew Jaynes
3f8aaf753a Docs: Adjust documentation for the $size parameter in the image_downside hook doc to clarify the required order of width and height values when an array is passed. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35035


git-svn-id: http://core.svn.wordpress.org/trunk@35000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:20:23 +00:00
Drew Jaynes
45174a8996 Docs: Adjust documentation for the $size parameter in image_downsize() to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35034


git-svn-id: http://core.svn.wordpress.org/trunk@34999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:18:24 +00:00
Drew Jaynes
7c25ad0613 Docs: Adjust documentation for the $size parameter in image_constrain_size_for_editor() to clarify the required order of width and height values when passing an array. 
See #34257.

Built from https://develop.svn.wordpress.org/trunk@35033


git-svn-id: http://core.svn.wordpress.org/trunk@34998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:16:24 +00:00
Boone Gorges
499d1b74ba Don't cache WP_Term objects in wp_get_object_cache(). 
The data stored in the cache should be raw database query results, not
`WP_Term` objects (which may be modified by plugins, and may contain additional
properties that shouldn't be cached).

If term relationships caches were handled in `wp_get_object_terms()` - where
a database query takes place - it would be straightforward to cache raw data.
See #34239. Since, in fact, `get_the_terms()` caches the value it gets from
`wp_get_object_terms()`, we need a technique that allows us to get raw data
from a `WP_Term` object. Mirroring `WP_User`, we introduce a `data` property
on term objects, which `get_the_terms()` uses to fetch cacheable term info.

Fixes #34262.
Built from https://develop.svn.wordpress.org/trunk@35032


git-svn-id: http://core.svn.wordpress.org/trunk@34997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:13:48 +00:00
Boone Gorges
6912d6fe64 Be stricter about sanitizing values coming out of WP_Term. 
Data passed into `get_instance()` should be run through `sanitize_term()`
before being used.

See #34262.
Built from https://develop.svn.wordpress.org/trunk@35031


git-svn-id: http://core.svn.wordpress.org/trunk@34996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:13:24 +00:00
Boone Gorges
2e4877d80c Fix incorrect setup in 'tag' query var test. 
The test, introduced in [33724], was intended to demonstrate the behavior of
`example.com?tag=foo` routing. But an error in the test setup meant that a
URL-encoded tag object was being set as the value of 'tag'. Due to a quirk in
the way that `parse_request()` parses query vars, an object value for 'tag'
would inadvertently produce correct results in certain cases. But it's not a
usage we actively support, and it's not what was meant to be tested.

See #33532, #34262.
Built from https://develop.svn.wordpress.org/trunk@35030


git-svn-id: http://core.svn.wordpress.org/trunk@34995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 15:04:26 +00:00
Boone Gorges
58aee33cd9 After [35028], normalize get_term_field() doc formatting. 
Fixes #34245.
Built from https://develop.svn.wordpress.org/trunk@35029


git-svn-id: http://core.svn.wordpress.org/trunk@34994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 04:14:48 +00:00
Boone Gorges
1a87ade436 Don't require a $taxonomy to be specified in get_term_field(). 
After [34997], the `$taxonomy` parameter of `get_term()` is optional. This
changeset brings `get_term_field()` in line with the new usage.

Adds unit tests for `get_term_field()`.

Props DrewAPicture.
See #34245.
Built from https://develop.svn.wordpress.org/trunk@35028


git-svn-id: http://core.svn.wordpress.org/trunk@34993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 04:14:24 +00:00
Drew Jaynes
f60bd8d827 Docs: Wrap a couple of hook name references in inline @see tags in the hook docs for custom_menu_order and menu_order. 
Inline `@see` tags in the context of hooks are parsed as links to hook pages in the Code Reference.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35027


git-svn-id: http://core.svn.wordpress.org/trunk@34992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 03:39:26 +00:00
Jeremy Felt
270d3f422c MS: Reflect falsy values for upload_space_check_disabled in UI. 
If the network option for `upload_space_check_disabled` is missing or an empty string, we should reflect how it will be treated elsewhere in the UI.

Props stephenharris.
Fixes #33986.

Built from https://develop.svn.wordpress.org/trunk@35026


git-svn-id: http://core.svn.wordpress.org/trunk@34991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-12 00:01:24 +00:00
Jeremy Felt
364e63b83b MS: Reject truthy, non-numeric network ids in _network_option(). 
A valid `$network_id` or `null`/`false` is expected as the first parameter for `_network_option()`. If something other than that is passed, we immediately return `false` rather than attempting to guess what network was intended.

See #28290.

Built from https://develop.svn.wordpress.org/trunk@35025


git-svn-id: http://core.svn.wordpress.org/trunk@34990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-11 23:30:24 +00:00
Jeremy Felt
092478579a MS: Adjust _network_option() parameter order, $network_id is first. 
This better aligns with expectations and matches the structure used by `_blog_option()`. The `_site_option()` functions remain as an appropriate method for working with the current network.

See #28290.

Built from https://develop.svn.wordpress.org/trunk@35024


git-svn-id: http://core.svn.wordpress.org/trunk@34989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-11 22:44:27 +00:00
Drew Jaynes
2c6e416159 Media: Remove logic for unnecessarily overloading the $content_width global when passing default dimensions used to display the post thumbnail image in the 'Featured Image' meta box. 
Updates documentation for the `$size` parameter in `admin_post_thumbnail_size` filter doc.

See #28512.

Built from https://develop.svn.wordpress.org/trunk@35023


git-svn-id: http://core.svn.wordpress.org/trunk@34988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-11 17:10:25 +00:00
Drew Jaynes
889a89c2a2 Media: Introduce the admin_post_thumbnail_size filter, which enables manipulation of the image size used to display the post thumbnail in the 'Featured Image' meta box. 
This filter has no effect on the image size used to display post thumbnails on the front-end.

Props dboulet, DrewAPicture.
Fixes #28512.

Built from https://develop.svn.wordpress.org/trunk@35022


git-svn-id: http://core.svn.wordpress.org/trunk@34987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-11 16:54:26 +00:00
Drew Jaynes
fb2a4bf9fb Docs: Fix some syntactical issues in property DocBlocks for WP_List_Table. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35021


git-svn-id: http://core.svn.wordpress.org/trunk@34986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-11 03:34:26 +00:00
Andrew Ozz
85285d1701 Fix inconsistency in src/wp-includes/js/media/views/uploader/editor.js. 
See #34251.

Built from https://develop.svn.wordpress.org/trunk@35020


git-svn-id: http://core.svn.wordpress.org/trunk@34985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-11 00:09:24 +00:00
Andrew Ozz
8dd2a31c38 Plupload: update to 2.1.8. Changelog: https://github.com/moxiecode/plupload/releases. 
Hide the editor uploader overlay on all drop events in the window, not only when dropping on the editor uploader element.


Fixes #34251, #22403.
Built from https://develop.svn.wordpress.org/trunk@35019


git-svn-id: http://core.svn.wordpress.org/trunk@34984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 23:50:25 +00:00
Sergey Biryukov
11def634f6 Customizer: WP_Customize_Cropped_Image_Control should extend WP_Customize_Image_Control, since Site Icon can only an image. 
Props paulwilde.
Fixes #34250.
Built from https://develop.svn.wordpress.org/trunk@35018


git-svn-id: http://core.svn.wordpress.org/trunk@34983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 23:25:24 +00:00
Jeremy Felt
3b42b801f8 MS: Handle the possibility of 0 when checking a user's upload quota. 
Upload space of 0 is now more possible via r35016 and should be respected rather than modified to a default of 10MB.

Fixes #34037.

Built from https://develop.svn.wordpress.org/trunk@35017


git-svn-id: http://core.svn.wordpress.org/trunk@34982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 23:17:25 +00:00
Jeremy Felt
49ce208880 MS: Allow for a blog_upload_space setting of 0 to restrict uploads. 
Previously, an value matching `empty()` would have been bypassed in favor of the default setting for 100MB.

Related #19538, r19639, r19652, where we saw the bug, fixed the bug, and then unfixed the bug so that it was not a surprise in a point release.

See #34037.

Built from https://develop.svn.wordpress.org/trunk@35016


git-svn-id: http://core.svn.wordpress.org/trunk@34981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 23:15:26 +00:00
Andrea Fercia
6b449abadc Accessibility: bump headings one level up on the Appearance > Widgets screen for a better headings hierarchy. 
Props mrahmadawais, afercia.
Fixes #33659.
Built from https://develop.svn.wordpress.org/trunk@35015


git-svn-id: http://core.svn.wordpress.org/trunk@34980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 16:34:25 +00:00
Scott Taylor
5fdf928bcf Admin JS: after [34977], avoid variable names conflicts with e. 
Props afercia.
Fixes #18590.

Built from https://develop.svn.wordpress.org/trunk@35014


git-svn-id: http://core.svn.wordpress.org/trunk@34979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 15:50:24 +00:00
Scott Taylor
00ade45fd1 Docs: some @global object vernaculars should be converted to the actual object type. 
See #33491.

Built from https://develop.svn.wordpress.org/trunk@35013


git-svn-id: http://core.svn.wordpress.org/trunk@34978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 15:45:25 +00:00
Scott Taylor
57c2ef2655 Users List Table: after [35011], just use wp_roles(), no global import. #winning 
See #22959.

Built from https://develop.svn.wordpress.org/trunk@35012


git-svn-id: http://core.svn.wordpress.org/trunk@34977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 15:36:26 +00:00
Scott Taylor
ab2905da84 Users List Table: after [34963], remove unused code/add doc for global import. 
See #22959.

Built from https://develop.svn.wordpress.org/trunk@35011


git-svn-id: http://core.svn.wordpress.org/trunk@34976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 15:26:24 +00:00
Scott Taylor
d021cb8bc0 WP Screen: after [34991], avoid unnecessary nesting levels and remove unused global import. 
See #33646.

Built from https://develop.svn.wordpress.org/trunk@35010


git-svn-id: http://core.svn.wordpress.org/trunk@34975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 15:20:24 +00:00
Andrea Fercia
6ec8174ca1 Accessibility: bump headings one level up on the Add Plugins screen for a better headings hierarchy. 
Fixes #33818.
Built from https://develop.svn.wordpress.org/trunk@35009


git-svn-id: http://core.svn.wordpress.org/trunk@34974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 15:17:26 +00:00
Sergey Biryukov
a5c1f545c4 Users: Remove redundant error message when password is only entered once. 
"Please enter the same password in both password fields" should cover all the scenarios.

Props MikeHansenMe, jmayhak, desrosj, gounder.
Fixes #33101.
Built from https://develop.svn.wordpress.org/trunk@35008


git-svn-id: http://core.svn.wordpress.org/trunk@34973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 13:22:26 +00:00
Weston Ruter
1fe64b1c65 Customizer: Fix scalability performance problem for previewing multidimensional settings. 
As the number of multidimensional settings (serialized options and theme mods) increase for a given ID base (e.g. a widget of a certain type), the number of calls to the `multidimensional` methods on `WP_Customize_Setting` increase exponentially, and the time for the preview to refresh grows in time exponentially as well.

To improve performance, this change reduces the number of filters needed to preview the settings off of a multidimensional root from N to 1. This improves performance from `O(n^2)` to `O(n)`, but the linear increase is so low that the performance is essentially `O(1)` in comparison. This is achieved by introducing the concept of an "aggregated multidimensional" setting, where the root value of the multidimensional serialized setting value gets cached in a static array variable shared across all settings.

Also improves performance by only adding preview filters if there is actually a need to do so: there is no need to add a filter if there is an initial value and if there is no posted value for a given setting (if it is not dirty).

Fixes #32103.

Built from https://develop.svn.wordpress.org/trunk@35007


git-svn-id: http://core.svn.wordpress.org/trunk@34972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 09:06:25 +00:00
Sergey Biryukov
ac9a85a45e Use wp_star_rating() on Add Themes screen: 
* It works correctly for RTL
* Requires less CSS styling
* Is visually consistent with plugin ratings
* Is more accessible

Fixes #34080.
Built from https://develop.svn.wordpress.org/trunk@35006


git-svn-id: http://core.svn.wordpress.org/trunk@34971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 06:51:24 +00:00
Sergey Biryukov
24219160f1 Add echo parameter for wp_star_rating(). 
See #34080.
Built from https://develop.svn.wordpress.org/trunk@35005


git-svn-id: http://core.svn.wordpress.org/trunk@34970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 06:43:24 +00:00
Drew Jaynes
c6bffb6264 Docs: Fix some minor formatting in the $query_args parameter description for the `` filter doc. 
See #8243. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35004


git-svn-id: http://core.svn.wordpress.org/trunk@34969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 06:39:24 +00:00
Drew Jaynes
504ff07656 Dashboard: Introduce the dashboard_recent_drafts_query_args filter, making it possible to manipulate the post query arguments used in the 'Recent Drafts' dashboard widget. 
Props iamfriendly.
Fixes #8243.

Built from https://develop.svn.wordpress.org/trunk@35003


git-svn-id: http://core.svn.wordpress.org/trunk@34968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 06:33:25 +00:00
Drew Jaynes
69c828b77b Template: Pass the $post parameter to the the_permalink filter. 
Props chriscct7.
Fixes #34234. See #23882.

Built from https://develop.svn.wordpress.org/trunk@35002


git-svn-id: http://core.svn.wordpress.org/trunk@34967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 05:46:24 +00:00
Drew Jaynes
c2b5aeebb0 Template: Rename the $id parameters in the_permalink(), get_the_permalink(), and get_permalink() to $post. 
In all three cases, the functions can accept a post ID, a `WP_Post` object, or a falsey value, which defaults to the value of the global `$post`. Switching to `$post` in this context allows the parameters to better self-document and removes ambiguity in the code they are subsequently used in.

Props chriscct7 for the initial patch.
See #34234.

Built from https://develop.svn.wordpress.org/trunk@35001


git-svn-id: http://core.svn.wordpress.org/trunk@34966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 05:41:29 +00:00
Sergey Biryukov
5399881b18 Merge two database update strings for consistency. 
Props pavelevap.
Fixes #33514.
Built from https://develop.svn.wordpress.org/trunk@35000


git-svn-id: http://core.svn.wordpress.org/trunk@34965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 05:14:23 +00:00
Boone Gorges
636464857e Return WP_Post objects from wp_get_object_terms(). 
A side effect of this change is that terms stored in the cache no longer have
an `object_id` associated with them. Previously, `object_id` had always been
cached when the term cache was populated via `wp_get_object_terms()`, a
strategy that was mostly harmless but still incorrect.

See #14162.
Built from https://develop.svn.wordpress.org/trunk@34999


git-svn-id: http://core.svn.wordpress.org/trunk@34964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 03:39:26 +00:00
Boone Gorges
71429da5b4 Return WP_Term objects from get_terms(). 
Props boonebgorges, flixos90, DrewAPicture.
See #14162.
Built from https://develop.svn.wordpress.org/trunk@34998


git-svn-id: http://core.svn.wordpress.org/trunk@34963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 02:13:28 +00:00
Boone Gorges
623e467712 Introduce WP_Term. 
`get_term()` now returns a `WP_Term` object, instead of a `stdClass` object.
Cache support and sanitization filters for individual terms are now more
centralized. For example, `get_term_by()` is able to cast results of its query
to a `WP_Term` object by passing it through `get_term()`.

The `$taxonomy` parameter for `get_term()` is now optional, as terms ought to
be unique to a taxonomy (ie, shared terms no longer exist). In cases where
`get_term()` detects that the term matching the specified term_id is from the
wrong taxonomy, it checks to see if you've requested a shared term, and if so,
it splits the term. This is used only for fallback purposes.

The elimination of shared terms allows the caching strategy for terms to be
simplified. Individual terms are now cached in a single 'terms' bucket.

Props flixos90, boonebgorges, scribu, dipesh.kakadiya.
See #14162.
Built from https://develop.svn.wordpress.org/trunk@34997


git-svn-id: http://core.svn.wordpress.org/trunk@34962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 01:59:29 +00:00
Jeremy Felt
f8a05879e8 MS: Show an error if a new site slug conflicts with an existing username. 
Props utkarshpatel, dipesh.kakadiya.
Fixes #33804.

Built from https://develop.svn.wordpress.org/trunk@34996


git-svn-id: http://core.svn.wordpress.org/trunk@34961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-10 01:42:26 +00:00
Drew Jaynes
1b1e18027d Template: Make it possible to both ''add'' and ''remove'' items from the page templates list using the theme_page_templates filter. 
The `theme_page_templates` hook was originally added in [27297] as `page_templates`, and later renamed in [27470]. Previously, it was only possible to remove or rename page templates via this hook.

Fixes #13265. Fixes #25879.

Built from https://develop.svn.wordpress.org/trunk@34995


git-svn-id: http://core.svn.wordpress.org/trunk@34960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 21:51:25 +00:00
Sergey Biryukov
662ad721ec Remove stray closing tag in wp-admin/themes.php. 
Props tfrommen.
Fixes #34237.
Built from https://develop.svn.wordpress.org/trunk@34994


git-svn-id: http://core.svn.wordpress.org/trunk@34959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 21:17:25 +00:00
Drew Jaynes
e89737ccfb Docs: Fix wrapping and syntax for a multi-comment in Walker_Comment::display_element(). 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34993


git-svn-id: http://core.svn.wordpress.org/trunk@34958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 21:03:25 +00:00
Drew Jaynes
e38a6edc61 Docs: Indent an example comment tree in the DocBlock for Walker_Comment::display_element() so it can be properly parsed in Markdown for the Code Reference. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34992


git-svn-id: http://core.svn.wordpress.org/trunk@34957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 21:00:27 +00:00
Andrea Fercia
42b33e1645 Administration: Convert H5 usage in Screen Options to use fieldsets and legends. 
These H5 (heading level 5) don't allow for a good headings hierarchy and shouldn't be headings in the first place. Each group of options has now its own fieldset and legend.
In `render_screen_options()`, introduce two new "render" methods: `render_meta_boxes_preferences()` and `render_list_table_columns_preferences()` for consistency with already existing render methods and cleaner code.

Props joedolson, afercia.
Fixes #33646.
Built from https://develop.svn.wordpress.org/trunk@34991


git-svn-id: http://core.svn.wordpress.org/trunk@34956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 18:05:24 +00:00
Helen Hou-Sandí
681573e80a Notices: Update one more instance of white-on-white. 
Because the media modal can be used on the front-end, the CSS needs to be added here rather than using the notice classes.

props paulwilde.
fixes #32244.

Built from https://develop.svn.wordpress.org/trunk@34990


git-svn-id: http://core.svn.wordpress.org/trunk@34955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 17:47:25 +00:00
Boone Gorges
a19d63b7a5 Ensure that WP_Date_Query accepts a value of 0 for 'hour'. 
Props jim912.
Fixes #34228.
Built from https://develop.svn.wordpress.org/trunk@34989


git-svn-id: http://core.svn.wordpress.org/trunk@34954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 16:33:25 +00:00
Sergey Biryukov
b40e362711 Fix typo in get_avatar() and get_avatar_data() docs. 
Props johnjamesjacoby.
Fixes #34232.
Built from https://develop.svn.wordpress.org/trunk@34988


git-svn-id: http://core.svn.wordpress.org/trunk@34953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 15:52:24 +00:00
Drew Jaynes
7e26ee2e3c Install: Match existing tonal style in setup-config.php by converting strings containing 'do not' and 'does not' to instead use contractions. 
The 'do not' is converted to "don't" because "you" is third-person plural, and 'does not' is converted to "doesn't" because `localhost` is third-person singular. While both are "negative" contractions, we often write this way in WordPress to provide a friendlier tone. That's your English grammar lesson for the day.

Props ankit-k-gupta, iamfriendly.
Fixes #30317.

Built from https://develop.svn.wordpress.org/trunk@34987


git-svn-id: http://core.svn.wordpress.org/trunk@34952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 15:43:27 +00:00
Sergey Biryukov
072cdf116a Fix typo in wp_rand() docs. 
See #28633.
Built from https://develop.svn.wordpress.org/trunk@34986


git-svn-id: http://core.svn.wordpress.org/trunk@34951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 05:20:23 +00:00
Sergey Biryukov
0d7c5569f5 In do_robots(), allow crawling for admin-ajax.php, since it's often used on front-end. 
Props dmchale, joostdevalk.
Fixes #33156.
Built from https://develop.svn.wordpress.org/trunk@34985


git-svn-id: http://core.svn.wordpress.org/trunk@34950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 05:16:23 +00:00
Sergey Biryukov
95da3826b9 Media: Return early from media_sideload_image() if $file didn't match the pattern for images. 
Props MikeHansenMe, serpent7776.
Fixes #32755.
Built from https://develop.svn.wordpress.org/trunk@34984


git-svn-id: http://core.svn.wordpress.org/trunk@34949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 04:46:24 +00:00
Drew Jaynes
d8811d591b Tests: Add basic DocBlocks for four helper methods in general/template.php used to assist testing the Site Icon feature. 
All four helpers were introduced in the feature merge for 4.3.

See #33968.

Built from https://develop.svn.wordpress.org/trunk@34983


git-svn-id: http://core.svn.wordpress.org/trunk@34948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 04:35:24 +00:00
Sergey Biryukov
3012b862af Add $id parameter to the_permalink(), for consistency with get_permalink(). 
Props johnjamesjacoby, chriscct7.
Fixes #23882.
Built from https://develop.svn.wordpress.org/trunk@34982


git-svn-id: http://core.svn.wordpress.org/trunk@34947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 04:34:24 +00:00
Dion Hulse
4852cbf14b Use PHP7's random_int() CSPRNG functionality in wp_rand() with a fallback to the random_compat library for PHP 5.x. 
`random_compat` offers a set of compatible functions for older versions of PHP, filling in the gap by using other PHP extensions when available.
We still include our existing `wp_rand()` functionality as a fallback for when no proper CSPRNG exists on the system.

Take Two, this was previously committed in [34922] but had an issue on PHP 5.2 which sarciszewski has now resolved.

Props sarciszewski
See #28633

Built from https://develop.svn.wordpress.org/trunk@34981


git-svn-id: http://core.svn.wordpress.org/trunk@34946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 04:28:24 +00:00
Sergey Biryukov
dfc4654172 Dashboard: Display year in Activity widget if the post date year is not the same as the current one. 
Props GaryJ, chriscct7.
Fixes #26502.
Built from https://develop.svn.wordpress.org/trunk@34980


git-svn-id: http://core.svn.wordpress.org/trunk@34945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 04:26:24 +00:00
Sergey Biryukov
6595b1b080 My Sites: Make "Create a New Site" link consistent with other "Add New" links. 
Props JeffMatson.
Fixes #34179.
Built from https://develop.svn.wordpress.org/trunk@34979


git-svn-id: http://core.svn.wordpress.org/trunk@34944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 03:50:24 +00:00
Sergey Biryukov
3c7b7f7133 After [34529], if a compatible termmeta table is found on database upgrade, convert it to utf8mb4 collation. 
Props dboulet.
Fixes #34224.
Built from https://develop.svn.wordpress.org/trunk@34978


git-svn-id: http://core.svn.wordpress.org/trunk@34943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 02:07:25 +00:00
Andrew Ozz
a6cf0b41a6 JS: in event callbacks replace the very outdated return false with preventDefault(). 
Props adamsilverstein.
Fixes #18590.
Built from https://develop.svn.wordpress.org/trunk@34977


git-svn-id: http://core.svn.wordpress.org/trunk@34942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 01:27:27 +00:00
Helen Hou-Sandí
b23005d7c1 Revisions: Update slider handle styling. 
This brings them in line with updated buttons as done in [34948] for #31459. It also gives it secondary action styling as opposed to primary, as restoring is considered the primary action.

props hugobaeta.
fixes #34220.

Built from https://develop.svn.wordpress.org/trunk@34976


git-svn-id: http://core.svn.wordpress.org/trunk@34941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 00:25:25 +00:00
Drew Jaynes
c67853a6da Docs: Add a missing @since version to the hook doc for the the_excerpt_embed filter, introduced in [34903]. 
See #34227.

Built from https://develop.svn.wordpress.org/trunk@34975


git-svn-id: http://core.svn.wordpress.org/trunk@34940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 23:25:24 +00:00
Drew Jaynes
9cbb68a4af Embeds: Rename the $return parameter in wp_filter_oembed_result() to $result to provide better context on what is being filtered. 
See #32522.

Built from https://develop.svn.wordpress.org/trunk@34974


git-svn-id: http://core.svn.wordpress.org/trunk@34939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 23:22:24 +00:00
John Blackbourn
44da78be26 Remove HTML escaping for the plugin name and author fields that are displayed when deleting a plugin. 
While it might seem counter-intuitive to remove HTML escaping, these fields are already safe (they originate in `_get_plugin_data_markup_translate()` which handles sanitization and escaping), and the AuthorName field actually allows some HTML. This change prevents escaped HTML from appearing here.

Fixes #25422

Built from https://develop.svn.wordpress.org/trunk@34973


git-svn-id: http://core.svn.wordpress.org/trunk@34938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 23:13:24 +00:00
Drew Jaynes
2f700ddbf2 Embeds: Combine the oembed_minwidth and oembed_maxwidth filters into one, similar to how the existing oembed_defaults works for width and height. 
See #32522. See #34227.

Built from https://develop.svn.wordpress.org/trunk@34972


git-svn-id: http://core.svn.wordpress.org/trunk@34937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 23:09:23 +00:00
Drew Jaynes
60f86d2865 Docs: Add missing @since versions for the oembed_minwidth and oembed_maxwidth filters, introduced in [34903]. 
See #34227.

Built from https://develop.svn.wordpress.org/trunk@34971


git-svn-id: http://core.svn.wordpress.org/trunk@34936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 22:55:25 +00:00
Drew Jaynes
8c35f77cdb Docs: Adjust third-person singular verbs in DocBlock summaries for oEmbed functions introduced in [34903]. 
See #34227.

Built from https://develop.svn.wordpress.org/trunk@34970


git-svn-id: http://core.svn.wordpress.org/trunk@34935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 22:50:25 +00:00
Drew Jaynes
fa3b23dc0d Embeds: Fix syntax on instantiating a new WP_oEmbed_Controller instance and cross-reference in the DocBlock for wp_oembed_parse_query(). 
See #34227.

Built from https://develop.svn.wordpress.org/trunk@34969


git-svn-id: http://core.svn.wordpress.org/trunk@34934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 22:40:24 +00:00
Drew Jaynes
f21439cc64 Docs: Adjust the summary for the oembed_discovery_links hook doc to mention that the filter is for HTML output. 
See #34227.

Built from https://develop.svn.wordpress.org/trunk@34968


git-svn-id: http://core.svn.wordpress.org/trunk@34933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 22:39:24 +00:00
Drew Jaynes
e4164932dd Docs: Clarify the file header summary for wp-includes/embed-functions.php, and add missing parameter information for wp_oembed_parse_query(), introduced in [34903]. 
See #34227.

Built from https://develop.svn.wordpress.org/trunk@34967


git-svn-id: http://core.svn.wordpress.org/trunk@34932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 22:38:25 +00:00
Drew Jaynes
77314454a5 Embeds: If we're adding a boatload of new items to default-filters.php, might as well make them readable. 
See #32522.

Built from https://develop.svn.wordpress.org/trunk@34966


git-svn-id: http://core.svn.wordpress.org/trunk@34931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 22:31:24 +00:00
John Blackbourn
b62e798c17 Introduce the ability to filter the Users admin listing screen by users with no role, if such users exist. 
Fixes #22993
Props spmlucas, johnbillion

Built from https://develop.svn.wordpress.org/trunk@34965


git-svn-id: http://core.svn.wordpress.org/trunk@34930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 22:07:47 +00:00
Drew Jaynes
cc4c59a1fa Docs: Add a couple of strategically-placed spaces in WP_Rewrite. 
Fixes #34218.

Built from https://develop.svn.wordpress.org/trunk@34964


git-svn-id: http://core.svn.wordpress.org/trunk@34929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 22:07:24 +00:00
John Blackbourn
1451ebc0d1 On the Users list table, show all the roles of a user in a comma-separated list if they have more than one role. This prevents role obfuscation in situations where a user has had more than one role programmatically assigned to them. 
Fixes #22959
Props scribu, JustinSainton, DrewAPicture, johnbillion

Built from https://develop.svn.wordpress.org/trunk@34963


git-svn-id: http://core.svn.wordpress.org/trunk@34928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 21:59:25 +00:00
Drew Jaynes
aab0da2e17 Docs: Mark the optional parameters for WP_Rewrite::generate_rewrite_rules() as such, and improve overall formatting. 
Also brings in the list of acceptable constants for the `$ep_mask` parameter.

See #34218.

Built from https://develop.svn.wordpress.org/trunk@34962


git-svn-id: http://core.svn.wordpress.org/trunk@34927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 21:49:26 +00:00
Jeremy Felt
554b1425ed Make $blog_id explicitly global. 
`$blog_id` is used in both single and multisite configurations as a global variable, though has never been explicitly marked as such in the global scope. This can cause confusion depending on how core is loaded.

Fixes #34217.

Built from https://develop.svn.wordpress.org/trunk@34961


git-svn-id: http://core.svn.wordpress.org/trunk@34926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 21:45:25 +00:00
Drew Jaynes
e147ba60b0 Docs: Convert the description for the optional $args parameter in WP_Rewrite::add_permastruct() into a hash notation. 
See #34218.

Built from https://develop.svn.wordpress.org/trunk@34960


git-svn-id: http://core.svn.wordpress.org/trunk@34925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 21:35:26 +00:00
Boone Gorges
c758468faf WP_User_Query role improvement redux. 
It's back, and it's better than ever: an overhaul of role-related arguments
in `WP_User_Query`. This updated version of the previously-reverted [34875]
includes support for the use of `$blog_id` without specifying a `$role`, for
a 99.7% reduced chance of breaking wordpress.org and other large sites.

Props boonebgorges, swissspidy.
Fixes #22212.
Built from https://develop.svn.wordpress.org/trunk@34959


git-svn-id: http://core.svn.wordpress.org/trunk@34924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 21:28:24 +00:00
Drew Jaynes
9f4d5731e9 Docs: Improve more formatting and syntax for inline comments in WP_Rewrite. 
See #34218.

Built from https://develop.svn.wordpress.org/trunk@34958


git-svn-id: http://core.svn.wordpress.org/trunk@34923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 21:24:24 +00:00
Drew Jaynes
17010f97c7 Docs: Add saner formatting and make readability improvements to a variety of inline comments in WP_Rewrite and WP_Rewrite::generate_rewrite_rules(). 
See #34218.

Built from https://develop.svn.wordpress.org/trunk@34957


git-svn-id: http://core.svn.wordpress.org/trunk@34922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 21:18:25 +00:00
Boone Gorges
99421d1799 Store SQL query string as a property on WP_User_Query. 
In addition to better parity with other WP query classes, this also allows
testing of SQL strings, should anyone want to do something so foolish.

See #22212.
Built from https://develop.svn.wordpress.org/trunk@34956


git-svn-id: http://core.svn.wordpress.org/trunk@34921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 21:06:23 +00:00
Sergey Biryukov
0b13fdf2fc Docs: Fix typo in [34944]. 
See #34218.
Built from https://develop.svn.wordpress.org/trunk@34955


git-svn-id: http://core.svn.wordpress.org/trunk@34920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 21:00:26 +00:00
Scott Taylor
dae5923c1d After [34953], unbreak WordPress. 
See [34930], #33982.

Built from https://develop.svn.wordpress.org/trunk@34954


git-svn-id: http://core.svn.wordpress.org/trunk@34919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 19:29:25 +00:00
Scott Taylor
c756465146 HTTP/REST API: move WP_HTTP_Response to wp-includes/ with the rest (ha!) of the HTTP classes. This is PHP 5.2, so this class is global, and as per @rmccue, unrelated to REST specifically. 
See [34930], #33982.

Built from https://develop.svn.wordpress.org/trunk@34953


git-svn-id: http://core.svn.wordpress.org/trunk@34918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 19:27:28 +00:00
Drew Jaynes
a07cd8b386 Docs: Normalize documentation spacing in the DocBlocks for add_meta_box() and remove_meta_box() following [34951]. 
Fixes #15000.

Built from https://develop.svn.wordpress.org/trunk@34952


git-svn-id: http://core.svn.wordpress.org/trunk@34917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 19:13:24 +00:00
Drew Jaynes
6e4268e6fa Administration: Add the ability to pass an array of screen IDs to add_meta_box() and remove_meta_box(). 
The `$screen` parameter in both functions can now accept a single screen ID, `WP_Screen` object, or an array of screen IDs.

Adds tests.

Props coffee2code, iamfriendly, madalinungureanu, mordauk, igmoweb, meloniq, DrewAPicture.
See #15000.

Built from https://develop.svn.wordpress.org/trunk@34951


git-svn-id: http://core.svn.wordpress.org/trunk@34916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 19:07:24 +00:00
Konstantin Obenland
b5be742e1f Template: Add fallback for empty containers. 
Since [14031] the container can be omitted in `wp_nav_menu()`. It can not
however in `wp_page_menu()`, which creates a conflict if it is set as
the fallback, Let's make sure there is always a valid container tag.

Fixes #33974.


Built from https://develop.svn.wordpress.org/trunk@34950


git-svn-id: http://core.svn.wordpress.org/trunk@34915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 18:27:25 +00:00
Sergey Biryukov
45bda3af69 REST API: Add some missing documentation. 
Props swissspidy.
Fixes #34215.
Built from https://develop.svn.wordpress.org/trunk@34949


git-svn-id: http://core.svn.wordpress.org/trunk@34914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 18:01:25 +00:00
Helen Hou-Sandí
5b40bd827c Buttons: Update styles and colors. 
* Aligns with the color standards. See https://make.wordpress.org/design/handbook/foundations/colors/
* Creates a consistent interaction experience between states.
* Improves contrast and accessibility.

props hugobaeta, afercia, melchoyce, michael-arestad.
fixes #31459.

Built from https://develop.svn.wordpress.org/trunk@34948


git-svn-id: http://core.svn.wordpress.org/trunk@34913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 17:31:24 +00:00
Boone Gorges
48493cdf3a Allow a null id to do a name lookup in wp_set_current_user(). 
Previously, the `name` fallback was failing in the case where the current user
was 0, due to a loose comparison between 0 (the current user) and `null` (the
value that is used to trigger the `name` fallback).

Props bobbingwide.
Fixes #20845.
Built from https://develop.svn.wordpress.org/trunk@34947


git-svn-id: http://core.svn.wordpress.org/trunk@34912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 17:29:24 +00:00
John Blackbourn
db4f4c5538 Improve the parameter names and inline documentation for add_rewrite_rule(), WP_Rewrite::add_rule(), and WP_Rewrite::add_external_rule(). 
Fixes #34197

Built from https://develop.svn.wordpress.org/trunk@34946


git-svn-id: http://core.svn.wordpress.org/trunk@34911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 17:28:25 +00:00
Boone Gorges
77ae65acdb Add tests for current behavior of wp_set_current_user(). 
See #20845.
Built from https://develop.svn.wordpress.org/trunk@34945


git-svn-id: http://core.svn.wordpress.org/trunk@34910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 17:19:24 +00:00
Drew Jaynes
305ae14461 Docs: Fix third-person singular verbs in DocBlock summaries throughout WP_Rewrite. 
See #34218.

Built from https://develop.svn.wordpress.org/trunk@34944


git-svn-id: http://core.svn.wordpress.org/trunk@34909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 17:12:24 +00:00
Sergey Biryukov
639371de09 Add wp_load_translations_early() to wpdb::check_connection(). 
Fixes #29306. See #34216.
Built from https://develop.svn.wordpress.org/trunk@34943


git-svn-id: http://core.svn.wordpress.org/trunk@34908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 17:11:24 +00:00
Sergey Biryukov
50e6ef8bd7 Split database error messages into separate strings to remove unnecessary HTML tags from translations. 
Add translator comments for placeholders.

Fixes #34216.
Built from https://develop.svn.wordpress.org/trunk@34942


git-svn-id: http://core.svn.wordpress.org/trunk@34907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 16:52:24 +00:00
Drew Jaynes
d2dee54669 Docs: Relocate some more DocBlock-level @see tags and add some missing @access tags in WP_Rewrite. 
See #34218.

Built from https://develop.svn.wordpress.org/trunk@34941


git-svn-id: http://core.svn.wordpress.org/trunk@34906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 16:51:24 +00:00
Drew Jaynes
1e6f1c9a9b Docs: Relocate some DocBlock-level @see tags in WP_Rewrite. 
See #34218.

Built from https://develop.svn.wordpress.org/trunk@34940


git-svn-id: http://core.svn.wordpress.org/trunk@34905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 16:49:24 +00:00
Drew Jaynes
02645d5711 Docs: Remove invalid inline @link tags from a variety of DocBlocks in WP_Rewrite. 
See #34218.

Built from https://develop.svn.wordpress.org/trunk@34939


git-svn-id: http://core.svn.wordpress.org/trunk@34904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 16:47:25 +00:00
Drew Jaynes
d1fd329ea2 Docs: Add a file header to wp-includes/class-wp-rewrite.php. 
See #34218.

Built from https://develop.svn.wordpress.org/trunk@34938


git-svn-id: http://core.svn.wordpress.org/trunk@34903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 16:41:26 +00:00
Dominik Schilling
c50acdcb4c Embeds: Update $wp_db_version to flush rewrite rules for [34903]. 
Fixes #34209.
Built from https://develop.svn.wordpress.org/trunk@34937


git-svn-id: http://core.svn.wordpress.org/trunk@34902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 11:12:28 +00:00
Dominik Schilling
f8c467e07a Term Meta: Prevent a "Multiple primary key defined" error during database upgrades. 
You must have two spaces between the words `PRIMARY KEY` and the definition of your primary key. Yes, seriously.

See [34529].
Fixes #34210.
Built from https://develop.svn.wordpress.org/trunk@34936


git-svn-id: http://core.svn.wordpress.org/trunk@34901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 11:09:26 +00:00
Gary Pendergast
24128dfc90 Posts: Add the pre_get_lastpostmodified filter to get_lastpostmodified(). 
This allows `get_lastpostmodified()` to be short circuited when the site wants to avoid running the occasionally slow queries in `_get_last_post_time()`.

Fixes #34205.


Built from https://develop.svn.wordpress.org/trunk@34935


git-svn-id: http://core.svn.wordpress.org/trunk@34900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 05:57:25 +00:00
Boone Gorges
c2a0d593ac Allow excluded keywords when searching posts. 
Pass a keyword with a leading hyphen to exclude posts containing that keyword.
For example, 'taco -onions' will return posts that contain the word 'taco' but
do not contain the word 'onions'.

Props akibjorklund.
Fixes #33988.
Built from https://develop.svn.wordpress.org/trunk@34934


git-svn-id: http://core.svn.wordpress.org/trunk@34899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 03:18:24 +00:00
John Blackbourn
7b230cafab Abstract the shortcode attribute parsing regex into its own function, update the JavaScript counterpart, and introduce a test to ensure they do not diverge again. 
Fixes #34191
Props miqrogroove, johnbillion

Built from https://develop.svn.wordpress.org/trunk@34933


git-svn-id: http://core.svn.wordpress.org/trunk@34898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 03:12:24 +00:00
John Blackbourn
d2416ca93a Correctly set the secure flag on the post password cookie based on the scheme of the referring URL, if it's available, instead of the home URL. 
Fixes #29641

Built from https://develop.svn.wordpress.org/trunk@34932


git-svn-id: http://core.svn.wordpress.org/trunk@34897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 03:09:24 +00:00
John Blackbourn
95045d629b Correctly set the secure flag for the test cookie based on the login URL scheme, and the same for the user settings cookies based on the admin URL scheme. 
Fixes #34159

Built from https://develop.svn.wordpress.org/trunk@34931


git-svn-id: http://core.svn.wordpress.org/trunk@34896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 03:05:25 +00:00
Ryan McCue
a998ea45e2 REST API: Add missing reference to WP_HTTP_Response 
See #33982

Built from https://develop.svn.wordpress.org/trunk@34930


git-svn-id: http://core.svn.wordpress.org/trunk@34895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 02:40:24 +00:00
Ryan McCue
a70d18a10d REST API: Unbreak everything. 
Obviously, it wouldn't have been a good commit unless I botched it.

See #33982.

Built from https://develop.svn.wordpress.org/trunk@34929


git-svn-id: http://core.svn.wordpress.org/trunk@34894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 02:34:24 +00:00
Ryan McCue
94e2352956 REST API: Introduce baby API to the world. 
Baby API was born at 2.8KLOC on October 8th at 2:30 UTC. API has lots
of growing to do, so wish it the best of luck.

Thanks to everyone who helped along the way:

Props rmccue, rachelbaker, danielbachhuber, joehoyle, drewapicture,
adamsilverstein, netweb, tlovett1, shelob9, kadamwhite, pento,
westonruter, nikv, tobych, redsweater, alecuf, pollyplummer, hurtige,
bpetty, oso96_2000, ericlewis, wonderboymusic, joshkadis, mordauk,
jdgrimes, johnbillion, jeremyfelt, thiago-negri, jdolan, pkevan,
iseulde, thenbrent, maxcutler, kwight, markoheijnen, phh, natewr,
jjeaton, shprink, mattheu, quasel, jmusal, codebykat, hubdotcom,
tapsboy, QWp6t, pushred, jaredcobb, justinsainton, japh, matrixik,
jorbin, frozzare, codfish, michael-arestad, kellbot, ironpaperweight,
simonlampen, alisspers, eliorivero, davidbhayes, JohnDittmar, dimadin,
traversal, cmmarslender, Toddses, kokarn, welcher, and ericpedia.

Fixes #33982.

Built from https://develop.svn.wordpress.org/trunk@34928


git-svn-id: http://core.svn.wordpress.org/trunk@34893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-08 02:31:25 +00:00