Commit Graph

26696 Commits

Author SHA1 Message Date
Drew Jaynes
61b8ba8461 Convert documentation for default arguments in WP_Http::request() to a hash notation.
Also update corresponding docs for functions that leverage its arguments.

See #28298.

Built from https://develop.svn.wordpress.org/trunk@29230


git-svn-id: http://core.svn.wordpress.org/trunk@29014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-18 22:01:15 +00:00
Drew Jaynes
f35e168f39 Fix syntax for single- and multi-line comments in wp-includes/class-http.php.
See #28943 and #28931.

Built from https://develop.svn.wordpress.org/trunk@29229


git-svn-id: http://core.svn.wordpress.org/trunk@29013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-18 21:47:15 +00:00
Andrew Nacin
c11836174c 4.0-beta2.
Built from https://develop.svn.wordpress.org/trunk@29228


git-svn-id: http://core.svn.wordpress.org/trunk@29012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-18 21:05:15 +00:00
Andrew Nacin
9e33ac1bee Plugin Install screens: Pass locale and installed plugins to the API, for context.
props tellyworth.
see #17902.

Built from https://develop.svn.wordpress.org/trunk@29227


git-svn-id: http://core.svn.wordpress.org/trunk@29011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-18 20:50:15 +00:00
Andrew Nacin
860f0922b7 Add 'Details' links to installed plugins.
Installed plugins that are up to date are now returned in the update-check API response.

props tellyworth.
see #17902.

Built from https://develop.svn.wordpress.org/trunk@29226


git-svn-id: http://core.svn.wordpress.org/trunk@29010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-18 20:49:17 +00:00
Helen Hou-Sandí
4da975b68f Plugin install: display cards in groups if the API returns them with the appropriate information. props tellyworth. fixes #28673.
Built from https://develop.svn.wordpress.org/trunk@29225


git-svn-id: http://core.svn.wordpress.org/trunk@29009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-18 19:35:14 +00:00
Andrew Nacin
84fb6743fe WP_Session_Tokens: Can't abstract a static method.
Implementations can choose to implement the drop_sessions() method on their own.

see #20276.

Built from https://develop.svn.wordpress.org/trunk@29224


git-svn-id: http://core.svn.wordpress.org/trunk@29008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-18 19:16:15 +00:00
John Blackbourn
4b31a9143a Update some inline docs for the WP_Http class. Fixes #28943.
Built from https://develop.svn.wordpress.org/trunk@29223


git-svn-id: http://core.svn.wordpress.org/trunk@29007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-18 18:15:15 +00:00
Sergey Biryukov
d2e690ac2d Fix parse error in PHP 5.2.
props georgestephanis.
see #20276.
Built from https://develop.svn.wordpress.org/trunk@29222


git-svn-id: http://core.svn.wordpress.org/trunk@29006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-18 17:34:15 +00:00
Andrew Nacin
654e46f03d Tie cookies and nonces to user sessions so they may be invalidated upon logout.
Sessions are stored in usermeta via WP_User_Meta_Session_Tokens, which extends the abstract WP_Session_Tokens class. Extending WP_Session_Tokens can allow for alternative storage, such as a separate table or Redis.

Introduces some simple APIs for session listing and destruction, such as wp_get_active_sessions() and wp_destroy_all_sessions().

This invalidates all existing authentication cookies, as a new segment (the session token) has been added to them.

props duck_, nacin, mdawaffe.
see #20276.

Built from https://develop.svn.wordpress.org/trunk@29221


git-svn-id: http://core.svn.wordpress.org/trunk@29005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-18 09:13:15 +00:00
Helen Hou-Sandí
e8ade6be6e Keyboard accessibility for the media modal:
* Arrow keys navigate between items in the grid.
* Transfer focus into the panel when selecting a tab along the side.
* Transfer focus into the details sidebar when selecting an item and vice versa.
* Set initial focus on the close button so that it is visible.

props celloexpressions, lessbloat, ericlewis. fixes #25100, #25101, #28704. see #23560.

Built from https://develop.svn.wordpress.org/trunk@29220


git-svn-id: http://core.svn.wordpress.org/trunk@29004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-18 07:57:15 +00:00
Helen Hou-Sandí
a034c2076b Plugin install cards:
* Move author attribution to its own line.
* Use `esc_url()` where appropriate.
* Better i18n.
* min-height for cards for a more even appearance.
* Show more cards on wide screens.
* Tighten up spacing below the filter bar.

props ocean90, helen. see #28785.

Built from https://develop.svn.wordpress.org/trunk@29219


git-svn-id: http://core.svn.wordpress.org/trunk@29003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-18 06:08:15 +00:00
Helen Hou-Sandí
02e3a7cbe3 Install Plugins screen:
* Utilize the (currently-named) filter bar from the Add Themes screen.
* Move the upload link to the h2, also like the Add Themes screen.

see #28673.

Built from https://develop.svn.wordpress.org/trunk@29218


git-svn-id: http://core.svn.wordpress.org/trunk@29002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-18 04:50:15 +00:00
Helen Hou-Sandí
c4b561bb6c Use more generic, reusable CSS for the filter bar on Add Themes. This will allow us to reuse the UI in other places, such as the Media Library. props paulwilde. fixes #28794.
Built from https://develop.svn.wordpress.org/trunk@29217


git-svn-id: http://core.svn.wordpress.org/trunk@29001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-18 03:40:16 +00:00
Sergey Biryukov
47119960de Don't 404 for empty feeds.
fixes #18505.
Built from https://develop.svn.wordpress.org/trunk@29216


git-svn-id: http://core.svn.wordpress.org/trunk@29000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 22:22:15 +00:00
Sergey Biryukov
be718ee860 Declare the variable before using it.
props danielbachhuber.
fixes #28932.
Built from https://develop.svn.wordpress.org/trunk@29215


git-svn-id: http://core.svn.wordpress.org/trunk@28999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 22:01:14 +00:00
Andrew Ozz
5c5c73b50e TinyMCE: add the 'colorpicker' and 'lists' plugins, fixes #28939, #27359.
Built from https://develop.svn.wordpress.org/trunk@29214


git-svn-id: http://core.svn.wordpress.org/trunk@28998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 21:54:14 +00:00
Helen Hou-Sandí
5267c64e5f Fix jshint errors introduced in [29212]. see #28842.
Built from https://develop.svn.wordpress.org/trunk@29213


git-svn-id: http://core.svn.wordpress.org/trunk@28997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 20:46:14 +00:00
Helen Hou-Sandí
06f5b5a490 Media Grid:
Instead of a separate bulk selection mode, persistently show a checkbox for each item. Restores the more familiar bulk actions dropdown + action button.

props ericlewis. see #28842.


Built from https://develop.svn.wordpress.org/trunk@29212


git-svn-id: http://core.svn.wordpress.org/trunk@28996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 20:42:15 +00:00
Andrew Ozz
4361a40427 TinyMCE: include 709266e308 that fixes the UI state updates for the "link" button. See #28576.
Built from https://develop.svn.wordpress.org/trunk@29211


git-svn-id: http://core.svn.wordpress.org/trunk@28995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 19:31:14 +00:00
Sergey Biryukov
b7c94cee0b Twenty Fourteen: Remove unused variable after [27120].
props michalzuber.
fixes #28928.
Built from https://develop.svn.wordpress.org/trunk@29210


git-svn-id: http://core.svn.wordpress.org/trunk@28994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 19:09:14 +00:00
Scott Taylor
fa02568c42 Merge wp_handle_upload() and wp_handle_sideload() by making them each wrap a new function: _wp_handle_upload().
Props DrewAPicture for docs.
Fixes #23686.

Built from https://develop.svn.wordpress.org/trunk@29209


git-svn-id: http://core.svn.wordpress.org/trunk@28993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 18:58:44 +00:00
Scott Taylor
87e14a7ecc After [29106], check for data.meta before attempting to render data.meta.bitrate.
See #28839.

Built from https://develop.svn.wordpress.org/trunk@29208


git-svn-id: http://core.svn.wordpress.org/trunk@28992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 17:42:16 +00:00
Scott Taylor
3ca4223a00 After [29197], use ! empty() instead of isset(). Don't call has_shortcode() internally twice if it's true.
Props kovshenin.
Fixes #26343.

Built from https://develop.svn.wordpress.org/trunk@29207


git-svn-id: http://core.svn.wordpress.org/trunk@28991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 17:38:13 +00:00
Drew Jaynes
097dc8ee15 Fix syntax for single- and multi-line comments in wp-admin-directory files.
See #28931.

Built from https://develop.svn.wordpress.org/trunk@29206


git-svn-id: http://core.svn.wordpress.org/trunk@28990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 09:14:16 +00:00
Drew Jaynes
e731028303 Fix syntax for single- and multi-line comments in root-directory files.
See #28931.

Built from https://develop.svn.wordpress.org/trunk@29205


git-svn-id: http://core.svn.wordpress.org/trunk@28989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 09:12:16 +00:00
Helen Hou-Sandí
b7445ec8a4 Media Grid Attachment Details modal UI improvements:
* Align better visually with the existing media modal and the post image edit modal.
* Add back a link to the full attachment edit screen (post.php).
* Add a title to the modal and move prev/next buttons next to the more-consistent close button.
* Remove mode tabs (metadata vs. image editing) in favor of the Edit Image button.

Still to come: responsive, IE8 testing and targeted CSS (calc() usage), general CSS cleanup.

props ericlewis, helen, melchoyce. see #28844. fixes #28915.

Built from https://develop.svn.wordpress.org/trunk@29204


git-svn-id: http://core.svn.wordpress.org/trunk@28988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 03:55:15 +00:00
Andrew Ozz
95735cf298 TinyMCE:
- Update to 4.1.2, changelog: https://github.com/tinymce/tinymce/blob/master/changelog.txt
- Update the tests to 4.1.2.
Fixes #28576.
Built from https://develop.svn.wordpress.org/trunk@29203


git-svn-id: http://core.svn.wordpress.org/trunk@28987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 00:59:16 +00:00
Andrew Ozz
d74a2a9f07 TinyMCE wpView: prevent fatal (security) errors when trying to access iframe.contentWindow in pausePlayers() and unsetPlayers(). See #28905.
Built from https://develop.svn.wordpress.org/trunk@29202


git-svn-id: http://core.svn.wordpress.org/trunk@28986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 00:50:15 +00:00
Scott Taylor
d395142fb9 In Plugin Install List Table, remove title attribute for plugin action links; add screen-reader-text.
Props joedolson.
Fixes #28853.

Built from https://develop.svn.wordpress.org/trunk@29201


git-svn-id: http://core.svn.wordpress.org/trunk@28985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 22:50:14 +00:00
Scott Taylor
8496504f59 Properly set $subdomain_error to false when applicable in ms_subdomain_constants(). This was previously untestable because it used static vars: use globals instead.
Adds unit test.
Fixes #28697.

Built from https://develop.svn.wordpress.org/trunk@29200


git-svn-id: http://core.svn.wordpress.org/trunk@28984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 22:35:14 +00:00
Drew Jaynes
9ae01ba532 Fix a typo in the @access tag for WP_List_Table::__get().
Props joehoyle.
Fixes #28925. See #28885.

Built from https://develop.svn.wordpress.org/trunk@29199


git-svn-id: http://core.svn.wordpress.org/trunk@28983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 22:13:14 +00:00
Scott Taylor
c2a7544cd6 Make sure that the ready event only fires once for relevant MCE views that are sandbox'd in iframes. Move some editor callbacks to initialize.
Props avryl.
See #28905.

Built from https://develop.svn.wordpress.org/trunk@29198


git-svn-id: http://core.svn.wordpress.org/trunk@28982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 22:10:16 +00:00
Scott Taylor
1292ee0151 Make has_shortcode() recursive/work for nested shortcodes.
Adds unit test.

Props katzwebdesign.
Fixes #26343.

Built from https://develop.svn.wordpress.org/trunk@29197


git-svn-id: http://core.svn.wordpress.org/trunk@28981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 22:05:17 +00:00
Scott Taylor
cf3deb2ecb Avoid a race condition when multiple windows are open so that orphaned terms cannot be created by accident.
Adds a unit test.

Props dlh.
Fixes #19205.

Built from https://develop.svn.wordpress.org/trunk@29196


git-svn-id: http://core.svn.wordpress.org/trunk@28980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 21:52:15 +00:00
Andrew Ozz
1637f1617f TinyMCE: fix aligncenter for html5-captions, props obenland, fixes #28681.
Built from https://develop.svn.wordpress.org/trunk@29195


git-svn-id: http://core.svn.wordpress.org/trunk@28979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 21:28:16 +00:00
Scott Taylor
e75d42daff Cleanup after [29179]:
* Remove `wp.media.mixin.pauseAllPlayers()` - was only ever intended to be used in MCE views, reaches too far into global scope. Rendered irrelevant since [28364].
* Remove `wp.media.mixin.pausePlayers()` - added in [28364]. MCE views no longer keep track of player instances and call mixin methods, they refer to their child iframes and call MEjs methods on the iframe's `window.mejs.players`. 

See #28905.

Built from https://develop.svn.wordpress.org/trunk@29194


git-svn-id: http://core.svn.wordpress.org/trunk@28978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 19:36:14 +00:00
Scott Taylor
69986d87a7 Cleanup after [29179]:
Don't attach nodes to the view instance and check if the iframe still exists before resizing.

Props avryl.
See #28905.

Built from https://develop.svn.wordpress.org/trunk@29193


git-svn-id: http://core.svn.wordpress.org/trunk@28977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 19:32:16 +00:00
Andrew Ozz
100e5ca40b Autosave: always expose the wp.autosave.local methods, fixes #28924.
Built from https://develop.svn.wordpress.org/trunk@29192


git-svn-id: http://core.svn.wordpress.org/trunk@28976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 18:34:16 +00:00
Scott Taylor
cd497224a3 Cleanup after [29179]:
* Pause players when media is edited via modal
* Remove players on unind
* Account for failure when an empty node is passed to an `mce.view.View`

See #28905.

Built from https://develop.svn.wordpress.org/trunk@29191


git-svn-id: http://core.svn.wordpress.org/trunk@28975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 18:19:14 +00:00
Andrew Ozz
7f7c3fb54f TinyMCE wpView: add noop() when returning early, fixes #28921
Built from https://develop.svn.wordpress.org/trunk@29190


git-svn-id: http://core.svn.wordpress.org/trunk@28974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 17:55:16 +00:00
Scott Taylor
75d3fe3e65 Cleanup after [29179]:
* Cleanup players when the editor is hidden - window scope is unique to each frame
* Add the editor body class to each iframe sandbox
* Remove unneeded code from `wp-mediaelement.js`

See #28905.

Built from https://develop.svn.wordpress.org/trunk@29189


git-svn-id: http://core.svn.wordpress.org/trunk@28973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 16:14:14 +00:00
Andrew Nacin
4bf7cdd49b DB schema change: Add comment_author_email(10) index.
props tellyworth, pento.
fixes #21435.

Built from https://develop.svn.wordpress.org/trunk@29188


git-svn-id: http://core.svn.wordpress.org/trunk@28972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 15:54:16 +00:00
Scott Taylor
57e966100f Cleanup after [29179]:
* `_WP_Editors::editor_settings()` no longer needs to load MEjs styles
* Make sure each identical shortcode with multiple instances also has an iframe sandbox for each instance
* For the time being, make audio and video shortcodes bypass the loading placeholder to avoid whiplash visually

Props avryl, wonderboymusic.
See #28905.

Built from https://develop.svn.wordpress.org/trunk@29187


git-svn-id: http://core.svn.wordpress.org/trunk@28971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 15:40:14 +00:00
Andrew Ozz
a97559bf57 Editor scrolling: better "scroll into view" in the visual editor. Don't override MCE path focus style. Props avryl, see #28328.
Built from https://develop.svn.wordpress.org/trunk@29186


git-svn-id: http://core.svn.wordpress.org/trunk@28970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 04:06:16 +00:00
Andrew Ozz
e400129cd8 Editor scrolling: on setcontent, resize the editor after some delay to allow the browser to render the content. Props avryl, see #28328.
Built from https://develop.svn.wordpress.org/trunk@29185


git-svn-id: http://core.svn.wordpress.org/trunk@28969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 02:30:15 +00:00
Andrew Ozz
5bef617d04 TinyMCE wpView: handle execCommand when the "fake caret" P is selected, props avryl, see #28595
Built from https://develop.svn.wordpress.org/trunk@29184


git-svn-id: http://core.svn.wordpress.org/trunk@28968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 02:19:15 +00:00
Andrew Ozz
c6afe2dd3e TinyMCE wpView:
- Cast off commands targeted to a view except undo, redo, RemoveFormat and mceToggleFormat (bold, italic, etc.).
- Disable the link and unlink buttons when a view is selected.
Props avryl, see #28595
Built from https://develop.svn.wordpress.org/trunk@29183


git-svn-id: http://core.svn.wordpress.org/trunk@28967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 00:10:17 +00:00
Andrew Ozz
5f54195855 TinyMCE wpView: remove unused code, props avryl, see #28595
Built from https://develop.svn.wordpress.org/trunk@29182


git-svn-id: http://core.svn.wordpress.org/trunk@28966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-15 23:39:15 +00:00
Lance Willett
f2adf04025 Twenty Thirteen: make small-screen menu accessible to keyboard commands and voice-driven software by using a focusable button element rather than h3 for the toggle element. Fixes #28293, props rclations and obenland.
Built from https://develop.svn.wordpress.org/trunk@29181


git-svn-id: http://core.svn.wordpress.org/trunk@28965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-15 23:10:15 +00:00