Commit Graph

30968 Commits

Author SHA1 Message Date
gziolo
f6f8094b1d Editor: Fix typo in image default size setting
Related change in Gutneberg: https://github.com/WordPress/gutenberg/pull/31324

Props mamaduka.
See #52920.


Built from https://develop.svn.wordpress.org/trunk@50798


git-svn-id: http://core.svn.wordpress.org/trunk@50407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-29 10:12:05 +00:00
davidbaumwald
589e89231a Coding Standards: Update $out in WP_Widget_Pages with a more meaningful name.
Rename an `$out` variable to `$output` for consistency with other widget classes..

Props mukesh27.
Fixes #53059.
Built from https://develop.svn.wordpress.org/trunk@50797


git-svn-id: http://core.svn.wordpress.org/trunk@50406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-28 20:55:03 +00:00
desrosj
4a73e53df4 Build/Test Tools: Correctly test grunt clean when built to run from src.
Because the `--` separator was missing, the `--dev` flag was not being passed to the script, thus not testing properly.

See #52625.
Built from https://develop.svn.wordpress.org/trunk@50796


git-svn-id: http://core.svn.wordpress.org/trunk@50405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-28 19:07:06 +00:00
Sergey Biryukov
754714ba43 Coding Standards: Fix a precision alignment issue in wp-admin/includes/template.php.
Follow-up to [49223].

See #52627.
Built from https://develop.svn.wordpress.org/trunk@50795


git-svn-id: http://core.svn.wordpress.org/trunk@50404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-28 18:55:05 +00:00
youknowriad
4f7ace4f9c Block Editor: Update the bundled block patterns.
This updates the block patterns included by default on WordPress
to give them more personality and to make use of the design tools
that has been added to the editor.

Props onemaggie, melchoyce, kjellr, beafialho, gziolo.
Fixes #52846.

Built from https://develop.svn.wordpress.org/trunk@50794


git-svn-id: http://core.svn.wordpress.org/trunk@50403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-28 10:38:05 +00:00
Sergey Biryukov
8cd601c8ba REST API: Check the results of get_metadata() in WP_REST_Meta_Fields methods.
This avoids PHP warnings in case the function returns boolean `false` instead of an array.

Props david.binda.
Fixes #53099.
Built from https://develop.svn.wordpress.org/trunk@50793


git-svn-id: http://core.svn.wordpress.org/trunk@50402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-27 18:36:04 +00:00
Sergey Biryukov
cbfa060298 Docs: Document the usage of $current_user global in get_user_by().
Follow-up to [50790].

Props paaggeli, mukesh27.
Fixes #53088.
Built from https://develop.svn.wordpress.org/trunk@50792


git-svn-id: http://core.svn.wordpress.org/trunk@50401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-27 17:49:06 +00:00
Sergey Biryukov
b2117d7299 Posts, Post Types: Pass the post object to the_password_form filter.
Props silb3r.
Fixes #29008.
Built from https://develop.svn.wordpress.org/trunk@50791


git-svn-id: http://core.svn.wordpress.org/trunk@50400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-26 15:38:05 +00:00
Peter Wilson
de519f9dfe Users: Share current user instance across functions.
Share the `WP_User` instance for the current user between the functions `get_userdata()` and `wp_get_current_user()`. Both functions return the `$current_user` global for the current user.

Force refresh the `$current_user` global within `clean_user_cache()` by immediately re-calling `wp_set_current_user()` with the current user's ID. This ensures any changes to the current user's permissions or other settings are reflected in the global. As a side-effect this immediately rewarms the current user's cache.

Props chaion07, chriscct7, donmhico, hellofromtonya, lukecarbis, peterwilsoncc, rmccue, TimothyBlynJacobs.
Fixes #28020.

Built from https://develop.svn.wordpress.org/trunk@50790


git-svn-id: http://core.svn.wordpress.org/trunk@50399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-26 01:03:59 +00:00
Peter Wilson
868ad5a313 Build/Tests tools: Improve get_bookmark() test coverage.
Props hellofromtonya, peterwilsoncc.
See #52988.

Built from https://develop.svn.wordpress.org/trunk@50789


git-svn-id: http://core.svn.wordpress.org/trunk@50398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-26 01:00:05 +00:00
Sergey Biryukov
1ad7538792 Plugins: When loading a plugin in a "sandbox" on activation, do it once.
This avoids a fatal error if the plugin is already included, e.g. in unit tests.

Follow-up to [50787].

See #31104.
Built from https://develop.svn.wordpress.org/trunk@50788


git-svn-id: http://core.svn.wordpress.org/trunk@50397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-25 13:21:05 +00:00
Sergey Biryukov
fe549286d5 Plugins: When loading a plugin in a "sandbox" on activation, do it in a separate function.
This avoids accidentally overriding some variables in the scope of `activate_plugin()`, e.g. `$silent` or `$network_wide`.

Plugins expecting to have access to `$network_wide` directly on inclusion should receive it as an argument of the activation hook callback instead, on any of these actions:

* `activate_plugin`
* `activate_{$plugin}`
* `activated_plugin`

Follow-up to [28644].

Props Mike_Cowobo, dd32, DrewAPicture, mensmaximus, SergeyBiryukov.
Fixes #31104.
Built from https://develop.svn.wordpress.org/trunk@50787


git-svn-id: http://core.svn.wordpress.org/trunk@50396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-24 18:04:04 +00:00
Aaron Jorbin
926cd0afee Bootstrap/Load: Add Function for reliable timing data
Adds timer_float which can be used to get the time elapsed so far during the PHP script. Should make it easier to display the page generation time in the footer of admin.

WordPress should expose timing data as a float in the most accurate manner possible. timer_stop() has two problems: it uses an initial timestamp generated later than it needs to be and its formatted return value can not reliably be used as a number (some locales swap commas and periods, for example).

Props andy, matt, jorbin.
Fixes #39163.


Built from https://develop.svn.wordpress.org/trunk@50786


git-svn-id: http://core.svn.wordpress.org/trunk@50395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-23 19:49:05 +00:00
Sergey Biryukov
75d7c7e8d9 Coding Standards: Use strict comparison in wp-admin/includes/update-core.php.
Includes minor code layout fixes for better readability.

See #52627.
Built from https://develop.svn.wordpress.org/trunk@50785


git-svn-id: http://core.svn.wordpress.org/trunk@50394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-23 14:51:05 +00:00
desrosj
64b4c21c1f Build/Test Tools: Remove Internet Explorer 11 from the browserslist.
This officially removes support for Internet Explorer 11 in the CSS files run through the build process in Core.

Individual tickets should be opened for removing each manually maintained area of the code base targeting IE11.

The resulting changes to CSS files are included in this commit.

Fixes #53077.
Built from https://develop.svn.wordpress.org/trunk@50784


git-svn-id: http://core.svn.wordpress.org/trunk@50393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-22 22:58:05 +00:00
Sergey Biryukov
8ef335a566 Coding Standards: Remove loose comparison in wp-admin/includes/plugin-install.php.
This more closely represents how the active installations count is displayed in the Plugin Directory.

See #52627.
Built from https://develop.svn.wordpress.org/trunk@50783


git-svn-id: http://core.svn.wordpress.org/trunk@50392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-22 19:18:05 +00:00
desrosj
2d7eb07747 Build/Test Tools: Update the caniuse-lite database.
This updates the `caniuse-lite` database to the most recent version (`1.0.30001214`) by running `npx browserslist@latest --update-db`.

The resulting changes after running `grunt precommit:css` are also included in this commit.

See #52624.
Built from https://develop.svn.wordpress.org/trunk@50782


git-svn-id: http://core.svn.wordpress.org/trunk@50391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-22 00:56:05 +00:00
Sergey Biryukov
aa3d0715ab Docs: Add a @since note to wp_mail() about using is_email() for validation.
Follow-up to [48645].

See #52628.
Built from https://develop.svn.wordpress.org/trunk@50781


git-svn-id: http://core.svn.wordpress.org/trunk@50390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-21 19:47:01 +00:00
Sergey Biryukov
784b1fb1b1 Coding Standards: Use strict comparison in wp-admin/includes/class-wp-terms-list-table.php.
Includes minor code layout fixes for better readability.

See #52627.
Built from https://develop.svn.wordpress.org/trunk@50780


git-svn-id: http://core.svn.wordpress.org/trunk@50389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-21 18:53:00 +00:00
davidbaumwald
5500f370fd Coding Standards: Fix minor, inline spacing issue in wp-admin/setup-config.php.
See #52627.



Built from https://develop.svn.wordpress.org/trunk@50779


git-svn-id: http://core.svn.wordpress.org/trunk@50388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-21 18:31:07 +00:00
davidbaumwald
e0d4745393 External Libraries: Update Underscore to version 1.13.1.
A full set of changes can be found on GitHub: https://github.com/jashkenas/underscore/compare/1.12.1...1.13.1.

Follow-up to [50650].

Props hareesh-pillai.
See #45785.
Built from https://develop.svn.wordpress.org/trunk@50778


git-svn-id: http://core.svn.wordpress.org/trunk@50387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-21 17:55:19 +00:00
gziolo
267f9d7479 Editor: Shape block editor filters to work better with the Gutenberg plugin
This should allow to use new filters in the Gutenberg plugin and therefore it prevents deprecation warnings when in the debug mode.

See #52920.


Built from https://develop.svn.wordpress.org/trunk@50777


git-svn-id: http://core.svn.wordpress.org/trunk@50386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-21 09:32:06 +00:00
gziolo
f4f125b869 Editor: Abstract block editor configuration
There are several WordPress hooks defined on the server that depend on $post object that isn’t present on the new screens like edit site, edit widgets, or edit navigation. This patch deprecates existing filters and introduces replacements that are context-aware.

Props azaozz, andraganescu, jeremyfelt, nosolosw, youknowriad.
See #52920.




Built from https://develop.svn.wordpress.org/trunk@50776


git-svn-id: http://core.svn.wordpress.org/trunk@50385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-21 05:12:05 +00:00
Peter Wilson
6ce6abd8c0 Upgrade/Install: Prevent possible type errors during installation.
Prevent a `TypeError` from occurring during installation if `wp-config.php` is not writable. In PHP 8.0 this can cause a fatal error, in earlier versions of PHP a warning would be thrown.

Account for a change in type returned by `fopen()` coming in a future version of PHP. Minor coding standards fixes in the `/wp-admin/setup-config.php` file.

Props xknown, hellofromTonya, jrf, peterwilsoncc.
See #51423.


Built from https://develop.svn.wordpress.org/trunk@50775


git-svn-id: http://core.svn.wordpress.org/trunk@50384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-21 01:33:03 +00:00
desrosj
0a27442af5 Build/Test Tools: Update several dependencies.
This updates the following dependencies:

- `cssnano` from version `4.1.10` to `4.1.11`.
- `grunt-webpack` from `4.0.2` to `4.0.3`.
- `qunit` from `12.14.1` to `12.15.0`.
- `sass` from `1.32.8` to `1.32.11`.
- `uglify-js` from `3.13.3` to `3.13.4`.

See #52624.
Built from https://develop.svn.wordpress.org/trunk@50774


git-svn-id: http://core.svn.wordpress.org/trunk@50383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-20 20:02:47 +00:00
desrosj
9d2315b409 External Libraries: Update Moment.js to the latest version.
This updates the `moment` script from version `2.27.0` to `2.29.1`.

Props shital-patel, hareesh-pillai.
Fixes #52853.
Built from https://develop.svn.wordpress.org/trunk@50773


git-svn-id: http://core.svn.wordpress.org/trunk@50382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-20 19:15:21 +00:00
Sergey Biryukov
253e1e0413 Code Modernization: Bring consistency to preparing some fields on Network Settings screen:
* `illegal_names`
* `limited_email_domains`
* `banned_email_domains`

If any of these options have a falsey value, treat it as an empty string. This addresses a PHP 8.1+ deprecation notice when passing a `null` value to `str_replace()`.

Additionally, avoid unnecessary type casting for better performance.

Props hellofromTonya, jrf, SergeyBiryukov.
See #51423.
Built from https://develop.svn.wordpress.org/trunk@50772


git-svn-id: http://core.svn.wordpress.org/trunk@50381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-20 14:49:08 +00:00
Peter Wilson
02894474ba Build/Test Tools: Add seeking support to stream test library.
Introduces seeking to the `WP_Test_Stream` stream wrapper. This allows the testing of `wp_getimagesize()` and `wp_read_image_metadata()` among others. Includes tests for the latter.

Props hellofromTonya.
Fixes #52922.
See #52826.

Built from https://develop.svn.wordpress.org/trunk@50771


git-svn-id: http://core.svn.wordpress.org/trunk@50380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-20 03:03:07 +00:00
Sergey Biryukov
596b9ed6ce Coding Standards: Use strict comparison in wp-admin/includes/class-wp-media-list-table.php.
Includes minor code layout fixes for better readability.

See #52627.
Built from https://develop.svn.wordpress.org/trunk@50770


git-svn-id: http://core.svn.wordpress.org/trunk@50379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-19 11:41:07 +00:00
Sergey Biryukov
0cbb526928 Docs: Correct comment format in wp-admin/edit-tags.php, remove extra space.
Props immeet94.
Fixes #46428.
Built from https://develop.svn.wordpress.org/trunk@50769


git-svn-id: http://core.svn.wordpress.org/trunk@50378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-18 14:29:03 +00:00
Sergey Biryukov
81ad8ccdf6 Coding Standards: Fix WPCS issues in wp-admin/includes/class-wp-comments-list-table.php.
* Rename method argument in `WP_Comments_List_Table::floated_admin_avatar()` per the naming conventions.
* Use strict comparison in `WP_Comments_List_Table::handle_row_actions()`.

See #52627.
Built from https://develop.svn.wordpress.org/trunk@50768


git-svn-id: http://core.svn.wordpress.org/trunk@50377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-18 13:55:07 +00:00
Sergey Biryukov
ed067531ec Coding Standards: Use strict comparison in wp-admin/includes/class-walker-nav-menu-edit.php.
See #52627.
Built from https://develop.svn.wordpress.org/trunk@50767


git-svn-id: http://core.svn.wordpress.org/trunk@50376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-17 12:22:03 +00:00
Clorith
f7536fd387 Site Health: Remove Ajax requests from dashboard widget.
The Site Health dashboard widget uses the same JavaScript file as the Site Health pages to generate its progress indicator.

This file was also set up to store the current Site Health check results if the current tab being shown isn't the debug information one, this had the side effect of the dashboard being seen as not the debug screen as well.

This now has a conditional making sure it's the status screen it self being displayed, before trying to do any Ajax requests.

Props arena.
Fixes #49814.
Built from https://develop.svn.wordpress.org/trunk@50766


git-svn-id: http://core.svn.wordpress.org/trunk@50375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-17 11:29:02 +00:00
Clorith
954842868f Site Health: Correct array key for the default tab
Use `reset` to get the label from the first tab entry as the default if no tab is defined.
This ensures even if the tab order is changed, or tabs are removed, no warnings will be thrown.

Follow-up to [50764].

See #47225.
Built from https://develop.svn.wordpress.org/trunk@50765


git-svn-id: http://core.svn.wordpress.org/trunk@50374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-17 10:55:03 +00:00
Clorith
eea98a5426 Site Health: Support custom sub-menus and pages.
Allow developers to extend the Site Health screen with their own custom navigation tabs and pages.

This implements a new filter, `site_health_navigation_tabs`, which takes an associated array of tab identifiers/slugs, and tab labels, allowing developers to add their own subpage to the Site Health interface as new tabs.

To output a custom page, or add to an existing page, the `site_health_tab_content` action is triggered whenever the `tab` query argument is present and not empty. This action includes the current tab as its argument, which a developer would match against to only output content when relevant.

Props ramiy for initial patch.
Fixes #47225.
Built from https://develop.svn.wordpress.org/trunk@50764


git-svn-id: http://core.svn.wordpress.org/trunk@50373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-17 01:14:01 +00:00
desrosj
b4fac1593d Build/Test Tools: Make adjustments to how often old branches are tested.
This adjusts the workflow responsible for testing old branches to only test old branches once per month. This more closely resembles the testing practices previously in place on TravisCI.

The latest, supported branch will continue to be tested twice per month.

This also makes adjustments so that the workflow is run whenever changes are made to it. This will help verify changes without having to wait until the next scheduled run.

Fixes #52653.
Built from https://develop.svn.wordpress.org/trunk@50763


git-svn-id: http://core.svn.wordpress.org/trunk@50372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-16 17:26:06 +00:00
Sergey Biryukov
afb02cb315 Coding Standards: Use strict comparison in wp-admin/includes/class-wp-automatic-updater.php.
Includes minor code layout fixes for better readability.

See #52627.
Built from https://develop.svn.wordpress.org/trunk@50762


git-svn-id: http://core.svn.wordpress.org/trunk@50371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-16 12:01:15 +00:00
gziolo
ad48a15387 Editor: Update WordPress packages to use with WordPress 5.8
In the response to the discussion during the Dev Chat, I'm doing a first pass to keep WordPress packages up to date in the WordPress 5.8 release cycle.

See https://github.com/WordPress/wordpress-develop/pull/1176 for more details.

Props youknowriad, aristath, andraganescu.
See #52991.


Built from https://develop.svn.wordpress.org/trunk@50761


git-svn-id: http://core.svn.wordpress.org/trunk@50370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-15 15:19:43 +00:00
gziolo
660443bbc7 Editor: Backport changes for WordPress packages added in 5.7.1
Props peterwilsoncc.
See #52912.


Built from https://develop.svn.wordpress.org/trunk@50760


git-svn-id: http://core.svn.wordpress.org/trunk@50369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-15 11:03:35 +00:00
Sergey Biryukov
ac9f1a4685 Coding Standards: Give a variable in WP_Automatic_Updater::after_core_update() a more meaningful name.
Follow-up to [25841], [25873], [25882].

See #52627.
Built from https://develop.svn.wordpress.org/trunk@50759


git-svn-id: http://core.svn.wordpress.org/trunk@50368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-15 10:31:08 +00:00
desrosj
e445660ee3 REST API: Allow authors to read their own password protected posts.
Allow authenticated users to read the contents of password protected posts if they have the `edit_post` meta capability for the post.

Props xknown, zieladam, peterwilsoncc, swissspidy, timothyblynjacobs.
Built from https://develop.svn.wordpress.org/trunk@50717


git-svn-id: http://core.svn.wordpress.org/trunk@50326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-14 23:24:04 +00:00
desrosj
ac930e0e5f External libraries: Include upstream GetID3 fix for PHP 8.
Props jrf, xknown.
Built from https://develop.svn.wordpress.org/trunk@50714


git-svn-id: http://core.svn.wordpress.org/trunk@50323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-14 23:10:04 +00:00
davidbaumwald
b7280388d6 Privacy: Ensure "Export Personal Data" does not generate invalid JSON.
Previously, when exporting personal data, if the JSON encoding of the data failed, the invalid JSON was still written to `export.json`.  This change captures the JSON encoding failure and adds a notice to the UI.  

Props hellofromTonya, jrf, SergeyBiryukov.
Fixes #52892.
Built from https://develop.svn.wordpress.org/trunk@50713


git-svn-id: http://core.svn.wordpress.org/trunk@50322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-14 21:28:08 +00:00
desrosj
294c370d72 Upgrade/Install: Correct the alignment of error messages for the language installer.
This makes the CSS selector used to right align certain form related elements more specific. This prevents any error messages from being right aligned.

Props sabernhardt, audrasjb.
Fixes #52989.
Built from https://develop.svn.wordpress.org/trunk@50712


git-svn-id: http://core.svn.wordpress.org/trunk@50321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-14 14:11:05 +00:00
Sergey Biryukov
0cd72ec474 Site Health: Correct test result status for the HTTPS test.
The supported status values for Site Health tests are `good`, `recommended`, and `critical`.

Follow-up to [50660].

Props TimothyBlynJacobs.
Fixes #52783.
Built from https://develop.svn.wordpress.org/trunk@50710


git-svn-id: http://core.svn.wordpress.org/trunk@50319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-14 13:02:08 +00:00
Peter Wilson
793da8732f Bundled Themes: Bump versions for WordPress 5.7.1.
Twenty Twenty-One: Bump version to 1.3
Twenty Seventeen: Bump version to 2.7

Props desrosj, mukesh27, peterwilsoncc.
Fixes #52859.

Built from https://develop.svn.wordpress.org/trunk@50708


git-svn-id: http://core.svn.wordpress.org/trunk@50317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-13 23:49:06 +00:00
Sergey Biryukov
a274a14bdd Coding Standards: Use strict comparison in wp-admin/includes/class-custom-image-header.php.
Includes minor code layout fixes for better readability.

See #52627.
Built from https://develop.svn.wordpress.org/trunk@50707


git-svn-id: http://core.svn.wordpress.org/trunk@50316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-13 19:05:04 +00:00
Sergey Biryukov
35de0a48fb Coding Standards: Use strict comparison in wp-admin/includes/class-custom-background.php.
Includes minor code layout fixes for better readability.

See #52627.
Built from https://develop.svn.wordpress.org/trunk@50706


git-svn-id: http://core.svn.wordpress.org/trunk@50315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-13 18:01:04 +00:00
davidbaumwald
d6a1170c70 I18N: Add context to strings when updating a plugin or theme with a ZIP package.
After [48390], plugins and themes can be updated with an uploaded ZIP file.  Strings were added for comparing the "current" and "uploaded" versions of a plugin or theme, but lacked context for each as to the object being referenced.  This change adds a `plugin` or `theme` context to each of these strings for disambiguation.

Props dimadin, SergeyBiryukov.
Fixes #53017.
Built from https://develop.svn.wordpress.org/trunk@50705


git-svn-id: http://core.svn.wordpress.org/trunk@50314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-13 17:38:05 +00:00
Dominik Schilling
2e6178bf3d Build/Test Tools: Remove an extra space in the job name for PHPUnit tests.
See #52625.
Built from https://develop.svn.wordpress.org/trunk@50704


git-svn-id: http://core.svn.wordpress.org/trunk@50313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-13 16:12:06 +00:00
gziolo
b31964a44b Blocks: Add is_default handling to server side block styles registry
Ensures that register_block_style lets developer pass `is_default` flag to mark one of the block style variations as the default one.

Props mukesh27, xavivars.
Fixes #53006.


Built from https://develop.svn.wordpress.org/trunk@50703


git-svn-id: http://core.svn.wordpress.org/trunk@50312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-13 08:04:13 +00:00
davidbaumwald
989ec57389 Feeds: Rename "Summary" to "Excerpt" in Reading Settings.
On the "Reading Settings" page, the post excerpt was referred to as a "Summary".  For consistency with the rest of Core, this change updates "summary" to "excerpt" both in the setting and the relevant help tab.

Props SergeyBiryukov, ravipatel, mukesh27.
Fixes #52987.
Built from https://develop.svn.wordpress.org/trunk@50702


git-svn-id: http://core.svn.wordpress.org/trunk@50311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-12 22:34:04 +00:00
Sergey Biryukov
8e059f3657 Coding Standards: Rewrite a fragment in request_filesystem_credentials() for clarity and to avoid repetition.
Follow-up to [8540], [8865].

See #52627.
Built from https://develop.svn.wordpress.org/trunk@50701


git-svn-id: http://core.svn.wordpress.org/trunk@50310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-12 18:34:05 +00:00
Sergey Biryukov
82042a0377 Coding Standards: Use strict comparison in wp-admin/includes/file.php.
Includes minor code layout fixes for better readability.

See #52627.
Built from https://develop.svn.wordpress.org/trunk@50700


git-svn-id: http://core.svn.wordpress.org/trunk@50309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-12 18:19:09 +00:00
Sergey Biryukov
c569c157f0 Coding Standards: Simplify the check for parent terms in export_wp().
This is more consistent with similar checks elsewhere in core.

See #52627.
Built from https://develop.svn.wordpress.org/trunk@50699


git-svn-id: http://core.svn.wordpress.org/trunk@50308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-11 13:44:13 +00:00
Dominik Schilling
f3034f1b1c Customize: Set playsinline attribute for custom header videos.
With the `playsinline` attribute the video can also autoplay on mobile browsers without asking the user to open it up fullscreen.
Also, change all video element properties to use boolean values.

Props klevyke, ocean90.
Fixes #50111.
Built from https://develop.svn.wordpress.org/trunk@50698


git-svn-id: http://core.svn.wordpress.org/trunk@50307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-10 12:40:05 +00:00
Dominik Schilling
8780574d11 Build/Test Tools: Remove remaining Travis CI references.
* Remove `travis:` tasks in Gruntfile.js.
* Remove status badge in README.md that comes from Travis CI via shields.io.
* Remove Travis CI related skipping in the `WP_UnitTestCase_Base::skipOnAutomatedBranches()` test method and related Docker environment variables.

Props johnbillion, SergeyBiryukov, ocean90.
See #52161.
Fixes #52666.
Built from https://develop.svn.wordpress.org/trunk@50697


git-svn-id: http://core.svn.wordpress.org/trunk@50306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-10 12:07:04 +00:00
Sergey Biryukov
2a7238f658 Coding Standards: Give a variable in wp-admin/themes.php a more meaningful name.
Follow-up to [20029].

See #52627.
Built from https://develop.svn.wordpress.org/trunk@50696


git-svn-id: http://core.svn.wordpress.org/trunk@50305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-10 12:01:10 +00:00
Rachel Baker
3d04a220be REST API: Move the rest_jsonp_enabled filter before setting the Content-Type header.
Fixes an issue where if JSONP was disabled the `Content-Type` HTTP header was still set to `application/javascript`.  

Props dd32, TimothyBlynJacobs.
Fixes #52691.
Built from https://develop.svn.wordpress.org/trunk@50695


git-svn-id: http://core.svn.wordpress.org/trunk@50304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-09 21:28:08 +00:00
Sergey Biryukov
68b73d3696 Themes: Remove unused code fragment from wp-admin/themes.php.
Follow-up to [25666], [26141].

Props mukesh27, rkradadiya.
Fixes #53005.
Built from https://develop.svn.wordpress.org/trunk@50694


git-svn-id: http://core.svn.wordpress.org/trunk@50303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-09 11:49:05 +00:00
Sergey Biryukov
bdacea193a Editor: Use a consistent way to retrieve post ID on Edit Post screens.
Props mukesh27, ravipatel, davidbaumwald.
Fixes #52995.
Built from https://develop.svn.wordpress.org/trunk@50693


git-svn-id: http://core.svn.wordpress.org/trunk@50302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-09 11:31:09 +00:00
Sergey Biryukov
57da3e7813 Coding Standards: Remove unnecessary unset() calls in WP_Importer methods.
Variables created within the scope of a function are discarded automatically when PHP leaves the scope of the function, i.e. on `return`, so doing a call to `unset()` straight before a `return` statement is redundant.

Props jrf, ravipatel, rachelbaker, mukesh27.
Fixes #52996.
Built from https://develop.svn.wordpress.org/trunk@50692


git-svn-id: http://core.svn.wordpress.org/trunk@50301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-08 11:12:08 +00:00
Sergey Biryukov
7d65ff4f7a Coding Standards: Use strict comparison in wp-admin/includes/dashboard.php.
Includes minor code layout fixes for better readability.

See #52627.
Built from https://develop.svn.wordpress.org/trunk@50689


git-svn-id: http://core.svn.wordpress.org/trunk@50298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-07 18:34:07 +00:00
ryelle
d2d09b9a7a Accessibility: Administration: Update various background colors for increased contrast.
This ensures that contrast between text color and background meets the WCAG 2.0 AA recommended value. The following locations were changed:

- Network List Tables: Use lighter background colors for site status indicator.
- Nav Menus: Use a lighter background color for invalid menu items.
- Pointers: Use a darker background for pointer header.
- Themes: Use darker background on filter button hover.
- Customizer: Use darker background for selected widget.

Follow-up to [50025], [50571].
Props kebbet, melchoyce, peterwilsoncc.
Fixes #52760.


Built from https://develop.svn.wordpress.org/trunk@50687


git-svn-id: http://core.svn.wordpress.org/trunk@50296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-07 16:38:09 +00:00
gziolo
e6eb25fda4 Editor: Ensure @wordpress/inteface package is listed as a dependency
Discovered when backporting changes for WordPress 5.7.1 release.

See #52991.



Built from https://develop.svn.wordpress.org/trunk@50686


git-svn-id: http://core.svn.wordpress.org/trunk@50295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-07 11:39:19 +00:00
gziolo
e60fe4f2f3 Build Tools: Update development dependencies from WP packages
This patch updates only development dependencies for WordPress packages to align better with the Gutenberg plugin.

See #52991.


Built from https://develop.svn.wordpress.org/trunk@50685


git-svn-id: http://core.svn.wordpress.org/trunk@50294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-07 11:15:58 +00:00
Peter Wilson
f992857b31 Build tools: Revert package-lock.json change in [50682].
See #52768.

Built from https://develop.svn.wordpress.org/trunk@50683


git-svn-id: http://core.svn.wordpress.org/trunk@50292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-07 01:34:05 +00:00
Peter Wilson
312da2b826 Media: Do not lazy load hidden images or embeds.
Improve the check for sourceless or dimensionless media when determining if the lazy loading attribute should be added to iframes and images. Never include the lazy loading attribute on embeds of WordPress posts as the iframe is initially hidden.

Including `loading="lazy"` on initially hidden iframes and images can prevent the media from loading in some browsers.

Props adamsilverstein, fabianpimminger, flixos90, johnbillion, jonkastonka, joyously, peterwilsoncc, SergeyBiryukov, SirStuey, swissspidy.
Fixes #52768.


Built from https://develop.svn.wordpress.org/trunk@50682


git-svn-id: http://core.svn.wordpress.org/trunk@50291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-07 01:01:05 +00:00
Sergey Biryukov
21bcc7c836 Login and Registration: Check if $_GET['login'] is set before using it in wp-login.php.
This avoids an "Undefined index" PHP notice displayed as part of password reset process if `$_GET['key']` is set, but `$_GET['login']` is not.

Props satrancali.
Fixes #52980.
Built from https://develop.svn.wordpress.org/trunk@50677


git-svn-id: http://core.svn.wordpress.org/trunk@50286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-06 18:39:10 +00:00
desrosj
c1e7f92d6a Build/Test Tools: Prevent PHPUnit tests on push for forks/private mirrors.
The reorganization of the PHPUnit workflow in [50441] unintentionally caused the tests to be run for every `push` event, even for forks and private mirrors.

Previously, the second job required the first one to pass, and the conditional check on the first prevented both from running. Because the first job is no longer required for the second, both jobs must have the appropriate conditional check.

Fixes #52983.
Built from https://develop.svn.wordpress.org/trunk@50670


git-svn-id: http://core.svn.wordpress.org/trunk@50282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-06 15:14:10 +00:00
desrosj
94dae2b608 Bundled Themes: Update the “Tested up to” value.
“Tested up to” is not displayed on the theme directory or within the WordPress dashboard, but should be updated to be accurate for anyone reading the theme’s source code.

Follow up to [50508].

Fixes #52859.
Built from https://develop.svn.wordpress.org/trunk@50669


git-svn-id: http://core.svn.wordpress.org/trunk@50281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-06 14:43:08 +00:00
desrosj
2b73649b52 Build/Test Tools: Update some dependencies.
This updates `elliptic` to version `6.5.4` through `npm audit fix`.

`uglify-js` is also updated to version `3.13.3`, and `grunt-contrib-uglify` to version `5.0.1`.

See #52624.
Built from https://develop.svn.wordpress.org/trunk@50668


git-svn-id: http://core.svn.wordpress.org/trunk@50280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-06 14:31:21 +00:00
desrosj
cfe859c1f3 Twenty Twenty-One: Rebuild IE specific editor stylesheet.
This was not updated to include the changes from [50493].

Fixes #52981. See #52702.
Built from https://develop.svn.wordpress.org/trunk@50667


git-svn-id: http://core.svn.wordpress.org/trunk@50279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-06 14:12:05 +00:00
desrosj
caa5abc6c1 Build/Test Tools: Update dependencies in default themes.
This updates several dependencies in the Twenty Nineteen, Twenty Twenty, and Twenty Twenty-One default themes.

See #52624.
Built from https://develop.svn.wordpress.org/trunk@50666


git-svn-id: http://core.svn.wordpress.org/trunk@50278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-06 14:07:07 +00:00
Sergey Biryukov
53c0882200 Coding Standards: Use strict comparison in wp-admin/includes/credits.php.
See #52627.
Built from https://develop.svn.wordpress.org/trunk@50665


git-svn-id: http://core.svn.wordpress.org/trunk@50277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-06 13:47:02 +00:00
Sergey Biryukov
48cd688076 Coding Standards: Use strict comparison in wp-admin/includes/comment.php.
See #52627.
Built from https://develop.svn.wordpress.org/trunk@50664


git-svn-id: http://core.svn.wordpress.org/trunk@50276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-06 13:45:09 +00:00
Peter Wilson
72a04aa045 Options, Meta APIs: Update default color scheme swatch to match CSS changes.
Update the default/fresh theme color swatch displayed on user profile pages to match CSS changes made during the 5.7 release cycle.

Props audrasjb, desrosj, ninetyninew, ryelle.
Fixes #52750.


Built from https://develop.svn.wordpress.org/trunk@50663


git-svn-id: http://core.svn.wordpress.org/trunk@50275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-06 05:44:07 +00:00
Peter Wilson
7442fe63a0 Site Health: Reduce false reports of HTTPS failures.
Reduce severity of failing HTTPS tests from critical to warning. Stop reporting failures if the site is being accessed over HTTPS but `wp_is_https_supported()` indicates a lack of support.

Props annalamprou, AnotherDave, ayeshrajans, bobbingwide, Clorith, dragongate, eatsleepcode, gab81, geoffrey1963, Ipstenu, k3nsai, mmuyskens, nicegamer7, peterwilsoncc, pwallner, SergeyBiryukov, TimothyBlynJacobs, Toru.
Fixes #52783.

Built from https://develop.svn.wordpress.org/trunk@50659


git-svn-id: http://core.svn.wordpress.org/trunk@50271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-06 03:24:08 +00:00
Sergey Biryukov
b8f35c130c Coding Standards: Give some variables in WP_Importer a more meaningful name.
See #52627.
Built from https://develop.svn.wordpress.org/trunk@50658


git-svn-id: http://core.svn.wordpress.org/trunk@50270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-05 10:50:03 +00:00
Sergey Biryukov
a338f84f32 Coding Standards: Use strict comparison in wp-admin/includes/class-wp-filesystem-*.php.
See #52627.
Built from https://develop.svn.wordpress.org/trunk@50657


git-svn-id: http://core.svn.wordpress.org/trunk@50269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-05 10:38:07 +00:00
Sergey Biryukov
10a084a067 Coding Standards: Move some translator comments to the correct place.
Follow-up to [46273], [50060], [50117].

See #52627.
Built from https://develop.svn.wordpress.org/trunk@50654


git-svn-id: http://core.svn.wordpress.org/trunk@50266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-04 18:30:05 +00:00
Sergey Biryukov
b6e32b9d4f REST API: Correct enum validation for numeric values.
When validating `enum` values as `integer` or `number`, consider a number with a zero fractional part to be equivalent to an integer of the same value.

In `rest_are_values_equal()`, when comparing two values of type `int` or `float` (in any combination), first cast both of them to `float` and then compare.

This matches some test cases from the official JSON Schema test suite.

Follow-up to [50010].

Props yakimun, stefanjoebstl, TimothyBlynJacobs, rachelbaker.
Fixes #52932.
Built from https://develop.svn.wordpress.org/trunk@50653


git-svn-id: http://core.svn.wordpress.org/trunk@50265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-04 18:07:04 +00:00
Sergey Biryukov
907bfe74cd Coding Standards: Use strict comparison in wp-admin/includes/class-core-upgrader.php.
See #52627.
Built from https://develop.svn.wordpress.org/trunk@50652


git-svn-id: http://core.svn.wordpress.org/trunk@50264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-04 16:49:09 +00:00
Sergey Biryukov
b70c00d6ac Build/Test Tools: Rename some Grunt tasks to use hyphens instead of camelCase.
This makes the task names more consistent with other tasks.

Follow-up to [41043], [48096], [50650].

See #52625.
Built from https://develop.svn.wordpress.org/trunk@50651


git-svn-id: http://core.svn.wordpress.org/trunk@50263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-03 12:46:10 +00:00
davidbaumwald
3912ca99fd External Libraries: Update Underscore to version 1.12.1.
Full set of changes at https://github.com/jashkenas/underscore/compare/1.8.3...1.12.1.  
The new version includes a `sourceMappingURL` that causes a build failure, so this change 
also introduces a task to remove this from the source during the build.

Props mukesh27, hareesh-pillai, desrosj, SergeyBiryukov, TimoTijhof.
Fixes #45785.
Built from https://develop.svn.wordpress.org/trunk@50650


git-svn-id: http://core.svn.wordpress.org/trunk@50262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-02 19:42:21 +00:00
desrosj
75923de5ef Build/Test Tools: Prevent the workflow for testing old branches from running on forks.
This adds a conditional statement to ensure the workflow that tests old branches only runs on the official `wordpress-develop` mirror. This prevents it from running on forks and private mirrors.

See #52653.
Built from https://develop.svn.wordpress.org/trunk@50648


git-svn-id: http://core.svn.wordpress.org/trunk@50260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-02 16:22:04 +00:00
davidbaumwald
cc0ce2c91d Editor: Update the default writing prompt to match the block editor.
Recently merged, https://github.com/WordPress/gutenberg/pull/29611, changed the default writing prompt text.  WordPress core offers the `write_your_story` filter with a default value using the same text.  This change updates the default text to match the recent change in the block editor.

Props Joen, SergeyBiryukov.
Fixes #52948.
Built from https://develop.svn.wordpress.org/trunk@50647


git-svn-id: http://core.svn.wordpress.org/trunk@50259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-02 16:08:04 +00:00
davidbaumwald
133c4e2e50 Docs: Clarify return results for a non-existing ID in metadata functions.
[48658] documented that various metadata functions return false for an invalid ID. However, that does not clarify what an invalid ID is: a non-numeric, zero, or negative value. This change adds the clarification in all relevant metadata function docblocks.

Props icopydoc, SergeyBiryukov, davidkryzaniak, audrasjb.
Fixes #51797.
Built from https://develop.svn.wordpress.org/trunk@50641


git-svn-id: http://core.svn.wordpress.org/trunk@50253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-02 15:49:05 +00:00
Sergey Biryukov
526dfa8b12 KSES: Add object-position to the list of safe CSS properties.
This resolves an issue with the Cover block, where the `object-position` property is removed from the content when a non-admin user saves the post, leading to block recovery loop.

Props Mamaduka, aristath.
Fixes #52961.
Built from https://develop.svn.wordpress.org/trunk@50634


git-svn-id: http://core.svn.wordpress.org/trunk@50246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-02 12:41:09 +00:00
davidbaumwald
5767dbd5ff Build/Test Tools: Cleanup link-manager.zip after REST API tests are finished.
Introduced in [48242], the `link-manager` plugin is copied from `DIR_TESTDATA/plugins` to `DIR_TESTDATA` during the REST API unit tests, but was not cleaned up afterward.  This created a "dirty" local working copy.  This change `unlink`s the copied plugin from `DIR_TESTDATA` after unit tests are completed.

Props johnbillion, TimothyBlynJacobs, desrosj, rachelbaker.
Fixes #52579.
Built from https://develop.svn.wordpress.org/trunk@50633


git-svn-id: http://core.svn.wordpress.org/trunk@50245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-01 20:41:07 +00:00
davidbaumwald
739dfb756f Coding Standards: Remove some extra whitespace in get_item_schema.
Introduced in [50527].

See #52627.
Built from https://develop.svn.wordpress.org/trunk@50632


git-svn-id: http://core.svn.wordpress.org/trunk@50244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-01 15:54:04 +00:00
davidbaumwald
ab6c10948f Coding Standards: Removing unnecessary parentheses from require_once in wp-admin/options-privacy.php.
In [47198], parentheses were removed from `include` and `require` statements, as they are language constructs, not function calls.  However, [50161] introduced a new `require_once` instance in `wp-admin/options-privacy.php`.  This change removes the unnecessary parentheses.

See #53627.
Built from https://develop.svn.wordpress.org/trunk@50631


git-svn-id: http://core.svn.wordpress.org/trunk@50243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-01 15:36:08 +00:00
Sergey Biryukov
3697386083 Editor: Consolidate enqueueing block editor assets in wp-includes/default-filters.php.
Follow-up to [44157], [46111], [48537], [50620].

See #52920.
Built from https://develop.svn.wordpress.org/trunk@50629


git-svn-id: http://core.svn.wordpress.org/trunk@50241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-01 11:46:09 +00:00
Dominik Schilling
07b7afd60a External Libraries: Upgrade PHPMailer from 6.3.0 to 6.4.0.
6.4.0 reverts a change that made the `mail()` and sendmail transports set the envelope sender if one isn't explicitly provided, as it was causing problems in specific PHP/server configurations.

Release post: https://github.com/PHPMailer/PHPMailer/releases/tag/v6.4.0
Changelog: https://github.com/PHPMailer/PHPMailer/compare/v6.3.0...v6.4.0

Props Synchro, tigertech, ayeshrajans, galbaras, audrasjb, SergeyBiryukov, desrosj, ocean90.
Fixes #52822.
Built from https://develop.svn.wordpress.org/trunk@50628


git-svn-id: http://core.svn.wordpress.org/trunk@50240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-31 21:30:03 +00:00
Aaron Jorbin
f4678dff60 Build/Test & External Libraries : Fix jQuery deprecation.
jQuery.isArray is deprecated. Array.isArray is safe and used in other parts of the code base.

See: #51812

Built from https://develop.svn.wordpress.org/trunk@50627


git-svn-id: http://core.svn.wordpress.org/trunk@50239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-31 20:29:06 +00:00
Sergey Biryukov
4d1595b6d4 Docs: Document the import_id parameter of wp_insert_post().
Follow-up to [9100].

Props donmhico.
Fixes #52943.
Built from https://develop.svn.wordpress.org/trunk@50621


git-svn-id: http://core.svn.wordpress.org/trunk@50234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-31 13:05:06 +00:00
gziolo
6d42a21103 Editor: Enqueue assets for format library for the block editor
Ensures that `wp-format-library` assets are always loaded for the block editor. Otherwise, they have to be loaded individually for every screen that needs it. It's similar to how `wp-block-directory` assets are handled.

Props ellatrix.
See #52920.


Built from https://develop.svn.wordpress.org/trunk@50620


git-svn-id: http://core.svn.wordpress.org/trunk@50233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-31 05:52:10 +00:00
desrosj
5c451da5e9 External Libraries: Update polyfill versions in the script loader.
Follow up to [50615, 50617].

See #52854.
Built from https://develop.svn.wordpress.org/trunk@50619


git-svn-id: http://core.svn.wordpress.org/trunk@50232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-30 17:57:05 +00:00
Sergey Biryukov
f701ad4999 Coding Standards: Remove some extra whitespace in _wp_translate_postdata().
See #52627.
Built from https://develop.svn.wordpress.org/trunk@50618


git-svn-id: http://core.svn.wordpress.org/trunk@50231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-30 15:19:03 +00:00
desrosj
85c90c4e01 External Libraries: Update the path to polyfill-library files in Webpack.
Follow up to [50615].

Props gziolo.
Fixes #52854.
Built from https://develop.svn.wordpress.org/trunk@50617


git-svn-id: http://core.svn.wordpress.org/trunk@50230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-30 14:49:04 +00:00
Sergey Biryukov
1a9eb60625 Docs: Add documentation for the ::setup_export_contents_test method used in personal data export tests.
Follow-up to [50613].

Props hellofromTonya.
See #51423.
Built from https://develop.svn.wordpress.org/trunk@50616


git-svn-id: http://core.svn.wordpress.org/trunk@50229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-30 14:24:03 +00:00
desrosj
7eee8521b0 External Libraries: Update several polyfill libraries.
This updates the following polyfill libraries:

- `formdata-polyfill` from `3.0.13` to `3.0.20`.
- `objectFitPolyfill` from `2.3.4` to `2.3.5`.
- `polyfill-library` from `3.42.0` to `3.104.0`.

Props gziolo, desrosj.
Fixes #52854.
Built from https://develop.svn.wordpress.org/trunk@50615


git-svn-id: http://core.svn.wordpress.org/trunk@50228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-30 14:16:33 +00:00
davidbaumwald
67d6f5f6c6 Docs: Fix indentation for wp_term_query->construct method parameters.
The `fields` and `orderby` properties in `WP_Term_Query` are arrays and each accepts a variety of keys.  To properly indent each key in the docblock, a `*` should be used, not `-`.

Props whyisjake, audrasjb, SergeyBiryukov.
Fixes #52839.
Built from https://develop.svn.wordpress.org/trunk@50614


git-svn-id: http://core.svn.wordpress.org/trunk@50227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-29 21:35:07 +00:00
Sergey Biryukov
69a7063a49 Code Modernization: Check if the _export_data_grouped post meta is an array when generating a personal data export file.
This avoids a fatal error on PHP 8 in `wp_privacy_generate_personal_data_export_file()` if the `_export_data_grouped` post meta exists but is not an array.

Additionally, refactor unit tests for the function to:
* Reduce redundant code
* Switch to data provider
* Test on the full HTML output instead of select pieces of the output
* Expand unhappy path coverage

Follow-up to [43012], [44786], [47146], [47278].

Props hellofromTonya, jrf, xknown.
See #51423.
Built from https://develop.svn.wordpress.org/trunk@50613


git-svn-id: http://core.svn.wordpress.org/trunk@50226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-29 19:37:04 +00:00
Sergey Biryukov
59d32bfe24 Build/Test Tools: Remove explicit puppeteer dependency.
This was added in [48177] to fix an issue where Puppeteer was not being installed correctly as a dependency of `@wordpress/wp-scripts`. This has been fixed, so this explicit dependency can be removed.

Props isabel_brison, desrosj, SergeyBiryukov.
Fixes #52843.
Built from https://develop.svn.wordpress.org/trunk@50612


git-svn-id: http://core.svn.wordpress.org/trunk@50225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-29 18:07:25 +00:00
Sergey Biryukov
dc4de0d5a5 Login and Registration: Add the "Error:" prefix to some password reset messages.
This makes the messages more consistent with other error messages related to authentication and registration.

Follow-up to [50589].

Props dd32.
Fixes #52914.
Built from https://develop.svn.wordpress.org/trunk@50611


git-svn-id: http://core.svn.wordpress.org/trunk@50224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-28 10:24:05 +00:00
Sergey Biryukov
05631ab4cd Docs: Spell "non-existent" in a consistent way.
See #52628.
Built from https://develop.svn.wordpress.org/trunk@50610


git-svn-id: http://core.svn.wordpress.org/trunk@50223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-27 13:34:12 +00:00
desrosj
87a4101834 Build/Test Tools: Update some devDependencies.
This updates the following `devDependencies`:

- `sinon` from `9.2.4` to `10.0.0`.
- `uglify-js` from `3.13.1` to `3.13.2`.

See #52624.
Built from https://develop.svn.wordpress.org/trunk@50598


git-svn-id: http://core.svn.wordpress.org/trunk@50211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 15:47:21 +00:00
desrosj
755882578e Twenty Twelve: Change theme version back to 3.3.
Because the changes in Twenty Twelve did not impact site look or functionality, version 3.4 of Twenty Twelve was not released in coordination with WordPress 5.7.

This reverts the portion of [50508] relevant to Twenty Twelve, changing the version back to 3.3 so that version 3.4 is not skipped accidentally when there are changes that should be released.

See #52704.
Built from https://develop.svn.wordpress.org/trunk@50596


git-svn-id: http://core.svn.wordpress.org/trunk@50209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 15:28:05 +00:00
desrosj
219cf1dd5f Build/Test Tools: Run code coverage workflow when the file is updated.
When the workflow file is updated, it should always be run to verify changes.

Follow up to [50592].

See #52786.
Built from https://develop.svn.wordpress.org/trunk@50595


git-svn-id: http://core.svn.wordpress.org/trunk@50208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 15:14:04 +00:00
desrosj
2a76425048 Build/Test Tools: Run code coverage workflow using parallel jobs.
This splits the code coverage workflow into two separate jobs, allowing single site and multisite to run in parallel. This cuts the total workflow run time in half.

Fixes #52923.
Built from https://develop.svn.wordpress.org/trunk@50594


git-svn-id: http://core.svn.wordpress.org/trunk@50207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 15:11:04 +00:00
desrosj
ae3ae14958 Build/Test Tools: Do not checkout the Importer plugin in the Code Coverage workflow.
Since [50285], the WordPress Importer plugin (which is required for the test suite to run successfully) has been installed as part of the `npm run env:install` script.

See #52625.
Built from https://develop.svn.wordpress.org/trunk@50593


git-svn-id: http://core.svn.wordpress.org/trunk@50206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 14:59:03 +00:00
desrosj
952acb240a Build/Test Tools: Fix code coverage reporting to generate report from src.
Since [50441-50442] switched the test workflows to run from `src` instead of `build`, code coverage reporting has stopped working. This was caused by the code coverage configuration continuing to reference `build`. This corrects the configuration so coverage reporting can resume.

This change also introduces the `workflow_dispatch` event to the workflow, which will allow committers to manually run the workflow when desired. For example, to confirm changes to the test suite do not break reporting.

This also adds the `phpunit.xml.dist` and `tests/phpunit/multisite.xml` files to the `paths` list. Since these files are responsible for configuring the test suite and code coverage reporting, any changes to them should verify that no problems were introduced.

Props jrf, johnbillion.
Fixes #52786. See #51734.
Built from https://develop.svn.wordpress.org/trunk@50592


git-svn-id: http://core.svn.wordpress.org/trunk@50205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 13:25:05 +00:00
desrosj
bbc301ca6e Build/Test Tools: Run test workflows on old branches on a schedule.
On TravisCI, old branches still receiving security updates were tested on a regular basis. This ensured tests continued to pass as time passed even if updates were not made to these branches.

On GitHub Actions, there is no interface to configure this (TravisCI had a UI), but there is a `schedule` event that can trigger workflow runs on cron that can be used to accomplish the same thing.

This introduces a workflow file that runs twice a month (on the 1st and 15th) to verify the tests within older branches.

Because the `schedule` event only runs within the primary branch, the appropriate workflows in each old branch will be triggered manually through the `workflow_dispatch` trigger using the GitHub REST API. `workflow_dispatch` will need to be added to all workflows in all old branches in order for the event to dispatch successfully.

Fixes #52653.
Built from https://develop.svn.wordpress.org/trunk@50590


git-svn-id: http://core.svn.wordpress.org/trunk@50203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 13:08:03 +00:00
Sergey Biryukov
2c6e1dc1f9 Login and Registration: Restore the "Error:" prefix for the "Unknown username" message.
This makes the message more consistent with other error messages related to authentication and registration.

Follow-up to [46417].

Props dd32.
See #52914, #52915.
Built from https://develop.svn.wordpress.org/trunk@50589


git-svn-id: http://core.svn.wordpress.org/trunk@50202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 12:14:07 +00:00
Peter Wilson
cc7bdc71e8 Media: Conditionally pass 2nd parameter to getimagesize().
In the wrapper function `wp_getimagesize()` check if the second parameter was passed before sending it to the PHP function `getimagesize()`. 

The PHP function has a different execution path depending on the number of parameters passed, this ensures the wrapper function follows the appropriate path.

Follow up to [50552].
Props azaozz, hellofromtonya, Mista-Flo, peterwilsoncc, rinatkhaziev, RogerTheriault, SergeyBiryukov, terriann, whyisjake.
Fixes #52826.

Built from https://develop.svn.wordpress.org/trunk@50586


git-svn-id: http://core.svn.wordpress.org/trunk@50199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 00:09:04 +00:00
davidbaumwald
9b8c498eea Privacy: Print screen reader text for the "Copy suggested policy text..." action button.
This change switches out `sprintf` for `printf` on the "Copy suggested policy text from..." button screen reader text.  Also, wrap the actual button text in a `<span aria-hidden="true">` to prevent both the button text and the screen reader text from being spoken.

Props mukesh27, SergeyBiryukov, sabernhardt.
Fixes #52891.
Built from https://develop.svn.wordpress.org/trunk@50585


git-svn-id: http://core.svn.wordpress.org/trunk@50198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 20:21:04 +00:00
davidbaumwald
bf267e05ca Docs: Fix description for $htmlhint argument in code editor settings.
Introduced in [41558].

Props sabernhardt.
See #52628.
Built from https://develop.svn.wordpress.org/trunk@50583


git-svn-id: http://core.svn.wordpress.org/trunk@50196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 20:00:05 +00:00
davidbaumwald
eaffb58ce8 Posts, Post Types: Remove / from non-self-closing "clear" div tags.
In [49178], self-closing `br` tags were switched to non-self-closing `div` elements for "clearing" purposes, but the self-closing "/" remained in place.  This fix removes the unnecessary slash.

Props pavelvisualcomposer, audrasjb, sabernhardt, akabarikalpesh, SergeyBiryukov.
Fixes #52878.
Built from https://develop.svn.wordpress.org/trunk@50582


git-svn-id: http://core.svn.wordpress.org/trunk@50195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 19:33:04 +00:00
desrosj
2e34561536 Build/Test Tools: Disable fail-fast for the NPM testing workflow.
This disables the `fail-fast` option in the GitHub Actions workflow for testing NPM. This allows all jobs in the test matrix to complete, even if one fails, painting a clear picture of where the issue lies.

Follow up to [50435].

See #52625.
Built from https://develop.svn.wordpress.org/trunk@50579


git-svn-id: http://core.svn.wordpress.org/trunk@50192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 15:10:06 +00:00
ryelle
14eddefa5e Login, Registration: Prevent button misalignment on login screen.
Replace the float CSS removed in [50569], which is used to align the login & register buttons.

Props mukesh27, audrasjb.
Fixes #52834.


Built from https://develop.svn.wordpress.org/trunk@50577


git-svn-id: http://core.svn.wordpress.org/trunk@50190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 14:23:03 +00:00
Sergey Biryukov
d6cc4f1aec Query: Consistently include a space in parentheses in WP_Meta_Query::get_sql_for_clause().
Props jillebehm, kaavyaiyer, hareesh-pillai.
Fixes #49279.
Built from https://develop.svn.wordpress.org/trunk@50576


git-svn-id: http://core.svn.wordpress.org/trunk@50189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 12:39:07 +00:00
Peter Wilson
a66cb4bb18 Script Loader: Escape HTML5 boolean attribute names.
Add escaping of boolean attribute names in `wp_sanitize_script_attributes()` for themes supporting HTML5 script elements.

Props tmatsuur, johnbillion, joyously.
Fixes #52894.

Built from https://develop.svn.wordpress.org/trunk@50575


git-svn-id: http://core.svn.wordpress.org/trunk@50188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-25 00:27:06 +00:00
Sergey Biryukov
fc6e4cbe3e Accessibility: Administration: Use a darker gray color for various admin UI items.
This ensures that the color meets the WCAG 2.0 AA recommended contrast ratio.

Follow-up to [50025], [50525].

Props sabernhardt, ryelle.
Fixes #52760.
Built from https://develop.svn.wordpress.org/trunk@50571


git-svn-id: http://core.svn.wordpress.org/trunk@50184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-24 16:41:07 +00:00
gziolo
8f6ed34331 Editor: Add image default size to block editor settings
Related: https://github.com/WordPress/gutenberg/pull/29966

Add new imageDefaultSize value to block editor settings.

Props Mamaduka.
Fixes #52896.



Built from https://develop.svn.wordpress.org/trunk@50570


git-svn-id: http://core.svn.wordpress.org/trunk@50183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-24 07:33:08 +00:00
Peter Wilson
270f2011f8 Login, Registration: Prevent button misalignment on password reset screen.
Prevent misalignment of "generate password" and "save password" buttons on the password reset screen on narrow screens and in languages requiring longer text than English.

Props audrasjb, grapplerulrich, ryelle.
Fixes #52834.

Built from https://develop.svn.wordpress.org/trunk@50569


git-svn-id: http://core.svn.wordpress.org/trunk@50182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-24 00:22:02 +00:00
Peter Wilson
ea83435668 Privacy: Wrap text in buttons on privacy policy guide.
On narrow screens allow the text to wrap in the copy buttons on the privacy policy guide screen to avoid horizontal overflow of the parent container.

Props audrasjb, davidbaumwald, jaymanpandya, paaljoachim, palmiak, sabernhardt, SergeyBiryukov, sumitsingh.
Fixes #52751.

Built from https://develop.svn.wordpress.org/trunk@50568


git-svn-id: http://core.svn.wordpress.org/trunk@50181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-24 00:04:04 +00:00
Peter Wilson
c41990398c REST API: Prevent database error when deleting meta data.
Add a check to `WP_REST_Meta_Fields::delete_meta_value()` ensuring meta data is set before attempting to delete it from the database. If the data does not exist, the delete is considered successful as the data matches the desired state.

Props BrechtVds, goaroundagain, TimothyBlynJacobs.
Fixes #52787.

Built from https://develop.svn.wordpress.org/trunk@50567


git-svn-id: http://core.svn.wordpress.org/trunk@50180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-23 23:36:04 +00:00
Peter Wilson
fedd1d2b63 Robots: Remove contradictory directive check in wp_robots().
Removes the mutually exclusive directives check in `wp_robots()`, ie allow both `follow` and `nofollow` to be specified and for `archive` and `noarchive` to be specified.

This fixes a bug in which WordPress would defer to the most permissive over the least permissive. When contradictory instructions are included, WordPress will defer to the search engine's or archivist's resolution policy: generally this is to observe the least, not most permissive.

Props Cybr, flixos90.
Fixes #52713.


Built from https://develop.svn.wordpress.org/trunk@50566


git-svn-id: http://core.svn.wordpress.org/trunk@50179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-23 23:02:05 +00:00
Sergey Biryukov
d5a6a1ab44 Taxonomy: Use a consistent check for the $rewrite['hierarchical'] parameter.
This avoids a "Trying to access array offset on value of type bool" PHP warning in `get_term_link()` if the `$rewrite` parameter of `register_taxonomy()` is set as `false`.

Props Tkama, SergeyBiryukov.
Fixes #52882.
Built from https://develop.svn.wordpress.org/trunk@50565


git-svn-id: http://core.svn.wordpress.org/trunk@50178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-23 13:55:03 +00:00
gziolo
3bd08d3bd4 Editor: Add new theme category for block types
Related: https://github.com/WordPress/gutenberg/pull/30020.

Introduces a new "theme" category to the default set to use with template-parts and other FSE blocks.

Props matveb.
Fixes #52883. 


Built from https://develop.svn.wordpress.org/trunk@50564


git-svn-id: http://core.svn.wordpress.org/trunk@50177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-23 09:02:06 +00:00
Sergey Biryukov
0ee244739a Code Modernization: Correct expected data type for WP_User_Search::$page property.
This fixes erroneous parentheses placement and applies the type cast to the variable it was intended for.

Follow-up to [3864].

Props hellofromTonya, jrf, xknown.
See #51423.
Built from https://develop.svn.wordpress.org/trunk@50563


git-svn-id: http://core.svn.wordpress.org/trunk@50176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-22 22:42:04 +00:00
Sergey Biryukov
63fba77ec7 Docs: Fix typo in pre_term_link filter description.
See #52628.
Built from https://develop.svn.wordpress.org/trunk@50562


git-svn-id: http://core.svn.wordpress.org/trunk@50175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-22 19:19:09 +00:00
Sergey Biryukov
590d59e92f Coding Standards: Move some translator comments to the correct place.
Follow-up to [48172].

See #52627.
Built from https://develop.svn.wordpress.org/trunk@50561


git-svn-id: http://core.svn.wordpress.org/trunk@50174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-21 13:13:03 +00:00
Sergey Biryukov
a885f914e4 Coding Standards: Add missing semicolon to some endif keywords.
See #52627.
Built from https://develop.svn.wordpress.org/trunk@50560


git-svn-id: http://core.svn.wordpress.org/trunk@50173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-21 13:05:04 +00:00
Sergey Biryukov
63191bd646 Tests: Move the get_current_commenter() method next to the test it's used in.
Follow-up to [48133].

See #52625.
Built from https://develop.svn.wordpress.org/trunk@50559


git-svn-id: http://core.svn.wordpress.org/trunk@50172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-21 12:55:04 +00:00
Sergey Biryukov
5e10227d76 Coding Standards: Use strict comparison for return type checks in a few functions:
* `get_bookmark()`
* `get_comment()`
* `get_post()`
* `get_children()`
* `wp_get_recent_posts()`
* `wp_get_post_revision()`
* `wp_get_nav_menu_items()`

Follow-up to [45710] for `get_term()`, [48507] for `wpdb::get_row()` and `wpdb::get_results()`.

See #52627.
Built from https://develop.svn.wordpress.org/trunk@50558


git-svn-id: http://core.svn.wordpress.org/trunk@50171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-21 12:41:04 +00:00
Sergey Biryukov
d72f4e0e48 Coding Standards: Use strict comparison in wp-admin/includes/class-wp-upgrader.php.
See #52627.
Built from https://develop.svn.wordpress.org/trunk@50557


git-svn-id: http://core.svn.wordpress.org/trunk@50170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-21 12:12:07 +00:00
Sergey Biryukov
d3d78e755b Coding Standards: Add a space before / character in some self-closing HTML tags.
While this has no effect on the code, it fixes a minor inconsistency with the rest of core.

Props laxman-prajapati.
Fixes #52870.
Built from https://develop.svn.wordpress.org/trunk@50556


git-svn-id: http://core.svn.wordpress.org/trunk@50169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-20 18:30:08 +00:00
Sergey Biryukov
643888dfc6 I18N: Update list of continents and cities for the timezone selection.
Props wangql, mukesh27.
Fixes #52861.
Built from https://develop.svn.wordpress.org/trunk@50555


git-svn-id: http://core.svn.wordpress.org/trunk@50168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-19 15:42:04 +00:00
Sergey Biryukov
b4c09beba8 I18N: Remove duplicate entries from the list of continents and cities.
Follow-up to [37554].

See #52861.
Built from https://develop.svn.wordpress.org/trunk@50554


git-svn-id: http://core.svn.wordpress.org/trunk@50167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-19 15:21:08 +00:00
whyisjake
471fc1e913 Media: Pass the appropriate reference into wp_getimagesize.
With changes that were introduced in [49889] the second parameter for getimagesize() function is expecting a a reference.

Previously, most calls did not pass the 2nd param, and as a result, we are getting unexpected results.

This was only a problem with applications that are using a custom stream wrapper, and the image contained EXIF data.

For more see:

* https://github.com/humanmade/S3-Uploads/issues/496
* https://github.com/aws/aws-sdk-php/issues/1923

Fixes #52826.
Props terriann, SergeyBiryukov, Mista-Flo, hellofromTonya, rinatkhaziev, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@50552


git-svn-id: http://core.svn.wordpress.org/trunk@50165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-19 00:01:03 +00:00
ryelle
3363e22f80 Pointers: Make pointer border darker to match arrow tip.
Props johnjamesjacoby, melchoyce, SergeyBiryukov.
Fixes #52670.


Built from https://develop.svn.wordpress.org/trunk@50551


git-svn-id: http://core.svn.wordpress.org/trunk@50164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 23:26:05 +00:00
Peter Wilson
c7fac4a9ea External libraries: Update generated script loader version hashes.
Update the generated file `src/wp-includes/assets/script-loader-packages.php` following the clipboard.js update in [50544].

See #52850.

Built from https://develop.svn.wordpress.org/trunk@50550


git-svn-id: http://core.svn.wordpress.org/trunk@50163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 22:45:04 +00:00
ryelle
0bfb5f043b Administration: Make focus states consistent in admin menu when collapsed.
When collapsed or on a small screen, these styles would override the color schemes, causing a dark background to appear regardless of the color scheme's settings. This change also uses `focus-within` to show or hide the menu item's arrow, consistent with how the arrow behaves on hover.

Props afercia, Bueltge.
Fixes #32579.


Built from https://develop.svn.wordpress.org/trunk@50549


git-svn-id: http://core.svn.wordpress.org/trunk@50162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 21:44:09 +00:00
desrosj
707b80c194 Emoji: Update the Twemoji library to version 13.0.2.
This point release does not add any new Emoji and only slightly modifies 14 existing Emoji without changing their meanings.

Because of this, the same CDN location (currently `/images/core/emoji/13.0.1`) can be updated with the new versions and sites running WordPress 5.6 or higher will start using the updated versions once their cache expires.

See #52852.
Built from https://develop.svn.wordpress.org/trunk@50548


git-svn-id: http://core.svn.wordpress.org/trunk@50161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 19:20:19 +00:00
Sergey Biryukov
87db5b833d External Libraries: Further fix jQuery deprecations in WordPress core.
Follow-up to [50001], [50270], [50367], [50383], [50410], [50420], [50429].

Props Clorith.
See #51812.
Built from https://develop.svn.wordpress.org/trunk@50547


git-svn-id: http://core.svn.wordpress.org/trunk@50160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 19:01:03 +00:00
desrosj
cd3e85fe23 External Libraries: Update the jQuery Form library.
This updates the `jquery-form` library from version `4.2.1` to `4.3.0`.

A full list of changes can be found on GitHub: https://github.com/jquery-form/form/compare/v4.2.1...v4.3.0.

Fixes #52685.
Built from https://develop.svn.wordpress.org/trunk@50546


git-svn-id: http://core.svn.wordpress.org/trunk@50159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 17:53:19 +00:00
desrosj
235b19b3b0 Build/Test Tools: Update some devDependencies.
This updates a handful of dependencies to their latest versions.

- `qunit` from `2.14.0` to `2.14.1`.
- `uglify-js` from `3.13.0` to `3.13.1`.
- `wait-on` from `5.2.1` to `5.3.0`.

See #52624.
Built from https://develop.svn.wordpress.org/trunk@50545


git-svn-id: http://core.svn.wordpress.org/trunk@50158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 17:48:23 +00:00
desrosj
456973fa26 External Libraries: Update Clipboard.js library to version 2.0.8.
This updates the `clipboard` library from version `2.0.6` to `2.0.8`.

A full list of changes can be found on GitHub: https://github.com/zenorocha/clipboard.js/compare/v2.0.6...v2.0.8.

Fixes #52850.
Built from https://develop.svn.wordpress.org/trunk@50544


git-svn-id: http://core.svn.wordpress.org/trunk@50157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 15:54:18 +00:00
desrosj
3a92b15f93 External Libraries: Update jQuery Color library to version 2.2.0.
This updates the `jquery-color` library from version `2.1.2` to `2.2.0`.

This also switches back to installing the dependency from NPM instead of GitHub. The maintainers have resumed publishing to NPM with the 2.2.0 release.

A full list of changes can be found on GitHub: https://github.com/jquery/jquery-color/compare/2.1.2...2.2.0.

Props hareesh-pillai, desrosj.
Fixes #51405.
Built from https://develop.svn.wordpress.org/trunk@50543


git-svn-id: http://core.svn.wordpress.org/trunk@50156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 15:50:18 +00:00
desrosj
0baa695906 Build/Test Tools: Revert [50540].
The E2E workflow is failing after this change. Reverting to to investigate further.

Unprops desrosj.
See #52843.
Built from https://develop.svn.wordpress.org/trunk@50542


git-svn-id: http://core.svn.wordpress.org/trunk@50155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 14:35:22 +00:00
Sergey Biryukov
bf29bb4441 Coding Standards: Use strict comparison for JS fragment in some admin files.
Follow-up to [48083].

Props nayanchamp7, rnaby.
Fixes #52845, #41988.
Built from https://develop.svn.wordpress.org/trunk@50541


git-svn-id: http://core.svn.wordpress.org/trunk@50154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 14:13:08 +00:00
desrosj
357e77789c Build/Test Tools: Remove explicit puppeteer dependency.
This was added in [48177] to fix an issue where Puppeteer was not being installed correctly as a dependency of `@wordpress/wp-scripts`. This has been fixed, so this explicit dependency can be removed.

Props isabel_brison.
Fixes #52843.
Built from https://develop.svn.wordpress.org/trunk@50540


git-svn-id: http://core.svn.wordpress.org/trunk@50153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 12:44:23 +00:00
Sergey Biryukov
6ad5c0c553 Docs: Correct formatting for the description of some register_post_type() parameters.
Props audrasjb.
Fixes #52836.
Built from https://develop.svn.wordpress.org/trunk@50538


git-svn-id: http://core.svn.wordpress.org/trunk@50151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-17 17:33:10 +00:00
Sergey Biryukov
4d514bb6ad Tests: Correct some newly introduced @covers tags.
Follow-up to [50289], [50344].

Props jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50537


git-svn-id: http://core.svn.wordpress.org/trunk@50150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-16 18:46:07 +00:00
ryelle
5d983ec85b Help/About: Run image comparison script after all assets have loaded.
If the callback is called before the images are loaded, the comparison doesn't work. `wp.domReady` uses `DOMContentLoaded`, which does not guarantee that the images are loaded. This switches to use the `load` event, which waits for all resources to load.

Props vladytimy, joyously, sergeybiryukov.
Fixes #52758.


Built from https://develop.svn.wordpress.org/trunk@50535


git-svn-id: http://core.svn.wordpress.org/trunk@50148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-15 19:51:09 +00:00
Sergey Biryukov
f9cc35ebad Twenty Seventeen: Remove extra space around post editor.
The editor uses the full height of its container, so the added margins cause the visual editor to break out of the container. This removes the top & bottom margins, and makes the left & right margins consistent with the meta box area.

Follow-up to [50465].

Props joseeyoast, audrasjb.
Fixes #52816.
Built from https://develop.svn.wordpress.org/trunk@50534


git-svn-id: http://core.svn.wordpress.org/trunk@50147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-15 13:26:06 +00:00
Sergey Biryukov
7720afe9a7 Coding Standards: Remove some extra whitespace in sanitize_comment_cookies().
See #52627.
Built from https://develop.svn.wordpress.org/trunk@50533


git-svn-id: http://core.svn.wordpress.org/trunk@50146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-14 17:01:12 +00:00
Sergey Biryukov
dc68fb8278 Docs: Synchronize $category_name description in WP_Block_Pattern_Categories_Registry methods.
Follow-up to [48156].

See #52628.
Built from https://develop.svn.wordpress.org/trunk@50532


git-svn-id: http://core.svn.wordpress.org/trunk@50145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-13 11:17:03 +00:00
Sergey Biryukov
0a3794a0de Docs: Correct DocBlock formatting for register_block_style_handle().
Follow-up to [48141].

See #52628.
Built from https://develop.svn.wordpress.org/trunk@50531


git-svn-id: http://core.svn.wordpress.org/trunk@50144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-13 11:15:04 +00:00
Sergey Biryukov
3f03bb352e Site Health: Use a singular string in dashboard widget if there is only one critical issue or recommendation.
Props Presskopp, hareesh-pillai.
Fixes #52521.
Built from https://develop.svn.wordpress.org/trunk@50530


git-svn-id: http://core.svn.wordpress.org/trunk@50143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-13 10:59:02 +00:00
Sergey Biryukov
cb55990e50 Docs: Add missing @since tags for item_link and item_link_description post type and taxonomy labels.
Follow-up to [50527].

See #52688.
Built from https://develop.svn.wordpress.org/trunk@50529


git-svn-id: http://core.svn.wordpress.org/trunk@50142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-13 10:25:06 +00:00
davidbaumwald
fb8c18e541 Docs: Correct unregister_block_style @param for $block_name.
In `unregister_block_style`, the `$block_name` parameter was documented as an array.  This change corrects the type to `string`, as that's what is expected in `WP_Block_Styles_Registry->unregister`. 

Props kraftner.
Fixes #52795.
Built from https://develop.svn.wordpress.org/trunk@50528


git-svn-id: http://core.svn.wordpress.org/trunk@50141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-12 20:05:08 +00:00
gziolo
f27c179afc Editor: Make block type aware of variations
Currently block variations are only defined on the client. In some cases, creating block variations on the server can be very useful, especially when needed data is not exposed in the REST APIs.

Related to https://github.com/WordPress/gutenberg/pull/29095.

Props: gwwar, timothyblynjacobs.
Fixes: #52688.


Built from https://develop.svn.wordpress.org/trunk@50527


git-svn-id: http://core.svn.wordpress.org/trunk@50140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-12 13:35:09 +00:00
Sergey Biryukov
96377c956f Accessibility: Administration: Use a darker color for post dates in the Activity and Quick Draft dashboard widgets.
This ensures that the color meets the WCAG 2.0 AA recommended contrast ratio.

Follow-up to [50025].

Props sabernhardt, Otshelnik-Fm, audrasjb.
Fixes #52760.
Built from https://develop.svn.wordpress.org/trunk@50525


git-svn-id: http://core.svn.wordpress.org/trunk@50138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-12 12:06:13 +00:00
ryelle
9808fad416 Help/About: Use absolute URLs for inline images on About pages.
This ensures the images are loaded correctly from both single site and network About pages.

Props TobiasBg, audrasjb.
Fixes #52743.


Built from https://develop.svn.wordpress.org/trunk@50523


git-svn-id: http://core.svn.wordpress.org/trunk@50136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-11 21:38:08 +00:00
Sergey Biryukov
88df1ef431 Coding Standards: Consistently format opendir() calls in get_plugins().
Props sabernhardt, subrataemfluence.
Fixes #44250.
Built from https://develop.svn.wordpress.org/trunk@50522


git-svn-id: http://core.svn.wordpress.org/trunk@50135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-11 15:19:08 +00:00
desrosj
efaa79d347 External Libraries: Update jQuery hoverIntent to version 1.10.1.
This updates the `jquery-hoverintent` dependency from 1.8.3 to 1.10.1.

For a full list of changes, see https://github.com/briancherne/jquery-hoverIntent/compare/v1.8.3...v1.10.1.

Fixes #52686.
Built from https://develop.svn.wordpress.org/trunk@50521


git-svn-id: http://core.svn.wordpress.org/trunk@50134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-10 15:25:20 +00:00
desrosj
de074081d1 External Libraries: Update jQuery to version 3.6.0.
This updates the jQuery dependency from 3.5.1 to 3.6.0.

For a full list of changes, see https://github.com/jquery/jquery/compare/3.5.1...3.6.0.

Fixes #52707. See #51812.
Built from https://develop.svn.wordpress.org/trunk@50520


git-svn-id: http://core.svn.wordpress.org/trunk@50133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-10 15:07:24 +00:00
Sergey Biryukov
a292585ea4 Help/About: Correct the WebM video URL on About page.
Props mihdan, audrasjb.
Fixes #52756.
Built from https://develop.svn.wordpress.org/trunk@50518


git-svn-id: http://core.svn.wordpress.org/trunk@50131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-10 10:28:11 +00:00
Peter Wilson
0b75f9557e Docs: Improve spelling in [50516].
Props jeremyfelt.
See #52628, #34564.

Built from https://develop.svn.wordpress.org/trunk@50517


git-svn-id: http://core.svn.wordpress.org/trunk@50130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-09 23:22:06 +00:00
Peter Wilson
fb1857def8 Docs: Improve compatibility comment in WP_List_Table.
Improve comment explaining backward compatibility check for the primary column in `WP_List_Table::get_column_info()`.

Unprops helen, markjaquith.
See #52628, #34564.


Built from https://develop.svn.wordpress.org/trunk@50516


git-svn-id: http://core.svn.wordpress.org/trunk@50129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-09 22:35:06 +00:00
Sergey Biryukov
ebee7d0ab9 Classic Editor: Make sure word count is hidden if JavaScript is disabled.
Removing `display: block` from the element allows the `.hide-if-no-js` class to have the intended effect.

Follow-up to [34275].

Props sabernhardt, mukesh27.
Fixes #52662.
Built from https://develop.svn.wordpress.org/trunk@50512


git-svn-id: http://core.svn.wordpress.org/trunk@50125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-09 10:13:08 +00:00
desrosj
a8b7cd17e0 Update $_old_files for 5.7.
Follow up to [50066].

See #52334.
Built from https://develop.svn.wordpress.org/trunk@50510


git-svn-id: http://core.svn.wordpress.org/trunk@50123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-08 18:30:07 +00:00
desrosj
e2a19b5352 Bundled Themes: Bump theme version numbers for WordPres 5.7.
This updates all new default themes to new versions, which will be released shortly after WordPress 5.7. The new versions are:

- Twenty Twenty-One: 1.2
- Twenty Twenty: 1.7
- Twenty Nineteen: 2.0
- Twenty Seventeen: 2.6
- Twenty Sixteen: 2.4
- Twenty Fifteen: 2.9
- Twenty Fourteen: 3.1
- Twenty Thirteen: 3.3
- Twenty Twelve: 3.4
- Twenty Eleven: 3.7
- Twenty Ten: 3.3

Fixes #52704.
Built from https://develop.svn.wordpress.org/trunk@50507


git-svn-id: http://core.svn.wordpress.org/trunk@50120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-08 14:17:08 +00:00
Sergey Biryukov
fa5a9d5e92 Upgrade/Install: Display version number on the "Update now" button on WordPress Updates screen.
Additionally, adjust the "Update to latest nightly" button to include the major version number of the nightly build.

This makes the button labels more accurate and provides more clear understanding of what the update will be.

Follow-up to [49984].

Props afragen, pbiron, SergeyBiryukov.
Fixes #52513.
Built from https://develop.svn.wordpress.org/trunk@50506


git-svn-id: http://core.svn.wordpress.org/trunk@50119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-08 11:31:09 +00:00
John Blackbourn
52679edbff Docs: Add examples of possible names for various hooks whose name contains a dynamic portion.
This provides greater discoverability of such hooks in search results on the Code Reference site as well as increased clarity when reading the source.

See #50734, #52628

Built from https://develop.svn.wordpress.org/trunk@50505


git-svn-id: http://core.svn.wordpress.org/trunk@50118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-07 12:32:09 +00:00
Sergey Biryukov
f4f826d74d Docs: Add a @since note to wp_admin_bar_edit_menu() about the "View Post" link on Comments screen for a single post.
Follow-up to [47903].

Props sabernhardt, janak007, munyagu.
Fixes #42366.
Built from https://develop.svn.wordpress.org/trunk@50504


git-svn-id: http://core.svn.wordpress.org/trunk@50117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-07 11:56:07 +00:00
John Blackbourn
2b596377be Build/Test Tools: Ensure the test_php_and_js_shortcode_attribute_regexes_match() test can run when testing using either the src or build directory.
Props alexstine, desrosj

See #51734

Built from https://develop.svn.wordpress.org/trunk@50501


git-svn-id: http://core.svn.wordpress.org/trunk@50114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-05 15:28:03 +00:00
Sergey Biryukov
497171a1c8 XML-RPC: Pass an empty array to the xmlrpc_call action in methods that have no arguments.
This avoids an "Undefined variable" PHP notice in the `::mt_supportedMethods()` and `::mt_supportedTextFilters()` methods.

Follow-up to [50353].

Props dd32.
Fixes #52524.
Built from https://develop.svn.wordpress.org/trunk@50499


git-svn-id: http://core.svn.wordpress.org/trunk@50112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-05 11:03:06 +00:00
noisysocks
328fa9858d Editor: Update @wordpress npm packages
Update @wordpress npm packages to the latest published versions. This includes
block editor bug fixes for WordPress 5.7 RC 3.

See #52718.

Built from https://develop.svn.wordpress.org/trunk@50496


git-svn-id: http://core.svn.wordpress.org/trunk@50109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-05 04:10:44 +00:00
ryelle
22358d62ce Help/About: Clarify two strings.
The intro text has been updated for accuracy and to make it easier for translation. The button text has been updated for accuracy.

Props jdy68, audrasjb, marybaum, davidbaumwald.
See #52347.


Built from https://develop.svn.wordpress.org/trunk@50495


git-svn-id: http://core.svn.wordpress.org/trunk@50108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-04 19:10:06 +00:00
desrosj
d3324379f9 Twenty Twenty-One: Make text readable when dark background is selected for the Media & Text block.
This change ensures that the text in the Media & Text block is readable when dark background colors are selected.

This is a regression that was introduced in [49987].

Props hellofromTonya, poena, paaljoachim, ryelle.
Fixes #52702.
Built from https://develop.svn.wordpress.org/trunk@50493


git-svn-id: http://core.svn.wordpress.org/trunk@50106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-04 16:57:05 +00:00
Sergey Biryukov
290229ae07 Docs: Update inline comments in some test files per the documentation standards.
See #52628.
Built from https://develop.svn.wordpress.org/trunk@50491


git-svn-id: http://core.svn.wordpress.org/trunk@50104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-04 10:13:07 +00:00
Peter Wilson
4d2abda74a Roles/Caps: Return same result from current_user_can and user_can().
Ensure `current_user_can()` and `user_can()` return the same results for logged out users. For core capabilities this changes `user_can( 0, 'exist' )` to return `true` rather than `false` in line with `current_user_can( 'exist' )` for logged out users.

Convert `current_user_can()` and `current_user_can_for_blog()` to wrapper functions ultimately calling `user_can()`.

Add anonymous user to primitive capability checks as appropriate. Convert `Tests_User_Capabilities::test_other_caps_for_all_roles()` to use a data provider and add tests to check whether user exists in the database (`WP_User::exists()`) as that intentionally differs from the `exist` capability.

Props jjj, johnbillion, peterwilsoncc, SergeyBiryukov, TimothyBlynJacobs.
Fixes #52076.


Built from https://develop.svn.wordpress.org/trunk@50490


git-svn-id: http://core.svn.wordpress.org/trunk@50103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-04 00:14:04 +00:00
noisysocks
534bbf3f36 Block Editor: Fix color support for dynamic blocks
Changes wp_apply_colors_support to check for for color instead of
__experimentalColor when determining block support for color.

Props nosolosw, rafhun, youknowriad.
See #52709.

Built from https://develop.svn.wordpress.org/trunk@50488


git-svn-id: http://core.svn.wordpress.org/trunk@50101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-03 23:31:04 +00:00
desrosj
bbdc16d705 Build/Test Tools: Update some dependencies.
This updates the following `devDependencies`:

- `grunt-contrib-cssmin` from `3.0.0` to `4.0.0`.
- `uglify-js` from `3.12.8` to `3.13.0`.

See #52624.
Built from https://develop.svn.wordpress.org/trunk@50487


git-svn-id: http://core.svn.wordpress.org/trunk@50100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-03 21:16:22 +00:00
desrosj
c082c48111 Build/Test Tools: Pin SHA versions to the remaining 3rd party actions.
This also adds inline comments to the end of each action installed using a SHA value to make it easier to determine which version of an action is currently being used.

Follow up to [50474,50476].

Props johnbillion.
See #52625.
Built from https://develop.svn.wordpress.org/trunk@50486


git-svn-id: http://core.svn.wordpress.org/trunk@50099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-03 20:31:06 +00:00
desrosj
2af9d4751a Build/Test Tools: Generalize the NPM test workflow.
The NPM test GitHub Actions workflow is currently used to verify that `npm install` and `npm run build` will complete successfully on Windows.

This generalizes the workflow and adds testing for Linux and MacOS to confirm that the scripts used to build WordPress also complete successfully in those environments.

Because MacOS workflow runs consume GHA minutes at a 10x rate, it’s added in a separate job in order to perform a more strict check.

This also adds steps to verify that using `npm run build:dev` and `npm run grunt clean`/`npm run grunt clean —dev` run successfully 

Props johnbillion.
Fixes #52658.
Built from https://develop.svn.wordpress.org/trunk@50485


git-svn-id: http://core.svn.wordpress.org/trunk@50098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-03 19:52:05 +00:00
Sergey Biryukov
4f61efe826 Docs: Update documentation in some WP_REST_Request tests per the documentation standards.
Follow-up to [49329].

See #52628.
Built from https://develop.svn.wordpress.org/trunk@50484


git-svn-id: http://core.svn.wordpress.org/trunk@50097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-03 19:26:08 +00:00
Sergey Biryukov
3cdbafe164 Help/About: Clarify a string about lazy-loading iframes.
Props davidbaumwald, audrasjb, hellofromTonya.
See #52347.
Built from https://develop.svn.wordpress.org/trunk@50483


git-svn-id: http://core.svn.wordpress.org/trunk@50094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 21:38:03 +00:00
desrosj
679c86818b Build/Test Tools: Add path detection when running GitHub Actions on pull_request.
This change adds a list of paths to check when determining which workflows to run on `pull_request`. This will prevent certain workflows from running unnecessarily when the files updated are not related to the tests and checks being performed.

Props peterwilsoncc, johnbillion.
Fixes #52667.
Built from https://develop.svn.wordpress.org/trunk@50479


git-svn-id: http://core.svn.wordpress.org/trunk@50090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 19:59:03 +00:00
ryelle
f4f117144e Help/About: Iterate on the 5.7 About Page.
Adds a more obviously interactive comparison for viewing the color scheme differences. Improvements on RTL and IE11. Update strings to be more clear and consistent. Switch to the CDN for loading images.

Props sarahricker, desrosj, melchoyce, SergeyBiryukov, tikifez, clorith, marybaum, audrasjb, francina, hellofromTonya.
Fixes #52693. See #52347.


Built from https://develop.svn.wordpress.org/trunk@50478


git-svn-id: http://core.svn.wordpress.org/trunk@50089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 19:50:04 +00:00
desrosj
37b71d9d40 Build/Test Tools: Change the cancel-workflow-action version to a SHA value.
Additionally, the `access_token` input now defaults to `github.token`, so specifying it is unnecessary.

Follow up to [50474].

Props johnbillion.
See #52625.
Built from https://develop.svn.wordpress.org/trunk@50476


git-svn-id: http://core.svn.wordpress.org/trunk@50087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 17:49:02 +00:00
Mike Schroder
34b0dc8023 Upgrade/Install: Invalidate OPcache for version.php during update.
Invalidate OPcache for `wp-content/version.php` on update individually, since it’s copied separately.

Props stodorovic, krstarica, cenay, desrosj, pbiron, sergeybiryukov, mikeschroder.
Fixes #51686, #51281.
See #36455.
Built from https://develop.svn.wordpress.org/trunk@50475


git-svn-id: http://core.svn.wordpress.org/trunk@50086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 17:13:03 +00:00
desrosj
a2a326b7cc Build/Test Tools: Pin the welcome-action to a specific commit SHA.
Some GitHub Action scripts require additional permissions to perform the desired operations. This permission is usually given by passing a personal access token (PAT) to the action as an input.

Because PATs grant access to sensitive information about the repository and actions with PATs become trusted actors, 3rd party actions should not be installed by specifying a major or minor version.

Instead, specifying a full length commit SHA will use the 3rd party action as an immutable release, ensuring the workflows within the repository are not affected by upstream security problems should they occur.

Props johnbillion.
See #52625.
Built from https://develop.svn.wordpress.org/trunk@50474


git-svn-id: http://core.svn.wordpress.org/trunk@50085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 16:11:04 +00:00
desrosj
39eb1e5ee0 Build/Test Tools: Run automated testing workflows for trunk branch.
This ensures a seamless transition when the primary branch is changed from `master` to `trunk` in the GitHub mirror. Once the transition is completed, the `master` branch can be removed.

See https://make.wordpress.org/systems/2021/03/02/update-git-wordpress-org-to-rename-master-to-trunk/ and https://make.wordpress.org/core/2020/06/18/proposal-update-all-git-repositories-to-use-main-instead-of-master/.

See #52625.
Built from https://develop.svn.wordpress.org/trunk@50473


git-svn-id: http://core.svn.wordpress.org/trunk@50084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 15:28:05 +00:00
Sergey Biryukov
e1239d91a9 Security, Site Health: Do not store HTTPS request error messages in an option.
This changes the logic in `update_https_detection_errors()` to never store error messages from the actual request since they could use a different encoding, which would make storing them in an option potentially fail, leading WordPress to then falsely assume that HTTPS is supported.

While this doesn't actually fix the encoding issue, it is not crucial to do so anyway, since these messages are not used anywhere. A simple differentiation between whether the overall HTTPS request or only the SSL verification failed should be sufficient for the purpose of this function.

Props flixos90, tmatsuur, lukecarbis.
Fixes #52484.
Built from https://develop.svn.wordpress.org/trunk@50471


git-svn-id: http://core.svn.wordpress.org/trunk@50082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 15:08:09 +00:00
ryelle
c2f6f53b9b Twenty Twenty-One: Correct inner container background color for Cover Blocks.
Adjust the background color palette rules so they don't show up on inner containers when they're not supposed to:
- When an inner container block is present, it only applies them to direct children of the block with the background color assigned.
- Since the background color should only be applied to the Cover block's overlay, not to the inner container, it opts that specific block out of this rule.

Props dianeco, kjellr, paaljoachim.
Fixes #52676.


Built from https://develop.svn.wordpress.org/trunk@50466


git-svn-id: http://core.svn.wordpress.org/trunk@50077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-01 23:26:04 +00:00