Sergey Biryukov
6f86cedb09
Menus: Improve the wording of instructions for dragging the items into the preferred order.
...
Props amolv, equin0x80, dlh.
Fixes #48184 .
Built from https://develop.svn.wordpress.org/trunk@46791
git-svn-id: http://core.svn.wordpress.org/trunk@46591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-27 19:51:01 +00:00
Sergey Biryukov
d8b251f0af
Administration: Properly wrap long titles in list tables on smaller screens.
...
Props mukesh27, iihglobal, wpamitkumar.
Fixes #48805 .
Built from https://develop.svn.wordpress.org/trunk@46790
git-svn-id: http://core.svn.wordpress.org/trunk@46590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-27 16:52:02 +00:00
Sergey Biryukov
e2c2fb64bf
Users: Display admin email verification screen in user's locale instead of site locale.
...
Props sathyapulse, TimothyBlynJacobs.
Fixes #48313 .
Built from https://develop.svn.wordpress.org/trunk@46788
git-svn-id: http://core.svn.wordpress.org/trunk@46588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-27 14:35:02 +00:00
ianbelanger
c74c8cf5f1
Bundled Themes: Fixes JS TypeError in Twenty Twenty.
...
On mobile devices using a webkit browser, the menu and search modals could not be opened due to a `TypeError: document.body is null`. This commit fixes that issue by adding a `touch-enabled` class to the body for browsers that do not support media queries.
Props quicoto, poena, Boga86, acosmin, macmanx.
Fixes #48601 .
Built from https://develop.svn.wordpress.org/trunk@46786
git-svn-id: http://core.svn.wordpress.org/trunk@46586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-26 18:21:03 +00:00
Sergey Biryukov
5af0c2989b
Tests: Add feed
group for get_feed_build_date()
test added in [46756].
...
See #48675 .
Built from https://develop.svn.wordpress.org/trunk@46785
git-svn-id: http://core.svn.wordpress.org/trunk@46585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-26 16:19:03 +00:00
Dominik Schilling
f4165a697d
Upgrade/Install: Provide a default label for "Continue" button in language selection form.
...
Prevents an empty continue button if a translation isn't yet available.
Props sathyapulse.
Fixes #48776 .
Built from https://develop.svn.wordpress.org/trunk@46784
git-svn-id: http://core.svn.wordpress.org/trunk@46584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-26 15:19:04 +00:00
Sergey Biryukov
63fefb540a
Users: Use correct variable when displaying the Additional Capabilities list in user profile.
...
Addresses a regression in [45926].
Props wpgurudev, aravindajith, anantajitjg, davidbaumwald.
Fixes #48725 .
Built from https://develop.svn.wordpress.org/trunk@46782
git-svn-id: http://core.svn.wordpress.org/trunk@46582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-25 14:01:03 +00:00
Sergey Biryukov
e0830ac7bc
Options, Meta APIs: Update @since
version for the $force_cache
parameter added for wp_load_alloptions()
in [46753] to 5.3.1.
...
See #31245 .
Built from https://develop.svn.wordpress.org/trunk@46779
git-svn-id: http://core.svn.wordpress.org/trunk@46579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-25 13:44:02 +00:00
Sergey Biryukov
012ddf095a
Media: Avoid a PHP notice in image_downsize()
when trying to replace a non-image URL with a rendered image from its meta.
...
Props Mte90, jrf, hareesh-pillai.
Fixes #48324 .
Built from https://develop.svn.wordpress.org/trunk@46772
git-svn-id: http://core.svn.wordpress.org/trunk@46572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-25 10:07:02 +00:00
Sergey Biryukov
2a85fe21d8
Accessibility: Administration: Underline links on Dashboard that are located within a line of text and thus need to be underlined:
...
* "change your theme completely"
* Active theme in the "At a Glance" box
* "View all drafts" in the Quick Draft box
Split "Manage widgets or menus" into separate items for consistency with other links.
For better accessibility, links that are a part of other text should be underlined and not rely on color alone to be distinguished.
Per accessibility coding standards:
> When links can be identified as such by the context, for example because they’re part of a menu, or a set of links clearly identified as user interface controls, they don’t necessarily need to be underlined. In all the other cases, especially for links surrounded by other text (in a line or block of text), links need to be always underlined.
https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/#links-underline-or-no-underline
https://make.wordpress.org/accessibility/handbook/design/use-of-color/#not-by-color-alone
Props afercia, audrasjb, karmatosed.
Fixes #48406 .
Built from https://develop.svn.wordpress.org/trunk@46770
git-svn-id: http://core.svn.wordpress.org/trunk@46570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-24 19:57:05 +00:00
Sergey Biryukov
a1ad168857
Twenty Twenty: Remove duplicate array key/value in TwentyTwenty_Non_Latin_Languages::get_non_latin_css()
.
...
Props manikmist09.
Fixes #48624 .
Built from https://develop.svn.wordpress.org/trunk@46765
git-svn-id: http://core.svn.wordpress.org/trunk@46565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-24 10:55:02 +00:00
Sergey Biryukov
c786eaa1df
Coding Standards: Fix WPCS issue in [46763].
...
See #48777 .
Built from https://develop.svn.wordpress.org/trunk@46764
git-svn-id: http://core.svn.wordpress.org/trunk@46564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-23 19:21:03 +00:00
Sergey Biryukov
26a750e162
Docs: Add missing @since
tags for functions in wp-admin/includes/update.php
.
...
Props sathyapulse, zodiac1978.
Fixes #48777 .
Built from https://develop.svn.wordpress.org/trunk@46763
git-svn-id: http://core.svn.wordpress.org/trunk@46563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-23 18:51:01 +00:00
Sergey Biryukov
0b5f3acd9f
Twenty Twenty: Correctly align the author bio and bottom post meta on single posts on mobile.
...
Props nielslange, Anlino.
Fixes #48619 .
Built from https://develop.svn.wordpress.org/trunk@46762
git-svn-id: http://core.svn.wordpress.org/trunk@46562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-23 14:54:04 +00:00
Sergey Biryukov
8e9c4a116a
Embeds: Remove CollegeHumor oEmbed provider, as the service does not exist anymore.
...
Props audrasjb, youknowriad.
Fixes #48696 .
Built from https://develop.svn.wordpress.org/trunk@46761
git-svn-id: http://core.svn.wordpress.org/trunk@46561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-23 10:15:03 +00:00
Sergey Biryukov
58aa1cc8c5
Docs: Adjust wp_is_json_request()
and wp_is_xml_request()
return value descriptions for consistency.
...
See #48771 , #48303 .
Built from https://develop.svn.wordpress.org/trunk@46760
git-svn-id: http://core.svn.wordpress.org/trunk@46560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-22 18:28:04 +00:00
Sergey Biryukov
597b22c99c
Docs: Correct spelling and capitalization in wp-includes/load.php
:
...
* Fix typo in `is_blog_admin()` description.
* Capitalize PHP correctly in `enable_wp_debug_mode_checks` filter description.
* Capitalize XML correctly in `wp_is_xml_request()` return value description.
Props stevegrunwell.
Fixes #48771 .
Built from https://develop.svn.wordpress.org/trunk@46759
git-svn-id: http://core.svn.wordpress.org/trunk@46559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-22 18:16:03 +00:00
Sergey Biryukov
56af5db74f
Editor: Improve the appearance of tag cloud in Tags meta box in classic editor.
...
Props sathyapulse, Spaceshipone, tmatsuur, audrasjb, afercia.
Fixes #48592 .
Built from https://develop.svn.wordpress.org/trunk@46758
git-svn-id: http://core.svn.wordpress.org/trunk@46558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-22 00:04:02 +00:00
Sergey Biryukov
882be65f94
Date/Time: Correct the time format in get_feed_build_date()
to use 24-hour format.
...
Follow-up to [46756].
See #48675 .
Built from https://develop.svn.wordpress.org/trunk@46757
git-svn-id: http://core.svn.wordpress.org/trunk@46557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-21 16:27:03 +00:00
Sergey Biryukov
d13ce45ff6
Date/Time: Remove mysql2date()
usage in get_feed_build_date()
to ensure the output includes correct timezone offset.
...
With the changes in [45908], `mysql2date()` works correctly for all local time inputs, but should not be used for UTC time inputs.
Add a unit test.
Props Rarst, lisota.
Fixes #48675 .
Built from https://develop.svn.wordpress.org/trunk@46756
git-svn-id: http://core.svn.wordpress.org/trunk@46556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-21 13:18:00 +00:00
Sergey Biryukov
44d5372825
I18N: Correct translator comment for By %s
string in Plugins list table.
...
Follow-up to [44541].
See #45898 .
Built from https://develop.svn.wordpress.org/trunk@46755
git-svn-id: http://core.svn.wordpress.org/trunk@46555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-21 00:08:02 +00:00
Sergey Biryukov
d5434d7cc7
Customize: If the return URL for Close button is a page added to the Appearance menu by a deactivated theme, fall back to the Themes screen.
...
Props JarretC, Jean-David, SergeyBiryukov.
Fixes #46686 .
Built from https://develop.svn.wordpress.org/trunk@46754
git-svn-id: http://core.svn.wordpress.org/trunk@46554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-20 18:49:03 +00:00
Sergey Biryukov
285d38bd83
Options, Meta APIs: Avoid a race condition causing the first of two subsequent requests updating different options at the same time to lose changes.
...
Every time an autoloaded option is updated or deleted, the `alloptions` cache is similarly updated. Due to the race condition, on any autoloaded option being updated, every other autoloaded option had its value set to the value at load time, causing a mismatch between the data in the persistent cache and the database.
This change introduces a `$force_cache` parameter for `wp_load_alloptions()` to force an update of the local `alloptions` cache from the persistent cache when an option is added, updated, or deleted, to minimize the chance of affecting other options.
Props fabifott, rmccue, tollmanz, johnjamesjacoby, spacedmonkey, dd32, jipmoors, tellyworth, jeremyclarke, joehoyle, boonebgorges, danielbachhuber, flixos90, jeichorn, mihdan, Grzegorz.Janoszka, SergeyBiryukov.
See #31245 .
Built from https://develop.svn.wordpress.org/trunk@46753
git-svn-id: http://core.svn.wordpress.org/trunk@46553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-20 13:42:03 +00:00
Sergey Biryukov
b0a0f62727
Docs: Fix typo in README.md
.
...
Props dkarfa.
Fixes #48737 .
Built from https://develop.svn.wordpress.org/trunk@46752
git-svn-id: http://core.svn.wordpress.org/trunk@46552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-20 08:33:01 +00:00
Sergey Biryukov
cca5c825ed
Docs: Clarify that WP_Theme::get()
, ::display()
, and several related methods treat the Tags
theme header as an array.
...
Props david.binda.
Fixes #48005 .
Built from https://develop.svn.wordpress.org/trunk@46751
git-svn-id: http://core.svn.wordpress.org/trunk@46551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-20 08:31:03 +00:00
Sergey Biryukov
8e4b0c2c45
XML-RPC: Pass correct variable as the URL parameter to http_headers_useragent
filter in wp_xmlrpc_server::pingback_ping()
.
...
Props wpgurudev, andreaitm.
Fixes #48721 . See #42186 .
Built from https://develop.svn.wordpress.org/trunk@46750
git-svn-id: http://core.svn.wordpress.org/trunk@46550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-19 11:07:03 +00:00
Sergey Biryukov
a6cecef42f
Login and Registration: Pass $user_data
parameter to the lostpassword_post
action in retrieve_password()
.
...
Props wpgurudev, pagewidth, lukecavanagh, johnbillion, kkarpieszuk.
Fixes #38334 .
Built from https://develop.svn.wordpress.org/trunk@46749
git-svn-id: http://core.svn.wordpress.org/trunk@46549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-19 10:01:04 +00:00
Andrea Fercia
c0950c1d50
Accessibility: Media: Add an aria-pressed
attribute to active button within a button group.
...
The `aria-pressed` attribute communicates semantically the "active" state of buttons that otherwise only look "active".
Fixes #48355 .
Built from https://develop.svn.wordpress.org/trunk@46748
git-svn-id: http://core.svn.wordpress.org/trunk@46548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-18 22:23:03 +00:00
Sergey Biryukov
06ab7e3f6b
Twenty Twenty: Fix typos in a variable name and inline comment in assets/js/color-calculations.js
.
...
Props tanvirul.
Fixes #48704 .
Built from https://develop.svn.wordpress.org/trunk@46747
git-svn-id: http://core.svn.wordpress.org/trunk@46547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-18 17:07:01 +00:00
Andrea Fercia
71725aeb95
Accessibility: Add an aria-current
attribute to the Media Library switch links.
...
The `aria-current` attribute is a simple, effective, way to help assistive technology users orientate themselves within a set of items.
Props mayanksonawat, afercia.
Fixes #48271 .
Built from https://develop.svn.wordpress.org/trunk@46746
git-svn-id: http://core.svn.wordpress.org/trunk@46546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-18 16:51:02 +00:00
Andrea Fercia
eec579dd86
Widgets: Avoid to move focus to the Image Widget "Insert from URL" field.
...
Fixes a bug after [45499], where the backbone view element isn't the input field any longer. Also, managing focus programmatically is often an assumption on a specific user flow and should generally be avoided, see #43169 .
Props dufresnesteven.
See #43169 .
Fixes #48588 .
Built from https://develop.svn.wordpress.org/trunk@46745
git-svn-id: http://core.svn.wordpress.org/trunk@46545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-18 16:23:02 +00:00
Sergey Biryukov
306045277e
Administration: Switch rgb()
CSS property for paused plugin error message in Plugins list table to rgba()
.
...
While technically correct as is, the latter is more consistent with other admin styles and causes less confusion.
Props manikmist09.
Fixes #48629 .
Built from https://develop.svn.wordpress.org/trunk@46744
git-svn-id: http://core.svn.wordpress.org/trunk@46544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-18 13:18:03 +00:00
Sergey Biryukov
f32831bf6d
Taxonomy: Correct the initial value for WP_Taxonomy::$labels
to match get_taxonomy_labels()
return type.
...
Improve documentation for consistency with `WP_Post_Type::$labels`.
Props alpipego.
Fixes #48681 .
Built from https://develop.svn.wordpress.org/trunk@46743
git-svn-id: http://core.svn.wordpress.org/trunk@46543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-18 07:58:59 +00:00
Sergey Biryukov
5aa3a51264
Docs: Update broken source code link in WP_Filesystem_SSH2
class.
...
Props mryoga, finchps.
Fixes #48467 .
Built from https://develop.svn.wordpress.org/trunk@46742
git-svn-id: http://core.svn.wordpress.org/trunk@46542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-17 16:16:02 +00:00
Sergey Biryukov
96e163473e
Docs: Update broken source code link in imgAreaSelect
jQuery plugin.
...
Props mryoga, finchps.
See #48467 .
Built from https://develop.svn.wordpress.org/trunk@46741
git-svn-id: http://core.svn.wordpress.org/trunk@46541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-17 16:14:03 +00:00
Sergey Biryukov
0d8e11db06
Docs: Replace Codex URLs with corresponding HelpHub articles in wp-config-sample.php
.
...
Props sebastienserre.
Fixes #48680 .
Built from https://develop.svn.wordpress.org/trunk@46740
git-svn-id: http://core.svn.wordpress.org/trunk@46540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-17 11:11:04 +00:00
Sergey Biryukov
418db0297e
Docs: Correct spelling of "subclass" and "overridden" in various docblocks and error messages.
...
Props garrett-eclipse.
Fixes #48676 .
Built from https://develop.svn.wordpress.org/trunk@46739
git-svn-id: http://core.svn.wordpress.org/trunk@46539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-17 07:43:01 +00:00
Sergey Biryukov
927aa4b44c
Docs: Fix typo in wp_credits_section_title()
description.
...
Switch descriptions for `wp_credits_section_title()` and `wp_credits_section_list()` to third-person singular verbs, per the documentation standards.
Props hareesh-pillai.
Fixes #48674 .
Built from https://develop.svn.wordpress.org/trunk@46738
git-svn-id: http://core.svn.wordpress.org/trunk@46538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-16 21:04:01 +00:00
Sergey Biryukov
0f90f6a739
Editor: Pass $editor_id
parameter to tiny_mce_plugins
, mce_external_plugins
, and mce_external_languages
filters, for consistency with teeny_mce_plugins
.
...
Document the `classic-block` value passed to various editor filters in `wp_tinymce_inline_scripts()`.
Add missing `@since` entries for the existing `$editor_id` parameter in various filters.
Props djp424, johnbillion, SergeyBiryukov.
Fixes #48441 .
Built from https://develop.svn.wordpress.org/trunk@46737
git-svn-id: http://core.svn.wordpress.org/trunk@46537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-16 16:36:02 +00:00
Sergey Biryukov
9bf98c307b
Security: Add WordPress 5.3.x to the "Supported Versions" section of GitHub Security Policy.
...
Props imath.
Fixes #48667 . See #48521 .
Built from https://develop.svn.wordpress.org/trunk@46736
git-svn-id: http://core.svn.wordpress.org/trunk@46536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-16 11:19:03 +00:00
whyisjake
a761a23464
Security: Add a GitHub Security Policy.
...
As part of more responsible security disclosure, we are adding a security policy to GitHub.
Fixes #48521 .
Props whyisjake, ayeshrajans.
Built from https://develop.svn.wordpress.org/trunk@46735
git-svn-id: http://core.svn.wordpress.org/trunk@46535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-15 23:46:01 +00:00
whyisjake
ba7170de9c
Toolbar: Properly escape the onclick attribute.
...
The onclick attribute was being escaped twice, once with `esc_js` and again with `esc_attr`.
Fixes #48117 .
Props tmatsuur, dinhtungdu.
Built from https://develop.svn.wordpress.org/trunk@46734
git-svn-id: http://core.svn.wordpress.org/trunk@46534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-15 23:24:02 +00:00
Sergey Biryukov
3a735ec87a
Docs: Improve a comment about $doing_wp_cron
global in wp-cron.php
.
...
Props chinteshprajapati, subrataemfluence, nielslange.
Fixes #46104 .
Built from https://develop.svn.wordpress.org/trunk@46733
git-svn-id: http://core.svn.wordpress.org/trunk@46533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-15 08:59:01 +00:00
Sergey Biryukov
4ec53dc54c
Docs: Remove incorrect @return
tags.
...
Props diddledan.
Fixes #48613 , #48614 .
Built from https://develop.svn.wordpress.org/trunk@46732
git-svn-id: http://core.svn.wordpress.org/trunk@46532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-14 09:57:03 +00:00
Sergey Biryukov
04ba6a1d8f
Docs: Correct parameter type for $item
in WP_REST_Terms_Controller::prepare_item_for_response()
.
...
Props diddledan, TimothyBlynJacobs.
Fixes #48616 .
Built from https://develop.svn.wordpress.org/trunk@46731
git-svn-id: http://core.svn.wordpress.org/trunk@46531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-14 08:55:02 +00:00
Sergey Biryukov
d4cec569fe
Docs: Fix typo in @return
value for PO::trim_quotes()
.
...
Props diddledan.
Fixes #48572 .
Built from https://develop.svn.wordpress.org/trunk@46730
git-svn-id: http://core.svn.wordpress.org/trunk@46530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-13 13:45:02 +00:00
John Blackbourn
3def77672d
Docs: Correct some invalid hook docblocks.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46729
git-svn-id: http://core.svn.wordpress.org/trunk@46529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-12 22:42:02 +00:00
Sergey Biryukov
6ceb0279af
Help/About: Move images to the CDN.
...
Props ryelle.
Fixes #47708 .
Built from https://develop.svn.wordpress.org/trunk@46724
git-svn-id: http://core.svn.wordpress.org/trunk@46524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-12 18:30:03 +00:00
Sergey Biryukov
3696fadc2d
Bundled Themes: Update Twenty Twenty.
...
This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46715], see fa8c3fc...a9e73ab
.
Props Anlino, karmatosed, williampatton, poena, joyously, ianbelanger, chetan200891.
See #48110 , #48386 , #48450 , #48505 , #48557 .
Fixes #48571 .
Built from https://develop.svn.wordpress.org/trunk@46722
git-svn-id: http://core.svn.wordpress.org/trunk@46522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-12 18:24:03 +00:00
Sergey Biryukov
7ce88a02cd
Bundled Themes: Update copyright year in readme.txt
for Twenty Twelve and Twenty Twenty.
...
Follow-up to [46719].
See #48566 .
Built from https://develop.svn.wordpress.org/trunk@46720
git-svn-id: http://core.svn.wordpress.org/trunk@46520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-12 17:51:02 +00:00