Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-07 11:20:28 +01:00
Code Issues Projects Releases Wiki Activity
32,586 Commits 50 Branches 747 Tags 791 MiB
7a24b60c2a
Commit Graph

5882 Commits

Author SHA1 Message Date
Sergey Biryukov
844586e889 Add missing translator comments after [34293]. 
See #31851.
Built from https://develop.svn.wordpress.org/trunk@34298


git-svn-id: http://core.svn.wordpress.org/trunk@34262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-18 18:39:23 +00:00
Scott Taylor
ec01716bb2 Don't use HTML tags in translation strings for "In Reply To" links for comments in the admin. 
Props ramiy.
Fixes #31857.

Built from https://develop.svn.wordpress.org/trunk@34297


git-svn-id: http://core.svn.wordpress.org/trunk@34261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-18 18:36:24 +00:00
Scott Taylor
15f2e57a5a Don't use HTML tags in translation strings in wp-admin/includes/update.php. 
Props ramiy.
Fixes #31855.

Built from https://develop.svn.wordpress.org/trunk@34296


git-svn-id: http://core.svn.wordpress.org/trunk@34260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-18 18:31:25 +00:00
Scott Taylor
318cd61abf Don't use <code> in translation strings in wp-admin/includes/schema.php. 
Props ramiy.
Fixes #31851.

Built from https://develop.svn.wordpress.org/trunk@34293


git-svn-id: http://core.svn.wordpress.org/trunk@34257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-18 18:21:25 +00:00
Scott Taylor
dd6fe1ba32 Network Setup: don't use <code> in translation strings in wp-admin/network files. 
Props ramiy.
Fixes #31840.

Built from https://develop.svn.wordpress.org/trunk@34292


git-svn-id: http://core.svn.wordpress.org/trunk@34256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-18 18:18:27 +00:00
Aaron Jorbin
10d03c1ab3 Remove support for my-hacks.php 
For the last 10 years, my-hacks has been deprecated and has been throwing a deprecation notice. For the last six years, you haven't been able to enable my-hacks.php in the admin UI. That should be enough time to give developers notice. Plugins and themes seem like they might have staying power.

Fixes #33741
Props bobbingwide


Built from https://develop.svn.wordpress.org/trunk@34291


git-svn-id: http://core.svn.wordpress.org/trunk@34255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-18 17:06:25 +00:00
Dominik Schilling
f3a62b7714 Theme Editor: Change file descriptions of header.php and footer.php. 
`header.php` is now "Theme Header" and `footer.php` is "Theme Footer". This prevents a clash with other "Header" strings in the context of "Custom Header".

Props ramiy.
Fixes #32975.
Built from https://develop.svn.wordpress.org/trunk@34290


git-svn-id: http://core.svn.wordpress.org/trunk@34254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-18 16:03:24 +00:00
Sergey Biryukov
b92955b427 Network Admin: Include IDs for users and sites on their respective views. 
Props danielbachhuber, wonderboymusic.
Fixes #18661.
Built from https://develop.svn.wordpress.org/trunk@34289


git-svn-id: http://core.svn.wordpress.org/trunk@34253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-18 15:58:25 +00:00
Dion Hulse
6113e498fc Updates: FTP: Add a missing PCRE modifer in [34281]. 
See #16026, #33432x

Built from https://develop.svn.wordpress.org/trunk@34282


git-svn-id: http://core.svn.wordpress.org/trunk@34246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-18 08:23:25 +00:00
Dion Hulse
5abc1eaab9 Updates: FTP/PemFTP Library: Remove the usage of deprecated regular expression functions (ereg replaced by PCRE). 
Props enshrined, aaroncampbell
Fixes #16026, #33432

Built from https://develop.svn.wordpress.org/trunk@34281


git-svn-id: http://core.svn.wordpress.org/trunk@34245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-18 08:20:27 +00:00
Scott Taylor
48d402a395 Posts List Table: Use a more robust technique for calculating $total_items so that pagination still appears when items are removed on the last page of results and ->max_num_pages decreases. 
Props A5hleyRich.
Fixes #29870.

Built from https://develop.svn.wordpress.org/trunk@34271


git-svn-id: http://core.svn.wordpress.org/trunk@34235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-17 21:18:24 +00:00
Helen Hou-Sandí
48befcf361 Superglobals: Revert [34059] until further notice. 
see #33837.

Built from https://develop.svn.wordpress.org/trunk@34265


git-svn-id: http://core.svn.wordpress.org/trunk@34229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-17 12:33:26 +00:00
Sergey Biryukov
514eb11cf4 Revert unintended change from [34262]. 
See #33910.
Built from https://develop.svn.wordpress.org/trunk@34263


git-svn-id: http://core.svn.wordpress.org/trunk@34227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-17 09:09:28 +00:00
Sergey Biryukov
d91fe61405 Docs: Expand the DocBlock for get_default_post_to_edit(). 
Props rabmalin.
Fixes #33910.
Built from https://develop.svn.wordpress.org/trunk@34262


git-svn-id: http://core.svn.wordpress.org/trunk@34226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-17 09:06:34 +00:00
Scott Taylor
f3dd19c6e2 Media: In wp_ajax_send_attachment_to_editor(), the fallback logic for $html should be tucked into an else statement so it isn't run needlessly and overwritten. 
Props tychay.
Fixes #32072.

Built from https://develop.svn.wordpress.org/trunk@34260


git-svn-id: http://core.svn.wordpress.org/trunk@34224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-17 05:55:25 +00:00
Scott Taylor
63efd92b11 Media: In get_image_send_to_editor(), allow a custom value for $rel. 
Props tychay.
Fixes #32074.

Built from https://develop.svn.wordpress.org/trunk@34259


git-svn-id: http://core.svn.wordpress.org/trunk@34223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-17 05:46:24 +00:00
Scott Taylor
58ac764859 Media List Table: remove the counts from the "views" portion of the toolbar, which are inconsistent with grid view. Also reduces complexity and removes potentially expensive count query. 
Related to the toolbar view, remove the `wp_admin_canonical_url()` action in grid mode. Grid views that result from links from the list table view are lenses into the library and need to be indicated as such vs being a full attachment query.

Fixes #29744.

Built from https://develop.svn.wordpress.org/trunk@34256


git-svn-id: http://core.svn.wordpress.org/trunk@34220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-17 02:30:26 +00:00
Boone Gorges
85c00bd943 Move new user notification emails to add_action() callbacks. 
When a new user is created in various places throughout the interface,
notifications are sent to the site admin and the new user. Previously, these
notifications were fired through direct calls to `wp_new_user_notification()`,
making it difficult to stop or modify the messages.

This changeset introduces a number of new action hooks in place of direct calls
to `wp_new_user_notification()`, and hooks the new wrapper function
`wp_send_new_user_notifications()` to these hooks.

Props dshanske, thomaswm, boonebgorges.
Fixes #33587.
Built from https://develop.svn.wordpress.org/trunk@34251


git-svn-id: http://core.svn.wordpress.org/trunk@34215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-16 22:19:24 +00:00
Scott Taylor
1e3807c10d wp-admin/includes/template.php is now a loader for 3 files made via svn cp: 
* `Walker_Category_Checklist` class
* `WP_Internal_Pointers` class
* `template-functions.php`

This is BC for plugins that are loading `wp-admin/includes/template.php` for fun.

See #33413.

Built from https://develop.svn.wordpress.org/trunk@34241


git-svn-id: http://core.svn.wordpress.org/trunk@34205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-16 15:35:23 +00:00
Sergey Biryukov
d06f5817f8 Docs: Expand the DocBlock for the WP_Theme::get_edit_link() method, introduced in [34084]. 
Fixes #32376.
Built from https://develop.svn.wordpress.org/trunk@34238


git-svn-id: http://core.svn.wordpress.org/trunk@34202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-16 15:01:27 +00:00
Drew Jaynes
13c25f5f49 Docs: Put "it's" in its place (again). 
Props kitchin.
Fixes #33894.

Built from https://develop.svn.wordpress.org/trunk@34234


git-svn-id: http://core.svn.wordpress.org/trunk@34198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-16 12:46:28 +00:00
Sergey Biryukov
4c019c6aee Comments: Fix a fatal error in Comments meta box after [34223]. 
Props tyxla.
Fixes #33893. See #33413.
Built from https://develop.svn.wordpress.org/trunk@34231


git-svn-id: http://core.svn.wordpress.org/trunk@34195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-16 11:37:25 +00:00
Drew Jaynes
3c73b53f66 Docs: Remove markdown from the DocBlock summary for WP_List_Table::get_primary_column(), introduced in [34166]. 
The PHP inline documentation standards for [https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#summary-formerly-short-description summaries] call for not using an markup or markdown. Also, using the full Class::method() in this context allows for better clarity in what is being referenced.

See #33854. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34229


git-svn-id: http://core.svn.wordpress.org/trunk@34193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-16 10:51:25 +00:00
Scott Taylor
5920e8eb13 Move WP_Post_Comments_List_Table to its own file. 
See #33413.

Built from https://develop.svn.wordpress.org/trunk@34223


git-svn-id: http://core.svn.wordpress.org/trunk@34187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-16 06:53:24 +00:00
John Blackbourn
a9e5cfddc7 Implement wp_login_url() and wp_registration_url() in places where wp-login.php is currently hard-coded. 
See #31495
Props GregLone

Built from https://develop.svn.wordpress.org/trunk@34213


git-svn-id: http://core.svn.wordpress.org/trunk@34177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-15 17:11:35 +00:00
Scott Taylor
ff3ae0e747 Don't redirect to the Term list table after submitting the form on the Edit Term page. 
Props chiragswadia, UmeshSingla, rhyswynne, afercia.
Fixes #17455.

Built from https://develop.svn.wordpress.org/trunk@34202


git-svn-id: http://core.svn.wordpress.org/trunk@34166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-15 15:59:42 +00:00
John Blackbourn
a5a8ae45a6 Remove outdated references to the preview_post_link filter docs. 
See #24345
Props paulwilde

Built from https://develop.svn.wordpress.org/trunk@34178


git-svn-id: http://core.svn.wordpress.org/trunk@34146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-15 10:32:31 +00:00
Scott Taylor
ab6d1fa247 Use get_attached_file() in attachment_submitbox_metadata(). 
Props kitchin.
Fixes #33386.

Built from https://develop.svn.wordpress.org/trunk@34171


git-svn-id: http://core.svn.wordpress.org/trunk@34139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-15 04:18:25 +00:00
Scott Taylor
54829b6305 Create a function, get_preview_post_link(), to DRY the logic for applying the 'preview_post_link' filter to a URL. 
Props TomHarrigan, wonderboymusic.
Fixes #24345.

Built from https://develop.svn.wordpress.org/trunk@34170


git-svn-id: http://core.svn.wordpress.org/trunk@34138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-15 04:15:25 +00:00
Scott Taylor
ee42803e21 Move WP_Screen to its own file. 
See #33413.

Built from https://develop.svn.wordpress.org/trunk@34169


git-svn-id: http://core.svn.wordpress.org/trunk@34137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-15 04:08:24 +00:00
Scott Taylor
fde014e85e Move the admin Nav Menu Walker subclasses into their own files. Load in nav-menu.php to remain BC. 
See #33413.

Built from https://develop.svn.wordpress.org/trunk@34168


git-svn-id: http://core.svn.wordpress.org/trunk@34136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-15 04:02:25 +00:00
Scott Taylor
780487556b Add a doc block to WP_List_Table::get_primary_column(). 
Fixes #33854.

Built from https://develop.svn.wordpress.org/trunk@34166


git-svn-id: http://core.svn.wordpress.org/trunk@34134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-15 03:35:25 +00:00
Scott Taylor
191400f9e6 Don't ever use the guid value when retrieving URLs for media, use wp_get_attachment_url(). Use get_attached_file() for path to file. 
Fixes #33386.

Built from https://develop.svn.wordpress.org/trunk@34163


git-svn-id: http://core.svn.wordpress.org/trunk@34131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-15 02:50:25 +00:00
Scott Taylor
69e3a390b2 In _wp_ajax_delete_comment_response(), read the new 'all' prop returned by get_comment_count() via wp_count_comments() when setting $total. 'all' doesn't include spam in its count. 
Updates unit tests.

Props dipesh.kakadiya.
Fixes #32362.

Built from https://develop.svn.wordpress.org/trunk@34161


git-svn-id: http://core.svn.wordpress.org/trunk@34129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-15 01:47:25 +00:00
Nikolay Bachiyski
097c4fd2f4 List tables: escape user e-mails 
Better safe than sorry.

Built from https://develop.svn.wordpress.org/trunk@34133


git-svn-id: http://core.svn.wordpress.org/trunk@34101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-14 22:33:25 +00:00
Scott Taylor
7639a89a1f wp_unspam_comment() can accept a full object instead of comment_ID to reduce cache/db lookups.. 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@34130


git-svn-id: http://core.svn.wordpress.org/trunk@34098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-14 21:47:25 +00:00
Scott Taylor
b1bc8a6522 More comment functions can accept a full object instead of comment_ID to reduce cache/db lookups. 
See ##33638.


Built from https://develop.svn.wordpress.org/trunk@34129


git-svn-id: http://core.svn.wordpress.org/trunk@34097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-14 21:40:24 +00:00
Scott Taylor
b2a30103ae In WP_List_Table, make a new public method, ->get_primary_column(), and revert [34101] due to BC issues. 
Fixes #33854.

Built from https://develop.svn.wordpress.org/trunk@34128


git-svn-id: http://core.svn.wordpress.org/trunk@34096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-14 20:29:26 +00:00
Scott Taylor
4d33644373 In WP_Media_List_Table, fetch all pending comment counts at once, instead of for each row in the loop. 
See #11381.

Built from https://develop.svn.wordpress.org/trunk@34127


git-svn-id: http://core.svn.wordpress.org/trunk@34095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-14 19:25:25 +00:00
Dominik Schilling
4af3a3374e Passwords: Deprecate second parameter of wp_new_user_notification(). 
The second parameter `$plaintext_pass` was removed in [33023] and restored as `$notify` in [33620] with a different behavior. If you have a plugin overriding `wp_new_user_notification()` which hasn't been updated you would get a notification with your username and the password "both".
To prevent this the second parameter is now deprecated and reintroduced as the third parameter.

Adds unit tests.

Props kraftbj, adamsilverstein, welcher, ocean90.
Fixes #33654.

(Don't ask for new pluggables kthxbye)
Built from https://develop.svn.wordpress.org/trunk@34116


git-svn-id: http://core.svn.wordpress.org/trunk@34084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-14 12:43:26 +00:00
Scott Taylor
ecc4106ed1 Add an argument to parent_dropdown(), $post, to allow it to be called for an arbitrary post. 
Fixes #23162.

Built from https://develop.svn.wordpress.org/trunk@34111


git-svn-id: http://core.svn.wordpress.org/trunk@34079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-14 03:20:25 +00:00
Scott Taylor
ae6a3aee7f Make WP_List_Table::get_primary_column_name() public in list table classes that have it. 
Fixes #33854.

Built from https://develop.svn.wordpress.org/trunk@34101


git-svn-id: http://core.svn.wordpress.org/trunk@34069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-14 01:12:25 +00:00
Helen Hou-Sandí
7f772bdaff Comments: Fix inline edit/reply on small screens. 
props ocean90, SergeyBiryukov.
fixes #33596.

Built from https://develop.svn.wordpress.org/trunk@34094


git-svn-id: http://core.svn.wordpress.org/trunk@34062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-13 12:47:27 +00:00
Weston Ruter
bd801ae5db Customize: Remove redundant aria-label attributes. 
Adds an `$options` array argument to `WP_Screen::render_screen_options()` to allow the `div#screen-options-wrap` element to be omitted when `wrap` value is `false`.

Props afercia, westonruter.
Fixes #33182.

Built from https://develop.svn.wordpress.org/trunk@34093


git-svn-id: http://core.svn.wordpress.org/trunk@34061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-13 06:16:26 +00:00
Scott Taylor
8591f94b0a WP_Posts_List_Table: there are a cadre of edit.php URLs that are generated by string-building instead of using our handy functions. Create a helper method, ->get_edit_link() that standardizes the generation and escaping of these URLs. 
Props BdN3504 for the initial patch on the ticket.
Fixes #32376.

Built from https://develop.svn.wordpress.org/trunk@34084


git-svn-id: http://core.svn.wordpress.org/trunk@34052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-12 17:13:25 +00:00
Scott Taylor
281faeb69d After [34076], fix the logic for post_status in months dropdown. 
See #21015.

Built from https://develop.svn.wordpress.org/trunk@34077


git-svn-id: http://core.svn.wordpress.org/trunk@34045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-12 08:19:24 +00:00
Scott Taylor
eb230b5424 List Tables: don't render "extra tablenav" if there are no posts. This includes Bulk Actions, Dates Dropdown, Category Dropdowns, Pagination. 
Also ensure that the Months dropdown, when it is shown, shows months from the proper set of posts.

Props egower, CoenJacobs, MikeHansenMe, mehulkaklotar.
Fixes #33824, #21015, #21856.

Built from https://develop.svn.wordpress.org/trunk@34076


git-svn-id: http://core.svn.wordpress.org/trunk@34044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-12 08:13:24 +00:00
Scott Taylor
ed83979728 AJAX Reply to Comment: check the edit_comment cap when parent comment will be auto-approved. 
Props rachelbaker.
Fixes #23939.

Built from https://develop.svn.wordpress.org/trunk@34074


git-svn-id: http://core.svn.wordpress.org/trunk@34042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-12 07:19:25 +00:00
Scott Taylor
821939d6d1 Quick Edit: fix an ID attribute name collision by renaming one of the author fields author-name. 
Props afercia.
Fixes #33770.

Built from https://develop.svn.wordpress.org/trunk@34070


git-svn-id: http://core.svn.wordpress.org/trunk@34038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-12 02:35:25 +00:00
Scott Taylor
b453af5718 When clicking "Show More Comments" in the Comments meta box on the Edit Post screen, change the click behavior to call a new class method on commentsBox, ->load(), that resets st (cool name) to the number of visible <tr>s before calling ->get(). This will account for spam'd and trash'd comments when returning comments at the proper offset. 
Props utkarshpatel.
Fixes #33829.

Built from https://develop.svn.wordpress.org/trunk@34069


git-svn-id: http://core.svn.wordpress.org/trunk@34037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-12 02:28:26 +00:00
Scott Taylor
cd7c0f0b0d Introduce wp_validate_action( $action = '' ), a helper function that checks $_REQUEST for action and returns it, or empty string if not present. If $action is passed, it checks to make sure they match before returning it, or an empty string. Strings are always returned to avoid returning multiple types. 
Implementing this removes 27 uses of direct superglobal access in the admin.

For more reading:
https://codeclimate.com/github/WordPress/WordPress/wp-admin/edit-comments.php

See #33837.

Built from https://develop.svn.wordpress.org/trunk@34059


git-svn-id: http://core.svn.wordpress.org/trunk@34027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 21:08:26 +00:00
Scott Taylor
58c3c30e8d After [33961], pass $comment to comment_class() where possible to avoid extra cache/db lookups. 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@34040


git-svn-id: http://core.svn.wordpress.org/trunk@34008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 06:12:24 +00:00
Scott Taylor
4465a83b95 After [34015], handle orphaned comments in the Dashboard comments widget. Pass full $comment versus just passing the comment ID when possible. 
See #33710.

Built from https://develop.svn.wordpress.org/trunk@34038


git-svn-id: http://core.svn.wordpress.org/trunk@34006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 05:56:24 +00:00
Scott Taylor
b9bbdabfe7 Create a new file, wp-admin/includes/noop.php, which loads all of the noop functions for load-script|styles.php and is only loaded by those files. DRYs in the process. 
See #33813.

Built from https://develop.svn.wordpress.org/trunk@34037


git-svn-id: http://core.svn.wordpress.org/trunk@34005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 05:04:23 +00:00
Scott Taylor
db9c5c81f5 Move ad hoc functions from wp-admin/credits.php to wp-admin/includes/credits.php, which is only included by the former. 
See #33813.

Built from https://develop.svn.wordpress.org/trunk@34036


git-svn-id: http://core.svn.wordpress.org/trunk@34004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 04:55:26 +00:00
Boone Gorges
39fb7992a9 Require numeric IDs in user deletion functions. 
`wp_delete_user()` and `wpmu_delete_user()` both require an `$id` parameter.
Previously, the functions did not verify that the value passed was, in fact,
a number. As such, passing an object or any other entity that would be cast
to int `1` would result in user 1 being deleted. We fix this by enforcing
the requirement that `$id` be numeric.

Props dipesh.kakadiya, utkarshpatel, juliobox.
Fixes #33800.
Built from https://develop.svn.wordpress.org/trunk@34034


git-svn-id: http://core.svn.wordpress.org/trunk@34002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 02:25:23 +00:00
Gary Pendergast
0d85038ce6 Schema: Increase the length of wp_options.option_name. 
It's pretty easy to run over the `option_name` length, which causes undefined behaviour when inserting and retrieving options. Increasing the length from `VARCHAR(64)` to `VARCHAR(191)` significantly reduces the risk of this occurring.

Because `option_name` has a `UNIQUE` index, we can only increase it to 191 characters, rather than 255. The index can only use a prefix of 191 characters, so will incorrectly restrict long different strings that have the same prefix, if we make the column longer.

Props scribu, OriginalEXE, khromov, MikeHansenMe, netweb, pento.

Fixes #13310.


Built from https://develop.svn.wordpress.org/trunk@34030


git-svn-id: http://core.svn.wordpress.org/trunk@33999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 01:26:24 +00:00
Scott Taylor
5918b30cdd Move network_settings_add_js() from wp-admin/network/settings.php to wp-admin/includes/ms.php. 
See #33813.

Built from https://develop.svn.wordpress.org/trunk@34026


git-svn-id: http://core.svn.wordpress.org/trunk@33995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 22:24:24 +00:00
Scott Taylor
2d2e3c911e Move confirm_delete_users() from wp-admin/network/users.php to wp-admin/includes/ms.php. 
See #33813.

Built from https://develop.svn.wordpress.org/trunk@34025


git-svn-id: http://core.svn.wordpress.org/trunk@33994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 22:23:46 +00:00
Scott Taylor
bd0a6bbf8c Create wp-admin/includes/network.php via svn cp and only load it in wp-admin/network.php. Move the functions there. 
See #33813.

Built from https://develop.svn.wordpress.org/trunk@34023


git-svn-id: http://core.svn.wordpress.org/trunk@33992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 22:01:24 +00:00
Scott Taylor
1d68ccec25 Move ad hoc Options functions to wp-admin/includes/options.php: 
* Move `options_discussion_add_js()` from `wp-admin/options-discussion.php`
* Move `options_general_add_js()` from `wp-admin/options-general.php`
* Move `options_permalink_add_js()` from `wp-admin/options-permalink.php`
* Move `options_reading_add_js()` from `wp-admin/options-reading.php`
* Move `options_reading_blog_charset()` from `wp-admin/options-reading.php`

See #33813.

Built from https://develop.svn.wordpress.org/trunk@34022


git-svn-id: http://core.svn.wordpress.org/trunk@33991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 21:45:24 +00:00
Scott Taylor
a40e30e7f4 Move 2 ad hoc user admin functions: 
* Move `use_ssl_preference()` from `wp-admin/user-edit.php` to `wp-admin/includes/user.php`.
* Move `admin_created_user_email()` from `wp-admin/user-new.php` to `wp-admin/includes/user.php`.

See #33813.

Built from https://develop.svn.wordpress.org/trunk@34021


git-svn-id: http://core.svn.wordpress.org/trunk@33990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 21:33:33 +00:00
Scott Taylor
503aa8b76d Move redirect_post() from wp-admin/post.php to wp-admin/includes/post.php. 
See #33813.

Built from https://develop.svn.wordpress.org/trunk@34020


git-svn-id: http://core.svn.wordpress.org/trunk@33989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 21:31:24 +00:00
Scott Taylor
f0b95b7bcc Move comment_footer_die() from wp-admin/comment.php to wp-admin/includes/comment.php. 
See #33813.

Built from https://develop.svn.wordpress.org/trunk@34019


git-svn-id: http://core.svn.wordpress.org/trunk@33988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 21:29:24 +00:00
Scott Taylor
a1d949f361 Move plugin_sandbox_scrape() from wp-admin/plugins.php to wp-admin/includes/plugin.php. 
See #33813.

Built from https://develop.svn.wordpress.org/trunk@34018


git-svn-id: http://core.svn.wordpress.org/trunk@33987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 21:24:24 +00:00
Scott Taylor
f8d7a43920 Move wp_widgets_access_body_class() (a hook callback) from wp-admin/widgets.php to wp-admin/includes/widgets.php. 
See #33813.

Built from https://develop.svn.wordpress.org/trunk@34017


git-svn-id: http://core.svn.wordpress.org/trunk@33986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 21:22:23 +00:00
Scott Taylor
98acab10ea Comments/PHP Notices: check that a parent comment exists before displaying an orphan's link to it in the admin. 
Props rachelbaker.
Fixes #33710.

Built from https://develop.svn.wordpress.org/trunk@34015


git-svn-id: http://core.svn.wordpress.org/trunk@33984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 20:51:23 +00:00
Scott Taylor
8cd584e6ed In wp_generate_attachment_metadata(), also pass $metadata to the intermediate_image_sizes_advanced filter. 
Props amereservant, wonderboymusic.
Fixes #23401.

Built from https://develop.svn.wordpress.org/trunk@34007


git-svn-id: http://core.svn.wordpress.org/trunk@33976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 18:04:24 +00:00
Scott Taylor
6e22d94488 Add a "View" row action for approved comments on the Dashboard screen, remove the link labeled #. 
Props rachelbaker, zeo.
Fixes #18885. 

Built from https://develop.svn.wordpress.org/trunk@34006


git-svn-id: http://core.svn.wordpress.org/trunk@33975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 17:49:24 +00:00
Scott Taylor
527b5b1405 In WP_Posts_List_Table::column_date(), the order of status and time should be switched. It doesn't make sense for phrases like "Last Modified" to occur AFTER the date. Should be before. 
Props johnbillion, wonderboymusic.
Fixes #18641. 

Built from https://develop.svn.wordpress.org/trunk@34005


git-svn-id: http://core.svn.wordpress.org/trunk@33974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 17:43:24 +00:00
Scott Taylor
52498a8546 In wp_media_upload_handler(), replace a lingering instance of media_upload_gallery() with wp_iframe(...) 
Props jeffstieler, antpb.
Fixes #17812. 

Built from https://develop.svn.wordpress.org/trunk@34003


git-svn-id: http://core.svn.wordpress.org/trunk@33972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 17:24:23 +00:00
Scott Taylor
49b8ccec79 When deleting via User List Table, don't prompt for re-attribution if the user(s) do(es) not have any posts. 
Props rajnikmit, wojtek.szkutnik, benjmay, wonderboymusic.
Fixes #6405. 

Built from https://develop.svn.wordpress.org/trunk@34000


git-svn-id: http://core.svn.wordpress.org/trunk@33969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 16:47:24 +00:00
Sergey Biryukov
f9e7fb306c Merge two similar strings. 
Props dipesh.kakadiya.
Fixes #33777.
Built from https://develop.svn.wordpress.org/trunk@33998


git-svn-id: http://core.svn.wordpress.org/trunk@33967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 10:59:27 +00:00
Scott Taylor
52516a68ab After the global churn in [33964], also set $post to null at the end of WP_Comments_List_Table::single_row() to ensure that an orphaned comment doesn't inherit the previous row's $post context. 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@33986


git-svn-id: http://core.svn.wordpress.org/trunk@33955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 03:12:23 +00:00
Scott Taylor
2c21d12232 Implement a priority system for Help Tabs to add them at specific positions. 
Adds unit tests.

Props swissspidy.
Fixes #19828.

Built from https://develop.svn.wordpress.org/trunk@33985


git-svn-id: http://core.svn.wordpress.org/trunk@33954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 01:27:23 +00:00
Scott Taylor
b8c37073d8 Add @access docs to class-wp-filesystem-* files. 
Props wenthemes.
Fixes #33725.

Built from https://develop.svn.wordpress.org/trunk@33984


git-svn-id: http://core.svn.wordpress.org/trunk@33953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 01:21:24 +00:00
Drew Jaynes
55f3b892fb Docs: Add a changelog entry to the DocBlock for touch_time() to mention the shift from accessing the global $comment to using get_comment(). 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@33979


git-svn-id: http://core.svn.wordpress.org/trunk@33948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 15:48:25 +00:00
Scott Taylor
02ae926dfd Round 2 of: We should use ellipses &hellip; / … instead of three dots/periods ... e.g Loading… not Loading... 
Props yoavf.
Fixes #32875.

Built from https://develop.svn.wordpress.org/trunk@33970


git-svn-id: http://core.svn.wordpress.org/trunk@33939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 04:39:25 +00:00
Scott Taylor
246f2a6bd9 Use get_comment() instead of a global in touch_time(). 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@33965


git-svn-id: http://core.svn.wordpress.org/trunk@33934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 03:05:24 +00:00
Scott Taylor
71f955dc84 In WP_Comments_List_Table, favor passing WP_Comment instances instead of $comment_ID to template functions. This allows us to bypass unnecessary cache lookups and simply pass the object through when it is set. 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@33964


git-svn-id: http://core.svn.wordpress.org/trunk@33933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 03:00:24 +00:00
Scott Taylor
d973339738 After [33891], get_comment() returns global $comment if no args are passed and the global is set (after setting the default to null here). This allows us to ditch global comment imports. 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@33963


git-svn-id: http://core.svn.wordpress.org/trunk@33932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 02:51:24 +00:00
Scott Taylor
8879565c0a In WP_User, add @property docs for description, first_name, and last_name. user_firstname and user_lastname only exist for back-compat. 
See #33491.

Built from https://develop.svn.wordpress.org/trunk@33958


git-svn-id: http://core.svn.wordpress.org/trunk@33927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 01:13:24 +00:00
Sergey Biryukov
a3f82f92f1 Widgets: Don't display sidebar description container if it's empty. 
Props paulwilde.
Fixes #32448.
Built from https://develop.svn.wordpress.org/trunk@33934


git-svn-id: http://core.svn.wordpress.org/trunk@33903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-06 07:59:24 +00:00
Sergey Biryukov
c177344508 Merge two permission error strings. 
Props pavelevap.
Fixes #33745.
Built from https://develop.svn.wordpress.org/trunk@33933


git-svn-id: http://core.svn.wordpress.org/trunk@33902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-06 06:42:26 +00:00
Sergey Biryukov
c65f37f892 Correct description for version and current_version parameters in wp_check_browser_version() response. 
Props extendwings.
Fixes #33753.
Built from https://develop.svn.wordpress.org/trunk@33932


git-svn-id: http://core.svn.wordpress.org/trunk@33901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-06 00:17:24 +00:00
Sergey Biryukov
4b5ef333a0 Correct the docblock for wp_list_widget_controls(). 
Props swissspidy.
Fixes #33751.
Built from https://develop.svn.wordpress.org/trunk@33930


git-svn-id: http://core.svn.wordpress.org/trunk@33899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 23:38:25 +00:00
Sergey Biryukov
465e348c12 Fix closing div in wp_print_request_filesystem_credentials_modal(). 
Props trepmal.
Fixes #33737.
Built from https://develop.svn.wordpress.org/trunk@33908


git-svn-id: http://core.svn.wordpress.org/trunk@33877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 15:17:24 +00:00
Boone Gorges
cc5eddda74 Allow wp_terms_checklist() to return markup rather than echoing it. 
Props kevinlangleyjr.
Fixes #33720.
Built from https://develop.svn.wordpress.org/trunk@33904


git-svn-id: http://core.svn.wordpress.org/trunk@33873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-04 21:25:25 +00:00
Scott Taylor
80a20e5c3d Handle more cases (untrailingslashit, HTTPS urls) for sanitizing an author URL for display in the comments list table. 
Props afercia, mehulkaklotar, swissspidy, johnbillion.
Fixes #33291.

Built from https://develop.svn.wordpress.org/trunk@33894


git-svn-id: http://core.svn.wordpress.org/trunk@33863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 23:23:24 +00:00
Scott Taylor
e73ee5ac98 Introduce WP_Comment class to model/strongly-type rows from the comments database table. Inclusion of this class is a pre-req for some more general comment cleanup and sanity. 
* Takes inspiration from `WP_Post` and adds sanity to comment caching. 
* Clarifies when the current global value for `$comment` is returned. The current implementation in `get_comment()` introduces side effects and an occasion stale global value for `$comment` when comment caches are cleaned.
* Strongly-types `@param` docs
* This class is marked `final` for now

Props wonderboymusic, nacin.

See #32619.

Built from https://develop.svn.wordpress.org/trunk@33891


git-svn-id: http://core.svn.wordpress.org/trunk@33860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 18:17:24 +00:00
Sergey Biryukov
771b29455b Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/includes/bookmark.php. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33682. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33887


git-svn-id: http://core.svn.wordpress.org/trunk@33856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 08:59:24 +00:00
John Blackbourn
606b6d15f1 Introduce wp_removable_query_args(), which returns an array of single-use query variables which can be removed from a URL. 
Also applies the function to the return URL when the Customizer is closed.

Fixes #32692
Props swissspidy, Mte90

Built from https://develop.svn.wordpress.org/trunk@33849


git-svn-id: http://core.svn.wordpress.org/trunk@33817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 11:29:23 +00:00
Jeremy Felt
9666aec8d1 Multisite: Remove duplicate span element output from row actions 
Fixes #32961.

Built from https://develop.svn.wordpress.org/trunk@33848


git-svn-id: http://core.svn.wordpress.org/trunk@33816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 21:51:21 +00:00
Sergey Biryukov
43194cea1c Add 'dashboard_secondary_items' filter for the number of secondary link items in the 'WordPress News' dashboard widget. 
props MikeHansenMe, DrewAPicture.
fixes #31434.
Built from https://develop.svn.wordpress.org/trunk@33833


git-svn-id: http://core.svn.wordpress.org/trunk@33801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 21:57:21 +00:00
Sergey Biryukov
a53d6b471f Add 'update_right_now_text' filter for the text displayed in the 'At a Glance' dashboard widget. 
props obenland.
fixes #33355.
Built from https://develop.svn.wordpress.org/trunk@33832


git-svn-id: http://core.svn.wordpress.org/trunk@33800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 21:45:21 +00:00
Drew Jaynes
375d30f699 Docs: Add a duplicate filter comment to the comment_email filter call in WP_Comments_List_Table, introduced in [33829]. 
See #11566.

Built from https://develop.svn.wordpress.org/trunk@33830


git-svn-id: http://core.svn.wordpress.org/trunk@33798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 21:22:21 +00:00
Scott Taylor
a5b157ffde Remove the hamburger global'ing from [33828]: since no args are passed to comment_author_email_link(), the internals can be simplified and applied inline. 
See #11566. 

Built from https://develop.svn.wordpress.org/trunk@33829


git-svn-id: http://core.svn.wordpress.org/trunk@33797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 21:09:21 +00:00
Scott Taylor
d0a1a47708 Fix warnings after [33826]. Only only one function call needs a global $comment, we shall hamburger it. 
See #11566. 

Built from https://develop.svn.wordpress.org/trunk@33828


git-svn-id: http://core.svn.wordpress.org/trunk@33796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 20:59:21 +00:00
Scott Taylor
7ab015c5ab WP_Comments_List_Table::single_row() has no reason to set the $comment global. No other methods use it, and we are not in template/loop context. This can mess with the response of get_comment() elsewhere, since get_comment() internally bypasses the cache/db when a global is set. 
See #11566. 

Built from https://develop.svn.wordpress.org/trunk@33826


git-svn-id: http://core.svn.wordpress.org/trunk@33794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 20:42:21 +00:00
Sergey Biryukov
8b1fe986c3 Use wp_html_excerpt() to properly cut comment author URL for display on Comments screen. 
props brettz95, solarissmoke.
fixes #15659.
Built from https://develop.svn.wordpress.org/trunk@33825


git-svn-id: http://core.svn.wordpress.org/trunk@33793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 20:41:21 +00:00
Sergey Biryukov
5a97ff5206 Bump H3 headings to H2 on Themes screen for better accessibility. 
props joehills.
fixes #33560.
Built from https://develop.svn.wordpress.org/trunk@33820


git-svn-id: http://core.svn.wordpress.org/trunk@33788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 03:51:21 +00:00
Scott Taylor
db11b48627 Favor using the consistent and agnostic string 'Attach' over 'Attach to a post' in the media list table. 
Props pavelevap.
Fixes #33515.

Built from https://develop.svn.wordpress.org/trunk@33810


git-svn-id: http://core.svn.wordpress.org/trunk@33778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-30 03:10:21 +00:00
John Blackbourn
6ee45a9606 Bring network admin user searching to parity with single site user searching by wrapping search terms in asterisks. This means that searches don't require an exact match and therefore significantly reduces friction when searching for users on the network admin screens. 
Fixes #32913

Built from https://develop.svn.wordpress.org/trunk@33801


git-svn-id: http://core.svn.wordpress.org/trunk@33769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-29 00:19:24 +00:00
Sergey Biryukov
d10fc64ab5 Network Admin: Hide the bulk actions checkbox for super admins. 
See [25125] for hiding the checkbox for the main site in Sites table.

props bordoni.
fixes #28529.
Built from https://develop.svn.wordpress.org/trunk@33777


git-svn-id: http://core.svn.wordpress.org/trunk@33745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 03:49:21 +00:00
Helen Hou-Sandí
1f500055a6 Drop the hyphen from e-mail and standardize on email. 
The AP Stylebook changed this in 2011, and we're woefully inconsistent, so let's go with the standard.

props morganestes, voldemortensen, niallkennedy (for patching on the previous AP style).
fixes #26156.

Built from https://develop.svn.wordpress.org/trunk@33774


git-svn-id: http://core.svn.wordpress.org/trunk@33742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 03:17:21 +00:00
John Blackbourn
6d7aeeac03 Don't change the View Post button permalink in the sample permalink HTML when updating the slug on a published or future post. 
Fixes #32954
Props boonebgorges, johnbillion

Built from https://develop.svn.wordpress.org/trunk@33773


git-svn-id: http://core.svn.wordpress.org/trunk@33741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-27 20:57:22 +00:00
Sergey Biryukov
4ae4d94dbb Remove wp-includes/comment-functions.php from the $_old_files array. See [33750]. 
props rachelbaker.
fixes #33569.
Built from https://develop.svn.wordpress.org/trunk@33772


git-svn-id: http://core.svn.wordpress.org/trunk@33740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-27 20:40:24 +00:00
John Blackbourn
b9ec4136d9 Remove error from the query variables when cleaning up a URL in wp_admin_canonical_url(). 
Fixes #32847

Built from https://develop.svn.wordpress.org/trunk@33770


git-svn-id: http://core.svn.wordpress.org/trunk@33738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-27 17:26:21 +00:00
John Blackbourn
a60d143f7b Correct the hook docs for the user_profile_update_errors action. 
Fixes #33537
Props yamchhetri

Built from https://develop.svn.wordpress.org/trunk@33769


git-svn-id: http://core.svn.wordpress.org/trunk@33737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-27 17:16:21 +00:00
Sergey Biryukov
fc9961ca22 Make post meta box toggles accessible. 
props joedolson.
fixes #33544.
Built from https://develop.svn.wordpress.org/trunk@33762


git-svn-id: http://core.svn.wordpress.org/trunk@33730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-26 15:23:24 +00:00
Scott Taylor
93f745fd9b In WP_Users_List_Table::single_row(), $actions is not always set before being used. 
See #33491.

Built from https://develop.svn.wordpress.org/trunk@33735


git-svn-id: http://core.svn.wordpress.org/trunk@33703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 20:38:20 +00:00
Scott Taylor
ef87172270 foreach is a statement, not a function. 
See #33491.

Built from https://develop.svn.wordpress.org/trunk@33734


git-svn-id: http://core.svn.wordpress.org/trunk@33702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 20:28:22 +00:00
Scott Taylor
c2a0336d22 Instead of [33713], allow WP_Posts_List_Table::get_bulk_actions() to check edit_posts AND delete_posts. 
Props DeBAAT.
Fixes #29789.

Built from https://develop.svn.wordpress.org/trunk@33733


git-svn-id: http://core.svn.wordpress.org/trunk@33701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 20:12:22 +00:00
Drew Jaynes
e8283a6f88 Docs: The type for the $t_time parameter in the post_date_column_time filter docs should be string, not array. 
Props jjeaton
Fixes #33540.

Built from https://develop.svn.wordpress.org/trunk@33731


git-svn-id: http://core.svn.wordpress.org/trunk@33699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 17:15:21 +00:00
Scott Taylor
767dd35a47 Media: 
When inserting an image into a post, the values in `wp.media.controller.Library` should not default to linking the image when no user settings are present.

The default display setting value for `link` is now `none`. User settings persist and will override or confirm this value based on user actions.

Props liljimmi, janhenckens, eherman24, wonderboymusic.
Fixes #31467.

Built from https://develop.svn.wordpress.org/trunk@33729


git-svn-id: http://core.svn.wordpress.org/trunk@33697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 12:13:23 +00:00
Dion Hulse
4f8ce1c232 Term Splitting: Switch to a faster cron unschedule process to benefit sites with thousands of affected jobs. Fix the cron hook name in the failsafe rescheduler. 
Props Otto42, dd32, peterwilsoncc
See #33423

Built from https://develop.svn.wordpress.org/trunk@33727


git-svn-id: http://core.svn.wordpress.org/trunk@33695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 04:32:21 +00:00
Scott Taylor
b1c00f2653 Posts List Table: 
Don't show bulk actions if the user can't edit posts.

Props DrewAPicture.
Fixes #29789.

Built from https://develop.svn.wordpress.org/trunk@33713


git-svn-id: http://core.svn.wordpress.org/trunk@33680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-23 16:28:28 +00:00
Scott Taylor
0fa7f817c4 In wp_ajax_add_meta(), do not juggle the value of $_POST and alter it directly. This was done so that edit_post() could pull $_POST out of the air by-reference and alter it (equally as bad). edit_post() accepts a $post_data array. Do that instead. 
See #33491.

Built from https://develop.svn.wordpress.org/trunk@33697


git-svn-id: http://core.svn.wordpress.org/trunk@33664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 18:13:24 +00:00
Scott Taylor
e9305edbce When createing "Sample Page" on install, comments should be closed. 
Props macmanx. 
Fixes #33490.

Built from https://develop.svn.wordpress.org/trunk@33693


git-svn-id: http://core.svn.wordpress.org/trunk@33660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 17:42:25 +00:00
Scott Taylor
fa2d0a2d55 Comment List Tables: 
* Toggle visibility of pending bubble when a comment is dynamically moderated
* Add a CSS class to the pending bubble to hide it / remove to show it

See #11200.

Built from https://develop.svn.wordpress.org/trunk@33692


git-svn-id: http://core.svn.wordpress.org/trunk@33659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 17:26:26 +00:00
Drew Jaynes
54b2e39fdd Docs: Add a changelog entry for the $post_type parameter added to the restrict_manage_posts hook in [33644]. 
Props pavelevap
Fixes #17891.

Built from https://develop.svn.wordpress.org/trunk@33691


git-svn-id: http://core.svn.wordpress.org/trunk@33658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 16:12:25 +00:00
Helen Hou-Sandí
514caf0120 List tables: Allow filtering of hidden and default hidden columns. 
Similar to `get_hidden_meta_boxes()`, there are now filters named `default_hidden_columns` and `hidden_columns`.

props Compute, MikeHansenMe, chriscct7.
fixes #32499.

Built from https://develop.svn.wordpress.org/trunk@33689


git-svn-id: http://core.svn.wordpress.org/trunk@33656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 15:32:29 +00:00
Dion Hulse
09da29102b WP_Filesystem: SSH2 handler: Remove support for is_writable() via SSH, it turns out PHP doesn't verify the writability via SFTP and instead uses a comparison based on the current php system process user instead of the ssh user. 
This fixes the 'The update cannot be installed because we will be unable to copy some files.' error encountered during updates by skipping the write test completely.

Props jobst.
Fixes #33480 for trunk

Built from https://develop.svn.wordpress.org/trunk@33688


git-svn-id: http://core.svn.wordpress.org/trunk@33655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 11:43:25 +00:00
Drew Jaynes
93009543bc Docs: Fix some minor inline documentation syntax issues in the hook docs for the post_edit_category_parent_dropdown_args filter, introduced in [33682]. 
See #32246. See #33026.

Built from https://develop.svn.wordpress.org/trunk@33686


git-svn-id: http://core.svn.wordpress.org/trunk@33653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 04:54:26 +00:00
Drew Jaynes
416df545ba Docs: Fix a variety of inline documentation syntax issues and add some strategic spacing. 
Fixes #29086.

Built from https://develop.svn.wordpress.org/trunk@33685


git-svn-id: http://core.svn.wordpress.org/trunk@33652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 04:13:24 +00:00
Drew Jaynes
3bb87e08e4 Docs: Add missing @access tags to properties and methods in wp-admin/includes/class-wp-upgrader. 
See #29086.

Built from https://develop.svn.wordpress.org/trunk@33684


git-svn-id: http://core.svn.wordpress.org/trunk@33651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 04:05:25 +00:00
Drew Jaynes
73d6dec8eb Docs: Correct a typo in the summary for the Theme_Upgrader->bulk property. 
Also adds a couple of missing `@access` tags.

Props kraftbj
See #29086.

Built from https://develop.svn.wordpress.org/trunk@33683


git-svn-id: http://core.svn.wordpress.org/trunk@33650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 03:15:25 +00:00
Boone Gorges
52614b491a Filter the arguments passed to wp_dropdown_categories() in the Categories post edit metabox. 
The new 'post_edit_category_parent_dropdown_args' provides parity with other
places in wp-admin where `wp_dropdown_categories()` args are filtered, such as
'taxonomy_parent_dropdown_args'.

Props theMikeD.
Fixes #33026.
Built from https://develop.svn.wordpress.org/trunk@33682


git-svn-id: http://core.svn.wordpress.org/trunk@33649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 01:28:25 +00:00
Drew Jaynes
c8638a285a Docs: Standardize @deprecated tag formatting for deprecated functions in wp-admin/includes/ms-deprecated.php. 
Props Alphawolf for the initial patch
Props DrewAPicture

See #28806.

Built from https://develop.svn.wordpress.org/trunk@33675


git-svn-id: http://core.svn.wordpress.org/trunk@33642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 22:26:24 +00:00
Drew Jaynes
bac6e69b3c Docs: Standardize @deprecated tag formatting and add missing DocBlocks to deprecated functions in wp-admin/includes/deprecated.php. 
Opted not to use the multi-function DocBlock syntax in the name of not taking shortcuts in documentation for the sake of brevity.

Props Alphawolf for the initial patch.
See #28806

Built from https://develop.svn.wordpress.org/trunk@33671


git-svn-id: http://core.svn.wordpress.org/trunk@33638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 21:23:25 +00:00
Drew Jaynes
c36c4efea6 Docs: Add a missing summary to the DocBlock for wp_media_upload_handler(). 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@33670


git-svn-id: http://core.svn.wordpress.org/trunk@33637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 21:01:25 +00:00
Drew Jaynes
89c39e7eab Docs: Clarify the different return conditions in the DocBlock for WP_List_Table->handle_row_actions(). 
This clarification follows the introduction of primary columns in 4.3. See #33313.

Props morganestes.
Fixes #33436.

Built from https://develop.svn.wordpress.org/trunk@33668


git-svn-id: http://core.svn.wordpress.org/trunk@33635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 20:22:25 +00:00
Scott Taylor
4254f22c2d In WP_Posts_List_Table::inline_edit(), check that $post_formats[0] is an array before traversing. 
Props DrewAPicture.
Fixes #33025.


Built from https://develop.svn.wordpress.org/trunk@33667


git-svn-id: http://core.svn.wordpress.org/trunk@33634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 20:19:25 +00:00
Scott Taylor
4694c477d3 Custom Post Types: 
* Introduce `is_post_type_viewable( $post_type_object )`
* Separate the HTML bits from the translatable bits in the `post` messages array in `edit-form-advanced.php`
* Don't show certain UI pieces when a post is not viewable on the front end

When a custom post type item is not viewable on the front end, we don't want to show links to View it (on the front end) all over the admin. We also want to hide the Preview link, et al. We also want our admin messages to not contain said links.

Custom post types with `public_queryable` set to `false` are not viewable on the front end. 
`'page'` is viewable on the front end, but `'page'` is a `_builtin` type, and `public_queryable` is set to `false` when it is registered - see `WP::parse_request()` for when `public_queryable` gets used.

This is confusing, but also somewhat straightforward: to determine if a post type is viewable on the front end, we can check one way for `_builtin => true` and another way for `_builtin => false`:

`$post_type->publicly_queryable || ( $post_type->_builtin && $post_type->public )`

If a post type is `publicly_queryable`, it's viewable. If that value is `false`, it is viewable if it's a `_builtin` type that is also `public`.

I am in search of edge cases, so this shall land.

Props wonderboymusic, DrewAPicture.
See #17609.

Built from https://develop.svn.wordpress.org/trunk@33666


git-svn-id: http://core.svn.wordpress.org/trunk@33633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 19:40:25 +00:00
Scott Taylor
20f6db2b18 Comment List Tables: 
* Ensure that dynamic bubble counts are in sync by `comment_post_ID`
* Scope `:animated` to `#the-comment-list`

See #11200.


Built from https://develop.svn.wordpress.org/trunk@33662


git-svn-id: http://core.svn.wordpress.org/trunk@33629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 16:36:25 +00:00
Scott Taylor
2e2223ae74 Comments List Table: 
* In a view that initially has comments, but they get removed due to user actions: show the `No Items` row instead of bombing out and showing nothing (which looks broken)
* To accomplish this, in `WP_Comments_List_Table::display()`: call `->display_rows_or_placeholder()` instead of `->display()`
* Listen for the end of row `.fadeOut()`s if necessary using jQuery Promises

Fixes #11200.

Built from https://develop.svn.wordpress.org/trunk@33657


git-svn-id: http://core.svn.wordpress.org/trunk@33624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 05:54:25 +00:00
Scott Taylor
df618f3461 Comments List Table: 
* Show count next to "Approved"
* Properly increment/decrement counts when row actions are clicked
* In `_wp_ajax_delete_comment_response()`, return the comment's `status` with the `supplemental` data
* Handle counts properly on each scenario of `undo`

See #11200.

Built from https://develop.svn.wordpress.org/trunk@33655


git-svn-id: http://core.svn.wordpress.org/trunk@33622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 02:51:25 +00:00
Dion Hulse
a32d83586e Upgrades: When upgrading via FTP, use LIST -a to detect if a file exists. 
`LIST` & `NLST` by default on some servers require the `-a` flag to view hidden files (ie. `.maintenance`)
Although we could simply pass the `-a` flag to `NLST`, opting to use `LIST` which we use elsewhere should mean less chance of server incompatibilities.

Props jcroucher.
Fixes #28013.

Built from https://develop.svn.wordpress.org/trunk@33648


git-svn-id: http://core.svn.wordpress.org/trunk@33615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 12:38:25 +00:00
Dion Hulse
25c5d372d3 Term Splitting: Fix a reversal of parameters to wp_schedule_single_event() introduced in [33621]. 
The existing invalid cron entries will not be purged automatically (as the 'timestamp' is never matched) so we do this ourselves.

Props mechter for noticing!
See #30261.
Fixes #33423 for trunk.

Built from https://develop.svn.wordpress.org/trunk@33646


git-svn-id: http://core.svn.wordpress.org/trunk@33613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 11:31:26 +00:00
Dion Hulse
096b2f58fa Fix PHP notice after [33492] when updating themes. 
Props bobbingwide.
See #33208.
Fixes #33427.

Built from https://develop.svn.wordpress.org/trunk@33645


git-svn-id: http://core.svn.wordpress.org/trunk@33612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 10:35:25 +00:00
Scott Taylor
3923017f82 The 'restrict_manage_posts' hook currently fires on the Post and Media list tables, but is passed zero arguments. Pass $post_type. 
Props sunnyratilal, scribu.
Fixes #17891.

Built from https://develop.svn.wordpress.org/trunk@33644


git-svn-id: http://core.svn.wordpress.org/trunk@33611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 06:23:25 +00:00
Scott Taylor
23f62a59da Correct typo in doc block for WP_Filesystem_ftpsockets::rmdir 
Props Toro_Unit.
Fixes #33255.

Built from https://develop.svn.wordpress.org/trunk@33639


git-svn-id: http://core.svn.wordpress.org/trunk@33606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-18 23:33:24 +00:00
Dominik Schilling
96a6f0ac1f Pinking shears. 
Built from https://develop.svn.wordpress.org/trunk@33627


git-svn-id: http://core.svn.wordpress.org/trunk@33594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 21:39:25 +00:00
Dominik Schilling
ce557062f4 Upgrade: Update $_old_files for 4.3. 
fixes #33394.
Built from https://develop.svn.wordpress.org/trunk@33626


git-svn-id: http://core.svn.wordpress.org/trunk@33593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 20:24:26 +00:00
Helen Hou-Sandí
50e42e8a07 List tables: Yet more primary column fallbacks. 
Some custom list tables override enough methods for the column definition fallback to never kick in, so let's ensure that toggling columns only applies when a primary column is defined in some way. We also need to show a toggle button when we can when there are no row actions.

props Chouby, obenland, ocean90.
fixes #33313.

Built from https://develop.svn.wordpress.org/trunk@33623


git-svn-id: http://core.svn.wordpress.org/trunk@33590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 15:38:25 +00:00
Boone Gorges
dba7c50d29 Don't run term-splitting routine on new installations. 
Props pento.
Fixes #30261.
Built from https://develop.svn.wordpress.org/trunk@33621


git-svn-id: http://core.svn.wordpress.org/trunk@33588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 14:29:25 +00:00
Konstantin Obenland
e6bc6242ad Passwords: Restore second parameter for wp_new_user_notification(). 
After [33023] users would always be notified, this restores previous behavior.

Props markjaquith, ocean90.
Fixes #33358.


Built from https://develop.svn.wordpress.org/trunk@33620


git-svn-id: http://core.svn.wordpress.org/trunk@33587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 14:25:27 +00:00
Boone Gorges
151d27369d Term splitting routine should be run in a separate process, triggered via wp-cron. 
[32814] introduced a routine to split shared terms, which was run during the
regular WP database upgrade. This turned out to be problematic because plugins
are not loaded during the db upgrade (due to `WP_INSTALLING`), with the result
that plugins were not able to hook into the 'split_shared_term' action during
the bulk split. We work around this limitation by moving the term splitting
routine to a separate process, triggered by a wp-cron hook.

Props boonebgorges, Chouby, peterwilsoncc, pento, dd32.
Fixes #30261.
Built from https://develop.svn.wordpress.org/trunk@33615


git-svn-id: http://core.svn.wordpress.org/trunk@33582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-14 03:59:26 +00:00
Dominik Schilling
f74a907eac Capabilities: Fall back to the edit_posts capability for orphaned comments. 
Also avoid PHP notices because of orphaned comments in the comments list table.
Includes unit test.

props pento, dd32.
fixes #33154.
Built from https://develop.svn.wordpress.org/trunk@33614


git-svn-id: http://core.svn.wordpress.org/trunk@33581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-13 22:31:24 +00:00
Andrew Ozz
3bfd096440 Fix paste typos in upgrade.php. 
Props tellyworth. Fixes #33206.
Built from https://develop.svn.wordpress.org/trunk@33609


git-svn-id: http://core.svn.wordpress.org/trunk@33576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-11 23:44:24 +00:00
Dion Hulse
aace7c2c8d Function documentation: Fix a broken docbock introduced with [32642]. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@33601


git-svn-id: http://core.svn.wordpress.org/trunk@33568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-10 10:50:26 +00:00
Dion Hulse
e2b10dad49 Upgrade: Skip the sitecategories table when it doesn't exist (Global Terms is disabled). 
Props nofearinc, obenland, SergeyBiryukov, and pento.
Fixes #33206

Built from https://develop.svn.wordpress.org/trunk@33597


git-svn-id: http://core.svn.wordpress.org/trunk@33564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-09 02:22:26 +00:00
John Blackbourn
6bd6069fc0 Remove all existing internal feature pointers. 
Fixes #33289
Props obenland, ocean90, SergeyBiryukov

Built from https://develop.svn.wordpress.org/trunk@33593


git-svn-id: http://core.svn.wordpress.org/trunk@33560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-07 00:59:24 +00:00
Mark Jaquith
309516a6c1 Move media hooks out of admin-filters.php as sometimes editors are used on the front end. 
fixes #33257
props wonderboymusic
Built from https://develop.svn.wordpress.org/trunk@33590


git-svn-id: http://core.svn.wordpress.org/trunk@33557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-06 20:40:26 +00:00
Dominik Schilling
198cdb1dde Multisite mails: Initialize $current_user before accessing $current_user->user_login. 
props Toro_Unit.
see #31217.
fixes #33254.
Built from https://develop.svn.wordpress.org/trunk@33569


git-svn-id: http://core.svn.wordpress.org/trunk@33536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-04 11:39:25 +00:00
Dominik Schilling
a9b3f12826 Heartbeat: Ensure post locks are released. 
Built from https://develop.svn.wordpress.org/trunk@33542


git-svn-id: http://core.svn.wordpress.org/trunk@33509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-04 04:54:34 +00:00
Dominik Schilling
8b91700d5b Fix PHP notice after [33492]. 
props jesin.
see #33178.
fixes #33208.
Built from https://develop.svn.wordpress.org/trunk@33519


git-svn-id: http://core.svn.wordpress.org/trunk@33486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-30 19:59:25 +00:00
Andrew Ozz
7ace03443a Press This: properly add Open Sans to the editor, using the mce_css filter. 
See #26072. Fixes #33189.
Built from https://develop.svn.wordpress.org/trunk@33497


git-svn-id: http://core.svn.wordpress.org/trunk@33464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-29 19:38:25 +00:00
Dominik Schilling
8679a93f16 Themes: Remove legacy theme preview. 
The pre-3.4 theme previewer doesn't work when using a static front page.
We kept the old theme preview for no-JS and some browsers that were less capable. But since browsers are doing a better job today we don't need to continue fixing/shipping this legacy code. Bye!

fixes #33178.
Built from https://develop.svn.wordpress.org/trunk@33492


git-svn-id: http://core.svn.wordpress.org/trunk@33459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-29 18:36:26 +00:00
Helen Hou-Sandí
7b7ae2ee25 Comments list table: Display that cute lil comment bubble. 
The comments list table suffers from "wall of text" problems, which the two plain text links compounded.

props obenland. fixes #33149.

Built from https://develop.svn.wordpress.org/trunk@33490


git-svn-id: http://core.svn.wordpress.org/trunk@33457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-29 18:08:25 +00:00
Dominik Schilling
dc4c2fa0bf Upgrade: Lowercase the "s" in remove_all_filters(). 
props afragen.
fixes #33173.
Built from https://develop.svn.wordpress.org/trunk@33487


git-svn-id: http://core.svn.wordpress.org/trunk@33454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-29 14:57:25 +00:00
Mark Jaquith
c5719ba15a Make the "using default password" nag more accurate. 
"Easy to remember" isn't necessarily what we want to encourage.

fixes #33168
props arjunskumar
Built from https://develop.svn.wordpress.org/trunk@33485


git-svn-id: http://core.svn.wordpress.org/trunk@33452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-29 14:06:25 +00:00
Andrew Ozz
fa25fe82ef Fix updating of nonces on the Edit Post screen after the log in expires and the user logs in again. 
Props iseulde, azaozz. Fixes #33098.
Built from https://develop.svn.wordpress.org/trunk@33468


git-svn-id: http://core.svn.wordpress.org/trunk@33435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-28 22:07:25 +00:00
Mark Jaquith
4965581097 Don't blindly trust the output of glob() to be an array. 
props kitchin
fixes #33093
Built from https://develop.svn.wordpress.org/trunk@33447


git-svn-id: http://core.svn.wordpress.org/trunk@33414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-27 18:05:24 +00:00
Konstantin Obenland
0b0c456a44 Site Icon: Minor cleanup for WP_Site_Icon after [33329]. 
Built from https://develop.svn.wordpress.org/trunk@33446


git-svn-id: http://core.svn.wordpress.org/trunk@33413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-27 16:09:25 +00:00
Sergey Biryukov
48a1c86245 Comment string tweaks: 
* Merge two strings about an invalid comment ID.
* Add missing context to 'Mark as Spam' string.
* Merge two 'In Response To' strings, replace redundant context with a translator comment.

props pavelevap.
fixes #32334.
Built from https://develop.svn.wordpress.org/trunk@33436


git-svn-id: http://core.svn.wordpress.org/trunk@33403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-26 23:36:24 +00:00
Sergey Biryukov
fbd8a43b5d Merge two duplicate strings. 
props pavelevap.
fixes #31730.
Built from https://develop.svn.wordpress.org/trunk@33433


git-svn-id: http://core.svn.wordpress.org/trunk@33400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-26 23:04:25 +00:00
Sergey Biryukov
67618d5cc0 Merge similar strings for plugin update permissions. 
props pavelevap.
fixes #32388.
Built from https://develop.svn.wordpress.org/trunk@33432


git-svn-id: http://core.svn.wordpress.org/trunk@33399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-26 23:01:25 +00:00
Dion Hulse
765714ac0b Switch to a more performant query in meta_form(). 
Props lumaraf, swissspidy, rarylson, pento
Fixes #24498

Built from https://develop.svn.wordpress.org/trunk@33390


git-svn-id: http://core.svn.wordpress.org/trunk@33358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-23 05:17:25 +00:00
Gary Pendergast
fe5a844be5 Capabilities: When creating an auto-draft, ensure that the current user still has permission to do so. 
Built from https://develop.svn.wordpress.org/trunk@33357


git-svn-id: http://core.svn.wordpress.org/trunk@33329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-22 04:02:25 +00:00
Konstantin Obenland
0f61e187b6 Site Icon: Create custom sizes for images that don't need cropping. 
This will duplicate an image that doesn't need cropping once and will skip
creating new images and custom sizes if the selected image has the `site-icon`
context.

Fixes #33011.

Built from https://develop.svn.wordpress.org/trunk@33356


git-svn-id: http://core.svn.wordpress.org/trunk@33328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-22 02:30:25 +00:00
Ella Iseulde Van Dorpe
262c1a7e54 Publish box: fix strange date format after change 
Part props tyxla.
Fixes #30716.

Built from https://develop.svn.wordpress.org/trunk@33340


git-svn-id: http://core.svn.wordpress.org/trunk@33312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-21 11:40:25 +00:00
Konstantin Obenland
3248497cf3 Site Icon: Add crop preview to the media modal. 
* Monkey patches imgAreaSelect library to support touch events.
* Removes Settings version of Site Icon since it would have been the same flow.
* Removes default value for Customizer setting - there is no default favicon.

Fixes #16434.



Built from https://develop.svn.wordpress.org/trunk@33329


git-svn-id: http://core.svn.wordpress.org/trunk@33301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-20 15:57:25 +00:00
Scott Taylor
432f9891f7 Ensure that private posts cannot be made sticky via Quick Edit. 
DRY the logic for stickies in `wp_xmlrpc_server` by introducing `->_toggle_sticky()`.

Props wonderboymusic, obenland, chriscct7.
Fixes #20662.

Built from https://develop.svn.wordpress.org/trunk@33325


git-svn-id: http://core.svn.wordpress.org/trunk@33297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-19 18:09:25 +00:00
Ella Iseulde Van Dorpe
dac985cdc4 Editor: Add Media should be a button 
Props afercia.
Fixes #32969.

Built from https://develop.svn.wordpress.org/trunk@33298


git-svn-id: http://core.svn.wordpress.org/trunk@33270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-16 19:38:23 +00:00
Konstantin Obenland
2883bbbb68 Customize: Provide a default way to save cropped images. 
Allows plugins and themes to use `WP_Customize_Cropped_Image_Control` without
having to define their own way of saving the cropped image.

Props celloexpressions for initial patch.
Fixes #29211.


Built from https://develop.svn.wordpress.org/trunk@33280


git-svn-id: http://core.svn.wordpress.org/trunk@33252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-15 19:54:25 +00:00
Scott Taylor
4d34e37311 List Tables: 
* In `->handle_row_actions()`, bail immediately if `$primary` and `$column_name` do not match. Saves us a nesting level and avoids declaring code that is unusable.
* In `WP_List_Table::single_row_columns()`, allow `_column_{$name}` to be called dynamically by core to avoid having to override the entirety of `->single_row_columns()` in `WP_MS_Users_List_Table` and `WP_Posts_List_Table`
* In `WP_MS_Sites_List_Table`, `id` is not a column.

Props wonderboymusic, paulwilde.
Fixes #29881.

Built from https://develop.svn.wordpress.org/trunk@33270


git-svn-id: http://core.svn.wordpress.org/trunk@33242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-14 17:47:24 +00:00
Konstantin Obenland
4f94d3a969 Media: Don't indent action links if there is no media icon. 
See #32254.


Built from https://develop.svn.wordpress.org/trunk@33269


git-svn-id: http://core.svn.wordpress.org/trunk@33241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-14 17:46:24 +00:00
Konstantin Obenland
2a0ddf8523 Media: Reduce link noise between icons and titles in list view. 
Props afercia.
Fixes #32254.


Built from https://develop.svn.wordpress.org/trunk@33268


git-svn-id: http://core.svn.wordpress.org/trunk@33240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-14 17:24:26 +00:00
Helen Hou-Sandí
4182df24f8 List tables: Even more robust fallback for the primary column. 
Since `WP_List_Table::get_default_primary_column()` can be overridden in a subclass and columns can be further filtered, it is possible to end up with a primary column that no longer exists. This is particularly evident in list tables for custom post types that have been altered via filter.

props ocean90.
fixes #32996.

Built from https://develop.svn.wordpress.org/trunk@33266


git-svn-id: http://core.svn.wordpress.org/trunk@33238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-14 16:18:25 +00:00
Konstantin Obenland
542e01162f Media: Remove post_type variable, unused since [32676]. 
Fixes #32948.

Built from https://develop.svn.wordpress.org/trunk@33263


git-svn-id: http://core.svn.wordpress.org/trunk@33235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-14 15:06:25 +00:00
Dion Hulse
43077a6ef8 Updates: When performing an ajax plugin update, rely upon wp_update_plugins() to check the contents of the transient and return early if no request needs to be made. 
This works around a bug where custom update handlers are injecting an update into an empty transient, malforming the transient and causing update failures.
Fixes #32198 for trunk

Built from https://develop.svn.wordpress.org/trunk@33257


git-svn-id: http://core.svn.wordpress.org/trunk@33229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-14 08:01:25 +00:00
Drew Jaynes
e4ecc7e5c4 Fix summaries and add missing @global descriptions to the upgrade_430_fix_comments() and split_all_shared_terms() functions added in 4.3. 
See [33020], [32643]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33212


git-svn-id: http://core.svn.wordpress.org/trunk@33184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 19:56:24 +00:00
Drew Jaynes
f9194e361c Add a description for the dynamic portion of the nav_menu_items_{$post_type_name}_recent filter added in 4.3. 
See [32833]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33211


git-svn-id: http://core.svn.wordpress.org/trunk@33183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 19:51:24 +00:00
Drew Jaynes
2d0721aab9 Fix the summary for the WP_Users_List_Table->get_default_primary_column_name() method added in 4.3. 
See [32644]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33210


git-svn-id: http://core.svn.wordpress.org/trunk@33182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 19:48:25 +00:00
Drew Jaynes
0322d0e89b Fix inline documentation syntax in the WP_Upgrader->clear_destination() method added in 4.3. 
See [32854]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33209


git-svn-id: http://core.svn.wordpress.org/trunk@33181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 19:46:25 +00:00
Drew Jaynes
f9070e11b4 Fix summaries for two methods added to WP_Terms_List_Table in 4.3. 
See [32644]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33207


git-svn-id: http://core.svn.wordpress.org/trunk@33179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 18:22:25 +00:00
Drew Jaynes
d1a3d2e6ea Add missing summaries, @access tags, and some parameter descriptions for methods added to WP_Links_List_Table in 4.3. 
See [32753]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33204


git-svn-id: http://core.svn.wordpress.org/trunk@33176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 18:03:24 +00:00
Konstantin Obenland
2829827c1c Site Icon: Add Android-specific app icon. 
Falling back to Apple app icons is deprecated behavior and will not work
forever. 192px is the recommended size for that icon.

Props kraftbj.
Fixes #32964.


Built from https://develop.svn.wordpress.org/trunk@33202


git-svn-id: http://core.svn.wordpress.org/trunk@33174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 17:58:47 +00:00
Drew Jaynes
5ebb6855b6 Add missing summaries, @access tags, and some parameter descriptions for methods added to WP_MS_Sites_List_Table in 4.3. 
See [32755]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33199


git-svn-id: http://core.svn.wordpress.org/trunk@33171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 17:53:24 +00:00
Drew Jaynes
88229587c0 Improving formatting for various pieces of inline documentation in the new WP_Site_Icon class added in 4.3. 
See [32994]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33198


git-svn-id: http://core.svn.wordpress.org/trunk@33170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 17:51:24 +00:00
Drew Jaynes
b2cc4de9b2 Add missing summaries, @access tags, and some parameter descriptions to methods added to WP_Posts_List_Table in 4.3. 
See [32740]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33197


git-svn-id: http://core.svn.wordpress.org/trunk@33169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 17:49:25 +00:00
Drew Jaynes
9a2261d3bf Fix the DocBlock summary for WP_Plugins_List_Table->get_primary_column_name(), added in 4.3. 
See [32644]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33196


git-svn-id: http://core.svn.wordpress.org/trunk@33168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 17:46:26 +00:00
Drew Jaynes
3361f39479 Add missing summaries and parameter descriptions to new methods added to WP_MS_Users_List_Table in 4.3. 
See [32757]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33195


git-svn-id: http://core.svn.wordpress.org/trunk@33167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 17:43:25 +00:00
Drew Jaynes
5961dbb65b Add missing summaries to new methods added to WP_MS_Themes_List_Table in 4.3. 
See [32756]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33193


git-svn-id: http://core.svn.wordpress.org/trunk@33165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 16:13:26 +00:00
John Blackbourn
f3eba1581c Place the locale inside the md5 hash in the dashboard RSS feed widget transient key to prevent the transient timeout option name becoming longer than the allowed field size. 
Props andg
Fixes #32804

Built from https://develop.svn.wordpress.org/trunk@33192


git-svn-id: http://core.svn.wordpress.org/trunk@33164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 15:32:25 +00:00
John Blackbourn
396cc7b2e4 Correct a parameter name in the docs for wp_insert_category(). 
Built from https://develop.svn.wordpress.org/trunk@33190


git-svn-id: http://core.svn.wordpress.org/trunk@33162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 12:59:25 +00:00
John Blackbourn
1f7a3bc58d Append the current locale to dashboard RSS widget cache keys so they refresh accordingly when the locale is changed. 
Fixes #32804
Props andg

Built from https://develop.svn.wordpress.org/trunk@33183


git-svn-id: http://core.svn.wordpress.org/trunk@33155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-12 22:07:25 +00:00
Konstantin Obenland
13ab10fff7 Site Icon: Improve a11y in Settings. 
Props afercia.
Fixes #32970.


Built from https://develop.svn.wordpress.org/trunk@33180


git-svn-id: http://core.svn.wordpress.org/trunk@33152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-12 19:43:24 +00:00
Drew Jaynes
967b04a7f8 Add missing summaries and @access tags to methods added to WP_Media_List_Table in 4.3. 
See [32754]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33179


git-svn-id: http://core.svn.wordpress.org/trunk@33151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-12 18:34:24 +00:00
Drew Jaynes
d7c887fe5d Fix the summaries for a few methods and hooks added to WP_List_Table in 4.3. 
See [32644]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33178


git-svn-id: http://core.svn.wordpress.org/trunk@33150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-12 18:32:24 +00:00
Drew Jaynes
703d4c259c Fix filter doc vernacular for the new wp_ajax_cropped_attachment_id hook added in 4.3. 
See #32891.

Built from https://develop.svn.wordpress.org/trunk@33176


git-svn-id: http://core.svn.wordpress.org/trunk@33148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-12 18:26:24 +00:00
Jeremy Felt
9f0506e3b2 Add better handling for actions and messaging in MS Sites List Table row actions 
* Simplify URLs used for row actions to remove messaging and site domain/path.
* Use confirmation messaging from a managed list of actions when handling the request.
* Find the site address from the site ID rather than using information passed in the URL.

Fixes #32963.

Built from https://develop.svn.wordpress.org/trunk@33173


git-svn-id: http://core.svn.wordpress.org/trunk@33145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-12 02:36:26 +00:00
Helen Hou-Sandí
6e73f1282e List tables: Better accessibility and design for the comments bubble. 
It is now plain text in the comments list table's "In Response To" column, where it was visually a bit confusing to have the bubble. For other list tables, it now shows a little notification bubble with the number of pending comments. The bubble and notification become plain text in the responsive list table view. It also shows no bubble when there are no comments at all, reducing some of the visual noise.

props picard102, afercia, karinchristen.
fixes #32152.

Built from https://develop.svn.wordpress.org/trunk@33155


git-svn-id: http://core.svn.wordpress.org/trunk@33127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-10 21:44:25 +00:00
Konstantin Obenland
f29e5044cd Site Icon: Add Customizer UI. 
Second part of the Site Icon feature after [32994] introduced it for Settings.

Props celloexpressions.
See #16434.


Built from https://develop.svn.wordpress.org/trunk@33154


git-svn-id: http://core.svn.wordpress.org/trunk@33126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-10 21:33:24 +00:00
Dominik Schilling
75d6c10b01 Customizer: Use a <button> for the collapse sidebar … button. 
props afercia.
fixes #32819.
Built from https://develop.svn.wordpress.org/trunk@33153


git-svn-id: http://core.svn.wordpress.org/trunk@33125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-10 21:22:26 +00:00
Jeremy Felt
0bc0b0c917 Do not allow deletion of a super admin user through wpmu_delete_user(). 
In step with the UI provided by `wp-admin/network/users.php`, super admin privileges must be removed before a user can be deleted through the API.

Props @johnjamesjacoby, @jeremyfelt.
Fixes #32935.

Built from https://develop.svn.wordpress.org/trunk@33143


git-svn-id: http://core.svn.wordpress.org/trunk@33114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-09 16:16:25 +00:00
Andrew Ozz
4cd790906f TinyMCE, Press This: add the wptextpattern plugin to the Press This editor. 
See #31441.
Built from https://develop.svn.wordpress.org/trunk@33128


git-svn-id: http://core.svn.wordpress.org/trunk@33099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-08 19:53:25 +00:00
Helen Hou-Sandí
9c3bc85649 Ensure error messages look like, well, errors. 
props obenland, rachelbaker.
fixes #32475.

Built from https://develop.svn.wordpress.org/trunk@33117


git-svn-id: http://core.svn.wordpress.org/trunk@33088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-07 23:11:24 +00:00
Scott Taylor
0deed4b842 In install_dashboard() (plugin-install, FWIW), make sure slug is populated and degrease the unfortunate whitespace that was present. 
Props tyxla.
Fixes #32889.

Built from https://develop.svn.wordpress.org/trunk@33114


git-svn-id: http://core.svn.wordpress.org/trunk@33085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-07 19:19:24 +00:00
Helen Hou-Sandí
0b046085ae Show row actions on focus for the dashboard comment list. 
see #25408.

Built from https://develop.svn.wordpress.org/trunk@33106


git-svn-id: http://core.svn.wordpress.org/trunk@33077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-07 15:26:24 +00:00
Helen Hou-Sandí
81c2f541b0 List tables: Add a fallback for the primary column. 
Without a primary column defined, nothing shows in the responsive view at all, which is bad.

props mordauk.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@33104


git-svn-id: http://core.svn.wordpress.org/trunk@33075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-07 15:12:27 +00:00
Helen Hou-Sandí
df220685a0 List tables: Account for comments being reused on the post edit screen. 
Adding the `.wp-list-table` class gets us a few responsive goodies for free. And now it won't show a strange button outline.

see #32395.

Built from https://develop.svn.wordpress.org/trunk@33101


git-svn-id: http://core.svn.wordpress.org/trunk@33072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-07 00:09:24 +00:00
Jeremy Felt
c9027b00ba Assign proper active class when showing plugin updates in network admin 
Previously, a plugin would trigger an active class if it was active on the network's main site.

Fixes #32901.

Built from https://develop.svn.wordpress.org/trunk@33100


git-svn-id: http://core.svn.wordpress.org/trunk@33071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-07 00:02:24 +00:00
Jeremy Felt
3faebf40a6 Remove unused $current_site global in MS Sites list table 
Found itself unused after [32719].

See #32434.

Built from https://develop.svn.wordpress.org/trunk@33097


git-svn-id: http://core.svn.wordpress.org/trunk@33068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-06 22:51:25 +00:00
Konstantin Obenland
c9a29b0123 Check for all required caps before (un)sticking a post. 
In cases where a user has the `edit_others_posts` capability but not
`publish_posts`, it was possible for that user to unstick a post after editing,
since the input field was never made available in that context.

Props ericmann, chriscct7.
Fixes #24153.


Built from https://develop.svn.wordpress.org/trunk@33096


git-svn-id: http://core.svn.wordpress.org/trunk@33067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-06 22:41:25 +00:00
Sergey Biryukov
c543f98ee6 Plugins list table: Add an aria-label attribute with the plugin name to plugin action links to provide context for screen reader users. 
props bramd, rianrietveld, afercia.
fixes #26167.
Built from https://develop.svn.wordpress.org/trunk@33087


git-svn-id: http://core.svn.wordpress.org/trunk@33058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-05 15:03:25 +00:00
Konstantin Obenland
664b0373dc Site Icon: Switch to using H1 headings. 
See #31650.

Props afercia.
Fixes #32885.


Built from https://develop.svn.wordpress.org/trunk@33084


git-svn-id: http://core.svn.wordpress.org/trunk@33055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-04 18:49:27 +00:00
Jeremy Felt
767ed1e9b1 Use the full site URL in choose_primary_blog() when a user is a member of only one site. 
Aligns with the output used when a user is a member of multiple sites.

Fixes #32884.

Built from https://develop.svn.wordpress.org/trunk@33081


git-svn-id: http://core.svn.wordpress.org/trunk@33052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-04 04:21:24 +00:00
Sergey Biryukov
b2299463b6 Plugins list table: Use case-insensitive sorting. 
props GaryJ.
fixes #32735.
Built from https://develop.svn.wordpress.org/trunk@33076


git-svn-id: http://core.svn.wordpress.org/trunk@33047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-03 21:53:25 +00:00
Konstantin Obenland
cf22cd7d72 Site Icon: Remove date dropdown from media modal. 
This also allows us to leverage the builtin `suggestedWidth` and
`suggestedHeight` parameters to convey the expected image size.

Props ocean90.
Fixes #32860.


Built from https://develop.svn.wordpress.org/trunk@33075


git-svn-id: http://core.svn.wordpress.org/trunk@33046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-03 21:28:24 +00:00
Dion Hulse
ceaec85751 Press This: Rewrite WP_Press_This::fetch_source_html() to utilise the HTTP API better without the need for a local temporary file. 
This reverts [33061] but keeps it's custom UA string.

See #32864

Built from https://develop.svn.wordpress.org/trunk@33062


git-svn-id: http://core.svn.wordpress.org/trunk@33033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-03 12:01:25 +00:00
Sergey Biryukov
fc8c36eb97 Press This: Set explicit user agent. 
props kraftbj.
fixes #32864.
Built from https://develop.svn.wordpress.org/trunk@33061


git-svn-id: http://core.svn.wordpress.org/trunk@33032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-03 11:17:24 +00:00
Dion Hulse
36de491d68 Don't upgrade global tables to utf8mb4 when wp_should_upgrade_global_tables() says not to. 
Additionally fixes an incorrect conditional in [33057] which would result in the usermeta index being altered twice on Multisite updates.

See #32154

Built from https://develop.svn.wordpress.org/trunk@33058


git-svn-id: http://core.svn.wordpress.org/trunk@33029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-03 05:44:24 +00:00
Dion Hulse
d651de0dac Introduce wp_should_upgrade_global_tables() to determine if global tables should be upgraded automatically. Use it throughout the existing upgrade routines. 
Props johnjamesjacoby for initial patch
Fixes #32154 for trunk

Built from https://develop.svn.wordpress.org/trunk@33057


git-svn-id: http://core.svn.wordpress.org/trunk@33028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-03 04:34:24 +00:00
Dion Hulse
cbacb92dae Enable utf8mb4 for MySQL extension users. Previously utf8mb4 was limited to MySQLi users only unintentionally. 
This change does the following things
 * Allows utf8mb4 for the MySQL extension
 * Re-runs the utf8->utf8mb4 conversion for single sites, this will do nothing for tables already converted
 * Re-runs the utf8->utf8mb4 conversion for global tables in multisite when the environment supports utf8mb4
 * Removes upgrade_420() calling as upgrade_430() will perform those changes now instead

The index shortenings should have still taken place on utf8 sites previously, so there's no need to run those again. 

Props kovshenin, pento, dd32
Fixes #32127 for trunk.

Built from https://develop.svn.wordpress.org/trunk@33055


git-svn-id: http://core.svn.wordpress.org/trunk@33026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-03 03:26:24 +00:00
Konstantin Obenland
a4e803fbd4 Use get_default_comment_status() globally. 
Also makes the filter name static and passes the post type for context.

Props valendesigns.
Fixes #31168.


Built from https://develop.svn.wordpress.org/trunk@33054


git-svn-id: http://core.svn.wordpress.org/trunk@33025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-02 22:32:25 +00:00
Konstantin Obenland
cd7a40bdc7 Site Icon: Improve responsiveness for small screen devices. 
Using Jcrop's `trueSize` argument also allows us to get rid of all that behind
the scenes temp image creating and back and forth calculating of image sizes.

Props tyxla for initial patch.
See #16434.


Built from https://develop.svn.wordpress.org/trunk@33053


git-svn-id: http://core.svn.wordpress.org/trunk@33024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-02 21:16:24 +00:00
Sergey Biryukov
3fb3d2a762 Replace @returns with @return in PHP docblocks. 
props kraftbj.
fixes #32865.
Built from https://develop.svn.wordpress.org/trunk@33052


git-svn-id: http://core.svn.wordpress.org/trunk@33023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-02 21:05:24 +00:00
Konstantin Obenland
0d270f67c2 Site Icon: Skip cropping if image has the correct size. 
Props jipmoors for initial patch.
See #16434.


Built from https://develop.svn.wordpress.org/trunk@33051


git-svn-id: http://core.svn.wordpress.org/trunk@33022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-02 20:40:25 +00:00
Mark Jaquith
423a1a7ca4 New password change/set UI. 
* Generate the password for the user
* More tightly integrate password strength meter
* Warn on weak passwords

see #32589

props MikeHansenMe, adamsilverstein, binarykitten
Built from https://develop.svn.wordpress.org/trunk@33023


git-svn-id: http://core.svn.wordpress.org/trunk@32994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-01 14:48:24 +00:00
Dion Hulse
ebb6aa1d4a Split upgrade_430() into two so that split_all_shared_terms() runs when upgrade_430_fix_comments() bails early. 
See [32814], #30261, [32364], #32165

Built from https://develop.svn.wordpress.org/trunk@33020


git-svn-id: http://core.svn.wordpress.org/trunk@32991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-01 07:35:24 +00:00
Helen Hou-Sandí
8eb7f71e6b List tables: A better responsive view. 
Instead of truncating columns, the data that's already in the markup can now be toggled into view. Only seems appropriate to celebrate four years of contributing by finally doing the first thing I ever mocked up.

Known issues / concerns:
* Custom list tables that don't define a primary column will show nothing at all. These are not extremely common, as `WP_List_Table` isn't really recommended for plugin consumption, but it happens. We need to come up with some kind of fallback.
* Some visual elements, particularly whitespace, could use refining.
* Needs a11y review.
* Touch performance on iOS feels sluggish - is there anything we can do about that?
* Would this be better accordion-style (only one expanded at a time)?
* Is `wp_strip_all_tags()` good enough for column titles that have HTML in them? It's essentially a workaround for the fact that core's comments column does that for the icon, which maybe it shouldn't. Perhaps worth another ticket, as a markup change would be fairly independent.
* Visual hierarchy is not great when expanded (also worthy of another ticket).
* Quick edit now becomes noticeably more annoying to cancel out of, as you have to scroll all the way down and you lose your position from before it was opened. Again, worthy of another ticket.

props Michael Arestad, helen.
see #32395.

Built from https://develop.svn.wordpress.org/trunk@33016


git-svn-id: http://core.svn.wordpress.org/trunk@32987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-01 01:31:25 +00:00
Konstantin Obenland
f18fabc300 Site Icon: Move admin icon filter to its rightful place. 
The action is unrelated to `WP_Site_Icon` itself.

Props kraftbj.
See #16434.


Built from https://develop.svn.wordpress.org/trunk@33011


git-svn-id: http://core.svn.wordpress.org/trunk@32982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-30 23:26:25 +00:00
Dominik Schilling
7cc9a4c092 Plugins list table: Sort plugins by Name by default so translated plugin names get correctly sorted. 
props swissspidy.
fixes #32735.
Built from https://develop.svn.wordpress.org/trunk@33010


git-svn-id: http://core.svn.wordpress.org/trunk@32981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-30 22:31:25 +00:00
Dominik Schilling
86ebc13446 Remove unnecessary feedback message from WP_Importer::is_user_over_quota(). 
fixes #32021.
Built from https://develop.svn.wordpress.org/trunk@33008


git-svn-id: http://core.svn.wordpress.org/trunk@32979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-30 20:32:25 +00:00
Konstantin Obenland
38e4211efb Use existing nomenclature pattern for Site Icon class. 
Props kraftbj.
Fixes #32834.


Built from https://develop.svn.wordpress.org/trunk@33001


git-svn-id: http://core.svn.wordpress.org/trunk@32972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-30 14:37:27 +00:00
Andrew Ozz
b092defb17 Press This: 
- Add support for the Text editor.
- Add auto-scrolling when the caret moves out of the viewport while the user is typing (similarly to editor-expand).
- Add auto-resize for the textarea.
See #32706.
Built from https://develop.svn.wordpress.org/trunk@32999


git-svn-id: http://core.svn.wordpress.org/trunk@32970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-30 03:58:27 +00:00
Konstantin Obenland
c56a8ae0f7 Introducing Site Icon, favicon management for WordPress. 
This v1 marries Jetpack's Site Icon module with the Media Modal, reusing code
from the Custom Header admin. For now, the core-provided icons will be limited
to a favicon, an iOS app icon, and a Windows tile icon, leaving `.ico` support
and additional icons to plugins to add.

Props obenland, tyxla, flixos90, jancbeck, markjaquith, scruffian.
See #16434.


Built from https://develop.svn.wordpress.org/trunk@32994


git-svn-id: http://core.svn.wordpress.org/trunk@32965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-29 12:58:25 +00:00
Helen Hou-Sandí
83e33a2ca0 List tables: Bring screen reader text for comments column title to media. 
see #32152, [31513].

Built from https://develop.svn.wordpress.org/trunk@32991


git-svn-id: http://core.svn.wordpress.org/trunk@32962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-28 15:44:25 +00:00
Aaron Jorbin
1525010f74 Deprecate php4 style constructors 
PHP7 is deprecating PHP4 style constructors, so we need to modify our code to have _construct methods that fire before the named PHP4 style constructors.  The PHP4 style constructors will call the PHP5 style constructor in case it is being called directly (usually via parent::METHOD).

This modifies external libraries to add PHP5 style constructors, but doesn't add a notice for when they are used.  In WordPress core code, PHP4 style constructors are being given a call to _deprecated_constructor. To the PHP4 style constructor I say "I know that I can't take no more | It ain't no lie | I wanna see you out that door | Baby, bye, bye, bye..."

Upstream: https://wiki.php.net/rfc/remove_php4_constructors

Props jdgrimes, netweb, jorbin
See #31982


Built from https://develop.svn.wordpress.org/trunk@32990


git-svn-id: http://core.svn.wordpress.org/trunk@32961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-28 15:27:24 +00:00
Sergey Biryukov
b26accf35a List tables: Select All should not be a column header. 
It sets a redundant relationship with all checkboxes in its column and also conveys wrong information for screen readers.

props afercia, valendesigns.
see #31654.
Built from https://develop.svn.wordpress.org/trunk@32984


git-svn-id: http://core.svn.wordpress.org/trunk@32955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-28 05:46:25 +00:00
Andrew Ozz
275fc220ef Press This: 
- Save a draft before opening the standard editor window.
- While saving a post show Saving... instead of Publish for the main visible part of the split button (same as the Save Draft button before).
See #32757.
Built from https://develop.svn.wordpress.org/trunk@32983


git-svn-id: http://core.svn.wordpress.org/trunk@32954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-28 04:59:24 +00:00
Konstantin Obenland
7dc1d06e64 Proper heading for admin screens. 
First step towards restoring a good heading structure in wp-admin.
The previous `<h1>` contained the site title and a link to the front page and was removed with the toolbar refactoring in 3.2.

Props joedolson, afercia.
Fixes #31650.


Built from https://develop.svn.wordpress.org/trunk@32974


git-svn-id: http://core.svn.wordpress.org/trunk@32945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 15:41:25 +00:00
Scott Taylor
8b1286417e ob_get_contents() followed by ob_end_clean() can be replaced by ob_get_clean(). 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32965


git-svn-id: http://core.svn.wordpress.org/trunk@32936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 01:12:24 +00:00
Scott Taylor
a0e373ef80 For doc block types, favor bool over the few remaining booleans 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32964


git-svn-id: http://core.svn.wordpress.org/trunk@32935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 01:03:25 +00:00
Scott Taylor
642af1f3f4 Some doc blocks should use bool instead of true|false 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32963


git-svn-id: http://core.svn.wordpress.org/trunk@32934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 00:45:24 +00:00
Scott Taylor
60b8e86b36 In WP_Filesystem_Base::chdir|chgrp|chmod() (all mock abstract methods), modify @return to include string so that subclass @returns match. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32962


git-svn-id: http://core.svn.wordpress.org/trunk@32933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 00:43:24 +00:00
Scott Taylor
7537240d37 List tables: when post navigation links point to the current page, use <span>s and text instead of <a>s. 
Props afercia.
Fixes #32253.

Built from https://develop.svn.wordpress.org/trunk@32948


git-svn-id: http://core.svn.wordpress.org/trunk@32919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 20:32:26 +00:00
Scott Taylor
587c570efa After [32796], improve the accessibility and markup for instances of touch_time(). 
Props rianrietveld, afercia.
Fixes #31714.

Built from https://develop.svn.wordpress.org/trunk@32945


git-svn-id: http://core.svn.wordpress.org/trunk@32916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 19:30:25 +00:00
Andrew Ozz
7142248743 Press This: better screen reader text for the arrow part of the split button. 
Props afercia. See #32757.
Built from https://develop.svn.wordpress.org/trunk@32944


git-svn-id: http://core.svn.wordpress.org/trunk@32915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 19:24:25 +00:00
Scott Taylor
7453d12390 Remove unused code from WP_Press_This::html(). 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32939


git-svn-id: http://core.svn.wordpress.org/trunk@32910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 16:38:25 +00:00
Scott Taylor
d9bd43c702 Remove unused code from WP_MS_Sites_List_Table::display_rows(). 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32938


git-svn-id: http://core.svn.wordpress.org/trunk@32909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 16:36:29 +00:00
Andrew Ozz
d3ee649cb9 Press This: support passing i parameter to add an image src. 
Props stephdau, azaozz. Fixes #32173.
Built from https://develop.svn.wordpress.org/trunk@32936


git-svn-id: http://core.svn.wordpress.org/trunk@32907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 03:06:25 +00:00
Andrew Ozz
d4f3428d5f Press This, split button: wrap the sub-buttons in an unordered list to aid accessibility. 
Props afercia. See #32757.
Built from https://develop.svn.wordpress.org/trunk@32934


git-svn-id: http://core.svn.wordpress.org/trunk@32905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 01:55:30 +00:00
John Blackbourn
b5973e92ec Introduce a no_terms label for taxonomies. This label is used when indicating that there are no terms in the given taxonomy associated with an object. 
Fixes #32150
Props afercia

Built from https://develop.svn.wordpress.org/trunk@32933


git-svn-id: http://core.svn.wordpress.org/trunk@32904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 00:16:27 +00:00
Drew Jaynes
e9758d4e48 Fix a typo in the DocBlock for get_plugins(). 
Props onnimonni, swissspidy.
Fixes #32758.

Built from https://develop.svn.wordpress.org/trunk@32927


git-svn-id: http://core.svn.wordpress.org/trunk@32898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 12:22:27 +00:00
Dion Hulse
42fbb6568e WP Filesystem: Correctly set the @since for WP_Filesystem_Base::getchmod() added in r32923. 
This is 2.5.0 as that's when the function become available in all subclasses.
See #29548

Built from https://develop.svn.wordpress.org/trunk@32924


git-svn-id: http://core.svn.wordpress.org/trunk@32895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 04:52:25 +00:00
Dion Hulse
8f47efe7dc WP Filesystem: Correctly parse the permissions field in the directory listings, and actually set it in FTP environments 
Props mnelson4 for initial patch.
Fixes #29548

Built from https://develop.svn.wordpress.org/trunk@32923


git-svn-id: http://core.svn.wordpress.org/trunk@32894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 04:49:25 +00:00
Andrew Ozz
f8cf80e9b1 Press This: ensure proper tab order in the split button. Tweak padding and border color a bit. 
See #32757.
Built from https://develop.svn.wordpress.org/trunk@32921


git-svn-id: http://core.svn.wordpress.org/trunk@32892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 03:23:27 +00:00
Andrew Ozz
f4109b0c5d Press This: convert the Preview | Save | Publish buttons to a split button. 
See #32757.
Built from https://develop.svn.wordpress.org/trunk@32920


git-svn-id: http://core.svn.wordpress.org/trunk@32891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 02:46:27 +00:00
Scott Taylor
00de0e6341 In unregister_setting(), search for $option_name in a segment of $new_whitelist_options keyed by $option_group. 
Props nofearinc.
Fixes #26479.

Built from https://develop.svn.wordpress.org/trunk@32905


git-svn-id: http://core.svn.wordpress.org/trunk@32876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-22 20:51:26 +00:00
Scott Taylor
b8f49cebee List table views: fix missing current class for "All" when logged in as an author. 
Props afercia.
Fixes #32015.

Built from https://develop.svn.wordpress.org/trunk@32903


git-svn-id: http://core.svn.wordpress.org/trunk@32874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-22 20:39:27 +00:00
Helen Hou-Sandí
5a07e4bba4 Add "Scheduled" to post states. 
props rclations.
fixes #32131.

Built from https://develop.svn.wordpress.org/trunk@32902


git-svn-id: http://core.svn.wordpress.org/trunk@32873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-22 16:07:26 +00:00
Sergey Biryukov
4332d8dfc0 Avoid a PHP notice in WP_Press_This::get_suggested_content() after [32828]. 
props kraftbj.
fixes #32751.
Built from https://develop.svn.wordpress.org/trunk@32901


git-svn-id: http://core.svn.wordpress.org/trunk@32872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-22 15:20:28 +00:00
Scott Taylor
92d67bf395 Use valid markup in Walker_Nav_Menu_Edit::start_el() - replace <d(l|t)> with <div> for .menu-item-bar and .menu-item-handle. 
Props sagarjadhav.
Fixes #31817.

Built from https://develop.svn.wordpress.org/trunk@32879


git-svn-id: http://core.svn.wordpress.org/trunk@32850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 22:22:26 +00:00
Scott Taylor
032ea5b132 Add access modifier to WP_Upgrader::clear_destination() 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32871


git-svn-id: http://core.svn.wordpress.org/trunk@32842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 21:53:25 +00:00
Scott Taylor
86beb35f6d Use <button> instead of <a> for non-link links in Quick Edit. 
Props afercia.
Fixes #32213.

Built from https://develop.svn.wordpress.org/trunk@32869


git-svn-id: http://core.svn.wordpress.org/trunk@32840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 21:42:27 +00:00
Scott Taylor
cfe78e0e95 Cleanup (ms-)?admin-filters.php 
Props johnjamesjacoby.
Fixes #32529.

Built from https://develop.svn.wordpress.org/trunk@32865


git-svn-id: http://core.svn.wordpress.org/trunk@32836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 21:18:25 +00:00
Dion Hulse
8593dc3172 When updating plugins/themes verify that the files to be deleted can be modified before starting the deletion process. 
This will avoid partially deleting an item during update which has inconsistent permissions.
This change only affects those using the direct & ssh transports as FTP's is_writable() currently always returns `true`.
Fixes #30921

Built from https://develop.svn.wordpress.org/trunk@32854


git-svn-id: http://core.svn.wordpress.org/trunk@32825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 03:49:25 +00:00
Dion Hulse
a21f890abb Remove a redundant index drop, it'll be dropped and re-created a few lines further down. 
Fixes a warning during updating from 4.0 or earlier.
Fixes #31388 for trunk

Built from https://develop.svn.wordpress.org/trunk@32852


git-svn-id: http://core.svn.wordpress.org/trunk@32823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 03:18:26 +00:00
Konstantin Obenland
c1a9c4b7b8 Semanticize Help and Screen Options toggle. 
Links used as UI controls that are not real links but act as buttons, should be buttons.

Props afercia.
Fixes #32494.


Built from https://develop.svn.wordpress.org/trunk@32844


git-svn-id: http://core.svn.wordpress.org/trunk@32815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 16:36:25 +00:00
Konstantin Obenland
d872f38c31 Show the posts meta box by default in Appearance > Menus. 
Lessens user confusion and the likelyhood of misusing custom links
to add menu items for posts.

Props bcole808.
Fixes #32440.


Built from https://develop.svn.wordpress.org/trunk@32842


git-svn-id: http://core.svn.wordpress.org/trunk@32813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 15:04:26 +00:00
Konstantin Obenland
c9e1e2be9b Make posts in the 'Most recent' tab of post type meta boxes filterable. 
Provides parity with the 'View All' tab of post type meta boxes in Appearance > Menus.

Props jpyper, chriscct7.
Fixes #19365.


Built from https://develop.svn.wordpress.org/trunk@32833


git-svn-id: http://core.svn.wordpress.org/trunk@32804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 11:35:28 +00:00
Andrew Ozz
bc2630e099 Press This: Check the embeds list against all of the oembed providers. 
Props stephdau. Fixes #32069.
Built from https://develop.svn.wordpress.org/trunk@32828


git-svn-id: http://core.svn.wordpress.org/trunk@32799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 00:12:26 +00:00
Andrew Ozz
b77a3a33f5 Press This: show error message when the user is attempting to add a category that already exists. 
Fixes #32339.
Built from https://develop.svn.wordpress.org/trunk@32827


git-svn-id: http://core.svn.wordpress.org/trunk@32798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 23:13:26 +00:00
Boone Gorges
f62bf61b2c Bail out of 4.3 term splitting routine when no shared terms are found. 
Props dd32.
See #30261.
Built from https://develop.svn.wordpress.org/trunk@32819


git-svn-id: http://core.svn.wordpress.org/trunk@32790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 11:40:24 +00:00
Boone Gorges
290044ef15 Split all shared taxonomy terms on upgrade to 4.3. 
Dear Shared Terms, Welcome to Splitsville. Population: You.

See #30261.
Built from https://develop.svn.wordpress.org/trunk@32814


git-svn-id: http://core.svn.wordpress.org/trunk@32785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 01:53:26 +00:00
Helen Hou-Sandí
d159cc2272 Media list table: Avoid PHP notices by using the proper variables. 
Also visually tightens up the row actions.

props tyxla.
fixes #32657. see #29881.

Built from https://develop.svn.wordpress.org/trunk@32805


git-svn-id: http://core.svn.wordpress.org/trunk@32776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 21:33:25 +00:00
Scott Taylor
5c6b63d3a6 if is a statment, not a function. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32800


git-svn-id: http://core.svn.wordpress.org/trunk@32771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 20:01:25 +00:00
Helen Hou-Sandí
a49c192f37 Media list table: Restore row actions. 
see #29881, #32657.

Built from https://develop.svn.wordpress.org/trunk@32798


git-svn-id: http://core.svn.wordpress.org/trunk@32769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 19:47:24 +00:00
Dion Hulse
faf6383ebd Updates: Consistently use the same variable to refer to the plugin, avoids a potential PHP Notice when an external update script adds data without that key. 
Props mordauk. Fixes #31784

Built from https://develop.svn.wordpress.org/trunk@32784


git-svn-id: http://core.svn.wordpress.org/trunk@32755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-15 06:26:25 +00:00
Dion Hulse
c6bb637f89 Updats: Add a filter for the options params for the update being performed. 
Props nofearinc. Fixes #27754

Built from https://develop.svn.wordpress.org/trunk@32783


git-svn-id: http://core.svn.wordpress.org/trunk@32754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-15 05:35:26 +00:00
Dion Hulse
b881a541bb Updates: Remove redundant title tags from update outputs. 
Props afercia. Fixes #32530

Built from https://develop.svn.wordpress.org/trunk@32781


git-svn-id: http://core.svn.wordpress.org/trunk@32752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-15 05:09:25 +00:00
Dion Hulse
0eb8bfc464 Updates: When a error occurs during the connection phase, pass the error message back as the ajax failure message. 
See #32435

Built from https://develop.svn.wordpress.org/trunk@32778


git-svn-id: http://core.svn.wordpress.org/trunk@32749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-15 03:32:27 +00:00
Andrew Nacin
e7f618d86e Tweak the first post/page content to get with the times. 
props chriscct7.
fixes #22474.

Built from https://develop.svn.wordpress.org/trunk@32768


git-svn-id: http://core.svn.wordpress.org/trunk@32739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 18:56:50 +00:00
Scott Taylor
4348074f3a In WP_MS_Users_List_Table::display_rows(): 
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - there is a small amount of logic that requires overriding, otherwise it is largely the same as the parent method

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32757


git-svn-id: http://core.svn.wordpress.org/trunk@32728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 17:11:26 +00:00
Scott Taylor
3855cfbffd In WP_MS_Themes_List_Table::display_rows(): 
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32756


git-svn-id: http://core.svn.wordpress.org/trunk@32727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 16:54:26 +00:00
Scott Taylor
2bdcc71bc0 In WP_MS_Sites_List_Table::display_rows(): 
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - it could inherit from `WP_List_Table` if we can find a way to handle the `id` column. When that happens, we can ditch this method.

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32755


git-svn-id: http://core.svn.wordpress.org/trunk@32726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 16:23:25 +00:00
Scott Taylor
ba8cfcab71 In WP_Media_List_Table::display_rows(): 
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32754


git-svn-id: http://core.svn.wordpress.org/trunk@32725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 15:57:27 +00:00
Scott Taylor
a56576edfe In WP_Links_List_Table::display_rows(): 
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32753


git-svn-id: http://core.svn.wordpress.org/trunk@32724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 15:33:25 +00:00
Scott Taylor
b8eb353590 In WP_Posts_List_Table, move the <th> markup out of ->column_cb(). 
See #29881, [32740].

Built from https://develop.svn.wordpress.org/trunk@32752


git-svn-id: http://core.svn.wordpress.org/trunk@32723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 15:14:24 +00:00
Scott Taylor
18827ed337 In wp_ajax_hidden_columns(), don't explode() on an empty string. 
In `columns.hidden()`, which lives in `common.js`, don't return items with no `id`.

This was resulting in options like `manageedit-postcolumnshidden` containing a serialized array with random empty items.

Props afercia, wonderboymusic.
Fixes #32466.

Built from https://develop.svn.wordpress.org/trunk@32751


git-svn-id: http://core.svn.wordpress.org/trunk@32722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 15:00:25 +00:00
Scott Taylor
da0400e273 In WP_Posts_List_Table::column_title(), use is_post_type_hierarchical() instead of $this->hierarchical_display in the logic to determine whether the_excerpt() should be called. 
Fixes #32187.

Built from https://develop.svn.wordpress.org/trunk@32749


git-svn-id: http://core.svn.wordpress.org/trunk@32720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 14:42:26 +00:00
Scott Taylor
c11e433858 After [32740], in WP_Posts_List_Table::single_row() - $lock_holder is checked but unused, so the call to get_userdata() is unnecessary. 
See #29881.

Built from https://develop.svn.wordpress.org/trunk@32742


git-svn-id: http://core.svn.wordpress.org/trunk@32713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 20:48:26 +00:00
Scott Taylor
c1c7a7c14c After [32740], correct doc block typo. 
See #29881.

Built from https://develop.svn.wordpress.org/trunk@32741


git-svn-id: http://core.svn.wordpress.org/trunk@32712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 20:29:26 +00:00
Scott Taylor
3f4cadf4aa Override ->single_row_columns() in WP_Posts_List_Table. 
Break apart the giant `switch` statement in `->single_row()` into `column_{$column_name}` methods.
To maintain the `->single_row_columns( $item )` interface, add a property, `$current_level`, to allow access to `$level`.

This list table class is now easier to subclass.

Props joehoyle, wonderboymusic.
See #29881.

Built from https://develop.svn.wordpress.org/trunk@32740


git-svn-id: http://core.svn.wordpress.org/trunk@32711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 20:18:24 +00:00
Scott Taylor
d0aa8e4a6e In WP_Terms_List_Table::display_rows_or_placeholder(): 
* `get_terms()` can return `WP_Error`, so its return value should be checked before traversing.
* The 2nd call to `get_terms()` can be removed, it is redundant #OPTIMIZATION

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32739


git-svn-id: http://core.svn.wordpress.org/trunk@32710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 18:55:25 +00:00
Scott Taylor
da4c3d0fe4 In WP_Posts_List_Table::single_row(): 
* `get_the_terms()` can return `WP_Error`, so its return value should be checked before traversing.
* Correct the `@param` doc blocks

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32738


git-svn-id: http://core.svn.wordpress.org/trunk@32709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 18:50:25 +00:00
Scott Taylor
4835310a18 In WP_Media_List_Table::display_rows(), get_the_terms() can return WP_Error, so its return value should be checked before traversing. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32737


git-svn-id: http://core.svn.wordpress.org/trunk@32708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 18:45:25 +00:00