Scott Taylor
b964ac0148
Live update the menu item title when the user is editing the "Navigation Label" field.
...
Props celloexpressions.
See #23076 .
Built from https://develop.svn.wordpress.org/trunk@28707
git-svn-id: http://core.svn.wordpress.org/trunk@28523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-09 18:39:15 +00:00
Helen Hou-Sandí
d558331e18
Properly indicate with the cursor that the editor can be vertically resized using the entire info bar, not just the handle displayed in the corner.
...
props torresga. fixes #28420 .
Built from https://develop.svn.wordpress.org/trunk@28703
git-svn-id: http://core.svn.wordpress.org/trunk@28520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-08 19:47:14 +00:00
Helen Hou-Sandí
b5ef672c6b
Grid view for the media library, first pass. This is alpha; expect imperfection. We will be iterating further.
...
props ericlewis, shaunandrews, wonderboymusic.
see #24716 .
Built from https://develop.svn.wordpress.org/trunk@28682
git-svn-id: http://core.svn.wordpress.org/trunk@28500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-05 22:01:18 +00:00
Sergey Biryukov
4b14fe0593
Remove one-time variable from add_settings_error().
...
props niallkennedy.
fixes #22228 .
Built from https://develop.svn.wordpress.org/trunk@28681
git-svn-id: http://core.svn.wordpress.org/trunk@28499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-05 18:29:14 +00:00
Sergey Biryukov
26d0ad5e12
Remove redundant 'Visit author homepage' title attributes for plugins and themes.
...
props joedolson.
fixes #26554 .
Built from https://develop.svn.wordpress.org/trunk@28673
git-svn-id: http://core.svn.wordpress.org/trunk@28491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-05 04:52:16 +00:00
Drew Jaynes
a6e536fba6
Make sure to use 3-digit x.x.x style for two 3.9.0 @since
versions.
...
Props netweb.
Fixes #28446 .
Built from https://develop.svn.wordpress.org/trunk@28658
git-svn-id: http://core.svn.wordpress.org/trunk@28476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-04 05:35:16 +00:00
Drew Jaynes
b0877f02a4
Make sure $post
is properly documented as optional where applicable.
...
See #28388 .
Built from https://develop.svn.wordpress.org/trunk@28653
git-svn-id: http://core.svn.wordpress.org/trunk@28471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-03 03:53:17 +00:00
Sergey Biryukov
dc6b95589a
Plugin activation/deletion errors should be styled as such.
...
props johnbillion.
fixes #28260 .
Built from https://develop.svn.wordpress.org/trunk@28646
git-svn-id: http://core.svn.wordpress.org/trunk@28464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-31 20:10:15 +00:00
Sergey Biryukov
ee9d9133ac
Avoid stomping of the $plugin variable in activate_plugin().
...
fixes #28102 .
Built from https://develop.svn.wordpress.org/trunk@28644
git-svn-id: http://core.svn.wordpress.org/trunk@28462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-30 22:08:14 +00:00
Sergey Biryukov
66bfea485a
Display the site scheme, not the current scheme on Edit Site screen in network admin.
...
props johnbillion.
fixes #28406 .
Built from https://develop.svn.wordpress.org/trunk@28643
git-svn-id: http://core.svn.wordpress.org/trunk@28461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-30 22:01:15 +00:00
Sergey Biryukov
df597224e5
Add paragraph tags to 'Add Existing User' section on 'Add New User' screen in multisite.
...
props jkudish, topher1kenobe.
fixes #20271 .
Built from https://develop.svn.wordpress.org/trunk@28642
git-svn-id: http://core.svn.wordpress.org/trunk@28460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-30 21:51:14 +00:00
Scott Taylor
ecdcfb55bb
Make the image editor less jumpy when opening.
...
Props eddiemoya, ericlewis.
Fixes #22793 .
Built from https://develop.svn.wordpress.org/trunk@28639
git-svn-id: http://core.svn.wordpress.org/trunk@28457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-30 19:53:15 +00:00
Scott Taylor
9187e3bd55
Restore $val
in WP_Importer::bump_request_timeout()
- even though the parent class and WP_Import
ignore the parameter, it creates an incompatible interface notice in the plugin.
...
See [28629].
Built from https://develop.svn.wordpress.org/trunk@28637
git-svn-id: http://core.svn.wordpress.org/trunk@28455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-30 19:35:16 +00:00
Scott Taylor
af860fbe84
Cleanup for switch
statements:
...
* Move `default` to the bottom in `WP_Theme_Install_List_Table`
* `switch/endswitch` syntax is not supported in Hack. Switch to `switch (...) { .... }` syntax. (A few template-type instances linger).
Fixes #28409 .
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28633
git-svn-id: http://core.svn.wordpress.org/trunk@28452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-30 17:58:15 +00:00
Drew Jaynes
1868c1fc4b
Remove unnecessary "not used" notation for filter parameters in wp-admin/includes/media.php.
...
Also add `@param` and `@return` descriptions.
See #28408 .
Built from https://develop.svn.wordpress.org/trunk@28632
git-svn-id: http://core.svn.wordpress.org/trunk@28451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-30 17:38:14 +00:00
Scott Taylor
c403768fa2
Remove some dead variable assignments.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28629
git-svn-id: http://core.svn.wordpress.org/trunk@28449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-30 16:59:14 +00:00
Andrew Ozz
15a1f80885
TinyMCE in iOS:
...
- Fix placing the caret at the bottom of longer posts when the keyboard is open.
- Disable resizing on switching editors and on show/hide the kitchen sink row.
See #28242
Built from https://develop.svn.wordpress.org/trunk@28626
git-svn-id: http://core.svn.wordpress.org/trunk@28446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-30 02:38:16 +00:00
Helen Hou-Sandí
3f1deae10b
Don't use the box shadow focus styling for the admin menu or toolbar. see #28267 .
...
Built from https://develop.svn.wordpress.org/trunk@28616
git-svn-id: http://core.svn.wordpress.org/trunk@28440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-29 14:23:15 +00:00
Helen Hou-Sandí
ec121f9899
Better align link element focus with form focus styling, which also improves the visibility. props zamfeer. see #28267 .
...
Built from https://develop.svn.wordpress.org/trunk@28608
git-svn-id: http://core.svn.wordpress.org/trunk@28432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-29 03:58:14 +00:00
Sergey Biryukov
78a9cb855e
Fix displaying taxonomies in bulk edit if the post type does not support titles.
...
props scribu.
fixes #16793 .
Built from https://develop.svn.wordpress.org/trunk@28600
git-svn-id: http://core.svn.wordpress.org/trunk@28425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-28 13:50:14 +00:00
Sergey Biryukov
d3e6a5ded0
Remove obsolete code from wp_dashboard_setup().
...
props kitchin.
fixes #26604 .
Built from https://develop.svn.wordpress.org/trunk@28592
git-svn-id: http://core.svn.wordpress.org/trunk@28417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-27 15:41:15 +00:00
Sergey Biryukov
e94ee8f08c
Move 'Documentation on date and time formatting' link under the 'Time Format' block.
...
props gauravmittal1995.
fixes #28348 .
Built from https://develop.svn.wordpress.org/trunk@28591
git-svn-id: http://core.svn.wordpress.org/trunk@28416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-27 14:50:14 +00:00
Sergey Biryukov
84422e6d7d
Add BMP to the list of displayable image types.
...
props ericlewis.
fixes #26808 .
Built from https://develop.svn.wordpress.org/trunk@28589
git-svn-id: http://core.svn.wordpress.org/trunk@28414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-27 13:25:14 +00:00
Sergey Biryukov
db9057f308
Remove redundant get_shortcode_regex() check.
...
props kovshenin.
see #28195 .
Built from https://develop.svn.wordpress.org/trunk@28587
git-svn-id: http://core.svn.wordpress.org/trunk@28412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-27 11:30:16 +00:00
Scott Taylor
3c1723afd7
When adding a URL in the Insert from URL
state in the media modal, attempt to show a preview of the content. Drop the unused width and height fields.
...
This will probably be iterated upon.
Props helen, jtsternberg, wonderboymusic.
See #15490 .
Built from https://develop.svn.wordpress.org/trunk@28581
git-svn-id: http://core.svn.wordpress.org/trunk@28406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-26 23:57:14 +00:00
Scott Taylor
89864b4a5a
Don't pass embeds through the_content()
when trying to render MCE previews, leverage WP_Embed
and do_shortcode()
instead.
...
Props kovshenin.
See #28195 .
Built from https://develop.svn.wordpress.org/trunk@28580
git-svn-id: http://core.svn.wordpress.org/trunk@28405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-26 23:43:15 +00:00
Scott Taylor
8b7b72d75e
In media_sideload_image()
, check the returned value of download_url()
earlier to avoid attempting to unlink()
an instance of WP_Error
.
...
Props georgestephanis.
Fixes #28204 .
Built from https://develop.svn.wordpress.org/trunk@28567
git-svn-id: http://core.svn.wordpress.org/trunk@28392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-23 21:33:14 +00:00
Scott Taylor
5b5b756edf
In get_terms_to_edit()
, call get_object_term_cache()
before priming cache with wp_get_object_terms()
.
...
In `get_inline_data()`, do the same.
On list table screens with taxonomies in the admin, this dramatically reduces the number of database queries (3x less). Even more so with a persistent object cache (5x less).
Props johnbillion, jeffstieler, wonderboymusic.
Fixes #18968 .
Built from https://develop.svn.wordpress.org/trunk@28561
git-svn-id: http://core.svn.wordpress.org/trunk@28387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-23 19:29:14 +00:00
Scott Taylor
8d4d645629
Fix parsing in wp_match_mime_types()
to allow some mime-types with +
in them to appear in the list of filter links shown above the list table on upload.php
.
...
Props _duck.
Fixes #20672 .
Built from https://develop.svn.wordpress.org/trunk@28553
git-svn-id: http://core.svn.wordpress.org/trunk@28379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 21:36:15 +00:00
Scott Taylor
d22b5226a8
In wp_dashboard_recent_posts()
, $i
is set and never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28545
git-svn-id: http://core.svn.wordpress.org/trunk@28371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 18:56:15 +00:00
Scott Taylor
0e03abda62
$theme_name
is set but no longer used in wp_dashboard_right_now()
. The theme name is displayed with the call to update_right_now_message()
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28544
git-svn-id: http://core.svn.wordpress.org/trunk@28370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 18:54:13 +00:00
Scott Taylor
b8d469600b
These functions import $wpdb
but do not use it.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28539
git-svn-id: http://core.svn.wordpress.org/trunk@28365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 17:37:14 +00:00
Sergey Biryukov
219321eedc
Fix inconsistent header underlining and spacing in background update emails.
...
fixes #28306 .
Built from https://develop.svn.wordpress.org/trunk@28537
git-svn-id: http://core.svn.wordpress.org/trunk@28363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 09:41:15 +00:00
Sergey Biryukov
45d5e5d32f
Use correct function name.
...
props ericlewis.
fixes #28329 .
Built from https://develop.svn.wordpress.org/trunk@28535
git-svn-id: http://core.svn.wordpress.org/trunk@28361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 07:59:16 +00:00
Scott Taylor
7de0b2b2c8
Upgrade _WP_List_Table_Compat
to PHP5-style constructor.
...
Add `public` to methods/members of `WP_Role`.
Add `public` to methods/members of `WP_User` where appropriate. Don't set `private` where indicated until more study has occurred and tests have been written for compatibiliy with existing magic methods.
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28531
git-svn-id: http://core.svn.wordpress.org/trunk@28357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 17:20:17 +00:00
Scott Taylor
7415ae10a3
hackificator
doesn't like mixed single/double-quoted attributes. These were 2 lingering instances in the admin.
...
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28530
git-svn-id: http://core.svn.wordpress.org/trunk@28356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 17:10:15 +00:00
Scott Taylor
09ecc213c8
In WP_Filesystem_Base
, the constructor is a noop, so it shouldn't even be declared. Setting it implies that parent::__construct()
should be called by its subclasses.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28529
git-svn-id: http://core.svn.wordpress.org/trunk@28355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 16:46:14 +00:00
Scott Taylor
85f73cf458
Classes that have __set()
also need __isset()
and __unset()
.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28524
git-svn-id: http://core.svn.wordpress.org/trunk@28350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 06:52:14 +00:00
Scott Taylor
821246b4ae
Some classes with __get()
method also need __set()
.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28521
git-svn-id: http://core.svn.wordpress.org/trunk@28347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 06:31:15 +00:00
Scott Taylor
dfa4de15fa
Add missing access modifiers to methods/members in Walker
and subclasses. Add a magic __get()
method.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28514
git-svn-id: http://core.svn.wordpress.org/trunk@28340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 06:00:15 +00:00
Scott Taylor
2f513d3320
Fix some hackificator
odds and ends in wp-admin
:
...
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28500
git-svn-id: http://core.svn.wordpress.org/trunk@28326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:04:16 +00:00
Drew Jaynes
511eabe5f3
Improve inline documentation of default arguments for post_format_meta_box()
, post_tags_meta_box()
, and post_categories_meta_box()
.
...
See #28298 .
Built from https://develop.svn.wordpress.org/trunk@28499
git-svn-id: http://core.svn.wordpress.org/trunk@28325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 03:23:13 +00:00
Scott Taylor
130771a383
hackificator
doesn't like mixed quote styles in some generated HTML. The switch from single to double allows these files to be parsed.
...
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28497
git-svn-id: http://core.svn.wordpress.org/trunk@28323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 01:59:15 +00:00
Scott Taylor
1383990ae2
Add access modifier (public
) to methods and members of WP_Upgrader
and its subclasses.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28496
git-svn-id: http://core.svn.wordpress.org/trunk@28322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 01:29:15 +00:00
Scott Taylor
58ca85e106
Add access modifier (public
) to methods and members of WP_Upgrader_Skin
and its subclasses.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28495
git-svn-id: http://core.svn.wordpress.org/trunk@28321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 01:23:15 +00:00
Scott Taylor
f090ff507d
Add access modifiers to methods and members of WP_Users_List_Table
.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28494
git-svn-id: http://core.svn.wordpress.org/trunk@28320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 01:19:14 +00:00
Scott Taylor
d28f6344de
Add access modifiers to methods and members of list table classes:
...
* `WP_List_Table` is the base class that implements `__get()` and `__call()` for BC
* Adds unit tests to confirm that subclasses properly inherit magic methods
* Add modifiers to subclasses: `WP_Links_List_Table`, `WP_Media_List_Table`, `WP_MS_Sites_List_Table`, `WP_MS_Themes_List_Table`, `WP_MS_Users_List_Table`, `WP_Plugin_Install_List_Table`, `WP_Plugins_List_Table`, `WP_Posts_List_Table`, `WP_Terms_List_Table`, `WP_Theme_Install_List_Table`, `WP_Themes_List_Table`
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28493
git-svn-id: http://core.svn.wordpress.org/trunk@28319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 01:17:15 +00:00
Scott Taylor
4e894f05f5
Add access modifier (public
) to methods in WP_Importer
.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28492
git-svn-id: http://core.svn.wordpress.org/trunk@28318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 00:19:15 +00:00
Scott Taylor
d5e35d187f
Add access modifier (public
) to members and methods in WP_Filesystem_SSH2
.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28491
git-svn-id: http://core.svn.wordpress.org/trunk@28317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 00:18:14 +00:00
Scott Taylor
41e1ecdfaf
Add access modifier (public
) to members and methods in WP_Filesystem_ftpsockets
.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28490
git-svn-id: http://core.svn.wordpress.org/trunk@28316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 00:14:14 +00:00