While this has no effect on void elements in HTML5, it fixes a minor inconsistency with the rest of core.
Follow-up to [47493], [48834], [50556], [51418].
Props radixweb, ankitmaru, TobiasBg, sabernhardt, audrasjb, SergeyBiryukov.
Merges [51473] to the 5.8 branch.
Fixes#53716.
Built from https://develop.svn.wordpress.org/branches/5.8@51506
git-svn-id: http://core.svn.wordpress.org/branches/5.8@51117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Version bump three bundled themes to avoid file not found and fatal errors introduced for child themes during the 5.8 release cycle.
* Twenty Ten: Version 3.5 (fatal error & 404)
* Twenty Eleven: Version 3.9 (404)
* Twenty Twelve: Version 3.5 (404)
These updates will be released mid 5.8.1 cycle due to the severity of the issues.
Follow up to [51482,51483].
Props dd32, peterwilsoncc.
Merges [51486] to the 5.8 branch.
Fixes#53777.
Built from https://develop.svn.wordpress.org/branches/5.8@51489
git-svn-id: http://core.svn.wordpress.org/branches/5.8@51100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
By using `get_template_directory_uri()` instead of `get_stylesheet_directory_uri()`, we make sure to include the images from the parent theme.
This avoids displaying missing images in block patterns when using a child theme of Twenty Ten, Twenty Eleven, or Twenty Twelve.
Follow-up to [51033], [51103], [51106].
Props audrasjb, SergeyBiryukov.
Merges [51483] to the 5.8 branch.
Fixes#53769.
Built from https://develop.svn.wordpress.org/branches/5.8@51488
git-svn-id: http://core.svn.wordpress.org/branches/5.8@51099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
By using `get_template_directory()` instead of `get_stylesheet_directory()`, we make sure to include the `block-patterns.php` file from the parent theme.
This avoids a PHP fatal error when using a child theme of Twenty Ten.
Follow-up to [51106].
Props ryelle, sabernhardt, loranrendel, SergeyBiryukov.
Merges [51482] to the 5.8 branch.
Fixes#53752.
Built from https://develop.svn.wordpress.org/branches/5.8@51487
git-svn-id: http://core.svn.wordpress.org/branches/5.8@51098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This includes three minor updates to generated CSS files:
- A single `-webkit-` prefix is removed for `min-width`, which was required for Safari <= 10.1 (0.06% total global usage). WordPress only supports the last two versions.
- 2 instances where the `-o-` prefix are added for `tab-size`. This appears to be for Opera Mobile, which has creeped back over the 1% global usage.
Props peterwilsoncc, jorbin, desrosj.
Merges [51456] to the 5.8 branch.
Fixes#53686.
Built from https://develop.svn.wordpress.org/branches/5.8@51458
git-svn-id: http://core.svn.wordpress.org/branches/5.8@51069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This includes:
- Suggestion List: Check if a node exists to scroll into view.
- Autocomplete: reset state for empty text.
- Adds auxiliary class names for editor styles in the widgets editor.
- Extract snackbars into a separate component.
- Rich text: run input rules after composition end.
- iframe: load inline styles.
- Multi select: select all: restore ref callback.
- Writing flow: allow select all from empty selection.
- Post Excerpt: Fix excerpt_more filter conflict and remove wordCount attribute.
- Add the percent unit to the default units in Core.
Props desrosj, youknowriad.
Merges [51443] to the 5.8 branch.
Fixes#53397.
Built from https://develop.svn.wordpress.org/branches/5.8@51445
git-svn-id: http://core.svn.wordpress.org/branches/5.8@51056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
More testing has revealed that the `image_editor_output_format` filter has some interesting edge cases that developers should be aware of when electing to use this filter (see #53667 and #53668).
Because this is a new filter that was intended to be used for experimenting with different ways to handle generating image sizes and has not yet been adopted in the wild, expanding the inline documentation is an acceptable temporary solution while these edge cases are explored further and addressed.
Props mikeschroder, antpb, desrosj, adamsilverstein, ianmjones.
Merges [51442] to the 5.8 branch.
See #53667, #53668, #35725.
Built from https://develop.svn.wordpress.org/branches/5.8@51444
git-svn-id: http://core.svn.wordpress.org/branches/5.8@51055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This fixes a bug where widgets are unintentionally moved to the `wp_inactive_widgets` sidebar when batch updates occur through the REST API.
When batch requests are processed, only `$_wp_sidebars_widgets` is updated by previous calls to `WP_REST_Widgets_Controller::create_item()`. `$sidebars_widgets` is not aware of the new widget’s intended location, and `retrieve_widgets()` mistakenly flags the widget as inactive.
Calling `wp_get_sidebars_widgets()` before `retrieve_widgets()` ensures both global variables match and is intended as a temporary fix until the root cause of the problem can be fixed.
Props zieladam, htmgarcia, timothyblynjacobs.
Merges [51432] to the 5.8 branch.
Fixes#53657.
Built from https://develop.svn.wordpress.org/branches/5.8@51439
git-svn-id: http://core.svn.wordpress.org/branches/5.8@51050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This includes the following fixes:
- Safari: see if compositing layer size is more reasonable when position fixed divs are not inserted into content.
- Site Logo Block: update Site Logo block UI and option syncing.
- Fix moving inner blocks in the Widgets Customizer.
- Allow themes to provide empty values for color.duotone and spacing.units
- Update getTermsInfo() to workaround parsing issue for translatable strings.
- Specify what settings can be part of settings.layout.
- Update conditions to hide duotone panel.
- Prevent entering invalid values in the Query Loop block config.
- Prevent color panel from showing as empty.
- Avoid calling gutenberg_ functions within code shipped through WordPress Core.
Props desrosj, youknowriad.
Merges [51421] to the 5.8 branch.
Fixes#53397.
Built from https://develop.svn.wordpress.org/branches/5.8@51422
git-svn-id: http://core.svn.wordpress.org/branches/5.8@51033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Update the image links to use the CDN. Use regular text color for headings. Fix two string issues. Remove unnecessary wp-components script & style.
Use a larger image for theme.json on retina screens, and update the spacing of sections on the page.
Props nao, audrasjb, karmatosed, desrosj, javiarce, milana_cap.
Merges [51413] and [51418] to the 5.8 branch.
See #52775.
Built from https://develop.svn.wordpress.org/branches/5.8@51420
git-svn-id: http://core.svn.wordpress.org/branches/5.8@51031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This changes the references to `wp.editor` in the text widget’s JavaScript to `wp.oldEditor`, which is the new location for the old `editor` script that was previously available at `window.wp.editor`.
Follow up to [51387-51388,51390].
Props spacedmonkey, zieladam, SergeyBiryukov.
Merges [51409] to the 5.8 branch.
Fixes#53437.
Built from https://develop.svn.wordpress.org/branches/5.8@51416
git-svn-id: http://core.svn.wordpress.org/branches/5.8@51027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This switches `WP_REST_Sidebars_Controller` to use `wp_sidebar_description()` for retrieving the description of a given sidebar instead of referencing the value in the `$wp_registered_sidebars` global variable directly.
`wp_sidebar_description()` uses `wp_kses()` to only allow the default list of `$allowed_tags` to be present in a sidebar’s description.
Props timothyblynjacobs, desrosj, SergeyBiryukov.
Merges [51408] to the 5.8 branch.
Fixes#53646.
Built from https://develop.svn.wordpress.org/branches/5.8@51412
git-svn-id: http://core.svn.wordpress.org/branches/5.8@51023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
- Typo corrections in filter descriptions.
- DocBlocks are now now wrapped to the next line after 80 characters, and not extending beyond 120 total characters wide.
- Remove unnecessary repeated references to the suggested replacement hooks.
- Adjustments to the indentation for consistency with other emails in Core, allowing the `phpcs:ignore` comment to be removed.
Props SergeyBiryukov.
Merges [51410] to the 5.8 branch.
Fixes#44314.
Built from https://develop.svn.wordpress.org/branches/5.8@51411
git-svn-id: http://core.svn.wordpress.org/branches/5.8@51022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
- Add missing short description for the function.
- Correct function names in `_doing_it_wrong()` calls.
- Document the usage of `$wp_scripts` and `$wp_styles` globals.
- Update syntax for multi-line comment per the documentation standards.
Follow-up to [51387], [51388].
Props SergeyBiryukov.
Merges [51390] to the 5.8 branch.
See #53437, #53569.
Built from https://develop.svn.wordpress.org/branches/5.8@51394
git-svn-id: http://core.svn.wordpress.org/branches/5.8@51005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
It is common that plugins erroneously have `wp-editor` or `wp-edit-post` as a
dependency in a script that is loaded in the new widgets editor. This is a smell
since both `@wordpress/editor` and `@wordpress/edit-post` assume the existence
of a global "post" object which the widgets editor does not have.
[51387] fixes the user-facing errors typically caused by this mistake, but we
can go a step further and warn developers about this by calling
`_doing_it_wrong()` when we detect that the `wp-editor` script or `wp-edit-post`
style is enqueued alongside `wp-edit-widgets` or `wp-customize-widgets`.
Props zieladam, spacedmonkey, TimothyBlynJacobs, andraganescu, dlh, noisysocks.
Merges [51388] to the 5.8 branch.
Fixes#53569. See #53437.
Built from https://develop.svn.wordpress.org/branches/5.8@51393
git-svn-id: http://core.svn.wordpress.org/branches/5.8@51004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The `wp-editor` script (`@wordpress/editor` npm package) is exposed as
`window.wp.editor` in WP Admin. This causes problems, though, as many older
scripts expect to see the older `editor` script available at `window.wp.editor`.
The solution is to export all the members of the older `window.wp.editor` module
in the newer module to maintain backwards compatibility.
Props zieladam, spacedmonkey, TimothyBlynJacobs, andraganescu, noisysocks.
Merges [51387] to the 5.8 branch.
See #53437.
Built from https://develop.svn.wordpress.org/branches/5.8@51392
git-svn-id: http://core.svn.wordpress.org/branches/5.8@51003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit fixes an issue with the color.duotone & spacing.units in which empty values didn't override previous origins, resulting in that a theme couldn't provide an empty set for this via its theme.json.
Props nosolosw, youknowriad, aristath, jorgefilipecosta.
Merges [51383] to the 5.8 branch.
Fixes#53175.
Built from https://develop.svn.wordpress.org/branches/5.8@51386
git-svn-id: http://core.svn.wordpress.org/branches/5.8@50997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
When a widget is removed from a sidebar, if it was removed from the middle of the list, the widgets property would become an object with numeric keys.
The sidebars controller now forces the widgets property to be a list.
Props walbo, timothyblynjacobs.
Merges [51377] to the 5.8 branch.
Fixes#53612.
Built from https://develop.svn.wordpress.org/branches/5.8@51385
git-svn-id: http://core.svn.wordpress.org/branches/5.8@50996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This improves the logic within excerpt_remove_blocks() to better handle innerBlocks. This prevents an empty excerpt from being returned when core/columns, core/column, and core/group blocks are present.
This issue has been surfaced in the Query Loop block, where excerpts can be set to display.
This introduces the excerpt_allowed_wrapper_blocks filter for controlling which blocks should be considered wrapper blocks.
Wrapper blocks and their nested contents are not stripped by excerpt_remove_blocks(), allowing their contents to appear in generated excerpts.
Backports [51348], [51375], [51378], and [51379] to the 5.8 branch.
Fixes#53604.
Props aristath, jorbin, SergeyBiryukov, desrosj.
Unprops jorbin.
Built from https://develop.svn.wordpress.org/branches/5.8@51382
git-svn-id: http://core.svn.wordpress.org/branches/5.8@50993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This adds unit tests to ensure `get_block_editor_settings()` properly maps some previously experimental features to their correct locations in the array of contextualized block editor settings returned by the function.
Follow up to [51149], [51213].
Props felipeelia, SergeyBiryukov.
Merges [51369] to the 5.8 branch.
Fixes#53458.
Built from https://develop.svn.wordpress.org/branches/5.8@51376
git-svn-id: http://core.svn.wordpress.org/branches/5.8@50987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This removes an inline comment block that was added when importing the `WP_Theme_JSON` class in [50959]. The comment is relevant to the code only when viewed within the context of the Gutenberg plugin.
Props nosolosw, jorbin, SergeyBiryukov.
Merges [51352] to the 5.8 branch.
Fixes#53576.
Built from https://develop.svn.wordpress.org/branches/5.8@51364
git-svn-id: http://core.svn.wordpress.org/branches/5.8@50973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
