John Blackbourn
8bec516c18
Menus: Correct the docblocks for Walker_Nav_Menu
, wp_nav_menu()
, and walk_nav_menu_tree()
.
...
This corrects the parameter type for the `$args` and `$item` parameters passed throughout these functions, class methods, and hooks.
See #24587
See #35206
See #37770
Built from https://develop.svn.wordpress.org/trunk@38559
git-svn-id: http://core.svn.wordpress.org/trunk@38502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-07 16:15:30 +00:00
Jeremy Felt
c9e60dab17
Media: Sanitize upload filename.
...
Built from https://develop.svn.wordpress.org/trunk@38538
git-svn-id: http://core.svn.wordpress.org/trunk@38481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-07 13:55:36 +00:00
Andrea Fercia
4a06a09310
Widgets: Make the Delete/Remove links red.
...
For consistency and accessibility, all the UI controls that perform destructive
actions should be red.
Props monikarao, lukecavanagh, patilswapnilv, ibachal.
See #35622 .
Fixes #37016 .
Built from https://develop.svn.wordpress.org/trunk@38536
git-svn-id: http://core.svn.wordpress.org/trunk@38479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-07 09:52:30 +00:00
Dion Hulse
1dbef33d80
Bump Akismet External.
...
See #37961
git-svn-id: http://core.svn.wordpress.org/trunk@38477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-07 02:06:44 +00:00
Pascal Birchler
18a8cf475b
Revert [38401] after [38480].
...
See #36335 .
Built from https://develop.svn.wordpress.org/trunk@38535
git-svn-id: http://core.svn.wordpress.org/trunk@38476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-06 18:13:35 +00:00
Pascal Birchler
54720a14d8
Upgrade/Install: Sanitize file name in File_Upload_Upgrader
.
...
Built from https://develop.svn.wordpress.org/trunk@38524
git-svn-id: http://core.svn.wordpress.org/trunk@38465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-06 17:26:31 +00:00
Peter Wilson
4131900722
Menus: Add white space option to wp_nav_menu()
and wp_list_pages()
.
...
Adds an `item_spacing` option to the arguments array for the functions `wp_nav_menu()`, `wp_list_pages()`, and `wp_page_menu()`. `item_spacing` is a boolean accepting either `preserve` or `discard`.
Previously, certain CSS choices could result in a site's layout changing if `wp_nav_menu()` fell back to the default `wp_list_pages()` due to differences in the whitespace within the HTML. The new argument ensures a function outputs consistant HTML while maintaining backward compatibility.
Fixes #35206 .
Built from https://develop.svn.wordpress.org/trunk@38523
git-svn-id: http://core.svn.wordpress.org/trunk@38464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-06 09:06:31 +00:00
John Blackbourn
cfe941cd6f
Role/Capability: Correct the multisite cap tests after [38521].
...
See #35614
See #32394
Built from https://develop.svn.wordpress.org/trunk@38522
git-svn-id: http://core.svn.wordpress.org/trunk@38463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-05 12:09:30 +00:00
John Blackbourn
9cf899d6f9
Role/Capability: Split meta and primitive capabilities in the helper functions in the roles and capability tests so primitive capability tests can be made more accurate.
...
See #35614
See #32394
Built from https://develop.svn.wordpress.org/trunk@38521
git-svn-id: http://core.svn.wordpress.org/trunk@38462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-05 11:00:32 +00:00
Andrea Fercia
3c1d571cd7
Accessibility: Improve the Customizer and Theme Installer initial focus.
...
The Customizer and Theme Installer open in full overlays that need to receive
focus. Also, keyboard navigation should be constrained within the overlays. Using
CSS `visibility` to hide all the content except the overlays, makes them the only
available and focusable content and allows browsers to handle focus natively.
See #29158 .
Fixes #33228 , #27705 .
Built from https://develop.svn.wordpress.org/trunk@38520
git-svn-id: http://core.svn.wordpress.org/trunk@38461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-04 21:51:31 +00:00
Sergey Biryukov
2bb27252f9
Script Loader: Correct default value for $src
in wp_enqueue_script()
and wp_enqueue_style()
.
...
Props Frank Klein for initial patch.
See #37770 .
Built from https://develop.svn.wordpress.org/trunk@38519
git-svn-id: http://core.svn.wordpress.org/trunk@38460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-04 04:09:28 +00:00
Drew Jaynes
f0bb2bc3c0
Docs: Update the $message
parameter for _default_wp_die_handler()
to notate that it can also accept a WP_Error
object.
...
Additionally, update the `$message` parameter description in the DocBlock for `wp_die()` to make it explicitly clear messages derived from a passed `WP_Error` object will only be evaluated if not performing an Ajax or XML-RPC request (as both default handlers completely ignore `WP_Error` object messages).
See #37770 .
Built from https://develop.svn.wordpress.org/trunk@38518
git-svn-id: http://core.svn.wordpress.org/trunk@38459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-04 03:41:31 +00:00
Sergey Biryukov
59b186febd
Upload: Correct encoding issue in swfupload.js
, introduced in [29479].
...
See #29199 .
Built from https://develop.svn.wordpress.org/trunk@38517
git-svn-id: http://core.svn.wordpress.org/trunk@38458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-03 15:02:36 +00:00
John Blackbourn
d098687501
Taxonomy: Introduce some taxonomy capability tests in preparation for introducing more fine grained capabilities for terms.
...
See #35614
Built from https://develop.svn.wordpress.org/trunk@38516
git-svn-id: http://core.svn.wordpress.org/trunk@38457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-03 02:15:36 +00:00
Jeremy Felt
58bca49227
Multisite: Deprecate wp_get_network()
.
...
`wp_get_network()` was converted into a wrapper for `get_network()` in 4.6.0 and can now be deprecated.
This moves `wp_get_network()` to the bottom of `ms-load.php` as `ms-deprecated.php` is not available early enough.
Props PieWP, flixos90.
Fixes #37553 .
Built from https://develop.svn.wordpress.org/trunk@38515
git-svn-id: http://core.svn.wordpress.org/trunk@38456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-02 23:48:31 +00:00
John Blackbourn
a3b581ce64
Embeds: Clarify some assertion failure messages and correct a test URL for Twitter timelines.
...
See #32360
Built from https://develop.svn.wordpress.org/trunk@38514
git-svn-id: http://core.svn.wordpress.org/trunk@38455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-02 22:53:30 +00:00
Weston Ruter
91f583c9af
Customize: Fix php warning due to WP_Customize_Manager::prepare_setting_validity_for_js()
incorrectly assuming that WP_Error
will only ever have arrays in its $error_data
.
...
* Eliminates the server mutating the a `WP_Error`'s `$error_data` to merge-in a `$from_server` flag (since it may not be an array to begin with). Instead it defers to the client to add a `fromServer` param on any `Notification` instances created from server-sent errors.
* Ensures that notifications will be re-rendered if a notification's `message` changes but the `data` and `type` remain the same.
* Adds explicit support for the `Notification` class to have a `setting` property, ensuring that the property is set whereas previously it was dropped.
Fixes #37890 .
Props westonruter, dlh.
Built from https://develop.svn.wordpress.org/trunk@38513
git-svn-id: http://core.svn.wordpress.org/trunk@38454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-02 22:35:44 +00:00
John Blackbourn
2559ade0ae
Embeds: Update the oEmbed provider test suite.
...
* Remove the manual flag for HTTPS support and replace it with a simple check on the URL format.
* Ensure `testOembedTestsCoverAllProviders()` actually fails when a new provider is added without a corresponding test.
See #32360
Built from https://develop.svn.wordpress.org/trunk@38512
git-svn-id: http://core.svn.wordpress.org/trunk@38453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-02 21:36:44 +00:00
Aaron Jorbin
dd983343d3
Formatting: Allow KSES custom elements with hyphens
...
The W3C Custom Elements spec (http://www.w3.org/TR/custom-elements/#concepts ) allows you to use your own custom DOM elements/tags. One of the main requirements is that the tag name "must contain a U+002D HYPHEN-MINUS character". This adjusts KSES to allow it.
Fixes #34105 .
Props batmoo.
Built from https://develop.svn.wordpress.org/trunk@38511
git-svn-id: http://core.svn.wordpress.org/trunk@38452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-02 04:16:28 +00:00
Sergey Biryukov
e318b5bf1d
I18N: Add translator comments for XML-RPC strings with placeholders.
...
See #37792 .
Built from https://develop.svn.wordpress.org/trunk@38510
git-svn-id: http://core.svn.wordpress.org/trunk@38451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-02 04:13:28 +00:00
Aaron Jorbin
7a8f0f10ad
Text Changes: Improve Error messages in XML-RPC
...
Three changes to the error message strings:
* add some missing periods.
* merge similar translation strings.
* remove the "Something wrong happened" suffix.
Fixes #37792 .
Props ramiy.
Built from https://develop.svn.wordpress.org/trunk@38509
git-svn-id: http://core.svn.wordpress.org/trunk@38450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-02 03:57:28 +00:00
Aaron Jorbin
17f21e28f9
Toolbar: Add unit tests for edit links.
...
When there is no post ID, there should be no edit link. This adds unit tests for it.
Fixes #22247 .
Props akibjorklund.
Built from https://develop.svn.wordpress.org/trunk@38508
git-svn-id: http://core.svn.wordpress.org/trunk@38449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-02 03:51:29 +00:00
Gary Pendergast
0cff37abf5
Database: Find the correct table names in DELETE
queries with table aliases
...
Previously, `wpdb::get_table_from_query()` would not find the correct table name in the query `DELETE a FROM table a`, due to not recognising the table alias immediately after the `DELETE` as correct syntax.
Fixes #37660 .
Built from https://develop.svn.wordpress.org/trunk@38507
git-svn-id: http://core.svn.wordpress.org/trunk@38448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-02 00:19:28 +00:00
Gary Pendergast
75c1875587
Shortcodes: Add the pre_do_shortcode_tag
filter.
...
This filter allows the shortcode generation process to be short-circuited, so expensive short codes can be cached and returned immediately.
Props ideag.
Fixes #37906 .
Built from https://develop.svn.wordpress.org/trunk@38506
git-svn-id: http://core.svn.wordpress.org/trunk@38447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-02 00:10:28 +00:00
Sergey Biryukov
8682603166
Docs: Correct @since
entry for the smilies
filter added in [38504].
...
See #35905 .
Built from https://develop.svn.wordpress.org/trunk@38505
git-svn-id: http://core.svn.wordpress.org/trunk@38446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-02 00:08:30 +00:00
Gary Pendergast
cce2ffaed5
Smilies: Add the smilies
filter.
...
This new filter allows the smilies array to be modified with a filter, instead of having to directly access the global.
Props mte90, jorbin.
Fixes #35905 .
Built from https://develop.svn.wordpress.org/trunk@38504
git-svn-id: http://core.svn.wordpress.org/trunk@38445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-02 00:00:30 +00:00
Andrea Fercia
c01c23c4f7
Accessibility: Make links in the Customizer underlined by default.
...
Links within lines or blocks of text should always be underlined since they can't
rely on color alone to be distinguished from the surrounding text. Exceptions
can be handled on a case-by-case basis.
Props Presskopp for the initial patch.
Fixes #37527 .
Built from https://develop.svn.wordpress.org/trunk@38503
git-svn-id: http://core.svn.wordpress.org/trunk@38444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 22:02:30 +00:00
Aaron Jorbin
22e6d59c67
Administration: Use a bool when when a bool is called for
...
The third parameter of `date_i18n` is a bool. Currently, it's a weak check, otherwise the call showing the universal time on the "General Settings" screen would be messed up. Use an actual bool so we call our own functions correctly.
Fixes #37634 .
Props fronaldaraujo.
Built from https://develop.svn.wordpress.org/trunk@38502
git-svn-id: http://core.svn.wordpress.org/trunk@38443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 18:34:28 +00:00
Aaron Jorbin
93ad7eab80
Administration: Use #fff instead of white
...
Cleans up a few places where the CSS coding standards were not being followed.
Fixes #37576 .
Props Presskopp, johnpgreen, netweb
Built from https://develop.svn.wordpress.org/trunk@38501
git-svn-id: http://core.svn.wordpress.org/trunk@38442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 18:14:31 +00:00
Boone Gorges
77a3cc733e
Query: 'orderby=include' should support comma-separated lists.
...
[30052] assumed that 'include' would be an array.
Props TimothyBlynJacobs.
Fixes #37904 .
Built from https://develop.svn.wordpress.org/trunk@38500
git-svn-id: http://core.svn.wordpress.org/trunk@38441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 16:51:30 +00:00
Gary Pendergast
4babadb704
Bootstrap: class-wp-locale.php
needs to be require_once()
-ed.
...
After [38364], the inclusion of `class-wp-locale.php` was changed from a `require_once()` to a `require()`. This caused problems for anything that called `load_text_domain_early()` prior to the `require()` but didn't bail, as it was now being `require()`-ed a second time.
With the use of `require_once()`, it doesn't really matter where it's loaded, so it has been moved next to the related `l10n.php` load.
See #37827 .
Built from https://develop.svn.wordpress.org/trunk@38496
git-svn-id: http://core.svn.wordpress.org/trunk@38437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 12:36:28 +00:00
Sergey Biryukov
616eb41287
Docs: Move term_description()
reference from filter docblock to get_the_archive_description()
function docblock.
...
Props dlh.
See #37259 .
Built from https://develop.svn.wordpress.org/trunk@38495
git-svn-id: http://core.svn.wordpress.org/trunk@38436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 12:32:28 +00:00
Sergey Biryukov
2b5d7555b4
Users: After [33766], don't reset the password when clicking "Show Password" and then "Cancel" on Add New User screen.
...
Props smerriman for reporting.
Fixes #37902 . See #33419 .
Built from https://develop.svn.wordpress.org/trunk@38494
git-svn-id: http://core.svn.wordpress.org/trunk@38435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 12:24:29 +00:00
Sergey Biryukov
7aa79d3705
Template: After [38486], actually use the $description
variable in get_the_archive_description()
.
...
Props dlh.
Fixes #37259 .
Built from https://develop.svn.wordpress.org/trunk@38493
git-svn-id: http://core.svn.wordpress.org/trunk@38434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 11:47:30 +00:00
Weston Ruter
94e8a9cfa0
Customize: Introduce paneVisible
state and ensure pane is visible when a construct is expanded (or focused).
...
Fixes issue whereby a user would see nothing happen if the pane is collapsed while they shift-click to edit an element in the preview.
Props curdin, celloexpressions, westonruter.
See #27403 .
Fixes #36678 .
Built from https://develop.svn.wordpress.org/trunk@38492
git-svn-id: http://core.svn.wordpress.org/trunk@38433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 05:55:27 +00:00
Dion Hulse
227a80eba3
Query: Use AND
in a SQL query rather than &&
.
...
This appears to have been the only instance of `&&` being used in SQL, so for consistency lets remove it.
Props scrappy@hub.org .
Fixes #37903 .
Built from https://develop.svn.wordpress.org/trunk@38491
git-svn-id: http://core.svn.wordpress.org/trunk@38432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 05:11:31 +00:00
John Blackbourn
69c152cee7
Taxonomy: Correct the function description for wp_ajax_add_link_category()
.
...
See #37770
Built from https://develop.svn.wordpress.org/trunk@38490
git-svn-id: http://core.svn.wordpress.org/trunk@38431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 00:49:29 +00:00
John Blackbourn
01c3ae084b
Taxonomy: Update various docs for parameters which are now WP_Term
objects.
...
See #37770
See #14162
Built from https://develop.svn.wordpress.org/trunk@38489
git-svn-id: http://core.svn.wordpress.org/trunk@38430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 00:40:29 +00:00
Sergey Biryukov
bfe8ba91b6
Template: In get_the_archive_description()
, add support for author archives.
...
Props henry.wright.
Fixes #37259 .
Built from https://develop.svn.wordpress.org/trunk@38486
git-svn-id: http://core.svn.wordpress.org/trunk@38427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 23:01:29 +00:00
Sergey Biryukov
a4f8854a46
Taxonomy: Introduce wp_insert_term_data
and wp_update_term_data
filters for altering term data before it is inserted/updated in the database.
...
Props atimmer, SergeyBiryukov.
Fixes #22293 .
Built from https://develop.svn.wordpress.org/trunk@38484
git-svn-id: http://core.svn.wordpress.org/trunk@38425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 21:41:27 +00:00
Andrea Fercia
c451e71d42
Text Changes: Improve the timezone setting description in General Settings.
...
Makes more clear users can set either a city or a UTC timezone offset.
Props GrantDerepas, andrew.p.
Fixes #34789 .
Built from https://develop.svn.wordpress.org/trunk@38483
git-svn-id: http://core.svn.wordpress.org/trunk@38424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 21:37:27 +00:00
John Blackbourn
14e40fd20c
Role/Capability: Add two missing meta capabilities to the caps tests.
...
See #32394
Built from https://develop.svn.wordpress.org/trunk@38482
git-svn-id: http://core.svn.wordpress.org/trunk@38423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 21:34:30 +00:00
Sergey Biryukov
a2582f50cc
Users: Pass $profileuser
parameter to user_profile_picture_description
filter on "Edit User" screen.
...
Props turtlepod, deremohan.
Fixes #37379 .
Built from https://develop.svn.wordpress.org/trunk@38481
git-svn-id: http://core.svn.wordpress.org/trunk@38422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 21:13:32 +00:00
Scott Taylor
f1631f4e03
Bootstrap: goodnight sweet prince.
...
See #36335 .
Built from https://develop.svn.wordpress.org/trunk@38480
git-svn-id: http://core.svn.wordpress.org/trunk@38421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 20:36:30 +00:00
Weston Ruter
03adca4299
Customize: Fix i18n by re-using the add_new_item
post type label instead of using a post type name in a generic string.
...
Props afercia, westonruter.
See #34923 .
Fixes #37895 .
Built from https://develop.svn.wordpress.org/trunk@38479
git-svn-id: http://core.svn.wordpress.org/trunk@38420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 19:15:28 +00:00
Weston Ruter
bce5ea9494
Customize: Use new $status_code
parameter for wp_send_json_error()
instead of calling status_header()
separately.
...
Props johnbillion.
See #35666 .
Fixes #37897 .
Built from https://develop.svn.wordpress.org/trunk@38478
git-svn-id: http://core.svn.wordpress.org/trunk@38419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 19:01:28 +00:00
Sergey Biryukov
b4aaf3925d
Login and Registration: Change login label to Username or Email Address
for clarity.
...
Props GaryJ.
Fixes #37871 .
Built from https://develop.svn.wordpress.org/trunk@38477
git-svn-id: http://core.svn.wordpress.org/trunk@38418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 18:51:28 +00:00
Sergey Biryukov
fe12301ca9
Help/About: Remove an outdated help sentence on "My Sites" screen.
...
Props johnjamesjacoby.
Fixes #37896 .
Built from https://develop.svn.wordpress.org/trunk@38474
git-svn-id: http://core.svn.wordpress.org/trunk@38415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 17:44:29 +00:00
Scott Taylor
af71985625
Query: r38356, you were not long for this world.
...
Fixes #37830 .
Built from https://develop.svn.wordpress.org/trunk@38471
git-svn-id: http://core.svn.wordpress.org/trunk@38412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 16:53:29 +00:00
Scott Taylor
a3ffebce30
Bootstrap: do not go gentle into that good night r38411, r38412, and parts of r38389.
...
See #36335 .
Built from https://develop.svn.wordpress.org/trunk@38470
git-svn-id: http://core.svn.wordpress.org/trunk@38411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 16:31:29 +00:00