Dominik Schilling
974ca19e36
Customizer: Improve JS templates for Panels and Sections added in [32658].
...
* Always fall back to using the default template if no custom template exists.
* Provide a set of default params when constructing new `Section` and `Panel` objects.
Includes QUnit tests.
Props celloexpressions, westonruter, ocean90.
Fixes #30737 .
Built from https://develop.svn.wordpress.org/trunk@32681
git-svn-id: http://core.svn.wordpress.org/trunk@32651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 22:47:25 +00:00
Andrew Ozz
02f5020d52
Editor: run autosave when pressing Ctrl or Command + S in the Text editor, same as the Visual editor.
...
Fixes #31655 .
Built from https://develop.svn.wordpress.org/trunk@32680
git-svn-id: http://core.svn.wordpress.org/trunk@32650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 19:02:25 +00:00
Andrew Ozz
1c0419071f
Emoji: make sure we parse only strings or DOM nodes that have children.
...
Props peterwilsoncc. Fixes #32300 .
Built from https://develop.svn.wordpress.org/trunk@32679
git-svn-id: http://core.svn.wordpress.org/trunk@32649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 18:25:25 +00:00
Andrew Ozz
4f9682f39e
TinyMCE wpView: preserve HTML wrapped in shortcodes.
...
Fixes #32078 .
Built from https://develop.svn.wordpress.org/trunk@32678
git-svn-id: http://core.svn.wordpress.org/trunk@32648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 18:09:26 +00:00
Andrew Ozz
b3d04247b7
Editor:
...
- Remove the old DFW.
- Add back-compat stub for wp-fullscreen.js.
- Keep wp_ajax_wp_fullscreen_save_post() for now.
See #30949 .
Built from https://develop.svn.wordpress.org/trunk@32677
git-svn-id: http://core.svn.wordpress.org/trunk@32647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 17:38:29 +00:00
Sergey Biryukov
ecf0bcc9fc
Revert a part of [32673] that caused a fatal error with SCRIPT_DEBUG
disabled.
...
see #19257 .
Built from https://develop.svn.wordpress.org/trunk@32676
git-svn-id: http://core.svn.wordpress.org/trunk@32646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 04:14:25 +00:00
Sergey Biryukov
3fc78a1109
Avoid a PHP notice in wp_enqueue_media()
if $post
is null.
...
see #19257 .
Built from https://develop.svn.wordpress.org/trunk@32675
git-svn-id: http://core.svn.wordpress.org/trunk@32645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 21:54:25 +00:00
John Blackbourn
ff3f2ac243
Remove an embed handler accidentally introduced in r32673.
...
Built from https://develop.svn.wordpress.org/trunk@32674
git-svn-id: http://core.svn.wordpress.org/trunk@32644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 16:56:26 +00:00
John Blackbourn
02192cb53f
Introduce featured_image
, set_featured_image
, remove_featured_image
, and use_featured_image
post type labels when registering a post type in order to override the 'Featured Image' text and its related phrases.
...
Props johnbillion, mordauk, valendesigns.
Fixes #19257 .
Built from https://develop.svn.wordpress.org/trunk@32673
git-svn-id: http://core.svn.wordpress.org/trunk@32643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 16:54:27 +00:00
Scott Taylor
42d51a4f89
Add doc blocks to functions that are missing them.
...
If the function has no need for `@param` or `@return`, do an archeaological dig to find `@since`.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32672
git-svn-id: http://core.svn.wordpress.org/trunk@32642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 03:18:25 +00:00
Drew Jaynes
9cb1017b3c
Fix inline documentation formatting in wp-admin/includes/admin-filters.php, introduced in [32653].
...
See #32529 .
Built from https://develop.svn.wordpress.org/trunk@32671
git-svn-id: http://core.svn.wordpress.org/trunk@32641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 02:00:26 +00:00
Drew Jaynes
0df0e0bf36
Fix syntax and add a missing return description for inline documentation introduced in [32644] for WP_Users_List_Table
.
...
See #25408 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32670
git-svn-id: http://core.svn.wordpress.org/trunk@32640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:45:27 +00:00
Drew Jaynes
65f31bc52e
Fix syntax and add missing return descriptions for inline documentation introduced in [32644] for WP_Terms_List_Table
.
...
See #25408 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32669
git-svn-id: http://core.svn.wordpress.org/trunk@32639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:44:26 +00:00
Drew Jaynes
a69f867738
Fix syntax and add missing return descriptions for inline documentation introduced in [32644] for WP_Posts_List_Table
.
...
See #25408 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32668
git-svn-id: http://core.svn.wordpress.org/trunk@32638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:42:25 +00:00
Drew Jaynes
5e2983a77e
Fix formatting and add a missing return description for inline documentation introduced in [32644] for WP_Plugins_List_Table
.
...
See #25408 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32667
git-svn-id: http://core.svn.wordpress.org/trunk@32637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:40:29 +00:00
Drew Jaynes
d7428fc35d
Fix formatting and add missing return descriptions for inline documentation introduced in [32644] for WP_MS_Users_List_Table
.
...
See #25408 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32666
git-svn-id: http://core.svn.wordpress.org/trunk@32636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:38:26 +00:00
Drew Jaynes
5e84c7004d
Fix syntax and add a missing return description for inline documentation introduced in [32644] for WP_MS_Themes_List_Table
.
...
See #25408 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32665
git-svn-id: http://core.svn.wordpress.org/trunk@32635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:36:27 +00:00
Drew Jaynes
88569734d8
Fix formatting and add missing return descriptions for inline documentation introduced in [32644] for WP_MS_Sites_List_Table
.
...
See #25408 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32664
git-svn-id: http://core.svn.wordpress.org/trunk@32634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:34:25 +00:00
Drew Jaynes
42afe1d373
Fix formatting and add a missing return description for inline documentation introduced in [32644] for WP_Media_List_Table
.
...
See #25408 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32663
git-svn-id: http://core.svn.wordpress.org/trunk@32633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:32:26 +00:00
Drew Jaynes
8bcf53cc68
Fix formatting and add missing return descriptions for inline documenation introduced in [32644] for WP_List_Table
.
...
Also fixes an error introduced in [32661] for `WP_Links_List_Table`.
See #25408 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32662
git-svn-id: http://core.svn.wordpress.org/trunk@32632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:29:26 +00:00
Drew Jaynes
2a0048b1fb
Fix formatting and add a missing return description for inline documentation introduced in [32644] for WP_Links_List_Table
.
...
See #25408 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32661
git-svn-id: http://core.svn.wordpress.org/trunk@32631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:23:26 +00:00
Drew Jaynes
5457eb4933
Add missing return descriptions and fix formatting of inline documentation introduced in [32644].
...
See #25408 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32660
git-svn-id: http://core.svn.wordpress.org/trunk@32630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:18:26 +00:00
Boone Gorges
4b546044d8
Term unit test factory class should override create_and_get()
method.
...
The override is necessary because the `get_term()` call, which fetches the
term object, needs the `'taxonomy'` argument passed to the factory method.
Props dlh.
Fixes #32536 .
Built from https://develop.svn.wordpress.org/trunk@32659
git-svn-id: http://core.svn.wordpress.org/trunk@32629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-30 13:04:25 +00:00
Weston Ruter
98b03d376e
Add JS templates for Customizer Panels and Sections.
...
This extends the approach taken for Customizer Controls in #29572 .
Props celloexpressions, westonruter, ocean90.
See #30737 .
Built from https://develop.svn.wordpress.org/trunk@32658
git-svn-id: http://core.svn.wordpress.org/trunk@32628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-30 00:03:30 +00:00
Scott Taylor
c502a281bb
After [32656], add @access
annotations to methods that have no doc block in wp-includes/*
.
...
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32657
git-svn-id: http://core.svn.wordpress.org/trunk@32627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 21:37:24 +00:00
Scott Taylor
6a08b00632
Add @access
annotations to methods that have no doc block in wp-admin/includes/*
.
...
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32656
git-svn-id: http://core.svn.wordpress.org/trunk@32626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 21:32:24 +00:00
Scott Taylor
b3e0cfd25d
Add (more) missing doc blocks to wp-admin/includes/*
.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32655
git-svn-id: http://core.svn.wordpress.org/trunk@32625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 21:17:27 +00:00
Scott Taylor
c6a4512b1b
Add missing doc blocks to wp-admin/includes/*
.
...
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32654
git-svn-id: http://core.svn.wordpress.org/trunk@32624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 20:17:26 +00:00
Scott Taylor
a51dfa3971
In the style of #30947 and default-filters.php
, add 2 new files to wp-admin/includes
:
...
`admin-filters.php`
`ms-admin-filters.php`
There are random actions and filters littered among files like `misc.php`. These files contain functions that won't work outside of admin context and are typically only loaded in files that have already loaded the admin bootstrap.
See #32529 .
Built from https://develop.svn.wordpress.org/trunk@32653
git-svn-id: http://core.svn.wordpress.org/trunk@32623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 17:04:26 +00:00
Scott Taylor
9a29d8ac7b
Add missing annotations to
ajax-actions.php`
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32652
git-svn-id: http://core.svn.wordpress.org/trunk@32622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 16:01:27 +00:00
Helen Hou-Sandí
f5646cd9e5
Define a primary column for WP_Post_Comments_List_Table
.
...
props boonebgorges.
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@32651
git-svn-id: http://core.svn.wordpress.org/trunk@32621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 15:52:25 +00:00
Scott Taylor
19a3aacc94
Add @static*
annotations where they are missing.
...
Initialize all static vars that are not, most to `null`.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32650
git-svn-id: http://core.svn.wordpress.org/trunk@32620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 15:43:29 +00:00
Dominik Schilling
fccc19b510
Customizer: Replace accordion behavior of sections with a slide-in navigation.
...
This allows users to focus on the contents of the active section more easily and separating the navigation from the content/controls in the Customizer.
props valendesigns, celloexpressions.
see #31336 .
Built from https://develop.svn.wordpress.org/trunk@32649
git-svn-id: http://core.svn.wordpress.org/trunk@32619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 13:57:26 +00:00
Boone Gorges
ebac76facc
When parsing what appears to be a date archive request, check for a post with a clashing permalink before resolving to the archive.
...
A URL like `example.com/2015/05/15/` generally resolves to the May 15, 2015 date
archive. But in certain cases, it could also be the permalink of a post with
the slug `'2015'`. When a conflict of this sort is detected, resolve to the post
instead of the archive.
URL conflicts of this sort should no longer occur for new posts; see [32647].
Props valendesigns, boonebgorges, Denis-de-Bernardy.
Fixes #5305 .
Built from https://develop.svn.wordpress.org/trunk@32648
git-svn-id: http://core.svn.wordpress.org/trunk@32618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 13:10:24 +00:00
Boone Gorges
9f0c6cbf8c
Disallow post slugs that will result in permalinks that conflict with date archive URLs.
...
On certain permalink structures, a numeric post slug will result in a post
permalink that conflicts with a date archive URL. For example, with permastruct
`/%year%/%monthnum%/%postname%/`, a post published in May 2015 with slug
`'15'` will result in a URL (`/2015/05/15/`) that conflicts with the archive
for May 15, 2015.
To avoid this problem, `wp_unique_post_slug()` rejects a requested slug when it
would generate a conflict of this type. Thus, in our example, `'15'` would
become `'15-2'`.
Props valendesigns, boonebgorges, Denis-de-Bernardy, loushou.
See #5305 .
Built from https://develop.svn.wordpress.org/trunk@32647
git-svn-id: http://core.svn.wordpress.org/trunk@32617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 12:53:24 +00:00
Boone Gorges
66d76318b8
is_email_address_unsafe()
tests should only be run on multisite.
...
See [32638].
Built from https://develop.svn.wordpress.org/trunk@32646
git-svn-id: http://core.svn.wordpress.org/trunk@32616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 12:38:30 +00:00
Helen Hou-Sandí
fbb83441cb
After [32644], sanity for a pile of selectors.
...
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@32645
git-svn-id: http://core.svn.wordpress.org/trunk@32615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 03:00:26 +00:00
Helen Hou-Sandí
4c0c7fd7ba
List tables: introduce the concept of a "primary" column.
...
This becomes the column that contains the row actions, and allows for a more flexibility, particularly with custom post types and list tables. To (re)define the primary column, use the `list_table_primary_column` filter, which receives the column name and the screen ID as arguments.
props stephdau, DaveAl, jesin.
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@32644
git-svn-id: http://core.svn.wordpress.org/trunk@32614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 02:41:25 +00:00
Scott Taylor
282e28ad81
Add @global
annotations to (the rest of the?) wp-admin/*
files.
...
Does not include list table file changes.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32643
git-svn-id: http://core.svn.wordpress.org/trunk@32613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 02:06:31 +00:00
Scott Taylor
b56b9b3e5c
Add @global
annotations for wp-admin/*
.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32642
git-svn-id: http://core.svn.wordpress.org/trunk@32612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 21:41:30 +00:00
Scott Taylor
6ab487dde6
Add missing/alter existing doc blocks for wp-db.php
.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32641
git-svn-id: http://core.svn.wordpress.org/trunk@32611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 20:10:29 +00:00
Scott Taylor
2f3e567f44
Alter visibility of some properties in wpdb
:
...
`num_queries` is accessed publicly in core.
`num_rows` is accessed publicly in `ms-settings.php`.
`insert_id` is accessed publicly in core.
`prefix` is accessed publicly in `upgrade.php` and `capabilities.php`.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32640
git-svn-id: http://core.svn.wordpress.org/trunk@32610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 16:34:25 +00:00
Scott Taylor
bece996d45
Add missing doc blocks to widgets.php
.
...
Cleanup `@return` values.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32639
git-svn-id: http://core.svn.wordpress.org/trunk@32609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 16:20:25 +00:00
Boone Gorges
b1c2305aa1
Improve tests for is_email_address_unsafe()
.
...
* Move to a separate file for better organization and method names.
* Use a `dataProvider` when appropriate, for better readability.
* Add a test for splitting the banned domain list on line breaks.
See #20459 , #21730 .
Built from https://develop.svn.wordpress.org/trunk@32638
git-svn-id: http://core.svn.wordpress.org/trunk@32608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 16:06:27 +00:00
Scott Taylor
d38fed6449
Add missing doc blocks to user.php
.
...
`username_exists()` should return `false` instead of `null`, just like `email_exists()` does, which is right under it.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32637
git-svn-id: http://core.svn.wordpress.org/trunk@32607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 15:51:25 +00:00
Helen Hou-Sandí
abfece527b
About: Give bottom navigation links the full width.
...
This will prevent longer strings from wrapping needlessly, and is more semantically correct markup.
props tyxla.
fixes #32391 .
Built from https://develop.svn.wordpress.org/trunk@32636
git-svn-id: http://core.svn.wordpress.org/trunk@32606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 15:39:24 +00:00
Scott Taylor
66a9c83284
Add missing doc blocks to update.php
:
...
* `wp_version_check()`, `wp_update_plugins()`, and `wp_update_themes()` do not return meaningful responses, and their responses are never handled by core. As such, they shouldn't alternately return `void` or `false`. "Returning" in those functions is just "bailing"
* In the same functions, `version.php` doesn't need to load if `WP_INSTALLING` is defined - the function will immediately bail, the values will never be read, and the globals won't be reset. I have unified the approach in all 3 functions.
* When returning filtered `$locale`, there is no need to set the variable twice.
* In `_maybe_update_core()`, `isset()` can take multiple values to bail before the call to `time()`, if necessary. This is a micro-optimization to prevent PHP from hitting the OS unnecessarily.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32635
git-svn-id: http://core.svn.wordpress.org/trunk@32605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 15:29:28 +00:00
Jeremy Felt
f1ff34e547
Use a dataProvider for network option sanitization tests.
...
Cleans up tests for sanitization of `illegal_names`, `illegal_email_domains`, and `banned_email_domains` network options.
Fixes #32517 .
Built from https://develop.svn.wordpress.org/trunk@32634
git-svn-id: http://core.svn.wordpress.org/trunk@32604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 06:38:25 +00:00
Andrew Nacin
6df83c542b
Revert change to default-filters.php in [32632]. see #32516 .
...
Built from https://develop.svn.wordpress.org/trunk@32633
git-svn-id: http://core.svn.wordpress.org/trunk@32603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 05:52:25 +00:00
Andrew Nacin
65c382d550
Fix return
error in get_theme_mods() from [32629].
...
Split a line with both an assignment and a conditional, not to mention an interpolated variable. Lots going on, easy mistake to make.
props BrianLayman.
fixes #32516 .
Built from https://develop.svn.wordpress.org/trunk@32632
git-svn-id: http://core.svn.wordpress.org/trunk@32602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 05:51:25 +00:00