Scott Taylor
a5478d7adb
Let us pray to the gods of backwards compatibility:
...
* The way that the JS modules for media are currently set up turns the existing global `wp.media` namespace into a read-only API, this is bad.
* For the existing module implementation to work with plugins, those looking to override or extend a class would have to modify their own plugin to use `browserify` - we can't expect this to happen
* Because the general way that plugins override media classes is via machete (resetting them to something else), we cannot use `require( 'module' )` in the internal code for media modules
We CAN continue to use `require( 'fun/js' )` in the manifests for media.
Future code/projects should carefully consider what is made to be public API. In 3.5, EVERYTHING was made public, so everything shall remain public.
See #31684 , #28510 .
Built from https://develop.svn.wordpress.org/trunk@31935
git-svn-id: http://core.svn.wordpress.org/trunk@31914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 02:03:29 +00:00
Lance Willett
57918dfc8f
Twenty Fifteen: adjust scroll behavior to make sure sidebar height is calculated during scroll events, not just resize events.
...
Fixes #31734 . Props jartes, lancewillett.
Built from https://develop.svn.wordpress.org/trunk@31934
git-svn-id: http://core.svn.wordpress.org/trunk@31913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 22:49:27 +00:00
Dominik Schilling
289db2d37b
Customizer: Revert [31911]. We want to preserve url
and return
URL parameters to make the experience smoother.
...
see #31782 .
Built from https://develop.svn.wordpress.org/trunk@31933
git-svn-id: http://core.svn.wordpress.org/trunk@31912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 19:22:26 +00:00
Lance Willett
b8e58b3352
Twenty Thirteen: make sure submenu links work correctly on small screens with touch events.
...
Fixes #31762 , props davidhamiltron.
Built from https://develop.svn.wordpress.org/trunk@31932
git-svn-id: http://core.svn.wordpress.org/trunk@31911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 19:20:27 +00:00
Andrew Ozz
b5643f9a13
TinyMCE wpView: add back the removal of selected views on inserting new content. Was removed when reverting the first fix for embedding of pasted URLs.
...
Props mattheu. Fixes #31796 .
Built from https://develop.svn.wordpress.org/trunk@31931
git-svn-id: http://core.svn.wordpress.org/trunk@31910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 18:22:27 +00:00
Sergey Biryukov
e70e4e74fa
Press This: Use the error message returned by wp_update_post()
instead of a generic one.
...
props stephdau.
fixes #31808 .
Built from https://develop.svn.wordpress.org/trunk@31930
git-svn-id: http://core.svn.wordpress.org/trunk@31909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 14:39:26 +00:00
Sergey Biryukov
cd2e63700e
Use a more specific selector for comment moderation hotkeys after [31513].
...
props afercia.
fixes #31545 .
Built from https://develop.svn.wordpress.org/trunk@31929
git-svn-id: http://core.svn.wordpress.org/trunk@31908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 13:54:26 +00:00
Sergey Biryukov
43a99e0f1b
Make sure the update button in "At a Glance" dashboard widget does not overlap with long strings.
...
props SergeyBiryukov, afercia, tyxla.
fixes #30766 .
Built from https://develop.svn.wordpress.org/trunk@31928
git-svn-id: http://core.svn.wordpress.org/trunk@31907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 12:50:29 +00:00
Sergey Biryukov
a1dbd97adb
Fix duplicate ID for Save Menu button on Menus screen.
...
props sagarjadhav.
fixes #31803 .
Built from https://develop.svn.wordpress.org/trunk@31927
git-svn-id: http://core.svn.wordpress.org/trunk@31906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 09:49:26 +00:00
Gary Pendergast
3ddbef69e3
Emoji: When encoding emoji into HTML entities, 0 was being incorrectly trimmed from the right side of the hex string, causing some characters to be encoded incorrectly.
...
Built from https://develop.svn.wordpress.org/trunk@31926
git-svn-id: http://core.svn.wordpress.org/trunk@31905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 03:27:31 +00:00
Andrew Ozz
6cd9c9645e
Press This: fix accessibility for the post options "sidebar". Fix size of the Add Category button.
...
Part props afercis, joedolson. Fixes #31575 .
Built from https://develop.svn.wordpress.org/trunk@31925
git-svn-id: http://core.svn.wordpress.org/trunk@31904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 03:09:51 +00:00
Gary Pendergast
31db5d08fe
Emoji: When staticizing emoji into <img>
tags, include an alt
attribute of the original Emoji, to match both Smiley and Twemoji <img>
tags.
...
Built from https://develop.svn.wordpress.org/trunk@31924
git-svn-id: http://core.svn.wordpress.org/trunk@31903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 03:09:26 +00:00
Andrew Ozz
8ff664171d
Remove unused vars. See #31627 .
...
Built from https://develop.svn.wordpress.org/trunk@31923
git-svn-id: http://core.svn.wordpress.org/trunk@31902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 02:50:27 +00:00
Andrew Ozz
f128f08c2c
TinyMCE emoji: catch the inserting of emoji chars with the Windows 8 onscreen keyboard and replace if needed.
...
Fixes #31627 .
Built from https://develop.svn.wordpress.org/trunk@31922
git-svn-id: http://core.svn.wordpress.org/trunk@31901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 02:39:28 +00:00
Dominik Schilling
7bc60fed4a
Customizer: Increase initial-scale viewport specification to 1.0.
...
see #31794 , #28784 .
Built from https://develop.svn.wordpress.org/trunk@31921
git-svn-id: http://core.svn.wordpress.org/trunk@31900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-29 12:23:27 +00:00
Dominik Schilling
b07e3e2de7
Customizer: Fix calculation of panel positions when accessing via deep-links.
...
Make sure that the parent `li` is shown before attempting to calculate its position.
Improve also the logic for focusing on a panel to prevent focusing hidden elements.
props westonruter.
fixes #31014 .
see #31794 .
Built from https://develop.svn.wordpress.org/trunk@31920
git-svn-id: http://core.svn.wordpress.org/trunk@31899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-29 11:17:28 +00:00
Andrew Ozz
71f48f45e0
Press This:
...
- When saving, replace emoji images with chars in the title text.
- Clean up the title text on paste.
See #31768 .
Built from https://develop.svn.wordpress.org/trunk@31919
git-svn-id: http://core.svn.wordpress.org/trunk@31898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-29 03:14:28 +00:00
Dominik Schilling
96b88a391b
Theme Switcher: Use the global panel back button instead of adding a new one.
...
This ensures the back button is visible on iOS devices. Same as in [29610].
see #31794 .
Built from https://develop.svn.wordpress.org/trunk@31918
git-svn-id: http://core.svn.wordpress.org/trunk@31897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-28 22:09:26 +00:00
Dominik Schilling
7875dd4853
Customizer: Increase size of search field and disable text size adjustment to prevent auto zooming.
...
see #31794 .
Built from https://develop.svn.wordpress.org/trunk@31917
git-svn-id: http://core.svn.wordpress.org/trunk@31896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-28 21:03:27 +00:00
Dominik Schilling
80972b7ecd
Customizer: Fix selector for container which includes the controls. Broken since [30102].
...
see #31794 , #31014 .
Built from https://develop.svn.wordpress.org/trunk@31916
git-svn-id: http://core.svn.wordpress.org/trunk@31895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-28 20:47:30 +00:00
Dominik Schilling
2c036f589e
Remove a stray > introduced in [31905].
...
see #31776 .
Built from https://develop.svn.wordpress.org/trunk@31915
git-svn-id: http://core.svn.wordpress.org/trunk@31894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-27 23:20:27 +00:00
Dominik Schilling
ee2829959a
Theme Switcher: Opening themes details modal shouldn't require two clicks on touch devices.
...
Inspired by [26838].
see #31794 .
Built from https://develop.svn.wordpress.org/trunk@31914
git-svn-id: http://core.svn.wordpress.org/trunk@31893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-27 22:54:29 +00:00
Dominik Schilling
d51fded34c
Customizer: Use responsive button styles if screen is max-width 640px.
...
see #31794 , #28784 .
Built from https://develop.svn.wordpress.org/trunk@31913
git-svn-id: http://core.svn.wordpress.org/trunk@31892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-27 22:17:30 +00:00
Dominik Schilling
2dfb835751
Theme Switcher: Don't hide action buttons on narrow screens.
...
see #31794 .
Built from https://develop.svn.wordpress.org/trunk@31912
git-svn-id: http://core.svn.wordpress.org/trunk@31891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-27 21:53:27 +00:00
Dominik Schilling
2e314d764e
Customizer: Use proper preview URL for Live Preview links.
...
props mattwiebe.
fixes #31782 .
Built from https://develop.svn.wordpress.org/trunk@31911
git-svn-id: http://core.svn.wordpress.org/trunk@31890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-27 20:36:27 +00:00
Helen Hou-Sandí
007665e7be
Admin menu: Revert [31720] for swipe open/closed.
...
This is problematic on any device that uses swipe for history navigation, particularly iOS. It's also quite unrefined from an interaction point of view and would not be material for this release either way.
see #31187 .
Built from https://develop.svn.wordpress.org/trunk@31910
git-svn-id: http://core.svn.wordpress.org/trunk@31889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-27 17:48:30 +00:00
Gary Pendergast
bfb9990548
Emoji: [31864] changed emoji image's inline style from height
to max-height
. Unfortunately, anything using feedparser.py
(for example, NewsBlur) strips out max-height
, which gives us massive emoji in feeds.
...
This re-adds `height`, and also reminds us why we can't have nice things.
See #31719 .
Built from https://develop.svn.wordpress.org/trunk@31909
git-svn-id: http://core.svn.wordpress.org/trunk@31888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-27 02:12:28 +00:00
Andrew Ozz
321b551650
Fix focusing in the plugin and theme editors. Update the help.
...
Props afercia, Cheffheid. Fixes #31415 .
Built from https://develop.svn.wordpress.org/trunk@31908
git-svn-id: http://core.svn.wordpress.org/trunk@31887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 22:35:27 +00:00
Andrew Ozz
f663dc73d4
Press This: remove role="application"
from the Categories list wrapper. This doesn't make it work better in screen readers.
...
See #31443 .
Built from https://develop.svn.wordpress.org/trunk@31907
git-svn-id: http://core.svn.wordpress.org/trunk@31886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 21:49:32 +00:00
Dominik Schilling
8daaa09c9b
Improve newly added strings for i18n:
...
* Add context to "Format" string.
* Use "Format" with context for "Post format".
see #31776 .
Built from https://develop.svn.wordpress.org/trunk@31906
git-svn-id: http://core.svn.wordpress.org/trunk@31885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 21:19:26 +00:00
Dominik Schilling
55519962cc
Improve newly added strings for i18n:
...
* Use a placeholder for the theme name to be able to reorder words.
* Uppercase D for "Theme Details" to match existing strings.
* Merge two revision date formats.
* Add translator comment to strings with placeholders.
props obenland.
see #31776 .
Built from https://develop.svn.wordpress.org/trunk@31905
git-svn-id: http://core.svn.wordpress.org/trunk@31884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 20:56:26 +00:00
Dominik Schilling
e283270dbe
End "Update failed" with a full stop.
...
see #29820 .
Built from https://develop.svn.wordpress.org/trunk@31904
git-svn-id: http://core.svn.wordpress.org/trunk@31883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 19:09:27 +00:00
Drew Jaynes
fa8ac2fa8c
Post-beta3 bump.
...
Built from https://develop.svn.wordpress.org/trunk@31903
git-svn-id: http://core.svn.wordpress.org/trunk@31882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 18:37:27 +00:00
Drew Jaynes
34fd9811b2
WordPress 4.2-beta3
...
Built from https://develop.svn.wordpress.org/trunk@31902
git-svn-id: http://core.svn.wordpress.org/trunk@31881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 18:15:27 +00:00
Aaron Jorbin
48db232317
Remove Shiny Plugin Install strings
...
See #31773 , #29820
Built from https://develop.svn.wordpress.org/trunk@31901
git-svn-id: http://core.svn.wordpress.org/trunk@31880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 18:03:28 +00:00
Aaron Jorbin
4c05e8c71c
More clean up from removal of Shiny Plugin Installs
...
See #31773 , #29820
Unprops Jorbin, Pento
Built from https://develop.svn.wordpress.org/trunk@31900
git-svn-id: http://core.svn.wordpress.org/trunk@31879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 16:30:27 +00:00
Dominik Schilling
502c70ec99
Remove <code>
tags from translatable strings.
...
Uncomment deprecation notice for `get_bloginfo( 'text_direction' )`, see [14360].
props ramiy, DrewAPicture.
fixes #30614 .
Built from https://develop.svn.wordpress.org/trunk@31899
git-svn-id: http://core.svn.wordpress.org/trunk@31878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 15:17:28 +00:00
Andrew Ozz
62c3c1d798
Fix initialization of wp-emoji in IE8.
...
Props pento, azaozz. Fixes #31701 .
Built from https://develop.svn.wordpress.org/trunk@31898
git-svn-id: http://core.svn.wordpress.org/trunk@31877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 02:40:28 +00:00
Aaron Jorbin
9b23faef07
Remove Shiny Plugin Installs
...
See #31773 , #29820
Built from https://develop.svn.wordpress.org/trunk@31897
git-svn-id: http://core.svn.wordpress.org/trunk@31876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 02:30:28 +00:00
Boone Gorges
60c26865f9
Check that $_POST
array index is set before comparing it in post_preview()
.
...
This prevents PHP notices in cases where a user with 'edit_others_posts' but
without 'publish_posts' previews another user's posts.
Props tyxla.
Fixes #31760 .
Built from https://develop.svn.wordpress.org/trunk@31896
git-svn-id: http://core.svn.wordpress.org/trunk@31875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 01:45:26 +00:00
Boone Gorges
bc3d8197aa
When saving post, ensure that non-hierarchical taxonomy input is defined before attempting to parse it.
...
Taxonomy metaboxes that are disabled for the current user are included in the
post.php markup, but do not contain the 'newtag' field, and so should be
skipped when looping through the metaboxes to avoid invoking String methods
on a variable of type `undefined`.
Props MikeNGarrett, A5hleyRich.
Fixes #30859 .
Built from https://develop.svn.wordpress.org/trunk@31895
git-svn-id: http://core.svn.wordpress.org/trunk@31874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 01:23:28 +00:00
Andrew Ozz
6cc20e7095
Press This: on sites that support oEmbed, if the user has selected some text, quote it below the embed.
...
Props stephdau. Fixes #31763 .
Built from https://develop.svn.wordpress.org/trunk@31894
git-svn-id: http://core.svn.wordpress.org/trunk@31873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 01:17:26 +00:00
Dominik Schilling
de7ecc80d3
Customizer: [31885] actually hasn't fixed the SecurityError
s. This one does.
...
props mattwiebe.
fixes #31687 .
Built from https://develop.svn.wordpress.org/trunk@31893
git-svn-id: http://core.svn.wordpress.org/trunk@31872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 23:36:27 +00:00
Dominik Schilling
f333f9ef11
Customizer Theme Switcher: Reset font size of theme names in overlay. Apply left position only to themes section.
...
see #31303 .
Built from https://develop.svn.wordpress.org/trunk@31892
git-svn-id: http://core.svn.wordpress.org/trunk@31871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 22:58:27 +00:00
Drew Jaynes
79f58d9d40
Clarify the DocBlock summary for wp_scheduled_delete()
to mention that it includes posts of any type where the 'trash' status is used.
...
Props dkotter for the initial patch.
Fixes #31757 .
Built from https://develop.svn.wordpress.org/trunk@31891
git-svn-id: http://core.svn.wordpress.org/trunk@31870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 22:45:27 +00:00
Dominik Schilling
51854c53b4
Improve alignment of labels and inputs in Quick Edit.
...
props mattheu, valendesigns.
fixes #31408 .
Built from https://develop.svn.wordpress.org/trunk@31890
git-svn-id: http://core.svn.wordpress.org/trunk@31869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 22:25:26 +00:00
Dominik Schilling
5ef13b688e
Comments List: Don't let "Quick Edit" break on smaller screens.
...
Other class-wp-*-list-table.php files already contain a non-breaking space for the Quick Edit row action.
props kraftbj.
fixes #31482 .
Built from https://develop.svn.wordpress.org/trunk@31889
git-svn-id: http://core.svn.wordpress.org/trunk@31868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 22:15:27 +00:00
Andrew Ozz
1b2d93fbca
TinyMCE: make sure the editor is not completely empty before checking if the user clicked above or below a wpView.
...
Fixes #31765 .
Built from https://develop.svn.wordpress.org/trunk@31888
git-svn-id: http://core.svn.wordpress.org/trunk@31867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 18:55:29 +00:00
Dominik Schilling
4fbba16960
Avoid a PHP notice in wp_enqueue_script()
if $handle is an array.
...
Calling `wp_enqueue_script()` with an array as the first argument is a "hidden feature" and should be avoided. Use dependencies instead.
props sorich87 for initial patch.
fixes #31636 .
see #14488 .
Built from https://develop.svn.wordpress.org/trunk@31887
git-svn-id: http://core.svn.wordpress.org/trunk@31866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 17:55:27 +00:00
Dominik Schilling
29907e5f8b
Text Widget: Use !empty()
for checking if the filter setting is set.
...
props westonruter.
fixes #31690 .
Built from https://develop.svn.wordpress.org/trunk@31886
git-svn-id: http://core.svn.wordpress.org/trunk@31865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 17:34:28 +00:00