Peter Wilson
a56256d158
Site Health Check: Increase time allowance for cron checks.
...
Introduces `WP_Site_Health::has_late_cron()` for late wp-cron jobs and extends the time allowance before a job is considered missed.
In a standard configuration using loopback requests, a job is considered late once past due and missed over five minutes past due.
Late and missed time frames are extended if `DISABLE_WP_CRON` is defined as `true` to allow for crontab tasks running less frequently. A job is considered late once it's 15 minutes past due and missed over one hour past due.
A file for site health unit tests has been introduced with tests for cron in critical, late and missed states.
Props rockfire, afragen, peterwilsoncc.
Fixes #47223 .
Built from https://develop.svn.wordpress.org/trunk@45801
git-svn-id: http://core.svn.wordpress.org/trunk@45612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-15 00:35:55 +00:00
Gary Pendergast
b8c5530131
Build Tools: Change the PHPUnit Docker image's working directory to match the other images.
...
Also, pass the `WP_MULTISITE` environment variable along to the container.
See #47767 .
Built from https://develop.svn.wordpress.org/trunk@45800
git-svn-id: http://core.svn.wordpress.org/trunk@45611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-15 00:34:57 +00:00
Gary Pendergast
b473b2241e
Build Tools: Run composer
commands in a Docker container on Travis.
...
This tidies up the `.travis.yml` file a little more.
See #47767 .
Built from https://develop.svn.wordpress.org/trunk@45799
git-svn-id: http://core.svn.wordpress.org/trunk@45610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-14 23:12:55 +00:00
Sergey Biryukov
cc8e05df39
Widgets: Allow for short-circuiting widget output in the_widget()
using the widget_display_callback
filter, for consistency with output via a registered sidebar.
...
Props MarcGuay, donmhico.
Fixes #34226 .
Built from https://develop.svn.wordpress.org/trunk@45798
git-svn-id: http://core.svn.wordpress.org/trunk@45609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-14 23:03:55 +00:00
Sergey Biryukov
0e1343ee2b
Docs: Correct type for query_var
argument of register_taxonomy()
.
...
Props juiiee8487, audrasjb.
Fixes #47877 .
Built from https://develop.svn.wordpress.org/trunk@45797
git-svn-id: http://core.svn.wordpress.org/trunk@45608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-14 17:47:55 +00:00
Sergey Biryukov
c03a0bea8d
Posts, Post Types: In wp_trim_words()
make sure the $num_words
parameter is always an integer, as documented, to avoid a PHP warning.
...
Props donmhico, pikamander2.
Fixes #47867 .
Built from https://develop.svn.wordpress.org/trunk@45796
git-svn-id: http://core.svn.wordpress.org/trunk@45607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-14 17:18:55 +00:00
Sergey Biryukov
ae4087bca6
Users: Make wp_list_authors()
unit tests more readable.
...
See #23498 .
Built from https://develop.svn.wordpress.org/trunk@45795
git-svn-id: http://core.svn.wordpress.org/trunk@45606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-14 15:36:57 +00:00
Sergey Biryukov
d6faa62338
Networks and Sites: Improve documentation and variable naming in switch_to_blog()
and restore_current_blog()
.
...
In `switch_to_blog()`:
* Rename `$blog_id` to `$prev_blog_id` for clarity.
* Rename `$new_blog` to `$new_blog_id` for consistency.
* Pass `$prev_blog_id` as a second parameter to `switch_blog` action, instead of the duplicated `$new_blog_id`. This only clarifies documentation and does not affect functionality, since the values are equal in the context where the DocBlock is located.
In `restore_current_blog()`:
* Rename `$blog` to `$new_blog_id` for clarity.
* Rename `$blog_id` to `$prev_blog_id` for clarity.
Props ChriCo, jeremyfelt, SergeyBiryukov.
Fixes #45594 .
Built from https://develop.svn.wordpress.org/trunk@45794
git-svn-id: http://core.svn.wordpress.org/trunk@45605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-14 14:29:56 +00:00
Sergey Biryukov
428a738f1d
Plugins: Adjust the pause before running plugin search AJAX request on "Add Plugins" screen to allow more time for using browser's autocomplete.
...
Props donmhico, apermo.
Fixes #46021 .
Built from https://develop.svn.wordpress.org/trunk@45793
git-svn-id: http://core.svn.wordpress.org/trunk@45604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-14 02:02:56 +00:00
Sergey Biryukov
3ce3927dc1
Coding Standards: Fix JSHint error in [45790].
...
See #41545 .
Built from https://develop.svn.wordpress.org/trunk@45792
git-svn-id: http://core.svn.wordpress.org/trunk@45603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-14 00:02:55 +00:00
Sergey Biryukov
4cf729f5a9
Site Health: Simplify the language in Status Health Info page introduction, add a link to Status page.
...
Props birgire, mukesh27, subrataemfluence, leogermani.
Fixes #46946 .
Built from https://develop.svn.wordpress.org/trunk@45791
git-svn-id: http://core.svn.wordpress.org/trunk@45602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-13 23:35:56 +00:00
Adam Silverstein
3e605d3852
Comments: enable typing cmd/ctrl-enter to submit comment forms.
...
Add a key handler on the comment form that detects the cmd/ctrl-enter key press and submits the comment form.
Props xyfi, Lindstromer, helen, splitti.
Fixes #41545 .
Built from https://develop.svn.wordpress.org/trunk@45790
git-svn-id: http://core.svn.wordpress.org/trunk@45601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-13 21:26:56 +00:00
Andrew Ozz
400ed5add0
Remove trailing white space in upgrade.php.
...
See #46349 .
Built from https://develop.svn.wordpress.org/trunk@45789
git-svn-id: http://core.svn.wordpress.org/trunk@45600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-13 19:53:55 +00:00
Andrew Ozz
197b4a829b
Admin email verification:
...
- Add the `admin_email_lifespan` option when installing. Fixes a bug where the verification screen is shown right after installation.
- Reset the same option when upgrading and the user doing the DB upgrade is not an admin. This will ensure the email verification is shown next time an admin logs in.
- Use `site_url()` instead of `network_site_url()` for the form action. The latter seems needed only for password reset.
See #46349 .
Built from https://develop.svn.wordpress.org/trunk@45788
git-svn-id: http://core.svn.wordpress.org/trunk@45599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-13 17:40:55 +00:00
Peter Wilson
dc2e7e716f
Comments: Include post permalink in comment reply link.
...
Include the post's permalink when generating reply links in `get_comment_reply_link()` to account for comments displayed on index and archive pages.
This reapplies [32786] which was inadvertently reverted in [42360].
Props justinahinon, donmhico.
See #33383 .
Fixes #47174 .
Built from https://develop.svn.wordpress.org/trunk@45787
git-svn-id: http://core.svn.wordpress.org/trunk@45598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-13 05:09:56 +00:00
K. Adam White
aa90dc4e8c
Docs: Clarify custom-fields support requirement for viewing custom post meta in REST API.
...
Fixes #47866 .
Built from https://develop.svn.wordpress.org/trunk@45786
git-svn-id: http://core.svn.wordpress.org/trunk@45597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-13 01:51:56 +00:00
Gary Pendergast
28ad3662fc
Build Tools: Remove the old docker-compose.yml
file, now no longer used.
...
See #47767 .
Built from https://develop.svn.wordpress.org/trunk@45785
git-svn-id: http://core.svn.wordpress.org/trunk@45596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-12 09:22:55 +00:00
Gary Pendergast
20f833426a
Build Tools: Add the docker-compose.yml
file, missed in [45783].
...
See #47767 .
Built from https://develop.svn.wordpress.org/trunk@45784
git-svn-id: http://core.svn.wordpress.org/trunk@45595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-12 09:21:56 +00:00
Gary Pendergast
74d03c4692
Build Tools: Miscellaneous local-env
improvements.
...
- Move the functionality for controlling `local-env` out of `package.json`, into JS scripts.
- Merge the `docker-compose` config files, and move it to the root directory. This allows `docker-compose.override.yml` to work for local overrides.
- Fix nginx redirecting to port 80 under some circumstances.
- `npm run env:install` now creates `wp-tests.config.php` for you.
- Cleaned up a bunch of cruft in `.travis.yml`.
See #47767 .
Built from https://develop.svn.wordpress.org/trunk@45783
git-svn-id: http://core.svn.wordpress.org/trunk@45594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-12 08:29:55 +00:00
Sergey Biryukov
99f4ff2578
Site Health: Add database charset and collation information to debug info.
...
Props sharaz, Clorith, SergeyBiryukov.
Fixes #47828 .
Built from https://develop.svn.wordpress.org/trunk@45782
git-svn-id: http://core.svn.wordpress.org/trunk@45593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-12 01:54:57 +00:00
Sergey Biryukov
e6a4b884f5
Docs: Improve documentation for various feed link functions and filters.
...
Props atachibana, SergeyBiryukov.
Fixes #47862 .
Built from https://develop.svn.wordpress.org/trunk@45781
git-svn-id: http://core.svn.wordpress.org/trunk@45592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-11 17:21:57 +00:00
Sergey Biryukov
b7e7a5321b
Docs: Improve documentation for get_last_updated()
.
...
Props atachibana.
Fixes #47861 .
Built from https://develop.svn.wordpress.org/trunk@45780
git-svn-id: http://core.svn.wordpress.org/trunk@45591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-11 16:18:57 +00:00
Sergey Biryukov
80d153fb70
Docs: Improve documentation for get_page_by_title()
.
...
Props atachibana.
Fixes #47860 .
Built from https://develop.svn.wordpress.org/trunk@45779
git-svn-id: http://core.svn.wordpress.org/trunk@45590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-11 12:42:56 +00:00
Sergey Biryukov
64290005f5
Docs: Document the show_split_view
argument for wp_text_diff()
.
...
Convert `$args` array documentation to hash notation.
Props riddhiehta02, jeremyfelt, SergeyBiryukov.
Fixes #47224 .
Built from https://develop.svn.wordpress.org/trunk@45778
git-svn-id: http://core.svn.wordpress.org/trunk@45589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-10 22:28:54 +00:00
whyisjake
1a9812d9b4
Widgets: Replace http with https in the link placeholder widget image
...
The existing placeholder can make the user think that they must use http. We should encourage the use of https.
Also, the block editor uses https for its placeholders. Let's add some consistency.
Props Chaton666, audrasjb, mukesh27.
Fixes #46320 .
Built from https://develop.svn.wordpress.org/trunk@45777
git-svn-id: http://core.svn.wordpress.org/trunk@45588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-09 17:06:55 +00:00
Sergey Biryukov
6e060079ae
Twenty Sixteen: Correct HelpHub URL in readme.txt
.
...
See #47771 .
Built from https://develop.svn.wordpress.org/trunk@45776
git-svn-id: http://core.svn.wordpress.org/trunk@45587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-09 13:53:56 +00:00
Sergey Biryukov
092872c3fc
Twenty Nineteen: Add missing Installation
section to readme.txt
, for consistency with other themes.
...
See #47857 .
Built from https://develop.svn.wordpress.org/trunk@45775
git-svn-id: http://core.svn.wordpress.org/trunk@45586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-09 13:42:57 +00:00
Sergey Biryukov
aaea839402
Twenty Nineteen: Add missing copyright information.
...
Props poena, kjellr.
Fixes #47857 .
Built from https://develop.svn.wordpress.org/trunk@45774
git-svn-id: http://core.svn.wordpress.org/trunk@45585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-09 13:36:58 +00:00
Sergey Biryukov
441a3c97e0
Twenty Nineteen: Correct license URI.
...
Props munyagu, shital-patel.
Fixes #47850 .
Built from https://develop.svn.wordpress.org/trunk@45773
git-svn-id: http://core.svn.wordpress.org/trunk@45584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-09 02:57:59 +00:00
Gary Pendergast
12aa773802
Feeds: Introduce the get_self_link()
function.
...
Corresponds to the `self_link()` template function.
This matches other feed template functions, using one function to get the value, and a different function to echo it.
Props jojotjebaby, mobeen-abdullah, donmhico, audrasjb, dshanske.
Fixes #44838 .
Built from https://develop.svn.wordpress.org/trunk@45772
git-svn-id: http://core.svn.wordpress.org/trunk@45583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-09 01:31:56 +00:00
Sergey Biryukov
2aa8ce5bc5
REST API: In get_rest_url()
, check if $_SERVER['SERVER_NAME']
is set to avoid a PHP warning in CLI context.
...
Props paulschreiber.
Fixes #47854 .
Built from https://develop.svn.wordpress.org/trunk@45771
git-svn-id: http://core.svn.wordpress.org/trunk@45582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-08 20:20:55 +00:00
Sergey Biryukov
6041a08347
Bootstrap/Load: Change "Insufficient Requirements" wp_die()
heading to "Requirements Not Met", which is more appropriate for the context it's used in.
...
Props yoavf.
Fixes #47575 .
Built from https://develop.svn.wordpress.org/trunk@45770
git-svn-id: http://core.svn.wordpress.org/trunk@45581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-08 12:54:56 +00:00
Gary Pendergast
638bae9392
Emoji: Upgrade Twemoji to 12.1.2.
...
This upgrade adds support for the transgender flag: 🏳️⚧️
There's some additional housekeeping in this commit:
- Twemoji recently rearranged their repository and package, so `Gruntfile.js` needed tweaking to allow for that.
- As only new files were added in this Twemoji release, the CDN version didn't need updating.
Fixes #47852 .
Built from https://develop.svn.wordpress.org/trunk@45769
git-svn-id: http://core.svn.wordpress.org/trunk@45580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-08 04:05:55 +00:00
Sergey Biryukov
83187125e4
Bundled Themes: Audit and update version numbers passed to wp_enqueue_script()
to ensure proper cache busting.
...
Props dswebsme, ianbelanger, justinahinon.
Fixes #46981 .
Built from https://develop.svn.wordpress.org/trunk@45768
git-svn-id: http://core.svn.wordpress.org/trunk@45579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-08 01:29:58 +00:00
Sergey Biryukov
e0563013ed
Bundled Themes: Audit and update version numbers passed to wp_enqueue_style()
to ensure proper cache busting.
...
Props dswebsme, ianbelanger, desrosj.
Fixes #46979 .
Built from https://develop.svn.wordpress.org/trunk@45767
git-svn-id: http://core.svn.wordpress.org/trunk@45578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-08 01:25:58 +00:00
Sergey Biryukov
c965d2e097
Administration: Show a warning in Reading Settings when a Privacy Policy page is accidentally set as a Homepage or Posts page.
...
Props garrett-eclipse, subrataemfluence.
Fixes #46831 .
Built from https://develop.svn.wordpress.org/trunk@45766
git-svn-id: http://core.svn.wordpress.org/trunk@45577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 23:03:54 +00:00
Aaron Jorbin
b8fd2b631b
Bump grunt-patch-wordpress to 2.0.0
...
Fixes #47845
Props pento, kadamwhite, netweb, jorbin
Built from https://develop.svn.wordpress.org/trunk@45765
git-svn-id: http://core.svn.wordpress.org/trunk@45576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 15:09:57 +00:00
Sergey Biryukov
aa4ab3acdc
Twenty Seventeen: Correct height for a Button block without text.
...
Props ianbelanger, laurelfulford, nayana123.
Fixes #47414 .
Built from https://develop.svn.wordpress.org/trunk@45764
git-svn-id: http://core.svn.wordpress.org/trunk@45575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 11:57:54 +00:00
Sergey Biryukov
64202a7ca3
Twenty Eleven: Correct height for a Button block without text.
...
Props ianbelanger, laurelfulford, nayana123.
See #47414 .
Built from https://develop.svn.wordpress.org/trunk@45763
git-svn-id: http://core.svn.wordpress.org/trunk@45574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 11:56:57 +00:00
Gary Pendergast
d5d58a90f9
Build Tools: Switch all Travis PHPUnit jobs over to Docker-based PHP.
...
Additionally, there are a handful of related minor changes in this commit:
- `.travis.yml` has been tidied up a little.
- [45745] was incorrectly marking Travis jobs as passed when some PHPUnit runs failed.
- Add the `LOCAL_PHP_MEMCACHED` environment variable, for enabling Memcached.
- Add the `env:pull` NPM script, for refreshing Docker images.
See #47767 .
Built from https://develop.svn.wordpress.org/trunk@45762
git-svn-id: http://core.svn.wordpress.org/trunk@45573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 11:55:57 +00:00
Sergey Biryukov
de099aec14
Twenty Nineteen: Revise Latest Posts block styles to support post content options.
...
Props kjellr, ianbelanger.
Fixes #47340 .
Built from https://develop.svn.wordpress.org/trunk@45761
git-svn-id: http://core.svn.wordpress.org/trunk@45572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 11:48:57 +00:00
Sergey Biryukov
72b11e3322
Twenty Nineteen: Remove duplicate height
and width
attributes from SVG icons.
...
The attributes are added via `TwentyNineteen_SVG_Icons::get_svg()`, there's no need to have them separately in SVG sources.
Props mukesh27, albertomake.
Fixes #47128 .
Built from https://develop.svn.wordpress.org/trunk@45760
git-svn-id: http://core.svn.wordpress.org/trunk@45571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 11:41:54 +00:00
Sergey Biryukov
32afb6f7c7
Coding Standards: Use strict comparison in wp-admin/edit.php
.
...
Props davidbaumwald.
Fixes #47201 .
Built from https://develop.svn.wordpress.org/trunk@45759
git-svn-id: http://core.svn.wordpress.org/trunk@45570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 11:40:55 +00:00
Andrew Ozz
52c53ae6f8
Remove trailing white space in upgrade.php after [45757].
...
See #46349 .
Built from https://develop.svn.wordpress.org/trunk@45758
git-svn-id: http://core.svn.wordpress.org/trunk@45569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 01:01:57 +00:00
Andrew Ozz
fff56d219f
Add admin email verification screen. Shown every six months after an admin has logged in.
...
Also includes WPCS fixes for wp-login.php.
Props andraganescu, boemedia, lessbloat, azaozz.
See #46349 .
Built from https://develop.svn.wordpress.org/trunk@45757
git-svn-id: http://core.svn.wordpress.org/trunk@45568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 00:04:56 +00:00
Sergey Biryukov
e081194455
Administration: Correct "Quick Edit" link height in list tables for consistency with other action links.
...
Props jobthomas, burhandodhy.
Fixes #47815 .
Built from https://develop.svn.wordpress.org/trunk@45756
git-svn-id: http://core.svn.wordpress.org/trunk@45567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 22:20:58 +00:00
Sergey Biryukov
e4f1204e04
Coding Standards: Fix WPCS violation in [45754].
...
See #46570 .
Built from https://develop.svn.wordpress.org/trunk@45755
git-svn-id: http://core.svn.wordpress.org/trunk@45566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 18:10:59 +00:00
Sergey Biryukov
282dfee8e0
General: Correctly detect large floats in is_serialized()
.
...
Props killerbishop, donmhico, hoythan.
Fixes #46570 .
Built from https://develop.svn.wordpress.org/trunk@45754
git-svn-id: http://core.svn.wordpress.org/trunk@45565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 13:55:57 +00:00
Sergey Biryukov
d5fc1647c0
Feeds: Escape &
characters in atom_site_icon()
for XML, for consistency with rss2_site_icon()
.
...
Props abhijitrakas, shawfactor.
Fixes #47482 .
Built from https://develop.svn.wordpress.org/trunk@45753
git-svn-id: http://core.svn.wordpress.org/trunk@45564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 13:15:56 +00:00
Sergey Biryukov
2ac34c799b
Coding Standards: Use strict comparison in wp-admin/options-reading.php
.
...
Props subrataemfluence.
Fixes #46834 .
Built from https://develop.svn.wordpress.org/trunk@45752
git-svn-id: http://core.svn.wordpress.org/trunk@45563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 12:52:56 +00:00