Commit Graph

3469 Commits

Author SHA1 Message Date
Andrea Fercia
f86d225d26 Accessibility: Improve and modernize user interface controls: Improve new styles for the color picker.
Props audrasjb, garrett-eclipse.
Fixes #48131.

Built from https://develop.svn.wordpress.org/trunk@46360


git-svn-id: http://core.svn.wordpress.org/trunk@46159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 18:05:59 +00:00
antpb
6531c237e7 Media: Prevents clipping of text when scaling image edit screen.
This reapplies [46354] clean as the previous commit had remnants of an unrelated patch.

Props sabernhardt, audrasjb, afercia.
See #47115.

Built from https://develop.svn.wordpress.org/trunk@46359


git-svn-id: http://core.svn.wordpress.org/trunk@46158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 17:56:57 +00:00
Andrea Fercia
6566808e8a Accessibility: Improve and modernize user interface controls: Improve the new form controls styles and heights.
Improves cross-browsers rendering and addresses most of the reported edge cases.

See #47477.

Built from https://develop.svn.wordpress.org/trunk@46356


git-svn-id: http://core.svn.wordpress.org/trunk@46155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 17:24:59 +00:00
antpb
247e7eb7d5 Media: Revert [46354] preventing bad clipping of text in image details page.
See #47115.

Built from https://develop.svn.wordpress.org/trunk@46355


git-svn-id: http://core.svn.wordpress.org/trunk@46154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 17:12:59 +00:00
antpb
7c8028febf Media: Prevents clipping of text when scaling image edit screen.
Props sabernhardt, audrasjb, afercia.
See #47115.

Built from https://develop.svn.wordpress.org/trunk@46354


git-svn-id: http://core.svn.wordpress.org/trunk@46153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 16:34:58 +00:00
Andrea Fercia
20e781f44d Accessibility: Improve and modernize user interface controls: Remove the CSS transform 1 pixel shift from the buttons active state.
Props Joen.
See #34904.

Built from https://develop.svn.wordpress.org/trunk@46350


git-svn-id: http://core.svn.wordpress.org/trunk@46149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 10:53:57 +00:00
Andrea Fercia
dfcdb40c8f Accessibility: Improve and modernize user interface controls: Improve the radio buttons blue dot alignment.
Props desrosj, garrett-eclipse, afercia.
See #47498.

Built from https://develop.svn.wordpress.org/trunk@46345


git-svn-id: http://core.svn.wordpress.org/trunk@46144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-29 21:56:56 +00:00
Andrea Fercia
8ef586a897 Accessibility: Improve and modernize user interface controls: Make the secondary buttons border blue.
Props drw158, youknowriad, kjellr, melchoyce, talldanwp, audrasjb.
See #34904.

Built from https://develop.svn.wordpress.org/trunk@46344


git-svn-id: http://core.svn.wordpress.org/trunk@46143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-29 21:53:57 +00:00
Andrea Fercia
55b1dc642e Accessibility: After [46337]: make the select elements background white also on hover, active, and focus states.
See #47477.
See #48128.

Built from https://develop.svn.wordpress.org/trunk@46340


git-svn-id: http://core.svn.wordpress.org/trunk@46139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-28 16:45:57 +00:00
Andrea Fercia
7d769a9234 Accessibility: Improve and modernize user interface controls. Style the select elements disabled state.
Props adhitya03, MarcosAlexandre, kjellr.
See #47477.
Fixes #48129.

Built from https://develop.svn.wordpress.org/trunk@46339


git-svn-id: http://core.svn.wordpress.org/trunk@46138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-28 16:35:59 +00:00
Andrew Ozz
dd44ab5a58 Fix the context (right-click) menu when clicking the placeholder for the post title field on the classic Edit Post screen.
Props masummdar, audrasjb, afercia.
Fixes #47318.
Built from https://develop.svn.wordpress.org/trunk@46338


git-svn-id: http://core.svn.wordpress.org/trunk@46137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-28 16:20:57 +00:00
Andrea Fercia
becc682bcf Accessibility: Improve and modernize user interface controls. Make the select elements background white.
Props adhitya03.
See #47477.
Fixes #48128.

Built from https://develop.svn.wordpress.org/trunk@46337


git-svn-id: http://core.svn.wordpress.org/trunk@46136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-28 16:15:59 +00:00
whyisjake
b6f7c0cbc4 Administration: Ensure visual consistency with large titles in the sidebar.
Custom posts, and other menu titles that are long aren't wrapping correctly.

Props jagirbaheshwp, munyagu, harshbarach, hareesh-pillai, pratikkry, naveenkharwar, mukesh27, dushanthi, worldweb, audrasjb
Fixes #42201

Built from https://develop.svn.wordpress.org/trunk@46332


git-svn-id: http://core.svn.wordpress.org/trunk@46131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 21:51:57 +00:00
Andrea Fercia
66dd6814e7 Media: Restore the original Image Editor columns layout after [46326].
Fixes #47116.

Built from https://develop.svn.wordpress.org/trunk@46331


git-svn-id: http://core.svn.wordpress.org/trunk@46130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 20:37:57 +00:00
Andrea Fercia
93dd6d907a Accessibility: Media: Make the Image Editor buttons text visible.
User interface controls that use only icons aren't ideal for many users. 

Universal icons are rare. Icons must communicate meaning but their actual meaning varies depending on many factors including the users cultural background.
Moreover, users with cognitive impairments and speech recognition users need interface controls with visible text to be able to operate them.

- shortens some of the buttons text to: Rotate left, Rotate right, Flip vertical, Flip horizontal
- moves the Undo and Redo buttons underneath the main buttons group

Props nrqsnchz, melchoyce, karmatosed, sabernhardt, mikeschroder.
Fixes #47116.

Built from https://develop.svn.wordpress.org/trunk@46326


git-svn-id: http://core.svn.wordpress.org/trunk@46125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 17:16:57 +00:00
whyisjake
b4ab6b7e14 Menus: Duplicate Page Entry in View All Pages when generating a Menu
Simplifies the interface in menu creation.

Fixes [37782]
Props garrett-eclipse, mdgl, birgire, xkon, audrasjb, pento, girlieworks


Built from https://develop.svn.wordpress.org/trunk@46309


git-svn-id: http://core.svn.wordpress.org/trunk@46108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-25 21:51:58 +00:00
Andrea Fercia
f8a25a89c9 Accessibility: Implement the new focus styles on the login screen after [46247].
Props @kjellr.
See #47153.

Built from https://develop.svn.wordpress.org/trunk@46293


git-svn-id: http://core.svn.wordpress.org/trunk@46105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-25 16:40:00 +00:00
Sergey Biryukov
255b1d6e3f Privacy: Show a success message for personal data erasure.
Props garrett-eclipse, allendav, birgire, JoshuaWold, karmatosed, pputzer.
Fixes #44135.
Built from https://develop.svn.wordpress.org/trunk@46264


git-svn-id: http://core.svn.wordpress.org/trunk@46076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 19:13:58 +00:00
Andrea Fercia
0d75495612 Login and Registration: Add a "Show password" button on the login page.
The ability for users to see the password they're typing improves usability and accessibility of the login users flow.

- brings the login screen in line with the same feature already used in the New User, Edit User, and Reset Password pages
- improves association of labels and input fields by using explicit association with `for` / `id` attributes
- slightly increases the "Remember me" label font size

Props johnbillion, Iceable, audrasjb, joyously, adamsilverstein, boemedia, DrewAPicture, shadyvb, birgire, peterwilsoncc, pento, anevins, davidbaumwald, whyisjake, afercia.
Fixes #42888.

Built from https://develop.svn.wordpress.org/trunk@46256


git-svn-id: http://core.svn.wordpress.org/trunk@46068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 18:06:57 +00:00
Andrea Fercia
956725990f Accessibility: Make sortable meta boxes non sortable when there are no locations they can be dragged to.
Depending on the amount of meta boxes and the layout settings under Screen Options, sortable meta boxes may not be actually sortable.
In these cases, jQuery UI sortable needs to be disabled and the user interface shouldn't use a CSS `cursor: move`.

The use of consistent and relevant cursors may be important for users who have a cognitive disability, since cursors give a visual clue as to an element's functionality. Using the move cursor for elements which cannot be moved may be confusing or counter-intuitive for users.

Props adamsilverstein, antpb, anevins.
Fixes #47131.

Built from https://develop.svn.wordpress.org/trunk@46250


git-svn-id: http://core.svn.wordpress.org/trunk@46062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 17:30:58 +00:00
Andrea Fercia
6cb8e14790 Accessibility: Improve and modernize user interface controls. Sixth part: allow checkboxes and radio buttons to scale with text.
- uses a SVG icon for checkboxes
- uses CSS `rem` relative units

Props kjellr, afercia, audrasjb.
Fixes #47498.

Built from https://develop.svn.wordpress.org/trunk@46248


git-svn-id: http://core.svn.wordpress.org/trunk@46060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 16:51:57 +00:00
Andrea Fercia
165ac34260 Accessibility: Improve and modernize user interface controls for better contrast. Fifth part: Common form controls.
Props anevins, melchoyce, audrasjb, kjellr.
Fixes #47153.

Built from https://develop.svn.wordpress.org/trunk@46247


git-svn-id: http://core.svn.wordpress.org/trunk@46059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 16:21:58 +00:00
Andrea Fercia
38be855367 Accessibility: Improve and modernize user interface controls. Third part: allow buttons and form controls to scale with text.
Props kjellr, abrightclearweb, audrasjb.
Fixes #47477.

Built from https://develop.svn.wordpress.org/trunk@46243


git-svn-id: http://core.svn.wordpress.org/trunk@46055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 15:27:57 +00:00
Andrea Fercia
271f45072d Accessibility: Improve and modernize user interface controls for better contrast. Second part: tables, meta boxes, and other user interface elements.
Introduces better contrast for borders of the following user interface elements:
- Tables
- Screen Options and Help 
- Admin notices
- Welcome panel
- Meta boxes (post boxes)
- Cards
- Health Check accordions and headings
- Theme and Plugin upload forms

Props kjellr, melchoyce, karmatosed, audrasjb.
Fixes #48101.

Built from https://develop.svn.wordpress.org/trunk@46242


git-svn-id: http://core.svn.wordpress.org/trunk@46054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 15:10:59 +00:00
Andrea Fercia
618883f6f4 Accessibility: Improve and modernize user interface controls for better contrast. First part: buttons and links.
- Introduces new styles for the buttons, with better contrast for borders and better focus style.
- Introduces a new focus style for links.
- The new styles improve consistency with the ones used in the new Block Editor (Gutenberg).

Props michaelarestad, truchot, mor10, kellychoffman, adamsoucie, paaljoachim, Joen, kjellr, melchoyce, karmatosed, audrasjb, afercia.
Fixes #34904.

Built from https://develop.svn.wordpress.org/trunk@46241


git-svn-id: http://core.svn.wordpress.org/trunk@46053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 14:43:58 +00:00
Adam Silverstein
a2f45dc9eb Media: make search input full width on mobile. Take two.
Props m1tk00.
Fixes #40130.


Built from https://develop.svn.wordpress.org/trunk@46207


git-svn-id: http://core.svn.wordpress.org/trunk@46019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 20:09:54 +00:00
Andrew Ozz
0628245170 Admin email verification:
- Fix wording of the HTML title.
- Add hidden `(opens in a new tab)` to links that need it.
- Add the `screen-reader-text` CSS class to login.css.
- Add another translator comment.

Props afercia.
See #46349.

Built from https://develop.svn.wordpress.org/trunk@46203


git-svn-id: http://core.svn.wordpress.org/trunk@46015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 18:51:56 +00:00
Sergey Biryukov
42079f34a9 Site Health: Modify the grading indicator to remove percentage score in favor of a "Good" or "Should be improved" status.
This removes arbitrary confusion about what the numbers mean.

Props Clorith, hedgefield, Cybr, arena, DavidAnderson, earnjam, daveshine, Otto42, azaozz, asadkn, KARTHOST, tigertech, maximejobin, johnbillion, raboodesign, ramiy, afragen.
Fixes #47046.
Built from https://develop.svn.wordpress.org/trunk@46106


git-svn-id: http://core.svn.wordpress.org/trunk@45918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-14 14:29:56 +00:00
Andrea Fercia
17652fb3d4 Widgets: Fix "jumpiness" when reordering widgets by dragging them.
Props ketanumretiya030, mukesh27, andraganescu, audrasjb.
Fixes #46941.

Built from https://develop.svn.wordpress.org/trunk@46028


git-svn-id: http://core.svn.wordpress.org/trunk@45838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-04 21:49:48 +00:00
Andrea Fercia
fbc9dba70b Accessibility: Audit usage of abbreviations.
Title attributes on abbreviations are only available to a minority of users. The
best option is to avoid unnecessary abbreviations when possible. In the other cases,
use an `<abbr>` element (which provides a hint to user agents on how to announce
and display the abbreviation) and provide an expansion in plain text on first use.

- `readme.html`: improves abbreviations and removes unnecessary `title` attributes
- options-general: removes unnecessary abbreviations and improves the remaining ones
- customizer schedule changeset date: removes unnecessary abbreviations and improves the remaining ones
- posts table date: uses a `span` element instead of an `abbr` element because this is not an abbreviation

Fixes #46980.

Built from https://develop.svn.wordpress.org/trunk@45930


git-svn-id: http://core.svn.wordpress.org/trunk@45741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-02 21:44:58 +00:00
Mike Schroder
ccdc221b32 Administration: Output valid HTML when wp_die() is called.
To better support HTML and string calls to `wp_die()` without
outputting invalid HTML, wraps error messages in `<div>` rather than `<p>`.

Adds `.wp-die-message` CSS class for styling.

Props dinhtungdu, jeremyfelt, audrasjb, SergeyBiryukov, afercia, audrasjb, noisysocks.
Fixes #47580.
Built from https://develop.svn.wordpress.org/trunk@45909


git-svn-id: http://core.svn.wordpress.org/trunk@45720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-29 07:54:01 +00:00
Sergey Biryukov
53f5b172ab Plugins: Adjust margin for plugin headings on "Add Plugins" screen to avoid overlapping with "Network Activate" button.
Props justinahinon, chetan200891.
Fixes #47600.
Built from https://develop.svn.wordpress.org/trunk@45824


git-svn-id: http://core.svn.wordpress.org/trunk@45635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-17 14:33:56 +00:00
Andrew Ozz
fff56d219f Add admin email verification screen. Shown every six months after an admin has logged in.
Also includes WPCS fixes for wp-login.php.

Props andraganescu, boemedia, lessbloat, azaozz.
See #46349.
Built from https://develop.svn.wordpress.org/trunk@45757


git-svn-id: http://core.svn.wordpress.org/trunk@45568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 00:04:56 +00:00
Sergey Biryukov
e081194455 Administration: Correct "Quick Edit" link height in list tables for consistency with other action links.
Props jobthomas, burhandodhy.
Fixes #47815.
Built from https://develop.svn.wordpress.org/trunk@45756


git-svn-id: http://core.svn.wordpress.org/trunk@45567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 22:20:58 +00:00
Andrea Fercia
b853e21bf9 Accessibility: Improve the differences between revisions.
Color alone is not sufficient to visually communicate differences.

- adds `plus` and `minus` icons to the changed lines
- adds visually hidden text: `Added`, `Deleted`, and `Unchanged` to clarify the differences to assistive technologies users

Props birgire, audrasjb, kjellr, adamsilverstein.
Fixes #43532.

Built from https://develop.svn.wordpress.org/trunk@45729


git-svn-id: http://core.svn.wordpress.org/trunk@45540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-03 15:46:54 +00:00
Andrea Fercia
60431f3c53 Customize: Make the color picker close when clicking on the empty area on the right.
Props monikarao.
Fixes #47693.

Built from https://develop.svn.wordpress.org/trunk@45722


git-svn-id: http://core.svn.wordpress.org/trunk@45533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-02 17:09:57 +00:00
Tammie Lister
fa9980049e Admin: Improve Dashboard icon contrast.
The icons used across the dashboard had too low contrast to pass AA WCAG guidelines. They’re now slightly darker for better contrast.

Props @melchoyce, @SergeyBiryukov, @chetan200891 , @kjellr 
Fixes #46935

Built from https://develop.svn.wordpress.org/trunk@45700


git-svn-id: http://core.svn.wordpress.org/trunk@45511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-30 22:54:57 +00:00
Sergey Biryukov
7a4d1b5dbd Permalinks: Improve appearance of URL examples on Permalink Settings screen.
Props luan-ramos, sarath.ar.
Fixes #41559.
Built from https://develop.svn.wordpress.org/trunk@45693


git-svn-id: http://core.svn.wordpress.org/trunk@45504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 16:11:56 +00:00
Sergey Biryukov
b95b055225 Administration: Allow breaking long strings in <code> tags at any point, to avoid overflowing on mobile.
Props david.binda, mukesh27.
Fixes #47329.
Built from https://develop.svn.wordpress.org/trunk@45692


git-svn-id: http://core.svn.wordpress.org/trunk@45503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 16:09:55 +00:00
Sergey Biryukov
f933abef11 Accessibility: Taxonomy: When a new category or tag is being added, show a spinner and noop the button to avoid multiple requests.
Props andg, afercia, guddu1315, SergeyBiryukov.
Fixes #47607.
Built from https://develop.svn.wordpress.org/trunk@45683


git-svn-id: http://core.svn.wordpress.org/trunk@45494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-26 17:46:56 +00:00
Sergey Biryukov
5cdbe22b16 Administration: Merge CSS rules for #adminmenu .wp-submenu a in one place.
Props ozmatflc, AkSDvP.
Fixes #47780.
Built from https://develop.svn.wordpress.org/trunk@45682


git-svn-id: http://core.svn.wordpress.org/trunk@45493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-26 13:49:57 +00:00
Sergey Biryukov
ccba6c4aec Upgrade/Install: Bring some consistency to installation screen styles.
* Include `forms.css` and `l10n.css`, for consistency with login screen and other admin screens.
* Remove redundant `@import` directives from `login.css` for files already declared as dependencies.
* Adjust margin on password strength meter for consistency with other fields.
* Increase font size for "You will need this password to log in" notice.
* Fix misaligned icon on "Hide" button for the password.

Props iseulde, dan@micamedia.com, bassgang, cdog, johnbillion, nmenescardi, mukesh27, SergeyBiryukov.
Fixes #35776, #47757, #47758.
Built from https://develop.svn.wordpress.org/trunk@45673


git-svn-id: http://core.svn.wordpress.org/trunk@45484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 19:11:55 +00:00
Sergey Biryukov
02c07f23d5 Customize: Fix text direction for color picker in RTL.
Props vjik for the report.
Fixes #47688. See #23740.
Built from https://develop.svn.wordpress.org/trunk@45626


git-svn-id: http://core.svn.wordpress.org/trunk@45437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 00:05:57 +00:00
Andrea Fercia
ba24a8f6d3 Plugins: Fix the plugin details modal layout after [45520].
Props mukesh27, marybaum, audrasjb.
Fixes #47561.

Built from https://develop.svn.wordpress.org/trunk@45563


git-svn-id: http://core.svn.wordpress.org/trunk@45374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-25 14:11:55 +00:00
Andrea Fercia
340fd28d82 Accessibility: Improve focus management in the Media Views.
- keeps focus management only where necessary to avoid focus losses
- removes focus management where a specific user workflow was assumed
- makes the "Attachment Details" navigation buttons really disabled when there are no next or previous attachments
- adds inline comments to clarify all the usages of focus()

Fixes #43169.

Built from https://develop.svn.wordpress.org/trunk@45524


git-svn-id: http://core.svn.wordpress.org/trunk@45335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-12 21:03:52 +00:00
Andrea Fercia
9f579ea448 Administration: Improve the horizontal centering of the Site Health tabs.
Props dkarfa, davidbaumwald, Clorith, tinkerbelly, afercia.
Fixes #46881.

Built from https://develop.svn.wordpress.org/trunk@45522


git-svn-id: http://core.svn.wordpress.org/trunk@45333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-12 19:31:52 +00:00
Andrea Fercia
9f7f9d2d89 Administration: Fix the responsive layout after changes to the Screen Options and Help buttons position.
Fixes #45094.

Built from https://develop.svn.wordpress.org/trunk@45520


git-svn-id: http://core.svn.wordpress.org/trunk@45331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-12 19:21:54 +00:00
Andrea Fercia
935c35fe34 Accessibility: Improve the Screen Options and Help buttons order.
- makes the buttons visual order match the DOM order
- also, restores the focus style on the "hero" primary button after [34948]

Props vrimill, mukesh27 for reporting and testing.
Fixes #45094.

Built from https://develop.svn.wordpress.org/trunk@45503


git-svn-id: http://core.svn.wordpress.org/trunk@45314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 16:31:53 +00:00
Andrea Fercia
be14c6e5c6 Administration: Improve the Screen Options and Help buttons focus style after [45501].
Amends [45501].
See #46749.

Built from https://develop.svn.wordpress.org/trunk@45502


git-svn-id: http://core.svn.wordpress.org/trunk@45313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 16:07:52 +00:00
Andrea Fercia
17034e2a4e Administration: Remove extra border from the Screen Options and Help buttons.
The extra border was visible in the responsive view for smaller screens after [32844].

Props jitendrabanjara1991.
Fixes #46749.

Built from https://develop.svn.wordpress.org/trunk@45501


git-svn-id: http://core.svn.wordpress.org/trunk@45312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 14:50:52 +00:00
Andrea Fercia
6a9bcaeaa9 Accessibility: Improve accessibility of all the media views form controls.
- changes the media views form controls to have explicitly associated labels with for/id attributes
- adds a few missing labels / aria-labels
- improves a few existing labels / aria-labels
- improves semantics in a few places, by adding visually hidden headings, fieldset + legend elements, aria-describedby attributes
- improves the image custom size input fields and their labelling
- adds `role="status"` to the "saved" indicator so that status messages are announced to assistive technologies
- swaps the columns source order in the image details template, to make visual and DOM order match
- swaps the "Replace" and "Back" buttons source order in the Replace Image view, to make visual and DOM order match
- gallery settings: move checkbox label to the right: checkboxes are supposed to have labels on the right
- merge similar strings, unified to "Drop files to upload" (removed "Drop files here", and "Drop files anywhere to upload")
- makes the "upload-ui" consistent across the media views
- hides the IE 11 "X" `::-ms-clear` button in the Insert from URL field, as it conflicts with the uploading spinner
- adds comments to all the media templates to clarify their usage
- slightly increases vertical spacing between form fields in the media sidebar
- removes some CSS selectors introduced as backwards compatibility for WordPress pre-4.4
- removes some CSS still targeting Internet Explorer 7 and 8

Fixes #47141.
Fixes #47122.

Built from https://develop.svn.wordpress.org/trunk@45499


git-svn-id: http://core.svn.wordpress.org/trunk@45310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-07 20:45:02 +00:00
Andrea Fercia
d5333b9593 Fix the media player controls bar width in the media views.
Props vaishalipanchal, chetan200891.
Fixes #47457.

Built from https://develop.svn.wordpress.org/trunk@45497


git-svn-id: http://core.svn.wordpress.org/trunk@45308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-07 13:29:52 +00:00
Sergey Biryukov
baa2cd69b8 Media: Restore correct arrow direction in RTL in Attachment Details modal.
Reverts [29264]. As we now have a build task to replace dashicons for RTL, the CSS rules no longer worked as expected and had the opposite effect.

Props ramiy, SergeyBiryukov.
Fixes #46289.
Built from https://develop.svn.wordpress.org/trunk@45495


git-svn-id: http://core.svn.wordpress.org/trunk@45306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-06 01:25:52 +00:00
Sergey Biryukov
0d40c54f9b CSS Coding Standards: Use unitless values for line-height in wp-admin/css/media.css.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46530. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45484


git-svn-id: http://core.svn.wordpress.org/trunk@45295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 16:45:50 +00:00
Sergey Biryukov
412ffd0aaf Media: Move tag cloud styles that accidentally ended up in Media section after the reorganization in [16136] to a more appropriate place.
Remove styles for `wp-admin/update-core.php` accidentally duplicated in Media section as part of the same reorganization.

See #46530.
Built from https://develop.svn.wordpress.org/trunk@45483


git-svn-id: http://core.svn.wordpress.org/trunk@45294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 16:40:52 +00:00
Sergey Biryukov
fdc6b9583b CSS Coding Standards: Use unitless values for line-height in wp-admin/css/revisions.css.
Props ianbelanger, pbiron, afercia.
Fixes #46517. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45468


git-svn-id: http://core.svn.wordpress.org/trunk@45279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:16:52 +00:00
Sergey Biryukov
ca6aa01705 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/list-tables.css.
Props ianbelanger, pbiron, afercia.
Fixes #46515. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45467


git-svn-id: http://core.svn.wordpress.org/trunk@45278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:15:52 +00:00
Sergey Biryukov
afaeca95cf CSS Coding Standards: Use unitless values for line-height in wp-admin/css/login.css.
Props ianbelanger, pbiron, afercia.
Fixes #46514. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45466


git-svn-id: http://core.svn.wordpress.org/trunk@45277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:09:52 +00:00
Sergey Biryukov
1899a99c35 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/install.css.
Props ianbelanger, pbiron, afercia.
Fixes #46513. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45465


git-svn-id: http://core.svn.wordpress.org/trunk@45276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 11:53:53 +00:00
Sergey Biryukov
03814826b2 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/forms.css.
Props ianbelanger, pbiron, afercia.
Fixes #46512. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45464


git-svn-id: http://core.svn.wordpress.org/trunk@45275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 11:49:53 +00:00
Andrea Fercia
41accccad6 Administration: Improve the Site Health tables layout for small screens.
Props immeet94, jankimoradiya, desrosj, shashank3105, chetan200891, Clorith, hedgefield.	
Fixes #46960.

Built from https://develop.svn.wordpress.org/trunk@45463


git-svn-id: http://core.svn.wordpress.org/trunk@45274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 18:22:51 +00:00
Sergey Biryukov
52d478cb0d CSS Coding Standards: Use unitless values for line-height in wp-admin/css/edit.css.
Props ianbelanger, pbiron, afercia.
Fixes #46511. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45462


git-svn-id: http://core.svn.wordpress.org/trunk@45273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 16:05:53 +00:00
Sergey Biryukov
ce25e2f34d CSS Coding Standards: Use unitless values for line-height in wp-admin/css/dashboard.css.
Props ianbelanger, pbiron, afercia.
Fixes #46510. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45461


git-svn-id: http://core.svn.wordpress.org/trunk@45272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 16:03:52 +00:00
Sergey Biryukov
9860a4366d CSS Coding Standards: Use unitless values for line-height in wp-admin/css/customize-widgets.css.
Props ianbelanger, pbiron, afercia.
Fixes #46509. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45460


git-svn-id: http://core.svn.wordpress.org/trunk@45271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 16:01:53 +00:00
Andrea Fercia
fc17576fd2 Accessibility: Improve toggling the "Post locked" information visibility.
- effectively hides the "Post locked" information from assistive technologies
- when a post is locked, reveals the "Post locked" information without CSS animation
- the height CSS animation didn't work anyways after [24906]

See #24553.
Fixes #44946.

Built from https://develop.svn.wordpress.org/trunk@45417


git-svn-id: http://core.svn.wordpress.org/trunk@45228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 17:15:52 +00:00
Sergey Biryukov
00c60ccd33 CSS Coding Standards: Update unitless values for line-height in wp-admin/css/widgets.css with more precise calculations.
Props ianbelanger.
Fixes #46531.
Built from https://develop.svn.wordpress.org/trunk@45415


git-svn-id: http://core.svn.wordpress.org/trunk@45226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 14:44:52 +00:00
Sergey Biryukov
962da3db60 CSS Coding Standards: Update unitless values for line-height in wp-admin/css/nav-menus.css with more precise calculations.
Props ianbelanger.
Fixes #46516.
Built from https://develop.svn.wordpress.org/trunk@45414


git-svn-id: http://core.svn.wordpress.org/trunk@45225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 14:42:52 +00:00
John Blackbourn
01917b9f74 I18N: Add a language icon next to language selectors.
This change means that users who can't read the site's current language can more easily identify controls that allow them to change either the site language or their own admin area language.

Props janak007, atlasmahesh, afercia, birgire, JoshuaWold

Fixes #43144

Built from https://develop.svn.wordpress.org/trunk@45402


git-svn-id: http://core.svn.wordpress.org/trunk@45213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 20:43:52 +00:00
John Blackbourn
239a159ad2 Administration: Don't apply italic formatting to code blocks in setting descriptions.
Props chetan200891

Fixes #42651

Built from https://develop.svn.wordpress.org/trunk@45389


git-svn-id: http://core.svn.wordpress.org/trunk@45200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 23:14:53 +00:00
desrosj
c6da25fa9a Privacy: Prevent email field for personal data requests from overflowing.
Props anischarolia, ianbelanger, afercia.
Fixes #46961.
Built from https://develop.svn.wordpress.org/trunk@45326


git-svn-id: http://core.svn.wordpress.org/trunk@45137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 20:45:54 +00:00
desrosj
1ef254a465 Menus: Fix alignment of menu actions on mobile.
In [41197], changes were made to improve the responsive view for the Menu Name field and Save buttons. This caused the Delete Menu button to be misaligned.

Props ianbelanger, audrasjb, afercia, mukesh27.
Fixes #47173.
Built from https://develop.svn.wordpress.org/trunk@45324


git-svn-id: http://core.svn.wordpress.org/trunk@45135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 19:05:53 +00:00
desrosj
ca7c9a8288 Site Health: Improve alignment and spacing for section headers.
This changes the CSS for Site Health headers to use flexbox, which helps ensure the text is vertically aligned center and consistently spaced in both the Status and Info tabs. It also fixes an issue where the loading spinner GIF was cut off on smaller screens (originally reported in #47203.

Props Presskopp, odminstudios, kjellr, afercia, desrosj, hedgefield, ianbelanger, xavortm.
Fixes #47063.
Built from https://develop.svn.wordpress.org/trunk@45322


git-svn-id: http://core.svn.wordpress.org/trunk@45133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 18:30:53 +00:00
desrosj
f48f926077 Site Health: Improve vertical alignment of icons in test result descriptions.
This change removes redundant CSS properties for different health check statuses in favor of utilizing the `.dashicons` class already in Core to define them more consistently. This also fixes the vertical alignment issues.

Props chetan200891, Clorith, desrosj.
Fixes #46940.
Built from https://develop.svn.wordpress.org/trunk@45309


git-svn-id: http://core.svn.wordpress.org/trunk@45120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-15 14:26:07 +00:00
Andrea Fercia
1b3b04f354 Accessibility: Improve the "skip links" position for medium and small screens.
Fixes #47065.

Built from https://develop.svn.wordpress.org/trunk@45301


git-svn-id: http://core.svn.wordpress.org/trunk@45110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-09 21:12:02 +00:00
desrosj
71f9170c08 Administration: Prevent cards on the Tools page from overflowing on small screens.
Props anischarolia, mukesh27.
Fixes #46972.
Built from https://develop.svn.wordpress.org/trunk@45296


git-svn-id: http://core.svn.wordpress.org/trunk@45105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-09 14:56:56 +00:00
desrosj
c4062c75a7 Help/About: Final 5.2 about page updates.
Use final image URLs and fix a bug in IE11 where images were being cut off.

Props afercia, SergeyBiryukov, ianbelanger, desrosj, audrasjb.
See #46901.
Built from https://develop.svn.wordpress.org/trunk@45287


git-svn-id: http://core.svn.wordpress.org/trunk@45096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-07 17:19:55 +00:00
desrosj
3360974ad2 Help/About: Polish the About page for 5.2.
- The About page now uses a CSS grid to layout its design, making the page’s structure more obvious and hopefully easier for contributors in the future.
- Removes some code that is no longer used (such as videos, mejs elements, etc.).
- Update images.
- Unnecessary HTML is removed from a string on the page. This was a regression.
- Only users with the correct capability should be instructed to check their site status.
- Fixes the placement of commas.

Reviewed by melchoyce, afercia, jeremyfelt, and desrosj.

Props ryelle, melchoyce, cathibosco1, man4toman, SergeyBiryukov, afercia, ramiy, kjellr, tellyworth, earnjam, andreamiddleton, marybaum.
See #46901.
Built from https://develop.svn.wordpress.org/trunk@45278


git-svn-id: http://core.svn.wordpress.org/trunk@45087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-02 15:44:53 +00:00
desrosj
d53659ed71 Help/About: Fix tab display issues.
This change restores About page tab heights and fixes bugs with the tab bottom border caused by [44905] and [45243].

Reviewed by SergeyBiryukov and desrosj.

Props ixkaito, ianbelanger, afercia, SergeyBiryukov.
See #46901.
Fixes #47075.
Built from https://develop.svn.wordpress.org/trunk@45276


git-svn-id: http://core.svn.wordpress.org/trunk@45085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-02 10:37:51 +00:00
Gary Pendergast
d86524f09d Admin: Add the text for the WordPress 5.2 About page.
This changes includes placeholder images for now, they'll be replaced by the final images before final release.

Props chanthaboune, melchoyce, karmatosed, pento, marybaum, birgire, earnjam, andreamiddleton.
See #46901.


Built from https://develop.svn.wordpress.org/trunk@45271


git-svn-id: http://core.svn.wordpress.org/trunk@45080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-26 00:57:53 +00:00
Gary Pendergast
6fcd281707 CSS: Remove the units from line-height properties in common.css.
Props ianbelanger, talldanwp.
Fixes #46493.


Built from https://develop.svn.wordpress.org/trunk@45243


git-svn-id: http://core.svn.wordpress.org/trunk@45052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 06:02:53 +00:00
Andrea Fercia
d89a302503 Site Health: Improve the accordions styles for small screens.
Also, changes the hex color values to lowercase.

Props subrataemfluence, man4toman, garrett-eclipse, chetan200891, mukesh27, melchoyce, karmatosed, Clorith.
Fixes #46949.

Built from https://develop.svn.wordpress.org/trunk@45229


git-svn-id: http://core.svn.wordpress.org/trunk@45038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 11:00:53 +00:00
Andrea Fercia
fc7a8f7194 Administration: Improve the Site Health "Passed tests" button style for small screens.
Props chetan200891.
Fixes #46939.

Built from https://develop.svn.wordpress.org/trunk@45217


git-svn-id: http://core.svn.wordpress.org/trunk@45026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-16 16:23:52 +00:00
Mel Choyce
df276c333a Administration: Update chevron color in Site Health.
Props afercia.
Fixes #46934. See #46730.

Built from https://develop.svn.wordpress.org/trunk@45202


git-svn-id: http://core.svn.wordpress.org/trunk@45011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-15 18:56:54 +00:00
Andrea Fercia
10239ba45d Administration: Add a chevron icon to the Site Health "Passed tests" button.
The chevron icon helps clarify what the button does.

Props garrett-eclipse, Clorith, xkon, melchoyce.
Fixes #46730.

Built from https://develop.svn.wordpress.org/trunk@45201


git-svn-id: http://core.svn.wordpress.org/trunk@45010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-15 18:01:53 +00:00
Sergey Biryukov
b2a9bb4e78 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/customize-controls.css.
Props ianbelanger, audrasjb, pbiron, afercia.
Fixes #46494. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45189


git-svn-id: http://core.svn.wordpress.org/trunk@44998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 04:36:51 +00:00
Sergey Biryukov
77ff117d7f CSS Coding Standards: Use unitless values for line-height in wp-admin/css/themes.css.
Props ianbelanger, mukesh27, audrasjb, pbiron, afercia.
Fixes #46518. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45188


git-svn-id: http://core.svn.wordpress.org/trunk@44997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 04:32:51 +00:00
Sergey Biryukov
5fe5733f38 CSS Coding Standards: Use unitless values for line-height for count bubbles in wp-admin/css/admin-menu.css.
Missed in [45186].

Props ianbelanger.
See #46489, #44643.
Built from https://develop.svn.wordpress.org/trunk@45187


git-svn-id: http://core.svn.wordpress.org/trunk@44996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 04:20:50 +00:00
Sergey Biryukov
b76772b9a7 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/admin-menu.css.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46489. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45186


git-svn-id: http://core.svn.wordpress.org/trunk@44995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 00:17:50 +00:00
Andrew Ozz
30ccfd540f Site health: Load the "Info" tab immediately and notify the user while gathering site data. Changes the Info tab to work similarly to the Status tab: it does separate request to fetch the directories sizes and doesn't "block" the loading of the page.
Props xkon, afercia, Clorith, azaozz.
See #46707.
Built from https://develop.svn.wordpress.org/trunk@45176


git-svn-id: http://core.svn.wordpress.org/trunk@44985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 19:24:51 +00:00
Andrew Ozz
77e87830ae TinyMCE: Fix keyboard navigation when the dfw button is present but hidden. Ensure that button is added last in the DOM to match where it appears visually.
Props afercia, azaozz.
Fixes #46640.
Built from https://develop.svn.wordpress.org/trunk@45172


git-svn-id: http://core.svn.wordpress.org/trunk@44981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 18:08:53 +00:00
desrosj
6afe73667c Site Health: Add missing actions to tests.
This change adds missing actions for several tests. This ensures that the user is provided with a next step, whenever possible.

Also, change the URL displayed in the WordPress.org communication test description to `api.wordpress.org` for accuracy.

Props: garrett-eclipse, Clorith, vaishalipanchal.
Fixes #46734.
Built from https://develop.svn.wordpress.org/trunk@45170


git-svn-id: http://core.svn.wordpress.org/trunk@44979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 17:40:53 +00:00
desrosj
5bafb4ea2d Site Health: Improve the test badge implementation.
Label badges for each Site Health test currently display in either red, orange, or green, regardless of if the test passed or failed. This is confusing, as seeing red labels in the “Passed Test” section could alarm users (when really everything is OK and no action is required), and seeing green labels in the “Failed Tests” section would not appropriately encourage the user to take appropriate action.

This change makes several improvements to the label badges:

- Always right align the badges for consistent display.
- Remove background fill for badges. Instead, use a border.
- Use a consistent styling for all tests (passed and failed).
- The text color no longer uses true black (#000000).
- The `.badge.pink` CSS definition has been switched to `.badge.purple`, and the definitions for blue, gray, and green have also been updated to more closely follow the official WordPress color palette.

Props: pbiron, garrett-eclipse, hedgefield, Clorith, xkon, melchoyce, mdwolinski, alexdenning.
Fixes #46623.
Built from https://develop.svn.wordpress.org/trunk@45169


git-svn-id: http://core.svn.wordpress.org/trunk@44978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 17:04:52 +00:00
Andrea Fercia
2887cea50f Accessibility: Improve the image "Alternative Text" field in the Edit Media screen.
Brings parity with the changes for the Media Views introduced in [44900].
- moves the alt text field to the top as first field
- adds an explanatory text with a link pointing to the W3C "alt decision tree" tutorial
- adds `aria-describedby` to target the explanatory text
- adjusts the CSS and indentation

Props chetan200891.
Fixes #46875.

Built from https://develop.svn.wordpress.org/trunk@45158


git-svn-id: http://core.svn.wordpress.org/trunk@44967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-10 20:00:50 +00:00
Andrea Fercia
f27917373c Login and Registration: improve the CSS padding on the login input fields.
The right padding added in [44895] needs to be set only on the input fields in the Reset Password screen and exclude other login screens.

Amends [44895].
Fixes #42853.

Built from https://develop.svn.wordpress.org/trunk@45157


git-svn-id: http://core.svn.wordpress.org/trunk@44966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-10 16:12:51 +00:00
Gary Pendergast
5b8db48734 Site Health: Remove animated ellipsis from the status loading indicator.
This animation wasn't particularly reliable across browsers.

Props Clorith, afercia.
Fixes #46684.


Built from https://develop.svn.wordpress.org/trunk@45145


git-svn-id: http://core.svn.wordpress.org/trunk@44954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 23:29:51 +00:00
Sergey Biryukov
78340f315d CSS Coding Standards: Use unitless values for line-height in wp-admin/css/color-picker.css.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46492. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45131


git-svn-id: http://core.svn.wordpress.org/trunk@44940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-07 05:54:50 +00:00
Sergey Biryukov
c33b18b721 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/about.css.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46495. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45130


git-svn-id: http://core.svn.wordpress.org/trunk@44939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-07 05:51:51 +00:00
Sergey Biryukov
7eafd6d81a CSS Coding Standards: Use unitless values for line-height in wp-admin/css/customize-nav-menus.css.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46495. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45129


git-svn-id: http://core.svn.wordpress.org/trunk@44938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-07 05:49:51 +00:00
Sergey Biryukov
7eecc96e2d CSS Coding Standards: Use unitless values for line-height in wp-admin/css/site-health.css.
Props mukesh27, ianbelanger, pbiron, afercia.
Fixes #46760. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45128


git-svn-id: http://core.svn.wordpress.org/trunk@44937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-07 05:44:50 +00:00
Sergey Biryukov
95d13df56d CSS Coding Standards: Use unitless values for line-height in wp-admin/css/nav-menus.css.
Props ianbelanger, audrasjb, pbiron, afercia.
Fixes #46516. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45123


git-svn-id: http://core.svn.wordpress.org/trunk@44932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-06 16:10:51 +00:00
Felix Arntz
5754da106b Administration: Improve user experience and clarify when in recovery mode.
This changeset introduces several changes around usability when recovery mode is active:

* Display a notice in the admin clarifying that the user is in recovery mode.
* Use a highlight color for the admin bar link to exit recovery mode.
* Exit recovery mode automatically when logging out.
* Include a recovery mode indicator in the title tag.

Props aandrewdixon, azaozz, dhanukanuwan, flixos90, henrywright, karmatosed, mapk, melchoyce, spacedmonkey, TimothyBlynJacobs, tinkerbelly.
See #46608.

Built from https://develop.svn.wordpress.org/trunk@45117


git-svn-id: http://core.svn.wordpress.org/trunk@44926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-05 17:00:52 +00:00
Andrea Fercia
83546a04f5 Administration: Site Health: reserve some space for the admin notices.
Props xkon, Clorith, hedgefield, mapk, karmatosed, afercia.
Fixes #46651.

Built from https://develop.svn.wordpress.org/trunk@45091


git-svn-id: http://core.svn.wordpress.org/trunk@44900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 18:01:52 +00:00
Andrea Fercia
d8b8994336 Accessibility: Improve the Site Health accordions.
- removes the definition list and uses the markup from the ARIA Authoring Practices example
- removes incorrect ARIA roles
- avoids ARIA landmark regions proliferation

Props mukesh27 for the initial patch.
Fixes #46714.

Built from https://develop.svn.wordpress.org/trunk@45087


git-svn-id: http://core.svn.wordpress.org/trunk@44896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 15:08:58 +00:00
Andrea Fercia
fdda9ca9dd Coding Standards: Improve the Site Health CSS for small screens.
Amends #45071.
See #46685.

Built from https://develop.svn.wordpress.org/trunk@45074


git-svn-id: http://core.svn.wordpress.org/trunk@44883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-30 14:09:51 +00:00
Andrea Fercia
0942dfc6d4 Administration: Improve the CSS for the Site Health pages header.
Avoids the Site Health pages header layout to break when the Hello Dolly plugin or other floated content is printed out at the top of the page.

Props xkon.
Fixes #46650.

Built from https://develop.svn.wordpress.org/trunk@45072


git-svn-id: http://core.svn.wordpress.org/trunk@44881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-29 18:55:50 +00:00
Andrea Fercia
2a99454732 Coding Standards: Clean up the Site Health stylesheet.
- reduces selectors specificity to avoid over-qualified selectors
- removes unused rulesets / properties
- renames some CSS classes

Fixes #46685.

Built from https://develop.svn.wordpress.org/trunk@45071


git-svn-id: http://core.svn.wordpress.org/trunk@44880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-29 18:44:51 +00:00
Sergey Biryukov
774ac73a1f CSS Coding Standards: Use unitless values for line-height in wp-admin/css/widgets.css.
Props ianbelanger, audrasjb.
Fixes #46531. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45053


git-svn-id: http://core.svn.wordpress.org/trunk@44862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 16:39:51 +00:00
Gary Pendergast
65f7cdbce0 Site Health: Improve the "Copy to clipboard" button.
The previous method for copying the debug report to the clipboard involved having a hidden `<textarea>`, but this shows up in screen readers and can't be reliably hidden.

To work around this, the button now uses the `clipboard.js` library, which automatically handles browser differences in the Clipboard API, and can load the text to copy from a `data-` attribute on the button.

Props pento, hedgefield, afercia.
Fixes #46647.


Built from https://develop.svn.wordpress.org/trunk@45044


git-svn-id: http://core.svn.wordpress.org/trunk@44853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 22:31:52 +00:00
Andrea Fercia
9b15549b1c Accessibility: Simplify the Site Health score indicator.
The Site Health score indicator isn't exactly a "progress bar" and shouldn't use ARIA roles and properties related to progress bars. Also, some browser / screen reader combinations don't announce the score properly.
- removes any ARIA
- adds a screen-reader-text "Current health score:"
- adds `role="img" aria-hidden="true" focusable="false"` to the SVG
- reduces CSS specificity simplifying unnecessary overqualified selectors
- fixes the syntax for ::after and ::before (double colon)

Fixes #46621.

Built from https://develop.svn.wordpress.org/trunk@45041


git-svn-id: http://core.svn.wordpress.org/trunk@44850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 20:39:51 +00:00
Gary Pendergast
0a9d61ab63 Admin: Introduce the Site Health screens.
The Site Health tool serves two purposes:
- Provide site owners with information to improve the performance, reliability, and security of their site.
- Collect comprehensive debug information about the site.

By encouraging site owners to maintain their site and adhere to modern best practices, we ultimately improve the software hygeine of both the WordPress ecosystem, and the open internet as a whole.

Props Clorith, hedgefield, melchoyce, xkon, karmatosed, jordesign, earnjam, ianbelanger, wpscholar, desrosj, pedromendonca, peterbooker, jcastaneda, garyj, soean, pento, timothyblynjacobs, zodiac1978, dgroddick, garrett-eclipse, netweb, tobifjellner, pixolin, afercia, joedolson, birgire.
See #46573.

Built from https://develop.svn.wordpress.org/trunk@44986


git-svn-id: http://core.svn.wordpress.org/trunk@44817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-23 03:55:53 +00:00
Felix Arntz
3a77265148 Bootstrap/Load: Introduce a recovery mode for fixing fatal errors.
Using the new fatal handler introduced in [44962], an email is sent to the admin when a fatal error occurs. This email includes a secret link to enter recovery mode. When clicked, the link will be validated and on success a cookie will be placed on the client, enabling recovery mode for that user. This functionality is executed early before plugins and themes are loaded, in order to be unaffected by potential fatal errors these might be causing.

When in recovery mode, broken plugins and themes will be paused for that client, so that they are able to access the admin backend despite of these errors. They are notified about the broken extensions and the errors caused, and can then decide whether they would like to temporarily deactivate the extension or fix the problem and resume the extension.

A link in the admin bar allows the client to exit recovery mode.

Props timothyblynjacobs, afragen, flixos90, nerrad, miss_jwo, schlessera, spacedmonkey, swissspidy.
Fixes #46130, #44458.

Built from https://develop.svn.wordpress.org/trunk@44973


git-svn-id: http://core.svn.wordpress.org/trunk@44804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-21 21:53:51 +00:00
Sergey Biryukov
78f8073a72 Post Formats: Remove CSS transition effect on post format icons in the Posts list table.
Props afercia, melchoyce.
See #46591, #35497.
Built from https://develop.svn.wordpress.org/trunk@44963


git-svn-id: http://core.svn.wordpress.org/trunk@44794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-21 16:36:51 +00:00
Sergey Biryukov
99b929cbbc Accessibility: Remove post format filter links from format icons in the Posts list table.
Introduce a dedicated 'Formats' drop-down filter as a replacement.

Keep the icons as a simple visual indicator of the post format for now.

Props afercia, melchoyce, GaryJ, chiaralovelaces, SergeyBiryukov.
Fixes #35497.
Built from https://develop.svn.wordpress.org/trunk@44961


git-svn-id: http://core.svn.wordpress.org/trunk@44792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-21 15:32:01 +00:00
desrosj
217849aab3 Menus: Ensure consistent padding in the menu structure form.
Props shital-patel, welcher, hardik-amipara, audrasjb.
Fixes #42596.
Built from https://develop.svn.wordpress.org/trunk@44952


git-svn-id: http://core.svn.wordpress.org/trunk@44783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-21 02:56:51 +00:00
desrosj
18754216be Administration: Ensure consistent alignment for time and date fields across edit screens.
This change ensures that the values of time and date fields for comments and posts (both Classic Editor and quick edit) are consistently aligned in the center of the input fields. The block editor already enforces this alignment separately.

Props birgire, jainnidhi, melchoyce.
Fixes #43675.
Built from https://develop.svn.wordpress.org/trunk@44945


git-svn-id: http://core.svn.wordpress.org/trunk@44776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-20 18:29:53 +00:00
Andrea Fercia
e901bc4c2b Accessibility: Improve the Comments and Privacy count text.
- standardizes the Comment count string to `%s Comment in moderation', '%s Comments in moderation` so it can be bulk-updated
- adds the string as visually hidden text in the admin menu 
- introduces an `updateInModerationText` JS simple function, responsible to correctly update all the related text using the data from the AJAX response
- adds a visually hidden text "1 Privacy Policy update" to the Privacy menu items count
- adds/improves translators comments

Changes that apply to all the count bubbles (Updates, plugins, etc.)
- makes the bubbles and their text slightly bigger
- improves the active menu item bubble contrast by changing the background color to red (option 2 in the screenshot attached in a previous comment)

Props adamsoucie, afercia.
Fixes #33030.

Built from https://develop.svn.wordpress.org/trunk@44924


git-svn-id: http://core.svn.wordpress.org/trunk@44755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-18 15:22:53 +00:00
Andrea Fercia
8f69ebf812 Accessibility: Improve the semantics of "tabs" that are not real ARIA tabs.
Some "visual tabs" in the WordPress admin used links wrapped in a `h2` heading. While these tabs look like ARIA tabs, they're just navigation menus and should be marked-up as such to be correctly exposed to assistive technologies.
- changes the wrapping `<h2>` to a `<nav>` element: worth reminding `<nav>` elements also define ARIA landmarks
- adds an `aria-label` to the `<nav>` elements so they can be distinguished from other `<nav>` elements in the page
- adjusts the headings level in the Credits page

Props audrasjb, afercia.
Fixes #43398.

Built from https://develop.svn.wordpress.org/trunk@44905


git-svn-id: http://core.svn.wordpress.org/trunk@44736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-15 14:54:52 +00:00
Andrea Fercia
72979b167d Accessibility: Improve the placeholder "prompt" text in the post title and Quick Draft widget.
Old browsers didn't support the HTML placeholder attribute. For a number of years, `<label>` elements have been used in a few places in WordPress to emulate placeholders. It's time to improve semantics and interaction, use real placeholders when possible, and clean up some JavaScript.

- Quick Draft widget: it now uses visible `<label>` elements and a real `placeholder` attribute 
- removes the related JavaScript
- Post title:
  - keeps the "prompt" label for backwards compatibility
  - improves the JavaScript to make the "prompt" label stay visible on focus and disappear when typing, like real placeholder do
- changes the post "prompt" text from "Enter title here" to "Add title" for consistency with the Block Editor 
- cleans-up some CSS

Props Cheffheid, afercia.
Fixes #42390.

Built from https://develop.svn.wordpress.org/trunk@44896


git-svn-id: http://core.svn.wordpress.org/trunk@44727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-14 17:39:53 +00:00
Andrea Fercia
ca53eac85e Accessibility: Improve the password form buttons accessibility.
- makes the "Cancel" button always visible: this allows to generate a new password also on small screens
- moves focus back to the Generate Password button when closing the form
- changes the password reset show/hide button from a clickable `<span>` element to a real `<button>` element
- improves the CSS

Props janak007, afercia.
Fixes #42853.

Built from https://develop.svn.wordpress.org/trunk@44895


git-svn-id: http://core.svn.wordpress.org/trunk@44726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-13 23:37:57 +00:00
Sergey Biryukov
16fd7d42e8 Menus: After [42857], apply background to the correct elements on Menus screen.
Props audrasjb, afercia, mukesh27, garrett-eclipse.
Fixes #46368.
Built from https://develop.svn.wordpress.org/trunk@44801


git-svn-id: http://core.svn.wordpress.org/trunk@44633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-05 21:01:49 +00:00
Andrea Fercia
5c60995bd4 Accessibility: Replace media placeholder clickable divs with buttons.
`<button>` elements are natively interactive, supported by any assistive technology, and must be used instead of non-semantic, non-accessible `<div>` elements.

Also, this change aligns the Media Widgets and the Customizer site icon and site logo controls with the design pattern used in the new Block Editor for similar controls.

Props ramonopoly, welcher, afercia.
Fixes #43151.

Built from https://develop.svn.wordpress.org/trunk@44796


git-svn-id: http://core.svn.wordpress.org/trunk@44628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-05 17:49:52 +00:00
Andrea Fercia
957ad84b81 Coding standards: Fix incorrect CSS rgba() values.
Also, fixes some indentation where spaces were used instead of tabs.

Props nielslange, mukesh27.
Fixes #45937.

Built from https://develop.svn.wordpress.org/trunk@44791


git-svn-id: http://core.svn.wordpress.org/trunk@44623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-04 22:02:52 +00:00
Adam Silverstein
0e5e765a1b Revisions: improve display responsiveness, especially on smaller screen sizes.
* Fix an overlap issue with the "Restore this Revision" button that made it difficult to use on phone sized devices.

Props ryan, PranaliPatel, karinedo.
Fixes #33830.


Built from https://develop.svn.wordpress.org/trunk@44781


git-svn-id: http://core.svn.wordpress.org/trunk@44613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-28 20:11:50 +00:00
Andrea Fercia
7f977760a1 Accessibility: Improve buttons placement in the Comments Quick edit/Reply form.
Proximity of related information is an inclusive design principle that benefits everyone and it's particularly important for users with reduced visual field, low vision, or other vision or cognitive impairments. User interface controls that are logically grouped should be placed close to each other.
Also, this change makes the buttons visual order and the DOM order match.

Fixes #45972.

Built from https://develop.svn.wordpress.org/trunk@44757


git-svn-id: http://core.svn.wordpress.org/trunk@44589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-20 22:09:50 +00:00
Gary Pendergast
a7ef0feac0 Admin: Update the About page design to match mockups.
This commit also moves the images to s.w.org, removes the old "Gutenberg has been deactivated" warning, as well as removing some old JS from About pages of years gone past.

Props melchoyce, ryelle, paaljoachim, karmatosed, pento.
Fixes #46161.


Built from https://develop.svn.wordpress.org/trunk@44749


git-svn-id: http://core.svn.wordpress.org/trunk@44581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-19 01:57:52 +00:00
Gary Pendergast
82859e2641 Accessibility: Fix a regression in the old media modal pagination links.
[43019] improved the table pagination link styling, but introduced a regression in the old media dialog.

Props afercia, joneiseman.
Fixes #41858.


Built from https://develop.svn.wordpress.org/trunk@44747


git-svn-id: http://core.svn.wordpress.org/trunk@44579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-17 22:24:52 +00:00
Peter Wilson
f5cab6780f Administration: Save column visibility on small screens.
Modifies the jQuery selector for determining hidden columns to ensure they are detected when the expanded columns details are closed.

Adds high-specificity selectors specifically for setting screen options in the comments and plugins lists.

Props afercia.
Fixes #46005. 


Built from https://develop.svn.wordpress.org/trunk@44722


git-svn-id: http://core.svn.wordpress.org/trunk@44553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-01 02:14:51 +00:00
Felix Arntz
92c3c46abe Bootstrap/Load: Revert fatal error recovery mechanism from 5.1 to polish for 5.2.
Due to the high number of follow-up tickets and associated security concerns, it was decided to reschedule the fatal error recovery feature for WordPress 5.2, in order to address these issues properly. The feature will continue to be developed, with iterations being merged into trunk early in the 5.2 release cycle.

Fixes #46141. See #44458, #45932, #45940, #46038, #46047, #46068.

Built from https://develop.svn.wordpress.org/trunk@44717


git-svn-id: http://core.svn.wordpress.org/trunk@44548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-30 11:01:52 +00:00
Gary Pendergast
9b2a6b606c Plugin Installer: Ensure CSS for the 3-column view isn't applied to the 4-column view.
Props nielslange.
Fixes #43573.


Built from https://develop.svn.wordpress.org/trunk@44646


git-svn-id: http://core.svn.wordpress.org/trunk@44477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-18 04:03:52 +00:00
Andrea Fercia
173e0f9ee7 Administration: CSS coding standards
- properties should be followed by a colon and a space
- media queries shouldn't use spaces within parenthesis
- indentation should use tabs instead of spaces or mixed spaces / tabs
- the content property should use double quotes
- no double spaces

Props nadim0988, afercia.
Fixes #45185.

Built from https://develop.svn.wordpress.org/trunk@44637


git-svn-id: http://core.svn.wordpress.org/trunk@44468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-17 07:41:52 +00:00
Andrea Fercia
da760d1ecf Taxonomy: Remove extra padding around buttons on term edit page.
Props monikarao, mukesh27, chetan200891.
See #9777.
Fixes #45183.

Built from https://develop.svn.wordpress.org/trunk@44621


git-svn-id: http://core.svn.wordpress.org/trunk@44452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 12:59:52 +00:00
Andrea Fercia
f76f57e8ab Admin: Use the correct CSS media query for the Help tab on small screens after [44588].
See #43221

Built from https://develop.svn.wordpress.org/trunk@44604


git-svn-id: http://core.svn.wordpress.org/trunk@44435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 07:48:50 +00:00
Gary Pendergast
11e9c98d5b Admin: Make the Help tab available on small screens.
Props jobthomas, xkon.
Fixes #43221.


Built from https://develop.svn.wordpress.org/trunk@44588


git-svn-id: http://core.svn.wordpress.org/trunk@44419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 00:20:50 +00:00
Andrea Fercia
1c59f76953 Accessibility: Exclude the Windows High Contrast mode transparent outline from the CSS transition after [44544].
See #41286.

Built from https://develop.svn.wordpress.org/trunk@44575


git-svn-id: http://core.svn.wordpress.org/trunk@44406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-12 15:01:49 +00:00
Andrea Fercia
298ef1992e Menus: Make menu items not jump while dragging items.
Props alexvorn2, welcher, afercia.
Fixes #41160.

Built from https://develop.svn.wordpress.org/trunk@44567


git-svn-id: http://core.svn.wordpress.org/trunk@44398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-11 13:56:49 +00:00
Andrea Fercia
9a9b5699fd Accessibility: Improve text input in the Tags meta box when using Safari + Voiceover.
Props parbaugh, konainm, wbrubaker, pento, ryelle.
Fixes #44966.

Built from https://develop.svn.wordpress.org/trunk@44551


git-svn-id: http://core.svn.wordpress.org/trunk@44382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 22:30:49 +00:00
Andrea Fercia
64bbbda39e Accessibility: Improve color contrast ratio in the Events and News dashboard widget.
Props boemedia, lucagrandicelli.
Fixes #45280.

Built from https://develop.svn.wordpress.org/trunk@44549


git-svn-id: http://core.svn.wordpress.org/trunk@44380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 22:08:49 +00:00
Andrea Fercia
0b5beabd36 Accessibility: Remove negative tabindex from the login, install, and setup pages header.
Props bamadesigner, rishishah, jainnidhi.
Fixes #42632.

Built from https://develop.svn.wordpress.org/trunk@44545


git-svn-id: http://core.svn.wordpress.org/trunk@44376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 17:21:52 +00:00
Andrea Fercia
7481337591 Accessibility: Add focus styles for Windows High Contrast mode.
Introduces in core new focus styles dedicated to Windows High Contrast mode. The 
new styles use a transparent CSS outline as already explored in the Block Editor.
This first part covers some of the main user interface controls like buttons, links,
and media views elements. Other parts will be addressed in the next future.

Fixes #41286.

Built from https://develop.svn.wordpress.org/trunk@44544


git-svn-id: http://core.svn.wordpress.org/trunk@44375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 16:47:50 +00:00
Andrea Fercia
c40ae024cd Accessibility: Improve the way Safari and VoiceOver read out the screen reader text.
Sometimes, Safari and VoiceOver read out the text hidden with `screen-reader-text`
in a wrong order. While there's no known, full, solution, it is possible to make 
them respect the correct order reliably at least within buttons.

Fixes #42006.

Built from https://develop.svn.wordpress.org/trunk@44543


git-svn-id: http://core.svn.wordpress.org/trunk@44374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 16:31:49 +00:00
Felix Arntz
1e4088fc98 Bootstrap/Load: Introduce fatal error recovery mechanism allowing users to still log in to their admin dashboard.
This changeset introduces a `WP_Shutdown_Handler` class that detects fatal errors and which extension (plugin or theme) causes them. Such an error is then recorded, and an error message is displayed. Subsequently, in certain protected areas, for example the admin, the broken extension will be paused, ensuring that the website is still usable in the respective area. The major benefit is that this mechanism allows site owners to still log in to their website, to fix the problem by either disabling the extension or solving the bug and then resuming the extension.

Extensions are only paused in certain designated areas. The frontend for example stays unaffected, as it is impossible to know what pausing the extension would cause to be missing, so it might be preferrable to clearly see that the website is temporarily not accessible instead.

The fatal error recovery is especially important in scope of encouraging the switch to a maintained PHP version, as not necessarily every WordPress extension is compatible with all PHP versions. If problems occur now, non-technical site owners that do not have immediate access to the codebase are not locked out of their site and can at least temporarily solve the problem quickly.

Websites that have custom requirements in that regard can implement their own shutdown handler by adding a `shutdown-handler.php` drop-in that returns the handler instance to use, which must be based on a class that inherits `WP_Shutdown_Handler`. That handler will then be used in place of the default one.

Websites that would like to modify specifically the error template displayed in the frontend can add a `php-error.php` drop-in that works similarly to the existing `db-error.php` drop-in.

Props afragen, bradleyt, flixos90, ocean90, schlessera, SergeyBiryukov, spacedmonkey.
Fixes #44458.

Built from https://develop.svn.wordpress.org/trunk@44524


git-svn-id: http://core.svn.wordpress.org/trunk@44355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 20:05:49 +00:00
Gary Pendergast
0888007275 Admin: Add a "Set up your homepage" link to the Welcome panel.
As many WordPress sites use a static homepage rather than a blog, this link gives a natural next step for new sites owners wanting to configure their site in this manner.

Props professor44, joyously, nielslange, mukesh27, melchoyce.
Fixes #45019.


Built from https://develop.svn.wordpress.org/trunk@44485


git-svn-id: http://core.svn.wordpress.org/trunk@44316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 00:12:49 +00:00
Gary Pendergast
952c7253d3 Comments: Improve the Author box in the Edit Comment screen.
- Add a border below the heading, to match meta boxes.
- Remove the colons from the input labels.
- Tweak the padding and margins.

Props birgire, abdullahramzan, rhetorical, BODA1982, pento.
Fixes #43586.


Built from https://develop.svn.wordpress.org/trunk@44466


git-svn-id: http://core.svn.wordpress.org/trunk@44297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 06:19:50 +00:00
desrosj
f082806afa Block Editor: Display notice to the user when JavaScript is disabled.
Currently, when viewing the block editor with JavaScript disabled, the user sees a blank admin page with the admin menu sidebar. This adds an admin notice informing the user that JavaScript is required for the new block editor.

Props mkaz, pento, azaozz, ocean90, desrosj.
Fixes #45453.
Built from https://develop.svn.wordpress.org/trunk@44437


git-svn-id: http://core.svn.wordpress.org/trunk@44268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 20:40:50 +00:00
Sergey Biryukov
b06701a167 Plugins: Colorize plugin card compatibility icons on Add Plugins screen.
Props afragen, melchoyce, daniel-koskinen.
Fixes #44619.
Built from https://develop.svn.wordpress.org/trunk@44352


git-svn-id: http://core.svn.wordpress.org/trunk@44182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-20 18:15:47 +00:00
desrosj
9cd64e1341 Help/About: WordPress 5.0 About Page.
The About page describes all the great changes in WordPress 5.0.

Highlights:

- Warn users of Gutenberg plugin of its deactivation upon 5.0 upgrade.
- Added illustrations to the Four Freedoms page.
- Include a link to wporg user’s plugin favorites as a way to display only the classic plugin as a suggestion for install.
- Detail the Classic Editor plugin and the support timeline.

Props pixelverbieger, ocean90, karmatosed, pento, boemedia, lonelyvegan, sami.keijonen, TimothyBlynJacobs, xkon, afercia, laurelfulford, joostdevalk, ipstenu, matveb, joen, tinkerbelly, chanthaboune, kjellr, alexislloyd, melchoyce, mcsf, courtney0burton, Otto42, cathibosco, tobifjellner, helen, audrasjb, antpb, jjj, elrae, desrosj, azaozz, joemcgill, skithund, gziolo.

Merges [43913], [43921-43922], [43937-43938], [43946-43947], [43952-43953], [43967-43969] into trunk.

Fixes #45178.
Built from https://develop.svn.wordpress.org/trunk@44264


git-svn-id: http://core.svn.wordpress.org/trunk@44094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-17 16:36:59 +00:00
Sergey Biryukov
8f1ed83852 Build Tools: Revert unrelated changes to Gruntfile.js added in [44245].
See #45156.
Built from https://develop.svn.wordpress.org/trunk@44246


git-svn-id: http://core.svn.wordpress.org/trunk@44076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-17 03:23:04 +00:00
Sergey Biryukov
c6d8f995cd Build Tools: Add non-minified @wordpress scripts to the build output.
Props atimmer.
Merges [43886] to trunk.
See #45156.
Built from https://develop.svn.wordpress.org/trunk@44245


git-svn-id: http://core.svn.wordpress.org/trunk@44075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-17 03:22:13 +00:00
atimmer
0a372b57d0 Build/Test: Update dependencies for 5.0
Updates package dependencies to more modern versions, also adds .nvmrc and package-lock.json as followups to [43683] and [43571].

Merge notes: trunk already had an identical .nvmrc. package-lock.json exists in trunk, but has some changes based on the dependency updates.

Props jorbin.
Merges [43684], [43685] and [43686] to trunk.
See #44600.
Fixes #45064.

Built from https://develop.svn.wordpress.org/trunk@43977


git-svn-id: http://core.svn.wordpress.org/trunk@43809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-11 16:13:26 +00:00
Mel Choyce
7081f6c8fa List Tables: Arrange action items into a grid with extra space.
On small screens, list table actions were cramped. This makes it easy to press the wrong action by mistake. The items are now arranged into a grid and given extra room to create a larger tap-target.

The plugins list table was excluded because it's current layout doesn't match the others, and we should add more space to this in a future commit.

Props jobthomas, ryelle.
Fixes #45024.

Built from https://develop.svn.wordpress.org/trunk@43670


git-svn-id: http://core.svn.wordpress.org/trunk@43499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-03 18:56:24 +00:00
Gary Pendergast
8617817fb4 Plugin Installer: Allow 4 columns of search results on wide screens.
For screens wider than 2300px, show 4 colums of search results, as 3 columns looked quite stretched out.

This change also increases the default number of search results from 30 to 36, so that the columns have an even number of results, regardless of whether there are 2, 3, or 4 of them.

Props nielslange.
Fixes #43573.


Built from https://develop.svn.wordpress.org/trunk@43669


git-svn-id: http://core.svn.wordpress.org/trunk@43498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-02 20:07:24 +00:00
John Blackbourn
8730f3cb79 Customize: Increase the colour contrast of the line numbers in CodeMirror.
Props earnjam, abdullahramzan, audrasjb, Luminus

Fixes #44763

Built from https://develop.svn.wordpress.org/trunk@43574


git-svn-id: http://core.svn.wordpress.org/trunk@43403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-19 11:01:23 +00:00
Sergey Biryukov
632d61cead Plugins: Disable "Install Now" button for plugins that require a higher version of PHP or WordPress.
Display a notice with an explanation and the steps required to resolve the issue.

Props afragen, schlessera, flixos90, nerrad, melchoyce, boemedia, hedgefield, joyously, johnalarcon, lakenh, afercia, acirujano, ibantxillo, SergeyBiryukov.
Fixes #43986.
Built from https://develop.svn.wordpress.org/trunk@43436


git-svn-id: http://core.svn.wordpress.org/trunk@43263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-09 13:45:25 +00:00
Gary Pendergast
922f83a69f Once upon a midnight dreary, while I coded, weak and weary,
In many a strange and curious file of forgotten lore—
While I pondered, blaming Nacin, my notifications suddenly awakened,
As of someone quietly DMing;—DMing me, I can’t ignore.
“’Tis some contributor,” I muttered, “DMing me an idea or four—
            Only this and nothing more.”

Ah, distinctly I remember, at WordCamp US, last December;
A mad proposal nearly laid me—down out cold—upon the floor.
Curious, I listened closely;—to a plan I agreed with, mostly—
A way to make our JavaScript—JavaScript which was a chore—
Maintainable, extendable, for the future, is what I saw.
            Guten-ready for evermore.

Open here I switch to Slack, when, with many a patch and hack,
In there stepped Omar, a JavaScript developer hardcore;
Pronouncing all the changes fit; ready now to be commit;
“There’s nothing else for us to do,” DMing me, “It’s done!” he swore—
“No longer random guessing at which file need next be explored—
            Let’s move on, we’re all aboard.”

Moved all together, grouped and managed, in folders all is packaged,
The code had all been cleaned and tidied, important parts moved to the fore,
“Though this change be useful here,” I said, “it is too large, I fear,
We couldn’t manage such a patch, we’ve done nothing like this before—
Tell me where doth go this change, change to make our codebase soar!”
            Quoth Omar, “In WordPress Core.”

Props omarreis for shepherding this significant change.
Props adamsilverstein, aduth, atimmer, dingo_bastard, frank-klein, gziolo, herregroen, jaswrks, jeremyfelt, jipmoors, jorbin, netweb, ocean90, pento, tjnowell, and youknowriad for testing, feedback, discussion, encouragement, commiserations, etc.
I make no apologies for this commit message.
Fixes #43055.


Built from https://develop.svn.wordpress.org/trunk@43309


git-svn-id: http://core.svn.wordpress.org/trunk@43138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-23 10:05:31 +00:00
Andrew Ozz
534f732104 Privacy: use the more compatible word-break: break-all;, see [43278].
See #44092.
Built from https://develop.svn.wordpress.org/trunk@43282


git-svn-id: http://core.svn.wordpress.org/trunk@43111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 20:07:22 +00:00
Andrew Ozz
11ea5ebe0a Privacy: fix styling of the Privacy Settings buttons on mobile/small screens.
Props ianbelanger, azaozz.
Fixes #44093.
Built from https://develop.svn.wordpress.org/trunk@43279


git-svn-id: http://core.svn.wordpress.org/trunk@43108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 19:27:22 +00:00
Andrew Ozz
548f73cc7c Privacy: fix styling of the "next steps" buttons on the Export/Erase tools screens when text is long.
Props audrasjb, ianbelanger.
Fixes #44092.
Built from https://develop.svn.wordpress.org/trunk@43278


git-svn-id: http://core.svn.wordpress.org/trunk@43107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 18:59:21 +00:00
iandunn
3aaef96ff8 Privacy: Reposition log in policy link to avoid overlapping elements.
Previously, the link used absolute positioning, in order to stick it at the bottom of the page. That was done in order to create visual separation between it and the "action" links, like "Lost Your Password?"

The absolute positioning can cause conflicts in some situations, though. For example, if extra text or error notices are added above the form, then the login link would be positioned on top of other elements.

Switching to relative positioning with extra margins avoids those issues, while maintaining the visual separation between the "action" links and the privacy policy link.

Props imath, melchoyce, desrosj, xkon, iandunn.
Fixes #44046.

Built from https://develop.svn.wordpress.org/trunk@43274


git-svn-id: http://core.svn.wordpress.org/trunk@43103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 16:27:24 +00:00
Andrew Ozz
e765930982 Privacy: fix Export and Erase Personal Data list-tables on small screens.
Props ianbelanger, subrataemfluence, desrosj.
Fixes #44026.
Built from https://develop.svn.wordpress.org/trunk@43251


git-svn-id: http://core.svn.wordpress.org/trunk@43080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-14 09:21:21 +00:00
Weston Ruter
89708c5cec Customize: Hide expansion arrows in Customizer's available widgets list.
Fixes regression introduced by [42794].

Props dlh.
See #40677.
Fixes #43983.

Built from https://develop.svn.wordpress.org/trunk@43244


git-svn-id: http://core.svn.wordpress.org/trunk@43073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-11 17:35:23 +00:00
Sergey Biryukov
ae2b929294 Privacy: Update request confirmation notice text for clarity.
Props desrosj, melchoyce, garrett-eclipse.
Fixes #43970.
Built from https://develop.svn.wordpress.org/trunk@43232


git-svn-id: http://core.svn.wordpress.org/trunk@43061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 20:53:21 +00:00
iandunn
8af721fff8 Privacy: Replace intrusive policy update notice with menu bubbles.
Previously, when a plugin updated its suggested privacy policy text, an admin notice was shown on all screens in the Administration Panels. That was done in order to make sure that administrators were aware of it, so that they could update their policy if needed. That was a very heavy-handed and intrusive approach, though, which leads to a poor user experience, and notice fatigue. 

An alternative approach is to use bubble notifications in the menu, similar to when plugins have updates that need to be installed. That still makes it obvious that something needs the administrator's attention, but is not as distracting as a notice.

The notice will still appear on the Privacy page, though, since it is relevant to that screen, and provides an explanation of why the bubble is appearing.

Props azaozz, xkon, iandunn.
Fixes #43954. See #43953.

Built from https://develop.svn.wordpress.org/trunk@43223


git-svn-id: http://core.svn.wordpress.org/trunk@43052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 19:52:21 +00:00
Andrew Ozz
12d7f2be78 Privacy: fix styling on personal data tables.
Props melchoyce, allendav.
Fixes #43909.
Built from https://develop.svn.wordpress.org/trunk@43216


git-svn-id: http://core.svn.wordpress.org/trunk@43045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 16:02:21 +00:00
Andrew Ozz
7d9265e5c5 Privacy: cleanup of the "Export Personal Data" and "Erase Personal Data" screens.
Props desrosj, xkon.
See #43929.
Built from https://develop.svn.wordpress.org/trunk@43212


git-svn-id: http://core.svn.wordpress.org/trunk@43041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 10:01:21 +00:00
Andrew Ozz
35d5911ae8 Privacy: fixes for the privacy policy guide and suggested content:
- Separate the guide text form the suggested policy text.
- Add table of content for easier navigation.
- Move the content to tools.php (prevents the settings menu of being open).
- Add a link to the guide from the Privacy settings screen.

Props melchoyce, azaozz.
See #43980.
Built from https://develop.svn.wordpress.org/trunk@43203


git-svn-id: http://core.svn.wordpress.org/trunk@43032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-09 20:51:23 +00:00
Andrew Ozz
83c07f7a50 Privacy: fix spacing on small screens for the Use This Page button in Privacy Tools.
Props PressTigers, desrosj.
Fixes #43852.
Built from https://develop.svn.wordpress.org/trunk@43193


git-svn-id: http://core.svn.wordpress.org/trunk@43022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-09 16:13:21 +00:00
Andrew Ozz
3099f4d9ed Privacy: outputting the privacy policy guide and suggested content to a new page instead of a postbox.
Props melchoyce, azaozz.
See #43980.
Built from https://develop.svn.wordpress.org/trunk@43184


git-svn-id: http://core.svn.wordpress.org/trunk@43013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-08 23:45:21 +00:00
Andrew Ozz
c5d13c5934 Privacy: change how the default text for privacy policy is added:
- Insert both the text and tutorial in new policy pages and highlight is brightly in the editor.
- Show only the suggested text in the policy postbox.

Props melchoyce, azaozz.
See #43473.
Built from https://develop.svn.wordpress.org/trunk@43146


git-svn-id: http://core.svn.wordpress.org/trunk@42975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-03 17:13:21 +00:00
Andrew Ozz
0d2eb27a5d Privacy: do not fold a single section in the privacy policy poxtbox.
See #43473.
Built from https://develop.svn.wordpress.org/trunk@43126


git-svn-id: http://core.svn.wordpress.org/trunk@42955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 22:10:21 +00:00
iandunn
b1cf176f6e Privacy: Add policy link to login screen.
Personal data collection is more likely for registered users than casual visitors, and the privacy policy might have been updated since a user last logged in. Those changes could impact the collection of personal data from registered users, so it makes sense to provide a link to the policy before users log in.

Props voneff, xkon, melchoyce, chetan200891, desrosj.
Fixes #43721.

Built from https://develop.svn.wordpress.org/trunk@43120


git-svn-id: http://core.svn.wordpress.org/trunk@42949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 19:48:21 +00:00
Andrew Ozz
c21c4e25b3 Privacy: add default text for a privacy policy. First run.
Props xkon, idea15, allendav, azaozz.
See #43473.
Built from https://develop.svn.wordpress.org/trunk@43044


git-svn-id: http://core.svn.wordpress.org/trunk@42873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-30 14:47:21 +00:00
Andrea Fercia
e663af477a Coding standards: Change one occurrence of font weight 700 to 600.
Props chetan200891.
Amends [43018].
See #43897.

Built from https://develop.svn.wordpress.org/trunk@43021


git-svn-id: http://core.svn.wordpress.org/trunk@42850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-29 18:04:21 +00:00
Andrea Fercia
8d9f1ae0d5 Accessibility: Better color contrast for the tables pagination links.
By making the pagination links use the default style for buttons, color contrast
is improved and the CSS is simplified. Improves consistency with other UI controls.
Also, slightly increases the white space below the pagination links.

Props benoitchantre, afercia.
Fixes #41858.

Built from https://develop.svn.wordpress.org/trunk@43019


git-svn-id: http://core.svn.wordpress.org/trunk@42848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-29 16:25:21 +00:00
Andrea Fercia
26e91765eb Coding standards: Use numeric font weights instead of keywords.
Fixes #43897.

Built from https://develop.svn.wordpress.org/trunk@43018


git-svn-id: http://core.svn.wordpress.org/trunk@42847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-29 11:37:21 +00:00
Felix Arntz
6b2e34f703 General: Implement editorial, design and accessibility feedback for the PHP version nag.
The updated version of the nag is shorter, more on point and less aggressive than the previous one. It integrates better with the other dashboard widgets and fixes several accessibility concerns. A yellow warning color is used when the current PHP version is outdated, a red error color is used when it is also insecure.

Props afercia, birgire, danieltj, flixos90, johnjamesjacoby, karmatosed, Luciano Croce, nerrad, pento, schlessera, SergeyBiryukov, sonjaleix.

Fixes #41191.

Built from https://develop.svn.wordpress.org/trunk@43006


git-svn-id: http://core.svn.wordpress.org/trunk@42835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-26 14:31:24 +00:00
Andrew Ozz
891deab7c5 Privacy: make the sections in the suggested privacy policy text postbox foldable. Add Read More/Read Less buttons. Fix copying of the suggested text by pressing the button.
Props melchoyce, xkon, azaozz.
See #43620.
Built from https://develop.svn.wordpress.org/trunk@42992


git-svn-id: http://core.svn.wordpress.org/trunk@42821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-19 12:39:21 +00:00
Andrew Ozz
3108d2ffb2 Privacy: add a postbox that is shown when editing the privacy policy page, and where plugins and core will output suggested content and additional privacy info. First run.
Props melchoyce, azaozz.
See #43620.
Built from https://develop.svn.wordpress.org/trunk@42980


git-svn-id: http://core.svn.wordpress.org/trunk@42809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-16 08:53:20 +00:00
Andrew Ozz
4b2587abda Privacy: improve the screen for setting a privacy policy page.
Props melchoyce, xkon, azaozz.
See #43435.
Built from https://develop.svn.wordpress.org/trunk@42978


git-svn-id: http://core.svn.wordpress.org/trunk@42807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-13 17:56:20 +00:00
Andrew Ozz
108578a8ec Privacy: add new wp-admin screens for exporting and removing of personal data.
Props @melchoyce, @mikejolley, @allendav, @xkon.
See #43481.
Built from https://develop.svn.wordpress.org/trunk@42967


git-svn-id: http://core.svn.wordpress.org/trunk@42796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-10 18:02:30 +00:00
Sergey Biryukov
61a0745df8 Media: On Media Settings screen, make the pairs of labels and inputs always stacked vertically, on both mobile and desktop screens.
Make `<br />` tags on the screen behave as line breaks again after [41836]. Add a missing fieldset + legend for better accessibility.

Props afercia, RavanH, obenland, garrett-eclipse.
Fixes #42724. See #34539.
Built from https://develop.svn.wordpress.org/trunk@42864


git-svn-id: http://core.svn.wordpress.org/trunk@42694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-20 22:44:31 +00:00
Felix Arntz
ed1df81bba General: Introduce dashboard widget to inform administrators about outdated PHP versions.
This new dashboard widget is shown on WordPress sites which are powered by a PHP version which WordPress considers outdated, in order to inform site owners about the resulting problems and to explain how to upgrade to a supported version. An education page for that purpose has been previously created that the widget links to. The link is translatable so that localized versions of the page can be referred to as they become available.

The nag follows the example of the Browse Happy dashboard widget and is only visible for administrators, or network administrators when using multisite. To determine whether it needs to be displayed, a new wordpress.org API introduced prior is called that handles the version logic in a centralized location.

Props flixos90, hedgefield, schlessera.
Fixes #41191.

Built from https://develop.svn.wordpress.org/trunk@42832


git-svn-id: http://core.svn.wordpress.org/trunk@42662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-12 16:43:31 +00:00
Adam Silverstein
6751be3561 Customizer menus: correct oversized viewport after dragging menu items.
Fix an issue where the screen viewport resized to an oversized state on mobile devices after moving sub-menus.

Props kwonye.
Fixes #36884.

Built from https://develop.svn.wordpress.org/trunk@42817


git-svn-id: http://core.svn.wordpress.org/trunk@42647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-09 17:06:30 +00:00
Andrea Fercia
127ecc530c Accessibility: Underline the links in the Plugins descriptions and update notices.
Links within blocks and lines of text should always be underlined.

Props Travel_girl, chetan200891, Shital Patel.
Fixes #42647.

Built from https://develop.svn.wordpress.org/trunk@42810


git-svn-id: http://core.svn.wordpress.org/trunk@42640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 23:20:30 +00:00
Andrea Fercia
ffedf3d752 Accessibility: Widgets: Make the "Available Widgets" section operable with a keyboard.
For a number of years, the "Available Widgets" section has been off-limits for
keyboard users. Now it can be used also with the keyboard. This change introduces
also some improvements for assistive technologies.

- makes the widget toggles focusable and adds an `aria-expanded` attribute to indicate their state
- improves the toggles labelling to clarify context (add/edit)
- changes the controls to choose a sidebar from list items to buttons
- adds an `aria-label` attribute to the buttons to clarify their purpose
- adds an `aria-pressed` attribute to the buttons to indicate which one is selected
- improves color contrast of the selected button
- uses a `wp.a11y.speak()` message to announce to screen reader users when a widget has been added to a sidebar
- moves focus back to the toggle button when closing a widget

See #40677.

Built from https://develop.svn.wordpress.org/trunk@42794


git-svn-id: http://core.svn.wordpress.org/trunk@42624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-07 22:27:31 +00:00
Andrea Fercia
6a4b2a022a Accessibility: Make the Widgets screen "Enable accessibility mode" link more discoverable.
For a number of years, the link to the Widgets screen "Accessibility mode" lived
in the Screen Options panel, hidden by default. Many users, including assistive
technologies users, weren't able to find it or even aware it existed. By bringing
the link in the main screen, visible by default, this change makes the
"Accessibility mode" easily discoverable for everyone.

Props chetan200891, antonioeatgoat.
Fixes #42778.

Built from https://develop.svn.wordpress.org/trunk@42790


git-svn-id: http://core.svn.wordpress.org/trunk@42620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-06 17:21:33 +00:00
Andrea Fercia
9842bd6d24 Accessibility: Change the "Show / Hide dismissed updates" link to a button.
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.
Also, adds an `aria-expanded` attribute to communicate the expandable panel state
and improves the buttons spacing.

Props Cheffheid, audrasjb, afercia.
Fixes #38674.

Built from https://develop.svn.wordpress.org/trunk@42785


git-svn-id: http://core.svn.wordpress.org/trunk@42615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 15:50:30 +00:00
Andrea Fercia
64634898c2 Accessibility: Change the media upload "Dismiss error" link to a button.
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.

Props Cheffheid, audrasjb.
Fixes #38671.

Built from https://develop.svn.wordpress.org/trunk@42784


git-svn-id: http://core.svn.wordpress.org/trunk@42614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 15:33:33 +00:00
Sergey Biryukov
7a8e4bcb1b Administration: Remove erroneous transition-delay values from CSS files.
Although unitless zero is allowed for `<length>` CSS data type, it's invalid for `<time>` data type.

Props chetan200891, manuel_84, GaryJ.
Fixes #43195.
Built from https://develop.svn.wordpress.org/trunk@42689


git-svn-id: http://core.svn.wordpress.org/trunk@42517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 12:55:30 +00:00
Sergey Biryukov
12f854b6e8 Build/Test Tools: Update prefixed CSS properties in about.css.
Firefox 52+ supports unprefixed `column-count` and `column-gap` properties.

Props netweb, afercia.
Fixes #43190.
Built from https://develop.svn.wordpress.org/trunk@42687


git-svn-id: http://core.svn.wordpress.org/trunk@42515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-10 23:47:31 +00:00
Andrea Fercia
8a664edcab Administration: Make the Screen Options available on small screens.
Previously, the Screen Options toggle and the related panel content 
were hidden on small screens, preventing access to important settings,
including the ability to toggle the meta boxes visibility.

Props chetan200891.
Fixes #40985.

Built from https://develop.svn.wordpress.org/trunk@42644


git-svn-id: http://core.svn.wordpress.org/trunk@42473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-03 16:58:30 +00:00
Sergey Biryukov
4951b2897e Media: Remove checkered background for icons in Attachment Details.
Props BandonRandon.
Fixes #42535. See #41948.
Built from https://develop.svn.wordpress.org/trunk@42642


git-svn-id: http://core.svn.wordpress.org/trunk@42471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-03 13:54:31 +00:00
Andrea Fercia
a7c89d5761 Administration: CSS coding standards: use double quotes for values that require quotes.
As per the WordPress CSS coding standards, CSS properties with values that require quotes must use double quotes.
Also fixes some indentation and spacing.

Fixes #43220.

Built from https://develop.svn.wordpress.org/trunk@42641


git-svn-id: http://core.svn.wordpress.org/trunk@42470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-03 13:19:32 +00:00
Sergey Biryukov
d9d841b807 Media: Restore white background of the content area in media modal.
Props afercia, chetan200891.
Fixes #43088.
Built from https://develop.svn.wordpress.org/trunk@42572


git-svn-id: http://core.svn.wordpress.org/trunk@42401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-23 14:01:31 +00:00
Dion Hulse
ceaaed6604 Build: Use Node 8.x for trunk.
Props netweb.
See #35105.

Built from https://develop.svn.wordpress.org/trunk@42461


git-svn-id: http://core.svn.wordpress.org/trunk@42290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-16 03:58:49 +00:00
Sergey Biryukov
9cb44f5f2f Themes: Improve line wrapping in feature filter on Theme Install screen and in the Customizer.
Props chetan200891 for initial patch.
Fixes #42871.
Built from https://develop.svn.wordpress.org/trunk@42447


git-svn-id: http://core.svn.wordpress.org/trunk@42277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 19:27:53 +00:00
Weston Ruter
f4e974057e File Editor: Eliminate gap inserted between code editor and heading in IE11 when CodeMirror initializes.
Props afercia, melchoyce, Clorith for testing, SergeyBiryukov for testing.
See #12423.
Fixes #42554 for trunk.

Built from https://develop.svn.wordpress.org/trunk@42189


git-svn-id: http://core.svn.wordpress.org/trunk@42019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-15 18:29:46 +00:00
Weston Ruter
6c64136035 About Page: Fix issue with overlapping images and text on IE11 and Edge 15.
Props Clorith, ryelle, afercia, la-geek, SergeyBiryukov.
See #42514.
Fixes #42545.

Built from https://develop.svn.wordpress.org/trunk@42181


git-svn-id: http://core.svn.wordpress.org/trunk@42011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-14 23:02:48 +00:00
Weston Ruter
54a2c0dd1f About: Fix jumping behavior for titles and columns when scrolling.
Props ryelle.
See #42087.
Fixes #42514, #42526.

Built from https://develop.svn.wordpress.org/trunk@42173


git-svn-id: http://core.svn.wordpress.org/trunk@42003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 22:47:58 +00:00
Weston Ruter
6d2bf4398c About: Add vertical alignment for developer happiness sections.
Also run CSS autoprefixer to add `-ms-` prefixes for CSS grid identifiers for IE11.

Props Presskopp.
Amends [42121].
See #42087.
Fixes #42524 for trunk.

Built from https://develop.svn.wordpress.org/trunk@42161


git-svn-id: http://core.svn.wordpress.org/trunk@41992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-13 05:48:47 +00:00
Weston Ruter
2aa2c686d4 Theme Editor: Fix styling of child theme notice.
Props westonruter, melchoyce, ndiego.
See #24048.
Fixes #42491 for trunk.

Built from https://develop.svn.wordpress.org/trunk@42155


git-svn-id: http://core.svn.wordpress.org/trunk@41986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-11 20:43:53 +00:00
Weston Ruter
e86536afc9 Customize: Prevent nav menu location assignment checkbox change from increasing height by 1px.
Props obenland.
Amends [41817].
See #42157.
Fixes #42492.

Built from https://develop.svn.wordpress.org/trunk@42152


git-svn-id: http://core.svn.wordpress.org/trunk@41983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 23:01:48 +00:00
Weston Ruter
4bf8081e64 Widgets: Style the Image Widget's link field as invalid when a bad URL is supplied.
Fixes issue where user may supply an invalid URL and be unable to save the widget on the Widgets admin screen without being told why.

Amends [41252].
See #41274.
Fixes #42488.

Built from https://develop.svn.wordpress.org/trunk@42140


git-svn-id: http://core.svn.wordpress.org/trunk@41971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 01:28:49 +00:00
Weston Ruter
6c00350575 Settings: Fix date/time format previewing.
Props afercia.
Amends [41857].
Fixes #41603.

Built from https://develop.svn.wordpress.org/trunk@42134


git-svn-id: http://core.svn.wordpress.org/trunk@41965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-09 03:55:46 +00:00
Weston Ruter
3c6ce6751f Customize: Restore search icon to available widgets pane incorrectly removed in [41893].
See #42215.
Fixes #42472 for trunk.

Built from https://develop.svn.wordpress.org/trunk@42132


git-svn-id: http://core.svn.wordpress.org/trunk@41963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-09 01:02:47 +00:00
Mel Choyce
2382232692 About Page: Implement design.
Props ryelle, karmatosed, transl8or, obenland, melchoyce.
See #42087.

Built from https://develop.svn.wordpress.org/trunk@42121


git-svn-id: http://core.svn.wordpress.org/trunk@41952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 04:11:47 +00:00
Weston Ruter
ef272167c4 Customize: Present the date/time control input fields in the same format (and order) as date_format.
Props westonruter, obenland, atachibana for testing, Mirucon for testing.
See #42373, #28721.
Fixes #42394.

Built from https://develop.svn.wordpress.org/trunk@42111


git-svn-id: http://core.svn.wordpress.org/trunk@41940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-02 23:00:49 +00:00
Konstantin Obenland
b61de38e87 Customize: Spiff up theme updates
Fixes UI bugs around theme updates in the Customizer. Theme versions now get updated and users are no longer left alone after a successful update.

Props rinkuyadav999, celloexpressions for initial patch.
Fixes #42365.

Built from https://develop.svn.wordpress.org/trunk@42046


git-svn-id: http://core.svn.wordpress.org/trunk@41880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-31 01:33:47 +00:00
Weston Ruter
cb7483b595 Customize: Fix mobile placement of panes for available widgets and nav menu items.
Props Mahvash-Fatima.
Amends [41893].
See #42215.
Fixes #42359.

Built from https://develop.svn.wordpress.org/trunk@42036


git-svn-id: http://core.svn.wordpress.org/trunk@41870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-28 06:54:47 +00:00
Mel Choyce
c0d0380baa Code Editors: Tweak styles to work better on smaller screens.
See #42100.

Built from https://develop.svn.wordpress.org/trunk@41999


git-svn-id: http://core.svn.wordpress.org/trunk@41833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 20:29:46 +00:00
Helen Hou-Sandí
a7f2613fc7 Buttons: Ensure active styling applies to both :active and .active.
props sayedwp, helen.
fixes #42236.

Built from https://develop.svn.wordpress.org/trunk@41984


git-svn-id: http://core.svn.wordpress.org/trunk@41818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 23:34:49 +00:00
Aaron Jorbin
b8fc8cb59c Dashboard: Remove "Try Gutenberg" callout.
Reverting this for 4.9. It will be added back in a future version of WordPress. This doesn't mean that you shouldn't be trying Gutenberg, just that it isn't ready for a call out to a larger audience. But if you are the type to read commit messages, https://github.com/WordPress/gutenberg could use your pull requests and comments on issues.

Reverts [41931] [41900] [41896] [41895]
See #41316


Built from https://develop.svn.wordpress.org/trunk@41978


git-svn-id: http://core.svn.wordpress.org/trunk@41812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 20:48:47 +00:00
Andrea Fercia
69518459e6 Customize: Make sure the FTP credentials modal is visible.
The customizer and the theme installer use `visibility: hidden` on the body when
they open full-overlays screens. The FTP credentials modal needs a visibility
property set back to `visible` to be visible over those overlays.

Props purnendu.
Fixes #42205.

Built from https://develop.svn.wordpress.org/trunk@41972


git-svn-id: http://core.svn.wordpress.org/trunk@41806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 17:54:53 +00:00
Weston Ruter
c8105f1460 Customize: Fix alignment of Customize, Activate, and Live Preview buttons appearing on the Themes admin screen.
Amends [41893].
Props Mahvash-Fatima.
See #42215.
Fixes #42275.

Built from https://develop.svn.wordpress.org/trunk@41949


git-svn-id: http://core.svn.wordpress.org/trunk@41783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 18:10:47 +00:00
Weston Ruter
d695648084 Customize: Fix rendering issues in theme browsing when opening theme details or performing search in Safari.
Props sayedwp.
See #37661.
Fixes #42052.

Built from https://develop.svn.wordpress.org/trunk@41948


git-svn-id: http://core.svn.wordpress.org/trunk@41782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-19 17:57:47 +00:00
Sergey Biryukov
469e37446e Menus: Remove unnecessary top margin for menu item type on Menus screen for correct alignment with the dropdown icon.
Props punit5658.
Fixes #41521.
Built from https://develop.svn.wordpress.org/trunk@41925


git-svn-id: http://core.svn.wordpress.org/trunk@41759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 20:52:49 +00:00
Weston Ruter
9cb9695104 Customize: Fix visibility of overlay notifications in Safari.
Props sayedwp, westonruter.
Amends [41390].
See #35210, #42024, #42052.

Built from https://develop.svn.wordpress.org/trunk@41919


git-svn-id: http://core.svn.wordpress.org/trunk@41753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 18:14:37 +00:00
Konstantin Obenland
d8f98b3649 Customize: Unstick filter pane in Theme selector
Prevents the filter pane from blocking the view of theme search results when it's open.
Users are now able to just scroll to view results.

Props rclations.
Fixes #42212.

Built from https://develop.svn.wordpress.org/trunk@41903


git-svn-id: http://core.svn.wordpress.org/trunk@41737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 15:11:46 +00:00
Gary Pendergast
a2bd3e23d1 Dashboard: Ensure the "Dismiss" button on the Gutenberg callout is clickable.
Who likes z-index? We like z-index!

Props joemcgill.
See #41316.



Built from https://develop.svn.wordpress.org/trunk@41900


git-svn-id: http://core.svn.wordpress.org/trunk@41734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 14:55:48 +00:00
Konstantin Obenland
261f0d8ef2 Customize: Allow menu creation in locations pane
Adds a link to the menu creation workflow from the locations selector in the nav menu control.

Props bpayton, westonruter, Travel_girl, melchoyce, celloexpressions.
Fixes #36279.

Built from https://develop.svn.wordpress.org/trunk@41899


git-svn-id: http://core.svn.wordpress.org/trunk@41733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 14:51:47 +00:00
Mel Choyce
0c73d35816 Code Editors: Fix display of "help" cursor.
Props studionashvegas .
Fixes #42210.

Built from https://develop.svn.wordpress.org/trunk@41897


git-svn-id: http://core.svn.wordpress.org/trunk@41731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 13:11:49 +00:00
Gary Pendergast
3981736cd6 Dashboard: Introduce a "Try Gutenberg" callout.
To encourage more people to try Gutenberg, this new Dashboard box allows site users to easily install and try out Gutenberg.

Props pento, melchoyce, joen, karmatosed.
Fixes #41316.


Built from https://develop.svn.wordpress.org/trunk@41895


git-svn-id: http://core.svn.wordpress.org/trunk@41729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 10:04:47 +00:00
Weston Ruter
43b4a2577d Customize: Improve theme browsing UI on small screens.
Props Mahvash-Fatima, melchoyce, celloexpressions.
See #37661.
Fixes #42215.

Built from https://develop.svn.wordpress.org/trunk@41893


git-svn-id: http://core.svn.wordpress.org/trunk@41727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 04:06:47 +00:00
Weston Ruter
bd9d1d9178 Customize: Allow post/page stubs to be edited in WP Admin as "customization drafts" when changeset is saved as draft or scheduled.
* Update stubs to have draft status when changeset is saved as draft, instead of preventing auto-draft garbage collection by giving them a far-future `post_date`.
* Show notice in publish metabox when editing a customization draft indicating that it will be published automatically with its changeset; a link to Customizer is included.
* Include a new "Customization Draft" display post state in the post list table.
* Disconnect stubs from their changesets when they are updated with a status other than "Draft".
* Trash customization drafts when their related changeset is trashed or deleted.
* Add a `_customize_changeset_uuid` postmeta to stubs to link them with their associated changeset.
* Include `customize_changeset_uuid` as context when requesting to insert a new auto-draft.

Props westonruter, melchoyce.
See #39896, #39752, #34923.
Fixes #42220.

Built from https://develop.svn.wordpress.org/trunk@41887


git-svn-id: http://core.svn.wordpress.org/trunk@41721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-17 20:15:52 +00:00
Helen Hou-Sandí
bb66a52a14 Code Editors: Minor style improvements.
props melchoyce.
see #42214.

Built from https://develop.svn.wordpress.org/trunk@41882


git-svn-id: http://core.svn.wordpress.org/trunk@41716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 21:36:48 +00:00
Weston Ruter
94f9c7e789 Customize: Prevent theme details modal from being clipped in Safari.
Props afercia.
See #42052, #37661.

Built from https://develop.svn.wordpress.org/trunk@41871


git-svn-id: http://core.svn.wordpress.org/trunk@41705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-16 04:41:45 +00:00
Weston Ruter
ad8c9f0170 File Editor: Move inline to external style to fix extra padding in RTL page direction.
Props afercia.
Fixes #42221.

Built from https://develop.svn.wordpress.org/trunk@41865


git-svn-id: http://core.svn.wordpress.org/trunk@41699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-15 05:51:49 +00:00
Weston Ruter
8562e4bfac Customize: Fix visibility of theme browser header in Safari.
Props benoitchantre, afercia.
See #42052, #37661.

Built from https://develop.svn.wordpress.org/trunk@41863


git-svn-id: http://core.svn.wordpress.org/trunk@41697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-15 04:59:10 +00:00
Weston Ruter
24d304a0a1 Customize: Fix positioning of device-previewed window when publish settings are open.
* Update date control padding.
* Collapse publish settings section when opening panes for available widgets or nav menus.
* Remove save and cog buttons in mobile preview only mode.
* Move definition of `wp.customize.previewedDevice` to `wp.customize.state('previewedDevice')` for centralization, maintaining old alias.
* Remove unused CSS because the section is inside form now.

Props sayedwp, westonruter.
See #39896.
Fixes #42027, #42199.

Built from https://develop.svn.wordpress.org/trunk@41860


git-svn-id: http://core.svn.wordpress.org/trunk@41694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-13 21:21:55 +00:00
Helen Hou-Sandí
e48b16d96a File editor warning: Add a "Go back" button.
see #42100, #31779.

Built from https://develop.svn.wordpress.org/trunk@41859


git-svn-id: http://core.svn.wordpress.org/trunk@41693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-13 20:56:50 +00:00
Mel Choyce
e5db49d607 Settings: Widen time/day input fields on General Settings page, and move the preview onto the next line.
Props desrosj, afercia.
Fixes #41603.

Built from https://develop.svn.wordpress.org/trunk@41857


git-svn-id: http://core.svn.wordpress.org/trunk@41691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-13 18:39:48 +00:00
Mel Choyce
af6d136163 Improve File Credentials / Code Editor modal responsive styles.
Makes the modal full-width and height. 

Props sami.keijonen, Mirucon, helen.
Fixes #42111.

Built from https://develop.svn.wordpress.org/trunk@41854


git-svn-id: http://core.svn.wordpress.org/trunk@41688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-13 14:39:54 +00:00
Weston Ruter
8af4e6e3f9 Customize: Fix positioning of Preview button in mobile.
Props Mahvash-Fatima.
Fixes #42172.

Built from https://develop.svn.wordpress.org/trunk@41853


git-svn-id: http://core.svn.wordpress.org/trunk@41687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-13 08:23:50 +00:00
Weston Ruter
0659de4e21 File Editors: Display list of theme/plugin files in scrollable directory tree.
Props WraithKenny, afercia, melchoyce, westonruter.
Amends [41721].
Fixes #24048.

Built from https://develop.svn.wordpress.org/trunk@41851


git-svn-id: http://core.svn.wordpress.org/trunk@41685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-13 02:39:47 +00:00
Weston Ruter
434e3aba82 Customize: Add changeset locking in Customizer to prevent users from overriding each other's changes.
* Customization locking is checked when changesets are saved and when heartbeat ticks.
* Lock is lifted immediately upon a user closing the Customizer.
* Heartbeat is introduced into Customizer.
* Changes made to user after it was locked by another user are stored as an autosave revision for restoration.
* Lock notification displays link to preview the other user's changes on the frontend.
* A user loading a locked Customizer changeset will be presented with an option to take over.
* Autosave revisions attached to a published changeset are converted into auto-drafts so that they will be presented to users for restoration.
* Focus constraining is improved in overlay notifications.
* Escape key is stopped from propagating in overlay notifications, and it dismisses dismissible overlay notifications.
* Introduces `changesetLocked` state which is used to disable the Save button and suppress the AYS dialog when leaving the Customizer.
* Fixes bug where users could be presented with each other's autosave revisions.

Props sayedwp, westonruter, melchoyce.
See #31436, #31897, #39896.
Fixes #42024.

Built from https://develop.svn.wordpress.org/trunk@41839


git-svn-id: http://core.svn.wordpress.org/trunk@41673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-12 04:01:46 +00:00
Mel Choyce
a19f05ad63 Customizer: Improve specificity of small-screen styles in Widgets panel.
Props mrasharirfan, celloexpressions.
Fixes #41614.

Built from https://develop.svn.wordpress.org/trunk@41837


git-svn-id: http://core.svn.wordpress.org/trunk@41671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-12 03:53:47 +00:00
Mel Choyce
7e6748ad61 Settings: Widen image size input fields on Media Settings page.
On narrower devices, input fields are too short to fit the number of default digits they contain. This widens the fields and also breaks each height and width attribute onto a new line for better usability, using some terrible CSS trickery. My apologies.

Props: Toru, Presskopp, desrosj, xkon, ryelle, melchoyce.
Fixes #34539.

Built from https://develop.svn.wordpress.org/trunk@41836


git-svn-id: http://core.svn.wordpress.org/trunk@41670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-12 03:48:47 +00:00
Mel Choyce
009c3a94bb Gallery Widget: Fix row spacing across major browsers.
Props petertoi .
Fixes #42188.

Built from https://develop.svn.wordpress.org/trunk@41834


git-svn-id: http://core.svn.wordpress.org/trunk@41668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-11 21:14:51 +00:00
Mel Choyce
71aa62101f Gallery Widget: Remove grey background behind gallery, and align images to the edge of the container.
Props Presskopp, benoitchantre, mrasharirfan.
Fixes #42101.

Built from https://develop.svn.wordpress.org/trunk@41833


git-svn-id: http://core.svn.wordpress.org/trunk@41667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-11 19:45:49 +00:00
Weston Ruter
2866a3cad2 Customize: Vary description for nav menu locations control based on whether it is shown during menu creation.
Also fix issue with initial visibility of notice when there are no menus.

Amends [41823].
Props bpayton, melchoyce, westonruter.
See #42116.
Fixes #42113.

Built from https://develop.svn.wordpress.org/trunk@41832


git-svn-id: http://core.svn.wordpress.org/trunk@41666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-11 19:38:50 +00:00
Mel Choyce
39f3764a4b Code Editors: Improve cursor interactions on warning notices.
Fixes an issue where hovering over the warning icon didn't work if there were multiple warnings on the same line of code. Also updates the cursor from "pointer" to "help" when hovering over warnings and errors.

Props joyously, obenland.
Fixes #42129.

Built from https://develop.svn.wordpress.org/trunk@41830


git-svn-id: http://core.svn.wordpress.org/trunk@41664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-11 18:25:46 +00:00
Weston Ruter
c6f2ff7a8e Customize: Add notice for when there are no nav menus created yet, prompting user to create one.
Props bpayton, melchoyce, westonruter.
Fixes #42116.

Built from https://develop.svn.wordpress.org/trunk@41823


git-svn-id: http://core.svn.wordpress.org/trunk@41657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-11 05:28:52 +00:00
Weston Ruter
5bde734323 Customize: Fix vertical alignment of radio and checkbox inputs after [41740].
Props Shital Patel, subrataemfluence, sayedwp.
Amends [41740].
See #33085.
Fixes #42157.

Built from https://develop.svn.wordpress.org/trunk@41817


git-svn-id: http://core.svn.wordpress.org/trunk@41651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-10 23:45:51 +00:00
Mel Choyce
8f4e2bdb6b Customizer: Vertically center section arrows.
Props dualcube_subrata.
Fixes #42123.

Built from https://develop.svn.wordpress.org/trunk@41808


git-svn-id: http://core.svn.wordpress.org/trunk@41642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-10 16:23:50 +00:00
Weston Ruter
f462387431 Customize: Improve keyboard accessibility for publish settings section.
Props sayedwp.
See #39896.
Fixes #42027.

Built from https://develop.svn.wordpress.org/trunk@41802


git-svn-id: http://core.svn.wordpress.org/trunk@41636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-09 23:01:46 +00:00
Weston Ruter
35b5c9e762 Customize: Eliminate use of customize-loader in core so Customizer is opened consistently in top window.
* Open the door for future browser history feature in #28536, which is currently not feasible when customize-loader is used.
* Remove customizer-loader from being used on admin screens for Dashboard, Themes, non-shiny theme install/update.
* Keep the customize-loader functionality available for plugins, for the time being. It may become deprecated.
* Ensure `return` param in customizer links in Themes screen update to reflect `search` updated by `pushState`.
* Persist `return` when reloading Customizer due to theme switch, autosave restoration, or changeset trashing.
* Use `location.replace()` instead of changing `location.href` when trashing.
* Hide theme browser while Themes screen is loading when there is a `search` to prevent flash of unfiltered themes.
* Use throttling instead of debouncing when searching themes to ensure that screen is updated immediately on page load.
* Fix encoding and decoding of `search` param between URL and search field.
* Add support for dismissing autosaves when closing customize-loader, when it is used by plugins.
* Skip sending changeset UUID to customize-loader for population in browser location if changeset branching is not enabled.

See #28536.
Fixes #40254.

Built from https://develop.svn.wordpress.org/trunk@41797


git-svn-id: http://core.svn.wordpress.org/trunk@41631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-09 16:04:48 +00:00
Helen Hou-Sandí
b698881469 File Editors: Introduce an interstitial warning upon first visit.
This is an effort to provide a speed bump before heading into something potentially destructive and some education for users on better alternatives, even as we make the file editors safer to use. Each user, including existing users, will be shown a one-time dismissible modal warning on their first visit to each of the theme and plugin file editors.

Copy tweaks to come.

props michelleweber, Ipstenu, melchoyce, adamsilverstein, westonruter, toddnestor, aryamaaru, ZaneMatthew, cliffseal, helen.
fixes #31779.

Built from https://develop.svn.wordpress.org/trunk@41774


git-svn-id: http://core.svn.wordpress.org/trunk@41608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-05 04:25:48 +00:00
Weston Ruter
9d6134a88c Customize: Add default control template for standard input types.
Re-use default template instead of introducing custom one for the Discard Changes button.

See #30738.

Built from https://develop.svn.wordpress.org/trunk@41771


git-svn-id: http://core.svn.wordpress.org/trunk@41605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-05 02:56:47 +00:00
Weston Ruter
275f4713a5 Customize: Improve the menu creation flow.
Often, folks run into two issues when they create new menus: they click "Add a Menu" thinking it will add a new page to their menu, or they forget to assign their new menu to a location, and then wonder why it doesn't show up on their site.

This commit rearranges the order of items in the menu panel, and updates the flow for creating a menu by breaking it up into steps. Additionally, more help text has been added to guide people through the process of creating a menu.

Also adds default `type` lookups for Panel and Section instances. See #30741.

Props bpayton, obenland, westonruter, celloexpessions, afercia, melchoyce, zoonini, michelleweber.
Fixes #40104.

Built from https://develop.svn.wordpress.org/trunk@41768


git-svn-id: http://core.svn.wordpress.org/trunk@41602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-05 02:22:49 +00:00
Gary Pendergast
37aa531cd4 Plugins: Tweak the plugin icons added in [41695].
- Remove plugins icons from the plugin list table, as there were performance issues loading the icons when the site had lots of plugins.
- Depending on which icons the plugin has uploaded, prefer them in this order: `svg`, `128x128`, `256x256`.
- Improve the style of the fallback icon for plugins that don't have an icon defined.

Props Travel_girl, danieltj, afercia, karmatosed,hugobaeta, empireoflight, brentjett, melchoyce, pento.
Fixes #30186.


Built from https://develop.svn.wordpress.org/trunk@41755


git-svn-id: http://core.svn.wordpress.org/trunk@41589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-04 23:43:46 +00:00
Weston Ruter
f5bc1d1f52 Customize: Allow controls to be created with pre-instantiated Setting object(s), or even with plain Value object(s).
* Allow passing settings in keyed object (e.g. `settings: { default: 'id' }  ), or as an array (e.g. `settings: [ 'id' ]`) with first being default; again, `Setting`/`Value` objects may be supplied instead of IDs.
* Allow a single setting to be supplied with just a single `setting` param, either a string or a `Setting`/`Value` object.
* Update `changeset_status` and `scheduled_changeset_date` to be added dynamically with JS and simply passing of `api.state()` instances as `setting`.
* Introduce a `data-customize-setting-key-link` attribute which, unlike `data-customize-setting-link`, allows passing the setting key (e.g. `default`) as opposed to the setting ID.
* Allow `WP_Customize_Control::get_link()` to return `data-customize-setting-key-link` when setting is not registered.
* Eliminate `default_value` from `WP_Customize_Date_Time_Control` since now comes from supplied `Value`.
* Export status choices as `wp.customize.settings.changeset.statusChoices`.
* Export date and time formats as `wp.customize.settings.dateFormat` and `wp.customize.settings.timeFormat` respectively.

Props westonruter, sayedwp.
See #39896, #30738, #30741, #42083.
Fixes #37964, #36167.

Built from https://develop.svn.wordpress.org/trunk@41750


git-svn-id: http://core.svn.wordpress.org/trunk@41584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-04 20:02:49 +00:00