Commit Graph

42916 Commits

Author SHA1 Message Date
Sergey Biryukov
b152d93471 Editor: Update components package for WordPress 5.6 RC3.
@wordpress/components: 11.1.2 -> 11.1.3

This fixes an accessibility regression with VoiceOver not announcing the input label or an existing selection in the parent page dropdown under "Page Attributes" in the sidebar.

See https://github.com/WordPress/gutenberg/pull/27431 for more details.

Props isabel_brison, sarahricker, alexstine, kevin940726, talldanwp.
Reviewed by isabel_brison, SergeyBiryukov.
Merges [49737] to the 5.6 branch.
Fixes #51923.
Built from https://develop.svn.wordpress.org/branches/5.6@49738


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-03 14:47:29 +00:00
Helen Hou-Sandí
ca0e9e0891 Post WordPress 5.6 RC 2 version bump.
Built from https://develop.svn.wordpress.org/branches/5.6@49734


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-01 22:05:06 +00:00
Helen Hou-Sandí
310b4a2172 WordPress 5.6 RC 2.
Built from https://develop.svn.wordpress.org/branches/5.6@49733


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-01 21:45:04 +00:00
John Blackbourn
670319d84d REST API: Pass the previous state of the post as a parameter to the wp_after_insert_post hook.
This enables, for example, the previous post status to be used by this hook without the need to first capture it on an earlier hook.

This also fixes the value of the `$fire_after_hooks` parameter in `get_default_post_to_edit()` so the `wp_after_insert_post` action correctly fires just once on the new post screen.

This merges [45114] into the 5.6 branch

See #45114

Built from https://develop.svn.wordpress.org/branches/5.6@49732


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-01 20:57:05 +00:00
Sergey Biryukov
ea6021160a Tests: Ignore EOL differences in WP_List_Table::get_bulk_items() test for optgroups.
This avoids a misleading failure due to Unix vs. Windows EOL style mismatches and allows the test to pass on Windows.

Follow-up to [46612], [49190].

Reviewed by desrosj, SergeyBiryukov.
Merges [49691] to the 5.6 branch.
Fixes #19278.
Built from https://develop.svn.wordpress.org/branches/5.6@49730


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-01 19:42:05 +00:00
Sergey Biryukov
1857a746a5 Help/About: Move trailing punctuation in the jQuery Migrate Helper plugin link outside of the HTML tag.
Props psmits1567, audrasjb, tobifjellner, fierevere, markscottrobson.
Reviewed by desrosj, SergeyBiryukov.
Merges [49685] to the 5.6 branch.
Fixes #51813.
Built from https://develop.svn.wordpress.org/branches/5.6@49729


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-01 19:35:07 +00:00
desrosj
f8045141ad Twenty Twenty-One: Sync the latest changes for 5.6 RC2.
This will be the final sync from GitHub before placing that repository into read-only mode. All further changes should now flow entirely through Trac.

For a full list of changes since [49633], see 1d5a895...53acd9b.

Props poena, luminuu, kjellr, ryelle, allancole, melchoyce, felipeelia, aljullu, kebbet, chaton666, Clorith, mkaz, ingereck, paaljoachim.
Reviewed by desrosj, SergeyBiryukov.
Merges [49726] to the 5.6 branch.
Fixes #51526.
Built from https://develop.svn.wordpress.org/branches/5.6@49728


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-01 19:27:08 +00:00
Sergey Biryukov
d65c9e08eb Administration: Make sure row actions for recent comments in Activity dashboard widget stay visible when a single row gets focus.
Follow-up to [49142].

Props sabernhardt, kebbet, hareesh-pillai, pbiron.
Reviewed by ryelle, SergeyBiryukov.
Merges [49725] to the 5.6 branch.
Fixes #51886. See #51516, #49715.
Built from https://develop.svn.wordpress.org/branches/5.6@49727


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-01 19:21:06 +00:00
Sergey Biryukov
4541784a4f Site Health, App Passwords: Ensure REST API responses are properly translated.
The REST API requests in Site Health and App Passwords now include `_locale=user` in the request URL to ensure the user's locale is used instead of the site locale. Additionally, the `apiRequest` library now sends a JSON `Accept` header which is required by `determine_locale()` to respect the `_locale` query parameter.

The Site Health REST API controllers now manually load the default admin textdomain if not `is_admin()`. This allows for the Site Health tests to be translated even though the translations are part of the administration project and the REST API is not.

Props oglekler, kebbet, Clorith, TimothyBlynJacobs, ocean90, SergeyBiryukov, adamsilverstein.
Reviewed by TimothyBlynJacobs, SergeyBiryukov.
Merges [49716] to the 5.6 branch.
Fixes #51871.
Built from https://develop.svn.wordpress.org/branches/5.6@49724


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-01 18:07:08 +00:00
Sergey Biryukov
effd0cc28e Editor: Don't unnecessarily split a translatable string in block templates.
As a best practice, strings available for translation should contain entire sentences whenever possible.

Splitting a sentence in two parts and putting them back together after translation should be avoided, as the word order in other languages can be different from English.

Props tobifjellner, kebbet, audrasjb, mukesh27, hellofromTonya, azaozz, SergeyBiryukov.
Reviewed by azaozz, SergeyBiryukov.
Merges [49722] to the 5.6 branch.
Fixes #51893.
Built from https://develop.svn.wordpress.org/branches/5.6@49723


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-01 17:06:05 +00:00
Sergey Biryukov
49b15e942d Media: Revert [49567].
This addresses a regression with the pagination section in Media Library no longer taking additional query filtering into account.

Props iCaleb, trepmal, peterwilsoncc.
Reviewed by peterwilsoncc, SergeyBiryukov.
Merges [49720] to the 5.6 branch.
See #39968.
Built from https://develop.svn.wordpress.org/branches/5.6@49721


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-01 16:35:04 +00:00
Sergey Biryukov
024e5438ec Editor: Update packages for WordPress 5.6 RC2.
The following package versions were changed:

@wordpress/block-directory: 1.17.4 -> 1.17.5
@wordpress/block-editor: 5.1.3 -> 5.1.4
@wordpress/block-library: 2.26.4 -> 2.26.5
@wordpress/blocks: 6.24.1 -> 6.24.2
@wordpress/components: 11.1.1 -> 11.1.2
@wordpress/core-data: 2.24.1 -> 2.24.2
@wordpress/edit-post: 3.25.4 -> 3.25.5
@wordpress/editor: 9.24.3 -> 9.24.4
@wordpress/format-library: 1.25.3 -> 1.25.4
@wordpress/list-reusable-blocks: 1.24.1 -> 1.24.2
@wordpress/nux: 3.23.1 -> 3.23.2
@wordpress/reusable-blocks: 1.0.3 -> 1.0.4
@wordpress/server-side-render: 1.19.1 -> 1.19.2

See https://github.com/WordPress/gutenberg/pull/27366 for the list of fixed bugs.

Props isabel_brison.
Reviewed by isabel_brison, SergeyBiryukov.
Merges [49718] to the 5.6 branch.
Fixes #51902.
Built from https://develop.svn.wordpress.org/branches/5.6@49719


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-01 12:21:40 +00:00
Andrew Ozz
08062ba641 Quick/Bulk Edit: Fix undefined error when initializing UI Autocomplete 1.12.1 on non-existing element and then attempting to use the autocomplete instance.
Example: `jQuery( '#nonexisting' ).autocomplete().autocomplete( 'instance' ).something`.

Props _luigi, sabernhardt, donmhico, azaozz.
Reviewed by SergeyBiryukov, azaozz.
Merges [49703] and [49710] to the 5.6 branch.
Fixes #51872.
Built from https://develop.svn.wordpress.org/branches/5.6@49717


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-01 07:32:06 +00:00
Sergey Biryukov
53730e99fc Help/About: Update URLs in About page.
Replace the placeholder links now that the posts have been published. This also updates the jQuery plugin links to to local-site links, if the user can install plugins.

Follow-up to [49640].

Props mukesh27, ocean90.
Reviewed by ryelle, SergeyBiryukov.
Merges [49702] to the 5.6 branch.
See #51415.
Built from https://develop.svn.wordpress.org/branches/5.6@49715


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-30 17:32:04 +00:00
Sergey Biryukov
9c416615ce External Libraries: Upgrade PHPMailer to version 6.2.0.
For a full list of changes in this update, see the PHPMailer GitHub:
https://github.com/PHPMailer/PHPMailer/compare/v6.1.8...v6.2.0

Props ayeshrajans, jrf.
Reviewed by jrf, SergeyBiryukov.
Merges [49713] to the 5.6 branch.
Fixes #51874.
Built from https://develop.svn.wordpress.org/branches/5.6@49714


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-30 17:26:08 +00:00
Sergey Biryukov
3ccb035e8d Upgrade/Install: Display "You are using a development version" message on WordPress Updates screen for Beta or RC versions.
This ensures that the message is displayed when the `WP_AUTO_UPDATE_CORE` constant is set to `beta` or `rc` and the user is on a development version.

Follow-up to [49245], [49254], [49292], [49638], [49708].

Props afragen, audrasjb, azaozz, SergeyBiryukov.
Reviewed by azaozz, SergeyBiryukov.
Merges [49709] and [49668] to the 5.6 branch.
Fixes #51822.
Built from https://develop.svn.wordpress.org/branches/5.6@49712


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-30 16:53:05 +00:00
Sergey Biryukov
74600c1eed Upgrade/Install: Display "You are using a development version" message in the admin footer for Beta or RC versions.
This ensures that the message is displayed when the `WP_AUTO_UPDATE_CORE` constant is set to `beta` or `rc` and the user is on a development version.

Props afragen.
Reviewed by azaozz, SergeyBiryukov.
Merges [49708] to the 5.6 branch.
Fixes #51892.
Built from https://develop.svn.wordpress.org/branches/5.6@49711


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-30 16:38:09 +00:00
Andrew Ozz
6eec8bae02 External Libraries: Fix hiding of the text in the jQuery UI dialog close button.
Props marijnkoopman, SergeyBiryukov, Clorith, azaozz.
Merges [49704] to the 5.6 branch.
Fixes #51863.
Built from https://develop.svn.wordpress.org/branches/5.6@49707


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-29 09:56:09 +00:00
Sergey Biryukov
4c86c9d38c Comments: Correct ending tag placement in the "Search results for: ..." subtitle.
Follow-up to [49284], [49286].

Props Clorith, kebbet, johnbillion, audrasjb, azaozz.
Reviewed by azaozz, SergeyBiryukov.
Merges [49705] to the 5.6 branch.
Fixes #51889. See #37353.
Built from https://develop.svn.wordpress.org/branches/5.6@49706


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-28 17:32:04 +00:00
noisysocks
bc71ca7797 Editor: Remove render_block hooks from WP_Block
Reverts the move of pre_render_block, render_block_data, and
render_block_context to WP_Block.

This change has more implications than first thought so will be revisted later
in 5.7.

Reverts [49609,49608].
See #51612.

Built from https://develop.svn.wordpress.org/branches/5.6@49694


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-25 01:15:11 +00:00
desrosj
84e7b276b2 Build/Test Tools: Remove the E2E test GitHub Action workflow from the 5.6 branch.
The E2E test suite does not currently perform any meaningful tests, so continuing to run the workflow is not necessary for older branches.

Reviewed by peterwilsoncc, desrosj.
Fixes #51853.

Built from https://develop.svn.wordpress.org/branches/5.6@49690


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-24 16:07:04 +00:00
desrosj
626b4e78a7 Build/Test Tools: Remove the E2E test job from the 5.6 branch.
The E2E test job does not currently perform any meaningful tests, so continuing to run them is not necessary for older branches.

Reviewed by peterwilsoncc, desrosj.
Fixes #51853.

Built from https://develop.svn.wordpress.org/branches/5.6@49689


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-24 16:05:08 +00:00
Sergey Biryukov
a68d20cfcc Help/About: Clarify accessibility features.
* Captions are uploaded in the block editor, and not created in the editor.
* Avoid making an invalid claim of WCAG 2.1 conformance or trivialize the efforts still required to build an accessible and compliant site.

Follow-up to [49640].

Props joedolson.
Reviewed by ryelle, SergeyBiryukov.
Merges [49674] to the 5.6 branch.
See #51415.
Built from https://develop.svn.wordpress.org/branches/5.6@49687


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-23 19:42:02 +00:00
Sergey Biryukov
3cdf510961 Help/About: Correct placeholder for the accessibility statement feature plugin link.
Add missing translator comment.

Props audrasjb.
Reviewed by ryelle, SergeyBiryukov.
Merges [49651] to the 5.6 branch.
See #51415.
Built from https://develop.svn.wordpress.org/branches/5.6@49686


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-23 19:40:05 +00:00
Sergey Biryukov
5bbff0b5d6 Docs: Correct $fire_after_hooks parameter name in @since tags.
Follow-up to [49172], [49173].

Merges [49673] to the 5.6 branch.
Reviewed by peterwilsoncc, SergeyBiryukov.
Fixes #45114.
Built from https://develop.svn.wordpress.org/branches/5.6@49684


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-23 18:59:05 +00:00
Sergey Biryukov
f677bc838e Upgrade/Install: Replace the conditionals that check the AUTOMATIC_UPDATER_DISABLED constant and the automatic_updater_disabled filter in update-core.php with a call to WP_Automatic_Updater::is_disabled().
This prevents a PHP warning, fixes the logic, and considers `wp_is_file_mod_allowed( 'automatic_updater' )` when determining the UI state.

Props jamesros161, pbiron, audrasjb, azaozz.
Merges [49677] and [49681] to the 5.6 branch.
Fixes #51827.
Built from https://develop.svn.wordpress.org/branches/5.6@49682


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-22 16:06:06 +00:00
Andrew Ozz
1e60ec94af External Libraries: Update jQuery Migrate to 3.3.2.
Props mgol, azaozz.
Merges [49649] to the 5.6 branch.
Fixes #50564.
Built from https://develop.svn.wordpress.org/branches/5.6@49667


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-19 09:31:13 +00:00
Sergey Biryukov
e5de7dafd1 Site Health: Add missing i18n for the App Passwords documentation link.
Follow-up to [49334].

Props tai.
Reviewed by TimothyBlynJacobs, SergeyBiryukov.
Merges [49650] to the 5.6 branch.
Fixes #51815.
Built from https://develop.svn.wordpress.org/branches/5.6@49652


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-18 15:57:05 +00:00
whyisjake
d3d73c17ef Security: Update the Security Policy to acccount for 5.6.
See [49645].
Props helen, whyisjake.

Built from https://develop.svn.wordpress.org/branches/5.6@49646


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 23:01:10 +00:00
Helen Hou-Sandí
4ea6d8ec00 Branch 5.6.
Built from https://develop.svn.wordpress.org/branches/5.6@49643


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 22:50:10 +00:00
Helen Hou-Sandí
5ac21f5fbc Post WordPress 5.6 RC 1 version bump.
Built from https://develop.svn.wordpress.org/trunk@49642


git-svn-id: http://core.svn.wordpress.org/trunk@49380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 22:39:05 +00:00
Helen Hou-Sandí
c267ad2fde WordPress 5.6 RC 1.
Built from https://develop.svn.wordpress.org/trunk@49641


git-svn-id: http://core.svn.wordpress.org/trunk@49379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 22:01:02 +00:00
ryelle
6214f61cb1 Help/About: WordPress 5.6 About Page.
This change introduces the new About page for WordPress 5.6.

Props elmastudio, ryelle, melchoyce, karmatosed, webcommsat, marybaum, meher, OGlekler, lmurillom, vimes1984, sabrinazeidan, nalininonstopnewsuk, afshanadiya, michelleames, bmcdede, yvettesonneveld, sarahricker, isabel_brison, helen, hellofromtonya, poena, chanthaboune, cbringmann, joedolson, sabernhardt, garrett-eclipse, audrasjb, marks99.
See #51415.


Built from https://develop.svn.wordpress.org/trunk@49640


git-svn-id: http://core.svn.wordpress.org/trunk@49378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 21:34:04 +00:00
Sergey Biryukov
700c9455ab I18N: Avoid PHP notices for relative URLs in load_script_textdomain().
Props hellofromTonya, SeBsZ, archon810, nourma, justinahinon, SergeyBiryukov.
Fixes #49145.
Built from https://develop.svn.wordpress.org/trunk@49639


git-svn-id: http://core.svn.wordpress.org/trunk@49377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 20:52:09 +00:00
Helen Hou-Sandí
b456e9c9c8 Upgrade/Install: Consistent layout and accurate messages on the update screen.
* Clarifies that if you are on maintenance/security auto-updates that you are only on those and therefore there are more options available.
* Adds a message if a version control system has been detected, as automatic updates are disabled in that case.
* Ensures only one heading between `update available`, `you are on a dev version`, and `you are on latest` appears at any given time, falling back to `you are on latest` if something strange happens with the returned update data.
* Removes some older strings related to auto-updates, which greatly simplifies the above.
* Strips the `core-major-auto-updates-saved` query arg from the URL, as it is related to a dismissible notice.

Props audrasjb, pbiron, helen.
Fixes #51742.

Built from https://develop.svn.wordpress.org/trunk@49638


git-svn-id: http://core.svn.wordpress.org/trunk@49376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 20:28:04 +00:00
Sergey Biryukov
cce65c9baf Users: Use do_action_ref_array() for pre_get_users and pre_get_terms actions.
This brings some consistency with the other similar actions:

* `pre_get_comments`
* `pre_get_networks`
* `pre_get_posts`
* `pre_get_sites`
* `pre_user_query`

Follow-up to [29363] and [37572].

Props andy, adamsilverstein, hellofromTonya, desrosj, SergeyBiryukov.
Fixes #50961.
Built from https://develop.svn.wordpress.org/trunk@49637


git-svn-id: http://core.svn.wordpress.org/trunk@49375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 20:09:05 +00:00
desrosj
bcb9027236 Build/Test Tools: Update the package.json engines to point to the new LTS versions of Node/NPM.
Props mkaz, jorbin.
Fixes #51749.
Built from https://develop.svn.wordpress.org/trunk@49636


git-svn-id: http://core.svn.wordpress.org/trunk@49374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 19:52:00 +00:00
Sergey Biryukov
dfc3eeff10 General: Rename the wp_error_checked action to is_wp_error_instance for clarity.
Follow-up to [49022], [49023].

Props johnbillion, helen, johnjamesjacoby, Mte90, alexstandiford, hellofromTonya, jnylen0, SergeyBiryukov.
Fixes #40568.
Built from https://develop.svn.wordpress.org/trunk@49635


git-svn-id: http://core.svn.wordpress.org/trunk@49373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 19:21:05 +00:00
desrosj
50bf937ebb Build/Test Tools: Update several NPM dependencies.
These updates were applied when running `npm install`.

See #50769.
Built from https://develop.svn.wordpress.org/trunk@49634


git-svn-id: http://core.svn.wordpress.org/trunk@49372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 19:19:06 +00:00
desrosj
634e6b16c8 Twenty Twenty-One: Sync the latest changes for 5.6 RC1.
For a full list of changes since [49574-49577], see https://github.com/WordPress/twentytwentyone/compare/aa284fd...trunk.

Props poena, luminuu, kjellr, ryelle, aristath.
See #51526.
Built from https://develop.svn.wordpress.org/trunk@49633


git-svn-id: http://core.svn.wordpress.org/trunk@49371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 19:00:08 +00:00
Sergey Biryukov
cf75a715c4 App Passwords: Regenerate the .htaccess file to add a new rule.
Application Passwords introduced a new Rewrite Rule to handle the Authorization header on certain systems.

This bumps the database version and updates the file so the change is applied to sites upon upgrading to 5.6.

Follow-up to [49534].

Props pbiron, TimothyBlynJacobs, SergeyBiryukov.
Fixes #51723.
Built from https://develop.svn.wordpress.org/trunk@49632


git-svn-id: http://core.svn.wordpress.org/trunk@49370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 17:24:06 +00:00
Sergey Biryukov
f97647c207 Plugins: Make sure the HTML ID attributes for plugin checkboxes are unique.
Follow-up to [48374].

Props helen, sabernhardt, kishanjasani, mukesh27, hareesh-pillai.
Fixes #51256.
Built from https://develop.svn.wordpress.org/trunk@49631


git-svn-id: http://core.svn.wordpress.org/trunk@49369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 16:48:09 +00:00
Sergey Biryukov
7860b364fe Docs: Further remove tautology from comments in recurse_dirsize() tests.
Follow-up to [49212], [49616], [49628].

See #19879.
Built from https://develop.svn.wordpress.org/trunk@49630


git-svn-id: http://core.svn.wordpress.org/trunk@49368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 15:50:06 +00:00
Sergey Biryukov
5801fc9a93 Multisite: Rename the calculate_current_dirsize filter to pre_recurse_dirsize.
Set the default value to `false`. This brings some consistency with the `pre_get_space_used` filter.

Follow-up to [49212], [49616], [49628].

See #19879.
Built from https://develop.svn.wordpress.org/trunk@49629


git-svn-id: http://core.svn.wordpress.org/trunk@49367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 15:44:07 +00:00
Sergey Biryukov
e123448589 Docs: Adjust comments for recurse_dirsize() and related tests per the documentation standards.
Follow-up to [49212], [49616].

See #19879.
Built from https://develop.svn.wordpress.org/trunk@49628


git-svn-id: http://core.svn.wordpress.org/trunk@49366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 15:38:10 +00:00
Sergey Biryukov
f7d3a8b5c4 App Passwords: Add missing i18n for an error message.
Follow-up to [49617].

See #51513.
Built from https://develop.svn.wordpress.org/trunk@49627


git-svn-id: http://core.svn.wordpress.org/trunk@49365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 10:21:08 +00:00
Sergey Biryukov
1642f9bb1d Docs: Document the $args parameter of wp_oembed_get().
Link to `wp_oembed_get()` as the canonical source when documenting additional arguments in various `WP_oEmbed` methods.

Follow-up to [49620].

See #51269.
Built from https://develop.svn.wordpress.org/trunk@49626


git-svn-id: http://core.svn.wordpress.org/trunk@49364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 10:11:11 +00:00
noisysocks
9f065de733 Customize: Temporary fix for autosave restore notice not being removed
Fixes the "There is a more recent autosave of your changes" notice from not
being removed when the dismiss button is clicked.

The problem is caused by the notice being initialized twice: once by the
`common` script and then again by the `customize-controls` script.

This temporary fix prevents `customize-controls` from initializing a notice if
it has already been initialized.

A better fix would be to not initialize notices twice. This can be done by
removing `common` as a dependency of `updates` when `deprecateL10nObject` is
removed.

When this happens (est: 5.7), this temporary fix should be reverted.

Fixes #51425.
See #51317.
Props karthikbhatb, dlh, SergeyBiryukov.

Built from https://develop.svn.wordpress.org/trunk@49625


git-svn-id: http://core.svn.wordpress.org/trunk@49363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 04:45:11 +00:00
noisysocks
a3c8b3ddea Customize: Ensure multiple CSS classes are passed to nav_menu_link_attributes as an array
When multiple CSS classes are added to a menu item, the nav_menu_link_attributes
filter should be called with $item->classes set to an array of CSS class names.

When previewing in the Customizer, however, a single string was being passed to
$item->classes because WP_Customize_Nav_Menu_Item_Setting::preview() bypasses
wp_update_nav_menu_item() and instead uses filter_wp_get_nav_menu_items().

The fix is to make filter_wp_get_nav_menu_items() match what
wp_update_nav_menu_item() does and split the string into an array.

Fixes #43113.
Props dlh.

Built from https://develop.svn.wordpress.org/trunk@49624


git-svn-id: http://core.svn.wordpress.org/trunk@49362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 04:31:08 +00:00
noisysocks
fb2f5a743b Editor: Update WordPress packages for RC1
@wordpress/block-directory: 1.17.3 -> 1.17.4
@wordpress/block-library: 2.26.3 -> 2.26.4
@wordpress/edit-post: 3.25.3 -> 3.25.4

Fixes #51793.
Props isabel_brison.

Built from https://develop.svn.wordpress.org/trunk@49623


git-svn-id: http://core.svn.wordpress.org/trunk@49361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 04:13:29 +00:00