Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2025-01-09 09:57:38 +01:00
Code Issues Projects Releases Wiki Activity
42,525 Commits 50 Branches 749 Tags 807 MiB
bb67dde689
Commit Graph

16226 Commits

Author SHA1 Message Date
desrosj
acc97eae32 General: Reference the correct database version for 5.5.0 upgrades. 
Follow up to [48121].

See #50413.
Built from https://develop.svn.wordpress.org/trunk@48122


git-svn-id: http://core.svn.wordpress.org/trunk@47891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-22 17:33:08 +00:00
desrosj
4b60af1a6a General: Remove “whitelist” and “blacklist” in favor of more clear and inclusive language. 
“The WordPress open source community cares about diversity. We strive to maintain a welcoming environment where everyone can feel included.”

With this commit, all occurrences of “whitelist” and “blacklist” (with the single exception of the `$new_whitelist_options` global variable) are removed. A new ticket has been opened to explore renaming the `$new_whitelist_options` variable (#50434).

Changing to more specific names or rewording sentences containing these terms not only makes the code more inclusive, but also helps provide clarity. These terms are often ambiguous. What is being blocked or allowed is not always immediately clear. This can make it more difficult for non-native English speakers to read through the codebase.

Words matter. If one contributor feels more welcome because these terms are removed, this was worth the effort.

Props strangerstudios, jorbin, desrosj, joemcgill, timothyblynjacobs, ocean90, ayeshrajans, davidbaumwald, earnjam.
See #48900, #50434.
Fixes #50413.
Built from https://develop.svn.wordpress.org/trunk@48121


git-svn-id: http://core.svn.wordpress.org/trunk@47890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-22 17:26:13 +00:00
Sergey Biryukov
7dbc898342 Plugins: Make the appearance of plugin action links on Add Plugins screen more consistent. 
This ensures that the "More Details" link does not randomly wrap to a second line depending on the length of the button label above.

Props sabernhardt, kharisblank, Otto42, paresh07.
Fixes #48648.
Built from https://develop.svn.wordpress.org/trunk@48120


git-svn-id: http://core.svn.wordpress.org/trunk@47889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-22 15:30:18 +00:00
ellatrix
2349d1f999 Editor: Update default block categories 
See https://github.com/WordPress/gutenberg/pull/19279.

Props aduth, gziolo.
Fixes #50278.

Built from https://develop.svn.wordpress.org/trunk@48119


git-svn-id: http://core.svn.wordpress.org/trunk@47888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-22 14:07:10 +00:00
gziolo
85c5bca472 Editor: Remove default "layout" block attribute from WP_Block_Type::get_attributes 
The merging behavior which assigns the `layout` attribute in `WP_Block_Type` gets removed.

Props aduth, TimothyBlynJacobs.
Fixes #50257.


Built from https://develop.svn.wordpress.org/trunk@48118


git-svn-id: http://core.svn.wordpress.org/trunk@47887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-22 12:22:08 +00:00
gziolo
29ffb31cb3 Blocks: Add context fields to WP_Block_Type 
New block context related fields were added as part of https://github.com/WordPress/gutenberg/pull/22686. This changest backports them to WP_Block_Type class.

Props aduth, spacedmonkey, mcsf, epiqueras.
Fixes #47656.  


Built from https://develop.svn.wordpress.org/trunk@48117


git-svn-id: http://core.svn.wordpress.org/trunk@47886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-22 10:26:14 +00:00
Andrea Fercia
aa98d37cad Accessibility: Improve readability by removing unnecessary italic font style. 
Continues the removal of italic text where unnecessary or where used on whole lines and big chunks of text.
Removes italic type from:
- all the `howto` text e.g. the "Tags" meta box, the "Featured image" meta box, the "Insert/edit link" modal dialog in the Classic Editor 
- the Taxonomies list pages
- the edit Taxonomies pages
- the Menus page
- the Settings pages

Props audrasjb.
See #47327.

Built from https://develop.svn.wordpress.org/trunk@48116


git-svn-id: http://core.svn.wordpress.org/trunk@47885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-21 18:03:10 +00:00
Andrea Fercia
ae447adaf4 I18N: Restore the "Error:" prefix for error messages. 
Partially reverts [48059] as there's no full consensus on the removal of the text prefix. Further actions should be taken to improve consistency and accessibility of the admin notices. Keeps some improvements to the translatable strings from [48059].

Fixes #47656.

Built from https://develop.svn.wordpress.org/trunk@48115


git-svn-id: http://core.svn.wordpress.org/trunk@47884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-21 14:00:09 +00:00
Sergey Biryukov
e0d440f77f Posts, Post Types: Avoid a PHP warning when get_the_content() is called outside of the loop. 
This ensures that `$pages` and other globals are only used after they have been set up in `setup_postdata()`.

Follow-up to [44941].

Props tessawatkinsllc, dontdream, spacedmonkey, squarecandy, davidbaumwald, SergeyBiryukov.
Fixes #47824. See #42814.
Built from https://develop.svn.wordpress.org/trunk@48114


git-svn-id: http://core.svn.wordpress.org/trunk@47883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-21 10:36:07 +00:00
Sergey Biryukov
08d4e7dd69 Posts, Post Types: Simplify test_setup_postdata_loop(). 
The important part here is calling `the_content()` after setting up post data for another post without updating global `$post`.

The `foreach()` loop is not necessary.

Follow-up to [UT1289].

See #47824, #24330.
Built from https://develop.svn.wordpress.org/trunk@48113


git-svn-id: http://core.svn.wordpress.org/trunk@47882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-21 10:30:15 +00:00
TimothyBlynJacobs
88f54b22ba REST API: Add "Link" to the list of exposed cors headers. 
Currently, only the X-WP-Total and X-WP-TotalPages headers are exposed which means that clients have to manually construct the URL to implement pagination instead of using the "prev" and "next" Links.

Additionally, a filter "rest_exposed_cors_headers" is introduced to make it simpler for plugins to expose additional headers.

Props Toro_Unit, ayeshrajans.
Fixes #50369.

Built from https://develop.svn.wordpress.org/trunk@48112


git-svn-id: http://core.svn.wordpress.org/trunk@47881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 23:56:12 +00:00
Sergey Biryukov
19bca10d79 Coding Standards: Replace echo sprintf() with printf(). 
See #49542.
Built from https://develop.svn.wordpress.org/trunk@48111


git-svn-id: http://core.svn.wordpress.org/trunk@47880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 13:18:11 +00:00
Sergey Biryukov
be16bb9fba Docs: Remove extra spaces from @param tags. 
Per the documentation standards, `@param` tags should be aligned with each other, but not with the `@return` tag.

See #49572.
Built from https://develop.svn.wordpress.org/trunk@48110


git-svn-id: http://core.svn.wordpress.org/trunk@47879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 12:58:10 +00:00
Sergey Biryukov
b16368c268 Docs: Remove @staticvar tags from core. 
The tag was supported in phpDocumentor 1.x, but is no longer supported in 2.x and 3.x.

Usage of static variables is considered an internal implementation detail and has no information value for someone reading the docs.

Props alishanvr, jrf.
Fixes #50426.
Built from https://develop.svn.wordpress.org/trunk@48109


git-svn-id: http://core.svn.wordpress.org/trunk@47878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 12:40:12 +00:00
Sergey Biryukov
65724cf380 Docs: Correct DocBlock placement for allow_subdirectory_install filter. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48108


git-svn-id: http://core.svn.wordpress.org/trunk@47877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 12:24:08 +00:00
Sergey Biryukov
d586e4330d Docs: Miscellaneous DocBlock corrections for email filters in wp-includes/user.php. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48107


git-svn-id: http://core.svn.wordpress.org/trunk@47876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 12:22:07 +00:00
Sergey Biryukov
3fb623cf76 Docs: Use a hyphen with the "non" prefix in a more consistent way. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48106


git-svn-id: http://core.svn.wordpress.org/trunk@47875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 12:16:10 +00:00
Sergey Biryukov
26621b3b44 Docs: Miscellaneous DocBlock corrections for plugin and theme installation and updates. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48105


git-svn-id: http://core.svn.wordpress.org/trunk@47874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 12:14:09 +00:00
Sergey Biryukov
e13c363b17 Docs: Capitalize "ID", when referring to a post ID, term ID, etc. in a more consistent way. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48104


git-svn-id: http://core.svn.wordpress.org/trunk@47873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 12:02:12 +00:00
Sergey Biryukov
58bda42fc8 Docs: Synchronize and correct the documentation for wp_nav_menu() arguments in bundled themes. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48103


git-svn-id: http://core.svn.wordpress.org/trunk@47872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 11:22:10 +00:00
Sergey Biryukov
a576a13246 Docs: Remove an empty line between @param and @return tags, per the documentation standards. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48102


git-svn-id: http://core.svn.wordpress.org/trunk@47871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 11:18:09 +00:00
John Blackbourn
afe406b82e Docs: Fix some documentation errors in bundled themes. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48101


git-svn-id: http://core.svn.wordpress.org/trunk@47870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 07:24:06 +00:00
John Blackbourn
1a77bb81d8 Docs: Remove unnecessary variables names from @return tags. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48100


git-svn-id: http://core.svn.wordpress.org/trunk@47869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 22:55:12 +00:00
John Blackbourn
37234874a5 Docs: Misc improvements to inline docs. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48099


git-svn-id: http://core.svn.wordpress.org/trunk@47868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 22:28:13 +00:00
John Blackbourn
fe823d698f Docs: Corrections and improvements to inline docs related to XML sitemaps. 
See #50117, #49572
Built from https://develop.svn.wordpress.org/trunk@48098


git-svn-id: http://core.svn.wordpress.org/trunk@47867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 22:26:10 +00:00
John Blackbourn
acb8983ac1 Docs: Corrections and improvements to inline docs related to plugin and theme auto-updates. 
See #50052, #49572
Built from https://develop.svn.wordpress.org/trunk@48097


git-svn-id: http://core.svn.wordpress.org/trunk@47866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 22:17:07 +00:00
Sergey Biryukov
99d49a0cc3 Build/Test Tools: Replace the banner text from wp-emoji-loader.min.js in formatting.php during build process. 
This ensures that `/*! This file is auto-generated */` comment is not included on front end as part of the inline Emoji detection script.

Follow-up to [41271], [46589].

Props superpoincare, SergeyBiryukov.
Fixes #49861.
Built from https://develop.svn.wordpress.org/trunk@48096


git-svn-id: http://core.svn.wordpress.org/trunk@47865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 22:08:08 +00:00
Sergey Biryukov
82a5d41d9b Help/About: Move "Learn more: Auto-updates documentation" link about "Support", for consistency with other screens. 
Follow-up to [48062].

See #50215.
Built from https://develop.svn.wordpress.org/trunk@48095


git-svn-id: http://core.svn.wordpress.org/trunk@47864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 21:14:08 +00:00
Sergey Biryukov
896436f1b9 Sitemaps: Rename the wp_sitemaps_is_enabled filter to wp_sitemaps_enabled. 
This makes it more consistent with the other filters of the similar purpose.

Props arpitgshah.
Fixes #50428. See #50117.
Built from https://develop.svn.wordpress.org/trunk@48094


git-svn-id: http://core.svn.wordpress.org/trunk@47861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 18:00:07 +00:00
Sergey Biryukov
a15912561e Docs: Document globals in WP_Sitemaps_* classes the same way they are documented in the rest of core. 
See #49572, #50117.
Built from https://develop.svn.wordpress.org/trunk@48093


git-svn-id: http://core.svn.wordpress.org/trunk@47860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 17:56:09 +00:00
Andrew Ozz
aca919f007 Plugins and Themes Auto-Updates: 
- Fix displaying of errors on the Themes screen.
- Correct the classes used for the error messages, and use `notice-alt` as notices are mostly shown on a white background.

Props afercia, azaozz.
Fixes #50405.
Built from https://develop.svn.wordpress.org/trunk@48092


git-svn-id: http://core.svn.wordpress.org/trunk@47859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 16:51:14 +00:00
desrosj
019bc2d244 Docs: Add missing return type for _remove_theme_support(). 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48091


git-svn-id: http://core.svn.wordpress.org/trunk@47858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 14:46:10 +00:00
Sergey Biryukov
0050998801 Filesystem API: Expicitly set directory permissions in WP_Filesystem_SSH2::mkdir(). 
This ensures the permissions are correct after a directory is created with `ssh2_sftp_mkdir()`, which appears to be affected by system `umask` settings.

Props bbrdaric.
Fixes #49218.
Built from https://develop.svn.wordpress.org/trunk@48090


git-svn-id: http://core.svn.wordpress.org/trunk@47857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 10:38:08 +00:00
Sergey Biryukov
527696af3b Coding Standards: Add some space around control structures in WP_Filesystem_* classes for consistency and better readability. 
Additionally, synchronize `$tempfile` and `$temphandle` variable names in `WP_Filesystem_FTPext` and `WP_Filesystem_ftpsockets`.

See #49542.
Built from https://develop.svn.wordpress.org/trunk@48089


git-svn-id: http://core.svn.wordpress.org/trunk@47856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 10:36:12 +00:00
whyisjake
1e3d4921fb Privacy: Revert use relative paths for exported personal data. 
Tests need to be updated to pass.

See: #44038.

Unprops: whyisjake.


Built from https://develop.svn.wordpress.org/trunk@48088


git-svn-id: http://core.svn.wordpress.org/trunk@47855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 23:02:10 +00:00
whyisjake
2d514c83d5 Privacy: Use relative paths for exported personal data. 
Ensures back-compat while moving to paths off of the `/exports` directory.

Fixes: #44038.

Props: allendav, mrTall, desrosj, garrett-eclipse, cameronamcintyre, nmenescardi, xkon, whyisjake. 


Built from https://develop.svn.wordpress.org/trunk@48087


git-svn-id: http://core.svn.wordpress.org/trunk@47854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 21:40:14 +00:00
Adam Silverstein
810e9c3c2b Formatting: new filter safecss_filter_attr_allow_css on css parts. 
Enables developers to determine whether a section of CSS should be allowed or discarded. By default, the value will be false if the part contains \ ( & } = or comments. Returning true allows the CSS part to be included in the output.

Replaces the `safe_style_disallowed_chars` filter introduced in r47891.

Props azaozz.
Fixes #37134.


Built from https://develop.svn.wordpress.org/trunk@48086


git-svn-id: http://core.svn.wordpress.org/trunk@47853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 21:01:11 +00:00
Sergey Biryukov
50ffc3843b Docs: Add missing $user_data parameter name to lostpassword_post and lostpassword_errors filter DocBlocks. 
Follow-up to [48084].

See #49521, #49572.
Built from https://develop.svn.wordpress.org/trunk@48085


git-svn-id: http://core.svn.wordpress.org/trunk@47852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 20:29:15 +00:00
Sergey Biryukov
2c19aee6d5 Login and Registration: Introduce lostpassword_errors filter in retrieve_password() for errors encountered on a password reset request. 
This complements the `registration_errors` filter in `register_new_user()`.

Props wpdo5ea, dilipbheda.
Fixes #49521.
Built from https://develop.svn.wordpress.org/trunk@48084


git-svn-id: http://core.svn.wordpress.org/trunk@47851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 20:24:09 +00:00
Sergey Biryukov
05e28b4d7c Coding Standards: Use strict comparison for JS fragment in wp-admin/admin-header.php. 
Props subrataemfluence.
Fixes #45810.
Built from https://develop.svn.wordpress.org/trunk@48083


git-svn-id: http://core.svn.wordpress.org/trunk@47850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 20:08:09 +00:00
Sergey Biryukov
8d3075952e Administration: Combine the styles for <p> and .wp-die-message, instead of duplicating. 
This brings some consistency with `_default_wp_die_handler()`, where they are already combined.

Follow-up to [45909].

See #47580.
Built from https://develop.svn.wordpress.org/trunk@48082


git-svn-id: http://core.svn.wordpress.org/trunk@47849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 15:07:11 +00:00
Sergey Biryukov
168a9df672 Coding Standards: Fix WPCS issues in wp-includes/sitemaps/. 
Some of these were not caught when running `composer lint:errors`, but are fixed when running `phpcbf` directly.

Follow-up to [48072], [48080].

See #49542, #50117.
Built from https://develop.svn.wordpress.org/trunk@48081


git-svn-id: http://core.svn.wordpress.org/trunk@47848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 14:46:09 +00:00
Sergey Biryukov
e1bd050cb9 Coding Standards: Remove unused variable in WP_Sitemaps_Provider::get_sitemap_entries(). 
Follow-up to [48072].

See #49542, #50117.
Built from https://develop.svn.wordpress.org/trunk@48080


git-svn-id: http://core.svn.wordpress.org/trunk@47847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 14:44:07 +00:00
Pascal Birchler
fcd890e546 Sitemaps: Bump $wp_db_version to flush rewrite rules after [48072]. 
Props ocean90.
See #50117.

Built from https://develop.svn.wordpress.org/trunk@48079


git-svn-id: http://core.svn.wordpress.org/trunk@47846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 11:26:17 +00:00
Andrew Ozz
d61790f9dc Fix empty line phpcs error. 
See #50280.
Built from https://develop.svn.wordpress.org/trunk@48078


git-svn-id: http://core.svn.wordpress.org/trunk@47845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 00:46:09 +00:00
Andrew Ozz
7757ad5e94 Plugins and Themes Auto-Updates: allow overriding of the HTML for the auto-update setting link. This will let plugins show better/specific information when they are overriding the auto-update settings, for example "Updates are managed by ... plugin". 
Introduces: `theme_auto_update_setting_html`, `plugin_auto_update_setting_html`, and `theme_auto_update_setting_template` filters.

Props audrasjb, pbiron, azaozz.
Fixes #50280.
Built from https://develop.svn.wordpress.org/trunk@48077


git-svn-id: http://core.svn.wordpress.org/trunk@47844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 00:00:13 +00:00
Sergey Biryukov
cb72d22d67 Menus: Check the correct variable in Walker_Nav_Menu_Edit::start_el() when menu item is a taxonomy term. 
Follow-up to [45891].

Props ashour.
Fixes #50415.
Built from https://develop.svn.wordpress.org/trunk@48076


git-svn-id: http://core.svn.wordpress.org/trunk@47843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-17 19:47:14 +00:00
Sergey Biryukov
d81302511d External Libraries: Update Moment.js to 2.26.0. 
Changelog: https://github.com/moment/moment/compare/2.22.2...2.26.0

This commit also fixes a deprecation warning regarding the usage of `moment.locale()` to set locale properties.

As of Moment.js 2.12.0, `moment.locale()` is deprecated and `moment.updateLocale()` should be used instead.

Additionally, minimize `moment.js` as part of build process to remove the source map reference.

This avoids a `sourceMappingURL` being in the minified file, as we don't ship source maps.

Props yoancutillas, SergeyBiryukov.
Fixes #50408.
Built from https://develop.svn.wordpress.org/trunk@48075


git-svn-id: http://core.svn.wordpress.org/trunk@47842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-17 17:40:27 +00:00
ianbelanger
1a767ac06f Bundled Themes: Twenty Sixteen table border extends beyond table. 
Fixes issues where tables created by the table block have an extra border on the left side which extends below the table.

Props gsmumbo, mukesh27, JavierCasares.
Fixes #50180.
Built from https://develop.svn.wordpress.org/trunk@48074


git-svn-id: http://core.svn.wordpress.org/trunk@47841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-17 17:27:09 +00:00
ianbelanger
48eea2481c Bundled Themes: Twenty Nineteen horizontal rule is very narrow. 
Fixes the issue by adding specific styles for the `<hr>` tag.

Props laurelfulford, nielslange, kjellr, samful, leprincenoir.
Fixes #45912.
Built from https://develop.svn.wordpress.org/trunk@48073


git-svn-id: http://core.svn.wordpress.org/trunk@47840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-17 15:48:09 +00:00
Pascal Birchler
609dd1d14f Sitemaps: Add XML sitemaps functionality to WordPress. 
While web crawlers are able to discover pages from links within the site and from other sites, XML sitemaps supplement this approach by allowing crawlers to quickly and comprehensively identify all URLs included in the sitemap and learn other signals about those URLs using the associated metadata.

See https://make.wordpress.org/core/2020/06/10/merge-announcement-extensible-core-sitemaps/ for more details.

This feature exposes the sitemap index via `/wp-sitemap.xml` and exposes a variety of new filters and hooks for developers to modify the behavior. Users can disable sitemaps completely by turning off search engine visibility in WordPress admin.

This change also introduces a new `esc_xml()` function to escape strings for output in XML, as well as XML support to `wp_kses_normalize_entities()`.

Props Adrian McShane, afragen, adamsilverstein, casiepa, flixos90, garrett-eclipse, joemcgill, kburgoine, kraftbj, milana_cap, pacifika, pbiron, pfefferle, Ruxandra Gradina, swissspidy, szepeviktor, tangrufus, tweetythierry.
Fixes #50117.
See #3670. See #19998.

Built from https://develop.svn.wordpress.org/trunk@48072


git-svn-id: http://core.svn.wordpress.org/trunk@47839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-17 15:24:07 +00:00
desrosj
689fdc6319 Site Health: Verify PHP version requirements when auto-updating themes. 
Follow up of [47819].
See #49653.
Fixes #50411.
Built from https://develop.svn.wordpress.org/trunk@48071


git-svn-id: http://core.svn.wordpress.org/trunk@47838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-17 14:48:07 +00:00
Sergey Biryukov
a9a6b25cae Script Loader: Include the script or style handle in _wp_scripts_maybe_doing_it_wrong() message. 
This makes the message more helpful and allows for easier debugging.

Props janthiel.
Fixes #50406.
Built from https://develop.svn.wordpress.org/trunk@48070


git-svn-id: http://core.svn.wordpress.org/trunk@47837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-17 10:16:08 +00:00
TimothyBlynJacobs
41f70ae5f8 REST API: Only register one block renderer route. 
Every block has a different set of attributes. These attributes are specified as a JSON Schema object. Previously, every block registered its own block renderer route using its attributes for the schema. This allowed for the attributes to be validated using the built in endpoint validation rules. It had the unfortunate side effect, however, of creating a large number of nearly identical REST API routes, one for each dynamic block. Each registered route has a performance impact. As the number of server side blocks goes up, this becomes more and more of an issue.

Now, we register a single block renderer route and dynamically validate the attributes based on the selected block.

Fixes #48079.
Props gziolo, TimothyBlynJacobs.

Built from https://develop.svn.wordpress.org/trunk@48069


git-svn-id: http://core.svn.wordpress.org/trunk@47836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-17 03:22:12 +00:00
Sergey Biryukov
353c9bfc58 Docs: List the expected return type first for size_format() and wp_get_original_referer(). 
Follow-up to [46696], [47060].

See #49572.
Built from https://develop.svn.wordpress.org/trunk@48068


git-svn-id: http://core.svn.wordpress.org/trunk@47835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 21:24:07 +00:00
Sergey Biryukov
de59ad23a4 Docs: Consistently include an empty line between @since tag and @see, @link, or @global, per the documentation standards. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48067


git-svn-id: http://core.svn.wordpress.org/trunk@47834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 21:07:14 +00:00
Sergey Biryukov
8fdb0728be Text Changes: Replace "webmaster" with "site admin" in register_new_user(). 
Follow-up to [48049], accidentally reverted in [48059].

Props kebbet.
See #50394.
Built from https://develop.svn.wordpress.org/trunk@48066


git-svn-id: http://core.svn.wordpress.org/trunk@47833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 20:05:10 +00:00
Sergey Biryukov
a8cd3a3e2c Coding Standards: Rename the $clean or $ids variable in several functions to $non_cached_ids for clarity. 
* `_get_non_cached_ids()`
* `update_meta_cache()`
* `update_object_term_cache()`

See #49542.
Built from https://develop.svn.wordpress.org/trunk@48065


git-svn-id: http://core.svn.wordpress.org/trunk@47832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 19:09:08 +00:00
ianbelanger
c5ee065c3a Bundled Themes: Twenty Seventeen pagination links don't appear for home pages. 
Fixes issues where pagination does not work on the page that is set to the home page.

Props dimitris.m, laurelfulford, poena, ianbelanger, samful.
Fixes #39685.
Built from https://develop.svn.wordpress.org/trunk@48064


git-svn-id: http://core.svn.wordpress.org/trunk@47831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 18:40:07 +00:00
Sergey Biryukov
49edaea6f1 Coding Standards: Fix WPCS issues in wp-admin/nav-menus.php. 
Includes minor code layout fixes for better readability.

See #49542.
Built from https://develop.svn.wordpress.org/trunk@48063


git-svn-id: http://core.svn.wordpress.org/trunk@47830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 18:38:08 +00:00
whyisjake
97e2b94f84 Help/About: Add help tabs to provide informations about plugin & themes auto-updates. 
Adds language around how the feature works and includes links to the WordPress HelpHub pages.

Fixes: #50215.
Props: audrasjb, garrett-eclipse, paaljoachim, marybaum, pbiron, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@48062


git-svn-id: http://core.svn.wordpress.org/trunk@47829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 17:29:07 +00:00
ianbelanger
5e0879db84 Bundled Themes: Twenty Seventeen Navbar z-index issue. 
Fixes navbar z-index issue by upping the z-index value to 1000 from 7.

Props halgatewood, justnorris, poena, sinatrateam.
Fixes #39384.
Built from https://develop.svn.wordpress.org/trunk@48061


git-svn-id: http://core.svn.wordpress.org/trunk@47828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 17:16:10 +00:00
whyisjake
ed1e6c3d87 Themes: Add additional later escaping to post_class() and body_class() functions. 
Additionally, this adds a few tests to test output.

Fixes #20009.

Props mfields, scribu, azaozz, obenland, dd32, nacin, jrf, jdgrimes, garyj, whyisjake. 
 

Built from https://develop.svn.wordpress.org/trunk@48060


git-svn-id: http://core.svn.wordpress.org/trunk@47827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 16:57:15 +00:00
Andrea Fercia
f83c504b88 I18N: Remove the "Error:" prefix from error messages. 
For a number of years, most of the WordPress error messages have been prefixed with "Error:". However, these messages appear in a context where it's already clear an error occurred. Whether it's an error, a warning, or any other classification, that's not so relevant for users. The content of the message is the relevant part. The "Error:" prefix doesn't add great value while it does add unnecessary complexity for the message readability.

Also, revises some of these messages to improve clarity and removes HTML from translatable strings.

Props garrett-eclipse, ramiy, SergeyBiryukov, afercia, sabernhardt, quadthemes, audrasjb. 
See #47003, #43037, #42945, #15887.
Fixes #47656.

Built from https://develop.svn.wordpress.org/trunk@48059


git-svn-id: http://core.svn.wordpress.org/trunk@47826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 15:35:13 +00:00
desrosj
8f065b688d Build/Test Tools: Prevent double /s when including PHPMailer files. 
`ABSPATH` includes a trailing slash already.

Follow up of [48033].
Props desrosj.
See #50377, #41750.
Built from https://develop.svn.wordpress.org/trunk@48058


git-svn-id: http://core.svn.wordpress.org/trunk@47825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 13:59:12 +00:00
Sergey Biryukov
1f06606aa7 Customize: Introduce get_custom_logo_image_attributes filter for the list of custom logo image attributes. 
Props achbed, dlh, westonruter.
Fixes #36640.
Built from https://develop.svn.wordpress.org/trunk@48057


git-svn-id: http://core.svn.wordpress.org/trunk@47824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 11:49:08 +00:00
whyisjake
bdb1fe0d7e Administration: Remove wp-auth-check from the Heartbeat API. 
As of [27153], wp-auth-check is returned on all heartbeats without the need for data from client-side. This also means that the timing and scheduling of this request data is ineffectual.

Fixes #50305.

Props dsixinetu, azaozz, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@48056


git-svn-id: http://core.svn.wordpress.org/trunk@47823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 07:09:09 +00:00
whyisjake
8a6cc1a810 Cache API: Add wp_cache_get_multiple() to core functions. 
* `update_object_term_cache`
* `update_meta_cache`
* `_get_non_cached_ids`

See [47938].

Fixes #50352.

Props spacedmonkey, tillkruss, lukecavanagh. 


Built from https://develop.svn.wordpress.org/trunk@48055


git-svn-id: http://core.svn.wordpress.org/trunk@47822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 06:30:09 +00:00
whyisjake
28c6339400 I18N: Add i18n to size_format(). 
Add translatable strings to the units of the `size_format()` function.

Props Rahe, audrasjb, ocean90.

Fixes #50194.


Built from https://develop.svn.wordpress.org/trunk@48054


git-svn-id: http://core.svn.wordpress.org/trunk@47821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 06:10:08 +00:00
whyisjake
ea8331f00d REST API: Allow queries other than the main query to be is_home. 
Ensure that REST API calls can match the main query of the page. 

See #34373.

Fixes #50213.

Props: dlh, TimothyBlynJacobs, boonebgorges, joemcgill, whyisjake. 


Built from https://develop.svn.wordpress.org/trunk@48053


git-svn-id: http://core.svn.wordpress.org/trunk@47820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 06:04:12 +00:00
whyisjake
ccf534dc48 Code Standards: Cleanup some code spacing. 
See: #37826 and #44286.

Built from https://develop.svn.wordpress.org/trunk@48052


git-svn-id: http://core.svn.wordpress.org/trunk@47819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 00:56:08 +00:00
whyisjake
d3c44a690d Menus: Provide menu settings when creating a new menu. 
This simplifies the steps in the process of adding new menus.

Props: garrett-eclipse, audrasjb, ianjvr. 

Built from https://develop.svn.wordpress.org/trunk@48051


git-svn-id: http://core.svn.wordpress.org/trunk@47818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-15 23:22:06 +00:00
whyisjake
28d29b35f7 Comments: Don't display edit links to trashed post comments. 
If a post is in the trash, the comments bubble won't link to the comments list.

Fixes: #37826.
Props: swissspidy, helen, FolioVision, DrewAPicture, stevenlinx, donmhico, birgire, garrett-eclipse, andraganescu, johnbillion. 



Built from https://develop.svn.wordpress.org/trunk@48050


git-svn-id: http://core.svn.wordpress.org/trunk@47817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-15 23:06:08 +00:00
Sergey Biryukov
6aa5788189 Text Changes: Replace "Webmaster" in output messages with more appropriate terms: 
* "All at `###SITENAME###`" in `wp-admin/ms-delete-site.php`, for consistency with other Multisite emails.
* "Site admin" in `register_new_user()`, for clarity.

Props Presskopp, marybaum.
Fixes #50394.
Built from https://develop.svn.wordpress.org/trunk@48049


git-svn-id: http://core.svn.wordpress.org/trunk@47816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-15 19:41:11 +00:00
desrosj
4cdd79af25 Emoji: Upgrade Twemoji to version 13.0.0. 
🥸

Props kraftbj, desrosj, otto42.
Fixes #50148.
Built from https://develop.svn.wordpress.org/trunk@48048


git-svn-id: http://core.svn.wordpress.org/trunk@47815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-15 18:04:26 +00:00
ianbelanger
6d914acd6c Bundled Themes: Twenty Nineteen dropcap appears higher than expected in Firefox. 
Fixes the issue by adding moz specific top margin for the dropcap.

Props kjellr, joseph.dickson, maxpertici, samful.
Fixes #45876.
Built from https://develop.svn.wordpress.org/trunk@48047


git-svn-id: http://core.svn.wordpress.org/trunk@47814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-15 15:13:09 +00:00
desrosj
b8de1549ff Coding Standards: Remove the PHP Compatibility scanning job from the allowed_failures list. 
All pre-existing compatibility warnings and errors as flagged by the PHPCompatibilityWP ruleset have been addressed.

Fixes #49922.
Built from https://develop.svn.wordpress.org/trunk@48046


git-svn-id: http://core.svn.wordpress.org/trunk@47813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-15 15:04:10 +00:00
desrosj
c4a89f1635 General: Continuing to work towards a passing PHP Compatibility scan. 
- Add `phpcs:ignore` statements to compatibility checks in PHPMailer.
- Remove quotes around the assertion in an `assert()` call. This will trigger a deprecated notice under certain conditions on PHP 7.2.

Props jrf, desrosj.
See #49922, #48033.
Built from https://develop.svn.wordpress.org/trunk@48045


git-svn-id: http://core.svn.wordpress.org/trunk@47812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-15 14:56:07 +00:00
Sergey Biryukov
942fc4e0fc Networks and Sites: Don't unnecessarily switch to the current blog in get_blog_details(). 
Props arpitgshah, djennez, acsnaterse, joostdevalk, SergeyBiryukov.
Fixes #50391.
Built from https://develop.svn.wordpress.org/trunk@48044


git-svn-id: http://core.svn.wordpress.org/trunk@47811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-15 12:31:11 +00:00
Sergey Biryukov
a1f8dd4972 Posts, Post Types: Introduce default_category_post_types filter. 
The filter allows custom post types associated with the `category` taxonomy to opt in to requiring a default category, same as regular posts.

Props enrico.sorcinelli.
Fixes #43516.
Built from https://develop.svn.wordpress.org/trunk@48043


git-svn-id: http://core.svn.wordpress.org/trunk@47810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-14 21:42:17 +00:00
Dominik Schilling
893c580831 Users: On the 'Add New User' screen, don't show the roles dropdown if the current user can't promote other users. 
Fixes #50345.
Built from https://develop.svn.wordpress.org/trunk@48042


git-svn-id: http://core.svn.wordpress.org/trunk@47809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-14 17:03:10 +00:00
Dominik Schilling
9f7a7f8d57 Coding Standards: Fix code indentation in post_submit_meta_box() to improve readability. 
See #49542.
Built from https://develop.svn.wordpress.org/trunk@48041


git-svn-id: http://core.svn.wordpress.org/trunk@47808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-14 16:31:08 +00:00
Sergey Biryukov
d776a4d15e Coding Standards: Use strict comparison in js/_enqueues/lib/ajax-response.js. 
Props ankitmaru.
Fixes #50320.
Built from https://develop.svn.wordpress.org/trunk@48040


git-svn-id: http://core.svn.wordpress.org/trunk@47807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-14 11:28:07 +00:00
Sergey Biryukov
01eb2907a7 Accessibility: Themes: Don't link to the home page in get_custom_logo() when it's displayed on the home page. 
Props Soean, audrasjb, sabernhardt, FlorianBrinkmann, rianrietveld, afercia, joedolson, samful, knutsp, SergeyBiryukov.
See #37011.
Built from https://develop.svn.wordpress.org/trunk@48039


git-svn-id: http://core.svn.wordpress.org/trunk@47806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-14 10:02:11 +00:00
Sergey Biryukov
e6ee3f742e External Libraries: Update Masonry to 4.2.2 and imagesLoaded to 4.1.4. 
Notable changes include dropping support for IE 8 & 9, which are no longer supported by WordPress core either.

Release notes:
https://github.com/desandro/masonry/releases
https://github.com/desandro/imagesloaded/releases

Changelogs:
https://github.com/desandro/masonry/compare/v3.3.2...v4.2.2
https://github.com/desandro/imagesloaded/compare/v3.2.0...v4.1.4

Props pierlo, hareesh-pillai, grapplerulrich, pderksen, desrosj, garrett-eclipse, SergeyBiryukov.
Fixes #37675, #48031.
Built from https://develop.svn.wordpress.org/trunk@48038


git-svn-id: http://core.svn.wordpress.org/trunk@47805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-13 18:53:27 +00:00
Sergey Biryukov
04200b39ce Themes: Ensure the theme slug is set before checking if the theme is installed or active. 
This fixes an issue with every installed theme being marked as active on Themes screen.

The slug is set on Add Themes screen, but not on Themes.

Follow-up to [47924].

Props BackuPs, mukesh27, SergeyBiryukov.
Fixes #50381. See #50334.
Built from https://develop.svn.wordpress.org/trunk@48037


git-svn-id: http://core.svn.wordpress.org/trunk@47804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-13 14:26:07 +00:00
Sergey Biryukov
c7b843302f Coding Standards: Exclude the whole PHPMailer directory from WPCS checks, for consistency with other external libraries in their own directory. 
Follow-up to [48033].

See #41750.
Built from https://develop.svn.wordpress.org/trunk@48036


git-svn-id: http://core.svn.wordpress.org/trunk@47803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-13 12:36:10 +00:00
Sergey Biryukov
aa5017ebb9 External Libraries: Add class aliases for phpmailerException and SMTP to deprecated files to account for the new namespace. 
This ensures backward compatibility with plugins using the old `class-phpmailer.php` or `class-smtp.php` files.

Follow-up to [48033].

Props Otto42.
Fixes #50379. See #41750.
Built from https://develop.svn.wordpress.org/trunk@48035


git-svn-id: http://core.svn.wordpress.org/trunk@47802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-12 21:42:09 +00:00
TimothyBlynJacobs
afaeaf1529 External Libraries: Skip deprecated file warning for PHPMailer if the API is not loaded. 
In [48033] the "class-phpmailer.php" file was deprecated. In test suites, this file is loaded before WordPress in order to setup a mock PHPMailer instance. This means that for test suites that are still loading that file, they'll experience fatal errors due to the undefined "_deprecated_file" function.

This commit skips issuing the deprecated file warning if the "_deprecated_file" function is not available.

Fixes #50380.

Built from https://develop.svn.wordpress.org/trunk@48034


git-svn-id: http://core.svn.wordpress.org/trunk@47801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-12 21:10:08 +00:00
desrosj
e4379c5ba8 External Libraries: Upgrade PHPMailer to version 6.1.6. 
Now that WordPress Core supports PHP >= 5.6, the PHPMailer library can be updated to the latest version.

The PHPMailer files now reside in a new directory, `wp-includes/PHPMailer`. These files are copied verbatim from the library upstream and will make updating in the future easier. For backwards compatibility, the old files will remain and trigger deprecated file warnings.

The PHPMailer class is also now under the `PHPMailer\PHPMailer\PHPMailer` namespace. The `PHPMailer` class in the global namespace has been aliased for a seamless transition.

This upgrade also clears up a handful of PHP compatibility issues detailed in #49922.

For a full list of changes, see the PHPMailer GitHub: https://github.com/PHPMailer/PHPMailer/compare/v5.2.27...v6.1.6.

Props Synchro, SergeyBiryukov, desrosj, donmhico, ayeshrajans.
Fixes #41750.
Built from https://develop.svn.wordpress.org/trunk@48033


git-svn-id: http://core.svn.wordpress.org/trunk@47800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-12 15:47:07 +00:00
ianbelanger
232277586f Bundled Themes: Twenty Nineteen long submenu item titles do not wrap. 
Fixes the issue of long submenu item titles that do not wrap by adding a `max-width: 20rem;` and removing `white-space: nowrap;`.

Props kjellr, mukesh27, mohsinrasool, samful.
Fixes #45866.
Built from https://develop.svn.wordpress.org/trunk@48032


git-svn-id: http://core.svn.wordpress.org/trunk@47799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-12 15:11:08 +00:00
Sergey Biryukov
4cc11cdbdd Filesystem API: Avoid a PHP notice in WP_Filesystem_Direct::owner() and ::group() methods and their WP_Filesystem_SSH2 counterparts. 
Although not officially documented in the PHP manual, `posix_getpwuid()` and `posix_getgrgid()` can return `false` in some circumstances.

Props logig.
Fixes #50373.
Built from https://develop.svn.wordpress.org/trunk@48031


git-svn-id: http://core.svn.wordpress.org/trunk@47798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-12 12:35:09 +00:00
ianbelanger
99c6adfeaa Bundled Themes: Twenty Seventeen CSS issue when using rowspan in tables. 
Fixes CSS issue when using rowspan in tables. This issue does not apply to the Table Block, just tables inserted as custom html.

Props aussi, subrataemfluence, jainnidhi.
Fixes #44004.
Built from https://develop.svn.wordpress.org/trunk@48028


git-svn-id: http://core.svn.wordpress.org/trunk@47796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-11 17:15:08 +00:00
ianbelanger
5bc4b92551 Bundled Themes: Twenty Seventeen add Telegram and Whatsapp support to Social Media Menu. 
Adds Telegram and Whatsapp support and SVG's to Social Media Menu.

Props cpasqualini, audrasjb, laurelfulford, karmatosed, ibdz.
Fixes #43999.
Built from https://develop.svn.wordpress.org/trunk@48027


git-svn-id: http://core.svn.wordpress.org/trunk@47795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-11 15:31:09 +00:00
Sergey Biryukov
4de0d47792 Canonical: Revert [47937] pending unit tests and further review. 
Props needle.
See #12456.
Built from https://develop.svn.wordpress.org/trunk@48026


git-svn-id: http://core.svn.wordpress.org/trunk@47794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-11 10:55:11 +00:00
whyisjake
c075eec24f Editor: Ensure latest comments can only be viewed from public posts. 
Props: poena, xknown. 

Built from https://develop.svn.wordpress.org/trunk@47984


git-svn-id: http://core.svn.wordpress.org/trunk@47752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-10 19:20:11 +00:00
ianbelanger
9524b335c7 Bundled Themes: Twenty Twenty and Twenty Nineteen version bump. 
We are releasing new versions of Twenty Twenty & Twenty Nineteen today thus we need to bump the version.

Props ianbelanger.
Fixes #50359.
Built from https://develop.svn.wordpress.org/trunk@47952


git-svn-id: http://core.svn.wordpress.org/trunk@47724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-10 17:32:06 +00:00
whyisjake
dda0ccdd18 Administration: Add a new filter to extend set-screen-option. 
Props: xknown, SergeyBiryukov.

Built from https://develop.svn.wordpress.org/trunk@47951


git-svn-id: http://core.svn.wordpress.org/trunk@47723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-10 17:24:51 +00:00
whyisjake
ffc4869c9c Themes: Ensure a broken theme name is returned properly. 
Props: sstoqnov.

Built from https://develop.svn.wordpress.org/trunk@47950


git-svn-id: http://core.svn.wordpress.org/trunk@47722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-10 17:23:36 +00:00
whyisjake
10e2a50c52 Formatting: Ensure that wp_validate_redirect() sanitizes a wider variety of characters. 
Props: xknow, vortfu.


Built from https://develop.svn.wordpress.org/trunk@47949


git-svn-id: http://core.svn.wordpress.org/trunk@47721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-10 17:22:28 +00:00
whyisjake
7e9267567f Editor: Prevent HTML decoding on by setting the proper editor context. 
Props: sstoqnov.

Built from https://develop.svn.wordpress.org/trunk@47948


git-svn-id: http://core.svn.wordpress.org/trunk@47720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-10 17:21:20 +00:00
whyisjake
2ae3b3b801 Embeds: Ensure that the title attribute is set correctly on embeds. 
Props xknown.

Built from https://develop.svn.wordpress.org/trunk@47947


git-svn-id: http://core.svn.wordpress.org/trunk@47719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-10 17:20:10 +00:00
Sergey Biryukov
1d95eb63a7 Docs: Add missing documentation for the $group parameter of WP_Object_Cache::get_multiple(). 
Synchronize documentation between `wp_cache_get_multiple()`, its compat version, and the class method.

See #20875.
Built from https://develop.svn.wordpress.org/trunk@47944


git-svn-id: http://core.svn.wordpress.org/trunk@47717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-10 09:57:09 +00:00
TimothyBlynJacobs
941a31318c REST API: Fix updating "multiple" meta keys with non-string values. 
Previously, the REST API would end up deleting each row of metadata and recreating it unnecessarily. This was caused by a type mismatch where the metadata API would always return a string value, and the REST API operated on a typed value.

The REST API now applies the same sanitization and type casting for "multiple" meta keys and "single" meta keys.

Fixes #49339.
Props renathoc.

Built from https://develop.svn.wordpress.org/trunk@47943


git-svn-id: http://core.svn.wordpress.org/trunk@47716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-10 02:22:13 +00:00
desrosj
38352d2c7a Coding Standards: Cleans up some PHPCS issues introduced in [47938]. 
See #20875.
Built from https://develop.svn.wordpress.org/trunk@47942


git-svn-id: http://core.svn.wordpress.org/trunk@47715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 22:42:12 +00:00
ianbelanger
4e61c5fb0f Bundled Themes: Twenty Twenty number of replies not translatable. 
Fixes the issue by removing the single quote from around the `1` in the elseif conditional of the comments template.

Props Parvand, SergeyBiryukov, desrosj, juliobox, Mista-Flo, benjamingosset, audrasjb, opurockey.
Fixes #49058.
Built from https://develop.svn.wordpress.org/trunk@47941


git-svn-id: http://core.svn.wordpress.org/trunk@47714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 20:02:08 +00:00
ianbelanger
32116649cf Bundled Themes: Twenty Twenty HTML in featured image caption is being escaped. 
Fixes the issue by replacing `esc_html` with `wp_kses_post` in the caption in featured images.

Props pierlo, JavierCasares, audrasjb.
Fixes #49833.
Built from https://develop.svn.wordpress.org/trunk@47940


git-svn-id: http://core.svn.wordpress.org/trunk@47713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 19:52:07 +00:00
whyisjake
ae76b79f85 Cache API: Include the cache-compat file. 
This was missed during the prior commit.

See [47938].


Built from https://develop.svn.wordpress.org/trunk@47939


git-svn-id: http://core.svn.wordpress.org/trunk@47712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 19:50:09 +00:00
whyisjake
3e2b649351 Cache API: Introduce wp_cache_get_multi(). 
Many caching backend have support for multiple gets in a single request. This brings that support to core, with a compatability fallback that will loop over requests if needed.

Fixes: #20875.
Props: nacin, tollmanz, wonderboymusic, ryan, jeremyfelt, spacedmonkey, boonebgorges, dd32, rmccue, ocean90, jipmoors, johnjamesjacoby, tillkruess, donmhico, davidbaumwald, SergeyBiryukov, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@47938


git-svn-id: http://core.svn.wordpress.org/trunk@47711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 19:47:13 +00:00
whyisjake
c65334d820 Canonical: Ensure a redirect for posts missing postname in a query with an ID. 
If a site is using `/%post_id%/%postname%/` as permalink structure, and is missing the `postname`, the site  won't redirect to the appropriate URL. This change ensure that the redirect happens.

Fixes: #12456.
Props: Frank.Prendergast, dd32, Otto42, hlanggo, wonderboymusic, atimmer, seth17, calvin_ngan, Niresh12495, anbumz, SergeyBiryukov, donmhico.



Built from https://develop.svn.wordpress.org/trunk@47937


git-svn-id: http://core.svn.wordpress.org/trunk@47710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 19:26:12 +00:00
Sergey Biryukov
f5d5b76f6e Docs: Fix typo in WP_Widget::__construct() and ::WP_Widget() DocBlocks. 
Props SUM1.
Fixes #50348.
Built from https://develop.svn.wordpress.org/trunk@47936


git-svn-id: http://core.svn.wordpress.org/trunk@47709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 15:37:10 +00:00
Sergey Biryukov
c227ed2322 Docs: Improve documentation for is_active_sidebar(). 
The function determines whether the sidebar contains widgets, not that it is loaded on the page.

Props SUM1.
Fixes #50347.
Built from https://develop.svn.wordpress.org/trunk@47935


git-svn-id: http://core.svn.wordpress.org/trunk@47708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 15:31:09 +00:00
ianbelanger
c681e37da7 Bundled Themes: Twenty Fifteen bulleted list block appears too far to the left in the editor. 
Fixes the issue by removing unnecessary margin rules for bulleted lists in the editor.

Props kjellr.
Fixes #50029.
Built from https://develop.svn.wordpress.org/trunk@47934


git-svn-id: http://core.svn.wordpress.org/trunk@47707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 14:10:09 +00:00
ianbelanger
644fb1b931 Bundled Themes: Twenty Twenty uses overly specific selector for button background. 
Fixes the issue by removing `:not(.toogle)` from the `button` selector, as it is not needed.

Props flixos90.
Fixes #50271.
Built from https://develop.svn.wordpress.org/trunk@47933


git-svn-id: http://core.svn.wordpress.org/trunk@47706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 13:52:08 +00:00
Sergey Biryukov
bbdfffdaa1 Networks and Sites: Ensure the site ID in wp_insert_site() is still correct after calling clean_blog_cache(). 
By saving `$wpdb->insert_id` to a variable, we make sure the ID does not change if another database insert is performed on the `clean_site_cache` action.

Props trepmal.
Fixes #50324.
Built from https://develop.svn.wordpress.org/trunk@47932


git-svn-id: http://core.svn.wordpress.org/trunk@47705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 12:41:09 +00:00
Sergey Biryukov
40584118d9 Docs: Document that get_tags() returns a WP_Error object if any of the specified taxonomies do not exist. 
Props coffee2code.
Fixes #50344.
Built from https://develop.svn.wordpress.org/trunk@47930


git-svn-id: http://core.svn.wordpress.org/trunk@47703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 11:14:12 +00:00
desrosj
784908ae5f Coding Standards: PHP short ternary operator syntax is not allowed. 
WPCS 2.2.0 added a sniff for detecting short ternary operator syntax, which is not allowed per the Core handbook.

Follow up of [47927].
Fixes #50258.
Built from https://develop.svn.wordpress.org/trunk@47929


git-svn-id: http://core.svn.wordpress.org/trunk@47702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-08 21:27:10 +00:00
desrosj
d1015f46b5 Build/Test Tools: Update the wp-coding-standards/wpcs package. 
This updates the version from 2.1.1 to 2.3.0, the latest version at this time.

Fixes #50258.
Built from https://develop.svn.wordpress.org/trunk@47927


git-svn-id: http://core.svn.wordpress.org/trunk@47701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-08 20:11:10 +00:00
desrosj
c591d94cc5 General: Remove or add inline comments to $HTTP_RAW_POST_DATA occurrences. 
The `$HTTP_RAW_POST_DATA` global was deprecated in PHP 5.6 and removed completely in PHP 7.0. In general, `php://input` should be used instead of `$HTTP_RAW_POST_DATA`.

Because WordPress Core still supports PHP 5.6, some plugins or sites may still rely on this variable being present and populated with the expected data. For that reason, occurrences of the variable will remain with updated inline documentation until support for PHP 5.6 is officially dropped in WordPress.

Props skoskie, jrf, desrosj, TimothyBlynJacobs.
See #49922.
Fixes #49810.
Built from https://develop.svn.wordpress.org/trunk@47926


git-svn-id: http://core.svn.wordpress.org/trunk@47700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-08 19:55:10 +00:00
desrosj
9e9be350e2 Bundled Themes: Update several package versions in Twenty Twenty and Twenty Nineteen. 
The following packages received version bumps:

Twenty Twenty
- `concurrently`
- `postcss-cli`
- `rtlcss`
- `stylelint-a11y`

Twenty Nineteen
- `node-sass`
- `postcss-cli`
- `rtlcss`

See #49768.
Built from https://develop.svn.wordpress.org/trunk@47925


git-svn-id: http://core.svn.wordpress.org/trunk@47699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-08 18:47:08 +00:00
Sergey Biryukov
4adfd75159 Themes: Show a disabled "Activated" button instead of "Activate" for the active theme on Add Themes screen. 
Additionally, switch the "Live Preview" label for the active theme to "Customize", for consistency with the Themes screen.

Props afercia, SergeyBiryukov.
Fixes #50334.
Built from https://develop.svn.wordpress.org/trunk@47924


git-svn-id: http://core.svn.wordpress.org/trunk@47698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-08 18:16:10 +00:00
TimothyBlynJacobs
5efaf888a5 REST API: Support the (min|max)Items JSON Schema keywords. 
A future commit will add support for the uniqueItems keyword.

Props sorenbronsted.
See #48821.

Built from https://develop.svn.wordpress.org/trunk@47923


git-svn-id: http://core.svn.wordpress.org/trunk@47697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-07 22:42:13 +00:00
Sergey Biryukov
18a9359c06 Posts, Post Types: Display a more specific error message when an attachment could not be inserted into the database. 
Props shital-patel, Presskopp, ocean90.
Fixes #50325.
Built from https://develop.svn.wordpress.org/trunk@47922


git-svn-id: http://core.svn.wordpress.org/trunk@47696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-07 09:24:11 +00:00
TimothyBlynJacobs
171356a890 REST API: Add additional fields to the themes controller. 
When the themes controller was introduced it only returned a theme's supported features. This adds the majority of a theme's header information to the response.

Props ockham, spacedmonkey.
Fixes #49906.

Built from https://develop.svn.wordpress.org/trunk@47921


git-svn-id: http://core.svn.wordpress.org/trunk@47695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-07 06:46:10 +00:00
Peter Wilson
6459c0f2ee Block Editor: Update wp-includes/assets/script-loader-packages.php. 
Follow-up to [47765], [47766].
See #50094.

Built from https://develop.svn.wordpress.org/trunk@47920


git-svn-id: http://core.svn.wordpress.org/trunk@47694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-07 01:29:12 +00:00
Sergey Biryukov
b19c1627e5 Bootstrap/Load: Introduce wp_get_environment_type() to retrieve the current environment type. 
The type can be set via the `WP_ENVIRONMENT_TYPE` global system variable, a constant of the same name, or the `wp_get_environment_type` filter.

Possible values include `development`, `stage`, `production'. If not set, the type defaults to `production`.

Props Clorith, krogsgard, joostdevalk, frank-klein, Maelacuna, nathanrice, grierson, jchristopher, davidvee, jackfungi, johnbillion, tabrisrp, knutsp, ev3rywh3re, Rastaban, danielbachhuber, pfefferle, audrasjb, SergeyBiryukov.
Fixes #33161.
Built from https://develop.svn.wordpress.org/trunk@47919


git-svn-id: http://core.svn.wordpress.org/trunk@47693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-06 11:07:12 +00:00
Adam Silverstein
0b9a800512 Media: remove any attachment-filter query param when switching views. 
Fix an issue where the media attachment filter no longer worked after switching to list view, filtering by a media type then switching back to the grid view.

Props itzmekhokan, netsurfer2705, zodiac1978.
Fixes #43656.


Built from https://develop.svn.wordpress.org/trunk@47915


git-svn-id: http://core.svn.wordpress.org/trunk@47689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-05 21:13:10 +00:00
Sergey Biryukov
f546fe5aa5 Networks and Sites: Update the link text for "Debugging a WordPress Network" support article in ms_not_installed(). 
Props Presskopp.
Fixes #50326.
Built from https://develop.svn.wordpress.org/trunk@47914


git-svn-id: http://core.svn.wordpress.org/trunk@47688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-05 09:13:08 +00:00
Sergey Biryukov
4bbb7fb852 Docs: Update the DocBlock for the wp_media_attach_action hook per the documentation standards. 
Rename the `$att_id` variable to `$attachment_id` for clarity.

Follow-up to [47909].

See #49614.
Built from https://develop.svn.wordpress.org/trunk@47913


git-svn-id: http://core.svn.wordpress.org/trunk@47687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-05 08:30:10 +00:00
desrosj
07a3972bc3 Docs: Fix a typo in the Docker compose file. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@47912


git-svn-id: http://core.svn.wordpress.org/trunk@47686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-04 16:53:09 +00:00
whyisjake
00df557404 REST API: Ensure that all properties of get_endpoint_args_for_item_schema are listed. 
* Add new var $valid_schema_properties to match rest_validate_value_from_schema()
* Unit test to ensure all valid properties exists, and non-valid properties are ignored

Fixes: #50301.
Props: pentatonicfunk, TimothyBlynJacobs.


Built from https://develop.svn.wordpress.org/trunk@47911


git-svn-id: http://core.svn.wordpress.org/trunk@47685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-04 16:43:08 +00:00
desrosj
b013a15d43 Accessibility: Add the aria-hidden attribute to the auto-update related icons. 
`<span>` elements used for displaying icons should use the `aria-hidden` attribute as they are purely decorative.

Props audrasjb, ryokuhi.
Fixes #50293.
Built from https://develop.svn.wordpress.org/trunk@47910


git-svn-id: http://core.svn.wordpress.org/trunk@47684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-04 15:47:09 +00:00
whyisjake
00d3696923 Media: Add an action for wp_media_attach_action. 
This action fires when media is attached/detached from a post.

Fixes: #49614.
Props: jonoaldersonwp, antpb, rebasaurus, donmhico. 


Built from https://develop.svn.wordpress.org/trunk@47909


git-svn-id: http://core.svn.wordpress.org/trunk@47683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-04 15:00:09 +00:00
Sergey Biryukov
0eaae8ebbf Docs: Update type for WP_Block_Type::$style property. 
Follow-up to [47907].

See #48529.
Built from https://develop.svn.wordpress.org/trunk@47908


git-svn-id: http://core.svn.wordpress.org/trunk@47682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-04 10:44:10 +00:00
gziolo
eec4c743fa Blocks: Update default value for some fields in WP_Block_Type 
Related to the issue with default values for the blocks registered on the server. By using null for some fields we can treat them as undefined on the client.

See: WordPress/gutenberg#22849.
Props aduth.
Fixes #48529. 


Built from https://develop.svn.wordpress.org/trunk@47907


git-svn-id: http://core.svn.wordpress.org/trunk@47681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-04 06:07:13 +00:00
Sergey Biryukov
b50e87d52b Docs: Add missing @global reference for the $post_id global in wp_admin_bar_edit_menu(). 
Follow-up to [47903].

Props davidbaumwald.
See #50312.
Built from https://develop.svn.wordpress.org/trunk@47906


git-svn-id: http://core.svn.wordpress.org/trunk@47680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-03 21:27:09 +00:00
desrosj
2ef561db67 Build/Test Tools: Revert [47901]. 
This is not matching branches as desired.

Unrops desrosj, jorbin, ocean90, TimothyBlynJacobs.
Fixes #50307.
Built from https://develop.svn.wordpress.org/trunk@47905


git-svn-id: http://core.svn.wordpress.org/trunk@47679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-03 21:14:09 +00:00
Aaron Jorbin
df343d59f2 Build/Test: Die with an error if populate_network fails 
If you are missing WP_TESTS_EMAIL, populate_network will fail and it can be hard to debug. As populate_network can return a wp_error object, we can detect that and display the error to a user.

See: https://github.com/WordPress/gutenberg/pull/22613
Fixes: #50251
Props: TimothyBlynJacobs

Built from https://develop.svn.wordpress.org/trunk@47904


git-svn-id: http://core.svn.wordpress.org/trunk@47678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-03 21:04:10 +00:00
Sergey Biryukov
524f188982 Toolbar: Display a "View Post" link when viewing comments for a single post on Comments screen. 
Props Otto42, matt, SergeyBiryukov.
Fixes #50312.
Built from https://develop.svn.wordpress.org/trunk@47903


git-svn-id: http://core.svn.wordpress.org/trunk@47677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-03 19:57:10 +00:00
desrosj
27485fd7aa General: Continuing to work towards a passing PHP Compatibility scan. 
This is a final pass to fix PHP compatibiilty issues in the codebase with code changes or adding `phpcs:ignore` comments.

With this change, all PHP compatibility warnings and errors without specific tickets have been addressed (see #49810 and #41750).

Props desrosj, johnbillion, jrf.
See #49922.
Built from https://develop.svn.wordpress.org/trunk@47902


git-svn-id: http://core.svn.wordpress.org/trunk@47676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-03 17:40:12 +00:00
desrosj
e2790b4e63 Build/Test Tools: Disable Travis CI build Slack notifications for non-official branches. 
When branches are unintentionally pushed to the GitHub `wordpress-develop` mirror by committers, a build is triggered in Travis and the result is reported in Slack if the criteria defined is met.

Though this is not the desired workflow (any modifications made to the mirror are erased when the repository is synced from SVN), this can cause a lot of noise if several pushes are made and raise false alarms.

This change limits builds only to the `master` branch, and branches meeting the `X.X` pattern to match each branched version.

Props desrosj, jorbin, ocean90, TimothyBlynJacobs.
Fixes #50307.
Built from https://develop.svn.wordpress.org/trunk@47901


git-svn-id: http://core.svn.wordpress.org/trunk@47675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-03 17:03:12 +00:00
Sergey Biryukov
353def14e2 Docs: Document the term_order value for the orderby parameter of WP_Term_Query::__construct(). 
Props pbiron.
See #49572.
Built from https://develop.svn.wordpress.org/trunk@47898


git-svn-id: http://core.svn.wordpress.org/trunk@47672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-03 14:41:06 +00:00
Sergey Biryukov
5636fb886b Docs: Reformat the orderby section of WP_Term_Query::__construct() for better readability. 
This makes it more consistent with the `fields` section.

See #49572.
Built from https://develop.svn.wordpress.org/trunk@47897


git-svn-id: http://core.svn.wordpress.org/trunk@47671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-03 14:37:09 +00:00
Sergey Biryukov
f22e113e95 File Editor: Don't verify SSL certificate when doing loopback requests for checking for fatal errors. 
Previously, verification was disabled for the loopback request to the admin URL, but not to the home URL.

Follow-up to [46230].

Props munyagu.
Fixes #50309. See #47957.
Built from https://develop.svn.wordpress.org/trunk@47896


git-svn-id: http://core.svn.wordpress.org/trunk@47670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-03 11:43:15 +00:00
Sergey Biryukov
683507fe14 External Libraries: Update clipboard.js to 2.0.6. 
This change includes some bug fixes and removal of the PhantomJS dependency.

Changelog: https://github.com/zenorocha/clipboard.js/compare/v2.0.4...v2.0.6

Props hareesh-pillai.
Fixes #50306.
Built from https://develop.svn.wordpress.org/trunk@47895


git-svn-id: http://core.svn.wordpress.org/trunk@47669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-03 11:12:33 +00:00
Sergey Biryukov
cf597dcf7c Plugins: Make the message displayed when no plugins are installed more concise. 
Props johnjamesjacoby, Presskopp.
Fixes #42336.
Built from https://develop.svn.wordpress.org/trunk@47894


git-svn-id: http://core.svn.wordpress.org/trunk@47668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-03 10:51:13 +00:00
Sergey Biryukov
b247cafd91 Docs: Correct @since version for available_permalink_structure_tags filter. 
Follow-up to [41182].

Props tiagohillebrandt, sabernhardt.
Fixes #42624.
Built from https://develop.svn.wordpress.org/trunk@47893


git-svn-id: http://core.svn.wordpress.org/trunk@47667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-03 10:38:09 +00:00
Sergey Biryukov
72b5018aa3 Docs: Miscellaneous DocBlock corrections. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@47892


git-svn-id: http://core.svn.wordpress.org/trunk@47666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-03 10:02:13 +00:00
Adam Silverstein
86b50870ec Formatting: add a new 'safe_style_disallowed_chars' filter. 
Enable developers to change the regex used in `safecss_filter_attr` to limit characters in the parsed CSS.

Props paulschreiber, swissspidy, rmccue, bartekcholewa, miinasikk.
Fixes #37134.


Built from https://develop.svn.wordpress.org/trunk@47891


git-svn-id: http://core.svn.wordpress.org/trunk@47665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-02 23:46:11 +00:00
Sergey Biryukov
569c006248 Comments: Rename Walker_Comment::comment_text() to ::filter_comment_text() for clarity. 
Ensure the comment object is not null before checking its status.

Follow-up to [47887].

See #49956.
Built from https://develop.svn.wordpress.org/trunk@47889


git-svn-id: http://core.svn.wordpress.org/trunk@47663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-02 21:45:10 +00:00
whyisjake
9f86174e08 Comments: Ensure that unmoderated comments won't be search indexed. 
After a comment is submitted, only allow a brief window where the comment is live on the site. 

Fixes #49956.
Props: jonkolbert, ayeshrajans, Asif2BD, peterwilsoncc, imath, audrasjb, jonoaldersonwp, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@47887


git-svn-id: http://core.svn.wordpress.org/trunk@47661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-02 20:12:07 +00:00
Sergey Biryukov
30b61fc9e8 Bundled Themes: Consistently check for WP_Error before outputting get_the_tag_list(). 
Some themes already had these checks in place as a result of [41756], but not others.

Props sixhours, davidakennedy, SergeyBiryukov.
Fixes #39860.
Built from https://develop.svn.wordpress.org/trunk@47886


git-svn-id: http://core.svn.wordpress.org/trunk@47660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-02 17:05:13 +00:00
Sergey Biryukov
3fd1fe298a Docs: Correct @param type for pre_redirect_guess_404_permalink filter. 
Improve filter documentation for consistency with other similar short-circuit filters in core.

Follow-up to [47878].

See #16557.
Built from https://develop.svn.wordpress.org/trunk@47885


git-svn-id: http://core.svn.wordpress.org/trunk@47659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-02 16:23:11 +00:00
Dominik Schilling
ba92ed7615 I18N: Use wp.i18n for translatable strings in wp-admin/js/updates.js. 
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.

Props swissspidy, ocean90.
See #20491.
Fixes #50235.
Built from https://develop.svn.wordpress.org/trunk@47884


git-svn-id: http://core.svn.wordpress.org/trunk@47658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-01 21:41:09 +00:00
Andrew Ozz
0318a92948 Plugins and Themes Auto-Updates: update the state of the auto-update link on the themes screen after successfully saving the setting. 
Props desrosj, pbiron, azaozz.
Fixes #50291.
Built from https://develop.svn.wordpress.org/trunk@47883


git-svn-id: http://core.svn.wordpress.org/trunk@47657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-01 20:53:15 +00:00
Dominik Schilling
94be20e612 Build/Test Tools: Avoid an empty "title" heading if no title is set in _wp_die_handler_exit() and _wp_die_handler_txt(). 
Fixes #50297.
Built from https://develop.svn.wordpress.org/trunk@47882


git-svn-id: http://core.svn.wordpress.org/trunk@47656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-01 20:50:08 +00:00
Dominik Schilling
c5ac08ba45 Build/Test Tools: Add PHPUnit to Composer dev dependencies. 
This helps setting up the correct version of PHPUnit to run WordPress core tests locally and for using it as source for code autocompletion in tests. Also introduces a new Composer script `test` to run the PHPUnit tests.

Props welcher, ayeshrajans, vinkla, johnbillion, Rarst, netweb, ocean90.
Fixes #46815.
Built from https://develop.svn.wordpress.org/trunk@47881


git-svn-id: http://core.svn.wordpress.org/trunk@47655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-01 20:31:07 +00:00
Dominik Schilling
c7aab4121f Build/Test Tools: Let WP_UnitTestCase_Base extend the namespaced version of PHPUnit's test case class. 
With the minimum PHP version requirement set to 5.6 we're now able to use namespaces by default. This replaces `PHPUnit_Framework_TestCase` with `PHPUnit\Framework\TestCase` for `WP_UnitTestCase_Base` to solve autocompletion issues with code editors when using more recent PHPUnit versions. `PHPUnit\Framework\TestCase` is available since PHPUnit 5.4 and now the minimum required PHPUnit version.

Fixes #50236.
Built from https://develop.svn.wordpress.org/trunk@47880


git-svn-id: http://core.svn.wordpress.org/trunk@47654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-01 19:43:13 +00:00
whyisjake
69a866a1a9 Administration: Unify the date structure in list view and excerpt view. 
Both views now show a full date string. Something like `Published 2020/05/27 at 10:25 pm`.

Fixes: #35391.
Props: afercia, ocean90, TimothyBlynJacobs, audrasjb, SergeyBiryukov, joedolson.


Built from https://develop.svn.wordpress.org/trunk@47879


git-svn-id: http://core.svn.wordpress.org/trunk@47653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-01 19:15:08 +00:00
whyisjake
f201c1b217 Canonical: Add the ability to disable redirect_guess_404_permalink(). 
This also adds a few more filters to make adding redirects easier. Notably:

1. `do_redirect_guess_404_permalink`
2. `pre_redirect_guess_404_permalink`
3. `strict_redirect_guess_404_permalink`

Fixes: #16557.
Props: msafi, nacin, simonwheatley, westi, mboynes, joostdevalk, Lex_Robinson, MikeSchinkel, haukep, paulschreiber, DrewAPicture, ravenswd, esemlabel, stevegibson12, martychc23, DrLightman, jivanpal, neonkowy, laternastudio, apedog, audrasjb, davidbaumwald, Confridin, donmhico, ryotsun. 


Built from https://develop.svn.wordpress.org/trunk@47878


git-svn-id: http://core.svn.wordpress.org/trunk@47652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-01 18:49:10 +00:00
Dominik Schilling
b65cf7f992 Build/Test Tools: Improve Travis config to pass config validation. 
* Add missing `os` and `dist` with the current default values.
* Replace the alias `matrix` with `jobs`.
* Remove unsupported `on_start` for `notifications.slack`.

Fixes #50296.
Built from https://develop.svn.wordpress.org/trunk@47877


git-svn-id: http://core.svn.wordpress.org/trunk@47651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-01 16:39:08 +00:00
Dominik Schilling
7152c73f6a Editor: Fix code style for constructor arguments added in [47875]. 
Also revert unintended changes to `WP_Block_Type::__construct()` DocBlock.

See #48529.
Built from https://develop.svn.wordpress.org/trunk@47876


git-svn-id: http://core.svn.wordpress.org/trunk@47650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-01 16:27:15 +00:00
gziolo
c704057e0d Add fields to WP_Block_Type 
As part of #47620 and the RFC for block registeration. Server registered blocks are missing some fields. These changeset includes them.

Props spacedmonkey, aduth.

Fixes #48529.


Built from https://develop.svn.wordpress.org/trunk@47875


git-svn-id: http://core.svn.wordpress.org/trunk@47649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-01 12:27:08 +00:00
Sergey Biryukov
1c176ffb1e Docs: Correct and clarify an inline comment about the upload_url_path and upload_path options in wp-admin/options-media.php. 
Synchronize it with a similar comment in `wp-admin/options.php`.

See #49572.
Built from https://develop.svn.wordpress.org/trunk@47874


git-svn-id: http://core.svn.wordpress.org/trunk@47648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-01 11:22:13 +00:00
Sergey Biryukov
cda84f2409 Build/Test Tools: Bump node-sass and webpack-dev-server versions as a result of npm audit. 
Props whyisjake.
See #49768.
Built from https://develop.svn.wordpress.org/trunk@47873


git-svn-id: http://core.svn.wordpress.org/trunk@47647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-31 20:24:46 +00:00
Sergey Biryukov
f7da44c8d2 Upgrade/Install: Rename wp_in_maintenance_mode() to wp_is_maintenance_mode(), for consistency with wp_is_recovery_mode(). 
While the former name might be a bit more accurate, the latter matches the existing naming pattern.

Follow-up to [47623].

Fixes #49959.
Built from https://develop.svn.wordpress.org/trunk@47871


git-svn-id: http://core.svn.wordpress.org/trunk@47646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-31 19:54:24 +00:00
Sergey Biryukov
5f47ca5b8b Docs: Adjust the documentation for the new ID alias in get_term_by() for consistency with get_user_by(). 
Follow-up to [47865].

See #45163.
Built from https://develop.svn.wordpress.org/trunk@47870


git-svn-id: http://core.svn.wordpress.org/trunk@47645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-31 19:53:04 +00:00
whyisjake
9859bf6204 Build/Test Tools: Revert some devDependency changes for 5.5. 
After bumping some major updates, tests on Travis are failing. 

See: https://travis-ci.com/WordPress/wordpress-develop/builds/168839259 ##49768.
Unprops: whyisjake.


Built from https://develop.svn.wordpress.org/trunk@47869


git-svn-id: http://core.svn.wordpress.org/trunk@47644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-31 19:51:42 +00:00
whyisjake
ef135efa6d Build/Test Tools: Bump devDependencies for WordPress 5.5 
There are several other changes that need to be made for the security audit, this is just the first pass.

Fixes #49768.
Props SergeyBiryukov, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@47867


git-svn-id: http://core.svn.wordpress.org/trunk@47643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-30 04:56:34 +00:00
whyisjake
e8fa5d6fc2 Code Standards: Clean up whitespace on the end of a file. 
See: #45163.
Props: whyisjake.


Built from https://develop.svn.wordpress.org/trunk@47866


git-svn-id: http://core.svn.wordpress.org/trunk@47642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-29 23:35:11 +00:00
whyisjake
7798f64340 Taxonomy: Extend get_term_by to accept ID as a term parameter. 
Similar to `get_user_by`, both `ID` and `id` should be able to accepted.

Fixes #45163.
Props emrikol, esoj.
 

Built from https://develop.svn.wordpress.org/trunk@47865


git-svn-id: http://core.svn.wordpress.org/trunk@47641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-29 22:43:09 +00:00
Sergey Biryukov
2277a9df24 Docs: Improve documentation for functions in wp-includes/category.php per the documentation standards. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@47864


git-svn-id: http://core.svn.wordpress.org/trunk@47640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-29 10:07:10 +00:00
Sergey Biryukov
bc18c233d6 Docs: Document that get_category_by_slug() returns false if the category doesn't exist. 
Props stevenlinx.
Fixes #50277.
Built from https://develop.svn.wordpress.org/trunk@47863


git-svn-id: http://core.svn.wordpress.org/trunk@47639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-29 10:02:13 +00:00
Sergey Biryukov
8924832842 Coding Standards: Use strict comparison in wp-admin/_index.php. 
See #49542.
Built from https://develop.svn.wordpress.org/trunk@47862


git-svn-id: http://core.svn.wordpress.org/trunk@47638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-28 10:02:12 +00:00
Sergey Biryukov
8713fac0d7 Docs: Remove unused @global declarations from _WP_Editors::print_tinymce_scripts(). 
Follow-up to [47860].

See #45398.
Built from https://develop.svn.wordpress.org/trunk@47861


git-svn-id: http://core.svn.wordpress.org/trunk@47637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-27 19:48:11 +00:00
whyisjake
552883574b Editor: Remove TinyMCE global version. 
The global variable is not being used in the `editor_settings` method. 

Fixes #45398.
Props ishitaka, noisysocks, mista-flo.


Built from https://develop.svn.wordpress.org/trunk@47860


git-svn-id: http://core.svn.wordpress.org/trunk@47636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-27 19:28:12 +00:00
Andrea Fercia
38b7495af7 Administration and Site Health: Make information on Search engine visibility more prominent. 
- makes the "Search engines discouraged" message on the Dashboard more prominent
- adds "Search engine visibility" information under Site Health > Info > WordPress 
- removes title case in favor of sentence case in all the related strings 

Props audrasjb, swissspidy, emanuel_blagonic, Presskopp, karmatosed, valentinbora, melchoyce.
Fixes #35288.

Built from https://develop.svn.wordpress.org/trunk@47859


git-svn-id: http://core.svn.wordpress.org/trunk@47635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-27 14:33:11 +00:00
Sergey Biryukov
95d53b9a66 Docs: Correct @return value for WP_REST_Meta_Fields::get_value(). 
Props chrisvanpatten.
Fixes #50259.
Built from https://develop.svn.wordpress.org/trunk@47858


git-svn-id: http://core.svn.wordpress.org/trunk@47634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-27 09:44:11 +00:00
whyisjake
57fb3c6cf0 Coding Standards: Change auto-update filters to be more consistent. 
* send_theme_auto_update_email 👉 auto_theme_update_send_email
* wp_plugins_auto_update_enabled 👉 plugins_auto_update_enabled
* wp_themes_auto_update_enabled 👉 themes_auto_update_enabled

Want to make sure that @ronalfy gets props for his work in #50052 too.

See #50052.
Props: ronalfy, pbiron, azaozz, audrasjb, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@47857


git-svn-id: http://core.svn.wordpress.org/trunk@47633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-26 18:03:08 +00:00
Dominik Schilling
a01835679a Posts, Post Types: Pass the post object to the delete_attachment action. 
Also add the missing `$post` parameter to the `delete_post` and `deleted_post` actions in `wp_delete_attachment()`.

See #30940.
Built from https://develop.svn.wordpress.org/trunk@47856


git-svn-id: http://core.svn.wordpress.org/trunk@47632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-26 14:49:06 +00:00
Sergey Biryukov
7b192d406a Coding Standards: Fix instances of Generic.WhiteSpace.ArbitraryParenthesesSpacing.FoundEmpty. 
See #49542.
Built from https://develop.svn.wordpress.org/trunk@47855


git-svn-id: http://core.svn.wordpress.org/trunk@47631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-26 09:37:10 +00:00
Sergey Biryukov
235bd98f3c Docs: Improve documentation for add_existing_user_to_blog(). 
Props stevenlinx.
Fixes #50243.
Built from https://develop.svn.wordpress.org/trunk@47854


git-svn-id: http://core.svn.wordpress.org/trunk@47630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-25 14:23:13 +00:00
Sergey Biryukov
786ac48c84 Coding Standards: Use strict comparison in wp-admin/network where static strings are involved. 
Includes minor code layout fixes for better readability.

Follow-up to [47808].

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47853


git-svn-id: http://core.svn.wordpress.org/trunk@47629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-24 09:17:09 +00:00
Sergey Biryukov
5899bf0f32 Coding Standards: Use strict comparison for $wp_db_version check in wp-admin/network/upgrade.php. 
Follow-up to [47787], [47788].

See #50155, #49542.
Built from https://develop.svn.wordpress.org/trunk@47852


git-svn-id: http://core.svn.wordpress.org/trunk@47628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-24 09:15:07 +00:00
Sergey Biryukov
5b4174e409 Coding Standards: Use strict comparison for more count() calls. 
Follow-up to [47848].

Props mukesh27.
Fixes #50232. See #49542.
Built from https://develop.svn.wordpress.org/trunk@47851


git-svn-id: http://core.svn.wordpress.org/trunk@47627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-23 16:22:07 +00:00
Dominik Schilling
ed71319421 Role/Capability: Use meta caps edit_post, read_post, and delete_post directly. 
Rather than consulting the post type object, let `map_meta_cap()` handle that for us.

Props peterwilsoncc, ocean90.
Fixes #50128.
See #23226.
Built from https://develop.svn.wordpress.org/trunk@47850


git-svn-id: http://core.svn.wordpress.org/trunk@47626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-23 15:24:07 +00:00
Dominik Schilling
aaeab2f3f5 Rest API: Ensure rest_ensure_response() upgrades WP_HTTP_Response to WP_REST_Response. 
An instance of `WP_HTTP_Response` doesn't ensure that the required methods used in `WP_REST_Server::dispatch()` exist, currently causing a fatal error.

Props ali11007, TimothyBlynJacobs, ocean90.
Fixes #49495.
Built from https://develop.svn.wordpress.org/trunk@47849


git-svn-id: http://core.svn.wordpress.org/trunk@47625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-23 14:36:09 +00:00
Sergey Biryukov
b9751d4efe Coding Standards: Use strict comparison for count() calls. 
See #49542.
Built from https://develop.svn.wordpress.org/trunk@47848


git-svn-id: http://core.svn.wordpress.org/trunk@47624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-23 11:38:08 +00:00
whyisjake
e9282e7389 Bundled Themes: Add missing RTL styles for to fix inconsistent margins on .alignwide and .alignfull items. 
Fixes the inconsistent margins for alignwide and alignfull classes used on Cover Block when it is the first block on a page.

Props kthmd, utz119, nikhilbhansi, and sabernhardt.
Fixes #49435.

Built from https://develop.svn.wordpress.org/trunk@47846


git-svn-id: http://core.svn.wordpress.org/trunk@47622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-23 06:23:06 +00:00
Sergey Biryukov
f1114d4507 Coding Standards: Fix WPCS issues in wp-admin/plugin-editor.php and wp-admin/theme-editor.php. 
See #49542.
Built from https://develop.svn.wordpress.org/trunk@47845


git-svn-id: http://core.svn.wordpress.org/trunk@47621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-23 00:01:10 +00:00
Sergey Biryukov
c0bec847d1 Theme Editor: Remove unused $has_templates boolean. 
The variable is a remnant from when the Theme Editor still had the "Templates" heading and is unused in the current logic.

The condition it was a part of would always evaluate to true for a child theme, regardless of the `$has_templates` value.

Props dboy1988.
Fixes #50199.
Built from https://develop.svn.wordpress.org/trunk@47844


git-svn-id: http://core.svn.wordpress.org/trunk@47620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-22 23:20:08 +00:00
whyisjake
e7150ae5c7 REST API: Ensure proper namespacing when registering routes. 
The PR will corerce routes that have a leading slash and throwing a `_doing_it_wrong` notice while ensuring a proper namespace.

Fixes #49749.
Props TimothyBlynJacobs, skarabeq, afercia.


Built from https://develop.svn.wordpress.org/trunk@47842


git-svn-id: http://core.svn.wordpress.org/trunk@47618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-22 20:48:08 +00:00
Sergey Biryukov
5850f5f6ef Coding Standards: Fix WPCS issues in wp-admin/includes/class-wp-site-health-auto-updates.php. 
See #49542.
Built from https://develop.svn.wordpress.org/trunk@47841


git-svn-id: http://core.svn.wordpress.org/trunk@47617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-22 17:56:08 +00:00
Sergey Biryukov
64ed8a7355 Coding Standards: Fix WPCS issues in wp-admin/includes/class-wp-debug-data.php. 
Follow-up to [47550], [47557], [47835].

See #50052.
Built from https://develop.svn.wordpress.org/trunk@47840


git-svn-id: http://core.svn.wordpress.org/trunk@47616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-22 17:26:07 +00:00
Sergey Biryukov
443dd105d4 Customize: Move the WordPress logo with a white background to the wp-includes directory. 
This ensures that the image used as a default site icon looks good on a dark background.

The image was previously changed in the `wp-admin` directory, but the site icon is now loaded from `wp-includes`.

Follow-up to [36635], [47018], [47564], [47832].

Props ocean90.
Fixes #49798.
Built from https://develop.svn.wordpress.org/trunk@47838


git-svn-id: http://core.svn.wordpress.org/trunk@47614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-21 09:10:12 +00:00
Peter Wilson
39babb4dfb KSES: Support the video element's playsinline attribute. 
Allow users without the `unfiltered_html` capability to use the `playsinline` attribute when embedding videos.

Additionally this adds unit tests for passing the video element through kses.

Fixes #50167. See #29826.

Built from https://develop.svn.wordpress.org/trunk@47837


git-svn-id: http://core.svn.wordpress.org/trunk@47613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-21 04:54:11 +00:00
Sergey Biryukov
ba03c426db Docs: Add missing @since tag for auto_plugin_theme_update_email filter. 
See #50052.
Built from https://develop.svn.wordpress.org/trunk@47836


git-svn-id: http://core.svn.wordpress.org/trunk@47612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-20 19:33:10 +00:00
whyisjake
661b929e1e Security: Add user interface to auto-update themes and plugins. 
Building on core update mechanisms, this adds the ability to enable automatic updates for themes and plugins to the WordPress admin. 

Fixes: #50052.
Props: afercia, afragen, audrasjb, azaozz, bookdude13, davidperonne, desrosj, gmays, gmays, javiercasares, karmatosed, knutsp, mapk, mukesh27, netweb, nicolaskulka, nielsdeblaauw, paaljoachim, passoniate, pbiron, pedromendonca, whodunitagency, whyisjake, wpamitkumar, and xkon.

Built from https://develop.svn.wordpress.org/trunk@47835


git-svn-id: http://core.svn.wordpress.org/trunk@47611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-20 18:49:09 +00:00
Andrea Fercia
2a86d8d534 Accessibility: Media: Hide the invisible "file input" on media views from assistive technologies. 
The file input button is visually hidden, but was announced by screen readers in workflows unrelated to file uploads.
It is now hidden from assistive technologies by the means of an `aria-hidden` attribute, as its CSS display property must not be changed to make sure it still works on old browsers.

See #49753.
Fixes #47611.

Built from https://develop.svn.wordpress.org/trunk@47834


git-svn-id: http://core.svn.wordpress.org/trunk@47610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-20 13:33:07 +00:00
Sergey Biryukov
23c4fbeaa0 Customize: Load the default site icon from the wp-includes directory. 
Files inside the `wp-admin` directory may not be publicly available.

Follow-up to [36635], [47018].

Props whyisjake, finomeno, ocean90.
Fixes #50131.
Built from https://develop.svn.wordpress.org/trunk@47832


git-svn-id: http://core.svn.wordpress.org/trunk@47608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-20 10:36:09 +00:00
Sergey Biryukov
434bee9fc9 Coding Standards: Fix WPCS issues in wp-includes/class-wp-customize-manager.php. 
Follow-up to [47819].

Props sorenbronsted.
See #49542.
Built from https://develop.svn.wordpress.org/trunk@47821


git-svn-id: http://core.svn.wordpress.org/trunk@47597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-19 08:41:12 +00:00
ianbelanger
bc0e05d6c8 Bundled Themes: Twenty Twenty inconsistent top and bottom margins for .alignwide and .alignfull on Chrome vs Safari. 
Fixes the inconsistent margins for `alignwide` and `alignfull` classes used on Cover Block when it is the first block on a page.

Props kthmd, utz119, nikhilbhansi.
Fixes #49435.
Built from https://develop.svn.wordpress.org/trunk@47820


git-svn-id: http://core.svn.wordpress.org/trunk@47596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-18 19:52:07 +00:00
Sergey Biryukov
307725883a Themes: Prevent installation of themes that require a higher version of PHP or WordPress. 
Props afragen.
Fixes #49653. See #48491.
Built from https://develop.svn.wordpress.org/trunk@47819


git-svn-id: http://core.svn.wordpress.org/trunk@47595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-18 16:03:09 +00:00
Sergey Biryukov
54cdfaef59 Themes: Remove extra whitespace from wp-admin/includes/ajax-actions.php and wp-admin/includes/theme.php. 
Follow-up to [47816].

See #48491.
Built from https://develop.svn.wordpress.org/trunk@47818


git-svn-id: http://core.svn.wordpress.org/trunk@47594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-18 12:55:06 +00:00
Sergey Biryukov
e445642243 Themes: Remove debug call from wp-admin/theme-install.php. 
Follow-up to [47816].

See #48491.
Built from https://develop.svn.wordpress.org/trunk@47817


git-svn-id: http://core.svn.wordpress.org/trunk@47593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-18 12:49:08 +00:00
Sergey Biryukov
b73bbd8139 Themes: Prevent activation and live preview of themes that require a higher version of PHP or WordPress. 
Props afragen, jorbin, TimothyBlynJacobs, SergeyBiryukov.
See #48491.
Built from https://develop.svn.wordpress.org/trunk@47816


git-svn-id: http://core.svn.wordpress.org/trunk@47592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-18 12:32:10 +00:00
Sergey Biryukov
d528d7a044 Site Health: Use WP_Theme::parent() in the inactive themes test as a more reliable check that the parent theme exists. 
This is also more consistent with the other instances of directly referencing `WP_Theme::parent()` properties or methods in core.

Props mukesh27, juanlopez4691, davidbaumwald, afragen, SergeyBiryukov.
Fixes #49934.
Built from https://develop.svn.wordpress.org/trunk@47815


git-svn-id: http://core.svn.wordpress.org/trunk@47591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-18 04:38:10 +00:00
Sergey Biryukov
91936df3d1 Coding Standards: Fix WPCS issues in plugin and theme upgrader classes. 
See #49542.
Built from https://develop.svn.wordpress.org/trunk@47814


git-svn-id: http://core.svn.wordpress.org/trunk@47590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-17 09:39:11 +00:00
Sergey Biryukov
f9b60d3334 Accessibility: Login and Registration: Respect the prefers-reduced-motion media query for "shake" CSS animation on login failure. 
This shake should not occur when the user has opted to reduce motion, for example by selecting the "Reduce motion" option in macOS' preferences or unselecting "Show animations in Windows" in Windows' preferences.

Follow-up to [47226].

Props eddystile, johnbillion, sabernhardt, afercia, audrasjb.
Fixes #49723.
Built from https://develop.svn.wordpress.org/trunk@47813


git-svn-id: http://core.svn.wordpress.org/trunk@47589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-16 20:25:19 +00:00
TimothyBlynJacobs
cf0bfa3856 Coding Standards: Correct docblock indentation. 
Fixes PHPCS failure introduced in r47811.

Built from https://develop.svn.wordpress.org/trunk@47812


git-svn-id: http://core.svn.wordpress.org/trunk@47588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-16 19:56:09 +00:00
TimothyBlynJacobs
1e524e7322 REST API: Add @since entries for rest_validate_value_from_schema(). 
See #49572, #48818, #44949, #50053, #48820, #49720, #42961, #44975, #43392, #38583.

Built from https://develop.svn.wordpress.org/trunk@47811


git-svn-id: http://core.svn.wordpress.org/trunk@47587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-16 19:33:09 +00:00
TimothyBlynJacobs
fe00d7f7bf REST API: Support the JSON Schema pattern keyword. 
Props jason_the_adams, birgire, sorenbronsted.
Fixes #44949.

Built from https://develop.svn.wordpress.org/trunk@47810


git-svn-id: http://core.svn.wordpress.org/trunk@47586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-16 19:03:08 +00:00
TimothyBlynJacobs
26bda18a23 REST API: Check required properties are provided when validating an object. 
Previously, the WP_REST_Request object validated that top-level properties were defined, but this did not extend to those object's required properties. This adds validation to rest_validate_value_from_schema() directly.

Both the v3 and v4 JSON Schema syntax for required properties is supported.

Props sorenbronsted.
Fixes #48818.

Built from https://develop.svn.wordpress.org/trunk@47809


git-svn-id: http://core.svn.wordpress.org/trunk@47585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-16 18:44:09 +00:00
Sergey Biryukov
7932193708 Coding Standards: Use strict comparison where static strings are involved. 
This reduces the number of `WordPress.PHP.StrictComparisons.LooseComparison` issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47808


git-svn-id: http://core.svn.wordpress.org/trunk@47584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-16 18:42:12 +00:00
Sergey Biryukov
45f7e68d54 Media: Expose media grid frame via wp-media-grid-ready trigger for easier customization. 
Props soulseekah.
Fixes #50185.
Built from https://develop.svn.wordpress.org/trunk@47807


git-svn-id: http://core.svn.wordpress.org/trunk@47583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-16 17:25:11 +00:00
Sergey Biryukov
16a8128765 Coding Standards: Fix WPCS issues in wp-admin/includes/class-wp-screen.php. 
See #49542.
Built from https://develop.svn.wordpress.org/trunk@47802


git-svn-id: http://core.svn.wordpress.org/trunk@47578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-15 18:13:09 +00:00
ianbelanger
e54d8406eb Bundled Themes: Twenty Eleven & Twenty Twelve dropdown category widget exceeds parent div when strings are long enough. 
Fixes the width of the category dropdown by limiting the width of `select` items in widgets using `max-width: 100%`.

Props gma992, karmatosed.
Fixes #37926.
Built from https://develop.svn.wordpress.org/trunk@47801


git-svn-id: http://core.svn.wordpress.org/trunk@47577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-15 16:31:11 +00:00
ianbelanger
b10bd5134c Bundled Themes: Twenty Twenty version bump. 
We are releasing a new version of Twenty Twenty today thus we need to bump the version.

Props ianbelanger.
Fixes #50174.
Built from https://develop.svn.wordpress.org/trunk@47800


git-svn-id: http://core.svn.wordpress.org/trunk@47576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-14 18:12:07 +00:00
ianbelanger
86b20d5655 Bundled Themes: Twenty Twenty custom post types that don't support authors, shows author box. 
This fixes the issue where custom post types will show an author box, even if they don't support authors.

Props joyously, donmhico.
Fixes #48803.
Built from https://develop.svn.wordpress.org/trunk@47799


git-svn-id: http://core.svn.wordpress.org/trunk@47575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-14 17:17:07 +00:00
Sergey Biryukov
618329a750 Docs: Update Michael Heilemann's URL in a comment in wp-includes/theme-compat/footer.php. 
Props ritterml, mukesh27.
Fixes #50171.
Built from https://develop.svn.wordpress.org/trunk@47798


git-svn-id: http://core.svn.wordpress.org/trunk@47574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-14 15:33:08 +00:00
Sergey Biryukov
69adb593a2 Themes: Add "Block Editor Patterns" and "Full Site Editing" to the list of WordPress theme features. 
Follow-up to [meta9876].

Props dingo_d.
Fixes #50164. See #meta5212.
Built from https://develop.svn.wordpress.org/trunk@47797


git-svn-id: http://core.svn.wordpress.org/trunk@47573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-14 14:43:08 +00:00
ianbelanger
ceed19f625 Bundled Themes: Twenty Twenty add GPLv2 compatible TikTok icon to the social icon menu. 
This adds a GPLv2 compatible TikTok icon to replace the non-compatible TikTok icon and update the readme.txt file. Updates previous commit which used a non-compatible TikTok icon [47589]

Props poena, audrasjb, Emlebrun.
Fixes #49893.
Built from https://develop.svn.wordpress.org/trunk@47796


git-svn-id: http://core.svn.wordpress.org/trunk@47572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-14 13:48:11 +00:00
ianbelanger
f7539586be Bundled Themes: Twenty Twenty add icon for g.page links. 
Adds the option to use a g.page url for the social menu.

Props argentite, mayankmajeji.
Fixes #49088.
Built from https://develop.svn.wordpress.org/trunk@47795


git-svn-id: http://core.svn.wordpress.org/trunk@47571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-14 13:05:09 +00:00
Sergey Biryukov
fb0e6531ab Docs: Add @since notes for theme features added or removed in get_theme_feature_list() after its introduction in WordPress 3.1. 
See #50165.
Built from https://develop.svn.wordpress.org/trunk@47794


git-svn-id: http://core.svn.wordpress.org/trunk@47570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-14 12:50:08 +00:00
Sergey Biryukov
04e3fd6995 Themes: Add "Block Editor Styles" and "Wide Blocks" to the list of WordPress theme features. 
These were added to Theme Directory API in anticipation of being committed to core for WordPress 5.2+, which has not happened until now.

Follow-up to [meta8273].

See #46272.
Built from https://develop.svn.wordpress.org/trunk@47790


git-svn-id: http://core.svn.wordpress.org/trunk@47566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-14 09:18:08 +00:00
Sergey Biryukov
5e42a6c9e5 Export: Use correct escaping function for term IDs in <wp:term> nodes. 
Follow-up to [34333].

Props DrLightman, marcio-zebedeu.
Fixes #50113.
Built from https://develop.svn.wordpress.org/trunk@47789


git-svn-id: http://core.svn.wordpress.org/trunk@47565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-14 07:55:12 +00:00
Sergey Biryukov
9e343ccb33 Coding Standards: Use strict comparison in wp-admin/upgrade.php. 
Props mukesh27.
Fixes #50155.
Built from https://develop.svn.wordpress.org/trunk@47788


git-svn-id: http://core.svn.wordpress.org/trunk@47564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-13 10:10:08 +00:00
Sergey Biryukov
1e813b0275 Coding Standards: Correct db_version check in wp-admin/admin.php. 
Follow-up to [47785].

See #49239.
Built from https://develop.svn.wordpress.org/trunk@47787


git-svn-id: http://core.svn.wordpress.org/trunk@47563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-12 20:59:08 +00:00
Sergey Biryukov
bfba3fc458 Docs: Improve documentation for functions in wp-admin/install-helper.php per the documentation standards. 
Synchronize descriptions with the functions' counterparts from `wp-admin/includes/upgrade.php`.

See #49572.
Built from https://develop.svn.wordpress.org/trunk@47786


git-svn-id: http://core.svn.wordpress.org/trunk@47562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-12 18:40:07 +00:00
Sergey Biryukov
aa69c25d5f Coding Standards: Use strict comparison in some wp-admin files. 
Props pikamander2, mukesh27, SergeyBiryukov.
Fixes #49239.
Built from https://develop.svn.wordpress.org/trunk@47785


git-svn-id: http://core.svn.wordpress.org/trunk@47561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-12 18:32:08 +00:00
ianbelanger
2eef7ee2ac Bundled Themes: Twenty Twenty anchor links don't work in mobile menu. 
Modifies the mobile modal menu javascript, so that anchor links will close the modal and scroll to the anchor within the page.

Props Giorgio25b, suzylah, yuhin, samful, bdcstr.
Fixes #48916.
Built from https://develop.svn.wordpress.org/trunk@47784


git-svn-id: http://core.svn.wordpress.org/trunk@47560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-12 16:45:11 +00:00
Sergey Biryukov
2517abb4bd Docs: Add a note that the $protocols parameter of esc_url_raw() defaults to return value of wp_allowed_protocols(). 
This complements already existing note in `esc_url()`.

Props audrasjb.
Fixes #50147.
Built from https://develop.svn.wordpress.org/trunk@47783


git-svn-id: http://core.svn.wordpress.org/trunk@47559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-11 20:34:13 +00:00
Sergey Biryukov
3fc1b33d53 Docs: Use 3-digit, x.x.x style semantic versioning for inline comments in populate_options(). 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@47782


git-svn-id: http://core.svn.wordpress.org/trunk@47558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-11 17:26:08 +00:00
Sergey Biryukov
7f60aee75a Tests: Give canonical test fixtures for paginated content more descriptive names. 
Follow-up to [47727].

See #28081, #40773, #45337.
Built from https://develop.svn.wordpress.org/trunk@47781


git-svn-id: http://core.svn.wordpress.org/trunk@47557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-10 20:31:08 +00:00
Sergey Biryukov
ddd3647d7d Coding Standards: Rename some files and classes in phpunit/tests/functions/ per the naming conventions. 
https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#naming-and-organization

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47780


git-svn-id: http://core.svn.wordpress.org/trunk@47556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-10 12:09:10 +00:00
Peter Wilson
1c4513e5c3 Tests: Add unit tests for _cleanup_header_comment(). 
Props pbearne.
Fixes #38101. See #8497.

Built from https://develop.svn.wordpress.org/trunk@47779


git-svn-id: http://core.svn.wordpress.org/trunk@47555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-10 05:23:11 +00:00
Sergey Biryukov
0c3117a80f Coding Standards: Fix WPCS issues in wp-includes/update.php. 
Props mukesh27.
Fixes #50130.
Built from https://develop.svn.wordpress.org/trunk@47778


git-svn-id: http://core.svn.wordpress.org/trunk@47554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-09 12:52:10 +00:00
Sergey Biryukov
5511b43e2c Administration: Avoid a PHP 7.4 notice in add_meta_box() when attempting to re-add a previously removed box. 
The logic for skipping previously removed meta boxes with the `core` priority should also apply to the `sorted` priority that is used when the boxes were manually reordered.

Add a unit test.

Props coolmann, franzarmas, SergeyBiryukov.
Fixes #50019.
Built from https://develop.svn.wordpress.org/trunk@47777


git-svn-id: http://core.svn.wordpress.org/trunk@47553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-09 12:26:12 +00:00
ianbelanger
928ce10da0 Bundled Themes: Twenty Twenty customizer retina_logo should be hidden when no logo is set. 
Modifies the Customize setting `Site Identity > Retina logo` so that the option is hidden if there is no logo is set in `Site Identity > Logo`.

Props truongwp.
Fixes #50109.
Built from https://develop.svn.wordpress.org/trunk@47776


git-svn-id: http://core.svn.wordpress.org/trunk@47552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-08 19:36:10 +00:00
Sergey Biryukov
1cde7d86f9 Coding Standards: Fix WPCS issues in wp-admin/includes/template.php. 
See #49542.
Built from https://develop.svn.wordpress.org/trunk@47775


git-svn-id: http://core.svn.wordpress.org/trunk@47551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-08 16:36:18 +00:00
Sergey Biryukov
43a6aff0d4 Coding Standards: Use strict comparison in wp-includes/widgets/class-wp-widget-rss.php. 
Props mukesh27.
Fixes #50125.
Built from https://develop.svn.wordpress.org/trunk@47774


git-svn-id: http://core.svn.wordpress.org/trunk@47550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-08 08:36:18 +00:00
Sergey Biryukov
33194d29c2 Site Health: Improve the appearance of administration email verification box. 
Add `max-width` on desktop view and some padding on smaller screens.

Props chetan200891, azaozz, Clorith, afragen.
Fixes #48607.
Built from https://develop.svn.wordpress.org/trunk@47772


git-svn-id: http://core.svn.wordpress.org/trunk@47548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-07 21:42:11 +00:00
Dominik Schilling
7ded6c2d2a Administration: Remove any CSS related to Internet Explorer versions 6 – 10. 
In WordPress 3.2 support for IE6 was dropped, IE7 followed a few versions later. With the 4.8 release, WordPress officially ended support for Internet Explorer versions 8, 9, and 10. Yet, we still have shipped CSS for the unsupported IE versions....until now! Goodbye to ie.css and star hacks!

* Removes ie.css and `ie` style handle.
* Removes IE specific class names and any related CSS.
* Drops support for IE8 and older in `wp_customize_support_script()`.
* Updates compatibility mode for CSS minification to `ie11`.

Props ayeshrajans, isabel_brison, afercia, netweb, peterwilsoncc, ocean90.
Fixes #17232, #46015.
Built from https://develop.svn.wordpress.org/trunk@47771


git-svn-id: http://core.svn.wordpress.org/trunk@47547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-06 20:15:07 +00:00
Sergey Biryukov
a0224a579d Menus: Add a Cancel link to the screen for creating a new menu. 
The use case this helps the most is when there's only one menu and you click "create a new menu". In this case the Cancel link allows you to go back to the single existing menu.

Props garrett-eclipse, audrasjb.
Fixes #46367.
Built from https://develop.svn.wordpress.org/trunk@47770


git-svn-id: http://core.svn.wordpress.org/trunk@47546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-06 19:35:11 +00:00
Sergey Biryukov
bf3296a9a0 Script Loader: Add the $group parameter to WP_Dependencies::do_item(). 
Previously, the method was called with two parameters in `::do_items()`, while the method signature only included one parameter.

Technically, this was not an issue as `WP_Dependencies::do_item()` is a placeholder meant to be overwritten when extending the class. When handling scripts, `WP_Dependencies` is extended with `WP_Scripts`, and the `$group` parameter was only used in `WP_Scripts::do_item()`, which does expect a second argument.

However, officially adding the parameter to `WP_Dependencies::do_item()` signature prevents code misunderstanding and avoids a warning in PHP code inspection tools.

Props kaggdesign, soulseekah, azaozz, SergeyBiryukov.
Fixes #43627.
Built from https://develop.svn.wordpress.org/trunk@47769


git-svn-id: http://core.svn.wordpress.org/trunk@47545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-06 16:27:12 +00:00
Sergey Biryukov
86ac5e1432 Site Health: Do not trigger the fatal error handler while updates are being installed. 
Triggering the error handler during updates may cause false positives. For example, updates may temporarily "fail" while files are moved around, but work fine once completed. Sending emails about temporary failures would just be confusing to the recipient.

Props Clorith, airamerica.
Fixes #48964.
Built from https://develop.svn.wordpress.org/trunk@47768


git-svn-id: http://core.svn.wordpress.org/trunk@47544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-06 14:38:17 +00:00
whyisjake
538e9fb308 Block Editor: Update _all_ of the block editor packages following the 5.4.1 release. 
This is an extension of [47619] and [47765].

Fixes #50094.
Props aduth, peterwilsoncc, whyisjake, ocean90, and afercia.


Built from https://develop.svn.wordpress.org/trunk@47766


git-svn-id: http://core.svn.wordpress.org/trunk@47542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-05 23:56:33 +00:00
whyisjake
4a11b9db02 Block Editor: Update WordPress Packages following the 5.4.1 release. 
This bumps @wordpress/block-library 2.14.7 ➡️ 2.14.8

Fixes #50094.
Props aduth, peterwilsoncc, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@47765


git-svn-id: http://core.svn.wordpress.org/trunk@47541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-05 23:39:31 +00:00
whyisjake
62f6909480 Code standards: Drop a newline in the customizer to comply with WordPress Coding Standards 
Extends [47763] and #46829.

Built from https://develop.svn.wordpress.org/trunk@47764


git-svn-id: http://core.svn.wordpress.org/trunk@47540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-05 22:00:09 +00:00
whyisjake
7a48040e13 Menus: Denote the special pages in the Customizer menu editor. 
The special pages here are the pages that are used for the Privacy Policy, Home, and the Posts page.

Fixes #46829.
Props garrett-eclipse, audrasjb.

Built from https://develop.svn.wordpress.org/trunk@47763


git-svn-id: http://core.svn.wordpress.org/trunk@47539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-05 21:17:06 +00:00
Sergey Biryukov
9782eb82ad Site Health: Display the original PHP memory limit on Site Health Info screen. 
This ensures that if the limit has been modified for admin screens by `wp_raise_memory_limit()`, the original value is displayed along with the current value.

Props Clorith, espiat, zodiac1978, SergeyBiryukov.
Fixes #49329.
Built from https://develop.svn.wordpress.org/trunk@47762


git-svn-id: http://core.svn.wordpress.org/trunk@47538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-05 18:58:09 +00:00
Sergey Biryukov
b1a275684a Canonical: Only redirect non-existing page requests to the post permalink if the post is found. 
Follow-up to [47760].

See #45337, #40773, #28081, #11694.
Built from https://develop.svn.wordpress.org/trunk@47761


git-svn-id: http://core.svn.wordpress.org/trunk@47537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-04 10:49:07 +00:00
Sergey Biryukov
5b046976cc Canonical: Redirect paged requests for a static page assigned as the "Posts page". 
This avoids displaying duplicate content of the home page under different URLs with appended page numbers.

This change only affects the `<!--nextpage-->` pagination (`page` query variable) and not the regular multiple posts pagination (`paged` query variable).

The posts page does not support the `<!--nextpage-->` pagination, so requests for invalid page numbers should be redirected to the page permalink, applying the logic previously implemented for single posts or pages.

Follow-up to [34492], [47727].

Props jeremyfelt, sachit.tandukar, SergeyBiryukov.
Fixes #45337. See #40773, #28081, #11694.
Built from https://develop.svn.wordpress.org/trunk@47760


git-svn-id: http://core.svn.wordpress.org/trunk@47536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-04 10:42:07 +00:00
Sergey Biryukov
37d179de1c Coding Standards: Fix WPCS issues in wp-includes/canonical.php. 
Reformat long conditions and dense code blocks for better readability.

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47759


git-svn-id: http://core.svn.wordpress.org/trunk@47535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-04 09:05:08 +00:00
TimothyBlynJacobs
46854d7322 REST API: Support more JSON Schemas when filtering a response by context. 
The array type, multi-types, and the additional properties keyword are now supported. Additionally, the filter recurses to an infinite depth.

Fixes #48819.

Built from https://develop.svn.wordpress.org/trunk@47758


git-svn-id: http://core.svn.wordpress.org/trunk@47534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-04 02:46:05 +00:00
TimothyBlynJacobs
ed4bdbb8f1 Tests: Update wp-api-generated.js. 
[47755] and [47756] caused a schema change, so the wp-api-generated.js file needs to be updated.

Built from https://develop.svn.wordpress.org/trunk@47757


git-svn-id: http://core.svn.wordpress.org/trunk@47533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-04 00:28:09 +00:00
TimothyBlynJacobs
7023be21f5 REST API: Accept POST requests in the block renderer endpoint. 
Rendering a block is idempotent, so a GET is the most natural request method. However, the maximum length of URLs prevented blocks with large attributes from being rendered.

Props ryankienstra.
Fixes #49680.

Built from https://develop.svn.wordpress.org/trunk@47756


git-svn-id: http://core.svn.wordpress.org/trunk@47532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-03 22:58:05 +00:00
TimothyBlynJacobs
facb1728b9 REST API: Validate that the oembed url parameter is a string. 
This prevents a PHP warning from being issued by esc_url_raw when a non-string value is provided.

Props dd32.
Fixes #49991.

Built from https://develop.svn.wordpress.org/trunk@47755


git-svn-id: http://core.svn.wordpress.org/trunk@47531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-03 22:42:06 +00:00
John Blackbourn
717f0d0a3e Docs: Misc docblock corrections and improvements. 
See #49572
Built from https://develop.svn.wordpress.org/trunk@47754


git-svn-id: http://core.svn.wordpress.org/trunk@47530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-03 19:38:08 +00:00
TimothyBlynJacobs
ac3c2fe60a REST API: Support the uuid JSON Schema format. 
This accepts a uuid of any version. A future commit could add support for restricting uuids to a specific version.

Props johnwatkins0.
Fixes #50053.

Built from https://develop.svn.wordpress.org/trunk@47753


git-svn-id: http://core.svn.wordpress.org/trunk@47529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-03 19:20:09 +00:00
John Blackbourn
c215a6dc27 Build/Test Tools: Further enhancements to the local development environment readme. 
Props desrosj, donmhico

See #50058
Built from https://develop.svn.wordpress.org/trunk@47752


git-svn-id: http://core.svn.wordpress.org/trunk@47528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-03 14:43:07 +00:00
Andrea Fercia
36524e1e25 File Editor: Remove CSS exceptions for the "Select plugin/theme to edit" and documentation "Look Up" buttons. 
Buttons should use the default buttons styles, no exceptions.

Props passoniate, garethgillman.
See #49197.
Fixes #49353.

Built from https://develop.svn.wordpress.org/trunk@47751


git-svn-id: http://core.svn.wordpress.org/trunk@47527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-03 14:21:08 +00:00
Andrea Fercia
bc3cee1d5b Upload: Improve file input and button alignment in plugin/theme upload form. 
Resets flexbox on smaller screens. Improves vertical alignment on large screens.
Follow-up to [47599] and [47271].

Props mukesh27, DarkoG.
See #48859, #49914.
Fixes #49951.

Built from https://develop.svn.wordpress.org/trunk@47750


git-svn-id: http://core.svn.wordpress.org/trunk@47526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-03 13:36:12 +00:00
Sergey Biryukov
72ef4ae81a Docs: Further update inline documentation for the wpdb class per the documentation standards. 
Restore some previous edits from [46696], [47060], [47122], [47230] that were accidentally reverted in [47740].

See #49572.
Built from https://develop.svn.wordpress.org/trunk@47749


git-svn-id: http://core.svn.wordpress.org/trunk@47525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-03 11:45:06 +00:00
John Blackbourn
f89f744fb2 Media: Ensure a consistent structure for the array returned by wp_get_attachment_image_src(). 
The array returned by this function previously included a fourth element only when an intermediate image size was used. This change ensures a consistent structure in the returned array regardless of the function's internal behaviour.

Props wido, joemcgill, johnbillion

Fixes #46113
Built from https://develop.svn.wordpress.org/trunk@47748


git-svn-id: http://core.svn.wordpress.org/trunk@47524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-02 22:57:06 +00:00
John Blackbourn
1a27d51b48 Menus: Allow empty taxonomy terms to be surfaced when searching for items. 
This brings the behaviour inline with that of browsing terms or using the All Items tab, which correctly shows empty terms.

Props birgire, audrasjb

Fixes #45298
Built from https://develop.svn.wordpress.org/trunk@47747


git-svn-id: http://core.svn.wordpress.org/trunk@47523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-02 22:36:07 +00:00
John Blackbourn
cc4e27142e Upgrade/Install: Unlink the logo on the installation and config setup screens. 
This allows for a natural tab order during installation, without negatively impacting users who use the keyboard for navigation, those who use a screen reader, or those who use neither.

Props lwill, afercia, audrasjb.

Fixes #47759
Built from https://develop.svn.wordpress.org/trunk@47746


git-svn-id: http://core.svn.wordpress.org/trunk@47522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-02 21:46:08 +00:00
John Blackbourn
5641afd43b Administration: Reduce the chance that a PHP error message that occurs before the admin menu gets output is covered by the admin menu. 
Props EmpireOfLight, afercia, Mte90, audrasjb, sunnyratilal

Fixes #35155
Built from https://develop.svn.wordpress.org/trunk@47745


git-svn-id: http://core.svn.wordpress.org/trunk@47521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-02 21:01:05 +00:00
John Blackbourn
55117c5376 Build/Test Tools: Add information regarding the default credentials for the local development environment to the project readme. 
Props bookdude13

Fixes #49273
Built from https://develop.svn.wordpress.org/trunk@47744


git-svn-id: http://core.svn.wordpress.org/trunk@47520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-02 20:19:08 +00:00
John Blackbourn
7307415f6d Build/Test Tools: Add more comprehensive instructions to the readme for the local development environment. 
See #50058
Built from https://develop.svn.wordpress.org/trunk@47743


git-svn-id: http://core.svn.wordpress.org/trunk@47519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-02 19:16:07 +00:00
John Blackbourn
d29f5c14ac Build/Test Tools: Exclude plugins and themes within src. 
Just like the `build` directory, `src` can include plugins and themes which shouldn't be linted by PHPCS.

Fixes #49781
Built from https://develop.svn.wordpress.org/trunk@47742


git-svn-id: http://core.svn.wordpress.org/trunk@47518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-02 18:17:05 +00:00
John Blackbourn
1c01b6c32e Build/Test Tools: Remove unnecessary formatting before linting on Travis CI. 
Fixes #49722
Built from https://develop.svn.wordpress.org/trunk@47741


git-svn-id: http://core.svn.wordpress.org/trunk@47517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-02 17:46:07 +00:00
John Blackbourn
736874a51e Docs: Update inline documentation for the wpdb class. 
Props theMikeD

Fixes #49477
Built from https://develop.svn.wordpress.org/trunk@47740


git-svn-id: http://core.svn.wordpress.org/trunk@47516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-02 17:25:07 +00:00
Dominik Schilling
a6f3ad2d21 Users: Don't reset user language preference on user update. 
Props johnbillion.
Fixes #38665.
Built from https://develop.svn.wordpress.org/trunk@47739


git-svn-id: http://core.svn.wordpress.org/trunk@47515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-02 16:29:06 +00:00
Sergey Biryukov
4abdb06f72 Query: Simplify the logic in WP::handle_404() to allow for easier modifications. 
See #45337.
Built from https://develop.svn.wordpress.org/trunk@47738


git-svn-id: http://core.svn.wordpress.org/trunk@47514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-02 08:48:08 +00:00
desrosj
25c841026d General: More PHP compatibility adjustments. 
In this round:
- Removed references to `safe_mode` in `class-php3.php`. This was removed in PHP 5.4.
- Add inline exclude comments for compatibility checks in getID3.

Follow up of [47735-47736].

See #49922.
Built from https://develop.svn.wordpress.org/trunk@47737


git-svn-id: http://core.svn.wordpress.org/trunk@47513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-01 20:12:06 +00:00
desrosj
791e3bdb38 General: Fix typo within phpcs:ignore inline comment. 
Follow up of [47735].

See #49922.
Built from https://develop.svn.wordpress.org/trunk@47736


git-svn-id: http://core.svn.wordpress.org/trunk@47512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-01 19:36:06 +00:00
desrosj
89ddd19884 General: Fix various issues flagged by the PHPCompatibilityWP PHPCS ruleset. 
As part of the continued effort to improve PHP compatibility, the following improvments are being made:

- Removing deprecated PHP `safe_mode` checks not found in bundled external libraries.
- Change the remaining `while` loops using `each()` to `foreach` loops.
- Prevent false positives from being flagged for the `sodium_compat` library being caused by loading this in a non-standard way.
- Add inline comments to not flag deprecated PHP directives in the getID3 library.

Props desrosj, earnjam, dryanpress.
See #49922.
Built from https://develop.svn.wordpress.org/trunk@47735


git-svn-id: http://core.svn.wordpress.org/trunk@47511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-01 19:07:09 +00:00
Sergey Biryukov
10945d2f3d Taxonomy: Restore (un-deprecate) the tag_row_actions filter. 
The filter provides a simple way for plugin authors to add actions generically for all taxonomy list tables without looping through each taxonomy individually.

Props joemcgill, delowardev.
Fixes #49808.
Built from https://develop.svn.wordpress.org/trunk@47734


git-svn-id: http://core.svn.wordpress.org/trunk@47510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-01 16:45:09 +00:00
desrosj
a72e30d847 External Libraries: Update the SimplePie library to the latest version (1.5.5). 
This brings SimplePie in sync with the most up to date version, 1.5.5.

This update brings many bug fixes, small enhancements, and PHP compatibility fixes for newer versions of PHP.

For a full list of changes, see https://github.com/simplepie/simplepie/blob/master/CHANGELOG.md#155-may-1-2020.

Props dshanske, slushman, etruel, wpshades, dmenard, desrosj, hareesh-pillai, stevenkword, jrf, Ipstenu, johnbillion.
Fixes #36669.
Built from https://develop.svn.wordpress.org/trunk@47733


git-svn-id: http://core.svn.wordpress.org/trunk@47509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-05-01 14:26:07 +00:00
desrosj
7f5686d40e Build/Test Tools: Introduce a command for restarting the local Docker environment. 
This change introduces the `env:restart` command for easier restarting of the local Docker environment.

Props desrosj, ianbelanger.
Fixes #50039.

Built from https://develop.svn.wordpress.org/trunk@47730


git-svn-id: http://core.svn.wordpress.org/trunk@47507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-30 20:22:06 +00:00
desrosj
8959d57ceb Reverting [47728]. 
Unprops desrosj.
See #50039.
Built from https://develop.svn.wordpress.org/trunk@47729


git-svn-id: http://core.svn.wordpress.org/trunk@47506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-30 20:17:09 +00:00
desrosj
4a6383a2da -username=desrosj 
Built from https://develop.svn.wordpress.org/trunk@47728


git-svn-id: http://core.svn.wordpress.org/trunk@47505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-30 19:55:07 +00:00
Sergey Biryukov
eae1462bef Canonical: Redirect paged requests for non-paginated posts to the post permalink. 
This avoids displaying duplicate content of the same post under different URLs and ensures the canonical URL is correct.

Previously, requests for invalid page numbers were only redirected to the post permalink if the post was actually paginated using the `<!--nextpage-->` marker.

Follow-up to [34492].

Props jeremyfelt, prografika, sachit.tandukar, subrataemfluence, hronak, ekatherine, henry.wright, chesio, dd32, SergeyBiryukov.
Fixes #40773. See #45337, #28081, #11694.
Built from https://develop.svn.wordpress.org/trunk@47727


git-svn-id: http://core.svn.wordpress.org/trunk@47504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-30 12:05:14 +00:00
Sergey Biryukov
8ca76cabfc Help/About: Revert [47699] from trunk. 
Built from https://develop.svn.wordpress.org/trunk@47706


git-svn-id: http://core.svn.wordpress.org/trunk@47483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-29 18:44:11 +00:00
whyisjake
cf8bd373fe Update the about page for WordPress 5.4.1 
Built from https://develop.svn.wordpress.org/trunk@47699


git-svn-id: http://core.svn.wordpress.org/trunk@47476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-29 18:37:05 +00:00
ianbelanger
b1a318f3bd Bundled Themes: Twenty Twenty image caption is not aligned center when image is, on the front-end. 
Fixes the image caption alignment issue by adding `text-align: center;` to `.wp-block-image .aligncenter figcaption`.

Props markusthiel, SergeyBiryukov, garethgillman.
Fixes #49320.
Built from https://develop.svn.wordpress.org/trunk@47689


git-svn-id: http://core.svn.wordpress.org/trunk@47466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-29 18:19:05 +00:00
Sergey Biryukov
800b71ca31 Coding Standards: Fix WPCS issues in tests/formatting/SanitizeFileName.php. 
Follow-up to [47638].
Built from https://develop.svn.wordpress.org/trunk@47664


git-svn-id: http://core.svn.wordpress.org/trunk@47441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-29 17:26:18 +00:00
Sergey Biryukov
266b52513b Docs: Correct @since versions, remove duplicate comment. 
Follow-up to [47633].
Built from https://develop.svn.wordpress.org/trunk@47663


git-svn-id: http://core.svn.wordpress.org/trunk@47440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-29 17:25:10 +00:00
whyisjake
fd21a9346c Formatting: Expand sanitize_file_name to have better support for utf8 characters. 
Props: xknown, peterwilsoncc.

Built from https://develop.svn.wordpress.org/trunk@47638


git-svn-id: http://core.svn.wordpress.org/trunk@47413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-29 15:40:07 +00:00
whyisjake
c16fa7c73d Cache API: Ensure proper escaping around the stats method in the cache API. 
Props: nickdaugherty, batmoo, whyisjake, westi.

Built from https://develop.svn.wordpress.org/trunk@47637


git-svn-id: http://core.svn.wordpress.org/trunk@47412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-29 15:36:06 +00:00
whyisjake
94f5dc0cad Block Editor: Coding standards, properly escape class names. 
Props: aduth, noisysocks, pento, talldanwp, jorgefilipecosta, whyisjake, ellatrix, ehti.

Built from https://develop.svn.wordpress.org/trunk@47636


git-svn-id: http://core.svn.wordpress.org/trunk@47411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-29 15:34:09 +00:00
whyisjake
3ee9488292 Query: Ensure that only a single post can be returned on date/time based queries. 
Props: sstoqnov, peterwilsoncc.

Built from https://develop.svn.wordpress.org/trunk@47635


git-svn-id: http://core.svn.wordpress.org/trunk@47410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-29 15:28:04 +00:00
whyisjake
f7b4147bea User: Invalidate user_activation_key on password update. 
Props: sstoqnov, sergeybiryukov.


Built from https://develop.svn.wordpress.org/trunk@47634


git-svn-id: http://core.svn.wordpress.org/trunk@47409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-29 15:25:07 +00:00
whyisjake
55cd633c37 Customize: Add additional filters to Customizer to prevent JSON corruption. 
This solution extends the wp_insert_post_data filter to pass in addition to the slashed/sanitized/processed data, and the slashed/sanitized/unprocessed data, to also pass the initial slashed/unsanitized/unprocessed data which was passed into wp_insert_post(). This then allows plugins to have complete control over how sanitization is performed based on the post type.

Props westonruter, peterwilsoncc, sstoqnov, whyisjake, xknown.
 

Built from https://develop.svn.wordpress.org/trunk@47633


git-svn-id: http://core.svn.wordpress.org/trunk@47408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-29 15:14:10 +00:00
Sergey Biryukov
3dc1e33fb5 Networks and Sites: Link to Nginx documentation on Network Setup screen when Nginx is in use. 
Props lipathor, audrasjb, johnbillion, flixos90.
Fixes #41166.
Built from https://develop.svn.wordpress.org/trunk@47632


git-svn-id: http://core.svn.wordpress.org/trunk@47407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-29 14:43:09 +00:00
Sergey Biryukov
0da2c98ddc Docs: Correct @return type for WP_Theme::get_post_templates(). 
The method returns an array of strings, not a single string.

Props mayankmajeji, salvatore.formisano.
Fixes #50020.
Built from https://develop.svn.wordpress.org/trunk@47631


git-svn-id: http://core.svn.wordpress.org/trunk@47406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-28 15:02:11 +00:00
Sergey Biryukov
5371e3fd62 Site Health: Avoid a PHP notice in WP_Site_Health::wp_cron_scheduled_check() if async test response does not contain the expected result. 
Additionally, avoid a PHP notice in `::get_test_php_version()` if the minimum recommended version of PHP could not be determined.

Props schlessera, oakesjosh.
Fixes #49943.
Built from https://develop.svn.wordpress.org/trunk@47628


git-svn-id: http://core.svn.wordpress.org/trunk@47403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-27 22:01:08 +00:00
TimothyBlynJacobs
352cb55cca REST API: Support the (min|max)Length JSON Schema keywords. 
Props sorenbronsted.
Fixes #48820.

Built from https://develop.svn.wordpress.org/trunk@47627


git-svn-id: http://core.svn.wordpress.org/trunk@47402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-27 02:29:07 +00:00
Sergey Biryukov
e55ca10ddc Comments: Ensure that inserting a comment with an empty type results in correct comment type. 
Add unit tests for `wp_handle_comment_submission()` and `wp_insert_comment()` receiving an empty type.

Follow-up to [47597].

Props ocean90, imath.
Fixes #49236.
Built from https://develop.svn.wordpress.org/trunk@47626


git-svn-id: http://core.svn.wordpress.org/trunk@47401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-26 13:44:07 +00:00
Sergey Biryukov
6b5087812c Comments: Restore inclusion of an empty comment type when building the WHERE clause in WP_Comment_Query::get_comment_ids(). 
This ensures that `get_comments( array( 'type' => 'comment' ) )` still includes comments that have not yet migrated to the `comment` type.

Follow-up to [47597].

Props ocean90.
See #49236.
Built from https://develop.svn.wordpress.org/trunk@47625


git-svn-id: http://core.svn.wordpress.org/trunk@47400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-26 13:14:06 +00:00
Sergey Biryukov
77eb929b52 Upgrade/Install: Introduce wp_in_maintenance_mode(), a helper function to check if WordPress is currently in maintenance mode. 
Props Clorith.
Fixes #49959.
Built from https://develop.svn.wordpress.org/trunk@47623


git-svn-id: http://core.svn.wordpress.org/trunk@47398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-25 20:19:07 +00:00
Sergey Biryukov
43cfa7ee60 Administration: Remove right padding on form tables on smaller screens so that the spacing is equal on both sides. 
Additionally, reduce the right margin on screen meta links (Help and Screen Options) to align with the tables.

Props jainnidhi, garrett-eclipse, ibdz, SergeyBiryukov.
Fixes #43279.
Built from https://develop.svn.wordpress.org/trunk@47622


git-svn-id: http://core.svn.wordpress.org/trunk@47397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-25 12:27:11 +00:00
ianbelanger
72ef7ee315 Bundled Themes: Twenty Twenty remove unnecessary $css_dependencies variable in twentytwenty_block_editor_styles(). 
Removes the unnecessary `$css_dependencies` variable in `twentytwenty_block_editor_styles()`.

Props ocean90, Dency.
Fixes #49986.
Built from https://develop.svn.wordpress.org/trunk@47618


git-svn-id: http://core.svn.wordpress.org/trunk@47393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-24 14:59:07 +00:00
Sergey Biryukov
ced8fb20a1 Code Modernization: Remove error suppression from parse_url() calls. 
Previously, the `@` operator was used to prevent possible warnings emitted by `parse_url()` in PHP < 5.3.3 when URL parsing failed.

Now that the minimum version of PHP required by WordPress is 5.6.20, this is no longer needed.

Props netpassprodsr, Howdy_McGee.
Fixes #49980. See #24780.
Built from https://develop.svn.wordpress.org/trunk@47617


git-svn-id: http://core.svn.wordpress.org/trunk@47392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-24 07:28:10 +00:00
Sergey Biryukov
0dc461c72e Networks and Sites: Don't display an empty Menu Settings section in network admin if there are no items. 
This accounts for returning an empty array from the `mu_menu_items` filter.

Props dlh.
Fixes #49977.
Built from https://develop.svn.wordpress.org/trunk@47616


git-svn-id: http://core.svn.wordpress.org/trunk@47391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-23 18:58:05 +00:00
Sergey Biryukov
b6c70b7712 Embeds: Fix incorrect usage of get_home_url() in oEmbed tests. 
Switch to `home_url()` for consistency with other tests and to avoid confusion.

Props david.binda.
Fixes #49988.
Built from https://develop.svn.wordpress.org/trunk@47615


git-svn-id: http://core.svn.wordpress.org/trunk@47390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-23 18:41:07 +00:00
ianbelanger
f97ac354c6 Bundled Themes: Twenty Twenty button styles produce inconsistent output and cannot be edited. 
Fixes the issue with button styles not working when the Gutenberg plugin is activated while maintaining backwards compatibility.

Props nrqsnchz, poena, kjellr.
Fixes #49896.
Built from https://develop.svn.wordpress.org/trunk@47614


git-svn-id: http://core.svn.wordpress.org/trunk@47389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-23 15:41:09 +00:00
ianbelanger
4632322382 Bundled Themes: Twenty Twenty resized images are centered inside the editor (with no alignment set) since WordPress 5.4. 
Fixes the image alignment issue by removing `margin-left: auto;` and `margin-right: auto;` from `.editor-styles-wrapper .wp-block-image.is-resized`.

Props dianeco, JavierCasares.
Fixes #49600.
Built from https://develop.svn.wordpress.org/trunk@47613


git-svn-id: http://core.svn.wordpress.org/trunk@47388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-22 19:25:08 +00:00
desrosj
a753e44d4e Bootstrap/Load: Deprecate wp_unregister_GLOBALS(). 
The `register_globals` directive in PHP was deprecated in version 5.3 and removed entirely in 5.4.

Now that WordPress only supports PHP 5.6.20 and newer, the `wp_unregister_GLOBALS()` function can be deprecated.

Props ayeshrajans, desrosj, SergeyBiryukov.
Fixes #49938.
Built from https://develop.svn.wordpress.org/trunk@47612


git-svn-id: http://core.svn.wordpress.org/trunk@47387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-22 15:42:09 +00:00
Sergey Biryukov
427405535f Docs: Synchronize parameter documentation for various metadata functions, update per the documentation standards. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@47611


git-svn-id: http://core.svn.wordpress.org/trunk@47386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-22 10:31:09 +00:00
Sergey Biryukov
9aa0fff80e Docs: Document the default value of $single and $prev_value parameters in various metadata functions. 
Props denisco.
See #49572.
Built from https://develop.svn.wordpress.org/trunk@47610


git-svn-id: http://core.svn.wordpress.org/trunk@47385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-22 09:40:10 +00:00
ianbelanger
29abe5c726 Bundled Themes: Twenty Twenty submenu items disappear underneath the Cover block. 
Fixes the submenu issue by raising the z-index value of the site-header from 1 to 2.

Props kjellr, JavierCasares.
Fixes #49322.
Built from https://develop.svn.wordpress.org/trunk@47609


git-svn-id: http://core.svn.wordpress.org/trunk@47384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-21 20:06:08 +00:00
ianbelanger
116a9b3039 Bundled Themes: Twenty Twenty missed license for images. 
Fixes the image license in the readme by removing screenshot.png.

Props h71, poena.
Fixes #49316.
Built from https://develop.svn.wordpress.org/trunk@47608


git-svn-id: http://core.svn.wordpress.org/trunk@47383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-21 19:43:09 +00:00
ianbelanger
c9ea34b6b3 Bundled Themes: Twenty Twenty block editor inserter is missing the +. 
Fixes the disappearing `+` in the block editor when using the latest version of the Gutenberg plugin, by adding support for the native Gutenberg editor styles and removing `color: inherit;` from Twenty Twenty's style.css.

Props nrqsnchz, .
Fixes #49610.
Built from https://develop.svn.wordpress.org/trunk@47607


git-svn-id: http://core.svn.wordpress.org/trunk@47382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-21 19:17:08 +00:00
Sergey Biryukov
6c243b4b0a Networks and Sites: Display the Site Address field on Add Site screen in left-to-right text direction. 
Props ramiy.
Fixes #49949.
Built from https://develop.svn.wordpress.org/trunk@47606


git-svn-id: http://core.svn.wordpress.org/trunk@47381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-21 11:26:07 +00:00
Sergey Biryukov
b4373fafe9 Menus: Remove unused commented out code in wp-admin/nav-menus.php. 
Props garrett-eclipse, audrasjb.
Fixes #49967.
Built from https://develop.svn.wordpress.org/trunk@47605


git-svn-id: http://core.svn.wordpress.org/trunk@47380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-21 09:02:08 +00:00
Sergey Biryukov
589666abc3 External Libraries: Revert [47603]. 
With the Docker image for PHP 7.4 updated to stable version, this should no longer be necessary.

See https://github.com/WordPress/wpdev-docker-images/pull/26

Props ocean90.
Fixes #49945.
Built from https://develop.svn.wordpress.org/trunk@47604


git-svn-id: http://core.svn.wordpress.org/trunk@47379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-20 15:41:08 +00:00
Sergey Biryukov
e9e5d8e2b2 External Libraries: Comment out magic quote functions in getID3(). 
For some reason, the `version_compare()` check does not work as expected on Travis.

Follow-up to [46113], [47601].

See #49945.
Built from https://develop.svn.wordpress.org/trunk@47603


git-svn-id: http://core.svn.wordpress.org/trunk@47378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-20 12:12:06 +00:00
Sergey Biryukov
1bac2cbe66 External Libraries: Backport a commit from getID3() trunk to fix a PHP 7.4+ notice. 
This addresses a "Trying to access array offset on value of type bool" notice in the `getid3_mp3::MPEGaudioHeaderValid()` method.

Props schlessera.
Fixes #49945.
Built from https://develop.svn.wordpress.org/trunk@47602


git-svn-id: http://core.svn.wordpress.org/trunk@47377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-20 11:34:07 +00:00
Sergey Biryukov
694bec2071 External Libraries: Update getID3() to 1.9.19. 
Changelog: https://github.com/JamesHeinrich/getID3/compare/v1.9.18...v1.9.19

Props ayeshrajans, schlessera.
See #49945.
Built from https://develop.svn.wordpress.org/trunk@47601


git-svn-id: http://core.svn.wordpress.org/trunk@47376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-20 11:13:07 +00:00
Sergey Biryukov
71dea21c5f Users: Change "Your Profile" and "My Profile" links in admin menu and toolbar to just "Profile" for consistency. 
Props donmhico, bcworkz, seanchayes, mikeschroder, garrett-eclipse, akhileshsabharwal, ScottSmith, nacin, jenmylo, afercia, swissspidy, felix-edelmann, helen, melchoyce, karmatosed.
Fixes #26769.
Built from https://develop.svn.wordpress.org/trunk@47600


git-svn-id: http://core.svn.wordpress.org/trunk@47375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-20 08:39:06 +00:00
Sergey Biryukov
30a35a4806 Upload: Better align file input and buttons in plugin/theme upload form. 
Follow-up to [47271].

Props seedsca, piyushmca.
Fixes #49914.
Built from https://develop.svn.wordpress.org/trunk@47599


git-svn-id: http://core.svn.wordpress.org/trunk@47374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-19 09:47:08 +00:00
Sergey Biryukov
ee387b9181 Accessibility: Widgets: Prevent checkboxes in widget control forms from overlapping on smaller screens. 
Props jaz_on, milindmore22, passoniate, audrasjb, carriganvb, afercia, SergeyBiryukov.
Fixes #49228.
Built from https://develop.svn.wordpress.org/trunk@47598


git-svn-id: http://core.svn.wordpress.org/trunk@47373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-18 07:03:09 +00:00
Sergey Biryukov
61a2f62ffd Comments: Use comment instead of an empty string for the comment_type DB field value in comments table. 
This is the first step to bring support for custom comment types into WordPress.

Add a scheduled upgrade routine to update the type value for existing comments, in batches of 100 at a time.

Props imath, aaroncampbell, jeremyfelt, dshanske.
Fixes #49236.
Built from https://develop.svn.wordpress.org/trunk@47597


git-svn-id: http://core.svn.wordpress.org/trunk@47372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-17 19:35:06 +00:00
Sergey Biryukov
012b134b23 Coding Standards: Fix WPCS indentation issue in wp-admin/nav-menus.php. 
This was causing a `PEAR.Functions.FunctionCallSignature.Indent` error if PHP_CodeSniffer 3.5.3 or newer is installed locally, despite the task passing on Travis.

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47596


git-svn-id: http://core.svn.wordpress.org/trunk@47371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-17 18:55:09 +00:00
Sergey Biryukov
af1a737b48 Coding Standards: Fix WPCS indentation issue in wp-admin/includes/class-wp-links-list-table.php. 
This was causing a `Generic.WhiteSpace.ScopeIndent.IncorrectExact` error if PHP_CodeSniffer 3.4.1 or newer is installed locally, despite the task passing on Travis.

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47595


git-svn-id: http://core.svn.wordpress.org/trunk@47370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-17 18:31:07 +00:00
ianbelanger
cf9b35eccd Bundled Themes: Twenty Twenty fix typo in readme.txt. 
Fixed TikTok was misspelled as Tik Tok in the readme.txt.

Props Asif2BD.
Fixes #49932.
Built from https://develop.svn.wordpress.org/trunk@47594


git-svn-id: http://core.svn.wordpress.org/trunk@47369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-17 15:47:08 +00:00
Sergey Biryukov
fc7561ce11 Coding Standards: Format the markup of widget forms in a more consistent manner. 
See #49542.
Built from https://develop.svn.wordpress.org/trunk@47593


git-svn-id: http://core.svn.wordpress.org/trunk@47368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-17 09:38:07 +00:00
Sergey Biryukov
900cfc4816 Administration: Remove the smiley from overly happy "No activity yet!" message on Dashboard. 
Props francoist, karmatosed, ibdz, estelaris, nrqsnchz, Presskopp.
Fixes #48387.
Built from https://develop.svn.wordpress.org/trunk@47592


git-svn-id: http://core.svn.wordpress.org/trunk@47367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-17 07:57:10 +00:00
ianbelanger
d9c2537d87 Bundled Themes: Twenty Nineteen center and right-aligned heading accents appear broken. 
Fixes the center and right aligned heading accents so that they align with the text, instead of just staying left-aligned.

Props kjellr, melchoyce.
Fixes #49699.
Built from https://develop.svn.wordpress.org/trunk@47591


git-svn-id: http://core.svn.wordpress.org/trunk@47366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-16 19:47:10 +00:00
ianbelanger
c03b6040fe Bundled Themes: Twenty Twenty inline images in list blocks are not positioned correctly. 
Fixes the alignment of inline images in list blocks to match the way they look in the editor.

Props poena, mayankmajeji, JavierCasares.
Fixes #49793.
Built from https://develop.svn.wordpress.org/trunk@47590


git-svn-id: http://core.svn.wordpress.org/trunk@47365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-16 19:38:07 +00:00
ianbelanger
5116ed9ebb Bundled Themes: Twenty Twenty add TikTok to the social icon menu. 
This adds TikTok as an option in the social icon menu.

Props mislavjuric, poena, audrasjb.
Fixes #49893.
Built from https://develop.svn.wordpress.org/trunk@47589


git-svn-id: http://core.svn.wordpress.org/trunk@47364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-16 19:01:09 +00:00
Sergey Biryukov
4fbfbf5f61 Plugins: Add HTML ID attributes to plugin action links for easier targeting in browser-based testing. 
Props roytanck, shooper.
Fixes #49916.
Built from https://develop.svn.wordpress.org/trunk@47588


git-svn-id: http://core.svn.wordpress.org/trunk@47363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-16 17:02:08 +00:00
ianbelanger
b2f072b97e Bundled Themes: Twenty Nineteen editor style interferes with navigation menu block. 
Update editor styles to prepare for changes coming to the editor in 5.5. Currently the issue is only present when using the latest version of the Gutenberg plugin.

Props kjellr, Joen.
Fixes #49613.
Built from https://develop.svn.wordpress.org/trunk@47587


git-svn-id: http://core.svn.wordpress.org/trunk@47362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-16 14:56:16 +00:00
ianbelanger
90f5e0576b Bundled Themes: Twenty Nineteen decrease the font size for widget titles. 
Update styles to decrease the font size for widget titles.

Props kjellr, mukesh27.
Fixes #45865.
Built from https://develop.svn.wordpress.org/trunk@47586


git-svn-id: http://core.svn.wordpress.org/trunk@47361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-16 14:38:10 +00:00
Sergey Biryukov
92538d89ee Site Health: Detect an active PHP session as a possible reason for HTTP requests timing out. 
PHP sessions created by a `session_start()` function call may interfere with REST API and loopback requests.

An active session should be closed by `session_write_close()` before making any HTTP requests.

Props matthieumota, netweblogic, Clorith, afragen, vjik, SergeyBiryukov.
Fixes #47320.
Built from https://develop.svn.wordpress.org/trunk@47585


git-svn-id: http://core.svn.wordpress.org/trunk@47360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-16 08:20:09 +00:00
Sergey Biryukov
4e13efaf96 Code Modernization: Remove conditional use of stream_get_contents() PHP function. 
The function was introduced in PHP 5.0.0. Now that the minimum version of PHP required by WordPress is 5.6.20, these conditions are no longer needed.

Props jrf.
Fixes #48091.
Built from https://develop.svn.wordpress.org/trunk@47584


git-svn-id: http://core.svn.wordpress.org/trunk@47359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-15 11:54:08 +00:00
Sergey Biryukov
bb2c0198ab Comments: Clarify that "Comment Moderation" and "Comment Blocklist" options in Discussion Settings also apply to browser's user agent string for submitted comments. 
Props zodiac1978.
Fixes #49902.
Built from https://develop.svn.wordpress.org/trunk@47583


git-svn-id: http://core.svn.wordpress.org/trunk@47358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-15 06:40:05 +00:00
Dominik Schilling
2d04c2e5c8 Posts, Post Types: Pass the post object to the before_delete_post, delete_post, deleted_post, and after_delete_post actions. 
Props jadpm.
Fixes #30940.
Built from https://develop.svn.wordpress.org/trunk@47582


git-svn-id: http://core.svn.wordpress.org/trunk@47357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-14 19:26:07 +00:00
Sergey Biryukov
a4f6f2beae Mail: Make the check for empty post title in wp-mail.php more resilient. 
This addresses a regression in [47054], which caused posts sent via email to published with an empty title.

Props whyisjake, Otto42, MarkRH, MattyRob, mukesh27, afragen, pikamander2.
Fixes #49853.
Built from https://develop.svn.wordpress.org/trunk@47580


git-svn-id: http://core.svn.wordpress.org/trunk@47355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-14 11:32:06 +00:00
Sergey Biryukov
a21b8a91c6 Docs: Add a @since note for un-deprecated category_link and tag_link filters. 
Follow-up to [47576].

See #49759.
Built from https://develop.svn.wordpress.org/trunk@47578


git-svn-id: http://core.svn.wordpress.org/trunk@47353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-14 08:15:19 +00:00
whyisjake
0a714eb26f Taxonomy: Un-depracate category_link and tag_link filters. 
Depracating these filter might have been an accident, so let's restore.

Props SergeyBiryukov, audrasjb, peterwilsoncc.
Fixes #49759. 

Built from https://develop.svn.wordpress.org/trunk@47576


git-svn-id: http://core.svn.wordpress.org/trunk@47351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-14 00:33:09 +00:00
Sergey Biryukov
ae59482c80 Plugins: Simplify the logic of validate_plugin_requirements(), update documentation. 
This updates the function for consistency with `validate_theme_requirements()`.

Follow-up to [44978], [45546], [47573].

Fixes #43992.
Built from https://develop.svn.wordpress.org/trunk@47574


git-svn-id: http://core.svn.wordpress.org/trunk@47349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-13 15:31:05 +00:00
Sergey Biryukov
d341f20fb1 Themes: Block theme activation if it requires a higher version of PHP or WordPress. 
Introduce `validate_theme_requirements()` for validating a theme's WordPress and PHP version requirements.

Follow-up to [44978] and [45546] for plugins.

Props afragen, audrasjb, SergeyBiryukov.
See #43992.
Built from https://develop.svn.wordpress.org/trunk@47573


git-svn-id: http://core.svn.wordpress.org/trunk@47348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-13 15:28:11 +00:00
Sergey Biryukov
87b3b38242 Privacy: Add an indication when the Copy action in Privacy Policy Guide is complete. 
This adds a "Copied!" text near the "Copy this section to clipboard" button to provide direct feedback that the action was completed.

Props garrett-eclipse, nickylimjj, xkon, desrosj, birgire.
Fixes #44588.
Built from https://develop.svn.wordpress.org/trunk@47572


git-svn-id: http://core.svn.wordpress.org/trunk@47347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-12 14:26:11 +00:00
Sergey Biryukov
48225beffb Rewrite Rules: Use double quotes instead of backticks in .htaccess instructions about # BEGIN/END markers. 
Previously, the backticks resulted in extra markup being added when posted on support forums.

Props mayankmajeji, knutsp.
Fixes #49868.
Built from https://develop.svn.wordpress.org/trunk@47571


git-svn-id: http://core.svn.wordpress.org/trunk@47346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-11 15:09:11 +00:00
Sergey Biryukov
9f379bb930 Docs: Fix typo in WP_Upgrader::__construct() DocBlock. 
Props mattrad.
Fixes #49856.
Built from https://develop.svn.wordpress.org/trunk@47570


git-svn-id: http://core.svn.wordpress.org/trunk@47345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-10 09:48:17 +00:00
whyisjake
92636d716a Site Health instantiation prevents use of some hooks by plugins. 
As the WP_Site_Health class is instantiated prior to plugins being required and the `plugins_loaded` hook being fired, it prevents plugins from using the following hooks in the functions called by `maybe_create_scheduled_event()`.

Fixes #49824.
Props peterwilsoncc, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@47568


git-svn-id: http://core.svn.wordpress.org/trunk@47343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-10 03:57:08 +00:00
whyisjake
e42f45e667 Customize: Give the WordPress logo a white background for dark mode browsers. 
The favicon is transparent, which would normally look fine, but on a dark background it washes out.

Props DhrRob, audrasjb.
Fixes 49798.

Built from https://develop.svn.wordpress.org/trunk@47564


git-svn-id: http://core.svn.wordpress.org/trunk@47339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-10 02:50:07 +00:00
whyisjake
a1bf993892 Privacy: Support additional elements (table, ol, ul) in privacy policy guide new styling 
The privacy policy guide supports a lot of HTML, include rules for lists, and ensure proper styling for the rest.

Props garrett-eclipse. 
Fixes #49772.

Built from https://develop.svn.wordpress.org/trunk@47560


git-svn-id: http://core.svn.wordpress.org/trunk@47335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-09 22:34:05 +00:00
K. Adam White
951b1d89db REST API: Handle parameter types consistently within set_param(). 
A request has multiple parameter types, including "query" and "json." Updating a parameter could previously modify a key's value in the wrong parameter type, leading to confusing and self-contradictory response objects.

Props mnelson4, TimothyBlynJacobs, vagios, jnylen0.
Fixes #40838.

Built from https://develop.svn.wordpress.org/trunk@47559


git-svn-id: http://core.svn.wordpress.org/trunk@47334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-09 19:30:07 +00:00
Andrea Fercia
f927fdedb4 Accessibility: Fix the headings hierarchy on the Freedoms page. 
Props ryelle, afercia.
Fixes #49838.

Built from https://develop.svn.wordpress.org/trunk@47558


git-svn-id: http://core.svn.wordpress.org/trunk@47333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-09 16:09:11 +00:00
Sergey Biryukov
856e1a27b8 Coding Standards: Use strict type check for in_array() and array_search(). 
This addresses all the remaining `WordPress.PHP.StrictInArray.MissingTrueStrict` issues in core.

Includes minor code layout fixes for better readability.

Follow-up to [47550].

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47557


git-svn-id: http://core.svn.wordpress.org/trunk@47332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-09 15:43:10 +00:00
Mike Schroder
7097f6cef0 Tests: Pass API key to distributed test reporter. 
Pass environment variable for test reporter API key to
`docker-compose` so that it can authenticate and submit results
to the hosting distributed tests.

Props SergeyBiryukov, mikeschroder.
Fixes #49846.
Built from https://develop.svn.wordpress.org/trunk@47556


git-svn-id: http://core.svn.wordpress.org/trunk@47331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-09 06:08:10 +00:00
Sergey Biryukov
c18e44d6b1 Privacy: Make the deprecated wp_get_user_request_data() function available on front end. 
Previously, it was accidentally made available only in admin context.

Follow-up to [44606], [47245].

Props garrett-eclipse, johnjamesjacoby, r-a-y, Dono12.
Fixes #49802.
Built from https://develop.svn.wordpress.org/trunk@47555


git-svn-id: http://core.svn.wordpress.org/trunk@47330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-08 18:33:08 +00:00
Andrew Ozz
0e38f8ed26 Media: Enable lazy-loading of images by automatically adding the new loading="lazy" attribute to image tags on the front-end. 
- Introduces `wp_lazy_loading_enabled()`, `wp_filter_content_tags()`, `wp_img_tag_add_loading_attr()`, and `wp_img_tag_add_srcset_and_sizes_attr()` functions.
- Introduces `wp_lazy_loading_enabled`, `wp_img_tag_add_loading_attr`, and `wp_img_tag_add_srcset_and_sizes_attr` filters.

Props flixos90, addyosmani, mor10, swissspidy, pierlo, westonruter, spacedmonkey, mikeschroder, jonoaldersonwp, peterwilsoncc, narwen, jeffpaul, OptimizingMatters, futtta, mukeshpanchal27, azaozz.

Fixes #44427.
Built from https://develop.svn.wordpress.org/trunk@47554


git-svn-id: http://core.svn.wordpress.org/trunk@47329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-08 00:55:07 +00:00
Sergey Biryukov
195312ead2 Users: Pass the ID of the user that was logged out to the wp_logout action. 
Props donmhico, figureone, TimothyBlynJacobs, rebasaurus.
Fixes #49533.
Built from https://develop.svn.wordpress.org/trunk@47553


git-svn-id: http://core.svn.wordpress.org/trunk@47328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-07 16:14:10 +00:00
Sergey Biryukov
78e62aa3e4 Coding Standards: Whitelist date_default_timezone_set() usage in wp-settings.php. 
See #49542.
Built from https://develop.svn.wordpress.org/trunk@47552


git-svn-id: http://core.svn.wordpress.org/trunk@47327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-06 09:06:12 +00:00
Sergey Biryukov
57b7f0bc22 Coding Standards: Switch WordPress.PHP.YodaConditions.NotYoda back to error level. 
This was marked as a warning in [45665] until all the issues associated with the sniff are addressed, so that linting on Travis could run across the entire codebase.

With all the instances now addressed, this override is no longer needed.

Follow-up to [47054], [47218], [47219].

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47551


git-svn-id: http://core.svn.wordpress.org/trunk@47326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-05 03:21:06 +00:00
Sergey Biryukov
38676936ba Coding Standards: Use strict type check for in_array() and array_search() where strings are involved. 
This reduces the number of `WordPress.PHP.StrictInArray.MissingTrueStrict` issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47550


git-svn-id: http://core.svn.wordpress.org/trunk@47325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-05 03:02:11 +00:00
Andrew Ozz
10e3e44219 Media: Remove display: none; from the (visually hidden) <input type="file"> button used in Plupload to select files for uploading. Fixes selecting files in Edge <= 44 and iOS Safari. 
Props treecutter, johnbillion, pbiron, isabel_brison, Ipstenu, azaozz.
Fixes #49753 for trunk.
Built from https://develop.svn.wordpress.org/trunk@47549


git-svn-id: http://core.svn.wordpress.org/trunk@47324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-04 22:54:09 +00:00
Sergey Biryukov
9f481cdf7a Tests: Remove test_post_thumbnails_types_true(). 
The test incorrectly describes the behavior of `current_theme_supports( 'post-thumbnails' )` and only passes by accident.

Follow-up to [30148].

Fixes #49801.
Built from https://develop.svn.wordpress.org/trunk@47548


git-svn-id: http://core.svn.wordpress.org/trunk@47323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-04 00:27:06 +00:00
K. Adam White
51619c00a4 REST API: Fix revisions controller get_item permission check. 
r45812 incorrectly introduced a delete_post permissions check into the get_item method, breaking some plugins which requested revisions when generating previews.

Props sorenbronsted, yohannp, TimothyBlynJacobs.
Fixes #49645.

Built from https://develop.svn.wordpress.org/trunk@47547


git-svn-id: http://core.svn.wordpress.org/trunk@47322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-03 19:40:08 +00:00
Sergey Biryukov
441001f29f Docs: Add documentation for the $parent parameter of get_admin_page_parent(). 
Props subrataemfluence.
Fixes #45849.
Built from https://develop.svn.wordpress.org/trunk@47546


git-svn-id: http://core.svn.wordpress.org/trunk@47321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-03 17:23:11 +00:00
Sergey Biryukov
ca8463f4f4 Docs: Use third-person singular verbs for function descriptions in wp-includes/category-template.php, per the documentation standards. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@47545


git-svn-id: http://core.svn.wordpress.org/trunk@47320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-02 15:51:08 +00:00
Sergey Biryukov
4ef14fd7af Build/Test Tools: Remove a starting empty line from svn:ignore property on wp-includes. 
Follow-up to [47352].

See #48154.
Built from https://develop.svn.wordpress.org/trunk@47544


git-svn-id: http://core.svn.wordpress.org/trunk@47319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-01 13:45:09 +00:00
desrosj
64b3c852bf Bundled Themes: Bump version numbers and update changelogs in default themes for WordPress 5.4. 
Props ianbelanger, desrosj, SergeyBiryukov.
Fixes #49743.
Built from https://develop.svn.wordpress.org/trunk@47539


git-svn-id: http://core.svn.wordpress.org/trunk@47314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-31 19:11:07 +00:00
Sergey Biryukov
402193798e Twenty Nineteen: Update style-editor.css after [47327]. 
Props ianbelanger.
See #48526.
Built from https://develop.svn.wordpress.org/trunk@47537


git-svn-id: http://core.svn.wordpress.org/trunk@47312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-31 18:57:11 +00:00
Sergey Biryukov
116d909f58 Twenty Nineteen: Update style-rtl.css after [47339]. 
Props ianbelanger.
See #49410.
Built from https://develop.svn.wordpress.org/trunk@47536


git-svn-id: http://core.svn.wordpress.org/trunk@47311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-31 18:55:10 +00:00
Sergey Biryukov
042bf6dbd9 Administration: Make the height of dashboard widget headings consistent with that of post meta boxes on smaller screens. 
This also ensures that the toggle arrow for dashboard widgets is properly aligned.

Props chetan200891.
Fixes #49727.
Built from https://develop.svn.wordpress.org/trunk@47535


git-svn-id: http://core.svn.wordpress.org/trunk@47310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-31 02:52:07 +00:00
ianbelanger
2e7235f7ca Bundled Themes: Twenty Twenty Button block forces All Capital letters - revert [47531]. 
Reverts [47531] to add `text-transform: uppercase;` back to button blocks.

Props joyously.
Fixes #49710.
Built from https://develop.svn.wordpress.org/trunk@47534


git-svn-id: http://core.svn.wordpress.org/trunk@47309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-30 18:29:08 +00:00
Sergey Biryukov
e38a57db0c Help/About: Use CDN URLs for 5.4 About page header images. 
See #49295.
Built from https://develop.svn.wordpress.org/trunk@47532


git-svn-id: http://core.svn.wordpress.org/trunk@47307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-30 17:49:07 +00:00
ianbelanger
340216b5eb Bundled Themes: Twenty Twenty Button block forces All Capital letters. 
Removes `text-transform: uppercase;` from button blocks in order to give the user the option to have a button without All Capital letters.

Props mukesh27.
Fixes #49710.
Built from https://develop.svn.wordpress.org/trunk@47531


git-svn-id: http://core.svn.wordpress.org/trunk@47306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-30 15:20:07 +00:00
Sergey Biryukov
49d7b8c51f Filesystem API: Correct punctuation in request_filesystem_credentials() error message. 
Props mayankmajeji, kharisblank.
Fixes #49724.
Built from https://develop.svn.wordpress.org/trunk@47530


git-svn-id: http://core.svn.wordpress.org/trunk@47305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-30 01:32:07 +00:00
Sergey Biryukov
c83710ccee Site Health: Remove paragraph tag from the actions container in issue template. 
Most of the tests pass content that is already wrapped in a paragraph or list tags, thus producing nested paragraphs or invalid markup.

Additionally, don't output an empty `<div>` tag if the test does not provide any actions.

Props maxpertici, afercia.
Fixes #48948.
Built from https://develop.svn.wordpress.org/trunk@47529


git-svn-id: http://core.svn.wordpress.org/trunk@47304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-30 01:25:11 +00:00
Sergey Biryukov
764a1761aa Site Health: Correct markup in ::get_test_php_extensions() and ::get_test_background_updates() description. 
These tests output an unordered list, which doesn't need to be wrapped in a paragraph tag.

Additionally, pass an empty string as an `actions` parameter in `::get_test_php_default_timezone()`, for consistency with other tests.

Props afercia.
See #48948.
Built from https://develop.svn.wordpress.org/trunk@47528


git-svn-id: http://core.svn.wordpress.org/trunk@47303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-29 03:46:06 +00:00
Sergey Biryukov
d552e475fd Site Health: Add pretty links support information to debug data. 
Props valentinbora, afragen.
Fixes #49422.
Built from https://develop.svn.wordpress.org/trunk@47527


git-svn-id: http://core.svn.wordpress.org/trunk@47302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-28 21:20:06 +00:00
John Blackbourn
8f1eddef11 Comments: Ensure all elements in the array returned by get_comment_count() are integers. 
Previously elements would be a mixture of strings and integers depending on their numeric value.

Props progremzion, m.usama.masood

Fixes #48093
Built from https://develop.svn.wordpress.org/trunk@47526


git-svn-id: http://core.svn.wordpress.org/trunk@47301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-28 20:44:09 +00:00
Sergey Biryukov
ce2dea9ef6 Help/About: Improve accessibility of the 5.4 About page: 
* Remove vertical text and unnecessary italics.
* Update H1 headings on About, Credits, Freedoms, Privacy pages to be unique to each page.

Props sabernhardt, ryelle, melchoyce, karmatosed, audrasjb, afercia, davidbaumwald, SergeyBiryukov.
See #49295.
Built from https://develop.svn.wordpress.org/trunk@47521


git-svn-id: http://core.svn.wordpress.org/trunk@47296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-27 23:41:06 +00:00
Sergey Biryukov
a546a9c35c Coding Standards: Remove some extra tabs in wp-admin/user-new.php. 
Follow-up to [47516], [47519].

See #38665.
Built from https://develop.svn.wordpress.org/trunk@47520


git-svn-id: http://core.svn.wordpress.org/trunk@47295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-27 22:30:09 +00:00
Sergey Biryukov
ee1bf5a911 Coding Standards: Fix WPCS issues in [47516]. 
See #38665.
Built from https://develop.svn.wordpress.org/trunk@47519


git-svn-id: http://core.svn.wordpress.org/trunk@47294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-27 22:25:08 +00:00
jorgefilipecosta
0a2dad400d Block Editor: Update WordPress Packages WordPress 5.4 RC 5 Take 2. 
The following package versions were changed:
@wordpress/edit-post: 3.13.8 -> 3.13.9
Includes PR https://github.com/WordPress/gutenberg/pull/21220

Props aduth, mapk, ItsJonQ.
Fixes: #49717.
Built from https://develop.svn.wordpress.org/trunk@47517


git-svn-id: http://core.svn.wordpress.org/trunk@47292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-27 22:08:24 +00:00
John Blackbourn
41ae74f7b4 Users: Add a user language preference option to the "Add New User" form. 
This uses the same language selection control as the user editing screen and allows new users to be invited to a site in their own language.

Props barryceelen, johnbillion

Fixes #38665
Built from https://develop.svn.wordpress.org/trunk@47516


git-svn-id: http://core.svn.wordpress.org/trunk@47291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-27 21:58:05 +00:00
Sergey Biryukov
38e37b83df Site Health: Remove esc_url() used on "Debugging in WordPress" article URL in WP_Fatal_Error_Handler::display_default_error_template(). 
The function may not be available in some contexts, for example if a fatal error happens in `advanced-cache.php` drop-in.

Props rob006.
Fixes #49709.
Built from https://develop.svn.wordpress.org/trunk@47515


git-svn-id: http://core.svn.wordpress.org/trunk@47290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-27 18:22:06 +00:00
jorgefilipecosta
b9ef707d7d Block Editor: Update WordPress Packages WordPress 5.4 RC 5. 
The following package versions were changed:
@wordpress/annotations: 1.12.2 -> 1.12.3
@wordpress/block-directory: 1.5.6 -> 1.5.7
@wordpress/block-editor: 3.7.6 -> 3.7.7
@wordpress/block-library: 2.14.6 -> 2.14.7
@wordpress/blocks: 6.12.2 -> 6.12.3
@wordpress/components: 9.2.5 -> 9.2.6
@wordpress/core-data: 2.12.2 -> 2.12.3
@wordpress/edit-post: 3.13.7 -> 3.13.8
@wordpress/editor: 9.12.6 -> 9.12.7
@wordpress/format-library: 1.14.6 -> 1.14.7
@wordpress/list-reusable-blocks: 1.13.5 -> 1.13.6
@wordpress/nux: 3.12.5 -> 3.12.6
@wordpress/server-side-render: 1.8.5 -> 1.8.6
Description of editor changes included in the RC available at https://github.com/WordPress/gutenberg/pull/21210.

Props mcsf, aduth.
Fixes: #49716.
Built from https://develop.svn.wordpress.org/trunk@47513


git-svn-id: http://core.svn.wordpress.org/trunk@47288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-27 18:10:36 +00:00
Sergey Biryukov
f4f1184deb Build/Test Tools: Update QUnit and Sinon to the latest versions. 
Update JS tests per the QUnit 2.x Upgrade Guide.

Fixes #37117.
Built from https://develop.svn.wordpress.org/trunk@47512


git-svn-id: http://core.svn.wordpress.org/trunk@47287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-27 00:18:22 +00:00
K. Adam White
58d5aad2a3 REST API: Fix _fields filtering of registered rest fields. 
Use rest_is_field_included when determining which additional fields to include to permit filtering by nested field properties.

Props Dudo, kadamwhite, TimothyBlynJacobs.
Fixes #49648.

Built from https://develop.svn.wordpress.org/trunk@47511


git-svn-id: http://core.svn.wordpress.org/trunk@47286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-26 17:52:16 +00:00
John Blackbourn
7dbad241cb Themes: Always list broken themes even if the user cannot take a corresponding action within the admin area. 
This prevents broken themes being hidden when the `DISALLOW_FILE_MODS` constant is in use.

Props rebasaurus

Fixes #49268
Built from https://develop.svn.wordpress.org/trunk@47510


git-svn-id: http://core.svn.wordpress.org/trunk@47285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-26 17:50:15 +00:00
John Blackbourn
33d4f0573c Query: Introduce an action which gets fired when a 404 is triggered. 
Fixes #48061
Built from https://develop.svn.wordpress.org/trunk@47509


git-svn-id: http://core.svn.wordpress.org/trunk@47284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-26 17:43:07 +00:00
Sergey Biryukov
b9869da157 Coding Standards: Fix WPCS issues in wp-includes/class-wp-http-proxy.php. 
Props thrijith, mukesh27.
Fixes #46784.
Built from https://develop.svn.wordpress.org/trunk@47508


git-svn-id: http://core.svn.wordpress.org/trunk@47283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-26 07:20:10 +00:00
Sergey Biryukov
2b030a1647 Docs: Add documentation for WP_Comments_List_Table::floated_admin_avatar(). 
Props akbarhusen, ayeshrajans, Soean, ajayghaghretiya1, netweb, SergeyBiryukov.
Fixes #41491.
Built from https://develop.svn.wordpress.org/trunk@47507


git-svn-id: http://core.svn.wordpress.org/trunk@47282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-25 14:43:11 +00:00
noisysocks
b4e1e8f0d1 Comments: Fix title not updating when replying to a comment 
When replying to an existing comment, the comment form is moved to below the
existing comment with JS, but the form heading was not being updated. This
fixes the issue by introducing a new data-attribute to the reply link with the
correct heading string, and applying that string to the heading when the form
is moved.

Props isabel_brison, azaozz, peterwilsoncc.
Fixes #38009.

Built from https://develop.svn.wordpress.org/trunk@47506


git-svn-id: http://core.svn.wordpress.org/trunk@47281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-25 04:55:10 +00:00
Sergey Biryukov
55482506a3 Docs: Revert a type change for the $value parameter of WP_Dependencies::add_data() in [47170]. 
Although described as a string in several places, it's technically not limited to a particular type.

Props westonruter.
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47502


git-svn-id: http://core.svn.wordpress.org/trunk@47277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-24 20:56:09 +00:00
jorgefilipecosta
26cc999d64 Help/About: Fix a typo on the about page and fix a link. 
The text "on your" appeared two times. This commit fixes the issue and removes the duplication. It also updates the field guide permalink.

Props garrett-eclipse, ixkaito, karmatosed, SergeyBiryukov.
Built from https://develop.svn.wordpress.org/trunk@47500


git-svn-id: http://core.svn.wordpress.org/trunk@47275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-24 15:03:08 +00:00
Sergey Biryukov
c4a852af51 Docs: Update inline comment in Tests_DB::test_locale_floats(). 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@47498


git-svn-id: http://core.svn.wordpress.org/trunk@47273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-24 01:08:06 +00:00
Andrew Ozz
e3b3b5c1b7 Build/Test Tools: Introduce Install-changed. It keeps a hash of package.json and compares it when run. If it has any changes, it runs npm install. 
This keeps `node_modules` always updated and is useful not only when the packages have been updated, but also when the working copy has been "reverted" to an earlier revision.

Fixes #49594.
Built from https://develop.svn.wordpress.org/trunk@47497


git-svn-id: http://core.svn.wordpress.org/trunk@47272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-24 01:06:34 +00:00
Andrew Ozz
6ea351bed7 Build/Test Tools: Fix PHPUnit bootstrap to install WP from /build when tests are run with npm run test, grunt test, grunt then phpunit, etc. 
Fixes #49663.
Built from https://develop.svn.wordpress.org/trunk@47496


git-svn-id: http://core.svn.wordpress.org/trunk@47271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-24 00:20:06 +00:00
jorgefilipecosta
61ddc8d582 Block Editor: Update WordPress Packages WordPress 5.4 RC 4. 
The following package versions were changed:
@wordpress/annotations: 1.12.1 -> 1.12.2
@wordpress/block-directory: 1.5.5 -> 1.5.6
@wordpress/block-editor: 3.7.5 -> 3.7.6
@wordpress/block-library: 2.14.5 -> 2.14.6
@wordpress/blocks: 6.12.1 -> 6.12.2
@wordpress/components: 9.2.4 -> 9.2.5
@wordpress/core-data: 2.12.1 -> 2.12.2
@wordpress/data: 4.14.1 -> 4.14.2
@wordpress/data-controls: 1.8.1 -> 1.8.2
@wordpress/edit-post: 3.13.6 -> 3.13.7
@wordpress/editor: 9.12.5 -> 9.12.6
@wordpress/format-library: 1.14.5 -> 1.14.6
@wordpress/keyboard-shortcuts: 1.1.1 -> 1.1.2
@wordpress/list-reusable-blocks: 1.13.4 -> 1.13.5
@wordpress/notices: 2.0.1 -> 2.0.2
@wordpress/nux: 3.12.4 -> 3.12.5
@wordpress/rich-text: 3.12.1 -> 3.12.2
@wordpress/server-side-render: 1.8.4 -> 1.8.5
@wordpress/viewport: 2.13.1 -> 2.13.2
Description of editor changes included in the RC available at https://github.com/WordPress/gutenberg/pull/21083.

Props itsjonq, mcsf, aduth.
Fixes: #49688.
Built from https://develop.svn.wordpress.org/trunk@47495


git-svn-id: http://core.svn.wordpress.org/trunk@47270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-23 23:40:19 +00:00
Sergey Biryukov
3ec189f978 Docs: Add missing @since tags for WP_User_Request properties. 
Correct type for `$email`, `$confirmed_timestamp`, and `$completed_timestamp` properties.

Props pbiron, garrett-eclipse.
Fixes #49675.
Built from https://develop.svn.wordpress.org/trunk@47494


git-svn-id: http://core.svn.wordpress.org/trunk@47269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-23 20:20:09 +00:00
Sergey Biryukov
5ce4cc4930 Administration: Add / character to <img> tag in WP_Plugin_Install_List_Table::display_rows(). 
While this has no effect on void elements in HTML5, it fixes a minor inconsistency with the rest of core.

Props adnan.limdi, Soean.
Fixes #41904.
Built from https://develop.svn.wordpress.org/trunk@47493


git-svn-id: http://core.svn.wordpress.org/trunk@47268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-23 03:03:07 +00:00
Sergey Biryukov
248a115c2b Upgrade/Install: Return a more appropriate HTTP response status code (409 Conflict) if the wp-config.php file already exists. 
Props linyows, ocean90.
Fixes #42466.
Built from https://develop.svn.wordpress.org/trunk@47478


git-svn-id: http://core.svn.wordpress.org/trunk@47267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-21 15:44:15 +00:00
Sergey Biryukov
77e32cff47 Coding Standards: Fix WPCS issue in [47475]. 
See #49295.
Built from https://develop.svn.wordpress.org/trunk@47476


git-svn-id: http://core.svn.wordpress.org/trunk@47265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-20 17:33:07 +00:00
Sergey Biryukov
8f31a95982 Help/About: Add design for 5.4 About page. 
Props melchoyce, marybaum, marktimemedia, elmastudio, ryelle, karmatosed, audrasjb, afercia, francina, sabernhardt.
See #49295.
Built from https://develop.svn.wordpress.org/trunk@47475


git-svn-id: http://core.svn.wordpress.org/trunk@47264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-20 17:13:10 +00:00
Sergey Biryukov
2fd80efe13 Administration: Escape admin title on output after the admin_title filter runs, not before. 
Props lalitpendhare, adnan.limdi, subrataemfluence, andraganescu.
Fixes #41921.
Built from https://develop.svn.wordpress.org/trunk@47474


git-svn-id: http://core.svn.wordpress.org/trunk@47261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-20 02:20:08 +00:00
Sergey Biryukov
ed01dbb89b Privacy: Correct bottom padding for table of contents on Privacy Policy Guide on smaller screens. 
Props jagirbahesh, birgire, garrett-eclipse.
Fixes #49570.
Built from https://develop.svn.wordpress.org/trunk@47473


git-svn-id: http://core.svn.wordpress.org/trunk@47260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-19 20:45:10 +00:00
Sergey Biryukov
c6c8862b87 Post Formats: Pass post type to the disable_formats_dropdown filter in WP_Posts_List_Table::formats_dropdown(). 
Props MatheusFD, birgire.
Fixes #47959.
Built from https://develop.svn.wordpress.org/trunk@47472


git-svn-id: http://core.svn.wordpress.org/trunk@47259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-18 19:13:10 +00:00
Andrew Ozz
e94cd4e1a0 Build Tools: Use the new combinedOutputFile setting for the updated DependencyExtractionWebpackPlugin and output script-loader-packages.php directly in wp-includes/assets/. 
Props gziolo, azaozz.
See: #48154.
Built from https://develop.svn.wordpress.org/trunk@47471


git-svn-id: http://core.svn.wordpress.org/trunk@47258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-18 04:50:10 +00:00
Sergey Biryukov
dd12e83491 Docs: Correct the description of $hard parameter in flush_rewrite_rules(). 
Props david.binda.
Fixes #49660.
Built from https://develop.svn.wordpress.org/trunk@47468


git-svn-id: http://core.svn.wordpress.org/trunk@47255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-17 19:34:08 +00:00
jorgefilipecosta
7c8f8d776f Block Editor: Update WordPress Packages WordPress 5.4 RC 3. 
The following package versions were changed:
@wordpress/block-directory: 1.5.4 -> 1.5.5
@wordpress/block-editor: 3.7.4 -> 3.7.5
@wordpress/block-library: 2.14.4 -> 2.14.5
@wordpress/components: 9.2.3 -> 9.2.4
@wordpress/dependency-extraction-webpack-plugin: 2.3.0 -> 2.4.0
@wordpress/edit-post: 3.13.5 -> 3.13.6
@wordpress/editor: 9.12.4 -> 9.12.5
@wordpress/format-library: 1.14.4 -> 1.14.5
@wordpress/list-reusable-blocks: 1.13.3 -> 1.13.4
@wordpress/nux: 3.12.3 -> 3.12.4
@wordpress/server-side-render: 1.8.3 -> 1.8.4

Props aduth.
Fixes: #49657.
Built from https://develop.svn.wordpress.org/trunk@47462


git-svn-id: http://core.svn.wordpress.org/trunk@47249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-16 22:07:16 +00:00
John Blackbourn
7004afe4f4 Docs: Various docblock corrections and improvements. 
See #49572
Built from https://develop.svn.wordpress.org/trunk@47461


git-svn-id: http://core.svn.wordpress.org/trunk@47248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-16 18:40:07 +00:00
Sergey Biryukov
0a08229a9b Tests: Use PUPPETEER_SKIP_CHROMIUM_DOWNLOAD environment variable instead of config setting. 
This is more consistent with the similar approach in Gutenberg Travis setup.

Follow-up to [47449].

See #49621.
Built from https://develop.svn.wordpress.org/trunk@47459


git-svn-id: http://core.svn.wordpress.org/trunk@47246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-16 12:24:09 +00:00
Sergey Biryukov
25333cc670 Menus: When adding a label for special pages in wp_setup_nav_menu_item() strip all HTML tags, as the label is escaped on output. 
Follow-up to [47211], [47213].

Props stiofansisland.
Fixes #49374.
Built from https://develop.svn.wordpress.org/trunk@47458


git-svn-id: http://core.svn.wordpress.org/trunk@47245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-16 01:32:05 +00:00
Sergey Biryukov
73ef224e64 Administration: When editing a plugin or theme file, close any active PHP session. 
This prevents HTTP requests from timing out when attempting to connect back to the site.

Props bruandet, vjik, donmhico, SergeyBiryukov.
Fixes #43358.
Built from https://develop.svn.wordpress.org/trunk@47457


git-svn-id: http://core.svn.wordpress.org/trunk@47244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-15 19:45:07 +00:00
Sergey Biryukov
cf75b95197 Site Health: Run the first scheduled site health check a day after the initial site setup. 
This reduces the chance of displaying incorrect results due to running the check too early in first time setup scenarios.

Props Clorith, garrett-eclipse, roytanck, joostdevalk.
Fixes #49577.
Built from https://develop.svn.wordpress.org/trunk@47456


git-svn-id: http://core.svn.wordpress.org/trunk@47243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-14 16:36:07 +00:00
Sergey Biryukov
dacd7a55ea Toolbar: Move the logic for rendering the admin bar on wp_footer to wp_admin_bar_render(). 
Clarify in the function documentation that it is now called on `wp_body_open` action first, with `wp_footer` as a fallback.

Follow-up to [47221].

Fixes #47053.
Built from https://develop.svn.wordpress.org/trunk@47455


git-svn-id: http://core.svn.wordpress.org/trunk@47242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-14 16:01:08 +00:00
Sergey Biryukov
d5f942d7ba General: Trim the input data in maybe_unserialize(), for consistency with is_serialized(). 
Props pbearne, mikeschroder.
Fixes #36416.
Built from https://develop.svn.wordpress.org/trunk@47454


git-svn-id: http://core.svn.wordpress.org/trunk@47241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-13 21:13:08 +00:00
Sergey Biryukov
0dc46c0ba5 General: Move maybe_serialize() to a more appropriate place in the file, before maybe_unserialize(). 
Rename the `$original` parameter of `maybe_unserialize()` to `$data`, for consistency with other serialization functions.

See #36416.
Built from https://develop.svn.wordpress.org/trunk@47453


git-svn-id: http://core.svn.wordpress.org/trunk@47240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-13 21:07:06 +00:00
Sergey Biryukov
045d4face1 Tests: Extract is_serialized() test cases into data providers; reuse them for maybe_serialize() and maybe_unserialize() tests. 
Props pbearne, mikeschroder, SergeyBiryukov.
See #36416.
Built from https://develop.svn.wordpress.org/trunk@47452


git-svn-id: http://core.svn.wordpress.org/trunk@47239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-13 20:41:07 +00:00
Sergey Biryukov
c8cc78671b Database: Introduce wpdb::db_server_info() to retrieve full MySQL server information string as supplied by mysqli_get_server_info(). 
This complements `wpdb::db_version()`, which only returns a numeric version string and strips any additional information, e.g. vendor name.

Props clarinetlord, birgire, webaware, pento.
Fixes #40037. See #27703.
Built from https://develop.svn.wordpress.org/trunk@47451


git-svn-id: http://core.svn.wordpress.org/trunk@47238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-12 15:55:07 +00:00
TimothyBlynJacobs
1367b1175f REST API: Introduce "hex-color" JSON Schema format. 
Props spacedmonkey, chrisvanpatten.
Fixes #49270.

Built from https://develop.svn.wordpress.org/trunk@47450


git-svn-id: http://core.svn.wordpress.org/trunk@47237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-12 02:42:08 +00:00
Sergey Biryukov
bcb8ee6dcf Tests: Download Chromium for e2e tests only. 
This reduces the chance of random failures due to network timeouts and avoids the overhead of unnecessarily downloading ~120 MB for PHP or JS tests.

Fixes #49621.
Built from https://develop.svn.wordpress.org/trunk@47449


git-svn-id: http://core.svn.wordpress.org/trunk@47236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-11 02:03:11 +00:00
Peter Wilson
a88ac4f003 Media: Introduce preflight filter to wp_delete_attachment(). 
Introduces the filter `pre_delete_attachment` to allow developers to prevent or modify the deletion of attachments. This improves consistency with `wp_delete_post()` and `wp_trash_post()`.

Props joemcgill, peterwilsoncc.
Fixes #49597.

Built from https://develop.svn.wordpress.org/trunk@47448


git-svn-id: http://core.svn.wordpress.org/trunk@47235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-10 22:48:07 +00:00
Sergey Biryukov
9aa864f1a7 Bundled Themes: Update calendar widget styles for 5.4 markup to fix the alignment of a single month link. 
Follow-up to [47405].

Props sabernhardt.
Reviewed by ianbelanger, SergeyBiryukov.
Fixes #49549.
Built from https://develop.svn.wordpress.org/trunk@47444


git-svn-id: http://core.svn.wordpress.org/trunk@47231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-10 20:53:06 +00:00
Sergey Biryukov
70def7fc4a Help/About: Use consistent vertical whitespace between sections on Freedoms page. 
Props chetan200891.
Fixes #49619.
Built from https://develop.svn.wordpress.org/trunk@47443


git-svn-id: http://core.svn.wordpress.org/trunk@47230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-10 20:39:16 +00:00
jorgefilipecosta
da43022d3f Block Editor: Update WordPress Packages WordPress 5.4 RC 2. 
The following package versions were changed:
@wordpress/block-directory: 1.5.3 -> 1.5.4
@wordpress/block-editor: 3.7.3 -> 3.7.4
@wordpress/block-library: 2.14.3 -> 2.14.4
@wordpress/edit-post: 3.13.4 -> 3.13.5
@wordpress/editor: 9.12.3 -> 9.12.4
@wordpress/format-library: 1.14.3 -> 1.14.4

Props aduth, gziolo, mapk.
Fixes: #49611.
Built from https://develop.svn.wordpress.org/trunk@47441


git-svn-id: http://core.svn.wordpress.org/trunk@47228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-10 14:53:18 +00:00
ianbelanger
4c1b25b5cc Bundled Themes: Twenty Twenty content font CSS selector is too important - updated. 
This adds more selectors for headings, tables, addresses, cite, figcaption, file and caption blocks to make the font-family match as before [47133].

Props alexandreb3, SergeyBiryukov.
Fixes #49318.
Built from https://develop.svn.wordpress.org/trunk@47439


git-svn-id: http://core.svn.wordpress.org/trunk@47226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-09 19:48:07 +00:00
Sergey Biryukov
d8a0b6ef2c Help/About: Update and correct some strings for 5.4 About page. 
Props garrett-eclipse, Ipstenu, ocean90, tobifjellner, la-geek.
Reviewed by ocean90, SergeyBiryukov.
See #49295.
Built from https://develop.svn.wordpress.org/trunk@47436


git-svn-id: http://core.svn.wordpress.org/trunk@47223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-09 00:11:04 +00:00
Sergey Biryukov
9448f5c95e Themes: Prevent tags in Theme Details modal from being partially hidden behind action buttons on smaller screens. 
Props sagarjadhav, valentinbora.
Fixes #31783.
Built from https://develop.svn.wordpress.org/trunk@47435


git-svn-id: http://core.svn.wordpress.org/trunk@47222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-08 01:52:05 +00:00
Sergey Biryukov
cb5308b0ab Administration: Add missing description for "Page title" element of the admin menu array. 
Props ajoah, valentinbora, kaitlin414.
Fixes #42911.
Built from https://develop.svn.wordpress.org/trunk@47434


git-svn-id: http://core.svn.wordpress.org/trunk@47221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-08 00:18:05 +00:00
Sergey Biryukov
9fbd842eb2 Customize: Ensure color picker's Clear button is aligned properly. 
Props Cybr.
Fixes #49543.
Built from https://develop.svn.wordpress.org/trunk@47433


git-svn-id: http://core.svn.wordpress.org/trunk@47220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-07 01:13:06 +00:00
Sergey Biryukov
d6178e1dcf REST API: Fix typo in disable-custom-gradients theme feature description. 
Props Ipstenu, tobifjellner, pixelverbieger.
Reviewed by ocean90, johnbillion, SergeyBiryukov.
Fixes #49585.
Built from https://develop.svn.wordpress.org/trunk@47432


git-svn-id: http://core.svn.wordpress.org/trunk@47219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-06 00:17:05 +00:00
Sergey Biryukov
6b1e845fca Tests: Remove unnecessary use of wpdb_exposed_methods_for_testing in test_utf8mb3_post_saves_with_emoji(). 
Props clarinetlord.
Fixes #39998.
Built from https://develop.svn.wordpress.org/trunk@47431


git-svn-id: http://core.svn.wordpress.org/trunk@47218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-05 11:55:05 +00:00
Sergey Biryukov
4b64d587a5 General: Ensure get_tag_regex() always returns a string, to match the documented value. 
Props subrataemfluence.
Fixes #45643.
Built from https://develop.svn.wordpress.org/trunk@47430


git-svn-id: http://core.svn.wordpress.org/trunk@47217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-04 12:05:05 +00:00
Sergey Biryukov
eea1fd30c2 General: Correct the default value of the $defaults parameter in wp_parse_args() to match the documented type. 
Props subrataemfluence.
See #45643.
Built from https://develop.svn.wordpress.org/trunk@47429


git-svn-id: http://core.svn.wordpress.org/trunk@47216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-04 12:00:06 +00:00
Sergey Biryukov
4a00ea1127 Docs: Reorder @throws tags in WP_Customize_Nav_Menu_Setting and WP_Customize_Nav_Menu_Item_Setting for consistency with WP_Customize_Custom_CSS_Setting. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@47428


git-svn-id: http://core.svn.wordpress.org/trunk@47215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-04 11:36:06 +00:00
Sergey Biryukov
57e91eb89a Docs: Add missing @throws tag to _wp_json_sanity_check() DocBlock. 
Props subrataemfluence.
See #45643.
Built from https://develop.svn.wordpress.org/trunk@47427


git-svn-id: http://core.svn.wordpress.org/trunk@47214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-04 11:34:08 +00:00
Peter Wilson
8483056ea1 Trunk is now 5.5 alpha 
Built from https://develop.svn.wordpress.org/trunk@47426


git-svn-id: http://core.svn.wordpress.org/trunk@47213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-04 01:20:11 +00:00
jorgefilipecosta
3227238b36 Post WordPress 5.4 RC 1 version bump. 
Built from https://develop.svn.wordpress.org/trunk@47424


git-svn-id: http://core.svn.wordpress.org/trunk@47211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 22:02:05 +00:00
jorgefilipecosta
4510afa73e WordPress 5.4 RC 1. 
Built from https://develop.svn.wordpress.org/trunk@47423


git-svn-id: http://core.svn.wordpress.org/trunk@47210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 21:43:06 +00:00
Sergey Biryukov
293bc81bf6 Help/About: Add strings for 5.4 About page. 
Props elmastudio, chanthaboune, francina, marybaum, audrasjb.
See #49295.
Built from https://develop.svn.wordpress.org/trunk@47422


git-svn-id: http://core.svn.wordpress.org/trunk@47209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 21:22:07 +00:00
jorgefilipecosta
86bafc002d Editor: Update WordPress packages to make editor full-screen by default. 
The following package versions were changed:
@wordpress/e2e-test-utils: 4.3.0 -> 4.3.1
@wordpress/edit-post: 3.13.3 -> 3.13.4
This commit update allows the following PR to be part of trunk https://github.com/WordPress/gutenberg/pull/20611.

Props youknowriad, mcsf, mapk.
Fixes: #49574.
Built from https://develop.svn.wordpress.org/trunk@47421


git-svn-id: http://core.svn.wordpress.org/trunk@47208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 20:45:08 +00:00
Sergey Biryukov
18e3aa433c Privacy: Prevent unexpected scrolling when clicking the "Copy this section to clipboard" button on Privacy Policy Guide screen. 
Props garrett-eclipse, birgire, davidbaumwald, pbiron.
Fixes #49540.
Built from https://develop.svn.wordpress.org/trunk@47420


git-svn-id: http://core.svn.wordpress.org/trunk@47207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 17:51:05 +00:00
Sergey Biryukov
c30fd0b54d Media: Improve the appearance of image editor on small and medium screens. 
This prevents the main area of Edit Media screen from being pushed down too far.

Props sabernhardt, afercia, fierevere, sathyapulse, mikeschroder, johnbillion.
Fixes #48780. See #47136.
Built from https://develop.svn.wordpress.org/trunk@47418


git-svn-id: http://core.svn.wordpress.org/trunk@47205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 17:21:05 +00:00
jorgefilipecosta
cf40905ada Scripts: Use core-js url as polyfill for window.URL. 
URL polyfill from the polyfill-library library is not spec-conformant, in a way which negatively impacts its usability for pending revisions to the block editor. Specifically, there were revisions to the implementation of the wp-url script to detect URL validity by relying on thrown errors from the URL constructor, but this specific behavior is not implemented in this version of the polyfill.
There was another issue in r47238, which is that the test used to check whether the polyfill should be included is not accurate. This commit uses a different check and fixes the issue.

Props aduth.
Fixes: #49360.
Built from https://develop.svn.wordpress.org/trunk@47416


git-svn-id: http://core.svn.wordpress.org/trunk@47203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 16:55:07 +00:00
Sergey Biryukov
62ef2d6719 Site Health: Fix typo in Site Health Status dashboard widget. 
Follow-up to [47063], [47413].

Props Clorith, dlh.
See #49562.
Built from https://develop.svn.wordpress.org/trunk@47415


git-svn-id: http://core.svn.wordpress.org/trunk@47202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 12:22:07 +00:00
Sergey Biryukov
a9479f31d1 Docs: Correct formatting of some DocBlocks in Plugin_Upgrader and Theme_Upgrader per the documentation standards. 
See #49400.
Built from https://develop.svn.wordpress.org/trunk@47414


git-svn-id: http://core.svn.wordpress.org/trunk@47201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 11:39:08 +00:00
Sergey Biryukov
ab854ce518 Site Health: Improve the strings in Site Health Status dashboard widget. 
Follow-up to [47063].

Props dlh.
Fixes #49562.
Built from https://develop.svn.wordpress.org/trunk@47413


git-svn-id: http://core.svn.wordpress.org/trunk@47200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 11:21:07 +00:00
John Blackbourn
24567bf775 Privacy: Fix the URLs and legacy redirects for the personal data export and erasure screens. 
Props Jurgen Oldenburg, garrett-eclipse

Fixes #49476
Built from https://develop.svn.wordpress.org/trunk@47412


git-svn-id: http://core.svn.wordpress.org/trunk@47199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 00:50:06 +00:00
John Blackbourn
e12cca1ce8 Privacy: Reintroduce consistency to the styling of suggested privacy text from core and plugins. 
Props garrett-eclipse

Fixes #49282
Built from https://develop.svn.wordpress.org/trunk@47411


git-svn-id: http://core.svn.wordpress.org/trunk@47198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 00:42:06 +00:00
John Blackbourn
da52485cf1 Editor: Revert a fix for incorrect usage of ID attributes on custom fields. 
This reverts [47222] due to compatibility issues with plugins which are using the `#poststuff` selector.

See #46964
Built from https://develop.svn.wordpress.org/trunk@47410


git-svn-id: http://core.svn.wordpress.org/trunk@47197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 00:37:06 +00:00
John Blackbourn
9860470360 Upgrade/Install: Improved inline docs for the plugin and theme updater maintenance mode functionality. 
Props bookdude13

See #49400
Built from https://develop.svn.wordpress.org/trunk@47409


git-svn-id: http://core.svn.wordpress.org/trunk@47196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-03 00:29:06 +00:00
jorgefilipecosta
cc17fee089 Block Editor: Update WordPress Packages WordPress 5.4 RC 1. 
The following package versions were changed:
@wordpress/annotations: 1.12.0 -> 1.12.1
@wordpress/block-directory: 1.5.2 -> 1.5.3
@wordpress/block-editor: 3.7.2 -> 3.7.3
@wordpress/block-library: 2.14.2 -> 2.14.3
@wordpress/blocks: 6.12.0 -> 6.12.1
@wordpress/components: 9.2.2 -> 9.2.3
@wordpress/core-data: 2.12.0 -> 2.12.1
@wordpress/data: 4.14.0 -> 4.14.1
@wordpress/data-controls: 1.8.0 -> 1.8.1
@wordpress/edit-post: 3.13.2 -> 3.13.3
@wordpress/editor: 9.12.2 -> 9.12.3
@wordpress/format-library: 1.14.2 -> 1.14.3
@wordpress/keyboard-shortcuts: 1.1.0 -> 1.1.1
@wordpress/list-reusable-blocks: 1.13.2 -> 1.13.3
@wordpress/notices: 2.0.0 -> 2.0.1
@wordpress/nux: 3.12.2 -> 3.12.3
@wordpress/priority-queue: 1.5.0 -> 1.5.1
@wordpress/rich-text: 3.12.0 -> 3.12.1
@wordpress/server-side-render: 1.8.2 -> 1.8.3
@wordpress/viewport: 2.13.0 -> 2.13.1

Props aduth.
Fixes: #49567.
Built from https://develop.svn.wordpress.org/trunk@47408


git-svn-id: http://core.svn.wordpress.org/trunk@47195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-02 23:21:15 +00:00
Andrew Ozz
aa8d4257ea Build Tools: Exclude the src/wp-includes/assets/ directory from copying when building. Its content is generated by Webpack and copied in another task. 
See #48154.
Built from https://develop.svn.wordpress.org/trunk@47407


git-svn-id: http://core.svn.wordpress.org/trunk@47194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-02 19:10:06 +00:00
John Blackbourn
aed09845b2 Feeds: Remove an unreachable condition when generating archive feed links. 
Props donmhico, pbiron

Fixes #48427
Built from https://develop.svn.wordpress.org/trunk@47406


git-svn-id: http://core.svn.wordpress.org/trunk@47193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-02 18:52:04 +00:00
ianbelanger
27a52dec3e Bundled Themes: Update calendar widget styles for 5.4 markup. 
Fixes the alignment of month links in the calendar widget with the changes in version 5.4 for all Bundled Themes, except Twenty Thirteen, which was already fixed in #49546.

Props sabernhardt.
Fixes #49549.
Built from https://develop.svn.wordpress.org/trunk@47405


git-svn-id: http://core.svn.wordpress.org/trunk@47192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-02 16:55:08 +00:00
Sergey Biryukov
26e1072d65 Build/Test Tools: Bump devDependencies for WordPress 5.4. 
Props ayeshrajans, garrett-eclipse.
Fixes #49547.
Built from https://develop.svn.wordpress.org/trunk@47404


git-svn-id: http://core.svn.wordpress.org/trunk@47191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-02 01:54:13 +00:00
Sergey Biryukov
b193d0a34b Tests: Add a unit test to ensure the "Supported Versions" section of GitHub Security Policy always includes the latest stable branch. 
See #48667, #48521.
Built from https://develop.svn.wordpress.org/trunk@47403


git-svn-id: http://core.svn.wordpress.org/trunk@47190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-02 01:13:03 +00:00
Sergey Biryukov
e041a3a8f3 Docs: Use more specific type in parameter descriptions for is_page(), is_single(), is_singular(), and their WP_Query counterpart methods. 
Props marekdedic, shaharia.azam, shaampk1.
Fixes #48354. See #48303.
Built from https://develop.svn.wordpress.org/trunk@47402


git-svn-id: http://core.svn.wordpress.org/trunk@47189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-01 17:29:06 +00:00
Sergey Biryukov
abce2d8d6c Docs: Synchronize parameter descriptions for conditional tags with their WP_Query counterpart methods. 
See #48354, #48303.
Built from https://develop.svn.wordpress.org/trunk@47401


git-svn-id: http://core.svn.wordpress.org/trunk@47188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-01 17:21:06 +00:00
Sergey Biryukov
f82fd2c436 Docs: Use more specific type in parameter description for wp_unslash(). 
Props marekdedic.
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47400


git-svn-id: http://core.svn.wordpress.org/trunk@47187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-01 16:26:05 +00:00
Sergey Biryukov
7ca7727ec0 Docs: Use more specific type in description for _WP_Dependency::$deps. 
Props marekdedic.
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47399


git-svn-id: http://core.svn.wordpress.org/trunk@47186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-01 16:24:04 +00:00
John Blackbourn
251d77e1a1 Docs: Miscellaneous docs fixes and improvements. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47398


git-svn-id: http://core.svn.wordpress.org/trunk@47185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-01 10:40:07 +00:00
John Blackbourn
056dad9c2c Docs: Use more specific types in parameter descriptions in place of mixed. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47397


git-svn-id: http://core.svn.wordpress.org/trunk@47184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-01 10:38:07 +00:00
John Blackbourn
bf8c4ee5c6 Docs: Correct the parameter documentation of the request_filesystem_credentials filter. 
See #48303
Built from https://develop.svn.wordpress.org/trunk@47396


git-svn-id: http://core.svn.wordpress.org/trunk@47183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-03-01 10:33:04 +00:00
Sergey Biryukov
fcff974c33 Privacy: Make the progress indicator for export and erasure visible even if not hovered over. 
Follow-up to [47246].

Props pbiron, garrett-eclipse.
Fixes #44264.
Built from https://develop.svn.wordpress.org/trunk@47395


git-svn-id: http://core.svn.wordpress.org/trunk@47182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-29 23:45:07 +00:00
John Blackbourn
46674e2367 Docs: Correct and improve the docs for some media related functions. 
See #48303
Built from https://develop.svn.wordpress.org/trunk@47394


git-svn-id: http://core.svn.wordpress.org/trunk@47181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-29 16:49:07 +00:00
ianbelanger
7f26b262b2 Bundled Themes: Twenty Twenty searchform.php error. 
Fixes phpcs error in the searchform.php file. The variables in this file were not prefixed correctly.

Props fahimmurshed.
Fixes #49523.
Built from https://develop.svn.wordpress.org/trunk@47393


git-svn-id: http://core.svn.wordpress.org/trunk@47180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-28 20:56:06 +00:00
ianbelanger
3bfa7b9ef9 Bundled Themes: Twenty Thirteen update calendar widget styles for 5.4 markup. 
Fixes the alignment of month links in the calendar widget with the changes in version 5.4

Props sabernhardt.
Fixes #49546.
Built from https://develop.svn.wordpress.org/trunk@47392


git-svn-id: http://core.svn.wordpress.org/trunk@47179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-28 20:07:07 +00:00
Sergey Biryukov
cbe5f9963a Docs: Improve documentation for WP_REST_Attachments_Controller. 
This adds a missing DocBlock for `::register_routes()` and parameter descriptions for `::post_process_item()`.

Includes minor documenation fixes in other REST API classes for consistency.

Props dkarfa, mukesh27, SergeyBiryukov.
Fixes #48841.
Built from https://develop.svn.wordpress.org/trunk@47391


git-svn-id: http://core.svn.wordpress.org/trunk@47178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-28 12:31:08 +00:00
Sergey Biryukov
eb524c0b38 Docs: Improve documentation for various metadata functions. 
This adds a more specific description for accepted object types: `post`, `comment`, `term`, `user`, or any other object type with an associated meta table.

Props sheparddw, kraftbj, DrewAPicture, SergeyBiryukov.
Fixes #45464.
Built from https://develop.svn.wordpress.org/trunk@47390


git-svn-id: http://core.svn.wordpress.org/trunk@47177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-28 12:14:08 +00:00
Sergey Biryukov
32be7d6460 Coding Standards: Update PHPCS Composer plugin to v0.6.0. 
Release log: https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases/tag/v0.6.0

Props jrf.
See #49222.
Built from https://develop.svn.wordpress.org/trunk@47389


git-svn-id: http://core.svn.wordpress.org/trunk@47176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-28 01:40:05 +00:00
Sergey Biryukov
19268546a5 Twenty Twenty: Replace quotation marks in starter content with HTML entities. 
Props fahimmurshed.
Fixes #49534.
Built from https://develop.svn.wordpress.org/trunk@47388


git-svn-id: http://core.svn.wordpress.org/trunk@47175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-27 22:00:07 +00:00
Sergey Biryukov
50afd0aa1b Docs: Add a reference to WP_Customize_Panel::__construct() for information on accepted arguments in WP_Customize_Manager::add_panel(). 
Synchronize the documentation between two places, use `WP_Customize_Panel::__construct()` as the canonical source.

Props iaaxpage, marekdedic.
Fixes #48344.
Built from https://develop.svn.wordpress.org/trunk@47387


git-svn-id: http://core.svn.wordpress.org/trunk@47174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-27 20:36:07 +00:00
Sergey Biryukov
9043b9833f Docs: Add a reference to WP_Customize_Section::__construct() for information on accepted arguments in WP_Customize_Manager::add_section(). 
Synchronize the documentation between two places, use `WP_Customize_Section::__construct()` as the canonical source.

Props amolv, marekdedic.
Fixes #48346.
Built from https://develop.svn.wordpress.org/trunk@47386


git-svn-id: http://core.svn.wordpress.org/trunk@47173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-27 20:29:06 +00:00
Sergey Biryukov
569319f553 Docs: Clarify the type of theme_supports argument in various Customizer classes. 
Props marekdedic.
See #48347.
Built from https://develop.svn.wordpress.org/trunk@47385


git-svn-id: http://core.svn.wordpress.org/trunk@47172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-27 20:23:06 +00:00
Sergey Biryukov
8c5a8f1811 Docs: Add a reference to WP_Customize_Setting::__construct() for information on accepted arguments in WP_Customize_Manager::add_setting(). 
Synchronize the documentation between two places, use `WP_Customize_Setting::__construct()` as the canonical source.

Props tmanoilov, marekdedic.
Fixes #48347.
Built from https://develop.svn.wordpress.org/trunk@47384


git-svn-id: http://core.svn.wordpress.org/trunk@47171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-27 20:09:06 +00:00
Sergey Biryukov
ac9b6fcef8 Docs: Use a consistent description for the $manager parameter in various Customizer class constructions. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47383


git-svn-id: http://core.svn.wordpress.org/trunk@47170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-26 15:33:05 +00:00
Sergey Biryukov
3d75b5bac5 Docs: Add a @see reference to WP_Customize_Control::__construct() in child class constructors. 
Follow-up to [47363], [47364].

See #48343, #48348.
Built from https://develop.svn.wordpress.org/trunk@47382


git-svn-id: http://core.svn.wordpress.org/trunk@47169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-26 13:30:08 +00:00
Sergey Biryukov
9bb8831642 Build/Test Tools: Remove redundant Tests_Post_Types::register_post_type() helper method, use register_post_type() directly. 
Props gh640, varunshanbhag.
Fixes #49365.
Built from https://develop.svn.wordpress.org/trunk@47381


git-svn-id: http://core.svn.wordpress.org/trunk@47168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-26 13:18:07 +00:00
Andrew Ozz
c2bea683a2 Build Tools: Do not delete the (now committed) script-loader-packages.php file when running clean:js and copy it to /build. Fixes cases when running grunt watch or -dev where that file may be deleted and not recreated. 
See #48154.
Built from https://develop.svn.wordpress.org/trunk@47380


git-svn-id: http://core.svn.wordpress.org/trunk@47167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-26 05:15:09 +00:00
jorgefilipecosta
218cd5f4c2 Post WordPress 5.4 Beta 3 version bump. 
Built from https://develop.svn.wordpress.org/trunk@47379


git-svn-id: http://core.svn.wordpress.org/trunk@47166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 22:13:08 +00:00
jorgefilipecosta
3c8112e912 WordPress 5.4 Beta 3. 
Built from https://develop.svn.wordpress.org/trunk@47378


git-svn-id: http://core.svn.wordpress.org/trunk@47165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 21:56:07 +00:00
Sergey Biryukov
3adea27d1c Block Editor: Update wp-includes/assets/script-loader-packages.php. 
Follow-up to [47352], [47354].

Props aduth, ocean90, garrett-eclipse.
Fixes #49506.
Built from https://develop.svn.wordpress.org/trunk@47377


git-svn-id: http://core.svn.wordpress.org/trunk@47164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 21:45:06 +00:00
Sergey Biryukov
ab0cf0aa51 Privacy: Switch buttons in Next Steps column of privacy request tables to break-word for better legibility on various screen sizes. 
Props garrett-eclipse, afercia, nrqsnchz.
Fixes #46304.
Built from https://develop.svn.wordpress.org/trunk@47376


git-svn-id: http://core.svn.wordpress.org/trunk@47163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 21:01:06 +00:00
Sergey Biryukov
8136532954 Accessibility: Media: Hide the invisible "file upload button" on media views from assistive technologies. 
The button is visually hidden, but was announced by screen readers in workflows unrelated to file uploading, leading to confusion.

Props afercia, audrasjb, azaozz.
Fixes #47611.
Built from https://develop.svn.wordpress.org/trunk@47375


git-svn-id: http://core.svn.wordpress.org/trunk@47162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 20:44:06 +00:00
Sergey Biryukov
1a9b7f8737 General: Introduce HTML classes in get_calendar() for easier CSS targeting: 
* `.wp-calendar-table` for the `<table>` element.
* `.wp-calendar-nav` for the navigation wrapper.
* `.wp-calendar-nav-prev` for the previous month link.
* `.wp-calendar-nav-next` for the next month link.

Replace `#prev` and `#next` HTML IDs with `.wp-calendar-nav-prev` and `.wp-calendar-nav-next` classes.

Props sabernhardt, BackuPs, audrasjb, jorbin.
Fixes #39763.
Built from https://develop.svn.wordpress.org/trunk@47374


git-svn-id: http://core.svn.wordpress.org/trunk@47161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 20:30:07 +00:00
Sergey Biryukov
153eb7537e Docs: In update_option(), remove an inaccurate statement about the $autoload value for new options. 
If the option does not exist, it will be created with whatever was passed to the `$autoload` parameter, `'yes'` being only the default value.

Props leogermani.
Fixes #48357.
Built from https://develop.svn.wordpress.org/trunk@47373


git-svn-id: http://core.svn.wordpress.org/trunk@47160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 20:08:07 +00:00
Sergey Biryukov
3a333ef030 Coding Standards: Use strict comparison for normalize_whitespace() checks when comparing revisions or autosaves. 
Props dkarfa, itowhid06, TimothyBlynJacobs.
Fixes #47965.
Built from https://develop.svn.wordpress.org/trunk@47372


git-svn-id: http://core.svn.wordpress.org/trunk@47159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 19:35:09 +00:00
Sergey Biryukov
8b0a0c44aa Widgets: Create a unique HTML ID for the <ul> element of Recent Comments widget if more than one instance is displayed on the page. 
Props peterwilsoncc, audrasjb, birgire, justinahinon, mbrailer, desrosj.
Fixes #46747.
Built from https://develop.svn.wordpress.org/trunk@47371


git-svn-id: http://core.svn.wordpress.org/trunk@47158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 19:29:06 +00:00
Sergey Biryukov
00f110740b Bootstrap/Load: In wp_magic_quotes(), revert the type change to string for REQUEST_TIME and REQUEST_TIME_FLOAT values, which should retain their proper type. 
Among other things, this preserves compatibility of WP with PHPUnit Code Coverage generation.

Props jrf, Veraxus, Rarst.
See #48605.
Built from https://develop.svn.wordpress.org/trunk@47370


git-svn-id: http://core.svn.wordpress.org/trunk@47157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 18:33:06 +00:00
Sergey Biryukov
1e81c20ff5 Docs: In wp_insert_user(), correct @type for rich_editing, syntax_highlighting, comment_shortcuts, and show_admin_bar_front arguments. 
Follow-up to [47368].

See #49087.
Built from https://develop.svn.wordpress.org/trunk@47369


git-svn-id: http://core.svn.wordpress.org/trunk@47156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 18:20:06 +00:00
Sergey Biryukov
2cd5292def Docs: In wp_insert_user(), clarify that rich_editing, syntax_highlighting, comment_shortcuts, and show_admin_bar_front arguments accept true or false as a string literal, not boolean. 
Props garrett-eclipse, audrasjb, valentinbora, bilgilabs, SergeyBiryukov.
Fixes #49087.
Built from https://develop.svn.wordpress.org/trunk@47368


git-svn-id: http://core.svn.wordpress.org/trunk@47155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 18:16:07 +00:00
Sergey Biryukov
89689e5ba9 Docs: Clarify in WP_Customize_Manager::remove_*() methods that removing a setting, panel, section, or control does not destroy the class instance or remove its filters. 
Props dlh, fgiannar, jon81, westonruter.
Fixes #48747.
Built from https://develop.svn.wordpress.org/trunk@47367


git-svn-id: http://core.svn.wordpress.org/trunk@47154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 17:50:05 +00:00
Sergey Biryukov
5308f570cb Comments: Restore the fourth parameter of comments_number() as $post_id, for consistency with get_comments_number_text(). 
The parameter was previously used as the number of comments, marked as deprecated in [5101].

Given that it's been deprecated for the last 13 years, it should be safe to undeprecate and repurpose it for a cleaner function signature, instead of adding a fifth parameter.

Follow-up to [47276].

Fixes #48772.
Built from https://develop.svn.wordpress.org/trunk@47366


git-svn-id: http://core.svn.wordpress.org/trunk@47153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 17:34:08 +00:00
Sergey Biryukov
b7c69ce058 Widgets: Avoid an overflow issue in widget controls that include <select> form fields. 
Props alexischenal, audrasjb, dkarfa.
Fixes #49401.
Built from https://develop.svn.wordpress.org/trunk@47365


git-svn-id: http://core.svn.wordpress.org/trunk@47152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 17:04:07 +00:00
Sergey Biryukov
d51c720d2f Docs: Add a reference to WP_Customize_Control::__construct() for information on accepted arguments in WP_Customize_Manager::add_control(). 
Synchronize the documentation between two places, use `WP_Customize_Control::__construct()` as the canonical source.

Props hAmpzter, marekdedic, SergeyBiryukov.
Fixes #48343.
Built from https://develop.svn.wordpress.org/trunk@47364


git-svn-id: http://core.svn.wordpress.org/trunk@47151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 16:41:07 +00:00
Sergey Biryukov
cfc27d08ce Docs: Add a reference to WP_Customize_Control::__construct() for information on accepted arguments to override class property defaults in child classes. 
Props marcio-zebedeu, marekdedic.
Fixes #48348.
Built from https://develop.svn.wordpress.org/trunk@47363


git-svn-id: http://core.svn.wordpress.org/trunk@47150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 16:21:07 +00:00
K. Adam White
44e1bbef85 REST API: Correctly infer empty objects passed via query parameters. 
Permit passing an empty object as the string "?obj=". The type of the passed empty argument is inferred from the registered schema.

Props TimothyBlynJacobs, steffanhalv, schlessera, dd32.
Fixes #42961.

Built from https://develop.svn.wordpress.org/trunk@47362


git-svn-id: http://core.svn.wordpress.org/trunk@47149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 15:34:07 +00:00
K. Adam White
a5f16272dd REST API: Permit access to the themes controller if user can edit any post type. 
Check a more exhaustive list of post type editing caps beyond "edit_post" to ensure custom user roles with access to to specific post types may still use block editor functionality depending on theme features.

Props miyauchi, TimothyBlynJacobs.
Fixes #46723.

Built from https://develop.svn.wordpress.org/trunk@47361


git-svn-id: http://core.svn.wordpress.org/trunk@47148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 15:20:08 +00:00
K. Adam White
8faf366ab9 REST API: Apply all relevant block rendering filters when rendering block previews. 
Several filters were introduced to the render_block method since the initial implementation of the block-renderer/ endpoints, causing the output of those endpoints to diverge from the rendered content of blocks on the frontend.

Props kadamwhite, TimothyBlynJacobs, miinasikk.
Fixes #49387.

Built from https://develop.svn.wordpress.org/trunk@47360


git-svn-id: http://core.svn.wordpress.org/trunk@47147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 15:05:06 +00:00
Sergey Biryukov
67a6527d51 Script Loader: Improve performance of wp_script_is() for scripts registered with complex dependencies. 
This switches `WP_Dependencies::recurse_deps()` from recursively checking the same handles over and over again to keep a flattened array of queued items and their dependencies for faster lookup in `WP_Dependencies::query()`.

Props superdav42.
Fixes #46469.
Built from https://develop.svn.wordpress.org/trunk@47359


git-svn-id: http://core.svn.wordpress.org/trunk@47146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 13:42:05 +00:00
Sergey Biryukov
c60ea3261f Docs: Add a @since note for including delete_posts in default capabilities in get_post_type_capabilities(). 
Follow-up to [47357].

See #30991.
Built from https://develop.svn.wordpress.org/trunk@47358


git-svn-id: http://core.svn.wordpress.org/trunk@47145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 12:55:08 +00:00
Sergey Biryukov
aaccfc063f Posts, Post Types: Ensure delete_posts is included in default post type capabilities regardless of map_meta_cap value. 
This resolves PHP notices in a few places in core where this capability is checked.

Props Mte90, johnbillion, dipesh.kakadiya, jipmoors, bamadesigner, dd32, johnjamesjacoby, xedin.unknown, flixos90, SergeyBiryukov.
Fixes #30991.
Built from https://develop.svn.wordpress.org/trunk@47357


git-svn-id: http://core.svn.wordpress.org/trunk@47144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 12:50:06 +00:00
Sergey Biryukov
1a090b3385 Customize: When a menu item is removed from the menu, uncheck its source item on the available items panel. 
Props donmhico, garrett-eclipse, audrasjb.
Fixes #46830.
Built from https://develop.svn.wordpress.org/trunk@47356


git-svn-id: http://core.svn.wordpress.org/trunk@47143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 11:14:08 +00:00
Sergey Biryukov
556c6d80d8 Script Loader: Remove unnecessary reference sign from function definitions in script loader. 
This resolves PHP warnings when extensions like `php_uopz` or `php_tideways_xhprof` are in use.

Object variables in PHP 5+ contain a reference to the object, and it's the reference that's passed around.

Props jqz, killerbishop, Mte90, TJNowell, jorbin, pento, pcarvalho, valentinbora, SergeyBiryukov.
Fixes #44979.
Built from https://develop.svn.wordpress.org/trunk@47355


git-svn-id: http://core.svn.wordpress.org/trunk@47142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 00:59:06 +00:00
jorgefilipecosta
f616ffb9c1 Block Editor: Update WordPress Packages WordPress 5.4 Beta 3. 
The following package versions were changed:
@wordpress/block-directory: 1.5.1 -> 1.5.2
@wordpress/block-editor: 3.7.1 -> 3.7.2
@wordpress/block-library: 2.14.1 -> 2.14.2
@wordpress/components: 9.2.1 -> 9.2.2
@wordpress/edit-post: 3.13.1 -> 3.13.2
@wordpress/editor: 9.12.1 -> 9.12.2
@wordpress/format-library: 1.14.1 -> 1.14.2
@wordpress/list-reusable-blocks: 1.13.1 -> 1.13.2
@wordpress/media-utils: 1.7.1 -> 1.7.2
@wordpress/nux: 3.12.1 -> 3.12.2
@wordpress/server-side-render: 1.8.1 -> 1.8.2

Fixes #49506.
Built from https://develop.svn.wordpress.org/trunk@47354


git-svn-id: http://core.svn.wordpress.org/trunk@47141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-25 00:18:15 +00:00
Sergey Biryukov
3209729f5f Accessibility: Widgets: Restore missing string in script loader. 
The string was previously added in [42794] and accidentally removed in [44163].

Props garrett-eclipse, audrasjb.
Fixes #49505.
Built from https://develop.svn.wordpress.org/trunk@47353


git-svn-id: http://core.svn.wordpress.org/trunk@47140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-24 23:07:09 +00:00
Andrew Ozz
50be657d81 Build Tools: 
- Update the DependencyExtractionWebpackPlugin to 2.3.0 and set it to output a single assets file.
- Grunt: copy the assets file to both `SOURCE_DIR` and `BUILD_DIR` as `wp-includes/assets/script-loader-packages.php`.
- "Unignore" the `wp-includes/assets` directory. Its content will be committed similarly to `wp-includes/blocks`.
- Update `wp_default_packages_scripts()` to use the above file. This also removes the hard-coded lists of packages and packages with translations.

Props gziolo, pbearne, johnbillion, isabel_brison, ocean90, azaozz.
Fixes #48154.
Built from https://develop.svn.wordpress.org/trunk@47352


git-svn-id: http://core.svn.wordpress.org/trunk@47139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-24 21:22:08 +00:00
K. Adam White
480372b07c REST API: Fix namespace shadowing issue in route matching logic. 
Following [47260] a namespace such as "test-ns" prevents any namespace such as "test-ns/v1" from being found when matching routes.
While not best practice, this was an unintentional back-compat break; this patch restores the original behavior.

Props david.binda, TimothyBlynJacobs.
Fixes #48530.


Built from https://develop.svn.wordpress.org/trunk@47351


git-svn-id: http://core.svn.wordpress.org/trunk@47138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-24 18:07:08 +00:00
Sergey Biryukov
4aeebf03a5 Menus: Introduce wp_nav_menu_item_custom_fields_customize_template action that fires at the end of the form field template for nav menu items in the customizer. 
This brings parity with the `wp_nav_menu_item_custom_fields` action added in [47190] for the Menus screen.

Props celloexpressions.
Fixes #47056.
Built from https://develop.svn.wordpress.org/trunk@47350


git-svn-id: http://core.svn.wordpress.org/trunk@47137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-24 14:58:19 +00:00
Sergey Biryukov
735d31ffbb Coding Standards: Add missing braces to if conditions and use strict comparison in js/_enqueues/wp/media/editor.js. 
Props ankitmaru.
Fixes #49317.
Built from https://develop.svn.wordpress.org/trunk@47349


git-svn-id: http://core.svn.wordpress.org/trunk@47136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-23 08:58:05 +00:00
Sergey Biryukov
9f8f54bfbb Built/Test Tools: Ignore the node_modules folder in Twenty Nineteen when running grunt jshint:themes. 
Follow-up to [45060], [46352], [46450].

Fixes #49494. See #46706.
Built from https://develop.svn.wordpress.org/trunk@47348


git-svn-id: http://core.svn.wordpress.org/trunk@47135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-23 08:28:06 +00:00
Sergey Biryukov
5a23e3fabd Docs: Use third-person singular verbs for function descriptions in wp-includes/option.php, per the documentation standards. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47347


git-svn-id: http://core.svn.wordpress.org/trunk@47134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-23 01:07:08 +00:00
Sergey Biryukov
30572ef8ed Docs: Add a @staticvar entry for $transports in WP_Http::_dispatch_request(). 
Props utsav72640.
Fixes #48774.
Built from https://develop.svn.wordpress.org/trunk@47346


git-svn-id: http://core.svn.wordpress.org/trunk@47133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-22 19:12:06 +00:00
Sergey Biryukov
e0a2660719 I18N: Replace .htaccess with placeholders in the strings for Site Health custom rules check. 
Props ramiy.
Fixes #48864.
Built from https://develop.svn.wordpress.org/trunk@47345


git-svn-id: http://core.svn.wordpress.org/trunk@47132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-22 18:56:06 +00:00
Sergey Biryukov
b4cea6ae93 I18N: Use a consistent wording for "Unable to write to file" strings. 
Props ramiy.
Fixes #48862.
Built from https://develop.svn.wordpress.org/trunk@47344


git-svn-id: http://core.svn.wordpress.org/trunk@47131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-22 18:33:08 +00:00
desrosj
b92155f273 General: Introduce a pull request template. 
This ensures that contributors opening a pull request on GitHub for code review have proper guidance.

See https://make.wordpress.org/core/2020/02/21/working-on-trac-tickets-using-github-pull-requests/ and https://meta.trac.wordpress.org/ticket/4903.

Props noisysocks, desrosj.
Fixes #49489.
Built from https://develop.svn.wordpress.org/trunk@47342


git-svn-id: http://core.svn.wordpress.org/trunk@47129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-21 18:25:07 +00:00
Sergey Biryukov
92050d6499 Build/Test Tools: Remove unused ::assertPostHasTerms() method from tests/term.php. 
The associated test was removed in [30241].

See #49485.
Built from https://develop.svn.wordpress.org/trunk@47341


git-svn-id: http://core.svn.wordpress.org/trunk@47128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-21 17:06:06 +00:00
Adam Silverstein
2c5ebcee68 Comments: improve styling on mobile for comments marked as spam. 
Correct an issue where comments marked as spam in a mobile view displayed incorrectly, filling a narrow and very tall column with the notice that a comment was marked as spam. 

Props jeremyfelt, lorenzof, mukesh27, razamalik, xkon.
Fixes #48814.


Built from https://develop.svn.wordpress.org/trunk@47340


git-svn-id: http://core.svn.wordpress.org/trunk@47127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-21 17:04:08 +00:00
ianbelanger
5a6decf95c Bundled Themes: Twenty Nineteen text color setting in pullquote block not applied. 
Fixes the pullquote color setting by adding classes that are more specific to the color options.

Props ianbelanger.
Fixes #49410.
Built from https://develop.svn.wordpress.org/trunk@47339


git-svn-id: http://core.svn.wordpress.org/trunk@47126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-21 14:59:09 +00:00
Sergey Biryukov
f0dfe42216 I18N: Replace upload_max_filesize, php.ini, MAX_FILE_SIZE with placeholders in upload error strings. 
Props ramiy.
Fixes #48869.
Built from https://develop.svn.wordpress.org/trunk@47330


git-svn-id: http://core.svn.wordpress.org/trunk@47123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-20 17:18:06 +00:00
TimothyBlynJacobs
5031baa32b REST API: Don't assume all item schemas have properties. 
All schema types, not just objects, are permitted as the base type of a resource. A future patch could add validation support for those types, but this fix only prevents a PHP warning from being issued.

Props dhavalkasvala, johnwatkins0, birgire.
Fixes #48785.

Built from https://develop.svn.wordpress.org/trunk@47328


git-svn-id: http://core.svn.wordpress.org/trunk@47122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-20 16:58:06 +00:00
ianbelanger
a5cfb704bd Bundled Themes: Twenty Nineteen Update margins in editor styles to address upcoming block editor margin changes. 
Fixes the margins in the block editor to address recent changes in block margins.

Props Joen, SergeyBiryukov, kjellr, jffng, allancole.
Fixes #48526.
Built from https://develop.svn.wordpress.org/trunk@47327


git-svn-id: http://core.svn.wordpress.org/trunk@47121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-20 16:40:06 +00:00
TimothyBlynJacobs
450d49183b REST API: Fix links format in OPTIONS requests for non-variable routes. 
Props nsundberg, johnwatkins0, birgire.
Fixes #49149.

Built from https://develop.svn.wordpress.org/trunk@47326


git-svn-id: http://core.svn.wordpress.org/trunk@47120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-20 00:55:05 +00:00
TimothyBlynJacobs
808768224d REST API: Warn if registering array settings without an items schema. 
The documentation for register_setting has also been clarified to include all of the supported types and the flexibility of the show_in_rest parameter.

Fixes #42875.
Props perrywagle, dshanske, kadamwhite.

Built from https://develop.svn.wordpress.org/trunk@47325


git-svn-id: http://core.svn.wordpress.org/trunk@47119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-19 22:56:07 +00:00
Sergey Biryukov
c15cd5f5c4 Docs: Add missing quote to {@see 'comment_$old_status_to_$new_status'} hook reference in wp_transition_comment_status() DocBlock. 
Props coffee2code.
Fixes #49474.
Built from https://develop.svn.wordpress.org/trunk@47324


git-svn-id: http://core.svn.wordpress.org/trunk@47118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-19 13:45:07 +00:00
Sergey Biryukov
511a297fb4 Tests: Correct assertions in test_site_dates_are_gmt(). 
`assertSame()` doesn't have the `$delta` parameter, only `assertEquals()` does.

Follow-up to [47313].

See #40364.
Built from https://develop.svn.wordpress.org/trunk@47318


git-svn-id: http://core.svn.wordpress.org/trunk@47116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-19 04:40:05 +00:00
Sergey Biryukov
e67b01895b Posts, Post Types: Discard tags_input parameter in wp_update_post() if it's the same as existing post tags. 
This ensures that `wp_update_post()` does not unintentionally modify post tags if the post has several tags with the same name but different slugs.

Tags should only be modified if `tags_input` parameter was explicitly provided, and is different from the existing tags.

Props kaggdesign, SergeyBiryukov.
Fixes #45121.
Built from https://develop.svn.wordpress.org/trunk@47317


git-svn-id: http://core.svn.wordpress.org/trunk@47115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-19 03:52:09 +00:00
Sergey Biryukov
548685b97d Tests: Use delta comparison in test_site_dates_are_gmt() to avoid race conditions. 
See #40364.
Built from https://develop.svn.wordpress.org/trunk@47313


git-svn-id: http://core.svn.wordpress.org/trunk@47113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-19 02:43:08 +00:00
Sergey Biryukov
c4a5b98fa0 Build/Test Tools: Keep wp-config.php file in the build directory on rebuild, but still copy it over from src if it also exists there. 
Follow-up to [47303].

Props afercia, isabel_brison, SergeyBiryukov.
Fixes #49460.
Built from https://develop.svn.wordpress.org/trunk@47312


git-svn-id: http://core.svn.wordpress.org/trunk@47112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-19 01:50:05 +00:00
Sergey Biryukov
399c2bf8c6 Tests: Remove an irrelevant tags_input property assertion from test_get_page_template_property(). 
This appears to be a copy/paste from the `test_get_tags_input_property()` test above.

See #45121.
Built from https://develop.svn.wordpress.org/trunk@47311


git-svn-id: http://core.svn.wordpress.org/trunk@47111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-19 01:05:09 +00:00
Tammie Lister
152892b04c Bump version number to beta 2-47310 
Built from https://develop.svn.wordpress.org/trunk@47310


git-svn-id: http://core.svn.wordpress.org/trunk@47110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-18 21:29:05 +00:00
Tammie Lister
d55eaec1f7 Bump version number to beta 2 
Built from https://develop.svn.wordpress.org/trunk@47309


git-svn-id: http://core.svn.wordpress.org/trunk@47109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-18 21:11:06 +00:00
desrosj
4cc82e180e Widgets: Revert [47307]. 
Even though the source URL for an attachment is stored in a variable, attachments should still be passed through the `wp_video_shortcode()` function.

Unprops desrosj, spacedmonkey.
See #46718.
Built from https://develop.svn.wordpress.org/trunk@47308


git-svn-id: http://core.svn.wordpress.org/trunk@47108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-18 18:19:06 +00:00
desrosj
520fe14f79 Widgets: Remove unnecessary redundant conditional. 
Props spacedmonkey.
Fixes #46718.
Built from https://develop.svn.wordpress.org/trunk@47307


git-svn-id: http://core.svn.wordpress.org/trunk@47107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-18 17:52:06 +00:00
desrosj
447536a0e6 Site Health: Display the REST API test error codes correctly. 
This change fixes an issue where the error codes associated with failed REST API tests are not being printed to the screen. In addition, the square brackets have been replaced with parentheses for consistency, and the error code (which is much less useful to end-users than the error message itself) has been moved to the end of the line.

This also clarifies the associated translator comments.

Props afercia, desrosj.
Fixes #49426.
Built from https://develop.svn.wordpress.org/trunk@47306


git-svn-id: http://core.svn.wordpress.org/trunk@47106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-18 16:48:06 +00:00
Sergey Biryukov
306d804d86 Theme Editor: Disable CodeMirror CSS linting. 
Being a good idea in theory, in practice it does not always work reliably, may not recognize newer CSS properties, and sometimes displays phantom errors with no particular error message.

A plugin can re-enable CSS linting via the `wp_code_editor_settings` filter.

Props skypressatx, ThemeZee, johnbillion, ianbelanger, ZanderZ, starvoters1, raoulunger, prashantvatsh, SergeyBiryukov.
Fixes #44471.
Built from https://develop.svn.wordpress.org/trunk@47305


git-svn-id: http://core.svn.wordpress.org/trunk@47105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-18 15:51:08 +00:00
Andrea Fercia
d1054fcb48 Accessibility: Improve readability by removing unnecessary italic font style. 
Per Web Content Accessibility Guidelines 2.0, big chunks of italic text should be avoided.
Same applies to UI controls, since they're meant to be comfortably readable by the largest possible audience, e.g.: label elements.

Removes italic font style from:
- the Quick Edit / Bulk Edit forms
- the Recovery Mode plugin error details
- the Image Editor inline help

Props birgire, audrasjb, SergeyBiryukov, melchoyce, estelaris, sabernhardt, xkon, nrqsnchz, afercia.
See #47327.

Built from https://develop.svn.wordpress.org/trunk@47304


git-svn-id: http://core.svn.wordpress.org/trunk@47104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-18 15:32:09 +00:00
Sergey Biryukov
bb7880a7ea Build/Test Tools: Keep wp-config.php file in the build directory on rebuild. 
Props isabel_brison.
Fixes #49460.
Built from https://develop.svn.wordpress.org/trunk@47303


git-svn-id: http://core.svn.wordpress.org/trunk@47103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-18 09:27:09 +00:00
jorgefilipecosta
b522d90421 Block Editor: Update WordPress Packages WordPress 5.4 beta 2. 
The following package versions were changed:
@wordpress/block-directory: 1.5.0 -> 1.5.1
@wordpress/block-editor: 3.7.0 -> 3.7.1
@wordpress/block-library: 2.14.0 -> 2.14.1
@wordpress/components: 9.2.0 -> 9.2.1
@wordpress/edit-post: 3.13.0 -> 3.13.1
@wordpress/editor: 9.12.0 -> 9.12.1
@wordpress/format-library: 1.14.0 -> 1.14.1
@wordpress/list-reusable-blocks: 1.13.0 -> 1.13.1
@wordpress/media-utils: 1.7.0 -> 1.7.1
@wordpress/nux: 3.12.0 -> 3.12.1
@wordpress/server-side-render: 1.8.0 -> 1.8.1

Props gziolo, youknowriad, epiqueras, aduth.
Fixes #49458.
Built from https://develop.svn.wordpress.org/trunk@47302


git-svn-id: http://core.svn.wordpress.org/trunk@47102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-17 23:02:14 +00:00
jorgefilipecosta
ce3cd1cd91 Block Editor: Add missing package to the default export array. 
Follow up on https://core.trac.wordpress.org/ticket/49358#comment:12.
We should add "warning" to the array of packages with default export to avoid the need for developers to use wp.warning.default.

Props gziolo, aduth.
Fixes #49436.
Built from https://develop.svn.wordpress.org/trunk@47301


git-svn-id: http://core.svn.wordpress.org/trunk@47101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-17 12:32:05 +00:00
Sergey Biryukov
9de7b1c35e Site Health: Prevent the Site Health Status dashboard widget from loading on network admin screen for now. 
Props Clorith, pbiron.
See #47606, #47085.
Built from https://develop.svn.wordpress.org/trunk@47300


git-svn-id: http://core.svn.wordpress.org/trunk@47100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-17 09:59:04 +00:00
Sergey Biryukov
61986acde9 Users: Limit the scope of admin files required in WP_REST_Users_Controller. 
This requires only `wp-admin/includes/user.php` for `get_editable_roles()`, instead of `wp-admin/includes/admin.php`.

Follow-up to [43589].

Props johnwatkins0.
Fixes #49450.
Built from https://develop.svn.wordpress.org/trunk@47299


git-svn-id: http://core.svn.wordpress.org/trunk@47099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-17 05:33:06 +00:00
Sergey Biryukov
8f877dc875 Docs: Improve inline comments for require_once calls in WP_REST_Users_Controller per the documentation standards. 
Follow-up to [47295].

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47298


git-svn-id: http://core.svn.wordpress.org/trunk@47098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-17 03:56:06 +00:00
Sergey Biryukov
97380ec1ce Docs: Fix typo in a comment in WP_REST_Attachments_Controller::create_item(). 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47297


git-svn-id: http://core.svn.wordpress.org/trunk@47097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-17 03:30:04 +00:00
Sergey Biryukov
1d5d5b3e87 REST API: Restore wp-admin/includes/image.php requirement in WP_REST_Attachments_Controller::create_item(). 
Although the file is already included via the `::insert_attachment()` method, this addresses an inconsistency and corrects a misleading comment.

It also reduces the possibility of a future error in case `::insert_attachment()` is no longer called earlier in `::create_item()` at some point.

Follow-up to [43850] and [44206].

Props luisrivera.
Fixes #49449.
Built from https://develop.svn.wordpress.org/trunk@47296


git-svn-id: http://core.svn.wordpress.org/trunk@47096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-17 03:24:07 +00:00
Sergey Biryukov
445e2859ab Docs: Improve inline comments for require_once() calls in WP_REST_Attachments_Controller. 
See #49449, #48303.
Built from https://develop.svn.wordpress.org/trunk@47295


git-svn-id: http://core.svn.wordpress.org/trunk@47095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-17 03:13:05 +00:00
Sergey Biryukov
5875ad981b Menus: Restore the title of the currently active/expanded menu item when clicking "Cancel" after editing. 
Other inputs are already restored to their previous values in that case.

Props Girishpanchal, nilamacharya, JoshuaWold, welcher, SergeyBiryukov.
Fixes #43031.
Built from https://develop.svn.wordpress.org/trunk@47294


git-svn-id: http://core.svn.wordpress.org/trunk@47094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-16 06:27:08 +00:00
Sergey Biryukov
74b90a6b45 Themes: Correct the height of theme actions button container on various screen sizes. 
Props aftabmuni, alexischenal, ideaboxcreations, audrasjb, SergeyBiryukov.
Fixes #49302.
Built from https://develop.svn.wordpress.org/trunk@47293


git-svn-id: http://core.svn.wordpress.org/trunk@47093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-15 05:08:05 +00:00
Sergey Biryukov
f147a4003e Widgets: Hide the "Align" legend in Image Widget display settings, since the associated controls are also hidden. 
Props audrasjb, fotisps, marcelo2605.
Fixes #48931.
Built from https://develop.svn.wordpress.org/trunk@47292


git-svn-id: http://core.svn.wordpress.org/trunk@47092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-15 02:50:08 +00:00
Sergey Biryukov
a2b2f63b78 Administration: Allow wp_update_link() to update the link_owner field, for consistency with other link fields. 
Props pbiron, valentinbora, nikhilgupte.
Fixes #41687.
Built from https://develop.svn.wordpress.org/trunk@47291


git-svn-id: http://core.svn.wordpress.org/trunk@47091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-15 01:55:06 +00:00
Sergey Biryukov
19fd7a0da9 Administration: Correct alignment of form controls inside custom meta boxes. 
Props audrasjb, dontdream, valentinbora.
Fixes #49013.
Built from https://develop.svn.wordpress.org/trunk@47289


git-svn-id: http://core.svn.wordpress.org/trunk@47089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-14 00:52:06 +00:00
Sergey Biryukov
e16d70a9d4 Tests: Rename $d variable in some date/time tests to $format for clarity. 
Follow-up to [47287].

See #49222.
Built from https://develop.svn.wordpress.org/trunk@47288


git-svn-id: http://core.svn.wordpress.org/trunk@47088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-14 00:12:11 +00:00
Sergey Biryukov
6b2c63031c Coding Standards: Rename $d parameter in various date/time functions to $format for clarity. 
See #49222.
Built from https://develop.svn.wordpress.org/trunk@47287


git-svn-id: http://core.svn.wordpress.org/trunk@47087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-14 00:07:07 +00:00
Sergey Biryukov
f7338b347d Docs: Update @return tag for wp_allow_comment() with trash as a possible return value. 
Props oakesjosh, jeremyfelt.
Fixes #49206.
Built from https://develop.svn.wordpress.org/trunk@47286


git-svn-id: http://core.svn.wordpress.org/trunk@47086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-13 17:50:05 +00:00
Sergey Biryukov
57ba9a2906 General: Update Michel Valdrighi's website in license.txt. 
Props sebastienserre.
Fixes #49130.
Built from https://develop.svn.wordpress.org/trunk@47285


git-svn-id: http://core.svn.wordpress.org/trunk@47085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-12 11:54:05 +00:00
Sergey Biryukov
534fcd7b0e Privacy: Only show the Privacy Policy page notice when editing the page, not on drafts list. 
Props chetan200891, xkon, garrett-eclipse.
Fixes #48431.
Built from https://develop.svn.wordpress.org/trunk@47284


git-svn-id: http://core.svn.wordpress.org/trunk@47084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-12 11:44:08 +00:00
Sergey Biryukov
b2ecf2c2bc Privacy: Improve the appearance of privacy request email inputs on mobile. 
Props garrett-eclipse, xkon.
Fixes #48189.
Built from https://develop.svn.wordpress.org/trunk@47283


git-svn-id: http://core.svn.wordpress.org/trunk@47083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-12 11:29:10 +00:00
jorgefilipecosta
53f823e21e Post WordPress 5.4 Beta 1 version bump. 
Built from https://develop.svn.wordpress.org/trunk@47282


git-svn-id: http://core.svn.wordpress.org/trunk@47082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 22:46:09 +00:00
jorgefilipecosta
b24a667b9a WordPress 5.4 Beta 1. 
Built from https://develop.svn.wordpress.org/trunk@47281


git-svn-id: http://core.svn.wordpress.org/trunk@47081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 22:20:10 +00:00
Sergey Biryukov
63ed0401a0 Privacy: Revert [47269] for now to address side effects on Multisite installations. 
See #44176.
Built from https://develop.svn.wordpress.org/trunk@47280


git-svn-id: http://core.svn.wordpress.org/trunk@47080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 21:48:06 +00:00
Sergey Biryukov
652966a2a5 Privacy: Introduce filters for the headers of all the privacy-related e-mails: 
* `wp_privacy_personal_data_email_headers`
* `user_request_confirmed_email_headers`
* `user_erasure_complete_email_headers`
* `user_request_action_email_headers`

Props xkon, garrett-eclipse, zaffarn, desrosj.
Fixes #44501.
Built from https://develop.svn.wordpress.org/trunk@47279


git-svn-id: http://core.svn.wordpress.org/trunk@47079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 21:43:07 +00:00
Sergey Biryukov
e6d01e007c Privacy: Add a table of contents to Personal Data Export report for easier navigation. 
Props xkon, garrett-eclipse, birgire, karmatosed.
Fixes #46894.
Built from https://develop.svn.wordpress.org/trunk@47278


git-svn-id: http://core.svn.wordpress.org/trunk@47078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 21:28:05 +00:00
Sergey Biryukov
cbaf9bf9d1 Coding Standards: Use a strict in_array() check for reserved names of user data items in wp_user_personal_data_exporter(). 
Props azaozz.
Fixes #47509.
Built from https://develop.svn.wordpress.org/trunk@47277


git-svn-id: http://core.svn.wordpress.org/trunk@47077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 20:55:07 +00:00
Sergey Biryukov
17e563cd9c Comments: Add a $post_id parameter to get_comments_number_text() and comments_number(). 
This allow for using these functions outside of the loop.

Props donmhico, garrett-eclipse, Hinjiriyo, imath.
Fixes #48772.
Built from https://develop.svn.wordpress.org/trunk@47276


git-svn-id: http://core.svn.wordpress.org/trunk@47076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 20:41:05 +00:00
desrosj
be2ec734f2 Upgrade/Install: Enable maintenance mode when plugins are auto-updated. 
When an attempt is made to update an active plugin automatically, there is the potential currently for two negative scenarios:

- The plugin can be deactivated if the Plugins admin screen is loaded when the plugin update is incomplete, causing a PHP error.
- The WSOD protection could be triggered, sending a false alarm email to the site administrator.

By enabling maintenance mode before an active plugin update is attempted, these scenarios can be avoided.

This change implements the same approach as the `Theme_Upgrader` class of using the `upgrader_pre_install` and `upgrader_post_install` hooks to toggle maintenance mode.

Props desrosj, SergeyBiryukov.
Fixes #49400.
Built from https://develop.svn.wordpress.org/trunk@47275


git-svn-id: http://core.svn.wordpress.org/trunk@47075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 20:14:05 +00:00
Andrew Ozz
a2accf4db7 Media: Pass through the $unfiltered param to get_attached_file() in wp_get_original_image_path(). 
Props ianmjones, joemcgill, azaozz.
Fixes #48421.
Built from https://develop.svn.wordpress.org/trunk@47274


git-svn-id: http://core.svn.wordpress.org/trunk@47074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 19:47:07 +00:00
ianbelanger
4489fb7b36 Bundled Themes: Twenty Sixteen text color setting in pullquote block not applied. 
Fixes the pullquote color setting by moving `color` from `blockquote p` to `blockquote`. Also adds the border-left to the front-end stylesheet to match the editor. Also adds styles for rtl pullquote.

Props kokkieh, desrosj, mukesh27, khushbu19, disillusia, aliveic, abrightclearweb, SergeyBiryukov.
Fixes #47019.
Built from https://develop.svn.wordpress.org/trunk@47273


git-svn-id: http://core.svn.wordpress.org/trunk@47073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 19:38:05 +00:00
Sergey Biryukov
ae102b2487 Export: Use correct context for the Posts label on the Export screen. 
The string refers to the post type name specifically, not to a generic term to identify a publication on WordPress.

Props audrasjb, jdy68.
Fixes #49306.
Built from https://develop.svn.wordpress.org/trunk@47272


git-svn-id: http://core.svn.wordpress.org/trunk@47072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 19:35:06 +00:00
jorgefilipecosta
40046869f3 Upload: Fix Plugin and Theme upload form are misaligned. 
This commit makes sure that when uploading a plugin or theme file, the Install Now button is correctly aligned, and the button does not drops to the next line if filename is long.

Props seedsca, SergeyBiryukov, audrasjb.
Fixes #48859.
Built from https://develop.svn.wordpress.org/trunk@47271


git-svn-id: http://core.svn.wordpress.org/trunk@47071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 19:18:09 +00:00
Sergey Biryukov
5a29f108e0 Privacy: Introduce wp_privacy_additional_user_data filter to make it easier to include additional user meta in a personal data export. 
Props pbiron, xkon, garrett-eclipse, azaozz.
Fixes #47509.
Built from https://develop.svn.wordpress.org/trunk@47270


git-svn-id: http://core.svn.wordpress.org/trunk@47070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 18:59:05 +00:00
Sergey Biryukov
30c7bb621c Privacy: Un-map privacy capabilities to make them available to be assigned for custom roles: 
* `erase_others_personal_data`
* `export_others_personal_data`
* `manage_privacy_options`

Previously mapped to `manage_options` or `manage_network` (on Multisite), these are now added to the Administrator role separately.

Additionally, `manage_privacy_options` is added to the Editor role.

Props garrett-eclipse, xkon, pbiron, desrosj, johnbillion, flixos90, juliobox, lakenh, Ov3rfly, ianatkins.
Fixes #44176.
Built from https://develop.svn.wordpress.org/trunk@47269


git-svn-id: http://core.svn.wordpress.org/trunk@47069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 18:36:06 +00:00
Sergey Biryukov
bf29d14a69 Site Health: Adjust "Database username" and "Table prefix" strings for consistency with the same strings in wp-admin/setup-config.php. 
Props ramiy.
Fixes #47043.
Built from https://develop.svn.wordpress.org/trunk@47268


git-svn-id: http://core.svn.wordpress.org/trunk@47068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 16:48:05 +00:00
Sergey Biryukov
5bf387bb07 Customize: Avoid unnecessary get_theme_mod() call and premature escaping in get_header_video_url(). 
The result is still escaped with `esc_url_raw()` for retrieval, and with `esc_url()` for display in `the_header_video_url()`.

Props dlh, Tkama.
Fixes #40044.
Built from https://develop.svn.wordpress.org/trunk@47267


git-svn-id: http://core.svn.wordpress.org/trunk@47067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 16:36:06 +00:00
Andrea Fercia
0fcc994a8f Media: Fix bottom spacing on various Media Modal elements for non-webkit browsers. 
Implementation of bottom padding in overflow content differs across browsers. See https://github.com/w3c/csswg-drafts/issues/129. To make bottom spacing consistent across browsers there's the need for an alternate CSS method.
- uses a CSS `after` pseudo element or simply a bottom margin to reserve some bottom spacing
- removes a couple leftovers from [40428]
- fixes an annoying visual glitch where the media modal content is visible behind the bottom toolbar border

Props sabernhardt, afercia.
See #40152.
Fixes #48378.

Built from https://develop.svn.wordpress.org/trunk@47266


git-svn-id: http://core.svn.wordpress.org/trunk@47066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 16:32:06 +00:00
K. Adam White
c85c8f5235 REST API: Introduce rest_{$this->post_type}_item_schema filter to enable manipulation of schema values. 
register_rest_field can be used to add properties to a schema, but no mechanism existed to alter existing properties like "content".
Running the schema through this filter lets plugins append additional sub-properties to existing schema definitions.

Props luisherranz, TimothyBlynJacobs, swissspidy, westonruter, kadamwhite.
Fixes #47779.


Built from https://develop.svn.wordpress.org/trunk@47265


git-svn-id: http://core.svn.wordpress.org/trunk@47065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 16:28:06 +00:00
ianbelanger
97524fd300 Bundled Themes: Twenty Twenty property border-style is overwritten - coding standard. 
Fixes coding standard violations in the classic editor stylesheets.

Props ankitmaru.
Fixes #49006.
Built from https://develop.svn.wordpress.org/trunk@47264


git-svn-id: http://core.svn.wordpress.org/trunk@47064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 16:11:06 +00:00
Sergey Biryukov
76718fbea3 Widgets: Prevent currently active wide widget controls from being partially covered by another widget's controls. 
The currently active widget controls should always be displayed on top.

Props audrasjb, fervillz, rinkuyadav999, jaydeep23290, ashokrd2013, melchoyce, pento, westonruter, SergeyBiryukov.
Fixes #42001.
Built from https://develop.svn.wordpress.org/trunk@47263


git-svn-id: http://core.svn.wordpress.org/trunk@47063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 15:26:09 +00:00
antpb
036eca242a Media: Reset aspect ratio constraints when width and height fields fail numeric validation. 
Props TBschen, valentinbora.
Fixes #49073.

Built from https://develop.svn.wordpress.org/trunk@47262


git-svn-id: http://core.svn.wordpress.org/trunk@47062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 04:40:10 +00:00
K. Adam White
12709269c1 REST API: Allow meta to be set when creating a new media record via REST. 
Props TimothyBlynJacobs, apermo.
Fixes #44567.

Built from https://develop.svn.wordpress.org/trunk@47261


git-svn-id: http://core.svn.wordpress.org/trunk@47061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 03:39:06 +00:00
K. Adam White
23696bb074 REST API: Match REST API routes on namespace before performing regex checks. 
Rule out groups of API endpoints by simple namespace string comparison to reduce the number of regex checks necessary when matching a route.

Props TimothyBlynJacobs.
Fixes #48530.

Built from https://develop.svn.wordpress.org/trunk@47260


git-svn-id: http://core.svn.wordpress.org/trunk@47060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 03:22:05 +00:00
Andrew Ozz
3d126b2dc7 Media: Improve wording for error message on failed post-processing of uploaded images. 
Props eclev91, desrosj, antpb, azaozz.
Fixes #49280.
Built from https://develop.svn.wordpress.org/trunk@47259


git-svn-id: http://core.svn.wordpress.org/trunk@47059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 03:20:06 +00:00
K. Adam White
25d8f7240e REST API: List all core theme feature support details in /themes endpoint response. 
Fully list which first-party core theme features are supported in the /themes endpoint response. This brings the REST API themes controller's response more in line with the output of get_theme_support().

Props adamboro, apieschel, koke, spacedmonkey, TimothyBlynJacobs.
See #49037.

Built from https://develop.svn.wordpress.org/trunk@47258


git-svn-id: http://core.svn.wordpress.org/trunk@47058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 02:00:07 +00:00
Sergey Biryukov
9614434049 Media: Improve the preview of transparent images in Image widget by using CSS3 to show a checkered background. 
Props bahia0019.
Fixes #49237.
Built from https://develop.svn.wordpress.org/trunk@47257


git-svn-id: http://core.svn.wordpress.org/trunk@47057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 01:47:06 +00:00
Sergey Biryukov
5d00e8f78b Administration: Move .has-row-actions class in Recent Comments dashboard widget next to .dashboard-comment-wrap, for consistency. 
Follow-up to [47255].

See #42938.
Built from https://develop.svn.wordpress.org/trunk@47256


git-svn-id: http://core.svn.wordpress.org/trunk@47056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 01:21:05 +00:00
Sergey Biryukov
8c2fb2148b Administration: Remove a blank space in the Recent Comments dashboard widget if avatars are disabled on Discussion Settings screen. 
Props Marius84, shital-patel, GaryJ, ianbelanger, sgastard, lgrev01, donmhico, garrett-eclipse, audrasjb, SergeyBiryukov.
Fixes #42938.
Built from https://develop.svn.wordpress.org/trunk@47255


git-svn-id: http://core.svn.wordpress.org/trunk@47055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 01:17:06 +00:00
Sergey Biryukov
055af2b506 Site Health: Improve the wording for PHP update recommendations. 
Props Clorith, grafruessel, sathyapulse, wpgurudev, garrett-eclipse, marybaum, xkon, SergeyBiryukov.
Fixes #48716.
Built from https://develop.svn.wordpress.org/trunk@47254


git-svn-id: http://core.svn.wordpress.org/trunk@47054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 00:41:05 +00:00
Sergey Biryukov
ca3366926a Docs: Improve documentation for tests/phpunit/includes/spy-rest-server.php. 
Props andizer.
Fixes #47567.
Built from https://develop.svn.wordpress.org/trunk@47253


git-svn-id: http://core.svn.wordpress.org/trunk@47053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 00:20:07 +00:00
Sergey Biryukov
984d1c60b5 Comments: Improve the appearance of the Status box on Edit Comment screen. 
This makes the box more consistent with the Publish meta box in classic editor.

Props birgire, nfmohit, melchoyce, afercia.
Fixes #43587.
Built from https://develop.svn.wordpress.org/trunk@47252


git-svn-id: http://core.svn.wordpress.org/trunk@47052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-11 00:06:04 +00:00
Sergey Biryukov
507d056b7e Media: In media_sideload_image(), store the original attachment URL in the _source_url post meta value. 
Props dshanske, joemcgill, antpb.
Fixes #48164.
Built from https://develop.svn.wordpress.org/trunk@47251


git-svn-id: http://core.svn.wordpress.org/trunk@47051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 23:47:04 +00:00
jorgefilipecosta
56906bcf59 Block Editor: Update WordPress Packages; Remove navigation block; Add social links block 
The following package versions were changed:
@wordpress/annotations: 1.11.0 -> 1.12.0
@wordpress/api-fetch: 3.10.0 -> 3.11.0
@wordpress/block-directory: 1.4.0 -> 1.5.0
@wordpress/block-editor: 3.6.0 -> 3.7.0
@wordpress/block-library: 2.13.0 -> 2.14.0
@wordpress/blocks: 6.11.0 -> 6.12.0
@wordpress/components: 9.1.0 -> 9.2.0
@wordpress/core-data: 2.11.0 -> 2.12.0
@wordpress/data: 4.13.0 -> 4.14.0
@wordpress/data-controls: 1.7.0 -> 1.8.0
@wordpress/e2e-test-utils: 4.2.0 -> 4.3.0
@wordpress/edit-post: 3.12.0 -> 3.13.0
@wordpress/editor: 9.11.0 -> 9.12.0
@wordpress/format-library: 1.13.0 -> 1.14.0
@wordpress/icons: 1.0.0 -> 1.1.0
@wordpress/keyboard-shortcuts: 1.0.0 -> 1.1.0
@wordpress/list-reusable-blocks: 1.12.0 -> 1.13.0
@wordpress/media-utils: 1.6.0 -> 1.7.0
@wordpress/notices: 1.12.0 -> 2.0.0
@wordpress/nux: 3.11.0 -> 3.12.0
@wordpress/plugins: 2.11.0 -> 2.12.0
@wordpress/primitives: 1.0.0 -> 1.1.0
@wordpress/rich-text: 3.11.0 -> 3.12.0
@wordpress/server-side-render: 1.7.0 -> 1.8.0
@wordpress/url: 2.10.0 -> 2.11.0
@wordpress/viewport: 2.12.0 -> 2.13.0
The navigation block inclusion was reverted.
The social links block was included.

Props gziolo, youknowriad, mcsf, noisysocks.
Fixes #49397.
Built from https://develop.svn.wordpress.org/trunk@47250


git-svn-id: http://core.svn.wordpress.org/trunk@47050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 22:33:27 +00:00
Sergey Biryukov
363191d8ee Docs: Improve documentation for the $attr parameter of wp_get_attachment_image(). 
Props juanfra, Mte90, DrewAPicture, joemcgill, SergeyBiryukov.
Fixes #36661.
Built from https://develop.svn.wordpress.org/trunk@47249


git-svn-id: http://core.svn.wordpress.org/trunk@47049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 22:03:07 +00:00
Sergey Biryukov
f8f24b49e6 Coding Standards: Fix JSHint issues in [47246]. 
See #44264.
Built from https://develop.svn.wordpress.org/trunk@47248


git-svn-id: http://core.svn.wordpress.org/trunk@47048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 21:38:08 +00:00
Sergey Biryukov
13922a3210 Privacy: Convert buttons to links visually in Privacy Export/Erasure "Next Steps" column. 
With a lot of export or erasure requests, the secondary buttons were becoming overwhelming when stacked on top of each other.

Props xkon, karmatosed.
Fixes #49323.
Built from https://develop.svn.wordpress.org/trunk@47247


git-svn-id: http://core.svn.wordpress.org/trunk@47047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 21:15:05 +00:00
Sergey Biryukov
5ddf97e142 Privacy: Give progress indication for export and erasure. 
This adds a progress indicator for "Download Personal Data" and "Erase Personal Data" row actions, which can take a while with a lot of data.

Props garrett-eclipse, allendav, dominic_ks, xkon, karmatosed, birgire.
Fixes #44264.
Built from https://develop.svn.wordpress.org/trunk@47246


git-svn-id: http://core.svn.wordpress.org/trunk@47046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 20:19:05 +00:00
Sergey Biryukov
3342aafe5e Privacy: Rename wp_get_user_request_data() to wp_get_user_request() for clarity; deprecate the old function. 
The function returns an instance of the `WP_User_Request` object itself, not its `$request_data` property.

Follow-up to [44606].

Props garrett-eclipse.
Fixes #46302.
Built from https://develop.svn.wordpress.org/trunk@47245


git-svn-id: http://core.svn.wordpress.org/trunk@47045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 19:57:05 +00:00
ianbelanger
99f402dc62 Bundled Themes: Twenty Twenty post navigation links outside of the container. 
Fixes a bug where the in-page pagination does not align within the inner container.

Props ataurr, audrasjb, mukesh27.
Fixes #48979.
Built from https://develop.svn.wordpress.org/trunk@47244


git-svn-id: http://core.svn.wordpress.org/trunk@47044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 19:25:05 +00:00
ianbelanger
598b2889a9 Bundled Themes: Twenty Twenty add WhatsApp to the social icon menu. 
This adds WhatsApp as an option in the social icon menu.

Props rryyaanndd, audrasjb.
Fixes #49098.
Built from https://develop.svn.wordpress.org/trunk@47243


git-svn-id: http://core.svn.wordpress.org/trunk@47043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 19:12:05 +00:00
Sergey Biryukov
762140cc6b Twenty Nineteen: Add the missing inc/helper-functions.php file. 
Follow-up to [47214].

Props kjellr, jffng.
Fixes #45984.
Built from https://develop.svn.wordpress.org/trunk@47242


git-svn-id: http://core.svn.wordpress.org/trunk@47042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 19:07:06 +00:00
ianbelanger
2b52ae5c1b Bundled Themes: Twenty Twenty Author Bio/Post Meta Width in Cover Template in Mobile. 
Fixes a bug where the author bio and post meta have no left or right padding in smaller viewports.

Props JarretC.
Fixes #49254.
Built from https://develop.svn.wordpress.org/trunk@47241


git-svn-id: http://core.svn.wordpress.org/trunk@47041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 18:25:07 +00:00
jorgefilipecosta
76e375434b Block Editor: Backport inclusion of new editor settings to the core. 
This commit includes in the core settings for the gradients theme API stabilized in https://github.com/WordPress/gutenberg/pull/20107, and for the image sizes required for the latest posts feature image https://github.com/WordPress/gutenberg/pull/17151/.

Props: youknowriad, ryelle.
Fixes #49389.
Built from https://develop.svn.wordpress.org/trunk@47240


git-svn-id: http://core.svn.wordpress.org/trunk@47040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 17:52:15 +00:00
TimothyBlynJacobs
7019add74e REST API: Add support for the REDIRECT_HTTP_AUTHORIZATION header. 
Previously the REST API did not account for server configurations where the Authorization header must be added using ModRewrite. This caused major DUX issues when trying to use custom authentication mechanisms.

Fixes #47077.
Props dshanske, cklosows.

Built from https://develop.svn.wordpress.org/trunk@47239


git-svn-id: http://core.svn.wordpress.org/trunk@47039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 16:08:16 +00:00
aduth
4bff827833 Script Loader: Add polyfill for window.URL, window.DOMRect. 
Pending block editor revisions for WordPress 5.4 will make use of `window.URL` and `window.DOMRect`. These are not available in Internet Explorer (or pre-Chromium Edge for `DOMRect`) and must be polyfilled to avoid script errors.

The changes make use of the existing polyfill pattern, and existing `polyfill-library` dependency. The dependency is bumped to the latest version, since the previous version did not include the `DOMRect` polyfill.

Props jorgefilipecosta.
Fixes #49360.

Built from https://develop.svn.wordpress.org/trunk@47238


git-svn-id: http://core.svn.wordpress.org/trunk@47038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 15:17:07 +00:00
Sergey Biryukov
c14f2b74c0 Privacy: Include session tokens in Personal Data Export. 
Session tokens contain an IP address and user agent.

Props garrett-eclipse, nickylimjj, lakenh, xkon, rconde.
Fixes #45889.
Built from https://develop.svn.wordpress.org/trunk@47237


git-svn-id: http://core.svn.wordpress.org/trunk@47037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 05:44:04 +00:00
Sergey Biryukov
346f505a75 Privacy: Include community-events-location user meta value in Personal Data Export. 
The value is used by the WordPress Events and News widget to show relevant WP community events.

The location information may include an IP address, location description, and latitude/longitude coordinates.

Props garrett-eclipse, coreymckrill, xkon.
Fixes #43921.
Built from https://develop.svn.wordpress.org/trunk@47236


git-svn-id: http://core.svn.wordpress.org/trunk@47036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 05:32:06 +00:00
Sergey Biryukov
d98fe66044 Site Health: Move the warning about WP_DEBUG_LOG being publicly accessible from "critical issues" to "recommended improvements" if the error log is outside of the WordPress directory. 
Props afragen, Clorith, miss_jwo, mikeschroder, kubiq, xkon.
Fixes #47985.
Built from https://develop.svn.wordpress.org/trunk@47235


git-svn-id: http://core.svn.wordpress.org/trunk@47035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 05:16:07 +00:00
Sergey Biryukov
4f151b577e Administration: Standardize "found in Trash" messages. 
Props Presskopp, audrasjb.
Fixes #38669.
Built from https://develop.svn.wordpress.org/trunk@47234


git-svn-id: http://core.svn.wordpress.org/trunk@47034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 04:57:06 +00:00
Sergey Biryukov
a6949956d1 Administration: Capitalize Trash consistently in various messages and comments. 
When used as a noun referring to the "virtual" place, `Trash` should be capitalized.

Props garrett-eclipse, aandrewdixon, Presskopp.
Fixes #45317.
Built from https://develop.svn.wordpress.org/trunk@47233


git-svn-id: http://core.svn.wordpress.org/trunk@47033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 04:12:07 +00:00
Sergey Biryukov
02ae343849 Login and Registration: Clarify the message on "Lost Password" screen. 
Props pbiron, Presskopp.
Fixes #49346.
Built from https://develop.svn.wordpress.org/trunk@47232


git-svn-id: http://core.svn.wordpress.org/trunk@47032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 03:50:05 +00:00
Sergey Biryukov
c1fb007ff3 Docs: Add documentation for globals in wp-settings.php. 
Props chinteshprajapati.
Fixes #46253.
Built from https://develop.svn.wordpress.org/trunk@47231


git-svn-id: http://core.svn.wordpress.org/trunk@47031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 03:34:05 +00:00
Sergey Biryukov
32edd58e4c Docs: Add descriptions for some globals: 
* `$wp_version`
* `$wp_local_package`
* `$required_php_version`
* `$required_mysql_version`

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47230


git-svn-id: http://core.svn.wordpress.org/trunk@47030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 03:30:06 +00:00
Andrew Ozz
e4f36258f9 Media: Ensure imgareaselect.js is not initialized twice for the same image. May happen when uploading an image into a post and then clicking on Edit Image. 
Fixes #49262.
Built from https://develop.svn.wordpress.org/trunk@47229


git-svn-id: http://core.svn.wordpress.org/trunk@47029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 02:54:05 +00:00
Sergey Biryukov
f13044b031 Editor: Add unique classes to .post-attributes-label-wrapper paragraphs for easier JS or CSS targeting. 
Props sathyapulse, sabernhardt, garrett-eclipse, noisysocks.
Fixes #44408.
Built from https://develop.svn.wordpress.org/trunk@47228


git-svn-id: http://core.svn.wordpress.org/trunk@47028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 02:29:06 +00:00
Sergey Biryukov
ddc8ddb294 Import: Remove "Blogroll" import option (for links in OPML format) from the list of popular importer plugins. 
Link Manager is disabled for new installations since WordPress 3.5, so core should not encourage importing links.

See #meta4706 for the corresponding WordPress.org API change.

Props Ipstenu, hareesh-pillai, DrewAPicture, nacin, karmatosed, dd32, garrett-eclipse.
Fixes #22994. See #21307.
Built from https://develop.svn.wordpress.org/trunk@47227


git-svn-id: http://core.svn.wordpress.org/trunk@47027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 02:12:06 +00:00
Sergey Biryukov
95edb66e53 Login and Registration: Use CSS animation instead of old JavaScript code for "shake" animation on login failure. 
Props markjaquith, valentinbora.
Fixes #48490.
Built from https://develop.svn.wordpress.org/trunk@47226


git-svn-id: http://core.svn.wordpress.org/trunk@47026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-10 01:52:04 +00:00
Sergey Biryukov
9bd75db1fc Build/Test Tools: Expose port 3306 of MySQL container. 
This only defines the container port to allow `docker-compose` to choose an ephemeral host port.

Props ocean90, peterwilsoncc.
Fixes #48281.
Built from https://develop.svn.wordpress.org/trunk@47225


git-svn-id: http://core.svn.wordpress.org/trunk@47025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-09 21:22:05 +00:00
TimothyBlynJacobs
5ecd61023a REST API: Introduce selective link embedding. 
Previously the _embed flag would embed all embeddable links in a response even if only a subset of the links were necessary. Now, a list of link relations can be passed in the _embed parameter to restrict the list of embedded objects.

Props rheinardkorf, adamsilverstein, jnylen0, cklosows, chrisvanpatten, TimothyBlynJacobs.
Fixes #39696.

Built from https://develop.svn.wordpress.org/trunk@47224


git-svn-id: http://core.svn.wordpress.org/trunk@47024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-09 20:54:05 +00:00
Aaron Jorbin
b21985f139 General: Fix HTML for get_calendar() 
The <tfoot> element was allowed to precede the <tbody> element in HTML 5. However, that was changed in HTML 5.1 and <tfoot> must now follow <tbody>.

This removes the tfooot and instead uses a nav element for navigation between months.

Fixes: #39763
Props: isabel_brison, Harry Milatz, audrasjb, abhijitrakas, SergeyBiryukov

Built from https://develop.svn.wordpress.org/trunk@47223


git-svn-id: http://core.svn.wordpress.org/trunk@47023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-09 20:44:04 +00:00
joedolson
61ce35440c Editor: Fix incorrect usage of ID attributes on custom fields. 
Repeated containers used for custom fields have duplicate ID attributes. Duplicate IDs are incorrect HTML, and will also cause unexpected results when trying to manipulate using JS. Duplicate IDs are changed to matching classes; CSS & JS updated to match. 

Props jankimoradiya, audrasjb, donmhico, afercia.
Fixes #46964.

Built from https://develop.svn.wordpress.org/trunk@47222


git-svn-id: http://core.svn.wordpress.org/trunk@47022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-09 19:41:07 +00:00
joedolson
1dbe25bc0a Toolbar: Load toolbar in wp_body_open when available. 
For accessibility, the visual appearance and source order should match. Moving the toolbar to load in the new hook `wp_body_open` (5.2) fixes a long-standing source order problem.

Props jankimoradiya, afercia, SergeyBiryukov, audrasjb, ocean90, xkon, dinhtungdu.
Fixes #47053.

Built from https://develop.svn.wordpress.org/trunk@47221


git-svn-id: http://core.svn.wordpress.org/trunk@47021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-09 18:26:08 +00:00
Sergey Biryukov
9429c8436d Coding Standards: Correct the get_plugin_page_hook() check in wp-admin/admin.php. 
The condition is meant to check for a non-empty string, however `get_plugin_page_hook()` can return null, in which case the strict check doesn't work as expected.

Follow-up to [47218].

See #48455, #49222.
Built from https://develop.svn.wordpress.org/trunk@47220


git-svn-id: http://core.svn.wordpress.org/trunk@47020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-09 17:08:03 +00:00
Sergey Biryukov
641c632b0c Coding Standards: Use Yoda conditions where appropriate. 
See #49222.
Built from https://develop.svn.wordpress.org/trunk@47219


git-svn-id: http://core.svn.wordpress.org/trunk@47019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-09 16:55:09 +00:00
Sergey Biryukov
5e6c949861 Coding Standards: Use Yoda conditions in some wp-admin files. 
Props subrataemfluence, marcio-zebedeu, bookdude13, 1naveengiri, alishankhan.
Fixes #44365, #48455.
Built from https://develop.svn.wordpress.org/trunk@47218


git-svn-id: http://core.svn.wordpress.org/trunk@47018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-09 16:53:06 +00:00
Andrea Fercia
f2edcb4421 Accessibility: Media: Make the toolbar and inline uploader visual order always match the DOM order. 
Depending on the specific media view, the media UI elements are placed in a
different visual order. This change makes sure their visual order always
matches the DOM order.

Propos syhc, audrasjb, afercia.
See #37188.
Fixes #48403.

Built from https://develop.svn.wordpress.org/trunk@47217


git-svn-id: http://core.svn.wordpress.org/trunk@47017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-09 16:32:04 +00:00
Sergey Biryukov
f454fc8165 Embeds: Add support for TikTok. 
Props audrasjb, jblz, peterwilsoncc, felipeloureirosantos.
Fixes #49083.
Built from https://develop.svn.wordpress.org/trunk@47216


git-svn-id: http://core.svn.wordpress.org/trunk@47016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-09 04:55:06 +00:00
Sergey Biryukov
e713bf9a88 Site Health: Only get MySQL server information in tests where it's actually needed. 
This resolves an issue with plugins like HyperDB, which doesn't have a database connection until a query is made.

Props xkon, Otto42, Clorith.
See #47606.
Built from https://develop.svn.wordpress.org/trunk@47215


git-svn-id: http://core.svn.wordpress.org/trunk@47015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-08 20:10:05 +00:00
Sergey Biryukov
297aa098ae Twenty Nineteen: Improve code organization in template-functions.php by moving helper functions into their own file. 
These functions are moved to `inc/helper-functions.php`:

* `twentynineteen_can_show_post_thumbnail()`
* `twentynineteen_image_filters_enabled()`
* `twentynineteen_get_avatar_size()`
* `twentynineteen_is_comment_by_post_author()`
* `twentynineteen_get_discussion_data()`
* `twentynineteen_hsl_hex()`

Additionally, `twentynineteen_add_dropdown_icons()` is moved to `inc/icon-functions.php` to join `twentynineteen_nav_menu_social_icons()`.

Props akshayar, allancole, grapplerulrich.
Fixes #45984.
Built from https://develop.svn.wordpress.org/trunk@47214


git-svn-id: http://core.svn.wordpress.org/trunk@47014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-08 13:01:06 +00:00
Sergey Biryukov
7748f7082f Menus: When adding a label for special pages in wp_setup_nav_menu_item(), check if get_post_states() is available, to avoid fatal errors on front end. 
Fixes #49374.
Built from https://develop.svn.wordpress.org/trunk@47213


git-svn-id: http://core.svn.wordpress.org/trunk@47013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-08 12:49:07 +00:00
Sergey Biryukov
8fa6586958 Tests: Add a basic test for wp() function. 
Props pbearne, donmhico.
Fixes #48844.
Built from https://develop.svn.wordpress.org/trunk@47212


git-svn-id: http://core.svn.wordpress.org/trunk@47012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-08 05:31:07 +00:00
Sergey Biryukov
b70056dd70 Menus: Use get_post_states() to denote special pages on the added menu item accordions. 
Front Page, Posts Page, or Privacy Policy Page should now be marked as such on the added menu items.

Props garrett-eclipse.
Fixes #49374.
Built from https://develop.svn.wordpress.org/trunk@47211


git-svn-id: http://core.svn.wordpress.org/trunk@47011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-07 23:46:05 +00:00
Sergey Biryukov
803feb30dd Docs: Improve description for the $editor_id parameter of wp_editor() and _WP_Editors::editor(). 
The restictions mentioned for the parameter value should be consistenct.

Props pbiron, SergeyBiryukov.
Fixes #49384.
Built from https://develop.svn.wordpress.org/trunk@47210


git-svn-id: http://core.svn.wordpress.org/trunk@47010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-07 23:30:05 +00:00
Sergey Biryukov
01f133ee28 Accessibility: Menus: Make tab panels in Add menu items section more accessible for keyboard users. 
Props audrasjb, afercia.
Fixes #49211.
Built from https://develop.svn.wordpress.org/trunk@47209


git-svn-id: http://core.svn.wordpress.org/trunk@47009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-07 21:38:06 +00:00
Sergey Biryukov
052b8ebdbe Accessibility: Customize: Improve focus styles for color picker and media upload button in Customizer. 
Props audrasjb, timhavinga, afercia, karmatosed.
Fixes #48694.
Built from https://develop.svn.wordpress.org/trunk@47208


git-svn-id: http://core.svn.wordpress.org/trunk@47008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-07 21:11:05 +00:00
Sergey Biryukov
b2a1146380 Coding Standards: Adjust coding standards to always omit parentheses for include/require statements. 
These are language constructs, not function calls, so the parentheses are unnecessary.

This updates the PHPCS configuration file the enforce the sniff until it is moved from the `WordPress-Extra` ruleset to the `WordPress-Core` ruleset upstream.

Follow-up to [47198].

Props desrosj, jrf, GaryJ.
Fixes #49376.
Built from https://develop.svn.wordpress.org/trunk@47207


git-svn-id: http://core.svn.wordpress.org/trunk@47007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-07 19:16:06 +00:00
John Blackbourn
1f1fd617f5 Posts, Post Types: Add a parameter to the post_locked_dialog action which contains a reference to the user who holds the lock. 
Fixes #48443
Built from https://develop.svn.wordpress.org/trunk@47206


git-svn-id: http://core.svn.wordpress.org/trunk@47006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-07 17:53:06 +00:00
John Blackbourn
71f099fdb0 Taxonomy: Clarify the docs for the return values of the term_exists() function. 
Props dotancohen, sathyapulse

Fixes #43345
Built from https://develop.svn.wordpress.org/trunk@47205


git-svn-id: http://core.svn.wordpress.org/trunk@47005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-07 17:48:09 +00:00
John Blackbourn
701ad95968 Script Loader: Fix a docblock so it points to the correct page on the developer reference. 
Props joyously, pbiron

Fixes #48503
Built from https://develop.svn.wordpress.org/trunk@47204


git-svn-id: http://core.svn.wordpress.org/trunk@47004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-07 17:42:06 +00:00
John Blackbourn
352ac8bf35 Posts, Post Types: Introduce a filter which allows the addition of __trashed suffixes on post slugs to be skipped. 
Fixes #46433
Built from https://develop.svn.wordpress.org/trunk@47203


git-svn-id: http://core.svn.wordpress.org/trunk@47003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-07 17:33:06 +00:00
Andrew Ozz
aea25de893 Media: Add link to the original image in the image properties if it was scaled or rotated after uploading. 
Fixes #49290.
Built from https://develop.svn.wordpress.org/trunk@47202


git-svn-id: http://core.svn.wordpress.org/trunk@47002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-07 05:13:05 +00:00
Sergey Biryukov
d1b39f784c Tests: Revert the dirname( __FILE__ ) replacement in wp-tests-config-sample.php for now, to avoid breaking unit tests created with WP-CLI scaffold command. 
Follow-up to [47198].

Props kaggdesign, danielbachhuber, bwmarkle.
Fixes #48082, #49377.
Built from https://develop.svn.wordpress.org/trunk@47201


git-svn-id: http://core.svn.wordpress.org/trunk@47001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-06 21:51:06 +00:00
Sergey Biryukov
b95cee937e Tests: Change a few remaining include_once statements to require_once, for consistency. 
See #48082.
Built from https://develop.svn.wordpress.org/trunk@47200


git-svn-id: http://core.svn.wordpress.org/trunk@47000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-06 21:42:06 +00:00
jorgefilipecosta
d69005e1d8 Block Editor: Update WordPress Packages. 
The following package versions were changed:
@wordpress/a11y: 2.6.0 -> 2.7.0
@wordpress/annotations: 1.10.0 -> 1.11.0
@wordpress/api-fetch: 3.9.0 -> 3.10.0
@wordpress/autop: 2.5.1 -> 2.6.0
@wordpress/blob: 2.6.0 -> 2.7.0
@wordpress/block-directory: 1.3.0 -> 1.4.0
@wordpress/block-editor: 3.5.0 -> 3.6.0
@wordpress/block-library: 2.12.0 -> 2.13.0
@wordpress/block-serialization-default-parser: 3.4.1 -> 3.5.0
@wordpress/blocks: 6.10.0 -> 6.11.0
@wordpress/components: 9.0.0 -> 9.1.0
@wordpress/compose: 3.10.0 -> 3.11.0
@wordpress/core-data: 2.10.0 -> 2.11.0
@wordpress/custom-templated-path-webpack-plugin: 1.5.0 -> 1.6.0
@wordpress/data: 4.12.0 -> 4.13.0
@wordpress/data-controls: 1.6.0 -> 1.7.0
@wordpress/date: 3.7.0 -> 3.8.0
@wordpress/dependency-extraction-webpack-plugin: 2.1.0 -> 2.2.0
@wordpress/deprecated: 2.6.1 -> 2.7.0
@wordpress/dom: 2.7.0 -> 2.8.0
@wordpress/dom-ready: 2.6.0 -> 2.7.0
@wordpress/e2e-test-utils: 4.1.0 -> 4.2.0
@wordpress/edit-post: 3.11.0 -> 3.12.0
@wordpress/editor: 9.10.0 -> 9.11.0
@wordpress/element: 2.10.0 -> 2.11.0
@wordpress/escape-html: 1.6.0 -> 1.7.0
@wordpress/format-library: 1.12.0 -> 1.13.0
@wordpress/hooks: 2.6.0 -> 2.7.0
@wordpress/html-entities: 2.5.0 -> 2.6.0
@wordpress/i18n: 3.8.0 -> 3.9.0
@wordpress/is-shallow-equal: 1.7.0 -> 1.8.0
@wordpress/keyboard-shortcuts: 0.2.0 -> 1.0.0
@wordpress/keycodes: 2.8.0 -> 2.9.0
@wordpress/library-export-default-webpack-plugin: 1.5.0 -> 1.6.0
@wordpress/list-reusable-blocks: 1.11.0 -> 1.12.0
@wordpress/media-utils: 1.5.0 -> 1.6.0
@wordpress/notices: 1.11.0 -> 1.12.0
@wordpress/nux: 3.10.0 -> 3.11.0
@wordpress/plugins: 2.10.0 -> 2.11.0
@wordpress/priority-queue: 1.4.0 -> 1.5.0
@wordpress/redux-routine: 3.6.2 -> 3.7.0
@wordpress/rich-text: 3.10.0 -> 3.11.0
@wordpress/scripts: 6.2.0 -> 7.0.0
@wordpress/server-side-render: 1.6.0 -> 1.7.0
@wordpress/shortcode: 2.5.0 -> 2.6.0
@wordpress/token-list: 1.8.0 -> 1.9.0
@wordpress/url: 2.9.0 -> 2.10.0
@wordpress/viewport: 2.11.0 -> 2.12.0
@wordpress/wordcount: 2.6.2 -> 2.7.0
Added these new packages:
@wordpress/warning
@wordpress/primitives
@wordpress/icons
Re-added keyboard-shortcuts to script loader removed by mistake on revision 47198.

Props gziolo, itsjonq, youknowriad, mcsf, andraganescu.
Fixes #49358.
Built from https://develop.svn.wordpress.org/trunk@47199


git-svn-id: http://core.svn.wordpress.org/trunk@46999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-06 21:03:31 +00:00
Sergey Biryukov
47ed56f38f Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 
This avoids the performance overhead of the function call every time `dirname( __FILE__ )` was used instead of `__DIR__`.

This commit also includes:

* Removing unnecessary parentheses from `include`/`require` statements. These are language constructs, not function calls.
* Replacing `include` statements for several files with `require_once`, for consistency:
 * `wp-admin/admin-header.php`
 * `wp-admin/admin-footer.php`
 * `wp-includes/version.php`

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.
Built from https://develop.svn.wordpress.org/trunk@47198


git-svn-id: http://core.svn.wordpress.org/trunk@46998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-06 06:33:11 +00:00
Sergey Biryukov
ecb8633dcc Coding Standards: Move WP_Object_Cache to wp-includes/class-wp-object-cache.php. 
This ensures the file containing the `WP_Object_Cache` class conforms to the coding standards.

For backward compatibility, the new file is included from `wp-includes/cache.php`.

Fixes #49373. See #49222.
Built from https://develop.svn.wordpress.org/trunk@47197


git-svn-id: http://core.svn.wordpress.org/trunk@46997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-06 05:53:06 +00:00
Sergey Biryukov
39e133bce8 Posts, Post Types: Add default menu_icon values for built-in post types. 
This allows the icons to be retrieved via `get_post_type_object()`.

Props m.usama.masood, michael.ecklund, SergeyBiryukov.
Fixes #38844.
Built from https://develop.svn.wordpress.org/trunk@47196


git-svn-id: http://core.svn.wordpress.org/trunk@46996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-05 22:40:05 +00:00
Sergey Biryukov
9bb7789f07 Tests: In Tests_dbDelta, only force MyISAM database engine on MySQL versions older than 5.7. 
Since MySQL 5.7, InnoDB engine supports `FULLTEXT` indexes, so forcing MyISAM is unnecessary.

Follow-up to [47193], which addressed the issue in `Tests_dbDelta::setUp()`, but missed other tests.

Props xkon, joonasvanhatapio, SergeyBiryukov.
Fixes #49367.
Built from https://develop.svn.wordpress.org/trunk@47195


git-svn-id: http://core.svn.wordpress.org/trunk@46995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-05 22:07:05 +00:00
Sergey Biryukov
9ed35cf902 Posts, Post Types: Change "Featured Image" post label to use sentence case: "Featured image". 
This makes it more consistent with other UI elements in the block editor.

Props mcsf.
Fixes #49371.
Built from https://develop.svn.wordpress.org/trunk@47194


git-svn-id: http://core.svn.wordpress.org/trunk@46994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-05 19:09:05 +00:00
Sergey Biryukov
6c1ee98e22 Tests: In Tests_dbDelta::setUp(), only force MyISAM database engine on MySQL versions older than 5.7. 
Since MySQL 5.7, InnoDB engine supports `FULLTEXT` indexes, so forcing MyISAM is unnecessary.

Props xkon, joonasvanhatapio, SergeyBiryukov.
Fixes #49367.
Built from https://develop.svn.wordpress.org/trunk@47193


git-svn-id: http://core.svn.wordpress.org/trunk@46993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-05 18:21:03 +00:00
ianbelanger
02d01de6c5 Bundled Themes: Twenty Twenty Menu rendering problem Unicode (Bangla). 
Fixes a bug where certain words break on to a second line in the primary and footer menus, in certain languages.

Props smallprogrammers, Shital Patel, mukesh27, audrasjb.
Fixes #48970.
Built from https://develop.svn.wordpress.org/trunk@47192


git-svn-id: http://core.svn.wordpress.org/trunk@46992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-05 15:02:05 +00:00
Sergey Biryukov
0544629460 Posts, Post Types: Wrap text submitted via Quick Draft dashboard widget in the Paragraph block. 
Props audrasjb, jeroenrotty.
Fixes #48120.
Built from https://develop.svn.wordpress.org/trunk@47191


git-svn-id: http://core.svn.wordpress.org/trunk@46991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-05 08:10:05 +00:00
Sergey Biryukov
44288356e2 Menus: Introduce wp_nav_menu_item_custom_fields action that fires just before the move buttons of a nav menu item in the menu editor. 
Props MikeSchinkel, birgire, sebastian.pisula, desrosj, helgatheviking.
Fixes #47056. See #38904, #18584.
Built from https://develop.svn.wordpress.org/trunk@47190


git-svn-id: http://core.svn.wordpress.org/trunk@46990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-05 07:43:05 +00:00
Sergey Biryukov
84c43d1863 Docs: Correct type for $item and $args parameters in Walker_Nav_Menu_Checklist and Walker_Nav_Menu_Edit to match the parent Walker_Nav_Menu` class. 
Follow-up to [38559], [45537].

See #24587, #48303.
Built from https://develop.svn.wordpress.org/trunk@47189


git-svn-id: http://core.svn.wordpress.org/trunk@46989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-05 07:25:05 +00:00
Sergey Biryukov
c32e05f308 Site Health: Improve focus style for accordion items on Site Health screens. 
The new style is more consistent with other elements like `.wp-core-ui` buttons.

Props audrasjb, mensmaximus, afercia, melchoyce, Clorith.
Fixes #48578.
Built from https://develop.svn.wordpress.org/trunk@47188


git-svn-id: http://core.svn.wordpress.org/trunk@46988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-05 06:43:04 +00:00
Sergey Biryukov
fa0563c877 Docs: Add a @since note for [47186]. 
See #48558.
Built from https://develop.svn.wordpress.org/trunk@47187


git-svn-id: http://core.svn.wordpress.org/trunk@46987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-05 06:33:04 +00:00
Sergey Biryukov
4f422b028d Taxonomy: In register_taxonomy(), return the registered taxonomy object on success, for consistency with register_post_type(). 
Props krynes, SergeyBiryukov.
Fixes #48558.
Built from https://develop.svn.wordpress.org/trunk@47186


git-svn-id: http://core.svn.wordpress.org/trunk@46986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-05 06:26:06 +00:00
Sergey Biryukov
b3f75c66f4 Coding Standards: Fix WPCS issue in [47184]. 
See #49344.
Built from https://develop.svn.wordpress.org/trunk@47185


git-svn-id: http://core.svn.wordpress.org/trunk@46985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-05 05:03:05 +00:00
Sergey Biryukov
0561e81ecc Tests: Allow dbDelta() tests to (mostly) run on MySQL 8.0.11+. 
* MySQL 8.0.11 changed the `GeometryCollection` data type name to `GeomCollection`, with the latter being the preferred name.
* MySQL 8.0.17 removed support for the display width attribute for integer data types. Previously, default display width of 20 digits was used: `BIGINT(20)`.

The affected tests now check the MySQL server version and use the appropriate data types.

This leaves one unresolved failure on MySQL 8.0.17+ to be addressed in the future, caused by the same `BIGINT` display width discrepancy coming from `wp_get_db_schema()`.

Props kaggdesign, ottok, jeremyfelt, SergeyBiryukov.
Fixes #44384, #49344. See #49364.
Built from https://develop.svn.wordpress.org/trunk@47184


git-svn-id: http://core.svn.wordpress.org/trunk@46984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-05 04:30:04 +00:00
Sergey Biryukov
ccdc1db0a9 Tests: Allow wpdb::set_sql_mode() tests to run on MySQL 8.0.11+. 
MySQL 8.0.11 removed support for the `NO_AUTO_CREATE_USER` SQL mode, which was used in as an example of a mode compatible with WordPress.

`NO_AUTO_VALUE_ON_ZERO` is now used in the affected tests instead, which is supported on both MySQL 5.7.x and 8.0.x.

Props kaggdesign, jeremyfelt, afragen.
Fixes #44586. See #49344.
Built from https://develop.svn.wordpress.org/trunk@47183


git-svn-id: http://core.svn.wordpress.org/trunk@46983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-05 03:30:05 +00:00
Sergey Biryukov
e2440d55e7 Docs: Clarify that is_page_template() accepts a template filename, not the Template Name file header. 
Props mkaz.
Fixes #49362.
Built from https://develop.svn.wordpress.org/trunk@47182


git-svn-id: http://core.svn.wordpress.org/trunk@46982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-05 03:14:06 +00:00
Sergey Biryukov
a16f3f8f13 Posts, Post Types: Fail gracefully when checking whether a single post with an unregistered post status should be displayed in WP_Query::get_posts(). 
If the post status is not registered, assume it's not public, but still allow access to users with edit permissions (same as for a protected post status, e.g. `draft`), so that they could recover orphaned content.

Add unit tests.

Follow-up to [47178].

Props roytanck, SergeyBiryukov.
Fixes #48653.
Built from https://develop.svn.wordpress.org/trunk@47181


git-svn-id: http://core.svn.wordpress.org/trunk@46981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-05 01:33:05 +00:00
Sergey Biryukov
da6f24fba9 Posts, Post Types: Revert [47179] pending test failures investigation. 
See #48653.
Built from https://develop.svn.wordpress.org/trunk@47180


git-svn-id: http://core.svn.wordpress.org/trunk@46980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-04 23:02:09 +00:00
Sergey Biryukov
73a088f5b6 Posts, Post Types: Fail gracefully when checking whether the post should be displayed in WP_Query::get_posts() against unregistered post status. 
If the post status is not registered, assume it's not public.

Follow-up to [47178].

Props roytanck.
See #48653.
Built from https://develop.svn.wordpress.org/trunk@47179


git-svn-id: http://core.svn.wordpress.org/trunk@46979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-04 22:22:06 +00:00
Sergey Biryukov
46951e0b17 Posts, Post Types: Fail gracefully when checking mapped cap against unregistered post status. 
With `map_meta_cap` enabled for a post type, the `read_post` capability for posts with a public status is supposed to be mapped to the post type's `read` capability.

When a post is left in the database after the post status is no longer present, and WP does a `read_post` check against it, a PHP notice was thrown, and the cap check always failed.

As a more graceful fallback, the cap is now mapped onto `edit_others_posts`, which allows highly privileged users to be able to access orphaned content.

A `_doing_it_wrong()` notice is also added, so that developers and site administrators are aware that the cap mapping is failing in the absence of the registered post status.

Follow-up to [34091], which introduced a similar approach to checking mapped caps against an unregistered post type.

Props roytanck, SergeyBiryukov.
Fixes #48653.
Built from https://develop.svn.wordpress.org/trunk@47178


git-svn-id: http://core.svn.wordpress.org/trunk@46978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-04 22:15:08 +00:00
Sergey Biryukov
3882b3f567 Coding Standards: Fix WPCS issues in [47175]. 
See #49361.
Built from https://develop.svn.wordpress.org/trunk@47177


git-svn-id: http://core.svn.wordpress.org/trunk@46977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-04 21:42:04 +00:00
jorgefilipecosta
d7e321c7c7 Block Editor: Include navigation block server logic. 
Core did not include the navigation block PHP files.
This commit fixes the issue referred, and now the navigation block is executed on the frontend. The block still does not work as expected and throws an error during frontend execution. That problem is going to be fixed on the next WordPress package update.
This commit adds the file as it is on the npm package used.

Props gziolo.
Fixes #49348.
Built from https://develop.svn.wordpress.org/trunk@47176


git-svn-id: http://core.svn.wordpress.org/trunk@46976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-04 20:16:04 +00:00
Sergey Biryukov
d3a9952838 Users: Pass the $reassign parameter to the remove_user_from_blog action. 
Props Tivus.
Fixes #49361.
Built from https://develop.svn.wordpress.org/trunk@47175


git-svn-id: http://core.svn.wordpress.org/trunk@46975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-04 19:43:03 +00:00
Sergey Biryukov
761644c636 Docs: Improve description for add_user_to_blog() and remove_user_from_blog() parameters. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47174


git-svn-id: http://core.svn.wordpress.org/trunk@46974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-04 19:40:06 +00:00
Sergey Biryukov
be057c4a1c Users: In remove_user_from_blog(): 
* Change default value of the `$blog_id` parameter to match the documented type.
* Change the type of the `$reassign` parameter for consistency with `$user_id` and `$blog_id`.
* Add documentation for the return value.

See #49361.
Built from https://develop.svn.wordpress.org/trunk@47173


git-svn-id: http://core.svn.wordpress.org/trunk@46973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-04 19:36:04 +00:00
Sergey Biryukov
e956bbebe1 TinyMCE: Remove duplicate keys and strings from langs/wp-langs-en.js. 
Props david.binda.
Fixes #49359.
Built from https://develop.svn.wordpress.org/trunk@47172


git-svn-id: http://core.svn.wordpress.org/trunk@46972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-04 16:43:07 +00:00
Sergey Biryukov
143c6a1de8 Database: Add ANSI to the list of incompatible SQL modes. 
Starting with MySQL 5.7.5, the `ANSI` mode implies `ONLY_FULL_GROUP_BY`, which is already listed in `wpdb` as incompatible per [27072].

When `ANSI` is enabled on MySQL 5.7.5+, `ONLY_FULL_GROUP_BY` remains enabled even after being "unset" by `wpdb::set_sql_mode()`.

To prevent this, the `ANSI` mode should also be listed as incompatible. It is not enabled on default MySQL installations.

Props jnylen0.
Fixes #48377.
Built from https://develop.svn.wordpress.org/trunk@47171


git-svn-id: http://core.svn.wordpress.org/trunk@46971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-04 01:14:07 +00:00
Sergey Biryukov
c289bb59ac Docs: Improve documentation for WP_Dependencies, WP_Scripts, and WP_Styles methods. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47170


git-svn-id: http://core.svn.wordpress.org/trunk@46970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-03 00:19:03 +00:00
Sergey Biryukov
982a6453c9 Canonical: When removing trailing punctuation from query string arguments, match the whole query var name. 
Props daveslaughter.
Fixes #49347.
Built from https://develop.svn.wordpress.org/trunk@47169


git-svn-id: http://core.svn.wordpress.org/trunk@46969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-03 00:14:07 +00:00
gziolo
bfc5248126 Build: Copy block metadata files for dynamic blocks. 
For dynamic blocks, there are several blocks whose metadata needs to be loaded in PHP. The attributes that are loaded via PHP are not exposed to the ReactNative components when Gutenberg loads the index.js files in the Mobile Apps. To support one master set of metadata that can be used to register in the PHP files and the Javascript files; with this patch, the block.json files are copied over with their corresponding PHP files.

Props chipsnyder and azaozz.

Fixes #49196.


Built from https://develop.svn.wordpress.org/trunk@47168


git-svn-id: http://core.svn.wordpress.org/trunk@46968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-02 19:19:04 +00:00
Sergey Biryukov
8163215dc4 Plugins: Remove obsolete plugin_slugs transient from WP_Plugins_List_Table::prepare_items(). 
The transient is only used in the `wp_dashboard_plugins_output()` function, which is deprecated and unused since [40607].

The function itself also sets the same transient, so it can be removed from `WP_Plugins_List_Table`.

Props aftabmuni.
Fixes #49340.
Built from https://develop.svn.wordpress.org/trunk@47167


git-svn-id: http://core.svn.wordpress.org/trunk@46967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-02 15:50:04 +00:00
Sergey Biryukov
e79f7f71aa REST API: Merge "not allowed to create new terms" permission error message with an existing string. 
Follow-up to [39309], [39313].

See #38857.
Built from https://develop.svn.wordpress.org/trunk@47166


git-svn-id: http://core.svn.wordpress.org/trunk@46966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-02 05:41:03 +00:00
Sergey Biryukov
f51b4579d5 Docs: Fix typo in a comment with WP_DEBUG_DISPLAY description. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47165


git-svn-id: http://core.svn.wordpress.org/trunk@46965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-02 05:34:05 +00:00
Sergey Biryukov
11fb46d4c6 Editor: Remove back-compat stub for Classic Editor's old distraction-free writing mode. 
The original script was deprecated in [30338] and removed in [32677].

Props Presskopp, ketuchetan.
Fixes #39448.
Built from https://develop.svn.wordpress.org/trunk@47164


git-svn-id: http://core.svn.wordpress.org/trunk@46964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-02 04:15:03 +00:00
Sergey Biryukov
9ce9450bf9 Tests: Adjust XML-RPC unit tests for [47160]. 
Follow-up to [47162].

See #40096.
Built from https://develop.svn.wordpress.org/trunk@47163


git-svn-id: http://core.svn.wordpress.org/trunk@46963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-02 04:09:04 +00:00
Sergey Biryukov
11dc73b383 Tests: Adjust XML-RPC unit tests for [47160]. 
See #40096.
Built from https://develop.svn.wordpress.org/trunk@47162


git-svn-id: http://core.svn.wordpress.org/trunk@46962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-02 03:32:04 +00:00
Sergey Biryukov
2f58dc5ce9 Docs: Add more specific description for WP_Http::processResponse() return value. 
Props marekdedic, takeshifurusato.
Fixes #48351.
Built from https://develop.svn.wordpress.org/trunk@47161


git-svn-id: http://core.svn.wordpress.org/trunk@46961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-02 03:27:05 +00:00
Sergey Biryukov
7e331ab235 Post Thumbnails: Make sure get_post_thumbnail_id() returns an integer, to match the documented return value. 
This makes the function more consistent with `get_the_ID()` or `wp_get_post_parent_id()`, both returning an integer.

Props 0v3rth3d4wn.
Fixes #40096.
Built from https://develop.svn.wordpress.org/trunk@47160


git-svn-id: http://core.svn.wordpress.org/trunk@46960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-02 03:08:04 +00:00
Sergey Biryukov
c94722d9bc Docs: Improve inline comments in wp-admin/options.php per the documentation standards. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47159


git-svn-id: http://core.svn.wordpress.org/trunk@46959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-02 02:42:04 +00:00
Sergey Biryukov
a0f8b7003b Administration: Include options page name in the "Options page not found" error message to provide better context for plugin developers. 
Props tdlewis77, williampatton.
Fixes #42941.
Built from https://develop.svn.wordpress.org/trunk@47158


git-svn-id: http://core.svn.wordpress.org/trunk@46958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-01 22:42:06 +00:00
Sergey Biryukov
8e37999368 Docs: Correct DocBlock formatting for register_setting(). 
Document the full list of whitelisted option key names.

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47157


git-svn-id: http://core.svn.wordpress.org/trunk@46957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-01 22:01:07 +00:00
Sergey Biryukov
deb1886078 Accessibility: Text Changes: Use sentence case for the word Error in various error messages, instead of all caps. 
Using all caps should be avoided for better readability and because screen readers may pronounce all-caps words as abbreviations.

Props afercia, ryokuhi, sabernhardt, garrett-eclipse.
See #47656, #43037, #42945.
Built from https://develop.svn.wordpress.org/trunk@47156


git-svn-id: http://core.svn.wordpress.org/trunk@46956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-01 21:38:04 +00:00
Sergey Biryukov
15a6accec4 Tests: Update the expected message in test_with_draft_post(). 
Follow-up to [47154].

See #42945.
Built from https://develop.svn.wordpress.org/trunk@47155


git-svn-id: http://core.svn.wordpress.org/trunk@46955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-01 21:13:05 +00:00
Sergey Biryukov
2fe7c95153 Text Changes: Capitalize error messages consistently. 
Props Presskopp.
Fixes #42945.
Built from https://develop.svn.wordpress.org/trunk@47154


git-svn-id: http://core.svn.wordpress.org/trunk@46954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-01 20:55:05 +00:00
Sergey Biryukov
12a6907123 Text Changes: Add missing periods to some error messages, for consistency. 
Props Presskopp.
Fixes #42735.
Built from https://develop.svn.wordpress.org/trunk@47153


git-svn-id: http://core.svn.wordpress.org/trunk@46953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-01 20:32:05 +00:00
Sergey Biryukov
21548ad0de Text Changes: Add missing periods to comment status update notices, for consistency. 
Props Presskopp.
See #42735.
Built from https://develop.svn.wordpress.org/trunk@47152


git-svn-id: http://core.svn.wordpress.org/trunk@46952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-01 20:29:05 +00:00
Sergey Biryukov
f65bc1401a Networks and Sites: Reduce max-width for user and site search inputs on Dashboard screen in Network Admin. 
This ensures that the inputs don't push the buttons to the next line.

Props williampatton, bordoni.
Fixes #49043.
Built from https://develop.svn.wordpress.org/trunk@47151


git-svn-id: http://core.svn.wordpress.org/trunk@46951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-01 17:38:03 +00:00
Sergey Biryukov
06979c6597 Docs: Document the addition of $json_report_pathname parameter to the wp_privacy_personal_data_export_file_created action. 
Follow-up to [47146].

Props xkon.
Fixes #49029.
Built from https://develop.svn.wordpress.org/trunk@47150


git-svn-id: http://core.svn.wordpress.org/trunk@46950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-01 04:17:05 +00:00
Sergey Biryukov
0aff1cf6bd Site Health: Rename WP_Site_Health::initialize() introduced in [47063] to ::get_instance(), for clarity and consistency with other core classes. 
Use `WP_Site_Health::get_instance()` where it's needed, instead of creating multiple instances of the class.

Props afercia, xkon, Clorith, SergeyBiryukov.
See #47606.
Built from https://develop.svn.wordpress.org/trunk@47149


git-svn-id: http://core.svn.wordpress.org/trunk@46949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-01 00:39:09 +00:00
Sergey Biryukov
3cd1514b91 Privacy: Clarify bulk action labels for personal data export and removal requests. 
Props garrett-eclipse, xkon, shariqkhan2012, websupporter, desrosj, JoshuaWold.
Fixes #44674.
Built from https://develop.svn.wordpress.org/trunk@47148


git-svn-id: http://core.svn.wordpress.org/trunk@46948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-31 03:43:05 +00:00
Sergey Biryukov
aef48b433b Accessibility: Privacy: Improve the readability of the suggested text in Privacy Policy Guide. 
Per WCAG 2.0 guidelines, big chunks of italic text should be avoided for better accessibility.

Props birgire, sabernhardt, xkon, garrett-eclipse, melchoyce, karmatosed, afercia, jepperask, SergeyBiryukov.
Fixes #44621. See #47327.
Built from https://develop.svn.wordpress.org/trunk@47147


git-svn-id: http://core.svn.wordpress.org/trunk@46947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-31 03:25:05 +00:00
Sergey Biryukov
39cef6947a Privacy: Introduce a JSON file into the personal data export. 
The produced ZIP archive will now include an `export.json` file along with the current `index.html`.

Props xkon.
Fixes #49029. See #46424.
Built from https://develop.svn.wordpress.org/trunk@47146


git-svn-id: http://core.svn.wordpress.org/trunk@46946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-31 01:36:05 +00:00
Sergey Biryukov
d0a0825809 Site Health: Add support for required WordPress and PHP versions to themes. 
Follow-up to [45546] for plugins.

Props flixos90, afragen.
Fixes #44592. See #40934, #meta3718.
Built from https://develop.svn.wordpress.org/trunk@47145


git-svn-id: http://core.svn.wordpress.org/trunk@46945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-31 01:17:04 +00:00
Sergey Biryukov
eafc40be6d Privacy: Remove user's email address from personal data export filename. 
Use `wp_unique_filename()` to avoid potential collisions instead.

Props xkon, garrett-eclipse, donmhico, Ov3rfly, Clorith, allendav.
Fixes #44197.
Built from https://develop.svn.wordpress.org/trunk@47144


git-svn-id: http://core.svn.wordpress.org/trunk@46944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-31 00:58:06 +00:00
Sergey Biryukov
4f67024da6 Administration: Add punctuation to "If you change this, we will send you an email" message on General Settings, Network Settings, and Profile screens. 
Props kinjaldalwadi, donmhico.
Fixes #49235.
Built from https://develop.svn.wordpress.org/trunk@47143


git-svn-id: http://core.svn.wordpress.org/trunk@46943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-31 00:28:04 +00:00
Sergey Biryukov
6c05771d55 HTTP API: Add some basic tests for wp_remote_fopen(). 
Props pbearne, donmhico.
Fixes #48845.
Built from https://develop.svn.wordpress.org/trunk@47142


git-svn-id: http://core.svn.wordpress.org/trunk@46942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-31 00:22:05 +00:00
Sergey Biryukov
60f5fa9367 Tests: Rename wpValidateBoolean.php for consistency with other files. 
See #30238.
Built from https://develop.svn.wordpress.org/trunk@47141


git-svn-id: http://core.svn.wordpress.org/trunk@46941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-31 00:16:04 +00:00
Sergey Biryukov
3b9cddaea5 Twenty Nineteen: Remove duplicate font-size property. 
The theme does not use a `px` fallback for `rem` units anywhere else.

Follow-up to [47053] for Twenty Twenty.

See #49015.
Built from https://develop.svn.wordpress.org/trunk@47140


git-svn-id: http://core.svn.wordpress.org/trunk@46940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-31 00:09:08 +00:00
ianbelanger
9fc09b2720 Fixes PHPCS Introduced in [47135]. 
There was extra whitespace in the previous commit, this removes it.

See #48552
Built from https://develop.svn.wordpress.org/trunk@47139


git-svn-id: http://core.svn.wordpress.org/trunk@46939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-30 21:55:05 +00:00
K. Adam White
b78819c3fa REST API: Reuse previously-generated embedded objects when building collection response. 
Store each generated embedded object in a temporary cache when querying for linked resources so that repeated links to the same resource do not trigger repeated queries or processing.

Props TimothyBlynJacobs.
Fixes #48838.


Built from https://develop.svn.wordpress.org/trunk@47138


git-svn-id: http://core.svn.wordpress.org/trunk@46938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-30 20:22:07 +00:00
Sergey Biryukov
d80131190f Twenty Nineteen: Standardize the Required PHP and Tested Up To headers. 
* Remove `WordPress` from `Requires at least` headers.
* Ensure the `Requires at least` and `Requires PHP` headers are present in the `style.css` file.

Follow-up to [46676], which updated `style-rtl.css`, but not `style.scss` or `style.css`.

See #48517.
Built from https://develop.svn.wordpress.org/trunk@47136


git-svn-id: http://core.svn.wordpress.org/trunk@46936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-30 20:04:05 +00:00
ianbelanger
dae1032531 Bundled Themes: Twenty Twenty add theme support for responsive embeds. 
Adds the call to `responsive-embed` theme support in order to fix issues with facebook embeds not being responsive at certain screen widths.

Props williampatton, nielslange.
Fixes #48552.
Built from https://develop.svn.wordpress.org/trunk@47135


git-svn-id: http://core.svn.wordpress.org/trunk@46935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-30 19:21:07 +00:00
Sergey Biryukov
46a08859d0 Themes: Replace &mdash; with &ndash; as a separator between Monday and Friday in theme starter content. 
The `ndash` standardly is the "through" indicator for showing inclusive dates and numbers, while the `mdash` is an interruptor and used as an aside.

Props mikejdent, garrett-eclipse.
Fixes #48286.
Built from https://develop.svn.wordpress.org/trunk@47134


git-svn-id: http://core.svn.wordpress.org/trunk@46934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-30 19:17:06 +00:00
ianbelanger
481bbb3128 Bundled Themes: Twenty Twenty content font CSS selector is too important. 
This makes the font family selector for `entry-content` less specific and thus easier to override.

Props alexandreb3, larrach, audrasjb.
Fixes #49318.
Built from https://develop.svn.wordpress.org/trunk@47133


git-svn-id: http://core.svn.wordpress.org/trunk@46933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-30 18:28:07 +00:00
Sergey Biryukov
d3c032bc35 Dashboard: Improve the appearance of "WordPress Events and News" dashboard widget for multi-day events. 
If an upcoming event spans over several days, this information is now properly reflected in the widget.

Props imath, casiepa, iandunn, hareesh-pillai, melchoyce, mapk, desrosj, audrasjb, SergeyBiryukov.
Fixes #47798.
Built from https://develop.svn.wordpress.org/trunk@47124


git-svn-id: http://core.svn.wordpress.org/trunk@46924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-29 02:19:08 +00:00
Sergey Biryukov
b2ffea836b Docs: Fix typos in wp-admin/includes/class-pclzip.php. 
With the upstream library not updated in 10 years since the last time it was merged, it should be safe to treat it as "adopted" rather than external, and make these fixes.

Props passoniate, ottok.
Fixes #49163. See #38464.
Built from https://develop.svn.wordpress.org/trunk@47123


git-svn-id: http://core.svn.wordpress.org/trunk@46923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-29 00:56:04 +00:00
Sergey Biryukov
001ffe81fb Docs: Improve inline comments per the documentation standards. 
Includes minor code layout fixes for better readability.

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47122


git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-29 00:45:18 +00:00
Sergey Biryukov
e336b24edd Docs: Improve DocBlocks in phpunit/includes/object-cache.php per the documentation standards. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47121


git-svn-id: http://core.svn.wordpress.org/trunk@46921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-29 00:39:04 +00:00
Sergey Biryukov
395ee12145 Docs: Improve comments in js/_enqueues/wp/revisions.js per the documentation standards. 
Props passoniate.
Fixes #49177.
Built from https://develop.svn.wordpress.org/trunk@47120


git-svn-id: http://core.svn.wordpress.org/trunk@46920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-29 00:37:04 +00:00
Sergey Biryukov
037a736757 Docs: Improve comments in some wp-admin files per the documentation standards. 
Follow-up to [47084].

Props passoniate, apedog.
Fixes #49223, #49227.
Built from https://develop.svn.wordpress.org/trunk@47119


git-svn-id: http://core.svn.wordpress.org/trunk@46919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-29 00:35:08 +00:00
Sergey Biryukov
cfb79b15c3 Coding Standards: Disable WPCS warnings for date_default_timezone_set() and current_time( 'timestamp' ) calls in Date/Time tests. 
These calls are intentional and required for the tests.

See #49222.
Built from https://develop.svn.wordpress.org/trunk@47118


git-svn-id: http://core.svn.wordpress.org/trunk@46918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-28 00:53:05 +00:00
Sergey Biryukov
2c1d3770fa Docs: Fix typo in a comment in js/media/models/attachment.js. 
Props wptoolsdev.
Fixes #49303.
Built from https://develop.svn.wordpress.org/trunk@47117


git-svn-id: http://core.svn.wordpress.org/trunk@46917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-27 14:44:08 +00:00
Sergey Biryukov
50edbd537e Customize: Fix typo in CustomHeader.prototype.initialize() DocBlock in src/js/_enqueues/wp/custom-header.js. 
Props ankitmaru.
Fixes #49301.
Built from https://develop.svn.wordpress.org/trunk@47116


git-svn-id: http://core.svn.wordpress.org/trunk@46916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-27 14:33:05 +00:00
Sergey Biryukov
e65032ff6b Coding Standards: Use strict comparison in wp-admin/user/admin.php. 
Apply the case-insensitive network-site comparisons added in [27725] for `wp-admin/network/admin.php` to `wp-admin/user/admin.php` too, for consistency.

Props rimadoshi.
Fixes #49300.
Built from https://develop.svn.wordpress.org/trunk@47115


git-svn-id: http://core.svn.wordpress.org/trunk@46915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-27 14:30:05 +00:00
Sergey Biryukov
c7bab2b410 Comments: Add In reply to: %s parent comment link to new comment email notifications. 
This information was previously available on the Moderate Comment screen in the admin, but was missing from moderation emails.

Props imath, danieltj, andraganescu, galbaras, SergeyBiryukov.
Fixes #43805. See #43429.
Built from https://develop.svn.wordpress.org/trunk@47114


git-svn-id: http://core.svn.wordpress.org/trunk@46914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-27 04:33:04 +00:00
Sergey Biryukov
b79e042b00 Docs: Remove extra trailing spaces from wp_add_privacy_policy_content() DocBlock to fix WPCS issues, apply minor formatting changes for consistency. 
Follow-up to [47112].

See #49282.
Built from https://develop.svn.wordpress.org/trunk@47113


git-svn-id: http://core.svn.wordpress.org/trunk@46913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-27 01:06:04 +00:00
Andrew Ozz
516629964c Privacy: Cleanup .wp-policy-help CSS remnants and add back-compat when hiding the tutorial content before copying. 
Props garrett-eclipse.
Fixes #49282.
Built from https://develop.svn.wordpress.org/trunk@47112


git-svn-id: http://core.svn.wordpress.org/trunk@46912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-26 23:02:03 +00:00
Sergey Biryukov
1c3b5c9dc8 Comments: Add In reply to %s. prefix to child comments in comments feed. 
The prefix includes a link to the parent comment and the name of its author.

Props zodiac1978, imath, SergeyBiryukov.
Fixes #43429.
Built from https://develop.svn.wordpress.org/trunk@47111


git-svn-id: http://core.svn.wordpress.org/trunk@46911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-26 22:29:06 +00:00
Sergey Biryukov
c9c2ff21f5 Twenty Twenty: Remove unnecessary escaping of get_the_title() in comments.php. 
For users with the `unfiltered_html` capability, titles can contain legitimate markup.

The title is filtered on saving, so the content in the database is considered safe.

Props kjellr, joyously, peterwilsoncc.
Fixes #49190.
Built from https://develop.svn.wordpress.org/trunk@47110


git-svn-id: http://core.svn.wordpress.org/trunk@46910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-25 22:06:07 +00:00
Sergey Biryukov
b8d10d8b63 Docs: Improve documentation for add_user_to_blog(), add_existing_user_to_blog(), and add_new_user_to_blog(). 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47109


git-svn-id: http://core.svn.wordpress.org/trunk@46909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-24 17:20:07 +00:00
Andrea Fercia
6b4368669d Toolbar: Remove leftover @since notations after [46678]. 
See #19647.

Built from https://develop.svn.wordpress.org/trunk@47108


git-svn-id: http://core.svn.wordpress.org/trunk@46908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-23 12:59:06 +00:00
Sergey Biryukov
c67b2c235a Cache API: Remove WP_Object_Cache::__destruct() and wpdb::__destruct(). 
Originally added in [4686], these constructor/destructor pairings were designed to prevent the objects from being destroyed before shutdown, when output buffers are flushed.

A deeper investigation reveals that this approach didn't quite work as expected and was later made redundant by introducing `wp_ob_end_flush_all()` in [5462].

Props wonderboymusic, nacin, Mte90, SergeyBiryukov.
Fixes #21402.
Built from https://develop.svn.wordpress.org/trunk@47107


git-svn-id: http://core.svn.wordpress.org/trunk@46907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-23 00:27:05 +00:00
jorgefilipecosta
48299521c6 Block Editor: Update WordPress Packages. 
The following package versions were changed:
@wordpress/a11y: 2.5.1 -> 2.6.0
@wordpress/annotations: 1.9.0 -> 1.10.0
@wordpress/api-fetch: 3.8.0 -> 3.9.0
@wordpress/blob: 2.5.1 -> 2.6.0
@wordpress/block-directory: 1.2.0 -> 1.3.0
@wordpress/block-editor: 3.4.0 -> 3.5.0
@wordpress/block-library: 2.11.0 -> 2.12.0
@wordpress/blocks: 6.9.0 -> 6.10.0
@wordpress/components: 8.5.0 -> 9.0.0
@wordpress/compose: 3.9.0 -> 3.10.0
@wordpress/core-data: 2.9.0 -> 2.10.0
@wordpress/data: 4.11.0 -> 4.12.0
@wordpress/data-controls: 1.5.0 -> 1.6.0
@wordpress/dom: 2.6.0 -> 2.7.0
@wordpress/dom-ready: 2.5.1 -> 2.6.0
@wordpress/e2e-test-utils: 4.0.0 -> 4.1.0
@wordpress/edit-post: 3.10.0 -> 3.11.0
@wordpress/editor: 9.9.0 -> 9.10.0
@wordpress/format-library: 1.11.0 -> 1.12.0
@wordpress/i18n: 3.7.0 -> 3.8.0
@wordpress/is-shallow-equal: 1.6.1 -> 1.7.0
@wordpress/keycodes: 2.7.0 -> 2.8.0
@wordpress/list-reusable-blocks: 1.10.0 -> 1.11.0
@wordpress/media-utils: 1.4.0 -> 1.5.0
@wordpress/notices: 1.10.0 -> 1.11.0
@wordpress/nux: 3.9.0 -> 3.10.0
@wordpress/plugins: 2.9.0 -> 2.10.0
@wordpress/priority-queue: 1.3.1 -> 1.4.0
@wordpress/rich-text: 3.9.0 -> 3.10.0
@wordpress/scripts: 6.1.1 -> 6.2.0
@wordpress/server-side-render: 1.5.0 -> 1.6.0
@wordpress/viewport: 2.10.0 -> 2.11.0
The following package was added:
@wordpress/keyboard-shortcuts

Props gziolo.
Fixes #49204.
Built from https://develop.svn.wordpress.org/trunk@47106


git-svn-id: http://core.svn.wordpress.org/trunk@46906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-22 22:06:21 +00:00
iandunn
2974f78157 Multisite: Add $context parameter to switch_blog action. 
The action is fired by both `switch_to_blog()` and `restore_current_blog()`, and previously it was difficult for callback functions to determine which function had fired it.

Props SergeyBiryukov, johnbillion, jeremyfelt.
Fixes #49265.

Built from https://develop.svn.wordpress.org/trunk@47105


git-svn-id: http://core.svn.wordpress.org/trunk@46905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-22 20:53:05 +00:00
Sergey Biryukov
f34eef4437 Docs: Expand @return value description for wp_loginout(), wp_register(), get_calendar(). 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47104


git-svn-id: http://core.svn.wordpress.org/trunk@46904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-22 00:57:03 +00:00
Sergey Biryukov
6cf32058ff Docs: Expand @return description for the_terms(). 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47103


git-svn-id: http://core.svn.wordpress.org/trunk@46903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-22 00:41:06 +00:00
Sergey Biryukov
cfa3dc8ee8 Docs: Correct @return value for parent_dropdown(). 
Follow-up to [47100].

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47102


git-svn-id: http://core.svn.wordpress.org/trunk@46902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-22 00:33:04 +00:00
Sergey Biryukov
c3f9af4f00 Docs: Adjust documentation for some pre_* filters for consistency. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47101


git-svn-id: http://core.svn.wordpress.org/trunk@46901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-22 00:25:04 +00:00
Sergey Biryukov
eb513c5ac8 Docs: Adjust @return value of parent_dropdown() for consistency with other dropdown functions. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47100


git-svn-id: http://core.svn.wordpress.org/trunk@46900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-22 00:22:03 +00:00
Sergey Biryukov
381df97419 Docs: Correct @return value for update_core() and Core_Upgrader::upgrade(). 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47099


git-svn-id: http://core.svn.wordpress.org/trunk@46899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-22 00:19:04 +00:00
Sergey Biryukov
46dd0a79f6 Date/Time: In wp_maybe_decline_date(), add support for a range of days, e.g. February 21–23. 
A potential use case is displaying multi-day events in the WordPress Events and News dashboard widget.

See #47798, #48934.
Built from https://develop.svn.wordpress.org/trunk@47098


git-svn-id: http://core.svn.wordpress.org/trunk@46898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-21 23:48:04 +00:00
Sergey Biryukov
95f5cecd77 Docs: Expand @return value description for wp_nav_menu(). 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47097


git-svn-id: http://core.svn.wordpress.org/trunk@46897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-21 20:13:05 +00:00
Sergey Biryukov
dd79e6e107 Docs: Correct DocBlock formatting for filters accepting the $parsed_args parameter. 
Follow-up to [45667].

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47096


git-svn-id: http://core.svn.wordpress.org/trunk@46896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-21 15:41:04 +00:00
Sergey Biryukov
185e36d428 I18N: Merge duplicate "you must be logged in to comment" strings. 
Props ramiy.
Fixes #49251.
Built from https://develop.svn.wordpress.org/trunk@47095


git-svn-id: http://core.svn.wordpress.org/trunk@46895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-21 14:52:06 +00:00
Sergey Biryukov
6730b3f716 I18N: Synchronize MediaElement.js translation strings with the currently bundled version. 
Some strings were previously removed in [43345] and accidentally reintroduced in [44163].

Props ramiy.
Fixes #49249. See #42139, #37453.
Built from https://develop.svn.wordpress.org/trunk@47094


git-svn-id: http://core.svn.wordpress.org/trunk@46894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-21 02:21:05 +00:00
Sergey Biryukov
60c651ad6a I18N: Add missing placeholders to some translators comments in wp-admin. 
Props ramiy.
Fixes #49248.
Built from https://develop.svn.wordpress.org/trunk@47093


git-svn-id: http://core.svn.wordpress.org/trunk@46893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-20 15:43:04 +00:00
Sergey Biryukov
c946a71d9d I18N: Correct translator comment in wp-admin/options-permalink.php. 
Props ramiy.
Fixes #49247.
Built from https://develop.svn.wordpress.org/trunk@47092


git-svn-id: http://core.svn.wordpress.org/trunk@46892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-20 15:10:04 +00:00
Sergey Biryukov
cf249b07ed I18N: Merge duplicate %1$s is not of type %2$s strings in rest_validate_value_from_schema(). 
Props ramiy.
Fixes #49244.
Built from https://develop.svn.wordpress.org/trunk@47091


git-svn-id: http://core.svn.wordpress.org/trunk@46891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-20 14:44:06 +00:00
Sergey Biryukov
1adca958e3 I18N: Remove unnecessary HTML from "Active:" strings in wp-admin/themes.php. 
Follow-up to [45435].

Props ramiy.
Fixes #49243.
Built from https://develop.svn.wordpress.org/trunk@47090


git-svn-id: http://core.svn.wordpress.org/trunk@46890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-20 14:27:04 +00:00
Sergey Biryukov
d5be8f0635 I18N: Correct translator comments in WP_Users_List_Table::get_views() to provide information about each placeholder. 
Props ramiy.
Fixes #49242.
Built from https://develop.svn.wordpress.org/trunk@47089


git-svn-id: http://core.svn.wordpress.org/trunk@46889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-20 14:08:05 +00:00
Sergey Biryukov
2900bb8ea7 Docs: Update links to https://secure.php.net/, they now redirect to https://www.php.net/. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47088


git-svn-id: http://core.svn.wordpress.org/trunk@46888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-20 03:14:06 +00:00
Sergey Biryukov
f9b0dfbb8b Docs: Correct description for shortcode_atts_{$shortcode} filter. 
Props glebkema.
Fixes #49225.
Built from https://develop.svn.wordpress.org/trunk@47087


git-svn-id: http://core.svn.wordpress.org/trunk@46887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-19 13:41:08 +00:00
Sergey Biryukov
bb5765e951 Mail: Remove angle brackets from password reset URL in emails sent by retrieve_password() and wp_new_user_notification(). 
The brackets were originally added in [16285] per W3C recommendation in https://www.w3.org/Addressing/URL/5.1_Wrappers.html to avoid wrapping the URL across multiple lines in plain text in older email clients.

This doesn't seem like a common issue in modern email clients, and the current implementation causes more issues than it solves. Since the URL is on a line by itself, it should not require any delimiters.

The URL in recovery mode email introduced in [44973] doesn't have angle brackets, so it's time to retire them in password reset email too if they're not used consistently.

Props donmhico, Otto42, sproutchris, iandunn, dd32, DaveWP196, sebastian.pisula, tommix, sablednah, julian.kimmig, Rahe, clayisland, arenddeboer, nicole2292, nagoke, squarecandy, eatingrules, SergeyBiryukov.
Fixes #21095, #23578, #44589.
Built from https://develop.svn.wordpress.org/trunk@47086


git-svn-id: http://core.svn.wordpress.org/trunk@46886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-18 02:32:06 +00:00
Sergey Biryukov
89f5d3dd0c Networks and Sites: Clarify the recommendation to remove the www prefix from the site domain before creating a network. 
The `siteurl` option reference was not quite clear, and the string actually refers to the domain name, not the full URL.

Props kharisblank, tobifjellner, ramiy.
Fixes #49214.
Built from https://develop.svn.wordpress.org/trunk@47085


git-svn-id: http://core.svn.wordpress.org/trunk@46885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-18 01:15:04 +00:00
Sergey Biryukov
053a9cd5b8 Docs: Improve comments in some wp-admin files per the documentation standards. 
Props passoniate.
Fixes #49215, #49216.
Built from https://develop.svn.wordpress.org/trunk@47084


git-svn-id: http://core.svn.wordpress.org/trunk@46884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-18 00:54:04 +00:00
Sergey Biryukov
1cfc32af58 Coding Standards: Remove unnecessary // phpcs:ignore instances in WP_Debug_Data. 
`WP_Theme::__get()` accepts `Name`, `Version`, and `Author` theme properties in lower case too.

Additionally, remove one short ternary instance, not allowed per the coding standards.

See #49222.
Built from https://develop.svn.wordpress.org/trunk@47083


git-svn-id: http://core.svn.wordpress.org/trunk@46883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-18 00:26:06 +00:00
Sergey Biryukov
0f47f2b9e5 Widgets: Remove extra padding from number inputs in Recent Posts and Recent Comments widgets. 
Props marcio-zebedeu, audrasjb, SergeyBiryukov.
Fixes #49195.
Built from https://develop.svn.wordpress.org/trunk@47082


git-svn-id: http://core.svn.wordpress.org/trunk@46882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-17 13:57:03 +00:00
Sergey Biryukov
82f41c5afc Date/Time: Add some basic tests for current_time(). 
Props pbearne, talldanwp, SergeyBiryukov.
Fixes #34378.
Built from https://develop.svn.wordpress.org/trunk@47081


git-svn-id: http://core.svn.wordpress.org/trunk@46881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-17 02:52:05 +00:00
Sergey Biryukov
d84c987e16 Tests: Replace date() with gmdate() in WP_Test_REST_Posts_Controller tests. 
Follow-up to [45424], [46252].

See #46438, #44491, #39953.
Built from https://develop.svn.wordpress.org/trunk@47080


git-svn-id: http://core.svn.wordpress.org/trunk@46880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-17 02:04:04 +00:00
Sergey Biryukov
5c358b8f19 Tests: Update the wp_maybe_decline_date() tests for [47078]. 
See #48934.
Built from https://develop.svn.wordpress.org/trunk@47079


git-svn-id: http://core.svn.wordpress.org/trunk@46879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-17 01:16:04 +00:00
Sergey Biryukov
a370d1a9c0 Date/Time: Pass the date format to wp_maybe_decline_date(). 
This ensures that the function has enough context to determine the necessity of replacing the month name with the correct form in locales that require it.

Props SergeyBiryukov, Rarst.
Fixes #48934.
Built from https://develop.svn.wordpress.org/trunk@47078


git-svn-id: http://core.svn.wordpress.org/trunk@46878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-17 01:12:04 +00:00
Sergey Biryukov
e884aca67b Tests: Revert [47076], this should have been committed with the related changes to the function. 
Built from https://develop.svn.wordpress.org/trunk@47077


git-svn-id: http://core.svn.wordpress.org/trunk@46877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-17 01:10:04 +00:00
Sergey Biryukov
c883c65e3c Tests: Move wp_maybe_decline_date() tests to the date directory. 
See #48934.
Built from https://develop.svn.wordpress.org/trunk@47076


git-svn-id: http://core.svn.wordpress.org/trunk@46876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-17 00:56:07 +00:00
Sergey Biryukov
45286c5bb3 Accessibility: Login and Registration: Add a role="main" landmark to the container div in wp-signup.php. 
Props SteelWagstaff, audrasjb.
Fixes #48657.
Built from https://develop.svn.wordpress.org/trunk@47075


git-svn-id: http://core.svn.wordpress.org/trunk@46875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-16 03:44:05 +00:00
Sergey Biryukov
06f90e098a Login and Registration: Remove duplicate <label> tag from show_blog_form() in wp-signup.php. 
Props vaishalipanchal, audrasjb.
Fixes #49174.
Built from https://develop.svn.wordpress.org/trunk@47074


git-svn-id: http://core.svn.wordpress.org/trunk@46874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-16 00:34:05 +00:00
Sergey Biryukov
691adde1e6 Date/Time: Use wp_date() to display the correct time of the next DST transition in Timezone setting on General Settings screen. 
Props Rarst, autotutorial.
Fixes #49038.
Built from https://develop.svn.wordpress.org/trunk@47073


git-svn-id: http://core.svn.wordpress.org/trunk@46873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-16 00:28:06 +00:00
Sergey Biryukov
3e68a63e6a Editor: Correct vertical alignment for "Published on" month dropdown in Classic Editor. 
Props pratik-jain, justinahinon, audrasjb.
Fixes #49115.
Built from https://develop.svn.wordpress.org/trunk@47072


git-svn-id: http://core.svn.wordpress.org/trunk@46872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-15 18:31:07 +00:00
Sergey Biryukov
57fbd3c847 File Editor: Remove extra padding on submit button for "Select plugin/theme to edit" dropdown on smaller screens. 
Props passoniate.
Fixes #49197.
Built from https://develop.svn.wordpress.org/trunk@47071


git-svn-id: http://core.svn.wordpress.org/trunk@46871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-15 00:23:07 +00:00
Sergey Biryukov
569ff9dd27 Upgrade/Install: Correct vertical alignment for "Continue" button on language selection during the install process. 
Props garrett-eclipse, audrasjb.
Fixes #49018.
Built from https://develop.svn.wordpress.org/trunk@47070


git-svn-id: http://core.svn.wordpress.org/trunk@46870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-14 01:11:03 +00:00
Sergey Biryukov
10ae398727 Site Health: Avoid "Undefined property" PHP notices in wp_dashboard_site_health() when the status result transient does not exist yet. 
Props dlh for initial patch.
See #47606.
Built from https://develop.svn.wordpress.org/trunk@47069


git-svn-id: http://core.svn.wordpress.org/trunk@46869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-13 17:27:06 +00:00
Sergey Biryukov
4a9c0e35e1 Cron API: Use WEEK_IN_SECONDS constant for the weekly schedule added in [47062]. 
Props afercia.
See #47606.
Built from https://develop.svn.wordpress.org/trunk@47068


git-svn-id: http://core.svn.wordpress.org/trunk@46868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-13 17:05:07 +00:00
Sergey Biryukov
f18b173674 Networks and Sites: Use warning styles for 'Caution' and 'Warning' messages during Multisite installation. 
Props dlh.
Fixes #49186.
Built from https://develop.svn.wordpress.org/trunk@47067


git-svn-id: http://core.svn.wordpress.org/trunk@46867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-13 17:00:06 +00:00
Sergey Biryukov
9fa4cce9c2 Docs: Correct description for show_in_admin_all_list and show_in_admin_status_list arguments of register_post_status(). 
Props audrasjb.
Fixes #49180.
Built from https://develop.svn.wordpress.org/trunk@47066


git-svn-id: http://core.svn.wordpress.org/trunk@46866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-13 00:50:02 +00:00
Sergey Biryukov
fa2f6e0644 Docs: Improve documentation for wp_save_image_file() and related functions. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47065


git-svn-id: http://core.svn.wordpress.org/trunk@46865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-12 16:56:05 +00:00
Sergey Biryukov
810a243f2d Tests: In Tests_Site_Health, create a WP_Site_Health instance before clearing the cron array, as the constructor schedules its own task now. 
See #47606.
Built from https://develop.svn.wordpress.org/trunk@47064


git-svn-id: http://core.svn.wordpress.org/trunk@46864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-12 14:18:03 +00:00
Sergey Biryukov
2c4480958b Site Health: Introduce Site Health Status dashboard widget. 
The widget informs administrators of any potential issues that should be addressed to improve the performance or security of their website, and directs them to the Site Health screen for more details.

Props Clorith, hedgefield, guddu1315.
See #47606.
Built from https://develop.svn.wordpress.org/trunk@47063


git-svn-id: http://core.svn.wordpress.org/trunk@46863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-12 13:33:05 +00:00
Sergey Biryukov
26ce3c9f19 Cron API: Add a new cron schedule for weekly events. 
Props Clorith.
See #47606.
Built from https://develop.svn.wordpress.org/trunk@47062


git-svn-id: http://core.svn.wordpress.org/trunk@46862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-12 11:20:04 +00:00
Sergey Biryukov
f8a5ae6b93 Upgrade/Install: Remove the suggestion for users to skip a minor update to keep their current translation. 
With the introduction of asynchronous translation updates in WordPress 3.7+, the suggestion is no longer relevant.

Props casiepa, danieltj, tobifjellner, netweb.
Fixes #43242.
Built from https://develop.svn.wordpress.org/trunk@47061


git-svn-id: http://core.svn.wordpress.org/trunk@46861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-12 02:24:03 +00:00
Sergey Biryukov
dd4d98a368 Docs: In various @return tags, list the expected type first, instead of false. 
Follow-up to [46696].

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47060


git-svn-id: http://core.svn.wordpress.org/trunk@46860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-11 18:32:05 +00:00
Sergey Biryukov
2294d65753 Docs: Synchronize @return descriptions for ::handle_row_actions() methods in list tables. 
Make sure `WP_Comments_List_Table::handle_row_actions()` and `WP_MS_Sites_List_Table::handle_row_actions()` return a string, for consistency with other classes.

See #49170, #48303.
Built from https://develop.svn.wordpress.org/trunk@47059


git-svn-id: http://core.svn.wordpress.org/trunk@46859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-11 17:59:04 +00:00
Sergey Biryukov
d469aa8162 Docs: Correct @return description for WP_List_Table::handle_row_actions(). 
Props pbiron.
Fixes #49170.
Built from https://develop.svn.wordpress.org/trunk@47058


git-svn-id: http://core.svn.wordpress.org/trunk@46858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-11 17:57:03 +00:00
Sergey Biryukov
6a3deacf86 Docs: Correct @return type for Theme_Upgrader::check_parent_theme_filter(). 
Props diddledan.
Fixes #48570.
Built from https://develop.svn.wordpress.org/trunk@47057


git-svn-id: http://core.svn.wordpress.org/trunk@46857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-11 02:46:05 +00:00
Sergey Biryukov
77aa5d1604 Docs: Remove a reference to WordPress 2.7 from readme.html. 
Props afercia, donmhico.
Fixes #47963.
Built from https://develop.svn.wordpress.org/trunk@47056


git-svn-id: http://core.svn.wordpress.org/trunk@46856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-10 14:05:05 +00:00
Sergey Biryukov
a94ed9baf3 Docs: Remove @return void from widget DocBlocks. 
Per the documentation standards, it should not be used outside of the default bundled themes.

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47055


git-svn-id: http://core.svn.wordpress.org/trunk@46855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-10 00:30:05 +00:00
Sergey Biryukov
d784ebbcb4 Coding Standards: Use strict comparison and Yoda conditions in the root directory files. 
Props pikamander2.
Fixes #48965.
Built from https://develop.svn.wordpress.org/trunk@47054


git-svn-id: http://core.svn.wordpress.org/trunk@46854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-09 00:55:05 +00:00
desrosj
a24f5ccd1f Bundled Themes: Remove duplicate font-size property in Twenty Twenty. 
Props ankitmaru.
Fixes #49015.


Built from https://develop.svn.wordpress.org/trunk@47053


git-svn-id: http://core.svn.wordpress.org/trunk@46853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-08 16:50:04 +00:00
Sergey Biryukov
cef48881f0 Docs: Correct alphabetic order of parameters in WP_Query::parse_query() DocBlock. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47052


git-svn-id: http://core.svn.wordpress.org/trunk@46852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-08 12:10:04 +00:00
jorgefilipecosta
80ce372761 Block Editor: Update WordPress Packages. 
Updated packages:
@wordpress/annotations: 1.7.2 -> 1.9.0
@wordpress/api-fetch: 3.6.4 -> 3.8.0
@wordpress/block-directory: 1.0.5 -> 1.2.0
@wordpress/block-editor: 3.2.5 -> 3.4.0
@wordpress/block-library: 2.9.6 -> 2.11.0
@wordpress/blocks: 6.7.2 -> 6.9.0
@wordpress/components: 8.3.2 -> 8.5.0
@wordpress/compose: 3.7.2 -> 3.9.0
@wordpress/core-data: 2.7.5 -> 2.9.0
@wordpress/data: 4.9.2 -> 4.11.0
@wordpress/data-controls: 1.3.4 -> 1.5.0
@wordpress/date: 3.5.0 -> 3.7.0
@wordpress/dom: 2.5.2 -> 2.6.0
@wordpress/e2e-test-utils: 3.0.0 -> 4.0.0
@wordpress/edit-post: 3.8.6 -> 3.10.0
@wordpress/editor: 9.7.6 -> 9.9.0
@wordpress/element: 2.8.2 -> 2.10.0
@wordpress/escape-html: 1.5.1 -> 1.6.0
@wordpress/format-library: 1.9.5 -> 1.11.0
@wordpress/i18n: 3.6.1 -> 3.7.0
@wordpress/keycodes: 2.6.2 -> 2.7.0
@wordpress/list-reusable-blocks: 1.8.4 -> 1.10.0
@wordpress/media-utils: 1.2.4 -> 1.4.0
@wordpress/notices: 1.8.2 -> 1.10.0
@wordpress/nux: 3.7.2 -> 3.9.0
@wordpress/plugins: 2.7.2 -> 2.9.0
@wordpress/rich-text: 3.7.2 -> 3.9.0
@wordpress/scripts: 6.0.0 -> 6.1.1
@wordpress/server-side-render: 1.3.4 -> 1.5.0
@wordpress/shortcode: 2.4.1 -> 2.5.0
@wordpress/token-list: 1.6.1 -> 1.8.0
@wordpress/url: 2.8.2 -> 2.9.0
@wordpress/viewport: 2.8.2 -> 2.10.0

Props gziolo, youknowriad.
Fixes #49142.
Built from https://develop.svn.wordpress.org/trunk@47051


git-svn-id: http://core.svn.wordpress.org/trunk@46851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-08 11:57:23 +00:00
Sergey Biryukov
ea6e0cc3ca Coding Standards: Use Yoda conditions in wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php. 
Props jenilk.
Fixes #49150.
Built from https://develop.svn.wordpress.org/trunk@47050


git-svn-id: http://core.svn.wordpress.org/trunk@46850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-08 11:32:02 +00:00
Sergey Biryukov
967f43a6cb Docs: Indicate that load_script_textdomain_relative_path filter value can be false. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47049


git-svn-id: http://core.svn.wordpress.org/trunk@46849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-08 00:27:04 +00:00
gziolo
572f1725d9 Build Tools: do not include assets for JS dependencies that do not exist. 
This is a follow-up for #48154, where we started including *.asset.php files to declare package dependencies.
This works well but creates warnings in environments where the package does not exist because WordPress was not fully built.

Props jeherve, swissspidy.

Fixes #49144.


Built from https://develop.svn.wordpress.org/trunk@47048


git-svn-id: http://core.svn.wordpress.org/trunk@46848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-07 15:28:05 +00:00
Sergey Biryukov
d3d630c98a Site Health: Make sure the "Copied!" text is vertically centered to the "Copy site info to clipboard" button. 
Props garrett-eclipse.
Fixes #49139.
Built from https://develop.svn.wordpress.org/trunk@47047


git-svn-id: http://core.svn.wordpress.org/trunk@46847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-07 00:09:04 +00:00
Sergey Biryukov
ce48d7502c REST API: Display the actual conflicting value in addition to the taxonomy name in the _doing_it_wrong() message for a conflicting rest_base or name property. 
Follow-up to [47037] and [47045].

Props TimothyBlynJacobs.
See #48401.
Built from https://develop.svn.wordpress.org/trunk@47046


git-svn-id: http://core.svn.wordpress.org/trunk@46846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-06 17:09:04 +00:00
Sergey Biryukov
a540d748d3 REST API: Display the taxonomy name in the _doing_it_wrong() message for a conflicting rest_base or name property, to match the translator comment. 
Follow-up to [47037].

See #48401.
Built from https://develop.svn.wordpress.org/trunk@47045


git-svn-id: http://core.svn.wordpress.org/trunk@46845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-06 16:47:02 +00:00
Sergey Biryukov
28639fc8d5 I18N: Replace rest_authentication_errors filter name with a placeholder in a translatable string. 
Follow-up to [38947] and [40038].

See #38446.
Built from https://develop.svn.wordpress.org/trunk@47044


git-svn-id: http://core.svn.wordpress.org/trunk@46844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-06 16:21:04 +00:00
Sergey Biryukov
667f26b3af I18N: Replace php.ini, post_max_size, and upload_max_filesize with placeholders in "File is empty" error message. 
Props ramiy.
Fixes #48868.
Built from https://develop.svn.wordpress.org/trunk@47043


git-svn-id: http://core.svn.wordpress.org/trunk@46843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-06 16:16:03 +00:00
Dominik Schilling
918dead27e Docs: Remove duplicate inline comment in wp_mail(). 
See [5639].
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47042


git-svn-id: http://core.svn.wordpress.org/trunk@46842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-06 14:51:05 +00:00
Sergey Biryukov
0be749362a Docs: Improve documentation for tests/phpunit/includes/testcase-ajax.php. 
Props andizer, SergeyBiryukov.
Fixes #47568.
Built from https://develop.svn.wordpress.org/trunk@47041


git-svn-id: http://core.svn.wordpress.org/trunk@46841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-05 15:33:00 +00:00
Dominik Schilling
c89dab8c98 Media: After [46375], enable JavaScript translations for the media-views script. 
See #49134.
Built from https://develop.svn.wordpress.org/trunk@47040


git-svn-id: http://core.svn.wordpress.org/trunk@46840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-05 13:11:04 +00:00
Sergey Biryukov
6a3a0b519c Docs: Fix typo in media_post_single_attachment_fields_to_edit() description. 
Props mukesh27.
Fixes #49131.
Built from https://develop.svn.wordpress.org/trunk@47039


git-svn-id: http://core.svn.wordpress.org/trunk@46839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-04 18:00:06 +00:00
Sergey Biryukov
7ad56f1237 Coding Standards: Add missing braces to if conditions in js/_enqueues/wp/customize/base.js. 
Props ankitmaru.
Fixes #49122.
Built from https://develop.svn.wordpress.org/trunk@47038


git-svn-id: http://core.svn.wordpress.org/trunk@46838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-04 01:28:05 +00:00
K. Adam White
08f53ef906 REST API: Issue doing_it_wrong if a taxonomy's specified rest_base is already in use by a different resource. 
Props fgiannar, TimothyBlynJacobs, kingkool68, SergeyBiryukov.
Fixes #48401.


Built from https://develop.svn.wordpress.org/trunk@47037


git-svn-id: http://core.svn.wordpress.org/trunk@46837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-03 19:24:03 +00:00
K. Adam White
7660fcda61 REST API: Short-circuit comment controller permissions check if commented-upon post type does not exist. 
Props imani3011, dragosh635, subrataemfluence, timothyblynjacobs.
Fixes #42238.


Built from https://develop.svn.wordpress.org/trunk@47036


git-svn-id: http://core.svn.wordpress.org/trunk@46836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-03 18:44:03 +00:00
gziolo
355c05ea71 Build Tools: Integrate DependencyExtractionWebpackPlugin in the JS build. 
This patch integrates DependencyExtractionWebpackPlugin which was battle-tested in Gutenberg. 

This will greatly simplify the process of upgrading npm packages which change after every Gutenberg release. It might even useful during the WordPress release cycle as we might need to publish more often as we discover critical bugs and regressions.

Props jonsurrell, adamsilverstein, youknowriad, ocean90, netweb.

Fixes #48154. 


Built from https://develop.svn.wordpress.org/trunk@47035


git-svn-id: http://core.svn.wordpress.org/trunk@46835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-03 13:17:24 +00:00
Sergey Biryukov
9bec6f1e54 REST API: Synchronize permission checks in ::get_items_permissions_check() methods for post types, post statuses, and users: 
* Only query post types with `'show_in_rest' => true` instead of looping over all post types and checking the `show_in_rest` property separately.
* Return from the `foreach()` loop as soon as the permission check succeeded.

Props pbiron, TimothyBlynJacobs, SergeyBiryukov.
Fixes #49118.
Built from https://develop.svn.wordpress.org/trunk@47034


git-svn-id: http://core.svn.wordpress.org/trunk@46834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-03 02:28:03 +00:00
Sergey Biryukov
ba033e96ef Link Manager: Use a strict in_array() check in wp-links-opml.php. 
Props dkarfa.
Fixes #49106.
Built from https://develop.svn.wordpress.org/trunk@47033


git-svn-id: http://core.svn.wordpress.org/trunk@46833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-03 01:14:02 +00:00
Sergey Biryukov
523bf256ef Docs: Synchronize "Default empty array" notes for $args parameter in get_comment_text() and comment_text(). 
Props denisco.
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47032


git-svn-id: http://core.svn.wordpress.org/trunk@46832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-02 19:22:03 +00:00
Sergey Biryukov
8ec3da8a25 Site Health: Fix typo in a variable name in js/_enqueues/admin/site-health.js. 
Props nickylimjj.
Fixes #49112.
Built from https://develop.svn.wordpress.org/trunk@47031


git-svn-id: http://core.svn.wordpress.org/trunk@46831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-02 12:11:02 +00:00
Sergey Biryukov
9571033894 Coding Standards: Move assignment out of condition in js/media/controllers/library.js. 
Props ankitmaru.
Fixes #49108.
Built from https://develop.svn.wordpress.org/trunk@47030


git-svn-id: http://core.svn.wordpress.org/trunk@46830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-02 12:07:02 +00:00
Sergey Biryukov
d3a14b7719 Coding Standards: Move assignment out of condition in js/media/views/settings.js. 
Props ankitmaru.
Fixes #49107.
Built from https://develop.svn.wordpress.org/trunk@47029


git-svn-id: http://core.svn.wordpress.org/trunk@46829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-02 12:02:02 +00:00
Sergey Biryukov
f2e464f8c1 Coding Standards: Use strict comparison in wp-comments-post.php. 
Props dkarfa.
Fixes #49105.
Built from https://develop.svn.wordpress.org/trunk@47028


git-svn-id: http://core.svn.wordpress.org/trunk@46828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-02 11:42:01 +00:00
Sergey Biryukov
b9353dbf70 Coding Standards: Use strict comparison and Yoda conditions in wp-includes/widgets.php. 
Props jenilk.
Fixes #49104.
Built from https://develop.svn.wordpress.org/trunk@47027


git-svn-id: http://core.svn.wordpress.org/trunk@46827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-02 11:37:05 +00:00
Sergey Biryukov
3fe8bdfca7 Happy New Year! 
Update copyright year to 2020 in bundled themes' `readme.txt`.
Built from https://develop.svn.wordpress.org/trunk@47026


git-svn-id: http://core.svn.wordpress.org/trunk@46826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-01 03:53:01 +00:00
Sergey Biryukov
c856ffcd0a Happy New Year! 
Update copyright year to 2020 in `license.txt`.
Built from https://develop.svn.wordpress.org/trunk@47025


git-svn-id: http://core.svn.wordpress.org/trunk@46825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-01 02:19:06 +00:00
Sergey Biryukov
6357cae029 Docs: Fix typo in _crop_image_resource() DocBlock. 
Props mukesh27.
Fixes #49103.
Built from https://develop.svn.wordpress.org/trunk@47024


git-svn-id: http://core.svn.wordpress.org/trunk@46824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-31 12:34:01 +00:00
Sergey Biryukov
a2f5c24d36 Docs: Add missing descriptions and @return tags for _WP_Editors::get_mce_locale() and ::get_baseurl(). 
Props adnan.limdi.
Fixes #41869.
Built from https://develop.svn.wordpress.org/trunk@47023


git-svn-id: http://core.svn.wordpress.org/trunk@46823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-31 01:31:02 +00:00
Sergey Biryukov
7174c2a0c7 Docs: Add missing @since tags for wp-includes/class-wp-editor.php. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47022


git-svn-id: http://core.svn.wordpress.org/trunk@46822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-31 01:25:03 +00:00
Sergey Biryukov
09e7a72ec2 Docs: Fix typo in .env file description. 
Props mujuonly, dkarfa.
Fixes #49095.
Built from https://develop.svn.wordpress.org/trunk@47021


git-svn-id: http://core.svn.wordpress.org/trunk@46821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-30 13:48:03 +00:00
Sergey Biryukov
fef26f8d1f Coding Standards: Fix WPCS issue in [47019]. 
See #49091.
Built from https://develop.svn.wordpress.org/trunk@47020


git-svn-id: http://core.svn.wordpress.org/trunk@46820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-29 22:32:00 +00:00
Sergey Biryukov
7590296984 Twenty Twenty: Remove extra space from arrow-down-circled icon name in TwentyTwenty_SVG_Icons::$ui_icons. 
Props kitchin.
Fixes #49091.
Built from https://develop.svn.wordpress.org/trunk@47019


git-svn-id: http://core.svn.wordpress.org/trunk@46819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-29 20:45:06 +00:00
Sergey Biryukov
d858656023 Bootstrap/Load: Make handling the /favicon.ico requests more flexible. 
Previously, `wp_favicon_request()` was introduced in [13205] to avoid a performance hit of serving a full 404 page on every favicon request.

While working as intended, that implementation did not provide a way for theme or plugin authors to manage the behavior of favicon requests.

This changeset implements the following logic (only applied if WordPress is installed in the root directory):

* If there is a Site Icon set in Customizer, redirect `/favicon.ico` requests to that icon.
* Otherwise, use the WordPress logo as a default icon.
* If a physical `/favicon.ico` file exists, do nothing, let the server handle the request.

Handling `/favicon.ico` is now more consistent with handling `/robots.txt` requests.

New functions and hooks:

* Introduce `is_favicon()` conditional tag to complement `is_robots()`.
* Introduce `do_favicon` action to complement `do_robots` and use it in template loader.
* Introduce `do_favicon()` function, hooked to the above action by default, to complement `do_robots()`.
* Introduce `do_faviconico` action to complement `do_robotstxt`, for plugins to override the default behavior.
* Mark `wp_favicon_request()` as deprecated in favor of `do_favicon()`.

Props jonoaldersonwp, birgire, joostdevalk, mukesh27, SergeyBiryukov.
Fixes #47398.
Built from https://develop.svn.wordpress.org/trunk@47018


git-svn-id: http://core.svn.wordpress.org/trunk@46818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-28 21:20:04 +00:00
Sergey Biryukov
c546aa36ec Docs: Improve @return description for wp_update_comment() and WP_UnitTest_Factory_For_Comment::update_object(). 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47017


git-svn-id: http://core.svn.wordpress.org/trunk@46817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-27 00:30:02 +00:00
Sergey Biryukov
7970e62c06 Coding Standards: Fix WPCS issue in [47015]. 
See #49082.
Built from https://develop.svn.wordpress.org/trunk@47016


git-svn-id: http://core.svn.wordpress.org/trunk@46816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-26 15:53:02 +00:00
Sergey Biryukov
7c2275dfe4 Docs: Fix typo in wp_dashboard_cached_rss_widget() documentation. 
Props mukesh27.
Fixes #49082.
Built from https://develop.svn.wordpress.org/trunk@47015


git-svn-id: http://core.svn.wordpress.org/trunk@46815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-26 14:42:03 +00:00
Sergey Biryukov
a814d6e363 Tests: Set network_id instead of site_id in WP_UnitTest_Factory_For_Blog defaults. 
Follow-up to [47011], [47013].

See #47195.
Built from https://develop.svn.wordpress.org/trunk@47014


git-svn-id: http://core.svn.wordpress.org/trunk@46814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-26 00:27:03 +00:00
Sergey Biryukov
5e236248e4 Tests: Update legacy arguments passed to WP_UnitTest_Factory_For_Blog::create_object(). 
This converts the arguments originally meant for `wpmu_create_blog()` to the ones used by `wp_insert_site()`.

Follow-up to [47011].

Fixes #47195.
Built from https://develop.svn.wordpress.org/trunk@47013


git-svn-id: http://core.svn.wordpress.org/trunk@46813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-25 21:41:02 +00:00
Sergey Biryukov
cf54349cb7 Tests: Replace most instances of wpmu_delete_blog() not specifically testing that function with wp_delete_site(). 
Follow-up to [47011].

See #47195.
Built from https://develop.svn.wordpress.org/trunk@47012


git-svn-id: http://core.svn.wordpress.org/trunk@46812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-25 18:17:01 +00:00
Sergey Biryukov
e2231ec703 Tests: Switch WP_UnitTest_Factory_For_Blog::create_object() to use wp_insert_site(). 
Map some arguments for backward compatibility with `wpmu_create_blog()` previously used there.

Props davidbaumwald, danielbachhuber, jeremyfelt, SergeyBiryukov.
See #47195.
Built from https://develop.svn.wordpress.org/trunk@47011


git-svn-id: http://core.svn.wordpress.org/trunk@46811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-25 18:12:02 +00:00
Sergey Biryukov
8990cf9296 Media: Make sure attachment_url_to_postid() performs a case-sensitive search for the uploaded file name. 
Previously, the first available match was returned, regardless of the case, which was not always the expected result.

Props archon810, ben.greeley, tristangemus, vsamoletov, SergeyBiryukov.
Fixes #39768.
Built from https://develop.svn.wordpress.org/trunk@47010


git-svn-id: http://core.svn.wordpress.org/trunk@46810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-25 02:26:03 +00:00
Sergey Biryukov
8073fd3ec0 Docs: Use a third-person singular verb for comment template function descriptions, per the documentation standards. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47009


git-svn-id: http://core.svn.wordpress.org/trunk@46809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-24 16:19:01 +00:00
Sergey Biryukov
9c68816a21 Docs: Improve documentation for get_comment_author_url(). 
Props stevenlinx.
Fixes #49076.
Built from https://develop.svn.wordpress.org/trunk@47008


git-svn-id: http://core.svn.wordpress.org/trunk@46808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-24 16:10:05 +00:00
Sergey Biryukov
bb70f4e530 Docs: Correct the note about the CORE_UPGRADE_SKIP_NEW_BUNDLED constant in $_new_bundled_files global description. 
In order to tell WordPress not to install new bundled themes on update, `CORE_UPGRADE_SKIP_NEW_BUNDLED` should be set to `true`, as the name suggests, not `false`.

Follow-up to [39064].

Props tomgreer, knutsp, crdunst.
See #49056.
Built from https://develop.svn.wordpress.org/trunk@47007


git-svn-id: http://core.svn.wordpress.org/trunk@46807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-23 18:00:02 +00:00
Sergey Biryukov
246a035d99 Docs: Improve documentation for admin menu functions: 
* `get_admin_page_parent()`
* `get_admin_page_title()`
* `get_plugin_page_hook()`
* `get_plugin_page_hookname()`
* `user_can_access_admin_page()`

Add missing descriptions and `@since` tags.

Props subrataemfluence, kennithnichol, stevenlinx, SergeyBiryukov.
Fixes #44253, #49067.
Built from https://develop.svn.wordpress.org/trunk@47006


git-svn-id: http://core.svn.wordpress.org/trunk@46806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-23 14:36:04 +00:00
Sergey Biryukov
f501814eac Upgrade/Install: When creating the .htaccess file in insert_with_markers(), make sure it has 0644 as a minimum set of permissions. 
Props rcutmore, dd32, i3anaan.
Fixes #40572.
Built from https://develop.svn.wordpress.org/trunk@47005


git-svn-id: http://core.svn.wordpress.org/trunk@46805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-22 02:45:03 +00:00
Sergey Biryukov
9b3a895631 Shortcodes: Introduce apply_shortcodes() as an alias for do_shortcode(). 
This better aligns with the semantics of applying filters to the input and returning a result, rather than performing an action and outputting to the current buffer.

Props ljasinskipl, thefarlilacfield.
Fixes #37422.
Built from https://develop.svn.wordpress.org/trunk@47004


git-svn-id: http://core.svn.wordpress.org/trunk@46804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-21 20:12:03 +00:00
Sergey Biryukov
5e8fe89ef5 Shortcodes: Make sure wp.shortcode.string() accepts the attrs array keys in any order. 
Props yale01, georgestephanis, adamsilverstein, zsusag, mircoraffinetti, SergeyBiryukov.
Fixes #36263.
Built from https://develop.svn.wordpress.org/trunk@47003


git-svn-id: http://core.svn.wordpress.org/trunk@46803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-21 18:34:04 +00:00
Sergey Biryukov
27d9bac051 Administration: Add doing_wp_cron to wp_removable_query_args(). 
It's a single-use URL parameter that does not need to be passed to canonical URLs in the admin.

Props dlh.
Fixes #49017.
Built from https://develop.svn.wordpress.org/trunk@47002


git-svn-id: http://core.svn.wordpress.org/trunk@46802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-21 16:14:04 +00:00
Sergey Biryukov
7b70f584a7 Tests: Don't fail the test in WP_UnitTestCase_Base::skipOnAutomatedBranches() if Travis environment variables are unavailable, it prevents from running the test locally. 
Follow-up to [47000].

See #49050.
Built from https://develop.svn.wordpress.org/trunk@47001


git-svn-id: http://core.svn.wordpress.org/trunk@46801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-20 12:15:04 +00:00
Sergey Biryukov
01b91b2a0f Tests: Correct the check for pull requests in WP_UnitTestCase_Base::skipOnAutomatedBranches(). 
Mark the test as failed if the environment variables are unavailable.

Fixes #49050.
Built from https://develop.svn.wordpress.org/trunk@47000


git-svn-id: http://core.svn.wordpress.org/trunk@46800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-20 01:12:01 +00:00
Sergey Biryukov
a5deda7083 Build/Test Tools: Pass the TRAVIS_BRANCH and TRAVIS_PULL_REQUEST environment variables along to the Docker container. 
This ensures that `WP_UnitTestCase::skipOnAutomatedBranches()` has access to these variables.

See #49050, #47767.
Built from https://develop.svn.wordpress.org/trunk@46999


git-svn-id: http://core.svn.wordpress.org/trunk@46799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-20 00:03:01 +00:00
Sergey Biryukov
d391a2633c Tests: Skip external HTTP test for recommended PHP and MySQL versions on 503 errors. 
Fixes #49049.
Built from https://develop.svn.wordpress.org/trunk@46998


git-svn-id: http://core.svn.wordpress.org/trunk@46798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-19 20:29:01 +00:00
whyisjake
464615e876 Editor: Add unit tests for v5.3.1 block serialization functions 
r46896 was intended to have included unit tests for the block serialization functions added as part of the changeset.

Props: @aduth.
Fixes: #49048 


Built from https://develop.svn.wordpress.org/trunk@46997


git-svn-id: http://core.svn.wordpress.org/trunk@46797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-19 18:50:01 +00:00
Sergey Biryukov
5d5bf01d12 Tests: In test_readme(), if the HTTP request to secure.php.net or dev.mysql.com failed, include response code in the error message. 
See #40533, #44613.
Built from https://develop.svn.wordpress.org/trunk@46996


git-svn-id: http://core.svn.wordpress.org/trunk@46796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-19 15:45:05 +00:00
Sergey Biryukov
c677634788 Tests: Remove unused cache keys from data_get_site_caches(). 
Follow-up to [46990].

See #40363.
Built from https://develop.svn.wordpress.org/trunk@46991


git-svn-id: http://core.svn.wordpress.org/trunk@46791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-18 03:22:02 +00:00
Sergey Biryukov
5f6a36ceb6 Networks and Sites: Remove invalidation of unused cache keys in clean_blog_cache(). 
Props spacedmonkey, flixos90, thamaraiselvam.
Fixes #40363.
Built from https://develop.svn.wordpress.org/trunk@46990


git-svn-id: http://core.svn.wordpress.org/trunk@46790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-18 02:59:02 +00:00
Sergey Biryukov
4edec193bc Users: When creating the first user on installation, populate the Website profile field with the site URL. 
Skip setting the field if the user already exists, which is the case when the user tables are being shared among multiple sites.

Props EFAREM, eclare, darrenlambert, zachflauaus, viralsampat.
Fixes #35778.
Built from https://develop.svn.wordpress.org/trunk@46989


git-svn-id: http://core.svn.wordpress.org/trunk@46789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-18 02:26:03 +00:00
Sergey Biryukov
694913d65f I18N: Make the minimum input length to start searching posts in the "Insert/edit link" modal localizable. 
Props Toro_Unit, birgire, miyauchi, swissspidy, ocean90.
Fixes #44662.
Built from https://develop.svn.wordpress.org/trunk@46988


git-svn-id: http://core.svn.wordpress.org/trunk@46788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-18 01:15:03 +00:00
Sergey Biryukov
6e7080036f Docs: Improve comments in tests/formatting/redirect.php per the documentation standards. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46987


git-svn-id: http://core.svn.wordpress.org/trunk@46787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-18 00:28:01 +00:00
Sergey Biryukov
8c709ed78c Docs: Add @method notation for WP_UnitTest_Factory_For_Term::create_and_get() for consistency with other factories. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46986


git-svn-id: http://core.svn.wordpress.org/trunk@46786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-18 00:26:02 +00:00
Sergey Biryukov
396647666f Docs: Various documentation fixes for unit test factories. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46985


git-svn-id: http://core.svn.wordpress.org/trunk@46785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-18 00:19:02 +00:00
Sergey Biryukov
2cf3fb14ee Tests: Use delta comparison in test_should_fall_back_to_last_post_modified() to avoid race conditions. 
See #48957.
Built from https://develop.svn.wordpress.org/trunk@46981


git-svn-id: http://core.svn.wordpress.org/trunk@46781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-17 21:33:02 +00:00
Andrew Ozz
6403619f92 Upload: Run the final file name collision test in wp_unique_filename() for each existing file + 1. 
Props pbiron.
See #48975.

Built from https://develop.svn.wordpress.org/trunk@46976


git-svn-id: http://core.svn.wordpress.org/trunk@46776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-17 20:52:03 +00:00
Sergey Biryukov
da041582df Date/Time: Ensure that get_feed_build_date() correctly handles a modified post object with invalid date. 
* Clarify in the documentation that the function returns `false` on failure.
* Consistently pass the return value through the `get_feed_build_date` filter.

Props Rarst, dd32, azaozz, tellyworth.
Fixes #48957.
Built from https://develop.svn.wordpress.org/trunk@46974


git-svn-id: http://core.svn.wordpress.org/trunk@46774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-17 20:43:03 +00:00
Sergey Biryukov
8eb278d19a Docs: Clarify that get_lastpostdate() and get_lastpostmodified() can return false on failure. 
The both use `_get_last_post_time()` internally.

Props Rarst.
See #48957.
Built from https://develop.svn.wordpress.org/trunk@46973


git-svn-id: http://core.svn.wordpress.org/trunk@46773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-17 20:26:01 +00:00
Sergey Biryukov
bbd898b1dd Upgrade/Install: Remove unused global in upgrade_430_fix_comments(). 
Props adnan.limdi.
Fixes #41970.
Built from https://develop.svn.wordpress.org/trunk@46972


git-svn-id: http://core.svn.wordpress.org/trunk@46772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-17 16:45:03 +00:00
Sergey Biryukov
d273235abd Login/Registration: Pass the error data to the wp_login_failed action. 
Props hamedmoodi, rixeo.
Fixes #49007.
Built from https://develop.svn.wordpress.org/trunk@46971


git-svn-id: http://core.svn.wordpress.org/trunk@46771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-17 15:36:01 +00:00
Sergey Biryukov
a79636f82a Docs: Correct @type for timeout argument in WP_Http::request(). 
Props georgestephanis, benedictsinger.
Fixes #49005.
Built from https://develop.svn.wordpress.org/trunk@46970


git-svn-id: http://core.svn.wordpress.org/trunk@46770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-17 15:25:01 +00:00
Sergey Biryukov
18b0cd4f7d Date/Time: Add a unit test for [46968]. 
See #48145.
Built from https://develop.svn.wordpress.org/trunk@46969


git-svn-id: http://core.svn.wordpress.org/trunk@46769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-17 14:37:02 +00:00
Sergey Biryukov
c0b6dffffc Date/Time: In wp_insert_post(), when checking the post date to set future or publish status, use a proper delta comparison. 
[3525] allowed a difference up to 59 seconds between the post date/time and the current time to consider the post published instead of scheduled, but that didn't take start of a new minute into account.

Rapidly creating post fixtures in unit tests could encounter a one-second discrepancy between `current_time( 'mysql' )` and `gmdate( 'Y-m-d H:i:s' )`, returning values like `2019-12-16 23:43:00` vs. `2019-12-16 23:42:59`, respectively, and setting the post to a `future` status instead of `publish`.

[45851], while working as intended, made the issue somewhat more likely to occur.

This caused all sorts of occasional random failures in various tests on Travis, mostly on PHP 7.1.

Fixes #48145.
Built from https://develop.svn.wordpress.org/trunk@46968


git-svn-id: http://core.svn.wordpress.org/trunk@46768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-17 02:25:03 +00:00
Andrew Ozz
c67c3ee6a0 Fix the colors in all color schemes for the .active class for buttons. 
Props ryelle, audrasjb.
Fixes #49003 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46967


git-svn-id: http://core.svn.wordpress.org/trunk@46767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-17 00:15:03 +00:00
Andrew Ozz
ef7326129f Upload: Fix the final file name collision test in wp_unique_filename() when uploading a file with upper case extension. Add a unit test to catch that in the future. 
Fixes #48975 for trunk.

Built from https://develop.svn.wordpress.org/trunk@46966


git-svn-id: http://core.svn.wordpress.org/trunk@46766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-16 23:44:04 +00:00
Andrew Ozz
e0ace80488 Upload: 
- Fix PHP warnings in `wp_unique_filename()` when the destination directory is unreadable.
- Run the final name collision test only for files that are saved to the uploads directory.
- Update the unit tests to match.

Props eden159, audrasjb, azaozz.
Fixes #48960 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46965


git-svn-id: http://core.svn.wordpress.org/trunk@46765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-16 23:23:06 +00:00
Sergey Biryukov
8894c0f1a2 Coding Standards: Use strict comparison in wp-admin/widgets.php. 
Props jenilk.
Fixes #49000.
Built from https://develop.svn.wordpress.org/trunk@46964


git-svn-id: http://core.svn.wordpress.org/trunk@46764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-16 12:55:03 +00:00
Sergey Biryukov
5b9fd2d7e7 Coding Standards: Use strict comparison in wp-admin/includes/network.php. 
Props ataurr.
Fixes #48994.
Built from https://develop.svn.wordpress.org/trunk@46963


git-svn-id: http://core.svn.wordpress.org/trunk@46763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-16 12:37:06 +00:00
Sergey Biryukov
6d40400756 Coding Standards: Use strict comparison in wp-admin/edit-tags.php. 
Props passoniate.
Fixes #48985.
Built from https://develop.svn.wordpress.org/trunk@46962


git-svn-id: http://core.svn.wordpress.org/trunk@46762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-15 10:46:02 +00:00
Sergey Biryukov
087282e810 Coding Standards: Use strict comparison in wp-admin/term.php. 
Props vinita29.
Fixes #48983.
Built from https://develop.svn.wordpress.org/trunk@46961


git-svn-id: http://core.svn.wordpress.org/trunk@46761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-15 09:45:01 +00:00
Sergey Biryukov
35b29f11b3 Coding Standards: Add missing braces to if conditions in js/_enqueues/wp/util.js. 
Props ankitmaru.
Fixes #48980.
Built from https://develop.svn.wordpress.org/trunk@46960


git-svn-id: http://core.svn.wordpress.org/trunk@46760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-15 08:45:05 +00:00
Sergey Biryukov
1b675c6e4a Formatting: Return early from wp_kses_attr_check() if the element is not in the list of allowed elements and attributes. 
Props krynes, tristanleboss.
Fixes #48549.
Built from https://develop.svn.wordpress.org/trunk@46959


git-svn-id: http://core.svn.wordpress.org/trunk@46759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-14 15:53:06 +00:00
Sergey Biryukov
8260786e64 Docs: Clarify descriptions for get_gmt_from_date() and get_date_from_gmt(). 
Props johnbillion, Rarst.
Fixes #48650.
Built from https://develop.svn.wordpress.org/trunk@46958


git-svn-id: http://core.svn.wordpress.org/trunk@46757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-13 21:45:02 +00:00
Sergey Biryukov
0b8438a6d2 I18N: Replace file names in translatable strings on Permalink Settings screen with placeholders. 
Props ramiy.
Fixes #48863.
Built from https://develop.svn.wordpress.org/trunk@46957


git-svn-id: http://core.svn.wordpress.org/trunk@46756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-13 21:27:05 +00:00
ianbelanger
48692b6524 Bundled Themes: Bump version number and update changelog in Twenty Twenty for WordPress 5.3.1. 
This bumps the Twenty Twenty version number to `1.1` and update the `readme.txt` changelog.

Props audrasjb, sinatrateam, SergeyBiryukov
Fixes #48944.
Built from https://develop.svn.wordpress.org/trunk@46902


git-svn-id: http://core.svn.wordpress.org/trunk@46702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-12 18:26:03 +00:00
whyisjake
317465e2fe Prevent stored XSS in the block editor. 
Prevent escaped unicode characters become unescaped in unsafe HTML during JSON decoding.

Props: aduth, epiqueras, 

Built from https://develop.svn.wordpress.org/trunk@46896


git-svn-id: http://core.svn.wordpress.org/trunk@46696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-12 18:02:03 +00:00
whyisjake
84e4c8531a Update wp_kses_bad_protocol() to recognize &colon; on uri attributes, 
`wp_kses_bad_protocol()` makes sure to validate that uri attributes don’t contain invalid/or not allowed protocols. While this works fine in most cases, there’s a risk that by using the colon html5 named entity, one is able to bypass this function.

Props: xknown, nickdaugherty, peterwilsoncc.

Built from https://develop.svn.wordpress.org/trunk@46895


git-svn-id: http://core.svn.wordpress.org/trunk@46695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-12 17:55:05 +00:00
whyisjake
80eab318eb Prevent stored XSS through wp_targeted_link_rel(). 
Props: vortfu, whyisjake, peterwilsoncc, xknown,  SergeyBiryukov, flaviozavan.


Built from https://develop.svn.wordpress.org/trunk@46894


git-svn-id: http://core.svn.wordpress.org/trunk@46694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-12 17:54:02 +00:00
whyisjake
9e87c5b7b4 Ensure that a user can publish_posts before making a post sticky. 
Props: danielbachhuber, whyisjake, peterwilson, xknown.


Built from https://develop.svn.wordpress.org/trunk@46893


git-svn-id: http://core.svn.wordpress.org/trunk@46693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-12 17:52:02 +00:00
Sergey Biryukov
99f11a6af2 Docs: Update description for get_categories() to avoid suggesting the deprecated type argument. 
Follow-up to [13754].

Props dingo_d.
Fixes #48913.
Built from https://develop.svn.wordpress.org/trunk@46891


git-svn-id: http://core.svn.wordpress.org/trunk@46691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-12 16:47:05 +00:00
Sergey Biryukov
db18e7d50b Upgrade/Install: Improve the appearance of language selection on install: 
* Remove a stray chevron.
* Improve focus and hover styles.

Props garrett-eclipse, audrasjb.
Fixes #48927.
Built from https://develop.svn.wordpress.org/trunk@46887


git-svn-id: http://core.svn.wordpress.org/trunk@46687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-11 23:03:03 +00:00
Sergey Biryukov
c87fccd74f Comments: Avoid a PHP notice in comment_form() if the email field is not set. 
Follow-up to [46090].

Props mat-lipe.
Fixes #48943.
Built from https://develop.svn.wordpress.org/trunk@46885


git-svn-id: http://core.svn.wordpress.org/trunk@46685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-11 22:14:02 +00:00
Andrew Ozz
eb38423e22 Fixes in admin-bar.js: 
- Silence errors when a node doesn't exist similarly to jQuery.
- Add "feature testing" and fallbacks for old browsers as this may run on the front-end.
- Improve inline docs.

Props dinhtungdu, azaozz.
Fixes #47069.
Built from https://develop.svn.wordpress.org/trunk@46883


git-svn-id: http://core.svn.wordpress.org/trunk@46683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-11 18:56:03 +00:00
Sergey Biryukov
f8964463c1 Tests: Docs: Correct @param formatting in SpeedTrapListener after [35226] and [45607]. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46882


git-svn-id: http://core.svn.wordpress.org/trunk@46682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-11 15:48:03 +00:00
Sergey Biryukov
c48b359227 Tests: Correct the slowThreshold option name for SpeedTrapListener. 
The previous change in [45607] appears to be accidental.

Props Rarst.
Fixes #48933.
Built from https://develop.svn.wordpress.org/trunk@46881


git-svn-id: http://core.svn.wordpress.org/trunk@46681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-11 15:42:06 +00:00
Sergey Biryukov
9b91ffde04 Docs: Improve documentation for wp_dashboard_browser_nag() and dashboard_browser_nag_class(). 
Props grapplerulrich.
Fixes #48932.
Built from https://develop.svn.wordpress.org/trunk@46880


git-svn-id: http://core.svn.wordpress.org/trunk@46680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-11 10:59:05 +00:00
Andrew Ozz
b639963d7a TinyMCE: remove CSS map reference from /tinymce/skins/lightgray/skin.min.css. 
Props AlexHolsgrove.
Fixes #48577.
Built from https://develop.svn.wordpress.org/trunk@46879


git-svn-id: http://core.svn.wordpress.org/trunk@46679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-10 18:33:05 +00:00
Sergey Biryukov
aa919cd160 Comments: Optimize the query for pending comments count in wp_notify_moderator() for better performance on large tables. 
Props sgoen.
Fixes #48514.
Built from https://develop.svn.wordpress.org/trunk@46878


git-svn-id: http://core.svn.wordpress.org/trunk@46678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-10 13:47:00 +00:00
Sergey Biryukov
ee58f3f3d3 Coding Standards: Fix WPCS and JSHint issues in [46872]. 
See #47069.
Built from https://develop.svn.wordpress.org/trunk@46874


git-svn-id: http://core.svn.wordpress.org/trunk@46674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-10 01:34:01 +00:00
Andrew Ozz
d617011afd Fix the admin toolbar js when jQuery is not present and replace the jQuery based hoverIntent.js with a native implementation. Introduces the "hoverintent" (no dependencies) package. 
Props dinhtungdu, audrasjb, azaozz.
Fixes #47069.
Built from https://develop.svn.wordpress.org/trunk@46872


git-svn-id: http://core.svn.wordpress.org/trunk@46672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-10 01:03:02 +00:00
Sergey Biryukov
0524d9b781 Block Editor: Resolve @wordpress/block-directory to the expected version, 1.0.6. 
Follow-up to [46860].

Props aduth, garrett-eclipse, audrasjb, azaozz.
Fixes #48884.
Built from https://develop.svn.wordpress.org/trunk@46870


git-svn-id: http://core.svn.wordpress.org/trunk@46670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 22:29:08 +00:00
Sergey Biryukov
6ddf02b188 Menus: Avoid a PHP warning in add_submenu_page() when the same value is passed for both $parent_slug and $menu_slug parameters. 
Props welcher, ispreview, ayeshrajans, NextScripts, adamsilverstein, garrett-eclipse, 123host.
Fixes #48599.
Built from https://develop.svn.wordpress.org/trunk@46868


git-svn-id: http://core.svn.wordpress.org/trunk@46668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 21:03:02 +00:00
Sergey Biryukov
a209908501 Administration: Standardize form control height and alignment across the admin. 
This improves the appearance of various form controls in the admin and addresses some visual inconsistencies in WordPress 5.3.

Props afercia, audrasjb, jameskoster, GDragoN, azaozz, michaelarestad, murgroland, SamuelFernandez, chetan200891, veminom, dlh.
Fixes #48420.
Built from https://develop.svn.wordpress.org/trunk@46866


git-svn-id: http://core.svn.wordpress.org/trunk@46666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 20:26:03 +00:00
Sergey Biryukov
1dcf3eef7a Date/Time: XML-RPC: Сalculate the proper offset for GMT in wp.newPost, wp.editComment, mw.newPost, mw.editPost when post_date or comment_date is set. 
Previously, `post_date` or `comment_date` was assumed to be GMT, which is only true if the timezone string for the site matches GMT.

Add unit tests.

Props Rarst, smerriman, justdaiv, wonderboymusic, noyle.
Fixes #30429.
Built from https://develop.svn.wordpress.org/trunk@46864


git-svn-id: http://core.svn.wordpress.org/trunk@46664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 19:56:05 +00:00
Sergey Biryukov
098273f1d3 Date/Time: When determining whether to decline the month name in wp_maybe_decline_date(), take word boundaries into account. 
Add more unit tests.

Props Rarst, Clorith, timon33, Xendo, SergeyBiryukov.
Fixes #48606.
Built from https://develop.svn.wordpress.org/trunk@46862


git-svn-id: http://core.svn.wordpress.org/trunk@46662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 18:50:06 +00:00
Sergey Biryukov
a227c231a2 Block Editor: Bug fixes targeted for WordPress 5.3.1. 
The list of included fixes:

- Edge scrolling issues https://github.com/WordPress/gutenberg/pull/17707
- Intermittent JavaScript issues https://github.com/WordPress/gutenberg/pull/18559
- Remove embed CollegeHumor https://github.com/WordPress/gutenberg/pull/18591 

Updated packages:

- @wordpress/block-directory@1.0.6
- @wordpress/block-editor@3.2.5
- @wordpress/block-library@2.9.6
- @wordpress/core-data@2.7.5
- @wordpress/edit-post@3.8.6
- @wordpress/editor@9.7.6
- @wordpress/format-library@1.9.5

Props youknowriad, ellatrix, epiqueras, audrasjb, gziolo, mcsf, kyliesabra.
Fixes #48884.
Built from https://develop.svn.wordpress.org/trunk@46860


git-svn-id: http://core.svn.wordpress.org/trunk@46660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 17:37:10 +00:00
Sergey Biryukov
d4ef90b236 Upgrade/Install: Update sodium_compat to v1.12.1. 
This includes a speedup for signature verification on most platforms and bugfixes for 32-bit platforms.

Props paragoninitiativeenterprises, lukaswaudentio.
Fixes #48371.
Built from https://develop.svn.wordpress.org/trunk@46858


git-svn-id: http://core.svn.wordpress.org/trunk@46658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 16:42:04 +00:00
Sergey Biryukov
dd47d5aa81 Media: Use consistent width for Scale and Crop inputs. 
Follow-up to [46359].

Props sabernhardt, audrasjb.
Fixes #48907.
Built from https://develop.svn.wordpress.org/trunk@46856


git-svn-id: http://core.svn.wordpress.org/trunk@46656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 16:23:02 +00:00
Sergey Biryukov
303180b392 Twenty Twenty: Adjust the comment in [46851] per the documentation standards. 
See #48876.
Built from https://develop.svn.wordpress.org/trunk@46854


git-svn-id: http://core.svn.wordpress.org/trunk@46654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 16:18:02 +00:00
Sergey Biryukov
9648c368f0 Help/About: Add a hover effect for links on About pages. 
* Add a color that passes WCAG color contrast criteria to every link.
* Add an underline for links in credits list only on hover/focus.

Props audrasjb, ixkaito, mukesh27, melchoyce, SergeyBiryukov.
Fixes #48582.
Built from https://develop.svn.wordpress.org/trunk@46852


git-svn-id: http://core.svn.wordpress.org/trunk@46652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 15:31:05 +00:00
ianbelanger
48fbea17d6 Bundled Themes: Misaligned input placeholder text Twenty Twenty. 
This fixes placeholder misalignment in Firefox when a `height` is added as an inline style to the input field.

Props aljullu, subratamal.
Fixes #48876.
Built from https://develop.svn.wordpress.org/trunk@46851


git-svn-id: http://core.svn.wordpress.org/trunk@46651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 15:10:00 +00:00
Sergey Biryukov
35985cbf38 Twenty Twenty: Remove redundant echo for bloginfo() call in footer.php. 
Props acosmin.
Fixes #48918.
Built from https://develop.svn.wordpress.org/trunk@46849


git-svn-id: http://core.svn.wordpress.org/trunk@46649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 15:00:01 +00:00
Sergey Biryukov
dcf0cb68a2 Administration: Correct checkbox width in list tables on smaller screens. 
Previously, checkboxes for pending comments were partially hidden due to an added `4px` border.

Props audrasjb, jeremyfelt, talldanwp, melchoyce, marcelo2605, waleedt93.
Fixes #48815.
Built from https://develop.svn.wordpress.org/trunk@46845


git-svn-id: http://core.svn.wordpress.org/trunk@46645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 14:26:02 +00:00
ianbelanger
b051b9a0d4 Bundled Themes: Make checkbox in comment form larger Twenty Twenty. 
This makes the checkbox in the comment form larger and more consistent with other checkboxes.

Props kharisblank, audrasjb.
Fixes #48652.
Built from https://develop.svn.wordpress.org/trunk@46844


git-svn-id: http://core.svn.wordpress.org/trunk@46644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 14:08:03 +00:00
Sergey Biryukov
ac690426eb Accessibility: Menus: Properly disable form controls on the Menus screen that cannot be used until at least one menu is created. 
This ensures that the actual UI controls state matches the visually conveyed state.

Props afercia, audrasjb, dinhtungdu, sathyapulse, simonjanin, welcher, SergeyBiryukov.
Fixes #48409.
Built from https://develop.svn.wordpress.org/trunk@46842


git-svn-id: http://core.svn.wordpress.org/trunk@46642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 13:49:03 +00:00
Sergey Biryukov
23f45f0346 Twenty Twenty: Correct alignment for embedded Instagram posts. 
Props SGr33n, audrasjb, nielslange, JarretC.
Fixes #48688.
Built from https://develop.svn.wordpress.org/trunk@46840


git-svn-id: http://core.svn.wordpress.org/trunk@46640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 13:39:03 +00:00
Sergey Biryukov
87a759b81c Users: Introduce admin_email_remind_interval filter for dismissing the admin email confirmation screen. 
Props desrosj, birgire.
Fixes #48334.
Built from https://develop.svn.wordpress.org/trunk@46838


git-svn-id: http://core.svn.wordpress.org/trunk@46638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 13:26:02 +00:00
Sergey Biryukov
adf1792adc Docs: Correct DocBlock formatting for admin_email_confirm and admin_email_confirm_form hooks. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46837


git-svn-id: http://core.svn.wordpress.org/trunk@46637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 13:10:01 +00:00
Sergey Biryukov
4b333de597 Tests: Change group annotation for test_unique_filename_with_dimension_like_filename() to `ticket. 
See #42437.
Built from https://develop.svn.wordpress.org/trunk@46835


git-svn-id: http://core.svn.wordpress.org/trunk@46635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 12:18:01 +00:00
Sergey Biryukov
6c49066de7 Twenty Twenty: Pass $post_meta and $location values to twentytwenty_start_of_post_meta_list and twentytwenty_end_of_post_meta_list actions to provide better context. 
Props msaari, SergeyBiryukov.
Fixes #48906.
Built from https://develop.svn.wordpress.org/trunk@46832


git-svn-id: http://core.svn.wordpress.org/trunk@46632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 11:49:02 +00:00
Sergey Biryukov
8da965a5b8 Tests: Make sure network factory returns an integer ID for created objects, for consistency with other factories and the documented value. 
See #48145.
Built from https://develop.svn.wordpress.org/trunk@46831


git-svn-id: http://core.svn.wordpress.org/trunk@46631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 11:31:01 +00:00
Sergey Biryukov
e70c88213f Tests: Pad incrementors used in factories with leading zeros to make sure MySQL sorting works as expected. 
Previously, tests could create sequential objects with names like `Term 99`, `Term 100`, which by default would be returned in reverse order when sorted by name alphabetically, causing seemingly random test failures that are extremely hard to debug.

See #48145.
Built from https://develop.svn.wordpress.org/trunk@46830


git-svn-id: http://core.svn.wordpress.org/trunk@46630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 10:41:05 +00:00
Sergey Biryukov
860fc16954 Tests: Speed up comment submission unit tests by creating less fixtures and reusing them where possible. 
See #30017, #48145.
Built from https://develop.svn.wordpress.org/trunk@46829


git-svn-id: http://core.svn.wordpress.org/trunk@46629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-08 18:02:07 +00:00
Sergey Biryukov
f11d28a779 Twenty Twenty: Use duplicate hook references for page_css_class and page_menu_link_attributes filters in TwentyTwenty_Walker_Page. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46828


git-svn-id: http://core.svn.wordpress.org/trunk@46628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-07 14:03:03 +00:00
Sergey Biryukov
6677070a13 Bundled Themes: Correct @since tags to refer to the theme version instead of WordPress version. 
This makes `@since` notations in Twenty Seventeen, Twenty Nineteen, and Twenty Twenty consistent with the previous bundled themes.

See #48303.
Built from https://develop.svn.wordpress.org/trunk@46827


git-svn-id: http://core.svn.wordpress.org/trunk@46627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-07 13:56:06 +00:00
John Blackbourn
d53103ed62 Docs: Further docblock corrections and improvements. 
See #48303
Built from https://develop.svn.wordpress.org/trunk@46826


git-svn-id: http://core.svn.wordpress.org/trunk@46626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-07 13:23:01 +00:00
Sergey Biryukov
0f971e68ec Twenty Twenty: Replace Smooth Scroll JS implementation with scroll-behavior CSS property. 
The JS implementation had multiple issues and did not work as expected.

This change includes an accessibility enhancement by using `prefers-reduced-motion: reduce` media query property for users that don't want motion effects. For further explanation on this media query, see MDN documentation: https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-behavior#Accessibility_concerns

Props audrasjb, melchoyce, joostdevalk, Anlino, mauteri, sergiomdgomes, littlebigthing, williampatton, netweb, andraganescu, joyously, acosmin, mukesh27, hareesh-pillai.
Fixes #48763, #48551, #48866.
Built from https://develop.svn.wordpress.org/trunk@46824


git-svn-id: http://core.svn.wordpress.org/trunk@46624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-07 11:05:01 +00:00
John Blackbourn
f93ee2ca76 Docs: Increase the specificity of various docblock parameter types and return types. 
See #48303
Built from https://develop.svn.wordpress.org/trunk@46823


git-svn-id: http://core.svn.wordpress.org/trunk@46623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-06 22:43:04 +00:00
Andrew Ozz
15a566edef Upload: fix wp_unique_filename() to prevent name collisions with existing or future image sub-size file names, and add unit tests. 
Props Viper007Bond, pbiron, azaozz.
Fixes #42437.
Built from https://develop.svn.wordpress.org/trunk@46822


git-svn-id: http://core.svn.wordpress.org/trunk@46622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-06 22:28:00 +00:00
John Blackbourn
aa1fdcbd52 Docs: Correct various docblocks documentation. 
See #48303
Built from https://develop.svn.wordpress.org/trunk@46821


git-svn-id: http://core.svn.wordpress.org/trunk@46621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-06 22:23:04 +00:00
Aaron Jorbin
7d84502589 Text Changes: Rename Comment Blacklist option to be more inclusive 
This doesn't change the underlying option name as that would be a backcompat break, but it makes the UI a bit more inclusive.

Props dartiss, jeremyfelt, aaronjorbin.
Fixes #48900.


Built from https://develop.svn.wordpress.org/trunk@46820


git-svn-id: http://core.svn.wordpress.org/trunk@46620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-06 18:12:02 +00:00
Sergey Biryukov
c375d23ef5 Tests: Remove duplicate test_get_page_by_path_priority() test. 
The test was moved into its own file in [37478], but never removed from its previous location.

See #36711.
Built from https://develop.svn.wordpress.org/trunk@46819


git-svn-id: http://core.svn.wordpress.org/trunk@46619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-06 17:27:05 +00:00
Sergey Biryukov
2165eef44c Accessibility: Administration: Correct active button color for the alternative color schemes. 
Follow-up to [46815].

Props melchoyce, ryelle, larrach, audrasjb, studiotwee, afercia, azaozz.
Fixes #48598.
Built from https://develop.svn.wordpress.org/trunk@46817


git-svn-id: http://core.svn.wordpress.org/trunk@46617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-05 22:12:03 +00:00
Sergey Biryukov
20e18613d0 Accessibility: Administration: Apply a unified design to all secondary buttons across all color schemes. 
This ensures that secondary buttons have an appropriate color contrast in the alternative color schemes.

Props melchoyce, ryelle, audrasjb, ate-up-with-motor, afercia, sabernhardt.
Fixes #48585.
Built from https://develop.svn.wordpress.org/trunk@46815


git-svn-id: http://core.svn.wordpress.org/trunk@46615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-05 21:32:03 +00:00
Sergey Biryukov
23abf27b1a XML-RPC: Unify some "could not be created/updated/deleted" error messages for consistency. 
Props ramiy, SergeyBiryukov.
Fixes #48883.
Built from https://develop.svn.wordpress.org/trunk@46814


git-svn-id: http://core.svn.wordpress.org/trunk@46614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-05 13:48:03 +00:00
ianbelanger
8d6912dd27 Bundled Themes: Adds Customizer option to show or hide author bio Twenty Twenty. 
This adds an option to the Customizer that allows you to turn the author bio on or off, sitewide.

Props williampatton, nielslange acosmin, dlh.
Fixes #48550.
Built from https://develop.svn.wordpress.org/trunk@46813


git-svn-id: http://core.svn.wordpress.org/trunk@46613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-04 15:59:03 +00:00
Sergey Biryukov
38ad319fdf I18N: Change context for the "Add New" string on Themes screen for consistency with other similar strings. 
Props ramiy.
Fixes #48875.
Built from https://develop.svn.wordpress.org/trunk@46812


git-svn-id: http://core.svn.wordpress.org/trunk@46612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-04 10:36:01 +00:00
Sergey Biryukov
a5e52e04ee Docs: Move the canonical DocBlock for handle_bulk_actions-{$screen} action to wp-admin/edit.php. 
* Document accepted values for the `$items` parameter.
* Use interpolated syntax for the filter name.

Props dilipbheda, johnbillion, SergeyBiryukov.
Fixes #48857.
Built from https://develop.svn.wordpress.org/trunk@46811


git-svn-id: http://core.svn.wordpress.org/trunk@46611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-03 13:58:05 +00:00
Sergey Biryukov
6d1ed93c91 Taxonomy: Remove redundant caching from get_all_category_ids(), deprecated in favor of get_terms() in [28679]. 
The `all_category_ids` cache key it relied on was removed in [5555] and never repopulated, causing invalid or unexpected results when using a persistent object cache.

Props itowhid06, johnjamesjacoby.
Fixes #48176.
Built from https://develop.svn.wordpress.org/trunk@46810


git-svn-id: http://core.svn.wordpress.org/trunk@46610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-02 14:49:01 +00:00
Andrew Ozz
135e608b46 Upload: Exclude PNG images from scaling after uploading. Fixes a case where resizing a very large PNG may create a scaled image that has smaller dimensions but larger file size than the original. 
Fixes #48736.
Built from https://develop.svn.wordpress.org/trunk@46809


git-svn-id: http://core.svn.wordpress.org/trunk@46609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-01 18:26:05 +00:00
Sergey Biryukov
221287f626 Widgets: Remove WP_Widget_Factory::$hashed_class_counts property, unused since [46220]. 
The `spl_object_hash()` function was introduced in PHP 5.2.0. As of PHP 5.3, the PHP SPL extension can no longer be disabled, so the `WP_Widget_Factory::hash_object()` workaround was removed in [46220].

See #48074.
Built from https://develop.svn.wordpress.org/trunk@46808


git-svn-id: http://core.svn.wordpress.org/trunk@46608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-01 12:13:01 +00:00
Sergey Biryukov
0221a593b9 Administration: Correct font size for comment count in "At a Glance" dashboard widget on mobile. 
Props donmhico, jeremyfelt.
Fixes #48799.
Built from https://develop.svn.wordpress.org/trunk@46807


git-svn-id: http://core.svn.wordpress.org/trunk@46607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-30 00:42:01 +00:00
Sergey Biryukov
585af17b7c Tests: Merge [24251] from _wp_filter_build_unique_id() to _test_filter_build_unique_id(), for consistency. 
See #47407.
Built from https://develop.svn.wordpress.org/trunk@46806


git-svn-id: http://core.svn.wordpress.org/trunk@46606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-29 22:17:01 +00:00
Sergey Biryukov
3047531f6a Plugins: In _wp_filter_build_unique_id(), remove $wp_filter global and $filter_id_count static variable, unused since [46220]. 
See #47407, #48074.
Built from https://develop.svn.wordpress.org/trunk@46805


git-svn-id: http://core.svn.wordpress.org/trunk@46605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-29 22:14:01 +00:00
Sergey Biryukov
1d1c74385f REST API: Use strict in_array() checks for the list of usernames blacklisted via illegal_user_logins filter. 
See #48839.
Built from https://develop.svn.wordpress.org/trunk@46804


git-svn-id: http://core.svn.wordpress.org/trunk@46604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-29 22:04:02 +00:00
Sergey Biryukov
86c441140b REST API: Use a strict in_array() check in WP_REST_Request::get_parameter_order(). 
See #48839.
Built from https://develop.svn.wordpress.org/trunk@46803


git-svn-id: http://core.svn.wordpress.org/trunk@46603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-29 22:01:03 +00:00
Sergey Biryukov
d33571f7d5 REST API: Use a strict in_array() check in WP_REST_Meta_Fields::get_registered_fields(). 
Props dkarfa.
Fixes #48839.
Built from https://develop.svn.wordpress.org/trunk@46802


git-svn-id: http://core.svn.wordpress.org/trunk@46602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-29 21:59:03 +00:00
Sergey Biryukov
49401759f3 Docs: Correct @param type for the function parameter in tests_add_filter() and _test_filter_build_unique_id(). 
Synchronize documentation for `add_filter()`, `tests_add_filter()`, `_wp_filter_build_unique_id()`, `_test_filter_build_unique_id()`.

Add a note that `$tag` and `$priority` are no longer used in `_wp_filter_build_unique_id()` since [46220], and the function always returns a string now.

Props donmhico, remcotolsma, SergeyBiryukov.
Fixes #47407. See #48303.
Built from https://develop.svn.wordpress.org/trunk@46801


git-svn-id: http://core.svn.wordpress.org/trunk@46601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-29 21:42:01 +00:00
Sergey Biryukov
2a0489ec49 Docs: Replace @returns tags in JS docs with @return. 
Per the documentation standards, `@returns` is an unsupported synonym, `@return` should be used instead:
https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/

See #48303.
Built from https://develop.svn.wordpress.org/trunk@46800


git-svn-id: http://core.svn.wordpress.org/trunk@46600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-29 18:01:03 +00:00
Sergey Biryukov
4a4afbd68c Docs: Add missing full stops to @returns tags in JS docs, per the documentation standards. 
Props shital-patel, kalpshit.
Fixes #48305.
Built from https://develop.svn.wordpress.org/trunk@46799


git-svn-id: http://core.svn.wordpress.org/trunk@46599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-29 16:56:02 +00:00
Sergey Biryukov
acd0a3ca99 Site Health: Add a test for PHP default timezone. 
The test reports a failure if the default timezone was changed with `date_default_timezone_set()` to anything other than `UTC`.

WordPress historically uses `UTC` as the default timezone for calculating date and time offsets, overriding it is not recommended and can cause widespread and obscure issues.

Props Rarst, Clorith, TimothyBlynJacobs.
Fixes #48692.
Built from https://develop.svn.wordpress.org/trunk@46797


git-svn-id: http://core.svn.wordpress.org/trunk@46597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-28 15:48:03 +00:00
Sergey Biryukov
9d14355bf5 Date/Time: Make get_permalink() more resilient against PHP timezone changes. 
Overriding default PHP timezone with `date_default_timezone_set()`, while not recommended, should not inadvertently result in changing existing permalinks.

Add a unit test.

Props Rarst, steevithak, archon810, maciejmackowiak, Ov3rfly, Cybr, hometowntrailers, scvleon, miette49.
Fixes #48623.
Built from https://develop.svn.wordpress.org/trunk@46795


git-svn-id: http://core.svn.wordpress.org/trunk@46595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-28 13:42:00 +00:00
Sergey Biryukov
7acfab22b8 KSES: Add support for gradient backgrounds. 
Props jorgefilipecosta.
Fixes #48376.
Built from https://develop.svn.wordpress.org/trunk@46793


git-svn-id: http://core.svn.wordpress.org/trunk@46593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-28 00:29:02 +00:00
Sergey Biryukov
0aef4faacd Plugins: Correct default value of $replacement parameter in do_action_deprecated() and apply_filters_deprecated(). 
This addresses an inconsistency with `_deprecated_hook()`, which uses `is_null()` to check if `$replacement` was provided, however the previous default value was `false`.

Props shaampk1, felipeelia.
Fixes #48817.
Built from https://develop.svn.wordpress.org/trunk@46792


git-svn-id: http://core.svn.wordpress.org/trunk@46592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-27 23:55:01 +00:00
Sergey Biryukov
6f86cedb09 Menus: Improve the wording of instructions for dragging the items into the preferred order. 
Props amolv, equin0x80, dlh.
Fixes #48184.
Built from https://develop.svn.wordpress.org/trunk@46791


git-svn-id: http://core.svn.wordpress.org/trunk@46591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-27 19:51:01 +00:00
Sergey Biryukov
d8b251f0af Administration: Properly wrap long titles in list tables on smaller screens. 
Props mukesh27, iihglobal, wpamitkumar.
Fixes #48805.
Built from https://develop.svn.wordpress.org/trunk@46790


git-svn-id: http://core.svn.wordpress.org/trunk@46590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-27 16:52:02 +00:00
Sergey Biryukov
e2c2fb64bf Users: Display admin email verification screen in user's locale instead of site locale. 
Props sathyapulse, TimothyBlynJacobs.
Fixes #48313.
Built from https://develop.svn.wordpress.org/trunk@46788


git-svn-id: http://core.svn.wordpress.org/trunk@46588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-27 14:35:02 +00:00
ianbelanger
c74c8cf5f1 Bundled Themes: Fixes JS TypeError in Twenty Twenty. 
On mobile devices using a webkit browser, the menu and search modals could not be opened due to a `TypeError: document.body is null`. This commit fixes that issue by adding a `touch-enabled` class to the body for browsers that do not support media queries.

Props quicoto, poena, Boga86, acosmin, macmanx.
Fixes #48601.
Built from https://develop.svn.wordpress.org/trunk@46786


git-svn-id: http://core.svn.wordpress.org/trunk@46586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-26 18:21:03 +00:00
Sergey Biryukov
5af0c2989b Tests: Add feed group for get_feed_build_date() test added in [46756]. 
See #48675.
Built from https://develop.svn.wordpress.org/trunk@46785


git-svn-id: http://core.svn.wordpress.org/trunk@46585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-26 16:19:03 +00:00
Dominik Schilling
f4165a697d Upgrade/Install: Provide a default label for "Continue" button in language selection form. 
Prevents an empty continue button if a translation isn't yet available.

Props sathyapulse.
Fixes #48776.
Built from https://develop.svn.wordpress.org/trunk@46784


git-svn-id: http://core.svn.wordpress.org/trunk@46584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-26 15:19:04 +00:00
Sergey Biryukov
63fefb540a Users: Use correct variable when displaying the Additional Capabilities list in user profile. 
Addresses a regression in [45926].

Props wpgurudev, aravindajith, anantajitjg, davidbaumwald.
Fixes #48725.
Built from https://develop.svn.wordpress.org/trunk@46782


git-svn-id: http://core.svn.wordpress.org/trunk@46582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-25 14:01:03 +00:00
Sergey Biryukov
e0830ac7bc Options, Meta APIs: Update @since version for the $force_cache parameter added for wp_load_alloptions() in [46753] to 5.3.1. 
See #31245.
Built from https://develop.svn.wordpress.org/trunk@46779


git-svn-id: http://core.svn.wordpress.org/trunk@46579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-25 13:44:02 +00:00
Sergey Biryukov
012ddf095a Media: Avoid a PHP notice in image_downsize() when trying to replace a non-image URL with a rendered image from its meta. 
Props Mte90, jrf, hareesh-pillai.
Fixes #48324.
Built from https://develop.svn.wordpress.org/trunk@46772


git-svn-id: http://core.svn.wordpress.org/trunk@46572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-25 10:07:02 +00:00
Sergey Biryukov
2a85fe21d8 Accessibility: Administration: Underline links on Dashboard that are located within a line of text and thus need to be underlined: 
* "change your theme completely"
* Active theme in the "At a Glance" box
* "View all drafts" in the Quick Draft box

Split "Manage widgets or menus" into separate items for consistency with other links.

For better accessibility, links that are a part of other text should be underlined and not rely on color alone to be distinguished.

Per accessibility coding standards:
> When links can be identified as such by the context, for example because they’re part of a menu, or a set of links clearly identified as user interface controls, they don’t necessarily need to be underlined. In all the other cases, especially for links surrounded by other text (in a line or block of text), links need to be always underlined.
https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/#links-underline-or-no-underline
https://make.wordpress.org/accessibility/handbook/design/use-of-color/#not-by-color-alone

Props afercia, audrasjb, karmatosed.
Fixes #48406.
Built from https://develop.svn.wordpress.org/trunk@46770


git-svn-id: http://core.svn.wordpress.org/trunk@46570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-24 19:57:05 +00:00
Sergey Biryukov
a1ad168857 Twenty Twenty: Remove duplicate array key/value in TwentyTwenty_Non_Latin_Languages::get_non_latin_css(). 
Props manikmist09.
Fixes #48624.
Built from https://develop.svn.wordpress.org/trunk@46765


git-svn-id: http://core.svn.wordpress.org/trunk@46565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-24 10:55:02 +00:00
Sergey Biryukov
c786eaa1df Coding Standards: Fix WPCS issue in [46763]. 
See #48777.
Built from https://develop.svn.wordpress.org/trunk@46764


git-svn-id: http://core.svn.wordpress.org/trunk@46564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-23 19:21:03 +00:00
Sergey Biryukov
26a750e162 Docs: Add missing @since tags for functions in wp-admin/includes/update.php. 
Props sathyapulse, zodiac1978.
Fixes #48777.
Built from https://develop.svn.wordpress.org/trunk@46763


git-svn-id: http://core.svn.wordpress.org/trunk@46563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-23 18:51:01 +00:00
Sergey Biryukov
0b5f3acd9f Twenty Twenty: Correctly align the author bio and bottom post meta on single posts on mobile. 
Props nielslange, Anlino.
Fixes #48619.
Built from https://develop.svn.wordpress.org/trunk@46762


git-svn-id: http://core.svn.wordpress.org/trunk@46562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-23 14:54:04 +00:00
Sergey Biryukov
8e9c4a116a Embeds: Remove CollegeHumor oEmbed provider, as the service does not exist anymore. 
Props audrasjb, youknowriad.
Fixes #48696.
Built from https://develop.svn.wordpress.org/trunk@46761


git-svn-id: http://core.svn.wordpress.org/trunk@46561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-23 10:15:03 +00:00
Sergey Biryukov
58aa1cc8c5 Docs: Adjust wp_is_json_request() and wp_is_xml_request() return value descriptions for consistency. 
See #48771, #48303.
Built from https://develop.svn.wordpress.org/trunk@46760


git-svn-id: http://core.svn.wordpress.org/trunk@46560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-22 18:28:04 +00:00