Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-15 23:25:50 +01:00
Code Issues Projects Releases Wiki Activity
39,601 Commits 50 Branches 748 Tags 792 MiB
c1c7188c8a
Commit Graph

39601 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sergey Biryukov
c1c7188c8a Accessibility: Toolbar: Make the min-width value for #wpadminbar at 782px breakpoint consistent with that of <body>. 
This ensures that the "My Account" toolbar item stays visible at high zoom levels.

Props isabel_brison, chetan200891.
Merges [45684] to the 5.2 branch.
Fixes #47603.
Built from https://develop.svn.wordpress.org/branches/5.2@45842


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-19 04:37:52 +00:00
Sergey Biryukov
4ef44b9ab0 Media: Reduces the bulk media options to have one primary button. 
This fixes where 2 primary buttons were showing for bulk actions within media trash.

Props garrett-eclipse, afercia, ianbelanger, SergeyBiryukov, karmatosed.
Merges [45701] to the 5.2 branch.
Fixes #46757, #46758
Built from https://develop.svn.wordpress.org/branches/5.2@45841


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-19 04:34:52 +00:00
Sergey Biryukov
90c221a67c Accessibility: Improve the media views upload Dismiss Errors button. 
- makes the Dismiss Errors button visible in the media views inline uploader
- avoids a focus loss when activating the Dismiss Errors button

See the related GitHub issue from the WPCampus accessibility audit https://github.com/WordPress/gutenberg/issues/15354

Props afercia.
Merges [45376] to the 5.2 branch.
Fixes #47113.
Built from https://develop.svn.wordpress.org/branches/5.2@45840


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-19 04:31:52 +00:00
Sergey Biryukov
ad85b0fe1d Accessibility: Fix the headings hierarchy in the legacy Custom Background and Custom Header pages. 
Props afercia.
Merges [45411] to the 5.2 branch.
Fixes #47386.
Built from https://develop.svn.wordpress.org/branches/5.2@45839


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-19 04:29:53 +00:00
Sergey Biryukov
b967202110 Media: Make sure the bottom media toolbar content is fully visible with Internet Explorer 11. 
Props mspatovaliyski, afercia.
Merges [45526] to the 5.2 branch.
Fixes #47502.
Built from https://develop.svn.wordpress.org/branches/5.2@45838


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-19 04:26:51 +00:00
Sergey Biryukov
e256b2897b Formatting: Don't convert smilies in ignored tags that have attributes. 
Smilies in ignored tags are not supposed to be converted to emoji, but this can malfunction if the tag has attributes. For example, the Preformatted block with add a `class` to the `<pre>` tag.

Props pento, jikamens.
Merges [45569] to the 5.2 branch.
Fixes #47489.
Built from https://develop.svn.wordpress.org/branches/5.2@45837


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-19 04:24:53 +00:00
Sergey Biryukov
303034e393 Editor: Correct since annotation for the excerpt_allowed_blocks filter. 
Props mukesh27, rabmalin.
Merges [45284] to the 5.2 branch.
Fixes #47079.
Built from https://develop.svn.wordpress.org/branches/5.2@45836


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-19 04:18:53 +00:00
Sergey Biryukov
7b8b2a7f5c Accessibility: Improve settings tables and forms after [45403]. 
- adds `role="presentation"` to the edit comment table 
- removes a few pointless `<fieldset>` elements
- adds a few missing `<label>` elements
- adds the CSS class `class="td-full"` to table rows spanning to multiple cells
- adds explicit `scope="row"` attribute to the table headers in `options-permalink.php`: this table is better communicated as data table 
- uses consistent label association in the "Privacy Settings" page
- in the installation page "Set up your database connection": associates descriptions to their inout fields using `aria-describedby`
- improves the link to gravatar.com in the `user-edit.php` page

Props afercia.
Merges [45416] to the 5.2 branch.
See #46899.
Fixes #47390.
Built from https://develop.svn.wordpress.org/branches/5.2@45835


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-19 04:15:52 +00:00
Sergey Biryukov
18987f840c Accessibility: Make sure layout tables across the admin are correctly linearized. 
Adds `role="presentation"` to the `<table>` elements used for layout purposes.

Ideally, HTML tables should be used for tabular data. When tables are used for layout purposes, it's important to remove any native semantics so that assistive technologies can correctly announce the table content in a linearized fashion.

Props greatislander, afercia.
Merges [45403] to the 5.2 branch.
See #46899.
Built from https://develop.svn.wordpress.org/branches/5.2@45834


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-19 04:13:54 +00:00
Sergey Biryukov
7b82b8fd18 Site Health: Use correct variable when checking PHP requirements for a plugin update in WP_Plugins_List_Table::single_row(). 
Props diddledan, sharaz, vaishalipanchal, afragen.
Merges [45750] to the 5.2 branch.
Fixes #47835.
Built from https://develop.svn.wordpress.org/branches/5.2@45833


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-19 04:09:52 +00:00
Sergey Biryukov
7ab695d1d6 Menus: Trim whitespace from custom link URLs. 
Props majemedia, SergeyBiryukov.
Merges [45655] and [45656] to the 5.2 branch.
Fixes #47723.
Built from https://develop.svn.wordpress.org/branches/5.2@45832


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-19 04:07:52 +00:00
Sergey Biryukov
d8a0523887 Editor: Fix undefined $locked var in edit-form-blocks.php when the show_post_locked_dialog filter is used to disable displaying of the dialog. 
Props aprea.
Merges [45564] to the 5.2 branch.
Fixes #47604.
Built from https://develop.svn.wordpress.org/branches/5.2@45831


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-19 04:04:52 +00:00
Sergey Biryukov
e81b064b0b Customize: Fix text direction for color picker in RTL. 
Props vjik, SergeyBiryukov.
Merges [45626] to the 5.2 branch.
Fixes #47688. See #23740.
Built from https://develop.svn.wordpress.org/branches/5.2@45830


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-19 04:02:52 +00:00
Sergey Biryukov
22eb801023 Block Editor: Avoid a PHP warning when a theme adds an editor style with an empty filename. 
Props pento, gqevu6bsiz.
Merges [45619] to the 5.2 branch.
Fixes #45739.
Built from https://develop.svn.wordpress.org/branches/5.2@45829


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-19 04:00:52 +00:00
Sergey Biryukov
37b995b2bb Menus: Fix the Custom Links text fallback. 
When adding a Custom Link and leaving the "Link Text" field empty, WordPress used to set a default fallback text: "Menu Item".

The changes in [36379] broke this behavior making the fallback text: `(Pending)`, with a leading space.

Pending major refactoring of the Menus page (which is going to use a block-based user interface) this change just restores the original behavior by adding the fallback text to the related AJAX response.

Props christophherr, Fencer04, thakkarhardik, backermann1978, audrasjb.
Merges [45727] to the 5.2 branch.
Fixes #38415.
Built from https://develop.svn.wordpress.org/branches/5.2@45828


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-19 03:56:53 +00:00
Sergey Biryukov
7bde97c5d1 Plugins: Fix the plugin details modal layout after [45520]. 
Props mukesh27, marybaum, audrasjb.
Merges [45563] to the 5.2 branch.
Fixes #47561.
Built from https://develop.svn.wordpress.org/branches/5.2@45666


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-24 22:02:56 +00:00
desrosj
65463622a1 Help/About: Improve wording of PHP Error Protection section. 
Merges [45551] to the 5.2 branch.

Props pedromendonca, garrett-eclipse.
See #47475.
Fixes #47538.
Built from https://develop.svn.wordpress.org/branches/5.2@45552


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-20 09:55:54 +00:00
desrosj
e58fe38b12 Post WordPress 5.2.2 version bump. 
Built from https://develop.svn.wordpress.org/branches/5.2@45550


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-18 18:12:52 +00:00
desrosj
41aff9bd35 Help/About: Update the About page for WordPress 5.2.2. 
Reviewed by ocean90, desrosj.

Props audrasjb.
Fixes #47558.
Built from https://develop.svn.wordpress.org/branches/5.2@45548


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-18 16:53:52 +00:00
desrosj
3fe25878ba WordPress 5.2.2. 
Built from https://develop.svn.wordpress.org/branches/5.2@45547


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-18 15:40:54 +00:00
Andrew Ozz
7447c360b5 Bump version on the 5.2 branch after releasing 5.2.2-RC2. 
Built from https://develop.svn.wordpress.org/branches/5.2@45534


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-13 17:33:53 +00:00
Andrew Ozz
d1cec4590f Bump version to 5.2.2-RC2 
Built from https://develop.svn.wordpress.org/branches/5.2@45533


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-13 17:08:52 +00:00
Andrew Ozz
5d7e433b1d Add a Recovery Mode Exit button to the notice. This fixes it in responsive view. 
Props desrosj, karmatosed, chetan200891, afercia, afragen, garrett-eclipse.
Merges [45529] to the 5.2 branch.
Fixes #47070.

Built from https://develop.svn.wordpress.org/branches/5.2@45530


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-13 16:05:52 +00:00
desrosj
70a8322fd3 Customize: Remove “Update” link for themes on multisite installs. 
In [38887], installing themes in the Customizer was disabled for multisite installs. However, an update link continues to be displayed when a theme update is available. Clicking the link causes a JavaScript error.

This removes that update link because updates cannot actually be performed in the Customizer in this situation.

Reviewed by desrosj and azaozz.
Merges [45527] to the 5.2 branch.

Props desrosj, earnjam, mukesh27, audrasjb, garrett-eclipse.
Fixes #46997.
Built from https://develop.svn.wordpress.org/branches/5.2@45528


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-13 15:34:52 +00:00
Andrea Fercia
63870541c7 Administration: Improve the horizontal centering of the Site Health tabs. 
Props dkarfa, davidbaumwald, Clorith, tinkerbelly, afercia.
Merges [45522] to the 5.2 branch.
Fixes #46881 for 5.2.2.

Built from https://develop.svn.wordpress.org/branches/5.2@45523


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-12 19:36:53 +00:00
Andrea Fercia
3d1f02b537 Administration: Fix the responsive layout after changes to the Screen Options and Help buttons position. 
Merges [45520] to the 5.2 branch.
Fixes #45094 for 5.2.2.

Built from https://develop.svn.wordpress.org/branches/5.2@45521


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-12 19:24:55 +00:00
desrosj
6b63fc5845 Post WordPress 5.2.2-RC1 version bump. 
Built from https://develop.svn.wordpress.org/branches/5.2@45518


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-10 19:37:52 +00:00
desrosj
cddad01ede WordPress 5.2.2-RC1. 
Built from https://develop.svn.wordpress.org/branches/5.2@45517


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-10 19:13:54 +00:00
Sergey Biryukov
3b157938be I18N: Merge duplicate "authenticity could not be verified" strings, fix comma placement on About page. 
Props pedromendonca, garrett-eclipse.
Merges [45515] to the 5.2 branch.
Fixes #47475.
Built from https://develop.svn.wordpress.org/branches/5.2@45516


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-10 14:16:53 +00:00
Andrea Fercia
8da585f83f Administration: Improve the Site Health tables layout for small screens. 
Props immeet94, jankimoradiya, desrosj, shashank3105, chetan200891, Clorith, hedgefield. 

Merges [45463] to the 5.2 branch.
Fixes #46960 for 5.2.2.

Built from https://develop.svn.wordpress.org/branches/5.2@45514


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-10 14:03:52 +00:00
Andrea Fercia
b2fbbe2100 Administration: Remove extra border from the Screen Options and Help buttons. 
The extra border was visible in the responsive view for smaller screens after [32844].

Props jitendrabanjara1991.

Merges [45501] and [45502] to the 5.2 branch.
Fixes #46749 for 5.2.2.

Built from https://develop.svn.wordpress.org/branches/5.2@45513


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-10 13:59:52 +00:00
Sergey Biryukov
7eab77d326 I18N: Merge duplicate "Status" and "Info" strings on Site Health screens. 
Props ramiy.
Merges [45488] to the 5.2 branch.
Fixes #47227.
Built from https://develop.svn.wordpress.org/branches/5.2@45512


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-10 13:48:52 +00:00
Sergey Biryukov
e28153577f Media: Restore correct arrow direction in RTL in Attachment Details modal. 
Reverts [29264]. As we now have a build task to replace dashicons for RTL, the CSS rules no longer worked as expected and had the opposite effect.

Props ramiy, SergeyBiryukov.
Merges [45495] to the 5.2 branch.
Fixes #46289.
Built from https://develop.svn.wordpress.org/branches/5.2@45511


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-10 13:46:52 +00:00
desrosj
f8677253e4 I18N: Combine similar strings with minor differences. 
Merges [45298] to the 5.2 branch.

Props dimadin.
Fixes #47158.
Built from https://develop.svn.wordpress.org/branches/5.2@45510


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-10 13:34:45 +00:00
Andrea Fercia
c3bc45b95d Accessibility: Improve the Screen Options and Help buttons order. 
- makes the buttons visual order match the DOM order
- also, restores the focus style on the "hero" primary button after [34948]

Props vrimill, mukesh27 for reporting and testing.
Merges [45503] to the 5.2 branch.
Fixes #45094 for 5.2.2.

Built from https://develop.svn.wordpress.org/branches/5.2@45509


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-10 13:33:52 +00:00
Peter Wilson
426d43abb7 Site health: Introduce view_site_health_checks capability. 
Introduces the faux primitive capability `view_site_health_checks` available to single site admins and multisite super-admin to view the site health page within the admin.

The capability is mapped to the `install_plugins` capability without being dependent on the file system being writable. This fixes a bug where the feature couldn't be used by sites unable to write to the file system or managed through version control.

The capability is granted on the `user_has_cap` filter.

Props birgire, Clorith, palmiak, peterwilsoncc, spacedmonkey.
Merges [45507] to the 5.2 branch.
Fixes #46957 for 5.2.2.


Built from https://develop.svn.wordpress.org/branches/5.2@45508


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-10 07:50:53 +00:00
youknowriad
3b810cf2a3 Block Editor: Update packages to the ones slated for WP5.2.2 
- Fix the template validation notice
 - Fix for focus jumps when typing in meta attributes

Packages updated:

 - @wordpress/block-editor@2.0.3
 - @wordpress/block-library@2.4.6
 - @wordpress/e2e-tests@1.1.6
 - @wordpress/edit-post@3.3.6
 - @wordpress/editor@9.2.6
 - @wordpress/format-library@1.4.6

Props aduth, desrosj.
Merges [45481] to the 5.2 branch.
Fixes #47429.

Built from https://develop.svn.wordpress.org/branches/5.2@45482


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-30 15:48:56 +00:00
desrosj
51fa88c742 Post WordPress 5.2.1 version bump. The 5.2 branch is now 5.2.2-alpha. 
Built from https://develop.svn.wordpress.org/branches/5.2@45374


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-21 19:36:59 +00:00
desrosj
4e82993677 WordPress 5.2.1. 
Built from https://develop.svn.wordpress.org/branches/5.2@45372


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-21 18:18:53 +00:00
desrosj
5db435f564 Post WordPress 5.2.1-RC2 version bump. 
Built from https://develop.svn.wordpress.org/branches/5.2@45370


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-20 18:02:53 +00:00
desrosj
f1239a817e WordPress 5.2.1-RC2. 
Built from https://develop.svn.wordpress.org/branches/5.2@45369


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-20 17:43:53 +00:00
desrosj
67a2425575 Feeds: Ensure a feed’s <lastBuildDate> has the correct date. 
The maximum modified time for a is currently being determined after an arbitrary date format is applied. Because the string sort in `max()` is being used to return the highest (most recent) modified value, the incorrect date is sometimes returned. This was introduced in [45247].

Merges [45367] to the 5.2 branch.

Reviewed by desrosj, SergeyBiryukov.
Props onlanka, Rarst, mukesh27.
Fixes #47304.
Built from https://develop.svn.wordpress.org/branches/5.2@45368


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-20 14:47:54 +00:00
Sergey Biryukov
da22a1cc85 Upgrade/Install: As a follow-up to [45357], when linking to Update PHP support page in error messages, check if wp_get_update_php_url() and wp_get_update_php_annotation() exist. 
`wp-admin/includes/update-core.php` runs in the context of the previous WordPress version. Any calls to newly introduced functions there need to be checked via `function_exists()`.

Reviewed by desrosj, earnjam, SergeyBiryukov.

Props dd32, imath.
Merges [45365] to the 5.2 branch.
Fixes #47323.
Built from https://develop.svn.wordpress.org/branches/5.2@45366


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-20 14:32:02 +00:00
desrosj
b3425b83cd Help/About: Replace minor release strings with pre-existing ones. 
Also, update the number of bugs fixed in 5.2.1 to include those being fixed after RC1.

Reviewed by desrosj, SergeyBiryukov.

Props ocean90, SergeyBiryukov, mukesh27.
Fixes #47312.
Built from https://develop.svn.wordpress.org/branches/5.2@45364


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-20 14:22:02 +00:00
desrosj
d1ff0af1e7 Post WordPress 5.2.1-RC1 version bump. 
Built from https://develop.svn.wordpress.org/branches/5.2@45361


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-17 19:43:53 +00:00
desrosj
8b6279d42c WordPress 5.2.1-RC1. 
Built from https://develop.svn.wordpress.org/branches/5.2@45360


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-17 19:09:02 +00:00
desrosj
d7266b423d Help/About: Update the about page for 5.2.1. 
32 bugs were squashed in 5.2.1.

Props earnjam, ianbelanger, chanthaboune.
Fixes #47294.
Built from https://develop.svn.wordpress.org/branches/5.2@45359


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-17 18:51:52 +00:00
Sergey Biryukov
1c574a4d6b Upgrade/Install: Improve error messages displayed when WordPress update fails due to an incompatible PHP version by linking to the Update PHP support page. 
Additionally, fix a regression in [44451] where the error message in `wp-admin/upgrade.php` was prepared, but never displayed.

Props afragen, netweb, hareesh-pillai, SergeyBiryukov.
Merges [45357] to the 5.2 branch.
Fixes #46937.
Built from https://develop.svn.wordpress.org/branches/5.2@45358


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-17 18:16:54 +00:00
desrosj
0e0e8daf1d Upgrade/Install: Don't run signature verify on slow 32-bit systems. 
The `sodium_compat` library can be very slow for certain operations on 32-bit architectures, which can lead to web server timeouts while attempting to verify an update. This adds a runtime speed check to skip signature verification on systems that would otherwise time out. Includes simple unit tests.

Merges [45345] to the 5.2 branch.

Props dd32, paragoninitiativeenterprises, tellyworth.
Fixes #47186.
Built from https://develop.svn.wordpress.org/branches/5.2@45356


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-17 17:49:54 +00:00
desrosj
10effe89b5 Upgrade/Install: Update sodium_compat to v1.10.0. 
This adds a `runtime_speed_test()` method for estimating if the 32-bit implementation is fast enough for expensive computations.

Merges [45344] to the 5.2 branch.

Props paragoninitiativeenterprises, tellyworth.
See #47186.
Built from https://develop.svn.wordpress.org/branches/5.2@45355


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-17 17:20:53 +00:00