Commit Graph

26828 Commits

Author SHA1 Message Date
Andrea Fercia
8da585f83f Administration: Improve the Site Health tables layout for small screens.
Props immeet94, jankimoradiya, desrosj, shashank3105, chetan200891, Clorith, hedgefield. 

Merges [45463] to the 5.2 branch.
Fixes #46960 for 5.2.2.

Built from https://develop.svn.wordpress.org/branches/5.2@45514


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 14:03:52 +00:00
Andrea Fercia
b2fbbe2100 Administration: Remove extra border from the Screen Options and Help buttons.
The extra border was visible in the responsive view for smaller screens after [32844].

Props jitendrabanjara1991.

Merges [45501] and [45502] to the 5.2 branch.
Fixes #46749 for 5.2.2.

Built from https://develop.svn.wordpress.org/branches/5.2@45513


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 13:59:52 +00:00
Sergey Biryukov
7eab77d326 I18N: Merge duplicate "Status" and "Info" strings on Site Health screens.
Props ramiy.
Merges [45488] to the 5.2 branch.
Fixes #47227.
Built from https://develop.svn.wordpress.org/branches/5.2@45512


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 13:48:52 +00:00
Sergey Biryukov
e28153577f Media: Restore correct arrow direction in RTL in Attachment Details modal.
Reverts [29264]. As we now have a build task to replace dashicons for RTL, the CSS rules no longer worked as expected and had the opposite effect.

Props ramiy, SergeyBiryukov.
Merges [45495] to the 5.2 branch.
Fixes #46289.
Built from https://develop.svn.wordpress.org/branches/5.2@45511


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 13:46:52 +00:00
desrosj
f8677253e4 I18N: Combine similar strings with minor differences.
Merges [45298] to the 5.2 branch.

Props dimadin.
Fixes #47158.
Built from https://develop.svn.wordpress.org/branches/5.2@45510


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 13:34:45 +00:00
Andrea Fercia
c3bc45b95d Accessibility: Improve the Screen Options and Help buttons order.
- makes the buttons visual order match the DOM order
- also, restores the focus style on the "hero" primary button after [34948]

Props vrimill, mukesh27 for reporting and testing.
Merges [45503] to the 5.2 branch.
Fixes #45094 for 5.2.2.

Built from https://develop.svn.wordpress.org/branches/5.2@45509


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 13:33:52 +00:00
Peter Wilson
426d43abb7 Site health: Introduce view_site_health_checks capability.
Introduces the faux primitive capability `view_site_health_checks` available to single site admins and multisite super-admin to view the site health page within the admin.

The capability is mapped to the `install_plugins` capability without being dependent on the file system being writable. This fixes a bug where the feature couldn't be used by sites unable to write to the file system or managed through version control.

The capability is granted on the `user_has_cap` filter.

Props birgire, Clorith, palmiak, peterwilsoncc, spacedmonkey.
Merges [45507] to the 5.2 branch.
Fixes #46957 for 5.2.2.


Built from https://develop.svn.wordpress.org/branches/5.2@45508


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 07:50:53 +00:00
youknowriad
3b810cf2a3 Block Editor: Update packages to the ones slated for WP5.2.2
- Fix the template validation notice
 - Fix for focus jumps when typing in meta attributes

Packages updated:

 - @wordpress/block-editor@2.0.3
 - @wordpress/block-library@2.4.6
 - @wordpress/e2e-tests@1.1.6
 - @wordpress/edit-post@3.3.6
 - @wordpress/editor@9.2.6
 - @wordpress/format-library@1.4.6

Props aduth, desrosj.
Merges [45481] to the 5.2 branch.
Fixes #47429.

Built from https://develop.svn.wordpress.org/branches/5.2@45482


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 15:48:56 +00:00
desrosj
51fa88c742 Post WordPress 5.2.1 version bump. The 5.2 branch is now 5.2.2-alpha.
Built from https://develop.svn.wordpress.org/branches/5.2@45374


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-21 19:36:59 +00:00
desrosj
4e82993677 WordPress 5.2.1.
Built from https://develop.svn.wordpress.org/branches/5.2@45372


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-21 18:18:53 +00:00
desrosj
5db435f564 Post WordPress 5.2.1-RC2 version bump.
Built from https://develop.svn.wordpress.org/branches/5.2@45370


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-20 18:02:53 +00:00
desrosj
f1239a817e WordPress 5.2.1-RC2.
Built from https://develop.svn.wordpress.org/branches/5.2@45369


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-20 17:43:53 +00:00
desrosj
67a2425575 Feeds: Ensure a feed’s <lastBuildDate> has the correct date.
The maximum modified time for a is currently being determined after an arbitrary date format is applied. Because the string sort in `max()` is being used to return the highest (most recent) modified value, the incorrect date is sometimes returned. This was introduced in [45247].

Merges [45367] to the 5.2 branch.

Reviewed by desrosj, SergeyBiryukov.
Props onlanka, Rarst, mukesh27.
Fixes #47304.
Built from https://develop.svn.wordpress.org/branches/5.2@45368


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-20 14:47:54 +00:00
Sergey Biryukov
da22a1cc85 Upgrade/Install: As a follow-up to [45357], when linking to Update PHP support page in error messages, check if wp_get_update_php_url() and wp_get_update_php_annotation() exist.
`wp-admin/includes/update-core.php` runs in the context of the previous WordPress version. Any calls to newly introduced functions there need to be checked via `function_exists()`.

Reviewed by desrosj, earnjam, SergeyBiryukov.

Props dd32, imath.
Merges [45365] to the 5.2 branch.
Fixes #47323.
Built from https://develop.svn.wordpress.org/branches/5.2@45366


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-20 14:32:02 +00:00
desrosj
b3425b83cd Help/About: Replace minor release strings with pre-existing ones.
Also, update the number of bugs fixed in 5.2.1 to include those being fixed after RC1.

Reviewed by desrosj, SergeyBiryukov.

Props ocean90, SergeyBiryukov, mukesh27.
Fixes #47312.
Built from https://develop.svn.wordpress.org/branches/5.2@45364


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-20 14:22:02 +00:00
desrosj
d1ff0af1e7 Post WordPress 5.2.1-RC1 version bump.
Built from https://develop.svn.wordpress.org/branches/5.2@45361


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 19:43:53 +00:00
desrosj
8b6279d42c WordPress 5.2.1-RC1.
Built from https://develop.svn.wordpress.org/branches/5.2@45360


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 19:09:02 +00:00
desrosj
d7266b423d Help/About: Update the about page for 5.2.1.
32 bugs were squashed in 5.2.1.

Props earnjam, ianbelanger, chanthaboune.
Fixes #47294.
Built from https://develop.svn.wordpress.org/branches/5.2@45359


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 18:51:52 +00:00
Sergey Biryukov
1c574a4d6b Upgrade/Install: Improve error messages displayed when WordPress update fails due to an incompatible PHP version by linking to the Update PHP support page.
Additionally, fix a regression in [44451] where the error message in `wp-admin/upgrade.php` was prepared, but never displayed.

Props afragen, netweb, hareesh-pillai, SergeyBiryukov.
Merges [45357] to the 5.2 branch.
Fixes #46937.
Built from https://develop.svn.wordpress.org/branches/5.2@45358


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 18:16:54 +00:00
desrosj
0e0e8daf1d Upgrade/Install: Don't run signature verify on slow 32-bit systems.
The `sodium_compat` library can be very slow for certain operations on 32-bit architectures, which can lead to web server timeouts while attempting to verify an update. This adds a runtime speed check to skip signature verification on systems that would otherwise time out. Includes simple unit tests.

Merges [45345] to the 5.2 branch.

Props dd32, paragoninitiativeenterprises, tellyworth.
Fixes #47186.
Built from https://develop.svn.wordpress.org/branches/5.2@45356


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 17:49:54 +00:00
desrosj
10effe89b5 Upgrade/Install: Update sodium_compat to v1.10.0.
This adds a `runtime_speed_test()` method for estimating if the 32-bit implementation is fast enough for expensive computations.

Merges [45344] to the 5.2 branch.

Props paragoninitiativeenterprises, tellyworth.
See #47186.
Built from https://develop.svn.wordpress.org/branches/5.2@45355


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 17:20:53 +00:00
desrosj
4ce6eb57b6 jQuery: bring jquery.js back into the WordPress SVN repo and backport the patch from 3.4.0.
Merges [45342] to the 5.2 branch.

Props MikeNGarrett, peterwilsoncc, azaozz.
Fixes #47020.
Built from https://develop.svn.wordpress.org/branches/5.2@45354


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 17:08:53 +00:00
Sergey Biryukov
2e6afd6f81 Media: Fix deletion of files on Windows.
`wp_delete_file_from_directory()` should always normalize file paths before comparing.

Props tonybogdanov, SergeyBiryukov.
Merges [45352] to the 5.2 branch.
Fixes #47185.
Built from https://develop.svn.wordpress.org/branches/5.2@45353


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 13:31:53 +00:00
Sergey Biryukov
a582a30bf4 Build/Test Tools: Use a non-zero exit code in wp_check_php_mysql_versions() when minimum PHP or MySQL requirements are not met.
This allows automated scripts and test suites to interpret the result correctly.

Props jrf, spacedmonkey.
Merges [45350] to the 5.2 branch.
Fixes #47169.
Built from https://develop.svn.wordpress.org/branches/5.2@45351


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 12:38:53 +00:00
Sergey Biryukov
50cec5733c Formatting: Adjust wp_targeted_link_rel() to ensure JSON format is preserved and correct quotes are used when adding the missing rel attribute.
Props birgire, TobiasBg, fierevere, audrasjb, SergeyBiryukov.
Merges [45348] to the 5.2 branch.
Fixes #46316, #47244.
Built from https://develop.svn.wordpress.org/branches/5.2@45349


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 12:13:03 +00:00
Sergey Biryukov
f47af3f8d6 Site Health: In PHP modules test description, move the space before the screen reader text out from the translatable string.
Props ocean90, tobifjellner.
Merges [45346] to the 5.2 branch.
Fixes #47161.
Built from https://develop.svn.wordpress.org/branches/5.2@45347


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 11:56:52 +00:00
Andrew Ozz
6ba2cde3a3 Update TinyMCE to 4.9.4. Changelog: https://github.com/tinymce/tinymce/blob/4.x/changelog.txt.
Props parkcityj, azaozz.
Merges [45316] to the 5.2 branch.
Fixes #47229 #47205.
Built from https://develop.svn.wordpress.org/branches/5.2@45343


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 04:49:54 +00:00
Sergey Biryukov
7b594da461 Accessibility: In back-compat code added for get_search_form() in [44956], when checking the (previously boolean) $args value, account for non-strict comparison.
Props dkarfa, sachyya-sachet.
Merges [45340] to the 5.2 branch.
Fixes #47177. See #42057.
Built from https://develop.svn.wordpress.org/branches/5.2@45341


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 02:24:55 +00:00
Sergey Biryukov
3715885b2b Help/About: Restore placeholder for WordPress version in tagline on About, Credits, and Freedoms pages to include minor versions.
Props desrosj, mukesh27.
Merges [45338] to the 5.2 branch.
Fixes #46408.
Built from https://develop.svn.wordpress.org/branches/5.2@45339


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 01:09:52 +00:00
Sergey Biryukov
12a29911fb Site Health: Use correct singular string for plugin and theme version tests.
Props edocev, Presskopp.
Merges [45336] to the 5.2 branch.
Fixes #47264.
Built from https://develop.svn.wordpress.org/branches/5.2@45337


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 01:01:53 +00:00
Sergey Biryukov
84256959b7 I18N: Avoid using placeholders for link start and end tags in alt text description strings added in [45158].
Use an established pattern of moving additional link attributes out of the translatable string.

Props dimadin.
Merges [45334] to the 5.2 branch.
Fixes #47159.
Built from https://develop.svn.wordpress.org/branches/5.2@45335


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 00:56:54 +00:00
desrosj
9bb8bd243e Accessibility: Improve the "skip links" position for medium and small screens.
Merges [45301] to the 5.2 branch.

Props afercia.
Fixes #47065.
Built from https://develop.svn.wordpress.org/branches/5.2@45333


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 00:42:54 +00:00
Sergey Biryukov
608c219a7d Site Health: In PHP modules test, ensure the description is translated as a whole sentence, not as separate string parts.
Props dimadin, SergeyBiryukov.
Merges [45331] to the 5.2 branch.
Fixes #47161.
Built from https://develop.svn.wordpress.org/branches/5.2@45332


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 00:09:54 +00:00
Sergey Biryukov
4319986977 Site Health: Update mergeinfo for [45329].
See #47297.
Built from https://develop.svn.wordpress.org/branches/5.2@45330


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 22:30:54 +00:00
Sergey Biryukov
056dae6ac5 Site Health: In HTTP requests test, when checking whether the WP_HTTP_BLOCK_EXTERNAL constant is defined, check its value as well.
Props chesio.
Merges [45328] to the 5.2 branch.
Fixes #47297.
Built from https://develop.svn.wordpress.org/branches/5.2@45329


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 22:24:53 +00:00
desrosj
a32c70deb9 Privacy: Prevent email field for personal data requests from overflowing.
Merges [45326] to the 5.2 branch.

Props anischarolia, ianbelanger, afercia.
Fixes #46961.
Built from https://develop.svn.wordpress.org/branches/5.2@45327


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 20:47:55 +00:00
desrosj
36bf915264 Menus: Fix alignment of menu actions on mobile.
In [41197], changes were made to improve the responsive view for the Menu Name field and Save buttons. This caused the Delete Menu button to be misaligned.

Merges [45324] to the 5.2 branch.

Props ianbelanger, audrasjb, afercia, mukesh27.
Fixes #47173.
Built from https://develop.svn.wordpress.org/branches/5.2@45325


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 19:08:53 +00:00
desrosj
3386574b51 Site Health: Improve alignment and spacing for section headers.
This changes the CSS for Site Health headers to use flexbox, which helps ensure the text is vertically aligned center and consistently spaced in both the Status and Info tabs. It also fixes an issue where the loading spinner GIF was cut off on smaller screens (originally reported in #47203.

Merges [45322] to the 5.2 branch.

Props Presskopp, odminstudios, kjellr, afercia, desrosj, hedgefield, ianbelanger, xavortm.
Fixes #47063.
Built from https://develop.svn.wordpress.org/branches/5.2@45323


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 18:33:01 +00:00
aduth
6400dfff00 Block Editor: Upgrade WordPress packages to the latest versions.
Updated packages:

 - @wordpress/annotations@1.2.3
 - @wordpress/block-editor@2.0.2
 - @wordpress/block-library@2.4.5
 - @wordpress/blocks@6.2.5
 - @wordpress/components@7.3.2
 - @wordpress/dom@2.2.5
 - @wordpress/e2e-tests@1.1.5
 - @wordpress/edit-post@3.3.5
 - @wordpress/editor@9.2.5
 - @wordpress/format-library@1.4.5
 - @wordpress/list-reusable-blocks@1.3.5
 - @wordpress/nux@3.2.5
 - @wordpress/rich-text@3.2.3

Props: youknowriad, gwwar, iseulde, tfrommen, gziolo.

Merges [45319] to the 5.2 branch.
Fixes #47284.

Built from https://develop.svn.wordpress.org/branches/5.2@45320


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 18:12:57 +00:00
desrosj
64f5990104 Accessibility: Add aria-current to the links in the <nav> elements introduced in [44905].
Also fixes a few translators comments and coding standards.

Merges [45300] to the 5.2 branch.

Props audrasjb, afercia.
Fixes #47106.
Built from https://develop.svn.wordpress.org/branches/5.2@45318


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 16:35:04 +00:00
desrosj
08844a2c42 Bootstrap/Load: Prevent PHP errors when a drop-in triggers fatal error protection.
When a drop-in (such as `advanced-cache.php`) contains a PHP error, additional PHP errors are caused when displaying the error protection screen because `load_default_textdomain()` and `WP_Error` are not yet available.

Though recovery mode is not supported for `mu-plugins` and drop-ins, fatal error protection is. This change ensures the error screen is displayed when a fatal error is encountered within a drop-in and not a white screen.

Merges [45311] to the 5.2 branch.

Props TimothyBlynJacobs, spacedmonkey, daxelrod.
Fixes #47265.
Built from https://develop.svn.wordpress.org/branches/5.2@45315


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-15 19:54:53 +00:00
desrosj
5bb4b73062 Site Health: Improve vertical alignment of icons in test result descriptions.
This change removes redundant CSS properties for different health check statuses in favor of utilizing the `.dashicons` class already in Core to define them more consistently. This also fixes the vertical alignment issues.

Merges [45309] to the 5.2 branch.

Props chetan200891, Clorith, desrosj.
Fixes #46940.
Built from https://develop.svn.wordpress.org/branches/5.2@45314


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-15 19:52:54 +00:00
desrosj
6d0e5ee9d0 Site Health: Link to the correct plugin update screen in multisite installs.
Merges [45308] to the 5.2 branch.

Props Clorith, sebastienserre, jeremyfelt, desrosj.
Fixes #47189.
Built from https://develop.svn.wordpress.org/branches/5.2@45313


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-15 19:49:52 +00:00
desrosj
7d01e72e43 Administration: Remove duplicate font-face declaration in Dashicons CSS.
This was causing console warnings in some browsers.

Merges [45310] to the 5.2 branch.

Props aduth, joen, afercia, timph, ianbelanger.
Fixes #47183.
Built from https://develop.svn.wordpress.org/branches/5.2@45312


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-15 19:47:55 +00:00
desrosj
d8620b86c7 Administration: Prevent cards on the Tools page from overflowing on small screens.
Merges [45296] to the 5.2 branch.

Props anischarolia, mukesh27.
Fixes #46972.
Built from https://develop.svn.wordpress.org/branches/5.2@45303


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-10 14:45:56 +00:00
desrosj
43aa419c4b Post WordPress 5.2 version bump.
Built from https://develop.svn.wordpress.org/branches/5.2@45295


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-07 21:20:53 +00:00
desrosj
03171ca85f WordPress 5.2.
Built from https://develop.svn.wordpress.org/branches/5.2@45291


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-07 19:39:54 +00:00
laurelfulford
0cea1e1e76 Default Themes: Bump the version numbers and release dates.
Update the theme versions and release dates for the default themes, in time for WordPress 5.2.

The POT files for Twenty Eleven and Twenty Ten have also been updated.

Reviewed by desrosj, jorbin.
Merges [45289] to the 5.2 branch.
Fixes #47172.


Built from https://develop.svn.wordpress.org/branches/5.2@45290


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-07 19:06:55 +00:00
desrosj
32fce28909 Help/About: Final 5.2 about page updates.
Use final image URLs and fix a bug in IE11 where images were being cut off.

Reviewed by afercia, desrosj.
Merges [45287] to the 5.2 branch.

Props afercia, SergeyBiryukov, ianbelanger, desrosj, audrasjb.
Fixes #46901.
Built from https://develop.svn.wordpress.org/branches/5.2@45288


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-07 17:22:56 +00:00
Andrew Ozz
dd6391bb09 Fix setup_postdata() to set the (inside the loop) globals before the_post action is fired. Follow-up from #42814 and [44941].
Props david.binda, spacedmonkey, boonebgorges, birgire, jorbin, azaozz.
Merges [45285] from trunk.
Fixes #47114 for 5.2.


Built from https://develop.svn.wordpress.org/branches/5.2@45286


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-04 21:08:18 +00:00
desrosj
a1f4b046d7 Post WordPress 5.2 RC2 version bump.
Built from https://develop.svn.wordpress.org/trunk@45280


git-svn-id: http://core.svn.wordpress.org/trunk@45089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-02 16:13:54 +00:00
desrosj
0aa044f0e1 WordPress 5.2 RC2.
Built from https://develop.svn.wordpress.org/trunk@45279


git-svn-id: http://core.svn.wordpress.org/trunk@45088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-02 16:04:51 +00:00
desrosj
3360974ad2 Help/About: Polish the About page for 5.2.
- The About page now uses a CSS grid to layout its design, making the page’s structure more obvious and hopefully easier for contributors in the future.
- Removes some code that is no longer used (such as videos, mejs elements, etc.).
- Update images.
- Unnecessary HTML is removed from a string on the page. This was a regression.
- Only users with the correct capability should be instructed to check their site status.
- Fixes the placement of commas.

Reviewed by melchoyce, afercia, jeremyfelt, and desrosj.

Props ryelle, melchoyce, cathibosco1, man4toman, SergeyBiryukov, afercia, ramiy, kjellr, tellyworth, earnjam, andreamiddleton, marybaum.
See #46901.
Built from https://develop.svn.wordpress.org/trunk@45278


git-svn-id: http://core.svn.wordpress.org/trunk@45087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-02 15:44:53 +00:00
desrosj
d48b709071 Bootstrap/Load: Ensure recovery link email and related notices are properly translated.
When recovery mode is triggered before the site’s locale has been initialized, the message displayed to the user and the email sent to the site administrator with the recovery mode link are always rendered in `en_US`. This change ensures the site’s locale is used even when an error happens early in the loading process.

Reviewed by swissspidy, SergeyBiryukov, and desrosj.

Props wolly, TimothyBlynJacobs, fierevere.
Fixes #47093.
Built from https://develop.svn.wordpress.org/trunk@45277


git-svn-id: http://core.svn.wordpress.org/trunk@45086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-02 10:53:52 +00:00
desrosj
d53659ed71 Help/About: Fix tab display issues.
This change restores About page tab heights and fixes bugs with the tab bottom border caused by [44905] and [45243].

Reviewed by SergeyBiryukov and desrosj.

Props ixkaito, ianbelanger, afercia, SergeyBiryukov.
See #46901.
Fixes #47075.
Built from https://develop.svn.wordpress.org/trunk@45276


git-svn-id: http://core.svn.wordpress.org/trunk@45085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-02 10:37:51 +00:00
desrosj
6ac1d4ec1a Site Health: Disable recommendations that could be problematic on multisite installs.
When viewing Site Health for a multisite install, there are a few recommendations that are not appropriate and could have negative implications for other sites on the install if the administrator follows the advice provided.

For example, Site Health recommends that inactive plugins and themes for a site should be removed. On a single site install, this is a great recommendation. However, on a multisite install, inactive plugins and themes for one site should not be removed because they could be active for other sites on the network.

This change also disables the `test_wp_version_check_attached()` test for multisite. This test checks for the presence of the `wp_version_check()` function on the `wp_version_check` hook, which is not present for every site on multisite.

Reviewed by jeremyfelt and desrosj.

Props iandunn, Clorith, azaozz, jeremyfelt.
Fixes #47084.
Built from https://develop.svn.wordpress.org/trunk@45275


git-svn-id: http://core.svn.wordpress.org/trunk@45084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-01 18:08:53 +00:00
Aaron Jorbin
e4a0fd4c01 Admin: Add some additional clarity to some about page links
It's important for links to have enough information in them in order to be clearly actionable. Destination and purpose should be clear. For example, `debug` isn't nearly as useful as `learn how to debug issues`.

This was signed off on by chanthaboune and jorbin.

Props afercia.
See: #46901.


Built from https://develop.svn.wordpress.org/trunk@45274


git-svn-id: http://core.svn.wordpress.org/trunk@45083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-30 17:31:55 +00:00
Gary Pendergast
0344202063 Post WordPress 5.2 RC1 version bump
Built from https://develop.svn.wordpress.org/trunk@45273


git-svn-id: http://core.svn.wordpress.org/trunk@45082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-26 01:23:53 +00:00
Gary Pendergast
754dca460c WordPress 5.2 RC1
Built from https://develop.svn.wordpress.org/trunk@45272


git-svn-id: http://core.svn.wordpress.org/trunk@45081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-26 01:15:52 +00:00
Gary Pendergast
d86524f09d Admin: Add the text for the WordPress 5.2 About page.
This changes includes placeholder images for now, they'll be replaced by the final images before final release.

Props chanthaboune, melchoyce, karmatosed, pento, marybaum, birgire, earnjam, andreamiddleton.
See #46901.


Built from https://develop.svn.wordpress.org/trunk@45271


git-svn-id: http://core.svn.wordpress.org/trunk@45080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-26 00:57:53 +00:00
Gary Pendergast
0bbfe42ab1 Media: Revert [44947].
`get_available_post_mime_types()` uses a query that's extremely slow on sites with lots of posts. The original fix can be revisited after those performance issues are tackled.

See #43658.

Built from https://develop.svn.wordpress.org/trunk@45270


git-svn-id: http://core.svn.wordpress.org/trunk@45079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-26 00:44:52 +00:00
Andrea Fercia
700f891c36 Accessibility: Remove redundant title attribute from the "Exit Recovery Mode" link.
Fixes #47045.

Built from https://develop.svn.wordpress.org/trunk@45269


git-svn-id: http://core.svn.wordpress.org/trunk@45078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-25 16:04:53 +00:00
Gary Pendergast
3b5307339d Bootstrap/Load: Tweak the recovery mode email text and behaviour.
- Change the recovery mode link expiry to 1 day.
- Improve the email text.
- Add a new `recovery_email_support_info` filter, for hosts to be able to customise their support contact information.

Props pento, chanthaboune, michelleweber, matt.
Fixes #46898.


Built from https://develop.svn.wordpress.org/trunk@45268


git-svn-id: http://core.svn.wordpress.org/trunk@45077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-25 00:47:52 +00:00
K. Adam White
0b6f00fde2 REST API: Always urlencode_deep() query args in get_items methods.
Passing all received query arguments through urlencode_deep ensures that the full set of query arguments are encoded in the same way.

Props dmsnell.
Fixes #46199

Built from https://develop.svn.wordpress.org/trunk@45267


git-svn-id: http://core.svn.wordpress.org/trunk@45076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-25 00:08:52 +00:00
Sergey Biryukov
8b333f8c20 Docs: Use 3-digit, x.x.x style semantic versioning for @since 5.2.0 entries in wp-admin/includes/file.php.
See #46543.
Built from https://develop.svn.wordpress.org/trunk@45266


git-svn-id: http://core.svn.wordpress.org/trunk@45075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-24 23:36:51 +00:00
Andrew Ozz
655c21bbea Fix parsing of inner blocks when auto-generating an excerpt. Helps to prevent cases where dynamic inner blocks may cause an infinite loop if trying to auto-generate an excerpt.
Props desrosj, pento, gziolo, azaozz.
Fixes #46133.
Built from https://develop.svn.wordpress.org/trunk@45265


git-svn-id: http://core.svn.wordpress.org/trunk@45074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-24 21:39:53 +00:00
Sergey Biryukov
ac7877ce6f Twenty Nineteen: Fix padding discrepancies in responsive styles for Column block.
Props kjellr, dianeco.
Fixes #46643, #46999.
Built from https://develop.svn.wordpress.org/trunk@45264


git-svn-id: http://core.svn.wordpress.org/trunk@45073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-24 18:37:52 +00:00
Sergey Biryukov
54c7c76836 Bootstrap/Load: Modify the fatal error template to indicate to the user that they can check the admin email address for further instructions.
Props spacedmonkey, TimothyBlynJacobs.
Fixes #46950.
Built from https://develop.svn.wordpress.org/trunk@45263


git-svn-id: http://core.svn.wordpress.org/trunk@45072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-24 18:14:53 +00:00
tellyworth
ed802428e3 Upgrade/install: fix verification bugs and scale back signature checks.
This fixes several bugs in the signature verification code:
Disables signature checks on certain incompatible PHP versions that cause math errors when opcache is enabled;
Prevents a spurious URL and subsequent error when downloading a zip file with query arguments;
Prevents errors triggered by third-party upgrade scripts as per #46615;
Disables signature tests for Plugins, Themes, and Translations, leaving only core updates.

At the 5.2 release the API servers will only provide signatures for core update packages, which is why messages are suppressed for plugins and other package types. Signatures for those other items will become available later.

Props dd32.
See #39309, #46615


Built from https://develop.svn.wordpress.org/trunk@45262


git-svn-id: http://core.svn.wordpress.org/trunk@45071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-24 07:44:51 +00:00
Andrew Ozz
df438d90a0 Remove the core/more block delimiters when splitting post_content on the <!--more--> tag.
Fixes:
- Parsing of blocks in the second half of post_content.
- Outputting malformed HTML when `the_content( null, true )` or  `<!--noteaser-->` is used.

Props lukecarbis, garrett-eclipse, birgire.
Fixes #46471.
Built from https://develop.svn.wordpress.org/trunk@45261


git-svn-id: http://core.svn.wordpress.org/trunk@45070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-24 05:40:52 +00:00
Andrew Ozz
0da8c2265f Site Health: Fix count of inactive themes and the recommendation to remove them when the default theme is active or is a parent of the active child theme.
Props sudhiryadav, ianbelanger, mukesh27, azaozz.
Fixes #46900.
Built from https://develop.svn.wordpress.org/trunk@45260


git-svn-id: http://core.svn.wordpress.org/trunk@45069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-23 21:37:53 +00:00
Andrew Ozz
2548263bac Site Health: Allow some HTML (inline tags only) in the section descriptions. Add some more docs about expected formatting of the gathered data.
Props kraftbj, jeherve, mukesh27, audrasjb, azaozz.
Fixes #46878.
Built from https://develop.svn.wordpress.org/trunk@45259


git-svn-id: http://core.svn.wordpress.org/trunk@45068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-23 21:05:52 +00:00
laurelfulford
c7f2bda6f2 Twenty Nineteen: Prevent too-long strings from causing horizontal scrolling.
Add hyphen and word-wrap styles to the site title, comments, and widget areas to break too-long strings and prevent horizontal scrolling.

Props ianbelanger, dswebsme, mukesh27.
Fixes #46704.


Built from https://develop.svn.wordpress.org/trunk@45258


git-svn-id: http://core.svn.wordpress.org/trunk@45067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-23 19:48:53 +00:00
laurelfulford
9950f8b71e Twenty Seventeen: Prevent too-long strings from causing horizontal scrolling.
Add a `max-width` to the site title, so too-long strings will wrap instead of causing horizontal scrolling. 

Props ianbelanger, dswebsme.
Fixes #46703.


Built from https://develop.svn.wordpress.org/trunk@45257


git-svn-id: http://core.svn.wordpress.org/trunk@45066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-23 16:44:52 +00:00
Adam Silverstein
18ccaf962e Bundled Theme: add a wp_body_open shim for older WordPress versions.
WordPress 5.2 adds the `wp_body_open()` function, and the default themes make use of it. This patch adds a shim for `wp_body_open` to bundled themes so this function will also work in older versions of WordPress.

Props lgedeon, johnbillion, timph, ramiy, pento.
Fixes #46679.


Built from https://develop.svn.wordpress.org/trunk@45256


git-svn-id: http://core.svn.wordpress.org/trunk@45065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-23 13:04:56 +00:00
aduth
0feb55f633 Editor: Update packages to apply bugfixes from Gutenberg 5.5.
- @wordpress/block-editor@2.0.1
- @wordpress/block-library@2.4.4
- @wordpress/blocks@6.2.4
- @wordpress/components@7.3.1
- @wordpress/dom@2.2.4
- @wordpress/e2e-tests@1.1.4
- @wordpress/edit-post@3.3.4
- @wordpress/editor@9.2.4
- @wordpress/format-library@1.4.4
- @wordpress/list-reusable-blocks@1.3.4
- @wordpress/nux@3.2.4

Props iseulde, kjellr, aduth, get_dave, talldanwp, jorgefilipecosta, afercia, nosolosw, jasmussen, netweb .

See https://github.com/WordPress/gutenberg/pull/14987 .
See https://github.com/WordPress/gutenberg/pull/15020 .
Fixes #46951 .

Built from https://develop.svn.wordpress.org/trunk@45255


git-svn-id: http://core.svn.wordpress.org/trunk@45064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-22 12:40:04 +00:00
Sergey Biryukov
355d5f9bb7 Docs: Correct @param type for $deprecated and $plugin_rel_path arguments of load_plugin_textdomain().
Props sudar.
Fixes #43304.
Built from https://develop.svn.wordpress.org/trunk@45254


git-svn-id: http://core.svn.wordpress.org/trunk@45063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-19 14:21:53 +00:00
Sergey Biryukov
d5c77c833a Docs: Add missing @since tag for WP_Recovery_Mode_Cookie_Service::parse_cookie().
Props mukesh27.
Fixes #46993.
Built from https://develop.svn.wordpress.org/trunk@45253


git-svn-id: http://core.svn.wordpress.org/trunk@45062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-19 14:00:51 +00:00
Sergey Biryukov
bd9421104a Networks and Sites: Use correct escaping function for classes added via ms_user_list_site_class filter.
Props david.binda.
Fixes #46990. See #41146.
Built from https://develop.svn.wordpress.org/trunk@45252


git-svn-id: http://core.svn.wordpress.org/trunk@45061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-19 13:51:51 +00:00
Sergey Biryukov
c9efbc89be Docs: Correct @return description for get_privacy_policy_template().
Props tmatsuur.
Fixes #46989. See #44005.
Built from https://develop.svn.wordpress.org/trunk@45251


git-svn-id: http://core.svn.wordpress.org/trunk@45060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-19 13:46:51 +00:00
Sergey Biryukov
8fdb4c2b0c Bundled Themes: Update readme.txt files to pass Theme Review guidelines.
Props rabmalin.
Fixes #45871.
Built from https://develop.svn.wordpress.org/trunk@45250


git-svn-id: http://core.svn.wordpress.org/trunk@45059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-19 13:41:54 +00:00
Sergey Biryukov
643ec358a4 Docs: Correct @return description for get_dirsize().
Props wpboss, tmatsuur.
Fixes #46987.
Built from https://develop.svn.wordpress.org/trunk@45249


git-svn-id: http://core.svn.wordpress.org/trunk@45058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-19 13:39:52 +00:00
Andrea Fercia
22d8c0af3c Accessibility: Improve the "Alt text" description styles for small screens.
Amends [44900].
See #41612.

Built from https://develop.svn.wordpress.org/trunk@45248


git-svn-id: http://core.svn.wordpress.org/trunk@45057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 21:43:52 +00:00
Adam Silverstein
b287642342 Feeds: improve structure and naming of feed build date helper function.
Simplify overall code structure by passing the required format to the helper function.
Clarify functionality by renaming `get_last_build_date` to `get_feed_build_date`.

Props pento, spacedmonkey.
Fixes #4575.


Built from https://develop.svn.wordpress.org/trunk@45247


git-svn-id: http://core.svn.wordpress.org/trunk@45056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 17:08:52 +00:00
Dominik Schilling
2d58638ba0 Site Health: Fix debug data with nested fields for copying.
* Use `$debug_data` instead of `$field['value']` to retrieve the debug data.
* Rename inner variables to avoid overriding the output variable.

Props Clorith, ocean90.
See #46573.
Built from https://develop.svn.wordpress.org/trunk@45246


git-svn-id: http://core.svn.wordpress.org/trunk@45055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 16:26:51 +00:00
Dominik Schilling
3e6183c69c Site Health: Provide context for tab headings to be able to distinguish them from existing strings.
See #46573.
Built from https://develop.svn.wordpress.org/trunk@45245


git-svn-id: http://core.svn.wordpress.org/trunk@45054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 16:06:51 +00:00
Dominik Schilling
bfc2be39e6 Site Health: Enable JavaScript translations for the site-health script.
See #46683.
Built from https://develop.svn.wordpress.org/trunk@45244


git-svn-id: http://core.svn.wordpress.org/trunk@45053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 15:41:51 +00:00
Gary Pendergast
6fcd281707 CSS: Remove the units from line-height properties in common.css.
Props ianbelanger, talldanwp.
Fixes #46493.


Built from https://develop.svn.wordpress.org/trunk@45243


git-svn-id: http://core.svn.wordpress.org/trunk@45052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 06:02:53 +00:00
Gary Pendergast
4325de4629 KSES: Add background-position and grid-template-columns as safe CSS properties.
Props aduth.
Fixes #46597.


Built from https://develop.svn.wordpress.org/trunk@45242


git-svn-id: http://core.svn.wordpress.org/trunk@45051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 05:56:51 +00:00
Andrew Ozz
3a0563e853 Site Health info tab: fix replacing the size strings in the copied info.
Props xkon.
See #46707.
Built from https://develop.svn.wordpress.org/trunk@45241


git-svn-id: http://core.svn.wordpress.org/trunk@45050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 04:51:52 +00:00
Gary Pendergast
699f028f21 Emoji: Upgrade Twemoji to 12.0.1.
As this point release doesn't modify any images, only adding a few missing ones, we don't need to change the CDN location.

Props earnjam.
Fixes #46805.


Built from https://develop.svn.wordpress.org/trunk@45240


git-svn-id: http://core.svn.wordpress.org/trunk@45049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 02:11:52 +00:00
Andrew Ozz
9659676fca Site Health info tab: Remove the "Directories and Sizes" section on Multisite installations. Most of the info shown there doesn't apply for multisite.
Props xkon, desrosj, azaozz.
Built from https://develop.svn.wordpress.org/trunk@45239


git-svn-id: http://core.svn.wordpress.org/trunk@45048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 00:34:51 +00:00
Sergey Biryukov
2d81c95f73 Bootstrap/Load: Only send the recovery mode email if the error occurs on a protected endpoint.
This reduces the potential email noise to places where the fatal error could be interfering with the login and admin experience.

Once the user is in recovery mode, any fatal errors (even if they aren't in a protected endpoint) are handled and the plugin or theme will be paused.

Props TimothyBlynJacobs.
See #46950.
Built from https://develop.svn.wordpress.org/trunk@45238


git-svn-id: http://core.svn.wordpress.org/trunk@45047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 23:04:53 +00:00
Andrew Ozz
2a5c2a2cce Site health info tab: replace "Not calculated" with "Loading..." in the "Directories and Sizes" section (that's an existing string and wouldn't cause problems for translators).
See #46707.
Built from https://develop.svn.wordpress.org/trunk@45237


git-svn-id: http://core.svn.wordpress.org/trunk@45046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 21:26:52 +00:00
Jeremy Felt
7ec74901d3 Docs: Add arguments passed by wp_insert_site() to wp_initialize_site().
Props codemascot.
Fixes #45061.

Built from https://develop.svn.wordpress.org/trunk@45236


git-svn-id: http://core.svn.wordpress.org/trunk@45045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 20:57:52 +00:00
Sergey Biryukov
2e0e63f923 Users: In wp_list_authors(), check for author's post count before getting author's metadata.
This significantly reduces the number of SQL queries when `wp_list_authors()` is called on a site where the majority of users don't have any posts, e.g. a membership site.

Props billerickson, ianbelanger, dswebsme.
Fixes #45105.
Built from https://develop.svn.wordpress.org/trunk@45235


git-svn-id: http://core.svn.wordpress.org/trunk@45044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 14:50:50 +00:00
Sergey Biryukov
23de32062e Site Health: Allow any callable added via site_status_tests filter to return test results for direct tests.
Async tests still need to be a string for the AJAX action.

Props kraftbj.
Fixes #46836.
Built from https://develop.svn.wordpress.org/trunk@45234


git-svn-id: http://core.svn.wordpress.org/trunk@45043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 14:35:50 +00:00
Sergey Biryukov
1be34a234f Docs: Remove @global tag for $wpdb from wp-admin/install.php and wp-admin/upgrade.php.
Per the documentation standards, the `@global` tag is meant to list PHP globals used within functions or methods.

The code in question uses the variable in global namespace, but does not explicitly declare it.

Props jayupadhyay01, dswebsme.
Fixes #46602.
Built from https://develop.svn.wordpress.org/trunk@45233


git-svn-id: http://core.svn.wordpress.org/trunk@45042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 14:07:53 +00:00
Sergey Biryukov
d2ccaacedf Docs: Correct spelling in various comments and DocBlocks, per the conventions in Core Contributor Handbook.
Props man4toman, samanehmirrajabi.
Fixes #45857.
Built from https://develop.svn.wordpress.org/trunk@45232


git-svn-id: http://core.svn.wordpress.org/trunk@45041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 13:26:51 +00:00
Sergey Biryukov
e1de58320d Themes: Standardize on passing frontpage and privacypolicy as the $type parameter to get_query_template().
These keys are used in `{$type}_template_hierarchy` and `{$type}_template` filters.

Previously, `front_page` and `privacy_policy` were passed, but `get_query_template()` stripped the underscores before passing the values to the filters.

Props rinatkhaziev, tmatsuur, johnbillion.
Fixes #21213, #46958.
Built from https://develop.svn.wordpress.org/trunk@45231


git-svn-id: http://core.svn.wordpress.org/trunk@45040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 12:58:51 +00:00