Scott Taylor
d0a1a47708
Fix warnings after [33826]. Only only one function call needs a global $comment
, we shall hamburger it.
...
See #11566 .
Built from https://develop.svn.wordpress.org/trunk@33828
git-svn-id: http://core.svn.wordpress.org/trunk@33796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 20:59:21 +00:00
Drew Jaynes
cf7694717b
Docs: Clarify the DocBlock summary for wp_create_nonce()
to mention that nonce-creation is also now dependent on user tokens, as of [29221].
...
Also adds a changelog entry for when user tokens were introduced into the nonce-creation process.
Props ericlewis
Fixes #33636 .
Built from https://develop.svn.wordpress.org/trunk@33827
git-svn-id: http://core.svn.wordpress.org/trunk@33795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 20:50:20 +00:00
Scott Taylor
7ab015c5ab
WP_Comments_List_Table::single_row()
has no reason to set the $comment
global. No other methods use it, and we are not in template/loop context. This can mess with the response of get_comment()
elsewhere, since get_comment()
internally bypasses the cache/db when a global is set.
...
See #11566 .
Built from https://develop.svn.wordpress.org/trunk@33826
git-svn-id: http://core.svn.wordpress.org/trunk@33794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 20:42:21 +00:00
Sergey Biryukov
8b1fe986c3
Use wp_html_excerpt()
to properly cut comment author URL for display on Comments screen.
...
props brettz95, solarissmoke.
fixes #15659 .
Built from https://develop.svn.wordpress.org/trunk@33825
git-svn-id: http://core.svn.wordpress.org/trunk@33793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 20:41:21 +00:00
Scott Taylor
50d0f8f1ae
WP_Widget_Pages::widget()
has no reason to set $comment
and $comments
globals.
...
See #11566 .
Built from https://develop.svn.wordpress.org/trunk@33824
git-svn-id: http://core.svn.wordpress.org/trunk@33792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 20:31:22 +00:00
Scott Taylor
1f1b72b5f5
After [33822], really add those unit tests for wp_count_comments()
.
...
See #19903 .
Built from https://develop.svn.wordpress.org/trunk@33823
git-svn-id: http://core.svn.wordpress.org/trunk@33791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 18:51:41 +00:00
Scott Taylor
6ae78f0fe4
Comments: wp_count_comments()
can use get_comment_count()
internally to makes its DB query, provided that get_comment_count()
returns more properties.
...
Adds/updates unit tests. There were zero (0) unit tests for `wp_count_comments()`.
Fixes #19903 .
Built from https://develop.svn.wordpress.org/trunk@33822
git-svn-id: http://core.svn.wordpress.org/trunk@33790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 18:51:22 +00:00
Scott Taylor
7808d5d1fa
Comments: dynamically update the document title text of the Comments List Table page when dynamically updating the number of comments awaiting moderation.
...
Fixes #33414 .
Built from https://develop.svn.wordpress.org/trunk@33821
git-svn-id: http://core.svn.wordpress.org/trunk@33789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 17:58:22 +00:00
Sergey Biryukov
5a97ff5206
Bump H3 headings to H2 on Themes screen for better accessibility.
...
props joehills.
fixes #33560 .
Built from https://develop.svn.wordpress.org/trunk@33820
git-svn-id: http://core.svn.wordpress.org/trunk@33788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 03:51:21 +00:00
Sergey Biryukov
82a8cec3b3
Bump H3 headings to H2 on Tools screen for better accessibility.
...
props Cheffheid.
fixes #33607 .
Built from https://develop.svn.wordpress.org/trunk@33819
git-svn-id: http://core.svn.wordpress.org/trunk@33787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 03:32:21 +00:00
Sergey Biryukov
48c82ef14d
Bump H3 headings to H2 on Permalink Settings screen for better accessibility.
...
props Cheffheid.
fixes #33611 .
Built from https://develop.svn.wordpress.org/trunk@33818
git-svn-id: http://core.svn.wordpress.org/trunk@33786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 03:29:21 +00:00
Sergey Biryukov
fb3d54d569
Bump H3 headings to H2 on WordPress Updates screen for better accessibility.
...
props Cheffheid.
fixes #33559 .
Built from https://develop.svn.wordpress.org/trunk@33817
git-svn-id: http://core.svn.wordpress.org/trunk@33785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 03:26:24 +00:00
Drew Jaynes
4d006fad9e
Docs: Bring the file header and class DocBlock summaries for class-wp-widget.php in-line with the intention of the docs standard:
...
* File headers: _What_ the file is
* Class DocBlocks: What purpose the class serves. Mentioning the class name in the class DocBlock is redundant
See #33413
Built from https://develop.svn.wordpress.org/trunk@33816
git-svn-id: http://core.svn.wordpress.org/trunk@33784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-30 23:14:21 +00:00
Konstantin Obenland
1e9372b699
Themes: Get the correct theme when template and stylesheet were both passed as arguments.
...
Fixes a bug where `$new_theme` got set before the second argument was
appropriately handled, causing the `current_theme` option to later always be
updated to the parent theme's name.
Introduced in [21131].
Props obenland, wonderboymusic.
Fixes #32635 .
Built from https://develop.svn.wordpress.org/trunk@33815
git-svn-id: http://core.svn.wordpress.org/trunk@33783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-30 21:45:23 +00:00
Scott Taylor
b35b167cfc
Improve/update escaping in default widgets:
...
* wrap some variables in `esc_attr()` before echoing
* replace some `strip_tags()` calls with `sanitize_text_field()`
* call `esc_url()` when wrapping some URLs
Props welcher.
See #23012 .
Built from https://develop.svn.wordpress.org/trunk@33814
git-svn-id: http://core.svn.wordpress.org/trunk@33782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-30 05:38:21 +00:00
Scott Taylor
42f915273d
Improve/update escaping in WP_Widget_Pages
.
...
Props welcher.
See #23012 .
Built from https://develop.svn.wordpress.org/trunk@33813
git-svn-id: http://core.svn.wordpress.org/trunk@33781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-30 04:47:22 +00:00
Scott Taylor
848c40c6a7
Add some theme mod unit tests.
...
Props MikeHansenMe.
See #28637 .
Built from https://develop.svn.wordpress.org/trunk@33812
git-svn-id: http://core.svn.wordpress.org/trunk@33780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-30 03:43:22 +00:00
Scott Taylor
107a7104bd
Fix the doc block syntax for the 'wp_get_current_commenter'
filter.
...
Props dimadin.
Fixes #33304 .
Built from https://develop.svn.wordpress.org/trunk@33811
git-svn-id: http://core.svn.wordpress.org/trunk@33779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-30 03:21:20 +00:00
Scott Taylor
db11b48627
Favor using the consistent and agnostic string 'Attach' over 'Attach to a post' in the media list table.
...
Props pavelevap.
Fixes #33515 .
Built from https://develop.svn.wordpress.org/trunk@33810
git-svn-id: http://core.svn.wordpress.org/trunk@33778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-30 03:10:21 +00:00
Scott Taylor
d5f666013f
Fix copy pasta in wp_cache_decr()
doc block.
...
Props danielbachhuber.
Fixes #33548 .
Built from https://develop.svn.wordpress.org/trunk@33809
git-svn-id: http://core.svn.wordpress.org/trunk@33777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-30 03:04:21 +00:00
Scott Taylor
32110c7f77
Switching themes: if the new theme doesn't have nav_menu_locations
defined, but the old theme does, copy the old theme's nav_menu_locations
into the new theme's theme mods.
...
cc melchoyce
Fixes #18588 .
Built from https://develop.svn.wordpress.org/trunk@33808
git-svn-id: http://core.svn.wordpress.org/trunk@33776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-30 03:01:21 +00:00
Scott Taylor
0d3f30ba61
Improve the reliability of the crop returned by image_get_intermediate_size()
.
...
Add a bunch of unit tests to `tests/image/intermediate_size.php`.
Props joemcgill, ericlewis, kitchin, SergeyBiryukov, chipbennett.
Fixes #17626 .
Built from https://develop.svn.wordpress.org/trunk@33807
git-svn-id: http://core.svn.wordpress.org/trunk@33775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-30 02:41:21 +00:00
Scott Taylor
e49980bdc1
get_comment_count()
currently increments awaiting_moderation
when comments are in the trash. This occurs because case 0:
will match any value passed to switch
that is a string that isn't specified in the list of cases. This is terrifying.
...
* Cases for `0` and `1` should be `'1'` and `'0'`
* Add unit tests for `get_comment_count()`. Currently, there are none.
See #33414 .
Built from https://develop.svn.wordpress.org/trunk@33806
git-svn-id: http://core.svn.wordpress.org/trunk@33774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-30 02:19:21 +00:00
Boone Gorges
a0e00c0d24
Pass taxonomy name to filters in get_adjacent_post()
.
...
Props sboisvert.
Fixes #33568 .
Built from https://develop.svn.wordpress.org/trunk@33805
git-svn-id: http://core.svn.wordpress.org/trunk@33773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-29 19:59:21 +00:00
Boone Gorges
7f5a8e6680
In wp_list_categories()
, 'current_category' should accept an array of values.
...
This allows the 'current-cat' or 'current-cat-parent' classes to be applied
to more than one item in the list.
Props vilkatis.
Fixes #33565 .
Built from https://develop.svn.wordpress.org/trunk@33804
git-svn-id: http://core.svn.wordpress.org/trunk@33772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-29 19:46:23 +00:00
Boone Gorges
f1d6acac56
Simplify the weeks-per-year calculation WP_Date_Query::validate_date_values()
.
...
Props luciole135.
Fixes #30845 .
Built from https://develop.svn.wordpress.org/trunk@33803
git-svn-id: http://core.svn.wordpress.org/trunk@33771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-29 01:47:21 +00:00
Sergey Biryukov
50d4d4a956
Make a period translatable.
...
props mako09.
fixes #33594 .
Built from https://develop.svn.wordpress.org/trunk@33802
git-svn-id: http://core.svn.wordpress.org/trunk@33770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-29 01:40:21 +00:00
John Blackbourn
6ee45a9606
Bring network admin user searching to parity with single site user searching by wrapping search terms in asterisks. This means that searches don't require an exact match and therefore significantly reduces friction when searching for users on the network admin screens.
...
Fixes #32913
Built from https://develop.svn.wordpress.org/trunk@33801
git-svn-id: http://core.svn.wordpress.org/trunk@33769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-29 00:19:24 +00:00
Sergey Biryukov
0764191402
Twenty Fifteen: Correct license information in readme.txt
.
...
props Otto42.
see #33590 , #31814 .
Built from https://develop.svn.wordpress.org/trunk@33800
git-svn-id: http://core.svn.wordpress.org/trunk@33768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 16:55:00 +00:00
Sergey Biryukov
a17a93dfc9
Twenty Fourteen: Correct license information in readme.txt
.
...
props Otto42.
see #33590 , #31814 .
Built from https://develop.svn.wordpress.org/trunk@33799
git-svn-id: http://core.svn.wordpress.org/trunk@33767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 16:54:41 +00:00
Sergey Biryukov
a842133f97
Twenty Thirteen: Correct license information in readme.txt
.
...
props Otto42.
see #33590 , #31814 .
Built from https://develop.svn.wordpress.org/trunk@33798
git-svn-id: http://core.svn.wordpress.org/trunk@33766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 16:54:20 +00:00
Sergey Biryukov
5035f85bb4
Twenty Twelve: Correct license information in readme.txt
.
...
props Otto42.
see #33590 , #31814 .
Built from https://develop.svn.wordpress.org/trunk@33797
git-svn-id: http://core.svn.wordpress.org/trunk@33765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 16:53:02 +00:00
Sergey Biryukov
0a40e3a1eb
Twenty Eleven: Correct license information in readme.txt
.
...
props Otto42.
see #33590 , #31814 .
Built from https://develop.svn.wordpress.org/trunk@33796
git-svn-id: http://core.svn.wordpress.org/trunk@33764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 16:52:41 +00:00
Sergey Biryukov
5373802ffa
Twenty Ten: Correct license information in readme.txt
.
...
props Otto42.
see #33590 , #31814 .
Built from https://develop.svn.wordpress.org/trunk@33795
git-svn-id: http://core.svn.wordpress.org/trunk@33763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 16:52:21 +00:00
Drew Jaynes
6a839cf091
Docs: Add a changelog entry to the set_site_transient_$transient
hook doc for the $transient
parameter, added in [33738].
...
Fixes #28402 .
Built from https://develop.svn.wordpress.org/trunk@33794
git-svn-id: http://core.svn.wordpress.org/trunk@33762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 15:41:21 +00:00
Drew Jaynes
0c2d49b844
Docs: Add a changelog entry to the pre_set_site_transient_$transient
hook doc for the $transient
parameter, added in [33738].
...
See #28402 .
Built from https://develop.svn.wordpress.org/trunk@33793
git-svn-id: http://core.svn.wordpress.org/trunk@33761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 15:40:21 +00:00
Drew Jaynes
45c5fe16c2
Docs: Add a changelog entry to the site_transient_$transient
hook doc for the $transient
parameter, added in [33738].
...
See #28402 .
Built from https://develop.svn.wordpress.org/trunk@33792
git-svn-id: http://core.svn.wordpress.org/trunk@33760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 15:39:21 +00:00
Drew Jaynes
5e8df999b8
Docs: Add a changelog entry to the pre_site_transient_$transient
hook doc for the $transient
parameter, added in [33738].
...
See #28402 .
Built from https://develop.svn.wordpress.org/trunk@33791
git-svn-id: http://core.svn.wordpress.org/trunk@33759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 15:37:21 +00:00
Drew Jaynes
2f926931a0
Docs: Add a changelog entry to the pre_update_site_option_$option
hook doc for the $option
parameter, added in [33738].
...
See #28402 .
Built from https://develop.svn.wordpress.org/trunk@33790
git-svn-id: http://core.svn.wordpress.org/trunk@33758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 15:36:21 +00:00
Drew Jaynes
9342ae98e9
Docs: Add a changelog entry to the pre_delete_site_option_$option
hook doc for the $option
parameter, added in [33738].
...
See #28402 .
Built from https://develop.svn.wordpress.org/trunk@33789
git-svn-id: http://core.svn.wordpress.org/trunk@33757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 15:35:21 +00:00
Drew Jaynes
f62b7a70ba
Docs: Add a changelog entry to the pre_add_site_option_$option
hook doc for the $option
parameter, added in [33738].
...
See #28402 .
Built from https://develop.svn.wordpress.org/trunk@33788
git-svn-id: http://core.svn.wordpress.org/trunk@33756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 15:34:21 +00:00
Drew Jaynes
5d1a7579b2
Docs: Add a changelog entry to the site_option_$option
hook doc for the $option
parameter, added in [33738].
...
See #28402 .
Built from https://develop.svn.wordpress.org/trunk@33787
git-svn-id: http://core.svn.wordpress.org/trunk@33755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 15:32:21 +00:00
Drew Jaynes
6ec59018cf
Docs: Add a changelog entry to the default_site_option_$option
hook doc for the $option
parameter, added in [33738].
...
See #28402 .
Built from https://develop.svn.wordpress.org/trunk@33786
git-svn-id: http://core.svn.wordpress.org/trunk@33754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 15:31:21 +00:00
Drew Jaynes
111559495f
Docs: Add a changelog entry to the pre_site_option_$option
hook doc for the $option
parameter, added in [33738].
...
See #28402 .
Built from https://develop.svn.wordpress.org/trunk@33785
git-svn-id: http://core.svn.wordpress.org/trunk@33753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 15:30:20 +00:00
Drew Jaynes
94775c9391
Docs: Add a changelog entry to the pre_set_transient_$transient
hook doc for the $transient
parameter, added in [33738].
...
See #28402 .
Built from https://develop.svn.wordpress.org/trunk@33784
git-svn-id: http://core.svn.wordpress.org/trunk@33752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 15:29:21 +00:00
Drew Jaynes
df9aa619d7
Docs: Add a changelog entry to the transient_$transient
hook doc for the $transient
parameter, introduced in [33738].
...
See #28402 .
Built from https://develop.svn.wordpress.org/trunk@33783
git-svn-id: http://core.svn.wordpress.org/trunk@33751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 15:27:20 +00:00
Drew Jaynes
d850f67df6
Docs: Add a changelog entry to the pre_transient_$transient
hook doc for the $transient
parameter, introduced in [33738].
...
See #28402 .
Built from https://develop.svn.wordpress.org/trunk@33782
git-svn-id: http://core.svn.wordpress.org/trunk@33750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 15:25:21 +00:00
Drew Jaynes
7cec289b60
Docs: Add a changelog entry to the update_option_{$option}
hook doc for the $option
parameter, introduced in [33738].
...
See #28402 .
Built from https://develop.svn.wordpress.org/trunk@33781
git-svn-id: http://core.svn.wordpress.org/trunk@33749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 15:24:21 +00:00
Drew Jaynes
96cd3a4a3c
Docs: Add a changelog entry to the pre_update_option_$option
hook doc for the $option
parameter, added in [33738].
...
See #28402 .
Built from https://develop.svn.wordpress.org/trunk@33780
git-svn-id: http://core.svn.wordpress.org/trunk@33748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 15:22:20 +00:00
Drew Jaynes
e33d5c45bc
Docs: Add a changelog entry to the option_$option
hook doc for the $option
parameter, added in [33738].
...
See #28402 .
Built from https://develop.svn.wordpress.org/trunk@33779
git-svn-id: http://core.svn.wordpress.org/trunk@33747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 15:20:20 +00:00