Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-15 23:25:50 +01:00
Code Issues Projects Releases Wiki Activity
36,737 Commits 50 Branches 748 Tags 792 MiB
d829ec4cf2
Commit Graph

36737 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Drew Jaynes
d829ec4cf2 Docs: Provide best practice guidance for achieving parity between $menu_slug values supplied when adding menu and submenu pages, and later trying to compare those initial values against sanitized screen IDs derived from $menu_slug. 
At the heart of the matter, the `$menu_slug` parameter in `add_menu_page()` and `add_submenu_page()` is not sanitized with `sanitize_key()`. When the screen object is later built for the admin page, the screen ID is derived from that `$menu_slug` value, though passed through `sanitize_key()`, which can produce unexpected results in comparison check.

Changing the sanitization code to provide actual parity is out of the question at this juncture, so updating the docs to describe how to avoid this edge case is the next best option.

Props GregRoss.
Fixes #35305.

Built from https://develop.svn.wordpress.org/trunk@40967


git-svn-id: http://core.svn.wordpress.org/trunk@40817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-30 04:18:43 +00:00
Drew Jaynes
af5b2ca7f5 Docs: Add more useful summaries to the DocBlocks for boolean $is_* properties in WP_Query. 
Props megane9988 for the initial patch.
Fixes #34726.

Built from https://develop.svn.wordpress.org/trunk@40966


git-svn-id: http://core.svn.wordpress.org/trunk@40816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-30 03:44:46 +00:00
Sergey Biryukov
641a4b643f Cron API: Introduce wp_unschedule_hook() to clear all events attached to a hook. 
This complements `wp_clear_scheduled_hook()`, which only clears events attached with specific arguments.

Props arena, mordauk, jrf.
Fixes #18997.
Built from https://develop.svn.wordpress.org/trunk@40965


git-svn-id: http://core.svn.wordpress.org/trunk@40815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-30 00:22:44 +00:00
Drew Jaynes
1fb8cbe8de Docs: Don't reference non-existent hooks inline in the DocBlock descriptions for the following template functions: 
* `get_index_template()`
* `get_404_template()`
* `get_author_template()`
* `get_category_template()`
* `get_tag_template()`
* `get_taxonomy_template()`
* `get_date_template()`
* `get_home_template()`
* `get_front_page_template()`
* `get_page_template()`
* `get_search_template()`
* `get_single_template()`
* `get_embed_template()`
* `get_singular_template()`
* `get_attachment_template()`

As mentioned when these dynamic hook references were originally fixed in [33274], we can't link to non-existent hooks inline because the Code Reference auto-linker won't pick up on the dynamic-ness of the hook, it'll just try to link to a hook reference that doesn't exist. In these cases, we need to be generic and provide context for the value of `$type`.

See [38418] for where the original fix was reversed. See this changeset for reversing the reversal.

Props donutz, milana_cap.

Fixes #41198.

Built from https://develop.svn.wordpress.org/trunk@40964


git-svn-id: http://core.svn.wordpress.org/trunk@40814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-29 16:05:41 +00:00
Drew Jaynes
8ccc74c054 Docs: Don't reference non-existent hooks inline in the DocBlock description for get_archive_template(). 
Also removes extra curly braces from the dynamic hook references added in [40962] to aid future re-parsing.

See #41198.

Built from https://develop.svn.wordpress.org/trunk@40963


git-svn-id: http://core.svn.wordpress.org/trunk@40813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-29 15:47:40 +00:00
Drew Jaynes
1e32ebe87d Docs: Don't reference non-existent hooks inline in the DocBlock description for get_post_type_archive_template(). 
Props milana_cap.
See #41198.

Built from https://develop.svn.wordpress.org/trunk@40962


git-svn-id: http://core.svn.wordpress.org/trunk@40812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-29 15:39:40 +00:00
James Nylen
8f6088ba6e REST API: Add a filter to allow modifying the response *after* embedded data is added. 
Fixes #38964.

Built from https://develop.svn.wordpress.org/trunk@40961


git-svn-id: http://core.svn.wordpress.org/trunk@40811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-29 13:17:43 +00:00
Sergey Biryukov
165807d39f Administration: In WP_List_Table::comments_bubble(), replace the mdash with its HTML entity for consistency with the similar code in other list tables. 
Props afercia.
See #40659, #32152.
Built from https://develop.svn.wordpress.org/trunk@40960


git-svn-id: http://core.svn.wordpress.org/trunk@40810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-29 00:04:43 +00:00
Sergey Biryukov
11bae4ded3 Docs: Add a @global entry for $post variable in wp_post_preview_js(). 
Props avinapatel.
Fixes #41194.
Built from https://develop.svn.wordpress.org/trunk@40959


git-svn-id: http://core.svn.wordpress.org/trunk@40809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-28 12:55:43 +00:00
Sergey Biryukov
c6289b7440 Docs: Add missing backtick character in export_wp() DocBlock. 
Props pbiron.
Fixes #41178.
Built from https://develop.svn.wordpress.org/trunk@40958


git-svn-id: http://core.svn.wordpress.org/trunk@40808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-27 00:58:41 +00:00
Sergey Biryukov
01a6f4d38e Administration: In taxonomy list tables, display a dash instead of a blank space and add "No description" as a screen reader text when the term description is blank. 
Props pratikgandhi, yahil.
Fixes #40659.
Built from https://develop.svn.wordpress.org/trunk@40957


git-svn-id: http://core.svn.wordpress.org/trunk@40807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-27 00:34:41 +00:00
Sergey Biryukov
25e94961b4 Administration: In user list tables, display a dash instead of a blank space and add "Unknown" as a screen reader text when the user's first name and last name are blank. 
Props Girishpanchal, yahil.
Fixes #40628.
Built from https://develop.svn.wordpress.org/trunk@40956


git-svn-id: http://core.svn.wordpress.org/trunk@40806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-27 00:27:39 +00:00
Sergey Biryukov
d08982bdbc Docs: Remove inaccurate parts of get_header, get_footer, and get_sidebar hooks documentation. 
These sentences suggested that the hooks allow a specific template file to be used in place of the default file, which is not the case.

Props desrosj.
Fixes #40892.
Built from https://develop.svn.wordpress.org/trunk@40955


git-svn-id: http://core.svn.wordpress.org/trunk@40805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-26 20:56:42 +00:00
Sergey Biryukov
62947553c5 Login and Registration: Prevent the enable_login_autofocus filter DocBlock from spilling into JS code. 
Props chris@vendiadvertising.com.
Fixes #41176.
Built from https://develop.svn.wordpress.org/trunk@40954


git-svn-id: http://core.svn.wordpress.org/trunk@40804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-26 20:37:42 +00:00
Felix Arntz
5650910c50 Multisite: Remove full stops from radio and checkbox labels in the Network Settings screen. 
This change brings consistency with the regular site administration panel settings pages: Radio and checkbox labels do not use full stops there, so those in the network administration panel should not either.

Props Ankit K Gupta.
Fixes #39319.

Built from https://develop.svn.wordpress.org/trunk@40953


git-svn-id: http://core.svn.wordpress.org/trunk@40803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-26 19:20:40 +00:00
Drew Jaynes
78dba2fefd Docs: List out accepted values for the $field parameter in get_the_author_meta(). 
Props choongsavvii.
Fixes #38258.

Built from https://develop.svn.wordpress.org/trunk@40952


git-svn-id: http://core.svn.wordpress.org/trunk@40802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-26 18:24:40 +00:00
Drew Jaynes
faab7f4533 Docs: Improve and clarify the DocBlock summary for wpmu_log_new_registrations(). 
Props daymobrew.
Fixes #39922.

Built from https://develop.svn.wordpress.org/trunk@40951


git-svn-id: http://core.svn.wordpress.org/trunk@40801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-26 18:05:41 +00:00
Drew Jaynes
474711aac1 Docs: Adjust notation for the $context parameter in the DocBlocks for the wp_kses_allowed_html() function and its associated wp_kses_allowed_html filter. 
`$context|$allowedtags` can be either a string or array.

Props bor0.
Fixes #40575.

Built from https://develop.svn.wordpress.org/trunk@40950


git-svn-id: http://core.svn.wordpress.org/trunk@40800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-25 22:16:40 +00:00
Drew Jaynes
75acd01f98 Docs: Notate format_for_editor() as the replacement function in the DocBlock for the deprecated wp_richedit_pre(). 
Props rabmalin.
See #41121. Fixes #40709.

Built from https://develop.svn.wordpress.org/trunk@40949


git-svn-id: http://core.svn.wordpress.org/trunk@40799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-25 22:10:41 +00:00
Drew Jaynes
07f01a2e10 Docs: Replace a variety of http links referenced in inline docs with their https counterparts (where possible). 
Props johnpgreen.
Fixes #40732.

Built from https://develop.svn.wordpress.org/trunk@40948


git-svn-id: http://core.svn.wordpress.org/trunk@40798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-25 22:06:41 +00:00
Drew Jaynes
97ef1ca74b Docs: Add missing deprecation, introduction, and summary information to the DocBlock for WP_Admin_Bar::recursive_render(). 
Props coffee2code.
Fixes #40840.

Built from https://develop.svn.wordpress.org/trunk@40947


git-svn-id: http://core.svn.wordpress.org/trunk@40797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-25 21:58:41 +00:00
Drew Jaynes
3a3e133aaf Docs: Clarify that the $post parameters for the get_the_modified_date and get_the_modified_time filters can also be of type null. 
Props dlh.
Fixes #40845.

Built from https://develop.svn.wordpress.org/trunk@40946


git-svn-id: http://core.svn.wordpress.org/trunk@40796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-25 21:50:40 +00:00
Drew Jaynes
30719312fb Docs: Add a clarification to the description about what the $output parameter in the embed_html filter doc represents. 
Props musus.
Fixes #37752.

Built from https://develop.svn.wordpress.org/trunk@40945


git-svn-id: http://core.svn.wordpress.org/trunk@40795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-25 21:46:39 +00:00
Drew Jaynes
22f76adc8c Docs: Add full documentation for members in the labels object returned by get_taxonomy_labels(). 
Props truongwp.
Fixes #41108.

Built from https://develop.svn.wordpress.org/trunk@40944


git-svn-id: http://core.svn.wordpress.org/trunk@40794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-25 21:42:43 +00:00
Drew Jaynes
f6bf00d378 Docs: Add a note to the DocBlock for wp_signon() mentioning that it doesn't handle setting the current user. 
Also outlines the conditions that must be met for is_user_logged_in() to work with it.

Part props SergeyBiryukov.
Fixes #28116.

Built from https://develop.svn.wordpress.org/trunk@40943


git-svn-id: http://core.svn.wordpress.org/trunk@40793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-25 20:08:40 +00:00
Drew Jaynes
de7499f88f Docs: Add full documentation for arguments accepted by wp_get_nav_menu_items(). 
Also provide differentiation between arguments as passed to `get_posts()` vs used for ordering outputted menu items.

By and large, arguments in the `$args` array are intended to directly affect how nav_menu_item posts are retrieved. When the default ARRAY_A is used for 'output', the 'order' and 'orderby' arguments are essentially ignored, instead giving preference to a hard-coded order of 'ASC' and an orderby value derived from the non-get_posts() argument 'output_key'.

Fixes #15533.

Built from https://develop.svn.wordpress.org/trunk@40942


git-svn-id: http://core.svn.wordpress.org/trunk@40792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-25 19:37:39 +00:00
Weston Ruter
b7ca48fff0 Widgets: Add accessibility mode support for TinyMCE-enhanced Text and Media widgets (Video, Audio, Images). 
Amends [40640], [40631].
Props westonruter, afercia.
See #35243, #32417.
Fixes #40986.

Built from https://develop.svn.wordpress.org/trunk@40941


git-svn-id: http://core.svn.wordpress.org/trunk@40791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-25 18:48:41 +00:00
John Blackbourn
a507248146 Users: Use more appropriate HTTP status codes for errors relating to user management. 
Also re-uses one error message string.

Props tuanmh

Fixes #40230

Built from https://develop.svn.wordpress.org/trunk@40940


git-svn-id: http://core.svn.wordpress.org/trunk@40790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-25 18:46:44 +00:00
Weston Ruter
46551a898a Widgets: Forcibly limit Video widget to only accept oEmbed URLs from YouTube and Vimeo (for now). 
Amends [40640].
Props timmydcrawford.
See #34115, #39994.
Fixes #40935.

Built from https://develop.svn.wordpress.org/trunk@40939


git-svn-id: http://core.svn.wordpress.org/trunk@40789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-25 07:24:41 +00:00
Drew Jaynes
ae690a3fdf Scripts: Correctly reference WP_Scripts::print_extra_script() as the replacement for the deprecated WP_Scripts::print_scripts_l10n() method, rather than a nonexistent global print_extra_script() function. 
Props fergbrain.
See #41121.

Built from https://develop.svn.wordpress.org/trunk@40938


git-svn-id: http://core.svn.wordpress.org/trunk@40788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-25 07:20:41 +00:00
Drew Jaynes
4c60260c29 Docs: Fix alignment of the $output parameter in the hook doc for the do_shortcode_tag filter. 
See #41017.

Built from https://develop.svn.wordpress.org/trunk@40937


git-svn-id: http://core.svn.wordpress.org/trunk@40787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-25 07:06:22 +00:00
Peter Wilson
cc82d38f47 Emoji: Fix typo in browserSupportsEmoji() comment. 
Fairies not Faries, introduced in [40850].

Fixes #41157.


Built from https://develop.svn.wordpress.org/trunk@40936


git-svn-id: http://core.svn.wordpress.org/trunk@40786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-25 07:05:42 +00:00
Weston Ruter
980f342ad6 Customize: Ensure header_image_data setting exists before attempting to use it. 
Amends [27497].
Props Collizo4sky.
Fixes #41007.

Built from https://develop.svn.wordpress.org/trunk@40935


git-svn-id: http://core.svn.wordpress.org/trunk@40785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-25 07:04:42 +00:00
Sergey Biryukov
332884f8dc Docs: Add a missing quote in user-agent argument description in WP_Http::request(). 
Props ixkaito.
Fixes #41154.
Built from https://develop.svn.wordpress.org/trunk@40934


git-svn-id: http://core.svn.wordpress.org/trunk@40784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-25 07:00:42 +00:00
Drew Jaynes
82ed0bdd11 Docs: Improve description wording for get_template_part() in regard to overloading by child themes. 
Also, update the summary to use a third-person singular verb.

Props ixmati.
See #41017.

Built from https://develop.svn.wordpress.org/trunk@40933


git-svn-id: http://core.svn.wordpress.org/trunk@40783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-25 06:56:40 +00:00
Drew Jaynes
6146ba0b33 Docs: Clarify the description for esc_html__() to note that the original text will be escaped on return if there is no translation, or the text domain isn't loaded. 
Props brianlayman.
See #41017.

Built from https://develop.svn.wordpress.org/trunk@40932


git-svn-id: http://core.svn.wordpress.org/trunk@40782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-25 06:41:41 +00:00
Drew Jaynes
c5da335097 Docs: Fix a typo in the description for the get_previous_post_link() $link parameter. The default value is '%title', not '%title%'. 
Props kmgalanakis.
See #41017.

Built from https://develop.svn.wordpress.org/trunk@40931


git-svn-id: http://core.svn.wordpress.org/trunk@40781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-25 06:20:43 +00:00
Drew Jaynes
fafa1dfa07 Docs: Add more complete documentation about expected values in the $meta parameter for wpmu_create_blog(). 
See #41017.

Built from https://develop.svn.wordpress.org/trunk@40930


git-svn-id: http://core.svn.wordpress.org/trunk@40780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-25 05:48:45 +00:00
Drew Jaynes
acea6cbad8 Improve the usefulness of several _deprecated_function() calls by passing known replacement functions, methods, or hooks. 
Props jrf.
See #41121.

Built from https://develop.svn.wordpress.org/trunk@40929


git-svn-id: http://core.svn.wordpress.org/trunk@40779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-25 00:05:44 +00:00
Sergey Biryukov
c0cf33b8f5 Import: Increase color contrast for "This importer is not installed" message on Multisite. 
Remove `.not-installed-main-site` class introduced in [38075], but never used.

Props nishitlangaliya, mbootsman.
Fixes #41117.
Built from https://develop.svn.wordpress.org/trunk@40928


git-svn-id: http://core.svn.wordpress.org/trunk@40778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-24 18:07:43 +00:00
Andrew Ozz
7f6ae69843 TinyMCE: fix directionality settings for RTL languages. 
Props westonruter, sa3idho.
Fixes #40972 for trunk.
Built from https://develop.svn.wordpress.org/trunk@40927


git-svn-id: http://core.svn.wordpress.org/trunk@40777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-24 09:19:43 +00:00
Weston Ruter
a46d94efeb Widgets: Rename "HTML Code" widget to "Custom HTML" widget. 
Correspondingly renames files, ID base from `html_code` to `custom_html`, and the filter from `widget_html_code_content` to `widget_custom_html_content`.

See #40907.

Built from https://develop.svn.wordpress.org/trunk@40926


git-svn-id: http://core.svn.wordpress.org/trunk@40776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-24 00:00:45 +00:00
Sergey Biryukov
cf458a871d Docs: Document tags_input parameter in wp_insert_post(). 
Props barryceelen.
Fixes #41137.
Built from https://develop.svn.wordpress.org/trunk@40925


git-svn-id: http://core.svn.wordpress.org/trunk@40775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-23 21:27:44 +00:00
Boone Gorges
779788d8d6 When querying for terms, do not assume that $taxonomies is a 0-indexed array. 
In [25108], the logic of term queries was modified to avoid assuming
that the `taxonomies` array was numerically indexed. See #23506. This
fix was inadvertantly reverted during the refactor in [25162].

Props david.binda.
Fixes #41113.
Built from https://develop.svn.wordpress.org/trunk@40924


git-svn-id: http://core.svn.wordpress.org/trunk@40774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-23 02:06:42 +00:00
Boone Gorges
8951af8ebb Introduce loop_no_results action. 
This action fires when a `WP_Query` query returns no results.

Props mgibbs189.
Props #40850.
Built from https://develop.svn.wordpress.org/trunk@40923


git-svn-id: http://core.svn.wordpress.org/trunk@40773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-23 01:55:44 +00:00
Drew Jaynes
3a6985de96 Docs: Standardize and add missing deprecation notations in DocBlocks for the following functions: 
* `post_form_autocomplete_off()`
* `_rotate_image_resource()`
* `_flip_image_resource()`
* `wp_get_sites()`
* `deactivate_sitewide_plugin()`

Props jrf.
See #41121.

Built from https://develop.svn.wordpress.org/trunk@40922


git-svn-id: http://core.svn.wordpress.org/trunk@40772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-22 17:48:45 +00:00
Boone Gorges
2ebc1fb143 Cache results in get_objects_in_term(). 
This helps to reduce database queries when generating nav menus.

Props spacedmonkey.
Fixes #37094.
Built from https://develop.svn.wordpress.org/trunk@40921


git-svn-id: http://core.svn.wordpress.org/trunk@40771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-22 03:19:44 +00:00
Boone Gorges
8ca91024e8 Improve cache invalidation when splitting shared terms. 
This changeset addresses two related issues:

* When splitting shared terms from hierarchical taxonomies, the process of regenerating the taxonomy hierarchy (`_get_taxonomy_hierarchy()`) requires recursive calls to `get_terms()` in order to descend the tree. By waiting until all shared terms in a term group have been invalidated before regenerating their taxonomy hierarchies, we avoid certain race conditions.
* Previously, a coding error prevented single-term caches from being invalidated for children of split terms. This error dates from [31418].

See #37189.
Built from https://develop.svn.wordpress.org/trunk@40920


git-svn-id: http://core.svn.wordpress.org/trunk@40770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-21 04:12:44 +00:00
Boone Gorges
989427d598 Introduce clean_taxonomy_cache() function. 
Previously, taxonomy-wide caches were cleaned only inside of
`clean_term_cache()`. This made it hard to clean taxonmy caches
in isolation from specific taxonomy terms.

Props spacedmonkey.
See #37189.
Built from https://develop.svn.wordpress.org/trunk@40919


git-svn-id: http://core.svn.wordpress.org/trunk@40769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-21 04:04:41 +00:00
Boone Gorges
f730861b90 Use WP_Term_Query when transforming tax queries. 
This change allows tax query transformations to be cached.

Props spacedmonkey.
Fixes #37038.
Built from https://develop.svn.wordpress.org/trunk@40918


git-svn-id: http://core.svn.wordpress.org/trunk@40768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-21 03:57:42 +00:00