Scott Taylor
db32f96d8a
Make 'Docs Committer' translatable.
...
Props dimadin.
Fixes #33424 .
Built from https://develop.svn.wordpress.org/trunk@33695
git-svn-id: http://core.svn.wordpress.org/trunk@33662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 17:47:25 +00:00
Scott Taylor
e9305edbce
When createing "Sample Page" on install, comments should be closed
.
...
Props macmanx.
Fixes #33490 .
Built from https://develop.svn.wordpress.org/trunk@33693
git-svn-id: http://core.svn.wordpress.org/trunk@33660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 17:42:25 +00:00
Scott Taylor
fa2d0a2d55
Comment List Tables:
...
* Toggle visibility of pending bubble when a comment is dynamically moderated
* Add a CSS class to the pending bubble to hide it / remove to show it
See #11200 .
Built from https://develop.svn.wordpress.org/trunk@33692
git-svn-id: http://core.svn.wordpress.org/trunk@33659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 17:26:26 +00:00
Drew Jaynes
54b2e39fdd
Docs: Add a changelog entry for the $post_type
parameter added to the restrict_manage_posts
hook in [33644].
...
Props pavelevap
Fixes #17891 .
Built from https://develop.svn.wordpress.org/trunk@33691
git-svn-id: http://core.svn.wordpress.org/trunk@33658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 16:12:25 +00:00
Helen Hou-Sandí
514caf0120
List tables: Allow filtering of hidden and default hidden columns.
...
Similar to `get_hidden_meta_boxes()`, there are now filters named `default_hidden_columns` and `hidden_columns`.
props Compute, MikeHansenMe, chriscct7.
fixes #32499 .
Built from https://develop.svn.wordpress.org/trunk@33689
git-svn-id: http://core.svn.wordpress.org/trunk@33656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 15:32:29 +00:00
Dion Hulse
09da29102b
WP_Filesystem: SSH2 handler: Remove support for is_writable() via SSH, it turns out PHP doesn't verify the writability via SFTP and instead uses a comparison based on the current php system process user instead of the ssh user.
...
This fixes the 'The update cannot be installed because we will be unable to copy some files.' error encountered during updates by skipping the write test completely.
Props jobst.
Fixes #33480 for trunk
Built from https://develop.svn.wordpress.org/trunk@33688
git-svn-id: http://core.svn.wordpress.org/trunk@33655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 11:43:25 +00:00
Drew Jaynes
93009543bc
Docs: Fix some minor inline documentation syntax issues in the hook docs for the post_edit_category_parent_dropdown_args
filter, introduced in [33682].
...
See #32246 . See #33026 .
Built from https://develop.svn.wordpress.org/trunk@33686
git-svn-id: http://core.svn.wordpress.org/trunk@33653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 04:54:26 +00:00
Drew Jaynes
416df545ba
Docs: Fix a variety of inline documentation syntax issues and add some strategic spacing.
...
Fixes #29086 .
Built from https://develop.svn.wordpress.org/trunk@33685
git-svn-id: http://core.svn.wordpress.org/trunk@33652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 04:13:24 +00:00
Drew Jaynes
3bb87e08e4
Docs: Add missing @access
tags to properties and methods in wp-admin/includes/class-wp-upgrader.
...
See #29086 .
Built from https://develop.svn.wordpress.org/trunk@33684
git-svn-id: http://core.svn.wordpress.org/trunk@33651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 04:05:25 +00:00
Drew Jaynes
73d6dec8eb
Docs: Correct a typo in the summary for the Theme_Upgrader->bulk
property.
...
Also adds a couple of missing `@access` tags.
Props kraftbj
See #29086 .
Built from https://develop.svn.wordpress.org/trunk@33683
git-svn-id: http://core.svn.wordpress.org/trunk@33650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 03:15:25 +00:00
Boone Gorges
52614b491a
Filter the arguments passed to wp_dropdown_categories()
in the Categories post edit metabox.
...
The new 'post_edit_category_parent_dropdown_args' provides parity with other
places in wp-admin where `wp_dropdown_categories()` args are filtered, such as
'taxonomy_parent_dropdown_args'.
Props theMikeD.
Fixes #33026 .
Built from https://develop.svn.wordpress.org/trunk@33682
git-svn-id: http://core.svn.wordpress.org/trunk@33649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 01:28:25 +00:00
Drew Jaynes
c8638a285a
Docs: Standardize @deprecated
tag formatting for deprecated functions in wp-admin/includes/ms-deprecated.php.
...
Props Alphawolf for the initial patch
Props DrewAPicture
See #28806 .
Built from https://develop.svn.wordpress.org/trunk@33675
git-svn-id: http://core.svn.wordpress.org/trunk@33642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 22:26:24 +00:00
Scott Taylor
6f9aa6df03
After [33666], fix broken sprintf
cruff.
...
See #17609 .
Built from https://develop.svn.wordpress.org/trunk@33672
git-svn-id: http://core.svn.wordpress.org/trunk@33639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 21:37:24 +00:00
Drew Jaynes
bac6e69b3c
Docs: Standardize @deprecated
tag formatting and add missing DocBlocks to deprecated functions in wp-admin/includes/deprecated.php.
...
Opted not to use the multi-function DocBlock syntax in the name of not taking shortcuts in documentation for the sake of brevity.
Props Alphawolf for the initial patch.
See #28806
Built from https://develop.svn.wordpress.org/trunk@33671
git-svn-id: http://core.svn.wordpress.org/trunk@33638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 21:23:25 +00:00
Drew Jaynes
c36c4efea6
Docs: Add a missing summary to the DocBlock for wp_media_upload_handler()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@33670
git-svn-id: http://core.svn.wordpress.org/trunk@33637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 21:01:25 +00:00
Drew Jaynes
89c39e7eab
Docs: Clarify the different return conditions in the DocBlock for WP_List_Table->handle_row_actions()
.
...
This clarification follows the introduction of primary columns in 4.3. See #33313 .
Props morganestes.
Fixes #33436 .
Built from https://develop.svn.wordpress.org/trunk@33668
git-svn-id: http://core.svn.wordpress.org/trunk@33635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 20:22:25 +00:00
Scott Taylor
4254f22c2d
In WP_Posts_List_Table::inline_edit()
, check that $post_formats[0]
is an array before traversing.
...
Props DrewAPicture.
Fixes #33025 .
Built from https://develop.svn.wordpress.org/trunk@33667
git-svn-id: http://core.svn.wordpress.org/trunk@33634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 20:19:25 +00:00
Scott Taylor
4694c477d3
Custom Post Types:
...
* Introduce `is_post_type_viewable( $post_type_object )`
* Separate the HTML bits from the translatable bits in the `post` messages array in `edit-form-advanced.php`
* Don't show certain UI pieces when a post is not viewable on the front end
When a custom post type item is not viewable on the front end, we don't want to show links to View it (on the front end) all over the admin. We also want to hide the Preview link, et al. We also want our admin messages to not contain said links.
Custom post types with `public_queryable` set to `false` are not viewable on the front end.
`'page'` is viewable on the front end, but `'page'` is a `_builtin` type, and `public_queryable` is set to `false` when it is registered - see `WP::parse_request()` for when `public_queryable` gets used.
This is confusing, but also somewhat straightforward: to determine if a post type is viewable on the front end, we can check one way for `_builtin => true` and another way for `_builtin => false`:
`$post_type->publicly_queryable || ( $post_type->_builtin && $post_type->public )`
If a post type is `publicly_queryable`, it's viewable. If that value is `false`, it is viewable if it's a `_builtin` type that is also `public`.
I am in search of edge cases, so this shall land.
Props wonderboymusic, DrewAPicture.
See #17609 .
Built from https://develop.svn.wordpress.org/trunk@33666
git-svn-id: http://core.svn.wordpress.org/trunk@33633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 19:40:25 +00:00
Scott Taylor
d65112d382
After [33662], remove unused var.
...
See #11200 .
Built from https://develop.svn.wordpress.org/trunk@33663
git-svn-id: http://core.svn.wordpress.org/trunk@33630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 17:19:25 +00:00
Scott Taylor
20f6db2b18
Comment List Tables:
...
* Ensure that dynamic bubble counts are in sync by `comment_post_ID`
* Scope `:animated` to `#the-comment-list`
See #11200 .
Built from https://develop.svn.wordpress.org/trunk@33662
git-svn-id: http://core.svn.wordpress.org/trunk@33629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 16:36:25 +00:00
Scott Taylor
0e4606c13e
JSHint after [33655].
...
Built from https://develop.svn.wordpress.org/trunk@33660
git-svn-id: http://core.svn.wordpress.org/trunk@33627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 06:31:25 +00:00
Scott Taylor
2e2223ae74
Comments List Table:
...
* In a view that initially has comments, but they get removed due to user actions: show the `No Items` row instead of bombing out and showing nothing (which looks broken)
* To accomplish this, in `WP_Comments_List_Table::display()`: call `->display_rows_or_placeholder()` instead of `->display()`
* Listen for the end of row `.fadeOut()`s if necessary using jQuery Promises
Fixes #11200 .
Built from https://develop.svn.wordpress.org/trunk@33657
git-svn-id: http://core.svn.wordpress.org/trunk@33624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 05:54:25 +00:00
Scott Taylor
657d0f6918
Comments List Table:
...
* Properly increment/decrement approved/pending bubbles in `response` column
See #11200 .
Built from https://develop.svn.wordpress.org/trunk@33656
git-svn-id: http://core.svn.wordpress.org/trunk@33623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 04:02:24 +00:00
Scott Taylor
df618f3461
Comments List Table:
...
* Show count next to "Approved"
* Properly increment/decrement counts when row actions are clicked
* In `_wp_ajax_delete_comment_response()`, return the comment's `status` with the `supplemental` data
* Handle counts properly on each scenario of `undo`
See #11200 .
Built from https://develop.svn.wordpress.org/trunk@33655
git-svn-id: http://core.svn.wordpress.org/trunk@33622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 02:51:25 +00:00
Konstantin Obenland
f770303868
Themes: Prevent short descriptions from wrapping version info.
...
Props mehulkaklotar for initial patch.
Fixes #33248 .
Built from https://develop.svn.wordpress.org/trunk@33651
git-svn-id: http://core.svn.wordpress.org/trunk@33618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 19:10:24 +00:00
Konstantin Obenland
2849e2c5e9
Themes: Open preview when requesting a single theme in the installer.
...
Props kraftner, obenland.
Fixes #28735 .
Built from https://develop.svn.wordpress.org/trunk@33650
git-svn-id: http://core.svn.wordpress.org/trunk@33617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 18:54:27 +00:00
Dion Hulse
a32d83586e
Upgrades: When upgrading via FTP, use LIST -a
to detect if a file exists.
...
`LIST` & `NLST` by default on some servers require the `-a` flag to view hidden files (ie. `.maintenance`)
Although we could simply pass the `-a` flag to `NLST`, opting to use `LIST` which we use elsewhere should mean less chance of server incompatibilities.
Props jcroucher.
Fixes #28013 .
Built from https://develop.svn.wordpress.org/trunk@33648
git-svn-id: http://core.svn.wordpress.org/trunk@33615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 12:38:25 +00:00
Dion Hulse
25c5d372d3
Term Splitting: Fix a reversal of parameters to wp_schedule_single_event() introduced in [33621].
...
The existing invalid cron entries will not be purged automatically (as the 'timestamp' is never matched) so we do this ourselves.
Props mechter for noticing!
See #30261 .
Fixes #33423 for trunk.
Built from https://develop.svn.wordpress.org/trunk@33646
git-svn-id: http://core.svn.wordpress.org/trunk@33613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 11:31:26 +00:00
Dion Hulse
096b2f58fa
Fix PHP notice after [33492] when updating themes.
...
Props bobbingwide.
See #33208 .
Fixes #33427 .
Built from https://develop.svn.wordpress.org/trunk@33645
git-svn-id: http://core.svn.wordpress.org/trunk@33612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 10:35:25 +00:00
Scott Taylor
3923017f82
The 'restrict_manage_posts'
hook currently fires on the Post and Media list tables, but is passed zero arguments. Pass $post_type
.
...
Props sunnyratilal, scribu.
Fixes #17891 .
Built from https://develop.svn.wordpress.org/trunk@33644
git-svn-id: http://core.svn.wordpress.org/trunk@33611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 06:23:25 +00:00
Scott Taylor
c15a1c2bab
Replace some hyphens with —
s in admin help tabs.
...
Props pixolin.
Fixes #30605 .
Built from https://develop.svn.wordpress.org/trunk@33641
git-svn-id: http://core.svn.wordpress.org/trunk@33608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 04:53:25 +00:00
Scott Taylor
8af2dbc671
Correct punctuation/case for inline comment in async-upload.php
...
Props chriscct7.
Fixes #33408 .
Built from https://develop.svn.wordpress.org/trunk@33640
git-svn-id: http://core.svn.wordpress.org/trunk@33607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-18 23:35:25 +00:00
Scott Taylor
23f62a59da
Correct typo in doc block for WP_Filesystem_ftpsockets::rmdir
...
Props Toro_Unit.
Fixes #33255 .
Built from https://develop.svn.wordpress.org/trunk@33639
git-svn-id: http://core.svn.wordpress.org/trunk@33606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-18 23:33:24 +00:00
Scott Taylor
227d38c9cd
Correct typo in JSDoc for wp.updates.decrementCount
...
Props mt8.biz.
Fixes #33363 .
Built from https://develop.svn.wordpress.org/trunk@33638
git-svn-id: http://core.svn.wordpress.org/trunk@33605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-18 21:47:25 +00:00
Konstantin Obenland
e36a91efe4
About: Use actual locale and not subtitle debug cruft.
...
H/t dimadin.
See #32929 .
Built from https://develop.svn.wordpress.org/trunk@33632
git-svn-id: http://core.svn.wordpress.org/trunk@33599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-18 17:07:26 +00:00
Konstantin Obenland
d55738d327
About: Update release video to use the correct ID.
...
Also adjusts locale handling to work with Videopress' subtitle implementation.
Props siobhan, jacklenox, sararosso, hugobaeta, nickmomrik, rauchg.
See #32929 .
Built from https://develop.svn.wordpress.org/trunk@33631
git-svn-id: http://core.svn.wordpress.org/trunk@33598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-18 17:02:27 +00:00
Dominik Schilling
96a6f0ac1f
Pinking shears.
...
Built from https://develop.svn.wordpress.org/trunk@33627
git-svn-id: http://core.svn.wordpress.org/trunk@33594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-17 21:39:25 +00:00
Dominik Schilling
ce557062f4
Upgrade: Update $_old_files
for 4.3.
...
fixes #33394 .
Built from https://develop.svn.wordpress.org/trunk@33626
git-svn-id: http://core.svn.wordpress.org/trunk@33593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-17 20:24:26 +00:00
Konstantin Obenland
69146f6b10
Passwords: Use keyup
event to prevent IE8's misinterpretation of propertychange
.
...
Props adamsilverstein, peterwilsoncc.
Fixes #33385 .
Built from https://develop.svn.wordpress.org/trunk@33625
git-svn-id: http://core.svn.wordpress.org/trunk@33592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-17 18:46:25 +00:00
Andrew Ozz
2de7757124
Fix creating of extra <br />
tags in both PHP and JS variants of wpautop(). Add PHP tests to catch similar problems in the future.
...
Props valendesigns, azaozz. Fixes #33377 .
Built from https://develop.svn.wordpress.org/trunk@33624
git-svn-id: http://core.svn.wordpress.org/trunk@33591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-17 17:36:24 +00:00
Helen Hou-Sandí
50e42e8a07
List tables: Yet more primary column fallbacks.
...
Some custom list tables override enough methods for the column definition fallback to never kick in, so let's ensure that toggling columns only applies when a primary column is defined in some way. We also need to show a toggle button when we can when there are no row actions.
props Chouby, obenland, ocean90.
fixes #33313 .
Built from https://develop.svn.wordpress.org/trunk@33623
git-svn-id: http://core.svn.wordpress.org/trunk@33590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-17 15:38:25 +00:00
Boone Gorges
dba7c50d29
Don't run term-splitting routine on new installations.
...
Props pento.
Fixes #30261 .
Built from https://develop.svn.wordpress.org/trunk@33621
git-svn-id: http://core.svn.wordpress.org/trunk@33588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-17 14:29:25 +00:00
Konstantin Obenland
e6bc6242ad
Passwords: Restore second parameter for wp_new_user_notification()
.
...
After [33023] users would always be notified, this restores previous behavior.
Props markjaquith, ocean90.
Fixes #33358 .
Built from https://develop.svn.wordpress.org/trunk@33620
git-svn-id: http://core.svn.wordpress.org/trunk@33587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-17 14:25:27 +00:00
Helen Hou-Sandí
1880411a0b
Menu customizer: Ensure the search results section is full height.
...
fixes #33375 .
Built from https://develop.svn.wordpress.org/trunk@33618
git-svn-id: http://core.svn.wordpress.org/trunk@33585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-14 21:32:25 +00:00
Weston Ruter
9ee7f050e9
Customize: Fix keyboard accessibility for toggling screen options and contextual help.
...
Also fix layout of search results in mobile.
Props valendesigns, afercia, adamsilverstein.
Fixes #33184 .
Built from https://develop.svn.wordpress.org/trunk@33617
git-svn-id: http://core.svn.wordpress.org/trunk@33584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-14 21:23:27 +00:00
Boone Gorges
151d27369d
Term splitting routine should be run in a separate process, triggered via wp-cron.
...
[32814] introduced a routine to split shared terms, which was run during the
regular WP database upgrade. This turned out to be problematic because plugins
are not loaded during the db upgrade (due to `WP_INSTALLING`), with the result
that plugins were not able to hook into the 'split_shared_term' action during
the bulk split. We work around this limitation by moving the term splitting
routine to a separate process, triggered by a wp-cron hook.
Props boonebgorges, Chouby, peterwilsoncc, pento, dd32.
Fixes #30261 .
Built from https://develop.svn.wordpress.org/trunk@33615
git-svn-id: http://core.svn.wordpress.org/trunk@33582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-14 03:59:26 +00:00
Dominik Schilling
f74a907eac
Capabilities: Fall back to the edit_posts
capability for orphaned comments.
...
Also avoid PHP notices because of orphaned comments in the comments list table.
Includes unit test.
props pento, dd32.
fixes #33154 .
Built from https://develop.svn.wordpress.org/trunk@33614
git-svn-id: http://core.svn.wordpress.org/trunk@33581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-13 22:31:24 +00:00
Konstantin Obenland
35f8b77882
About: Third pass at 4.3 about page:
...
* Improves some of the feature descriptions.
* Uses .org CDN for images and feature video.
* Fixes an overzealous Jetpack style that adds unwanted padding.
* Uses more specific `WP_List_Table` header.
* Adds 4.3 tagline to freedoms and credit page.
* Adds infrastructure for 4.3 about video. Only the ID needs to be updated.
* Makes all strings translatable.
Props siobhan, adamsilverstein, melchoyce, ocean90, markjaquith, helen, obenland.
Fixes #32929 .
Built from https://develop.svn.wordpress.org/trunk@33613
git-svn-id: http://core.svn.wordpress.org/trunk@33580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-13 22:11:35 +00:00
Boone Gorges
2c9e81349c
When splitting a shared 'nav_menu' term, ensure that nav items and theme locations are retained.
...
Props boonebgorges, dd32.
Fixes #33187 .
Built from https://develop.svn.wordpress.org/trunk@33611
git-svn-id: http://core.svn.wordpress.org/trunk@33578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-12 14:07:26 +00:00
Weston Ruter
7fcc3e50e1
Customize: Fix layout issues in panels and sections when resizing and autofocusing.
...
Also reverts [33157] which is no longer needed.
Props valendesigns, mattwiebe, westonruter, ocean90.
Fixes #33220 .
Built from https://develop.svn.wordpress.org/trunk@33610
git-svn-id: http://core.svn.wordpress.org/trunk@33577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-11 23:56:25 +00:00