Scott Taylor
dd6fe1ba32
Network Setup: don't use <code>
in translation strings in wp-admin/network
files.
...
Props ramiy.
Fixes #31840 .
Built from https://develop.svn.wordpress.org/trunk@34292
git-svn-id: http://core.svn.wordpress.org/trunk@34256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:18:27 +00:00
Aaron Jorbin
10d03c1ab3
Remove support for my-hacks.php
...
For the last 10 years, my-hacks has been deprecated and has been throwing a deprecation notice. For the last six years, you haven't been able to enable my-hacks.php in the admin UI. That should be enough time to give developers notice. Plugins and themes seem like they might have staying power.
Fixes #33741
Props bobbingwide
Built from https://develop.svn.wordpress.org/trunk@34291
git-svn-id: http://core.svn.wordpress.org/trunk@34255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 17:06:25 +00:00
Dominik Schilling
f3a62b7714
Theme Editor: Change file descriptions of header.php
and footer.php
.
...
`header.php` is now "Theme Header" and `footer.php` is "Theme Footer". This prevents a clash with other "Header" strings in the context of "Custom Header".
Props ramiy.
Fixes #32975 .
Built from https://develop.svn.wordpress.org/trunk@34290
git-svn-id: http://core.svn.wordpress.org/trunk@34254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 16:03:24 +00:00
Sergey Biryukov
b92955b427
Network Admin: Include IDs for users and sites on their respective views.
...
Props danielbachhuber, wonderboymusic.
Fixes #18661 .
Built from https://develop.svn.wordpress.org/trunk@34289
git-svn-id: http://core.svn.wordpress.org/trunk@34253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 15:58:25 +00:00
Drew Jaynes
33a1c0fc16
Docs: Clarify the significance of the $accepted_args
parameter value in the documentation for add_filter()
.
...
Adds a couple of examples to illustrate callbacks accepting a variable number of arguments.
Fixes #33862 .
Built from https://develop.svn.wordpress.org/trunk@34288
git-svn-id: http://core.svn.wordpress.org/trunk@34252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 14:53:28 +00:00
Drew Jaynes
d870f4c9f9
Docs: Fix some syntactical issues in the DocBlock for set_query_var()
.
...
Adds descriptions for the global `WP_Query` instance and the `$value` parameter.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34287
git-svn-id: http://core.svn.wordpress.org/trunk@34251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 10:29:25 +00:00
Drew Jaynes
18adeb92fa
Docs: Fix some syntactical issues in the documentation for get_queried_object_id()
.
...
Adds descriptions for the global `WP_Query` instance and the return.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34286
git-svn-id: http://core.svn.wordpress.org/trunk@34250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 10:27:24 +00:00
Drew Jaynes
7a73dfbfb6
Docs: Fix some syntactical isses in the DocBlock for get_queried_object()
.
...
Also add descriptions for the return and the `WP_Query` global.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34285
git-svn-id: http://core.svn.wordpress.org/trunk@34249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 10:21:26 +00:00
Drew Jaynes
05f4e52541
Docs: Add documentation to get_query_var()
and WP_Query::get()
for the optional $default
argument, introduced in 3.9 in [27304].
...
Props swissspidy.
Fixes #33856 .
Built from https://develop.svn.wordpress.org/trunk@34284
git-svn-id: http://core.svn.wordpress.org/trunk@34248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 09:41:27 +00:00
Dion Hulse
9f61845204
HTTP: Update the Root Certificate bundle.
...
See #30434
Built from https://develop.svn.wordpress.org/trunk@34283
git-svn-id: http://core.svn.wordpress.org/trunk@34247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 08:43:26 +00:00
Dion Hulse
6113e498fc
Updates: FTP: Add a missing PCRE modifer in [34281].
...
See #16026 , #33432x
Built from https://develop.svn.wordpress.org/trunk@34282
git-svn-id: http://core.svn.wordpress.org/trunk@34246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 08:23:25 +00:00
Dion Hulse
5abc1eaab9
Updates: FTP/PemFTP Library: Remove the usage of deprecated regular expression functions (ereg replaced by PCRE).
...
Props enshrined, aaroncampbell
Fixes #16026 , #33432
Built from https://develop.svn.wordpress.org/trunk@34281
git-svn-id: http://core.svn.wordpress.org/trunk@34245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 08:20:27 +00:00
Scott Taylor
3ed914175a
Add an argument to wp_page_menu()
, 'menu_tag'
, which defaults to div
but can be overridden to allow HTML5 tags like nav
.
...
Props paulwilde, stebbiv, wonderboymusic.
Fixes #10968 .
Built from https://develop.svn.wordpress.org/trunk@34280
git-svn-id: http://core.svn.wordpress.org/trunk@34244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 06:07:24 +00:00
Weston Ruter
88c1ab7c74
Customize: Fix live previewing of menu changes on subdirectory installs.
...
Props adamsilverstein, westonruter.
Fixes #33916 .
Built from https://develop.svn.wordpress.org/trunk@34278
git-svn-id: http://core.svn.wordpress.org/trunk@34242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 05:47:27 +00:00
Scott Taylor
c1c8b55617
Comments: in wp_rel_nofollow_callback()
, account for the fact that a link might already have a rel
attribute. Currently, if a link already has a rel
, it will result it duplicate attributes on the element with conflicting values.
...
Adds unit tests.
Props junsuijin, wonderboymusic.
Fixes #9959 .
Built from https://develop.svn.wordpress.org/trunk@34277
git-svn-id: http://core.svn.wordpress.org/trunk@34241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 04:36:24 +00:00
Scott Taylor
fe6a7e4baa
List Tables: ensure that sortable list table column headers have the same padding/line-height as non-sortable headers.
...
Props drozdz.
Fixes #27945 .
Built from https://develop.svn.wordpress.org/trunk@34276
git-svn-id: http://core.svn.wordpress.org/trunk@34240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 03:26:26 +00:00
Scott Taylor
9b7b7f6dde
Editor: add hide-if-no-js
class to <td id="wp-word-count">
. Word Count no worky with no JavaScript.
...
Props chriscct7.
Fixes #33379 .
Built from https://develop.svn.wordpress.org/trunk@34275
git-svn-id: http://core.svn.wordpress.org/trunk@34239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 02:32:26 +00:00
Scott Taylor
0708ffe15c
In wp-comments-post.php
, sanity check a few of the comment inputs that are expected to be a string beford calling string-only functions on them.
...
Props Kloon.
Fixes #23416 .
Built from https://develop.svn.wordpress.org/trunk@34274
git-svn-id: http://core.svn.wordpress.org/trunk@34238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 22:22:25 +00:00
Scott Taylor
a2f15ca7cd
Widgets: don't show a dropdown if there is only 1 taxonomy or zero taxonomies available to the Tag Cloud widget form. Don't output the widget if there are no terms in the selected taxonomy.
...
Props GautamGupta, wonderboymusic.
Fixes #16125 .
Built from https://develop.svn.wordpress.org/trunk@34273
git-svn-id: http://core.svn.wordpress.org/trunk@34237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 22:11:24 +00:00
Scott Taylor
c2e1bab509
Canonical: redirect URLs that match an attachment masked on the wrong URL to the attachment link for the matched attachment.
...
Props solarissmoke.
Fixes #19918 .
Built from https://develop.svn.wordpress.org/trunk@34272
git-svn-id: http://core.svn.wordpress.org/trunk@34236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 21:32:24 +00:00
Scott Taylor
48d402a395
Posts List Table: Use a more robust technique for calculating $total_items
so that pagination still appears when items are removed on the last page of results and ->max_num_pages
decreases.
...
Props A5hleyRich.
Fixes #29870 .
Built from https://develop.svn.wordpress.org/trunk@34271
git-svn-id: http://core.svn.wordpress.org/trunk@34235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 21:18:24 +00:00
Boone Gorges
32887d3dfb
Lazy-load comment meta on single post pages.
...
[34268] introduced cache priming for commentmeta, enabled by default. To
ensure performance on single post pages - where commentmeta is most likely
to cause performance issues - we disable up-front cache-priming. Instead, we
prime commentmeta caches for all comments in the loop the first time
`get_comment_meta()` is called on the page.
Props bradt, dd32, wonderboymusic, boonebgorges.
Fixes #16894 .
Built from https://develop.svn.wordpress.org/trunk@34270
git-svn-id: http://core.svn.wordpress.org/trunk@34234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 20:01:24 +00:00
Weston Ruter
93bcd86b2a
Customize: Reduce peak memory usage by JSON-encoding settings and controls individually.
...
When there are hundreds of settings and controls (e.g. nav menu items and widget instances) the resulting object that is JSON-encoded can become very large, and `wp_json_encode()` can consume a lot of memory to serialize it. By breaking down the serialization into multiple calls the peak memory usage can be kept in line.
Moves logic out of `wp-admin/customize.php` into the `WP_Customize_Manager` class with new methods:
* `is_ios()`
* `get_document_title_template()`
* `get_preview_url()`/`set_preview_url()`
* `get_return_url()`/`set_return_url()`
* `get_autofocus()`/`set_autofocus()`
* `customize_pane_settings()`
Includes unit tests for these methods, for which the logic was formerly untestable in `customize.php`.
Fixes #33898 .
Built from https://develop.svn.wordpress.org/trunk@34269
git-svn-id: http://core.svn.wordpress.org/trunk@34233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 19:42:26 +00:00
Boone Gorges
bb43f72692
Prime comment meta caches in WP_Comment_Query
.
...
The new 'update_comment_meta_cache' parameter, which defaults to `true`, can
be used to disable this behavior.
`update_comment_cache()` has been updated to support an `$update_meta_cache`
parameter, which also updates to true; this matches the pattern we use for
priming post caches.
See #16894 .
Built from https://develop.svn.wordpress.org/trunk@34268
git-svn-id: http://core.svn.wordpress.org/trunk@34232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 19:30:27 +00:00
Boone Gorges
cdc6bc8ad5
Tell the insert_user_meta
filter whether user is being updated.
...
`insert_user_meta` was introduced in [33708]. This changeset passes the
`$update` parameter to it.
Props tharsheblows, geminorum.
Fixes #31549 .
Built from https://develop.svn.wordpress.org/trunk@34266
git-svn-id: http://core.svn.wordpress.org/trunk@34230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 14:35:26 +00:00
Helen Hou-Sandí
48befcf361
Superglobals: Revert [34059] until further notice.
...
see #33837 .
Built from https://develop.svn.wordpress.org/trunk@34265
git-svn-id: http://core.svn.wordpress.org/trunk@34229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 12:33:26 +00:00
Drew Jaynes
e13d18969f
Docs: Add a reminder to the DocBlock description for add_query_arg()
mentioning that the output is not escaped by default.
...
Props brentvr for the initial patch. (first props!)
See #33912 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34264
git-svn-id: http://core.svn.wordpress.org/trunk@34228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 09:39:24 +00:00
Sergey Biryukov
514eb11cf4
Revert unintended change from [34262].
...
See #33910 .
Built from https://develop.svn.wordpress.org/trunk@34263
git-svn-id: http://core.svn.wordpress.org/trunk@34227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 09:09:28 +00:00
Sergey Biryukov
d91fe61405
Docs: Expand the DocBlock for get_default_post_to_edit()
.
...
Props rabmalin.
Fixes #33910 .
Built from https://develop.svn.wordpress.org/trunk@34262
git-svn-id: http://core.svn.wordpress.org/trunk@34226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 09:06:34 +00:00
Scott Taylor
1f3dce8c75
Media: Ensure that HTML5 captions apply the 'img_caption_shortcode_width'
.
...
Props joemcgill.
Fixes #31053 .
Built from https://develop.svn.wordpress.org/trunk@34261
git-svn-id: http://core.svn.wordpress.org/trunk@34225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 06:04:24 +00:00
Scott Taylor
f3dd19c6e2
Media: In wp_ajax_send_attachment_to_editor()
, the fallback logic for $html
should be tucked into an else
statement so it isn't run needlessly and overwritten.
...
Props tychay.
Fixes #32072 .
Built from https://develop.svn.wordpress.org/trunk@34260
git-svn-id: http://core.svn.wordpress.org/trunk@34224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 05:55:25 +00:00
Scott Taylor
63efd92b11
Media: In get_image_send_to_editor()
, allow a custom value for $rel
.
...
Props tychay.
Fixes #32074 .
Built from https://develop.svn.wordpress.org/trunk@34259
git-svn-id: http://core.svn.wordpress.org/trunk@34223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 05:46:24 +00:00
Scott Taylor
ad0eb9c442
Media: In wp_prepare_attachment_for_js()
, don't call file_exists()
and filesize()
to retrieve $bytes
if the data is already present in $meta
. This is how the same code in attachment_submitbox_metadata()
already works.
...
Props polevaultweb.
Fixes #33214 .
Built from https://develop.svn.wordpress.org/trunk@34258
git-svn-id: http://core.svn.wordpress.org/trunk@34222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 05:03:24 +00:00
Scott Taylor
c871986819
Uploader: Fire 'wp_handle_upload' in wp_upload_bits()
. Thusly, the filter in wp_xmlrpc_server::mw_newMediaObject()
is redundant.
...
Props dllh.
Fixes #33539 .
Built from https://develop.svn.wordpress.org/trunk@34257
git-svn-id: http://core.svn.wordpress.org/trunk@34221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 04:46:25 +00:00
Scott Taylor
58ac764859
Media List Table: remove the counts from the "views" portion of the toolbar, which are inconsistent with grid view. Also reduces complexity and removes potentially expensive count query.
...
Related to the toolbar view, remove the `wp_admin_canonical_url()` action in grid mode. Grid views that result from links from the list table view are lenses into the library and need to be indicated as such vs being a full attachment query.
Fixes #29744 .
Built from https://develop.svn.wordpress.org/trunk@34256
git-svn-id: http://core.svn.wordpress.org/trunk@34220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 02:30:26 +00:00
Scott Taylor
a87ef29978
In wp_mime_type_icon()
, the length of the $wilds
array varies depending on what is passed as $mime
. Loop over $wilds
instead of arbitrarily checking $wilds[0]
.
...
Adds unit tests.
Fixes #33012 .
Built from https://develop.svn.wordpress.org/trunk@34255
git-svn-id: http://core.svn.wordpress.org/trunk@34219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 00:37:25 +00:00
Scott Taylor
6759f04a24
Media JS: ensure that wp.media.frame
(a static reference to the "current" Frame
) is reset when a cached frame is opened.
...
Fixes #33458 .
Built from https://develop.svn.wordpress.org/trunk@34254
git-svn-id: http://core.svn.wordpress.org/trunk@34218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 00:10:26 +00:00
Sergey Biryukov
444509e246
Docs: Expand the $comment_approved
argument description for 'comment_post'
action.
...
Props cfinke.
Fixes #33903 .
Built from https://develop.svn.wordpress.org/trunk@34253
git-svn-id: http://core.svn.wordpress.org/trunk@34217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 22:30:23 +00:00
Boone Gorges
48b7547a52
Improve consistency of comment notification callback signatures.
...
Both `wp_new_comment_notify_moderator()` and `wp_new_comment_notify_postauthor()`
now accept a single argument: `$comment_ID`.
Props SergeyBiryukov.
Fixes #33587 .
Built from https://develop.svn.wordpress.org/trunk@34252
git-svn-id: http://core.svn.wordpress.org/trunk@34216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 22:26:24 +00:00
Boone Gorges
85c00bd943
Move new user notification emails to add_action()
callbacks.
...
When a new user is created in various places throughout the interface,
notifications are sent to the site admin and the new user. Previously, these
notifications were fired through direct calls to `wp_new_user_notification()`,
making it difficult to stop or modify the messages.
This changeset introduces a number of new action hooks in place of direct calls
to `wp_new_user_notification()`, and hooks the new wrapper function
`wp_send_new_user_notifications()` to these hooks.
Props dshanske, thomaswm, boonebgorges.
Fixes #33587 .
Built from https://develop.svn.wordpress.org/trunk@34251
git-svn-id: http://core.svn.wordpress.org/trunk@34215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 22:19:24 +00:00
Boone Gorges
f6fb4653eb
Don't notify post authors about spam comments.
...
[34106] moved post author notification to a hook, and in the process, missed
the 'spam' check. This changeset restores that check.
To make unit testing easier, the notification callbacks have been refactored
to return values: false when various conditions aren't met (eg, approved
comments should not trigger moderation emails), and the return value of the
`wp_notify_*()` function otherwise.
Props cfinke, kraftbj.
See #33587 .
Built from https://develop.svn.wordpress.org/trunk@34250
git-svn-id: http://core.svn.wordpress.org/trunk@34214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 22:00:25 +00:00
Sergey Biryukov
a1050a58dc
Add a missing Oxford comma on Export screen.
...
Props juhise.
Fixes #33906 .
Built from https://develop.svn.wordpress.org/trunk@34249
git-svn-id: http://core.svn.wordpress.org/trunk@34213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 21:34:39 +00:00
Boone Gorges
5eae305403
Throw a notice when an invalid tax is passed to wp_insert_post()
.
...
Props jdgrimes.
Fixes #25477 .
Built from https://develop.svn.wordpress.org/trunk@34248
git-svn-id: http://core.svn.wordpress.org/trunk@34212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 19:25:26 +00:00
Boone Gorges
471fc6d9a5
Allow taxonomies to be non-public.
...
[13216] introduced the 'public' argument for `register_taxonomy()`. This param
was used to set defaults for 'show_ui' and a number of other params, but it
never did anything itself.
With this changeset, taxonomies registered with `public=false` will no longer
be queryable on the front end, ie via taxonomy archive queries.
Props wpsmith, ocean90, nacin, ericlewis, boonebgorges.
Fixes #21949 .
Built from https://develop.svn.wordpress.org/trunk@34247
git-svn-id: http://core.svn.wordpress.org/trunk@34211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 19:05:23 +00:00
Boone Gorges
6153a72796
Failed get_term_by()
lookups should always return false
.
...
Previously, we sometimes returned `null`.
Props charlestonsw, tyxla.
Fixes #33281 .
Built from https://develop.svn.wordpress.org/trunk@34246
git-svn-id: http://core.svn.wordpress.org/trunk@34210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 18:50:26 +00:00
Scott Taylor
af593128a7
Revert [33925], by-reference array manipulation is breaking comments in some themes.
...
This implementation is losing its shine.
See #16894 .
Built from https://develop.svn.wordpress.org/trunk@34245
git-svn-id: http://core.svn.wordpress.org/trunk@34209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 18:14:25 +00:00
Scott Taylor
956f076095
After [34160], also upgrade objects passed to get_avatar()
.
...
See #32619 .
Built from https://develop.svn.wordpress.org/trunk@34244
git-svn-id: http://core.svn.wordpress.org/trunk@34208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 17:34:24 +00:00
Sergey Biryukov
bf36b458bb
Docs: Update the DocBlock for wp_page_menu()
to include 'before'
, 'after'
, and 'walker'
arguments added in [34200].
...
Align the `$defaults` array and include the default value for `'show_home'`.
Props stevegrunwell.
Fixes #11095 .
Built from https://develop.svn.wordpress.org/trunk@34243
git-svn-id: http://core.svn.wordpress.org/trunk@34207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 16:47:25 +00:00
Sergey Biryukov
dd11460efa
Add register_post_type_args
filter for changing register_post_type()
arguments before further processing.
...
Does not apply to built-in post types.
Props MikeSchinkel, nickciske, engelen, swissspidy.
Fixes #17447 .
Built from https://develop.svn.wordpress.org/trunk@34242
git-svn-id: http://core.svn.wordpress.org/trunk@34206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 15:47:25 +00:00
Scott Taylor
1e3807c10d
wp-admin/includes/template.php
is now a loader for 3 files made via svn cp
:
...
* `Walker_Category_Checklist` class
* `WP_Internal_Pointers` class
* `template-functions.php`
This is BC for plugins that are loading `wp-admin/includes/template.php` for fun.
See #33413 .
Built from https://develop.svn.wordpress.org/trunk@34241
git-svn-id: http://core.svn.wordpress.org/trunk@34205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 15:35:23 +00:00