Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-17 16:15:24 +01:00
Code Issues Projects Releases Wiki Activity
33,042 Commits 50 Branches 748 Tags 792 MiB
e638f72a9a
Commit Graph

33042 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Boone Gorges
e638f72a9a Order terms by 'name' when populating object term cache. 
[34217] removed the `ORDER BY` clause from `update_object_term_cache()`, for
improved performance. But this proved to cause problems in cases where users
were expecting the results of `get_the_terms()` to be ordered by 'name'. Let's
revert the change for the time being, and look into more disciplined ordering
in a future release.

Props afercia.
See #28922. Fixes #35180.
Built from https://develop.svn.wordpress.org/trunk@36056


git-svn-id: http://core.svn.wordpress.org/trunk@36021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-22 01:51:28 +00:00
Gary Pendergast
2f53c1ada2 Tests: Use the default_storage_engine MySQL option on newer MySQL versions. 
In MySQL 5.5.3, `storage_engine` was deprecated in favour of `default_storage_engine`, and subsequently removed in MySQL 5.7. To avoid errors when running tests on MySQL 5.7, we need to switch between the options based on MySQL version.

Props skithund, jeremyfelt.

Fixes #34692.


Built from https://develop.svn.wordpress.org/trunk@36055


git-svn-id: http://core.svn.wordpress.org/trunk@36020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-21 22:27:25 +00:00
Drew Jaynes
79705d5cc1 Docs: Fix a typo in the 4.4.0 changlog entry in the intermediate_image_sizes_advanced hook doc. 
Props morganestes.
Fixes #35190.

Built from https://develop.svn.wordpress.org/trunk@36054


git-svn-id: http://core.svn.wordpress.org/trunk@36019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-21 22:24:27 +00:00
Andrea Fercia
dc31b503ec Accessibility: Remove the revisions limit title attribute from the Publish box. 
The revisions limit warning is now always displayed in plain text even when the
limit is not reached yet. Removes the plus "+" from the revisions count number.

Fixes #35029.
Built from https://develop.svn.wordpress.org/trunk@36053


git-svn-id: http://core.svn.wordpress.org/trunk@36018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-21 14:39:28 +00:00
John Blackbourn
779d639c85 Tests: Prevent role capability pollution in Tests_Post_GetPostsByAuthorSql::test_user_has_access_only_to_private_posts_for_certain_post_types(). 
Built from https://develop.svn.wordpress.org/trunk@36050


git-svn-id: http://core.svn.wordpress.org/trunk@36015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-21 07:16:29 +00:00
John Blackbourn
bfc3302852 Tests: Fix all the things. 
See #30017, #32394

Built from https://develop.svn.wordpress.org/trunk@36049


git-svn-id: http://core.svn.wordpress.org/trunk@36014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-21 07:10:27 +00:00
John Blackbourn
405d5ba71d Query: Re-initialise any dynamically-added public query vars before running the public query vars test. 
See #35115

Built from https://develop.svn.wordpress.org/trunk@36048


git-svn-id: http://core.svn.wordpress.org/trunk@36013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-21 07:00:28 +00:00
John Blackbourn
3fdd127ce2 Tests: Shave a second off the user capability tests by reusing its user fixtures. 
See #30017, #32394

Built from https://develop.svn.wordpress.org/trunk@36047


git-svn-id: http://core.svn.wordpress.org/trunk@36012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-21 06:57:37 +00:00
John Blackbourn
45019c3467 Query: Introduce a unit test which will fail when new public query vars are introduced without also updating the test. This adds an extra layer of explicitness to introducing public query vars in order to avoid introducing unintentional clashes with URL query vars that are already in use. 
See #35115 

Built from https://develop.svn.wordpress.org/trunk@36045


git-svn-id: http://core.svn.wordpress.org/trunk@36010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-21 05:49:28 +00:00
John Blackbourn
d4eb85569b Login: Revert [34213] and [35897]. It has become apparent that there is a need for a separate function (and corresponding filter) which allows for the login form action URL to differ from the URL used to access the login form, so that plugins or implementations which change the login URL do not need to worry about handling the form submission at the same URL. 
For now, we'll revert to the pre-4.4 behaviour of hard-coding the login form action URL as `wp-login.php` and look at implementing a separate function and corresponding filter in 4.5.

Props KrissieV, salcode, JPry
Fixes #34925
See #35103

Built from https://develop.svn.wordpress.org/trunk@36042


git-svn-id: http://core.svn.wordpress.org/trunk@36007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-21 03:23:29 +00:00
Boone Gorges
26caa329f2 Respect approval status when determining comment page count in comments_template(). 
Since 4.4, when fetching the first page of comments and the 'newest' comments
are set to display first, `comments_template()` must perform arithmetic to
determine which comments to show. See #8071. This arithmetic requires the
total comment count for the current post, which is calculated with a separate
`WP_Comment_Query`. This secondary comment query did not properly account for
non-approved comment statuses; all unapproved comments should be part of the
comment count for admins, and individual users should have their own
unapproved comments included in the count. As a result, `comments_template()`
was, in some cases, being fooled into thinking that a post had fewer comments
available for pagination than it actually had, which resulted in empty pages
of comments.

We correct this problem by mirroring 'status' and 'include_unapproved' params
of the main comment query within the secondary query used to calculate
pagination.

Fixes #35068.
Built from https://develop.svn.wordpress.org/trunk@36040


git-svn-id: http://core.svn.wordpress.org/trunk@36005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-21 03:07:32 +00:00
John Blackbourn
afc7f43ca0 Comments: When a comment is submitted, ensure the user_ID element in the array that's passed to the preprocess_comment filter gets populated. 
Fixes #34997

Built from https://develop.svn.wordpress.org/trunk@36038


git-svn-id: http://core.svn.wordpress.org/trunk@36003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-21 02:47:26 +00:00
Gary Pendergast
ba8b95cdbe Texturize: Transform & into & in tag attributes. 
[35709] was overly broad, and stopped transforming `&` characters within tag attributes. So that sites aren't generating invalid HTML, we need to restore this functionality, while continuing to not transform `&` within blocked tags.

Fixes #35008 for trunk.


Built from https://develop.svn.wordpress.org/trunk@36036


git-svn-id: http://core.svn.wordpress.org/trunk@36001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-21 02:43:26 +00:00
Gary Pendergast
dbf5d782ad Query: Remove title from the public query vars list. 
[33706] added `title` as a public query var, but there's not really a practical need for this, and it interferes with any plugin that uses `title` as a query var for itself.

Props tyxla.

Fixes #35115 for trunk.


Built from https://develop.svn.wordpress.org/trunk@36034


git-svn-id: http://core.svn.wordpress.org/trunk@35999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-21 00:43:27 +00:00
Drew Jaynes
a28bfe8ba6 Docs: Add missing notations for the optional $tab_index and $extended parameters in the DocBlock for the deprecated the_editor() function. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36033


git-svn-id: http://core.svn.wordpress.org/trunk@35998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-20 21:21:27 +00:00
Andrea Fercia
7849bb7d94 Accessibility: Remove title attributes from the updates links on the Plugin and Themes list tables. 
Adds `aria-label` attributes on some links and on the "update nag" link. Adds translator comments.

Fixes #35167.
Built from https://develop.svn.wordpress.org/trunk@36032


git-svn-id: http://core.svn.wordpress.org/trunk@35997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-20 16:09:28 +00:00
Andrew Ozz
6e49a963b1 Responsive images: fix calculations when determining whether to include particular image file in srcset. 
Props joemcgill.
Fixes #34955 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36031


git-svn-id: http://core.svn.wordpress.org/trunk@35996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-20 02:39:32 +00:00
Drew Jaynes
5399b2137f Docs: Add missing parameter and return notations to the DocBlock for the deprecated get_usernumposts() function. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36030


git-svn-id: http://core.svn.wordpress.org/trunk@35995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-19 19:41:30 +00:00
Eric Lewis
e844695e12 Docs: Add documentation to wp-blog-header.php. 
Fixes #35161.

Built from https://develop.svn.wordpress.org/trunk@36029


git-svn-id: http://core.svn.wordpress.org/trunk@35994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-19 11:20:28 +00:00
Drew Jaynes
013d1178e5 Docs: Add missing parameter and return notations in the DocBlock for get_profile(). 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36028


git-svn-id: http://core.svn.wordpress.org/trunk@35993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-19 09:04:26 +00:00
Drew Jaynes
543420158f Docs: Properly mark the $classname parameter as optional. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36027


git-svn-id: http://core.svn.wordpress.org/trunk@35992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-19 09:00:26 +00:00
Drew Jaynes
eb158d65c7 Docs: Add missing parameter and return notations to the DocBlock for the deprecated wp_specialchars() function. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36026


git-svn-id: http://core.svn.wordpress.org/trunk@35991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-19 08:58:25 +00:00
Drew Jaynes
57878dd1b9 Docs: Add missing parameter notations and descriptions in the DocBlock for get_link(). 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36025


git-svn-id: http://core.svn.wordpress.org/trunk@35990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-19 08:54:26 +00:00
Drew Jaynes
932c91b766 Docs: Add missing parameter and return notations in the DocBlock for the deprecated _nc() function. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36024


git-svn-id: http://core.svn.wordpress.org/trunk@35989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-19 08:48:27 +00:00
Drew Jaynes
7b1ac33dee Docs: Add a missing summary, parameter, and return descriptiosn to the DocBlock for the deprecated function, get_linkrating(). 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36023


git-svn-id: http://core.svn.wordpress.org/trunk@35988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-19 08:23:26 +00:00
Drew Jaynes
df0c1aa0ed Docs: Add a missing notation for the $gmt_time parameter in the DocBlock for spawn_cron(). 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36022


git-svn-id: http://core.svn.wordpress.org/trunk@35987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-19 08:20:27 +00:00
Drew Jaynes
decb25a8ae Docs: Add missing DocBlocks for hash_hmac() and _hash_hmac(). 
Both will be ignored from parsing as and serve as compat functions for PHP's `hash_hmac()`.

Introduced in [18111].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@36021


git-svn-id: http://core.svn.wordpress.org/trunk@35986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-19 05:11:27 +00:00
Drew Jaynes
c10ec122ca Docs: Fix inline comment syntax in _mb_strlen(), an internal compat method for mb_strlen(). 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36020


git-svn-id: http://core.svn.wordpress.org/trunk@35985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-19 04:59:33 +00:00
Drew Jaynes
87786b4373 Docs: Add missing DocBlocks for mb_strlen() and _mb_strlen(). 
Both will be ignored from parsing as and serve as compat functions for PHP's `mb_strlen()`, which is not enabled by default.

Introduced in [32114].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@36019


git-svn-id: http://core.svn.wordpress.org/trunk@35984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-19 04:56:29 +00:00
Drew Jaynes
9e04750fc4 Docs: Fix inline comment syntax in _mb_substr(), an internal compat method for mb_substr(). 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36018


git-svn-id: http://core.svn.wordpress.org/trunk@35983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-19 04:50:28 +00:00
Drew Jaynes
be6589730d Docs: Add missing DocBlocks for mb_substr() and _mb_substr(). 
Both will be ignored from parsing as and serve as compat functions for PHP's `mb_substr()`, which is not enabled by default.

Introduced in [17621].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@36017


git-svn-id: http://core.svn.wordpress.org/trunk@35982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-19 04:47:28 +00:00
Andrea Fercia
67e1f55c4b Accessibility: Remove title attributes and improve accessibility on the "no-js" Menus screen. 
When JavaScript is off, the reorder menu item and Edit menu item links now use `aria-label`
attributes instead of title attributes.

Fixes #35134.
Built from https://develop.svn.wordpress.org/trunk@36016


git-svn-id: http://core.svn.wordpress.org/trunk@35981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-19 00:17:26 +00:00
Andrea Fercia
5787972a67 Accessibility: Remove title attributes from the Theme browser. 
Also, adds translators comments and removes a no more used variable, see [27748].

Fixes #35140.
Built from https://develop.svn.wordpress.org/trunk@36015


git-svn-id: http://core.svn.wordpress.org/trunk@35980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-19 00:00:29 +00:00
Andrea Fercia
f7f14d94f3 Accessibility: Improvements for the Authentication Check modal dialog "Close X". 
Removes the title attribute and uses a `<button>` element instead of a `<div>`.
Also simplifies the CSS and takes care of the hover/focus style.

Fixes #35142.
Built from https://develop.svn.wordpress.org/trunk@36014


git-svn-id: http://core.svn.wordpress.org/trunk@35979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-18 23:51:26 +00:00
Drew Jaynes
05e0d7c3c3 Docs: Add missing parameter and return descriptions to the DocBlocks for _wp_object_name_sort_cb() and _wp_object_count_sort_cb(), both uasort() callbacks. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36013


git-svn-id: http://core.svn.wordpress.org/trunk@35978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-18 23:38:26 +00:00
Drew Jaynes
9b89047bf2 Docs: Add a missing notation for the $context parameter in the DocBlock for _nx_noop(). 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36012


git-svn-id: http://core.svn.wordpress.org/trunk@35977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-18 23:16:26 +00:00
Drew Jaynes
13bead9e58 Docs: Fix the syntax for the get_previous_post_link() DocBlock to ensure it's read and parsed as such instead of as a multi-line comment. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36011


git-svn-id: http://core.svn.wordpress.org/trunk@35976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-18 23:14:26 +00:00
Drew Jaynes
f4af7643d8 Docs: Add a missing summary, description, and @since version to the DocBlock for wp_redirect_admin_locations(). 
Introduced in [19880].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@36010


git-svn-id: http://core.svn.wordpress.org/trunk@35975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-18 23:08:26 +00:00
Drew Jaynes
907e0ce6f1 Docs: Add a missing notation for the $bookmark_id parameter in the DocBlock for clean_bookmark_cache(). 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36009


git-svn-id: http://core.svn.wordpress.org/trunk@35974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-18 23:01:28 +00:00
Boone Gorges
31db92d83e Add current-cat-ancestor class to ancestor items in wp_list_categories(). 
Pairs nicely with `current-cat-parent`.

Props jrchamp, swisssipdy, ardathksheyna, wonderboymusic.
Fixes #10676.
Built from https://develop.svn.wordpress.org/trunk@36008


git-svn-id: http://core.svn.wordpress.org/trunk@35973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-18 18:38:25 +00:00
Aaron Jorbin
0eaedf734f Remove RDIO from oEmbed providers 
RDIO is shutting down. https://www.rdio.com/farewell/

Props swissspidy
Fixes #35152


Built from https://develop.svn.wordpress.org/trunk@36007


git-svn-id: http://core.svn.wordpress.org/trunk@35972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-18 18:16:27 +00:00
Boone Gorges
b2f4f73633 Ensure that wp_list_categories() supports comma-separated lists for 'exclude' and 'exclude_tree'. 
[34696] introduced a regression whereby comma-separated values for 'exclude'
and 'exclude_tree' would be handled improperly when merging the two parameters,
resulting in category IDs being incorrectly dropped from the combined array.

Props gblsm, hnle.
Fixes #35156.
Built from https://develop.svn.wordpress.org/trunk@36005


git-svn-id: http://core.svn.wordpress.org/trunk@35970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-18 18:12:25 +00:00
Boone Gorges
5d46c03508 Ensure get_terms() results are unique when using 'meta_query'. 
The introduction of 'meta_query' to `get_terms()` in 4.4 made it possible for
`get_terms()` to erroneously return duplicate results. To address the issue,
we add the `DISTINCT` keyword to the SQL query when a 'meta_query' parameter
has been provided.

Props @jadpm.
Fixes #35137.
Built from https://develop.svn.wordpress.org/trunk@36003


git-svn-id: http://core.svn.wordpress.org/trunk@35968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-18 17:44:25 +00:00
Sergey Biryukov
3f35196e48 Docs: Fix copy/paste error in wp_remote_retrieve_cookies() description. 
Props mark8barnes.
Fixes #35157.
Built from https://develop.svn.wordpress.org/trunk@36002


git-svn-id: http://core.svn.wordpress.org/trunk@35967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-18 17:23:29 +00:00
Sergey Biryukov
ff36a54824 Widgets: Add missing closing tag for spinner after [35317]. 
Props rabmalin.
Fixes #35150.
Built from https://develop.svn.wordpress.org/trunk@36001


git-svn-id: http://core.svn.wordpress.org/trunk@35966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-18 12:02:28 +00:00
Andrea Fercia
6fdd27a1d6 Accessibility: Remove the title attribute from the Featured Image postbox thumbnail. 
The title attribute is now replaced with plain text in a `howto` paragraph, as done for example in the Tags postbox.
Adds an `aria-describedby` attribute on the thumbnail link to target the description.
Also, fixes the focus style on the featured image thumbnail.

Fixes #35076.
Built from https://develop.svn.wordpress.org/trunk@36000


git-svn-id: http://core.svn.wordpress.org/trunk@35965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-17 23:44:26 +00:00
Pascal Birchler
a7e13d0af9 Editor: Correctly indent definition lists when switching from the visual to the text editor. 
Props ocean90, katieburch.
Fixes #23299.
Built from https://develop.svn.wordpress.org/trunk@35999


git-svn-id: http://core.svn.wordpress.org/trunk@35964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-17 23:06:25 +00:00
Andrea Fercia
e8b900d9f5 Accessibility: Remove title attributes from the Link Manager screen. 
Title attributes are now replaced with `aria-label` where appropriate.
Also fixes some typos in the DocBlocks.

Fixes #35135.
Built from https://develop.svn.wordpress.org/trunk@35998


git-svn-id: http://core.svn.wordpress.org/trunk@35963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-17 22:53:28 +00:00
Pascal Birchler
333bdb535a Remove unused variables after [35995] and [35996]. 
See #34439.
Built from https://develop.svn.wordpress.org/trunk@35997


git-svn-id: http://core.svn.wordpress.org/trunk@35962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-17 18:41:27 +00:00
Pascal Birchler
51bb4db622 Network Admin: Remove the list of files which will be deleted when deleting a theme. 
Fixes #34439.
Built from https://develop.svn.wordpress.org/trunk@35996


git-svn-id: http://core.svn.wordpress.org/trunk@35961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-17 18:35:26 +00:00