Upstream
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
31,001 Commits 48 Branches 719 Tags 912 MiB
Commit Graph

31001 Commits

Author SHA1 Message Date
Scott Taylor e73ee5ac98 Introduce `WP_Comment` class to model/strongly-type rows from the comments database table. Inclusion of this class is a pre-req for some more general comment cleanup and sanity. 
* Takes inspiration from `WP_Post` and adds sanity to comment caching. 
* Clarifies when the current global value for `$comment` is returned. The current implementation in `get_comment()` introduces side effects and an occasion stale global value for `$comment` when comment caches are cleaned.
* Strongly-types `@param` docs
* This class is marked `final` for now

Props wonderboymusic, nacin.

See #32619.

Built from https://develop.svn.wordpress.org/trunk@33891


git-svn-id: http://core.svn.wordpress.org/trunk@33860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 18:17:24 +00:00
Helen Hou-Sandí 89de754f0e UI: Restrict textarea resizing to vertical to prevent ugliness. 
props tyxla, MatheusFD.
fixes #33400.

Built from https://develop.svn.wordpress.org/trunk@33890


git-svn-id: http://core.svn.wordpress.org/trunk@33859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 18:05:25 +00:00
Sergey Biryukov ba056692a6 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-includes/class-wp-customize-manager.php`. 
props kraftbj.
fixes #33684. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33889


git-svn-id: http://core.svn.wordpress.org/trunk@33858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 09:21:23 +00:00
Sergey Biryukov bc8af88903 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/network/site-users.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33683. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33888


git-svn-id: http://core.svn.wordpress.org/trunk@33857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 09:03:24 +00:00
Sergey Biryukov 771b29455b Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/includes/bookmark.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33682. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33887


git-svn-id: http://core.svn.wordpress.org/trunk@33856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 08:59:24 +00:00
Sergey Biryukov c4ce11422c Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/widgets.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33680. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33886


git-svn-id: http://core.svn.wordpress.org/trunk@33855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 08:56:24 +00:00
Sergey Biryukov ce05b02a59 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/users.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33679. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33885


git-svn-id: http://core.svn.wordpress.org/trunk@33854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 08:54:24 +00:00
Sergey Biryukov b4fbbf53cf Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/user-new.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33678. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33884


git-svn-id: http://core.svn.wordpress.org/trunk@33853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 08:46:52 +00:00
Drew Jaynes e2038f9150 Docs: Add inline DocBlocks for the `require_once()` calls that now bring in top-level HTTP API functionality and HTTP API classes. 
Classes brought in from separate files now include:
* `WP_Http`
* `WP_Http_Streams`
* `WP_Http_Curl`
* `WP_HTTP_Proxy`
* `WP_Http_Cookie`
* `WP_Http_Encoding`

See #33413. See #32246.

Built from https://develop.svn.wordpress.org/trunk@33882


git-svn-id: http://core.svn.wordpress.org/trunk@33851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 04:36:30 +00:00
Drew Jaynes 69375b243a Docs: Clarify the file header summary for wp-includes/http.php, the top-level file for the HTTP Request API. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33881


git-svn-id: http://core.svn.wordpress.org/trunk@33850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 04:36:08 +00:00
Drew Jaynes 853fd32e88 Docs: Add a missing file header for wp-includes/class-http.php. 
Also clarifies the class DocBlock summary for `WP_Http` to more clearly describe its purpose.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33880


git-svn-id: http://core.svn.wordpress.org/trunk@33849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:39:21 +00:00
Drew Jaynes 05ec4d2029 Docs: Clarify the file header summary for wp-includes/http-functions.php, introduced in [33748]. 
Also removes now-moot extra information from the file header description.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33879


git-svn-id: http://core.svn.wordpress.org/trunk@33848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:37:20 +00:00
Drew Jaynes d948d8e104 Docs: Add a missing file header to wp-includes/class-wp-http-streams.php, introduced in [33748]. 
Also clarifies the class DocBlock summary for `WP_Http_Streams` to better describe its purpose.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33878


git-svn-id: http://core.svn.wordpress.org/trunk@33846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:33:21 +00:00
Drew Jaynes b9ef409823 Docs: Add a missing file header to wp-includes/class-wp-http-proxy.php, introduced in [33748]. 
Also clarifies the class DocBlock summary for `WP_HTTP_Proxy` to better describe its purpose.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33876


git-svn-id: http://core.svn.wordpress.org/trunk@33844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:30:21 +00:00
Drew Jaynes f7ba27390c Docs: Add a missing file header for wp-includes/class-wp-http-encoding.php, introduced in [33748]. 
Also clarifies the class DocBlock summary for `WP_Http_Encoding`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33875


git-svn-id: http://core.svn.wordpress.org/trunk@33843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:28:21 +00:00
Drew Jaynes 378d3e0f8d Docs: Add a missing file header for wp-includes/class-wp-http-curl.php, introduced in [33748]. 
Also clarifies the class DocBlock summary for `WP_Http_Curl` to better describe its purpose.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33874


git-svn-id: http://core.svn.wordpress.org/trunk@33842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:23:21 +00:00
Drew Jaynes c42da1df59 Docs: Add a missing file header to wp-includes/class-wp-http-cookie.php, introduced in [33748]. 
Also clarifies the summary in the class DocBlock for `WP_Http_Cookie`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33873


git-svn-id: http://core.svn.wordpress.org/trunk@33841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:19:21 +00:00
Drew Jaynes 31f52091ec Docs: Clarify the file header summary for wp-includes/widgets.php, the top-level file for the core Widgets API. 
Also fixes some minor grammar issues in the file description.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33872


git-svn-id: http://core.svn.wordpress.org/trunk@33840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:14:20 +00:00
Drew Jaynes 0ce0241740 Docs: Clarify the file header summary for widget-functions.php, introduced in [33746]. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33871


git-svn-id: http://core.svn.wordpress.org/trunk@33839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 02:58:20 +00:00
Drew Jaynes 95dc9825a7 Docs: Clarify the file header summary for class-wp-widget-factory.php, introduced in [33746]. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33870


git-svn-id: http://core.svn.wordpress.org/trunk@33838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 02:54:22 +00:00
Drew Jaynes a92dc6aeed Docs: Improve the file header for class-wp-widget.php to describe what the file contains. 
Also rewrites the class DocBlock summary for `WP_Widget` to better describe the '''purpose''' of the class.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33869


git-svn-id: http://core.svn.wordpress.org/trunk@33837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 02:50:21 +00:00
Drew Jaynes ab990ac594 Docs: Add a missing summary to the DocBlock for `Walker::get_number_of_root_elements()`. 
Props wen-solutions
See #33662.

Built from https://develop.svn.wordpress.org/trunk@33868


git-svn-id: http://core.svn.wordpress.org/trunk@33836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 19:51:21 +00:00
Scott Taylor 3cad9d8385 After [33723], ensure that `$i` is properly set before looping. 
See #16865.

Built from https://develop.svn.wordpress.org/trunk@33867


git-svn-id: http://core.svn.wordpress.org/trunk@33835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:48:22 +00:00
Sergey Biryukov bc0a1e1c4b Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/themes.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33677. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33866


git-svn-id: http://core.svn.wordpress.org/trunk@33834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:45:21 +00:00
Sergey Biryukov 3e0929740e Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/press-this.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33676. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33865


git-svn-id: http://core.svn.wordpress.org/trunk@33833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:38:21 +00:00
Sergey Biryukov d5ac2bc41e Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/post-new.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33675. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33864


git-svn-id: http://core.svn.wordpress.org/trunk@33832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:36:22 +00:00
Sergey Biryukov a880c5c576 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/options.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33674. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33863


git-svn-id: http://core.svn.wordpress.org/trunk@33831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:31:21 +00:00
Sergey Biryukov 5ceecc4eaf Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/nav-menus.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33673. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33862


git-svn-id: http://core.svn.wordpress.org/trunk@33830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:21:21 +00:00
Sergey Biryukov b136b074bf Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/edit.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33671. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33861


git-svn-id: http://core.svn.wordpress.org/trunk@33829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:15:20 +00:00
Sergey Biryukov d2919e2d71 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/edit-comments.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33669. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33860


git-svn-id: http://core.svn.wordpress.org/trunk@33828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:04:21 +00:00
Sergey Biryukov 31b0fe4b6f Set svn:eol-style for the files added in [32806]. 
see #32576.
Built from https://develop.svn.wordpress.org/trunk@33859


git-svn-id: http://core.svn.wordpress.org/trunk@33827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 17:55:21 +00:00
John Blackbourn 6aad2eb98c Correctly encode spaces in URLs passed to `esc_url()` instead of removing them. 
Fixes #23605
Props enshrined, johnbillion

Built from https://develop.svn.wordpress.org/trunk@33858


git-svn-id: http://core.svn.wordpress.org/trunk@33826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 17:20:21 +00:00
Sergey Biryukov 3d1c08a1a5 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/customize.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33668. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33857


git-svn-id: http://core.svn.wordpress.org/trunk@33825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 17:05:22 +00:00
Andrea Fercia f35c176426 Customize: use correct CSS selectors for the Menu Customizer reorder-toggle button after [33604]. 
Fixes #33633.
Built from https://develop.svn.wordpress.org/trunk@33856


git-svn-id: http://core.svn.wordpress.org/trunk@33824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 16:56:20 +00:00
John Blackbourn 06c86124ad More unit tests for `esc_url()` and `esc_url_raw()`. 
See #23605, #20771, #16859

Built from https://develop.svn.wordpress.org/trunk@33855


git-svn-id: http://core.svn.wordpress.org/trunk@33823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 16:51:21 +00:00
Sergey Biryukov cf69e6deb3 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/custom-header.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33667. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33854


git-svn-id: http://core.svn.wordpress.org/trunk@33822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 16:29:21 +00:00
Sergey Biryukov d95417a5e7 Provide more helful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/media-upload.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33672. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33853


git-svn-id: http://core.svn.wordpress.org/trunk@33821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 16:21:21 +00:00
Sergey Biryukov c3b663ad8d Provide more helful feedback than just “Cheatin’ uh?” for permission errors in `wp-admin/edit-tags.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33670. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33852


git-svn-id: http://core.svn.wordpress.org/trunk@33820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 16:06:21 +00:00
John Blackbourn 867a449fee Add some more passing unit tests for `esc_url()` in preparation for upcoming changes. 
See #23605, #20771, #16859

Built from https://develop.svn.wordpress.org/trunk@33851


git-svn-id: http://core.svn.wordpress.org/trunk@33819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 14:20:21 +00:00
Boone Gorges 709fde7584 Remove `#` from `@ticket` annotation in a unit test. 
This improper character was erroneously introduced in [33724].

Props netweb.
Fixes #33532.
Built from https://develop.svn.wordpress.org/trunk@33850


git-svn-id: http://core.svn.wordpress.org/trunk@33818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 13:40:21 +00:00
John Blackbourn 606b6d15f1 Introduce `wp_removable_query_args()`, which returns an array of single-use query variables which can be removed from a URL. 
Also applies the function to the return URL when the Customizer is closed.

Fixes #32692
Props swissspidy, Mte90

Built from https://develop.svn.wordpress.org/trunk@33849


git-svn-id: http://core.svn.wordpress.org/trunk@33817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 11:29:23 +00:00
Jeremy Felt 9666aec8d1 Multisite: Remove duplicate span element output from row actions 
Fixes #32961.

Built from https://develop.svn.wordpress.org/trunk@33848


git-svn-id: http://core.svn.wordpress.org/trunk@33816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 21:51:21 +00:00
Drew Jaynes 05c7abcf13 Docs: Add missing parameter documentation to the the DocBlock for `WP_User::__set()`. 
Props racase for the initial patch.
Fixes #33652.

Built from https://develop.svn.wordpress.org/trunk@33847


git-svn-id: http://core.svn.wordpress.org/trunk@33815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 21:47:21 +00:00
Scott Taylor 0415dd7c53 After [33807], fix unit tests for PHP 5.2 
Fixes #17626.

Built from https://develop.svn.wordpress.org/trunk@33846


git-svn-id: http://core.svn.wordpress.org/trunk@33814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 17:04:21 +00:00
Scott Taylor 9f8816c939 De-Jorbin [33814]. 
See #23012.

Built from https://develop.svn.wordpress.org/trunk@33845


git-svn-id: http://core.svn.wordpress.org/trunk@33813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 15:48:22 +00:00
Sergey Biryukov bffe6a63ba Make curly quotes in playlist item title translatable. 
fixes #33391.
Built from https://develop.svn.wordpress.org/trunk@33844


git-svn-id: http://core.svn.wordpress.org/trunk@33812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 13:50:21 +00:00
Scott Taylor 9b8169bd30 Move widget classes to their own files in `wp-includes/widgets`: 
* `default-widgets.php` now requires all of the individual classes
* Move the functions scattered about this file to `widget-functions.php`, which loads before `default-widgets.php`, which only conditionally loads anyway in `wp_maybe_load_widgets()`, which is hooked on `plugins_loaded` 

See #33413, #23012.

Built from https://develop.svn.wordpress.org/trunk@33843


git-svn-id: http://core.svn.wordpress.org/trunk@33811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 13:49:21 +00:00
Sergey Biryukov 32b5726fd4 Merge two similar strings. 
props pavelevap.
fixes #33643.
Built from https://develop.svn.wordpress.org/trunk@33842


git-svn-id: http://core.svn.wordpress.org/trunk@33810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 13:46:24 +00:00
Scott Taylor ecf0b82afb Add some JS docs to `customize-base.js` 
Props ericlewis.
Fixes #33639.

Built from https://develop.svn.wordpress.org/trunk@33841


git-svn-id: http://core.svn.wordpress.org/trunk@33809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 04:15:22 +00:00
Scott Taylor a829ee32ce User Settings: allow dashes in `get|set_user_setting()` in PHP and `get|setUserSetting()` in JS. 
Add unit tests - there were none. Mock `set_user_setting()` since it won't run due to `headers_sent()` being `true`.

Fixes #22781.

Built from https://develop.svn.wordpress.org/trunk@33840


git-svn-id: http://core.svn.wordpress.org/trunk@33808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 03:57:21 +00:00