WordPress

mirror of https://github.com/WordPress/WordPress.git synced 2024-11-03 01:09:39 +01:00

Author	SHA1	Message	Date
Andrea Fercia	6566808e8a	Accessibility: Improve and modernize user interface controls: Improve the new form controls styles and heights. Improves cross-browsers rendering and addresses most of the reported edge cases. See #47477. Built from https://develop.svn.wordpress.org/trunk@46356 git-svn-id: http://core.svn.wordpress.org/trunk@46155 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-30 17:24:59 +00:00
antpb	247e7eb7d5	Media: Revert [46354] preventing bad clipping of text in image details page. See #47115. Built from https://develop.svn.wordpress.org/trunk@46355 git-svn-id: http://core.svn.wordpress.org/trunk@46154 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-30 17:12:59 +00:00
antpb	7c8028febf	Media: Prevents clipping of text when scaling image edit screen. Props sabernhardt, audrasjb, afercia. See #47115. Built from https://develop.svn.wordpress.org/trunk@46354 git-svn-id: http://core.svn.wordpress.org/trunk@46153 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-30 16:34:58 +00:00
Andrew Ozz	38e6958698	Media: Move `wp_get_original_image_path()` to `wp-content/post.php` to make it easier to access from plugins. Props pbiron. See #47873. Built from https://develop.svn.wordpress.org/trunk@46353 git-svn-id: http://core.svn.wordpress.org/trunk@46152 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-30 16:28:59 +00:00
Andrea Fercia	20e781f44d	Accessibility: Improve and modernize user interface controls: Remove the CSS transform 1 pixel shift from the buttons active state. Props Joen. See #34904. Built from https://develop.svn.wordpress.org/trunk@46350 git-svn-id: http://core.svn.wordpress.org/trunk@46149 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-30 10:53:57 +00:00
desrosj	8cb7c5c764	Upgrade/Install: Fix the Install Now button in the plugin overlay when running WordPress on a specific port. Props garrett-eclipse, pierlo, afragen. Fixes #48077. Built from https://develop.svn.wordpress.org/trunk@46348 git-svn-id: http://core.svn.wordpress.org/trunk@46147 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-30 00:05:57 +00:00
Andrea Fercia	dfcdb40c8f	Accessibility: Improve and modernize user interface controls: Improve the radio buttons blue dot alignment. Props desrosj, garrett-eclipse, afercia. See #47498. Built from https://develop.svn.wordpress.org/trunk@46345 git-svn-id: http://core.svn.wordpress.org/trunk@46144 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-29 21:56:56 +00:00
Andrea Fercia	8ef586a897	Accessibility: Improve and modernize user interface controls: Make the secondary buttons border blue. Props drw158, youknowriad, kjellr, melchoyce, talldanwp, audrasjb. See #34904. Built from https://develop.svn.wordpress.org/trunk@46344 git-svn-id: http://core.svn.wordpress.org/trunk@46143 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-29 21:53:57 +00:00
Sergey Biryukov	5f2c7142a1	Docs: Improve documentation for `::display()` methods in various list tables. Props itowhid06. Fixes #47947. Built from https://develop.svn.wordpress.org/trunk@46341 git-svn-id: http://core.svn.wordpress.org/trunk@46140 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-29 11:04:58 +00:00
Andrea Fercia	55b1dc642e	Accessibility: After [46337]: make the select elements background white also on hover, active, and focus states. See #47477. See #48128. Built from https://develop.svn.wordpress.org/trunk@46340 git-svn-id: http://core.svn.wordpress.org/trunk@46139 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-28 16:45:57 +00:00
Andrea Fercia	7d769a9234	Accessibility: Improve and modernize user interface controls. Style the select elements disabled state. Props adhitya03, MarcosAlexandre, kjellr. See #47477. Fixes #48129. Built from https://develop.svn.wordpress.org/trunk@46339 git-svn-id: http://core.svn.wordpress.org/trunk@46138 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-28 16:35:59 +00:00
Andrew Ozz	dd44ab5a58	Fix the context (right-click) menu when clicking the placeholder for the post title field on the classic Edit Post screen. Props masummdar, audrasjb, afercia. Fixes #47318. Built from https://develop.svn.wordpress.org/trunk@46338 git-svn-id: http://core.svn.wordpress.org/trunk@46137 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-28 16:20:57 +00:00
Andrea Fercia	becc682bcf	Accessibility: Improve and modernize user interface controls. Make the select elements background white. Props adhitya03. See #47477. Fixes #48128. Built from https://develop.svn.wordpress.org/trunk@46337 git-svn-id: http://core.svn.wordpress.org/trunk@46136 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-28 16:15:59 +00:00
Sergey Biryukov	07a753cb35	Docs: Add documentation for `WP_Comments_List_Table::display()`. Props itowhid06, dinhtungdu. Fixes #47929. Built from https://develop.svn.wordpress.org/trunk@46336 git-svn-id: http://core.svn.wordpress.org/trunk@46135 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-27 23:03:58 +00:00
whyisjake	b6f7c0cbc4	Administration: Ensure visual consistency with large titles in the sidebar. Custom posts, and other menu titles that are long aren't wrapping correctly. Props jagirbaheshwp, munyagu, harshbarach, hareesh-pillai, pratikkry, naveenkharwar, mukesh27, dushanthi, worldweb, audrasjb Fixes #42201 Built from https://develop.svn.wordpress.org/trunk@46332 git-svn-id: http://core.svn.wordpress.org/trunk@46131 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-26 21:51:57 +00:00
Andrea Fercia	66dd6814e7	Media: Restore the original Image Editor columns layout after [46326]. Fixes #47116. Built from https://develop.svn.wordpress.org/trunk@46331 git-svn-id: http://core.svn.wordpress.org/trunk@46130 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-26 20:37:57 +00:00
whyisjake	c034f5b4c3	Menus: Replace http with https in placeholders. Encourage the use of https with the placeholder text in menus. Fixes #46312 Props aksl95, audrasjb, celloexpressions, SergeyBiryukov, jorbin. Built from https://develop.svn.wordpress.org/trunk@46330 git-svn-id: http://core.svn.wordpress.org/trunk@46129 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-26 20:32:55 +00:00
Andrea Fercia	93dd6d907a	Accessibility: Media: Make the Image Editor buttons text visible. User interface controls that use only icons aren't ideal for many users. Universal icons are rare. Icons must communicate meaning but their actual meaning varies depending on many factors including the users cultural background. Moreover, users with cognitive impairments and speech recognition users need interface controls with visible text to be able to operate them. - shortens some of the buttons text to: Rotate left, Rotate right, Flip vertical, Flip horizontal - moves the Undo and Redo buttons underneath the main buttons group Props nrqsnchz, melchoyce, karmatosed, sabernhardt, mikeschroder. Fixes #47116. Built from https://develop.svn.wordpress.org/trunk@46326 git-svn-id: http://core.svn.wordpress.org/trunk@46125 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-26 17:16:57 +00:00
Sergey Biryukov	6e8f550770	General: Correct strict comparison in `WP_Links_List_Table::column_categories()` introduced in [46313]. `$cat_id` is a string, `$category` is an integer. See #48142. Built from https://develop.svn.wordpress.org/trunk@46316 git-svn-id: http://core.svn.wordpress.org/trunk@46115 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-26 01:24:56 +00:00
Sergey Biryukov	148322a970	Docs: Improve documentation for `_post_states()` and `get_post_states()`. Add documentation for `_media_states()`. See #47110. Built from https://develop.svn.wordpress.org/trunk@46315 git-svn-id: http://core.svn.wordpress.org/trunk@46114 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-26 00:57:58 +00:00
whyisjake	a351243928	General: Further phpcs cleanup. In [46312] and [46313] we attempted to do some phpcs cleanup. This commit cleans up three issues that were introduced in [46309]. Fixes #48142. Props: whyisjake, garrett-eclipse, desrosj Built from https://develop.svn.wordpress.org/trunk@46314 git-svn-id: http://core.svn.wordpress.org/trunk@46113 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-26 00:37:58 +00:00
whyisjake	d53b773a47	General: Further phpcs cleanup. In [46312] we attempted to do some `phpcs` cleanup. This commit cleans up three issues that were introduced in [46309]. Fixes #48142. Props whyisjake, garrett-eclipse. Built from https://develop.svn.wordpress.org/trunk@46313 git-svn-id: http://core.svn.wordpress.org/trunk@46112 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-25 23:38:57 +00:00
whyisjake	38dc032e66	General: Linter cleanup `phpcbf` was able to clean up a few files. Tests were breaking as a result of code formatting. Fixes #48142 Props whyisjake Built from https://develop.svn.wordpress.org/trunk@46312 git-svn-id: http://core.svn.wordpress.org/trunk@46111 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-25 22:53:58 +00:00
whyisjake	b4ab6b7e14	Menus: Duplicate Page Entry in View All Pages when generating a Menu Simplifies the interface in menu creation. Fixes [37782] Props garrett-eclipse, mdgl, birgire, xkon, audrasjb, pento, girlieworks Built from https://develop.svn.wordpress.org/trunk@46309 git-svn-id: http://core.svn.wordpress.org/trunk@46108 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-25 21:51:58 +00:00
Andrea Fercia	f8a25a89c9	Accessibility: Implement the new focus styles on the login screen after [46247]. Props @kjellr. See #47153. Built from https://develop.svn.wordpress.org/trunk@46293 git-svn-id: http://core.svn.wordpress.org/trunk@46105 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-25 16:40:00 +00:00
desrosj	894e133d0c	Build/Test Tools: Introduce automated PHP compatibility checking. This change introduces a new Composer script, `compat` that will scan the codebase for (detectable) potential PHP compatibility issues using the `PHP_CodeSniffer` and a custom ruleset based off of the `PHPCompayibilityWP` ruleset (`phpcompat.xml.dist`). The command will be run as a separate job within each Travis build. While many compatibility issues and false positives have already been corrected in this commit and other Trac tickets, there are still some remaining. For that reason, the job is allowed to fail while the remainder of the potential compatibility issues are investigated and addressed. After those are resolved, the job should be set as required to pass to help prevent new compatibility issues from being introduced. Props desrosj, jrf, all PHPCompatibilityWP and PHPCompatibility contributors. Fixes #46152. Built from https://develop.svn.wordpress.org/trunk@46290 git-svn-id: http://core.svn.wordpress.org/trunk@46102 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-25 13:47:58 +00:00
Sergey Biryukov	c7f4cbc62c	Docs: Improve consistency in `@since` tags for parameters that were made optional. See #47110. Built from https://develop.svn.wordpress.org/trunk@46288 git-svn-id: http://core.svn.wordpress.org/trunk@46100 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-24 12:54:57 +00:00
Sergey Biryukov	a943fd64bc	Coding Standards: Fix WPCS issue in [46283]. See #48110. Built from https://develop.svn.wordpress.org/trunk@46284 git-svn-id: http://core.svn.wordpress.org/trunk@46096 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 23:24:57 +00:00
Sergey Biryukov	75ca249558	Twenty Twenty: Rename widget areas to `sidebar-1` and `sidebar-2`. This ensures that widgets are mapped correctly and is consistent with the previous default themes. See https://github.com/WordPress/twentytwenty/issues/481. Reverts [46282]. Props ocean90, garrett-eclipse, desrosj, SergeyBiryukov. See #48110. Built from https://develop.svn.wordpress.org/trunk@46283 git-svn-id: http://core.svn.wordpress.org/trunk@46095 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 23:17:58 +00:00
Sergey Biryukov	b95b6f2c73	Site Health: Move "The folder ... was detected as being under version control" message from failure to warning. Props afragen, davidbaumwald. Fixes #47982. Built from https://develop.svn.wordpress.org/trunk@46281 git-svn-id: http://core.svn.wordpress.org/trunk@46093 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 21:24:56 +00:00
desrosj	098455b06f	Bundled Themes: Make Twenty Twenty the new default theme. After being imported in [46271], Twenty Twenty can now be set as the default theme in WordPress. See #48110. Props desrosj, ocean90. Built from https://develop.svn.wordpress.org/trunk@46278 git-svn-id: http://core.svn.wordpress.org/trunk@46090 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 21:00:58 +00:00
Sergey Biryukov	c117b9957f	Site Health: Use `WP_Automatic_Updater::is_disabled()` to check whether automatic updates are disabled. The previous check for `DISALLOW_FILE_MODS` and `AUTOMATIC_UPDATER_DISABLED` constants didn't always provide accurate results. Props Clorith, kraftner, afragen. Fixes #47869. Built from https://develop.svn.wordpress.org/trunk@46276 git-svn-id: http://core.svn.wordpress.org/trunk@46088 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 20:52:56 +00:00
Sergey Biryukov	371f83cfd1	Site Health: Introduce `site_status_test_result` filter for the output of a finished Site Health test. Props Clorith. Fixes #47864. Built from https://develop.svn.wordpress.org/trunk@46269 git-svn-id: http://core.svn.wordpress.org/trunk@46081 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 20:04:58 +00:00
Sergey Biryukov	db5f9f7a3a	Site Health: Update PHP extension tests to reflect the current state of the Hosting Teams handbook recommendations. Props Clorith, bronsonquick, jrf, johnbillion, galbaras, mikeschroder, jorbin. Fixes #47454. Built from https://develop.svn.wordpress.org/trunk@46268 git-svn-id: http://core.svn.wordpress.org/trunk@46080 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 19:50:56 +00:00
Sergey Biryukov	9510aaecde	Site Health: Improve wording for PHP update warning. Props danieltj, garrett-eclipse, marybaum, afragen, chetan200891. Fixes #47644. Built from https://develop.svn.wordpress.org/trunk@46267 git-svn-id: http://core.svn.wordpress.org/trunk@46079 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 19:39:58 +00:00
Sergey Biryukov	5955f0938b	Privacy: Introduce `wp_privacy_personal_data_email_to` and `wp_privacy_personal_data_email_subject` filters. Pass email data to the `wp_privacy_personal_data_email_content` filter. Props garrett-eclipse, thakkarhardik, birgire. Fixes #46303. Built from https://develop.svn.wordpress.org/trunk@46265 git-svn-id: http://core.svn.wordpress.org/trunk@46077 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 19:25:57 +00:00
Sergey Biryukov	255b1d6e3f	Privacy: Show a success message for personal data erasure. Props garrett-eclipse, allendav, birgire, JoshuaWold, karmatosed, pputzer. Fixes #44135. Built from https://develop.svn.wordpress.org/trunk@46264 git-svn-id: http://core.svn.wordpress.org/trunk@46076 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 19:13:58 +00:00
John Blackbourn	f14fc1392c	Taxonomy: Redirect to the correct URL after deleting a taxonomy term attached to a post type other than Post. Props donmhico, mukesh27 Fixes #47858 Built from https://develop.svn.wordpress.org/trunk@46263 git-svn-id: http://core.svn.wordpress.org/trunk@46075 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 19:10:58 +00:00
desrosj	bcbedd7f55	Coding Standards: Fix a coding standards issue introduced in [46254]. See #37392. Built from https://develop.svn.wordpress.org/trunk@46261 git-svn-id: http://core.svn.wordpress.org/trunk@46073 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 18:35:00 +00:00
Andrea Fercia	0d75495612	Login and Registration: Add a "Show password" button on the login page. The ability for users to see the password they're typing improves usability and accessibility of the login users flow. - brings the login screen in line with the same feature already used in the New User, Edit User, and Reset Password pages - improves association of labels and input fields by using explicit association with `for` / `id` attributes - slightly increases the "Remember me" label font size Props johnbillion, Iceable, audrasjb, joyously, adamsilverstein, boemedia, DrewAPicture, shadyvb, birgire, peterwilsoncc, pento, anevins, davidbaumwald, whyisjake, afercia. Fixes #42888. Built from https://develop.svn.wordpress.org/trunk@46256 git-svn-id: http://core.svn.wordpress.org/trunk@46068 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 18:06:57 +00:00
johnjamesjacoby	e5302dff26	Multisite/Sites: supplemental commit to r46251. This commit adds the links to the list-table class itself (that were missed in r46251.) See #37392. Props pbiron, thomaswm. Built from https://develop.svn.wordpress.org/trunk@46254 git-svn-id: http://core.svn.wordpress.org/trunk@46066 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 17:51:58 +00:00
Ella Iseulde Van Dorpe	22ae908ede	Editor: Add Nonce Endpoint This is a follow up to #47843, implementing a PHP endpoint and inline scripts after the editor package updates. The action was originally added in https://github.com/WordPress/gutenberg/pull/16683. Fixes #48076. Built from https://develop.svn.wordpress.org/trunk@46253 git-svn-id: http://core.svn.wordpress.org/trunk@46065 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 17:47:56 +00:00
johnjamesjacoby	b65ea119bb	Multisite/Sites: Add links to filter websites by status. This commit brings the Network-Admin Sites list page up-to-speed with other similar list-table powered pages, by adding links to filter the results by Site Status. Includes a single unit test for the newly introduced `wp_count_sites()` multisite function, named to match the `wp_count_` function pattern from other list tables. Fixes #37392. Props mnelson4, spacedmonkey, pbiron. Built from https://develop.svn.wordpress.org/trunk@46251 git-svn-id: http://core.svn.wordpress.org/trunk@46063 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 17:35:59 +00:00
Andrea Fercia	956725990f	Accessibility: Make sortable meta boxes non sortable when there are no locations they can be dragged to. Depending on the amount of meta boxes and the layout settings under Screen Options, sortable meta boxes may not be actually sortable. In these cases, jQuery UI sortable needs to be disabled and the user interface shouldn't use a CSS `cursor: move`. The use of consistent and relevant cursors may be important for users who have a cognitive disability, since cursors give a visual clue as to an element's functionality. Using the move cursor for elements which cannot be moved may be confusing or counter-intuitive for users. Props adamsilverstein, antpb, anevins. Fixes #47131. Built from https://develop.svn.wordpress.org/trunk@46250 git-svn-id: http://core.svn.wordpress.org/trunk@46062 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 17:30:58 +00:00
Andrea Fercia	6cb8e14790	Accessibility: Improve and modernize user interface controls. Sixth part: allow checkboxes and radio buttons to scale with text. - uses a SVG icon for checkboxes - uses CSS `rem` relative units Props kjellr, afercia, audrasjb. Fixes #47498. Built from https://develop.svn.wordpress.org/trunk@46248 git-svn-id: http://core.svn.wordpress.org/trunk@46060 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 16:51:57 +00:00
Andrea Fercia	165ac34260	Accessibility: Improve and modernize user interface controls for better contrast. Fifth part: Common form controls. Props anevins, melchoyce, audrasjb, kjellr. Fixes #47153. Built from https://develop.svn.wordpress.org/trunk@46247 git-svn-id: http://core.svn.wordpress.org/trunk@46059 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 16:21:58 +00:00
antpb	46892ffb12	Media: Sets `post_id` optional in `media_sideload_image()` and `media_handle_sideload()`. Props SergeyBiryukov, donmhico, mikeschroder, sebastian.pisula. Fixes #43579. Built from https://develop.svn.wordpress.org/trunk@46245 git-svn-id: http://core.svn.wordpress.org/trunk@46057 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 16:03:56 +00:00
Andrea Fercia	38be855367	Accessibility: Improve and modernize user interface controls. Third part: allow buttons and form controls to scale with text. Props kjellr, abrightclearweb, audrasjb. Fixes #47477. Built from https://develop.svn.wordpress.org/trunk@46243 git-svn-id: http://core.svn.wordpress.org/trunk@46055 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 15:27:57 +00:00
Andrea Fercia	271f45072d	Accessibility: Improve and modernize user interface controls for better contrast. Second part: tables, meta boxes, and other user interface elements. Introduces better contrast for borders of the following user interface elements: - Tables - Screen Options and Help - Admin notices - Welcome panel - Meta boxes (post boxes) - Cards - Health Check accordions and headings - Theme and Plugin upload forms Props kjellr, melchoyce, karmatosed, audrasjb. Fixes #48101. Built from https://develop.svn.wordpress.org/trunk@46242 git-svn-id: http://core.svn.wordpress.org/trunk@46054 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 15:10:59 +00:00
Andrea Fercia	618883f6f4	Accessibility: Improve and modernize user interface controls for better contrast. First part: buttons and links. - Introduces new styles for the buttons, with better contrast for borders and better focus style. - Introduces a new focus style for links. - The new styles improve consistency with the ones used in the new Block Editor (Gutenberg). Props michaelarestad, truchot, mor10, kellychoffman, adamsoucie, paaljoachim, Joen, kjellr, melchoyce, karmatosed, audrasjb, afercia. Fixes #34904. Built from https://develop.svn.wordpress.org/trunk@46241 git-svn-id: http://core.svn.wordpress.org/trunk@46053 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 14:43:58 +00:00
Andrea Fercia	e43633b7d0	Accessibility: Menus: Improve the menu items "Select All". - changes "Select All" from a link to a checkbox - the new checkbox is available only when JavaScript support is on - semantically and for accessibility, a checkbox is a better user interface control because the available action is clear to all users and the selected state is communicated natively - it's consistent with the existing pattern for the admin tables Props birgire, audrasjb, afercia. Fixes #47048. Built from https://develop.svn.wordpress.org/trunk@46240 git-svn-id: http://core.svn.wordpress.org/trunk@46052 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-23 12:42:58 +00:00
John Blackbourn	e36d1bcbd8	Docs: Docblock corrections and improvements, mostly related to various `pre_*` filters. See #47110 Built from https://develop.svn.wordpress.org/trunk@46232 git-svn-id: http://core.svn.wordpress.org/trunk@46044 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-21 17:41:57 +00:00
Dominik Schilling	123b4475b0	Site Health: Don't verify SSL certificate when testing the local site. The SSL certificate may be self-signed which prevents various tests from returning proper results. Since the Cron API and file editors don't verify the certificate the tests shouldn't either. Props Clorith, ocean90. Fixes #47957. Built from https://develop.svn.wordpress.org/trunk@46231 git-svn-id: http://core.svn.wordpress.org/trunk@46043 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-21 16:06:57 +00:00
Dominik Schilling	4d9c482e79	File Editor: Don't verify SSL certificate when doing loopback requests for checking for fatal errors. Props Clorith. See #47957. Built from https://develop.svn.wordpress.org/trunk@46230 git-svn-id: http://core.svn.wordpress.org/trunk@46042 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-21 15:59:56 +00:00
Dominik Schilling	01b6bd9f38	Site Health: Replace `wp_get_upload_dir()` with `wp_upload_dir()`. `wp_get_upload_dir()` returns the theoretical path of the uploads directory. When there was no upload yet the test returns an incorrect result (not writeable) because the directory doesn't exist. Switching to `wp_upload_dir()`, which creates the directory on the fly, ensures a proper test result. Fixes #47958. Built from https://develop.svn.wordpress.org/trunk@46228 git-svn-id: http://core.svn.wordpress.org/trunk@46040 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-21 15:49:57 +00:00
Sergey Biryukov	a879bcb1c6	Code Modernization: Remove a workaround for `IMAGETYPE_ICO` in `file_is_displayable_image()`. The `IMAGETYPE_ICO` constant was introduced in PHP 5.3, so no longer needs a workaround. Props jrf. See #48074. Built from https://develop.svn.wordpress.org/trunk@46217 git-svn-id: http://core.svn.wordpress.org/trunk@46029 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-20 22:18:59 +00:00
desrosj	594f77dbae	Docs: Add missing `$which` parameter descriptions. Follow up of [46211]. See #45954. Built from https://develop.svn.wordpress.org/trunk@46212 git-svn-id: http://core.svn.wordpress.org/trunk@46024 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-20 20:57:57 +00:00
desrosj	ba2700068d	Networks and Sites: Add support for the `extra_tablenav()` method in `WP_MS_Sites_List_Table`. This method allows additional filters or other UI components to be added to the top and bottom of the `WP_List_Table` between the bulk actions dropdown and search input field. Fixes #45954. Props pbiron, desrosj. Built from https://develop.svn.wordpress.org/trunk@46211 git-svn-id: http://core.svn.wordpress.org/trunk@46023 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-20 20:53:58 +00:00
Sergey Biryukov	a9aefc83bc	Code Modernization: Remove conditional use of PHP `realpath()`. The `realpath()` function was introduced in PHP 4.0.0. There's no point in checking if the function exists in PHP 5.6+, in only 2 instances out of 29. Props jrf. Fixes #48075. Built from https://develop.svn.wordpress.org/trunk@46210 git-svn-id: http://core.svn.wordpress.org/trunk@46022 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-20 20:46:56 +00:00
Sergey Biryukov	d2ebf7d0e4	Privacy: Display group items count in the personal data export file if there's more than one item in the group. Props birgire, garrett-eclipse, pputzer. Fixes #46895. Built from https://develop.svn.wordpress.org/trunk@46209 git-svn-id: http://core.svn.wordpress.org/trunk@46021 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-20 20:30:58 +00:00
Adam Silverstein	a2f45dc9eb	Media: make search input full width on mobile. Take two. Props m1tk00. Fixes #40130. Built from https://develop.svn.wordpress.org/trunk@46207 git-svn-id: http://core.svn.wordpress.org/trunk@46019 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-20 20:09:54 +00:00
desrosj	3cf6276ed0	Code Modernization: Remove JSON extension workarounds for PHP < 5.6. The PHP native JSON extension has been bundled and compiled with PHP by default since version 5.2.0. Because the minimum version of PHP required by WordPress is now 5.6.20 (see #46594 and [45058]), JSON extension related polyfills and backwards compatibility code can now be removed. This change removes code that supported JSON related functionality on older versions of PHP. This includes (but is not limited to) checks that `json_last_error()` exists, checking and setting the `JSON_UNESCAPED_SLASHES` and `JSON_PRETTY_PRINT` constants if not previously defined, and deprecating the `_wp_json_prepare_data()` function (which was 100% workaround code). Follow up of [46205]. See #47699. Props jrf, Clorith, pento. Built from https://develop.svn.wordpress.org/trunk@46206 git-svn-id: http://core.svn.wordpress.org/trunk@46018 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-20 20:08:57 +00:00
Andrew Ozz	0628245170	Admin email verification: - Fix wording of the HTML title. - Add hidden `(opens in a new tab)` to links that need it. - Add the `screen-reader-text` CSS class to login.css. - Add another translator comment. Props afercia. See #46349. Built from https://develop.svn.wordpress.org/trunk@46203 git-svn-id: http://core.svn.wordpress.org/trunk@46015 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-20 18:51:56 +00:00
Andrew Ozz	29ea4c6a4c	Media/Upload: rotate images on upload according to EXIF Orientation. Props msaggiorato, wpdavis, markoheijnen, dhuyvetter, msaggiorato, n7studios, triplejumper12, pbiron, mikeschroder, joemcgill, azaozz. Fixes #14459. Built from https://develop.svn.wordpress.org/trunk@46202 git-svn-id: http://core.svn.wordpress.org/trunk@46014 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-20 18:21:57 +00:00
desrosj	38254bdc6f	Site Health: Use sentence casing consistently in header tags. Props SergeyBiryukov, ajayghaghretiya1, ronakganatra, mukesh27, Clorith. Fixes #47298. Built from https://develop.svn.wordpress.org/trunk@46199 git-svn-id: http://core.svn.wordpress.org/trunk@46011 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-20 17:26:57 +00:00
Sergey Biryukov	d968a74e2a	Docs: Add `@since` tag for the new `$position` argument added to `add_submenu_page()` and related functions in [46197]. See #39776. Built from https://develop.svn.wordpress.org/trunk@46198 git-svn-id: http://core.svn.wordpress.org/trunk@46010 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-20 17:06:57 +00:00
Adam Silverstein	6ca808129c	Menus: add a position argument to `add_submenu_page` and the helper functions that use it. Add a position argument to the `add_submenu_page` function similar to the one already in `add_menu_page`. When adding sub menus enables setting the position in the sub menu where the item should appear. In addition, add the position argument to functions that call `add_submenu_page` under the hood: `add_management_page`, `add_options_page`, `add_theme_page`, `add_plugins_page`, `add_users_page`, `add_dashboard_page`, `add_posts_page`, `add_media_page`, `add_links_page`, `add_pages_page` and `add_comments_page`. Props welcher, birgire, alexvorn2. Fixes #39776. Built from https://develop.svn.wordpress.org/trunk@46197 git-svn-id: http://core.svn.wordpress.org/trunk@46009 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-20 15:00:59 +00:00
whyisjake	a014bd21c1	Multisite: Remove the redundant `blog_versions` table. As part of the Multisite installation process, a `blog_versions` table is created. This table is never read from (except immediately prior to updating it), it's only ever inserted into or updated. It is not used to determine which blogs need to be upgraded. This table was introduced in 3.0 when the WPMU schema was merged #11644 and it appears the table has never been used in core and is therefore redundant and may as well be removed. Props johnbillion, nacin, ryan, johnjamesjacoby, whyisjake. Fixes #19755. See #41685. Built from https://develop.svn.wordpress.org/trunk@46194 git-svn-id: http://core.svn.wordpress.org/trunk@46006 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-19 22:07:57 +00:00
whyisjake	250eb42802	Networks and Sites: Save database version in site meta (Multisite) Currently there is there a table in multisite called blog_versions. All this table stores is the database version as number and the date updated. With plans to add site meta in #37923 this new table should be used. This has a number of benefits, including functions to CRUD these values in the database. Once this data is in the blogmeta, table, the blog_versions table can be removed all together. If require a SQL view can be used blog_versions from data stored in blogmeta. Props spacedmonkey, leogermani. Fixes #41685. See #19755. Built from https://develop.svn.wordpress.org/trunk@46193 git-svn-id: http://core.svn.wordpress.org/trunk@46005 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-19 21:42:58 +00:00
desrosj	3d06de26a3	PHP 7.4: Fix another instance of array access on a datatype that cannot be accessed as an array. PHP 7.4 adds a warning when trying access a null/bool/int/float/resource (everything but array, string and object) as if it were an array. Follow up of [45639]. Props desrosj, jrf. See #47704. Built from https://develop.svn.wordpress.org/trunk@46185 git-svn-id: http://core.svn.wordpress.org/trunk@45997 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-19 14:30:56 +00:00
Andrew Ozz	463e050b25	Uploads: add helper functions for setting, getting, and deleting the temp upload reference used to the attachment_id when retrying to make image sub-sizes. See #47872. Built from https://develop.svn.wordpress.org/trunk@46174 git-svn-id: http://core.svn.wordpress.org/trunk@45986 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-19 01:26:55 +00:00
whyisjake	08a077658d	Accessibility: Replace wp-a11y.js with @wordpress/a11y package We've extracted wp-includes/wp-a11y.js to a reusable package wordpress/a11y which is published on NPM. Let's make sure this package is also used in WordPress core. Once all the JavaScript is built using webpack, we can also import this package wherever it is used and configure webpack to load is an external. Props omarreiss, herregroen, desrosj, ocean90, afercia, sstoqnov Built from https://develop.svn.wordpress.org/trunk@46167 git-svn-id: http://core.svn.wordpress.org/trunk@45979 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-18 17:41:55 +00:00
desrosj	5a477b5715	Docs: Add missing descriptions for functions in `wp-admin/update-core.php`. Also, fix the `@since` annotation added in [45480] to include the correct version. Props SergeyBiryukov, ajayghaghretiya1. Fixes #47424. Built from https://develop.svn.wordpress.org/trunk@46161 git-svn-id: http://core.svn.wordpress.org/trunk@45973 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-17 20:43:56 +00:00
desrosj	5329411f6d	General: Ensure the arguments passed to `implode()` are in the correct order. The `implode()` function accepts two. parameters, `$glue` and `$pieces`. For historical reasons, these parameters have been accepted in any order, though it was recommended that the documented order of `$glue, $pieces` be used. Starting in PHP 7.4, specifying the parameters in the reverse order will trigger a deprecation notice with the plan to remove this tolerance in PHP 8.0. This change fixes the occurrences of reversed arguments in Core with the exception of those contained in included external libraries. These will be handled separately. Props jrf, jorbin. See #47746. Built from https://develop.svn.wordpress.org/trunk@46155 git-svn-id: http://core.svn.wordpress.org/trunk@45967 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-17 13:40:57 +00:00
johnjamesjacoby	757d077669	Network Admin: Allow Sites to have filterable States in List Table rows. This change introduces a new `site_states()` method to the Sites List Table class (with a new `display_site_states` filter inside of it) following the pattern popularized in other List Table classes before it (Posts, Media, etc...) Fixes #37684. Props mnelson4, pbiron, jeremyfelt, johnjamesjacoby. Built from https://develop.svn.wordpress.org/trunk@46153 git-svn-id: http://core.svn.wordpress.org/trunk@45965 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-16 23:34:55 +00:00
Sergey Biryukov	e6bbff13c5	Code Modernisation: Replace `call_user_func_array()` in various `__call()` methods with dynamic function calls. The callback in these functions is always checked against a limited list of valid callbacks that can be safely changed to dynamic function calls. Props jrf. See #47678. Built from https://develop.svn.wordpress.org/trunk@46144 git-svn-id: http://core.svn.wordpress.org/trunk@45956 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-15 11:53:56 +00:00
Sergey Biryukov	8ee3790851	Code Modernisation: Replace `call_user_func_array()` in `wp-admin/includes/widgets.php` and associated unit tests with a direct function call. Props jrf. See #47678. Built from https://develop.svn.wordpress.org/trunk@46138 git-svn-id: http://core.svn.wordpress.org/trunk@45950 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-15 11:41:55 +00:00
Sergey Biryukov	f166554882	Code Modernisation: Replace `call_user_func_array()` in `wp-admin/includes/template.php` with a dynamic function call. Props jrf. See #47678. Built from https://develop.svn.wordpress.org/trunk@46137 git-svn-id: http://core.svn.wordpress.org/trunk@45949 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-15 11:35:56 +00:00
Sergey Biryukov	7c370fa9d0	Code Modernisation: Replace `call_user_func_array()` in `wp-admin/includes/ajax-actions.php` with a dynamic function call. Props jrf. See #47678. Built from https://develop.svn.wordpress.org/trunk@46136 git-svn-id: http://core.svn.wordpress.org/trunk@45948 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-15 11:34:57 +00:00
Sergey Biryukov	30fe3f5d4f	Code Modernisation: Introduce the spread operator in `wp-admin/includes/media.php`. Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable. Props jrf. See #47678. Built from https://develop.svn.wordpress.org/trunk@46131 git-svn-id: http://core.svn.wordpress.org/trunk@45943 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-15 11:12:55 +00:00
Sergey Biryukov	7093392099	Code Modernisation: Introduce the spread operator in `wp-admin/includes/dashboard.php`. Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable. Props jrf. See #47678. Built from https://develop.svn.wordpress.org/trunk@46130 git-svn-id: http://core.svn.wordpress.org/trunk@45942 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-15 11:11:56 +00:00
Sergey Biryukov	340b7b53c8	Code Modernisation: Introduce the spread operator in `wp-admin/includes/class-*-upgrader-skin.php`. Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable. Props jrf. See #47678. Built from https://develop.svn.wordpress.org/trunk@46125 git-svn-id: http://core.svn.wordpress.org/trunk@45937 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-15 10:42:54 +00:00
jorgefilipecosta	099eb0578e	Block Editor: Add preloading of autosaves. With the introduction of https://github.com/WordPress/gutenberg/pull/7945, the block editor requests autosave data when the editor is loaded. This can be optimized by preloading the request server-side and then passing the request data to the client using the preloading mechanism in editor-form-blocks.php. Props: talldanwp, aduth. Built from https://develop.svn.wordpress.org/trunk@46110 git-svn-id: http://core.svn.wordpress.org/trunk@45922 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-14 16:47:54 +00:00
Sergey Biryukov	42079f34a9	Site Health: Modify the grading indicator to remove percentage score in favor of a "Good" or "Should be improved" status. This removes arbitrary confusion about what the numbers mean. Props Clorith, hedgefield, Cybr, arena, DavidAnderson, earnjam, daveshine, Otto42, azaozz, asadkn, KARTHOST, tigertech, maximejobin, johnbillion, raboodesign, ramiy, afragen. Fixes #47046. Built from https://develop.svn.wordpress.org/trunk@46106 git-svn-id: http://core.svn.wordpress.org/trunk@45918 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-14 14:29:56 +00:00
Aaron Jorbin	dd3ad3ac51	GENERAL: Remove magic quote functions The path to magic quote sanity took a fun and exciting turn: PHP core removed it and WordPress updated the minimum version. For the formally external pclzip, the code is commented out to make investigating easier and in case we ever need to merge upstream (if that still exists) changes. Props ayeshrajans, jrf, jorbin. See #47783. Fixes #18322. Built from https://develop.svn.wordpress.org/trunk@46105 git-svn-id: http://core.svn.wordpress.org/trunk@45917 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-13 22:21:01 +00:00
Adam Silverstein	a3eba2c201	Login and Registration: reset password - ensure submit button disabled when field empty. Fix an issue where the submit button was enabled with an empty password when the user previously checked "Confirm use of weak password" for a weak password, then cleared the password field. Props henry.wright. Fixes #47924. Built from https://develop.svn.wordpress.org/trunk@46103 git-svn-id: http://core.svn.wordpress.org/trunk@45915 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-13 18:30:55 +00:00
Sergey Biryukov	3591f1ad60	Text Changes: Correct "up-to-date" vs. "up to date" usage in a database update string and inline comments. * "Up to date" is an adverb phrase that describes an action that brings something in line with the latest information. * "Up-to-date" is an adjective phrase that is used as a synonym for "current". Props socalchristina, hareesh-pillai, garrett-eclipse, desrosj, aprea. Fixes #38998. Built from https://develop.svn.wordpress.org/trunk@46096 git-svn-id: http://core.svn.wordpress.org/trunk@45908 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-12 13:06:57 +00:00
desrosj	abed60bb51	Editor: Add missing block data fields for blocks registered server side. In [44122], the `styles` and `parent` block fields were omitted on accident. This change makes it possible to reuse them on the client. Props gziolo. Fixes #47017. Built from https://develop.svn.wordpress.org/trunk@46091 git-svn-id: http://core.svn.wordpress.org/trunk@45903 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-11 14:52:56 +00:00
Sergey Biryukov	dcb08f0637	Docs: Fix placement of some duplicate hook references. Hook documentation should be on the line directly above the line containing the `do_action()` or `apply_filters()` call. The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of duplicate hook references. Includes minor code layout fixes. See #47110. Built from https://develop.svn.wordpress.org/trunk@46088 git-svn-id: http://core.svn.wordpress.org/trunk@45900 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-10 19:23:55 +00:00
Sergey Biryukov	49b4cfc034	Accessibility: Media: Replace `@` with `at` in the displayed date format. The `@` symbol makes sense in the context of email addresses, but does not have a universal meaning in the context of dates. Props audrasjb, afercia. Fixes #47893. Built from https://develop.svn.wordpress.org/trunk@46085 git-svn-id: http://core.svn.wordpress.org/trunk@45897 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-09 00:07:57 +00:00
Sergey Biryukov	86a10090a0	Accessibility: Comments: Replace `@` with `at` in the displayed date format. The `@` symbol makes sense in the context of email addresses, but does not have a universal meaning in the context of dates. Props birgire, afercia, audrasjb, SergeyBiryukov. Fixes #47893. Built from https://develop.svn.wordpress.org/trunk@46084 git-svn-id: http://core.svn.wordpress.org/trunk@45896 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-08 23:53:55 +00:00
Sergey Biryukov	f8ba775d7c	Accessibility: Posts, Post Types: Replace `@` with `at` in the displayed date format. The `@` symbol makes sense in the context of email addresses, but does not have a universal meaning in the context of dates. Props birgire, afercia, audrasjb, SergeyBiryukov. Fixes #47832. Built from https://develop.svn.wordpress.org/trunk@46083 git-svn-id: http://core.svn.wordpress.org/trunk@45895 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-08 23:24:56 +00:00
Andrew Ozz	dc8349ba0a	Media: Add handling for "BIG" images. When the users upload a big image, typically a photo, scale it down to make it suitable for web use. Then use the scaled image as the "full" size, and keep the originally uploaded image for creating high quality sub-sizes in the future and in case the users want to download it later. Introduces `wp_get_original_image_path()` that retrieves the path to the originally uploaded image in all cases, and `big_image_size_threshold` filter to set the pixel value above which images will be scaled. The same value is used as max-width and max-height when scaling. See #47873. Built from https://develop.svn.wordpress.org/trunk@46076 git-svn-id: http://core.svn.wordpress.org/trunk@45888 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-07 01:07:55 +00:00
Sergey Biryukov	699c6001fd	Upgrade/Install: Escape the `%` in `width="100%"` in a `printf()` call in `Plugin_Upgrader_Skin::after()`. Props afragen. Fixes #47989. Built from https://develop.svn.wordpress.org/trunk@46072 git-svn-id: http://core.svn.wordpress.org/trunk@45884 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-06 06:26:56 +00:00
Sergey Biryukov	c1e3b68b19	Docs: Improve documentation for `do_meta_boxes` action. Props felipeelia, killua99, SergeyBiryukov. Fixes #46542. Built from https://develop.svn.wordpress.org/trunk@46071 git-svn-id: http://core.svn.wordpress.org/trunk@45883 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-06 00:06:56 +00:00
Andrea Fercia	17652fb3d4	Widgets: Fix "jumpiness" when reordering widgets by dragging them. Props ketanumretiya030, mukesh27, andraganescu, audrasjb. Fixes #46941. Built from https://develop.svn.wordpress.org/trunk@46028 git-svn-id: http://core.svn.wordpress.org/trunk@45838 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-04 21:49:48 +00:00
whyisjake	90d9bdc54c	Update wp.a11y.speak() to sanitize HTML before display. Props iandunn, adamsilverstein, sstoqnov, peterwilsoncc Built from https://develop.svn.wordpress.org/trunk@45979 git-svn-id: http://core.svn.wordpress.org/trunk@45790 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-04 17:13:21 +00:00
Sergey Biryukov	761cd81a01	Escape the output in `wp_ajax_upload_attachment()`. Props whyisjake, sstoqnov. Built from https://develop.svn.wordpress.org/trunk@45936 git-svn-id: http://core.svn.wordpress.org/trunk@45747 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-04 16:09:56 +00:00
Andrew Ozz	e313498193	Uploads: After an image is uploaded and PHP times out or runs out of memory during post-processing (the server response is HTTP 500 error), try to resize it three more times. Then, if all attempts fail, do a cleanup of any sub-sizes that may have been created and show an error message asking the user to scale the image and upload it again. See #47872. Built from https://develop.svn.wordpress.org/trunk@45934 git-svn-id: http://core.svn.wordpress.org/trunk@45745 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-04 01:11:54 +00:00
Sergey Biryukov	97cbf72bf9	I18N: Fix typo in a function name in [45932]. See #44360. Built from https://develop.svn.wordpress.org/trunk@45933 git-svn-id: http://core.svn.wordpress.org/trunk@45744 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-03 00:57:54 +00:00
Sergey Biryukov	e199663322	I18N: Capitalize translator comments consistently, add trailing punctuation. Includes minor code layout fixes. See #44360. Built from https://develop.svn.wordpress.org/trunk@45932 git-svn-id: http://core.svn.wordpress.org/trunk@45743 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-03 00:41:05 +00:00
Andrea Fercia	fbc9dba70b	Accessibility: Audit usage of abbreviations. Title attributes on abbreviations are only available to a minority of users. The best option is to avoid unnecessary abbreviations when possible. In the other cases, use an `<abbr>` element (which provides a hint to user agents on how to announce and display the abbreviation) and provide an expansion in plain text on first use. - `readme.html`: improves abbreviations and removes unnecessary `title` attributes - options-general: removes unnecessary abbreviations and improves the remaining ones - customizer schedule changeset date: removes unnecessary abbreviations and improves the remaining ones - posts table date: uses a `span` element instead of an `abbr` element because this is not an abbreviation Fixes #46980. Built from https://develop.svn.wordpress.org/trunk@45930 git-svn-id: http://core.svn.wordpress.org/trunk@45741 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-02 21:44:58 +00:00
Sergey Biryukov	8662d9a74d	I18N: Split translatable strings located on the same line preceded with a translator comment, where the first string needs that comment, but the second does not. Props johnbillion. See #44360. Built from https://develop.svn.wordpress.org/trunk@45927 git-svn-id: http://core.svn.wordpress.org/trunk@45738 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-02 00:43:55 +00:00
Sergey Biryukov	16b8d91baa	I18N: Improve translator comments. * Add missing translator comments. * Fix placement of some translator comments. Translator comments should be on the line directly above the line containing the translation function call for optimal compatibility with various `.pot` file generation tools. The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of translator comments. Includes minor code layout fixes. Polyglots, rejoice! All WordPress core files now have translator comments for all strings with placeholders! Props jrf, subrataemfluence, GaryJ, webdados, Dency, swissspidy, alvarogois, marcomartins, mihaiiceyro, vladwtz, niq1982, flipkeijzer, michielatyoast, chandrapatel, thrijith, joshuanoyce, FesoVik, tessak22, bhaktirajdev, cleancoded, dhavalkasvala, garrett-eclipse, bibliofille, socalchristina, priyankkpatel, 5hel2l2y, adamsilverstein, JeffPaul, pierlo, SergeyBiryukov. Fixes #44360. Built from https://develop.svn.wordpress.org/trunk@45926 git-svn-id: http://core.svn.wordpress.org/trunk@45737 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-01 17:13:59 +00:00
Sergey Biryukov	ffcb1d0d99	Comments: In AJAX response when deleting a comment, account for ` ` as a thousands separator in `total_items_i18n` and `total_pages_i18n` numbers. Props denisco, SergeyBiryukov. Fixes #47953. Built from https://develop.svn.wordpress.org/trunk@45918 git-svn-id: http://core.svn.wordpress.org/trunk@45729 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-30 18:34:06 +00:00
Sergey Biryukov	d26191eb03	Docs: Simplify `get_plugin_data()` and `get_file_data()` description. See #47110. Built from https://develop.svn.wordpress.org/trunk@45917 git-svn-id: http://core.svn.wordpress.org/trunk@45728 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-30 16:57:56 +00:00
Sergey Biryukov	3f048f5ace	Docs: Update plugin headers example in `get_plugin_data()` to clarify that `Version` is not a required field. Props casiepa. See #47110, #meta4707. Built from https://develop.svn.wordpress.org/trunk@45916 git-svn-id: http://core.svn.wordpress.org/trunk@45727 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-30 16:16:57 +00:00
John Blackbourn	640c90d35d	Docs: Correct and improve inline docs relating to caching, terms, meta, and some misc tweaks. See #47110 Built from https://develop.svn.wordpress.org/trunk@45915 git-svn-id: http://core.svn.wordpress.org/trunk@45726 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-30 11:36:08 +00:00
Sergey Biryukov	3965d4735c	I18N: Add missing translator comment in help text on Reading Settings screen. Props garrett-eclipse. See #46708. Built from https://develop.svn.wordpress.org/trunk@45913 git-svn-id: http://core.svn.wordpress.org/trunk@45724 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-29 21:36:55 +00:00
Sergey Biryukov	7caac01470	Administration: Add a note to "For each post in a feed, include [Full text / Summary]" option that how content is displayed in browsers depends on the theme. Add a documentation link to learn more about feeds. Props JarretC, SergeyBiryukov, pento, talldanwp, dinhtungdu, noisysocks, tobifjellner. Fixes #46708. Built from https://develop.svn.wordpress.org/trunk@45912 git-svn-id: http://core.svn.wordpress.org/trunk@45723 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-29 21:25:55 +00:00
Felix Arntz	90c424f73b	Multisite: Improve performance by caching not found lookups for sites and networks. With this change, the result of a site or network lookup by ID will be cached even if the ID does not exist. When a new site or network is created, the cache for the respective new ID is cleared. Props mnelson4, nielsdeblaauw. Fixes #42251. Built from https://develop.svn.wordpress.org/trunk@45910 git-svn-id: http://core.svn.wordpress.org/trunk@45721 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-29 12:42:56 +00:00
Mike Schroder	ccdc221b32	Administration: Output valid HTML when `wp_die()` is called. To better support HTML and string calls to `wp_die()` without outputting invalid HTML, wraps error messages in `<div>` rather than `<p>`. Adds `.wp-die-message` CSS class for styling. Props dinhtungdu, jeremyfelt, audrasjb, SergeyBiryukov, afercia, audrasjb, noisysocks. Fixes #47580. Built from https://develop.svn.wordpress.org/trunk@45909 git-svn-id: http://core.svn.wordpress.org/trunk@45720 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-29 07:54:01 +00:00
Sergey Biryukov	27a384caa4	Site Health: Merge two similar strings explaining what drop-in plugins are. Props garrett-eclipse, ramiy, Clorith. Fixes #47247. Built from https://develop.svn.wordpress.org/trunk@45905 git-svn-id: http://core.svn.wordpress.org/trunk@45716 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-28 03:13:55 +00:00
Sergey Biryukov	6cad27efcd	Site Health: Standardize on `SELECT VERSION()` query for checking the database server version, due to the MariaDB version declaration potentially causing issues in production environments. Partially reverts [45691]. Props Clorith. Fixes #47738. Built from https://develop.svn.wordpress.org/trunk@45904 git-svn-id: http://core.svn.wordpress.org/trunk@45715 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-28 03:09:52 +00:00
Sergey Biryukov	b1847ef3e2	Menus: In `wp_setup_nav_menu_item()` and `Walker_Nav_Menu_Edit::start_el()`, check if the post or term associated with the menu item still exists to avoid a PHP notice. If the associated post or term no longer exists, mark the menu item as invalid. Props mehulkaklotar, kamrankhorsandi, cristiano.zanca, SergeyBiryukov. Fixes #31703. Built from https://develop.svn.wordpress.org/trunk@45891 git-svn-id: http://core.svn.wordpress.org/trunk@45702 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-25 21:32:59 +00:00
Sergey Biryukov	fe0b22cd67	Users: Adjust [45806] to make sure `$all_userids` is always defined. Props kbrownkd. Fixes #47936. Built from https://develop.svn.wordpress.org/trunk@45890 git-svn-id: http://core.svn.wordpress.org/trunk@45701 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-25 20:03:57 +00:00
Sergey Biryukov	c896a0911e	Site Health: Add timezone to Site Health Info page. Props justinahinon, sharaz, artisticasad, Rarst. Fixes #47842. Built from https://develop.svn.wordpress.org/trunk@45889 git-svn-id: http://core.svn.wordpress.org/trunk@45700 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-24 19:37:57 +00:00
Sergey Biryukov	1aaf11947e	Date/Time: Simplify the date comparing logic in `WP_Community_Events::trim_events()`. The Events API returns event date without timezone information, so trying to parse it into a timestamp and compare to a WP timestamp is pointless. Props Rarst. Fixes #47463. Built from https://develop.svn.wordpress.org/trunk@45886 git-svn-id: http://core.svn.wordpress.org/trunk@45697 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-23 02:15:55 +00:00
Sergey Biryukov	6e555f0c77	Date/Time: Introduce `current_datetime()` for better time operations. Returning a `DateTimeImmutable` representation of the current moment in time, this allows for a more flexible and reliable use than `current_time()` provides. Props Rarst. Fixes #47464. Built from https://develop.svn.wordpress.org/trunk@45883 git-svn-id: http://core.svn.wordpress.org/trunk@45694 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-23 01:12:55 +00:00
desrosj	e7c8b21e71	Coding Standards: Dynamic hooks should be named using interpolation not concatenation. Props arena, desrosj. Fixes #47052. Built from https://develop.svn.wordpress.org/trunk@45881 git-svn-id: http://core.svn.wordpress.org/trunk@45692 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-22 19:08:55 +00:00
Sergey Biryukov	f6fc8025c4	Administration: Adjust [45814] to address a backward compatibility issue for plugins passing multiple CSS classes to `add_settings_error()`. Only add the `notice-` prefix for `error`, `success`, `warning`, `info` CSS classes, keep other classes as is. Add unit tests for `settings_errors()`. Props afercia, SergeyBiryukov. Fixes #44941. Built from https://develop.svn.wordpress.org/trunk@45873 git-svn-id: http://core.svn.wordpress.org/trunk@45684 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-22 00:22:56 +00:00
Sergey Biryukov	3d12c4b6d8	Docs: Fix typo in `_wp_make_subsizes()` DocBlock. Props itowhid06. Fixes #47913. See #40439. Built from https://develop.svn.wordpress.org/trunk@45871 git-svn-id: http://core.svn.wordpress.org/trunk@45682 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-21 16:23:56 +00:00
Sergey Biryukov	f8fb93cd0d	Customizer: Trim whitespace from custom link URLs. This complements a similar fix for the Menus screen in [45655]. Props donmhico, audrasjb. Fixes #47888. See #47723. Built from https://develop.svn.wordpress.org/trunk@45869 git-svn-id: http://core.svn.wordpress.org/trunk@45680 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-21 00:27:57 +00:00
Sergey Biryukov	d9954ed4cb	Privacy: Add descriptions for sections in a personal data export file. Props garrett-eclipse, Venutius, karmatosed. Fixes #45491. Built from https://develop.svn.wordpress.org/trunk@45825 git-svn-id: http://core.svn.wordpress.org/trunk@45636 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-18 02:07:57 +00:00
Sergey Biryukov	53f5b172ab	Plugins: Adjust margin for plugin headings on "Add Plugins" screen to avoid overlapping with "Network Activate" button. Props justinahinon, chetan200891. Fixes #47600. Built from https://develop.svn.wordpress.org/trunk@45824 git-svn-id: http://core.svn.wordpress.org/trunk@45635 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-17 14:33:56 +00:00
Sergey Biryukov	be6bbe4b5d	Administration: Replace legacy `updated` message type in `add_settings_error()` calls with `success`. See #44640. Built from https://develop.svn.wordpress.org/trunk@45818 git-svn-id: http://core.svn.wordpress.org/trunk@45629 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-16 00:39:55 +00:00
Sergey Biryukov	e5deae5e78	Administration: In `add_settings_error()`, add `warning` and `info` as possible values for message type. Account for these new values in `settings_errors()`, resulting in `notice-warning` and `notice-info` CSS classes. Map legacy `error` and `updated` CSS classes to `notice-error` and `notice-success`. Props donmhico, toddhalfpenny, flixos90, desrosj, javorszky, SergeyBiryukov. Fixes #44640, #44941. Built from https://develop.svn.wordpress.org/trunk@45814 git-svn-id: http://core.svn.wordpress.org/trunk@45625 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-15 23:01:55 +00:00
Sergey Biryukov	ab0b860db9	Users: When deleting users, exclude the current user from the content existence check. The current user cannot be deleted, so the check is redundant in that context and should only be done for other users. Props mt8.biz, SergeyBiryukov. Fixes #47851. Built from https://develop.svn.wordpress.org/trunk@45806 git-svn-id: http://core.svn.wordpress.org/trunk@45617 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-15 13:06:55 +00:00
Gary Pendergast	7169586254	Schema: Add an index to `wp_options.autoload`. Most sites will be unaffected by this change, but those with a large number of rows in `wp_options`, only a small number of which have `autoload` set, will see a significant performance improvement. Sites with a large number of rows in `wp_options`, with many of them having `autoload` set will unfortunately see a performance penalty on top of the already very slow queries they're running, but this should be the minority of cases. Props DanBUK. Fixes #24044. Built from https://develop.svn.wordpress.org/trunk@45805 git-svn-id: http://core.svn.wordpress.org/trunk@45616 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-15 07:13:55 +00:00
Sergey Biryukov	98ffc642a9	Networks and Sites: Trim site domain when creating a new site on Add New Site screen before further validation. Props dharmin16, jeremyfelt, aubreypwd. Fixes #44808. Built from https://develop.svn.wordpress.org/trunk@45804 git-svn-id: http://core.svn.wordpress.org/trunk@45615 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-15 01:21:55 +00:00
Sergey Biryukov	d85ba82d8e	Docs: Add missing `@since` tag for `WP_Site_Health::has_late_cron()`. See #47223. Built from https://develop.svn.wordpress.org/trunk@45803 git-svn-id: http://core.svn.wordpress.org/trunk@45614 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-15 00:42:55 +00:00
Peter Wilson	a56256d158	Site Health Check: Increase time allowance for cron checks. Introduces `WP_Site_Health::has_late_cron()` for late wp-cron jobs and extends the time allowance before a job is considered missed. In a standard configuration using loopback requests, a job is considered late once past due and missed over five minutes past due. Late and missed time frames are extended if `DISABLE_WP_CRON` is defined as `true` to allow for crontab tasks running less frequently. A job is considered late once it's 15 minutes past due and missed over one hour past due. A file for site health unit tests has been introduced with tests for cron in critical, late and missed states. Props rockfire, afragen, peterwilsoncc. Fixes #47223. Built from https://develop.svn.wordpress.org/trunk@45801 git-svn-id: http://core.svn.wordpress.org/trunk@45612 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-15 00:35:55 +00:00
Sergey Biryukov	428a738f1d	Plugins: Adjust the pause before running plugin search AJAX request on "Add Plugins" screen to allow more time for using browser's autocomplete. Props donmhico, apermo. Fixes #46021. Built from https://develop.svn.wordpress.org/trunk@45793 git-svn-id: http://core.svn.wordpress.org/trunk@45604 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-14 02:02:56 +00:00
Sergey Biryukov	4cf729f5a9	Site Health: Simplify the language in Status Health Info page introduction, add a link to Status page. Props birgire, mukesh27, subrataemfluence, leogermani. Fixes #46946. Built from https://develop.svn.wordpress.org/trunk@45791 git-svn-id: http://core.svn.wordpress.org/trunk@45602 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-13 23:35:56 +00:00
Andrew Ozz	400ed5add0	Remove trailing white space in upgrade.php. See #46349. Built from https://develop.svn.wordpress.org/trunk@45789 git-svn-id: http://core.svn.wordpress.org/trunk@45600 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-13 19:53:55 +00:00
Andrew Ozz	197b4a829b	Admin email verification: - Add the `admin_email_lifespan` option when installing. Fixes a bug where the verification screen is shown right after installation. - Reset the same option when upgrading and the user doing the DB upgrade is not an admin. This will ensure the email verification is shown next time an admin logs in. - Use `site_url()` instead of `network_site_url()` for the form action. The latter seems needed only for password reset. See #46349. Built from https://develop.svn.wordpress.org/trunk@45788 git-svn-id: http://core.svn.wordpress.org/trunk@45599 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-13 17:40:55 +00:00
Sergey Biryukov	99f4ff2578	Site Health: Add database charset and collation information to debug info. Props sharaz, Clorith, SergeyBiryukov. Fixes #47828. Built from https://develop.svn.wordpress.org/trunk@45782 git-svn-id: http://core.svn.wordpress.org/trunk@45593 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-12 01:54:57 +00:00
Sergey Biryukov	6041a08347	Bootstrap/Load: Change "Insufficient Requirements" `wp_die()` heading to "Requirements Not Met", which is more appropriate for the context it's used in. Props yoavf. Fixes #47575. Built from https://develop.svn.wordpress.org/trunk@45770 git-svn-id: http://core.svn.wordpress.org/trunk@45581 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-08 12:54:56 +00:00
Sergey Biryukov	c965d2e097	Administration: Show a warning in Reading Settings when a Privacy Policy page is accidentally set as a Homepage or Posts page. Props garrett-eclipse, subrataemfluence. Fixes #46831. Built from https://develop.svn.wordpress.org/trunk@45766 git-svn-id: http://core.svn.wordpress.org/trunk@45577 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-07 23:03:54 +00:00
Sergey Biryukov	32afb6f7c7	Coding Standards: Use strict comparison in `wp-admin/edit.php`. Props davidbaumwald. Fixes #47201. Built from https://develop.svn.wordpress.org/trunk@45759 git-svn-id: http://core.svn.wordpress.org/trunk@45570 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-07 11:40:55 +00:00
Andrew Ozz	52c53ae6f8	Remove trailing white space in upgrade.php after [45757]. See #46349. Built from https://develop.svn.wordpress.org/trunk@45758 git-svn-id: http://core.svn.wordpress.org/trunk@45569 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-07 01:01:57 +00:00
Andrew Ozz	fff56d219f	Add admin email verification screen. Shown every six months after an admin has logged in. Also includes WPCS fixes for wp-login.php. Props andraganescu, boemedia, lessbloat, azaozz. See #46349. Built from https://develop.svn.wordpress.org/trunk@45757 git-svn-id: http://core.svn.wordpress.org/trunk@45568 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-07 00:04:56 +00:00
Sergey Biryukov	e081194455	Administration: Correct "Quick Edit" link height in list tables for consistency with other action links. Props jobthomas, burhandodhy. Fixes #47815. Built from https://develop.svn.wordpress.org/trunk@45756 git-svn-id: http://core.svn.wordpress.org/trunk@45567 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-05 22:20:58 +00:00
Sergey Biryukov	2ac34c799b	Coding Standards: Use strict comparison in `wp-admin/options-reading.php`. Props subrataemfluence. Fixes #46834. Built from https://develop.svn.wordpress.org/trunk@45752 git-svn-id: http://core.svn.wordpress.org/trunk@45563 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-05 12:52:56 +00:00
Sergey Biryukov	ad9d8c7d58	Plugins: Use `include_once` for `wp-admin/includes/plugin-install.php` in `WP_Plugin_Install_List_Table::prepare_items()`. This brings consistency with the other instances where the file is included, and allows for reusing its functions in custom code. Props engelen, desrosj. Fixes #38874. Built from https://develop.svn.wordpress.org/trunk@45751 git-svn-id: http://core.svn.wordpress.org/trunk@45562 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-05 11:07:55 +00:00
Sergey Biryukov	c1a252da8e	Site Health: Use correct variable when checking PHP requirements for a plugin update in `WP_Plugins_List_Table::single_row()`. Props diddledan, sharaz, vaishalipanchal. Fixes #47835. Built from https://develop.svn.wordpress.org/trunk@45750 git-svn-id: http://core.svn.wordpress.org/trunk@45561 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-05 10:58:56 +00:00
Sergey Biryukov	f7b8423b12	Upgrade/Install: Make sure `translate_level_to_role()` always returns a value. Props diddledan. Fixes #46848. Built from https://develop.svn.wordpress.org/trunk@45747 git-svn-id: http://core.svn.wordpress.org/trunk@45558 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-05 07:48:58 +00:00
Sergey Biryukov	e8cd892ba4	Administration: Display a warning at the top of "All Settings" screen. Props zodiac1978, donmhico, pixolin. Fixes #47718. Built from https://develop.svn.wordpress.org/trunk@45743 git-svn-id: http://core.svn.wordpress.org/trunk@45554 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-04 13:03:55 +00:00
Sergey Biryukov	9967a3e030	Docs: Add missing description for `$post` global. Props immeet94. Fixes #46503. See #47110. Built from https://develop.svn.wordpress.org/trunk@45742 git-svn-id: http://core.svn.wordpress.org/trunk@45553 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-04 12:28:56 +00:00
Sergey Biryukov	6da93732e7	Docs: Add missing description for `$current_screen` global. Props mukesh27. Fixes #45604. See #47110. Built from https://develop.svn.wordpress.org/trunk@45740 git-svn-id: http://core.svn.wordpress.org/trunk@45551 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-04 02:03:55 +00:00
Sergey Biryukov	7f7480cb2a	Docs: Add missing description for `$wp_query` and `$wp_the_query` globals. Props mukesh27. See #45604, #47110. Built from https://develop.svn.wordpress.org/trunk@45739 git-svn-id: http://core.svn.wordpress.org/trunk@45550 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-04 01:59:56 +00:00
Sergey Biryukov	e0311b76c7	Docs: Add missing description for `$wp_locale` global. Props mukesh27. See #45604, #47110. Built from https://develop.svn.wordpress.org/trunk@45737 git-svn-id: http://core.svn.wordpress.org/trunk@45548 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-04 01:46:55 +00:00
Sergey Biryukov	b1e34ccc1f	Docs: Add missing description for `$wp_rewrite` global. See #45604, #47110. Built from https://develop.svn.wordpress.org/trunk@45735 git-svn-id: http://core.svn.wordpress.org/trunk@45546 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-04 01:19:56 +00:00
Sergey Biryukov	29b072e706	Docs: Add missing description for `$wpdb`, `$wp_db_version`, and `$wp_current_db_version` globals. Props mukesh27, utsav72640, immeet94, SergeyBiryukov. See #45604. Built from https://develop.svn.wordpress.org/trunk@45734 git-svn-id: http://core.svn.wordpress.org/trunk@45545 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-04 01:12:56 +00:00
Sergey Biryukov	702ee129ad	Docs: Fix typo in a comment in `WP_Site_Health::get_test_theme_version()`. See #47110. Built from https://develop.svn.wordpress.org/trunk@45733 git-svn-id: http://core.svn.wordpress.org/trunk@45544 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-04 00:48:56 +00:00
Sergey Biryukov	fd83290995	Site Health: If `WP_DEFAULT_THEME` doesn't exist, use `WP_Theme::get_core_default_theme()` as a fallback. Props ajayghaghretiya1, juliobox, SergeyBiryukov. Fixes #47299. Built from https://develop.svn.wordpress.org/trunk@45732 git-svn-id: http://core.svn.wordpress.org/trunk@45543 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-04 00:02:55 +00:00
Sergey Biryukov	7dbc4d28e5	Script Loader: Send a 400 Bad Request status code in `load-scripts.php` and `load-styles.php` if the required `load[]` parameter is not set. Props compilenix. Fixes #44108. Built from https://develop.svn.wordpress.org/trunk@45731 git-svn-id: http://core.svn.wordpress.org/trunk@45542 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-03 22:17:57 +00:00
Aaron Jorbin	c377191858	PHP 7.4 compatibility fix / accessing arrays/string using curly brace syntax PHP used to allow both square brackets and curly braces to be used interchangeably for accessing array elements and string offsets. The curly bracket syntax is only allowed in a limited set of cases and can be confusing for people not used to it. PHP 7.4 will deprecate the curly brace syntax for accessing array elements and string offsets and it is expected that support will be completely removed in PHP 8.0. Ref: https://wiki.php.net/rfc/deprecate_curly_braces_array_access See #47751. Props jrf. Built from https://develop.svn.wordpress.org/trunk@45730 git-svn-id: http://core.svn.wordpress.org/trunk@45541 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-03 20:21:55 +00:00
Andrea Fercia	b853e21bf9	Accessibility: Improve the differences between revisions. Color alone is not sufficient to visually communicate differences. - adds `plus` and `minus` icons to the changed lines - adds visually hidden text: `Added`, `Deleted`, and `Unchanged` to clarify the differences to assistive technologies users Props birgire, audrasjb, kjellr, adamsilverstein. Fixes #43532. Built from https://develop.svn.wordpress.org/trunk@45729 git-svn-id: http://core.svn.wordpress.org/trunk@45540 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-03 15:46:54 +00:00
Andrea Fercia	7b45746001	Menus: Fix the Custom Links text fallback. When adding a Custom Link and leaving the "Link Text" field empty, WordPress used to set a default fallback text: "Menu Item". The changes in [36379] broke this behavior making the fallback text: ` (Pending)`, with a leading space. Pending major refactoring of the Menus page (which is going to use a block-based user interface) this change just restores the original behavior by adding the fallback text to the related AJAX response. Props christophherr, Fencer04, thakkarhardik, backermann1978, audrasjb. Fixes #38415. Built from https://develop.svn.wordpress.org/trunk@45727 git-svn-id: http://core.svn.wordpress.org/trunk@45538 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-03 12:19:56 +00:00
Sergey Biryukov	c26f1c5d90	Taxonomy: Fix deprecated calls to `get_terms()`. The taxonomy should be passed as part of `$args`, rather than as its own argument. Props sgastard, mukesh27, SergeyBiryukov. Fixes #47819. Built from https://develop.svn.wordpress.org/trunk@45723 git-svn-id: http://core.svn.wordpress.org/trunk@45534 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-03 03:35:56 +00:00
Andrea Fercia	60431f3c53	Customize: Make the color picker close when clicking on the empty area on the right. Props monikarao. Fixes #47693. Built from https://develop.svn.wordpress.org/trunk@45722 git-svn-id: http://core.svn.wordpress.org/trunk@45533 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-02 17:09:57 +00:00
Sergey Biryukov	b32cff72c2	Users: Deprecate `update_user_status()` in favor of `wp_update_user()`. Props spacedmonkey, SergeyBiryukov. Fixes #45747. Built from https://develop.svn.wordpress.org/trunk@45708 git-svn-id: http://core.svn.wordpress.org/trunk@45519 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-08-01 11:28:54 +00:00
Sergey Biryukov	ee23869c68	Docs: Correct parameter documentation for `bulk_edit_custom_box` and `quick_edit_custom_box` actions. Props abrain. Fixes #47810. Built from https://develop.svn.wordpress.org/trunk@45704 git-svn-id: http://core.svn.wordpress.org/trunk@45515 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-31 15:10:58 +00:00
Tammie Lister	fa9980049e	Admin: Improve Dashboard icon contrast. The icons used across the dashboard had too low contrast to pass AA WCAG guidelines. They’re now slightly darker for better contrast. Props @melchoyce, @SergeyBiryukov, @chetan200891 , @kjellr Fixes #46935 Built from https://develop.svn.wordpress.org/trunk@45700 git-svn-id: http://core.svn.wordpress.org/trunk@45511 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-30 22:54:57 +00:00
Sergey Biryukov	98642b4821	Users: Use case-insensitive email address comparison when checking whether "Grant this user super admin privileges" checkbox should be displayed on Edit User screen. Props trepmal. Fixes #47119. Built from https://develop.svn.wordpress.org/trunk@45698 git-svn-id: http://core.svn.wordpress.org/trunk@45509 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-28 17:42:55 +00:00
Sergey Biryukov	ec8940edeb	Coding Standards: Fix WPCS violations in `wp-admin/includes/class-walker-nav-menu-edit.php`. Props sudhiryadav, audrasjb. Fixes #46902. Built from https://develop.svn.wordpress.org/trunk@45697 git-svn-id: http://core.svn.wordpress.org/trunk@45508 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-28 16:53:52 +00:00
Sergey Biryukov	c9942bb3d8	Coding Standards: Fix WPCS violations in [45694]. See #47466. Built from https://develop.svn.wordpress.org/trunk@45696 git-svn-id: http://core.svn.wordpress.org/trunk@45507 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-28 16:52:56 +00:00
Sergey Biryukov	e7abdc7040	Docs: Improve the DocBlocks for `got_mod_rewrite()`, `extract_from_markers()`, `insert_with_markers()`. See #47110. Built from https://develop.svn.wordpress.org/trunk@45695 git-svn-id: http://core.svn.wordpress.org/trunk@45506 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-28 16:35:56 +00:00
Sergey Biryukov	67e5038470	Rewrite Rules: Add a comment to `# BEGIN/END` `.htaccess` markers to clarify that the directives are dynamically generated, and should only be modified via WordPress filters. Introduce `insert_with_markers_inline_instructions` filter to modify the default instructions text. Props bradleyt, SergeyBiryukov. Fixes #47466. Built from https://develop.svn.wordpress.org/trunk@45694 git-svn-id: http://core.svn.wordpress.org/trunk@45505 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-28 16:31:57 +00:00
Sergey Biryukov	7a4d1b5dbd	Permalinks: Improve appearance of URL examples on Permalink Settings screen. Props luan-ramos, sarath.ar. Fixes #41559. Built from https://develop.svn.wordpress.org/trunk@45693 git-svn-id: http://core.svn.wordpress.org/trunk@45504 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-28 16:11:56 +00:00
Sergey Biryukov	b95b055225	Administration: Allow breaking long strings in `<code>` tags at any point, to avoid overflowing on mobile. Props david.binda, mukesh27. Fixes #47329. Built from https://develop.svn.wordpress.org/trunk@45692 git-svn-id: http://core.svn.wordpress.org/trunk@45503 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-28 16:09:55 +00:00
Sergey Biryukov	a59301c2ba	Site Health: Consistently use `wpdb::db_version()` for checking the database server version, instead of partically replicating its functionality. Props Clorith, wpfed. Fixes #47738. Built from https://develop.svn.wordpress.org/trunk@45691 git-svn-id: http://core.svn.wordpress.org/trunk@45502 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-28 14:55:57 +00:00
Sergey Biryukov	f933abef11	Accessibility: Taxonomy: When a new category or tag is being added, show a spinner and noop the button to avoid multiple requests. Props andg, afercia, guddu1315, SergeyBiryukov. Fixes #47607. Built from https://develop.svn.wordpress.org/trunk@45683 git-svn-id: http://core.svn.wordpress.org/trunk@45494 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-26 17:46:56 +00:00
Sergey Biryukov	5cdbe22b16	Administration: Merge CSS rules for `#adminmenu .wp-submenu a` in one place. Props ozmatflc, AkSDvP. Fixes #47780. Built from https://develop.svn.wordpress.org/trunk@45682 git-svn-id: http://core.svn.wordpress.org/trunk@45493 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-26 13:49:57 +00:00
Sergey Biryukov	e925997562	Site Health: Show parent theme in its own accordion on Site Health Info screen; rename "Other Themes" to "Inactive Themes". Props garrett-eclipse, mukesh27, Clorith, xkon, msaggiorato. Fixes #46925. Built from https://develop.svn.wordpress.org/trunk@45680 git-svn-id: http://core.svn.wordpress.org/trunk@45491 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-26 03:49:55 +00:00
Sergey Biryukov	a186dbcb65	I18N: Update translator comments after [45674]. See #47771. Built from https://develop.svn.wordpress.org/trunk@45676 git-svn-id: http://core.svn.wordpress.org/trunk@45487 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-25 22:52:56 +00:00
Sergey Biryukov	8e85299a00	General: First pass at replacing Codex URLs with a corresponding HelpHub or DevHub article. Props ianbelanger, tobifjellner, SergeyBiryukov. See #47771. Built from https://develop.svn.wordpress.org/trunk@45674 git-svn-id: http://core.svn.wordpress.org/trunk@45485 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-25 22:45:57 +00:00
Sergey Biryukov	ccba6c4aec	Upgrade/Install: Bring some consistency to installation screen styles. * Include `forms.css` and `l10n.css`, for consistency with login screen and other admin screens. * Remove redundant `@import` directives from `login.css` for files already declared as dependencies. * Adjust margin on password strength meter for consistency with other fields. * Increase font size for "You will need this password to log in" notice. * Fix misaligned icon on "Hide" button for the password. Props iseulde, dan@micamedia.com, bassgang, cdog, johnbillion, nmenescardi, mukesh27, SergeyBiryukov. Fixes #35776, #47757, #47758. Built from https://develop.svn.wordpress.org/trunk@45673 git-svn-id: http://core.svn.wordpress.org/trunk@45484 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-25 19:11:55 +00:00
Sergey Biryukov	316fa4aecb	Code Editor: Check for correct `mode` value in `wp.codeEditor.initialize` to enable autocomplete support for PHP. Props ediamin. Fixes #47769. Built from https://develop.svn.wordpress.org/trunk@45670 git-svn-id: http://core.svn.wordpress.org/trunk@45481 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-25 01:27:57 +00:00
Sergey Biryukov	aee690fd84	Permalinks: Update URLs for "Changing File Permissions" documentation article. Props patilswapnilv, ianbelanger, SergeyBiryukov. Fixes #47768. Built from https://develop.svn.wordpress.org/trunk@45669 git-svn-id: http://core.svn.wordpress.org/trunk@45480 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-25 01:18:55 +00:00
Sergey Biryukov	18bd01985b	Coding Standards: Rename `$r` variable used with `wp_parse_args()` to `$parsed_args` for clarity. Props freewebmentor. Fixes #45059. Built from https://develop.svn.wordpress.org/trunk@45667 git-svn-id: http://core.svn.wordpress.org/trunk@45478 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-25 00:48:58 +00:00
Gary Pendergast	971814047f	Coding Standards: Move wp-admin/custom-background.php to wp-admin/includes/class-custom-background.php This renames the file containing the Custom_Background class to conform to the coding standards. This commit also includes: - A new custom-background.php that includes the new file, for anyone that may've been including the file directly. - Replaces a reference to the old filename with the new filename. See #47632. Built from https://develop.svn.wordpress.org/trunk@45662 git-svn-id: http://core.svn.wordpress.org/trunk@45473 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-19 04:02:55 +00:00
Gary Pendergast	1f5fcff132	Coding Standards: Improve spacing of `printf()` calls in the admin About pages. Props garrett-eclipse. Fixes #47734. Built from https://develop.svn.wordpress.org/trunk@45660 git-svn-id: http://core.svn.wordpress.org/trunk@45471 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-19 00:09:58 +00:00
Sergey Biryukov	1c331e8931	I18N: Make URLs to `https://wordpress.org/about/` and related pages translatable, as they can now be localized on Rosetta sites. Props mukesh27. Fixes #46386. Built from https://develop.svn.wordpress.org/trunk@45659 git-svn-id: http://core.svn.wordpress.org/trunk@45470 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-18 12:41:57 +00:00
Gary Pendergast	22412b1d97	Customizer: Show all widgets when the search field is cleared. When clicking the clear button on the widget search field, the search results should refresh to show all widgets. Props Mahesh901122. Fixes #47534. Built from https://develop.svn.wordpress.org/trunk@45658 git-svn-id: http://core.svn.wordpress.org/trunk@45469 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-18 05:55:59 +00:00
Sergey Biryukov	7149d65934	Editor: Replace external Classic Editor plugin URL with a link to Add Plugins screen with Classic Editor pre-selected. This applies to messages displayed when JavaScript is disabled in Block Editor, or an incompatible meta box is used. Props garrett-eclipse, derweili, afercia. Fixes #47487. Built from https://develop.svn.wordpress.org/trunk@45657 git-svn-id: http://core.svn.wordpress.org/trunk@45468 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-18 01:33:57 +00:00
Gary Pendergast	24d08a9463	Coding Standards: Move `wp-admin/custom-header.php` to `wp-admin/includes/class-custom-image-header.php` This renames the file containing the `Custom_Image_Header` class to conform to the coding standards. This commit also includes: - A new `custom-header.php` that includes the new file, for anyone that may've been including the file directly. - Replaces references to the old filename with the new filename. See #47632. Built from https://develop.svn.wordpress.org/trunk@45654 git-svn-id: http://core.svn.wordpress.org/trunk@45465 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-17 06:17:56 +00:00
Sergey Biryukov	1f256f3fdc	Administration: In `admin-ajax.php`, send `X-Robots-Tag` header earlier, so that it applies before `wp_die()` when no action parameter was provided. Props robi-bobi, harryfear, garrett-eclipse. Fixes #47711. Built from https://develop.svn.wordpress.org/trunk@45650 git-svn-id: http://core.svn.wordpress.org/trunk@45461 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-17 01:11:56 +00:00
Sergey Biryukov	66afb60397	Site Health: Use consistent verbiage for "Learn more" links. Props ronakganatra, garrett-eclipse. Fixes #47302. Built from https://develop.svn.wordpress.org/trunk@45649 git-svn-id: http://core.svn.wordpress.org/trunk@45460 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-16 22:28:57 +00:00
Sergey Biryukov	f600647e22	Site Health: Replace "harddrive" with "device" on Site Health Info screen. Props chetan200891, timhavinga, Cybr, Clorith. Fixes #46965. Built from https://develop.svn.wordpress.org/trunk@45648 git-svn-id: http://core.svn.wordpress.org/trunk@45459 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-16 22:19:55 +00:00
Sergey Biryukov	e5ad773194	I18N: Merge duplicate "Your plugins/themes/translations are all up to date" strings. Props ramiy. Fixes #47252. Built from https://develop.svn.wordpress.org/trunk@45647 git-svn-id: http://core.svn.wordpress.org/trunk@45458 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-16 22:13:58 +00:00
Andrew Ozz	5eba5381e6	Media: Sort the new sizes array by priority when creating image sub-sizes. See #40439. Built from https://develop.svn.wordpress.org/trunk@45645 git-svn-id: http://core.svn.wordpress.org/trunk@45456 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-16 21:48:56 +00:00
Sergey Biryukov	62216de5d4	Docs: Move the `do_mu_upgrade` DocBlock out of the preceding `if` statement. Props ChriCo, dkarfa. Fixes #47710. Built from https://develop.svn.wordpress.org/trunk@45643 git-svn-id: http://core.svn.wordpress.org/trunk@45454 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-16 13:15:58 +00:00
Sergey Biryukov	62dc808103	Docs: Correct `@since` tag for `do_mu_upgrade` hook, for consistency with `after_mu_upgrade` and `wpmu_upgrade_site`. See #47110. Built from https://develop.svn.wordpress.org/trunk@45642 git-svn-id: http://core.svn.wordpress.org/trunk@45453 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-16 12:42:59 +00:00
Sergey Biryukov	83d175cdd0	I18N: Add context for theme filter strings in `WP_MS_Themes_List_Table::get_views()`. Props audrasjb. Fixes #47695. Built from https://develop.svn.wordpress.org/trunk@45634 git-svn-id: http://core.svn.wordpress.org/trunk@45445 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-14 14:47:56 +00:00
Sergey Biryukov	436a9512e2	Upgrade/Install: Remove debugging artifacts from `wp-admin/upgrade.php` added in [1229]. Props rahulvaza. Fixes #47074. Built from https://develop.svn.wordpress.org/trunk@45633 git-svn-id: http://core.svn.wordpress.org/trunk@45444 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-14 14:39:57 +00:00
Sergey Biryukov	02c07f23d5	Customize: Fix text direction for color picker in RTL. Props vjik for the report. Fixes #47688. See #23740. Built from https://develop.svn.wordpress.org/trunk@45626 git-svn-id: http://core.svn.wordpress.org/trunk@45437 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-12 00:05:57 +00:00
Gary Pendergast	bb8afb46b9	Block Editor: Avoid a PHP warning when a theme adds an editor style with an empty filename. Fixes #45739. Built from https://develop.svn.wordpress.org/trunk@45619 git-svn-id: http://core.svn.wordpress.org/trunk@45430 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-11 07:21:55 +00:00
Gary Pendergast	4c3d541e23	Block Editor: Fix the link to the classic editor when incompatible meta boxen are detected. Props tmatsuur, mukesh27. Fixes #45935. Built from https://develop.svn.wordpress.org/trunk@45618 git-svn-id: http://core.svn.wordpress.org/trunk@45429 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-07-11 06:01:58 +00:00

... 2 3 4 5 6 ...

18015 Commits