Scott Taylor
fc850bf274
Unit Tests: consolidate the many separate implementations of _make_attachment()
into a helper method on WP_UnitTestCase
.
...
Fixes #34075 .
Built from https://develop.svn.wordpress.org/trunk@35309
git-svn-id: http://core.svn.wordpress.org/trunk@35275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 01:59:26 +00:00
Weston Ruter
d7e13544ea
Customizer: Prevent nav_menu_item
settings from becoming dirty when their controls are set up.
...
Since `wp_setup_nav_menu_item()` returns the `classes` property as an array but the Customizer manages the value as a string, the setting needs to initially export the value as a string. This prevents the `classes` property type change from causing the setting to get marked as dirty even though nothing changed. This is a regression from [34788].
See #34111 .
Built from https://develop.svn.wordpress.org/trunk@35308
git-svn-id: http://core.svn.wordpress.org/trunk@35274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 22:45:29 +00:00
Weston Ruter
bee05e0cdc
Customizer: Introduce customize_loaded_components
filter to allow core components to be disabled.
...
Also move style rule from `customize-nav-menus.css` to `customize-controls.css` so that widgets button is properly styled when `nav_menus` component is excluded from loading. See [35304]. See #33327 .
Props westonruter, DrewAPicture.
Fixes #33552 .
Built from https://develop.svn.wordpress.org/trunk@35307
git-svn-id: http://core.svn.wordpress.org/trunk@35273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 22:16:25 +00:00
Andrew Ozz
3451251548
TinyMCE: update to 4.2.6. Changelog: http://www.tinymce.com/develop/changelog/?ctrl=version&act=view&pr_id=1&vr_id=887 .
...
Fixes #34331 .
Built from https://develop.svn.wordpress.org/trunk@35306
git-svn-id: http://core.svn.wordpress.org/trunk@35272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 22:06:24 +00:00
Weston Ruter
c77bb38b3d
Customizer: Allow new option
settings to not be saved as autoloaded by passing an autoload
arg value of false
.
...
The `autoload` argument value is passed along to `update_option()` which has accepted an `$autoload` parameter since [31628].
Props westonruter, dlh.
See #26394 .
Fixes #33499 .
Built from https://develop.svn.wordpress.org/trunk@35305
git-svn-id: http://core.svn.wordpress.org/trunk@35271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 21:19:25 +00:00
Andrea Fercia
1e1e7a9fc9
Customizer: Make the widgets "Reorder" and "Add a Widget" buttons... buttons.
...
For accessibility, UI controls should preferably be native controls. Adds
ARIA attributes and labels to improve accessibility and pair these buttons
with the ones in the Menu Customizer.
Props obenland, TomHarrigan, sanket.parmar, metodiew, afercia.
Fixes #33327 .
Built from https://develop.svn.wordpress.org/trunk@35304
git-svn-id: http://core.svn.wordpress.org/trunk@35270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 20:15:26 +00:00
Drew Jaynes
8549e76d56
Docs: Add translator comments for two _deprecated_argument()
calls added to get_wp_title_rss()
and wp_title_rss()
in [35294].
...
See #31078 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35303
git-svn-id: http://core.svn.wordpress.org/trunk@35269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 19:20:25 +00:00
Weston Ruter
6d9d18315d
Customizer: Implement indicators for invalid nav menu items.
...
The same indicator on the nav menus admin page is now present for nav menu items in the Customizer. When a menu item is present for a post type that is no longer registered, the menu item will appear with the indicator.
Props kucrut, westonruter.
Fixes #33665 .
Built from https://develop.svn.wordpress.org/trunk@35302
git-svn-id: http://core.svn.wordpress.org/trunk@35268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 19:08:25 +00:00
Drew Jaynes
0715dc8a4f
Docs: Adjust syntax in the hook doc summaries for the document_title_separator
and document_title_parts
filters, introduced in [35294].
...
See #31078 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35301
git-svn-id: http://core.svn.wordpress.org/trunk@35267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 18:37:54 +00:00
Drew Jaynes
7c538033dd
Docs: Fix indentation and improve usefulness of inline comments surrounding the if/elseif conditions for assigning document titles in wp_get_document_title()
.
...
See #31078 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35300
git-svn-id: http://core.svn.wordpress.org/trunk@35266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 18:32:00 +00:00
Konstantin Obenland
f6941fddf4
Site Icon: Get site icon ID only when needed.
...
Cuts down on unnecessary queries, especially in environments that rely on
post meta a lot. Reverts [32997].
Props ap.koponen, swissspidy.
Fixes #34368 .
Built from https://develop.svn.wordpress.org/trunk@35299
git-svn-id: http://core.svn.wordpress.org/trunk@35265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 18:23:44 +00:00
Drew Jaynes
0ea90a9174
Docs: Update the hook doc for the pre_get_document_title
filter to explain ''what'' value is filterable rather than ''why'' the value is filterable :-)
...
The hook was introduced in [35294].
See #31078 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35298
git-svn-id: http://core.svn.wordpress.org/trunk@35264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 18:14:24 +00:00
Drew Jaynes
0a1026ac10
Docs: Improve vague changelog entries for functions and hooks where arguments were deprecated in [35294].
...
See #31078 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35297
git-svn-id: http://core.svn.wordpress.org/trunk@35263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 18:10:43 +00:00
Drew Jaynes
08f3a3b226
Docs: Fix up DocBlock syntax for the now-deprecated wp_title()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35296
git-svn-id: http://core.svn.wordpress.org/trunk@35262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 17:53:24 +00:00
Konstantin Obenland
788cb75879
Tests: Use updated filter names and oembed title for UT sanity.
...
See [35294], #31078 .
Built from https://develop.svn.wordpress.org/trunk@35295
git-svn-id: http://core.svn.wordpress.org/trunk@35261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 17:05:25 +00:00
Konstantin Obenland
c69e96422b
Themes: Improve document title output.
...
Introduces more flexibility in filtering all parts of the document title,the
separator, and a way to short-circuit title generation. Plugins can now also
check for theme support and reliably filter the entire output. See #18548 .
Deprecates `wp_title()`.
Fixes #31078 .
Built from https://develop.svn.wordpress.org/trunk@35294
git-svn-id: http://core.svn.wordpress.org/trunk@35260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 16:21:25 +00:00
Sergey Biryukov
b8e250927f
In wp_list_categories()
, rewrite a long condition for clarity.
...
See #34363 .
Built from https://develop.svn.wordpress.org/trunk@35293
git-svn-id: http://core.svn.wordpress.org/trunk@35259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 16:13:26 +00:00
Sergey Biryukov
e0af554638
Tags: Avoid a double trailing space after tags separator in auto-suggest.
...
Props afercia.
Fixes #33881 .
Built from https://develop.svn.wordpress.org/trunk@35292
git-svn-id: http://core.svn.wordpress.org/trunk@35258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 16:00:30 +00:00
Boone Gorges
b285b3002a
Correct inline comment in wp_list_categories()
.
...
The fallback link for the 'All' option is 'page_for_posts', not
'page_on_front'. Introduced in [32292].
Props sudar, SergeyBiryukov.
Fixes #34363 .
Built from https://develop.svn.wordpress.org/trunk@35291
git-svn-id: http://core.svn.wordpress.org/trunk@35257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 12:55:27 +00:00
Drew Jaynes
7c3a476909
Docs: Correction: MONTH_IN_SECONDS
was added in 4.4.0.
...
Props swissspidy.
See [33698]. See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35290
git-svn-id: http://core.svn.wordpress.org/trunk@35256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 07:35:26 +00:00
Drew Jaynes
3686b78448
Media: Introduce the image_get_intermediate_size
filter to its like-named function, making it possible to manipulate returned intermedia image size data.
...
Covers both the default and meaningful short-circuit return cases. Also adds a hash notation to the return documentation in the DocBlock.
Props A5hleyRich, DH-Shredder, wonderboymusic.
Fixes #34124 .
Built from https://develop.svn.wordpress.org/trunk@35289
git-svn-id: http://core.svn.wordpress.org/trunk@35255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 07:24:27 +00:00
Drew Jaynes
875c82f17f
Media: Introduce the enclosure_links
filter, which makes it possible to adjust the list of audio and video enclosure links derived from post content before querying the database.
...
Props niallkennedy, stevenkword.
Fixes #19890 .
Built from https://develop.svn.wordpress.org/trunk@35288
git-svn-id: http://core.svn.wordpress.org/trunk@35254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 07:09:25 +00:00
Drew Jaynes
2eb8672961
Docs: The MINUTE_IN_SECONDS
, HOUR_IN_SECONDS
, DAY_IN_SECONDS
, WEEK_IN_SECONDS
, MONTH_IN_SECONDS
, and YEAR_IN_SECONDS
constants were introduced in 3.5.
...
See [21996]. See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35287
git-svn-id: http://core.svn.wordpress.org/trunk@35253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 06:59:29 +00:00
Drew Jaynes
02c9aeaef3
Filesystem: Introduce constants to allow for easier expression of file sizes and other data amounts.
...
Adds:
* `KB_IN_BYTES` (kilobytes)
* `MB_IN_BYTES` (megabytes)
* `GB_IN_BYTES` (gigabytes)
* `TB_IN_BYTES` (terabytes)
Props nbachiyski, sudar.
See #22405 .
Built from https://develop.svn.wordpress.org/trunk@35286
git-svn-id: http://core.svn.wordpress.org/trunk@35252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 06:55:25 +00:00
Drew Jaynes
7771205935
Query: Introduce the content_pagination
filter, which makes it possible to manipulate how post content is split into "pages" in WP_Query::setup_postdata()
.
...
The "pages" — or chunks of post content – are determined by splitting based on the presence of `<!-- nextpage -->` tags in the post content.
Props sirzooro, chriscct7.
Fixes #9911 .
Built from https://develop.svn.wordpress.org/trunk@35285
git-svn-id: http://core.svn.wordpress.org/trunk@35251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 06:33:27 +00:00
Scott Taylor
afe975d754
Formatting: allow date strings to be passed to get_gmt_from_date()
, instead of requiring 'Y-m-d H:i:s'
.
...
Adds unit tests.
Props pbearne.
Fixes #34279 .
Built from https://develop.svn.wordpress.org/trunk@35284
git-svn-id: http://core.svn.wordpress.org/trunk@35250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 06:08:25 +00:00
Scott Taylor
f4cc7b3de8
Feeds: add CEST
to $timezone
in SimplePie_Parse_Date
.
...
Props swissspidy.
Fixes #32749 .
Built from https://develop.svn.wordpress.org/trunk@35283
git-svn-id: http://core.svn.wordpress.org/trunk@35249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 05:57:24 +00:00
Scott Taylor
b0561ed6e4
Dashboard: use the create_posts
cap on the post type object when determining if the Quick Press widget can be displayed.
...
Props jim912, ocean90, chriscct7.
Fixes #25681 .
Built from https://develop.svn.wordpress.org/trunk@35282
git-svn-id: http://core.svn.wordpress.org/trunk@35248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 05:49:24 +00:00
Scott Taylor
f89b90a1c9
Theme Installer: toggle iframe-ready
on the overlay to control the spinner animated GIF and high CPU usage.
...
Props afercia, adamsilverstein.
Fixes #33322 .
Built from https://develop.svn.wordpress.org/trunk@35281
git-svn-id: http://core.svn.wordpress.org/trunk@35247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 05:36:25 +00:00
Scott Taylor
85a6189ad8
Users: when calling wp_insert_user()
with an valid user ID, return WP_Error
instead of arbitrarily updating user meta.
...
Adds unit test.
Props swissspidy, bilalcoder.
Fixes #28004 .
Built from https://develop.svn.wordpress.org/trunk@35280
git-svn-id: http://core.svn.wordpress.org/trunk@35246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 05:28:24 +00:00
Scott Taylor
5d63788d9a
XML-RPC: after [35095], change the name of the xmlrpc_memory_limit
filter to xmlrpc_chunk_parsing_size
.
...
Props ankit.gade.
Fixes #29957 .
Built from https://develop.svn.wordpress.org/trunk@35279
git-svn-id: http://core.svn.wordpress.org/trunk@35245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 05:19:25 +00:00
Scott Taylor
c5b6202dfa
Widgets: revert [34376] and [34386] as pertains to the Categories widget supporting custom taxonomies.
...
Punting on 4th down.
See #21165 .
Built from https://develop.svn.wordpress.org/trunk@35278
git-svn-id: http://core.svn.wordpress.org/trunk@35244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 04:57:25 +00:00
Scott Taylor
62d8b8c5bc
List Tables: revert the majority of [34467]. This was almost universally abhorred (the JS that disabled the bulk dropdowns).
...
See #31634 .
Built from https://develop.svn.wordpress.org/trunk@35277
git-svn-id: http://core.svn.wordpress.org/trunk@35243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 04:29:24 +00:00
Scott Taylor
89d1eb1e00
Formatting: when making unique filenames in wp_unique_filename()
by adding an incrementing number, prefix it with a dash to disambiguate from files that end in numbers.
...
Updates unit tests.
Props mikejolley, tyxla.
Fixes #21453 .
Built from https://develop.svn.wordpress.org/trunk@35276
git-svn-id: http://core.svn.wordpress.org/trunk@35242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 04:05:25 +00:00
Scott Taylor
4f16590e8e
Customizer: when available, show the description
when rendering the dropdown-pages
Control.
...
Props downstairsdev, MikeHansenMe, _smartik_.
Fixes #31540 .
Built from https://develop.svn.wordpress.org/trunk@35275
git-svn-id: http://core.svn.wordpress.org/trunk@35241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 03:48:26 +00:00
Drew Jaynes
a92d4f6fcb
Docs: Update the default scheme for get_rest_url()
from 'json' to 'rest'.
...
Also adds 'rest' to the documented list of schemes for `home_url()`, `get_home_url()`, `set_url_scheme()`, and the `home_url` and `set_url_scheme` hooks.
Props rachelbaker.
Fixes #34300 .
Built from https://develop.svn.wordpress.org/trunk@35274
git-svn-id: http://core.svn.wordpress.org/trunk@35240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 22:39:25 +00:00
Andrea Fercia
e074209a3d
Accessibility: Improve the headings hierarchy in the Add Themes screen.
...
Fixes #33819 .
Built from https://develop.svn.wordpress.org/trunk@35273
git-svn-id: http://core.svn.wordpress.org/trunk@35239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 22:04:25 +00:00
Weston Ruter
a89294dc49
Widgets: Modify unit test assertion to be compatible with widget_nav_menu
option being filtered by plugin to return ArrayIterator
.
...
Modifies assertion added in [35100].
See #26876 .
See #32474 .
Built from https://develop.svn.wordpress.org/trunk@35272
git-svn-id: http://core.svn.wordpress.org/trunk@35238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 21:27:26 +00:00
Drew Jaynes
9f0f213d5e
Docs: Add a missing file header for wp-admin/includes/class-wp-site-icon.php.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@35271
git-svn-id: http://core.svn.wordpress.org/trunk@35237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 20:09:26 +00:00
Drew Jaynes
d5a15475d2
Tests: Add some more test coverage for get_term_field()
.
...
See #33968 .
Built from https://develop.svn.wordpress.org/trunk@35270
git-svn-id: http://core.svn.wordpress.org/trunk@35236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 03:29:24 +00:00
Boone Gorges
9cc7660c53
Don't store data
as a property on WP_Term
objects.
...
`wp_ajax_add_term()` fetches a term using `get_term()`, and passes the term to
`WP_Ajax_Response`, which expects each of the term's properties to be scalar.
Having `$data` as a `stdClass` (meant to mimic `WP_User::data`, populated by
a `get_row()` database query) violated this expectation, causing fatal string
conversion errors. As a workaround, `$term->data` is converted so that it is
no longer an actual property of the term object, but is assembled only when
requested in the magic `__get()` method.
Fixes #34348 .
Built from https://develop.svn.wordpress.org/trunk@35269
git-svn-id: http://core.svn.wordpress.org/trunk@35235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 03:12:24 +00:00
Boone Gorges
2543ffbbae
Bust object term cache in wp_remove_object_terms()
.
...
Props tszming.
Fixes #34338 .
Built from https://develop.svn.wordpress.org/trunk@35268
git-svn-id: http://core.svn.wordpress.org/trunk@35234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 01:53:24 +00:00
Dion Hulse
85258bb914
In insert_with_markers()
restore the 4.3 behaviour of creating the file if it doesn't exist.
...
This change also makes it bail early (without writing) if the markers content is the same as the existing, and uses `ftell()` rather than `$bytes` for the location to truncate the file to - based on the file pointer being at the end of the written stream.
Props willmot tigertech kevinatelement
See #31767
Built from https://develop.svn.wordpress.org/trunk@35267
git-svn-id: http://core.svn.wordpress.org/trunk@35233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 00:53:24 +00:00
Drew Jaynes
fd9bcf111d
Docs: Fix a typo in the $blog_id
parameter name in the rest_url
filter doc.
...
Props rachelbaker.
Fixes #34351 .
Built from https://develop.svn.wordpress.org/trunk@35266
git-svn-id: http://core.svn.wordpress.org/trunk@35232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 23:12:25 +00:00
Andrea Fercia
579246ab4a
Multisite: Improve the Admin Bar parent menu items color on hover and focus.
...
Props Nikschavan for the initial patch.
Fixes #34040 .
Built from https://develop.svn.wordpress.org/trunk@35265
git-svn-id: http://core.svn.wordpress.org/trunk@35231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 16:22:24 +00:00
Drew Jaynes
2e11f8cc16
Taxonomy: Improve deprecated argument strings for the 'link' type in get_categories()
and wp_dropdown_categories()
.
...
Props swissspidy, gagan0123.
Fixes #34318 .
Built from https://develop.svn.wordpress.org/trunk@35264
git-svn-id: http://core.svn.wordpress.org/trunk@35230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 15:35:24 +00:00
Drew Jaynes
b37bb95aad
Administration: Introduce the manage_posts_extra_tablenav
action, which fires inside the tablenav for the posts list table, and just outside the "actions" container.
...
Props hlashbrooke, wonderboymusic.
Fixes #30341 .
Built from https://develop.svn.wordpress.org/trunk@35263
git-svn-id: http://core.svn.wordpress.org/trunk@35229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 14:56:23 +00:00
Drew Jaynes
0aaa2900eb
Docs: Add a version to the file header for wp-admin/includes/comment.php.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@35262
git-svn-id: http://core.svn.wordpress.org/trunk@35228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 14:34:25 +00:00
Ella Iseulde Van Dorpe
9845e08340
TinyMCE: Drag and drop link with image
...
Make sure images don't loose their link after drag and drop.
Fixes #28272 .
Built from https://develop.svn.wordpress.org/trunk@35261
git-svn-id: http://core.svn.wordpress.org/trunk@35227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 11:05:23 +00:00
John Blackbourn
532e1fb856
Some cleanup that was missed in [35259].
...
See #33728 , #24853
Built from https://develop.svn.wordpress.org/trunk@35260
git-svn-id: http://core.svn.wordpress.org/trunk@35226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 06:26:24 +00:00