Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-12-26 02:57:45 +01:00
Code Issues Projects Releases Wiki Activity
38,016 Commits 50 Branches 749 Tags 806 MiB
ffedf3d752
Commit Graph

25229 Commits

Author SHA1 Message Date
Adam Silverstein
de6906a045 Customizer: in menus, reset results when closing the 'add items' panel. 
Trigger a keyup event when clearing the search field in response to closing the add item panel. The keyup event triggers a search and resets the results. Previously, the search field was cleared while the potentially blank search results were left in place making it impossible to select new menu items.

Props Blair jersyer, aranwer104, afercia.
Fixes #43333.


Built from https://develop.svn.wordpress.org/trunk@42744


git-svn-id: http://core.svn.wordpress.org/trunk@42574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-25 18:48:29 +00:00
Sergey Biryukov
b34b1ee061 Tests: Correct a "false positive" assertion in test_media_handle_upload_ignores_page_parent_for_directory_date(). 
Props birgire.
Fixes #42736.
Built from https://develop.svn.wordpress.org/trunk@42743


git-svn-id: http://core.svn.wordpress.org/trunk@42573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-25 18:47:30 +00:00
Sergey Biryukov
61e8101442 Tests: Avoid hardcoded domain name in test_media_handle_upload_uses_post_parent_for_directory_date(). 
Props birgire.
See #42736.
Built from https://develop.svn.wordpress.org/trunk@42742


git-svn-id: http://core.svn.wordpress.org/trunk@42572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-25 18:43:30 +00:00
Adam Silverstein
89c9e27fd1 Unit Tests: add a DIR_TESTROOT constant to avoid relative paths. 
Fix an issue that prevents tests from running correctly when run outside their normal context.

Props PressLabs, johnbillion.
Fixes #40071.


Built from https://develop.svn.wordpress.org/trunk@42741


git-svn-id: http://core.svn.wordpress.org/trunk@42571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-25 18:07:31 +00:00
Adam Silverstein
a299c5c344 Fix eshint error since r42739. 
Remove a trailing comma in [42739] that was throing a jshint error.


Built from https://develop.svn.wordpress.org/trunk@42740


git-svn-id: http://core.svn.wordpress.org/trunk@42570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-25 16:49:30 +00:00
Adam Silverstein
da89d20c39 Media: grid view - correct placeholder positioning during uploads. 
Preventing contextually created attachments from being added to the grid collection in Attachments.validator. Remove the previous filtering introduced in [41937] which caused the placement issue.

Props lancewillett, Junaidkbr, designsimply, joemcgill.
Fixes #42968.

Built from https://develop.svn.wordpress.org/trunk@42739


git-svn-id: http://core.svn.wordpress.org/trunk@42569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-25 16:41:31 +00:00
Sergey Biryukov
4d47bfce41 Coding Standards: Fix code indent in unescape_invalid_shortcodes(). 
Props joelcj91, GaryJ.
Fixes #43346.
Built from https://develop.svn.wordpress.org/trunk@42738


git-svn-id: http://core.svn.wordpress.org/trunk@42568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-25 16:36:30 +00:00
Adam Silverstein
505c2ddb61 Taxonomy: restore TagSearch unit tests and correct deprecated version string. 
Reverts unit test removal, instead changing them to expect the function to be deprecated.
Correct the version the ajax callback was deprecated.

Amends [42614].

Props dlh, ocean90.
Fixes #38922.


Built from https://develop.svn.wordpress.org/trunk@42737


git-svn-id: http://core.svn.wordpress.org/trunk@42567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-25 16:28:30 +00:00
Sergey Biryukov
395667f916 Comments: After [42703], make sure $args['type'] in paginate_comments_links() is always defined. 
Props anantajitjg.
Fixes #43299.
Built from https://develop.svn.wordpress.org/trunk@42736


git-svn-id: http://core.svn.wordpress.org/trunk@42566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-25 16:08:30 +00:00
Sergey Biryukov
35d5163d66 Docs: Correct description for WP_User::get_role_caps(). 
Props thomaswm.
Fixes #43410.
Built from https://develop.svn.wordpress.org/trunk@42735


git-svn-id: http://core.svn.wordpress.org/trunk@42565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-25 15:39:30 +00:00
Sergey Biryukov
b6229650e0 Themes: Pre-translate theme names on Themes screen before sorting the array, to improve performance and avoid a warning in PHP 5.x. 
Props bobbingwide, sebastian.pisula.
Fixes #34565.
Built from https://develop.svn.wordpress.org/trunk@42734


git-svn-id: http://core.svn.wordpress.org/trunk@42564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-25 13:18:30 +00:00
Sergey Biryukov
b12620e798 Build/Test Tools: Remove vendor file name entry from .gitignore. 
Props netweb.
Fixes #43411.
Built from https://develop.svn.wordpress.org/trunk@42733


git-svn-id: http://core.svn.wordpress.org/trunk@42563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-25 11:30:32 +00:00
Sergey Biryukov
0e39cef343 Menus: When checking if a Custom Link matches the current URL to add the current-menu-item class, check for decoded URL as well. 
Props soulseekah, campusboy1987.
Fixes #43401.
Built from https://develop.svn.wordpress.org/trunk@42732


git-svn-id: http://core.svn.wordpress.org/trunk@42562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-24 13:44:31 +00:00
Sergey Biryukov
fc5617e7fe Administration: Use HTTPS for dashboard_primary_feed URL. 
`dashboard_secondary_feed` is already using HTTPS since [29787].

Props iandunn.
Fixes #40416.
Built from https://develop.svn.wordpress.org/trunk@42731


git-svn-id: http://core.svn.wordpress.org/trunk@42561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-24 09:30:33 +00:00
Gary Pendergast
cf49eacd62 REST API: Translate the taxonomy visibility description strings. 
This was missed in [42729].

Props TimothyBlynJacobs.
Fixes #42707.


Built from https://develop.svn.wordpress.org/trunk@42730


git-svn-id: http://core.svn.wordpress.org/trunk@42560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-22 00:59:30 +00:00
Gary Pendergast
d6923d285c REST API: Show taxonomy visibility settings. 
For Gutenberg and other admin-type interfaces, it's useful to be able to see the visibility settings for taxonomies.

Props joehoyle, pento.
Fixes #42707.


Built from https://develop.svn.wordpress.org/trunk@42729


git-svn-id: http://core.svn.wordpress.org/trunk@42559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-22 00:24:31 +00:00
Aaron Jorbin
f4f64377b7 Community Events Dashboard: Use wp_list_pluck rather than array_columns 
array_columns is only available in PHP 5.5+

Introduced in [42726]

See: #41112.


Built from https://develop.svn.wordpress.org/trunk@42728


git-svn-id: http://core.svn.wordpress.org/trunk@42558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-21 23:27:31 +00:00
Andrea Fercia
54a45f6d77 Accessibility: Change the terms "Quick Edit" link to a button. 
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.
See #38677 / [42725].

Fixes #43382.

Built from https://develop.svn.wordpress.org/trunk@42727


git-svn-id: http://core.svn.wordpress.org/trunk@42557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-21 23:04:31 +00:00
Aaron Jorbin
9f8d1ab69d Community Events Dashboard: Always show a WordCamp if one is coming up 
WordCamps are celebrations of the local WordPress Community and once a local one is scheduled, people in that community should know it is coming. This adjusts the WordPress Events in the dashboard widgets to always display a WordCamp, even if there are multiple Meetups happening first.

Props iandunn, metalandcoffee, warmlaundry, alejandroxlopez, jorbin.
Fixes #41112.


Built from https://develop.svn.wordpress.org/trunk@42726


git-svn-id: http://core.svn.wordpress.org/trunk@42556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-21 23:01:31 +00:00
Andrea Fercia
4767e7736c Accessibility: Change the posts "Quick Edit" link to a button. 
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation. Also,
adds an `aria-expanded` attribute to the button to communicate to assistive
technologies the expanded / collapsed status of the Quick Edit form.

Props Cheffheid, audrasjb, afercia.
Fixes #38677.

Built from https://develop.svn.wordpress.org/trunk@42725


git-svn-id: http://core.svn.wordpress.org/trunk@42555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-21 22:31:32 +00:00
Sergey Biryukov
ebeb2bcf5b Tests: Replace use of $this->server with rest_get_server() for better memory recycling. 
Props danielbachhuber.
Fixes #41641.
Built from https://develop.svn.wordpress.org/trunk@42724


git-svn-id: http://core.svn.wordpress.org/trunk@42554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-21 16:25:31 +00:00
Mark Jaquith
edfe2ece51 Cache API: Allow external object caches to gracefully degrade to the default object cache. 
Rework logic for how external object caches are detected, so that if
an external cache does not define a `wp_cache_init()`, the built-in
object cache will be used.

Object caches can now wrap their entire contents in logic checks. So a
Redis caching backend could make sure that the `Redis` PHP class is
available before defining all the caching functions. And if Redis is
not available, the site doesn't break or throw errors or think it is
using caching when it isn't. This is particularly useful for doing
local development, where you might want to develop on a site without
running Memcache or Redis like you are in production.

* Accounts for multisite, which may re-initialize the object cache
multiple times.
* Accounts for object caches that may include `object-cache.php` during
`advanced-cache.php` (before WP loads it).

Props jtsternberg, markjaquith.
Fixes #22661.


Built from https://develop.svn.wordpress.org/trunk@42723


git-svn-id: http://core.svn.wordpress.org/trunk@42553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-21 14:59:30 +00:00
Sergey Biryukov
c7c98dd7ea Docs: Correct $id parameter type for old_slug_redirect_post_id filter. 
Props dlh.
Fixes #43375.
Built from https://develop.svn.wordpress.org/trunk@42722


git-svn-id: http://core.svn.wordpress.org/trunk@42552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-21 09:35:33 +00:00
Sergey Biryukov
9e5e5ecdc6 Docs: Add a reference to get_pages() arguments in wp_dropdown_pages() and wp_list_pages(), as they both use the function internally. 
Props birgire.
Fixes #43355.
Built from https://develop.svn.wordpress.org/trunk@42721


git-svn-id: http://core.svn.wordpress.org/trunk@42549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-19 22:24:31 +00:00
Sergey Biryukov
dcf5eb07de Docs: Correct documentation for Heartbeat filters. 
`$response` parameter is documented as an array or object, but only array is actually supported.

See #42777, #42505.
Built from https://develop.svn.wordpress.org/trunk@42720


git-svn-id: http://core.svn.wordpress.org/trunk@42548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-19 21:46:33 +00:00
Peter Wilson
e6ccdf161f General: Further improve error messages following [42648]. 
Props kristastevens, melchoyce.
Fixes #38332 for trunk.


Built from https://develop.svn.wordpress.org/trunk@42719


git-svn-id: http://core.svn.wordpress.org/trunk@42547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-19 02:13:32 +00:00
Dominik Schilling
5eddf9a359 I18N: Remove unused $start_of_week property from WP_Locale. 
Missed in [35685], see #28344.

Props birgire, tonybogdanov.
Fixes #43344.
Built from https://develop.svn.wordpress.org/trunk@42718


git-svn-id: http://core.svn.wordpress.org/trunk@42546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-18 16:32:34 +00:00
Konstantin Obenland
3f7a8aac6b Docs: Add filter docs for wp_refresh_nonces 
Props chetan200891, slushman, dlh, netweb.
Fixes #42777.


Built from https://develop.svn.wordpress.org/trunk@42717


git-svn-id: http://core.svn.wordpress.org/trunk@42545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-17 04:42:33 +00:00
Sergey Biryukov
e50b9c943f Database: If both WP_DEBUG and WP_DEBUG_DISPLAY are true, display a more specific error message in wpdb::bail(). 
Props sivel, Mte90, SergeyBiryukov.
Fixes #13657.
Built from https://develop.svn.wordpress.org/trunk@42716


git-svn-id: http://core.svn.wordpress.org/trunk@42544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-15 14:29:30 +00:00
atimmer
e17e29d4ea Docs: Improve JSDoc for for wp-admin/js/xfn.js. 
Props kapteinbluf, igorsch.
Fixes #43204.

Built from https://develop.svn.wordpress.org/trunk@42715


git-svn-id: http://core.svn.wordpress.org/trunk@42543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-15 13:35:31 +00:00
atimmer
34c6523a0d Docs: Improve JSDoc for wp-admin/js/user-suggest.js. 
Amend r42708 by fixing the 80 character wrap around.

Props timhavinga.
See #43270.

Built from https://develop.svn.wordpress.org/trunk@42714


git-svn-id: http://core.svn.wordpress.org/trunk@42542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-15 13:26:33 +00:00
Sergey Biryukov
7d2cd516d1 Twenty Seventeen: Underline links in comments. 
Props jainnidhi, larrach, audrasjb.
Fixes #43317. 
Built from https://develop.svn.wordpress.org/trunk@42713


git-svn-id: http://core.svn.wordpress.org/trunk@42541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-15 03:34:30 +00:00
Sergey Biryukov
5d1e06f939 Docs: Move inline comments in wp_kses_split2() before the blocks they apply to. 
See #42505.
Built from https://develop.svn.wordpress.org/trunk@42712


git-svn-id: http://core.svn.wordpress.org/trunk@42540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-14 11:46:33 +00:00
Sergey Biryukov
d9f222f740 Customize: Correct closing tags in customize_themes_print_templates(). 
Props johnpgreen, nandorsky.
Fixes #43307.
Built from https://develop.svn.wordpress.org/trunk@42711


git-svn-id: http://core.svn.wordpress.org/trunk@42539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-13 22:15:32 +00:00
Drew Jaynes
6e665d1f15 Docs: Link to the "Conditional Tags" article in the Theme Developer Handbook from the descriptions for a variety of core conditional tag functions. 
These notations largely serve to direct consumers (of both the source and the parsed code reference) to extended information on individual and related conditional tags throughout WordPress. The changeset also standardizes corresponding DocBlock summaries to use third-person singular verbs.

Notations been added for the following functions:

* comments_open()
* email exists()
* has_excerpt()
* has_post_thumbnail()
* has_tag()
* in_category()
* in_the_loop()
* is_404()
* is_active_sidebar()
* is_active_widget()
* is_admin()
* is_admin_bar_showing()
* is_archive()
* is_attachment()
* is_author()
* is_blog_installed()
* is_category()
* is_comments_popup()
* is_date()
* is_day()
* is_dynamic_sidebar()
* is_feed()
* is_front_page()
* is_home()
* is_local_attachment()
* is_main_query
* is_month()
* is_multi_author
* is_new_day()
* is_page()
* is_page_template()
* is_paged()
* is_plugin_active()
* is_plugin_active_for_network()
* is_plugin_inactive()
* is_plugin_page()
* is_post_type_archive()
* is_preview()
* is_rtl()
* is_search()
* is_single()
* is_singular()
* is_sticky()
* is_tag()
* is_tax()
* is_taxonomy_hierarchical()
* is_time()
* is_trackback()
* is_user_logged_in()
* is_year()
* pings_open()
* post_type_exists()
* taxonomy_exists()
* term_exists()
* username exists()
* wp_attachment_is_image()
* wp_script_is()

Props janalwin.
Fixes #43254.

Built from https://develop.svn.wordpress.org/trunk@42710


git-svn-id: http://core.svn.wordpress.org/trunk@42538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-13 16:54:31 +00:00
atimmer
5e190dc084 Docs: Improve JSDoc for media/views/spinner.js. 
Amends r42675 - includes the built media files.

Built from https://develop.svn.wordpress.org/trunk@42709


git-svn-id: http://core.svn.wordpress.org/trunk@42537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-13 15:45:30 +00:00
atimmer
87130f0e20 Docs: Improve JSDoc for wp-admin/js/user-suggest.js. 
Props timhavinga.
Fixes #43270.

Built from https://develop.svn.wordpress.org/trunk@42708


git-svn-id: http://core.svn.wordpress.org/trunk@42536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-13 15:38:31 +00:00
Sergey Biryukov
68a3e7745a Docs: Add documentation for header_video_settings filter. 
Props milana_cap.
Fixes #43300.
Built from https://develop.svn.wordpress.org/trunk@42707


git-svn-id: http://core.svn.wordpress.org/trunk@42535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-12 22:39:31 +00:00
Sergey Biryukov
dfa6839706 Media: In img_caption_shortcode(), make sure $id and $caption_id are always defined. 
See #34595.
Built from https://develop.svn.wordpress.org/trunk@42706


git-svn-id: http://core.svn.wordpress.org/trunk@42534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-12 22:36:33 +00:00
Sergey Biryukov
0306b3f637 Docs: Use code formatting for tags in img_caption_shortcode() DocBlock. 
See #34595.
Built from https://develop.svn.wordpress.org/trunk@42705


git-svn-id: http://core.svn.wordpress.org/trunk@42533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-12 21:40:31 +00:00
Sergey Biryukov
0f8d7de77d Media: Pass original attribute values to img_caption_shortcode_width filter instead of markup pieces. 
Add `caption_id` to the list of documented `[caption]` shortcode attributes.

See #34595.
Built from https://develop.svn.wordpress.org/trunk@42704


git-svn-id: http://core.svn.wordpress.org/trunk@42532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-12 21:37:30 +00:00
Sergey Biryukov
0a97d79899 Comments: Avoid a PHP notice in paginate_comments_links() if type argument is set to array. 
The function is a wrapper for `paginate_links()`, which returns an array if requested.

Props anantajitjg.
Fixes #43299.
Built from https://develop.svn.wordpress.org/trunk@42703


git-svn-id: http://core.svn.wordpress.org/trunk@42531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-12 21:12:35 +00:00
Sergey Biryukov
abf27d78b9 Media: After [42695], remove redundant check that is already performed a few lines above. 
Props gnif.
See #43255.
Built from https://develop.svn.wordpress.org/trunk@42702


git-svn-id: http://core.svn.wordpress.org/trunk@42530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-11 21:55:30 +00:00
Sergey Biryukov
c2e74ab915 Database: In require_wp_db(), check if database constants are defined before using them. 
Otherwise, `wp-admin/setup-config.php` triggers an undefined constant warning in PHP 7.2.

Props mariusvw, jryancard for initial patch.
Fixes #35560.
Built from https://develop.svn.wordpress.org/trunk@42701


git-svn-id: http://core.svn.wordpress.org/trunk@42529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-11 18:47:30 +00:00
Sergey Biryukov
b2411e9e3f Administration: Make sure wp.updates.addAdminNotice is displayed after the page header and does not unexpectedly push down "Add New" and other buttons. 
Props shivapoudel.
Fixes #41221.
Built from https://develop.svn.wordpress.org/trunk@42700


git-svn-id: http://core.svn.wordpress.org/trunk@42528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-11 17:28:30 +00:00
Sergey Biryukov
e1e041271e Docs: Fix typo in term_exists() DocBlock. 
Props milana_cap, danieltj.
Fixes #43268.
Built from https://develop.svn.wordpress.org/trunk@42699


git-svn-id: http://core.svn.wordpress.org/trunk@42527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-11 17:16:29 +00:00
Sergey Biryukov
4a55ea5e68 Networks and Sites: In get_site_by_path(), use single domain and path parameters if there's only one item to look for. 
This should increase the chances of `WP_Site_Query::get_sites()` hitting an existing cache.

Props spacedmonkey.
Fixes #42299.
Built from https://develop.svn.wordpress.org/trunk@42698


git-svn-id: http://core.svn.wordpress.org/trunk@42526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-11 17:09:31 +00:00
Sergey Biryukov
f88dddcab5 Media: Add aac to the list of allowed file types. 
Props desrosj.
Fixes #42919.
Built from https://develop.svn.wordpress.org/trunk@42697


git-svn-id: http://core.svn.wordpress.org/trunk@42525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-11 16:40:31 +00:00
Sergey Biryukov
3de0634199 Docs: Fix typo in wp_audio_extensions and wp_video_extensions filter descriptions. 
See #42505.
Built from https://develop.svn.wordpress.org/trunk@42696


git-svn-id: http://core.svn.wordpress.org/trunk@42524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-11 16:29:30 +00:00
Sergey Biryukov
e6322d0afe Media: In WP_Image_Editor::make_image(), close previously opened output buffer if the file could not be created. 
Props dhanendran, gnif.
Fixes #43255.
Built from https://develop.svn.wordpress.org/trunk@42695


git-svn-id: http://core.svn.wordpress.org/trunk@42523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-11 16:25:31 +00:00
Sergey Biryukov
beeafbc7ec Media: After [42693], update HTML4 markup in img_caption_shortcode() to avoid an empty ID attribute as well. 
Add a unit test for `aria-describedby` in `img_caption_shortcode()`.

See #34595.
Built from https://develop.svn.wordpress.org/trunk@42694


git-svn-id: http://core.svn.wordpress.org/trunk@42522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-11 15:40:30 +00:00
Sergey Biryukov
0f2b559d05 Media: Only add aria-describedby in img_caption_shortcode() if a non-empty attachment ID attribute was provided. 
See #34595.
Built from https://develop.svn.wordpress.org/trunk@42693


git-svn-id: http://core.svn.wordpress.org/trunk@42521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-11 15:20:30 +00:00
Sergey Biryukov
dffe5deb97 Media: Make sure $caption_id does not depend on an undefined variable. 
See #34595.
Built from https://develop.svn.wordpress.org/trunk@42692


git-svn-id: http://core.svn.wordpress.org/trunk@42520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-11 14:53:30 +00:00
Sergey Biryukov
3e19b66f40 Media: Add aria-describedby to img_caption_shortcode() output to improve image/caption relationship. 
Props joedolson.
Fixes #34595.
Built from https://develop.svn.wordpress.org/trunk@42691


git-svn-id: http://core.svn.wordpress.org/trunk@42519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-11 14:44:30 +00:00
Sergey Biryukov
8df00f0354 Media: Convert concatenation in img_caption_shortcode() to sprintf() for clarity. 
See #34595.
Built from https://develop.svn.wordpress.org/trunk@42690


git-svn-id: http://core.svn.wordpress.org/trunk@42518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-11 14:17:30 +00:00
Sergey Biryukov
7a8e4bcb1b Administration: Remove erroneous transition-delay values from CSS files. 
Although unitless zero is allowed for `<length>` CSS data type, it's invalid for `<time>` data type.

Props chetan200891, manuel_84, GaryJ.
Fixes #43195.
Built from https://develop.svn.wordpress.org/trunk@42689


git-svn-id: http://core.svn.wordpress.org/trunk@42517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-11 12:55:30 +00:00
Sergey Biryukov
e97d2c0407 Users: After [41163], add a notice for Email field on Profile screen that the new address will not become active until confirmed. 
Props dilipbheda.
Fixes #43106. See #16470.
Built from https://develop.svn.wordpress.org/trunk@42688


git-svn-id: http://core.svn.wordpress.org/trunk@42516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-11 12:23:31 +00:00
Sergey Biryukov
12f854b6e8 Build/Test Tools: Update prefixed CSS properties in about.css. 
Firefox 52+ supports unprefixed `column-count` and `column-gap` properties.

Props netweb, afercia.
Fixes #43190.
Built from https://develop.svn.wordpress.org/trunk@42687


git-svn-id: http://core.svn.wordpress.org/trunk@42515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-10 23:47:31 +00:00
Sergey Biryukov
903224cce4 Plugins: Use correct variable name in install_plugin_information(). 
Props afragen.
Fixes #43282. See #43192, #29274.
Built from https://develop.svn.wordpress.org/trunk@42686


git-svn-id: http://core.svn.wordpress.org/trunk@42514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-10 22:08:30 +00:00
Sergey Biryukov
b1f48870d7 Administration: Rename Appearance → Editor menu item to Theme Editor and Plugins → Editor to Plugin Editor for clarity. 
Props xkon, karmatosed.
Fixes #43072.
Built from https://develop.svn.wordpress.org/trunk@42685


git-svn-id: http://core.svn.wordpress.org/trunk@42513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-10 08:43:32 +00:00
John Blackbourn
ee24b48106 Comments: Add a "Mine" link to the list of filters on the comment listing screen. 
This filter shows comments made by the current user, and copies the same filter functionality that's available on the post listing screens.

Props Iceable

Fixes #42379

Built from https://develop.svn.wordpress.org/trunk@42684


git-svn-id: http://core.svn.wordpress.org/trunk@42512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-09 18:46:31 +00:00
Drew Jaynes
1ae9491548 Docs: Fix a copy paste error in the DocBlock summary for wp_ssl_constants(), see [13062]. 
Props terriann.
Fixes #43272.

Built from https://develop.svn.wordpress.org/trunk@42683


git-svn-id: http://core.svn.wordpress.org/trunk@42511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-09 18:21:31 +00:00
John Blackbourn
b1ed10ab9a HTTP API: Add the URL as a paramter to various HTTP related filters. 
Props paulschreiber, purnendu

Fixes #42186

Built from https://develop.svn.wordpress.org/trunk@42682


git-svn-id: http://core.svn.wordpress.org/trunk@42510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-09 18:11:30 +00:00
John Blackbourn
427ae1692d Docs: Un-correct an incorrection correction. 
See [42680]

See #42505

Built from https://develop.svn.wordpress.org/trunk@42681


git-svn-id: http://core.svn.wordpress.org/trunk@42509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-09 17:57:30 +00:00
John Blackbourn
763f34d117 Docs: Correct some secondary documentation for the https_local_ssl_verify and https_ssl_verify filters. 
See #42505

Built from https://develop.svn.wordpress.org/trunk@42680


git-svn-id: http://core.svn.wordpress.org/trunk@42508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-09 17:48:29 +00:00
John Blackbourn
fc6ba86b80 Docs: First pass at switching some array parameter documentation to typed notation. 
Props janak007

See #41756

Built from https://develop.svn.wordpress.org/trunk@42679


git-svn-id: http://core.svn.wordpress.org/trunk@42507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-09 17:26:31 +00:00
John Blackbourn
91464bce65 Docs: Add missing code formatting to various @since entries. 
See #42505

Built from https://develop.svn.wordpress.org/trunk@42678


git-svn-id: http://core.svn.wordpress.org/trunk@42506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-09 16:55:31 +00:00
John Blackbourn
823cac40df Docs: Update the hook docs for update_bulk_theme_complete_actions. 
See #42505

Built from https://develop.svn.wordpress.org/trunk@42677


git-svn-id: http://core.svn.wordpress.org/trunk@42505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-09 16:22:45 +00:00
John Blackbourn
332b9844a9 Posts, Post Types: Add a new add_inline_data action which allows extra fields to be added to the inline editing fields. 
Props mensmaximus, NathanAtmoz

Fixes #36085

Built from https://develop.svn.wordpress.org/trunk@42676


git-svn-id: http://core.svn.wordpress.org/trunk@42504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-09 15:55:32 +00:00
atimmer
8ad4538d0f Docs: Improve JSDoc for media/views/spinner.js. 
Props avillegasn.
Fixes #43230.

Built from https://develop.svn.wordpress.org/trunk@42675


git-svn-id: http://core.svn.wordpress.org/trunk@42503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-09 14:32:33 +00:00
Sergey Biryukov
b9944def27 Posts, Post Types: Remove extra tabs around page_attributes_meta_box_template action in page_attributes_meta_box(). 
Props chetan200891.
See #43252.
Built from https://develop.svn.wordpress.org/trunk@42674


git-svn-id: http://core.svn.wordpress.org/trunk@42502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-08 11:24:32 +00:00
Sergey Biryukov
ef4f47d00f Customize: Avoid extra tabs in a textarea in WP_Customize_Control::render_content(). 
See #43252.
Built from https://develop.svn.wordpress.org/trunk@42673


git-svn-id: http://core.svn.wordpress.org/trunk@42501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-08 10:59:30 +00:00
Sergey Biryukov
a5958a289b Upgrade/Install: Avoid extra line breaks in a textarea in wp-admin/setup-config.php. 
See #43252.
Built from https://develop.svn.wordpress.org/trunk@42672


git-svn-id: http://core.svn.wordpress.org/trunk@42500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-08 10:59:00 +00:00
Sergey Biryukov
a65ce4e34b Options: Avoid extra tabs in a textarea in wp-admin/options.php. 
See #43252.
Built from https://develop.svn.wordpress.org/trunk@42671


git-svn-id: http://core.svn.wordpress.org/trunk@42499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-08 10:58:31 +00:00
Sergey Biryukov
cceab04984 Comments: Avoid extra tabs in a textarea in WP_Comments_List_Table::column_comment(). 
Props chetan200891, jrf.
Fixes #43252.
Built from https://develop.svn.wordpress.org/trunk@42670


git-svn-id: http://core.svn.wordpress.org/trunk@42498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-08 10:57:32 +00:00
Helen Hou-Sandí
aaa28bba15 Options: Use strings in the test suite that follow community guidelines. 
Also somewhat explain to future maintainers why this pairing of strings was chosen, besides this committer's musical preferences. Social opinions on cancer are fairly clear, as are commonly accepted definitions of profanity and family-friendly language.

Shout out to the close contender, which would have been particularly appropriate here: "You could be the king // But watch the queen conquer".

see #43207, #38176

Built from https://develop.svn.wordpress.org/trunk@42667


git-svn-id: http://core.svn.wordpress.org/trunk@42495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-07 22:42:31 +00:00
John Blackbourn
1c2ef0f475 Build/Test Tools: Allow code coverage reports to be generated. 
This corrects the attribute needed to allow PHPUnit to generate coverage reports, and also adds a blacklist of files and directories that are excluded from coverage reports.

Props schlessera, jipmoors

Fixes #43067, #43240

Built from https://develop.svn.wordpress.org/trunk@42665


git-svn-id: http://core.svn.wordpress.org/trunk@42494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-07 22:21:30 +00:00
John Blackbourn
f7224ea635 Docs: Copy a helpful inline doc into the function header for visibility. 
See #42505

Built from https://develop.svn.wordpress.org/trunk@42664


git-svn-id: http://core.svn.wordpress.org/trunk@42493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-07 22:13:30 +00:00
Aaron Jorbin
17589837d2 Options: Use most appropriate language in the test suite. 
The test suite's opinion of cancer should be clear.

Reverts r42659.

See #43207, #38176



Built from https://develop.svn.wordpress.org/trunk@42663


git-svn-id: http://core.svn.wordpress.org/trunk@42492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-07 20:59:31 +00:00
Boone Gorges
355b6e80da Improve parameter description for 'allow_empty_comments'. 
Introduced in [42661].

Props swissspidy.
See #16979.
Built from https://develop.svn.wordpress.org/trunk@42662


git-svn-id: http://core.svn.wordpress.org/trunk@42491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-07 20:50:30 +00:00
Boone Gorges
6c11ac0c16 Comments: Introduce 'allow_empty_comment' filter. 
This filter allows plugin authors to allow empty comments on a selective
basis during comment submission.

Props jpurdy647.
Fixes #16979.
Built from https://develop.svn.wordpress.org/trunk@42661


git-svn-id: http://core.svn.wordpress.org/trunk@42490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-07 20:09:30 +00:00
Drew Jaynes
39ce01d83a Docs: Fix a typo in the DocBlock description for get_bloginfo() illustrating the URL structure for RDF feeds. 
Props ibachal.
See #42505.

Built from https://develop.svn.wordpress.org/trunk@42660


git-svn-id: http://core.svn.wordpress.org/trunk@42489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-07 19:42:30 +00:00
John Blackbourn
982791db31 Options: Use more appropriate language in the test suite. 
See #43207, #38176

Built from https://develop.svn.wordpress.org/trunk@42659


git-svn-id: http://core.svn.wordpress.org/trunk@42488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-07 18:52:31 +00:00
Drew Jaynes
9dd9913ecd Docs: Document default arguments for wp_tag_cloud() in a hash notation, noting that full lists of additionally-supported arguments are already documented in get_terms() and wp_generate_tag_cloud(). 
Props birgire, johnbillion.
Fixes #42019.

Built from https://develop.svn.wordpress.org/trunk@42658


git-svn-id: http://core.svn.wordpress.org/trunk@42487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-07 15:22:34 +00:00
Felix Arntz
f3eaddd2dc Options: Unhook default option filter when setting is unregistered. 
Fixes #43207.

Built from https://develop.svn.wordpress.org/trunk@42655


git-svn-id: http://core.svn.wordpress.org/trunk@42484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-06 14:49:32 +00:00
Dion Hulse
3517dc0b8b Updates: Partially revert [42584], as this branch of code should always be run after a core update check. 
This code branch is responsible for running all autoupdates, including plugins and themes - which should run regardless of if there's a core autoupdate available.

This revert does not revert the `$timeout` changes, as these should still use cached data if it's available.
Ideally this should be decoupled from the core update check to allow background updates to operate even when the core update check is disabled or running more often than twice daily.

See #43103.

Built from https://develop.svn.wordpress.org/trunk@42653


git-svn-id: http://core.svn.wordpress.org/trunk@42482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-06 11:04:34 +00:00
Dion Hulse
0eb9e0c8d0 XML-RPC: Add default values to IXR_Message for PHP 7.2 compatibility to avoid PHP Warnings. 
Fixes #43216 for trunk.

Built from https://develop.svn.wordpress.org/trunk@42652


git-svn-id: http://core.svn.wordpress.org/trunk@42481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-06 02:56:32 +00:00
Peter Wilson
8f0ab2efb8 Taxonomy: Stop warming term meta cache unnecessarily. 
Prevent several core function calls to `get_terms()` from warming the term meta cache.

Props peterwilsoncc, boonebgorges, jrf.
Fixes #43142.


Built from https://develop.svn.wordpress.org/trunk@42649


git-svn-id: http://core.svn.wordpress.org/trunk@42478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-05 04:10:30 +00:00
Peter Wilson
0d39b35c11 General: Replace Cheatin’ uh? with friendlier error messages. 
While intended as a playful error message, `Cheatin’ uh?` can be interpreted as insulting or accusatory in an already stressful situation. This replaces Cheatin’ with more meaningful error messages, depending on the error that occurs.

Props ElectricFeet, EricMeyer, karmatosed, dd32, BandonRandon, melchoyce for language; dmsnell for original patch; peterwilsoncc.
Fixes #38332.


Built from https://develop.svn.wordpress.org/trunk@42648


git-svn-id: http://core.svn.wordpress.org/trunk@42477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-05 02:30:34 +00:00
John Blackbourn
a1eb261cd1 Canonical: Add $x_redirect_by parameter to wp_safe_redirect(). 
See [42633] and [42408].

Fixes #42313.

Built from https://develop.svn.wordpress.org/trunk@42647


git-svn-id: http://core.svn.wordpress.org/trunk@42476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-04 16:05:32 +00:00
Drew Jaynes
f3ca5b5f47 Tests: Simplify @covers annotations for WP_Error test coverage. Also fix a typo in a test method name. 
See #42742.

Built from https://develop.svn.wordpress.org/trunk@42646


git-svn-id: http://core.svn.wordpress.org/trunk@42475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-03 17:38:30 +00:00
Drew Jaynes
3544e0151d Tests: Fix two typos introduced for a get_term_field() test in [35270]. 
See #33968.

Built from https://develop.svn.wordpress.org/trunk@42645


git-svn-id: http://core.svn.wordpress.org/trunk@42474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-03 17:11:30 +00:00
Andrea Fercia
8a664edcab Administration: Make the Screen Options available on small screens. 
Previously, the Screen Options toggle and the related panel content 
were hidden on small screens, preventing access to important settings,
including the ability to toggle the meta boxes visibility.

Props chetan200891.
Fixes #40985.

Built from https://develop.svn.wordpress.org/trunk@42644


git-svn-id: http://core.svn.wordpress.org/trunk@42473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-03 16:58:30 +00:00
Sergey Biryukov
430a724a03 Help/About: Correct outdated media icons reference in help text on Edit Post screen. 
Props thrijith, transl8or.
Fixes #42378.
Built from https://develop.svn.wordpress.org/trunk@42643


git-svn-id: http://core.svn.wordpress.org/trunk@42472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-03 13:58:30 +00:00
Sergey Biryukov
4951b2897e Media: Remove checkered background for icons in Attachment Details. 
Props BandonRandon.
Fixes #42535. See #41948.
Built from https://develop.svn.wordpress.org/trunk@42642


git-svn-id: http://core.svn.wordpress.org/trunk@42471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-03 13:54:31 +00:00
Andrea Fercia
a7c89d5761 Administration: CSS coding standards: use double quotes for values that require quotes. 
As per the WordPress CSS coding standards, CSS properties with values that require quotes must use double quotes.
Also fixes some indentation and spacing.

Fixes #43220.

Built from https://develop.svn.wordpress.org/trunk@42641


git-svn-id: http://core.svn.wordpress.org/trunk@42470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-03 13:19:32 +00:00
Sergey Biryukov
abdea23275 Docs: Convert $args array description for wp_get_themes() to a hash notation. 
Props milana_cap.
Fixes #43213.
Built from https://develop.svn.wordpress.org/trunk@42640


git-svn-id: http://core.svn.wordpress.org/trunk@42469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-02 09:38:30 +00:00
Sergey Biryukov
f45e696e21 Media: Avoid a PHP warning in wp_calculate_image_srcset() if a plugin returns a non-array value via wp_calculate_image_srcset filter. 
Props mrmadhat, codegrau.
Fixes #43201.
Built from https://develop.svn.wordpress.org/trunk@42639


git-svn-id: http://core.svn.wordpress.org/trunk@42468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-02 07:48:31 +00:00
Sergey Biryukov
2f54a93369 Posts, Post Types: Don't count pending comments in WP_Posts_List_Table::_display_rows() if the post type does not support comments. 
Props seanchayes.
Fixes #43212.
Built from https://develop.svn.wordpress.org/trunk@42638


git-svn-id: http://core.svn.wordpress.org/trunk@42467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-02 07:38:32 +00:00
Sergey Biryukov
66e2c1ed87 Build Tools: Update SPDX License in package.json to adhere to SPDX v3.0 specification. 
Props netweb.
Fixes #43032.
Built from https://develop.svn.wordpress.org/trunk@42637


git-svn-id: http://core.svn.wordpress.org/trunk@42466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-01 16:39:30 +00:00