Florian CUNY
7b55ca70b2
Fixed some Flags and added a security check in FlagsManager
...
...to avoid duplicates of Listeners
2018-02-07 13:41:37 +01:00
Florian CUNY
f33fa2477a
Use .equals() in #isBanned(UUID) in Island
2018-02-07 13:33:37 +01:00
Florian CUNY
12cac6b3aa
Minor adjustments to ranks-related methods in Island
2018-02-07 13:29:19 +01:00
Florian CUNY
293ab2ccf9
Added default values to Settings
2018-02-07 13:16:09 +01:00
Tastybento
e5a87ccf7a
Code cleanup and bug fixing.
...
This just cleans up a lot of code that could cause confusion or was
actually wrong.
2018-02-06 23:04:09 -08:00
Tastybento
1db21c10da
Fixed bug with help that I introduced.
...
Added specific convenience showHelp() method to Composite command.
2018-02-06 22:45:21 -08:00
Tastybento
61f0a6f997
Made homeTeleport void because it does not return anything useful
2018-02-06 22:02:14 -08:00
Tastybento
ad50b04177
Removed unneeded method.
2018-02-06 21:59:15 -08:00
Tastybento
eefcd48c7c
Fixed return values for execute.
2018-02-06 21:57:45 -08:00
Tastybento
af5c7e472e
Fixed execute return values.
2018-02-06 21:48:59 -08:00
Tastybento
a9373a3eea
Fixed return values - false = error
2018-02-06 21:46:59 -08:00
Tastybento
00470b1fc8
Return false if error.
2018-02-06 21:45:10 -08:00
Tastybento
3e2d2ec2d6
Return false if unsuccessful due to no island.
2018-02-06 21:44:40 -08:00
Tastybento
219d1e66ab
Fixed brackets.
2018-02-06 21:43:31 -08:00
Tastybento
f4c7a3fe45
Made command return false if unsuccessful.
2018-02-06 21:40:29 -08:00
Tastybento
81b0543f25
Added missing break statement to switch.
2018-02-06 21:34:48 -08:00
Tastybento
574febb327
Added missing break statement in switch.
2018-02-06 21:34:20 -08:00
Tastybento
2e89a2654f
Added more try-with-resource to auto-close prepared statement
2018-02-06 21:33:05 -08:00
Tastybento
fdc7a62990
Fixed issue where Optional was not being explicitly checked before get.
2018-02-06 21:31:59 -08:00
Tastybento
2d64070d3f
Avoided setting static variable in non-static method.
2018-02-06 21:31:19 -08:00
Tastybento
5a5ae2d077
Used Java standard ordering of words
2018-02-06 21:30:56 -08:00
Tastybento
ed622dc9c0
Fixed switch break bug.
2018-02-06 21:30:35 -08:00
tastybento
bb404380f5
Replaced raw stack trace dumps with helpful error messages.
2018-02-06 16:37:34 -08:00
tastybento
aac17990bc
Made description private.
2018-02-06 16:09:49 -08:00
tastybento
8b7d92d8e6
Added better error message for exception when loading addons.
2018-02-06 16:06:04 -08:00
tastybento
04a4394752
Make addon non-public and provide getter to address minor vulnerability.
2018-02-06 16:04:22 -08:00
tastybento
7e2f8052da
Improved exception handling error messages.
2018-02-06 15:59:42 -08:00
tastybento
1e920825ef
Added context to raw stack trace dump after exception.
2018-02-06 15:55:31 -08:00
tastybento
672d43fb67
Fixed unnecessary if statement and removed redundant code.
2018-02-06 14:11:10 -08:00
tastybento
56ff9f62e4
Used try-with-resources to ensure jar is closed.
2018-02-06 14:07:35 -08:00
tastybento
28b88763e6
Changed Optional map to ifPresent because return value is not needed.
2018-02-06 14:05:48 -08:00
tastybento
8743ac50ef
Removed duplicate sub-expression in if statement.
2018-02-06 14:02:58 -08:00
tastybento
941d9d3dc5
Removed if/else change because it is not required.
2018-02-06 14:01:52 -08:00
tastybento
d2098c3dbe
Check if Optional click handler exists before getting it.
2018-02-06 13:59:23 -08:00
tastybento
2c1d52761f
Cast operand to double.
2018-02-06 13:54:23 -08:00
tastybento
06e61d858c
Fixed a lot of unclosed prepared statements, connections and resultset
2018-02-06 13:52:25 -08:00
tastybento
84d36a1a24
Simplified some logic.
2018-02-06 13:35:17 -08:00
tastybento
f7c4e5a988
Added null checks.
2018-02-06 13:33:08 -08:00
tastybento
1ddf706c68
Bug fixes to avoid NPE's and Optional gets without isPresent
2018-02-06 13:21:08 -08:00
Tastybento
ace6294e23
Came full circle - kept Flags as final statics
...
This approach simulates an enum, but one that can be extended by others
to add custom flags. I added a handy values() method that uses
reflection to provide a list of all the flags in the class.
See TestBSkyBlock.java test classes for the tests of the default flag
registration and the custom flag registration.
2018-02-05 23:53:07 -08:00
tastybento
be5404e9c2
Added Setting type to flags.
...
Flags can be Protection type or Setting Type.
Still needs testing for PVP.
2018-02-05 17:39:04 -08:00
tastybento
645b4eb610
Implements flags as enum so flags are protected.
2018-02-05 14:51:03 -08:00
tastybento
ffbf938a32
WIP trying out moving flags into flag manager.
2018-02-05 14:30:35 -08:00
tastybento
812594783e
Made Adapter its own annotation.
2018-02-05 11:35:50 -08:00
Tastybento
26956d8386
Fixed missing locale text for invites.
...
Fixed config settings for teams.
2018-02-04 21:48:34 -08:00
Tastybento
fa1ccd0c99
Fixed bugs with MySQL saving and loading.
...
Added the adapter annotation to MySQL and fixed issues with empty
hashmaps causing null errors.
Added a flag serializer adapter for the protection flags so that flags
are saved and loaded correctly.
Renamed the Adapter notation class to be clearer about what it is doing.
2018-02-04 12:53:17 -08:00
Tastybento
83d0848429
Fixed bugs with protection.
...
Added serializer adapter for the Flags hashmap in Island.
Teams don't work. Need to work out why.
PVP doesn't work correctly. It allows members to hit visitors anytime,
but visitors can only hit others if PVP is off. This isn't how it is
supposed to work!
2018-02-03 20:42:12 -08:00
Tastybento
6c2078fbec
Added event tests.
...
Fixed bug with user being retained after a checkIsland.
2018-02-03 19:25:53 -08:00
Tastybento
c648409858
Reworked code so it can be tested using automated unit tests.
...
See TestBSkyBlock.java class for protection tests.
More to come!
2018-02-03 15:26:13 -08:00
Tastybento
df0ecca217
Added dependency injection (DI) for flag listeners for plugin.
...
This is required for automated testing (can't use static getInstance). I
really need automated testing of the protection classes, so even though
this adds a parameter to the classes, it's important to have it right
now.
2018-02-03 11:54:33 -08:00
