Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2025-02-01 23:01:28 +01:00
Code Issues Projects Releases Wiki Activity

[EC-598] chore: tweak how unassigned rpId gets calcuated

Browse Source
This commit is contained in:
Andreas Coroiu 2023-04-17 14:06:37 +02:00
parent 10d5f69ea4
commit adf7298678
No known key found for this signature in database
GPG Key ID: E70B5FFC81DFEC1A
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libs/common/src/fido2/services/fido2-client.service.ts
View File

@ -41,9 +41,9 @@ export class Fido2ClientService implements Fido2ClientServiceAbstraction {
} }
const parsedOrigin = parse(params.origin, { allowPrivateDomains: true }); const parsedOrigin = parse(params.origin, { allowPrivateDomains: true });
const rpId = params.rp.id ?? parsedOrigin.domain; const rpId = params.rp.id ?? parsedOrigin.hostname;
if (parsedOrigin.domain == undefined || !params.origin.startsWith("https://")) { if (parsedOrigin.hostname == undefined || !params.origin.startsWith("https://")) {
throw new DOMException("'origin' is not a valid https origin", "SecurityError"); throw new DOMException("'origin' is not a valid https origin", "SecurityError");
} }
@ -161,9 +161,9 @@ export class Fido2ClientService implements Fido2ClientServiceAbstraction {
} }
const parsedOrigin = parse(params.origin, { allowPrivateDomains: true }); const parsedOrigin = parse(params.origin, { allowPrivateDomains: true });
const rpId = params.rpId ?? parsedOrigin.domain; const rpId = params.rpId ?? parsedOrigin.hostname;
if (parsedOrigin.domain == undefined || !params.origin.startsWith("https://")) { if (parsedOrigin.hostname == undefined || !params.origin.startsWith("https://")) {
throw new DOMException("'origin' is not a valid https origin", "SecurityError"); throw new DOMException("'origin' is not a valid https origin", "SecurityError");
} }