Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-12-04 13:44:00 +01:00
Code Issues Projects Releases Wiki Activity

fix: cmd + w doesn't close the window on macOS (#714) (#342)

Browse Source 
cmd + w doesn't close the window on macOS. Based on @cscharf explanation - https://github.com/bitwarden/desktop/issues/714#issuecomment-810554674 - it seems that issue was introduced in response to erroneous Apple Store approver request. The code change reversed this change.
This commit is contained in:
kapitainsky 2021-04-13 19:31:34 +01:00 committed by GitHub
parent 827674847f
commit c832728b6d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/electron/baseMenu.ts
View File

@ -9,8 +9,6 @@ import {
import { I18nService } from '../abstractions/i18n.service'; import { I18nService } from '../abstractions/i18n.service';
import { WindowMain } from './window.main'; import { WindowMain } from './window.main';
import { isMacAppStore } from './utils';
export class BaseMenu { export class BaseMenu {
protected editMenuItemOptions: MenuItemConstructorOptions; protected editMenuItemOptions: MenuItemConstructorOptions;
protected viewSubMenuItemOptions: MenuItemConstructorOptions[]; protected viewSubMenuItemOptions: MenuItemConstructorOptions[];
@ -143,7 +141,7 @@ export class BaseMenu {
}, },
{ {
label: this.i18nService.t('close'), label: this.i18nService.t('close'),
role: isMacAppStore() ? 'quit' : 'close', role: 'close',
}, },
]; ];
} }