Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-10-22 07:50:04 +02:00
Code Issues Projects Releases Wiki Activity

[PM-13189] Send copy updates (#11619)

Browse Source 
* Add more descriptive header text

* Update hint under optional password field

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
This commit is contained in:
Daniel James Smith 2024-10-21 16:10:57 +02:00 committed by GitHub
parent c9de05de95
commit d298ac6edf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 22 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
apps/browser/src/_locales/en/messages.json
View File

@ -2464,8 +2464,8 @@
"message": "Optionally require a password for users to access this Send.", "message": "Optionally require a password for users to access this Send.",
"description": "'Send' is a noun and the name of a feature called 'Bitwarden Send'. It should not be translated." "description": "'Send' is a noun and the name of a feature called 'Bitwarden Send'. It should not be translated."
}, },
"sendPasswordDescV2": { "sendPasswordDescV3": {
"message": "Require this password to view the Send.", "message": "Add an optional password for recipients to access this Send.",
"description": "'Send' is a noun and the name of a feature called 'Bitwarden Send'. It should not be translated." "description": "'Send' is a noun and the name of a feature called 'Bitwarden Send'. It should not be translated."
}, },
"sendNotesDesc": { "sendNotesDesc": {
@ -4494,9 +4494,15 @@
"itemLocation": { "itemLocation": {
"message": "Item Location" "message": "Item Location"
}, },
"fileSend": {
"message": "File Send"
},
"fileSends": { "fileSends": {
"message": "File Sends" "message": "File Sends"
}, },
"textSend": {
"message": "Text Send"
},
"textSends": { "textSends": {
"message": "Text Sends" "message": "Text Sends"
}, },

19
apps/browser/src/tools/popup/send-v2/add-edit/send-add-edit.component.ts
View File

@ -174,18 +174,25 @@ export class SendAddEditComponent {
) )
.subscribe((config) => { .subscribe((config) => {
this.config = config; this.config = config;
this.headerText = this.getHeaderText(config.mode); this.headerText = this.getHeaderText(config.mode, config.sendType);
}); });
} }
/** /**
* Gets the header text based on the mode. * Gets the header text based on the mode and type.
* @param mode The mode of the send form. * @param mode The mode of the send form.
* @param type The type of the send
* @returns The header text. * @returns The header text.
*/ */
private getHeaderText(mode: SendFormMode) { private getHeaderText(mode: SendFormMode, type: SendType) {
return this.i18nService.t( const headerKey =
mode === "edit" || mode === "partial-edit" ? "editSend" : "createSend", mode === "edit" || mode === "partial-edit" ? "editItemHeader" : "newItemHeader";
);
switch (type) {
case SendType.Text:
return this.i18nService.t(headerKey, this.i18nService.t("textSend"));
case SendType.File:
return this.i18nService.t(headerKey, this.i18nService.t("fileSend"));
}
} }
} }

2
libs/tools/send/send-ui/src/send-form/components/options/send-options.component.html
View File

@ -41,7 +41,7 @@
[appCopyClick]="sendOptionsForm.get('password').value" [appCopyClick]="sendOptionsForm.get('password').value"
showToast showToast
></button> ></button>
<bit-hint>{{ "sendPasswordDescV2" | i18n }}</bit-hint> <bit-hint>{{ "sendPasswordDescV3" | i18n }}</bit-hint>
</bit-form-field> </bit-form-field>
<bit-form-control *ngIf="!disableHideEmail || originalSendView?.hideEmail"> <bit-form-control *ngIf="!disableHideEmail || originalSendView?.hideEmail">
<input <input