1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-21 11:35:34 +01:00
Commit Graph

16697 Commits

Author SHA1 Message Date
Bernd Schoolmann
cc7d197d4b
Fix title missing in ssh-key edit/view in web 2024-11-21 11:20:20 +01:00
Bernd Schoolmann
5e6c5c8779
[PM-14993] Add ssh-agent error handling and security fixes (#12048)
* Add error handling and security fixes

* Add is running status, and add more errors on windows
2024-11-20 10:38:21 +01:00
Bernd Schoolmann
eda38855f0
[PM-14989] Add unit tests for putty keys (#12030) 2024-11-20 01:09:12 -08:00
rr-bw
9429ae1d06
feat(auth): [PM-9723] Refresh LoginViaAuthRequestComponent (#11545)
Creates a refreshed and consolidated LoginViaAuthRequestComponent for use on all visual clients, which will be used when the UnauthenticatedExtensionUIRefresh feature flag is on.
2024-11-19 14:53:01 -08:00
Nick Krantz
2df8643e29
separate out "new" button implementations for extension refresh (#12002) 2024-11-19 12:28:00 -06:00
Nick Krantz
ca839b3d80
[PM-14019] Toggle Vault Filters (#11929)
* move vault headings to their own component

* update aria-label to bind to the data attribute

* move vault headings to the vault-v2 folder

* integrate disclosure trigger to hide vault filters

* remove built in margin on search component

- spacing will be managed by the parent component

* add event emitter so consuming components can know when disclosure status has changed

* add filter badge when filters are selected and the filters are hidden

* persist filter visibility state to disk

* add supporting text for the filter button

* remove extra file

* only read from stored state on component launch.

- I noticed delays when trying to use stored state as the source of truth

* use two-way data binding for change event

* update vault headers to use two way data binds from disclosure component

- also adjust consuming changes

* add border thickness

* add ticket to the FIXME

* move number of filters observable into service

* move state coordination into filter service

* only expose state and update methods from filter service

* simplify observables to avoid needed state lifecycle methods

* remove comment

* fix test imports

* update badge colors

---------

Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2024-11-19 11:49:42 -06:00
cyprain-okeke
c17f582768
[PM-13345]Add the new policy (#11894)
* Add the new policy

* Add the free family policy behind flag

* Patch build process

* Revert "Patch build process"

This reverts commit 4024e974b1.

* [PM-13346] Email notification impacts (#11967)

* Changes error notification for disabled offer

* Add the feature to the change

* Add the missing dot

* Remove the authenicated endpoint

* Add the changes for error toast

* Resolve the lint issue

* rename file a correctly

* Remove the floating promise comments

* Delete unwanted comments

---------

Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2024-11-19 17:36:52 +01:00
Oscar Hinton
0386b7f068
Switch to using PowerShell for compressing (#12052) 2024-11-19 17:25:35 +01:00
Jason Ng
21855595c5
[PM-14219] Add service for new device verification notice (#11988)
* added service and spec file for new device verification notice
2024-11-19 10:04:40 -05:00
renovate[bot]
140a514be3
[deps] Platform: Pin dependencies (#11528)
* [deps] Platform: Pin dependencies

* Bump Versions

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
2024-11-19 09:49:21 -05:00
Justin Baur
8823c7b0b2
[PM-8748] Make 5 Seconds the Max we wait for a sync to complete on unlock (#11882)
* Make 5 Seconds the Max we wait for a sync to complete on unlock

* Move Comment

---------

Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2024-11-19 09:06:29 -05:00
Daniel James Smith
ce042d4ad0
Fix linting (#12051)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-11-19 13:52:46 +00:00
Oscar Hinton
e43a204ab2
Fix broken browser build (#12050) 2024-11-19 13:43:19 +00:00
LamTrinh.Dev
7a778dbb32
Update Bitwarden mobile repositories at README.md (#12027) 2024-11-19 13:28:17 +00:00
Oscar Hinton
b55a28f755
[PM-14485] Remove manifest and index.html logic from gulp (#12033)
Refactor the remaining logic from gulp.  Part of the browser build script
refactor effort.

Webpack is now responsible for performing most of the operations previously
done by gulp. This includes: - Setting browser specific class - Building the
manifest file  The `package.json` is modified to include browser specific
commands for `build`, `build:prod`, `build:watch` and `dist`.

# Manifests

Manifests now uses the `copy-webpack-plugin` `transform` feature. The logic is
located in `apps/browser/webpack/manifest.js`. It reads a template, which
supports some basic operations primarily overriding with browser specific
fields using `__browser__`.  The `manifest.json` for both regular and mv3
builds are identical to our existing manifests except:
- `applications` renamed to `browser_specific_settings`.
- `permissions` sorted alphabetically.

# Safari build

Safari requires additional packaging commands. This is implemented as a
powershell script due to the cross-platform nature, and since we generally
require powershell in our distribution pipelines. An alternative would be to
write it in bash, but bash is less powerful and would require some additional
commands like `jq`. Another alternative is to write it using js, but that would
require additional dependencies.
2024-11-19 13:25:30 +00:00
Bernd Schoolmann
2ec7bbcd13
Fix import dialog ssh key i18n (#12049) 2024-11-19 14:16:42 +01:00
Andreas Coroiu
33f7643e15
[PM-12989] Create process for qa to build client with particular sdk version (#11601)
* feat: update sdk service abstraction with documentation and new `userClient$` function

* feat: add uninitialized user client with cache

* feat: initialize user crypto

* feat: initialize org keys

* fix: org crypto not initializing properly

* feat: avoid creating clients unnecessarily

* chore: remove dev print/subscription

* fix: clean up cache

* chore: update sdk version

* feat: implement clean-up logic (#11504)

* chore: bump sdk version to fix build issues

* chore: bump sdk version to fix build issues

* fix: missing constructor parameters

* refactor: simplify free() and delete() calls

* refactor: use a named function for client creation

* fix: client never freeing after refactor

* fix: broken impl and race condition in tests

* feat: add sdk override to desktop build

* feat: add SDK version to browser about dialog

* feat: add sdk override to browser build

* fix: `npm ci` overriding the override

* fix: artifacts not properly downloaded

* fix: switch to new repository

* feat: add debug version function to web

* feat: add sdk-version to CLI

* feat: add version to desktop

* feat: add override to cli

* feat: add override to web

* fix: cli version acting as default command

* fix: consistent workflow input name

* feat: add error handling

* feat: upgrade sdk-internal

* fix: forgot to update package lock

* fix: broken CI build

move sdk version to a regular command

* chore: revert version changes

* refactor: move error handling code

* chore: bump SDK to 0.2.0.main-1

* fix: clean up references to inputs.sdk_commit

* refactor: rename `init` to `applyVersionToWindow`
2024-11-19 13:59:59 +01:00
Will Martin
a07b072196
[CL-499][PM-14020] compact mode (#11796) 2024-11-18 16:35:49 -05:00
✨ Audrey ✨
3521c54672
[PM-14964] revert passphrase minimum (#12019)
* revert passphrase minimum
* add recommendation text to browser refresh;  hide hint text when value exceeds recommendation
* migrate validators to generator configuration
2024-11-18 13:43:03 -06:00
renovate[bot]
15418659ad
[deps] Autofill: Update tldts to v6.1.61 (#12029)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-18 14:41:03 -05:00
Brandon Treston
2447355153
[pm-14025] Remove usage of ActiveUserState from organization.service (#11799)
* WIP refactor organizationService

* rename file, add tests

* fix tests, remove promisies from servcie

* rename tests, classes, and files. Remove unneeded code

* refactor organization service function params to expect a UserId

* fix test

---------

Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2024-11-18 12:26:10 -05:00
bw-ghapp[bot]
330057e2d8
Autosync the updated translations (#12042)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-11-18 18:08:29 +01:00
bw-ghapp[bot]
06304f9bf8
Autosync the updated translations (#12041)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-11-18 18:07:54 +01:00
bw-ghapp[bot]
8ce9d7571c
Autosync the updated translations (#12043)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-11-18 18:07:23 +01:00
Vince Grassia
4d9dc9a839
BRE-438 - Update Crowdin workflow (#12038) 2024-11-18 16:15:58 +00:00
github-actions[bot]
0f2dbb1164
Autosync the updated translations (#12010)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-11-18 15:56:11 +00:00
Merissa Weinstein
c51b9233b3
decrease bit-item ring size (#12017) 2024-11-18 09:48:27 -06:00
Tom
f1538e1a5f
[PM-14525] remove member access feature flag (#11972)
* Remove member access feature flag

* removing unused code
2024-11-18 10:37:08 -05:00
Oscar Hinton
d875ded8fa
Revert "[PM-14485] Remove manifest and index.html logic from gulp" (#12032)
This reverts commit c388697fdf.
2024-11-18 15:38:53 +01:00
Oscar Hinton
c388697fdf
[PM-14485] Remove manifest and index.html logic from gulp (#11861)
Refactor the remaining logic from gulp.  Part of the browser build script
refactor effort.

Webpack is now responsible for performing most of the operations previously
done by gulp. This includes: - Setting browser specific class - Building the
manifest file  The `package.json` is modified to include browser specific
commands for `build`, `build:prod`, `build:watch` and `dist`.

# Manifests

Manifests now uses the `copy-webpack-plugin` `transform` feature. The logic is
located in `apps/browser/webpack/manifest.js`. It reads a template, which
supports some basic operations primarily overriding with browser specific
fields using `__browser__`.  The `manifest.json` for both regular and mv3
builds are identical to our existing manifests except:
- `applications` renamed to `browser_specific_settings`.
- `permissions` sorted alphabetically.

# Safari build

Safari requires additional packaging commands. This is implemented as a
powershell script due to the cross-platform nature, and since we generally
require powershell in our distribution pipelines. An alternative would be to
write it in bash, but bash is less powerful and would require some additional
commands like `jq`. Another alternative is to write it using js, but that would
require additional dependencies.
2024-11-18 11:50:24 +01:00
Thomas Rittson
ea5f492fd1
[PM-14935] fix: null error when GroupsComponent first loads (#12013) 2024-11-18 14:24:12 +10:00
Alec Rippberger
be61d5d325
Convert select to bit-select (#12008) 2024-11-17 20:24:12 -06:00
Todd Martin
0308e6e180
Remove showPasswordless conditionals (#11928)
Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2024-11-15 12:34:02 -05:00
Alexander Hammerman
d55c8712ac
[PM-12753] Desktop edit folder button visibility (#11284)
* Adds max-width to filter button to ensure edit button visibility

* Now applies max-width only when folder is selected

---------

Co-authored-by: Jason Ng <jng@bitwarden.com>
2024-11-15 09:54:13 -05:00
Victoria League
3b5b2d6bd6
[CL-265] CL/extension refresh feature branch (#8696)
* [CL-245] Update palette to new light and dark theme colors (#8633)

* [CL-245] Add new color swatches to storybook (#8697)

* [CL-238] update typography (#8997)

* [CL-230] [CL-296] Update button styles (#9345)

* [CL-237] Update menu styles for extension refresh (#9525)

* [CL-267] Add 100-level color variants and update primary-600 (#9550)

* [CL-286] Update badge to use focus-visible instead of focus (#9551)

* [CL-250] Update badge styles for extension refresh (#9572)

* [CL-234] callout style refresh (#9920)

* [CL-233] Update form field styles (#9776)

* [CL-239][CL-251][CL-342] dialog style refresh (#10096)

* [CL-239] simple dialog style refresh

* [CL-342] fix text overflow in dialog; add story

* [CL-244] readonly fields (#10164)

* [CL-352] Fix Angular errors related to form element changes (#10211)

* [CL-273] Update styles for checkbox and form control (#10146)

* [CL-274] Update styling for radio button (#10333)

* [CL-338] Remove extra space in item content when end slot is empty (#10350)

* [CL-377] Fix extension style conflict for input background (#10351)

* [CL-271] Update styles for toggle (#10377)

* [CL-381] Update spacing around form elements (#10432)

* [CL-229] Update icon button styles (#10405)

* [CL-380] Remove hover state from disabled form fields (#10639)

* [CL-405] Allow toggle group input to be full width (#10658)

* [CL-389] Exclude end slot label content from truncation (#10508)

* [CL-383] Remove manual focus when password toggle is clicked (#10749)

* [CL-278][CL-391] misc bit-item style fixes (#10758)

* [CL-391] use pointer cursor on hover when link or button

* [CL-210] Change base font size from 14px to 16px (#10779)

* [CL-291] Finalize styling for chip select (#10771)

* [CL-257] update banner component styles (#10766)

* [CL-443] Fix sizing issues (#10893)

* [CL-445] Fix small sizing and spacing issues (#10962)

* [CL-382] Reduce element shifting on readonly hover (#10956)

* [CL-396] Update theme colors to new hexes (#10968)

* [CL-395] Remove text headers color (#10997)

* [CL-404] Switch to primary-600 for all focus indicators (#11015)

* [CL-397] Remove primary-500 (#11036)

* [CL-447] Ensure DM Sans displays correctly at all font weights (#11041)

* [CL-448] Scrollbar Styles (#11111)

* CL-252/update toast (#10996)

* [CL-275] Update link styles (#11174)

* [CL-446] Update hover state for unselected chip selects (#11172)

* [CL-454] Improve color a11y for toast and banner interactive elements (#11200)

* [CL-457] Center input text for select and multiselect (#11239)

* [CL-455] Do not use responsive margin for sections in dialogs or extension (#11243)

* [CL-459] Fix chip behavior when opening menu while item is selected (#11227)

* [CL-388] Update vertical nav colors for new palette (#11226)

* scope styled scrollbar to only select elements (#11247)

* edit radio buttons to be block inputs and update spacing (#11291)

* [CL-453] Fix multiselect chip spacing and truncation (#11300)

* [PM-11131] Prevent duplicated sr labels on form field icon buttons (#11383)

* [CL-303] Prevent chip menu from running offscreen (#11348)

* [CL-476] Fix DM Sans font on Windows (#11409)

* implements scrollbar styles for firefox/chrome and safari (#11447)

* [CL-472] Fix search background color in extension (#11466)

* [CL-481] Style updates for bit-item, bit-card, and primary-100 (#11473)

* [CL-478] Remove underline on hover for most components (#11477)

* [CL-477] Remove focus styles for readonly input (#11510)

* [CL-487] Fix vault items virtual scroll height (#11581)

* [PM-8625] Increase popup width (#11686)

* [CL-494] Wrap long words in toggle group (#11659)

* [CL-13820] Add class to remove link underline (#11762)

* [CL-435] Prevent Windows extension from shifting (#11851)

* [CL-503] Add notification color variables (#11802)

* [PM-14043] Update size of toggle group label to fit more content (#11881)

* [CL-498] Set chip menu width minimum to chip select width (#11905)

---------

Co-authored-by: Will Martin <contact@willmartian.com>
Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
Co-authored-by: Nick Krantz <125900171+nick-livefront@users.noreply.github.com>
Co-authored-by: Merissa Weinstein <merissa.k.weinstein@gmail.com>
Co-authored-by: Danielle Flinn <43477473+danielleflinn@users.noreply.github.com>
2024-11-15 09:21:17 -05:00
Brandon Treston
5c540a86f4
[PM-13829] Add organizationId to isAdmin check, refactor isAdmin to getter (#11997)
* Add organizationId to isAdmin check, refactor isAdmin to getter for restore and delete

* add comment
2024-11-14 17:17:40 -05:00
✨ Audrey ✨
48294aac86
invert ambiguous character flag (#12004) 2024-11-14 15:55:19 -05:00
Daniel James Smith
73632cd368
[PM-12598] Create dedicated importer for Password-XP (csv) (#11751)
* Create dedicated password-xp csv importer

* Add support for importing unmapped columns as custom fields

* Add support for importing folders and assiging items to them

* On import into an organization, convert folders to collections

* Register importer within importService and make it selectable via the UI

Add instructions on how to export from Password XP

* Mark method as private

* Add docs

* Add comment around folder detection

* Move test data into separate file

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2024-11-14 21:28:55 +01:00
Nick Krantz
d4a381e1bd
[PM-14653] PM/AC Delete Cipher (#11996)
* check for admin console for unassigned ciphers

* use `isUnassigned` helper

* remove unneeded comment
2024-11-14 14:22:17 -06:00
Jordan Aasen
b0c5b5e9e6
[PM-14567] - fix routes. update copy and headers (#11908)
* fix routes. update copy and headers

* Patch build process

* Revert "Patch build process"

This reverts commit 4d3716d375.

---------

Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
Co-authored-by: Tom <144813356+ttalty@users.noreply.github.com>
2024-11-14 14:38:10 -05:00
Bernd Schoolmann
76105aa275
Fix double prompt when unlocking by ssh request (#12000) 2024-11-14 19:56:39 +01:00
Evan Bassler
c1302a3604
reorder address field identification (#11824)
Co-authored-by: Evan Bassler <evanbassler@Evans-MBP.attlocal.net>
Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2024-11-14 13:29:30 -05:00
Jonas Hendrickx
a4156799e9
[PM-13783] Battle harden ProviderType enum expansion (#11920) 2024-11-14 17:46:02 +01:00
Daniel García
d0f24dc41f
Improve desktop IPC logging (#11864)
* Improve desktop IPC logging

* Log error

* Force file to only log info, like the desktop app does

* use ?
2024-11-14 17:45:19 +01:00
Oscar Hinton
ef127fd26e
Ensure we await for the wasm module to load (#11995)
Webpack seems to always convert imports to be async. This causes a issue where
init_sdk is not always initialized before we call it. To resolve this I added
a promise we can await in MV3 mode, and also defined a timeout which throws an
error we can use to identify if we have issues loading the module.
2024-11-14 17:29:56 +01:00
Github Actions
5da5c886ea Bumped client version(s) 2024-11-14 16:13:41 +00:00
cd-bitwarden
a1ad3383f7
[PM-13894] updating the text area for notes to have 5 rows (#11976)
* updating the text area for notes to have 5 rows

* Applying the row count to the edit page as well

---------

Co-authored-by: --global <>
2024-11-14 16:06:57 +00:00
Rui Tomé
e6fce421f5
[PM-10324] Add bulk delete option for organization members (#11892)
* Refactor organization user API service to support bulk deletion of users

* Add copy for bulk user delete dialog

* Add bulk user delete dialog component

* Add bulk user delete functionality to members component

* Refactor members component to only display bulk user deletion option if the Account Deprovisioning flag is enabled

* Patch build process

* Revert "Patch build process"

This reverts commit 917c969f00.

---------

Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2024-11-14 15:49:16 +00:00
✨ Audrey ✨
642b8d2e6b
[PM-14838] upgrade generator account storage to ObjectKey storage (#11975) 2024-11-14 10:09:59 -05:00
aj-bw
a08c9776cb
PM-14914/ssh-key-item-type-filtering-web (#11990) 2024-11-14 10:05:43 -05:00