1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-22 11:45:59 +01:00
Commit Graph

13340 Commits

Author SHA1 Message Date
Justin Baur
6f84f4ca73
[PM-3330] Force Update to Lockable Accounts on PIN/Biometric Update (#6006)
* Add Listener For Events that Need To Redraw the Menu

* Send redrawMenu Message When Pin/Biometrics Updated
2023-08-10 13:42:07 -04:00
Todd Martin
55482c5648
Updated email change component to getOrDeriveMasterKey (#6009) 2023-08-10 13:39:33 -04:00
Jared Snider
2fe93e37df
PM-3369 - TDE - Persist user's choice to trust device to state when user ma… (#6000)
* PM-3369 - Persist user's choice to trust device to state when user makes choice + persist previous choices out of state

* PM-3369 - Must set trust device in state on load if it's never been set before

* PM-3369 - Refactor BaseLoginDecOptions to properly set trust device choice in state on load

* Update libs/angular/src/auth/components/base-login-decryption-options.component.ts

Co-authored-by: Jake Fink <jfink@bitwarden.com>

---------

Co-authored-by: Jake Fink <jfink@bitwarden.com>
2023-08-10 13:15:57 -04:00
Robyn MacCallum
ab11de9883
Add optional chaining to master key (#6007) 2023-08-10 12:25:36 -04:00
Robyn MacCallum
5e88624b13
Add distinctUntilChanged to fix multiple value changes for biometrics firing (#5999) 2023-08-10 08:22:28 -04:00
Jared Snider
c80c0fd701
PM-3355 - TDE - Browser JIT Account Creation - Browser create user logic still had logic for simply closing the extension tab but as we no longer open the login decryption options in a tab we needed to update the logic here to navigate the user directly onto the vault. (#5993) 2023-08-09 18:13:20 -04:00
Jared Snider
78c2e2c894
PM-3332 - LoginWithDevice - Add error handling logic around admin auth request retrieval similar to sso login strategy to prevent error state and allow re-creation of an admin auth request if it has been purged from the server for whatever reason. (#5991) 2023-08-09 15:31:28 -04:00
Robyn MacCallum
935adb71c2
[PM 3219] Fix key migration locking up the Desktop app (#5990)
* Only check to migrate key on VaultTimeout startup

* Remove desktop specific check
2023-08-09 13:01:42 -04:00
André Bispo
4ab6a7fb5d
[PM-3121] Added new copy with exclamation mark 2023-08-09 15:21:57 +01:00
Jake Fink
ea4d584989
[PM-2852] Final merge from Key Migration branch to TDE Feature Branch (#5977) 2023-08-09 09:16:40 -04:00
Jared Snider
deee699ede
PM-3345 - TDE - Desktop - Biometrics setting submenu tweak - do not s… (#5988)
* PM-3345 - TDE - Desktop - Biometrics setting submenu tweak - do not show require MP or PIN entry on restart if user doesn't have at least one of those options b/c otherwise user can get into a bad state where they cannot unlock

* PM-3345 - TDE - Desktop - Settings comp - if user turns off PIN and Biometric is on + require PIN on restart is enabled then must turn that setting off to prevent bad user state

* PM-3345 - Final tweak to logic
2023-08-08 13:56:30 -04:00
Jared Snider
0e2a9e9d92
PM-3331 - TDE - Firefox - Browser extension - fix access denied error… (#5984)
* PM-3331 - TDE - Firefox - Browser extension - fix access denied error on popup load which was caused by the canAccessFeature guard failing to lookup the TDE feature flag as the server config was returning null even after a successful server call as only returned the value if the user was unauthenticated for some reason

* PM-3331 - After discussion with Andre, further refactor ConfigService logic to always return the latest information from the server so that requests for feature flag data will always get the most up to date information.
2023-08-08 11:03:50 -04:00
Jared Snider
185b9b046b
PM-3332 - TDE - SsoLoginStrategy - For existing admin auth reqs, must… (#5980)
* PM-3332 - TDE - SsoLoginStrategy - For existing admin auth reqs, must manually handle 404 error case to prevent app from hanging and clear the local state if the admin auth req in the DB has been purged; i.e., it should fail silently.

* Add TODO for SSO Login Strategy tests
2023-08-08 10:41:22 -04:00
Jared Snider
a7a7aab6c2
PM-3210 - TDE - LoginWithDevice routing fix - Mirror PR #5950 in just simply providing a back action on click which works for all app generated scenarios (#5982) 2023-08-08 10:40:24 -04:00
Jared Snider
adaed6f1d5
PM-3329 - Restore everHadUserKey logic from PM-3169 which I incorrectly removed in order to fix routing logic so that user can lock and land on the lock screen properly (#5979) 2023-08-07 16:50:25 -04:00
Jared Snider
cb1834ae7c
Fix issue where we were incorrectly calling setRememberEmailValues in the AdminAuthRequest state - no need to do this as the email is already saved to state. By calling this method, we would actually overwrite the already saved email with null as the user's choice to remember email wasn't persisted through SSO on the login service. (#5972) 2023-08-07 09:49:44 -04:00
Justin Baur
517a06aa41
Fix AdminAuthRequest Serialization on Desktop (#5970)
- toJSON isn't being called by ElectronStorageService
- Force it's conversion to JSON earlier so it happens for all storage methods
2023-08-06 12:23:15 -04:00
Justin Baur
52543f4df7
Add Missing Slash (#5967) 2023-08-04 21:48:26 -04:00
Todd Martin
cb54f8b64c
[PM-3314] Fixed missing MP prompt on lock component (#5966)
* Updated lock component to handle no master password.

* Added a comment.
2023-08-04 20:37:16 -04:00
Andreas Coroiu
00c4be83cb
[PM-3169] Login decryption options in extension popup (#5909)
* [PM-3169] refactor: lock guard and add new redirect guard

* [PM-3169] feat: implement fully rewritten routing

* [PM-3169] feat: close SSO window

* [PM-3169] feat: store sso org identifier in state

* [PM-3169] fix: tests

* [PM-3169] feat: get rid of unconventional patch method

* PM-3169 - SSO & 2FA Comps - Update naming of new callback to match existing pattern + add tests for callback logic execution.

* PM-3169 - Update LockGuard to have a special exception for allowing the TDE Login with MP flow

* PM-3169 - Per discussion w/ Jake and Justin, rename login-initiated guard to be tde decryption required guard (more named for functionality vs specific route)

* PM-3169 - Add some additional context to new redirect guard scenario

* PM-3169 - Per PR feedback, replace all callback types with Promise<void> as the return values are not being used.

* PM-3169 - StateSvc - Per PR feedback, update setUserSsoOrganizationIdentifier signature to explicitly use null instead of partial<string> which doesn't do anything

* PM-3169 - Replace onSuccessfulLogin type to compile

* PM-3169 - Add clarification comment for why we are not using a query param for persisting the org identifier

* PM-3169 - Per discussion with Justin, only use memory for SsoOrgId as we don't need to persist it beyond that; tested and it worked on all 3 clients for new user TDE creation

* PM-3169 - Add missing ssoIdentifierRequired translation to desktop and browser

* PM-3169 - After discussing with Justin again, we realized that memory doesn't work on desktop if user refreshes app or closes and re-opens it so must use disk.

* PM-3169 - Per PR feedback, remove hasEverHadUserKey logic as we can just leverage existing getUserKey method to check if we have a user key or not; tested all guards in browser and web with no issues

* PM-3169 - Per design discussion with Danielle, move account created toast after successful account creation vs on load of page.

---------

Co-authored-by: Jared Snider <116684653+JaredSnider-Bitwarden@users.noreply.github.com>
Co-authored-by: Jared Snider <jsnider@bitwarden.com>
2023-08-04 17:55:11 -04:00
Todd Martin
bae82ded05
Changed settings menu to be enabled whenever the account is not locked. (#5965) 2023-08-04 17:02:50 -04:00
Justin Baur
7af6aa93e5
[PM-3215][PM-3289] Create MasterKey from Password If Needed (#5931)
* Create MasterKey from Password

- Check if the MasterKey is stored or not
- Create it if it's not

* Add getOrDeriveKey Helper

* Use Helper In More Places
2023-08-04 11:33:18 -04:00
Andreas Coroiu
c56e85687c
[PM-1200] Unlock settings changes for accounts without master password - clients (#5894)
* [PM-1200] chore: add comment for jake

* [PM-1200] chore: rename to `vault-timeout`

* [PM-1200] feat: initial version of `getAvailableVaultTimeoutActions`

* [PM-1200] feat: implement `getAvailableVaultTimeoutActions`

* [PM-1200] feat: change helper text if only logout is available

* [PM-1200] feat: only show available timeout actions

* [PM-1200] fix: add new service factories and dependencies

* [PM-1200] fix: order of dependencies

`UserVerificationService` is needed by `VaultTimeoutSettingsService`

* [PM-1200] feat: add helper text if no lock method added

* [PM-1200] refactor: simplify prev/new values when changing timeout and action

* [PM-1200] feat: fetch timeout action from new observable

* [PM-1200] refactor: make `getAvailableVaultTimeoutActions` private

* [PM-1200] feat: add test cases for `vaultTimeoutAction$`

* [PM-1200] feat: implement new timeout action logic

* [PM-1200] feat: add dynamic lock options to browser

* [PM-1200] feat: enable/disable action select

* [PM-1200] feat: add support for biometrics

* [PM-1200] feat: add helper text and disable unavailable options

* [PM-1200] feat: update action on unlock method changes

* [PM-1200] feat: update browser to use async pipe

* [PM-1200] fix: element not updating

* [PM-1200] feat: hide masterPassOnRestart pin option

* [PM-1200] feat: hide change master password from browser settins

* [PM-1200] feat: hide change master password from app menu

* [PM-1200] feat: logout if lock is not supported

* [PM-1200] feat: auto logout from lock screen if unlocking is not supported

* [PM-1200] feat: remove lock button from web menus

* Revert "[PM-1200] fix: element not updating"

This reverts commit b27f425f48570d0d5dbc9dedb9797023fef64d8b.

* Revert "[PM-1200] feat: update browser to use async pipe"

This reverts commit 766c15bc3dbadcf7dcef3053b148e7874f8939ce.

* [PM-1200] chore: add comment regarding detectorRef

* [PM-1200] feat: remove lock now button from browser settings

* [PM-1200] feat: add `userId` to unlock settings related methods

* [PM-1200] feat: remove non-lockable accounts from menu

* [PM-1200] fix: cli not building

---------

Co-authored-by: Todd Martin <tmartin@bitwarden.com>
Co-authored-by: Jared Snider <116684653+JaredSnider-Bitwarden@users.noreply.github.com>
2023-08-04 09:43:20 -04:00
Robyn MacCallum
f799fd721c
Check if a user has a mp before showing kdf warning (#5929) 2023-08-03 15:54:11 -04:00
Jared Snider
4ac754bee4
TDE - State Svc - setDeviceKey should support setting null for future support of clearing device key. (#5942) 2023-08-02 15:37:41 -04:00
Jared Snider
4f000ac11c
PM-2759 - Fix broken backwards compatibility for authResult.resetMast… (#5940)
* PM-2759 - Fix broken backwards compatibility for authResult.resetMasterPassword

* PM-2759 - Update TODO with specific tech debt task + target release date
2023-08-02 11:06:50 -04:00
Todd Martin
c1006cfa59
Removed buttons (#5935) 2023-08-01 19:40:44 -04:00
Jared Snider
667e8aa550
Merge remote-tracking branch 'origin/master' into feature/trusted-device-encryption + web messages.json merge conflict resolution 2023-08-01 17:41:08 -04:00
Jonathan Prusik
fb74c2d6ee
use EnvironmentService to get the appropriate web vault URL (#5862) 2023-07-31 14:41:41 -04:00
aj-rosado
7ef2acc11a
[PM-2804] Migrate Send List to Component Library (#5796)
* Migrate Send list html to use Component Library and TailWind

* Added ComponentLibrary search module to Send

* Updated the No-Items on Send List to the new CL

* Added missing type on button at send.component.html

* Changed send to standalone component on web

* Moved no send icon to the consuming component

* removed unnecessary href on send component html

* Added sort to send list

* Removed SendComponent from loose-components module and added on app module

* Removed unnecessary click handler on send name button

* Created own file for no-send icon

* set icons folder as lowercase

* Corrected no-send.icon import

* Setting name as default sort on send list

* Added extra height to no-send.icon and removed classes from bit-no-items title container

* Removed the size small from options button
2023-07-31 12:04:33 +01:00
github-actions[bot]
49549cc150
Autosync the updated translations (#5913)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-07-29 10:43:13 +00:00
github-actions[bot]
9b8cd57847
Autosync the updated translations (#5911)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-07-28 08:14:33 +00:00
github-actions[bot]
6f4fc05510
Autosync the updated translations (#5912)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-07-28 08:13:22 +00:00
Shane Melton
e24ef1b9d6
Fix notifications webpack proxy for Web (#5794)
* Update webpack config to support proxying web socket connections for notifications

* turn off runtime error overlay

---------

Co-authored-by: Matt Gibson <mgibson@bitwarden.com>
2023-07-27 11:05:19 -05:00
Andreas Coroiu
db2a21a647
[PM-3210] fix: use back navigation (#5907) 2023-07-27 16:38:57 +02:00
Robyn MacCallum
81320a0d6d
[PM-3101] Fix autofill items not working for users without a master password (#5885)
* Add service factories for user verification services

* Update autofill service to check for existence of master password for autofill

* Update the context menu to check for existence of master password for autofill

* context menu test fixes
2023-07-27 10:19:14 -04:00
Andreas Coroiu
7977776b1c
fix: remove Unauth guard from /login-with-device 2023-07-27 09:33:02 +02:00
cd-bitwarden
54642225ab
647 - rearrange drop downs (#5791) 2023-07-26 20:55:52 -04:00
cd-bitwarden
0fc0e6226f
for secrets manager show SM title (#5780)
* for secrets manager show SM title

* removing convoluted i18 conversion

* removing unused messages, and updating navbar to use the proper messages
2023-07-27 00:53:09 +00:00
Vincent Salucci
090a5bcced
fix: update manage reset password to manage account recovery, refs AC-1542 (#5851) 2023-07-26 13:36:29 -05:00
github-actions[bot]
290c6aee8f
Bumped desktop version to 2023.7.2 (#5901)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-07-26 11:40:22 -04:00
Jared Snider
0b861f4d0c
Auth/pm 1050/pm 1051/remaining tde approval flows (#5864) 2023-07-25 19:25:00 -04:00
Conner Turnbull
ab6085cd88
[AC-1562] Added region custom field to PayPal add credits (#5897)
* Added config service func for getting cloud region

* Updated to use `buildServerConfig`
2023-07-25 15:57:29 -04:00
github-actions[bot]
4ba9427967
Bumped web version to 2023.7.1 (#5896)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-07-25 19:18:16 +00:00
Conner Turnbull
d874573a32
Added region custom field to paypal add credits (#5895) 2023-07-25 13:39:09 -04:00
Todd Martin
9c1247afa3
Added missing localization for trial initiation. (#5891) 2023-07-25 10:36:15 -04:00
Todd Martin
a456e4d3b5
Fixed link to navigate to Members page. (#5892) 2023-07-25 10:31:43 -04:00
Joseph Flinn
ba8ad9598b
Update EU Prod config with correct production payment settings (#5874) 2023-07-25 06:54:12 -07:00
Andreas Coroiu
79d186f4f5
[PM-3120] fix: device key not being saved properly (#5882) 2023-07-25 09:26:14 +02:00
Daniel James Smith
b734edba14
Display importFormatError on failed to parse input (#5809) 2023-07-24 23:07:44 +00:00