* [deps] Tools: Update electron to v28.2.7
* Bump version in electron-builder.json
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
* If editing your own member modal, you cannot add new collections or groups
* Update forms to prevent this
* Add helper text
* Delete unused api method
* [PM-6501] Search field disqualifications preventing filling password input fields
* [PM-6501] Reworking implementation of AutofillService.isSearchField to more carefully test search field attribute keywords
* [PM-6501] Reworking implementation of AutofillService.isSearchField to more carefully test search field attribute keywords
* [PM-6501] Reworking implementation of AutofillService.isSearchField to more carefully test search field attribute keywords
* added showCards and Identities to vault settings and then added migration file
* added migration file and removed fields from domain
* fixed merge conflicts
* Require init in i18n service.
this is needed to load translations and set translation locale
* No longer need to cast i18n
* Expose user preferred locale in i18nService
This is for correctly displaying `default` when no locale has been set in preferences components. The `locale$` observable should always resolve to the currently locale currently being translated to.
Use SafeProvider as a factory for all our providers to ensure
that the DI token, implementation, and deps all match.
---------
Co-authored-by: Matt Gibson <mgibson@bitwarden.com>
* create domain settings state provider
* replace callsites for defaultUriMatch and neverDomains with DomainSettingsService equivalents
* replace callsites for equivalentDomains with DomainSettingsService equivalents and clean up unused AccountSettingsSettings
* add migrations for domain settings state
* do not use enum for URI match strategy constants and types
* add getUrlEquivalentDomains test
* PR suggestions/cleanup
* refactor getUrlEquivalentDomains to return an observable
Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com>
* update tests
* add UriMatchStrategy docs notes
* service class renames
* use service abstraction at callsites previously using service class directly
---------
Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com>
* add key definition and StrategyData classes
* use state providers for login strategies
* serialize login data for cache
* use state providers for auth request notification
* fix registrations
* add docs to abstraction
* fix sso strategy
* fix password login strategy tests
* fix base login strategy tests
* fix user api login strategy tests
* PM-3339 add tests for admin auth request in sso strategy
* fix auth request login strategy tests
* fix webauthn login strategy tests
* create login strategy state
* use barrel file in common/spec
* test login strategy cache deserialization
* use global state provider
* add test for login strategy service
* fix auth request storage
* add recursive prototype checking and json deserializers to nested objects
* fix CLI
* Create wrapper for login strategy cache
* use behavior subjects in strategies instead of global state
* rename userApi to userApiKey
* pr feedback
* fix tests
* fix deserialization tests
* fix tests
---------
Co-authored-by: rr-bw <102181210+rr-bw@users.noreply.github.com>
* Remove Unused services
* Split platform utils between foreground and background
* Respond to clipboard clearing and biometric unlock
* Use new browser platform utils
* Fix folder name
* Fix imports
* biometrics is supported only on windows and mac
* Reject native messaging with errors
We're now going through the runtime background, which expects error objects in message failures
* Improve state documentation
* Add namespace for application id
* Spec out behavior of app id service
* Use state providers for app ids
* Migrate app Id
* Add reactive interface
UI warns the user whenever using secure storage in browser that it's
insecure. This is not a change from the current background behavior,
just uses the already existing services in each context.
* Use state provider to store preferred language
* migrate preferred language
* Use new i18n provider to get LOCAL_ID
* Fix preloaded english i18n
This is a mock service that forces english translations, it doesn't need the i18n interface that allows changing of locales.
* PR improvements
* Fixup merge
* [deps] Platform: Update Rust crate libsecret to v0.5.0
* Update gio to match with the version from libsecret
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com>
* add enableContextMenu to autofillSettings and migrate disableContextMenuItem
* replace usages of disableContextMenuItem with autofill settings service global enableContextMenu
Turns out the HCaptcha accessibility feature on desktop stopped working a while back. This PR resolves it and tweaks the implementation to use norefeerer and noopener for improved sandboxing. This comes with the slight tweak in behaviour namely we now get the cookie when you click the back button.
To fix hcaptcha not working I needed to use the correct session storage.
* [deps] Tools: Update electron to v28.2.6
* Update version in electron-builder.json
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
* funnel rp name or id to the cipher name on save
* remove comment
* add rp name and id to addCipher function
---------
Co-authored-by: Merissa Weinstein <merissaweinstein@merissas-mbp-2.lan>
* [PM-5880] Refactor Browser Platform Utils Service to Remove Window Service
* [PM-5880] Implementing BrowserClipboardService to handle clipboard logic between the BrowserPlatformUtils and offscreen document
* [PM-5880] Adjusting how readText is handled within BrowserClipboardService
* [PM-5880] Adjusting how readText is handled within BrowserClipboardService
* [PM-5880] Working through implementation of chrome offscreen API usage
* [PM-5880] Implementing jest tests for the methods added to the BrowserApi class
* [PM-5880] Implementing jest tests for the OffscreenDocument class
* [PM-5880] Working through jest tests for BrowserClipboardService
* [PM-5880] Adding typing information to the clipboard methods present within the BrowserPlatformUtilsService
* [PM-5880] Working on adding ServiceWorkerGlobalScope typing information
* [PM-5880] Updating window references when calling BrowserPlatformUtils methods
* [PM-5880] Finishing out jest tests for the BrowserClipboardService
* [PM-5880] Finishing out jest tests for the BrowserClipboardService
* [PM-5880] Implementing jest tests to validate the changes within BrowserApi
* [PM-5880] Implementing jest tests to ensure coverage within OffscreenDocument
* [PM-5880] Implementing jest tests for the BrowserPlatformUtilsService
* [PM-5880] Removing unused catch statements
* [PM-5880] Implementing jest tests for the BrowserPlatformUtilsService
* [PM-5880] Implementing jest tests for the BrowserPlatformUtilsService
* [PM-5880] Fixing broken tests
* Fix invite member dialog not submitting on enter
updateOn: onBlur is unnecessary with component library forms
and was preventing the form from being submitted without deselecting
the email field
* Simplify name for validator
* [PM-5879] Removing `backgroundWindow` reference used for determing system theme preference in Safari
* [PM-5879] Removing `backgroundWindow` reference used for determing system theme preference in Safari
* [PM-5879] Reworking factory logic within ThemingService factory
* [PM-5876] Adjust LP Fileless Importer to Suppress Download with DOM Append in Manifest v3
* [PM-5876] Incorporating jest tests for affected logic
* [PM-5876] Fixing jest test that leverages rxjs
* [PM-5876] Updating documentation within BrowserApi.executeScriptInTab
* [PM-5876] Implementing jest tests for the new LP suppress download content scripts
* [PM-5876] Adding a change to webpack to ensure we do not package the mv2 side script for `lp-suppress-import-download.mv2.ts` if building the extension for mv3
* [PM-5876] Implementing changes based on feedback during code review
* [PM-5876] Implementing changes based on feedback during code review
* [PM-5876] Implementing changes based on feedback during code review
* [PM-5876] Implementing changes based on feedback during code review
* [PM-5876] Implementing a configuration to feed the script injection of the Fileless Importer CSV download supression script
* Migrate existing provider data to StateProvider
Migrate existing provider data to StateProvider
* Rework the ProviderService to call StateProvider
* Unit test the ProviderService
* Update DI to reflect ProviderService's new args
* Add ProviderService to logout chains across products
* Remove provider related stateService methods
* Update libs/common/src/state-migrations/migrations/28-move-provider-state-to-state-provider.spec.ts
Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
* Cover up a copy/paste job
* Compare equality over entire array in a test
---------
Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
* create user notification settings state provider
* replace state service get/set disableAddLoginNotification and disableChangedPasswordNotification with user notification settings service equivalents
* migrate disableAddLoginNotification and disableChangedPasswordNotification global settings to user notification settings state provider
* add content script messaging the background for enableChangedPasswordPrompt setting
* Implementing feedback to provide on PR
* Implementing feedback to provide on PR
* PR suggestions cleanup
---------
Co-authored-by: Cesar Gonzalez <cgonzalez@bitwarden.com>
* Revert "[PM-5277] Migrate Sync Service to State Provider (#7680)"
This reverts commit 78008a9e1e.
Includes a noop migration builder that allows us to bridge over the deleted migration
* Prefer revert migrations to noop
this revert avoids the need to change behavior between released vs unreleased migrations and keeps some dangerous code out of the repo :success:
* Update ordering of badge settings migrator to be consistent with `rc`, which was cut with only up to version 25
* Fix missing type import
* [PM-673] Safari Notification Bar Does Not Show Folders
* [PM-673] Refactoring Context Menu Implementations to Ensure Pages with No Logins Can Dismiss Notification Bar
* [PM-673] Refactoring typing information for the LockedVaultPendingNotificationsItem typing
* [PM-673] Refactoring typing information for notification background
* [PM-673] Finishing out typing for potential extension messages to the notification bar;
* [PM-673] Working through implementation details for the notification background
* [PM-673] Fixing issues present with messaging re-implementation
* [PM-673] Fixing issue with folders not populating within Safari notification bar
* [PM-673] Fixing jest test issues present within implementation
* [PM-673] Fixing issue present with webVaultUrl vulnerability
* [PM-673] Fixing XSS Vulnerability within Notification Bar;
* [PM-5670] Putting together a partial implementation for having messages appear on network error within the notification bar
* [PM-673] Incorporating status update for when user has successfully saved credentials
* [PM-673] Incorporating status update for when user has successfully saved credentials
* [PM-5949] Refactor typing information for notification bar
* [PM-5949] Fix jest tests for overlay background
* [PM-5949] Removing unnused typing data
* [PM-5949] Fixing lint error
* [PM-5949] Adding jest tests for convertAddLoginQueueMessageToCipherView method
* [PM-5949] Fixing jest test for overlay
* [PM-5950] Fix Context Menu Update Race Condition and Refactor Implementation
* [PM-5950] Adding jest test for cipherContextMenu.update method
* [PM-5950] Adding documentation for method within MainContextMenuHandler
* [PM-5950] Adding jest tests for the mainContextMenuHandler
* [PM-673] Stripping unnecessary work for network drop issue
* [PM-673] Stripping unnecessary work for network drop issue
* [PM-2753] Prompt to Save New Login Credentials Silently Drops Data on Network Error
* [PM-673] Stripping out work done for another ticket
* [PM-4566] Fix santization check issue found with webVaulUrl in notification bar
* [PM-4566] Refactoring implementation
* [PM-5950] Removing unnecessary return value from MainContextMenuHandler.create method
* [PM-673] Implementing unit test coverage for newly introduced logic
* [PM-673] Implementing unit test coverage for newly introduced logic
* [PM-673] Implementing unit test coverage for newly introduced logic
* [PM-673] Implementing unit test coverage for newly introduced logic
* [PM-2753] Implementing jest tests to validate logic changes
* [PM-2753] Implementing jest tests to validate logic changes
* [PM-2753] Implementing jest tests to validate logic changes
* [PM-2753] Implementing jest tests to validate logic changes
* [PM-2753] Incorporating addition of green and red borders when success or error events occur
* [PM-4566] Adding jest test to validate changes within the notification background
* [PM-5950] Fixing unawaited context menu promise
* [PM-673] Merging changes in from main and fixing merge conflicts
* [PM-2753] Merging work in from main and resolving merge conflicts
* [PM-6122] Rework `window` call within NotificationBackground to function within content script
* [PM-4566] Incorporating a more fleshed out implementation to remove queryParams from the notification bar url entirely
* [PM-673] Fixing issue where updates to the added login were not triggering correctly
* [PM-673] Merging changes in from main and fixing merge conflicts
* [deps] Tools: Update electron to v28.2.5
* Update version in electron-builder.json
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
* Establish biometric unlock enabled in state providers
* Use biometric state service for biometric state values
* Migrate biometricUnlock
* Fixup Dependencies
* linter and import fixes
* Fix injection
* Fix merge
* Use boolean constructor as mapper
* Conform to documented test naming conventions
* Commit documentation suggestion
Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
* Fix merge commit
* Fix test names
---------
Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
* [deps] Tools: Update electron-builder to v24
* Add ElectronTeamID
* Remove double signing and use the proper extraFiles for safari extension
* Revert "Remove double signing and use the proper extraFiles for safari extension"
This reverts commit 94635dbd02.
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Hinton <hinton@users.noreply.github.com>
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
* create badge settings state provider
* replace state service get/set disableBadgeCounter with badge settings service equivalent
* migrate disableBadgeCounter account setting to badge settings state provider
* cleanup and address PR suggestions
* Sent initiation path for organization and user signups
* Rename organizationQueryParameter > organizationTypeQueryParameter
* Jared's feedback
* Split PM & SM initiation path
