1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-24 12:06:15 +01:00
Commit Graph

3326 Commits

Author SHA1 Message Date
Nick Krantz
01e530d02b
[PM-11691] Remove Nord and Solarized Dark from extension (#11013)
* remove nord and solarized dark from AppearanceV2 component
- This component already behind the extension refresh feature flag

* update the users theme to system when nord or solarized dark is selected

* For desktop, still allow all theme types by overriding the default theme service.

* change theme on the fly rather than updating local state.

- When the feature flag is removed then a migration will have to take place
2024-09-19 10:55:40 -05:00
Ike
afff91e0f3
added duofederal.com to valid urls (#11137) 2024-09-19 11:32:42 -04:00
bw-ghapp[bot]
19f4afcd2b
Bumped client version(s) (#11152)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-09-19 14:27:51 +00:00
Oscar Hinton
e5bb2e58a6
[PM-12004] Fix ~60 compile warnings in webpack for web (#11004) 2024-09-19 15:00:07 +02:00
Oscar Hinton
6ffd85c42c
[PM-11342] Fix 404 missing styles (#11147)
Fix 404 page lacking styles on nested pages.
2024-09-19 14:56:47 +02:00
renovate[bot]
a96e3cb647
[deps] Tools: Update electron to v32.1.1 (#11067)
* [deps] Tools: Update electron to v32.1.1

* Bump version in electron-builder.json

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-09-18 23:41:07 +02:00
Jordan Aasen
00f2317a82
[PM-11903] - add file send component (#11132)
* wip - send file details

* wip - file send

* send file details

* fix click on send list container

* remove popup code

* remove popup code

* finalize send file details

* address PR feedback. add base form to send form

* revert changes to send list items container

* revert changes to send list items container

---------

Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2024-09-18 14:36:53 -07:00
Alec Rippberger
2b85392b0f
PM-11338: [Defect] Clicking outside of View {Item} dialog should close the dialog properly (#11035)
* Handle undefined result.

* Updated enum values for consistency.
2024-09-18 16:02:47 -05:00
Alec Rippberger
6c1d74a4ce
[PM-11395] [Defect] View Login - TOTP premium badge does nothing when clicked (#10857)
* Add MessagingService to LoginCredentialView component.

* Add comments.

* Add WIP PremiumUpgradeService

* Simplify web PremiumUpgradeServices into one service.

* Relocate service files.

* Add browser version of PremiumUpgradePromptService.

* Cleanup debug comments.

* Run prettier.

* rework promptForPremium to take organization id and add test.

* Add test for browser

* Rework imports to fix linter errors.

* Add Shane's reworked WebVaultPremiumUpgradePromptService.
2024-09-18 16:00:54 -05:00
cyprain-okeke
1940256fe2
Resolve the discount issue (#11128) 2024-09-18 18:55:31 +01:00
Alec Rippberger
931f86c948
[PM- 9666] Implement edit item view individual vault (#10553)
* Add initial vault cipher form for cipher edit.

* Add ability to add new cipher by type

* Add ability to save and clone cipher,

* Update canEditAllCiphers to take 1 argument.

* Add attachments button to add/edit dialog.

* Add semi-working attachment dialog.

* Add working attachment functionality.

* Remove debugging code.

* Add tests for new attachments dialog component.

* Add AddEditComponentV2 tests.

* Remove AddEditComponentV2 delete functionality.

* Remove unnecessary else statement.

* Launch password generation in new dialog when extension refresh enabled.

* Add tests for PasswordGeneratorComponent.

* Adjust password and attachments dialog sizes.

* run lint:fix

* Remove unnecessary form from button.

* Add missing provider in test.

* Remove password generation events.

* Add WebVaultGeneratorDialogComponent and WebCipherFormGenerationService

* Move and rename CipherFormQueryParams

* Use WebCipherFormGenerationService to launch password / user generation modals.

* Add WebVaultGeneratorDialogComponent tests.

* Remove unnecessary functionality and corresponding tests.

* Fix failing tests.

* Remove unused properties from AddEditComponentV2

* Pass CipherFormConfig to dialog.

* Clean up unused attachment dialog functionality.

* Update AddEdit cancel functionality to prevent navigating user.

* Make attachment dialog open a static method.

* Add addCipherV2 method and clean up tests.

* Remove changes to QueryParams.

* Add tests for WebCipherFormGenerationService

* Remove unused onCipherSaved method.

* Remove cipherSaved event.

* Remove unused password generator component

* Refactor to simplify editCipherId for extensionRefresh flag.

* Add additional comments to AddEditComponentV2.

* Simplify open vault generator dialog comment.

* Remove unused organizationService

* Remove unnecessary typecasting.

* Remove extensionRefreshEnabled and related.

* Remove slideIn animation

* Remove unused AddEditComponentV2 properties.

* Add back generic typing.

* Condesnse properties into single form config.

* Remove onDestroy and related code.

* Run prettier

* fix injection warning

* Handle cipher save.

* Redirect to vault on delete and make actions consistent.

* Update comment.
2024-09-18 12:48:47 -05:00
Daniel James Smith
a674f698a2
[PM-12067] Add sorting to exposed passwords report (#11029)
* Add sorting to exposed passwords report

- Create new type to represent a row within the report
- Add types and remove usage of any
- Include the exposed number of times within the data passed to the datasource/table instead of looking it up via the `exposedPasswordMap`
- Enable sorting via bitSortable
- Set default sort to order by exposed number of times in descending order

* Show headers and sort also within AC version of exposed-passwords report but hide the Owner column

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-09-18 18:53:04 +02:00
David Torosyan
2d7fb035d4
[desktop] Allow manual sync while locked (#6126)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-09-18 17:57:32 +02:00
cyprain-okeke
727fbb6731
Ac 3030 discount is not included in the pricing breakdown when annual plan (#11126)
* Resolve the discount issues

* Resolve the payment cvv alignment

* Resolve the wrong message for secrets manager

* Remove unused commented code

* resolve the display message bug on sm flow
2024-09-18 16:22:04 +01:00
Bernd Schoolmann
f6e51ef024
Don't process reload when cancelling biometrics (#11081) 2024-09-18 10:41:23 -04:00
Jordan Aasen
f8fc6269f2
[PM-11899] - send text details component (#11002)
* Temporary local changes not meant to be merged

* WIP - send text details

* send text details

* remove extraneous code

* create base send details component

* remove file components

* fix send text details form

* remove comments

* fix send text details component

* revert type changes

* send created redirect

* Revert "send created redirect"

This reverts commit 36711d54a3.

* Removed hint under textArea, as per design

* Removed unused message keys

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-09-18 14:04:51 +02:00
Bernd Schoolmann
1b7bb014d2
[PM-11312] Add "prevent screenshot" setting to windows and mac (#10707)
* Add screenshot protection to windows and mac

* Update messaging of screencapture prevention feature

* Set default state to false
2024-09-18 12:38:35 +02:00
bw-ghapp[bot]
18ef74930c
Bumped client version(s) (#11118)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-09-18 00:39:01 +00:00
Justin Baur
e8979decae
Add Back Safari Only Handling of Process Reload (#11115) 2024-09-17 16:58:23 -04:00
Shane Melton
99ba56785d
[PM-11393] Remove the need for TotpCaptureService in Autofill Options View component (#11093) 2024-09-17 13:15:11 -07:00
Alec Rippberger
80a9836cb2
Navigate to fault after cipher deleted. (#11042) 2024-09-17 14:00:21 -05:00
Jason Ng
d0516f24e8
[AC-2627] Empty Collection New Item Btn Permissions (#11089)
* only show new item btn in empty collection for can edit perm
2024-09-17 14:28:39 -04:00
Nick Krantz
d68853a4a2
[PM-11131] Screen Reader Announcements for Copy (#11091)
* add copy specific aria-labels for login ciphers

* add copy specific aria-labels for card ciphers

* add copy translations for identity to web translations
2024-09-17 13:23:15 -05:00
Nick Krantz
a42006763d
[PM-9455] FireFox back handling (#10867)
* Refactor `POPUP_VIEW_MEMORY` to use `disk` rather than memory for the browser extension.

- When FireFox opens the popup in an standalone window memory is lost, thus causing the `popup-route-history` to be lost and back navigation ceases to work

* spelling

* revert state definition change

* add `onUpdated` event for firefox

* rework observable handling

* remove unneeded `from`
2024-09-17 08:42:57 -05:00
Rui Tomé
c05b6eb116
[PM-11667] Remove all code related to the outdated custom permissions 'Edit/Delete Assigned Collections' (#10904)
* [PM-11667] Remove all code related to the outdated custom permissions 'Edit/Delete Assigned Collections'

* Revert change made to data model in state migration
2024-09-17 14:22:17 +01:00
Justin Baur
1ebef296b9
[PM-12024] Move Lock All To Happen in Background (#11047)
* Move Lock All To Happen in Background

- Make it done serially
- Have the promise only resolve once it's complete

* Unlock Active Account Last

* Add Tests

* Update Comment
2024-09-16 16:08:03 -04:00
Victoria League
112bad03b1
[PM-8582] Move Safari browser check to libs/platform (#11007) 2024-09-16 15:36:05 -04:00
Nick Krantz
26f3dcfc66
add back events for browser refresh extension (#11085)
- something went sideways in a merge
2024-09-16 14:02:20 -05:00
SmithThe4th
51a2ec393c
[PM-11693] Restoring/permanently deleting item from View item page takes you to Vault page (#10995)
* route to trash after restore or delete

* route to trash after restore or delete
2024-09-16 14:08:01 -04:00
Bernd Schoolmann
15610906d2
[PM-7608] Account Security Settings V2 (#10441)
* Implement account security settings v2

* Increase await dialog delay to 500 msec

* Update messages

* Replace platformservice with biometricsservice

* Cleanup

* Cleanup

* Fix account security component according to feedback

* Re-add old message

* Re-add old error message

* Fix minimum timeout message

* Fix screen-reader on custom timeout

* Remove debugging configurations

* Fix incorrectly changed message

* Remove custom vault timeout text

* Restore vaultTimeoutPolicyInEffect i18n message in web

* Change text to use vaultTimeoutPolicyInEffect1

* Fix tests
2024-09-16 17:40:08 +02:00
Thomas Avery
31a5aa9dd7
[PM-12011] Fix Unlock with biometrics on the Safari browser extension (#11040)
* Add biometricUnlockAvailable to SafariWebExtensionHandler
2024-09-16 09:59:25 -05:00
Alex Morask
096a2563bb
Piped submit text to i18n (#11078) 2024-09-16 10:23:10 -04:00
renovate[bot]
16651214ac
[deps] Platform: Update @types/node to v20.16.5 (#11058)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-16 09:47:56 -04:00
Cesar Gonzalez
b0e0e71974
[PM-11517] Improve autofill collection of page details performance (#10816)
* Testing out a rework of the performance improvements introduced into extension

* Working through improvements

* Implementing max_depth methodology for the deepQuery approach used when querying elements

* Refactoring implementation

* Refactoring implementation

* Fixing jest tests

* Incorporating documenation within domQueryService

* [PM-11519] `browser` global reference triggering an error when sending an extension message

* [PM-11517] Working through refactoring and jest testing of the domQueryService

* [PM-11517] Working through refactoring and jest testing of the domQueryService

* [PM-11517] Incorporating tests for the debounce util method

* [PM-11517] Incorporating tests for the debounce util method

* [PM-11517] Removing unnecessary property

* [PM-11517] Starting to work through an idea regarding querying without the shadowDom on pages that definitively do not contain a ShadowDOM element

* [PM-11419] Adjusting implementation to ensure we clear any active requests when the passkeys setting is modified

* [PM-11517] Removing unnecessary comments
2024-09-16 08:35:56 -05:00
renovate[bot]
62ee447c36
[deps] Autofill: Update tldts to v6.1.46 (#11054)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-16 09:34:33 -04:00
Nick Krantz
c64477034a
set extensionRefreshEnabled to be undefined so the "new" button isn't shown until the feature flag is resolved (#11038) 2024-09-16 08:33:23 -05:00
Oscar Hinton
20d83ab198
[PM-2718] Set nspasteboard.ConcealedType for clipboard on MacOS (#11025)
Enables the use of `exclude_from_clipboard` for macos, introduced in recent version of arboard
2024-09-16 15:16:28 +02:00
cyprain-okeke
f816e80314
[AC-3023] Resolve the capitalization here (#11019)
* Resolve the capitalization here

* Resolve the returned issue on A11y

* Fix the storage bug
2024-09-16 10:14:46 +01:00
rr-bw
b713e18b1a
remove duplicate route (#11034) 2024-09-13 10:46:31 -07:00
rr-bw
96d116d643
[PM-8116] Auth Browser Refresh: Password Hint Component (#10492)
* setup component, services, and web HTML

* make Web and Browser functional

* make desktop functional

* update template to solidify common client HTML

* simplify template and class

* update browser routing

* move canActivate to correct location

* simplify post submit routing

* update routing to use unauthUiRefreshSwap()

* constrain AnonLayout title/subtitle width, reduce height on destkop to account for header

* reduce height on browser to account for header (otherwise have to scroll to see EnvSelector

* resolve email issue when clicking 'cancel' on extension popout

* update routing for web

* persist email to popout

* update web router and anon-layout min-h based on client

* change anchor link to button

* remove unnecessary formatting changes

* add new icon

* remove unnecessary call to loginEmailService
2024-09-13 09:16:25 -07:00
Bernd Schoolmann
54cc35e29a
[PM-6037] Fix process reload not triggering on inactive account lock/logout (#9805)
* Send loggedOut/locked events on logout/lock event

* Revert "Send loggedOut/locked events on logout/lock event"

This reverts commit 293f2d6131.

* Ensure loggedOut is sent for non-active user logouts too

* Make loggedOut accept userIds

* Add userBeingLoggedOut in desktop app component

* Await updateconnection calls
2024-09-13 18:11:05 +02:00
Alex Morask
0080fcc979
Use payment-v2.component in trial-billing-step.component (#11010) 2024-09-13 09:29:11 -04:00
Jonathan Prusik
e72203d5e0
fix typos (#11011) 2024-09-13 09:17:07 -04:00
github-actions[bot]
83a11a195e
Autosync the updated translations (#11022)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-09-13 09:50:20 +00:00
renovate[bot]
1e76d237e8
[deps] Platform: Update Rust crate arboard to v3.4.1 (#11017)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-13 10:54:40 +02:00
github-actions[bot]
739b34da2f
Autosync the updated translations (#11020)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-09-13 08:09:18 +00:00
github-actions[bot]
650b183d08
Autosync the updated translations (#11021)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-09-13 08:01:06 +00:00
Jordan Aasen
023912c53d
[PM-11631] - hide free Bitwarden Families button if user is not eligible (#10971)
* hide  Free Bitwarden Families button if user is not eligible

* use organizationService.canManageSponsorships$ for determining if free bitwarden families is available

* update comment
2024-09-13 11:58:18 +10:00
Jared Snider
bd3863c313
Auth/PM-11969 - Registration with Email Verification - Accept Emergency Access Invite Flow (#11018)
* PM-11969 - Registration with Email Verification - Accept Emergency Access Invite Fixed

* PM-11969 - Fix PR feedback

* PM-11969 - AcceptEmergencyComponent - remove prop
2024-09-12 20:14:37 -04:00
Justin Baur
fe96aa85f2
[PM-12007] Fix vault timeout action logout with account switching (#11008)
* Protect Against Toast Error

* Use `concatMap` Instead of `switchMap`
2024-09-12 15:59:33 -04:00
Nick Krantz
70fbcf2a10
[PM-11657] Stripe + Browser Refresh Styling (#10978)
* add check for `ExtensionRefresh` in StripeService

- Stripe components need new styles to match the new CL components

* add global styles for Stripe components

- Matches closer to the browser refresh components

* add browser refresh component details to Stripe JS initialization

* add component to match the display of the new component library that shows only when the `ExtensionRefresh` flag is enabled

* update both payment components to use payment label component

- This styling of the label is separate from the `AC2476_DeprecateStripeSourcesAPI` flag

* update security code copy

* change layout of the trial component to account for new CL components

* absolutely position label to remove extra spacing around the label

* remove unneeded logic
2024-09-12 14:37:44 -05:00
Jared Snider
b6cde7e3ef
Auth/PM-11945 - Registration with Email Verification - Fix Org Sponsored Free Family Plan not working (#11012)
* PM-11945 - AcceptOrg - fix inaccurate comment.

* PM-11945 - Refactor new registration process to pass along orgSponsoredFreeFamilyPlanToken

* PM-11945 - RegistrationFinishComponent - wire up passing of orgSponsoredFreeFamilyPlanToken to submit method

* PM-11945 - Add todo
2024-09-12 15:24:35 -04:00
cyprain-okeke
fc2c83f0d3
[AC-3022]Selecting a plan makes the plan cards content to auto-adjusts (#10992)
* Resolve the recommended issue

* Resolve the discount display issues

* remove unused tw property

* Resolve all the outstanding bugs

* Fix the A11y bug

* Resolve the base storage issue

* Rename service account in the summary

* changes for the A11y bug

* Fix the improper keyboard navigation in modal

* Add some additional ui changes
2024-09-12 19:12:38 +01:00
Daniel James Smith
f70b3df2d2
[PM-11949] Fix generating and copying export password (#10999)
* Use password field value instead of local variable for copy to clipboard

Use appCopyClick directive instead of manually copying and showing success toast

* Add missing "copySuccessful" message key to desktop and web

* Remove whitespace from web en/messages.json

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-09-12 20:04:39 +02:00
Jake Fink
07d2e36496
[PM-10914] add option to delete all folders if migration fails (#10983)
* add option to delete all folders if migration fails

* update text and flow to reattempt migration

* clear encrypted folders as well on delete all

* Update messaging
2024-09-12 13:47:35 -04:00
Jason Ng
89751f46d6
[PM-254] Set PDF Attachments in Web to download, add success toast (#10757)
* add success toast to pdf attachment download in web

* update desktop attachments for toastService

* removed trailing comma

---------

Co-authored-by: gbubemismith <gsmithwalter@gmail.com>
Co-authored-by: SmithThe4th <gsmith@bitwarden.com>
2024-09-11 15:27:53 -04:00
Alex Morask
2cfbfcbdfe
Run prettier (#10993) 2024-09-11 15:03:39 -04:00
Victoria League
a0a0a7ae13
[CL-395] Add and use art colors in svgs (#10990) 2024-09-11 14:54:07 -04:00
Shane Melton
8e4dab5eba
[PM-10996] Remove restrict-provider-access feature flag (#10977) 2024-09-11 10:45:23 -07:00
Nick Krantz
db9003458b
[PM-11436] New "+" button (#10907)
* replace icon in "new" button on admin-console

* replace icon in "new" button on secrets manager

* reduce flash of "new item" button by checking the availability of the organization
2024-09-11 11:29:53 -05:00
Alex Morask
4fa31b8f2b
Use payment-v2.component in change-plan-dialog.component when FF is on (#10976) 2024-09-11 09:48:22 -04:00
renovate[bot]
35f4b4c7ac
[deps] Vault: Update https-proxy-agent to v7.0.5 (#7932)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-10 16:01:37 -07:00
Jared Snider
546115876f
Move extension refresh redirect util function to libs so other clients can use it (#10979) 2024-09-10 17:47:16 -04:00
SmithThe4th
8921230b4f
[PM-11200] Move delete item permission to Can Manage (#10890)
* Refactored the showDelete function to check if a user can manage a collection

Removed the can edit or manage cipher check from the show delete function

* Add check for AC vault to return true when user has admin access

* Check user is an admin or custom user with editAnyCollection

* Check user is an admin or custom user with editAnyCollection
2024-09-10 14:15:01 -04:00
Bitwarden DevOps
744a48183b
Bumped client version(s) (#10975) 2024-09-10 16:47:18 +00:00
✨ Audrey ✨
4128b18b27
[PM-8279] password generation component (#10805) 2024-09-10 12:43:33 -04:00
Jared Snider
2d02b6ca5c
Auth/PM-11252 - Registration with Email Verification - Add new redirect connector (#10682)
* PM-11252 - Registration with email verification - Add new signup redirect connector

* PM-11252 - Make the redirect connector generic and extensible while updating it to reference the new fragment based approach which prevents open redirects and prevents the query string from being sent to servers or proxies.

* PM-11252 - PR feedback - refactor redirect to simply forward any fragment onward with no query param parsing required leading to an even more generic solution.

* PM-11252 - Docs

* PM-11252 - PR Feedback - Include styles in chunks to remove need to manually import scss

* PM-11252 - Update redirect html to tailwind.
2024-09-10 11:29:48 -04:00
cyprain-okeke
c1b1db071d
[AC-3029][Defect] Organization storage count is not carried over to the Upgrade dialog Total section (#10965)
* Resolve the ui changes issues

* Resolve the storage ui issue
2024-09-10 12:57:47 +01:00
renovate[bot]
71e5bcb947
[PM-11885] [deps] Tools: Update electron to v32.0.2 (#10964)
* [deps] Tools: Update electron to v32.0.2

* Bump version electron-builder.json

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2024-09-10 12:02:05 +02:00
Daniel James Smith
1bf29f8285
Typescript 5.3: Fix-super-missuse-on-instance-properties (#10952)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-09-09 19:32:13 +02:00
cyprain-okeke
e786eac87d
Resolve the ui changes issues (#10955) 2024-09-09 18:21:09 +01:00
Tom
8a199a1f66
[AC-2614] Member Access Localization (#10931)
* Initial setup and modifications for member access report api implementation

* Adding the permissions logic for getting the permissions text

* fixing the test cases

* Some refactoring on async calls

* Comments on the model

* Resolving the mock issue

* messages

* Localization of text

* One more file to fix merge
2024-09-09 11:48:08 -04:00
Bitwarden DevOps
456b156729
Bumped client version(s) (#10961) 2024-09-09 15:05:49 +00:00
github-actions[bot]
4624cd8506
Autosync the updated translations (#10958)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-09-09 14:58:13 +00:00
Bitwarden DevOps
55cd021471
Bumped client version(s) (#10960) 2024-09-09 14:57:25 +00:00
github-actions[bot]
bf7a490a76
Autosync the updated translations (#10959)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-09-09 14:55:53 +00:00
github-actions[bot]
e37af18359
Autosync the updated translations (#10957)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-09-09 14:39:28 +00:00
rr-bw
d189b4e294
[PM-8013] CLI MAC failure logs - update secureStorageService deps (#10935) 2024-09-09 10:05:04 -04:00
Jared Snider
e954621761
Auth/PM-10684 - Fix CLI asking for MP even if session key provided as command option (#10917)
* PM-10684 - ServiceContainer - Add better docs

* PM-10684 - UserAutoUnlockKeyService - setUserKeyInMemoryIfAutoUserKeySet - refactor method to return a bool instead of nothing so users can know if a user key was retrieved & set without another call.

* PM-10684 - Remove async code ( Program.ts) responsible for setting the auto user key from the session option handler (event emitter which fires when a user passes --session <sessionKey> to a command). Returning this to synchronous execution prevents a race condition between the setting of the user key and the command executing the exitIfLocked logic in the base-program which would check if the user key had been set to determine if the command should be allowed to execute or if the user was locked. When running a loop from a script, the command would often trigger the exitIfLocked before the auto user key could be set in state from the option:session session.

* PM-10684 - Clean up missed item per PR feedback
2024-09-09 10:03:30 -04:00
Conner Turnbull
60e9969017
[AC-2568] Split billing history calls to separately call for invoices and transactions. Added paging buttons (#10697)
* Split billing history calls to separately call for invoices and transactions. Added paging button

* Added missing button types
2024-09-09 09:39:02 -04:00
Jordan Aasen
9e45e32c7d
[PM-8277] - Password generator history component (#10921) 2024-09-09 09:25:41 -04:00
Todd Martin
ed4d481e4d
[PM-7646][PM-5506] Revert IPC changes (#10946)
* Revert "Remove unnecessary plist keys in desktop_proxy (#10933)"

This reverts commit 4dbb036df1.

* Revert "Fix TestFlight errors caused by desktop_proxy (#10928)"

This reverts commit 40cb4b5353.

* Revert "[PM-5506] Enable electron fuses (#10073)"

This reverts commit 78c5e9c706.

* Revert "[PM-7846] Implement a rust based native messaging proxy and IPC system (#9894)"

This reverts commit 55874b72bf.
2024-09-09 09:09:17 -04:00
Cesar Gonzalez
2827d338ee
[PM-11419] Fix issues encountered with inline menu passkeys (#10892)
* [PM-11419] Login items do not display after adding passkey

* [PM-11419] Login items do not display after adding passkey

* [PM-11419] Incorporating fixes for deleting a cipher from the inline menu as well as authenticating using passkeys

* [PM-11419] Fixing an issue where master password reprompt is ignored for a set passkey cipher

* [PM-11419] Fixing an issue where saving a passkey does not trigger a clearing of cached cipher values

* [PM-11419] Refactoring implementation

* [PM-11419] Ensuring that passkeys must be enabled in order for ciphers to appear

* [PM-11419] Adding an abort event from the active request manager

* [PM-11419] Adding an abort event from the active request manager

* [PM-11419] Working through jest tests within implementation

* [PM-11419] Fixing jest tests within Fido2ClientService and Fido2AuthenticatorService

* [PM-11419] Adding jest tests for added logic within OverlayBackground

* [PM-11419] Adding jest tests for added logic within OverlayBackground

* [PM-11419] Reworking how we handle assuming user presence when master password reprompt is required

* [PM-11419] Reworking how we handle assuming user presence when master password reprompt is required

* [PM-11419] Reworking how we handle assuming user presence when master password reprompt is required

* [PM-11419] Refactoring implementation

* [PM-11419] Incorporating suggestion for reporting failed passkey authentication from the inline menu

* [PM-11419] Reworking positioning of the abort controller that informs the background script of an error

* [PM-11419] Scoping down the behavior surrounding master password reprompt a bit more tightly

* [PM-11419] Reworking how we handle reacting to active fido2 requests to avoid ambiguity

* [PM-11419] Reworking how we handle reacting to active fido2 requests to avoid ambiguity

* [PM-11419] Adjusting implementation to ensure we clear any active requests when the passkeys setting is modified
2024-09-09 08:44:08 -04:00
cyprain-okeke
3af0590807
Fix the adjusting issue on the plans selection (#10953) 2024-09-09 13:25:14 +01:00
md-5
e3fc4547ae
Handle detached table cells in autofill service (#10880)
Fixes errors and high CPU usage / browser lockup on offending webpages.

HTMLTableCellElement.cellIndex will be -1 if the cell is not part of any row, which will cause getTextContentFromElement to fail since it will not receive a valid sibling cell.
2024-09-06 17:22:43 -04:00
Cesar Gonzalez
4e1912e24e
[PM-11481] Incorporate TOTP field qualification to ensure inline menu appears correctly for login forms (#10900)
* [PM-11481] Incorporate TOTP field qualification to ensure inline menu appears correctly for login forms

* [PM-11481] Incorporate TOTP field qualification to ensure inline menu appears correctly for login forms
2024-09-06 21:00:47 +00:00
Cesar Gonzalez
12b5ce548d
[PM-11689] Incorporate refined submit button capture logic within auto-submit login content script (#10909)
* [PM-11689] Incorporate refined submit button capture logic within auto-submit login content script

* [PM-11689] Refactoring implementation to better unify logic

* [PM-11689] Adjusting regex value in order to avoid iterating over element unnecessarily

* [PM-11689] Adjusting regex value in order to avoid iterating over element unnecessarily

* [PM-11689] Adjusting regex value in order to avoid iterating over element unnecessarily
2024-09-06 15:57:12 -05:00
Daniel García
4dbb036df1
Remove unnecessary plist keys in desktop_proxy (#10933) 2024-09-06 20:06:01 +02:00
Bernd Schoolmann
45806ed8d8
Add fallbackbulkencryptservice to main.background.ts (#10696) 2024-09-06 19:00:50 +02:00
SmithThe4th
a48773ae4f
[PM-11692] [PM-11693] [PM-11694] Fixed defects with browser refresh trash component (#10911)
* Added animation when viewing item in trash

* Fixed A11y to announce delete forever

* Route to vault page after restore or delete action is performed
2024-09-06 12:55:26 -04:00
Daniel García
40cb4b5353
Fix TestFlight errors caused by desktop_proxy (#10928)
* Add info.plist and enable app-sandbox

* Log available identities

* Fix cert selection

* Remove comment
2024-09-06 17:48:51 +02:00
Jonathan Prusik
9881c7842b
[PM-10418] Bugfix - Expiration date on cards does not always autofill the correct format (#10705)
* add branching logic for alternative card expiration autofill strategy

* simplify logic and fix some pattern-matching bugs

* add EnableNewCardCombinedExpiryAutofill feature flag

* update default format for card expiry date and update tests

* review reccs
2024-09-06 11:24:04 -04:00
Alex Morask
56ededa947
Update organization-plans.component to use new payment-v2.component when FF is on (#10906) 2024-09-06 10:19:12 -04:00
Alex Morask
2aa4b07d68
Move braintree.service and stripe.service from jslib-services.module into web (#10923) 2024-09-06 09:51:00 -04:00
Nick Krantz
fb1a294c97
update aria label of the character count toggle (#10915) 2024-09-06 08:49:46 -05:00
Justin Baur
92e71d9252
[PM-11661]Add New Reseed - Fill Buffer Behind Feature Flag (#10905)
* Add New Reseed - Fill Buffer Behind Feature Flag

* Add Tests

* Lint
2024-09-06 09:48:27 -04:00
Todd Martin
03b3345bf6
[PM-11619] Replace client-side feature flag with server-side flag (#10709) 2024-09-06 09:25:15 -04:00
github-actions[bot]
ffaf94a5db
Autosync the updated translations (#10919)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-09-06 11:40:32 +00:00
github-actions[bot]
d28b62ae5d
Autosync the updated translations (#10920)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-09-06 11:08:30 +00:00
github-actions[bot]
7eaf870213
Autosync the updated translations (#10918)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-09-06 07:45:18 +00:00
otbutz
d905dd1653
Add missing doctype (#10860) 2024-09-05 20:22:45 -04:00
cyprain-okeke
8eef46ad4e
[PM-11417] Customers' Expiration Date in Admin Console changing to next invoice date when Pending Invoice items exist (#10774)
* Resolve the wrong subscription expiration date

* Refactor the change to include flag

* refactor the change to consider the flag

* Resolve the year bug for all subscription

* Changes for the premium user

* resolve the premium issue
2024-09-05 23:48:15 +01:00
Bernd Schoolmann
b2966b158a
[PM-11461] Fix jit proivisioning for snap desktop (#10794)
* Fix snap jit privisioning

* Fix server keeping connection open on favicon request
2024-09-05 18:15:09 -04:00
cyprain-okeke
397141b9d9
Resolve the issue of blank seat and seat limit pm (#10902) 2024-09-05 20:40:27 +01:00
Justin Baur
3bbc2cc691
Change AppIdService to Use Storage Directly (#10835) 2024-09-05 14:44:19 -04:00
Bitwarden DevOps
f58138a51d
Bumped client version(s) (#10913) 2024-09-05 18:18:22 +00:00
Bitwarden DevOps
63e3f3218b
Bumped client version(s) (#10912) 2024-09-05 18:05:23 +00:00
Jared Snider
352ab29665
Auth/PM-11635 - Extension Registration Bugfix - Unable to login after account creation issue (#10896)
* PM-11635 - Refactor Base Login Component NgOnInit to properly connect the loading of email settings from state to the processing of query params. If an email is not passed via query params (like registration / normal login), then we will try to load the email from state.

* PM-11635 - Extension login component - call parent ngOnInit as it is responsible for processing / setting email from either query params or state. The addition of the child ngOnInit prevented the parent component ngOnInit from executing.
2024-09-05 13:55:30 -04:00
Bitwarden DevOps
0902ca5ae8
Bumped client version(s) (#10910) 2024-09-05 16:33:26 +00:00
Jordan Aasen
329f8b138c
[PM-11438] add padding to self-hosted subscription import button (#10869)
* add padding to import button

* reduce padding on upload input

* add padding to premium self-hosted file upload
2024-09-05 09:31:59 -07:00
Daniel James Smith
74d510332d
[PM-9884] Create empty send add/edit page for browser (#10155)
* Move SendV2component into send-v2 subFolder

* Create SendFormContainer and related services

* Add initial SendFormComponent which uses the SendFormContainer

* Remove AdditionalOptionsSectionComponent which will be added with a future PR

* Add libs/tools/send to root tsconfig

* Register libs/tools/send/send-ui with root jest.config.js

* Register libs/tools/send/send-ui with root tailwind.config.js

* Create empty Send add edit page

- Introduces conditional routing based on extension refresh feature flag
- After selecting a Send type via the New button navigate to the new send-add-edit page and build a SendFormConfig

* Fix service injection on DefaultSendFormService

* Rename setHeader into getHeaderText, make it private and add documentation

* Set radix/base to 10 for parseInt

* Add documentation

* Rename local variable

* Removed unneeded loading state

* Remove unused originalSendId

* Run prettier

* Add link to edit an existing send

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-09-05 17:46:03 +02:00
Alex Morask
2a1d9b7f31
[AC-2963] Add premium-v2.component for individual users (#10885)
* Add premium-v2.component

* (No Logic) Move existing premium.component into new premium folder

* Add new premium-v2.component to /premium route behind FF
2024-09-05 11:20:23 -04:00
Victoria League
32903a21f9
[CL-322] Remove tw-sr-only from form field labels (#10868) 2024-09-05 10:16:06 -04:00
Daniel García
78c5e9c706
[PM-5506] Enable electron fuses (#10073) 2024-09-05 13:20:44 +02:00
Daniel García
55874b72bf
[PM-7846] Implement a rust based native messaging proxy and IPC system (#9894)
* [PM-7846] Implement a rust based native messaging proxy and IPC system

* Only build desktop_proxy

* Bundle the desktop_proxy file

* Make sys deps optional for the proxy

* Restore accidentally deleted after-sign

* Update native cache to contain dist folder

* Add some test logging

* Native module cache seems very aggressive

* Fix invalid directory

* Fix debug print

* Remove cache force

* Remove cache debug code

* Only log to file in debug builds

* Place the binary in the correct place for mac and make sure it's signed

* Fix platform paths

* Test unsigned appx

* Revert "Test unsigned appx"

This reverts commit e47535440a.

* Fix comment

* Remove logs

* Use debug builds in native code, and test private path on MacOS

* Add connected message

* Update IPC API comments

* Update linux to also use XDG_ dir

* Update main.rs comment

* Improve docs and split some tasks spawned into separate functions

* Update send docs and return number of elements sent

* Mark `listen` as async to ensure it runs in a tokio context, handle errors better

* Add log on client channel closed

* Move binary to MacOS folder, and sign it manually so it gets the correct entitlements

* Fix some review comments

* Run prettier

* Added missing zbus_polkit dep

* Extract magic number and increase it to match spec

* Comment fix

* Use Napi object, combine nativeBinding export, always log to file

* Missed one comment

* Remove unnecessary generics

* Correct comment

* Select only codesigning identities

* Filter certificates

* Also add local dev cert

* Remove log

* Fix package ID

* debug_assert won't run the pop() in release mode

* Better error messages

* Fix review comments

* Remove unnecessary comment

* Update napi generated TS file

* Temporary fix for DDG
2024-09-05 12:54:24 +02:00
Bernd Schoolmann
196729fe94
[PM-8316] Fix account switcher on vault logout timeout (#10653)
* Fix account switcher on logged out account on startup

* Undo space removal

* Add additional checks for null values

* Fix account switching on timeout on browser

* Fix linting

* Fix broken init in browser
2024-09-05 11:24:27 +02:00
Alec Rippberger
fdd2c774c6
[PM-11339] [Defect] Owner information in Item details section needs spacing and alignment (#10762)
* Add vault files to config.content array.

* Adjust unordered list spacing.
2024-09-04 15:45:23 -07:00
Alec Rippberger
c2046f8929
Add missing address label. (#10823) 2024-09-04 15:40:25 -07:00
Alec Rippberger
5ba39651e2
[PM-10833] [Defect] Add items to new dropdown in admin console (#10828)
* Add cipher types to "new" dropdown in admin console.

* Keep feature flag code consistent.

* Add missing menu divider.
2024-09-04 15:38:56 -07:00
Alec Rippberger
8aa81dec3b
[PM-11388] [Defect] Section headers are missing for View {Item} on web (#10838)
* Add Personal Details header.

* Add missing translation strings.
2024-09-04 15:33:54 -07:00
Thomas Rittson
0173b5192e
[PM-11623] Refactor access-selector stories (#10874)
* Split access-selector stories into separate stories and files
* Tweak existing stories to better represent actual use cases in our app
* Add jsdoc comments
* Add stories
2024-09-05 08:33:35 +10:00
Thomas Rittson
8344623185
[PM-11450] Move organization-user domain to admin-console lib (#10785)
- move organization-user files from libs/common/src/admin-console into libs/admin-console/src/common
- add barrel files and update imports to use barrel files
- rename OrganizationUserService to OrganizationUserApiService
- rename OrganizationUserServiceImplementation to DefaultOrganizationUserApiService
2024-09-04 18:21:26 -04:00
Cesar Gonzalez
2f69228c21
[PM-11656] Inline menu updates with empty list of ciphers (#10891) 2024-09-04 15:44:08 -05:00
Cesar Gonzalez
1a1d9e2d76
[PM-11386] Limit presentation of inline menu for identities strictly to fields that contain valid autocomplete attribute (#10865)
* [PM-11386] Limit presentation of inline menu for identities strictly to fields that contain valid autocomplete attribute

* [PM-11386] Limit presentation of inline menu for identities strictly to fields that contain valid autocomplete attribute
2024-09-04 15:42:52 -05:00
Cesar Gonzalez
e594059865
[PM-11474] Rework injection of delayed passkey script to address identified bugs (#10830)
* [PM-11474] Delay cleanup of injected passkey script

* [PM-11474] Incorporating changes to ensure passkeys function within Safari script effectively

* [PM-11474] Fixing jest tests

* [PM-11474] Fixing jest tests
2024-09-04 15:42:37 -05:00
SmithThe4th
55ffe9913d
fixed typography issues (#10886) 2024-09-04 16:14:58 -04:00
Ike
b264a3f442
toast is how showing; removed event emitter to use built in emitter in base class; (#10761) 2024-09-04 12:49:18 -07:00
renovate[bot]
0419f91df6
[deps]: Lock file maintenance (#10852)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-04 13:55:46 -04:00
renovate[bot]
53efb9a7c3
[deps] Platform: Update @types/node to v20.16.4 (#10843)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-04 13:55:11 -04:00
Jonathan Prusik
095ce7ec30
[PM-7956] Update passkey pop-out to new UI (#10796)
* rename existing fido2 components to use v1 designation

* use fido2 message type value constants in components

* add v2 fido2 components

* add search to login UX of fido2 v2 component

* add new item button in top nav of fido2 v2 component

* get and pass activeUserId to cipher key decription methods

* cleanup / PR suggestions
2024-09-04 13:50:48 -04:00
Jonathan Prusik
44f1fc156c
[PM-11458] Bugfix - If two digit year was entered for card, the expired card message shows if card is not expired (#10801)
* normalize card expiry year before determining if it is expired

* add tests
2024-09-04 13:39:48 -04:00
Alex Morask
6edc3edb9a
[AC-2960] Create new adjust-storage-dialog component without payment.component (#10793)
* Add adjust-storage-dialog-v2.component

* (No Logic) Rename old adjust-storage.component to adjust-storage-dialog.component

* (No Logic) Move existing adjust-storage-dialog.component into new adjust-storage-dialog folder

* Use adjust-storage-dialog-v2.component in adjustStorage methods when FF is on
2024-09-04 12:30:47 -04:00
Merissa Weinstein
c73ee88126
turn enableCipherKeyEncryption flag off (#10621) 2024-09-04 10:52:22 -05:00
Nick Krantz
c5c8a0dd5e
swap account font color for muted (#10883) 2024-09-04 10:51:53 -05:00
Todd Martin
86fab07a37
Auth/PM-5099 Ensure consistent casing of email used for fingerprint generation in Auth Requests (#8571)
* Created method for handilng email-address-based fingerprint.

* Added test for new method.

* Added returns to annotation
2024-09-04 10:22:06 -04:00
Bitwarden DevOps
77e03aee47
Bumped client version(s) (#10873) 2024-09-04 01:09:02 +00:00
Jonathan Prusik
5f2eecd7be
[PM-11350] Use shared expiration year normalization util function (#10735)
* use shared expiration year normalization util function

* use shared exp year normalization in web and desktop client

* handle cases where input has leading zeroes

* add utils tests

* handle cases where input is all zeroes
2024-09-03 15:12:36 -04:00
rr-bw
b27dc44298
[PM-11136] Convert LoginEmailService email property to state provider (#10624)
* convert email property to state provider

* update tests

* assign loginEmail to variable before passing in

* remove nav logic in ngOnInit
2024-09-03 09:40:11 -07:00
Alec Rippberger
ea618c682a
Use alt background for view dialog. (#10763) 2024-09-03 10:30:46 -05:00
Nick Krantz
87a1742a43
lowercase header for add/edit v2 (#10770) 2024-09-03 10:24:14 -05:00
Bernd Schoolmann
5f5e4498e8
[PM-11593] Fix backgroundbrowserbiometricservice initialization (#10861)
* Fix backgroundbrowserbiometricservice initialization

* Cleanup according to review
2024-09-03 16:56:55 +02:00
Andreas Coroiu
60fca9c118
Revert "[deps] Platform: Update argon2 to v0.41.1 (#9819)" (#10858)
This reverts commit 5dac4b94e1.
2024-09-03 14:06:23 +02:00
renovate[bot]
5dac4b94e1
[deps] Platform: Update argon2 to v0.41.1 (#9819)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-02 14:13:53 +02:00
rr-bw
c5a267baad
[PM-11000] AnonLayout Icon/Logo theme refactor (#10549)
* update base anon-layout logo/icon

* update ExtensionAnonLayout logo/icon based on theme

* remove hard-coded fill

* remove solarizedDark class

---------

Co-authored-by: Bernd Schoolmann <mail@quexten.com>
2024-08-31 12:26:11 -07:00
SmithThe4th
e7d4f8575d
renamed bulk and inline menu options (#10834) 2024-08-30 16:45:47 -04:00
Jared Snider
1b75261f68
Fix web vault lock throwing an error (#10833) 2024-08-30 16:35:58 -04:00
SmithThe4th
5a73639946
[PM-8125] Move Trash to the Vault settings page (#10736)
* created trash and trash container component

* added trash to vault settings

created observable to get deleted ciphers

* export icon

added locales

* remove edit and delete footver from trash view cipher

* Added helper text when viewing deleted ciphers

* prevent premature access of isDeleted from the cipher object

* simplified the condition to show the edit button

* return cipherView for deletedCiphers$ since that is what is used in the component

* changed section header to h6

* added routing animation

* Added restore to footer
2024-08-30 15:46:26 -04:00
Jason Ng
963e339e4f
PM-11429 Users with Except PW permissions will not get Copy Password Option Vault V2 (#10831) 2024-08-30 15:38:37 -04:00
Alex Morask
95d04f264f
Remove unused payment.component from adjust-subscription.component.html (#10820) 2024-08-30 14:18:07 -04:00
Jordan Aasen
2882fa3077
[AC-2268] - migrate toast to CL service for admin-console (#10663)
* migrate toast to CL service for admin-console

* fix spec

* add missing dep for toastService

* fix toastService args

* fix toastService args

* fix toastService args
2024-08-30 11:16:06 -07:00