1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-29 12:55:21 +01:00
Commit Graph

13253 Commits

Author SHA1 Message Date
Justin Baur
c85ddfe833
[PM-2998] Move Approving Device Check (#5822)
* Switch to retrieving approving device from token response

- Remove exist-by-types API call
- Define `HasApprovingDevices` on TDE options

* Update Naming

* Update Test

* Update Missing Names
2023-07-17 08:56:30 -04:00
Todd Martin
0696252fb3
Removed self-hosted check from TDE SSO config. (#5837) 2023-07-14 11:32:04 -04:00
Justin Baur
1d71d99b85
Merge remote-tracking branch 'origin/master' into feature/trusted-device-encryption 2023-07-13 11:42:42 -04:00
Todd Martin
baab72eaf2
Found another missing await. (#5819) 2023-07-13 11:23:04 -04:00
Matt Gibson
aa6bb723f2
Disable mv3 artifacts (#5816) 2023-07-13 10:02:50 -05:00
Vince Grassia
312ee54434
Add default push location for Chocolatey (#5805) 2023-07-13 10:08:36 -04:00
Daniel James Smith
afb6c86c2e
Update web-path for team-auth-dev (#5817)
With https://github.com/bitwarden/clients/pull/5336 all files got moved to apps/web/src/app/auth, but CODEOWNERS still pointed to apps/web/src/auth
2023-07-13 14:08:16 +00:00
github-actions[bot]
028e2b8a61
Bumped browser version to 2023.7.1 (#5815)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-07-13 12:40:14 +00:00
Andreas Coroiu
2f1358cf04
[PM-2928] [PM-2929] [PM-2930] Fixes for: [PM-1203] Replace MP confirmation with verification code (#5798)
* [PM-2928] feat: hide change email if user doen't have MP

* [PM-2929] feat: hide KDF settings if user doesn't have MP

* [PM-2930] feat: remove MP copy
2023-07-13 09:34:43 +02:00
Jared Snider
5480e47bb6
Defect - LockComp - After setting user key, must AWAIT retrieval of user's previous choice to have trusted the device or not. (#5804) 2023-07-12 17:55:34 -04:00
Todd Martin
22cb3d57a4
Adding missing await. (#5801) 2023-07-12 16:34:17 -04:00
Jared Snider
213b8f7ad0
Merge remote-tracking branch 'origin/master' into feature/trusted-device-encryption 2023-07-12 14:59:08 -04:00
Jared Snider
2a5a30844d
Auth/[PM-1260] - Existing User - Login with Trusted Device (Flow 2) (#5775)
* PM-1378 - Refactor - StateSvc.getDeviceKey() must actually convert JSON obj into instance of SymmetricCryptoKey

* TODO: BaseLoginDecryptionOptionsComponent - verify new user check doesn't improperly pick up key connector users

* PM-1260 - Add new encrypted keys to TrustedDeviceUserDecryptionOptionResponse

* PM-1260 - DeviceTrustCryptoSvc - decryptUserKeyWithDeviceKey: (1) update method to optionally accept deviceKey (2) Return null user key when no device key exists (3) decryption of user key now works in the happy path

* PM-1260 - LoginStrategy - SaveAcctInfo - Must persist device key on new account entity created from IdTokenResponse for TDE to work

* PM-1260 - SSO Login Strategy - setUserKey refactor - (1) Refactor existing logic into trySetUserKeyForKeyConnector + setUserKeyMasterKey call and (2) new trySetUserKeyWithDeviceKey method for TDE

* PM-1260 - Refactor DeviceTrustCryptoService.decryptUserKeyWithDeviceKey(...) - Add try catch around decryption attempts which removes device key (and trust) on decryption failure + warn.

* PM-1260 - Account - Add deviceKey to fromJSON

* TODO: add device key tests to account keys

* TODO: figure out state service issues with getDeviceKey or if they are an issue w/ the account deserialization as a whole

* PM-1260 - Add test suite for decryptUserKeyWithDeviceKey

* PM-1260 - Add interfaces for server responses for UserDecryptionOptions to make testing easier without having to use the dreaded any type.

* PM-1260 - SSOLoginStrategy - SetUserKey - Add check looking for key connector url on user decryption options + comment about future deprecation of tokenResponse.keyConnectorUrl

* PM-1260 - SSO Login Strategy Spec file - Add test suite for TDE set user key logic

* PM-1260 - BaseLoginStrategy - add test to verify device key persists on login

* PM-1260 - StateService - verified that settings persist properly post SSO and it's just device keys we must manually instantiate into SymmetricCryptoKeys

* PM-1260 - Remove comment about being unable to feature flag auth service / login strategy code due to circ deps as we don't need to worry about it b/c of the way we've written the new logic to be additive.

* PM-1260 - DevicesApiServiceImplementation - Update constructor to properly use abstraction for API service

* PM-1260 - Browser - AuthService - (1) Add new, required service factories for auth svc and (2) Update auth svc creation in main.background with new deps

* PM-1260 - CLI - Update AuthSvc deps

* PM-1260 - Address PR feedback to add clarity / match conventions

* PM-1260 - Resolving more minor PR feedback

* PM-1260 - DeviceTrustCryptoService - remove debug warn

* PM-1378 - DeviceTrustCryptoSvc - TrustDevice - Fix bug where we only partially encrypted the user key with the device public key b/c I incorrectly passed userKey.encKey (32 bytes) instead of userKey.key (64 bytes) to the rsaEncrypt function which lead to an encryption type mismatch when decrypting the user's private key with the 32 byte decrypted user key obtained after TDE login.  (Updated happy path test to prevent this from happening again)

* PM-1260 - AccountKeys tests - add tests for deviceKey persistence and deserialization

* PM-1260 - DeviceTrustCryptoSvc Test - tweak verbiage per feedback

* PM-1260 - DeviceTrustCryptoSvc - Test verbiage tweak part 2

* Update apps/browser/src/background/service-factories/devices-api-service.factory.ts

per PR feedback

Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>

---------

Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
2023-07-12 12:14:24 -04:00
Todd Martin
fbf67a819f
[PM-2846][PM-2860] Properly pass region from global to account state (#5764)
* Properly pass region from global to account state

* Fixed comment.

* Updated logic to not set environment if region with predefined URLs is selected.

* Added logic to clear environment URLs in EnvironmentService.

* Fixed comment
2023-07-12 10:44:55 -04:00
Opeyemi
a37b8db250
Deprecate release-qa-web.yml wf (#5786)
* Deprecate release-qa-web.yml wf

* Merge master
2023-07-12 11:19:28 +01:00
rr-bw
8a75eb0a80
[PM-2396] Remove Settings Cog Wheel (#5654)
* remove settings cog

* remove comment
2023-07-11 16:34:37 -07:00
André Bispo
511ca540b5
Change getUserTrustDeviceChoiceForDecryption / setUserTrustDeviceChoiceForDecryption to getShouldTrustDevice / setShouldTrustDevice (#5795) 2023-07-11 23:25:36 +01:00
rr-bw
259687d3fb
[PM-1693] Login with Device page text update (#5650)
* remove 'mobile' from sentence

* Revert "remove 'mobile' from sentence"

This reverts commit 62b8546cb6.

* update text and change key
2023-07-11 13:21:42 -07:00
github-actions[bot]
a1f6d19ab7
Bumped all version to 2023.7.0 (#5792)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
2023-07-11 13:45:17 -04:00
Vince Grassia
028d7425db
Fix CODEOWNERS file for releases (#5793) 2023-07-11 17:44:12 +00:00
renovate[bot]
775a13a5f2
Update bitwarden/gh-actions digest to a30e9c3 (#5722)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-07-11 10:12:36 -06:00
Daniel James Smith
e2dda66fdf
Extend auth ownership (#5790)
Assigning `bitwarden_license/bit-web/src/app/auth` @bitwarden/team-auth-dev
2023-07-11 15:29:02 +00:00
Robyn MacCallum
7b7cfad689
Fix autofill codeowners (#5785) 2023-07-11 09:17:02 -04:00
Robyn MacCallum
65d970a16f
Exclude en locale files from requiring a review from leads (#5702) 2023-07-11 08:46:04 -04:00
Opeyemi
05203d96c6
add workflow call to deploy-non-prod-web.yml (#5728)
* add workflow call to deploy-non-prod-web.yml

* Remove required in wf call and dispatch
2023-07-10 23:57:56 +01:00
Vince Grassia
cc1572f6bc
Fix Snapcraft Action Version (#5772) 2023-07-10 15:56:57 -07:00
Vince Grassia
7b26998999
DEVOPS-1400 - Fix Test Workflow (#5778) 2023-07-10 18:55:59 -04:00
Shane Melton
48a9b7d703
[PM-2647] Remove try/catch that was silencing error messages on incorrect passwords (#5662) 2023-07-10 11:59:24 -07:00
Vince Grassia
da436317e3
DEVOPS-1400 - Fix Version Auto Bump workflow (#5754) 2023-07-10 09:06:05 -04:00
cd-bitwarden
04207647de
[SM-650] Updating search and select all to work together properly (#5510)
* Updating search and select all to work together properly

* adding comment and moving filtered data below private variables

* thomas suggested changes

* making service-accounts-list the same as projects and secrest list

* changes

* Update service-accounts-list.component.ts

* removing unnecessary code

* setting active filter on set data, adding comment

* removing unused field

* Update libs/components/src/table/table-data-source.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

---------

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
2023-07-08 13:59:35 +00:00
Jacob Fink
89120532b2
fix merge issues 2023-07-07 11:10:15 -04:00
Jacob Fink
e789d6ec70
Merge branch 'tde-key-model-migration' into feature/trusted-device-encryption 2023-07-07 10:28:56 -04:00
Jacob Fink
60708831fe
Merge branch 'master' into feature/trusted-device-encryption 2023-07-07 10:24:11 -04:00
André Bispo
8786a7b57f
[PM-1202] Hide the Master Password tab on Settings / Security (#5649)
* [PM-1203] feat: ask for OTP if user does not have MP

* [PM-1203] feat: get master password status from decryption options

* [PM-1203] feat: add backwards compatibility for accounts/servers without decryption options

* [PM-1203] feat: move hasMasterPassword to user-verification.service
2023-07-07 15:20:22 +01:00
Justin Baur
e6cb56f902
Adds Events & Human Readable Messages (#5746) 2023-07-07 10:07:42 -04:00
Jacob Fink
0f97a89a87
rename enc user key setter in crypto service 2023-07-07 09:39:37 -04:00
github-actions[bot]
e6bad5998d
Autosync the updated translations (#5757)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-07-07 08:24:51 +00:00
github-actions[bot]
cf7b3efe66
Autosync the updated translations (#5758)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-07-07 05:10:23 +00:00
github-actions[bot]
bffefc46fa
Autosync the updated translations (#5756)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-07-07 05:01:29 +00:00
Will Martin
69945adba2
[SM-839] remove enable from copy (#5721)
* remove enable from copy

* revert af changes; update en locale to remove enable copy
2023-07-06 18:51:40 -04:00
Vince Grassia
a004453034
Update crowdin action hash (#5753) 2023-07-06 13:05:37 -07:00
Vince Grassia
d16b717897
Fix input error in 'Update Homebrew formula' step (#5751) 2023-07-06 12:52:03 -04:00
Jacob Fink
7a25c376ce
fix cli 2023-07-06 12:51:31 -04:00
Jacob Fink
160ca2cd3b
Merge branch 'master' into tde-key-model-migration 2023-07-06 12:41:41 -04:00
Jacob Fink
84874fdd11
rename key hash to password hash on crypto service 2023-07-06 12:38:36 -04:00
Jacob Fink
b4fd44320d
set master key on lock component 2023-07-06 12:17:41 -04:00
Jacob Fink
d562dc67a0
remove extra partial key 2023-07-06 12:16:34 -04:00
Cesar Gonzalez
b2e5f7de33
[PM-482] Desktop Application is Minimized When There is a Master Password Reprompt and Copying Vault Item Password (#5635) 2023-07-06 10:06:24 -05:00
Robyn MacCallum
b737c70712
[PM-2067] Update Folder Add-Edit modal to use the Component Library (#5648)
* Add formGroup to base FolderAddEditComponent

* [web] use DialogService to open the modal

* [web] migrate FolderAddEditComponent use component library

* [desktop] use the formGroup in the template

* [browser] use the formGroup in the template

* [browser & desktop] remove disable on form invalid

* [web] Migrate to async actions

* [web] Strengthen typing for FolderAddEdit dialog

* Show form error instead of error toast

* Move browser folder add edit component to vault

* Remove extra template variables

* Remove inner form

* Remove inner form

* Update apps/web/src/app/vault/individual-vault/folder-add-edit.component.html

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

---------

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
2023-07-06 09:58:12 -04:00
Andreas Coroiu
887b2ec78e
[PM-1033] Org invite user creation flow 1 (#5611)
* [PM-1033] feat: basic redirection to login initiated

* [PM-1033] feat: add ui for TDE enrollment

* [PM-1033] feat: implement auto-enroll

* [PM-1033] chore: add todo

* [PM-1033] feat: add support in browser

* [PM-1033] feat: add support for desktop

* [PM-1033] feat: improve key check hack to allow regular accounts

* [PM-1033] feat: init asymmetric account keys

* [PM-1033] chore: temporary fix bug from merge

* [PM-1033] feat: properly check if user can go ahead an auto-enroll

* [PM-1033] feat: simplify approval required

* [PM-1033] feat: rewrite using discrete states

* [PM-1033] fix: clean-up and fix merge artifacts

* [PM-1033] chore: clean up empty ng-container

* [PM-1033] fix: new user identification logic

* [PM-1033] feat: optimize data fetching

* [PM-1033] feat: split user creating and reset enrollment

* [PM-1033] fix: add missing loading false statement

* [PM-1033] fix: navigation logic in sso component

* [PM-1033] fix: add missing query param

* [PM-1033] chore: rename to `ExistingUserUntrustedDevice`

* PM-1033 - fix component templates to reference `ExistingUserUntrustedDevice` so clients can build

---------

Co-authored-by: Jared Snider <jsnider@bitwarden.com>
2023-07-06 09:16:16 +02:00