1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-09-24 03:32:51 +02:00
bitwarden-browser/apps/desktop/src/app
Patrick H. Lauke 22a138a46f
[PM-2432] Desktop: Modify switch account dropdown/dialog for accessibility (#5529)
* Tweak account switcher button

- if it opens a dialog, it should advertise this with `aria-haspopup="dialog"`, not `aria-haspopup="menu"`
- if it opens a dialog, the `aria-expanded` is pointless (as the user will never get back out into the underlying page to check if it's expanded or collapsed, since it's for a dialog not a disclosure widget or menu)

* Make two variants for button to sort out `aria-label` on logged-in case

* Remove `aria-controls` for button

as it's a dialog that opens, not a disclosure, this is irrelevant

* Fix `overlayPostition` typo

* Simplify approach

just use existing single button, but add visually hidden extra "Switch account" to accName

* Tweak account switch buttons in dialog/dropdown

* Take out the confusing "Logged in as..." a11y text
* Use visible button text (with a few extra `sr-only` parts, for readability) as the button's accName
* Add the "Switch account" context to each of the buttons to make clear what they do
2023-10-31 10:55:43 -07:00
..
accounts [PM-4360] Move auth owned code into auth (#6595) 2023-10-19 08:03:32 +00:00
components [PM-4357] remove disableClose on BrowserSyncVerificationDialog and AwaitDesktopDialog (#6730) 2023-10-30 12:24:26 -04:00
layout [PM-2432] Desktop: Modify switch account dropdown/dialog for accessibility (#5529) 2023-10-31 10:55:43 -07:00
services [PM-3753] Update electron desktop language handling (#6482) 2023-10-24 12:32:54 +02:00
shared [SM-251] Migrate to new avatar component (#3600) 2022-10-27 14:38:34 +02:00
tools [PM-4195] LastPass importer flow (#6541) 2023-10-23 17:46:49 +00:00
app-routing.module.ts [PM-3198][PM-3199] Rename PasswordlessLoginStrategy (#6425) 2023-10-25 11:15:05 -07:00
app.component.ts [PM-4197] Enable importing on deskop (#6502) 2023-10-19 08:00:06 -05:00
app.module.ts [PM-4360] Move auth owned code into auth (#6595) 2023-10-19 08:03:32 +00:00
main.ts [PM-3996] Scaffolding for preload script (#6065) 2023-10-12 11:50:17 +02:00