mirror of
https://github.com/bitwarden/server.git
synced 2024-11-24 12:35:25 +01:00
1.6 KiB
1.6 KiB
🎟️ Tracking
📔 Objective
📸 Screenshots
⏰ Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
🦮 Reviewer guidelines
- 👍 (
:+1:
) or similar for great changes - 📝 (
:memo:
) or ℹ️ (:information_source:
) for notes or general info - ❓ (
:question:
) for questions - 🤔 (
:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (
:art:
) for suggestions / improvements - ❌ (
:x:
) or ⚠️ (:warning:
) for more significant problems or concerns needing attention - 🌱 (
:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt - ⛏ (
:pick:
) for minor or nitpick changes