Upstream/harbor
1
0
Fork 0
mirror of https://github.com/goharbor/harbor.git synced 2024-10-03 07:47:54 +02:00
Code Issues Projects Releases Wiki Activity
11,021 Commits 50 Branches 311 Tags 339 MiB
307b8973ce
Commit Graph

5229 Commits

Author SHA1 Message Date
孙世军
eabff82366
Improve getChanges function for edit registries compoment (#15404) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-08-12 10:08:49 +08:00
Gustavo Stein
cd987c6b8a
Fixes bizarre translation for CLI in pt-br. (#15390) 
Signed-off-by: Gustavo Raphael Stein <grstein.ramone@gmail.com>
 2021-08-11 09:59:54 +08:00
Tianon Gravi
af18f5bd20
Adjust "flattening" tooltip quotes to be consistent (#15393) 
This is a minor consistency issue, but it also turns into a minor rendering issue where something is converting "backtick + a" into "à"

Signed-off-by: Tianon Gravi <tianon@infosiftr.com>
 2021-08-10 15:21:13 +08:00
stonezdj(Daojun Zhang)
d7c8c722f5
Merge pull request #15397 from stonezdj/21aug4_fix_ldap_ipv6 
Support IPv6 when connecting to LDAP server
 2021-08-09 12:47:20 +08:00
孙世军
9a10c6627b
Add docker build to deploy Harbor UI for testing (#15381) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-08-09 10:37:49 +08:00
stonezdj
409039b502 Support IPv6 when connecting to LDAP server 
Use net.SplitHostPort instead of strings.Split
 Fixes #15354

Signed-off-by: stonezdj <stonezdj@gmail.com>
 2021-08-04 12:54:44 +08:00
Wang Yan
9e11753949
upgrade helm v3 version (#15372) 
1. update helm v3 to v3.6.1
2. update autorest to v14.2.0
3. update other related models

Signed-off-by: Wang Yan <wangyan@vmware.com>
 2021-07-30 14:43:42 +08:00
Wang Yan
f7b1610476
replace jwt model (#15367) 
update the jwt model to github.com/golang-jwt/jwt
Starting from v3.2.1, the import path has changed from github.com/dgrijalva/jwt-go to github.com/golang-jwt/jwt.

Signed-off-by: Wang Yan <wangyan@vmware.com>
 2021-07-29 11:08:10 +08:00
孙世军
538266c51a
Handle invalid date for HarborDatePipe (#15359) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-07-27 08:18:20 +08:00
孙世军
f6801cea57
Improve event service (#15353) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-07-26 12:16:49 +08:00
Daniel Jiang
5984175a1f
Merge pull request #15288 from malacoss/patch-1 
Fix OIDC connect button string - [French]
 2021-07-26 11:31:00 +08:00
Vadim Bauer
13d5e4a7de
fixes the broken pipe connection error with postgres. Similar as PR: #4719 (#15211) 
Signed-off-by: Vadim Bauer <vb@container-registry.com>

Co-authored-by: Vadim Bauer <vb@container-registry.com>
 2021-07-23 14:56:54 +08:00
Wang Yan
e5a614967d
drop gc api of registryctl (#15325) 
The API is desiged for read-only gc job, as the read only gc has already deprecated, remove this api accordingly.

Signed-off-by: Wang Yan <wangyan@vmware.com>
 2021-07-23 14:15:02 +08:00
Shengwen Yu
766e953325 fix: update adapter ut (mock http requests) 
Closes: #15318

Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
 2021-07-22 19:45:36 +08:00
malacoss
f11a6f21e8 Fix OIDC connect button string - [French] 
Signed-off-by: Mathieu Alorent <mathieu.alorent-externe@acoss.fr>
 2021-07-19 10:53:14 +02:00
孙世军
8da8acde19
Fix style issue for oidc-onbord component (#15333) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-07-19 12:26:47 +08:00
Daniel Jiang
e46e9631fa
Merge pull request #15303 from reasonerjt/fix-15241 
Remediate the empty subiss problem
 2021-07-16 13:34:40 +08:00
Daniel Jiang
3e983b1747
Merge pull request #15242 from kschu91/bugfix/15241 
Fix refreshing oidc access token breaks users subiss in database
 2021-07-16 10:58:31 +08:00
Daniel Jiang
422894a0f5 Remediate the empty subiss problem 
This commit include 2 changes to mitigate and remediate the problem
described in #15241

1. When the token is to be updated in the "oidc_user" table, make sure
   only the column "token" will be udpated.
2. Restore the subiss column for the record that has this column cleared
   by mistake, by decoding the persisted token.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2021-07-16 00:07:47 +08:00
stonezdj(Daojun Zhang)
2fa530eefa
Merge pull request #15247 from stonezdj/21jun30_remove_auth_user 
Delete users under auth_mode other than db_auth
 2021-07-14 13:25:43 +08:00
孙世军
8fb76689ab
Update UI to support deleting OIDC users (#15305) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-07-13 15:28:53 +08:00
Wang Yan
f7a4401dcb
deprecate version 1 robot account (#15296) 
1, deprecate support for version 1 robot support, the robotv1 cannot be used anymore.
2, reserve the /project/{id_or_name}/robots api.

After the PR, user cannot use the robotv1 to login, and do any interaction with Harbor,
but still can view & delete them with UI or API.

Signed-off-by: Wang Yan <wangyan@vmware.com>
 2021-07-13 13:39:44 +08:00
Daniel Jiang
3e502ec9a4
Merge pull request #15196 from sixeIa/fix-basedn-empty 
Add SearchDN error, mark field as required in UI
 2021-07-12 12:32:52 +08:00
stonezdj
c163bc8317 Delete users under auth_mode other than db_auth 
The following information should cleanup before delete user:
  Delete project member of this user.
  Delete oidc_user when auth_mode is oidc_auth.
  Fixes #8424
  It also removes the deleted user from project member and the deleted condition in the project member query for consistency
Signed-off-by: stonezdj <stonezdj@gmail.com>
 2021-07-12 11:31:40 +08:00
stonezdj(Daojun Zhang)
7b84f4e137
Merge pull request #15270 from stonezdj/21jun05_fix_rest_int_parse_fail 
Fix invalid syntax errors when int value is convert to scientific notation
 2021-07-11 21:00:06 +08:00
Alexis L
2ce814329b
Merge branch 'goharbor:master' into fix-basedn-empty 2021-07-09 22:32:35 +02:00
Alexis
d6283ee913
Add SearchDN error, mark field as required in UI 
Signed-off-by: Alexis <60alexis@gmail.com>
 2021-07-09 22:30:52 +02:00
ChenYu Zhang
304aff33db
Merge pull request #15280 from chlins/fix/p2p-task-time-format 
fix(p2p): adjust task time format
 2021-07-09 16:29:09 +08:00
Wang Yan
248be37c3e
clean code of common util (#15287) 
Remove the useless code from the common util

Signed-off-by: Wang Yan <wangyan@vmware.com>
 2021-07-09 15:35:05 +08:00
Kevin Schu
03b7b01f77 reverted unintentional committed change 
Signed-off-by: Kevin Schu <kevin.schu@aoe.com>
 2021-07-08 15:43:14 +02:00
Kevin Schu
0679f4701e if username is not available in remote, fall back to username from token 
Signed-off-by: Kevin Schu <kevin.schu@aoe.com>
 2021-07-08 15:36:18 +02:00
Wang Yan
494d74d32d
bump up go version to 1.16 (#15286) 
Signed-off-by: Wang Yan <wangyan@vmware.com>
 2021-07-08 16:25:15 +08:00
chlins
f93fc2aa0b fix(p2p): adjust task time format 
Signed-off-by: chlins <chlins.zhang@gmail.com>
 2021-07-07 21:39:46 +08:00
Wang Yan
b158086642
fix conformance failure (#15261) 
fixes #15252

Give 404 for invalid digest when to get/head manifest

Signed-off-by: Wang Yan <wangyan@vmware.com>
 2021-07-06 15:11:13 +08:00
stonezdj
41968091a2 Fix invalid syntax errors when int value is convert to scientific notation 
Add parseInt function to parse the scientific notation

Signed-off-by: stonezdj <stonezdj@gmail.com>
 2021-07-05 22:20:00 +08:00
Jiaolin Yang
ddb6619769
Merge pull request #15245 from ilyee/typo 
Fix commentline typos in src/pkg/repository/model/model.go
 2021-07-05 16:38:11 +08:00
Steven Zou
4ddaecdc3f
Merge pull request #15238 from chlins/fix/create-p2p-policy-permission 
fix(p2p): fix p2p create policy permission
 2021-07-05 11:04:28 +08:00
elihe
426f7bc7bc Fix commentline typos in src/pkg/repository/model/model.go 
Signed-off-by: elihe <elihe@tencent.com>
 2021-07-02 10:12:15 +08:00
孙世军
bb57264f11
Improve login page for OIDC (#15214) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-07-02 09:42:04 +08:00
Kevin Schu
4147fbeba0 subiss needs to be part of selected fields, otherwise this attribute would be empty and will cause issues when working with the user object later on. 
Signed-off-by: Kevin Schu <kevin.schu@aoe.com>
 2021-07-01 15:12:28 +02:00
Wang Yan
29ccdff766
add retry for blob & manifest deletion in GC (#15235) 
Fixes #15197

To handle the blob & manifest deletion error, add 1 minute retry.

Signed-off-by: Wang Yan <wangyan@vmware.com>
 2021-07-01 18:49:40 +08:00
chlins
f1456558db fix(p2p): fix p2p create policy permission 
Signed-off-by: chlins <chlins.zhang@gmail.com>
 2021-07-01 16:14:26 +08:00
stonezdj(Daojun Zhang)
4e1f6633af
Merge pull request #15229 from stonezdj/21jun28_update_swagger_search_group 
Add ldap_group_dn parameter to search group with ldap group dn
 2021-06-30 14:04:21 +08:00
孙世军
91f4d412f0
Improve i18n service (#15215) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-06-30 10:22:48 +08:00
孙世军
f902db9d85
Change quota unit to Mebibyte (#15220) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-06-30 10:22:32 +08:00
stonezdj
fcd2fbcfe7 Add ldap_group_dn parameter to search group with ldap group dn 
Fixes #15171
 Cannot use q.Query because ldap_group_dn contains comma(,) and equal(=), which are reserved characters in q.Query

Signed-off-by: stonezdj <stonezdj@gmail.com>
 2021-06-29 20:20:47 +08:00
孙世军
ff11cbafa1
Improve event log component (#15191) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-06-29 18:15:17 +08:00
Steven Zou
2a3b91a11a
Merge pull request #15217 from wy65701436/joblog-ref 
refactor job log
 2021-06-29 17:44:17 +08:00
stonezdj(Daojun Zhang)
08d47f471a
Move genyaml to cmd/swagger (#15062) 
Signed-off-by: stonezdj <stonezdj@gmail.com>
 2021-06-29 14:29:03 +08:00
Wang Yan
1abe978e87 refactor job log 
Move job service logger to new program model

Signed-off-by: Wang Yan <wangyan@vmware.com>
 2021-06-29 13:37:45 +08:00
Alexis L
573d97f15b
Add TiB support for display, fix unit to correct one (#15201) 
* Add TiB support for display, fix unit to correct one

Signed-off-by: Alexis <60alexis@gmail.com>

* Fix unit test

Signed-off-by: Alexis <60alexis@gmail.com>
 2021-06-29 10:40:30 +08:00
孙世军
b789674ada
Fix css bug for disabled checkbox (#15181) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-06-23 17:13:41 +08:00
孙世军
33301ec65e
Enhance swagger UI (#15168) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-06-23 16:28:14 +08:00
孙世军
0464305bcc
Bump up UI version to v2.4.0 (#15174) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-06-23 16:27:40 +08:00
Will Sun
410c5bcd78
Undate Angular to the latest version (#15129) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-06-16 16:39:10 +08:00
Wenkai Yin(尹文开)
4997eea4c6
Merge pull request #15124 from ywk253100/210610_rep 
Add validation for destination namespace when creating/updating replication policy
 2021-06-15 09:46:09 +08:00
Will Sun
47b7457378
Add validator to destination namespace input (#15120) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-06-11 11:58:43 +08:00
Wenkai Yin
9ebd517c7e Add validation for destination namespace when creating/updating replication policy 
Add validation for destination namespace when creating/updating replication policy

Signed-off-by: Wenkai Yin <yinw@vmware.com>
 2021-06-10 22:16:05 +08:00
Wenkai Yin
c26e45efab Fix the concurrent pushing the same image issue 
The transaction will be aborted when get errors during the execution which causes the following sqls report error.
This commit moves the re-getting artifact logic out of the second transaction to avoid the concurrent pushing issue

Signed-off-by: Wenkai Yin <yinw@vmware.com>
 2021-06-10 21:16:05 +08:00
Wenkai Yin(尹文开)
df000bd7fe
Merge pull request #15090 from heww/tag-for-scanning 
fix: supply the latest tag of artifact to scan request
 2021-06-09 14:00:44 +08:00
Steven Zou
cdfbe7b92b
Merge pull request #15084 from ywk253100/210608_dest_ns 
Flattening repository path components excepting the last one
 2021-06-09 13:36:41 +08:00
Will Sun
e774976811
Fix UI issues found in round-2 testing day (#15093) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-06-09 12:50:33 +08:00
He Weiwei
1b955cd28e fix: supply the latest tag of artifact to scan request 
Closes #14416 #14299

Signed-off-by: He Weiwei <hweiwei@vmware.com>
 2021-06-08 10:11:10 +00:00
Wenkai Yin
120be22988 Flattening repository path components excepting the last one 
Flattening repository path components excepting the last one in replication

Fixes #15072

Signed-off-by: Wenkai Yin <yinw@vmware.com>
 2021-06-08 15:39:45 +08:00
Will Sun
706de334d3
Optimize UI imports (#15042) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-06-07 10:06:06 +08:00
Wang Yan
8a0cd99473
fixes 13976 (#15047) 
Fixes #13976 for the quota exceed case, gc will print the untagged blobs for dry-run

Signed-off-by: Wang Yan <wangyan@vmware.com>
 2021-06-04 15:56:53 +08:00
Wang Yan
ea35e7b9ec
enable policy checker for head manifest request (#15056) 
As from docker v20, the containerd leverages the cache when to pull a manifest, that leads to the
client doesn't send the get manifest request if the image exists in local.

The content trust and vul checker are only valid for get manifest request, the PR is to enable the checkers on
head manifest request to handle the containerd local cache scenario.

Signed-off-by: Wang Yan <wangyan@vmware.com>
 2021-06-03 16:54:04 +08:00
Jiaolin Yang
a2992327be
Merge pull request #14919 from yunkunrao/master 
Fix dragonfly preheat error.
 2021-06-03 13:36:15 +08:00
Will Sun
c4f4e6e7e1
Fix critical CVEs for ui packages (#15030) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-06-02 09:54:05 +08:00
yunkunrao
af814a2af2 Code clean 
Signed-off-by: yunkunrao <yunkunrao@gmail.com>
 2021-06-01 23:13:03 +08:00
Wang Yan
2a1c9ec96a
update the log level of robot v1 context (#15037) 
The robotv1 context uses the robot$ as a hardcoded prefix to identify robot account, it will raise error
for a valid robotv2 account with this prefix.

Update the log level to avoid the redundant logs for the default installation.

Signed-off-by: Wang Yan <wangyan@vmware.com>
 2021-06-01 18:30:40 +08:00
He Weiwei
fec9f59a43 test: use mockery generated artifact Manager in tests 
Closes #14284

Signed-off-by: He Weiwei <hweiwei@vmware.com>
 2021-06-01 04:00:08 +00:00
Will Sun
50b44e13d2
Fix ui issues found in testing day (#15015) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-05-31 18:58:58 +08:00
Wenkai Yin(尹文开)
6e649ac39f
Merge pull request #15014 from heww/move-scan-report-to-job 
refactor: convert scan report in scan job
 2021-05-31 15:55:31 +08:00
Wenkai Yin(尹文开)
f0e1ba4e1b
Merge pull request #15005 from ywk253100/210528_ns 
Declare the capability of supported repository path component for registries
 2021-05-31 15:53:40 +08:00
Daniel Jiang
238bea2066
Merge pull request #15010 from reasonerjt/v2auth-enhancement 
Make v2auth more strict
 2021-05-31 13:10:31 +08:00
Daniel Jiang
486554caa1
Merge pull request #15011 from reasonerjt/merge-slash-middleware 
Add merge slash middleware
 2021-05-31 13:09:39 +08:00
Wenkai Yin(尹文开)
4ed5fee681
Merge pull request #14949 from stonezdj/21may22_fallback_localregistry 
Fall back to local registry when upstream registry is not working
 2021-05-31 11:00:43 +08:00
ChenYu Zhang
04cd5f86dd
Merge pull request #14999 from chlins/fix/p2p-preheat-executions-time-format 
fix: format p2p preheat execution start_time and end_time to standard…
 2021-05-30 13:07:16 +08:00
He Weiwei
f6a1c31f9f refactor: convert scan report in scan job 
Signed-off-by: He Weiwei <hweiwei@vmware.com>
 2021-05-29 12:19:36 +00:00
Daniel Jiang
f4ac81b710 Add merge slash middleware 
There are code in the core component to conditionally execute code based
on the pattern of url path, and different ingress controller or reverse
proxy may handle the dup slashes in the url path differently.
This commit merge dup slashes in the url paths to make things more
consistent.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2021-05-28 17:24:48 +08:00
He Weiwei
c7a4af3170
test: mock the API requests for the huawei registry (#15009) 
Signed-off-by: He Weiwei <hweiwei@vmware.com>
 2021-05-28 17:09:48 +08:00
Daniel Jiang
d3b8c613fd Make v2auth more strict 
This commit enhances the v2auth middleware, such that any un-recognized
request sent to /v2/ will be blocked.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2021-05-28 16:41:48 +08:00
chlins
5833f5498c fix: format p2p preheat execution start_time and end_time to standard time format 
Signed-off-by: chlins <chlins.zhang@gmail.com>
 2021-05-28 13:05:01 +08:00
Wenkai Yin
741793a553 Declare the capability of supported repository path component for registries 
Declare the capability of supported repository path component for registries

fixes #14981
fixes #14980

Signed-off-by: Wenkai Yin <yinw@vmware.com>
 2021-05-28 10:42:16 +08:00
Ziming Zhang
77b44a62e7 fix aws adapter url 
Signed-off-by: Ziming Zhang <zziming@vmware.com>
 2021-05-27 23:29:12 +08:00
yunkunrao
82fd606f8f Update Unit Test. 
Signed-off-by: yunkunrao <yunkunrao@gmail.com>
 2021-05-27 18:50:47 +08:00
Eike David Lenz
a3e27ebb87
fix nil map assignment in gc handler (#14918) 
Signed-off-by: Eike David Lenz <e.lenz@mittwald.de>
 2021-05-26 10:46:11 +08:00
Daniel Jiang
12420ae31d
Merge pull request #14957 from stonezdj/21may24_update_configure 
Change configurations in swagger.yaml make it more readable
 2021-05-25 23:58:40 +08:00
Wang Yan
42a9d0d905
remove common project code (#14939) 
move project model from common to pkg

Signed-off-by: Wang Yan <wangyan@vmware.com>
 2021-05-25 11:01:19 +08:00
Will Sun
d88dcffa03
Remove redundant sorting code for list projects (#14956) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-05-25 10:24:44 +08:00
stonezdj
fe830ac4d2 Change configurations in swagger.yaml make it more readable 
Update the genyaml to generate the configurations type
Add toCfgMap in config handler

Signed-off-by: stonezdj <stonezdj@gmail.com>
 2021-05-24 19:13:55 +08:00
Wenkai Yin(尹文开)
544fa806fa
Set null list when or list is nil in query (#14941) 
Set null list when or list is nil in query

Signed-off-by: Wenkai Yin <yinw@vmware.com>
 2021-05-24 16:22:39 +08:00
stonezdj
d7d26c0966 Fall back to local registry when upstream registry is not working 
Fixes #14822
When upstream registry not working, but status might stay healthy because the health check interval is 5 minutes, if a pull request comes before registry status turns to unhealthy, the proxy cache middleware might proxy the request to the upstream registry and get a 401 error and this 401 error might translate to a http 500 error to the client eventually.

To solve this issue, it fall back all error to local registry when proxying manifest except the NotFoundError from the local registry.

Signed-off-by: stonezdj <stonezdj@gmail.com>
 2021-05-24 14:29:05 +08:00
fanjiankong
306e519dbe Fix tencentcr adapter. 
1. Limit API qps for the adapter.
2. Allow set qps via env.
3. Fix Tencnet SDK pagenation.
4. Fix resource filter.

Signed-off-by: fanjiankong <fanjiankong@tencent.com>
 2021-05-24 10:33:49 +08:00
He Weiwei
a1ac9b98df
fix: delete robots by project id using raw sql (#14951) 
QuerySeter.Delete will call two queies in the orm of beego. First it
will query all primary keys of the model by the QuerySeter, and then the
orm will delete the models using the IN statement of these primary keys.
This will be failed in the postgres when the records more than 65535.
This commit changes to use the raw query to delete the robots of the
project.

Closes #14678

Signed-off-by: He Weiwei <hweiwei@vmware.com>
 2021-05-24 10:31:48 +08:00
yunkunrao
fa8a0d09d6 Fix dragonfly preheat error. 
Signed-off-by: yunkunrao <yunkunrao@gmail.com>
 2021-05-23 17:50:54 +08:00
Will Sun
bea27a7da1
Improve scan all page (#14940) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-05-21 17:55:57 +08:00
Daniel Jiang
dee6064e60
Merge pull request #14926 from reasonerjt/rm-common-dao-oidc-user-onboard 
Remove the onboard and update funcs for OIDC user from common/dao
 2021-05-20 19:34:59 +08:00
Daniel Jiang
66766a8f69 Remove the onboard and update funcs for OIDC user from common/dao 
Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2021-05-20 16:23:07 +08:00
ChenYu Zhang
a50f782beb
fix: change sql to improve the performance of catalog api (#14820) 
Signed-off-by: chlins <chlins.zhang@gmail.com>
 2021-05-20 15:52:53 +08:00
Daniel Jiang
8600b06975
Merge pull request #14925 from ywk253100/210520_perf 
Improve the performance of artifact related APIs
 2021-05-20 14:10:45 +08:00
Daniel Jiang
5be0c6d35a
Merge pull request #14911 from reasonerjt/fix-14386 
Use system configuration resource for permission checking
 2021-05-20 14:05:06 +08:00
Wenkai Yin(尹文开)
9afeb90646
Merge pull request #14923 from reasonerjt/fix-14862 
Fail with 401 for GET .../users/current/permissions
 2021-05-20 14:02:32 +08:00
Wenkai Yin(尹文开)
0fe551274d
Merge pull request #14921 from ywk253100/210519_db 
Clean up tech debt codes
 2021-05-20 13:44:10 +08:00
Wenkai Yin(尹文开)
36d76d8704
Merge pull request #14912 from ywk253100/210518_bug 
Truncate the string when deletinng the resources when the length exceeds the limit
 2021-05-20 12:09:36 +08:00
Wenkai Yin
998e392bb4 Clean up tech debt codes 
Clean up tech debt codes

Signed-off-by: Wenkai Yin <yinw@vmware.com>
 2021-05-20 11:47:46 +08:00
Wenkai Yin
dc059a9a8f Improve the performance of artifact related APIs 
Improve the performance of artifact related APIs by adding indexes and refactoring sql logic

Closes #13890 #14813 #14814

Signed-off-by: Wenkai Yin <yinw@vmware.com>
 2021-05-20 11:25:43 +08:00
Wenkai Yin(尹文开)
08ed886936
Merge pull request #14914 from ywk253100/210518_registry 
Update the field name of registry model
 2021-05-19 17:20:12 +08:00
Daniel Jiang
93fe178dc3 Fail with 401 for GET .../users/current/permissions 
fixes #14862

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2021-05-19 16:28:39 +08:00
Will Sun
1896df2cfb
Improve css style (#14909) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-05-19 12:49:38 +08:00
Daniel Jiang
294ee52d7a
Merge pull request #14900 from reasonerjt/rm-common-dao-getuser-onboard 
Remove GetUser and Onboard from common/dao
 2021-05-19 11:21:00 +08:00
He Weiwei
c6bd7b2ec2
ci: lint the swagger file (#14916) 
Signed-off-by: He Weiwei <hweiwei@vmware.com>
 2021-05-19 10:36:09 +08:00
Daniel Jiang
4492e47e89
Merge pull request #14910 from reasonerjt/fix-oidc-callback-nil-pointer 
Check user in security context before getting the ID
 2021-05-18 23:35:46 +08:00
Wenkai Yin
315f490d3c Update the field name of registry model 
Update the field name of registry mode

Signed-off-by: Wenkai Yin <yinw@vmware.com>
 2021-05-18 17:26:20 +08:00
Wenkai Yin
5ebc8b4fdd Truncate the string when deletinng the resources when the length exceeds the limit 
Truncate the string when deletinng the resources when the length exceeds the limit

Signed-off-by: Wenkai Yin <yinw@vmware.com>
 2021-05-18 17:17:41 +08:00
Daniel Jiang
c41d75fb31 Use system configuration resource for permission checking 
This commit uses system configuration resource for permission check
against API to ping OIDC and update systen CVE allowlist.
Fixes #14386

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2021-05-18 16:06:58 +08:00
Daniel Jiang
952644e23f Remove GetUser and Onboard from common/dao 
Replaced by funcs in src/pkg/user and src/controller/user

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2021-05-18 15:28:41 +08:00
Daniel Jiang
ebe5733f27 Check user in security context before getting the ID 
This commit fix a potential nil pointer issue when trying to read User
ID from security context

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2021-05-18 14:54:58 +08:00
He Weiwei
0c315d8aee
refactor: remove allowlist in GetSummary of scan controller (#14836) 
Signed-off-by: He Weiwei <hweiwei@vmware.com>
 2021-05-18 14:01:59 +08:00
Vadim Bauer
1a3335edc5
Provide information about missing RBAC permissions in debug mode. (#14906) 
Signed-off-by: Vadim Bauer <vb@container-registry.com>

Co-authored-by: Vadim Bauer <vb@container-registry.com>
 2021-05-18 10:02:34 +08:00
Wenkai Yin(尹文开)
aaff28f6ff
Merge pull request #14843 from ninjadq/fix_webhook_parse_chartname 
Fix webhook parse chartname panic
 2021-05-18 09:30:22 +08:00
Will Sun
0a8ff4c1f9
Update project summary page (#14874) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-05-17 10:39:33 +08:00
Wenkai Yin(尹文开)
e553cbe795
Merge pull request #14887 from wy65701436/golang-15 
bump up go to v1.15.12
 2021-05-17 10:32:19 +08:00
Will Sun
ba68f16b8d
Support searching quota by project name (#14881) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-05-17 09:46:24 +08:00
He Weiwei
7fb1bc538c
refactor: remove unused core/api/models pkg (#14882) 
Signed-off-by: He Weiwei <hweiwei@vmware.com>
 2021-05-14 17:15:44 +08:00
Wang Yan
0fb520a33b bump up go to v1.15.12 
Signed-off-by: Wang Yan <wangyan@vmware.com>
 2021-05-14 15:36:23 +08:00
He Weiwei
6f3607cebd
perf: cache the metadata of the scanner (#14879) 
1. Cache the metadata of scanner 30s.
2. Change the scanner client request timeout to 5s.

Signed-off-by: He Weiwei <hweiwei@vmware.com>
 2021-05-14 14:27:37 +08:00
Ziming
1665dbcbc8
fix(retention) add delete retention API (#14747) 
Signed-off-by: Ziming Zhang <zziming@vmware.com>
 2021-05-14 14:15:42 +08:00
Daniel Jiang
35c9a98272
Merge pull request #14875 from heww/fix-scan-all 
fix: using new ctx to scan artifact when scanAll
 2021-05-14 12:56:10 +08:00
He Weiwei
eed91dab45
fix: requires authn for apis of project scanner (#14880) 
Closes #14863

Signed-off-by: He Weiwei <hweiwei@vmware.com>
 2021-05-14 11:27:23 +08:00
He Weiwei
f800d531ec fix: using new ctx to scan artifact when scanAll 
DB transaction failure may break the loop query of the artifacts, the
result is that not all artifacts are scanned in one scan all job. Using
a new DB connection to call the Scan method of the controller to avoid
this problem.

Signed-off-by: He Weiwei <hweiwei@vmware.com>
 2021-05-13 12:33:10 +00:00
Daniel Jiang
fa46b0d736
Merge pull request #14095 from jsoref/tokens 
Tokens
 2021-05-13 13:25:58 +08:00
Wang Yan
ad9569da26
refactor preheat model (#14858) 
Move the notification to preheat models

Signed-off-by: Wang Yan <wangyan@vmware.com>
 2021-05-12 22:29:01 +08:00
DQ
2583107446 Fix panic issue when there are '--' in chart name 
let webhook get name function consistent with chartmuseum

Signed-off-by: DQ <dengq@vmware.com>
 2021-05-12 14:11:57 +00:00
Qian Deng
17dd48e5a3
Merge pull request #14854 from ninjadq/upgrade_helm_chart 
Upgrade helm chart
 2021-05-12 19:33:03 +08:00
stonezdj(Daojun Zhang)
0dfc801a50
Error string should not be capitalized (#14840) 
Signed-off-by: stonezdj <stonezdj@gmail.com>
 2021-05-12 16:53:37 +08:00
Wenkai Yin
c04f3a2aac Fix duplicate execution record issue 
When the core service cannot response the checkin request in time, duplicated execution records may be created, this commit introduces the revision column to make sure there is only one record for one schedule trigger

Signed-off-by: Wenkai Yin <yinw@vmware.com>
 2021-05-12 15:40:52 +08:00
Moshe Immerman
d1b553fd3a
feat: add ORM_DEBUG env option (#14709) 
Signed-off-by: Moshe Immerman <moshe@flanksource.com>
 2021-05-12 10:56:30 +08:00
Daniel Jiang
bd9a1c6722
Merge pull request #14829 from reasonerjt/user-common-dao-cleanup 
Move user related funcs from common/dao
 2021-05-12 10:56:18 +08:00
Will Sun
eec3619df1
UI enhancement for replication namespace (#14818) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-05-12 10:11:04 +08:00
stonezdj(Daojun Zhang)
a6d92ca807
Merge pull request #14777 from stonezdj/21apr15_declarative_config 
Implement declarative configure feature
 2021-05-12 09:21:57 +08:00
Daniel Jiang
6d0e391740 Move user related funcs from common/dao 
This commit moves more user related funcs, such as ChangePassword,
Login, ChangeUserProfile from common/dao to rely on /pkg/user and
pkg/oidc.
It also removes the code for resetting user's password as it's disabled.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2021-05-12 01:12:57 +08:00
Wang Yan
b714baae87
fixes immutable rule issue (#14849) 
fixes #14568

Signed-off-by: Wang Yan <wangyan@vmware.com>
 2021-05-11 23:28:03 +08:00
DQ
9a974d2b2c Upgrade Helm Client Version 
From version 3.1.1 to 3.4.2

Signed-off-by: DQ <dengq@vmware.com>
 2021-05-11 13:51:55 +00:00
stonezdj
3825220ca6 Implement declarative configure feature 
Add env CONFIG_OVERWRITE_JSON for declarative config
Init config with the json in CONFIG_OVERWRITE_JSON in main.go

Signed-off-by: stonezdj <stonezdj@gmail.com>
 2021-05-11 20:58:19 +08:00
He Weiwei
0d7250f83d
perf: skip db tx for get, head and options api requests (#14837) 
Signed-off-by: He Weiwei <hweiwei@vmware.com>
 2021-05-11 10:54:15 +08:00
Wenkai Yin(尹文开)
e006f4bab5
Support specifying multiple fields for default sorting (#14788) 
Support specifying multiple fields for default sorting
Fixes #14433

Signed-off-by: Wenkai Yin <yinw@vmware.com>
 2021-05-10 17:04:10 +08:00
Will Sun
3322716bc6
Update storage display (#14807) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-05-07 11:15:13 +08:00
Daniel Jiang
8fa45a5338 Bump up go-oidc to v3 
Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2021-05-06 16:07:16 +08:00
Daniel Jiang
a66809cf85
Remove register and userexists funcs from dao pkg (#14798) 
This commit replaces them with funcs with user pkg

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2021-05-05 17:55:56 +08:00
Wenkai Yin(尹文开)
f8171cdf6e
Merge pull request #14783 from reasonerjt/clean-common-dao-user 
Clean up user related funcs in common/dao
 2021-04-30 14:10:38 +08:00
stonezdj(Daojun Zhang)
8f16831c75
Merge pull request #14717 from stonezdj/21pr16_verify_ldap_group_settings 
Add the ldap group config validation
 2021-04-30 10:19:43 +08:00
stonezdj
9010eeb832 Add the ldap group config validation 
When ldap_group_search_filter is set, check other required fields
When ldap_group_search_filter is empty, skip to attach group

Signed-off-by: stonezdj <stonezdj@gmail.com>
 2021-04-29 22:11:38 +08:00
Daniel Jiang
01858e3d71 Clean up user related funcs in common/dao 
This commit remove some funcs from package `common/dao/user` that can be
covered by the manager in `pkg/user`.

Ideally all funcs should be replaced but the dependency relationships
are tricky for some of them I'll push other commit to clean them up.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2021-04-29 18:08:16 +08:00
Will Sun
7642519bf4
Use standard query to search projects by name (#14778) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-04-29 16:29:24 +08:00
Daniel Jiang
c2ab1769b3
Merge pull request #14768 from reasonerjt/fix-14711 
Return 401 for GET request to /v2 API for public artifacts.
 2021-04-29 15:23:45 +08:00
Wang Yan
1dd3b9fd82
add storage consumption support (#14772) 
Return the total storage consumption in the statistic API

Signed-off-by: Wang Yan <wangyan@vmware.com>
 2021-04-29 12:36:25 +08:00
Wang Yan
f3260fdad1
move blob models (#14776) 
1, move project_blob into pkg
2, move artifact_blob into pkg

Signed-off-by: Wang Yan <wangyan@vmware.com>
 2021-04-29 12:36:08 +08:00
Wenkai Yin(尹文开)
9bbffa06db
Merge pull request #14662 from ywk253100/210413_dest_ns 
Refactor the replication policy destination namespace logic
 2021-04-29 11:18:43 +08:00
Wenkai Yin(尹文开)
30664995c7
Merge pull request #14762 from ywk253100/210427_task_not_found_master 
Read upstream job ID as ID when it isn't null
 2021-04-29 10:58:48 +08:00
Wang Yan
a08709b50d
deprecate read only GC job (#14773) 
After refactor GC, the way to trigger read only GC job has been deprecated, remove the code.

Signed-off-by: Wang Yan <wangyan@vmware.com>
 2021-04-29 10:34:13 +08:00
Wenkai Yin(尹文开)
81156b2182
Merge pull request #14756 from ywk253100/210427_replicate_chart_master 
Fix the failure of event based chart replication
 2021-04-29 09:51:14 +08:00
Will Sun
d50da06023
Remove loading state for new webhook button (#14770) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-04-28 18:22:09 +08:00
Will Sun
afa3f6d3e4
Refactor webhook policy page (#14758) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-04-28 10:22:16 +08:00
Wenkai Yin
710c80078b Refactor the replication policy destination namespace logic 
Support specifying what part of the repository will be replaced by the provided namespace

Signed-off-by: Wenkai Yin <yinw@vmware.com>
 2021-04-28 10:16:20 +08:00
Daniel Jiang
6a379d398c Return 401 for GET request to /v2 API for public artifacts. 
This commits make sure when the request does not carry authorization
headers, the HEAD and GET will get the same response code.  This change
should be made due to #14711

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2021-04-28 09:14:43 +08:00
Wenkai Yin(尹文开)
c54e690f69
Merge pull request #14702 from ywk253100/210419_metadata 
Refactor project metadata API
 2021-04-27 18:02:09 +08:00
Wenkai Yin
0539f051a2 Read upstream job ID as ID when it isn't null 
Read upstream job ID as ID when it isn't null to fix the job not found error

Signed-off-by: Wenkai Yin <yinw@vmware.com>
 2021-04-27 14:47:26 +08:00
stonezdj(Daojun Zhang)
46dcf7b0cb
Add missing operationId in swagger.yaml (#14722) 
Add operationId for systeminfo api
Add operationId for configure api
Update api test after adding operationId

Fixes #14617

Signed-off-by: stonezdj <stonezdj@gmail.com>
 2021-04-27 12:35:00 +08:00
Wenkai Yin
e04c866ccc Fix the failure of event based chart replication 
Fix the failure of event based chart replication

Signed-off-by: Wenkai Yin <yinw@vmware.com>
 2021-04-27 09:36:09 +08:00
Will Sun
af12f9aa01
Refactor tag-retention page (#14749) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-04-26 14:27:44 +08:00
stonezdj(Daojun Zhang)
c946457eef
Return 409 instead of 500 for duplicate project member (#14727) 
Fixes #14621

Signed-off-by: stonezdj <stonezdj@gmail.com>
 2021-04-26 12:59:37 +08:00
Daniel Jiang
5b526b8dc7
Remove dependencies from pkg/oidc to common/dao (#14739) 
Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2021-04-26 10:56:49 +08:00
Will Sun
a344b1e17c
Remove css justify-content for helm-chart list (#14692) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-04-26 10:32:46 +08:00
Will Sun
0c724d3a44
Add pagination support to label list (#14714) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-04-26 10:32:38 +08:00
Will Sun
705cb5b55d
Refactor gc and gi history page (#14728) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-04-26 10:25:36 +08:00
Will Sun
2ffa6580fa
Add pagination support to p2p policy list (#14742) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-04-26 10:25:10 +08:00
Daniel Jiang
72810d33d0
Refine the "not support" error when searching user (#14696) 
If authenticator does not support searching user/group, wraps it as a
not found error, such that the API will return 404 rather than confusing
500.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2021-04-21 14:11:02 +08:00
He Weiwei
c58ccdfb8c
feat: bump up go-swagger to v0.25.0 (#14703) 
Signed-off-by: He Weiwei <hweiwei@vmware.com>
 2021-04-21 11:07:10 +08:00
Wenkai Yin
311d6336a7 Refactor project metadata API 
Refactor project metadata API

Signed-off-by: Wenkai Yin <yinw@vmware.com>
 2021-04-20 22:27:17 +08:00
stonezdj(Daojun Zhang)
0b9cad33b1
Refine the code of config (#14675) 
Remove deps to common/dao
 Move Manager interface to config.go
 Remove duplicate code and change format of dao.go

Signed-off-by: stonezdj <stonezdj@gmail.com>
 2021-04-19 21:08:25 +08:00
Steven Zou
cae82dc3d0
Merge pull request #14676 from bitsf/update_adapter_region 
update aliyun and aws region
 2021-04-19 11:17:07 +08:00
Steven Zou
0a67e16922
Merge pull request #14677 from bitsf/fix_aws_checkRepository 
fix(replication) aws adapter checkRepository
 2021-04-19 11:16:05 +08:00
Will Sun
5e5544cd47
Add pagination support to scanner list (#14673) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-04-19 10:51:19 +08:00
Ziming Zhang
e8450d99ce update aliyun and aws region 
Signed-off-by: Ziming Zhang <zziming@vmware.com>
 2021-04-16 22:34:11 +08:00
Ziming Zhang
74bd82b3a1 fix(replication) aws adapter checkRepository 
Signed-off-by: Ziming Zhang <zziming@vmware.com>
 2021-04-16 22:28:14 +08:00
Wenkai Yin(尹文开)
5f0e7cfd62
Merge pull request #14372 from chlins/fix/registry-auth-parse-time 
fix: add precheck when registry check token expired
 2021-04-16 18:17:02 +08:00
Wenkai Yin
d85b3514e0 Refactor the statistics API 
Refactor the statistics API

Signed-off-by: Wenkai Yin <yinw@vmware.com>
 2021-04-16 10:23:13 +08:00
Wang Yan
6e3c9e29df
Api refactor label (#14650) 
* Refactor labl api

move to the new program model

Signed-off-by: wang yan <wangyan@vmware.com>

* continue resolve review comments

Signed-off-by: Wang Yan <wangyan@vmware.com>
 2021-04-15 17:27:58 +08:00
Will Sun
45663e002d
Improve event panel (#14664) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-04-15 16:44:58 +08:00
Will Sun
ba4a6d94ef
Add pagination support to project member list page (#14666) 
Signed-off-by: AllForNothing <sshijun@vmware.com>
 2021-04-15 16:44:25 +08:00
Wenkai Yin
654f4d9202 Refactor health check API 
Refactor the health check API

Signed-off-by: Wenkai Yin <yinw@vmware.com>
 2021-04-15 14:50:27 +08:00
He Weiwei
dc37c83e11
refactor: use singular as the tag for user APIs (#14654) 
Use singular as the tag for user APIs to align with other APIs.

Signed-off-by: He Weiwei <hweiwei@vmware.com>
 2021-04-15 10:52:48 +08:00
Wenkai Yin(尹文开)
e6b2abfebb
Merge pull request #14653 from reasonerjt/no-oidc-admin 
Do not get OIDC info for admin user
 2021-04-15 09:50:43 +08:00
Daniel Jiang
6668883c36 Do not get OIDC info for admin user 
This commit skips getting OIDC meta info for admin user.
It fixes the issue that admin user cannot login to portal, which was
introduced in refactor.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2021-04-14 21:51:53 +08:00
Daniel Jiang
d1426fb0c5
Merge pull request #14635 from stonezdj/21apr13_move_config_exp 
Move common config api to lib/config
 2021-04-14 18:08:18 +08:00
stonezdj(Daojun Zhang)
dd7bd72122
Merge pull request #14645 from stonezdj/21apr14_fix_projmember_fresh_user 
Fix nightly issue: can not add user that never logged in projectmember api
 2021-04-14 16:42:10 +08:00
Archer1A
264e2e45f2
fix(jobservice): value out of range (#14634) 
value out of range when job count bigger than 256

Signed-off-by: vic <985695123@qq.com>
 2021-04-14 14:28:36 +08:00
stonezdj
1f5b3b11f4 Fix nightly issue: can not add user that never logged in 
Handle the NotFoundError in userManager.GetUserByName()

Signed-off-by: stonezdj <stonezdj@gmail.com>
 2021-04-14 13:32:47 +08:00