Commit Graph

11428 Commits

Author SHA1 Message Date
prahaladdarkin
d53af792ad
Fixes for various bugs/issues logged as a part of the test day. (#17232)
Closes:
* CVE Data Export API IDOR issue
* https://github.com/goharbor/harbor/issues/17199
* https://github.com/goharbor/harbor/issues/17193
* https://github.com/goharbor/harbor/issues/17188
* https://github.com/goharbor/harbor/issues/17184

Signed-off-by: prahaladdarkin <prahaladd@vmware.com>
2022-07-26 16:50:54 +08:00
Wang Yan
02eae9dede
Filter out accessory from list artifact results (#17231)
Fixed #17145
1, Filter out the accessory from the artifact list.
2, Disable the display func of the accessory interface, currently this will not impact any kind of accessory, like signature and nydus. If we'd like to introduce it, it needs to resolve the pagiation issue of artifact list.

Signed-off-by: Wang Yan <wangyan@vmware.com>
2022-07-26 00:38:05 +08:00
Abirdcfly
2fece8c9ea
delete duplicate import and use ST1019 in golangci-lint (#17211)
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
2022-07-25 14:12:00 +08:00
Shijun Sun
e9855a88dd
Fix cve export UI issues (#17227)
Signed-off-by: AllForNothing <sshijun@vmware.com>
2022-07-25 10:41:44 +08:00
Yang Jiao
a4c577f9ec
Refresh base images (#17176)
Signed-off-by: Yang Jiao <jiaoya@vmware.com>
2022-07-22 15:48:47 +08:00
stonezdj(Daojun Zhang)
712419778a
Return bad request if audit log retention hour > 240000 hour (#17217)
Cap the retention hour to 240000 hour
  Fixes #17198

Signed-off-by: stonezdj <stonezdj@gmail.com>
2022-07-22 15:14:10 +08:00
stonezdj(Daojun Zhang)
8e876d847c
Add resource type in forward audit log (#17216)
Add resource type when forward audit log

  fixes #17201

Signed-off-by: stonezdj <stonezdj@gmail.com>
2022-07-22 09:54:07 +08:00
Yang Jiao
e58f18bd51
Update routing test case (#17221)
Add retry to improve test case stability

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
2022-07-21 17:40:38 +08:00
Shijun Sun
56e669ebbc
Fix log rotation UI issues (#17220)
Signed-off-by: AllForNothing <sshijun@vmware.com>
2022-07-21 16:49:26 +08:00
Shengwen YU
acc2872fa8
fix: remove redundant check due to always false (#17206)
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
2022-07-20 16:53:56 +08:00
Loong Dai
09371b48e8
lint: sort imports (#17131)
* lint: add goimports

Signed-off-by: Loong Dai <loong.dai@intel.com>
2022-07-20 11:33:08 +08:00
prahaladdarkin
f3edb03b49
Fix to CVE Data Export functionality for images pushed by docker push (#17182)
Closes:
* https://github.com/goharbor/harbor/issues/17167

Signed-off-by: prahaladdarkin <prahaladd@vmware.com>
2022-07-18 09:22:15 +08:00
Yang Jiao
72cd65df6a
Update delete multi project testcase (#17169)
Because this PR(#16236) update the delete project button xpath, so update synchronously

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
2022-07-14 22:47:53 +08:00
stonezdj(Daojun Zhang)
9a41272986
Change the log to logger in purge job (#17162)
Fixes #17151

Signed-off-by: stonezdj <stonezdj@gmail.com>
2022-07-14 17:46:52 +08:00
prahaladdarkin
3f383e3ffd
Improvements to Vulnerability Data Export functionality. (#17161)
Closes:
* https://github.com/goharbor/harbor/issues/17152
* https://github.com/goharbor/harbor/issues/17153
Better error handling in case of task executions not found in the system

Signed-off-by: prahaladdarkin <prahaladd@vmware.com>
2022-07-14 15:08:25 +08:00
Yang Jiao
349d220372
Update delete project test case (#17158)
Because this PR(#16236) update the delete project button xpath, so update synchronously

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
2022-07-13 17:39:12 +08:00
Yang Jiao
8d397d5a07
Add retry to project quota GC test case (#17164)
Add retry to improve test case stability

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
2022-07-13 17:38:22 +08:00
Wang Yan
ef8b8f0be7
resolve the cve export volumn permission (#17157)
See the right uid and gid for the scandata_exports in the prepare

Signed-off-by: Wang Yan <wangyan@vmware.com>
2022-07-12 14:52:18 +08:00
Shijun Sun
aa3cdcbc6c
Add CVE data exporting UI (#16236)
Signed-off-by: AllForNothing <sshijun@vmware.com>
2022-07-11 17:43:25 +08:00
prahaladdarkin
130452111b
Vulnerability scan data export functionality (#15998)
Vulnerability Scan Data (CVE) Export Functionality
Proposal - goharbor/community#174
Closes - https://github.com/goharbor/harbor/issues/17150
Changes:
* CVE Data export to CSV with filtering support.
* Implement CSV data export job for creating CSVs
* APIs to trigger CSV export job executions

Signed-off-by: prahaladdarkin <prahaladd@vmware.com>
2022-07-11 16:35:04 +08:00
Yang Jiao
f852996fe5
Update tag immutability xpath (#17149)
Because this PR(#17138) update the tag immutability xpath, so update synchronously

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
2022-07-11 15:59:55 +08:00
Orlix
ba0637f562
Tune stale action (#17146)
Tube stale action

- 60 days grace period for stale
- exclude issues and PR with labels : never-stale, kind/requirement

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>

Co-authored-by: OrlinVasilev <ovasilev@vmware.com>
2022-07-08 23:11:42 +02:00
Roooocky
7e4b26b220
Add new feature for supporting WebAssembly artifact (#16931)
support wasm

Signed-off-by: ln23415 <ln23415@hotmail.com>
2022-07-08 23:08:28 +08:00
Shijun Sun
af802a4416
Hide pull command for Nydus (#17143)
Signed-off-by: AllForNothing <sshijun@vmware.com>
2022-07-08 17:03:02 +08:00
Shijun Sun
6c1fbde2a8
Developer role should be able to view tag-retention rules (#17138)
Developer role should be able to view tag-rerention rules

Signed-off-by: AllForNothing <sshijun@vmware.com>
2022-07-08 11:38:54 +08:00
MinerYang
efd9632e96
add nydus middleware (#17126)
Signed-off-by: yminer <yminer@vmware.com>

remove comments

Signed-off-by: yminer <yminer@vmware.com>

update ut manifest

Signed-off-by: yminer <yminer@vmware.com>

modify comment manifest

Signed-off-by: yminer <yminer@vmware.com>

updtae ut testcase

Signed-off-by: yminer <yminer@vmware.com>

fixwhitespace lint

Signed-off-by: yminer <yminer@vmware.com>

update isNydus judgement && define annotation var

Signed-off-by: yminer <yminer@vmware.com>

whitespace lint

Signed-off-by: yminer <yminer@vmware.com>
2022-07-08 09:56:10 +08:00
Wang Yan
bd8d66c68d
resolve robot authgen password format issue (#17134)
In some cases, the robot automatically generates passwords that do not meet confidentiality requirements.
The fix adds retry for auto generating passwords, and the timeout is 1 minute.

The requirement: the secret must longer than 8 chars with at least 1 uppercase letter, 1 lowercase letter and 1 number

Signed-off-by: Wang Yan <wangyan@vmware.com>
2022-07-08 02:05:32 +08:00
DarthBlair
360689b1b9
Added Tag Retention Permission to Developer (#16514)
* added rbac.ResourceTagRetention to developer

Added Permissions to Developer to according to the "User Pemission by Role" Table

Signed-off-by: DarthBlair <Marcel.Bassuener@googlemail.com>

Co-authored-by: Shengwen Yu <yshengwen@vmware.com>
2022-07-07 12:28:19 +08:00
MinerYang
8485da240d
bump up github.com/containerd/containerd to v1.5.13 (#17129)
Signed-off-by: yminer <yminer@vmware.com>
2022-07-07 08:53:43 +08:00
Chenyu Zhang
41d10d571c
fix: repair execution status when it inconsistent (#17128)
Add migrations sql to repair the execution status when it does not
consistent with task status.

Closes: #17114

Signed-off-by: chlins <chenyuzh@vmware.com>
2022-07-06 17:02:03 +08:00
Chenyu Zhang
1a1ce634cc
Fix the process of cache layer (#17010)
fix: fix cache layer issues (#16995,#16997,#16996,#17038)

1. Load config and initialize cache layer in jobservice(for GC)
2. Cache artifact by digest the key should contains repository name
3. Repository cache cleanup error when update
4. Skip save cache when request ctx in transaction

Signed-off-by: chlins <chenyuzh@vmware.com>
2022-07-06 16:11:53 +08:00
MinerYang
8ba6a2bede
Add migration script for Harbor 2.6 (#17116)
add migration script for Harbor 2.6

Signed-off-by: yminer <yminer@vmware.com>
2022-07-06 14:08:24 +08:00
stonezdj(Daojun Zhang)
dcccb44db8
Add options to the user.Count method (#16285)
Fixes #16269, exclude the admin account by default
  Add excludeDefaultAdmin method -- exclude default admin by option
  Update authModeCanBeModified method -- the user count should be 0 without admin

Signed-off-by: stonezdj <stonezdj@gmail.com>
2022-07-06 13:57:31 +08:00
Wang Yan
6917021b41
resolve copy failure for artifact with multiple accessories (#17123)
If the artifact has more than one signaure, it will currently copy the last one. After the fix, all accessories can be copied to the target project.

Signed-off-by: wang yan <wangyan@vmware.com>
2022-07-05 20:10:22 +08:00
Chenyu Zhang
927f9f5af3
fix: attach labels for replication event (#17108)
Attach labels for replication event, list labels by artifact ID so for
event-based replication rule filter by label can work as expect.

Closes: #17014

Signed-off-by: chlins <chenyuzh@vmware.com>
2022-07-05 19:57:13 +08:00
heylongdacoder
5b52ec1a3f
Remove os.Kill in signal handling (#16111)
os.Kill cannot be trapped. May refer to SA1016
2022-07-05 12:03:51 +02:00
Dannyx323
dc1a03fde2
Added group_type information for type 3 OIDC group (#17118)
Added group_type information for type 3 OIDC group

Signed-off-by: Dannyx323 <46710098+Dannyx323@users.noreply.github.com>

Update swagger.yaml

Added group_type information for type 3 OIDC group

Signed-off-by: Dannyx323 <46710098+Dannyx323@users.noreply.github.com>
2022-07-05 14:55:23 +08:00
Orlix
d88630848a
Making stale bot a bit more active (#17115)
- reducing the stale ime to 30 days
- adding operations-per-run to 1000 so we can clean a bit more

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>

Co-authored-by: OrlinVasilev <ovasilev@vmware.com>
2022-07-05 09:31:57 +08:00
stonezdj(Daojun Zhang)
c9d6ba1469
Revert "Skip to refresh execution status when unchanged (#17023)" (#17111)
This reverts commit 88b8a7ac2c.

Signed-off-by: stonezdj <stonezdj@gmail.com>
2022-07-04 18:10:59 +08:00
stonezdj(Daojun Zhang)
8115484f32
Create index for performance (#17022)
Add index to avoid full table scan
Signed-off-by: stonezdj <stonezdj@gmail.com>
2022-07-04 14:38:05 +08:00
Shengwen YU
315d8a8993
fix: update code in compliance with golangci-lint revive (#17087)
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
2022-07-01 14:52:47 +08:00
Wang Yan
94bf1c0ebd
Resovle the system artifact schedule issue (#17098)
Scheduling of system artifact depends on the jobservice, where gorountine is used to avoid the circular dependencies between core and jobservice.

Signed-off-by: Wang Yan <wangyan@vmware.com>
2022-07-01 14:25:45 +08:00
Yang Jiao
1ac2c10f63
Modify Build Package Workflow trigger condition (#17106)
No need to build package when push tag

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
2022-07-01 01:59:56 +08:00
Wang Yan
b4ef1dbfd5
Unify retention schedule/task retrieve and update (#17083)
Add not-found handling for non exist items in retention operation.

Signed-off-by: Wang Yan <wangyan@vmware.com>
2022-07-01 01:58:14 +08:00
Yang Jiao
90e9b997bf
Enhancement Stop Scan Testcase (#17105)
Added error retries to improve test stability

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
2022-06-30 17:40:30 +08:00
Roger Klorese
79d149b603
Update ROADMAP.md (#16984)
* Update ROADMAP.md
2022-06-29 11:34:10 +08:00
Wenkai Yin(尹文开)
ab74e853ee
Enhance the read-only API to avoid deleting operations during the job running (#17055)
Enhance the read-only API to avoid deleting operations during the job running

Fixes #16901

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
2022-06-29 08:00:17 +08:00
Yang Jiao
77d28105bc
Upgrade pipenv to 2022.1.8 (#17093)
Signed-off-by: Yang Jiao <jiaoya@vmware.com>
2022-06-28 23:40:48 +08:00
Chenyu Zhang
1c3eb6974c
fix: update preheat api handler and DAO (#17079)
1. fix preheat dao Get method
2. update preheat tasks and getLog api

Signed-off-by: chlins <chenyuzh@vmware.com>
2022-06-28 19:01:08 +08:00
Yang Jiao
ff4eb7f27c
Add P2P Preheat Test case (#17089)
1.Add P2P Preheat test case triggered by manual
2.Add P2P Preheat test case triggered by events(Artifact is pushed Artifact is scanned Artifact is labeled)
3.Add P2P Preheat test case triggered by schedule
4.Migrated Distribution CRUD and P2P Preheat Policy CRUD to P2P_Preheat.robot for classification

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
2022-06-28 18:14:46 +08:00